<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<h3>
Mathieu Parent pushed to branch pam_winbind-try_authok
at <a href="https://salsa.debian.org/samba-team/samba">Debian Samba Team / samba</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0d62579a41fc4a04c299ec8a3537bf5db149149b">0d62579a</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-01-15T01:51:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.9.0pre1...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Mon Jan 15 02:51:51 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/264249db0f5515d8333d16218f1553ae9f0e7193">264249db</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-01-15T16:48:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbindd: Improve logic so it is easier to understand
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13209
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/00d176c6c592af59cc14271de4af1614578090a3">00d176c6</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-01-15T16:48:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Use a goto for cleaning up at the end
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13209
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bfc727f0b2d837a97fc9eb94a8811f23a656c4e4">bfc727f0</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-01-15T16:48:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Use a stackframe and cleanup when leaving
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13209
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/05ebafd91ee2dd511372ce63d656e9fc6735ee28">05ebafd9</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-01-15T21:16:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_client: Clenup copy_netr_SamInfo3() code
This gets rid of some strange macro and makes sure we clenaup at the
end.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13209
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Jan 15 22:16:13 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6aa0cc2570f9c86e76086bebf16234988107384e">6aa0cc25</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-15T21:17:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpc_server: Improve a debug message
A client sending us a bind with an unknown interface should not spam
syslog by default. Also, show what interface the client tried to connect
to.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a63aafb05d4d975aa9898b8a2dcbbf5d4f41938d">a63aafb0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-16T01:43:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">srcctl3: Improve debug messages
A customer's syslog was filled with
_svcctl_OpenServiceW: Failed to get a valid security descriptor
messages. This improves the messages to give info about which service failed
with which error code. Also, it makes OpenServiceW fail with the same error
message Windows fails with for unknown services.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jan 16 02:43:03 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a3f97f2662c6197913aeb50e5e3c0c09ff8307f">7a3f97f2</a></strong>
<div>
<span>by Jamie McClymont</span>
<i>at 2018-01-16T06:12:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: fix envvars for creation of default user in wait_for_start
Resolves failure of ad_member to start up under ad_dc (if
the user is determined to be needed).
Signed-off-by: Jamie McClymont <jamiemcclymont@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13225
Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Tue Jan 16 07:12:01 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/112938879f9e04a9a4f3d2ed69efacf2bce83799">11293887</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-01-16T15:38:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: fix the build with python3.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13221
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8224a3d6a03aeb4648bb624f775b139115567a8f">8224a3d6</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-01-16T20:02:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">packaging: fix default systemd-dir path.
https://bugzilla.samba.org/show_bug.cgi?id=13227
By default we should not end up with a
/usr/usr/lib/systemd/system path.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Tue Jan 16 21:02:28 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e77f8e4628ba868f09cbcf2970caac6c69fe080c">e77f8e46</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-01-17T00:31:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Remove file system sharemode before calling unlink
GPFS implements the DENY_DELETE sharemode, which prevents unlink() from
deleting the file.. This causes the problem that deleting a file through
"delete on close" fails, as the code in close.c first calls unlink() and
only later removes the file system sharemode.
Fix this by removing the file system sharemode before calling unlink().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13217
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Wed Jan 17 01:31:53 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0edce86e97a49f4bd79f4431015ac2b788105e46">0edce86e</a></strong>
<div>
<span>by Sachin Prabhu</span>
<i>at 2018-01-17T05:09:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_glusterfs: Add fallocate support for vfs_glusterfs
Adds fallocate support to the vfs glusterfs plugin.
v2: Add check for glusterfs-api version.
RHBZ: 1478875
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jan 17 06:09:29 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e4f62d4e4b91395d46c99c2a5313b0536793cca7">e4f62d4e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-17T18:24:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pdb: Fix CID 1427624 Resource leak
It's not exactly a resource leak (we only really realloc if we shrink
dramatically), but assigning the result from tdb_realloc looks nicer.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/92131d08987ac7c2fb219bf2e8300f3bc7b702f9">92131d08</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-17T18:24:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Fix CID 1427626 Uninitialized scalar variable
Likely a false positive, but Coverity can't follow all the paths leading
to line 2030
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e5c9427085f001941adaf761b18740a2e169240">4e5c9427</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-17T18:24:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pdb: Fix CID 1427620 Resource leak
It's not exactly a resource leak (we only really realloc if we shrink
dramatically), but assigning the result from tdb_realloc looks nicer.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3be1e68ce69f7ab8ac2cac97920c0e7f65b5ed6f">3be1e68c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-17T22:58:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Fix CID 1427626 Uninitialized scalar variable
Likely a false positive, but Coverity can't follow all the paths leading
to line 1598.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Jan 17 23:58:34 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7c1c8c68174ed484fe86a0d9e429daad3a47a57d">7c1c8c68</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-01-19T00:36:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">mit-kdb: support MIT Kerberos 1.16 KDB API changes
MIT Kerberos 1.16 adds ability to audit local and remote addresses
during AS_REQ processing. As result, audit_as_req callback signature
was changed to include the addresses and KDB API version was increased.
Change mit-kdb code to properly expose audit_as_req signature KDC
expects in 1.16 version. Also update #ifdefs to account for the new
KDB API version.
This commit does not add actual audit of the local and remote IP
addresses, it only makes it possible to compile against MIT Kerberos
1.16.
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Jan 19 01:36:22 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3904c26ac860038518d4ffae781ddbbf23746715">3904c26a</a></strong>
<div>
<span>by Puran Chand</span>
<i>at 2018-01-21T06:08:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Added smbc_SetConfiguration which lets the user set the smb.conf for libsmbclient code
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13229
Signed-off-by: Puran Chand <pchand@vmware.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c6999a248ad78f75cbfcc0f461298021b20905b4">c6999a24</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-21T06:08:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fileid: Fix the 32-bit build
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ac9d528b823aa89b3f3144f9377cc540f4b692e4">ac9d528b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-21T10:48:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Remove prog_guide4.txt
Move the still relevant parts elsewhere
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Sun Jan 21 11:48:01 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/33c0f5599d93a34619c8f37945f79a6e399a1b5e">33c0f559</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-01-22T05:24:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid race condition in sock_daemon test 5
This test fails when it takes more than 10s to run. This can occur
when the system is loaded and socket-wrapper is used.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9daf40c55af61081abca663c7250f103d5b2a0df">9daf40c5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-01-22T10:11:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: Fix documentation typo
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Mon Jan 22 11:11:38 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c34c2dd55545b99fba46cf374a1653bad96cea9e">c34c2dd5</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-01-22T11:26:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs:blackbox: add regression test for unsorted links in tombstones-expunge.sh
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a25c99c9f1fd1814c56c21848c748cd0e038eed7">a25c99c9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-01-22T11:26:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">repl_meta_data: fix linked attribute corruption on databases with unsorted links on expunge
This is really critical bug, it removes valid linked attributes.
When a DC was provisioned/joined with a Samba version older than 4.7
is upgraded to 4.7 (or later), it can happen that the garbage collection
(dsdb_garbage_collect_tombstones()), triggered periodically by the 'kcc' task
of 'samba' or my 'samba-tool domain tombstones expunge' corrupt the linked attributes.
This is similar to Bug #13095 - Broken linked attribute handling,
but it's not triggered by an originating change.
The bug happens in replmd_modify_la_delete()
were get_parsed_dns_trusted() generates a sorted array of
struct parsed_dn based on the values in old_el->values.
If the database doesn't support the sortedLinks compatibleFeatures
in the @SAMBA_DSDB record, it's very likely that
the array of old_dns is sorted differently than the values
in old_el->values.
The problem is that struct parsed_dn has just a pointer
'struct ldb_val *v' that points to the corresponding
value in old_el->values.
Now if vanish_links is true the damage happens here:
if (vanish_links) {
unsigned j = 0;
for (i = 0; i < old_el->num_values; i++) {
if (old_dns[i].v != NULL) {
old_el->values[j] = *old_dns[i].v;
j++;
}
}
old_el->num_values = j;
}
old_el->values[0] = *old_dns[0].v;
can change the value old_dns[1].v is pointing at!
That means that some values can get lost while others
are stored twice, because the LDB_FLAG_INTERNAL_DISABLE_SINGLE_VALUE_CHECK
allows it to be stored.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/850a8027f32185e523614231cca76505134bb5e4">850a8027</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-01-22T11:26:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: disable fixing duplicate linked attributes until we can recover lost forward links
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ca5eaf0cdcf8257ac52786aa7439c8f081a2fe0d">ca5eaf0c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-01-22T11:26:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:waf: Move HAVE_NETGROUP to wscript
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13238
Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c29d087e1ea4c92717ef86e372fe80f410580fdc">c29d087e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-01-22T11:26:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">include: Create system/nis.h in libreplace
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13238
Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ee0be7eb723be1420fd601ea1abe0af748562953">ee0be7eb</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-01-22T11:26:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: deal with recent glibc sunrpc header removal
We need to rely on libtirpc or libntirpc to be around in that case.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13238
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10976
Guenther
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87f105d76ce074bff08fd507d72568be88d48d00">87f105d7</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-01-22T11:26:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Allow passing 'lib' to CHECK_STRUCTURE_MEMBER
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13238
We need to be able to point it to the right header location, so we need
to be able to pass the 'lib' that it gets set.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/39a6ea766dfe55d84ab2284b8d5ed01d66da11dd">39a6ea76</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-01-22T16:26:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: Fix NFS quota support with libtirpc
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13238
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Jan 22 17:26:52 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c404d58830758bde11499bc1771070e76c6eecfe">c404d588</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-23T00:49:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Give unexpected.c its own header
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e8e09d72ce780a9462d164d7e97a379bfc951980">e8e09d72</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-23T00:49:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnmb: Remove a pointless struct member
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e4dc85b69c2a57e99156d7cd60e84ff6c550fb52">e4dc85b6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-23T00:49:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnmb: tsocket_address_unix_from_path deals fine with NULL
Other callers use NULL instead of "". Streamline it a bit
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0050d1b9a73cdff455d8a93f6aed6dbb964be096">0050d1b9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-23T00:49:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnmb: Fix two signed/unsigned hickups
Two warnings less
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8993342965987c58bc16baf9680c6fb9f2d11286">89933429</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-23T00:49:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsgetdcname: Fix a signed/unsigned hickup
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ca3745db305a14713ab2a709968379fbf332d015">ca3745db</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-23T00:49:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/resolve: Fix typos
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/30ff05c660d07eee0ec4d190734438d068c6337c">30ff05c6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-23T00:49:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/resolve: Make functions static
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c57cce1b973ec3a6ffd1a230fccaaa02c28c9e04">c57cce1b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-23T05:36:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/resolve: Make functions static
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jan 23 06:36:36 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/45aec7d3a23645998eb97a86a50345c20a8e14dc">45aec7d3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-23T23:58:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnmb: Add "parse_packet_talloc"
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a60970306df44ff5676c98899069f867ac77d36">6a609703</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-23T23:58:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnmb: Make nb_packet_read_recv return a talloc'ed pkt
This saves a few explicit destructors only doing free_packet()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ea5d38a69660bf5e086ff03d18b4a4e9eb75cce">7ea5d38a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-24T04:48:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnmb: Move "read_packet" to nmbd
It's only used there
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jan 24 05:48:19 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da3aaf972ab5b339b51ba1e802329b69885ccfe4">da3aaf97</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-01-24T04:49:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add timeout for individual tests, default is 10 minutes
This will cause a hung test to time out and fail rather than letting a
test run hang indefinitely. Some tests can take 5 minutes to run, so
10 minutes should be plenty.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e17d02d4039001563d189b33200c30e3906ce845">e17d02d4</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-01-24T04:49:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Only use socket-wrapper for simple, local daemon tests
The run_tests.sh -S option now takes the path to the socker-wrapper
shared library.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/50150d75814de6a1e2cb28fb7af72caa31d73e3c">50150d75</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-01-24T04:49:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add a UNIT pseudo-test-suite
This runs all of the unit tests.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b82d10856160d3b3f172bf7d45ac561002dbcac">8b82d108</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-01-24T09:28:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Fix a typo
This typo causes the script to be run with the default shell. If this
is not bash then the shell will fail to parse integration.bash.
This is a regression caused by commit
c607989d91b64d837253aae794b1a3d6013eb3e0. Clearly nobody has run this
test on Debian for a long time. :-(
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed Jan 24 10:28:52 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70d7f7d03c46c8727833f322bdc03da1b2aad720">70d7f7d0</a></strong>
<div>
<span>by Trever L. Adams</span>
<i>at 2018-01-24T09:29:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Samba-VirusFilter: memcache changes.
Signed-off-by: Trever L. Adams <trever.adams@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b1e69edd0592d3b4b0f958792826a236dd3466e1">b1e69edd</a></strong>
<div>
<span>by Trever L. Adams</span>
<i>at 2018-01-24T09:29:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Samba-VirusFilter: common headers and sources.
Samba-VirusFilter Contributors:
SATOH Fumiyasu @ OSS Technology Corp., Japan
Module creator/maintainer
Luke Dixon luke.dixon@zynstra.com
Samba 4 support
Trever L. Adams
Documentation
Code contributions
Samba-master merge work
With many thanks to the Samba Team.
Signed-off-by: Trever L. Adams <trever.adams@gmail.com>
Signed-off-by: SATOH Fumiyasu <fumiyas@osstech.co.jp>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0b25089edd453270e52f2d8e6858a9996bb29a0d">0b25089e</a></strong>
<div>
<span>by Trever L. Adams</span>
<i>at 2018-01-24T09:29:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Samba-VirusFilter: Sophos VFS backend.
Signed-off-by: Trever L. Adams <trever.adams@gmail.com>
Signed-off-by: SATOH Fumiyasu <fumiyas@osstech.co.jp>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5970d68bf651fb8dbf1ac4e79d8f2e9467154870">5970d68b</a></strong>
<div>
<span>by Trever L. Adams</span>
<i>at 2018-01-24T09:29:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Samba-VirusFilter: F-Secure AntiVirus (fsav) VFS and man page.
Signed-off-by: Trever L. Adams <trever.adams@gmail.com>
Signed-off-by: SATOH Fumiyasu <fumiyas@osstech.co.jp>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cbf743d329730387ede92a9d329893d1c651e97a">cbf743d3</a></strong>
<div>
<span>by Trever L. Adams</span>
<i>at 2018-01-24T14:08:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Samba-VirusFilter: clamav VFS and man page.
Signed-off-by: Trever L. Adams <trever.adams@gmail.com>
Signed-off-by: SATOH Fumiyasu <fumiyas@osstech.co.jp>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Jan 24 15:08:59 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d4f7d9e08ca690b8278b35690dfb9e4673c19e00">d4f7d9e0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-25T00:53:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnmb: Fix CID 1428474 Incorrect expression (COPY_PASTE_ERROR)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Jan 25 01:53:53 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c890011a769b497855748e130fa41e998babc305">c890011a</a></strong>
<div>
<span>by Trever L. Adams</span>
<i>at 2018-01-25T11:24:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Samba-VirusFilter: fix virusfilter_vfs_close() crash
Signed-off-by: Trever L. Adams <trever.adams@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e320c4c9b7426be296b3c311861ba2ddeeacdf9f">e320c4c9</a></strong>
<div>
<span>by Trever L. Adams</span>
<i>at 2018-01-25T11:24:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Samba-VirusFilter: clean up dir check vfs_close and vfs_open
Signed-off-by: Trever L. Adams <trever.adams@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/89c3a1ebbe0f22c03d8958df07da9983fd6fd3b5">89c3a1eb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-25T11:24:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnet: Use talloc_zero instead of ZERO_STRUCTP
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/849169a7b6ed0beb78bbddf25537521c1ed2f8e1">849169a7</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-01-25T16:19:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix wrong condition for error string assignment
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Thu Jan 25 17:19:12 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e7425bd5245ffea68b7e8f794c9b5f864d103769">e7425bd5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-01-26T01:25:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: ldap: Ensure the ADS_STRUCT pointer doesn't get freed on error, we don't own it here.
Thanks to Isaac Boukris <iboukris@gmail.com> for finding the
issue and testing this fix.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13244
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jan 26 02:25:20 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0766f066af4358c37861fd3c57b58869644a53c0">0766f066</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-30T12:27:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: Remove finddcs_nbt.c
This completes commit 06c90cb6f55701effa4cbafaf189a4de8471949b
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Jan 30 13:27:51 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f9150c5fa0ac81a848dbb6978a73c10170648d5b">f9150c5f</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-01-30T12:28:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Return if packet size is zero
Prevent further processing of sock_queue_process
if the received packet size is zero.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eae2d35fec071b020f420ba74ac6551c84140a4d">eae2d35f</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-01-30T12:28:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Remove sock_queue_destructor
The sock_queue_destructor is not needed.
The performed tasks will be performed automatically.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/32d867cf09a15626b991be414ab6440f68953f35">32d867cf</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-01-30T17:12:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Optimize sock_queue's memory managament
Make use of talloc pools for the sock_queue's memory requirements.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Tue Jan 30 18:12:32 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9fc471242fac5fec170a3d9ba599d81ed7374954">9fc47124</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-01-30T23:38:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: librpc: Allow client to correctly report etype unsupported by KDC to caller.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13247
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Jan 31 00:38:09 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8a4409c956bdbe5d928e685b7c219566d467a627">8a4409c9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-30T23:40:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_virusfilter: Fix CID 1428739 Buffer not null terminated
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/734404bbe911fd4aa6565b2a2aaecab4fbbf3c45">734404bb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-30T23:40:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_virusfilter: Fix CID 1428740 Macro compares unsigned to 0
vsnprintf returns "int" and not "size_t"
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/21eb5169f46b8d819a5d5d028baff581e4e63de6">21eb5169</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-01-31T04:28:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_virusfilter: Fix CID 1428738 Macro compares unsigned to 0
vsnprintf returns "int" and not "size_t"
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jan 31 05:28:48 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/925dc87a2ae47ba67e33d46b059fd9a57772dabf">925dc87a</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-01-31T23:33:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc_zero libnet_context on init
Zero the libnet_context on initialization
preventing an uninitalized cli_credentials struct.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Feb 1 00:33:34 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/83d42203d7d7f7171d44724720fa5cd99590b90b">83d42203</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-02-01T02:20:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add section for "samba-tool visualize"
(text from the commit message by Douglas adding the feature)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13226
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c90cf067e6822d742276beee3b73151994f81d8b">c90cf067</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-02-01T02:20:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Correct documentation
The doc still contains a reference to env var
policy (which isn't present in this release).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13223
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e10de35fabd728e0a81ec1d331255d12bef19686">e10de35f</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-02-01T02:20:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Correct WHATSNEW
The WHATSNEW incorrectly explains how to enable gpo.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13223
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b3673824adc16a2b26c5fd3c661062d95c3c83eb">b3673824</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-02-01T06:57:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Mention new option "apply group policies"
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13223
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Feb 1 07:57:54 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c857e08a019174b16155fc9311ad788cdafd4cc">4c857e08</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-03T17:41:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: run deltest20 against s3 as well
This marks the test as knownfail, the next commit fixes it.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/84f07a8dcb8ee3a27be96f3baea5313bd0eaa084">84f07a8d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-03T22:42:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: fix handling of delete-on-close on directories
This implements a check to test the delete-on-close flag of a directory
for requests to create files in this directory.
Windows server implement this check, Samba doesn't as it has performance
implications.
This commit implements the check and a new option to control it. By
default the check is skipped, setting "check parent directory delete on
close = yes" enables it.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Sat Feb 3 23:42:16 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/28fcf631c8985e8418fdc67cc78053e503f56d50">28fcf631</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-05T12:49:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/netcmd: implement __repr__ for class CommandError
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/681e0a1745b45c6ac22d394b9e78cb67007d7dc4">681e0a17</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-05T12:49:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python:tests: use TestCaseInTempDir for "samba.tests.common"
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1341780dcf9ec0c5d852fbbb77c5e00db2ad6564">1341780d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-05T12:49:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python:tests: remove test_dsdb_Dn() to test_dsdb_Dn_binary()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c56eb49119117a1a06afb0a76630ae5c7a1ca30c">c56eb491</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-05T12:49:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python:tests: add test_dsdb_Dn_sorted() to "samba.tests.common"
Failing until dsdb_Dn implements the correct __cmp__() function.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/55d466549a3113f7625acdd6eb42f71cf63719b5">55d46654</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-05T12:49:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/common: add __cmp__ function to dsdb_Dn similar to parsed_dn_compare()
Linked attribute values are sorted by objectGUID of the link target.
For C code we have parsed_dn_compare() to implement the logic,
the same is now available on python dsdb_Dn objects.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8c01acd56274a5cb5926622cacab997cb62dd5a9">8c01acd5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-05T12:49:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "dbcheck: disable fixing duplicate linked attributes until we can recover lost forward links"
This reverts commit 43e3f79d54c5aeaea820865d298d4249cf47af99.
The real fix will follow in the next commits.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/52bd0b09804621e6de9ee0a377a442a42e07ee05">52bd0b09</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-05T12:49:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/dbcheck: add a test for corrupt forward links restoration
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a71394c6a30e8a1b5c6553f7410148dbf2e4a80">4a71394c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-05T12:49:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: rename and reorder err_orphaned_backlink arguments
In preperation of adding more arguments.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f77503871fcb815e474cb76d14e22f7a8f083c9">6f775038</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-05T12:49:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: add forward_syntax argument to err_orphaned_backlink
Will be used in a subsequent commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f47fe6c4a8bde4abfee3c774d9667e6a3439a45">9f47fe6c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-05T12:49:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: only pass obj_dn to err_orphaned_backlink()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a651cc79d64b9bcc1d5fee9b2ef8800a1579dea1">a651cc79</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-05T12:49:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: rename err_duplicate_links arguments
In preperation of adding more arguments.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dc43d31cd20fd12d2758b73ec0318215b8fbedfb">dc43d31c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-05T12:49:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: add link direction to error message for duplicate links
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ec433f8531a822dd40b343fbf3244157a5ecd544">ec433f85</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-05T12:49:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: rename err_duplicate_links() to err_recover_forward_links() and adjust the output message
It's really a fatal error to have duplicate values as it's very likely that
some forward links got lost.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b0bc3f60084e5998dd34aada2ac7377d390affc6">b0bc3f60</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-05T12:49:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: remove ldb.FLAG_MOD_REPLACE when replacing search results for forward links
Search results don't have an ldb.FLAG_MOD_* flags set.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7df17c0a8dffceb053ca806c9426d493b4837b1a">7df17c0a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-05T12:49:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: store fixed forward link attributes with the correct sorting
The corruption we're trying to fix messed up the sorting,
so there's no point in keeping the current order.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/44a8782d71676517f0991f279f2472391ecede3b">44a8782d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-05T12:49:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: split out check_duplicate_links from check_dn
Refactoring, no change in behaviour.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e4cc062fa98f65369f3bde24a987c2651632cb06">e4cc062f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-05T12:49:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: add a dict where we remember attributes with duplicate links
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e258b4fb281d8577c425e05b35ce05cf128617ea">e258b4fb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-05T12:49:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: add a helper function that checks is a value has duplicate links
Will be used in a subsequent commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/20598033866ca3d0fdad1edf3cb39e4614eae112">20598033</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-05T12:49:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: make sure we always ask for the objectGUID attribute explicitly
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/182fb3c4c9db8715d0dbcbc3d1aa0655b5cb29f1">182fb3c4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-05T12:49:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: make sure we ask for replPropertyMetaData if we need to process any forward link attributes
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d59f201388e8a16688adda145734dab8e27b785f">d59f2013</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-05T12:49:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: add find_missing_forward_links_from_backlinks()
find_missing_forward_links_from_backlinks() finds and returns missing forward-links by
searching all for all objects that link to the object in the backlink attribute.
This will be used in the next commit to restore forward links in a corrupted
forward link attribute by passing the missing backling objects to
err_recover_forward_links().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5bf823d68bd33ee3160175a18a3838eff4e3cbb2">5bf823d6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-05T12:49:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: add support for restoring missing forward links
This recovers broken databases with duplicate and missing
forward links.
See commit a25c99c9f1fd1814c56c21848c748cd0e038eed7 for
the fix that prevents to problem from happening.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c3348feb09f4f0ba85455b8c3ff5c5fa60d139b">0c3348fe</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-05T17:32:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: skip find_missing_forward_links_from_backlinks() if the db has the sortedLinks feature
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Feb 5 18:32:51 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/859698d29b547217356851094ed8188236e717b6">859698d2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-06T01:47:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libads: Fix the build --without-ads
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Tue Feb 6 02:47:44 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a222b7506b53e689708834237f18877231dca589">a222b750</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-06T14:36:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libgpo: Fix the build --without-ads
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Tue Feb 6 15:36:01 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0f577cd9e79e8a93b09d0c5f5b4f6842ed847932">0f577cd9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-07T12:04:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: run "samba.tests.common"
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0109b5965f8a5f467aa12aa505be849ae33e1f8e">0109b596</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-02-07T12:04:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml: Add 'samba-tool visualize' to man samba-tool.8.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13226
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/701b2ed6cfa27f9638dd5ea5a85e2ddbc44aa5e8">701b2ed6</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-02-07T16:57:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Start release notes for Samba 4.9.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Feb 7 17:57:39 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b96b51fa95ca3723dfb0a86d5186f5b8a3485a99">b96b51fa</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-02-07T22:45:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/crypto: Update REQUIREMENTS for recent Samba changes
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a157091a22446fd60830d5f352e44c6bad9264ba">a157091a</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-02-07T22:45:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samdb: Add tests for samdb tdb file creation.
The current defaults for SamDB are to create the database file if it
does not exist. Most of the uses of SamDB assume the database already
exists, and so auto-creation is not the desired behaviour.
Also TDB will overwrite an existing non TDB file with a newly created
TDB file. This becomes an issue when using alternate database file
formats i.e. lmdb.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/736e438bf44d84d30d8d5091a3f915ef307a6b45">736e438b</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-02-07T22:45:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pyldb: Expose extra flags
Expose the SHOW_BINARY, ENABLE_TRACING and DONT_CREATE_DB flag constants
in the python api.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7009479b7a91715543e228412435ab2fdb6221ae">7009479b</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-02-07T22:45:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python SamDB: init default flags to FLG_DONT_CREATE_DB
The current defaults for SamDB are to create the database file if it does not
exist. Most of the uses of SamDB assume the database already exists, and so
auto-creation is not the desired behaviour.
TDB will overwrite an existing non TDB file with a newly created TDB file.
This becomes an issue when using alternate database file formats i.e. lmdb.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a3485c41b826e307b31a1113abcea9843ca78540">a3485c41</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-02-08T03:42:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Set test timeout to an hour
The current 10 minute timeout is causing autobuild failures in some
environments.
This timeout is simply meant to stop a test run from hanging
indefinitely due to a broken test. A 1 hour timeout is better than no
timeout.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Feb 8 04:42:56 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cf338b8260f5b33df6718e4850eed326c636b7ab">cf338b82</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-02-08T03:58:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pyldb: extend dn.is_child_of() test: dn is child of itself
Add this test so ensure that this (unclear) behaviour does
not change silently.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0a88be836b3b57e0b268d26350be419ef1aa4fdd">0a88be83</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-02-08T03:58:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samdb: add method normalize_dn_in_domain(): get full dn of an relative dn
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3f022b2dd0e0c9a5f1dea35609730ac0ce1bec76">3f022b2d</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-02-08T03:58:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samdb: Allow samdb.normalize_dn_in_domain() to take an ldb.Dn()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f202b0ef24ded7e93b986033473bc5cf260be33d">f202b0ef</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-02-08T03:58:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samdb: Improve function comment on normalize_dn_in_domain()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f973667face7f6f30723d2b7a1cfb86930b05629">f973667f</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-02-08T03:58:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add tests for samdb.normalize_dn_in_domain()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2e0f33d8420a4c4beecb28a85576e54a4694046c">2e0f33d8</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-02-08T03:58:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: implement ou management commands
Available subcommands:
create - Create an organizational unit.
delete - Delete an organizational unit.
list - List all organizational units
listobjects - List all objects in an organizational unit.
move - Move an organizational unit.
rename - Rename an organizational unit.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e3882f80e0940f16e7808f08b28f3a4803a4ea7b">e3882f80</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-02-08T03:58:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/samba-tool: add tests for new ou management commands
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dbd29a0194cebc6bd0d6fe163c82feedbb1b55e5">dbd29a01</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-02-08T03:58:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml:samba-tool.8: document ou management commands
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dc0fa33c6817ccbf1a90eea5ea1925d2953dd84d">dc0fa33c</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-02-08T03:58:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: implement user show command to display a user AD object
This command displays a user account and it's attributes in the
Active Directory domain.
The username specified on the command is the sAMAccountName.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6fbfe84c011adc6a426dbd92e779a8759ba80989">6fbfe84c</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-02-08T03:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml:samba-tool.8: document "user show" command
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87ddbb67201bedaa8f042a2b5175d795eec2cb7e">87ddbb67</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-02-08T03:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/samba-tool: add test for samba-tool user show command
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c1101d0335aba4fcede42e84b5058adc854c54a">4c1101d0</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-02-08T03:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool user: fix some typos
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/62a8eecfbbb4b5fb9f37e454e444751ccf16f82f">62a8eecf</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-02-08T03:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool user: implement the user move command
This new command allows to move an user into an ou or container.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b6b2eb8f881e081e80a2a0c1294dc2ec2beda859">b6b2eb8f</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-02-08T03:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml:samba-tool.8: document "user move" command
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/37b5195d1c747b5388cb2576cd370b5e2eb7d34a">37b5195d</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-02-08T03:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/samba-tool: add tests for user move command
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a2a5e61dc4f397de14320b685acc46de5cc0701">6a2a5e61</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-02-08T03:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool group: implement the group move command
This new command allows to move a a group into an ou or container.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8466323c1f1ca69981f0ade14937cf7737ee5549">8466323c</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-02-08T03:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml:samba-tool.8: document "group move" command
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c4bb546b21b7ddce5b6f0d023b35c62c98a71d65">c4bb546b</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-02-08T03:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/samba-tool: add tests for samba-tool group move command
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/178f86848d15b0a1b59e8a4535649f264a0d12c4">178f8684</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-02-08T03:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: add dns cleanup cmd
1. Add new command to cleanup dns records for a dns host name
2. Add test to verify the command is working
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d82687e77fc8467fb7a2c845220dde1f90fd30bf">d82687e7</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-02-08T03:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">remove_dc: Allow remove_dns_references to ignore missing server names
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/97de384e9a9c44e51954c385a30b113921b4c285">97de384e</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-02-08T03:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/samba-tool: dns cleanup should work with a missing name
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/90e74fc15a8366c775d12a0817b63b6539f1cdd6">90e74fc1</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-02-08T03:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool/dns: Clarify the cleanup subcommand
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c7d0e6f39b15e54264dff2a897256f6bf9736333">c7d0e6f3</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-02-08T09:00:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool/tests: Check that dns cleanup does not spuriously remove entries
This might happen in the multi-record case.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Feb 8 10:00:13 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3bc87a20e9c6af358749c0b9d17e03a281086d3e">3bc87a20</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-08T09:01:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Make g_lock_lock_send use TDB_DATA
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bdeb7e7d8185a112064930edbf0cf1ee5b72999e">bdeb7e7d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-08T09:01:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Make g_lock_lock use TDB_DATA
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a104e08171b50b9e23dc1869049d12e0c6176979">a104e081</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-08T09:01:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Make g_lock_unlock use TDB_DATA
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ed3521d1729a7bda1f127f4c5a754bf01b174665">ed3521d1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-08T09:01:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Make g_lock_write_data use TDB_DATA
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a6c749e76cd4f3be0f3a0db81324491314b949c0">a6c749e7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-08T09:01:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Make g_lock_do use TDB_DATA
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/67fcc7dbb9ad63886c594b1f563b6c1d2060cbd1">67fcc7db</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-08T09:01:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Make g_lock_dump use TDB_DATA
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be3c8d08ec6331c2d4c1724cb3933c34fb7d7f0f">be3c8d08</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-08T13:50:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Make g_lock_locks use TDB_DATA
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Feb 8 14:50:49 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5a483bc0d1d1daf68999c397a0094631fadacc40">5a483bc0</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-02-09T06:59:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/crypto/REQUIREMENTS: DRSUAPI replication replicated secrets was missing from the RC4 section
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/57784b41c1245397b1d8eaabdff0553f205b5231">57784b41</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-09T06:59:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/samba-tool user_wdigest: avoid py3-incompatible md5 module
In Python3, the md5 and sha modules are gone, but the functions are
available via hashlib (which is also in python 2.5+).
The md5.hexdigest() does what binascii.hexlify(md5.digest()) does.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e912a7303bdc859175a6a65106b63d404f85684">0e912a73</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-09T06:59:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/password_hash: avoid py3-incompatible md5 module
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a43dbb93ffa47c2c39e7bb1d89f3f93941b9e566">a43dbb93</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-09T06:59:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/samba_tool user virtualCryptSHA: remove unused py3 incompatible import
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d8aa50b217b16b7e809fa5d59b6240a5671e86b8">d8aa50b2</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-09T06:59:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python samdb.newuser(): use user DN not samaccountname to set password
This is noticably faster in cases (e.g. tests) where the same user
is added and deleted many times.
The rreason is samaccountname is retained for deleted objects, so the
search finds multiple objects that need to be filtered out internally.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/055b7308d252d3b1501f61884defcd5bbe91049e">055b7308</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-09T06:59:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">subunit.run: report failure in process return code
The protocol requires that the TestResult object remembers when it has failed, but
in subclassing unittest.TestResult we forgot to ensure this is true.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f6f192934c8d170b1786eb2fd09560b7e02b50d4">f6f19293</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-09T06:59:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool rodc: consistently use self.outf, not stdout
This increases the output of some commands from the point of view of
tests which read the outf, so we also need to change those tests a
bit.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cefb41b0edb273a0095e5bda85c9ce5cc3208fa3">cefb41b0</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-09T11:34:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">sambatool drs showrepl: prefer self over ctx in python classes
and the line length too.
(Now only python/samba/join.py uses ctx for self, but at least it does
it consistently. This was the only ctx function in the class).
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Feb 9 12:34:06 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53484d0d98475f55ae3bd02e1a86b9c45b20e33d">53484d0d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: fix LSA connections via DCERPC_AUTH_SCHANNEL
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13231
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1918a870c38c29bd3a05cd3f660ffe6623121bf3">1918a870</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: remove useless calls to get_trust_credentials() before cli_rpc_pipe_open_schannel_with_creds()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13231
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9fef5d1891e6c1aebea29fbfbb90e77631b7836c">9fef5d18</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: add missing can_do_ncacn_ip_tcp initialisation
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13232
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a613f4bccf171c40ede3e6ead9236463fcc5883">9a613f4b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-10T07:35:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: add routing_domain as parameter to add_trusted_domain
This also fixes the following CIDs:
CID 1427622: Null pointer dereferences (REVERSE_INULL)
CID 1427619: Null pointer dereferences (REVERSE_INULL)
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13233
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fe47041b4bf8d2ef6f6f9ba15a80038f1c60da3f">fe47041b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_client: allow Netlogon{Network,Interactive}TransitiveInformation in rpccli_netlogon_password_logon()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13234
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7329706a037fef75e8ced63bfb7ab93b64482eda">7329706a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_client: allow passing NetlogonNetwork[Transitive]Information to rpccli_netlogon_network_logon()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13234
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70bb9c27cf8c464d5af79acbe11a0d2d0e20f5a8">70bb9c27</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: use Netlogon{Interactive,Network}TransitiveInformation on transitive trusts
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13234
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c5bd18c0021b428c669dbbc35f65a3d436b4add5">c5bd18c0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: remove const from set_routing_domain()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13235
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/af9a37aa1925a18709365ceb93460d8ae0f66f51">af9a37aa</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: prepare find_auth_domain() transitive trusts on a DC
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13235
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b7bf6d4d81cde099d78cd9cc03aa085cec672d4">8b7bf6d4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: prepare find_lookup_domain_from_{name,sid}() transitive trusts on a DC
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13235
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7fc19747ef346df9cc72bb516b45a8309f462dd8">7fc19747</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_client: pass down lsa_LookupNamesLevel to dcerpc_lsa_lookup_sids_generic()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13236
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/728fb7c593230abeb681854d924e4619d6f4cf37">728fb7c5</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: don't force using LSA_LOOKUP_NAMES_ALL for non workstation trusts.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13236
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4274ef681bf3b974ce99b8f21fda3a86a5b305bc">4274ef68</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-10T07:35:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: move loading of trusted domains on a DC to a seperate function
This allows using the split out function in a subsequent commit in the
MSG_WINBIND_NEW_TRUSTED_DOMAIN message handler.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13237
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d8e4e7cae57eb192c6fcab6b9aef95fb10eeb5a8">d8e4e7ca</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-10T07:35:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: use add_trusted_domains_dc in wb_imsg_new_trusted_domain
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13237
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ffa9eb7d6453eb6c6f3a50ad72288d3891361752">ffa9eb7d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-10T07:35:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/rpc_server: remove unused data argument from MSG_WINBIND_NEW_TRUSTED_DOMAIN
winbindd doesn't use that data anymore.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13237
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f96ede6f500cc1a7c76e67ee785b44a99244d0d">9f96ede6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-10T07:35:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: rename MSG_WINBIND_NEW_TRUSTED_DOMAIN to MSG_WINBIND_RELOAD_TRUSTED_DOMAINS
This reflects the new implementation in winbindd.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13237
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6151909c823016417f863c22e77c8a136f3fbb95">6151909c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-10T07:35:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/rpc_server: trigger trusts reload in winbindd after successfull trust info acquisition
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13237
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b112cbc2462edf810473026c133b0802d1e18468">b112cbc2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: fix debug message in find_default_route_domain() on a DC
As we don't support multiple domains in a forest yet,
we don't need to print a warning a log level 0.
This also adds a missing \n.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13255
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b0e1a77ae5f7ef6d8db9a05718afa8d472a971b">8b0e1a77</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wbinfo: avoid segfault in wbinfo_auth_crap() if winbindd is not available
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13256
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2ee2551409e0bd0cd5bf130cc1e3736e58b8c14d">2ee25514</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: add_trusted_domain_from_auth() should not use dns_name = ""
Check whether the DNS domain name in the info6 struct is actually more
then just an empty string. If it is we want to call add_trusted_domain()
with NULL as DNS domain name argument.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13257
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be26a472ae082d612f9aec28c932d25e2317f9ba">be26a472</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/rpc_client: add rpccli_netlogon_interactive_logon()
This will be used in a subsequent commit.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13258
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d1c3676197032487505e9069c0655427b5fd385c">d1c36761</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: separate plaintext given and interactive in winbind_samlogon_retry_loop()
We need to handle 4 cases:
plaintext_given=true interactive=true
plaintext_given=false interactive=true
plaintext_given=true interactive=false
plaintext_given=false interactive=false
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13258
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2268f1c0dd1e8543c126553f80d94e80a1e32487">2268f1c0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: add a comment to a parameter in _winbind_SamLogon()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13258
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8c6c47aec0e91ab3944bea5f6eda8072f5db959d">8c6c47ae</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: pass 'bool interactive' to winbind_dual_SamLogon()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13258
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d76bcdb0854cff9b08010d47469fd48324d902bc">d76bcdb0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: handle interactive logons in _winbind_SamLogon()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13258
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b60c634123ee00021efc5b5aaa03e1663474d3da">b60c6341</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: introduce a cm_connect_netlogon_secure() which gives a valid netlogon_creds_ctx
At lot of callers require a valid schannel connection.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13259
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/60aa5e7657608c1a5519c03e690cce58efd67abd">60aa5e76</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/rpc_client: add copy_netr_SamInfo6() and map_validation_to_info6()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13260
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1a9857369d2fae08fefef613cf6cbd3354092a4a">1a985736</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: allow validation level 6 in winbind_SamLogon
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13260
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e1ba81996033e7c2cfeba13124ee7f404ded2031">e1ba8199</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/auth_winbind: ask for validation level 6
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13260
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d4ba23fd353ad387a374a5d7f6f6d085a0699d2c">d4ba23fd</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/auth: add create_info6_from_pac()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13261
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2b0181877806f171eee053c246dcb2eda2300261">2b018187</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/rpc_client: add map_info6_to_validation()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13261
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/021d75fb223630d06a256a605659abda9ece853f">021d75fb</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: get netr_SamInfo6 out of winbindd_dual_pam_auth_kerberos()
This way we don't loose dns_domain_name and user principal.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13261
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/42e445396881c5b6651a0dde0abde3d6bb0740bf">42e44539</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: call add_trusted_domain_from_auth() in winbindd_pam_auth_crap_done()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13262
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ce3cb2fb468d8798980b49d84568782becf25ea">5ce3cb2f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: let winbindd_pam_auth_pac_send() compute info6 from PAC
This way we don't loose the DNS info and UPN. A subsequent commit will
let winbindd_pam_auth_pac_send() return the full validation info.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13262
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5444cc4e7ed8ea0c063110f3b78f360d91b0b0a5">5444cc4e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: complete WBFLAG_PAM_AUTH_PAC handling in winbindd_pam_auth_crap_send()
winbindd_pam_auth_crap_recv() should not have any real logic.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13262
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8422c001bec169a73657b1d638ec8ec4c35c243a">8422c001</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T07:35:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: rename winbindd_pam_auth_pac_send and let it return validation
Just a preperational step. The next commit will update the caller to
make use of the validation info.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13262
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/597e755328940fc964b861333b557b0650666b24">597e7553</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-10T12:08:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: WBFLAG_PAM_AUTH_PAC should call add_trusted_domain_from_auth() is the result is trusted
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13262
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Sat Feb 10 13:08:50 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/72a81529aa13ac34a6dc1b1cdc37d1329af48ffe">72a81529</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-11T23:50:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: SambaToolCmdTest.assertMatch() indicates what was asserted
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cb920dd8732af30a7f74d5b492ea6ddfc2adfcbd">cb920dd8</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-12T04:21:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/samba-tool user wdigest: fix a flapping test
The output of something like
samba-tool user getpassword $USER --attributes virtualWDigest01
contains an LDIF section with long strings folded on the 77th column.
To unfold this LDIF we were using:
result = re.sub(r"\n\s*", '', out)
which worked fine EXCEPT when a space in the output happened to land
immediately after the fold and got eaten by the \s*.
Instead we remove just a single space after the line break, because
that is always what fold_string() in lib/ldb/common/ldb_ldif.c
inserts, and for this simple replacement we don't need the re module.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Feb 12 05:21:01 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b4384b7f0ecf3b47dd60acaf77636b679e3adc05">b4384b7f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-12T18:51:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Improve child selection
This improves the situation when a client request blocks a winbind
child. This might be a slow samlogon or lookupnames to a domain that's
far away. With random selection of the child for new request coming in
we could end up with a long queue when other, non-blocked children
could serve those new requests. Choose the shortest queue.
This is an immediate and simple fix. Step two will be to have a
per-domain and not a per-child queue. Right now we're pre-selecting
the check-out queue at Fry's randomly without looking at the queue
length. With this change we're picking the shortest queue. The better
change will be what Fry's really does: One central queue and red/green
lights on the busy/free checkout counters.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Feb 12 19:51:35 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a5cd134ed7634328c9d0b64a45a59c04530c7249">a5cd134e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-12T18:52:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Free memory before we exit the connect child
This will make valgrind happy.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2abf47cfb3153108e3b153fee571ab187f9eb755">2abf47cf</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-12T18:52:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Free is_parent before we terminate
This makes valgrind happy.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1e8ad19653f11adbcffecde3a5762b28c5e06c8d">1e8ad196</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-12T23:25:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Initialize the domain groups member
==9405== 4 errors in context 1 of 493:
==9405== Conditional jump or move depends on uninitialised value(s)
==9405== at 0x7507F71: vfprintf (in /lib64/libc-2.12.so)
==9405== by 0x75C515B: __vasprintf_chk (in /lib64/libc-2.12.so)
==9405== by 0x2A8728: dbgtext (stdio2.h:199)
==9405== by 0x22DCBB: winbindd_list_groups_done (winbindd_list_groups.c:127)
==9405== by 0x6C7F568: _tevent_req_error (tevent_req.c:167)
==9405== by 0x6C7F568: _tevent_req_error (tevent_req.c:167)
==9405== by 0x6C7F568: _tevent_req_error (tevent_req.c:167)
==9405== by 0x3CDAE8: dcerpc_binding_handle_call_done (binding_handle.c:445)
==9405== by 0x6C7F568: _tevent_req_error (tevent_req.c:167)
==9405== by 0x6C7F568: _tevent_req_error (tevent_req.c:167)
==9405== by 0x202701: wbint_bh_raw_call_done (winbindd_dual_ndr.c:139)
==9405== by 0x6C82C60: tevent_common_loop_timer_delay (tevent_timed.c:341)
==9405== by 0x6C83CA1: epoll_event_loop_once (tevent_epoll.c:911)
==9405== by 0x6C822D5: std_event_loop_once (tevent_standard.c:114)
==9405== by 0x6C7DC3C: _tevent_loop_once (tevent.c:533)
==9405== by 0x1D8A03: main (winbindd.c:1490)
==9405== Uninitialised value was created by a heap allocation
==9405== at 0x4A069EE: malloc (vg_replace_malloc.c:270)
==9405== by 0x6A71DCA: _talloc_array (in /usr/lib64/libtalloc.so.2.1.5)
==9405== by 0x22D959: winbindd_list_groups_send (winbindd_list_groups.c:69)
==9405== by 0x1D76BC: winbind_client_request_read (winbindd.c:647)
==9405== by 0x23AF2A: wb_req_read_done (wb_reqtrans.c:126)
==9405== by 0x6C83EA5: epoll_event_loop_once (tevent_epoll.c:728)
==9405== by 0x6C822D5: std_event_loop_once (tevent_standard.c:114)
==9405== by 0x6C7DC3C: _tevent_loop_once (tevent.c:533)
==9405== by 0x1D8A03: main (winbindd.c:1490)
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Feb 13 00:25:27 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e6187be11846239f1a0e6e76aa3812a52406989a">e6187be1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-12T23:26:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix a signed/unsigned hickup
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f51916265777189eafd7d8d73166fc52287f2878">f5191626</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-12T23:26:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Pass "file_id" through share_entry_forall
It's also in the share_entry, but that is redundant and will go
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/786e307fd433065c097915a9d98fc71b4afbab14">786e307f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-12T23:26:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">srvsvc: Use the passed-in file id, not the one from share_mode_entry
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9487510e9e1269e70d4c4fbc44316f0c8758be03">9487510e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-12T23:26:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Pass in "file_id" into share_mode_str()
This used to directly access share_entry->id, which will go
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3434b32b88e656e767a0a1d2fa3988b2fb2311b0">3434b32b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-12T23:26:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Pass in "file_id" into validate_my_share_entries
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c1079e3d2a9dd10b11e6b7c9b9852518ea637bb5">c1079e3d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-12T23:26:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">srvsvc: Use the passed-in file_id
The one in share_mode_entry will go
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bab8bf7acb71bc54c258c29e7392927afb8b0709">bab8bf7a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-12T23:26:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use "share_mode_data->id", not "share_mode_entry->id"
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5fdc62b2369b8463940629dc47c2768f0bcfc29d">5fdc62b2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-12T23:26:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove a redundant check
The file ids in all share modes match the share_mode_data's one
We don't have a paranoia check for this, but the share mode is per inode.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fc424b28cd54f4ff5737417db1e1f8059cad80db">fc424b28</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-12T23:26:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Pass "file_id" explicitly into share_mode_entry_to_message()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b7e29d04c6156a6eb5c02b12e53abd1a04d75471">b7e29d04</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-12T23:26:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Pass "file_id" explicitly to message_to_share_mode_entry()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ddb1524669681bffc86090432f01a21621d11d2f">ddb15246</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-12T23:26:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Avoid a dependency on share_mode_entry->id
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d9e51484703e7ff510c534c603d30975d87c895c">d9e51484</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-12T23:26:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Avoid a dependency on share_mode_entry->id
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9d7701c923bce11c05c879ea3f7cdd2322e3d2bd">9d7701c9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-12T23:26:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">srvsvc: Avoid a dependency on share_mode_entry->id
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1e2659e96d4a309e76d1fc2a5a3dabb83a258127">1e2659e9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-12T23:26:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Pass "file_id" explicitly to send_break_message()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f7e65719a4bc5fa2bede491d40a610b28f873c8a">f7e65719</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-12T23:26:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Pass "file_id" explicitly to send_break_to_none
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3bbc57564411b031bf3ce55652c9c899642da045">3bbc5756</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-13T04:01:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove "id" from share_mode_entry
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Feb 13 05:01:38 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d09bd9767322e5a3cfd060a969b8d3a3144453d9">d09bd976</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-13T15:25:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Fix smbpasswd manpage about password storage
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Feb 13 16:25:33 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/494dc70f69804e2d703b382a56406d69e984e9f1">494dc70f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-13T15:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnbt: Use TALLOC_FREE
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f23615956fee987f7cce85b724633790c5f64b6">6f236159</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-13T15:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnbt: Apply some const
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/44dcd5d094c5d44d6cc1e94c9be2e5b78f514acf">44dcd5d0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-13T15:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77c1df57a87b483c35ca01ede13d40980d3e1a96">77c1df57</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-13T15:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: Add some {}
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f7cc3db3f3ab93bc02a3446ad89a58b8eef00e8b">f7cc3db3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-13T15:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: Fix a cut&paste typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa29a695fbd0a1f881a2434fd1ce2bdef1d213ce">aa29a695</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-13T15:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Fix destructor setup in unexpected.c
The destructor does DLIST_REMOVE, so better make sure "client" is in fact
member of that list when the destructor fires
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3781dba923fc01ffa32ea1e15adb847bccae44bb">3781dba9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-13T15:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Fix an error path memleak
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/093871d931a9c925f3a858e2963d8f36988282ac">093871d9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-13T15:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsgetdcname: Add some const
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/46148e657f5d53b0d83dbcead9a8b8d0bd0baf21">46148e65</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-13T15:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: Slightly simplify net_lookup_dsgetdcname()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/36bb685abde872f43c3e23150119c3af91dea569">36bb685a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-13T20:07:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsocket: Avoid an unnecessary else branch
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Feb 13 21:07:17 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ebd88eb44192a28341579e4a4515bae479e7368a">ebd88eb4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-14T19:32:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Add a not that 'wbinfo --user-groups' may be incomplete
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Feb 14 20:32:18 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/298d812ca053811a56e5092fb52bffa60d007650">298d812c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-14T23:18:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Generate random test usernames
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a45e70bf47cb4b48f69a237298e143f574bf58bb">a45e70bf</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-14T23:18:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Convert base64 encoded password to utf-8
Pair-Programmed-With: Alexander Bokovoy <ab@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ee74f66a1715b2c88165f025ebc3b661f15c75d">7ee74f66</a></strong>
<div>
<span>by Lumir Balhar</span>
<i>at 2018-02-14T23:18:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Port dsdb_dns module to Python 3 compatible form.
Signed-off-by: Lumir Balhar <lbalhar@redhat.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cb15e32f85f7a69dff0e461ec3536a84e95407ca">cb15e32f</a></strong>
<div>
<span>by Lumir Balhar</span>
<i>at 2018-02-14T23:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Add `text_type` Python 2/3 compatible function name.
This compatible function name represents `str` in Python 3
and `unicode` in Python 2.
Signed-off-by: Lumir Balhar <lbalhar@redhat.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bc7c6c15da0ba42cd7f4b3551d2ab33f349bae1b">bc7c6c15</a></strong>
<div>
<span>by Lumir Balhar</span>
<i>at 2018-02-14T23:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Port samdb module to Python 3 compatible form
Signed-off-by: Lumir Balhar <lbalhar@redhat.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dce18a079e8c1e259bab4b4da57121d6ab4b7635">dce18a07</a></strong>
<div>
<span>by Lumir Balhar</span>
<i>at 2018-02-14T23:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Port dsdb module to Python 3 compatible form.
Signed-off-by: Lumir Balhar <lbalhar@redhat.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70a85c163ff7397075bf0cef8a483df4f33799b4">70a85c16</a></strong>
<div>
<span>by Lumir Balhar</span>
<i>at 2018-02-14T23:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: tests: Make tests of dsdb Python module Python 3 compatible
Signed-off-by: Lumir Balhar <lbalhar@redhat.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/92ec01dcf080901eb4c208b208651ae03e77f538">92ec01dc</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-14T23:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python.subunit: add assertRegexpMatches for Python 2.6
This is used in python/samba/tests/samba_tool/provision_password_check.py
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cec3646c5d2ac47df129f16f8994c332e2ad06c3">cec3646c</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-14T23:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: move samba-tool drs showrepl into its own suite
This is a simple copy of the sowrepl test to the new file, making room
to expand the test and (soon) to test JSON output.
pep-8 intentionally ignored to show this is a copy.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/48248b7ad15458f2f5a5b1410b1aed1c52cf019b">48248b7a</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-14T23:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test samba-tool drs showrepl: fix formatting and unused imports
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2cd70978681259713281bd9e89971cf98584b069">2cd70978</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-14T23:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test samba-tool drs showrepl: test expected output more strictly
We try to ensure the output has all the expected information in the
expected order.
Soon we're going to add a JSON output mode, and we are strengthening
the tests here to ensure we don't break anything.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/90d0c638ef1817337a58babd0c02be5c9c4611c6">90d0c638</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-14T23:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs showrepl: restructure in preparation for --json
Basically we just separate data extraction from printing.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ed15a452e7db6d76e231e5fbd45fa236c57a87f3">ed15a452</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-14T23:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs showrepl: add --json option for JSON output
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a12925b6ed66ca2e0383e8e60e4deeb5894dc3ed">a12925b6</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-14T23:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test samba-tool drs showrepl: test --json output
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8e54bc463adcfbc322249ba626e2c503ca13a864">8e54bc46</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-02-14T23:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Require jansson support for selftest of the AD DC
This avoids this code becoming untested if a package is not installed or
the configure test is accidentially broken.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b415f9202fcb05eb75513494c596bf30082ca63d">b415f920</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-02-14T23:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: GnuTLS is already mandetory to build the AD DC
This change avoids the code behind 'if have_tls_support' becoming untested
if the configure logic changes. We already assert that we have GnuTLS
elsewhere in the AD DC build scripts.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/23ec3021224d797ab9d889d8152d8d7774da0226">23ec3021</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-14T23:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbspool: Initialize empty_str on declaration
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/278ac393844bcbb5df7a2e2d75b878e20fba323e">278ac393</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-02-14T23:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Avoid a build started around midnight failing (again)
This case most likely relates to Daylight Saving changes creating
a 23 hour day.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a485ac32438b74315ffd4a7188909f00e175d4fa">a485ac32</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-14T23:18:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: convert 'except X, e' to 'except X as e' for all X
This is needed for Python 3 and is compatible with python 2.6
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4885937bf87e6c37c60cda890dc18d46b5868a91">4885937b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-14T23:18:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba python libs: convert 'except X, e' to 'except X as e'
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/28134d002b632a7fcd52906604412889fc973ef5">28134d00</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-14T23:18:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba python tests: convert 'except X, e' to 'except X as e'
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/20e38fbd457a35e90662a284bead44b05393f54b">20e38fbd</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-14T23:18:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb python tests: convert 'except X, e' to 'except X as e'
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f43cb7c38d1945cdeca259b53a433c68803482d0">f43cb7c3</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-14T23:18:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4/scripting python: convert 'except X, e' to 'except X as e'
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf2086e137e00414669828991027d9c450fd0bcc">bf2086e1</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-14T23:18:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">drs torture python: convert 'except X, e' to 'except X as e'
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/16e173ad2e52ed1140fd43cabdeec0bc4553f6d2">16e173ad</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-14T23:18:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest and autrobuild: convert 'except X, e' to 'except X as e'
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5fbb47144328b6bd4e52369c904d81633e5fdb02">5fbb4714</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-14T23:18:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">scripts/ python: convert 'except X, e' to 'except X as e'
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/578786c38b65e5c3925ab9f605cfd661d0950cc2">578786c3</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-15T04:40:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools python: convert 'except X, e' to 'except X as e'
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Feb 15 05:40:55 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/19fcd872ec76afffbc4952266fdfad9a352c4871">19fcd872</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-02-15T04:42:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/replica_sync: Add some additional replication in setUp
This should avoid some failures due to stale objects.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff9e63f976ef76f7f70221d4f6276e221ecd167f">ff9e63f9</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-02-15T04:42:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/drs_base: Allow the net drs replicate to try with a single object
This eventually passes down the replicate single object exop.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13269
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e694b8a1b993bf7213b191e1132c5d02e16ab85d">e694b8a1</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-02-15T04:42:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add RODC variables to list of those exported
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13269
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/45d19167d52e42bd2f9369dbe37a233902cc81b0">45d19167</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-02-15T04:42:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/replica_sync_rodc: Test conflict handling on an RODC
There are two cases we are interested in:
1) RODC receives two identical DNs which conflict
2) RODC receives a rename to a DN which already exists
Currently these issues are ignored, but the UDV and HWM are being
updated, leading to objects/updates being skipped.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13269
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59fa9e7ecf84bd4c2469e9a6835855769c4f6287">59fa9e7e</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-02-15T04:42:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">repl_metadata: Avoid silent skipping an object during DRS (due to RODC name collisions)
No error code was being set in this case, and so, we would commit the
HWM and UDV without actually having all the updates.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13269
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9952eda7a1923971f77f3183cfa4c505386b30ee">9952eda7</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-02-15T09:18:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">repl_metadata: Avoid silent skipping an object during DRS (due to RODC rename collisions)
No error code was being set in this case, and so, we would commit the
HWM and UDV without actually having all the updates.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13269
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Thu Feb 15 10:18:42 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e3c2c8bc66d747e0eb8e7c1736268f7fd0b0d7a">0e3c2c8b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-15T19:32:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Don't explicitly send "server_id" for ONLINESTATUS
Messaging already provides the sender id
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8313d715b073a36b95c09f40c1f2dfc9bf7d5b6">f8313d71</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-15T23:56:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Don't send "server_id" explicitly for DUMP_DOMAIN_LIST
messaging already provides the sender id
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Feb 16 00:56:36 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3450dd6a50d1d08f49de5ff98f2ce20f31081636">3450dd6a</a></strong>
<div>
<span>by Timur I. Bakeyev</span>
<i>at 2018-02-19T06:36:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Don't load LDB_MODULESDIR as a module file
We are setting modules directory here(LDB_MODULESDIR) so treat it this
way, no need to attempt to load it as a module file.
Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e2023e86d54be86784a18ccbeced4e2a046c710d">e2023e86</a></strong>
<div>
<span>by Timur I. Bakeyev</span>
<i>at 2018-02-19T06:36:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Remove some bashisms from the test scripts
Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d35a22cc445795faf8331b6d4b195e0c35eab99e">d35a22cc</a></strong>
<div>
<span>by Timur I. Bakeyev</span>
<i>at 2018-02-19T11:31:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix incorrect `ldbsearch` invocation
Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
Autobuild-User(master): Uri Simchoni <uri@samba.org>
Autobuild-Date(master): Mon Feb 19 12:31:38 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b45dc6841ff534e7a0eb481aa4f4149a716824f">7b45dc68</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-02-19T18:17:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">subnet: Avoid a segfault when renaming subnet objects
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13031
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c9c2754a950d6cd411d490fa7fb9fad5b194a01">9c9c2754</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-19T18:17:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/sites: ensure we can't manipulate subnets as non-admin
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13031
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c96dc78aa680d3a1c1d53ea9b18a966025a93e16">c96dc78a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-19T18:17:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:tldap: Fix parsing LDAPv2 escaped strings
Yes, this is outdated, but the missing 'break' produces a compiler
warning.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Simo Sorce <idra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/654b76739a72b8ecdf0542c0b9a566b82dcfb1e1">654b7673</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-19T18:17:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:tldap: Comment code for to LDAP escaping version
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7573b2a960c5bd32ac6d42b10bb46329ff7fa7b7">7573b2a9</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-19T22:47:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add tests for parsing LDAPv3 and LDAPv2 filter strings
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Feb 19 23:47:08 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a6eac8f64989235e7a297c14e349d98a3fc70e47">a6eac8f6</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-20T20:46:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbspool: Improve URI handling code
This also checks that the URI given via the environment variables
starts with smb://
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Feb 20 21:46:38 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9abe97285b7e1de25bf1c1f4fde8fd481a31a6bb">9abe9728</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-20T20:55:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tldap: Dump unnecessary includes
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b2aec11c76904bf6a8f67f0634cce5e443e77d8b">b2aec11c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-20T20:55:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: Pass a mem_ctx to make_new_session_info_guest()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f47cec2343ca7658460cc14fa613fdd2611677a">7f47cec2</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-20T20:55:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: Pass mem_ctx to init_guest_session_info()
Use a mem_ctx which gets freed if possible.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f9c6d369f4aa4a5c861f51041dd663e81e2ec4e">6f9c6d36</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-21T01:46:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: Pass mem_ctx to init_system_session_info()
We have a stackframe we can use for the lifetime of the session.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Feb 21 02:46:40 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/41085ad37de56504467a0014b70f6a708dcde91b">41085ad3</a></strong>
<div>
<span>by Jamie McClymont</span>
<i>at 2018-02-21T01:47:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: remove prototypes from some subroutine templates
Rationale, as sent to samba-technical:
> Why do you remove the explicit argument declarations for so many functions?
> These declarations help catch usage errors, i.e. wrong number of calling
> arguments, especially when you add arguments to functions.
My understanding is that because these are object methods, the prototypes
actually were not providing the checking benefits [see PERLSUB(1) (section
"Prototypes")] -- this is evidenced by the fact that some of the prototypes I
removed actually had the wrong number of arguments!
Now that the subroutines are being dynamically called by function references,
the checking also appears not to apply [see the same source].
There was also a more concrete reason: the setup code will automatically set
up multiple environment dependencies and pass each of their vars as an
individual parameter. Accomplishing this was [seemingly] impossible with the
prototypes in place.
Additionally, there seems to be a consensus among perl devs that prototypes
are generally harmful: see this post (by my colleague) for example:
http://www.perlmonks.org/?node_id=406231
Signed-off-by: Jamie McClymont <jamiemcclymont@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/962e8a0ea7db79b96dddec06a4bde211eea0d1d6">962e8a0e</a></strong>
<div>
<span>by Jamie McClymont</span>
<i>at 2018-02-21T01:47:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: move to declaratively specifying environments and their dependencies
This removes the tangle of code for starting up dependencies, and allows
selftest.pl to query dependencies (hence it can know when things can be shut
down early and how to order environments for optimal memory usage - that patch
not yet submitted).
It also removes the slightly hacky special-casing of the ad_members, and sets
$target->{vars} centrally (so each setup_ function does not need to).
Signed-off-by: Jamie McClymont <jamiemcclymont@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0b63f26bf72e5f5ce5ab6d052bc899375818a235">0b63f26b</a></strong>
<div>
<span>by Jamie McClymont</span>
<i>at 2018-02-21T06:47:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: change technique for running specific envs
Currently testsuites excluded with --exclude/--include-env are skipped when
encountered in the middle of a run, so they are included in progress reporting,
and the @todo list does not accurately show what will be done.
This change skips them earlier, preventing them from being added to @todo, as is
done with pattern-based including/excluding.
As well as making the progress indicator more accurate, this means that
selftest.pl can use @todo to determine when we are finished with an environment.
Signed-off-by: Jamie McClymont <jamiemcclymont@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Feb 21 07:47:58 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/14f798cbcccb5712d8b31bc891c49a00a7483a95">14f798cb</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2018-02-21T13:19:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: remove dead already commented code
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/29aa5c93d751384829175a3ac0cc42e6905fe8b1">29aa5c93</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2018-02-21T13:19:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript: drop checks for setnetgrent/endnetgrent/getnetgrent
we don't use setnetgrent/endnetgrent/getnetgrent since security share passed
away.
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/86e63d25ecfc1b4ca5f1555299ad72c8ade7b6f3">86e63d25</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2018-02-21T13:19:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: remove some duplicate checks
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/17c48f26dea5701feed1c24769348f332695391c">17c48f26</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: don't split the rid for SID_NAME_DOMAIN sids in wb_lookupsids
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13279
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b5ffa0e21f74fa0c452df38cf50e542eb278562d">b5ffa0e2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: initialize type = SID_NAME_UNKNOWN in wb_lookupsids_single_done()
We check for !NT_STATUS_LOOKUP_ERR(), but wb_lookupsid_recv()
only initializes the results together with NT_STATUS_OK.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13280
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5cae7da1de302b38ee0059590b1e93a3d60ee42c">5cae7da1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:cli_lsarpc: use talloc_zero_array() in dcerpc_lsa_lookup_sids_generic()
It just feels better for such a complex function.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13281
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/569c910b950df24b22777c545fe9f6427a19b035">569c910b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:cli_lsarpc: use talloc_zero_array() in dcerpc_lsa_lookup_names_generic()
It just feels better for such a complex function.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13281
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c376ab29d1d9f4b06fbb3a713029d79ecac80b59">c376ab29</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: make use of talloc_zero_array() in wb_lookupsids*()
It just feels better for such a complex function.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13281
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b86b94c71268cdab434ced74caedcdd5eb20e12">7b86b94c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: zero initialize variables in test_LookupSidsReply()
This avoids crashes if the server returns unexpected results. The test
should just report the failure in that case.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13282
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da784305e7b306664b79d30a734d45582f5bf4dd">da784305</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: fix double free errors in nsstest.c
We need to zero out static pointers on free.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13283
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1a258b6b0f667ec077639a7cfe826e5e25f46768">1a258b6b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_packets.py: let Lookup{Sids,Names}() work against a sane server
In order to resolve predefined sids or names we need to use
level = LSA_LOOKUP_NAMES_ALL (1).
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13284
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b02de5ad3e04babe1565868c69422cfc778458d9">b02de5ad</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">provision: fix the 'dnsdomain' for the local sam of a domain member
A member has a local AD database, which should not use the 'dnsdomain'
as the one on domain controllers.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13285
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9ccc6eef145c1f67e24cbb1c21402714f612c607">9ccc6eef</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpcclient: fix variable initialisation and add parenthesis to if clauses
Just a few README.Coding fixes.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/76868818e8b98a0cd4881d319e0735de5091b8b1">76868818</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpcclient: add lookupsids_level command
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3909f8fcfe6b82575ad8974acacde3270ce849fe">3909f8fc</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: use LSA_LOOKUP_OPTION_SEARCH_ISOLATED_NAMES/LSA_CLIENT_REVISION_1 in compat code
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f6e60d2c2e1f0a4eb6426c7da683abaa11babd05">f6e60d2c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: make sure dcesrv_lsa_LookupSids_common() gets prepared [ref] pointers
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3339a1c57266181570d5ca5e389719951f26b41d">3339a1c5</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: expect prepared [ref] pointers in dcesrv_lsa_LookupNames_common()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fe43dd8678e4f598e0ae802e3d93ad9b28988783">fe43dd86</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: make sure dcesrv_lsa_LookupNames2() gets prepared [ref] pointers
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e8a0223633fd2e6ebb3d864570b76932bc3e293a">e8a02236</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: remove unused 'status' variable in dcesrv_lsa_LookupSids_common()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d868fd875803e361653ccca4e61c5c25dc114aa">5d868fd8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: simplify [ref] pointer handling in dcesrv_lsa_LookupSids()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7c1c9bf53ffc24a25038326767e33f008c7a5552">7c1c9bf5</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: simplify [ref] pointer handling in dcesrv_lsa_LookupNames()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c0f6103ddea9a825f0f0dcf169e70a5f6a55c2e2">c0f6103d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: rename 'state' variable to 'policy_state' in dcesrv_lsa_LookupSids_common()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c78c17dc2fbaf523d1957bb748aa75ecd81e793b">c78c17dc</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: rename 'state' variable to 'policy_state' in dcesrv_lsa_LookupSids2()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ec55c18ceda5c430eaec97c5d7e594941e3a31fc">ec55c18c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: rename 'state' variable to 'policy_state' in dcesrv_lsa_LookupNames2()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/37cb34d16406d27831be74e952ee744e58b79fb4">37cb34d1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: base dcesrv_lsa_LookupNames() on dcesrv_lsa_LookupNames_common()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e6c9984bd563525dc312b67fe69ea7e4be04ee4e">e6c9984b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: base dcesrv_lsa_LookupNames2() on dcesrv_lsa_LookupNames_common()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ab7988aa2fd1a43f576a4b73a6893c61c7ef1957">ab7988aa</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: prepare dcesrv_lsa_LookupSids* for async processing
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b6a0b1a63f2ebfbd578047401dfbe38606c8c44">9b6a0b1a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: prepare dcesrv_lsa_LookupNames* for async processing
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e9ace1852ff88ebb7778e8db9a49bc5c61512d16">e9ace185</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:dsdb: add dsdb_trust_domain_by_{sid,name}()
This gets the lsa_ForestTrustDomainInfo for the searched
domain as well as the lsa_TrustDomainInfoInfoEx for the
direct trust (which might be the same for external trust or
the forest root domain).
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d7780c66866144eba59408c03af50256825165ba">d7780c66</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/security: add dom_sid_lookup_predefined_{sid,name}()
This basically implements [MS-LSAT] 3.1.1.1.1 Predefined Translation Database
and Corresponding View.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/475a761637bbcc93edbe8d83fc13037e1087941a">475a7616</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_trust_ntlm.sh: add lookup name tests
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3801c417db5891ee4a45b09e8841d8f1ff4500f9">3801c417</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: rewrite lookup sids/names code to honor the given lookup level
[MS-LSAT] 2.2.16 LSAP_LOOKUP_LEVEL defines the which views each level should
consult.
Up to now we support some wellknown sids, the builtin domain and our
account domain, but all levels query all views.
This commit implements 3 views (predefined, builtin, account domain)
+ a dummy winbind view (which will later be used to implement the
gc, forest and trust views)..
Depending on the level we select the required views.
This might not be perfect in all details, but it's enough
to pass all existing tests, which already revealed bugs
during the development of this patch.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3ffebee3de4aa313027779bc98cb6326fa17be85">3ffebee3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: implement wb_irpc_lsa_{LookupNames4,LookupSids3}()
This will be used by the LSA Server on an AD DC to request remote views
from trusts.
In future we should implement wb_lookupnames_send/recv similar to
wb_lookupsids_send/recv, but for now using wb_lookupname_send/recv in a loop
works as a first step.
We also need to make use of req->in.level and req->in.client_revision
once we want to support more than one domain within our own forest.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e9d5b8b6b41155a8a043275ae497bdb87044d476">e9d5b8b6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: implement forwarding lsa_Lookup{Sids,Names}() requests to winbindd
This might not be perfect yet, but it's enough to allow names from trusted
forests/domain to be resolved, which is very important for samba based
domain members.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13286
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3a7ebd0e940e80b185a9240c093e1fee6795fd5b">3a7ebd0e</a></strong>
<div>
<span>by Bjoern Jacke</span>
<i>at 2018-02-21T13:19:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">heimdal_build: use closefrom from libreplace
this silences a lot of "... has been redefined" compiler warnings on
platforms that don't have closefrom
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65e8edb382fbc7450919aad8b42cfcae9e779d11">65e8edb3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T13:19:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests:dcerpc/raw_protocol: reproduce call_id truncation bug
We need to make sure the server handles call_id values > UINT16_MAX.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13289
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d113f80944f2e1d2a7e80f73aea7a4cfdfbd140">5d113f80</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-21T18:02:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: fix call_id truncation in dcesrv_find_fragmented_call()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13289
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Feb 21 19:02:56 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d79575de8e47a0ce03e30c3ea84176be696269f">7d79575d</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-22T00:04:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: subunithelper needs to follow the subunit spec more closely
In particular allow ]\n without \n]\n as used by cmocka
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cb5f1f3b262467faba59b3b323e240d1351d5fc0">cb5f1f3b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-22T00:04:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">unittests.lib_util_modules: test module probe with "skel", not "unix"
The unix module is not available as a module on some systems.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/33ef0e57a4f08eae5ea06f482374fbc0a1014de6">33ef0e57</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-22T00:04:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/tests.py: remove always-needed, never-set with_cmocka flag
We have cmocka in third_party, so we are never without it.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6ef6ddce5a64c55729c2e3d423757f504b0ab15e">6ef6ddce</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-22T00:04:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">shift read_hex_bytes() and parse_guid_string() into lib/util
read_hex_bytes() is going to be used in lib/util/rfc1738.c.
parse_guid_string() is shifted for two reasons: Firstly, it is called
very often in some operations, sometimes constituting a few percent of
the CPU load, and it makes several calls to read_hex_bytes(). We want
the compiler to be able to inline those calls if it thinks that is
wise. Secondly, there are other places that could do with fast GUID
parsing.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a4c853a7deb080dd44e3c54eb45935ff0df91baf">a4c853a7</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-22T00:04:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">util/rfc1738_unescape(): return end pointer or NULL on error
At present we don't detect errors, but when we do we'll return NULL.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f3e20d98bdc04d6301ab0560cc7fde6ec9cc796">9f3e20d9</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-22T00:04:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">util/tests: add rfc1738 cmocka tests
These don't pass yet.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c20a3699075369e5516af47100220dab18435a91">c20a3699</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-22T00:04:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">util/rfc1738: simplify and fix rfc1738_unescape()
Improvements:
* NULL is returned when the string is incorrectly formed.
* Badly formed escapes like "% b" that were accepted by sscanf() are now
rejected.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d99a075239588170be5a26453219d3cac5425885">d99a0752</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-22T00:04:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">util/rfc1738: remove unused versions of rfc1738_escape
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a06cfa2e2caed2067bf9030408cf56de7b89d65">7a06cfa2</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-22T00:04:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">util/rfc1738: simplify and fix rfc1738_escape_part()
We now encode according to RFC 3986 (section 2.1 - 2.3).
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8c833470fc52332c62220ec9cc38c8a4fd7721f1">8c833470</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-22T05:13:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">util/rfc1738: update preamble
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Thu Feb 22 06:13:49 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a59619844e0def505a6bfa778c17721c062e0ee">6a596198</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-02-22T18:30:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: fix libceph-common detection
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13277
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Thu Feb 22 19:30:12 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0786a65cabb92a812cf1c692d0d26914f74a6f87">0786a65c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-22T22:15:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: allow -U"\\administrator" to work
cli_credentials_get_principal() returns NULL in that case.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13206
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e039e9b0d2a16b21ace019b028e5c8244486b8a3">e039e9b0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-22T22:15:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:cliconnect.c: remove useless ';'
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13206
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c625eae3f54e8de434de26e9f6a0f2fde557c18">5c625eae</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-02-22T22:15:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/py_creds: Add a SamLogonEx test with an empty string domain
This test passes against 4.6, but failed against 4.7.5 and master.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13206
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2e49a97777ebf5bffbeadca03517b4a21bca24c0">2e49a977</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-02-22T22:15:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/bind.py: Add a bind test with NTLMSSP with no domain
Confirmed to pass against Windows 2012 R2.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13206
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/57762229da971e837b923f09ca01bad6151f9419">57762229</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T03:08:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:auth_sam: allow logons with an empty domain name
It turns out that an empty domain name maps to the local SAM.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13206
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Feb 23 04:08:26 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/88d6703b89f9a7f847b6ec47d97569432927dcff">88d6703b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T03:09:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: improve documentation of tevent_queue_add_optimize_empty()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c6f31697a8edb03d36eece5c79581b952743b5b">5c6f3169</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T03:09:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: add tevent_queue_entry_untrigger()
Pair-Programmed-With: Volker Lendecke <vl@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f00c7cf9f5f325de0b754b127fcc0f07bea2d825">f00c7cf9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T03:09:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: version 0.9.36
* improve documentation of tevent_queue_add_optimize_empty()
* add tevent_queue_entry_untrigger()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d29dda141e08af42c535e8718226f95c45aadab8">d29dda14</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T03:09:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: use tevent_queue_wait_send/recv in wb_child_request_*()
We need a way to keep the child->queue blocked without relying on
the current 'req' (wb_child_request_state).
The next commit will make use of this.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13290
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/43af57d8728883c5ddbe169e1483181246fb68a8">43af57d8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T03:09:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: protect a pending wb_child_request against a talloc_free()
If the (winbind) client gave up we call TALLOC_FREE(state->mem_ctx)
in remove_client(). This triggers a recursive talloc_free() for all
in flight requests.
In order to maintain the winbindd parent-child protocol, we need
to keep the orphaned wb_simple_trans request until the parent
got the response from the child.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13290
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6548b82b5c1ed30ce14e17e4ba9d4bc24ab49c42">6548b82b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T03:09:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: call lp_winbind_enum_{users,groups}() already in set{pw,gr}ent()
This way we don't keep winbindd_cli_state->{pw,gr}ent_state arround forever,
if the client forgets an explicit end{pw,gr}ent().
This allows client_is_idle() return true in more cases.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13293
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b7789da8468c3f070727011639d5f74aca76cb59">b7789da8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T03:09:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: cleanup winbindd_cli_state->grent_state if winbindd_getgrent_recv() returns an error
A client may skip the explicit endgrent() if getgrent() fails.
This allows client_is_idle() return true in more cases.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13293
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b158d4e4c1c3fee0a8884bc5e8f0c5a5ce49687f">b158d4e4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T03:09:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: cleanup winbindd_cli_state->pwent_state if winbindd_getpwent_recv() returns an error
A client may skip the explicit endpwent() if getgrent() fails.
This allows client_is_idle() return true in more cases.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13293
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d73e3d451976e692c6c346f98547d7123f7b9006">d73e3d45</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T03:09:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: avoid using fstrcpy(dcname,...) in _dual_init_connection
domain->dcname was converted from fstring to char * by commit
14bae61ba36814ea5eca7c51cf1cc039e9e6803f.
Luckily this was only ever called with an empty string in
state->request->data.init_conn.dcname.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13294
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4d804f5f3e65df0e2f646d4f88793cab8e2f32d1">4d804f5f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T03:09:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: use state->{ev,request} in wb_domain_request_send()
This will reduce the diff for the following changes.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13295
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1f41193e005df37401a28004f0a95d4d73b98ccd">1f41193e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T03:09:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: improve wb_domain_request_send() to use wb_dsgetdcname_send() for a foreign domain
Commit ed3bc614cccec6167c64ac58d78344b6426cd019 got the logic wrong while
trying to implement the logic we had in init_child_connection(),
which was removed by commit d61f3626b79e0523beadff355453145aa7b0195c.
Instead of doing a WINBINDD_GETDCNAME request (which would caused an error
because the implementation was removed in commit
958fdaf5c3ba17969a5110e6b2b08babb9096d7e), we sent the callers request
and interpreted the result as WINBINDD_GETDCNAME response, which
led to an empty dcname variable. As result the domain child
opened a connection to the primary domain in order to lookup
a dc.
If we want to connect the primary domain from the parent via
a domain child of the primary domain.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13295
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c2d78a0a0a3f9b9ade61cf707f23e59a1a16c61b">c2d78a0a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T03:09:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: add idmap_child_handle() and use it instead of child->binding_handle
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13292
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/44ebaaac8933f5fc16a043b8c15a9449746af47b">44ebaaac</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T03:09:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: add locator_child_handle() and use it instead of child->binding_handle
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13292
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5116aff286bdffe4abc9ddda09cf64ab999fd13e">5116aff2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T03:09:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: make choose_domain_child() static
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13292
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b518cb0597d269002105644302c58ca8f9f0f717">b518cb05</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-23T03:09:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Maintain a binding handle per domain and always go via wb_domain_request_send()
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13292
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f2d45a6c2a88dd8833fc66d314ec21507dd52c3">7f2d45a6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T08:04:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Use one queue for all domain children
If we have multiple domain children, it's important
that the first idle child takes over the next waiting request.
Before we had the problem that a request could get stuck in the
queue of a busy child, while later requests could get served fine by
other children.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13292
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Feb 23 09:04:23 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f9e2cb1369fa9636ff613a4e9c7387151409eafc">f9e2cb13</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-02-23T11:47:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: use off_t, not size_t for TM size calculations
size_t is only a 32-bit integer on 32-bit platforms. We must use off_t
for file sizes.
https://bugzilla.samba.org/show_bug.cgi?id=13296
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/07844a9a13506b4ca9181cfde05d9e4170208f88">07844a9a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T11:47:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb/encrypted_secrets: remove dependency to libnettle and use our own aes_gcm_128_*()
We already rely on gnutls in order to implement SSL/TLS, so using that
to speed up crypto like aes gcm 128 is fine, but as we already have
code for that algorithm, we should use that instead of adding a new
dependency to libnettle.
Some (I guess newer versions) of gnutls use nettle internally, so
we may end up using that code, but we should not have a direct dependency.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13276
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c58f8c3cd84ab18d04bd39ad7d5f53676e092abb">c58f8c3c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T11:47:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smb_macros.h: add IS_AD_DC as addition to IS_DC
In the long run we should remove this again (as well as IS_DC).
But for now this makes some code changes in winbindd easier to
follow.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13278
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3e17a3b7cd4083299037ba9377931bea792b2d18">3e17a3b7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T11:47:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: force the usage of schannel in cm_connect_lsa() as AD DC
This makes sure we only talk to direct trusts.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13278
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/532a14dc684e7a6d8c584d5671a4ebbad00aa4fc">532a14dc</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T11:47:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: let cm_connect_netlogon_transport() only work against direct trust as AD DC
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13278
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/32a63e3ea985c967ca2aadbcd9e0c60ade2d0367">32a63e3e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T11:47:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: make sure we don't contact trusted domains via SAMR as AD DC
This is not needed for the normal operation of an AD DC.
Administrators should just use other tools instead of
wbinfo to list and query users and groups.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13278
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/18f27b5385240852e537cd5010cedb09f0bf233d">18f27b53</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T11:47:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: make sure we don't contact trusted domains via LDAP as AD DC
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13278
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/55c3af89f1b0baecf5e2d6c2646902edd0684aa8">55c3af89</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T11:47:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: set_dc_type_and_flags() is not needed on a DC
On a DC we load the trusts in the parent in add_trusted_domains_dc()
from our local configuration. There's no need to find out the trust details
via network calls.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13278
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/06601b3a9293db35feda1b033fa864dc1a764164">06601b3a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-23T16:58:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: don't try to do an authenticated SMB connection as AD DC
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13278
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Feb 23 17:58:23 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ad5e7966f555b1d2b39d276646934a2cd2535e6">5ad5e796</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-02-23T21:56:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix possible directory fd leak if the underlying OS doesn't support fdopendir()
HPUX has this problem.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13270
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Feb 23 22:56:35 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3b0a940c39e94f57457fd612721b1296d9752e57">3b0a940c</a></strong>
<div>
<span>by Jamie McClymont</span>
<i>at 2018-02-24T09:54:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Fail testsuite on unknown environment
The status quo was that tests in typo'd/unknown environments would be skipped.
This was a side effect of the mechanism by which samba3 tests were run, which
has now been changed.
For an example of this being a problem in the past, see commit 523bd03f (which
fixes an issue I noticed when reading subunit logs, and which did not fail the
test).
Signed-off-by: Jamie McClymont <jamiemcclymont@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6368af8260ec7dd74349eabb48d1312385e0ad49">6368af82</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-24T09:54:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Authenticate again so make sure we are not locked out
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bc56913271e9d3a30143ef5a45d32430766d9dc3">bc569132</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-24T09:54:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">repl_md: avoid returning LDB_SUCCESS on failure
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0258122535dbe1154a18d787e54728edfb09d10b">02581225</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-24T09:54:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:selftest: Run the smbtorture3 TLDAP test
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/72d780efca5412acf9d6b85f4f26a3974cb9ec2f">72d780ef</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-24T09:54:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:lib:com: Fix function declartions
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1ed693423d7a30c3810ddc1b6f052d376c8cd4e7">1ed69342</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-02-24T14:50:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb tests: fix null test on incorrect variable
Fix up tests that were performing a null check on the wrong variable
after a call to ldb_msg_new
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Feb 24 15:50:35 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be96147e6966ac7b68418e1889e55b38874c1561">be96147e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-24T17:20:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">text/python/blackbox: allow optional message in ProcessError
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a3954adedf89a186268fea272675687524325ff">4a3954ad</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-02-24T17:20:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/blackbox/smbcontrol: ping tests names ping target upon failure
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/106ea7a1bcde3f5aa4fbb4ff8beb0cb44cf0e0ed">106ea7a1</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-02-24T22:19:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Minor cleanup to libnet_join_member
Prevent code duplication by consolidating cleanup task
at the end of the function.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Feb 24 23:19:05 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c5a14306c82f702f4788faea262c9ec6ade584cb">c5a14306</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-02-26T01:32:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_debug: Fix binary data in debug log
When duplicate objects were added, the GUID was printed in the debug log
The GUID was not escaped and therefore displayed as binary content.
This patch splits out the duplicate DN creation error and the duplicate
GIUD error. Duplicate DN's are a normal event and don't require debug
logging.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13185
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a85bcb3f486ae6f473b934bbe920d1733b7f7a4">2a85bcb3</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-02-26T06:29:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_debug tests: Fix binary data in debug log
Tests to ensure:
When duplicate objects are added, the GUID was printed in the debug log
are passed through the escape function.
And that duplicate DN's do not generate debug log entries.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13185
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Feb 26 07:29:49 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/46e6626f73f42c84f254507c3ec2b591e2e732ba">46e6626f</a></strong>
<div>
<span>by Poornima G</span>
<i>at 2018-02-26T19:17:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_glusterfs: Fix the wrong pointer being sent in glfs_fsync_async
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13297
Pair-Programmed-With: Anoop C S <anoopcs@redhat.com>
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Mon Feb 26 20:17:50 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5f4b71d21d5018fe36150b03bc1a0593d4ead747">5f4b71d2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-26T21:30:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Remove "DUMP_EVENT_LIST" message
This was no longer implemented, remove it completely
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/350826868dc81846e0b1086ad5f69506ae2a44f6">35082686</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-02-27T02:23:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Only warn if rpc/rpc.h haven't been found
This is also used by talloc, tevent, etc. Those libs don't need or use
rpc.h
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Feb 27 03:23:37 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d88f826c7b78d84fef87ab1301b266f11b4162fb">d88f826c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-27T08:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsocket: Add "mem_ctx" to socket_create()
Every caller did a talloc_steal() after socket_create(). Just pass in the
correct memory context.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/92580b3f2fb1e23e5bfcc0e8ab19ee02e9ea5958">92580b3f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-27T08:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libdgram: Remove an unused parameter
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ec14fd981c27f9a3ce64922b54252ec5cabbc18">5ec14fd9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-27T08:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libdgram: Remove an unused parameter
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4897f8605622d9acda1996d3c39da6f51fec654e">4897f860</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-27T08:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: Remove some unused parameters
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f604c98ac2be8f86029d4abc350774807f75501a">f604c98a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-27T08:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: Remove a pointless assignment
I don't see how data.msg.dest_name.type is accessed further down
dgram_mailslot_netlogon_reply only accesses packet->src_addr, packet->src_port
and packet->data.msg.source_name, *not* data.msg.dest_name. Also, "packet" is
thrown away after this call.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/724349090c096efe32887a92059aae42232caeab">72434909</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-27T08:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: Factor out dgram sending from reply construction
Separation of concerns. Only one call to dgram_mailslot_netlogon_reply, which
does the UDP send.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/211a6072adb05cb74b1012cbd3637fdfe377c4f2">211a6072</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-27T08:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: Make nbtd_mailslot_netlogon_handler a bit more idiomatic
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7de96133858edee309102976fd7265d6e480e778">7de96133</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-27T08:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: Centralize a consistency check
This is a "should NEVER happen" and applies to both
LOGON_PRIMARY_QUERY and LOGON_SAM_LOGON_REQUEST
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e49e3470783275d00c6c386675ff8ac2c3aa7c24">e49e3470</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-27T08:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: nbtd_netlogon_getdc needs the nbtsrv, not the interface
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d673ca0c350c85bcf0b804690adce5cffa7a5f0b">d673ca0c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-27T08:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: nbtd_netlogon_samlogon needs the nbtsrv, not the inteface
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/28f7a1f754e0939870f2798dfe0e811b42dd83eb">28f7a1f7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-27T08:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: Fix a typo ("domian->domain")
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/33991e5c9086d5d437d1d408be1b54cb55333856">33991e5c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-27T08:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: nbtd_netlogon_getdc needs just the dst_name
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5f9a0903a2ddc10aab4c7f07387ed53d728089c7">5f9a0903</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-27T08:14:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: nbtd_netlogon_samlogon needs the dst_name, not the packet
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/165570192310e3a51c070bbcc3222664e683887f">16557019</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-27T08:14:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: Avoid an "else" branch
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b06eacd59137711728fab17ff3517e7dbb3a5ef">7b06eacd</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-27T08:14:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: Avoid a talloc call
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/39827b7582932baa9d71390096204e5f2f5afb3d">39827b75</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-27T08:14:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: nbtd_netlogon_getdc doesn't need "src"
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4da56e9f049c5aaa9e5573786cc5c490cfbfac96">4da56e9f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-02-27T13:10:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: Factor out packet generation for netlogon reply
This also fixes an inaccuracy (or even a bug?):
The previous code pulled the reply mailslot always through
req.logon.mailslot_name, which is the union for
LOGON_SAM_LOGON_REQUESTs. The LOGON_PRIMARY_QUERY must be referenced by
req.pdc.mailslot_name. It might have worked by chance, but this should
be more correct.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Feb 27 14:10:14 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c9888d4f6f730b8a2c190935e689075ddbf88a0a">c9888d4f</a></strong>
<div>
<span>by Rowland Penny</span>
<i>at 2018-02-27T19:31:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: user setexpiry: Fix incorrect Example2
Signed-off-by: Rowland Penny <rpenny@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Feb 27 20:31:39 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cb58e188008bf920df88dc0212b9f9bb23263179">cb58e188</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-28T03:54:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: version 1.3.2
* Expose the SHOW_BINARY, ENABLE_TRACING and DONT_CREATE_DB flag constants
in the python api.
* Extend dn.is_child_of() test.
* Don't load LDB_MODULESDIR as a module file.
* Fix binary data in debug log (bug #13185).
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Feb 28 04:54:21 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/afd97e72090aaf31b084646b5fcecaeb8cde653d">afd97e72</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-28T13:33:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: disable support for CROSS_ORGANIZATION domains
We don't support selective authentication yet,
so we shouldn't silently allow domain wide authentication
for such a trust.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13299
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/274209f5cd4eec2ffe4ffe12bfbb41eb8ed0c9df">274209f5</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-28T13:33:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:kdc: make use of dsdb_trust_parse_tdo_info() in samba_kdc_trust_message2entry()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13299
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d0a813a173be630c2def93cc55e4514204d265a2">d0a813a1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-28T13:33:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:kdc: only support LSA_TRUST_TYPE_UPLEVEL domains in samba_kdc_trust_message2entry()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13299
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/31b5328c46c5f510ba234f75688886987276ee9e">31b5328c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-02-28T18:45:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:kdc: disable support for CROSS_ORGANIZATION domains
We don't support selective authentication yet,
so we shouldn't silently allow domain wide authentication
for such a trust.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13299
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Feb 28 19:45:13 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f531c951b7bb3661e804f65f662f8fb74e7c21d5">f531c951</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-02-28T22:01:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: convert octal 'O1234' format to python3 compatible '0o1234'
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/15c72e0dd80d37fa5f0af1e52f5f95b0712b6c51">15c72e0d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-02-28T22:01:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba python libs: convert 'O1234' format to python3 compatible '0o1234'
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/efad273122348469d0fd1e0269dd74aa25857504">efad2731</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-02-28T22:01:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python tests: convert oct 'O1234' format to python3 compatible '0o1234'
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/91a5941f173caf3959df24c7702226b0088eeb86">91a5941f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-02-28T22:01:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba python libs: convert 'except X, (tuple)' to 'except X as e'
In addition to converting the except line another line is also added
for each except to extract the tuple contents.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/52729d35495db638c84caa8cc6f5ffdf0b670353">52729d35</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-02-28T22:01:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: convert 'except X, (tuple)' to 'except X as e'
In addition to converting the except line another line is also added
for each except to extract the tuple contents.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0de23d27d6b01f2501d076cc98f48ee72c48d50a">0de23d27</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-02-28T22:01:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba python tests: convert 'except X, (tuple)' to 'except X as e'
In addition to converting the except line another line is also added
for each except to extract the tuple contents.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f61bf115ef27f2a0fdc88304c74698b56653672">9f61bf11</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-02-28T22:01:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">drs torture python: convert 'except X, (tuple)' to 'except X as e'
In addition to converting the except line another line is also added
for each except to extract the tuple contents.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c31d387945ca579b8feb8a18b4aed2f9bcb7de8">0c31d387</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-02-28T22:01:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb python tests: convert 'except X, (tuple)' to 'except X as e'
In addition to converting the except line another line is also added
for each except to extract the tuple contents.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c21d4bc0a13866f47384805e4a8f729b878841e9">c21d4bc0</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-03-01T03:36:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py3compat: add strings describing bytes/unicode in both versions
What Python 3 calls "bytes", Python 2 calls "string";
What Python 3 calls "string", Python 2 calls "unicode".
This can cause confusion in e.g. help strings where the precise type
matters. These macros can be used to construct accurate messages for
both versions.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Thu Mar 1 04:36:15 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d31a8cd800db3862cf7e6935f135705af647b1d0">d31a8cd8</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:lib:com: Fix function declartions
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/76535df3248b7f4e489d1555f27cedd151cd1a50">76535df3</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:texpect: Avoid some compiler warnings
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/05dae361b388e71701a7c646f2787315e9bd5dfb">05dae361</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:replace: Add FALL_THROUGH support
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a5104e6a396ded1c2f603eff5bf8fc89bfe3bb61">a5104e6a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:replace: Add FALL_THROUGH statements in strptime.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2b01bd0475d6cb654f1ffbbc56152bf04d1a793d">2b01bd04</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:ldb: Add FALL_THROUGH statements in common/ldb_dn.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3429e9d9e59706ff2d17989530b67c74f80b879e">3429e9d9</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:ldb: Add FALL_THROUGH statements in ldb_map/ldb_map_inbound.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9d2296e070157ba9d4d4f80714ba8b1ad6691117">9d2296e0</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:ldb: Add FALL_THROUGH statements in ldb_map/ldb_map.c
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7adf497443f40aa381c242e5d72970369b021958">7adf4974</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:ldb: Add FALL_THROUGH statements in ldb_map/ldb_map_outbound.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2683140674fe37f449029870f0a2b6588b10a2b0">26831406</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:param: Add FALL_THROUGH statements in loadparm.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/37c637766eabd1123b259acbb3ae4eeb6b10de4a">37c63776</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Add FALL_THROUGH statements in substitute.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8da568efea444af26c7f63ba73de65c4a9f24e7d">8da568ef</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Add FALL_THROUGH statements in charset/charset_macosxfs.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a3fffd970c38e288476643fbea6cfa1943213b8d">a3fffd97</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Add FALL_THROUGH statements in util_file.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d78d1a71ffa166a95729e273a68e012f2965120e">d78d1a71</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Add FALL_THROUGH statements in substitute_generic.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9fed4562cae3e7e2b528b94176b6063522f332eb">9fed4562</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Add FALL_THROUGH statements in util_path.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/16d14fa86321f30ce2798aa5e4b9be493c267807">16d14fa8</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Add FALL_THROUGH statements in util_str.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/20e3a93c3b5b580abef4b2ab7eccc5f1be5d4b77">20e3a93c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:tdb: Add FALL_THROUGH statements in hash.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bdd1de17109f9f4ed6435851d74b97d19ffe6da1">bdd1de17</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:tdb: Add FALL_THROUGH statements in tdbtool.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/17410725065da5040f9c6eae2383a960b7712156">17410725</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:tdb: Add FALL_THROUGH statements in common/summary.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/721721911595c649b5cb549f19873eb8f07d2590">72172191</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libgpo: Add FALL_THROUGH statements in gpo_sec.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/64c9ca3a3df42dd19e0ed2981d2e1b3cb0990ca4">64c9ca3a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc:ndr: Add FALL_THROUGH statements in ndr_cab.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6744e8c7d4fb9fcb27cf940608118bd28ea2af2e">6744e8c7</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: Add FALL_THROUGH statements in auth_sam.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/03ed979eb0cfa37fb25cbaacc9e7a6fd871a8ec9">03ed979e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: Add FALL_THROUGH statements in pampass.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3f1a4b749d4157d075cd9146ab5d10d5d0e6ceec">3f1a4b74</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Add FALL_THROUGH statements in cbuf.c
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/feeb49f4cfe6260daba1c873d27cd848f063e8bd">feeb49f4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Add FALL_THROUGH statements in sysacls.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3b9aa1c625b0cc5ef55cc74602b6160443691e46">3b9aa1c6</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Add FALL_THROUGH statements in util_sd.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2cc130683e9b885739b4ae7952f1618277100bc2">2cc13068</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: Add FALL_THROUGH statements in dsgetdcname.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4744b777f5143b8956afb29ea2b35a8248c7daf9">4744b777</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: Add FALL_THROUGH statements in vfs_acl_common.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a4623fac64b7471e3dbde5cfca8f9dfa0ec28761">a4623fac</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Add FALL_THROUGH statements in nttrans.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/964b2d4aae5a4700a0e74725e6246f856df248b7">964b2d4a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Add FALL_THROUGH statements in trans2.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/273ef597616dc41620860781fe0e19cc747fe931">273ef597</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Add FALL_THROUGH statements in regedit.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/36315769b87d8de0482cb5090a9ddcda975f3c45">36315769</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Add FALL_THROUGH statements in net_conf.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b946e3480fc964895e1ef9bac340361aa209aa1">7b946e34</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Add FALL_THROUGH statements in net_rpc_conf.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d17cb7cebfa7d4525dca24668a35bd1d26034c42">d17cb7ce</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Add FALL_THROUGH statements in rpc_server.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/94d69cd4b8d9c50908615e152766af3c93011e4a">94d69cd4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:samdb: Add FALL_THROUGH statements in cracknames.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/487bd0a1e94c121daaf98acbb575612db297a520">487bd0a1</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:samdb: Add FALL_THROUGH statements in linked_attributes.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ef3ac405bf436fa6fd7daf20e0c90856dae8237f">ef3ac405</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:auth: Add FALL_THROUGH statements in auth_util.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/69fa5ecb6acaacdc0fbd8942baa3bbba1dabb75a">69fa5ecb</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:auth: Add FALL_THROUGH statements in auth_sam.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e2f1255840b0066c223f1f9caf7a3865fa4021a3">e2f12558</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:auth: Add FALL_THROUGH statements in gensec_krb5.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1508ff9cc45ea7e848e3373f66c83006a5a47d37">1508ff9c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Add FALL_THROUGH statements in dcesrv_srvsvc.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/50d3a9e70d2c5e86d3d26aeb369ebd7a83b60375">50d3a9e7</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Add FALL_THROUGH statements in basic/misc.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/856cda10375e2891d419d5c471df494ddc94976a">856cda10</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Add FALL_THROUGH statements in rpc/spoolss.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d123638a82e14d457572f2d97c0283796b6a1973">d123638a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth:credentials: Add FALL_THROUGH statements in credentials_secrets.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a646a7485eb2e042e7d301b50e418a1aca09b90">2a646a74</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth:gensec: Add FALL_THROUGH statements in spnego.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/00defe71009246703a23edd3cf20292821569a86">00defe71</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Add FALL_THROUGH statements in pam_winbind.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f5d69d7134ef3a9b73a9d2dcecac42e69319548c">f5d69d71</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet: Add FALL_THROUGH statements in libnet_join.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/824fa2c4dbba252cfa778027f0ea7fdfa4fda894">824fa2c4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: Add FALL_THROUGH statements in getdate.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cafe8ac9653a8ca9adbbc72e29fd71bf8c13a2d5">cafe8ac9</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lsa: Add FALL_THROUGH statements in srv_lsa_nt.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3e2e4096ccb9095847874cbbd89be054299d19ae">3e2e4096</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpcclient: Add FALL_THROUGH statements in rpcclient.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/29b5de26df8e562387540ad89b92fc94912ed8a7">29b5de26</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Add FALL_THROUGH statements in reply.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/45153120cb03c7e77a7b88f10679ebc7218519c9">45153120</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Add FALL_THROUGH statements in net_registry_check.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ba0b72fa3c7d131833e9055a00be2530e73ce75">5ba0b72f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Add FALL_THROUGH statements in ntlm_auth.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7619442a79ca0cff0d2edcab7a9bea36913683bf">7619442a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbindd: Add FALL_THROUGH statements in idmap_autorid.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1563f392c838798824bec248221a56125350e45c">1563f392</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:dsdb: Add FALL_THROUGH statements in password_hash.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a31147d675c6d557d2b139263134f8617108ba6c">a31147d6</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:lib: Add FALL_THROUGH statements in http.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d4ccca2d66536a24afe702dbb969a6ab878d914d">d4ccca2d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T03:37:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:spoolss: Remove incorrect fall through comment in srv_spoolss_nt.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1aabfff8a6ecd57ac6475667c2103eb8e3ec6bf3">1aabfff8</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T08:52:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Remove incorrect fall through comment in trusts_util.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Mar 1 09:52:37 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/43ca89b46bc76d10fb9bfda1d4ac7d16cf55b689">43ca89b4</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-01T08:53:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/dbcheck: Provision using the old schema and ignore displayName
These tests are currently not run on Ubuntu due to bashisms in the test.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/79d70d98089e5b3813b645214d7407183c26cb87">79d70d98</a></strong>
<div>
<span>by Timur I. Bakeyev</span>
<i>at 2018-03-01T08:53:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Remove some bashisms from the test scripts
Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ea3a80e66967cab13a664c50ae5f7d23be805e22">ea3a80e6</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-01T08:53:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">domain.py: Give some advice if the schema upgrade command fails
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0cf640a2f401d43421d4d8c244bdb50da8bebd86">0cf640a2</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T08:53:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Update pam_wrapper to version 1.0.5
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a65ea900d48347fbdec253cc5a6dadd613bbada">6a65ea90</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T08:53:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Add missing config.h in libpamtest
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4f76a1deae60f7725f7e4307549de3d097a59236">4f76a1de</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-01T08:53:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Implement forall_children()
Step 0 in removing winbindd_children as a variable: We have access to
all children via our domain list and the two explicit children. There's
no need to separately maintain a list of winbind children. Maintaining
child->pid != 0 is sufficient to make sure we only walk active children.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13309
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/94c02211f92000d84efabac98cc6f3341a49ae76">94c02211</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-01T08:53:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Use forall_children in winbind_child_died()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13309
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/723560aed2082fefdb0f9d27548fda200438bc8a">723560ae</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-01T08:53:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: "internal" children never have a domain set
Look at setup_domain_child(): There we always set child->domain. The only other
two children are the idmap and locator children, which don't have a domain set.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13309
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/815bdc65a2938dc00af2be1931918dbe40394dcb">815bdc65</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-01T08:53:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Remove unused winbindd_internal_child()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13309
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c58fb365a9652544b0fd40b52a79e641933a528">0c58fb36</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-01T08:53:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Use forall_domain_children in winbind_msg_offline()
Note that we only walk the domain children, which all have
child->domain != NULL. So we don't need that check anymore.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13309
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dba9a12e304d305a91c336681a34637bc41ac90b">dba9a12e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-01T08:53:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Use forall_domain_children in winbind_msg_online
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13309
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e6d3a59eb9d526018852ee0a349e64d51eb0f56">0e6d3a59</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-01T08:53:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Use forall_children in winbind_msg_ip_dropped_parent()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13309
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/09677053f7f0e3a6c007a59b9ac08fc159f79c9d">09677053</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-01T08:53:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Use forall_children in reinit_after_fork()
This removes the special handling for idmap_child() after the "This is
a little tricky" comment. I believe this was not required at all, the
idmap_child is part of the winbindd_children list.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13309
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/33f5f5c4610f1a249c2dc88848e4262e2f343c94">33f5f5c4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-01T08:53:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Remove the "winbindd_children" global
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13309
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/49adb5ac8fed5ec972bf3907169d2efd378970ca">49adb5ac</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-01T08:53:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Fix a race between the sigchld and 0-sized socket read
Fix a bug when a child dies when a request is pending in the child. If the
signal handler fires before epoll finds out the other end of the parent-child
socket is closed, we close the socket on our side without taking care of the
pending request. This causes two problems: First, that one pending request
never is replied to properly, and secondly, we might end up with EPOLL_DEL on a
wrong file descriptor. This causes all sorts of trouble if we hit an active
one.
The fix for this problem is not to close the socket in winbind_child_died().
This however stops an idle child that dies hard from being properly cleaned up.
The fix for that is to add the child->monitor_fde that is set pending only when
no child request is active. This way we can remove the close(sock) in the
signal handler.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13309
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c38062604b7884fa97e63ad28ed2f2a86880d022">c3806260</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-01T13:48:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Fix --ping-dc error handling
If the child dies at the wrong moment, we get an error in the "req" itself.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13309
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Mar 1 14:48:19 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a971bcd0799763966be6c3f1350130140e436e2">9a971bcd</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T13:49:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth:credentials: Add FALL_THROUGH statements in credentials.c
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/654a66b72dcf99884dafcf3659f513b634073da8">654a66b7</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T13:49:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth:credentials: Avoid an 'else' branch
This moves the 'return' statement to the end of the 'case' and makes clear
we leave here.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/33fa6778e1d95c41733c43b2b694cd22d440e4c6">33fa6778</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T18:38:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Build with -Wimplicit-fallthrough if supported
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Mar 1 19:38:12 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1e18edc76ad53c734be1db2983e9ee7c23feebd3">1e18edc7</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-packaging: Make the ctdb package own more directories
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/61a0ae91611fef66cea4009a950736d3bc522961">61a0ae91</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-packaging: Package event scripts via a wildcard
This avoids churn as event scripts are renamed and moved about.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0519c513adc7c6f024c50facfb8a963fedd3e1b7">0519c513</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Do not use ctdb_service_reconfigure() for policy routing
This is an unconditional reconfiguration so skip the unnecessary
logic.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c8dfd4fe5a5ef8a368406d2afef58cbf8f162ca5">c8dfd4fe</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Add default for public addresses file where missing
This makes it consistent with the rest of the script code.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1c2361a5f736bb14fa809a7071b1ebf08f560f8d">1c2361a5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Fix a double-typo bug
Amazingly, the code actually works! Understanding why is homework for
real shell experts, who are not necessarily created ==!
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bb03532cdd5df62cd70d4e8402745f1dbfbfeaaa">bb03532c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use consistent NAT gateway nodes file
Using a different file each time causes the event script to believe
that the configuration has changed even though only the node states
have changed. Change this to stop the tests from doing something
unexpected.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5537b36817925cb00ef142d5c7a17f5336133eed">5537b368</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop unneccessary unset of variable
The comment is incorrect. This is only set when running simple tests
on local daemons.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99350c18aadb0345051f9a21111da1cae3eabe55">99350c18</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Clean up PATH setting for stubs/ subdirectory
Drop unnecessary PATH setting in rc.local. The functions file no
longer sets PATH so setting it here is unnecessary. Fix a comment
referencing this PATH setting.
Given EVENTSCRIPTS_PATH is no longer used, use a more obvious variable
name and fail on missing stubs/ subdirectory.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e0e6e40d17da94d0e8688c01701d222f72343aac">e0e6e40d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Check for errors when adding stubs/ subdirectory to PATH
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/86f6481e996bb65cd71f7a946aec4964c89599d5">86f6481e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid creating files in /tmp.
Temporary test data should all go somewhere under TEST_VAR_DIR instead
of in the global /tmp. The existing mktemp could be changed so the
data goes into the test directory but mktemp is overkill in this case.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ca315203beab08649993285d0bf6b7a29b542887">ca315203</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Drop debugging variable CTDB_EXTERNAL_TRACE
This was an attempt to debug an unexpected situation. It never
triggered, so delete it and all supporting code.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9260ca217fd58903f924bba48515365f2f2228df">9260ca21</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Change onnode to use ONNODE_SSH and ONNODE_SSH_OPTS
Instead of more generic SSH and EXTRA_SSH_OPTS.
Quietly drop reference to rsh in case it gives anyone ideas.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/248c37413756c582f50b820fafb03d59fa2e0f99">248c3741</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Introduce a variable to hold the ssh command
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/254a18422c567a591d7e99ff6d1d0678d985c5fa">254a1842</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Revisit stray file descriptor avoidance in onnode
Commit 635da189dccef6516d490c228407b9987986c578 fixed a problem where
a stray file descriptor leaked into a subshell.
Explicitly close the file descriptor at the outermost possible point
rather than relying on fakessh() to do it.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d1ff94686ab7541827f9b8e0e40899d5cf5a4c83">d1ff9468</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add fake ssh command for local daemons tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53fea36b6e2dd8b44bbe6e011208cabfd21d1a58">53fea36b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use fake ssh script for onnode in local daemons tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8f9ac941902c587b9920e1ff4be77d6d4e3bbe4b">8f9ac941</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Remove test hooks from onnode
CTDB_NODES_SOCKETS is no longer used. The test code uses ONNODE_SSH
to run a fake ssh client.
Leave indenting sloppy and fix it in the next commit so that this
change is clear.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a12d6af0553207809ad1e882df25fbcb00c22a2">9a12d6af</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Reindent parts of onnode
No functional changes. Best viewed with diff/show -w to avoid
whitespace differences.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2ad1604c2baa547ad881dc75cbb47722d0af651b">2ad1604c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Avoid no-op "ctdb ptrans" call
This causes unnecessary g_lock activity and overhead.
This could be optimised in ctdb.c:control_ptrans(). However, that
makes the code more complex. Let's only do that if we get more
potentially no-op uses.
Note no optimisation is needed in the "notify" case because there is
already an early exit if there are no items.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/11c4bb110bad2a2ca213f1703a5a1408705ae0d8">11c4bb11</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Exit on statd-callout sub-test failure
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/95888c8e1a491ef58333714fe545d5651d05cc1a">95888c8e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Clean up statd-callout
This means there will be 2 loops reading the data but the code flow is
much more obvious.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4bb8a6222a7b24c8877aa8a799d6b10187f8259f">4bb8a622</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-01T18:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Generalise SM_NOTIFY output format in statd-callout tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/426e4a5a20cff73a80d80b46f15826deac3f934f">426e4a5a</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-01T23:38:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-pmda: Use modified API in pcp library 4.0
Support backward compatibility by checking for __pmID_int type, which
was previously in <pcp/impl.h>. In the new version, this type is not
defined anymore and there is no need to include <pcp/impl.h>.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Mar 2 00:38:52 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b67ffaf518c971817b167b41bf6226cddfdcfd2f">b67ffaf5</a></strong>
<div>
<span>by Dan Robertson</span>
<i>at 2018-03-01T23:39:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Use smb2 tcon if conn_protocol >= SMB2_02
When the connection protocol is SMB2 the tid from the smb1 member is
used instead of smb2 in cli_state_set_tid which often results in a null
deref.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13310
Signed-off-by: Dan Robertson <drobertson@tripwire.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a89a7146563f2d9eb8bc02f1c090158ee499c878">a89a7146</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-01T23:39:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Do not crash if we fail to init the session table
This should the following segfault with SMB1:
#6 sig_fault (sig=<optimized out>) at ../lib/util/fault.c:94
#7 <signal handler called>
#8 smbXsrv_session_create (conn=conn@entry=0x5654d3512af0, now=now@entry=131594481900356690, _session=_session@entry=0x7ffc93a778e8)
at ../source3/smbd/smbXsrv_session.c:1212
#9 0x00007f7618aa21ef in reply_sesssetup_and_X (req=req@entry=0x5654d35174b0) at ../source3/smbd/sesssetup.c:961
#10 0x00007f7618ae17b0 in switch_message (type=<optimized out>, req=req@entry=0x5654d35174b0) at ../source3/smbd/process.c:1726
#11 0x00007f7618ae3550 in construct_reply (deferred_pcd=0x0, encrypted=false, seqnum=0, unread_bytes=0, size=140, inbuf=0x0, xconn=0x5654d35146d0)
at ../source3/smbd/process.c:1762
#12 process_smb (xconn=xconn@entry=0x5654d3512af0, inbuf=<optimized out>, nread=140, unread_bytes=0, seqnum=0, encrypted=<optimized out>,
deferred_pcd=deferred_pcd@entry=0x0) at ../source3/smbd/process.c:2008
#13 0x00007f7618ae4c41 in smbd_server_connection_read_handler (xconn=0x5654d3512af0, fd=40) at ../source3/smbd/process.c:2608
#14 0x00007f761587eedb in epoll_event_loop_once () from /lib64/libtevent.so.0
Inspection the core shows that:
conn->client-session_table is NULL
conn->protocol is PROTOCOL_NONE
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13315
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f59f6cefa11c4866d2ede47d9c9b415e3d5e233d">f59f6cef</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-02T04:49:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: fix wbinfo -m --verbose trust type "Local"
Remove wrong "Local" strcmp(), there's another one, the correct one, a few lines
below. Since commit 95e3307917b5731ab883ee5fce530c5b559b4934
WBC_DOMINFO_TRUSTTYPE_NONE, which corresponded to the string "None" in the
winbindd response, is not used anymore.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13313
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Mar 2 05:49:18 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f3b650fc75b8edb27a852b88f469e8cd4a317f99">f3b650fc</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-03-02T09:49:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix autobuild for user names starting with c
This is similar to the fix from commit 0b1ba00: Now commit 475a7616 introduced
tests that create user names in the form DOMAIN\USER and pass them through
shell functions. There "echo" is used to print he username, resulting in
/bin/dash on sn-devel to interpret e.g. \c which skips any further output. The
result are test exceptions like:
failure: samba4.blackbox.trust_ntlm.Test01 rpcclient lookupnames with LOCALADMEMBER\cs(ad_member:local) [
Exception: Exception: LOCALADMEMBER
]
time: 2018-02-26 23:00:46.688800Z
Fix this by replacing the echo with printf %s. This surfaced for
test_rpcclient_grep, but apply the same change to all functions in
common_test_fns.inc for consistency.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Fri Mar 2 10:49:09 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ea893be35a909c35d5a977a5abd76cb48e24eed6">ea893be3</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-02T13:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">util: Fix the logic in ms_fnmatch_protocol()
Make sure we always pass a valid max_n pointer to ms_fnmatch_core().
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba6a82570abcde912712eb2830aed4eef4fbf491">ba6a8257</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-03-02T13:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add basic ms_fnmatch unit test
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Signed-off-by: David Disseldorp <ddiss@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2dd94e41f6e76b4cbbeb1704778a8c27b6eb35f4">2dd94e41</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T13:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: ads_get_dnshostname & ads_get_samaccountname don't use param
Both ads_get_dnshostname() & ads_get_samaccountname() are passed
a param machinename as a argument. Instead of using 'machinename' these
functions are erroneously using lp_netbiosname() instead.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d9593803eadb9a3d4ee4448a2b39ffdd056b68af">d9593803</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T13:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Clean up code a little rename 'ads_get_samaccountname()'
Function 'ads_get_samaccountname()' basically returns the machine_name passed
as an input param (appended with '$') if it exists on the ad. The function
really is testing for the existence of the samaccountname and is not really
'getting' it. This is also the way it is used. Renaming this function to
'ads_has_samaccountname()' better reflects what it is actually doing and how
clients calling the code use it. It also makes the client code using calling
this function less confusing.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cf0823fb9ee169efd6b268709c955db674e0cdbb">cf0823fb</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T13:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Add a basic Windows SPN parser.
(see https://social.technet.microsoft.com/wiki/contents/articles/717.service-principal-names-spns-setspn-syntax-setspn-exe.aspx)
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1400ab709e37e02f1d108f46779d49ba895ba8b1">1400ab70</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T13:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: change ads_add_service_principal_name implementation
Previously the function 'ads_add_service_principal_name' created
the SPNs based on the machine_name and dns name passed to the function.
In order to prepare for a future patch that will also need to write
SPN(s) to the AD computer account, the function implementation will
need to be changed. Instead of the function creating the SPN(s) it
will now take the list SPN(s) to write to the AD 'machine_name' account
as an input param instead.
The name of the function has been changed to
'ads_add_service_principal_names' to reflect this. Additionally client
code now needs to construct the SPNs to be passed into the function.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65ef044b8dba40e118446a0c700cffcf9bd81330">65ef044b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T13:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: add new 'net ads setspn list' subcommand
This patch adds basic functionality not unlike the setspn.exe
command that is provided by windows for adminsistering SPN on
the AD. (see https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2012-R2-and-2012/cc731241(v=ws.11)
Only the basic list operation (that corresponds to the -l
switch for setspn.exe is implemented)
Usage:
net ads setspn list <computer>
Note: <computer> is optional, if not specified the computer account
associated with value returned by lp_netbios_name() is used instead.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8a6c3c5ae2cab809d994821ed573315ba0c7562d">8a6c3c5a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T13:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: add new 'net ads setspn add' subcommand
This patch adds 'add' to the 'net ads setspn' subcommand
(see https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2012-R2-and-2012/cc731241(v=ws.11)
Usage:
net ads setspn add <computer> <SPN>
Note: <computer> is optional, if not specified the computer account
associated with value returned by lp_netbios_name() is used instead.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5fa82263ad6bc82c9a8b34797df35bd800b7f11f">5fa82263</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T13:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: add new 'net ads setspn delete' subcommand
This patch adds 'delete' to the 'net ads setspn' subcommand
(see https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2012-R2-and-2012/cc731241(v=ws.11)
Usage:
net ads setspn delete <computer> <SPN>
Note: <computer> is optional, if not specified the computer account
associated with value returned by lp_netbios_name() is used instead.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/21889ca21ce483ef53210273a212466882855181">21889ca2</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T13:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprocs/blackbox: Add tests for net ads setspn (add|delete|list)
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/efabfb1c17b02c2e567e8e351e52aa8ba69d7c34">efabfb1c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T13:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Allow 'net ads keytab add' handle Windows SPN(s) part 1
This patch addresses how the windows SPN is converted into a kerberos
priniciple to be written to the keytab file. A followup patch will
deal with writing Window SPN(s) to the AD.
Before this change 'net ads keytab add' handled three scenarios
a) 'net ads keytab add param' is passed a fully qualified kerberos principal
(identified by the presence of '@' in param) In this scenario the keytab
file alone is updated with the principal contained in 'param'.
b) 'net ads keytab add param'; is passed a machine name (identified by
the paramater ending with '$'). In this case the machine name
is converted to a kerberos principal with according to the recipe
'param@realm' where realm is determined by lp_realm().
c) 'net ads keytab add param' is passed a service (e.g. nfs, http etc.)
In this scenario the param containing the service is first converted to
into 2 kerberos principals (long and short forms) according to the
following recipe
i) long form: 'param/fully_qualified_dns@realm'
ii) short form: 'param/netbios_name@realm'
where 'fully_qualified_dns is retrieved from 'dNSHostName' attribute of
'this' machines computer account on the AD.
The principals are written to the keytab file
Secondly 2 windows SPNs are generated from 'param' as follows
i) long form 'param/full_qualified_dns'
ii) short form 'param/netbios_name'
These SPNs are written to the AD computer account object
After this change a) & b) & c) will retain legacy behaviour except
in the case of c) where if the 'param' passed to c) is a Windows SPN
(e.g. conforming to format 'serviceclass/host:port'
i) 'param' will get converted to a kerberos principal (just a single one)
with the following recipe: 'serviceclass/host@realm' which will
be written to the keytab file. The SPN written to the AD is created
as before and the legacy behaviour is preserved.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6cac9a4720713592ba9d0a88c39e331ec42baef4">6cac9a47</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T13:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Allow 'net ads keytab add' handle Windows SPN(s) part 2
This patch addresses how the windows SPN is written to the AD.
If a legacy service (e.g. cifs, http etc.) is passed as param to
'net ads keytab add param' then windows SPNs are generated from
'param' as follows
i) long form 'param/full_qualified_dns'
ii) short form 'param/netbios_name'
If the SPN is a is a Windows SPN (e.g. conforming to format
'serviceclass/host:port') then this is the SPN that is passed to
the AD.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53190e9a0f28b55325090fd6bb12dbfdef1fe6cd">53190e9a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T13:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs:: Add blackbox tests for 'net ads keytab add'
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e518ecdda040e1aa47506e436255597437a05ed">4e518ecd</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T13:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: add param to prevent writing spn(s) to ads
'net ads keytab add' currently in addition to adding to the
keytab file this command also can update AD computer objects
via ldap. This behaviour isn't very intuitive or expected given
the command name. By default we shouldn't write to the ADS.
Prepare to change the default behaviour by modifying the function
'ads_keytab_add_entry' to take a paramater to modify the existing
behaviour to optionally update the AD (or not).
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5adb29f242dde67865017ec8d45852a1fa290ebf">5adb29f2</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T13:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Modify default behaviour of 'net ads keytab add'
This change modifies the behaviour of 'net ads keytab add' such
that only the keytab file is modified.
A new command 'net ads keytab add_update_ads' has been added that
preserves the legacy behaviour which can update the AD computer
object with Winows SPN(s) as appropriate. Alternatively the new
command 'net ads setspn add' can be used to manually add the
windows SPN(s) that previously would have been added.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/284f5508a9563341817291aabf2640d05c2e8594">284f5508</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T13:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs: Switch expected failure tests to expected pass
Following the commit to change the behaviour of 'net ads keytab add' and
new 'keytab add_update_ads' some tests previously failing should now
pass.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0af66455ef87626b97689d75d17782d95455b55e">0af66455</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T13:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: 'net ads keytab create' shouldn't write SPN(s)
Modify default behaviour of 'net ads keytab create'
The change modifies the behaviour of 'net ads keytab create' such
that only the keytab file is modified. The current behaviour doesn't
make sense, existing SPN(s) pulled from the computer AD object have
the format 'serviceclass/host:port/servicename'.
'ads_keytab_create_default' calls ads_keytab_add_entry passing
'serviceclass' for each SPN retrieved from the AD. For each
serviceclass passed in a new pair of SPN(s) is generated as follows
i) long form 'param/full_qualified_dns'
ii) short form 'param/netbios_name'
This doesn't make sense as we are creating a new SPN(s) from an existing
one probably replacing the existing host with the 'client' machine.
If the keytab file exists then additionally each kerberos principal in the
keytab file is parsed to strip out the primary, then 'ads_keytab_add_entry'
is called which then tries by default to generate a SPN from any primary
that doesn't end in '$'. By default those SPNs are then added to the AD
computer account for the client running the command.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ebe9a86eadca37313dd85d9b317197bb7fa2b7e5">ebe9a86e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T13:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs: 'net ads keytab create' expected failures should now pass
Following the commit to change the behaviour of 'net ads keytab create'
some tests previously failing should now pass.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f542749acde5be0d2e77e05bec2c5b112c5ef282">f542749a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T13:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Add manpage for 'net ads keytab' subcommand
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0a19e8b467982b04f68b6ad0525ab20a5a29b7b3">0a19e8b4</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T13:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Add manpage for new 'net ads setspn' subcommand
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6ba2426089f6711ea058ecb9ace07cc057e671b6">6ba24260</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-02T18:12:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add info for 'net ads keytab' and 'net ads setspn' changes
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Mar 2 19:12:08 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/14f83ff83589e8f43cbd47a4115c2e9afcf4d5cb">14f83ff8</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-03-02T18:13:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Zero libnet_LookupName out struct before using
Zero libnet_LookupName out struct before setting results,
preventing false result interpretation.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6d0b6e937a55c55797f1d1136c3f75d27d6fa0d3">6d0b6e93</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-03-02T18:13:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Minor cleanup of libnet_LookupName_recv
Reduce indentation level and comply with 80 column rule.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e01d7d9d0f76b5624bc10d94965fad8f22b4ea7b">e01d7d9d</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-03-02T23:00:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Replace NT_STATUS_HAVE_NO_MEMORY macro
Replaced NT_STATUS_HAVE_NO_MEMORY macro and fixed
memory leaking error-path.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Sat Mar 3 00:00:34 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c5857f10020db35fee051485b96dfc7d579e7ed5">c5857f10</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-02T23:01:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:tests: Skip smbd error test if we do not log to stdout
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlet <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/782358a7621840a2e4a8d6b93e35dbbc279f8433">782358a7</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-02T23:01:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs: Return the correct error status code
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlet <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ffb836f3feb25861ab3fadc42b0fc2603468015c">ffb836f3</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-03T04:19:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Impove test names for samba.wbinfo_simple
This simplifies selecting a specific test to run.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlet <abartlet@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Sat Mar 3 05:19:38 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0bfbcdb69155315415867cee34d5293b1ee125fa">0bfbcdb6</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-03-03T04:20:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Add support for an option to restrict the key length
Allow the setting of the maximum key length, this allows the testing of
index key truncation code. Index key truncation is required to allow
the samba indexing scheme to be used with backends that enforce a
maximum key length.
This will allow emulation of a length-limited key DB for testing.
This is a testing-only feature, as the index format changes
based on this value.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c1504b94d1417894176811f18c5d450de22cfd2">5c1504b9</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-03-03T04:20:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Do not fail in GUID index mode if there is a duplicate attribute
It is not the job of the index code to enforce this, but do give a
a warning given it has been detected.
However, now that we do allow it, we must never return the same
object twice to the caller, so filter for it in ltdb_index_filter().
The GUID list is sorted, which makes this cheap to handle, thankfully.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0918068997d7d8fdfe0c2e0cb1a9836479839fb6">09180689</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-03-03T04:20:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Cope with key truncation
Modify the indexing code to handle a maximum key length, index keys
greater than the maximum length will be truncated to the maximum length.
And the unuque index code has been altered to handle multiple records
for the same index key.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d86a0895aab42323e3455b33eb849198b0f7b49">1d86a089</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-03-03T04:20:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Do not give the warning of duplicate attributes in truncation
In the truncation case a duplicate is perfectly expected.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ee74d4bb8052bf22dcc3b30abb2493ac9a3237a4">ee74d4bb</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-03-03T04:20:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Refuse to store a value in a unique index that is too long
Rather than add many special cases, over-long unique values are simply banned.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a4fd23407da70a7b279a24fca8a6f037e66a477">9a4fd234</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-03-03T04:20:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Combine identical not GUID index and special DN cases
Fold together two identical cases to simplify the code.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c0c888b571d4c21ab267024178353925a8c087c">4c0c888b</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-03-03T08:58:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Add tests for truncated index keys
Tests for the index truncation code as well as the GUID index
format in general.
Covers truncation of both the DN and equality search keys.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Mar 3 09:58:40 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ffcc3671cc238b19636e74d3e3ea71fa59a51b16">ffcc3671</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-03-05T00:33:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/smbcontrol: reduce ping test false positive rate
The ping test was failing when a transient ldap_server process died
between the time it was listed and the time it was pinged. We stop
treating that as failure.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Mar 5 01:33:46 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/db4d72d21c263dc50851dc9b36ee0de61ee5fef2">db4d72d2</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-05T15:01:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Directly return an error and do not fall through
Detected by -Wimplicit-fallthrough.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlet <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b4aa16b9edbd9fee9ec2e9cc9c925fbeb7281921">b4aa16b9</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-03-05T15:01:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/pmda: fix num_recoveries metric store
The num_recoveries metric is declared as PM_TYPE_U32, so should be
used accordingly.
Suggested-by: Nathan Scott <nathans@redhat.com>
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c59d5e11967b9b0afb16fcffc023c1437bf9ad21">c59d5e11</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-03-05T19:49:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: fix standalone ctdb build --with-systemd
For standalone ctdb builds, a samba-util-core dependency is added,
without corresponding systemd libraries, which are needed when
become_daemon.c is built --with-systemd. This results in:
default/lib/util/become_daemon_20.o: In function `daemon_status':
become_daemon.c:(.text+0x456): undefined reference to `sd_notifyf'
collect2: error: ld returned 1 exit status
Fix this by moving the systemd library dependencies from samba-util to
samba-util-core, the become_daemon.c base build target.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Mar 5 20:49:51 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1265346f6c8ada27f2f0cf29a4f21a457fb6af00">1265346f</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-05T19:50:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">partition: Use a transaction to write and a read lock to read the LDB_METADATA_SEQ_NUM
This is critical as otherwise we can read a sequence number in advance
of the data that it represents and so have a false cache.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8caf84a8d4c4454941c163b7ecd9a2e65060526c">8caf84a8</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-05T19:50:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">schema: Do not read different schema sequence values during a read transaction
During a read lock, we find ourselves seeing an unchanged schema, but
reading any updates to the metadata.tdb (in the case of lmdb, where
reads do not block writes).
The alternative is to read-lock the entire metadata.tdb, however, this
allows more concurrency by allowing reads not to block writes.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/242cf337e9e9d72f8c919d0772fd5e35fb2422dc">242cf337</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-05T19:50:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">partition: Leave metadata.tdb unlocking until last
With the lmdb patches, I have cleanly observed the database being read
in between the commit of the metadata.tdb and the eventual commits of
the individual partitions.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c4c64ff51f7ee6a332f71f093ffd37e06745e785">c4c64ff5</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-03-05T19:50:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mod_op_test: Fix core dump on ldb_case_attrs_index_test_teardown
With no schema syntax, this would occasionally crash as it dereferenced
some possibly NULL sequence of memory.
Note: Removing all tests except this one, made it crash reliably.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bca8ac0296b9049fcc126bd775eace265ecc1ced">bca8ac02</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-03-05T19:50:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">remove_dc.py: Abort transaction before throwing an exception
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/313b0c60f482c8fef45dcafba5d8dc6c2e29b461">313b0c60</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-05T19:50:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">schema_set: Add a missing newline between functions
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8ac1646e92d707705c94bc286c17f1cd0d5505fb">8ac1646e</a></strong>
<div>
<span>by Bob Campbell</span>
<i>at 2018-03-05T19:50:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samdb/schema_load: do schema loading with one search
It appears that there was a race condition between searching for the
attribute & class definitions, and searching for the schema object, if
the schema was changed in-between the two searches.
This is likely the cause of ldap_schema being flapping.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12889
Signed-off-by: Bob Campbell <bobcampbell@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a0e0227383612c5c13c1b6e67afff274ffd4571">2a0e0227</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-05T19:50:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: The schema should be reloaded during the transaction
Reload the schema just after getting the tranaction lock
but before the transaction counter is bumped.
This ensures we reload the schema exactly once but with
the DB locked.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c8f00aaba3532ea8055144a882d8fab49f56a8e">9c8f00aa</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-05T19:50:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Begin abstracting out the base key value operations
This will allow us to change the backend from tdb to lmdb.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e33fb2c63302b300f9175711b5d615eae58850d1">e33fb2c6</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-05T19:50:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Replace exists, name and error_map with key value ops
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/448101a3fd7375148d1a79a615477ac32b04f3fb">448101a3</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-05T19:50:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Replace tdb transaction code with generic key value ones
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e21a476c278f3963a1dd4ec7ad272e3fa3b09b40">e21a476c</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-05T19:50:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Add lock_read and unlock_read to key value ops
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c66a0054fb99b6519344c11954417d6615e1310b">c66a0054</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-05T19:50:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Remove tdb_get_seqnum and use a generic 'has_changed'
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/141148edd34c587f4e0f5b992d71201ade541d70">141148ed</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-03-05T19:50:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Add errorstr to the key value ops
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/68423e9f4a62fb4835c0e0c4a09a656aa02ffa10">68423e9f</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-05T19:50:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: factor out the (to be) common init code
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c9f2ff275b69bcd13ae236ae07dee8bce0a4e4a2">c9f2ff27</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-05T19:50:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Use key value ops for fetch command
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4d5180e45c58dc68f8d5dca09c4a87b6830468af">4d5180e4</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-05T19:50:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Implement a traversal function in key value ops
This can handle both read-only and writable traverses.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e3d364a99b98498b131452e739cedf8ce5a773da">e3d364a9</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-05T19:50:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">partition: Allow a different backend store from @PARTITION
By default, use tdb, but otherwise read the value from backendStore.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4014499b128cab567a3b27e31ce4ee86e58be4f7">4014499b</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-06T00:39:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Build a key value operation library
This allows sharing of the originally ldb_tdb operations to the new
ldb_mdb backend.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Mar 6 01:39:16 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0009a12b1f4798b4c83cd36efdede8db0ba7b790">0009a12b</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-03-06T22:30:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Remove python warning in tests/python/index.py
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b8f540b8d2132d9151fae4a3f2d6394fe8028ef">7b8f540b</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-03-06T22:30:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Change name to sam.ldb to align with new partition module assumptions
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87708c3f91fbcbe224d2a71119a420b59c6e950e">87708c3f</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-03-06T22:30:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mod_op_test: Add new nested transactions test
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f625f9b27b229f74a88dfe6d86fadd060c47160">7f625f9b</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-03-07T03:38:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mod_op_test: Make sure that closing the database frees locks
Without the destructor firing, this test used to pass, but now we show
that we must be able to open a new ldb handle.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Mar 7 04:38:02 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e9059c7b40069cfb036bfb95958b78c6a2c800e4">e9059c7b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-07T22:11:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs_fruit. Ensure we only return one set of the 'virtual' UNIX ACE entries.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/019a1bc4caf3439adcaac48b384e86d84a1ad383">019a1bc4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-07T22:11:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs_fruit: Ensure we operate on a copy of the incoming security descriptor.
This will allow us to modify it in the next commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8edad37e476295e25932778721d8ef33713f6853">8edad37e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-07T22:11:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs_fruit. If the security descriptor was modified, ensure we set the flags correctly to reflect the ACE's left.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e0b147f650fe59f606d1faffe57059e6e9d7837b">e0b147f6</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-08T03:09:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs_fruit. Change check_ms_nfs() to remove the virtual ACE's generated by fruit_fget_nt_acl().
Ensures they don't get stored in the underlying ACL.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Mar 8 04:09:38 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f0bebcc4e046ee668c83030c432f99586a17207c">f0bebcc4</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-08T13:14:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Remove unnecessary call to tdb_get_seqnum
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Mar 8 14:14:37 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f70164d65958956c689f0e2ee3bdd0c7634c146f">f70164d6</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-09T06:08:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-ib: Avoid fall through case statements
This is clearly unintended. Noticed with gcc 7.3.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/376e9794e2d19e8d17b0bdde36ce8a1a205986c6">376e9794</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-09T06:08:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-client: Client code should never free the client context
This should never have been done.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/35cc786d1083cba944b91775982c6a403fe8be20">35cc786d</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-09T06:08:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Wait for ctdb daemon to go away in shutdown
This can only be done on the local node. For remote node, exit as
soon as the control returns.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/efe3a7279ee43d1bd774b7ca22ec14dc233b9c97">efe3a727</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-09T06:08:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Drop ipiface command from ctdb tool
This command is not used anywhere and also does not work for IPv6
addresses.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53c550d894de660f20336c78bee42db7a52024d0">53c550d8</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-09T06:08:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Drop unused function ctdb_sys_find_ifname()
The ioctl SIOCGIFCONF does not return IPv6 addresses, so this function
does not work for IPv6 addresses.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8053f652cd987b3911f8871bcff2f4146527d27e">8053f652</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-09T06:08:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Event script commands cannot be run without daemon
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba7123021a3c6a707480614e621d1a1c7082ed9f">ba712302</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-09T06:08:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Fix documentation for ctdb ping command
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/208996134632cfa99654238a089849fc19ddca52">20899613</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Move script state to its own directory
Don't use the same directory as temporary databases.
Make associated test consistent.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fac6d23d2758428cefdabb8bb07bd83cd76deace">fac6d23d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Factor out function ctdb_setup_state_dir()
This allows state directories for scripts other than services.
ctdb_setup_state_dir() takes 2 mandatory arguments.
Unlike ctdb_setup_service_state_dir(), this does not print the
directory name but sets a global variable. The intention is to go
back to a more sensible style of usage.
This will require a shellcheck directive before the first use, such
as:
# Set by ctdb_setup_state_dir
# shellcheck disable=SC2154
foo="${script_state_dir}/bar"
An alternative would be something like the following, which tricks
shellcheck into believing the variable is set:
ctdb_setup_state_dir "service" "foo"
# Shellcheck
script_state_dir="$script_state_dir"
However, this is more cryptic.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eed0e3f6d7a4403a14a659b308267e04aee67623">eed0e3f6</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Use ctdb_setup_state_dir()
Replace all uses of ctdb_setup_service_state_dir() by
ctdb_setup_state_dir().
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ef0962acf0d214ec6ef50d3195494773f4f14107">ef0962ac</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop unused function ctdb_setup_service_state_dir()
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e6aae12ba2b9218d8ca89b3b3c73905f9dba22b9">e6aae12b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Move the reconfigure flag to the script state directory
Scripts that use these functions must call ctdb_setup_state_dir().
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bcadab714987b375b3ab4379bef23514e12ad24f">bcadab71</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Move failure counters to the service state directory
Scripts that use these counters must call ctdb_setup_state_dir().
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b416ed72d43242432a0a151ec5cb5c3509e33a43">b416ed72</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Simplify the names of NFS fail counter files
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5a99835c386d34d995c82aa491fae87995ead7db">5a99835c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-packaging: Use RPM's local state directory
Instead of fixed /var.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/914c877860ecc19f4375eab031fdd2a33bd6ded6">914c8778</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Rework simple tests daemon start/stop
Separate stopping and starting of daemons during restart
This allows actions to be taken after stopping and allows the init
testcase to be clearer about what it is doing.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a821306ec33076afc61195da2c022fe6f5f05a5a">a821306e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop broken wrapper code that uses PID
The code has been broken since commit
4b652c1527afe7eff4075c95946abfa114d74015.
If ctdbd isn't all the way up in time just make a basic attempt to
shut it down.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf250fe5957581adda60d2f9ae2014dd556e92b4">bf250fe5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop unnecessary complexity from wrapper
All of this logic was necessary when ctdbd did poor PID file and
socket handling. Those things are now solid, so remove this
unnecessary logic.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9fe85f4cc935313af6b65f80c7fbfc9d7ebc3916">9fe85f4c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-packaging: Package up relevant /var subdirectories
They're already created at installation time. This way they don't
need to be created at startup.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e5d537323bfb7aabbd6ba6919d30c8fdce003b7">0e5d5373</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Don't create directory for PID file
This is already created by installation and/or packaging.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a2c6c98302ea5630a18c4aa296a0a57b303e7c88">a2c6c983</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop init script PID directory backward compatibility
This tries to be backward compatible with very old versions of CTDB,
so don't bother.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a5473854f28b6fbe6e0c269fca752c7e7fff2dc">6a547385</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Provide default location for ctdbd PID file
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b0d892b9ad7491ae6d3c897b6a224a0e697b0c30">b0d892b9</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: CTDB_PIDFILE environment variable overrides default
Use environment variables for test-only options.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/52cdb03c65504534043311a5afbc43a51ba672af">52cdb03c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop PID file argument from wrapper
Use the default compile-time PID file.
Use a CTDB_PIDFILE environment variable when testing.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b1c87b26090fd357da1f0bce3ede025d03ffb96a">b1c87b26</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Factor out setup of fake CTDB_BASE
Several test suites need the CTDB_BASE directory to contain a subset
of the regular contents of that subdirectory. In some cases there are
symbolic links in the test directory (or a subdirectory) and these
symbolic links need to be fixed at installation time.
Instead, add new function setup_ctdb_base() to set CTDB_BASE, create
the directory and populate it as specified. This relies on
script_install_paths.sh so it can copy the specified targets. It also
copies any files from the test directory's etc-ctdb/ subdirectory.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/258e1e04ae43a50ffd16e17153c8b0a20b21c481">258e1e04</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use setup_ctdb_base() for eventscript unit tests
There is currently a directory of symlinks that are copied during test
setup. These symlinks are updated during installation so they point
to the right place when copied.
Instead, use setup_ctdb_base() during test setup.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2b38b82303e077c388897362b59b8bbdb30dd849">2b38b823</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use setup_ctdb_base() for onnode unit tests
The nodes file is now in the CTDB_BASE directory so no CTDB_NODES_FILE
variable is needed.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ee9051b7f7884a3beead841ef2a7684d8ab48784">ee9051b7</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: New directory for simple test state
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2b09dc9d8e130d4a5b3e8b7df61507ba1da7c6e8">2b09dc9d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use SIMPLE_TESTS_VAR_DIR for data for local daemons tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/670668f4c1598cffe5db51e53f81a0fff389495b">670668f4</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Clean up nodes and public address file setup
Untangle a single loop into two separate, clear functions. Create a
separate, empty file for the node with no public IPs instead of
pointing the configuration at /dev/null.
Leave the indentation in setup_ctdb() in the old style to make this
commit comprehensible.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/caf6b1c684f3df4b4fc67a3cf08ea66025b21bd3">caf6b1c6</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Reindent setup_ctdb() function
This could have been done earlier but previous movement of lines out
to new functions has made the job easier.
Best viewed with show/diff -w.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a7a5216968086cef406700af9192d3e37313158c">a7a52169</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use setup_ctdb_base() for simple tests
The comment in local.bash is incorrect. CTDB_BASE will never be set
here because this script is not run under onnode. Instead, this where
CTDB_BASE needs to be set when running against a real cluster.
For local daemons, the check for CTDB_BASE being inconsistent with
node_dir is temporary.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/85598480fbb3a994b853bcd44438d6da85d8f4f3">85598480</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Make fake ssh script set CTDB_BASE
The local daemons code puts the socket in the CTDB_BASE directory.
This means CTDB_NODES_SOCKETS can be replaced by CTDB_BASES, a list of
base directories. The fake ssh script can first determine the correct
CTDB_BASE directory and then use it to set CTDB_SOCKET and
CTDB_PIDFILE.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/98bd5b6a41f656802d075c50be7c5b766333080c">98bd5b6a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Depend on setup_ctdb_base() to install events.d/
This directory is only used by simple tests when running against local
daemons. Moving it to simple/etc-ctdb/events.d/ means that it is
automatically copied by setup_ctdb_base().
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bd66445eddd1273da034df703f6aba7864e8e542">bd66445e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T06:08:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "ctdb-doc: Fix monitoring bug in example NFS Ganesha call-out"
The check action should be there. It is used by 20.nfs_ganesha.check.
This reverts commit 4fa9026bbd9f67348d3203e0205c59ff4fb51d2d.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9e954bcbf43d67a18ee55f84cda0b09028f96b92">9e954bcb</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-09T11:24:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Don't use nc -d or -w options
nmap-ncat is used in some distributions to replace netcat. It has a
different meaning for these options.
We can get the same effect as the current combination of -d and -w by
piping a sleep process to nc. Subsequent use of $! works because it
gets the last process in pipeline.
Note that redirecting from /dev/null doesn't work with some versions
of nc. They just exit when they get EOF.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Mar 9 12:24:13 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b97d18f0fe26310501a0d7ece93dff48859da6b1">b97d18f0</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-03-12T19:39:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: Fix max indentation and max column
Minor cleanup reducing the max indentation level and max column length.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/614f5a041ea6e021c2ff9c4e462b0e22626c7f33">614f5a04</a></strong>
<div>
<span>by Uri Simchoni</span>
<i>at 2018-03-13T00:48:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">README.Coding: codify line splitting on function calls
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Mar 13 01:48:21 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fbd16473ecf073f86e36f9e29a80151272661dce">fbd16473</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-13T09:24:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/tests: add a test for password change with empty delete
Note that the request using the clearTextPassword attribute for the
password change is already correctly rejected by the server.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b23bf04caeb196da9515addbcdf17db0723ee553">b23bf04c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-13T09:24:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/password_hash: add a helper variable for LDB_FLAG_MOD_TYPE
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c653e51a3d991e0e08327186881b324b85106f0d">c653e51a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-13T09:24:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/password_hash: add a helper variable for passwordAttr->num_values
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2fea9ee701fed0417d8f681238663b7b00c451f8">2fea9ee7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-13T09:24:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: only call dsdb_acl_debug() if we checked the acl in acl_check_password_rights()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/39e689aa703536330083bfc4d58d15a2521e0f95">39e689aa</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-13T09:24:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: remove unused else branches in acl_check_password_rights()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e15ce12e1e9733f1e8eb13e77cbcdd0aea29f29">0e15ce12</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-13T09:24:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: check for internal controls before other checks
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/766ab4c52b06532f2dd8801ccf5d4aadf07a098e">766ab4c5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-13T09:24:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: add check for DSDB_CONTROL_PASSWORD_HASH_VALUES_OID control
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9dd7dd9ebba8d449feea66695fab3cbbb22d00e8">9dd7dd9e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-13T09:24:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: add a NULL check for talloc_new() in acl_check_password_rights()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3e6621fe58014f19477633b1c0b54288550f0e87">3e6621fe</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-13T09:24:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4/dsdb: correctly detect password resets
This change ensures we correctly treat the following LDIF
dn: cn=testuser,cn=users,...
changetype: modify
delete: userPassword
add: userPassword
userPassword: thatsAcomplPASS1
as a password reset. Because delete and add element counts are both
one, the ACL module wrongly treated this as a password change
request.
For a password change we need at least one value to delete and one value
to add. This patch ensures we correctly check attributes and their
values.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/407a34c73fcd666c22776bbc4aa56d02c0683463">407a34c7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-13T09:24:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: run password checking only once
This is needed, because a later commit will let the acl module add a
control to the change request msg and we must ensure that this is only
done once.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ab7dc210e9aedc1222055822ff296e4a67cfb27b">ab7dc210</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-13T09:24:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/samdb: define DSDB_CONTROL_PASSWORD_ACL_VALIDATION_OID control
Will be used to pass "user password change" vs "password reset" from the
ACL to the password_hash module, ensuring both modules treat the request
identical.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c80456855197f9fe9ef497a7fc94504c28445343">c8045685</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-13T09:24:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb: use DSDB_CONTROL_PASSWORD_ACL_VALIDATION_OID
This is used to pass information about which password change operation (change
or reset) the acl module validated, down to the password_hash module.
It's very important that both modules treat the request identical.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/50e7788603b97104fe116a07ab14a1d1148f4405">50e77886</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-13T09:24:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: changing dBCSPwd is only allowed with a control
This is not strictly needed to fig bug 13272, but it makes sense to also
fix this while fixing the overall ACL checking logic.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c41895be8222199ffe69749e32afc9946517f63f">c41895be</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-13T15:06:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1050: s3: RPC: spoolss server. Protect against null pointer derefs.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11343
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Mar 13 16:06:10 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8497d2090900b252853278f29a4aaf3bce7515da">8497d209</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-13T17:59:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libds: rename UF_MACHINE_ACCOUNT_MASK to UF_TRUST_ACCOUNT_MASK
The name UF_TRUST_ACCOUNT_MASK better reflects the use case and it's not
yet used.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d36aa65fe41517dee6136f49e4b01ed9f97ba05">5d36aa65</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-03-13T19:02:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.8.1...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/20609aa260f0a84dff4574df4a1564884a813f92">20609aa2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-13T22:48:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: dsdb/password_hash: use UF_TRUST_ACCOUNT_MASK
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Mar 13 23:48:28 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bffae41842fe218959fe6f8b43df694feec1589c">bffae418</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-15T14:46:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">utils: Add destroy_netlogon_creds_cli
This is a pure testing utility that will garble the netlogon_creds_cli
session_key. This creates a similar effect to our schannel credentials
as does a domain controller reboot.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0af88b98e7e1bba14827305257e77b63dc82d902">0af88b98</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-15T14:46:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Add smbcontrol disconnect-dc
Make a winbind child drop all DC connections
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4b7a9d560a51b51ac88f30276c87edc097b00d0b">4b7a9d56</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-15T14:46:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Keep "force_reauth" in invalidate_cm_connection
Right now I don't see a way to actually force a re-serverauth
from the client side as long as an entry in netlogon_creds_cli.tdb
exists. cm_connect_netlogon goes through invalidate_cm_connection, and
this wipes our wish to force a reauthenticatoin. Keep this intact until
we actually did reauthenticate.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a8d5e4d36768bc199c631626488b2d0acbd6e91a">a8d5e4d3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-15T14:46:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: add and use ldap_reconnect_need_retry() in winbindd_reconnect_ads.c
ldap_reconnect_need_retry() is a copy of reconnect_need_retry() minus
the RPC connection invalidation.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a33c1d25e0422483c903001dd246626f84c4cbc1">a33c1d25</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-15T14:46:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: check for NT_STATUS_IO_DEVICE_ERROR in reset_cm_connection_on_error()
reconnect_need_retry() already checks for this error, it surfaces up
from tstream_smbXcli_np as a mapping for EIO.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/17749a5d9fa08da1c61de45728656a2c9b85782d">17749a5d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-15T14:46:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: make reset_cm_connection_on_error() public
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2837b796af3e491b6bb34bd441758ae214f629ee">2837b796</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-15T14:46:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: call reset_cm_connection_on_error() from reconnect_need_retry()
This ensures we use the same disconnect logic in the reconnect backend,
which calls reconnect_need_retry(), and in the dual_srv frontend which
calls reset_cm_connection_on_error.
Both reset_cm_connection_on_error() and reconnect_need_retry() are very
similar, both return a bool indicating whether a retry should be
attempted, unfortunately the functions have a different default return,
so I don't dare unifying them, but instead just call one from the other.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2d1f00cc3ad77bed4e810dc910979e6cdf582216">2d1f00cc</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-15T14:46:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: force netlogon reauth for certain errors in reset_cm_connection_on_error()
NT_STATUS_RPC_SEC_PKG_ERROR is returned by the server if the server
doesn't know the server-side netlogon credentials anymore, eg after a
reboot. If this happens we must force a full netlogon reauth.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Volker Lendecke <vl@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/966ff3793a867a5ffe1a49e48c8ab3ecb02f8359">966ff379</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-15T14:46:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: call dcerpc_binding_handle_is_connected() from reset_cm_connection_on_error()
To consolidate the error handling for RPC calls, add the binding handle
as an additional argument to reset_cm_connection_on_error().
All callers pass NULL for now, so no change in behaviour up to here.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/08718af36f3ed6cf2308beb3800abfb0414f94b9">08718af3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-15T14:46:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: fix logic calling dcerpc_binding_handle_is_connected()
The calls were missing the negation operator, a retry should be
attempted is the binding handle got somehow disconnected behind the
scenes and is NOT connected.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6244a2beb184de8d050389e304f087ef153d61dd">6244a2be</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-15T14:46:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: use reset_cm_connection_on_error() instead of dcerpc_binding_handle_is_connected()
This catches more errors and triggers retry as appropriate.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c2cd2d3f3137e27cd6e4cabd34f27b49251f078d">c2cd2d3f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-15T14:46:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: add retry to _wbint_LookupSids()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fcf8edf9b8cdf5f3897c1a63ed97c302a231742f">fcf8edf9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-15T14:46:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: add retry to _wbint_DsGetDcName
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e608f058b8f2d2295e24498daa35852de3212b23">e608f058</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-15T14:46:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: add retry to _winbind_DsrUpdateReadOnlyServerDnsRecords
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c37fbfcb248e5a8d6088a28eb0c1a62423f94502">c37fbfcb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-15T19:57:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: add retry to _winbind_SendToSam
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Mar 15 20:57:44 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/82d8aa3b9cb15512d29a97b5a7e55ea1a052734f">82d8aa3b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-15T20:54:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:torture: add SMB2-ANONYMOUS which asserts no GUEST bit for anonymous
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf707a1eba39e996bb19457b63ddb658cc4183c2">bf707a1e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-15T20:54:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:selftest: run SMB2-ANONYMOUS
This fails against a non AD DC smbd.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f564847c8e9d31fe07dd3cbf435986b36f097fa3">f564847c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-15T20:54:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/security: only announce a session as GUEST if 'Builtin\Guests' is there without 'Authenticated User'
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/28ad1306b880a44824ee956a19656ac29581a1b9">28ad1306</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-15T20:54:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: remove unused auth_serversupplied_info->system
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f3ca3e71cc35876df47e31ec9c3643308add2405">f3ca3e71</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-15T20:54:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: add the "Unix Groups" sid for the primary gid
The primary gid might not be in the gid array.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/df3d278853ec097df27c221369dfb3ed0297d6c8">df3d2788</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-15T20:54:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: move add_local_groups() out of finalize_local_nt_token()
finalize_local_nt_token() will be used in another place,
were we don't want to add local groups in a following commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/efdc617c76d9043286e33b961f45ad4564232102">efdc617c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-15T20:54:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:passdb: handle dom_sid=NULL in create_builtin_{users,administrators}()
We should not crash if we're called with NULL.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c2ffbf9f764a94ef1dc1280741884cf63a017308">c2ffbf9f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-15T20:54:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: only call secrets_fetch_domain_sid() once in finalize_local_nt_token()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e8dc55d2b969b670322a913799d1af459a1000e7">e8dc55d2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-15T20:54:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: add add_builtin_guests() handling to finalize_local_nt_token()
We should add Builtin_Guests depending on the current token
not based on 'is_guest'. Even authenticated users can be member
a guest related group and therefore get Builtin_Guests.
Sadly we still need to use 'is_guest' within create_local_nt_token()
as we only have S-1-22-* SIDs there and still need to
add Builtin_Guests.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4f81ef9353ad76390aa910c8c17456fec21916c6">4f81ef93</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-15T20:54:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: don't try to expand system or anonymous tokens in finalize_local_nt_token()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d3aae5ba65c7ed0d5e9f8389101cf1c8c1f0a25b">d3aae5ba</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-15T20:54:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: pass AUTH_SESSION_INFO_* flags to finalize_local_nt_token()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f47f9e1f220d2dd547cf77bbc292357a2173870">7f47f9e1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-15T20:54:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: remove static from finalize_local_nt_token()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6ff891195855403bc485725aef8d43d4e3cabacb">6ff89119</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-15T20:54:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: add auth_user_info_copy() function
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/af4bc135e486e17164da0ea918281fbf689892c3">af4bc135</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-15T20:54:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: add auth3_user_info_dc_add_hints() and auth3_session_info_create()
These functions make it possible to construct a full auth_session_info
from the information available from an auth_user_info_dc structure.
This has all the logic from create_local_token() that is used
to transform a auth_serversupplied_info to a full auth_session_info.
In order to workarround the restriction that auth_user_info_dc
doesn't contain hints for the unix token/name, we use
the special S-1-5-88 (Unix_NFS) sids:
- S-1-5-88-1-Y gives the uid=Y
- S-1-5-88-2-Y gives the gid=Y
- S-1-5-88-3-Y gives flags=Y AUTH3_UNIX_HINT_*
The currently implemented flags are:
- AUTH3_UNIX_HINT_QUALIFIED_NAME
unix_name = DOMAIN+ACCOUNT
- AUTH3_UNIX_HINT_ISLOLATED_NAME
unix_name = ACCOUNT
- AUTH3_UNIX_HINT_DONT_TRANSLATE_FROM_SIDS
Don't translate the nt token SIDS into uid/gids
using sid mapping.
- AUTH3_UNIX_HINT_DONT_TRANSLATE_TO_SIDS
Don't translate the unix token uid/gids to S-1-22-X-Y SIDS
- AUTH3_UNIX_HINT_DONT_EXPAND_UNIX_GROUPS
The unix token won't get expanded gid values
from getgroups_unix_user()
By using the hints it is possible to keep the current logic
where an authentication backend provides uid/gid values and
the unix name.
Note the S-1-5-88-* SIDS never appear in the final security_token.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e8402ec0486ced6ac2adb640c61a9e5abc77d4e4">e8402ec0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-15T20:54:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: base make_new_session_info_system() on auth_system_user_info_dc() and auth3_create_session_info()
The changes in the resulting token look like this:
unix_token : *
unix_token: struct security_unix_token
uid : 0x0000000000000000 (0)
gid : 0x0000000000000000 (0)
- ngroups : 0x00000000 (0)
- groups: ARRAY(0)
+ ngroups : 0x00000001 (1)
+ groups: ARRAY(1)
+ groups : 0x0000000000000000 (0)
...
domain_name : *
domain_name : 'NT AUTHORITY'
dns_domain_name : NULL
- full_name : NULL
- logon_script : NULL
- profile_path : NULL
- home_directory : NULL
- home_drive : NULL
- logon_server : NULL
+ full_name : *
+ full_name : 'System'
+ logon_script : *
+ logon_script : ''
+ profile_path : *
+ profile_path : ''
+ home_directory : *
+ home_directory : ''
+ home_drive : *
+ home_drive : ''
+ logon_server : *
+ logon_server : 'SLOWSERVER'
last_logon : NTTIME(0)
last_logoff : NTTIME(0)
acct_expiry : NTTIME(0)
last_password_change : NTTIME(0)
allow_password_change : NTTIME(0)
force_password_change : NTTIME(0)
logon_count : 0x0000 (0)
bad_password_count : 0x0000 (0)
- acct_flags : 0x00000000 (0)
+ acct_flags : 0x00000010 (16)
authenticated : 0x01 (1)
unix_info : *
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a2a289d0446fedb4ea40834b5b5b190fdca30906">a2a289d0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-15T20:54:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: pass the whole auth_session_info from copy_session_info_serverinfo_guest() to create_local_token()
We only need to adjust sanitized_username in order to keep the same behaviour.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6afb6b67a198c88ab8fa3fee931729c43605716d">6afb6b67</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-15T20:54:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: add make_{server,session}_info_anonymous()
It's important to have them separated from make_{server,session}_info_guest(),
because there's a fundamental difference between anonymous (the client requested
no authentication) and guest (the server lies about the authentication failure).
The following is the difference between guest and anonymous token:
security_token: struct security_token
- num_sids : 0x0000000a (10)
- sids: ARRAY(10)
- sids : S-1-5-21-3793881525-3372187982-3724979742-501
- sids : S-1-5-21-3793881525-3372187982-3724979742-514
- sids : S-1-22-2-65534
- sids : S-1-22-2-65533
+ num_sids : 0x00000009 (9)
+ sids: ARRAY(9)
+ sids : S-1-5-7
sids : S-1-1-0
sids : S-1-5-2
- sids : S-1-5-32-546
sids : S-1-22-1-65533
+ sids : S-1-22-2-65534
+ sids : S-1-22-2-100004
sids : S-1-22-2-100002
sids : S-1-22-2-100003
+ sids : S-1-22-2-65533
privilege_mask : 0x0000000000000000 (0)
...
unix_token : *
unix_token: struct security_unix_token
uid : 0x000000000000fffd (65533)
gid : 0x000000000000fffe (65534)
- ngroups : 0x00000004 (4)
- groups: ARRAY(4)
+ ngroups : 0x00000005 (5)
+ groups: ARRAY(5)
groups : 0x000000000000fffe (65534)
- groups : 0x000000000000fffd (65533)
+ groups : 0x00000000000186a4 (100004)
groups : 0x00000000000186a2 (100002)
groups : 0x00000000000186a3 (100003)
+ groups : 0x000000000000fffd (65533)
info: struct auth_user_info
account_name : *
- account_name : 'nobody'
+ account_name : 'ANONYMOUS LOGON'
user_principal_name : NULL
user_principal_constructed: 0x00 (0)
domain_name : *
- domain_name : 'SAMBA-TEST'
+ domain_name : 'NT AUTHORITY'
dns_domain_name : NULL
- full_name : NULL
- logon_script : NULL
- profile_path : NULL
- home_directory : NULL
- home_drive : NULL
- logon_server : NULL
+ full_name : *
+ full_name : 'Anonymous Logon'
+ logon_script : *
+ logon_script : ''
+ profile_path : *
+ profile_path : ''
+ home_directory : *
+ home_directory : ''
+ home_drive : *
+ home_drive : ''
+ logon_server : *
+ logon_server : 'LOCALNT4DC2'
last_logon : NTTIME(0)
last_logoff : NTTIME(0)
acct_expiry : NTTIME(0)
last_password_change : NTTIME(0)
allow_password_change : NTTIME(0)
force_password_change : NTTIME(0)
logon_count : 0x0000 (0)
bad_password_count : 0x0000 (0)
- acct_flags : 0x00000000 (0)
+ acct_flags : 0x00000010 (16)
authenticated : 0x00 (0)
security_token: struct security_token
num_sids : 0x00000006 (6)
sids: ARRAY(6)
+ sids : S-1-5-7
+ sids : S-1-1-0
+ sids : S-1-5-2
sids : S-1-22-1-65533
sids : S-1-22-2-65534
sids : S-1-22-2-65533
- sids : S-1-1-0
- sids : S-1-5-2
- sids : S-1-5-32-546
privilege_mask : 0x0000000000000000 (0)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0ee9a550944034718ea188b277cca4b6fc5fbc5c">0ee9a550</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-15T20:54:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: make use of make_session_info_anonymous()
For unauthenticated connections we should default to a
session info with an anonymous nt token.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1957bf11f127fc08c6622999cadc7dd580ac7d3b">1957bf11</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-16T02:03:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: make use of make_{server,session}_info_anonymous()
It's important to have them separated from make_{server,session}_info_guest(),
because there's a fundamental difference between anonymous (the client requested
no authentication) and guest (the server lies about the authentication failure).
When it's really an anonymous connection, we should reflect that in the
resulting session info.
This should fix a problem where Windows 10 tries to join
a Samba hosted NT4 domain and has SMB2/3 enabled.
We no longer return SMB_SETUP_GUEST or SMB2_SESSION_FLAG_IS_GUEST
for true anonymous connections.
The commit message from a few commit before shows the resulting
auth_session_info change.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Mar 16 03:03:31 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/98623129446672521b7fa41d3457b8ce95db828c">98623129</a></strong>
<div>
<span>by Anton Nefedov via samba-technical</span>
<i>at 2018-03-16T02:04:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: map nterror on smb2_flush errorpath
smbd_smb2_flush_recv() expects nterror in tevent_req, and otherwise
aborts in tevent_req_is_nterror()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13338
Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/26e75cf661a4482291b4faafd90f50f200eac32c">26e75cf6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-16T06:48:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: gse: use "gensec_gssapi:requested_life_time"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Mar 16 07:48:37 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a27db0b61e40b6b503b53e3579867e227f1971b8">a27db0b6</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-03-16T08:46:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ms_schema: fix python2.6 incompatibility
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13337
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/03617480d121232c06ce5887947326f3c92625eb">03617480</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-16T13:46:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wbinfo: Improve the wording for --online-status
Currently it displays if a domain is online or offline which is wrong.
It tells us if we maintain an active connection to the domain or not.
Users are confused if they read offline because the think winbind is not
functional with that domain.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Mar 16 14:46:43 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3056e24a4bee545b94847265ec8ab3b228ce5f89">3056e24a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-16T13:47:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_smbclient_s3.sh: force LANG=C during test_utimes()
This makes the test independent from the developers environment.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da39e74c3909f1c260b4899ea835e789044aaa56">da39e74c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-16T18:47:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/security: fix some SID values in comments
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Mar 16 19:47:15 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ef091e2cf836793e2aa533990913609ccab5119a">ef091e2c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-16T22:07:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: vfs_fruit: Add remove_virtual_nfs_aces() a generic NFS ACE remover.
Not yet used, will be used to tidyup existing code.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a3c925d80433e3d4fe1b1b315edf6520cacf0a9e">a3c925d8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-16T22:07:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: vfs_fruit: Replace code in check_ms_nfs() with remove_virtual_nfs_aces().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/875ff2575feb96d06cf2290e5b6a226b32ef9758">875ff257</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-16T22:07:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: vfs_fruit: Replace code in fruit_fget_nt_acl() with remove_virtual_nfs_aces().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/013aaffe7ff0ed4c30495761bb3208c29b3b5de2">013aaffe</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-16T22:07:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: run vfs.fruit_netatalk test against seperate share
These tests require a fs with xattr support. This allows adding
xattr_tdb to all other shares in the next commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/49996ca9324596b6cd72eb8051ca3676dab17191">49996ca9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-16T22:07:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: vfs.fruit: add xattr_tdb where possible
This makes the tests indepent from fs xattr support.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a6054c01c29c2507e0d5a6aa110fee4fd5c5eeb9">a6054c01</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-17T03:04:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: vfs: fruit tests: Add regression test for dealing with NFS ACE entries.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Mar 17 04:04:32 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/689259be02624b992634aa1ce8addb0ebfc69c51">689259be</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-ib: Drop a bit-rotted test example from the README
This hasn't worked as advertised for a long time.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0ee7b8a6697d67d35af6d8fad10abb882bc1c121">0ee7b8a6</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop CTDB_PIDFILE configuration option
Use environment variables for test-only options.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/32fade2f13af44865d9131644c650a346ecd3473">32fade2f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop ctdbd --pidfile option
Use environment variables for test-only options.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3df36781019e6e1dae942f507fa374a9c57628c1">3df36781</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop CTDB_EVENT_SCRIPT_DIR configuration option
Event scripts live in a standard place.
For testing, CTDB_BASE is modified.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa961e8807658812ec9be7221ef0f0536bd1d24d">aa961e88</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop ctdbd --event-script-dir option
Event scripts live in a standard place.
For testing, CTDB_BASE is modified.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70fb005db4c468d2af54fb365d4c18438c89a45d">70fb005d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use CTDB_SOCKET environment variable to specify socket
Use environment variables for test-only options.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b05dc0bb84281793c025a6ca48b09ef13841d285">b05dc0bb</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Allow CTDB_SOCKET environment variable to be used
Use environment variables for test-only options.
Switch to using a local variable. This simplifies both the logic and
the ability to later drop the command-line option.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1f4fd30882cd57c321a6a12a807433aeda41126a">1f4fd308</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use environment variable for specifying socket
Use environment variables for test-only options. Don't put them in
the configuration file.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de44df261b951f500e63c9c5f9c97fbed6467cad">de44df26</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Drop a couple of unnecessary exports of CTDB_SOCKET
These were necessary because CTDB_SOCKET was not already exported via
test setup.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/81b57fa544830e78457691609c4c8dc2f6f17bcf">81b57fa5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop CTDB_SOCKET configuration option
Use environment variables for test-only options.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4961711621fd359e8b2135238b2da63243bae0a3">49617116</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop ctdbd --socket option
Use environment variables for test-only options.
The setenv() can be dropped because the socket location is either the
compile-time default or the already set environment variable.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0045a7cfeeb51e4283bf63bdc6a100e34b95e2a9">0045a7cf</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Move handling of CTDB_SOCKET to process_command()
options.socket will go away in future. This moves processing of
CTDB_SOCKET close to where it is used.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7e08c1d24c7a57cf73aa16b4c7b3f394157c9f1a">7e08c1d2</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Drop ctdb --socket option
Use environment variables for test-only options.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bdfc8b7e3efd813ab2e4daa50a2ef9abeb844eef">bdfc8b7e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add some options to setup_ctdb()
These provide special-purpose setups for particular testcases.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5615bdf7ff7af06eb599639c1bef444614e0dd93">5615bdf7</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb_tests: Reconfigure the cluster when restarting CTDB
The previous test might have made configuration changes, so call
setup_ctdb() to cause the configuration to be rewritten. This is only
really useful in local daemons tests.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4328f4a59e7e25d01f75bc3fe4e698dfedb8b4ed">4328f4a5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Update some tests to use setup_ctdb() options
Don't use environment variables for test-local configuration
variations.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e0ed9b307da996570ba384b0db31291f3d3f0fb9">e0ed9b30</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Don't allow simple tests to use environment for config
This was a mistake.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1dcc0adf1a9c0d1b56bf0a4d4c323e5e70c8e2e8">1dcc0adf</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Provide a default location for public addresses file
If the specified file or the default does not exist then log a
warning.
This is done in the takeover code to localise the handling of the
public addresses file. Soon the daemon command-line option will go
away and the takeover code will be replaced in the not too distant
future.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3d85488e3a5d4125dfcc7ff121d8c047f4a2d316">3d85488e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use default public addresses file in local daemon tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a0aa735de1d2230aedec6ab7710d37290b227cc5">a0aa735d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use default public addresses file for event script tests
Just use the default location in event script tests.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a757182134a9a3a40cfad97c1a078369a7b817fc">a7571821</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop 10.external event script
This was added for a vendor who decided not to use it. It is almost
certainly unused by anyone. If anyone really needs it then it is in
the git history.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b6127a6384de9bddda69a49437d656bb1bcd542a">b6127a63</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Allow tests access to CTDB_BASE
On the node where the tests are run, CTDB_BASE is always set. This
applies to local daemons too. However, when tests are being run
against a real cluster, there may be a need to access configuration
files. However, CTDB_BASE will not be set in this case.
So, provide a function to get CTDB_BASE, if set, or a real cluster
node's configuration directory, if CTDB_BASE is not set.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6ecddd4f723a034f945ff2bad49376f2dd2c8c62">6ecddd4f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop CTDB_PUBLIC_ADDRESSES configuration option
This option adds a lot of unnecessary complexity to scripts.
Configuration should go in $CTDB_BASE, either directly or via a
symlink, so simplify by using the default location.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/346c28d070fd7df0bbee9c70bbad80d35eae3658">346c28d0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Remove unused function get_ctdbd_command_line_option()
This was a bad idea.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/482ff4bdd3712ce5ac6423aa9509c364eff5db7a">482ff4bd</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop ctdbd --public-addresses option
Use the default location.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b1fcb0a129fa75d8f51a4fe0b6f29bcdc4467707">b1fcb0a1</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop CTDB_PUBLIC_INTERFACE configuration option
The interface must always be specified in the public addresses file.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f6d6f2220b5380532fc554697be832010fb93b53">f6d6f222</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop ctdbd --public-interface option
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c8c944d6186db11dc6523b2b32d4f70072e5cdfd">c8c944d6</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use default location for nodes file
Create the file and then copy it to CTDB_BASE for each node.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/16a93d7691998654213226d659d968d912e56c58">16a93d76</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Drop onnode CTDB_NODES_FILE environment variable
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d55e7d8abcba6ee16f9316431d24e9057f238ed0">d55e7d8a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop an orphaned comment
The relevant code was removed long ago.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/10354438b89f0a3162729f74243fedd859e29436">10354438</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use setup_base() in tool unit tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78248adad61a22cb7bf0c16a67e5479e86179c7c">78248ada</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Improve setting of helper paths
Make use of variables provided by script_install_paths.sh instead of
reinventing the logic.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3a7c49dfbc9ce579876d5cd680ede1f30c11c950">3a7c49df</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Put configuration, socket and PID file in CTDB_BASE
setup_ctdb_base() makes this a convenient temporary directory.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/480c586c7dbc5ffef832c6a0be2c4e6b70f98514">480c586c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Simplify nodes file handling in tool tests
Instead of using an intermediate environment variable for nodes files,
just create "node" or "nodes.<pnn>" in CTDB_BASE. This makes the
nodes file loading in fake_ctdb slightly repetitive but simplifies the
test scripts a lot. It also remove several instance of the CTDB_NODES
variable from the code base, so it is no longer found by "git grep".
Use an empty nodes file to indicate that fake_ctdbd should fail to
read it.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a1eac09dd36ef5d5f3f861cfb37d96f86eebe5ed">a1eac09d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Drop testing hook from ctdb tool
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6cf861a544e19b6b9df839d470e49baafff1097d">6cf861a5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop CTDB_NODES configuration option
Tests now deviate from the compile-time default by setting CTDB_BASE.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dedc9eab92140d328550fcb76c6504677630e841">dedc9eab</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: No longer honour CTDB_NODES environment variable
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/db7e4aa3d8a9eb73774bde28cf37b017555f5019">db7e4aa3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop ctdbd --nlist option
Tests now deviate from the compile-time default by setting CTDB_BASE.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/85a4375788d8ef8345ec390807f18299abdadb20">85a43757</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use onnode to start/stop local daemons
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ebd25890872402bce533469428aa65e08487352c">ebd25890</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use CTDB_BASE instead of node_dir
Simple test configuration is all relative to CTDB_BASE and node_dir is
redundant. Make this explicit by dropping most uses of node_dir.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d7f86a8cdb2c30ac74cdbb01230e3b89e177d48">1d7f86a8</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Construct values for CTDB_BASES by hand
setup_ctdb_base() and node_dir() duplicate the construction of
CTDB_BASE. Drop the use of node_dir() and construct the values for
CTDB_BASES by hand.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/02a942ea473cd68099e07a04e6f17f4b4d92f620">02a942ea</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T01:23:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop unused functions
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3451a03611b146c3b7acab93d452a88e85397f12">3451a036</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-19T06:32:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop CTDBD_CONF internal test variable
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon Mar 19 07:32:22 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8e6050587bc35601093ac9b71aae8fdbeddbcb73">8e605058</a></strong>
<div>
<span>by Andrej Gessel</span>
<i>at 2018-03-19T06:33:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">bugfix memory leak. partition_dn is only used to search and compare and is not freed at the function end.
Signed-off-by: Andrej Gessel <Andrej.Gessel@janztec.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ab4ceffb48e8f82057eea9b2eb2eb09d8bc5ddc">7ab4ceff</a></strong>
<div>
<span>by Matt Selsky</span>
<i>at 2018-03-19T06:33:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/kerberos: Fix typo in error message regarding fetching PAC using Heimdal
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13311
Signed-off-by: Matt Selsky <matthew.selsky@twosigma.com>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f092ac5b6ebbe3a717498fea08d8f4503e3259dc">f092ac5b</a></strong>
<div>
<span>by Jonathan Hunter</span>
<i>at 2018-03-19T11:39:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update help text for dbcheck
Update the help text for dbcheck, to make its behaviour clear (in
particular with reference to the difference between specifying "--yes"
on the command line, and answering "yes"/"all" to each individual
question)
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Mar 19 12:39:12 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3e8c50901c982aaddd86f81328a89e16f1bb5289">3e8c5090</a></strong>
<div>
<span>by Simo Sorce</span>
<i>at 2018-03-19T14:34:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Use "localhost" to be ipv6 only friendly
Signed-off-by: Simo Sorce <idra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/01319b6e659ab29050dd3aa14d800d6f77e511d5">01319b6e</a></strong>
<div>
<span>by Simo Sorce</span>
<i>at 2018-03-19T14:34:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "Use "localhost" to be ipv6 only friendly"
This reverts commit 54548f6dde3cf74f0e90ef577a55fd720dca6d93.
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f5e3b1e9d31510490976b992074024c5a0c1393b">f5e3b1e9</a></strong>
<div>
<span>by Simo Sorce</span>
<i>at 2018-03-19T19:29:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Remove dead code
Signed-off-by: Simo Sorce <idra@samba.org>
Autobuild-User(master): Simo Sorce <idra@samba.org>
Autobuild-Date(master): Mon Mar 19 20:29:28 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c2480b96b5f1cd22c2bc3b26c5846312295566f1">c2480b96</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: rename "guest" methods to "anonymous"
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c5874b9b68e0795e9dc23b04efa5959ac03ec8dc">c5874b9b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:passdb: add create_builtin_guests()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6c8cf7b6ec1b9bc534ddabfc2db8d7d6dac5fe4c">6c8cf7b6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet_join: make use of create_builtin_guests()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0b261dc4e3f2d04131e1ff76a017aaee6e38e7b1">0b261dc4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: make use of create_builtin_guests() in finalize_local_nt_token()
This makes the Builtin_Guests handling more dynamic,
by having a persistent storage for the memberships.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a0c091eba764e721cfa419e697700ca7a5695014">a0c091eb</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: support AUTH_SESSION_INFO_NTLM in finalize_local_nt_token()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2f1ba314df3e484206ee87841e3f6cf96e8c5c95">2f1ba314</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">drsuapi.idl: add DN/fpo-enabled attributes as DRSUAPI_ATTID_* values
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13307
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c406ecce5a5b4151f7cd72f5cce41275d47954de">c406ecce</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb:extended_dn_store: ignore DRSUAPI_ATTID_distinguishedName attributes
We have several tests which already test that, we can avoid doing
searches at all in that case.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13307
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be52754b2f41d98f194c17676297dccc585e55a6">be52754b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb:extended_dn_store: we need to pass down our altered request down on NO_SUCH_OBJECT
It's quite likely that there're more than one attribute and we may
already altered values.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13307
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/551f54e0d70e6daf96d40c8e23f44146b35c0220">551f54e0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb:extended_dn_store: pass the full 'struct dsdb_attribute' to extended_store_replace()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13307
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/18d98022326203e63a5fbec23d906002bd1f1261">18d98022</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb:extended_dn_store: We need to ignore self references on add operation
We have several schema related tests, which already prove
that for the defaultObjectCategory attribute.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13307
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/18f40cefe5a1ef609651cc26db26275baab5b48e">18f40cef</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb:extended_dn_store: rename extended_replace_dn to extended_replace_callback
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13307
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/21b17e759922d117ed346e32465201e0689821b8">21b17e75</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb:extended_dn_store: split out a extended_replace_dn() function
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13307
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b040d3289db247cdb8025f283fc30ffc2c2b40e7">b040d328</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/dsdb.py: prove the difference between linked and non-linked DN references
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13307
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3f357ad8365975f63811ac3effc9a54385217b45">3f357ad8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb:extended_dn_store: make sure reject storing references to deleted objects in linked attributes
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13307
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/470044bee84bdd798e9ccd0d1989b90e9a84ecaa">470044be</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">provision: use the provision control when adding foreignSecurityPrincipals
The next commits will require this.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/856504ca26d1769b5db8fe2e220414960349afe9">856504ca</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/dsdb.py: verify that foreignSecurityPrincipal objects require the provision control
Windows rejects creating foreignSecurityPrincipal objects directly.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a0813b2a9fe8004e4552a952e3587150f832993e">a0813b2a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb:samldb: require as_system or provision control to create foreignSecurityPrincipal objects
Windows rejects creating foreignSecurityPrincipal objects directly.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/799c9d1ce31258c6405602c2f8c53b93be582352">799c9d1c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/dsdb.py: test creation of foreignSecurityPrincipal via 'attr: <SID=...>'
[MS-ADTS] 3.1.1.5.2.3 Special Classes and Attributes claims:
FPO-enabled attributes:
member, msDS-MembersForAzRole, msDS-NeverRevealGroup,
msDS-NonMembers, msDS-RevealOnDemandGroup, msDS-ServiceAccount.
'msDS-NonMembers' always generates NOT_SUPPORTED.
'msDS-ServiceAccount' is not defined in any schema
(only msDS-HostServiceAccount).
'msDS-HostServiceAccount' is not an FPO-enabled attribute
and behaves as the 'manager' attribute.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fb03f9a1de1d8069fcce8710d275371305122bb3">fb03f9a1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb:extended_dn_store: add support for FPO (foreignSecurityPrincipal) enabled attributes
This implements the handling for FPO-enabled attributes, see
[MS-ADTS] 3.1.1.5.2.3 Special Classes and Attributes:
FPO-enabled attributes: member, msDS-MembersForAzRole,
msDS-NeverRevealGroup, msDS-NonMembers, msDS-RevealOnDemandGroup,
msDS-ServiceAccount.
Note there's no msDS-ServiceAccount in any schema (only
msDS-HostServiceAccount and that's not an FPO-enabled attribute
at least not in W2008R2)
msDS-NonMembers always generates NOT_SUPPORTED against W2008R2.
See also [MS-SAMR] 3.1.1.8.9 member.
We now create foreignSeurityPrincipal objects on the fly (as needed).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a70c929e7b4271a67ea9f85dad043bd5c896e3bd">a70c929e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb:repl_meta_data: improve error message in get_parsed_dns()
We may have a dn in '<SID=...>' form and ldb_dn_get_linearized()
just gives in empty string.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6415d6fc1974efd1da229c965b7d2ac85206abe2">6415d6fc</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/Samba4: use DOMAIN/REALM from the dcvars instead of using hardcoded values
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/94bbcb0ea0b4eb9a4f16d7eb4fbf4d363b34ba61">94bbcb0e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: generate a ramdon domain sid during provision and export as SAMSID/[TRUST_]DOMSID
This will be useful for future tests.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a0fe7b0389c2d4ccdcfdadf4dec33ef09759bfd">6a0fe7b0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: allow sid strings for 'group {add,remove}members'
This makes it possible to add foreign SIDS as group members.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b3a9880c90fc436510ad69dcee2e10feb7523ad">7b3a9880</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/Samba4: create add ${TRUST_DOMSID}-513 to a local group
This will allow testing expanding groups on the trust boundary.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b4dadcfb373972f34fd847a6f69146d1325b7cce">b4dadcfb</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs/blackbox: add test_trust_token.sh
This demonstrates, which SID we expect in a token of
an user of a trusted domain.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ef447434cb638563d1031a676ecbf1bf70a5e9ed">ef447434</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:selftest: run samba4.blackbox.trust_token against fl2003dc and fl2008r2dc
This fails currently as we don't expand groups on the trust boundary.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d6ee0651193f4e3d92d0ece162813eae8e128cb6">d6ee0651</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:auth: split out a authsam_domain_group_filter() function
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4565ac59984895ba8235a2da5afeaec48e97c41d">4565ac59</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:auth: add authsam_update_user_info_dc() that implements SID expanding for the local domain
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fd7c91825646aed612c0df1a641f458aab4f21a5">fd7c9182</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:auth_winbind: only call authsam_logon_success_accounting() for local users
There's no need to do a crack_name_to_nt4_name(), as the authentication
already provides the nt4 domain and account names.
This should only happen on an RODC, that we use the winbind auth module
for local users. So we should make sure we only try to reset
the badPwdCount for users of our own domain.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0f9a09bd3552fe62a98ce40cab6aee2740eb35ce">0f9a09bd</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:auth_winbind: make sure we expand group memberships of the local domain
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/396fd8f4ff3fd3b5d89109d35b06668bc266143a">396fd8f4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:kdc: remember is_krbtgt, is_rodc and is_trust samba_kdc_entry
This can later be used for sid filtering and similar things.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a5f803e9e9f7655f3a6867401d5d3eb667593a9f">a5f803e9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:kdc: pass krbtgt and server to samba_kdc_update_pac_blob()
This will be used for SID expanding and filtering.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/63de04c01cb7d53773f96a01473a311e1d4264b8">63de04c0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:kdc: make sure we expand group memberships of the local domain
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13300
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1f1e221a8ffbecd3f80073c05d8f194d2dad9b24">1f1e221a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb/samlogon_cache: zero session keys before storing the info3 structure
The samlogon_cache is only used to get group memberships of the account
without asking the dc.
But for authentication we always ask the dc.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8a1c930e1b2452050f4d49a8c54164aa4afdb15f">8a1c930e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/security: add dom_sid_is_valid_account_domain()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c9c6fa45c4ae2d3ffc8407276a9e965e701c8e9a">c9c6fa45</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-19T19:30:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: make use of dom_sid_is_valid_account_domain()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9bbabf628efb880512aeb68587698c0240dfabd5">9bbabf62</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-20T00:29:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pdb_samba_dsdb: make use of dom_sid_is_valid_account_domain()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Mar 20 01:29:40 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/618c714b6b6c0b63993299b40b9a466adb753cc2">618c714b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-20T15:07:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:replace: Fix linking when libtirpc-devel overwrites system headers
Some systems (like SUSE currently) install the new tirpc headers by
overwritting the existing system location used by gcc. This patch will
detect if the headers in the system location belong to tirpc or not.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13341
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Mar 20 16:07:05 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ebc21376e6a8362bbc7ac1d330da995af10a1c26">ebc21376</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-20T20:28:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:torture: add SMB2-ANONYMOUS which asserts no GUEST bit for anonymous
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 82d8aa3b9cb15512d29a97b5a7e55ea1a052734f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8227b0a6c092ebe84ea4cc402a9fc4cb8766b229">8227b0a6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-20T20:28:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:selftest: run SMB2-ANONYMOUS
This fails against a non AD DC smbd.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit bf707a1eba39e996bb19457b63ddb658cc4183c2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/abffcb8179101736dc98306d5232fd452ac63466">abffcb81</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-20T20:28:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/security: only announce a session as GUEST if 'Builtin\Guests' is there without 'Authenticated User'
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit f564847c8e9d31fe07dd3cbf435986b36f097fa3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a67e3d00169d220bfb085c465f073214eb26636a">a67e3d00</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-20T20:28:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: remove unused auth_serversupplied_info->system
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 28ad1306b880a44824ee956a19656ac29581a1b9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/88c8499ccc07fed5cfe263ced2309b50efc83c40">88c8499c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-20T20:28:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: add the "Unix Groups" sid for the primary gid
The primary gid might not be in the gid array.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit f3ca3e71cc35876df47e31ec9c3643308add2405)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/253f0d184151e6a3c8b2fd5d827d9c3a1d30149c">253f0d18</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-20T20:28:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: move add_local_groups() out of finalize_local_nt_token()
finalize_local_nt_token() will be used in another place,
were we don't want to add local groups in a following commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit df3d278853ec097df27c221369dfb3ed0297d6c8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/03b4684e9a3b1bd988409b89a6cc08ea1a4b8a56">03b4684e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-20T20:28:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:passdb: handle dom_sid=NULL in create_builtin_{users,administrators}()
We should not crash if we're called with NULL.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit efdc617c76d9043286e33b961f45ad4564232102)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8557994f1f535f81acd240eec2c462b0bb1d5b19">8557994f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-20T20:28:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: only call secrets_fetch_domain_sid() once in finalize_local_nt_token()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit c2ffbf9f764a94ef1dc1280741884cf63a017308)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2c148eb8ec36fc22caa9f47dada8f387eee80ab0">2c148eb8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-20T20:28:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: add add_builtin_guests() handling to finalize_local_nt_token()
We should add Builtin_Guests depending on the current token
not based on 'is_guest'. Even authenticated users can be member
a guest related group and therefore get Builtin_Guests.
Sadly we still need to use 'is_guest' within create_local_nt_token()
as we only have S-1-22-* SIDs there and still need to
add Builtin_Guests.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit e8dc55d2b969b670322a913799d1af459a1000e7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3adb292feec9364d1fd7c0f81927f1bf4d7d6d83">3adb292f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-20T20:28:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: don't try to expand system or anonymous tokens in finalize_local_nt_token()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 4f81ef9353ad76390aa910c8c17456fec21916c6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aee33186bb136a43222dcb85ac7dcc57760fa4b9">aee33186</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-20T20:28:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: pass AUTH_SESSION_INFO_* flags to finalize_local_nt_token()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit d3aae5ba65c7ed0d5e9f8389101cf1c8c1f0a25b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/05fad286f1c1f4e9fdfb1797cdfc6bf23d6c4a25">05fad286</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-20T20:28:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: remove static from finalize_local_nt_token()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 7f47f9e1f220d2dd547cf77bbc292357a2173870)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/df9ae9d72560578d0000a4083bd2ba3bf5cbd910">df9ae9d7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-20T20:28:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: add auth_user_info_copy() function
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 6ff891195855403bc485725aef8d43d4e3cabacb)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59cf56ee987e372c2afac0662d7ef830a943ad36">59cf56ee</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-20T20:28:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: add auth3_user_info_dc_add_hints() and auth3_session_info_create()
These functions make it possible to construct a full auth_session_info
from the information available from an auth_user_info_dc structure.
This has all the logic from create_local_token() that is used
to transform a auth_serversupplied_info to a full auth_session_info.
In order to workarround the restriction that auth_user_info_dc
doesn't contain hints for the unix token/name, we use
the special S-1-5-88 (Unix_NFS) sids:
- S-1-5-88-1-Y gives the uid=Y
- S-1-5-88-2-Y gives the gid=Y
- S-1-5-88-3-Y gives flags=Y AUTH3_UNIX_HINT_*
The currently implemented flags are:
- AUTH3_UNIX_HINT_QUALIFIED_NAME
unix_name = DOMAIN+ACCOUNT
- AUTH3_UNIX_HINT_ISLOLATED_NAME
unix_name = ACCOUNT
- AUTH3_UNIX_HINT_DONT_TRANSLATE_FROM_SIDS
Don't translate the nt token SIDS into uid/gids
using sid mapping.
- AUTH3_UNIX_HINT_DONT_TRANSLATE_TO_SIDS
Don't translate the unix token uid/gids to S-1-22-X-Y SIDS
- AUTH3_UNIX_HINT_DONT_EXPAND_UNIX_GROUPS
The unix token won't get expanded gid values
from getgroups_unix_user()
By using the hints it is possible to keep the current logic
where an authentication backend provides uid/gid values and
the unix name.
Note the S-1-5-88-* SIDS never appear in the final security_token.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit af4bc135e486e17164da0ea918281fbf689892c3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e811adb14b188808d29058d409d17c634536364b">e811adb1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-20T20:28:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: base make_new_session_info_system() on auth_system_user_info_dc() and auth3_create_session_info()
The changes in the resulting token look like this:
unix_token : *
unix_token: struct security_unix_token
uid : 0x0000000000000000 (0)
gid : 0x0000000000000000 (0)
- ngroups : 0x00000000 (0)
- groups: ARRAY(0)
+ ngroups : 0x00000001 (1)
+ groups: ARRAY(1)
+ groups : 0x0000000000000000 (0)
...
domain_name : *
domain_name : 'NT AUTHORITY'
dns_domain_name : NULL
- full_name : NULL
- logon_script : NULL
- profile_path : NULL
- home_directory : NULL
- home_drive : NULL
- logon_server : NULL
+ full_name : *
+ full_name : 'System'
+ logon_script : *
+ logon_script : ''
+ profile_path : *
+ profile_path : ''
+ home_directory : *
+ home_directory : ''
+ home_drive : *
+ home_drive : ''
+ logon_server : *
+ logon_server : 'SLOWSERVER'
last_logon : NTTIME(0)
last_logoff : NTTIME(0)
acct_expiry : NTTIME(0)
last_password_change : NTTIME(0)
allow_password_change : NTTIME(0)
force_password_change : NTTIME(0)
logon_count : 0x0000 (0)
bad_password_count : 0x0000 (0)
- acct_flags : 0x00000000 (0)
+ acct_flags : 0x00000010 (16)
authenticated : 0x01 (1)
unix_info : *
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit e8402ec0486ced6ac2adb640c61a9e5abc77d4e4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/07091cd7f02a7c785ed85ea79268d73249c8ac8e">07091cd7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-20T20:28:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: pass the whole auth_session_info from copy_session_info_serverinfo_guest() to create_local_token()
We only need to adjust sanitized_username in order to keep the same behaviour.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit a2a289d0446fedb4ea40834b5b5b190fdca30906)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a6ecafa7189938b77c11faf8e1026cb8c02256b8">a6ecafa7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-20T20:28:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: add make_{server,session}_info_anonymous()
It's important to have them separated from make_{server,session}_info_guest(),
because there's a fundamental difference between anonymous (the client requested
no authentication) and guest (the server lies about the authentication failure).
The following is the difference between guest and anonymous token:
security_token: struct security_token
- num_sids : 0x0000000a (10)
- sids: ARRAY(10)
- sids : S-1-5-21-3793881525-3372187982-3724979742-501
- sids : S-1-5-21-3793881525-3372187982-3724979742-514
- sids : S-1-22-2-65534
- sids : S-1-22-2-65533
+ num_sids : 0x00000009 (9)
+ sids: ARRAY(9)
+ sids : S-1-5-7
sids : S-1-1-0
sids : S-1-5-2
- sids : S-1-5-32-546
sids : S-1-22-1-65533
+ sids : S-1-22-2-65534
+ sids : S-1-22-2-100004
sids : S-1-22-2-100002
sids : S-1-22-2-100003
+ sids : S-1-22-2-65533
privilege_mask : 0x0000000000000000 (0)
...
unix_token : *
unix_token: struct security_unix_token
uid : 0x000000000000fffd (65533)
gid : 0x000000000000fffe (65534)
- ngroups : 0x00000004 (4)
- groups: ARRAY(4)
+ ngroups : 0x00000005 (5)
+ groups: ARRAY(5)
groups : 0x000000000000fffe (65534)
- groups : 0x000000000000fffd (65533)
+ groups : 0x00000000000186a4 (100004)
groups : 0x00000000000186a2 (100002)
groups : 0x00000000000186a3 (100003)
+ groups : 0x000000000000fffd (65533)
info: struct auth_user_info
account_name : *
- account_name : 'nobody'
+ account_name : 'ANONYMOUS LOGON'
user_principal_name : NULL
user_principal_constructed: 0x00 (0)
domain_name : *
- domain_name : 'SAMBA-TEST'
+ domain_name : 'NT AUTHORITY'
dns_domain_name : NULL
- full_name : NULL
- logon_script : NULL
- profile_path : NULL
- home_directory : NULL
- home_drive : NULL
- logon_server : NULL
+ full_name : *
+ full_name : 'Anonymous Logon'
+ logon_script : *
+ logon_script : ''
+ profile_path : *
+ profile_path : ''
+ home_directory : *
+ home_directory : ''
+ home_drive : *
+ home_drive : ''
+ logon_server : *
+ logon_server : 'LOCALNT4DC2'
last_logon : NTTIME(0)
last_logoff : NTTIME(0)
acct_expiry : NTTIME(0)
last_password_change : NTTIME(0)
allow_password_change : NTTIME(0)
force_password_change : NTTIME(0)
logon_count : 0x0000 (0)
bad_password_count : 0x0000 (0)
- acct_flags : 0x00000000 (0)
+ acct_flags : 0x00000010 (16)
authenticated : 0x00 (0)
security_token: struct security_token
num_sids : 0x00000006 (6)
sids: ARRAY(6)
+ sids : S-1-5-7
+ sids : S-1-1-0
+ sids : S-1-5-2
sids : S-1-22-1-65533
sids : S-1-22-2-65534
sids : S-1-22-2-65533
- sids : S-1-1-0
- sids : S-1-5-2
- sids : S-1-5-32-546
privilege_mask : 0x0000000000000000 (0)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(similar to commit 6afb6b67a198c88ab8fa3fee931729c43605716d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f9d850d3d1b803143bee807ebba218b7f14aaef0">f9d850d3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-20T20:28:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: make use of make_session_info_anonymous()
For unauthenticated connections we should default to a
session info with an anonymous nt token.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 0ee9a550944034718ea188b277cca4b6fc5fbc5c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/62c3a7a6bd165e10d58acad57858901c699ae470">62c3a7a6</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-03-20T22:16:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: Fix possible mem leak
The call to full_path_tos() might allocate memory which needs to be free'd
once processign is done.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/72979d1d60ca2eab1e7903c2e77b8cca69667691">72979d1d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">heimdal: Fix size types
This fixes compilation with -Wstrict-overflow=2
Upstream pull request:
https://github.com/heimdal/heimdal/pull/354
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/717976ac237fff3cf7a4e95dd0c67950dfaf8e20">717976ac</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:ntvfs: Fix size type in pvfs functions
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bbbe675a1a7afcbc89f27093b8d521d296cde2fa">bbbe675a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Fix size types in kerberos functions
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/19e621554f0ffe44745f7ebc7e2c71094a00bc11">19e62155</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:dns_server: Fix size types
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1bd4a0cf27dfe820ec9103374ed225375aac8ded">1bd4a0cf</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Fix size types in dcerpc dnsserver
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8438897828b16bfc5985d02b76268609a7610c7d">84388978</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:ldap_server: Fix size types
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/939b4723a7d159466bfe2e66ddcb38012e412385">939b4723</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:cldap_server: Fix size types
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c63ed7b656d4b3ea5518ee40679df96b84db0332">c63ed7b6</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Fix size types
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87ebb195d34e3c413eea7ef38024c1be97fd5be9">87ebb195</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:param: Fix size types
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b709b10eb62541b57adc11d6d36096f04647bee3">b709b10e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:utils: Fix size types
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a877018ebeb905f9fb9bbad7e138dad55918717e">a877018e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Fix size types
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/74fbc8ed4be57b3236bd6c4344fa990410fe4670">74fbc8ed</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Fix size types in qsinfo test
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/13540613edfcde827a41f60d78d64c63eb99f065">13540613</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Fix size types in qfileinfo test
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d5a8c49c1bc71eb751c57d076f452d7a2c3e95ea">d5a8c49c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:torture: Fix size types in spoolss test
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba3e21cea0dc70a8e8e6fc6e88c1721a3a455b9d">ba3e21ce</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: Fix size types in nmblib
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f5fd615cbf727663ad082176511dfad90969083d">f5fd615c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Fix size types in nss tests
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4630e06334c157639eaf6ae0858f491ca4fc1dad">4630e063</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:client: Fix size types
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/75c28a264223529777f8d1f86574178805aef706">75c28a26</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:client: Fix size types
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eb0bdefd2dd5477ae5c590b5be8c485fb3977775">eb0bdefd</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:avahi: Fix size types
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/206bbec4f94cc5bcf958961cfca187eb8106da36">206bbec4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:printing: Fix size type in printing_db
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8a108f624d516cb12396f135e21891c41a16852d">8a108f62</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbindd: Fix size types in idmap_tdb_common
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b19a810206ce954f3f7997c7a02a294a36e17da9">b19a8102</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:vfs_nettalk: Fix size types
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c2e9fb63c06ea37e11ed163a89a055748ea1ffc5">c2e9fb63</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Fix size types in srvsvc
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dfb69482c4a500a486fe8b4cb6f3841e58d00f56">dfb69482</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Fix size type in log2pcaphex
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c6b5297b406312a7944c11917a8d5c8235f72673">c6b5297b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:nmbd: Fix size type in nmbd_browsesync.c
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59b689474727c173f052d66a4ab924060181b903">59b68947</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: Fix size type in getdate
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/db31156dafbf4d2eebb171857df8814af230f896">db31156d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:passdb: Fix size types
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e3483f955bc5ba5eac90cf38c3e6ca2ee481b53d">e3483f95</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Fix size types in spoolss
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d0c882434cb94f89501283149a28b47a1dd6461c">d0c88243</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpcclient: Fix size types
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dcd0a7f738dabc67aef73abc805eb9eb0d226e8d">dcd0a7f7</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Fix size types in ldb_ldif functions
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da68a1b2f417ec82ea4ed3e7a4d867cef8ca8f93">da68a1b2</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:socket: Return early if we have only one interface
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f866844f44c3a9246076aa950148e994809d4b1b">f866844f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:dsdb: Fix integer operations
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3a383038ee7f74e5a9d2326a761b27950a14eb83">3a383038</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:nmbd: Fix possible integer overflow
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f6de82ef25c5d7969c3986d508a138c3c4f5a64">9f6de82e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:locking: Fix integer overflow check in posix_lock_in_range()
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0f7a86c46ff90b907615d8f096f86c383ccf3e8e">0f7a86c4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-20T22:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:vfs_preopen: Change to a do-while loop and fix the check
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cbbb6ef5c2b41bb46972fabc08c55134098ac29b">cbbb6ef5</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-21T01:29:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: make use of make_{server,session}_info_anonymous()
It's important to have them separated from make_{server,session}_info_guest(),
because there's a fundamental difference between anonymous (the client requested
no authentication) and guest (the server lies about the authentication failure).
When it's really an anonymous connection, we should reflect that in the
resulting session info.
This should fix a problem where Windows 10 tries to join
a Samba hosted NT4 domain and has SMB2/3 enabled.
We no longer return SMB_SETUP_GUEST or SMB2_SESSION_FLAG_IS_GUEST
for true anonymous connections.
The commit message from a few commit before shows the resulting
auth_session_info change.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Mar 16 03:03:31 CET 2018 on sn-devel-144
(cherry picked from commit 1957bf11f127fc08c6622999cadc7dd580ac7d3b)
Autobuild-User(v4-8-test): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(v4-8-test): Wed Mar 21 02:29:57 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e9d42e5681739dda041ae612f3c9a4a31b131bbd">e9d42e56</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-21T03:25:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:registry: Fix size types and length calculations
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Mar 21 04:25:39 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/245e179340bd870e486957f0a4b82be23ebc9f5a">245e1793</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-21T03:36:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">join.py: Add missing NTSTATUSError import
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/32a543198769c0e50f2039325d2e6eafdd877ba4">32a54319</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-21T03:36:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kcc_utils: Add a routine for automatic site coverage
This allows double-coverage if two links exist with the same cost.
Administrators should only connect an DC-less site via a single site
link.
This also allows unnecessary coverage by all sites in the adjoining site
link (to be resolved in the later patches).
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/96340e1ad2b15ab513e20e5a4317b90811c06bba">96340e1a</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-21T03:36:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kcc_utils: Keep a count of the DCs in each site
This is useful for ranking which sites are preferable within the same
site link.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f342d7e0256eda8f6702c0f2c7752fbcf459ba8f">f342d7e0</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-21T03:36:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kcc_utils: Prevent multiple sites attached to a sitelink covering a site
This avoids trivial duplicates in a similar manner as mentioned in:
https://blogs.technet.microsoft.com/askds/2011/04/29/sites-sites-everywhere/
It prefers the largest sites then the earliest alphabetically, so that
only a single site ever covers an uncovered site (within a site link).
Note that this isn't applicable over multiple site links (like Windows
presumably) and is only a simple mechanism to avoid excessive
registering. DCs within the site will also still register for each.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ecf503ce76cd241e0e095279642820f72c8a7fba">ecf503ce</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-21T03:36:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kcc_utils: Use lower name in automatic sites covered
This allows easier testing, as well as some consistency in the DNS
record creation.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b71f897b4feba0b6cae6c6c3d9c3122ebc640e38">b71f897b</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-21T03:36:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/kcc_util: Add unit tests for automatic site coverage
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/79b640f84e32ccd548d78e427b1cbdad1df21669">79b640f8</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-21T03:36:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/samba_dnsupdate: Add a trivial test of automatic site coverage
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2b87bf8c0984df65f7d0396f40442432c8b57c4b">2b87bf8c</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-03-21T03:36:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba_dnsupdate: Introduce automatic site coverage
This uses the underlying function in kcc_utils.py which already has
tests.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bddf66c460241378fb9248d630cf66f0e7740ed2">bddf66c4</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-03-21T03:36:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool ldapcmp: remove duplicate takes_optiongroups attribute
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9312a1cdafbd5a0140d72502487c4e478dc578d2">9312a1cd</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-03-21T08:25:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool visualize: fix python2.6 incompatibility
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13337
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Wed Mar 21 09:25:51 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c909ea4530d4e7e4aa27046c45e3e48b094a411">5c909ea4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-21T12:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fruit. Make the use of dom_sid_compare_domain() much clearer.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a7eaf909d7f139462351c43ef1dbb2915f8490f">4a7eaf90</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-21T12:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: Fix size type and checks in _vasprintf_tc
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/41b6810ba01f44537f470c806adb8686e1a39c48">41b6810b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-21T12:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: use a library destructor instead of atexit() if available
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7587
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/80f9ec016496087bca06d3c34b6f687f0dc145ac">80f9ec01</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-03-21T17:39:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: version 2.1.12
* Fix documentation typo
* Fix compilation with -Wstrict-overflow=2
* Use a library destructor instead of atexit() if available
(bug #7587)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Mar 21 18:39:33 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5e62c1cb36d7fe2336d5cc497c5173f40f00be1d">5e62c1cb</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-21T19:43:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:printing: Fix size check in get_file_version()
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e64738b606c815dc98f4ea289f6cd260f03a1975">e64738b6</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-21T19:43:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Fix size types in ms_fnmatch()
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b70bb81a191f57612b877564bcf2bae3ecdd1c24">b70bb81a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-21T19:43:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Fix size types in tldap_find_first_star()
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e0cf35aec23e2fa52a8a2c8b151a81175445efaf">e0cf35ae</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-22T00:54:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:param: Fix the size type in lp_do_parameter_parametric()
This fixes compilation with -Wstrict-overflow=2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Mar 22 01:54:08 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8dabcf8948c2e514b489169c34673e093519b583">8dabcf89</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-22T01:15:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: debug: smb2: Create a new DBGC_SMB2 debug class and mark all smbd/smb2_*.c files with it.
Will allow easier smb2-specific debugging.
https://bugzilla.samba.org/show_bug.cgi?id=13347
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cdde6d93605d15a59e816a35e8e02ca193bf1403">cdde6d93</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-22T01:15:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: debug: Add DBGC_XXX versions of the macros to allow class-specific messages.
https://bugzilla.samba.org/show_bug.cgi?id=13347
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ad973fddef00d6d92443be89e7f5404006a94d99">ad973fdd</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-22T01:15:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: SMB2: Add DBGC_SMB2_CREDITS class to specifically debug credit issues.
https://bugzilla.samba.org/show_bug.cgi?id=13347
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fc922bd29b40a20450f16728fa7347f8f83d3bcd">fc922bd2</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-22T01:15:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: docs: Add documentation for "smb2" and "smb2_credits" debug classes.
https://bugzilla.samba.org/show_bug.cgi?id=13347
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ac33b5653f9ee7a69cd367e262bdaceb29c9867c">ac33b565</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-22T01:15:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdbdump: Avoid an int cast
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/df2a036377ad68a999cbccd6e2ba813fa48e7cb9">df2a0363</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-22T01:15:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Harden tdb_rec_read
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2c94093ad961f3e93302dae6aa373e5b3fe8ee95">2c94093a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-22T01:15:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Handle TDB_NEXT_LOCK_ERR in tdb_traverse_internal
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1b0fbdaf853b341a8e53e23e1e3f2ae1c9037dc2">1b0fbdaf</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-22T01:15:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Harden tdb_check_used_record against overflow
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5f24fd6863f1278f1e5ea27829c5402c0cae4366">5f24fd68</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-22T01:15:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Make sure the hash size fits
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f45cbf42738d869e310027c05e0a5bba07de9fc">6f45cbf4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-22T01:15:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Harden allocating the tdb recovery area
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2adbb1f75183a1105848ccb6acc577541279b3f6">2adbb1f7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-22T01:15:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Align a few integer types
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7964b3640aacaab68f002c290d82f86e7c709268">7964b364</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-22T06:21:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Fix a "increases alignment" warning
Many of those warnings are difficult to fix, but this one was easy :-)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Mar 22 07:21:44 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d9505567554b13c7e5a61284b14ec90b8cb05075">d9505567</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-22T07:00:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Move defaulttasks to one-per-line
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87dac6295c1d062148af3fc51149eac418270408">87dac629</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-22T07:00:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">travis-ci: Only un-shallow for PIDL
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c32fa9bb22190a2809eaed2cfdb12c43613c61bb">c32fa9bb</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-22T07:00:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">travis-ci: Use Gold linker for faster builds
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0879be975873b5972b791bcad428a68573c77b69">0879be97</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-22T07:00:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Use the same #ifdef for is_our_primary_domain() as the only caller
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ef35fbfc8ca3f8583507c3b55cab1304290a204d">ef35fbfc</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-22T07:00:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-libnet: move rpc_join label into HAVE_ADS block with only caller
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3966342a1817b84d78e0c6687b4e7dc6d71f3c41">3966342a</a></strong>
<div>
<span>by Jamie McClymont</span>
<i>at 2018-03-22T07:00:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Clear environment before provision
Currently, if an environment is being provisioned after a test which used
ad_member_rfc2307, the provisioning process has all of the following in its
environment:
{
'DC_NETBIOSNAME' => 'LOCALDC',
'DC_PASSWORD' => 'locDCpass1',
'DC_SERVER_IP' => '127.0.0.21',
'DC_SERVER_IPV6' => 'fd00:0000:0000:0000:0000:0000:5357:5f15',
'DC_SERVER' => 'localdc',
'DC_USERNAME' => 'Administrator',
'DOMAIN' => 'SAMBADOMAIN',
'LOCAL_PATH' => '/.../st/ad_member_rfc2307/share',
'LOCK_DIR' => '/.../st/ad_member_rfc2307/lockdir',
'NETBIOSNAME' => 'RFC2307MEMBER',
'NMBD_SOCKET_DIR' => '/.../st/ad_member_rfc2307/nmbd',
'NSS_WRAPPER_GROUP' => '/.../st/ad_member_rfc2307/private/group',
'NSS_WRAPPER_HOSTNAME' => 'rfc2307member.samba.example.com',
'NSS_WRAPPER_HOSTS' => '/.../st/hosts',
'NSS_WRAPPER_MODULE_FN_PREFIX' => 'winbind',
'NSS_WRAPPER_MODULE_SO_PATH' => '/.../bin/default/nsswitch/libnss-wrapper-winbind.so',
'NSS_WRAPPER_PASSWD' => '/.../st/ad_member_rfc2307/private/passwd',
'PASSWORD' => 'loCalMemberPass',
'REALM' => 'SAMBA.EXAMPLE.COM',
'RESOLV_WRAPPER_HOSTS' => '/.../st/dns_host_file',
'SELFTEST_WINBINDD_SOCKET_DIR' => '/.../st/ad_member_rfc2307/winbindd',
'SERVER_IP' => '127.0.0.34',
'SERVER_IPV6' => 'fd00:0000:0000:0000:0000:0000:5357:5f22',
'SERVER' => 'RFC2307MEMBER',
'USERID' => '55668',
'USERNAME' => 'jamiemcclymont',
}
Unsurprisingly, some of these can cause issues for the provisioning process, if
a reduced subset of tests is being run which causes the provision to encounter
never-before-seen pairs of adjacent environments.
For example, a run with only
TESTS='--include-env=vampire_dc --include-env=ad_member_rfc2307'
would fail to start up the vampire_dc with:
Could not find machine account in secrets database:
Failed to fetch machine account password from secrets.ldb:
Could not find entry to match filter:
'(&(flatname=SAMBADOMAIN)(objectclass=primaryDomain))' base: 'cn=Primary Domains': No such object: dsdb_search at ../source4/dsdb/common/util.c:4641
Signed-off-by: Jamie McClymont <jamiemcclymont@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba805dcd6f95748d77e24d5de7c31af2ff5848b1">ba805dcd</a></strong>
<div>
<span>by Jamie McClymont</span>
<i>at 2018-03-22T07:00:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:selftest: explicitly set NSS/RESOLV_WAPPER_* in wait_for_start
These variables were previously set directly on the selftest process
for the purpose of making this ldbsearch call, allowing them to leak
into other environments.
Signed-off-by: Jamie McClymont <jamiemcclymont@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd1f8cdf6bd1fb9c881d96957d709b0f517852bb">dd1f8cdf</a></strong>
<div>
<span>by Jamie McClymont</span>
<i>at 2018-03-22T12:26:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: consistently produce high-res UTC time
Currently some subunit reporters throughout the codebase provide low-res time,
meaning timestamps jump back and forth in the subunit file. Also, some subunit
reporters produce UTC timestamps while others produce local time. UTC was chosen
as the standard for this commit since all of the timestamps end with a Z (= Zulu
= UTC).
Signed-off-by: Jamie McClymont <jamiemcclymont@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Mar 22 13:26:44 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/42d6dd2f30b6c3b3176bd1f378422a2eb62b1008">42d6dd2f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-22T17:26:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: always set vuid in check_user_ok()
A SMB session reauth will have invalidated conn->vuid via
conn_clear_vuid_caches().
Ensure conn->vuid always has the vuid of the current user in
check_user_ok().
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13351
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Mar 22 18:26:04 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/35ca6161f1f78d8f93cb2ec90083c037c0bfe88d">35ca6161</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-03-23T00:59:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Fix probably a copy&paste error in namemap_cache_set_sid2name()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13350
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Mar 23 01:59:08 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8fd73b389177f0622c3a6935a986e2581f7f661e">8fd73b38</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-23T01:32:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Align cleanup of tmpkpasswdscript with scripts that use it
Some scripts removed it without creating it and the others created it
and did not remove it.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e13349093923e754884a30db8c6b4f8928b32dad">e1334909</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-23T01:32:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Ensure tmpkpasswdscript is always under $PREFIX
Otherwise it might not be removed at the end of the test
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b9f0c7f93c058685e24d104432978bd40b94b49f">b9f0c7f9</a></strong>
<div>
<span>by Timur I. Bakeyev</span>
<i>at 2018-03-23T06:25:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix invocation of gnutls_aead_cipher_encrypt()
Which was failing with GNUTLS_E_SHORT_MEMORY_BUFFER - The given memory
buffer is too short to hold parameters.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13352
Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Fri Mar 23 07:25:30 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/708abbf3065120ffa2b3a9bf4b62912951d8bf0e">708abbf3</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba python tests: convert print func to be py2/py3 compatible
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aacbe1b65ccf6f75d26bcae517632e09552f23ca">aacbe1b6</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: convert print func to be py2/py3 compatible
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c251740b42b04eb0c277bc7975170e0fa784ebf">9c251740</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba python libs: convert print func to be py2/py3 compatible
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a8aab19b90324a02f11cd09c79b8b38522f451ca">a8aab19b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/dsdb: convert print func to be py2/py3 compatible
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/66a9b4dc66022a0059d37dae0c0e713d7588051f">66a9b4dc</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/script: convert print func to be py2/py3 compatible
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd5c347da5847980406978a5d199c36299d2cdf4">dd5c347d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting: convert print func to be py2/py3 compatible
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/66ea49130dd486e86aaa6df37d41dc3f27fdf772">66ea4913</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs: convert print func to be py2/py3 compatible
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bebdefeba912be4ff5bd93438151101671ecceda">bebdefeb</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: convert print func to be py2/py3 compatible
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/40e7d5799936cdfc079a0c7c21d277ad61696984">40e7d579</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: convert print func to be py2/py3 compatible
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/220f19fce045a80d8c031b684b1edf8c2e33a445">220f19fc</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/script/tests: convert print func to be py2/py3 compatible
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a64f77d4f72e1c92562f7fa262cc2a4db413536">2a64f77d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script: convert print func to be py2/py3 compatible
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b897d6d1c58df0d0914cfcb063d0f60943b1332">7b897d6d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/credentials/test: convert print func to be py2/py3 compatible
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0844c5aa22c60404044b4e6dfa51ec301194cb2a">0844c5aa</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/tdb: convert print func to be py2/py3 compatible
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cd1136f39bba306419ef19c2c0884e694a59f2d0">cd1136f3</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-03-23T06:28:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">README.Coding: mention compatible Python versions
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8ca43ec8e27bd4fabf9630b3f10cc0e4fcc04894">8ca43ec8</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-03-23T06:28:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">README.Coding: remove reference to non-existent prog_guide4.txt
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/04487198a77708544f6bdefd21c660160e6ec236">04487198</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/nbt: Fix illegal tuple index access.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0fa93f5fe99bd31c3f13241960c4ac600197c837">0fa93f5f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: Add simple python netbios test python2 only for the moment
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/330bbf7c3cfadd7f07fb5a83c5a7473c93e127dc">330bbf7c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python3 port for netbios module
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c02d5cafe2e0a8dc97bd161bcb5b9af5b151dd4">4c02d5ca</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable netbios python test for python3 too
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0d65c1ef65b1485ae772ac87a52bb58611d45c72">0d65c1ef</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb: python3 api should take 'bytes'
Attributes are properly represented by 'bytes' and *maybe* can be
converted into strings (if they are text).
py_dsdb_normalise_attributes currently expects strings, this is fine
in python2 however in python3 we need to actually pass a 'bytes'
class.
Signed-off-by: Noel Power <noel.power@suse.com>
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aea433ee0c87d42f670aa8b9e068b80cf2d9ef09">aea433ee</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Add compatability helpers to determine if type is really bytes
py3compat has PyBytes_Check macro which evalates to PyString_Check in
python2. To help switch behaviour based on whether you are dealing
with the bytes type the following macros have been added.
IsPy3Bytes
IsPy3BytesOrString
IsPy3Bytes will evaluate to false in python2 and will return the
expected result in python3. IsPy3BytesOrString will test for string
type alone in python2 or bytes and string in python3.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/18a5afa6fb3ac016db23be072a69b0b1378209b3">18a5afa6</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/librpc: GUID should accept string or bytes in python3
In python3 you can't store a binary blob GUID in a string class, you
need to use 'bytes'. This change ensures python2 code continues to use
a string and in python3 both 'bytes' and 'string' are supported.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cd5a4519b111993f8aef41c564de8ec359602507">cd5a4519</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba python tests: Ensure GUIDTests cover all input formats
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f6db12e236d3774b14e0af14889b0709cab3af0b">f6db12e2</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-03-23T06:28:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/dcerpc/misc.GUID: test that long-form py3 bytes works
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bb88292cee5289742b72ff0249f01d527920301f">bb88292c</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-03-23T06:28:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/dcerpc/misc.GUID: improve tests
1. Merge tests for different formats into a for loop, make it easy to
read and extend.
2. Add test for invalid formats.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a032ea5bf842da35099930008e308f35668d7caf">a032ea5b</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-03-23T06:28:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libgpo: port samba.gpo to python3
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a7cdad3e77ee78a9db20ae48dfe5e5c65597414">6a7cdad3</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-03-23T06:28:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add python tests for samba.gpo module
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4f036497f1e8825d5ebe3a14c528ddf6cb1a4b22">4f036497</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-03-23T06:28:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python3 port for dckeytab module
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e29a75e74a089c6d786cf7ae8a26d4f778ddccb6">e29a75e7</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-03-23T06:28:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add tests for dckeytab python module
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da72c4018ed92feab28025f8c6c29894f4c8691c">da72c401</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-23T11:00:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Move "none" environment to samba-none-env
This takes this part of the test out of the main, slow samba task
but also keeps it away from samba-o3 which is up against the 50min
budget on travis-ci.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Mar 23 12:00:40 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d418d0ca33afb41a793a2fff19ca68871aa5e9ef">d418d0ca</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-24T01:31:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Add a cache of the samr and lsa handles for the passdb domain
This domain is very close, in AD DC configurations over a internal ncacn_np pipe
and otherwise in the same process via C linking. It is however very expensive
to re-create the binding handle per SID->name lookup, so keep a cache.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fc9150dcab231fe9beb72e198b0c2742d5f2505f">fc9150dc</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-24T01:31:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Do re-connect if the RPC call fails in the passdb case
This is very, very unlikely but possible as in the AD case the RPC server is in
another process that may eventually be able to restart.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2610a3f2f7437309b259387e286e6e43d654b6e4">2610a3f2</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-24T06:21:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Use talloc_zero_array for consistency with other winbindd_domain allocators
The other allocator for this structure uses talloc_zero()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Mar 24 07:21:37 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/92a68af1a8473dc2a5d9d6036830f944e968606d">92a68af1</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-27T02:27:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-client: Do not try to allocate 0 sized record
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13356
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e37be92bfb790150b3791bef552aa4acf8f78b7">4e37be92</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-27T02:27:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-client: Add missing initialization of tevent_context
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13356
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/147ff850aada14b4930e705ed5b065c5eca22bac">147ff850</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-27T02:27:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Convert database map to a linked list in fake_ctdbd
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2de660722d4e4faf01d7cb251746af6497a777a9">2de66072</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-27T02:27:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add dbdir option for creating databases in fake_ctdbd
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/50e25418e0807ec8ef0afd9b529b975fa3bcba18">50e25418</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-27T02:27:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Implement database attach control in fake_ctdbd
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/14bdbef9c111a358e7f6e64abd8d2e4bae997976">14bdbef9</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-27T02:27:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add database attach tests
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e5e8469262344f60b7ecca9e2d1cc6aba54f6f9">0e5e8469</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-27T02:27:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use seqnum from tdb if available in fake_ctdbd
This also adds the lower level ltdb read/write functions required to
read seqnum from database.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5be29b792d2a48efcddc9137cbee250f42d31a2d">5be29b79</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-27T02:27:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add req_call processing in fake_ctdbd
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7c30d4791d0b3c7e47bf8f12a66d0450d1190270">7c30d479</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-27T02:27:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add volatile database tests
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8250956c9222264a774bf4fb7c86527630ee2655">8250956c</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-27T02:27:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Implement transaction control in fake_ctdbd
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a8e425767faf1dbe671eb25bb4cfcddfb5a7bb5">2a8e4257</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-27T02:27:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add persistent database tests
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a5fb33e277217fc8526f409a04ba0718c20cefe8">a5fb33e2</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-27T02:27:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Implement traverse control in fake_ctdbd
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c86565885d8aefc3d67ed80165332bfaa3f33ea4">c8656588</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-27T02:27:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add database traverse tests
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7da9802acdb1ec1d76050064f54aae38b21a03d4">7da9802a</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-27T02:27:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add debug messages for unimplemented functions
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ce5116cfb3990de8a088012bee9fd9f94bd21c97">ce5116cf</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-27T07:06:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Don't expand octal escapes in unit test output
The echo command in dash expands octal escapes in strings by default
but the echo command in bash doesn't. Since the behaviour is
ill-defined, use printf to handle affected strings. However, ensure
that these strings aren't used as format strings.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue Mar 27 09:06:14 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77d88d75f6262a855e818a9b2b4018f8b6ced7b0">77d88d75</a></strong>
<div>
<span>by Eric Vannier</span>
<i>at 2018-03-27T11:50:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Allow AESNI to be used on all processor supporting AESNI, not just Intel's This improves performance/reduced CPU usage. Tests performed: - Ran on Ivy Bridge and Ryzen and verified that AESNI is detected (crypto tests) - Ran on Ryzen, and observed 50% increased speed.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13302
Signed-off-by: Eric Vannier <evannier@google.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Mar 27 13:50:09 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a8e825c41c4b829a174451bd02162c763a2e887e">a8e825c4</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci: Create swap space to work around the 2G image
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/75d2be7da584a017beab493355cb88ce7dc61f4a">75d2be7d</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-03-27T21:03:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci: set docker image and change tag
1. Specify docker image to use in gitlab-ci.yml
2. Change tag autobuild to docker
So we can use gitlab.com shared runners.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2532c0db0ce2c189ab6fc96ab5c5e56ce5b17ecd">2532c0db</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-03-27T21:03:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci: add git variable to speed up clone
Set GIT_STATEGY to fetch, and GIT_DEPTH to 3.
This will speed up cloning for repos.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7544f3574168d4a41857550628e4391392e39f5b">7544f357</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Run nt4_dc and nt4_member tests in parallel
These do not interact with the main AD DC environments, so can run in parallel
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bfee4414298b9bba0c1a1b6f1416f179ad1b3863">bfee4414</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">travis-ci: Run new samba-nt4 environment
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fd0368999e80839d7b90379a53732431504ea646">fd036899</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci: Add samba-nt4 environment to the CI
This parallel build is de-coupled from the main samba build
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3fd29c05f347dfa305d93be9202fbae56570d223">3fd29c05</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Do not run smb2.notify against nt4_dc and ad_dc
This is a slow test and we need to keep the time on ad_dc down to below 50mins total
for travis-ci.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d47fb2232bdbbc401d59b86d2641078c6e7bfdc6">d47fb223</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Run all "ad_dc" environment tests in samba-ad-dc
This allows us not to run ad_dc tests in the main build, making the
autobuild process faster. The ad_dc tests run in less than 50mins
on travis-ci, which allows this part of the tests to be run.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e4a969ccc55758b402483e7e1b31ab054624c6c5">e4a969cc</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Remove fileserver tests from the main build
Again, this is to allow these to run in the 50min timelimit
of travis-ci and so gain test coverage.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9a6fdadbb2864678deb4c6cb85c7991d07576ab">a9a6fdad</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Move base.delaywrite tests to fileserver environment
This aims to keep the ad_dc tests well below 50mins for travis CI and
base.delaywrite is very slow.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0668303a3a6947dc57595bed1a78df3c0a628f68">0668303a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Move smbtorture3 tests to fileserver environment
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d6ac8beacf0762e786e57c07fd56fb4267a88b6b">d6ac8bea</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Try and test different configure options for new environments
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fafbeb18900b66df66e9b89276b66e2b66f49965">fafbeb18</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Move slower base.deny1 and base.deny2 to fileserver environment
This avoids these running in the ad_dc environment which we need to get under 50mins for
travis-ci.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d92087487d9e4c86f807631fc18a6d136f4841b4">d9208748</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Move samba.tests.samba_tool{.dnscmd,.sites} to chgdcpass
This helps reduce the runtime of ad_dc which needs to be under 50mins
including build time to run on travis-ci.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/474b39ce56c006b922118fae176d9e5a5f62ad49">474b39ce</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci: Set shared and private tags to allow builds that need ext4 to pass
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/56191dcfb783913742a373671901def7db28e842">56191dcf</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Split up the build further with samba-ad-dc-2
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/606ba7a0ba32313de0d0ab99bdcc288a6e4c02f8">606ba7a0</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab: Run fileserver tests on "private" not "shared"
This might make the delaywrite tests pass
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/97d020315148a4716395c808df2240099b66710a">97d02031</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Run all envs that depend on ad_dc in the ad_dc job
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5509fdea19552ec4c08f2cebe8e72f316dacd3be">5509fdea</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Do not run raw.notify, smb2.oplock and raw.oplock twice
These are slower tests that do not need to be run against the ad_dc configuration
in particular.
This saves time in the ad_dc job which needs to stay under 50mins to
pass on travis-ci (and faster tests are better for everyone anyway).
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/106793a42c4cc3d6209190ffa2da7190a247c1be">106793a4</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Do not run krb5.kdc machine account test against ad_dc
This code is already well tested against fl2008r2dc and just as per
8f1557a2c43e287c07723c16be78e1d858f4111d this test is slow and we can afford to be
more selective here.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f4fe1c836e492ff15611be05271e9d218ac5fc10">f4fe1c83</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci: Split up build_samba_others and build_ctdb tasks
These make too much output and the shared runners on GitLab CI object to
sending more than 4MB of output.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8c429bddfd88a3083a5e576d6562026a9692aab">f8c429bd</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Move slow raw_protocol test to chgdcpass environment
The ad_dc environment is busy and we need to keep it under 50mins for travis CI, so run
this on a different environment with a shorter runtime.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a93b1f6fd3c534e868a883621163e434dcf81bd6">a93b1f6f</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T21:03:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Do not run *.lock tests against both nt4_dc and ad_dc
This part of the protocol is not changed by being an AD DC.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d955ab2239dbeab649e69520e36109ca2c49ab89">d955ab22</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-03-27T23:53:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Run net.api.become.dc against less roles
This test is slower than many and need not be run five times.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Mar 28 01:53:56 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2f33b18d844802e228843af3f225dbbe13af333e">2f33b18d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-script: Drop CTDB_MANAGED_SERVICES configuration option
This seems never to have caught on so reduce complexity.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cf866d66aa33f4729321ea491217f462c585bce0">cf866d66</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop unused functions
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ad081f91443a2f16eb72c14dbaf290b8b737f641">ad081f91</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Make FAKE_CTDB_STATE globally set
Lots of things depend on it.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fb2090762ec84075d44603c18c037d9cc774dfad">fb209076</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: New global variable FAKE_NETWORK_STATE
Stash all the network state in this directory.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f730c4b3a7f32a16403579173433a51446df49d">6f730c4b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Fix a bug in the ctdb stub's moveip command
This was writing garbage into the IP layout file and relevant tests
were passing by luck.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/06be4a652935e7fbda280a5782a135e9806c74f2">06be4a65</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop unused ctdb stub scriptstatus and xpnn commands
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d1d5fc969840639606f07f454127f6d6e8dea16">7d1d5fc9</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move ctdb stub code from case statement to functions
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/713804beecbd05ec0e5c0ef823130fe1fd59061c">713804be</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Update argument handling of ctdb stub functions
All functions are now called after shifting away the command name.
There is less churn that expected because some functions don't use any
arguments.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ce1b5b30d3badd2dac3ff4df67e60eb3f3c6bbbc">ce1b5b30</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Remove case statement in ctdb stub
This removes a lot of unnecessary clutter.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3bbf3e97ca312cdc017c3173e734c85ac6e156db">3bbf3e97</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move variable FAKE_CTDB_IFACES_DOWN into ctdb stub
It is the only user of this variable.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/26329aa035674bc5a5779b670b8daf6f18b148d7">26329aa0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move variable FAKE_IP_STATE into the ip stub
It is the only user of this variable.
This is now a subdirectory of FAKE_NETWORK_STATE.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ab89958817c6d37056c833f641ddcf4121e82557">ab899588</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Don't set FAKE_ETHTOOL_LINK_DOWN globally
This variable doesn't need to be set in a generic function and can be
set by the ethtool support functions
This is now a subdirectory of FAKE_NETWORK_STATE.
The down/up functions get reindented because the new 1st line should
be indented according to the new script indent-with-tabs style.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3571345667e56c77a969b54febfee4397c558bfd">35713456</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: New support functions setup_dbdir() and setup_date()
For now, these need to be called from setup_generic() to stop tests
from breaking.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e4a4532e5c417146da3a30c00d74b2032e16dc66">e4a4532e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Make date handling consistent in 00.ctdb tests
This duplicates the filter function but that will be fixed later.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6eec33c0a7089e0e91597269f66f90dd5263e3d8">6eec33c0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Tweak debug function
Output to stderr. Read from stdin if no arguments given, making it
possible to handle long lines using here documents.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3c82d3ae3d11130dfafc78e9b099298906d45a61">3c82d3ae</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: New function setup_numnodes()
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d7d4874df634e664a2331adabd4e437c8b3d95a">1d7d4874</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Clean up fake share handling
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/26e090dd4ea08a2a0d110ceead5ec11f77a0ff6a">26e090dd</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Clean up handling of CTDB_SCRIPT_VARDIR
Only set this in ctdb_set_pnn() and always use the PNN in the path.
Generic setup functions like setup_ctdb() will go away soon in favour
of more doing setup that is specific to the script being tested.
Therefore, call ctdb_set_pnn() in define_test() to ensure that
CTDB_SCRIPT_VARDIR is always set. Note that setup_ctdb() is never
called with an argument so the default PNN has always been 0.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bbd96993c85bd3203ff555f18279260acb5f7695">bbd96993</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Allow modularisation of event script testing support
local.sh is enormous. Allow per-event-script customisation.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bcb6cc28618dcd1952da12bfa1eeab51adb75fe6">bcb6cc28</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Create 00.ctdb.sh
Contains testing support used only by tests for 00.ctdb event script.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b4dd7e539c8e37a4a594f3cd3a6819fc40a5594">7b4dd7e5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Create 01.reclock.sh
Contains testing support used only by tests for 01.reclock event
script.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f5a70415dd5377b59f2f2de8d60d6c5f35b9f89d">f5a70415</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Create 05.system.sh
Contains testing support used only by tests for 05.system event script.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ee6052e689c676fee1d3088befe9763940edb248">ee6052e6</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Create 10.interface.sh
Contains testing support used only by tests for 10.interface event
script.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/916b7f947e5c499dc7969def77b734f704c7ffb4">916b7f94</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Create 11.natgw.sh
Contains testing support used only by tests for 11.natgw event script.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e4899293355c6a139d59b22368e2425adea84df9">e4899293</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Create 13.per_ip_routing.sh
Contains testing support used only by tests for 13.per_ip_routing
event script.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/38b54a60f52ac72a5d20b72f4ccb79c4f62b3ae2">38b54a60</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Create 20.multipathd.sh
Contains testing support used only by tests for 20.multipathd event
script.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f306c2d8078af231b0406e579f296c5fec3382e7">f306c2d8</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Create 40.vsftpd.sh
Contains testing support used only by tests for 40.vsftpd event
script.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f33f4b3a2317f0d3c48b9b36c9af4af2ca219a10">f33f4b3a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Create 41.httpd.sh
Contains testing support used only by tests for 41.httpd event script.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a51e4ea042f71e1edddb4db19af8a70193900213">a51e4ea0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Create 49.winbind.sh
Contains testing support used only by tests for 49.winbind event
script.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/32d8483b071dc93bbdeff97c9fbcfa34699dea6f">32d8483b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Create 50.samba.sh
Contains testing support used only by tests for 50.samba event script.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d91de549b56249d8d1cdb62d441142068b9e3b4">7d91de54</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Create 60.nfs.sh and 06.nfs.sh
Contains testing support used only by tests for 60.nfs and 06.nfs
event scripts.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0f080cebef01affb88df7dc5a301cbb9efcf5ee4">0f080ceb</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Create 91.lvs.sh
Contains testing support used only by tests for 91.lvs event scripts.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0f78e0b4c404569ffe5d0091c8f2fdcca5c65455">0f78e0b4</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Create statd-callout.sh
Contains testing support used only by tests for statd-callout script.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b6cde6ff9f360e811c357ad7a461dfc7552e10d3">b6cde6ff</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 05.system.sh simple 80 column fixups
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bfd2d70fc490de94d04b91e0c8b5170bd915b314">bfd2d70f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 10.interface.sh simple 80 column fixups
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4430e22d0cbb92e0f2066ac9359eb287306ed85a">4430e22d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 11.natgw.sh simple 80 column fixups
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b526968bcf920c895a24d4bc447716721132166d">b526968b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 20.multipathd.sh 80 column fixups
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/44b29982f41729fbf7cae903f768b384e4a28824">44b29982</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 60.nfs.sh simple 80 column fixups and reordering
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/90387592598cf81db1dea53bc9ba077ce5eb26d7">90387592</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: statd-callout.sh simple 80 column fixups
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5815c32d0121d6f7b0741128383d3da923a3916a">5815c32d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Define generic setup() function
Create default setup() function that aborts. This function will be
redefined by each support script and used to do the setup.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/db5c6041522f72fa5a3f0f053f076769dbbab352">db5c6041</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 00.ctdb testing setup modularisation
Switch to generic setup() function and set variables there.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7cddc88d0386bbe3b5c2fb18dc28b4e9fa75f727">7cddc88d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 01.reclock event script setup modularisation
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d8232476ed21c014a6452f2fc4ddb8ae275d61b8">d8232476</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 05.system event script setup modularisation
Do initial test setup using setup() function. Rename usage setting
functions to make them more obvious.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8c81fb9d9a27ac836f24c90b381fcfba586d9fac">8c81fb9d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 10.interface event script setup modularisation
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a63c45608053d1f461f83f21cb2ca3471847d987">a63c4560</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 11.natgw event script setup modularisation
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0ca1cfcf6130c88c6808c4f8c37e4d7ff49f46b1">0ca1cfcf</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 13.per_ip_routing event script setup modularisation
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0bc1b4b27e5ffaff471118480b1ff00199839a78">0bc1b4b2</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 20.multipathd event script setup modularisation
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3172dc724473ef91076f97e9bdb0d2cdd16fa712">3172dc72</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 31.clamd event script setup modularisation
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99c3fd3460da162d8c66e837ef42f28de48dd8fe">99c3fd34</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 40.vsftpd event script setup modularisation
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/29eb410f265029e690b8371b0141d251a7cadd36">29eb410f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 41.httpd event script setup modularisation
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/34eba35c61f5123d08a2403817e99777decb0617">34eba35c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 49.winbind event script setup modularisation
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ab5bc195c40f3be84f72745a334b0b12f4b7f8e2">ab5bc195</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 50.samba event script setup modularisation
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/042a5101fc401eb023ee010896da75279e2a7d9c">042a5101</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 60.nfs (and 06.nfs) event script setup modularisation
Includes gratuitous changes to get lines below 80 columns.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8ee51d2f2d5a2b1369989e5250d6e89f2f12179c">8ee51d2f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: 91.lvs event script setup modularisation
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/58db0dbeda788c975c422412e912c4c23f5141a1">58db0dbe</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: statd-callout script setup modularisation
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6c5f7c0003ccbf99a00b8ec12b52e0ea97521f83">6c5f7c00</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Remove unused functions and stubs
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1c9b6c39925a9243179ba61a7c4476b35023c08e">1c9b6c39</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Clean up function detect_init_style()
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b18221529e242120ced0cee6592fb733950f1f5">8b182215</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Promote CTDB_INIT_STYLE to global options section
Clarify that the global options should be set in the system
configuration file.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b49977552741a739ae2bc2d6c0b3b5d4c36ee084">b4997755</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Split CTDB configuration loading
loadconfig() currently tries to load the CTDB configuration and also
any system configuration relevant to the current (event) script.
Instead add a new function load_system_config() to load the
distribution-specific system configuration for a component. Call this
directly in the rare scripts that need the system configuration.
Also call load_system_config when loading the CTDB configuration to
pull in anything from the CTDB system configuration. This is partly
for backward compatibility but also to get options that can be used
anywhere.
loadconfig() no longer takes an argument. It simply loads the CTDB
configuration.
Drop support for falling back to /etc/ctdb/sysconfig/ctdb (or
similar). Surely there's nobody who uses that!
Also, drop the indirection where loadconfig() calls _loadconfig().
This was used years ago as a test hook and is no longer required.
Inexplicably, this change introduces a new shellcheck test failure, so
silence this.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3712640d47d5e8e0b76ed2989779d2aae0ed73f6">3712640d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: New function setup_script_options()
Currently exports the variable assignment on each line. Later this
can be changed to handle actual per-script configuration.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/45de2b1d9b873d8be0f52ce90f059070aed6b22c">45de2b1d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use setup_script_options() in 05.system tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87cd76e0c62052fa0d28dfea3a5fc1088d5d883d">87cd76e0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use setup_script_options() in 10.interface tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b88a8188b0c5e945ee1c3135e4ff9a7520c3bdb">6b88a818</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use setup_script_options() in 11.natgw tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ef98333d6af7736f97eb19a273d43ce43bdbbfa2">ef98333d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use setup_script_options() in 13.per_ip_routing tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a16eb657d13d8f81b973481dfd7141407f204c0b">a16eb657</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use setup_script_options() in 20.multipathd tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/051458feb0208dd3cee1fed074d84e40fb5e65ea">051458fe</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use setup_script_options() in 31.clamd tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/17b8f12d1c5a99d7134018668e68302f19909582">17b8f12d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use setup_script_options() in 40.vsftpd tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3944fc4ae304c8e58c8fa0f7c3b98c5d8bd29845">3944fc4a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use setup_script_options() in 41.httpd tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ecda38c8940de073dc7de8894bc77eabb1cf4001">ecda38c8</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use setup_script_options() in 49.winbind tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/96ed6c34ba0d3513d7eeb3090a996bd0e369c4e4">96ed6c34</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use setup_script_options() in 50.samba tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a48bd342465ff78275ed83824c01aefdddca2b77">a48bd342</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use setup_script_options() in 60.nfs (and 06.nfs) tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e0c2b3a1e10c1e4557720933a0bd906901112e8e">e0c2b3a1</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use setup_script_options() in 91.lvs tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a2f8730c759438317ba3a0df08890075117e2525">a2f8730c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Add new function load_script_options()
For now this loads the global CTDB configuration too. This will
change in the future after things are properly modularised.
This also anticipates a future change where event scripts end with a
".script" suffix.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65ce5e2129d7c4ba7b1728ef1df6dd424ed65b49">65ce5e21</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Use load_script_options in event scripts
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/66cfddc61c77fa0eb7b8da05c34ae7eaf2596004">66cfddc6</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Script options into per-script file
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1db96ce26e555f1faa879ea4b29816f4ab2eb1a7">1db96ce2</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Rename setup_config() to setup_tunable_config()
Drop the "CTDB_SET_" prefix from variable names and add it back for
now. When there is a better way of setting tunables then this
function will support that.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/02fc52d69b2f74bb35150ddcec405c81da81f81f">02fc52d6</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T00:57:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Tunables are now loaded from ctdb.tunables
Using CTDB_SET_TunableVariables in the main configuration file is no
longer supported.
The only subtlety is an unexpected order change in one of the unit
test results. This is because the old implementation implicitly
sorted the tunable variables via the set command.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e0cf2fa766eed922e86428b2ecdf3da0a27bc9b">4e0cf2fa</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-03-28T05:27:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Delete unused fake /etc/sysconfig/ctdb file
The only remaining item is a setting of CTDB_DEBUGLEVEL, which is not
required.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed Mar 28 07:27:58 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/360804ed4f7d3ab7375ba68885fed4584ef0a438">360804ed</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-28T11:03:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndr_string: Fix a signed/unsigned glitch
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1cd0fe90cf642de4ab4d03819f87a13c20bd2805">1cd0fe90</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-28T14:08:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndr_string: Do overflow checks in ndr_push/pull_charset
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Mar 28 16:08:16 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b5925b3049998d2ac54720a24ab60ab78033374">8b5925b3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-28T22:21:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libads: Fix CID 1433606 Dereference before null check
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9ecc6f3b520ea6388a3b8d9f61cd2bbf16452400">9ecc6f3b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-28T22:21:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lsa_server: Fix CID 1433608 Dereference after null check
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1b7881ceec755e924c52083188762864d723367c">1b7881ce</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-28T22:21:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libads: Fix 1433611 Resource leak
Not really a memleak due to the passed-in talloc ctx, but this way it's cleaner
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bb7da3357388f7cf950455ca4f42cd7d43c3f02b">bb7da335</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-28T22:21:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Fix CID 1433614 Dereference after null check
This whole routine assumes module!=NULL, both in the successful as
well as in error cases. So checking for module!=NULL is confusing both
the reader as well as Coverity.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f3e98f41de25e3b52fd38f86317e428bfb53b287">f3e98f41</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-28T22:21:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: Fix CID 1433613 Operands don't affect result
Two changes: First, we can't check multiplication overflow after the
operation. This has to be done before with a division. Second, there
is no OFF_T_MAX, and both operands are size_t, so check for
SIZE_MAX. The result is assigned to off_t, but I'm not sure where the
automatic coercion from size_t to off_t would happen.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cfe8fa2c75426680d5253b52dc84e34d391f23e0">cfe8fa2c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-28T22:21:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbstatus: Fix CID 1128560 Dereference null return value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/67c31842b09799b07c25c06bddc181c65349f8fe">67c31842</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-28T22:21:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: Fix CID 1128559 Dereference null return value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/efa66c9ebf519dfaf194220652b3e5e01c303fb6">efa66c9e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-03-29T01:45:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libads: Fix CID 1349423 Resource leak
get_sorted_dc_list should already take care, but this way it's safer
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Mar 29 03:45:00 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2514bee0a3b0a12430e2679ee590075c54d4803a">2514bee0</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-29T18:31:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Files or directories can't be opened DELETE_ON_CLOSE without delete access.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13358
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53cdf7a9a18ed547eade4c3cdd80d286058e440d">53cdf7a9</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-29T18:31:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: Ensure a failed file create doesn't create the file.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13358
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/22fe8dcb77565495886244e88bb0433363d1f80a">22fe8dcb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-29T18:31:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: Test all combinations of file create to ensure behavior is the same.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13358
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/820b35bb1ceb445eb3659b67eedfb0a2f5b2f976">820b35bb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-29T18:31:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: Test all combinations of file open with existing file to ensure behavior is the same.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13358
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fd9084336e7e86ccec83141d880fd7c336c23b6c">fd908433</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-29T18:31:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: Test all combinations of directory create to ensure behavior is the same.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13358
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c98cd0f25edaae7558f18fd331e2fef3aabb61f2">c98cd0f2</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-29T21:13:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: Test all combinations of directory open with existing directory to ensure behavior is the same.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13358
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Mar 29 23:13:42 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/66052fdccd28922cf1caa2bc750e39051a6414cf">66052fdc</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-30T01:51:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: don't use the directory cache for SMB2/3
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13363
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Mar 30 03:51:48 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3ffc91813722c71f2dc4e6f3a8b3b4a2afc2e70b">3ffc9181</a></strong>
<div>
<span>by Jones Syue</span>
<i>at 2018-03-30T16:39:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: kernel oplocks. Fix assertion warning
Simply boolean 'ret' instead of 'ret = true'.
Signed-off-by: Jones Syue <jonessyue@qnap.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Mar 30 18:39:19 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/22299f9898ddb84db47b5372ca3cd49c3ec4a1f5">22299f98</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-03-30T22:07:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Fixing possible memory leak in ctdb_daemon_read_cb
In case of an error condition the further processing of the data is cancelled
and the callback returns. In such a scenario the data has to be free'd.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/611c9a0ba9472aae17a3099da20ea2d836cef84a">611c9a0b</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-03-30T22:07:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Fixing memory leak in ctdb_tcp_tnode_cb
It is expected by the caller(queue_process) that the callback is
free'ing the memory referenced by the data pointer.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aba3d508028567ccbfe8ea986d8f2b3f48af6215">aba3d508</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-03-30T22:07:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Fixing possible memory leak in ctdb_tcp_read_cb
In case of an error condition the further processing of the data is cancelled
and the callback returns. In such a scenario the data has to be free'd.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d6a9dc6e249fc1785a3b6e00bdee555f439b5d24">d6a9dc6e</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-03-30T22:07:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Use provided mem_ctx for newly allocated memory
ctdb_call_local is called with a mem_ctx parameter which should be used
for newly allocated memory.
This is safe because all allocations of this context are freed before
this function returns.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a2f2bf9e9706bc47c3d26ae40b7bb9658b8a9fa5">a2f2bf9e</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-03-30T22:07:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Use talloc_zero instead of zeroing attributes
Zero entire structure with talloc_zero on memory allocation instead of
setting each attribute individually.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3269cd67078ec28d72168e1a98ef4329243ffa7e">3269cd67</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-03-30T22:07:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-server: Cleanup ctdb_daemon_call_send_remote
Minor code cleanup and adding a temporary variable to improve readabilty.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b40bcb094d6aae00cae1b64a25ad3cdb39208449">b40bcb09</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-03-30T22:07:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-server: Only talloc_set_destructor when required
The destructor is only needed once the state got added to the DLIST.
Therefore, move the setting of the destructor to after the addition
of state to the DLIST.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/423d7e2460be16d0a66231d0e5b1c84d90ba5fe4">423d7e24</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-03-30T22:07:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-server: Replace the variable rc by something meaningful
Replace the varibale name "rc" in ctdb_start_revoke_ro_record
to prevent a mix-up with the common meaning of rc (return code).
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7248b82e56ad4009c5d5d91ce27af82ccd97bc33">7248b82e</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-03-30T22:07:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-server: Minor code cleanup
Cleanup ctdb_start_revoke_ro_record to improve readability.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/134223e4db52730e7a5dd059a815ece8bd4b6c41">134223e4</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-03-30T22:07:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-server: Add goto tag avoiding code duplication
Introduced err_out goto tag to prevent code duplication.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e8dba1908b34831944c1788de54abff1a5cf510d">e8dba190</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-03-31T01:45:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-server: Only set destructor if required
Set the detructor in ctdb_start_revoke_ro_record after the revokechild_handle
was added to the list.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Mar 31 03:45:51 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b75d2c650aa9ee632122fa87ea8a2a98f1fa613">6b75d2c6</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-03-31T06:34:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop "net serverid wipe" from 50.samba event script
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13359
There is no serverid database anymore.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Sat Mar 31 08:34:00 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f2ff61ce9e8ab56d8a69fce29c9f214d5d98f89e">f2ff61ce</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-03T14:41:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/util: remove unused '#include <sys/syscall.h>' from tests/tfork.c
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13342
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/329a229af3c3c9475b9254ca68c413ec18fa3b71">329a229a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-03T14:41:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/replace: define __[u]intptr_t_defined if we prove an replacement
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13344
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b8c30abb02f461f16af4da83eecd173993974dc1">b8c30abb</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-03T14:41:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: maintain prototypes for the linux based functions only once
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13344
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d5be3b3279162005d9ebea2eda71d455e4c48739">d5be3b32</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-03T14:41:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: add some const to _nss_winbind_initgroups_dyn() prototype
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13344
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dc160247d13e2c63574a7e7ec7720fc4c690483b">dc160247</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-03T14:41:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: fix the developer build of nsswitch/wins.c on freebsd 11
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13344
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fb7b67af984812784756574df4f0fb55d472181b">fb7b67af</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-03T14:41:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: fix the picky-developer build of vfs_virusfilter.c on FreeBSD 11
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13344
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/74278a70389e2479d80ec5c88b01a09c141e8d39">74278a70</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-03T14:41:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: make virusfilter_io_connect_path() more portable
We have existing utility functions to prepare a socket.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13343
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ae77db3b29ef08e1f74aa413049b995a598a5dd">7ae77db3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-03T14:41:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/crypto: avoid 'return void_function();' which isn't portable
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13343
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/666dda907b7f190b2dff1f2639bd2518240b9fb2">666dda90</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-03T14:41:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb/tests: avoid 'return void_function();' which isn't portable
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13343
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/702665cc52d5dc05ae636519e1ffe9c296f5ef77">702665cc</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-03T18:18:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: fix the build of vfs_aixacl2.c
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13345
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Apr 3 20:18:58 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/63e05322e2efec96edf6652a76fe93ae34b5c4c6">63e05322</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Update pam_wrapper to version 1.0.6
This fixes compilation with -Wstrict-overflow=2.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be709e8cde584dcc94d394ae3ae49e9342bb5d34">be709e8c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Add test for ldb_qsort()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/889d1daf8758841a8252916c4e85932ac6a6e6a6">889d1daf</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Fix overflow checks
This fixes compilation with -Wstrict-overflow=2.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/41895045bae5f71e964d767ce676172cc1e6768c">41895045</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Fix size type in cmocka
This fixes compilation with -Wstrict-overflow=2.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bc3834d6910c71159ee5e6dc3b04475706d9e846">bc3834d6</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Fix size types in fgets_slash()
This fixes compilation with -Wstrict-overflow=2.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c4a73ccd8f23eceae3ee598d9841860e7342230d">c4a73ccd</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:registry: Fix size type and loop
This fixes compilation with -Wstrict-overflow=2.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/28dec65cc26c4b53c1e1c9077edcdb540fb29551">28dec65c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:client: Fix size types and loop
This fixes compilation with -Wstrict-overflow=2.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa17db1f4061920512396032fcd3c7c8a4a8f38f">aa17db1f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">heimdal: Fix size types and array access
This fixes compilation with -Wstrict-overflow=2.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/abc9c56021db877a23f934805df0589d7a1b99f4">abc9c560</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Fix size types in torture_create_procs()
This fixes compilation with -Wstrict-overflow=2.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/06940155f315529c5b523f8bacdaf60036254bdc">06940155</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Fix size types in reply_negprot()
This fixes compilation with -Wstrict-overflow=2.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0459a2968fe4d39444f3a0cd8ccba8eeea19fd47">0459a296</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:printing: Fix size types
This fixes compilation with -Wstrict-overflow=2.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/22a28ac8acb44d88d866eb29af6b1161d1013d48">22a28ac8</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:spoolss: Fix size types
This fixes compilation with -Wstrict-overflow=2.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be4cb4a70bb033f649a5cb272d104e967a6deab3">be4cb4a7</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:client: Fix size types
This fixes compilation with -Wstrict-overflow=2.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/deccc84b73b0fa550cdf28a5fd4569d1a8477679">deccc84b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:torture: Fix size types in make_nonstd_fd()
This fixes compilation with -Wstrict-overflow=2.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/23bedb334daeeed46f2047bf383aa11545407f57">23bedb33</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: Update getdate.y to work with newer bison versions
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/083e52f5612c03f1b1741a953b74281457548289">083e52f5</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: Generate new getdate.c with bison
bison -o source3/modules/getdate.c source3/modules/getdate.y<Paste>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a12e12e98684d6928f888a81088987d85bc2ed45">a12e12e9</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Add missing cflags_end argument to SAMBA_MODULE
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/08e350b54f5673d34fbaa1e566307187f16b20c6">08e350b5</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Check for -Wno-strict-overflow
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3e0f538c74edc79fe579049c0cafd915067e9bf9">3e0f538c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T18:20:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: Set -Wno-strict-overflow for getdate if supported
bison generates an C89 files which does some weired things.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ebb1dd18e58df1ea5da20bc34d9900290ada65f">5ebb1dd1</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-03T21:08:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Add missing cflags_end argument to SAMBA_BINARY
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Apr 3 23:08:33 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/37dcbe173068514aeda6361c7168c465bdf65415">37dcbe17</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-03T22:44:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libhttp: Fix CID 1273001 Dereference after null check
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7164e00f40f15e56dc0f3d727bd4955e4927d45a">7164e00f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-03T22:44:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: Fix CID 710748 Resource leak
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ab6228c342e79758c50f2d7c035c318224a6defb">ab6228c3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-03T22:44:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lsasrv: Fix CID 241331 Self assignment
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd370f8a511bf13c48c5cd34c41fbb630172349f">dd370f8a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-03T22:44:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lsasrv: Fix CID 241332 Self assignment
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c31e5371bf3334964c078c963de7b5db7236ff35">c31e5371</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-03T22:44:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix CID 240676 Dereference after null check
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7bffd65bb570eb3b8a4502d52a18c98b7b640645">7bffd65b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-03T22:44:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">cldap: Avoid a ZERO_STRUCTP
This is done implicitly by tevent_req_create
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/64b144dce315642dcf606be4eacefab7036bb6c7">64b144dc</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-03T22:44:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Fix CID 1034744 Dereference after null check
This HIGHLY looks like a cut&paste error...
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/76babda4ef13111e402fcfac10d6f9c3d7bb75e9">76babda4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-03T22:44:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">groupdb: Fix CID 1167984 Ignoring number of bytes read
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2d7a3e0648f4f3175f453cf15050846fafdea745">2d7a3e06</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-03T22:44:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libads: Fix CID 1272809 Free of address-of expression
Look at the other SAFE_FREE's in this function...
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/925d1f23291c4bdbc832977b2b4577964b8301c8">925d1f23</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-03T22:44:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Fix CID 1034966 Uninitialized scalar variable
"continue" in a do-while loop jumps to the "while"-check, so "id_exists" needs
to be initialized by that point.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13367
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/54fc90025b0100dfa87e196d75b38ac87c40e7ee">54fc9002</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-03T22:44:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">utils: Fix CID 1035541 Uninitialized scalar variable
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5b52c308af6a21d290b964ddc64128b61faaaf6a">5b52c308</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-03T22:44:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pygpo: Fix CID 1422263 Resource leak
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bc16f7dafbcb73142ee300db7d4c23b0a322779e">bc16f7da</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-03T22:44:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pdb_ldap: Fix CID 1363266 Resource leak
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/54db80e6e73169848aec89029ac2640a14c9af11">54db80e6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-03T22:44:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: Fix CID 1414752 Resource leak
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c3341ed29a2182a3a5f6c05110acd25513767b1a">c3341ed2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-03T22:44:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: Avoid tallocs
Not really performance critical, but I think it's worth establishing sample
code to use more stack variables than going out to talloc.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/015e04660ccd340b65feedb2954062f614b400f7">015e0466</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-03T22:44:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_wrap: Fix CID 1034833 Resource leak
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f2df0e507b39e1258c4002916560e11fa25a776d">f2df0e50</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-04T01:51:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_wrap: Fix CID 1414755 Resource leak
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Apr 4 03:51:00 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c42c721b980d87588513751c12f8bb9f88e28cd5">c42c721b</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-04-04T04:35:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Remove double sanity checks from ctdb_daemon_read_cb
Within ctdb_daemon_read_cb the provided data is checked for sanity,
e.g. correct size and content. This is not required because it was
done already by the caller (queue_process).
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b8f7f42565d35e20ba576db101bd5eb27f90e903">b8f7f425</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-04-04T07:31:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Remove double sanity checks from ctdb_tcp_read_cb
Within ctdb_tcp_read_cb the provided data is checked for sanity,
e.g. correct size and content. This is not required because it was
done already by the caller(queue_process).
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Wed Apr 4 09:31:04 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e895b6cf4a7eb3d50d618a022be74db85975bf69">e895b6cf</a></strong>
<div>
<span>by Lutz Justen</span>
<i>at 2018-04-04T21:52:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: lib: messages: Don't use the result of sec_init() before calling sec_init().
Commit ad8c7171ba86e8a47d78b0c7329bb814e5a8871e accidently
moved sec_init() to the point after sec_initial_uid() is
called in the call to directory_create_or_exist_strict().
I missed this in the review (sorry). This works as root
as initial_uid/initial_gid are static (and so initialized
as zero) but doesn't work on ChromeOS as this code isn't
running as root.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13368
Signed-off-by: Lutz Justen <ljusten@google.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Apr 4 23:52:02 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/90c02ec64d0e3c860f8d6906cf849bdd2c7bcc54">90c02ec6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-04T23:10:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">credentials: Fix CID 1414796 Explicit null dereferenced
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cc746385bf1b6b8a45d66af092f90a6228a93d78">cc746385</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-04T23:10:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">credentials: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/91c0f497816bb88d8935a8a79c146c08379ecf53">91c0f497</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-04T23:10:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Handle long-running smb2cli_notify
This likely runs into a timeout. Properly cancel the smb2 request,
allowing the higher-level caller to re-issue this request on an existing
handle.
I did not see a proper way to achieve this with tevent_req_set_endtime or
something like that.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/abfe482828e8c1dc233d67657a4d11a91a731f70">abfe4828</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-04T23:10:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Handle IO_TIMEOUT in cli_smb2_notify properly
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1452677ef0044815df0702de5424d4711e18144b">1452677e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-05T02:05:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbclient: Handle ENUM_DIR in "notify" command
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Apr 5 04:05:52 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e481e4f30f4dc540f6f129b4f2faea48ee195673">e481e4f3</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-05T02:50:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Ensure we can not commit an index that is corrupt due to partial re-index
The re-index traverse can abort part-way though and we need to ensure
that the transaction is never committed as that will leave an un-useable db.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13335
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/06d9566ef7005588de18c5a1d07a5b9cd179d17b">06d9566e</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-04-05T02:50:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb tests: Prepare to run api and index test on tdb and lmdb
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13335
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/653a0a1ba932fc0cc567253f3e153b2928505ba2">653a0a1b</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-05T05:53:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Add test to show a reindex failure must not leave the DB corrupt
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13335
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Apr 5 07:53:10 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0210f60759c90e22fe86738490b328df7ff23b6f">0210f607</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-04-05T06:59:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Write py3 bin to correct args location
Comands written like this were working:
python /home/dmulder/code/samba/source4/scripting/bin/subunitrun
Changed to:
/usr/bin/python3 /home/dmulder/code/samba/source4/scripting/bin/subunitrun
But commands with env args overwrite the wrong arg:
CLIENT_IP=127.0.0.11 SOCKET_WRAPPER_DEFAULT_IFACE=11 python /home/dmulder/code/samba/source4/scripting/bin/subunitrun
Changed to:
/usr/bin/python3 SOCKET_WRAPPER_DEFAULT_IFACE=11 python /home/dmulder/code/samba/source4/scripting/bin/subunitrun
And were further mangled in plantestsuite_loadlist() to:
/usr/bin/python3 /home/dmulder/code/samba/source4/scripting/bin/subunitrun SOCKET_WRAPPER_DEFAULT_IFACE=11 python /home/dmulder/code/samba/source4/scripting/bin/subunitrun
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/522243364139e88352fd6f58a0eda5a950a35c8e">52224336</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-05T06:59:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python3 port for policy module
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ccc0e06caa0d4657f70c2461a63efaa7bd1f6d40">ccc0e06c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-05T06:59:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba test python: enable samba.tests.policy for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ad012d4118a1031be3111ee5305109a9d3117d0">7ad012d4</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-05T06:59:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python selftest: split samba3 test into separate tests
This patch splits the tests contained in samba3.py into separate
tests s3idmapdb.py, s3param.py, s3passdb.py, s3registry.py, s3windb.py
This allows test of associated python c-modules to be done independently.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ac888471b05e9529b84c221177ec820bde1be893">ac888471</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-05T06:59:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python3 port for param module
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c6bba60c8b3b203396af6713d565fbdea2a8f322">c6bba60c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-05T06:59:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python3 port for passdb module
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e4779b0da3140e0a9777a39b82222cd1a8102780">e4779b0d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-05T06:59:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python selftest: enable samba.tests.s3param to run with python3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8caa2cd48a8ad4ce6aeeb16e48a2382f913e073b">8caa2cd4</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-05T06:59:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python selftest: enable samba.tests.s3passdb to run with python3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1734655bf805342ce4b2a33c78729b681846da52">1734655b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-05T06:59:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python selftest: enabled samba.tests.s3registry to run with py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5fd49e895637ca491c7d716c3c18033129211f34">5fd49e89</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-05T06:59:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python selftest: enable samba.tests.s3windb to run with py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/22d563b13eb122197bdf0b24937a78aec3b260af">22d563b1</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest python: get samba.tests.s3idmapdb to run with py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/94fd3cfa79e65128f86cd109d2ae4ee1e563bc40">94fd3cfa</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python3 port for libsmb_samba_internal module
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/25e336ebbf373bd486ae31a654614925c2cfb111">25e336eb</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python samba test: enable samba.tests.libsmb_samba_internal for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53e76ed2ff1f9a82eb5260c10e86c890d893eb2a">53e76ed2</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python3 port for smbd module
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c10925e9507f8810f3ba91ac51454357a6c67c8f">c10925e9</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/ntvfs/posix/python: python3 (get|set)xattr value should be bytes
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ed0844fbb9b7d0f3fe0358cde16b31e453b7306d">ed0844fb</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba python tests: enable samba.tests.posixacl for python3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/05617a9eee726682e5b2db1e42d2181097bd37c4">05617a9e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba python tests: enable samba.tests.ntacls for python3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ad9bdd684db2f894e7d5bd911c73ef93252b008">7ad9bdd6</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python3 port for provision.c
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2d593c27fd4f7162f5f71f97d44a4fe286d53ff5">2d593c27</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">get make test TESTS=samba.tests.provision to work
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fe9e62935c459e4cdab0cefea1412614dd1969a8">fe9e6293</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba3: work around bytes formatting for Python 3.4
b'%s\x00' % key
The above % formatting for bytes is only available since Python 3.5,
however we need to support Python 3.4 so far.
Work around this with `+`.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d28379dc4acef6ddb887a2ead0c22e9f93a8aa50">d28379dc</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript_build: fix c modules deps name for Python 3
In wscript_build, the lib name in deps list may have postfix for Python
3. Instead of hard coding the base name directly, need to load correct
name for each Python version with `bld.pyembed_libname`.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cf8578537726d7239cb2c79fbe8282035569c864">cf857853</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.posixacl
Fix bytes and str issue.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d3e4c4737b14408fccaff2b89f260e81d90fb14e">d3e4c473</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.xattr
Fix bytes and str issue.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/908ee2d3d290148403b560fb8cf3a4128cbd2ec8">908ee2d3</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.blackbox.check_output
convert bytes to str for Python 3
`BlackboxTestCase.check_output` will return bytes since it uses
`subprocess.communicate` underneath.
Convert expected string result to bytes for comparing.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87743b3275f2bd218b417d46aa69b18e56a65ed9">87743b32</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.upgrade
`os.tempname` is removed in Python 3.
Use `tempfile` instead.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/34cf522e71a958be0817c35ad6f666a5ba91ba9a">34cf522e</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.password_quality
No change needed.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/55c9661468463fa08097820da382de7a81ed8e84">55c96614</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.dcerpc.rpc_talloc
No changes needed.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a35dfa017ba47f98a42a14adc70fd5430ca73e0e">a35dfa01</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.dcerpc.array
No change needed.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/80aaafc2ce96b3b18ae66d37cdb70cc731edb6e5">80aaafc2</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-05T06:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.dcerpc.string
No change needed.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0ebf52744c5171d4eb5f0b0616d3880d7bbd9db4">0ebf5274</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-05T06:59:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.common
fix dsdb_Dn comparison for Python 3
In Python 3, the builtin `cmp` funtion was dropped. And the `__cmp__` magic
method in object is no longer honored, which is replaced by 6 new methods:
__eq__, __ne__, __lt__, __le__, __gt__, __ge__.
This caused `tests.CommonTests` failed with `py3_compatiable=True`.
Fixed by adding the above methods.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/68d89b0a19b73fe218938280e7b4395261d7c269">68d89b0a</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-05T06:59:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.hostconfig
Fix relative import.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d774fa732ddb0d71b42eed09be041efcc76c6fe">5d774fa7</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-05T06:59:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.upgradeprovision
1. `has_key` was removed from dict in Python 3, use `in` instead.
2. `cmp` was removed in Python 3, define it ourselves.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a5bc4d8c7a4b0d97d54978f37e9fcabfbde1d38b">a5bc4d8c</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-05T06:59:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.kcc.graph
In Python 3, range() will not return a list any more.
So `range(7) * 4` will not work.
Convert range to list to fix.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff6642820179d7921055afa39f38609b4c7b8c0d">ff664282</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-05T06:59:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.kcc.graph_utils
zip will not return a list in Python 3.
Convert to list.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/47761ee449bd08e89fba05e5bfbe584524c638a5">47761ee4</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-05T06:59:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.samdb_api
Fix bytes and string.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/707af5b31b83cc72ec33bd2e12bad1dbbab9a850">707af5b3</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-05T10:16:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.blackbox.ndrdump
No change needed.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Apr 5 12:16:41 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/03124c85f1141f1e57398e526f38798b6f1fa741">03124c85</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-05T11:01:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: use atexit() again instead of a library destructor
The change for https://bugzilla.samba.org/show_bug.cgi?id=7587
("talloc_autofree_context() in shared libraries and plugins is a bad idea on FreeBSD")
(ommit 41b6810ba01f44537f470c806adb8686e1a39c48)
causes the following for sssd on Linux:
Stack trace of thread 19667:
#0 0x00007f2cab91ff6b __GI_raise (libc.so.6)
#1 0x00007f2cab90a5c1 __GI_abort (libc.so.6)
#2 0x00007f2cab90a491 __assert_fail_base (libc.so.6)
#3 0x00007f2cab9186e2 __GI___assert_fail (libc.so.6)
#4 0x00007f2cb10aaca5 k5_mutex_lock (libkrb5.so.3)
#5 0x00007f2cb10ab790 k5_mutex_lock (libkrb5.so.3)
#6 0x00007f2cb10ab8f5 profile_free_file (libkrb5.so.3)
#7 0x00007f2cb10ab983 profile_close_file (libkrb5.so.3)
#8 0x00007f2cb10af249 profile_release (libkrb5.so.3)
#9 0x00007f2cb10a06c7 k5_os_free_context (libkrb5.so.3)
#10 0x00007f2cb1075a9a krb5_free_context (libkrb5.so.3)
#11 0x000055cea7cb2dd1 kcm_data_destructor (sssd_kcm)
#12 0x00007f2cac153e96 _tc_free_internal (libtalloc.so.2)
#13 0x00007f2cac1537b0 _tc_free_internal (libtalloc.so.2)
#14 0x00007f2cac1537b0 _tc_free_internal (libtalloc.so.2)
#15 0x00007f2cac1537b0 _tc_free_internal (libtalloc.so.2)
#16 0x00007f2cac1537b0 _tc_free_internal (libtalloc.so.2)
#17 0x00007f2cac14e648 _talloc_free (libtalloc.so.2)
#18 0x00007f2cac14c480 talloc_lib_fini (libtalloc.so.2)
#19 0x00007f2cb151da96 _dl_fini (ld-linux-x86-64.so.2)
#20 0x00007f2cab9226bc __run_exit_handlers (libc.so.6)
#21 0x00007f2cab9227ec __GI_exit (libc.so.6)
#22 0x00007f2cb030dc61 orderly_shutdown (libsss_util.so)
#23 0x00007f2cac365a46 tevent_common_check_signal (libtevent.so.0)
#24 0x00007f2cac367975 epoll_event_loop_once (libtevent.so.0)
#25 0x00007f2cac365dab std_event_loop_once (libtevent.so.0)
#26 0x00007f2cac362098 _tevent_loop_once (libtevent.so.0)
#27 0x00007f2cac3622eb tevent_common_loop_wait (libtevent.so.0)
#28 0x00007f2cac365d3b std_event_loop_wait (libtevent.so.0)
#29 0x00007f2cb030eb37 server_loop (libsss_util.so)
#30 0x000055cea7cb29f4 main (sssd_kcm)
#31 0x00007f2cab90c1eb __libc_start_main (libc.so.6)
#32 0x000055cea7cb2c7a _start (sssd_kcm)
We still only register one atexit handler instead of multiple ones
like in talloc 2.1.11, but avoids using a library destructor.
Bug #7587 seems to be fixed by not using talloc_autofree_context()
within samba.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13366
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d48b62326a5256fabdcbdd97cc71c44527672527">d48b6232</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-05T13:53:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: version 2.1.13
* Use atexit() again instead of a library destructor
(bug #13366)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Apr 5 15:53:16 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d5ef8dbeef36eeb30fa94efae1d6df8647679812">d5ef8dbe</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-05T14:17:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">eventlog: Fix CID 242105 Unchecked return value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a1e69ebb73a61bc76595df99fe023bdc91ff532">7a1e69eb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-05T17:11:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">eventlog: Fix CID 1363194 Resource leak
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Apr 5 19:11:57 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9bf489d8d5838e73afaaca263485a332b14b174e">9bf489d8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-05T21:05:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: nmbd: Fix strict overflow checking compiler warning.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/924f3f000e627f0c12f1b2381608b3182c2d53c5">924f3f00</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-06T00:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Add '-Werror=strict-overflow -Wstrict-overflow=2' to the developer build
We could move it to 3, but shouldn't go higher. If you set it to 4 and 5
you will probably also get a lot of false positives.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Apr 6 02:07:16 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8b368c9f0c2a34b6d15303a9d6facd762e1a517">f8b368c9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-06T00:08:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Fix missing NULL terminator in ldb_mod_op_test testsuite
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5dc7db578647e5381976af4d0d447d3685b779f9">5dc7db57</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-06T00:08:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool domain classicupgrade: Do not mix python-samdb transactions and passdb modifications
This worked previously because we knew the same tdb was in use under the hood,
but now that nested TDB transactions are banned this breaks, and it breaks for
LMDB.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78851816501aa7ea266d6447605910e3bc8f3b20">78851816</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-04-06T00:08:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Change some prototypes to using ldb_val instead of TDB_DATA
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7bf853950d551e519fe25a344eb6a742fc5dd299">7bf85395</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-04-06T00:08:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Change remaining fetch prototypes to remove TDB_DATA
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8c848549eeff177d754624006b9fa629cf908369">8c848549</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-04-06T00:08:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">upgradeprovision: Do not copy backup lmdb -lock files
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/68d709741a868a3c02074934c4cc7355d6f9d19e">68d70974</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-06T00:08:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Ignore these tests in mdb test mode
These are tests are specifically for when the GUID index is not in use
which is always in with ldb_mdb.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eb4205fc31830f4227667e245395d81d3b3654cb">eb4205fc</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-06T00:08:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Allow GUID index mode to be tested on TDB
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d161a6dcfef09ad939df76c5c77eb8b7519a9326">d161a6dc</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-04-06T00:08:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb index: Fix truncation key length calculation
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/556466e7e3bed0edd8cd15e58dd4380f13c14364">556466e7</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-06T00:08:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: A more robust check for if we can fit the index string in
This avoids magic numbers and also is careful against overflow
from a long attr_for_dn.
This is done as a distinct commit to make the previous behaviour
change more clear, and to show that this does not change the
calculations, only improves the overflow check.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/412cdb1714570bb688ba01625da829d48a0c07ad">412cdb17</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-04-06T00:08:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb index: Add tests for truncated base 64 index keys
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0f7d1534954b87a39c68d9ceb5d4b03c3cff1839">0f7d1534</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-04-06T00:08:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb test: close pipes to stop forked tests failing on failure
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d206fcf5c7b7f598993e385896c9d9e8db64c31a">d206fcf5</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-04-06T00:08:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb tests: ldb_mod_op_test use correct ldb to create dn
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8d1b11aac9d43080c5efa1d84219af283f8c7d49">8d1b11aa</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-04-06T00:08:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: ltdb_tdb_parse_record map tdb error codes
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e001c5fb5f2de686cb86c9aae8741ae5776bde64">e001c5fb</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-04-06T00:08:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: ltdb_tdb_store require active transaction
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1fceb64dc2c7f994e800b00cc9fbd214ac42a201">1fceb64d</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-04-06T00:08:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: ltdb_tdb_delete require active transaction
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ca90e758ade97fb5e335029c7a1768094e70564">5ca90e75</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-04-06T00:08:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb tests: add cmocka tests of kv operations
Add tests for the behaviour the ldb layer expects the key value layer to
provide. This should make it easier to add another KV store
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/301cd5e58a58e4e373c81425fc6394d70becbdf7">301cd5e5</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-04-06T00:08:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Add wrapper of mdb_copy that we can call from python
This is like the use of tdbbackup for tdb files.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/34b12fbd8805d7f419ae5f41505e6ea430ad5168">34b12fbd</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-04-06T00:08:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">provision: allow provisioning of a different database backend
This sets the backendStore field in @PARTITION, depending on which
argument you set in the provision.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba61c684686933b1a69a1bb357428db9911b2048">ba61c684</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-06T00:08:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">provision: Set @INDEXLIST first when building dummy sam.ldb
The new LMDB backed will not allow normal records to be added before the @INDEXLIST
as this is what forces the GUID index mode.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a98568397d37a2dc9d20f20a5bc1f5b81c5f4b4d">a9856839</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-04-06T00:08:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: add lmdbLevelOne as a required feature.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/428c0a81aecd578e77123ca27b835b2fc8a54e26">428c0a81</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-04-06T00:08:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source3: initilize_password_db after a fork.
This is required because we need a new pointer for LDB after the fork,
and with LMDB we can not longer rely on tdb_reopen_all() to do that
for us.
This can not be done in reinit_after_fork() due to the dependency loop
this would create.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0935b25bd29fe03dbfbede0b3d65fefef74c1784">0935b25b</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-04-06T00:08:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Unwind transaction counter if start_transaction fails
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/946dfc783cde9015cc7f288b69008ff22436f255">946dfc78</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-04-06T03:12:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">upgradeprovision: detect and handle lmdb databases
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Apr 6 05:12:11 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f262520c8556b117d7c20bc4127b2de0483828ae">f262520c</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-04-06T04:29:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: implement computer management commands
Usage: samba-tool computer <subcommand>
Computer management.
Available subcommands:
create - Create a new computer.
delete - Delete a computer.
list - List all computers.
move - Move a computer to an organizational unit/container.
show - Display a computer AD object
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6e4a49e992a9b3b3dc5e96896c934abcb6ee6b4e">6e4a49e9</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-04-06T04:29:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/samba-tool: add tests for new computer management commands
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e41b9b04e23f0e8831ff922d247b737bf8116151">e41b9b04</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-06T04:29:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: improve computer management commands
This pathch is based on Björn Baumbach's work:
1. Add `--ip-address` option for create subcommand, to allow user set DNS
A or AAAA records while creating the computer.
2. Delete above DNS records while deleting the computer.
3. Add `--service-principal-name` option for create command, to allow user
set `servicePrincipalName` while creating the computer.
4. Tests.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5a51990f5dcc3cb8181d2fa4c3a1c07fea0f6112">5a51990f</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-04-06T04:29:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml:samba-tool.8: document computer management commands
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba81f33fc4fe7b972f6852a9b1e8b026fbd45fff">ba81f33f</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-06T04:29:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml:samba-tool.8: improve doc for computer management commands
Add docs for new options:
1. --ip-address
2. --service-prinicipal-name
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/306f5e57f2ebf80bb02a9d87c34d78b3d00ca010">306f5e57</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-04-06T04:29:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-mdssvc: allow build with --enable-spotlight and libtracker-sparql-2.0
adds libtracker-sparql version 2.0 to configure check with pkg-config.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0a6c2ac88f8c2423ffbb7cdf2624ca5d95cb3d30">0a6c2ac8</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-06T04:29:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: Escape username and computername in ldb search filter
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a02a98af8b20b8860252cbde372ef8f6a3b286f4">a02a98af</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: ldap: Ensure the ADS_STRUCT pointer doesn't get freed on error, we don't own it here.
Thanks to Isaac Boukris <iboukris@gmail.com> for finding the
issue and testing this fix.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13244
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jan 26 02:25:20 CET 2018 on sn-devel-144
(cherry picked from commit e7425bd5245ffea68b7e8f794c9b5f864d103769)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/678555091a5d6de1f0a32a2dd5e9ced2a9cf1b30">67855509</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix possible directory fd leak if the underlying OS doesn't support fdopendir()
HPUX has this problem.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13270
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Feb 23 22:56:35 CET 2018 on sn-devel-144
(cherry picked from commit 5ad5e7966f555b1d2b39d276646934a2cd2535e6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f1c0db35d5d6c75a5a6c6778a9093fa8e04053b8">f1c0db35</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs_fruit. Ensure we only return one set of the 'virtual' UNIX ACE entries.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit e9059c7b40069cfb036bfb95958b78c6a2c800e4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9fab1ddc2db5f88dbc9b396051cdc9d8d0195f4b">9fab1ddc</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs_fruit: Ensure we operate on a copy of the incoming security descriptor.
This will allow us to modify it in the next commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 019a1bc4caf3439adcaac48b384e86d84a1ad383)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8ea9d133048be3a04d5e4b92f0e497ac426e28cc">8ea9d133</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs_fruit. If the security descriptor was modified, ensure we set the flags correctly to reflect the ACE's left.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 8edad37e476295e25932778721d8ef33713f6853)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0aed47322cd8e9a8df09aaa222fa30bb2215c5b4">0aed4732</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs_fruit. Change check_ms_nfs() to remove the virtual ACE's generated by fruit_fget_nt_acl().
Ensures they don't get stored in the underlying ACL.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Mar 8 04:09:38 CET 2018 on sn-devel-144
(cherry picked from commit e0b147f650fe59f606d1faffe57059e6e9d7837b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2fc537b71998b9ea9a7492cb1d053e5b511da931">2fc537b7</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: vfs_fruit: Add remove_virtual_nfs_aces() a generic NFS ACE remover.
Not yet used, will be used to tidyup existing code.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit ef091e2cf836793e2aa533990913609ccab5119a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c80cb6a030cc000a52a3dc04d3794471c40ca82">9c80cb6a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: vfs_fruit: Replace code in check_ms_nfs() with remove_virtual_nfs_aces().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit a3c925d80433e3d4fe1b1b315edf6520cacf0a9e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/134c41255ca492d533d6e9cbeedabf1ac87aa7e4">134c4125</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: vfs_fruit: Replace code in fruit_fget_nt_acl() with remove_virtual_nfs_aces().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 875ff2575feb96d06cf2290e5b6a226b32ef9758)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1f93e4d2e703a61c689b040ff5f6ae60dacc7e75">1f93e4d2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-06T06:21:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: run vfs.fruit_netatalk test against seperate share
These tests require a fs with xattr support. This allows adding
xattr_tdb to all other shares in the next commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 013aaffe7ff0ed4c30495761bb3208c29b3b5de2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c45da7ee611ea9ac8ff8b88c8eeecbc06dfb7def">c45da7ee</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-06T06:21:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: vfs.fruit: add xattr_tdb where possible
This makes the tests indepent from fs xattr support.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 49996ca9324596b6cd72eb8051ca3676dab17191)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/47b1ec0a5ea458f9a8a21c29afca9ff21e2fbd8f">47b1ec0a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: vfs: fruit tests: Add regression test for dealing with NFS ACE entries.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Mar 17 04:04:32 CET 2018 on sn-devel-144
(cherry picked from commit a6054c01c29c2507e0d5a6aa110fee4fd5c5eeb9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65ca5574b769d8b211b4c9550b62f8af126346e9">65ca5574</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fruit. Make the use of dom_sid_compare_domain() much clearer.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13319
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 5c909ea4530d4e7e4aa27046c45e3e48b094a411)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f66a35b8beb8101a0064dfd58e494ec2f2fa40fd">f66a35b8</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-04-06T06:21:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Don't use nc -d or -w options
nmap-ncat is used in some distributions to replace netcat. It has a
different meaning for these options.
We can get the same effect as the current combination of -d and -w by
piping a sleep process to nc. Subsequent use of $! works because it
gets the last process in pipeline.
Note that redirecting from /dev/null doesn't work with some versions
of nc. They just exit when they get EOF.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13327
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 9e954bcbf43d67a18ee55f84cda0b09028f96b92)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ccda6d9b8c893d6432ac92c5c542cbde6039ad74">ccda6d9b</a></strong>
<div>
<span>by Anton Nefedov via samba-technical</span>
<i>at 2018-04-06T06:21:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: map nterror on smb2_flush errorpath
smbd_smb2_flush_recv() expects nterror in tevent_req, and otherwise
aborts in tevent_req_is_nterror()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13338
Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 98623129446672521b7fa41d3457b8ce95db828c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/43cbf7f7728414a6e0d0feb76d4e3a4729df55de">43cbf7f7</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-06T06:21:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:replace: Fix linking when libtirpc-devel overwrites system headers
Some systems (like SUSE currently) install the new tirpc headers by
overwritting the existing system location used by gcc. This patch will
detect if the headers in the system location belong to tirpc or not.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13341
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 618c714b6b6c0b63993299b40b9a466adb753cc2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/49a9c984974fe8c31aada72224cda434358c38f7">49a9c984</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: debug: smb2: Create a new DBGC_SMB2 debug class and mark all smbd/smb2_*.c files with it.
Will allow easier smb2-specific debugging.
https://bugzilla.samba.org/show_bug.cgi?id=13347
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
(cherry picked from commit 8dabcf8948c2e514b489169c34673e093519b583)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e9f54762fa607ad321016df2284c918547a40264">e9f54762</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: debug: Add DBGC_XXX versions of the macros to allow class-specific messages.
https://bugzilla.samba.org/show_bug.cgi?id=13347
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
(cherry picked from commit cdde6d93605d15a59e816a35e8e02ca193bf1403)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b5bc2f593d364bf173c13ef0cca9663db6019b69">b5bc2f59</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: SMB2: Add DBGC_SMB2_CREDITS class to specifically debug credit issues.
https://bugzilla.samba.org/show_bug.cgi?id=13347
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
(cherry picked from commit ad973fddef00d6d92443be89e7f5404006a94d99)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/58befddfce55fd1ade66d206dbdc3274dd2a790e">58befddf</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: docs: Add documentation for "smb2" and "smb2_credits" debug classes.
https://bugzilla.samba.org/show_bug.cgi?id=13347
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
(cherry picked from commit fc922bd29b40a20450f16728fa7347f8f83d3bcd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8a77ae09ee1522d01746a4cb7fd5661b980b86d7">8a77ae09</a></strong>
<div>
<span>by Eric Vannier</span>
<i>at 2018-04-06T06:21:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Allow AESNI to be used on all processor supporting AESNI, not just Intel's This improves performance/reduced CPU usage. Tests performed: - Ran on Ivy Bridge and Ryzen and verified that AESNI is detected (crypto tests) - Ran on Ryzen, and observed 50% increased speed.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13302
Signed-off-by: Eric Vannier <evannier@google.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Mar 27 13:50:09 CEST 2018 on sn-devel-144
(cherry picked from commit 77d88d75f6262a855e818a9b2b4018f8b6ced7b0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/25edad412a3d503114a805b434a729d5d2786b3f">25edad41</a></strong>
<div>
<span>by Timur I. Bakeyev</span>
<i>at 2018-04-06T06:21:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix invocation of gnutls_aead_cipher_encrypt()
Which was failing with GNUTLS_E_SHORT_MEMORY_BUFFER - The given memory
buffer is too short to hold parameters.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13352
Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Fri Mar 23 07:25:30 CET 2018 on sn-devel-144
(cherry picked from commit b9f0c7f93c058685e24d104432978bd40b94b49f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aeed66ece0220d40fe33e66f726c4638e7c02393">aeed66ec</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-04-06T06:21:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-client: Do not try to allocate 0 sized record
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13356
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 92a68af1a8473dc2a5d9d6036830f944e968606d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a630cb9a37b5ed423c5c23c021bc4bcbf28c5fc0">a630cb9a</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-04-06T06:21:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-client: Add missing initialization of tevent_context
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13356
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 4e37be92bfb790150b3791bef552aa4acf8f78b7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/879fccbb8acabbc396088babe469034424012541">879fccbb</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-04-06T06:21:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-client: Client code should never free the client context
This should never have been done.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 376e9794e2d19e8d17b0bdde36ce8a1a205986c6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/03876304a1f550330c622fee1e1f2e3e74d61f10">03876304</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Files or directories can't be opened DELETE_ON_CLOSE without delete access.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13358
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
(cherry picked from commit 2514bee0a3b0a12430e2679ee590075c54d4803a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2f418222ad1a6adf6252b265e1f53fd0a29cf473">2f418222</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: Ensure a failed file create doesn't create the file.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13358
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
(cherry picked from commit 53cdf7a9a18ed547eade4c3cdd80d286058e440d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d3ac788221e5532c11a557cf8754917f8007040e">d3ac7882</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: Test all combinations of file create to ensure behavior is the same.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13358
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
(cherry picked from commit 22fe8dcb77565495886244e88bb0433363d1f80a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/29aa75e66196fd16da9240798d5eaa07f364f232">29aa75e6</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: Test all combinations of file open with existing file to ensure behavior is the same.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13358
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
(cherry picked from commit 820b35bb1ceb445eb3659b67eedfb0a2f5b2f976)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1f94e367aacf2d61ee47d79b30396b14c8013113">1f94e367</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T06:21:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: Test all combinations of directory create to ensure behavior is the same.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13358
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
(cherry picked from commit fd9084336e7e86ccec83141d880fd7c336c23b6c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/95cad5cab30fb0cc54a730a8bbef88c34d6ed875">95cad5ca</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-06T07:30:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: Use same method for removing trailing $ as elsewhere in the tool
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Apr 6 09:30:14 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8e149c84f07870b8131521a6fa13af60d0772861">8e149c84</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-06T11:50:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: Test all combinations of directory open with existing directory to ensure behavior is the same.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13358
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Mar 29 23:13:42 CEST 2018 on sn-devel-144
(cherry picked from commit c98cd0f25edaae7558f18fd331e2fef3aabb61f2)
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Fri Apr 6 13:50:18 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/567fe36c36c1d84e0edca151ece6a5b091995a49">567fe36c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-06T12:58:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb/tests: remove lmdb.h include from test
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Apr 6 14:58:48 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c8faa732edbee876dca19d91ed4a670dd86468a">4c8faa73</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-06T15:57:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Fix trailing whitespace
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Apr 6 17:57:04 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f07afad07d9c670a00d9d314a8134efdda5e424">6f07afad</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-04-06T15:58:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_smbclient_s3.sh: Use correct separator in "list with backup privilege" test
Samba selftest uses the forward slash as winbind separator and in the
USERNAME passed to the test. "net sam rights" expect the backslash. Map
the separator used in selftest to a backslash to avoid creating an
incorrect username DOMAIN\DOMAIN/USERNAME.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13312
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3c146be404affc894c0c702bbfbfcc4fb9ed902b">3c146be4</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-04-06T15:58:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Fix wbcListUsers test
With an AD DC, wbcListUsers returns the users in the DOMAIN SEPARATOR
USERNAME format. The test then calls wbcLookupName with the domain name
and the previous string (including domain and separator) as username.
Fix this by passing the correct username and adding some additional
checks.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13312
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f4db4e86c341a89357082e81e30c302440647530">f4db4e86</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-04-06T15:58:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Fix wbcListGroups test
With an AD DC, wbcListGroups returns the users in the DOMAIN SEPARATOR
GROUPNAME format. The test then calls wbcLookupName with the domain
name and the previous string (including domain and separator) as
username. Fix this by passing the correct username and adding some
additional checks.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13312
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/552a00ec1f6795b9025298931a6cc50ebe552052">552a00ec</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-04-06T15:58:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add test for wbinfo name lookup
This demonstrates that wbinfo -n / --name-to-sid returns information
instead of failing the request. More specifically the query for
INVALIDDOMAIN//user returns the user SID for the joined domain, instead
of failing the request.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13312
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1775ac8aa4dc00b9a0845ade238254ebb8b32429">1775ac8a</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-04-06T19:03:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Do not ignore domain in the LOOKUPNAME request
A LOOKUPNAME request with a domain and a name containing a winbind
separator character would return the result for the joined domain,
instead of the specified domain.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13312
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Apr 6 21:03:31 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/11589a26ba40e9da90822a85b21327f49a69afda">11589a26</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-07T00:11:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/test: fix AAPL size check
A recent commit changed the ModelString from "Samba" to "MacSamba".
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c73ddfaaef7688762dab866e3af53359e09fc62">0c73ddfa</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-07T00:11:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture: spelling fix in vfs_fruit test
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7def556d020523d66b01dd358cc9e9adcdd40380">7def556d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-07T00:11:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture: spelling fix in vfs_fruit test
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ad90835c2bdf954622935139ec64ce640aa49b4b">ad90835c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-07T00:11:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">idmap: Use TALLOC_FREE instead of explicit code
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e29eaa43f511750cc1670b7154ef936496b46a39">e29eaa43</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-07T00:11:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">idmap: Fix CID 1363261 Resource leak
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de48619c15e19d8e79fcd7dea01b62f03fab6b4c">de48619c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-07T00:11:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pdb_nds: Fix CID 1273401 Unused value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5bba8c393d78235111cc5d744bb393847ca16283">5bba8c39</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2018-04-07T03:05:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smb2_tcon: Add check to prevent non-DFS clients from connecting to an msdfs proxy.
Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Apr 7 05:05:22 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/461a1172ff819692aa0a2dc5ce7fc5379c8a529e">461a1172</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-09T19:48:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix memory leak in vfswrap_getwd()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13372
Signed-off-by: Andrew Walker <awalker@ixsystems.com>.
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Apr 9 21:48:12 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3227b110d065500ed84fc70063da70ab35823a2e">3227b110</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-09T22:45:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Unix extensions attempts to change wrong field in fchown call.
Cut and paste error.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13375
Reported-by: Rungta, Vandana <vrungta@amazon.com>
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Tue Apr 10 00:45:56 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9230fe25287dd3ee53c9384f73f62b4e4ed8dd1e">9230fe25</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-04-10T07:40:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool visualize: fix python2.6 incompatibility
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13337
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Wed Mar 21 09:25:51 CET 2018 on sn-devel-144
(cherry picked from commit 9312a1cdafbd5a0140d72502487c4e478dc578d2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/365569dfc70a45ff9ba4b3baf9e3ea7de66eff4e">365569df</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-04-10T07:40:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ms_schema: fix python2.6 incompatibility
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13337
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit a27db0b61e40b6b503b53e3579867e227f1971b8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eb9085b3ef8610970a4168566f73395fd3c900d5">eb9085b3</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-04-10T07:40:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop "net serverid wipe" from 50.samba event script
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13359
There is no serverid database anymore.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Sat Mar 31 08:34:00 CEST 2018 on sn-devel-144
(cherry picked from commit 6b75d2c650aa9ee632122fa87ea8a2a98f1fa613)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9ed1968e8bf435d98a9fa02d1f0265398c45523">a9ed1968</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-10T07:40:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: don't use the directory cache for SMB2/3
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13363
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Mar 30 03:51:48 CEST 2018 on sn-devel-144
(cherry picked from commit 66052fdccd28922cf1caa2bc750e39051a6414cf)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2c3060b6a6c8d03286906adb89452788988feeeb">2c3060b6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-10T07:40:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Fix CID 1034966 Uninitialized scalar variable
"continue" in a do-while loop jumps to the "while"-check, so "id_exists" needs
to be initialized by that point.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13367
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 925d1f23291c4bdbc832977b2b4577964b8301c8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5afebb251c6b87d264ea66a20b29c79e8aa1215d">5afebb25</a></strong>
<div>
<span>by Lutz Justen</span>
<i>at 2018-04-10T07:40:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: lib: messages: Don't use the result of sec_init() before calling sec_init().
Commit ad8c7171ba86e8a47d78b0c7329bb814e5a8871e accidently
moved sec_init() to the point after sec_initial_uid() is
called in the call to directory_create_or_exist_strict().
I missed this in the review (sorry). This works as root
as initial_uid/initial_gid are static (and so initialized
as zero) but doesn't work on ChromeOS as this code isn't
running as root.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13368
Signed-off-by: Lutz Justen <ljusten@google.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Apr 4 23:52:02 CEST 2018 on sn-devel-144
(cherry picked from commit e895b6cf4a7eb3d50d618a022be74db85975bf69)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bc11f2851af7e71c91f90224c90528f2c7755f6a">bc11f285</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-10T12:44:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix memory leak in vfswrap_getwd()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13372
Signed-off-by: Andrew Walker <awalker@ixsystems.com>.
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Apr 9 21:48:12 CEST 2018 on sn-devel-144
(cherry picked from commit 461a1172ff819692aa0a2dc5ce7fc5379c8a529e)
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Tue Apr 10 14:44:28 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ee560fa3a67797deef86b3aea763389488790ef0">ee560fa3</a></strong>
<div>
<span>by William Brown</span>
<i>at 2018-04-10T23:06:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:ldb/password_hash.c: improve krb5 context error message
When heimdal encounters a MIT krb5.conf that it does not understand,
it would emit an "ldb operations error". Sadly this does not help
or communicate to the administrator the root cause of the issue.
Improve the error message for when krb init fails during password_hash.c
Signed-off-by: William Brown <william@blackhats.net.au>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/10dbd51e2d54c45de103de10c400d7f323c7223e">10dbd51e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-10T23:06:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdbtool: Use tdb_wipe_all in "erase" command
This is a lot quicker on large, fragmented databases. tdb_delete can
leave the freelist in a fragmented mess.
Also, it's a lot more robust: I've got a 4GB tdb file that was affected
by the problem fixed with c7211882a79. These databases have large space
at the end that is not part of any record or freelist
entry. tdb_wipe_all converts this space into a freelist entry. One
downside is that with those broken databases (which should not happen
after c7211882a79) have unallocated blocks in their file range after
this operation.
I think the speed advantage outweighs this disadvantage.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5cdc5834809e2ab7a84fcac7c4563805f7b7173b">5cdc5834</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-10T23:06:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nmbd: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59961f9cc90bd237ff39f9a03b74d032ccf6efd4">59961f9c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-10T23:06:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nmbd: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6c1e75f6b9284c9b2dd73ea0ea65fe54ebd3e272">6c1e75f6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-10T23:06:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Remove unused trustdom_cache.c
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/39bdd175e94584504edeb9f1ccf11890185bfdbf">39bdd175</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-10T23:06:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Give namequery.c its own header
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1643c334db7f49a9c5ededf3422e4cc9ff17f253">1643c334</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-10T23:06:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Give dsgetdcname.c its own header
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/295c53405ab5f12b79e62d54e288a7c9bafc857f">295c5340</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-10T23:06:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Introduce a helper variable
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d34014c9358c49a3407b0c726e85a21e3848d981">d34014c9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-10T23:06:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Pass "account_name/flags" through prep_getdc_request
Don't hardcode values that we might want to change later
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/07532f6a5953e5900d5350e12e13a76e37a9ec6a">07532f6a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-10T23:06:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Pass "account_name/flags" through nb_getdc
Don't hardcode values that we might want to change later
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/85dc9ee14023a8fb84b5c74555d43008bb6bb0c0">85dc9ee1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-10T23:06:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-lib: Remove support for libexc for IRIX backtraces
IRIX is long dead, and this code needs become_root() which is not in
the top level code.
Additionally, the check for libexc never made it into waf, so this
has been dead code since Samba 4.1.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3acc00b6808d5d5ad035d9d43526204db1608c8a">3acc00b6</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-10T23:06:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/util: Log PANIC before calling pacic action just like s3
This is like the changes made in s3 by
4fa555980070d78b39711ef21d77628d26055bc2
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf9551902afdb32310db4a3381964c435dd08bf0">bf955190</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-10T23:06:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/util: Move log_stack_trace() to common code
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/462eb4a44cc51dc17aebbcd5c609c9ff7f088554">462eb4a4</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-11T02:03:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/util: Call log_stack_trace() in smb_panic_default()
This matches the AD DC with the behaviour in smbd.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Apr 11 04:03:07 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7abe54b57f65c4e89ca34178690c3b19c1e4626f">7abe54b5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-11T09:52:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Unix extensions attempts to change wrong field in fchown call.
Cut and paste error.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13375
Reported-by: Rungta, Vandana <vrungta@amazon.com>
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Tue Apr 10 00:45:56 CEST 2018 on sn-devel-144
(cherry picked from commit 3227b110d065500ed84fc70063da70ab35823a2e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d2799ab5e45ad184bcb26fa8d0770711fe1907e8">d2799ab5</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-04-11T09:52:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_smbclient_s3.sh: Use correct separator in "list with backup privilege" test
Samba selftest uses the forward slash as winbind separator and in the
USERNAME passed to the test. "net sam rights" expect the backslash. Map
the separator used in selftest to a backslash to avoid creating an
incorrect username DOMAIN\DOMAIN/USERNAME.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13312
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 6f07afad07d9c670a00d9d314a8134efdda5e424)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f901e8cc594526e50a18cf58edef48ca5b74bb29">f901e8cc</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-04-11T09:52:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Fix wbcListUsers test
With an AD DC, wbcListUsers returns the users in the DOMAIN SEPARATOR
USERNAME format. The test then calls wbcLookupName with the domain name
and the previous string (including domain and separator) as username.
Fix this by passing the correct username and adding some additional
checks.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13312
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 3c146be404affc894c0c702bbfbfcc4fb9ed902b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/80560167956cde78652d804cdf26385f759ba39b">80560167</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-04-11T09:52:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Fix wbcListGroups test
With an AD DC, wbcListGroups returns the users in the DOMAIN SEPARATOR
GROUPNAME format. The test then calls wbcLookupName with the domain
name and the previous string (including domain and separator) as
username. Fix this by passing the correct username and adding some
additional checks.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13312
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit f4db4e86c341a89357082e81e30c302440647530)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/40ee7863a558568c69ee990fb8405ab51febae34">40ee7863</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-04-11T09:52:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add test for wbinfo name lookup
This demonstrates that wbinfo -n / --name-to-sid returns information
instead of failing the request. More specifically the query for
INVALIDDOMAIN//user returns the user SID for the joined domain, instead
of failing the request.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13312
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 552a00ec1f6795b9025298931a6cc50ebe552052)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/212815969f4a706bc8395e2f6dbf225318ff2ad7">21281596</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-11T13:19:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpc_server: Init local_server_* in make_internal_rpc_pipe_socketpair
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13370
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Apr 11 15:19:19 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bb5526d01fabd308d848a0b72332a2361438fcf5">bb5526d0</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-04-11T15:11:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Do not ignore domain in the LOOKUPNAME request
A LOOKUPNAME request with a domain and a name containing a winbind
separator character would return the result for the joined domain,
instead of the specified domain.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13312
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Apr 6 21:03:31 CEST 2018 on sn-devel-144
(cherry picked from commit 1775ac8aa4dc00b9a0845ade238254ebb8b32429)
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Wed Apr 11 17:11:21 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/95c81fe5dc4c4722369e954e844e2bede32c4a89">95c81fe5</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-11T17:07:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: Fix CID 1414792 Unchecked return value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/37b094c3387310fc66eb523b4ccda4b587cf5e95">37b094c3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-11T17:07:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: Fix CID 1416474 Dereference null return value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a9bc0fa209798c8e4d88a68dcc6ad0b95925a52">6a9bc0fa</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-11T17:07:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Fix CID 1427625 Calling risky function
Probably not really a problem, but we have generate_random(), so why not
use it?
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e7522a4ff8124b8d7bfad9c805dd140475d418e2">e7522a4f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-11T17:07:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dnsrpc: Use TALLOC_FREE instead of an explicit if-statement
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d40891a14683a9cc8951ad36fb9e09831b7122af">d40891a1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-11T17:07:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix CID 1414783 Double unlock
The loop is unnecessary, both susv4 as well as the Linux manpage
explicitly say:
> These functions shall not return an error code of [EINTR].
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/56a8739e228fd661e3c648a7a316f7967a55e81c">56a8739e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-11T17:07:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">credentials: Revert "credentials: Fix CID 1414796 Explicit null dereferenced"
This reverts commit 90c02ec64d0e3c860f8d6906cf849bdd2c7bcc54.
We have code to take care of password==NULL, this CID must be fixed in a
different way
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a9df7966031f3c364454e1497168e3bc24ad4d9">7a9df796</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-11T17:07:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">credentials: Fix line length
... just because I'll modify that line in the next commit
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dff196a15735ea4dd6946aa6f2efa8a7e8f54b77">dff196a1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-11T19:58:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">credentials: Fix CID 1414796 Explicit null dereferenced
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Apr 11 21:58:00 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4d839d0f46b723ed6809bb932b9ebe4ead2cec82">4d839d0f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-11T21:09:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs: vfs_streams_xattr: Don't blindly re-use the base file mode bits.
When returning the stat struct for an xattr stream,
we originally base the st_ex_mode field on the value
from the base file containing the xattr. If the base
file is a directory, it will have S_IFDIR set in st_ex_mode,
but streams can never be directories, they must be reported
as regular files.
The original code OR'ed in S_IFREG, but neglected to
AND out S_IFDIR.
Note this is not a complete to fix bug 13380 as
it doesn't fix the generic case with all streams
modules. See later fix and regression test.
Found in real-world use case by Andrew Walker <awalker@ixsystems.com>.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13380
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/118e77d86a7171f589f805fa4f63246b0cb63672">118e77d8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-11T21:09:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd. Generic fix for incorrect reporting of stream dos attributes on a directory
According to MS-FSA a stream name does not have
separate DOS attribute metadata, so we must return
the DOS attribute from the base filename. With one caveat,
a non-default stream name can never be a directory.
As this is common to all streams data stores, we handle
it here instead of inside all stream VFS modules.
Otherwise identical logic would have to be added to
all streams modules in their [f]get_dos_attribute_fn()
VFS calls.
Found in real-world use case by Andrew Walker <awalker@ixsystems.com>.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13380
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/82beaf868f252c4bc975ddafd80240af6f679b83">82beaf86</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-12T00:04:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: tests: Regression test to ensure we can never return a DIRECTORY attribute on a stream.
Tests streams_xattr and also streams_depot.
Inspired from a real-world test case by Andrew Walker <awalker@ixsystems.com>.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13380
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Apr 12 02:04:28 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c7973e9ba5671aa78525b335038b5ca8bf54aa3">5c7973e9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-12T03:15:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Check for userPassword support after loading the databases
The net result of this is only that userPassword values (which were
world readable when set) would still be visible after userPassword
started setting the main DB password.
In AD, those values become hidden once the dSHeuristics bit is set,
but Samba lost that when fixing a performance issue with
f26a2845bd42e580ddeaf0eecc9b46b823a0c6bc
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13378
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/056b2abde615aab986e43c41c297edfaf58aaea2">056b2abd</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-12T03:15:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: check for dSHeuristics more carefully
This check would pass if the dSHeuristics was treated as always being
000000000 for searches which is not enough, we must check for a value
of 000000001 (userPassword enabled).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13378
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/46b6f2d782efb0d15e676c5be359e1a4145cf426">46b6f2d7</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-12T03:15:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_wrap: Remove ldb_transaction_cancel_noerr from ldb_wrap_fork_hook()
Writing to a TDB, without locks (these are per-process) in a forked child is never going to
end well, if a transaction is open at this point we have bigger problems.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/23ef25faf5f60d4fcbaec28ffebd249556028c75">23ef25fa</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-12T03:15:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Ensure to cancel the transaction if we fail to save the prefixMap
This rare error case forgot to call ldb_transaction_cancel()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bd5f6f5a8327398bb261582d0e2c2de23854ad5d">bd5f6f5a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-12T03:15:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Do not create a transaction in partition_init()
This will allow us to lock the databases for read during all of the Samba init
hooks.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13379
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a755c413c87155b8dd94d6938ae2ddbd1e328403">a755c413</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-12T03:15:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Allow search before init() call in encrypted_secrets
Simply do not decrypt anything until the init call is run.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13379
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a4778ad48e985931912f3fd2a7e27270ab4df8ce">a4778ad4</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-12T03:15:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Wait until a transaction starts to call dsdb_schema_set_indices_and_attributes()
This avoids starting a transaction in schema_load_init() and allows it
to operate with a read lock held, which will avoid locking issues
(deadlock detected due to lock odering if we do not have a global
read lock).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13379
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/18d4a1cc3fa1fd9635bdfa702a62fc81e50f4be9">18d4a1cc</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-12T03:15:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Make a transaction before @INDEXLIST etc is checked in dsdb_schema_attributes.py
This helps us remove the write to the database from the (soon to be
read locked) init code.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13379
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/63956116328c0d1b75ff23e115de0389d95ae137">63956116</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-12T03:15:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Create rootdse_get_private_data()
This will get the private data on the first call, allowing that not to be
the init() hook.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13379
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4d37f55cc127cb823821050a333ace8a06f92d2c">4d37f55c</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-12T03:15:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Move ldb_set_default_dns() into rootdse_get_private_data()
This call needs to be done at the very first chance, in this case
during the first call to the lock_read() hook, otherwise the
schema_data module can't find the schema.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13379
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6baf7608dfc3517cb3798fc53db849f49c6d157a">6baf7608</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-12T03:15:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Allow search before init() is called in extended_dn_out
This matches the earlier check of p && p->normalise.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13379
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6c9e658ec1bb959e20aaab6244daf27dd6232fe2">6c9e658e</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-12T03:15:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Load schema during the read_lock() hook, not the search
This should trigger slightly less often and is the more correct place, as
we only load it during the first lock when not in a transaction.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13379
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e9483c269a9ef9e585030ec5f0337f88e73d0863">e9483c26</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-12T03:15:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Rework schema reload during the read lock
Rather than refusing the reload based on making cached sequence numbers match
just load it once at the time the DB is globally locked, if required.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13379
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/887b48c49328f7cede260923a33633096402a763">887b48c4</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-12T03:15:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: ensure we take out a read lock during the dsdb_init
We have to also take it out in the partitions code when we load the
partition backends.
This ensures that the init handlers hold a whole-db lock just as the
search code does.
To ensure the locking count in schema_load is balanced, the
private data is now created in the first lock_read() call.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13379
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/132e932da2f203d005abea4412fcf2c483b7c489">132e932d</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-12T03:15:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Use talloc_get_type_abort() in schema_load_{start,end}_transaction
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13379
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a7cdec9ded016d6a1996a0d68dc9b7b029e78c7f">a7cdec9d</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-04-12T03:15:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_wrap: Remove the magic cache of database handles except for sam.ldb
sam.ldb is handled in samdb_connect_url(), not this function.
This cache caused issues when "private dir" was changed in a testing script, but also
just generates many-owner shared mutable state that is frowned upon these days.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/040a526a3bbcafeeebb6dd50a563a4635dd79fea">040a526a</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-04-12T03:15:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb-samba: require pid match for cached ldb
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/490756a8401189550aa549d2eb1600c30e1c5d30">490756a8</a></strong>
<div>
<span>by Arvid Requate</span>
<i>at 2018-04-12T06:12:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Check "auth event notification" param in log_json
When Samba is compiled with JSON support it logs an error message
at log level 3 by default for every authentication event:
get_auth_event_server: Failed to find 'auth_event' registered on the
message bus to send JSON authentication events to:
NT_STATUS_OBJECT_NAME_NOT_FOUND
This patch adjusts the log_json function to consider the smb.conf
parameter "auth event notification" before calling auth_message_send.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13381
Signed-off-by: Arvid Requate <requate@univention.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Apr 12 08:12:39 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cfd2d70889fdb07bba4d0bb05e59abe2128c84ee">cfd2d708</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-04-12T06:13:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Rename the inf_to class to gp_ext_setter
This class will be subclassed and used for more
than just inf settings application.
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d47ab7e2a49048f425d544b38bc980abb4f53ef">1d47ab7e</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-04-12T06:13:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Move gp_sec_ext __init__ to base class
For this class to be extensible, the constructor
should be available to subclasses.
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dc4151476923067b7659f42ca1f2c5f809cfef1e">dc415147</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-04-12T06:13:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Move the file parse function to gp_ext
A file will always be read from the sysvol the
same way, but the data will be read differently.
This patch moves the parse function to gp_ext,
and requires subclasses to implement the read()
function to interpret the data.
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/10b43aa1c9c1772af1485d93a8bdf53c31de211c">10b43aa1</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-04-12T06:13:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Create base class gp_inf_ext
Abstract the process of reading from an ini file,
since other extensions will be reading gpos this
way.
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/76cfbb6e8cec87b7f1b069dfed06a572359eab0f">76cfbb6e</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-04-12T06:13:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Move implementation from samba_gpoupdate
The implementation of group policy apply should
not be in the application script. One reason is
to implement user apply, we can call these
functions via the python c-api, (passing creds
via the command line will expose them via ps).
Another reason for this is if some overrides
the smb.conf "gpo update command" option, it
would be useful to have these functions.
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/477fd77c4d200f2c987caaf0c1740273c7a4e4a7">477fd77c</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-04-12T06:13:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Create a gp_sec_ext module
Move the gp_sec_ext into it's own module,
which is how new gp_ext's will be created.
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6747553d1b40dc82b6aae6173dff7d2f89deb90d">6747553d</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-04-12T06:13:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">param: Add python binding for lpcfg_cache_path
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8e25e2f3408bda87e2acffa3fc464c32173bb814">8e25e2f3</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-04-12T06:13:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libgpo: gpo_copy_file() shouldn't explicitly call smb1
Don't call cli_openx directly to open a file this
calls smb1 code explicitly, which fails if we did
a multi-protocol negotiate and negotiated smb2+.
Use the higher level cli_open() instead.
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/09c21214798ad435db488d206050d842b117166e">09c21214</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-04-12T09:27:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: python chardet is not a dep of samba
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Thu Apr 12 11:27:03 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87e25cd1e45bfe57292b62ffc44ddafc01c61ca0">87e25cd1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-12T09:28:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smb2_server: correctly maintain request counters for compound requests
If a session expires during a compound request chain,
we exit smbd_smb2_request_dispatch() with
'return smbd_smb2_request_error(req, ...)' before
calling smbd_smb2_request_dispatch_update_counts().
As req->request_counters_updated was only reset
within smbd_smb2_request_dispatch_update_counts(),
smbd_smb2_request_reply_update_counts() was called
twice on the same request, which triggers
SMB_ASSERT(op->request_count > 0);
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13215
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/40edd1bc273f664d5567ef5be169033899acee1f">40edd1bc</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-12T12:38:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Test compound request request counters
This will send an unfixed smbd into the
SMB_ASSERT(op->request_count > 0);
in smbd_smb2_request_reply_update_counts
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13215
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Apr 12 14:38:39 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de398573fe753a347cba35666fcf84b30a3307f7">de398573</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-12T15:26:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smb2_server: correctly maintain request counters for compound requests
If a session expires during a compound request chain,
we exit smbd_smb2_request_dispatch() with
'return smbd_smb2_request_error(req, ...)' before
calling smbd_smb2_request_dispatch_update_counts().
As req->request_counters_updated was only reset
within smbd_smb2_request_dispatch_update_counts(),
smbd_smb2_request_reply_update_counts() was called
twice on the same request, which triggers
SMB_ASSERT(op->request_count > 0);
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13215
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 87e25cd1e45bfe57292b62ffc44ddafc01c61ca0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7e010280ade0834638c58ca7c60ed2f0ff78c112">7e010280</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-12T20:55:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Test compound request request counters
This will send an unfixed smbd into the
SMB_ASSERT(op->request_count > 0);
in smbd_smb2_request_reply_update_counts
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13215
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Apr 12 14:38:39 CEST 2018 on sn-devel-144
(cherry picked from commit 40edd1bc273f664d5567ef5be169033899acee1f)
Autobuild-User(v4-8-test): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(v4-8-test): Thu Apr 12 22:55:22 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/23d841036d3ba8f2c80bee4edc89049533524e68">23d84103</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-12T21:04:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap: Fix "use mmap = no"
Mutexes require mmap.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Apr 12 23:04:18 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c7e7cad4bf82ad08c5f11616d15f80842a930e1">5c7e7cad</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-13T05:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/libcli: python3 port for smb module
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e48e6b08a5ba357726db7b4ec3dd5ba9b143471d">e48e6b08</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-04-13T05:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: create test for pysmb module.
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a58393b2b4ebb8f7744ed367f14953f40d2e948">4a58393b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-13T05:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript_build: make sure we link extra-python versions of libraries
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f24f0e1faff6531b6229238c94e2ad8463abcdab">f24f0e1f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-13T05:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/param/wscript: build PROVISION subsytem for extra-python/py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/84f7ead29ab6cd71a24022994c8af5812738b913">84f7ead2</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-13T05:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libnet/wscript: build samba-net lib for extra-python/py3
python_net needs to link appropriate samba-net library for extra-py/py3
version so we need to build it for extra-python/py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/62105101463b0e2247737483d0078fa768ccc1c5">62105101</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-13T05:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib/policy/wscript_build: build samba_policy lib for extra-python/py3
pypolicy module needs appropriate samba_policy library for
extra-python/py3 therefore we need to build it for it to be available
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6716971ce1b023affc2503b72e83c22581faf64a">6716971c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-13T05:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/wscript: build grouping library for py2/py3 (--extra-python)
Grouping library is not used for any delivered libraries, however
it is used internally when building local libraries used when
"make test TESTS='blah'" is invoked. Failure to provide the grouping
library results in missing symbols (and cores) when running tests
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f3b52875388da6e064567621a53e9ccb508dc6d5">f3b52875</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: bulk replace dict.iteritems to items for py3
In py3, iterxxx methods are removed.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2892293182f282336f08ed17315ae744aa72bddc">28922931</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: bulk port tdb iterkeys for py3
In py3, `dict.iterkeys()` is removed, we need to use `keys()` instead.
This is compatible with py2 since `dict.keys()` exists for py2.
tdb pretents to be a dict, however, not completely.
It provides `iterkeys()` for py2 only, and `keys()` for py3 only,
which means replace `iterkeys()` to `keys()` will break py2.
In python, iter a dict will implicitly iter on keys.
Use this feature to work around.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9d79329d3d346780f4b3543a979c6af1e3bdc5f0">9d79329d</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: bulk replace dict.itervalues to values for py3
In py3, iterxxx methods are removed.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8432ca2b48385e4372fed306329f03185b46a620">8432ca2b</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: bulk replace file to open for py3
The builtin function `file` was removed in py3. Use `open` instead.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5258add3aaf9b9f077d4629355afc7b35cc58cd1">5258add3</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: bulk convert zip to list
In py3, zip will return a iterator other than a list.
Convert it to a list to support both py2 and py3.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aeb6e07df3c65356ca6560c48d3c45648c550774">aeb6e07d</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: fix unicode escape in doc string
The doc string has `\u` mark inside, which will cause encoding error in
py3. prefix `r` to doc string to fix.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/01ace23512adaf956e9db9dfaf559b14dc23c589">01ace235</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.dcerpc.sam
1. Fix invalid declaration syntax for toArray
2. Simplify toArray implementation with list comprehension.
3. Remove ending L for long integer.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e209cc2ee2f0dae5733e58b681eb27ab9bb3beae">e209cc2e</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.dcerpc.bare
Prefix b to bytes.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b8b40fabf64ae92ebb0694529c13fc178edaf55">9b8b40fa</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.dcerpc.rpcecho
Prefix `b` for bytes.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fb972815656618654b787d3414bc4ac4f41adb41">fb972815</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.dcerpc.registry
No changes needed.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eec07f2fe5eab8046eed78c7c4439732f9f2118b">eec07f2f</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.lsa_string
No change needed.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c07068038857bb93e3cf7f9f058054a3c9bda253">c0706803</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.source
In py2, `open` has no `encoding` arg, python guesses file encoding from
locale. This could be wrong.
Use `io.open` to open a file, so we can specify encoding in both py2 and
py3.
Also, open file with `r` instead of `rb` for py3.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9f591369ee9359961237a03eb19672a47cb4e11">a9f59136</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.docs
Popen methods will return bytes.
Decode output to string before using.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/470499fda32f10769a03df5c9a68a64d4261b2e6">470499fd</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: enable py3 for samba.tests.krb5_credentials
Fix encoding issue.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fadd2cec39ab38215c36e4d996ced38b95f66d37">fadd2cec</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">graph: fix divide for py3
`/` will return float other than int in py3.
Use `//` to keep consistent with py2.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6d696d61dd2b3eb144a2ccabb0f7e2cd974959b7">6d696d61</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">graph: fix sort for py3
`sorted` can not sort `None` with str in py3, use the `key` arg to fix.
Sort None as ''.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d1312c86d6ad5c813838eb653f71eedda8a97292">d1312c86</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-04-13T05:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/graph: actually test graphs, don't print
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/16a228ca3303e750d5035735fdc1472e18e9ee58">16a228ca</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/graph: enable py3 for samba.tests.graph
Changes are made separatedly in previous commits.
No change needed here.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/767f6e599af81f7b2be42981d997c3c02f7ac70c">767f6e59</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kcc/graph_utils: port string.translate for py3
In py3, `str.translate` removed the second positional argument
`deletechars`, which means you can not use it to delete chars from str.
Use `replace` for this case.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/09081eae3d821352786dfb38630ae10e6072040e">09081eae</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kcc/kcc_utils: convert dict.keys to list
In py3, `dict.keys()` will return a iterator not a list.
Convert it to list to support both py2 and py3.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/949109442f7d74b2bab820c6ef0a5a80685b5694">94910944</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kcc/kcc_utils: fix divide for py3
`/` will return float other than int in py3.
Use `//` to keep consistent with py2.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c7f3c91b62c3f8f2bb44fc23bf65710e4b290105">c7f3c91b</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kcc: fix sort for py3
py2:
list.sort(cmp=None, key=None, reverse=False)
sorted(iterable[, cmp[, key[, reverse]]])
py3:
list.sort(key=None, reverse=False)
sorted(iterable, *, key=None, reverse=False)
The `cmp` arg was removed in py3, make use of `key` arg to work around.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6eb3391cc251cac484ce34397c18373331ffcb78">6eb3391c</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T05:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kcc/graph: add __hash__ to InternalEdge for py3
In py3, if a class defines `__eq__()` but not `__hash__()`, its instances will
not be usable as items in hashable collections, e.g.: set.
Add `__hash__()` to InternalEdge, so it can be added to a set in py3.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0d56edb9bbffe137f1e0ac90c0c90f1d3cba9909">0d56edb9</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-04-13T05:27:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb/pyldb: initialize optional parameter in ldb_connect()
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e62d2bd498cae5465d8f192c5fc20daf772aa843">e62d2bd4</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-04-13T05:27:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt/pynbt: initialize optional parameter in nbt_name_register
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/399c22a86f0b8614137f783d957547ade219e431">399c22a8</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-04-13T05:27:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt/pynbt: initialize optional parameter in nbt_name_refresh
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a305014b530145563a581e880a14af17fc3fc04">2a305014</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-04-13T05:27:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/py_passdb: initialize optional parameters earlier
It is just a bit easier to see what is happening.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/30fb803ec07eb865c4c31c54320cef08e1cafff0">30fb803e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-04-13T05:27:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/lib/py-registry: initialize optional parameters for open_* functions
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c034caaf956dd7bf151ca86fe028928befe88f7b">c034caaf</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-04-13T05:27:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/webserver: initialise optional parameter
OK, this is unused and unimplemented.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ce63db26a1d9fd2272e7d708965557d0461a4eac">ce63db26</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-04-13T08:36:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_relay: bulk port print to modern py3 style
Change print to function and avoid the ugly `print >>sys.stderr`.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Fri Apr 13 10:36:32 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5fea3e3f23cf75e111b9043ddad8a93aad6c06bf">5fea3e3f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-13T16:14:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnbt: Add an explicit "mem_ctx" to name_request_send
Implicitly hanging requests off nbtsock is too inflexible for future use
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b770e646aa28e6ef36647f42b97a8330203bbd0">8b770e64</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-13T16:14:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnbt: Align data types
ARRAY_SIZE returns size_t
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b8f71674742a45c296b6ef6a69be3870c4ddf61c">b8f71674</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-13T19:04:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libdgram: Fix an error path memleak
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Apr 13 21:04:28 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/115423c95669772d2a8874c7557f76cd1bd567be">115423c9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-16T14:06:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tstream: Fix CID 1167982 Unchecked return value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78c3533729c99527e07813170f70bed1a3c836b2">78c35337</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-16T17:09:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tstream: Fix CID 1167981 Unchecked return value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Apr 16 19:09:56 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c988a56bd2e0faacc4eb6817e2aa3f7867a21657">c988a56b</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-04-17T19:07:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Mark libparse-pidl-perl, samba-dev, samba-dsdb-modules and samba-vfs-modules "Multi-Arch: same"
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/22703181d74e97bb4d3af63e51b1287fa2a38e69">22703181</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-04-17T19:08:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Standards-Version: 4.1.4, no change
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/54d35a1a98796d0445eafa0d63309efaf2bf832e">54d35a1a</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-04-17T19:18:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debian/smb.conf: Fix typo in comment line: sever -> server (Closes: #763648)
Signed-off-by: Santiago Vila <sanvila@debian.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/27c9121eb048cde2e20906c85d9839d7c798ce07">27c9121e</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-04-17T19:18:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Changelog for previous commits
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e6df6f206d568e313e9da99461ae5502d06d7eb1">e6df6f20</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-17T19:27:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: Factor out nbtd_name_query_reply_packet
Separate packet creation from sending out the packet. This way packet
creation can be used elsewhere in the future.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a7d5250597f5ae7a2b4555d12e0f12212e27fb3d">a7d52505</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-17T19:27:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: Factor out nbtd_node_status_reply_packet
Separate packet creation from sending out the packet. This way packet
creation can be used elsewhere in the future.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3ce079982b09ad189ffcc22ec27e0964bc7f467a">3ce07998</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-04-17T20:09:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Read smb.conf until [print$] section instead of [cdrom] to preserve locally-defined shares (Closes: #776259)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/04bfc02107845ed941cf7cfd5003a56736d78d54">04bfc021</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-04-17T20:19:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dhclient3 was renamed to dhclient long time ago...
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a306f25021195221a28da13231e998ed3861d1f0">a306f250</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-04-17T20:22:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Remove /etc/samba/dhcp.conf on purge (Closes: #784713)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fc473cd28261478cc9c3232b43fc725f0468f8a9">fc473cd2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-17T22:11:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: Align integer types
sizeof returns size_t
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Apr 18 00:11:51 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cc1eed99bda3773dc13e927f1df1c4fd72e4b848">cc1eed99</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-04-18T13:25:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: add option to choose to build with or without JSON audit support
Add a new configure option:
--with-json-audit
Build with JSON auth audit support (default=auto). This requires
the jansson devel package.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): <bbaumbach@samba.org>
Autobuild-Date(master): Wed Apr 18 15:25:42 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99859479fc6e12b2f74ce2dfa83da56d8b8f3d26">99859479</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-18T22:32:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:passdb: Do not return OK if we don't have pinfo set up
This prevents a crash in fill_mem_keytab_from_secrets()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13376
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Apr 19 00:32:22 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/18c097bc4984b679f4e3960bc5ae0b39abbe0781">18c097bc</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-04-19T08:08:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Move dhcp.conf out of /etc to allow ro root (Closes: #695362)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a4e2904c3d3e15236f1d658739d9e6635dfb285">9a4e2904</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-04-19T08:23:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update template for "Move dhcp.conf out of /etc to allow ro root"
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f3ab35a6243361de946a37f9b99af40b288d7cf">9f3ab35a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-19T09:40:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libads: Fix the build --without-ads
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Tue Feb 6 02:47:44 CET 2018 on sn-devel-144
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13273
(cherry picked from commit 859698d29b547217356851094ed8188236e717b6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a25ec76b6118c722378548655c1862db9e1bca42">a25ec76b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-19T09:40:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpc_server: Init local_server_* in make_internal_rpc_pipe_socketpair
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13370
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Apr 11 15:19:19 CEST 2018 on sn-devel-144
(cherry picked from commit 212815969f4a706bc8395e2f6dbf225318ff2ad7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/daf2c88a3fcc4b619da131c95595584bca80c345">daf2c88a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-19T09:40:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Handle long-running smb2cli_notify
This likely runs into a timeout. Properly cancel the smb2 request,
allowing the higher-level caller to re-issue this request on an existing
handle.
I did not see a proper way to achieve this with tevent_req_set_endtime or
something like that.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13382
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 91c0f497816bb88d8935a8a79c146c08379ecf53)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/61470f63f8c053f393070f6052f77fb0a9d7a4cc">61470f63</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-19T09:40:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Handle IO_TIMEOUT in cli_smb2_notify properly
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13382
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit abfe482828e8c1dc233d67657a4d11a91a731f70)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c45c96e94ed052bb1bb8d27a1eadcd611ab7af4a">c45c96e9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-19T14:16:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbclient: Handle ENUM_DIR in "notify" command
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13382
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Apr 5 04:05:52 CEST 2018 on sn-devel-144
(cherry picked from commit 1452677ef0044815df0702de5424d4711e18144b)
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Thu Apr 19 16:16:41 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ade0d54563fd11f1ca4cbae7d9550504b24473c7">ade0d545</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-20T09:56:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">utils: Add destroy_netlogon_creds_cli
This is a pure testing utility that will garble the netlogon_creds_cli
session_key. This creates a similar effect to our schannel credentials
as does a domain controller reboot.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit bffae41842fe218959fe6f8b43df694feec1589c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ad0b42ae90e8409133227666bb6cb0972cf96d44">ad0b42ae</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-20T09:56:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Add smbcontrol disconnect-dc
Make a winbind child drop all DC connections
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(backported from commit 0af88b98e7e1bba14827305257e77b63dc82d902)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1e60ca513b5c46ba2cd28a70237719eb0b32c6fe">1e60ca51</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-20T09:56:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Keep "force_reauth" in invalidate_cm_connection
Right now I don't see a way to actually force a re-serverauth
from the client side as long as an entry in netlogon_creds_cli.tdb
exists. cm_connect_netlogon goes through invalidate_cm_connection, and
this wipes our wish to force a reauthenticatoin. Keep this intact until
we actually did reauthenticate.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 4b7a9d560a51b51ac88f30276c87edc097b00d0b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/586a0ff38fa43ee837d10c982a480449d53ba88d">586a0ff3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-20T09:56:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: add and use ldap_reconnect_need_retry() in winbindd_reconnect_ads.c
ldap_reconnect_need_retry() is a copy of reconnect_need_retry() minus
the RPC connection invalidation.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit a8d5e4d36768bc199c631626488b2d0acbd6e91a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c701c461676a37b57f6b628e3729e8366699dda">5c701c46</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-20T09:56:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: check for NT_STATUS_IO_DEVICE_ERROR in reset_cm_connection_on_error()
reconnect_need_retry() already checks for this error, it surfaces up
from tstream_smbXcli_np as a mapping for EIO.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit a33c1d25e0422483c903001dd246626f84c4cbc1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4d2968cb1513c54ce5eca7f1ef43fe0e8dd77f41">4d2968cb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-20T09:56:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: make reset_cm_connection_on_error() public
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 17749a5d9fa08da1c61de45728656a2c9b85782d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d9aa1d560f9e061665a67c6fe8fc0fea357ca17">7d9aa1d5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-20T09:56:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: call reset_cm_connection_on_error() from reconnect_need_retry()
This ensures we use the same disconnect logic in the reconnect backend,
which calls reconnect_need_retry(), and in the dual_srv frontend which
calls reset_cm_connection_on_error.
Both reset_cm_connection_on_error() and reconnect_need_retry() are very
similar, both return a bool indicating whether a retry should be
attempted, unfortunately the functions have a different default return,
so I don't dare unifying them, but instead just call one from the other.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 2837b796af3e491b6bb34bd441758ae214f629ee)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cde7022ccb868d0139f1104729a0f2c4db5ff740">cde7022c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-20T09:56:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: force netlogon reauth for certain errors in reset_cm_connection_on_error()
NT_STATUS_RPC_SEC_PKG_ERROR is returned by the server if the server
doesn't know the server-side netlogon credentials anymore, eg after a
reboot. If this happens we must force a full netlogon reauth.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Volker Lendecke <vl@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 2d1f00cc3ad77bed4e810dc910979e6cdf582216)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c4fd5a390dfb6dbc4def7de110102008a765db85">c4fd5a39</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-20T09:56:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: call dcerpc_binding_handle_is_connected() from reset_cm_connection_on_error()
To consolidate the error handling for RPC calls, add the binding handle
as an additional argument to reset_cm_connection_on_error().
All callers pass NULL for now, so no change in behaviour up to here.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 966ff3793a867a5ffe1a49e48c8ab3ecb02f8359)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5bf61b01164afec5678818cdfd5e1980ddc37acc">5bf61b01</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-20T09:56:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: fix logic calling dcerpc_binding_handle_is_connected()
The calls were missing the negation operator, a retry should be
attempted is the binding handle got somehow disconnected behind the
scenes and is NOT connected.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 08718af36f3ed6cf2308beb3800abfb0414f94b9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6e1018e5887031a011d34cb2817c6818fbd7036c">6e1018e5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-20T09:56:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: use reset_cm_connection_on_error() instead of dcerpc_binding_handle_is_connected()
This catches more errors and triggers retry as appropriate.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 6244a2beb184de8d050389e304f087ef153d61dd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f9ccb90f2322529af882d244111728df66661010">f9ccb90f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-20T09:56:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: add retry to _wbint_LookupSids()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit c2cd2d3f3137e27cd6e4cabd34f27b49251f078d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ce6357b678dc0f16fc661a543a5298ddf17eac70">ce6357b6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-20T09:56:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: add retry to _wbint_DsGetDcName
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit fcf8edf9b8cdf5f3897c1a63ed97c302a231742f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/71eb2d9c2a41cf40e084f2e4ce98c56211ae1382">71eb2d9c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-20T09:56:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: add retry to _winbind_DsrUpdateReadOnlyServerDnsRecords
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit e608f058b8f2d2295e24498daa35852de3212b23)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8abea57ec7c143cf793f502793a411f5cdd17f1">f8abea57</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-20T09:56:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: add retry to _winbind_SendToSam
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13332
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Mar 15 20:57:44 CET 2018 on sn-devel-144
(cherry picked from commit c37fbfcb248e5a8d6088a28eb0c1a62423f94502)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cd2cc69eb46e561155856355c513b3acdb6af9dc">cd2cc69e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-20T09:56:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/util: remove unused '#include <sys/syscall.h>' from tests/tfork.c
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13342
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit f2ff61ce9e8ab56d8a69fce29c9f214d5d98f89e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f11278fa9b9a91f2b6f73138a774034eb6048079">f11278fa</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-04-20T09:56:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:passdb: Do not return OK if we don't have pinfo set up
This prevents a crash in fill_mem_keytab_from_secrets()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13376
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 99859479fc6e12b2f74ce2dfa83da56d8b8f3d26)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/63d9b5323d74eada4ba2cd7b9aa1819e1b38779e">63d9b532</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-20T09:56:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/replace: define __[u]intptr_t_defined if we prove an replacement
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13344
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
(cherry picked from commit 329a229af3c3c9475b9254ca68c413ec18fa3b71)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5cc7432b1d160c9406e093792b9e3cd310318b2c">5cc7432b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-20T09:56:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: maintain prototypes for the linux based functions only once
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13344
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
(cherry picked from commit b8c30abb02f461f16af4da83eecd173993974dc1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f0aa869b1b2f136d046a8d22634cbc77bbb2d14a">f0aa869b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-20T09:56:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: add some const to _nss_winbind_initgroups_dyn() prototype
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13344
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
(cherry picked from commit d5be3b3279162005d9ebea2eda71d455e4c48739)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9e1b535d10b1cc3d8aa1fffa4cd33bba4d97a009">9e1b535d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-20T09:56:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: fix the developer build of nsswitch/wins.c on freebsd 11
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13344
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
(cherry picked from commit dc160247d13e2c63574a7e7ec7720fc4c690483b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c703cfb4c1cbeae9827594f59a2e02f78eafd101">c703cfb4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-20T09:56:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_virusfilter: Fix CID 1428739 Buffer not null terminated
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13343
(cherry picked from commit 8a4409c956bdbe5d928e685b7c219566d467a627)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/932bdb2052d21b70ecb6e473a7174c9cb3acad21">932bdb20</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-20T09:56:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_virusfilter: Fix CID 1428740 Macro compares unsigned to 0
vsnprintf returns "int" and not "size_t"
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13343
(cherry picked from commit 734404bbe911fd4aa6565b2a2aaecab4fbbf3c45)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bade8dc3ccd1be5dba7d1dd61081a0763f770715">bade8dc3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-20T09:56:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_virusfilter: Fix CID 1428738 Macro compares unsigned to 0
vsnprintf returns "int" and not "size_t"
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jan 31 05:28:48 CET 2018 on sn-devel-144
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13343
(cherry picked from commit 21eb5169f46b8d819a5d5d028baff581e4e63de6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/deb624c8939fbd4a41b690ec410caa377ddf0bfd">deb624c8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-20T09:56:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: fix the picky-developer build of vfs_virusfilter.c on FreeBSD 11
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13344
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
(cherry picked from commit fb7b67af984812784756574df4f0fb55d472181b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/08d5ade345c2a4d92512dfe1e3019ab54e5473b6">08d5ade3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-20T09:56:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: make virusfilter_io_connect_path() more portable
We have existing utility functions to prepare a socket.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13343
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
(cherry picked from commit 74278a70389e2479d80ec5c88b01a09c141e8d39)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8c0a598b035295713ce0c2c0df444ac01b336b68">8c0a598b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-20T09:56:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/crypto: avoid 'return void_function();' which isn't portable
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13343
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
(cherry picked from commit 7ae77db3b29ef08e1f74aa413049b995a598a5dd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/74da4c879a1db1bd9ebac9df9bcfee00fa762015">74da4c87</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-20T09:56:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb/tests: avoid 'return void_function();' which isn't portable
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13343
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
(cherry picked from commit 666dda907b7f190b2dff1f2639bd2518240b9fb2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c67a2f85a7b9331feaef1489cbaaba11de4f9748">c67a2f85</a></strong>
<div>
<span>by William Brown</span>
<i>at 2018-04-20T13:23:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_wrap.c missing header
ldb_wrap.c was missing unistd.h causing implicit symbol declaration and error
during compilation.
Signed-off-by: William Brown <william@blackhats.net.au>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Simo Sorce <idra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/98fb60b1ee32406a0705a831dd2207efca5160e8">98fb60b1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-20T14:53:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: fix the build of vfs_aixacl2.c
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13345
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Apr 3 20:18:58 CEST 2018 on sn-devel-144
(cherry picked from commit 702665cc52d5dc05ae636519e1ffe9c296f5ef77)
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Fri Apr 20 16:53:16 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a18b51000ef2ab5c9c111490394ce0e2425edee2">a18b5100</a></strong>
<div>
<span>by William Brown</span>
<i>at 2018-04-20T16:18:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/security.c undefined value
s3/security.c had an NTSTATUS status that was undefined and with the configure
option --address-sanitizer this caused uninitialised value error.
Signed-off-by: William Brown <william@blackhats.net.au>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Simo Sorce <idra@samba.org>
Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Fri Apr 20 18:18:25 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/57d9969f5cd681cd02017c0b41fcbb12fe10fb08">57d9969f</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-04-20T19:12:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: fix build without JSON audit support
Autobuild-User(master): Björn Baumbach <bbaumbach@samba.org>
Autobuild-Date(master): Fri Apr 20 21:12:33 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/74590c6795f8dac5d62d78273730910819395b89">74590c67</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-23T08:30:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: call pthreadpool_tevent_init() already in smbd_process()
pthreadpool_tevent_init() doesn't start any thread yet, it only
allocates a bit of memory.
It's easier to start this in a central place, so that it's
available to all VFS modules.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ba243f3e72253992e6af3a2cc2bd0562170845f">7ba243f3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-23T08:30:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml: rewrite the vfs_aio_pthread manpage to reflect the >= 4.0.0 behavior
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b805a5975ec9b5f152803764e5e5f02a92e8ddba">b805a597</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-23T08:30:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: add some basic testing for aio_pthread
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b5a34e65d1cbe08da733ae79078bf76f83c3fbe4">b5a34e65</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-23T11:30:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:vfs_aio_pthread: make use of pthreadpool_tevent instead of pthreadpool_pipe
pthreadpool_tevent provides a much simpler api and avoids an extra
pipe for the completion notification.
This means we now have just one thread pool, that's shared for
all async pread, pwrite, fsync and openat() calls, instead of having
an extra pool for openat() with the same possible number of threads.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Apr 23 13:30:06 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f092ee2a5f02637f9ed55253a83d4132e0e4831d">f092ee2a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-23T23:53:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: Call dbwrap_local_open with the correct hash size
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ca6efa96f769a2106f754e332c347ee41d3fc447">ca6efa96</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-23T23:53:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: Call dbwrap_local_open with the correct tdb_flags
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7e183a22a7995db09c9bed561ab0de71dbdfdbcb">7e183a22</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-23T23:53:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">credentials: Call dbwrap_local_open with the correct hash size
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f09fd2b4c07fcf0e0d132d1fb487f1c1e040ad4">7f09fd2b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-23T23:53:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">credentials: Call dbwrap_local_open with the correct tdb_flags
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/281822ac8e5ea3a23257d60f5bd9611e63faff0e">281822ac</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-23T23:53:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">cluster4: Call dbwrap_local_open with the correct hash size
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f542552e1d104fa7cc738401c8b224e06ebb478a">f542552e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-23T23:53:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">cluster4: Call dbwrap_local_open with the correct tdb_flags
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/247563e10b22797f4a8110861a9e7623971e4b81">247563e1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-23T23:53:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap3: Call dbwrap_local_open with the correct hash size
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/91bb8b8ec6389f69608b6e2dcd09aca407ef05d2">91bb8b8e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-23T23:53:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap3: Call dbwrap_local_open with the correct tdb flags
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/807cb593ec00d07a5a0328db516960add2ba0336">807cb593</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-23T23:53:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: Call dbwrap_local_open with the correct hash size
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/812312ca170e9da876044846a35b28ea3ce30de6">812312ca</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-23T23:53:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: Call dbwrap_local_open with the correct tdb flags
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1aeac2f85db045d565e30d8b94334366e39222e9">1aeac2f8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-23T23:53:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap: Remove calls to loadparm
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/27e6e45164b1eda8b96701b609a09bda631db6e7">27e6e451</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-23T23:53:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap: Remove dependency on samba-hostconfig
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0b042589819caa364a4f8518931b5b7a3b22f708">0b042589</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-24T02:44:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Remove an unused struct declaration
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Apr 24 04:44:30 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fdcc1622082eaea3fc03c0346a56afbbff88e6d1">fdcc1622</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-24T09:13:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:messages: check reg->refcount == 0 before accessing other elements
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dfb712a03c2bd36641506ae9cfce1a0820e1a329">dfb712a0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-24T09:13:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:messages: check tevent_fd_get_flags() == 0 before using stale event context pointer
If the event context got deleted, tevent_fd_get_flags() will return 0
for the stale fde. In that case we should not use fde_ev->ev anymore.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8e5cc9732bb99df912bfd0fa09f7c14068f09874">8e5cc973</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-24T12:30:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:messages: improve tevent_create_immediate recycling
We should create the immediate event at the beginning
were we have a chance to return an error, rather than
ignoring a failure later.
As a side effect this also reuses the immediate event
after the refcount went to 0 and up again.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Apr 24 14:30:20 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ffe970007bf934955f72ec2d73bf8f94a2b796eb">ffe97000</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-24T12:32:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: fix memory leak in winbind_open_pipe_sock() when the privileged pipe is not accessable.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13400
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6120f568017544425071c9ad817faa236fd27058">6120f568</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-24T12:32:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ntlm_auth: PAM_AUTH_CRAP needs a privileged socket
This only works right now because wb_common always tries privileged
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fdf0b2a784f83f9fcaa204be7f28f9e7fc47836b">fdf0b2a7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-24T12:32:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Only connect to the priv socket if required
This should speed up calls like "wbinfo -p"
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ffeb2acf65ef0b669f57b3f6f047db03b2f1a6c6">ffeb2acf</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-24T15:18:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Speed up wbinfo -p
This was (possibly) used as an example in the early days of the async winbind
code we have today. It's not necessary to send this through a full tevent_req
round.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Apr 24 17:18:23 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a4d2eedafe333395d2fc1ce90fee5d63b11c6036">a4d2eeda</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-04-24T17:41:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:util: remove reinit_after_fork_pipe_handler before sending SIGTERM
We should not keep the tevent_fd active when we sending us a SIGTERM,
this is not a real problem, but due to a different bug I triggered
a 100% cpu loop. I think it's safer to idle in that case instead
of waisting a lot of energy.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4fa8e5671584025d9553cac00210aca7ef62695a">4fa8e567</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-24T17:41:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture3: Fix CID 1435119 Error handling issues (CHECKED_RETURN)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a37d9a45d1ff1b5d311d190a8aac49bc2b2c7a9f">a37d9a45</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-24T17:41:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: Fix callers of tevent_req_set_endtime
tevent_req_set_endtime internally already calls tevent_req_nomem and thus sets
the error status correctly.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d7cfb12bf3a29f31cd158246578ffbbf793d5425">d7cfb12b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-04-24T20:26:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: #include "util_event.h" only where needed
One dependency of includes.h less
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Apr 24 22:26:22 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c4bb166a7bc7805d955926081fe1f2ad7de512ae">c4bb166a</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-04-24T20:40:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Enable --accel-aes=intelaesni on DEB_HOST_GNU_CPU=x86_64 (Closes: #896196)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/35f2afe411a3b22fb1befadb3bee8da1bc14753c">35f2afe4</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2018-04-25T11:55:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">printing: return the same error code as windows does on upload failures
Some print drivers inf files are broken and cause driver installation to fail
on Samba servers. Windows returns WERR_APP_INIT_FAILURE in that case, we should
do the same. Windows machines are less unlucky with that.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13395
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Wed Apr 25 13:55:25 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e1125da58970869c34b14163c2db0adb9ac924b">0e1125da</a></strong>
<div>
<span>by William Brown</span>
<i>at 2018-04-25T17:59:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/smbd/server.c: create /run if missing
In some cases (containers mainly) /var/run may not be present. Instead of
erroring, we should create it at startup.
Signed-off-by: William Brown <william@blackhats.net.au>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/501819fa9e7926c2f54cb92d508ac0e8437fd476">501819fa</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-04-25T17:59:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpcclient: Print number of entries for NetSessEnum
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13407
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e04846c7df8e3eec1f3dbb2fc5eaf47ceb1c44d2">e04846c7</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-04-25T17:59:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add testcase for querying sessions after smbd crash
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13407
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a6fade4e10760284ef56abf45d3fa70038091cbe">a6fade4e</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-04-25T20:49:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpc_server: Fix NetSessEnum with stale sessions
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13407
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Apr 25 22:49:07 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8649e216650de85cd73eda64caa2e338d59582d5">8649e216</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-25T23:09:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add a wrapper script as git pre-commit hook
When developer mode is enabled, the wrapper script
"script/git-hooks/pre-commit-hook" gets installed as
.git/hooks/pre-commit
and calls "script/git-hooks/pre-commit-script".
This way we can later modify the "script/git-hooks/pre-commit-script"
without the need to ever change the installed commit hook itself.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Jeremy Allison <jra at samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5757d259321f20fab349fd1a0d447473ba2c8fc6">5757d259</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-04-26T01:54:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script/git-hooks: add check-trailing-whitespace
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Apr 26 03:54:39 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4ec993932b2bd584a8cd36785d727899f88ce442">4ec99393</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-04-26T07:16:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.8.1.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e5b036ddc413389ac7b967af85b97e86d8128f55">e5b036dd</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-04-26T07:16:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.8.1 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f1bf8d74cc910c1a48c105b85c71dc84ffda8f10">f1bf8d74</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-04-26T07:17:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.8.2...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a83fb4544607589cd85c95f2fa4a57b327d2d1b">6a83fb45</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-04-26T18:41:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">New upstream version 4.8.1+dfsg</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70f411c0ad70b6f93fc841d7283d99b4d3442d5f">70f411c0</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-04-26T18:51:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge tag 'upstream/4.8.1+dfsg'
Upstream version 4.8.1+dfsg
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7dbf83369705bf2fe7c4d6b79ddf794ea8adb5db">7dbf8336</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-04-27T04:53:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Fix some -Werror=strict-overflow issues
All quite obvious. For the LCP2 one, we're not actually counting so
use a bool instead of an int.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d8741feec533934e02bd54b7bcc4fb71dbe1a1e1">d8741fee</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-04-27T04:53:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Avoid shellcheck SC1117: Backslash is literal in "..."
This warning (apparently new in shellcheck 0.4.7) only applies to
double-quoted strings. Change affected constant strings to use
single-quotes. In the one example that contains a variable expansion
escape the backslash as recommended.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d44fed601d4e867cd2d282df5673753d2aefb0c9">d44fed60</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-04-27T04:53:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Avoid filtering stderr when onnode not running in parallel
stderr_filter() only does anything useful when running in
parallel (i.e. with the -p option). So, simplify the non-parallel
case by not using stderr_filter().
As a side-effect, this fixes an issue introduced in commit
85a4375788d8ef8345ec390807f18299abdadb20 where local daemon tests
would hang when trying to start daemons with VALGRIND set (to a
valgrind command that does not use --log-file). This is because
valgrind would keep stderr open for its output so the pipeline
involving stderr_filter() would never complete.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3388aed012d269ee896a71bddcc5570f16b92d6a">3388aed0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-04-27T04:53:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Drop references to CTDB_BASE from the documentation
CTDB_BASE should only ever be modified by test code. It should not be
mentioned in the user documentation.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/072650b40e79f407c16144ab441c26f469d89d29">072650b4</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-04-27T04:53:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Drop stale reference to unused configuration file
Recently removed but documentation change was forgotten.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dbc6ebc6244c2c409bbbb31ef922a7eab93d6f6a">dbc6ebc6</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-04-27T04:53:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Drop documentation for CTDB_SHUTDOWN_TIMEOUT option
This was recently removed but the documentation was forgotten.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/26430ab1d1d5edb64cd6c9fe279e5beb264a1c38">26430ab1</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-04-27T04:53:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop unused variable service_config
This was previously used by the loadconfig() function.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/110e72ccd8e241cb8bed7e257ee9d96767fd9e24">110e72cc</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-04-27T07:37:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop CTDB_RC_LOCAL testing hook
This is not used.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Apr 27 09:37:49 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/31c390407e4a563a187feeb478571b874361d755">31c39040</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-04-29T08:32:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Use dh-exec to install libaesni-intel.so.0 only on amd64
dh-exec (>= 0.13) in Debian>=jessie
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f249731b9597256e7449d7d117639b05dec49f16">f249731b</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-04-29T10:56:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Release 2:4.8.1+dfsg-1
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/693ca7b99e6b2bcce5a3a9c375a2c7e83a053894">693ca7b9</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-04-30T09:41:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Simplify a test
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a23d80547545f1d367ef446d6d7173999ca4e97c">a23d8054</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-04-30T12:26:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Fix a typo
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon Apr 30 14:26:43 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f477a7585b606a5f665636868da24da812f46da0">f477a758</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-04-30T13:43:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool visualize: use correct DC in graph label
We have been using a random DC (depending to hash order, which was not
random enough on Python 2.7 to affect the tests).
Reported-by: Noel Power <noel.power@suse.com>
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/db8da077ec5d2b23f2219dd8d667c85d38f56ca8">db8da077</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-30T13:43:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/ldb: Additionally accept unicode as string param in Py2
With the changes to make samba python code Py2/Py3 compatible there
now are many instances where string content is decoded.
Decoded string variables in Py2 are returned as the unicode type. Many
Py2 c-module functions that take string arguments only check for the
string type. However now it's quite possibe the content formally passed
as a string argument is now passed as unicode after being decoded,
such arguments are rejected and code can fail subtly. This only affects
places where the type is directly checked e.g. via PyStr_Check etc.
arguments that are parsed by ParseTuple* functions generally already
accept both string and unicode (if 's', 'z', 's*' format specifiers
are used)
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/702e85e48fc4972714c57683f4c7b1daf775bd5c">702e85e4</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-30T13:43:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/tevent: Additionally accept unicode as string param in Py2
With the changes to make samba python code Py2/Py3 compatible there
now are many instances where string content is decoded.
Decoded string variables in Py2 are returned as the unicode type. Many
Py2 c-module functions that take string arguments only check for the
string type. However now it's quite possibe the content formally passed
as a string argument is now passed as unicode after being decoded,
such arguments are rejected and code can fail subtly. This only affects
places where the type is directly checked e.g. via PyStr_Check etc.
arguments that are parsed by ParseTuple* functions generally already
accept both string and unicode (if 's', 'z', 's*' format specifiers
are used)
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7020af427ecb923015ba07ede45d4bb282db25e4">7020af42</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-30T13:43:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/nbt: Additionally accept unicode as string param in Py2
With the changes to make samba python code Py2/Py3 compatible there
now are many instances where string content is decoded.
Decoded string variables in Py2 are returned as the unicode type. Many
Py2 c-module functions that take string arguments only check for the
string type. However now it's quite possibe the content formally passed
as a string argument is now passed as unicode after being decoded,
such arguments are rejected and code can fail subtly. This only affects
places where the type is directly checked e.g. via PyStr_Check etc.
arguments that are parsed by ParseTuple* functions generally already
accept both string and unicode (if 's', 'z', 's*' format specifiers
are used)
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3544f1b5d2713479dea2a7ce27da11c8d2b85a90">3544f1b5</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-30T13:43:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/auth: Additionally accept unicode as string param in Py2
With the changes to make samba python code Py2/Py3 compatible there
now are many instances where string content is decoded.
Decoded string variables in Py2 are returned as the unicode type. Many
Py2 c-module functions that take string arguments only check for the
string type. However now it's quite possibe the content formally passed
as a string argument is now passed as unicode after being decoded,
such arguments are rejected and code can fail subtly. This only affects
places where the type is directly checked e.g. via PyStr_Check etc.
arguments that are parsed by ParseTuple* functions generally already
accept both string and unicode (if 's', 'z', 's*' format specifiers
are used)
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5055b54d4a67d695e6c8f61098358a759cc49888">5055b54d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-30T13:43:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb: Additionally accept unicode as string param in Py2
With the changes to make samba python code Py2/Py3 compatible there
now are many instances where string content is decoded.
Decoded string variables in Py2 are returned as the unicode type. Many
Py2 c-module functions that take string arguments only check for the
string type. However now it's quite possibe the content formally passed
as a string argument is now passed as unicode after being decoded,
such arguments are rejected and code can fail subtly. This only affects
places where the type is directly checked e.g. via PyStr_Check etc.
arguments that are parsed by ParseTuple* functions generally already
accept both string and unicode (if 's', 'z', 's*' format specifiers
are used)
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c129351cc6b6ebfec78747d8ab0709e45c196bb">5c129351</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-30T13:43:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/librpc: Additionally accept unicode as string param in Py2
With the changes to make samba python code Py2/Py3 compatible there
now are many instances where string content is decoded.
Decoded string variables in Py2 are returned as the unicode type. Many
Py2 c-module functions that take string arguments only check for the
string type. However now it's quite possibe the content formally passed
as a string argument is now passed as unicode after being decoded,
such arguments are rejected and code can fail subtly. This only affects
places where the type is directly checked e.g. via PyStr_Check etc.
arguments that are parsed by ParseTuple* functions generally already
accept both string and unicode (if 's', 'z', 's*' format specifiers
are used)
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba5f00deb772b76719bfd06467a6b05edfeef061">ba5f00de</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-30T13:43:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/param: Additionally accept unicode as string param in Py2
With the changes to make samba python code Py2/Py3 compatible there
now are many instances where string content is decoded.
Decoded string variables in Py2 are returned as the unicode type. Many
Py2 c-module functions that take string arguments only check for the
string type. However now it's quite possibe the content formally passed
as a string argument is now passed as unicode after being decoded,
such arguments are rejected and code can fail subtly. This only affects
places where the type is directly checked e.g. via PyStr_Check etc.
arguments that are parsed by ParseTuple* functions generally already
accept both string and unicode (if 's', 'z', 's*' format specifiers
are used)
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d2ee36e350108a226a3d3dc641a067c9eed4897d">d2ee36e3</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-30T13:43:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: Add some compatability PY2/PY3 functions
I hope these changes are a short term interim solution for the
absence of the 'six' module/library. I also hope that soon this
module can be removed and be replaced by usage of six.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d331ddf47f7b0ee360a8c7a61e0b38d279ecbd48">d331ddf4</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-30T13:43:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add aliases for StringIO.StringIO
cStringIO doesn't handle unicode, StringIO does. With py2/py3
compatable code we can easily find ourselves getting passed
unicode so we don't alias cStringIO
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cbd6786c0471782024750b85b6f4fbf42977c81b">cbd6786c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-30T13:43:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: Add binary_type for p2/p3 testing.
For helping test for binary types, binary_type evaluates to 'str'
in py2, and 'bytes' in py3.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/13280d3db9fdbbd87c6ed2faa69b24bc7660674d">13280d3d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-30T13:43:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: bulk conversion of caller to dsdb_Dn 2nd param.
Convert second param to dsdb_Dn to be unicode so py2 & py3 code
will work
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b54472f868dc491579b471db6c6660bb03ab51c3">b54472f8</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-30T13:43:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Bulk conversion callers of ldb.Dn second param
Convert second param passed to ldb.Dn to be unicode so py2 & py3 code
will work
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/141d9081f4715b6c0ef439f34ca3b79fbddac1dd">141d9081</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-30T13:43:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: port some isinstance str checks (to cater for unicode)
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/26c1eca5d29dc3298366e06f0b27af47efff2e73">26c1eca5</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-04-30T16:25:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Really ignore nmbd start errors when there is no non-loopback interface (Closes: #893762)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/268ad19eee469ef7d703d5b9610683aca874fa9f">268ad19e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-04-30T16:25:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: Py2/Py3 compat change '/' to '//' to ensure int result
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Mon Apr 30 18:25:25 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aefe444d17a2eee3c0ff38bd34cf9e3f012ecf51">aefe444d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-04-30T19:48:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ceph: VFS: Add asynchronous fsync to ceph module, fake using synchronous call.
This will allow me to ultimately simplify the VFS by removing the synchronous
fsync VFS call.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13412
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Mon Apr 30 21:48:55 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/01c8dc7e15b8764a9b8c8e34b84d0cab790edf47">01c8dc7e</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-01T11:31:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-client: Remove ununsed functions from old client code
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13411
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/45202d86c54960d8d39493def19c01c79746ef20">45202d86</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-01T11:31:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-build: Drop unnessary dependency on ctdb-client
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e70fe41949fee46ee2907f0363697c60dfc113b7">e70fe419</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-01T11:31:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Move ctdb_client.c to server/ subdir
It is used only by the code in the server directory. It's mainly used
in recovery daemon and vacuuming child process.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b3dc0dca47a424e22c0bbd13346d14b7a9f21402">b3dc0dca</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-01T11:31:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-build: Rename ctdb-client2 subsystem to ctdb-client
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cdd51df35fcf606488764052a7b113dd802ff74b">cdd51df3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Move some ctdbd options out of the debug section
ctdbd -i might be useful with systemd or similar, so should be
documented.
--nosetsched and --script-log-level options are valid user-level
options.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f5ee088420e592cdc9de30d1b38188ff27796ae4">f5ee0884</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Move some configuration options out of the debug section
These aren't test options so improve their visibility.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/17ad7d9114bfc749350daa3988fe3223569ef945">17ad7d91</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Set ctdb->notification_script directly
This doesn't need a wrapper function. It gets in the way if building
a value involves allocating memory (e.g. talloc_asprintf()) and then
ctdb_set_notification_script() duplicates that memory.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7052f87903fc5daaad2e155f345800ee897d19b2">7052f879</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop unused function ctdb_set_notification_script()
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/518be6d5a26771040801f76db1279912128f3bc1">518be6d5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Use a local variable instead of repeating getenv()
Makes the error handling easier and the code more compact.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ed80fc13444b317a8e783d82cf49e03e680ec1e8">ed80fc13</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Provide a default location for the notification script
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7e9dd3fd3c30962c1e47fc5514cdd88c8cbc96b7">7e9dd3fd</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Ensure notify.sh is available to local daemons
Changes to notification configuration are coming, so ensure notify.sh
is always "installed" for local daemons.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e5af067866d503e1ea53472507290c905e71791f">e5af0678</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop CTDB_NOTIFY_SCRIPT configuration option
Notification scripts are installed into $CTDB_BASE/notify.d/ and are
always run by notify.sh. Leave notify.sh where it is for now but no
longer consider it a configuration file. This is an interim measure
and will be changed again soon.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0349d658547918f1fa33043849a0865e745c6e37">0349d658</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop ctdbd --notification-script command-line option
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3c7b766e5a2fc23149d7cb78ca1167e3ec1ca5a3">3c7b766e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Add testing environment variable CTDB_TEST_MODE
This is a generic indicator that tests are being run.
For local daemons, this will replace --sloppy-start and
--nopublicipcheck - it also does --nosetsched, which isn't being
removed at this point.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5081cec49e33031c117e8fa6c876e186fade0904">5081cec4</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Make local daemon tests depend on CTDB_TEST_MODE
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8c43ce74948e0b218e19f677670238490dd93d69">8c43ce74</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop ctdbd --sloppy-start and --nopublicipcheck options
CTDB_LOCAL_DAEMON_MODE=yes is used instead.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/32430f84159a02f3f6cadd325bcac92b44e0c8dc">32430f84</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop CTDB_VALGRIND testing option
This is too inflexible for general use. There is no use finding a new
home for this in the new configuration scheme.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8a835ae175ddfb5c6b2644d576199043a145dd3d">8a835ae1</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop ctdbd --torture and --valgrinding options
These haven't been used by anyone in a long time. --valgrinding is
less use with CTDB_VALGRINDING now gone.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f4fe768ca3518873b24e74ba4857c870fac1e46d">f4fe768c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Move remaining test options to README
Test options do not belong in the user documentation. Move them to
the README file in the tests/ subdirectory.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4eea531416ab0516f82bffa4f35345d8d0785d36">4eea5314</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Move ctdb_init() to the only place it is used
This used to be used by client code but not anymore, so move it to
where it is used. Drop the comment because it is wrong. Modernise
logging.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1b574876753a2a76acefeed0a0268dad2c9db293">1b574876</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop duplicate initialisation of request ID context
This doesn't require configuration options so keep the instance in
ctdb_init().
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9623c920ab142a3d6dafaaad4086edab9eae63f5">9623c920</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Consolidate basic CTDB context initialisation
None of this initialisation needs configuration options, so centralise
it with the context initialisation.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/79c49f60a98dfc390b7ef6a4195833237532507d">79c49f60</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Reorder main() to improve the structure
Move code into clearly defined sections. Add a fail label for fatal
errors to ensure memory is freed. Modernise debug messages.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8821857cdfa775eee27f9bb5c7ea270c334880f8">8821857c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop warning when there is no recovery lock
After configuration changes ctdbd_wrapper will no longer see the
CTDB_RECOVERY_LOCK option. The daemon already logs a warning if the
recovery lock is not set, so simply drop this extra warning.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a5ba6b9c939214f5f133a184817bd68f6b86279">9a5ba6b9</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Log the logging location when not logging via syslog()
A variant of this is currently done by the wrapper but will be removed
from there because the wrapper will no longer see the CTDB_LOGGING
option.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3459a152f75ad0fc594d34a0486f2e998aed8cac">3459a152</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop UDP/file logging warning from ctdbd_wrapper
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eba893f06c99c3585a5c4f8ada39000b7de31439">eba893f0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Fix location of persistent databases
Always use CTDB_DBDIR_PERSISTENT, which is setup by the test
infrastructure. The persistent database directory is
not (necessarily) relative to the volatile one.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/051203e1f80c1365e8f72fc3e819e6dda3aac4f2">051203e1</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Fix location of persistent databases
If CTDB_DBDIR_PERSISTENT is not set then set the default relative to
CTDB_VARDIR. The persistent database directory is not (necessarily)
relative to the volatile one.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8ea7fa57f4a82d7ebd6f8aa77fd8073b0196cb6e">8ea7fa57</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: CTDB_DBDIR_PERSISTENT should not depend on CTDB_DBDIR
Add new variable CTDB_DBDIR_BASE, just for event script unit tests.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eb7ec16a963e13e903171227b655dbbf7f2a4051">eb7ec16a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Change default volatile database directory
Volatile databases now have their own subdirectory. This makes things
easier if we later recommend mounting a tmpfs on the volatile database
directory, rather than supporting the current CTDB_DBDIR=tmpfs magic.
No need to create database directories for local daemon tests. ctdbd
will do that.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/043f3f266a988dadbf2992800c198af6c4bc0569">043f3f26</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T11:31:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop support for CTDB_DBDIR=tmpfs
CTDB has no business mounting filesystems. Instead, documentation
for the new configuration system will include a recommendation that a
tmpfs be mounted on the volatile database directory.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c6c67d9ed29d863d74ad98d1d344797ad2e1db54">c6c67d9e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-01T14:20:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Remove function rewrite_ctdb_options()
This is no longer necessary after the removal of support for
CTDB_DBDIR=tmpfs.
File-local variable ctdb_rundir is no longer used, so drop it.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Tue May 1 16:20:37 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/811596b1694df1956a8c7585dbc766a7de12b254">811596b1</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-01T18:26:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Ignore nmbd start errors when there is no local IPv4 non-loopback interface (Closes: #859526)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d7cf1917033bb2d40c75b290947fc1ad347e2a09">d7cf1917</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-01T18:46:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix possible-unindented-list-in-extended-description in samba-vfs-modules
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a0482b9d8daa4f8a1ff2e3011fa9a2fcc370c3a1">a0482b9d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-01T20:15:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Add a synchronous smb_vfs_fsync_sync() call, built from async primitives.
Will be used in the next commit.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cf4442090e979bca1fc93d00f51b5d4fc99e59e2">cf444209</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-01T20:15:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs: Use the new smb_vfs_fsync_sync() call in place of SMB_VFS_FSYNC().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bc71cd035c816de4ca98002860496bf8f5d50fe3">bc71cd03</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-01T23:06:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Remove fsync_fn() from the VFS and all modules. VFS ABI change.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed May 2 01:06:28 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b1ac0944146705ed13a89b0d0ac1b4656641c170">b1ac0944</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-02T12:18:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Do not fail in GUID index mode if there is a duplicate attribute
It is not the job of the index code to enforce this, but do give a
a warning given it has been detected.
However, now that we do allow it, we must never return the same
object twice to the caller, so filter for it in ltdb_index_filter().
The GUID list is sorted, which makes this cheap to handle, thankfully.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13335
(cherry picked from commit 5c1504b94d1417894176811f18c5d450de22cfd2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3f15f1c63b994066e4ea9bc5e407c1d182511918">3f15f1c6</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-02T12:18:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Add tests for truncated index keys
Tests for the index truncation code as well as the GUID index
format in general.
Covers truncation of both the DN and equality search keys.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Mar 3 09:58:40 CET 2018 on sn-devel-144
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13335
(cherry picked into 4.8 and cut down to operate without truncated
index values from master commit 4c0c888b571d4c21ab267024178353925a8c087c
by Andrew Bartlett)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f70fcd8baa82ae13ce1a29fc493643bbe29c6b7">7f70fcd8</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-02T12:18:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Ensure we can not commit an index that is corrupt due to partial re-index
The re-index traverse can abort part-way though and we need to ensure
that the transaction is never committed as that will leave an un-useable db.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13335
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
(cherry picked from commit e481e4f30f4dc540f6f129b4f2faea48ee195673)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/89ce0d90f70140b28a3cf6fa15e4fc6e803b5495">89ce0d90</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-02T12:18:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb tests: Prepare to run api and index test on tdb and lmdb
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13335
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 06d9566ef7005588de18c5a1d07a5b9cd179d17b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/21e10ff3d46814c170ed9b35e341f3c6a72406ef">21e10ff3</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-02T12:18:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Add test to show a reindex failure must not leave the DB corrupt
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13335
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Apr 5 07:53:10 CEST 2018 on sn-devel-144
(cherry picked from commit 653a0a1ba932fc0cc567253f3e153b2928505ba2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf0a6646108bd447c05f099a7f345cf2a3bda070">bf0a6646</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-02T12:18:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Release ldb 1.3.3
* Fix failure to upgrade to the GUID index DB format
* Add tests for GUID index behaviour
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13306
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/13f23ec11ef3c932b0cb2000613dfbc6dd14554b">13f23ec1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-05-02T16:56:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: fix memory leak in winbind_open_pipe_sock() when the privileged pipe is not accessable.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13400
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit ffe970007bf934955f72ec2d73bf8f94a2b796eb)
Autobuild-User(v4-8-test): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(v4-8-test): Wed May 2 18:56:45 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff3a23e90f85508de39610eb3503562b76c22773">ff3a23e9</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-02T17:33:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: default: Remove fallback if we don't have HAVE_PREAD set. Samba doesn't work without pread.
Start of the changes to remove synchronous VFS read.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c68cfbcee6a19a19401893706d72994725b05ef5">c68cfbce</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-02T17:33:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: default: Remove recursion into the VFS inside the default pread call.
We already know we're at the POSIX level here.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c78aa1f3a6eb9c08c2fdd10c304d6192cb1b6c2">0c78aa1f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-02T20:20:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Default. Move vfs_read_data() out of source3/smbd/vfs.c to the printing code, which is the only caller.
Make static.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed May 2 22:20:23 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/795ec751ac5f6e58966385bec25063c4af4f185d">795ec751</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-03T00:42:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmbclient: Fix hard-coded connection error return of ETIMEDOUT.
We shouldn't hard-code the connection error as ETIMEDOUT when
we have a perfectly good NT_STATUS to map from.
Found by the ChromeOS guys trying to connect an SMB2-only client
to an SMB1-only supporting server.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13419
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu May 3 02:42:20 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a82ca08f37658069aa547a98344b48aaf6b4a270">a82ca08f</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-05-03T03:25:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba_dnsupdate: Put samba.kcc import after path insert of bin/python
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1b3d3304e5a55dbc4353ddade82da43e079e33ed">1b3d3304</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-03T03:25:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python.gpo.ADS_STRUCT: check type of loadparm argument
And add a test showning the segfault.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2096d13274b679c282bdb85c63900eba0d76d1be">2096d132</a></strong>
<div>
<span>by Richard Sharpe</span>
<i>at 2018-05-03T06:16:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix some incorrect debug messages that look to be copy-paste issues.
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Thu May 3 08:16:26 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7e091e505156381e385235ab4518b4d133a98497">7e091e50</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-03T06:17:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-lsa: Fix use-after-free in LSA server
This is a regression introduced in ab7988aa2fd1a43f576a4b73a6893c61c7ef1957.
The state variable contains the data to be returned to the client
and packed into NDR after the function returned.
This memory needs to be kept (on mem_ctx as parent) until that is
pushed and freed by the caller.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13420
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/61244998048111e2100e7fb535b3c9338853cbed">61244998</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-03T06:17:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Allow make test to run with --address-sanitizer
Recent GCC versions enforce that the library must be in LD_PRELOAD if linked to a plugin
(like a python module).
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4365741fe59ac833fe04e4eaa591422fcb51504e">4365741f</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-03T06:17:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Extend build combinations tested to include --without-ldap
This bumps --without-ads to the samba-nt4 job so that option alone is still covered.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c9764342c2f67983a037714110913dafe0dba59e">c9764342</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-03T06:17:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci: split up gitlab-ci file
The "private" build environments are not available to most users so
remove this from the default build. Only developers with access
to private runners (rather than a shared runner) will have a runner
tagged as "private".
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d0d32fc04f723dccb298dfb3824c6241e3135a57">d0d32fc0</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-03T06:17:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci: Use YAML templates to reduce duplication
Inspired by WIP patches by Jamie McClymont
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6784283844dc231dad428d0c45088c1f7df404b3">67842838</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-03T06:17:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci: Run samba-ad-dc-2 in the shared environment
This will allow more AD DC tests to run for those without access
to a private gitlab runner.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e48bd332dc05d05a0b1e64106a9266d1c5a591f6">e48bd332</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-05-03T06:17:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb/tests: don't use TEVENT_DEPRECATED in ldb_kv_ops_test.c
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/705cf715f9015e879bb7fe712fffe3a69b805aad">705cf715</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-03T06:17:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Make sure max_key_length != 0 requires a GUID index mode
We need to enforce the GUID index mode so end-users do not get a supprise
in mid-operation and we enforce a max key length of 511 so that the
index key trunctation is done correctly.
Otherwise the DB will appear to work until a very long key (DN or index)
is used, after which it will be sad.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/39e5faa77c144b0c548d8afe749c1f08438b7e8f">39e5faa7</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-03T06:17:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: make key/value backends expose if there is an active transaction
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/501b35f86199216c78e38b4e0bc8e985e417f95d">501b35f8</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-03T06:17:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Do not make search or DB modifications without a lock
The ldb_cache startup code would previously not take a read lock
nor a sufficiently wide write transaction.
The new code takes a read lock, and if it needs to write takes a
write lock (transaction) and re-reads before continuing.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f04bbd3ec39b9d08df7b6b6596823461aa37fedf">f04bbd3e</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-03T06:17:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Disallow TDB nested transactions and use tdb_transaction_active()
This avoids keeping a counter, which can be error-prone.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/25e1cfad3afd936227d8240666c61b2b339a74ba">25e1cfad</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-03T06:17:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Disallow reads without a transaction or read lock
This will ensure we match LMDB behaviour and avoid a repeat of the per-record locking
issues (compared with full DB locking) we had before Samba 4.7.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9ca34b9c4aca9fa39759181f262ff693a9c6eb5c">9ca34b9c</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-03T06:17:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb tests: api ensure database correctly populated
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c8b45a3509197d929191fda60324f51b8496b724">c8b45a35</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-03T06:17:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb tests: add cmocka tests of kv operation interactions with transactions
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7e67df48bc30cf21bd29baeee26e4b8dd792e95d">7e67df48</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-03T06:17:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb:partition_metadata: make use of ldb_relative_path() in partition_metadata_open()
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6c8748c1605bc313f9f0c71f0667fec2bf5ac03d">6c8748c1</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-03T06:17:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb:schema_load: make use of ldb_relative_path() in partition_metadata_open()
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1bff2ae12880ea5a22ce53f7e2732af740c04ac3">1bff2ae1</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-03T06:17:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Introduce new generic ldb:// prefix to allow backend autodetection
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c25cec834c13bd1ebdfe7be29ac90e1f17683c4e">c25cec83</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-03T06:17:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb-samba: Handle generic ldb:// url scheme in ldb_relative_path()
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cfa1c0bcb6d1d2b83939aed8208dc03b626dc8a3">cfa1c0bc</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-05-03T06:17:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Replace some references to tdb with ldb://
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/910b7beeb47c08a844c207b396c3fd7db9662a8e">910b7bee</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-03T06:17:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/dlz_bind9: support for multiple db types by using ldb://
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8a0c7f39d67d8767d9f203dd5a1dd50b49f00a95">8a0c7f39</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-03T09:08:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Prepare to allow tests to operate on ldb_mdb (by using the GUID index)
The LMDB backend requires the GUID index mode, so prepare for it
by setting a unique objectGUID on each record. Also prepare for the
index list to be optionally set as an attribute on the test object,
allowing the GUID index mode to be set later when LMDB is configured.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu May 3 11:08:12 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ca387c221f97421604346c141a857aba729493e7">ca387c22</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-03T11:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samdb: fix wrong computer container dn for newcomputer
CN=Users --> CN=Computers
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Rowland Penny <rpenny@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/47713d648740cf2d11436ac6bd768c23cf89ca7f">47713d64</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-03T11:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_virusfilter_fsav: Initialize stack pointers per README.Coding
This allows a build with --address-sanitizer
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a753ccfd946aaad320977ae8c5f483f73077c3f8">a753ccfd</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-03T14:33:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbspool: Fix cmdline argument handling
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13417
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Thu May 3 16:33:54 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d3b9d11bade8bc52d08688ee66a4a20fe0a31a04">d3b9d11b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-03T22:11:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:cleanupd: use MSG_SMB_BRL_VALIDATE to signal cleanupd unclean process shutdown
Since 6423ca4bf293cac5e2f84b1a37bb29b06b5c05ed messaging_send_all()
broadcasts messages in a cluster, so cleanupd receives those broadcasts
and acts upon it by re-broadcasting the message. Result: message
storm.
By reactivating the currently unused MSG_SMB_BRL_VALIDATE for the
trigger message to cleanupd we avoid the storm.
Note that MSG_SMB_BRL_VALIDATE was unused only in the sense that noone
*listened* to it, but we were still *sending* the message in
smbd_parent_ctdb_reconfigured(). de6fe2a1dd6ab03b1c369b61da17fded72305b2d
removed listening for MSG_SMB_BRL_VALIDATE from cleanupd. This commits
brings it back.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13414
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53ff08a2cf838c0f1c3f050ac2aa13fc3acc5981">53ff08a2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-04T01:02:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:cleanupd: sends MSG_SMB_UNLOCK twice to interested peers
MSG_SMB_UNLOCK should be send to smbd that are waiting on blocked
byte-range-locks when a lock holder died.
In smbd_cleanupd_unlock() we do this twice: once via a broadcast and
then again via brl_revalidate() to processes that are actually recorded
in brlock.tdb.
As brl_revalidate() should already take care of signaling anyone who
would be interested in the message, there's no need to broadcast.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13416
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri May 4 03:02:28 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0b6186bfce3f0f251ea57c7a01d0bf608fdb1805">0b6186bf</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-05-04T04:12:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netlogon: Add a comment regarding one of the DC location calls
It appears to be basically deprecated, as it was superceded by other
calls. Presumably it is also unused.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13365
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3fcb7680571621f229f37dc7ff6ee4df29750b85">3fcb7680</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-05-04T04:12:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Allow the disable of the Windows server site fallback
A usage in GetDCNameEx2 could return the wrong result. This may need to
be fixed in other places.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13365
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/00cb8a3e12a5f6358b11d3f9c3080e7d62fc99d1">00cb8a3e</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-05-04T04:12:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netlogon: Allow return of error code in future asynchronous winbind forwards
We change the naming conventions to match dcesrv_netr_*_base_call used elsewhere.
This is important when we make the underlying Ex2 call asynchronous.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13365
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/972659eb29b7ae496cb2558dfc75ad7f4b9dc4ff">972659eb</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-05-04T04:12:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/getdcname: Add a number of tests for GetDCNameEx
This will test the winbind forwarding to deal with sites that the target
DC does not exist in.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13365
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d23177cea2a919ec37177954448d090e84a13fe">7d23177c</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-05-04T04:12:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd_irpc: Add an IRPC call to trigger a DC locate
Calling the top level winbindd API would probably be more appropriate,
but we lack certain structures. We introduce this call in order to
return the result to NETLOGON (in order to give site-aware and domain
aware DC location).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13365
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6d188fe05b7860e3abd7cfcc21ce1390bbfd8a71">6d188fe0</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-05-04T04:12:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netlogon: Forward GetDCNameEx2 to winbind via IRPC
Here we simply forward everything without alteration (the same struct is
returned). This helps us to fix the case where the DC does not exist in
the target site, furthermore, this is supposed to work for trusted
domains.
In calling out to winbind, we now also notice if you provide a site
which exists in multiple domains and provide the correct domain (instead
of accidentally returning ourselves).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13365
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b56b522d49f3e20dc2ea3819a82f742e614ea9c">7b56b522</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-05-04T04:12:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netlogon: Store the client site to clobber any plausibly returned via winbind
So far, I have never observed the case where the winbind call ever
bothered to return a proper site, but in case it ever does so, we
clobber it here. This has implications for returning a non-local domain
site name, but for now, we ignore them.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13365
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d1730d6ff19b60ebf9f6b18aaa4afab733b18b25">d1730d6f</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-05-04T07:11:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netlogon: Allow zero-GUID to act the same as NULL in GetDCNameEx2
This matches Windows behaviour and allows rpcclient to work against
Samba without knowing the GUID ahead of time. Errors related to this
don't appear to occur within selftest.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13365
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Fri May 4 09:11:19 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/631bca9e92e9aa7380140ff9e603d40fda9e3e66">631bca9e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: printing: Reformatting of parts of this file to modern coding standards.
This should not change the code behavior in any way, it is just being
done to make it easier for me to move this code to calling the
standard read_file() function later on, which takes a file offset
to read from (and uses pread internally).
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a42a24b27d8691be894c39df4f9fdb83aefa754">6a42a24b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: printing: Split handling of PE file into separate function.
This is *horrible* old code...
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/43d9168569fa432982b344a2c4866b4ca0dc942a">43d91685</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: printing: Move handle_ne_file code into a separate function.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e943c5db1f2177acadd1c5d7e24fa37482264baa">e943c5db</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: printing: Rename vfs_read_data() -> printing_read_data().
This is an internal printing call, nothing to do with the VFS.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b927b53ad221d258ddddde4561752271923edf63">b927b53a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: printing: Rename printing_read_data() -> printing_pread_data() and add an offset parameter.
Currently pass -1 as the offset, so it's not used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4b580ee94e8b40ed260d215766d8692ceb2cda13">4b580ee9</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: printing: Make printing_pread_data() update the offset paramter, if not passed in as -1.
As all callers pass -1 here, still not used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/09aaed21091144c48586fdc97233166b2402f6b4">09aaed21</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: printing: Use auto-updating of offset in printing_pread_data() to remove offset tracking in get_file_version().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c736ae06821b46ca4c541982de3cf8af48c50ba">0c736ae0</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: printing: Add existing offset position as a parameter to handle_pe_file(), handle_ne_file()
Not yet used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a87328edee55c4e71b468da8642689bb24b6bb1d">a87328ed</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: printing: Use passed in offset, and offset tracking in printing_pread_data() to remove seeks from handle_pe_file().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9bf5d0da9516635eef5af246a3c7b5f3b0648f74">9bf5d0da</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: printing: Use offset tracking in printing_pread_data() to remove the seek in handle_ne_file().
Uses the fact that: lseek(fd, 0, SEEK_CUR) is merely getting the current file position,
which we have already tracked in in_pos.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70eb53366995e842f0f29733979a13b6738ffb1a">70eb5336</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: printing: Now we never pass an offset of -1, remove the off_t==-1 protections from printing_pread_data().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2bea1103e5d322515eac7ddae5e1444ceb5e7b97">2bea1103</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: printing: Remove the LSEEK in printing_pread_data() and use read_file() instead.
Removes last-but-one user of SMB_VFS_READ.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/75fde601be6058b98cac214e3f97e82cfcd2f4fe">75fde601</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Make cmd_read use read_file().
Removed last user of SMB_VFS_READ.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c1bcf1e7fd93a1dbedb210e624f99773a6f3d6f9">c1bcf1e7</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Remove SMB_VFS_READ() function and all implementations.
All code in Samba now uses SMB_VFS_PREAD or SMB_VFS_PREAD_SEND.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/90bd74640f0a79c1d1c2c0a5fee92e62700232e9">90bd7464</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: default: Remove fallback if we don't have HAVE_PWRITE set. Samba doesn't work without pwrite.
Start of the changes to remove synchronous VFS write.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/23f4b3f0ed1b5883b50b390292e06587c2a6e27b">23f4b3f0</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: default: Remove recursion into the VFS inside the default pwrite call.
We already know we're at the POSIX level here.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/394ac908c19bd54e6869865ddff44e2382aedb48">394ac908</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove the handling of offset == -1 in real_write_file().
All SMB1/2/3 offsets over the wire are absolute.
The only caller with offset == -1 is on a print-spool file
in reply_printwrite(), and write_file() redirects this
to print_spool_write(), which correctly handles the -1.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/25bad32993150a49a767aca87c7d234314ba7210">25bad329</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Remove vfs_write_data(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/532ff3a5b9580f75ee770fc7da7ba7fc43b5a91f">532ff3a5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: ceph: Replace the lseek/write ftruncate extend with pwrite.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/98f03064f75466929295b8854182977c7162e360">98f03064</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T20:34:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Remove the last user of SMB_VFS_WRITE.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/30e6b5999bf0be297de74dc991beeccfe4af6088">30e6b599</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T23:38:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Remove SMB_VFS_WRITE() function and all implementations.
All code in Samba now uses SMB_VFS_PWRITE or SMB_VFS_PWRITE_SEND.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Sat May 5 01:38:07 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/abb80ce44c41759306be3ff1cca6bea532bdf45f">abb80ce4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-04T23:39:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: client: Add btime_ts to struct finfo.
Fill it in when available, else return it as zero.
Based on a patch from Puran Chand <pchand@vmware.com>.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf13fe0f2226844123cfb090e0ab82c8ce24e09b">bf13fe0f</a></strong>
<div>
<span>by Puran Chand</span>
<i>at 2018-05-04T23:39:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmbclient: Add internal/external structures needed for readdirplus.
Not yet used.
Signed-off-by: Puran Chand <pchand@vmware.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3fc5a79750c443087ac0968085fadba74cce555d">3fc5a797</a></strong>
<div>
<span>by Puran Chand</span>
<i>at 2018-05-04T23:39:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmbclient: Add readdirplus cleanup code on directory close.
Signed-off-by: Puran Chand <pchand@vmware.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd3f019d588ee71a06985da2c1abe84391d95b0e">dd3f019d</a></strong>
<div>
<span>by Puran Chand</span>
<i>at 2018-05-04T23:39:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmbclient: Add function add_dirplus() to fill the list from a returned file info.
Not yet externally visible.
Signed-off-by: Puran Chand <pchand@vmware.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2166c2d3ee84ea2fde840c261d6401abc58650b5">2166c2d3</a></strong>
<div>
<span>by Puran Chand</span>
<i>at 2018-05-04T23:39:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmbclient: Add new function SMBC_readdirplus_ctx().
New ABI function, move to library version 0.33.
Signed-off-by: Puran Chand <pchand@vmware.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/54f29891090edb0a26120d8ad6ed0485c31516ab">54f29891</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-05T02:31:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: libsmbclient: Add a readdirplus() test suite.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat May 5 04:31:18 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a66f941619ecf4f2cae8680143e990307f42e264">a66f9416</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-05T02:32:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/pycredentials: correct spelling of reponse
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f94c9a135785414d6fed8785369c0c16e1fcb9b9">f94c9a13</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-05T02:32:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/ntlmssp_client: correct spelling of response
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4eeb43d06c7bfe1e3661c954586eed0b88315ee8">4eeb43d0</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-05T02:32:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: add compiler version to results tarball
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b7494f5e7f72a29350d5fbbf2dbae866ded9b63">6b7494f5</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-05T02:32:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">perftest: ad_dc_medley failing base search failed to catch exception
This meant it only happened once.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e6669d126472091fb0b012fe2371557aa5bc4c6c">e6669d12</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-05T02:32:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitignore .gdb_history anywhere in the tree
For when you run gdb in places like lib/ldb/ and it decides to leave
behind a history file.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ac053b1493157c752d7c7c802e95b5222d61b71c">ac053b14</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-05T02:32:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">.gitignore .agignore
.agingore is used by "the silver searcher", ag, which is a form of
grep with more useful defaults and prettier colours for searching
source trees.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2c6cac990e64983c7fdb5beb3316ef956fa0b0bc">2c6cac99</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-05T02:32:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">sambatool tests: make assertMatch use assertIn
With a note to tidy this up at some point
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/406284be95d38d9fbdfb970fbe6cb17f25c63bf6">406284be</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-05T02:32:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba_kcc: remove an unused variable
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cb40e2bbc8a34a1ec3584ab585c5bf44c037ef0e">cb40e2bb</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-05T02:32:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: do not try to send email to no recipient
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2073635d5818aa3fc844ee40dde0c8ae42ac5abd">2073635d</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-05T05:25:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: ensure we are using the same division in py 2 and 3
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Sat May 5 07:25:13 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ace735eb2b23896ad43bbf570be818a8ad533b58">ace735eb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-07T07:56:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs: vfs_streams_xattr: Don't blindly re-use the base file mode bits.
When returning the stat struct for an xattr stream,
we originally base the st_ex_mode field on the value
from the base file containing the xattr. If the base
file is a directory, it will have S_IFDIR set in st_ex_mode,
but streams can never be directories, they must be reported
as regular files.
The original code OR'ed in S_IFREG, but neglected to
AND out S_IFDIR.
Note this is not a complete to fix bug 13380 as
it doesn't fix the generic case with all streams
modules. See later fix and regression test.
Found in real-world use case by Andrew Walker <awalker@ixsystems.com>.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13380
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
(cherry picked from commit 4d839d0f46b723ed6809bb932b9ebe4ead2cec82)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3d4a8f2c5f1f89415ae52539f3c99e6b0b52f020">3d4a8f2c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-07T07:56:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd. Generic fix for incorrect reporting of stream dos attributes on a directory
According to MS-FSA a stream name does not have
separate DOS attribute metadata, so we must return
the DOS attribute from the base filename. With one caveat,
a non-default stream name can never be a directory.
As this is common to all streams data stores, we handle
it here instead of inside all stream VFS modules.
Otherwise identical logic would have to be added to
all streams modules in their [f]get_dos_attribute_fn()
VFS calls.
Found in real-world use case by Andrew Walker <awalker@ixsystems.com>.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13380
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
(cherry picked from commit 118e77d86a7171f589f805fa4f63246b0cb63672)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/81e7736c745dcceb8c1ad3859e33fa8c8de6d47e">81e7736c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-07T07:56:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: tests: Regression test to ensure we can never return a DIRECTORY attribute on a stream.
Tests streams_xattr and also streams_depot.
Inspired from a real-world test case by Andrew Walker <awalker@ixsystems.com>.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13380
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Apr 12 02:04:28 CEST 2018 on sn-devel-144
(cherry picked from commit 82beaf868f252c4bc975ddafd80240af6f679b83)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/24a933e7bda083e0be16f1092c1c103eceb99608">24a933e7</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2018-05-07T07:56:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">printing: return the same error code as windows does on upload failures
Some print drivers inf files are broken and cause driver installation to fail
on Samba servers. Windows returns WERR_APP_INIT_FAILURE in that case, we should
do the same. Windows machines are less unlucky with that.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13395
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Wed Apr 25 13:55:25 CEST 2018 on sn-devel-144
(cherry picked from commit 35f2afe411a3b22fb1befadb3bee8da1bc14753c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b7b08709434f8bedf7158e90724f45fbf9a15985">b7b08709</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-05-07T07:56:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpcclient: Print number of entries for NetSessEnum
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13407
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 501819fa9e7926c2f54cb92d508ac0e8437fd476)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2fcd26a31b0f0fd3778cadc31b497f3c4e132bbd">2fcd26a3</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-05-07T07:56:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add testcase for querying sessions after smbd crash
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13407
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit e04846c7df8e3eec1f3dbb2fc5eaf47ceb1c44d2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7cfaf7000180c9308b18b1944dd41971f805bff1">7cfaf700</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-05-07T07:56:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpc_server: Fix NetSessEnum with stale sessions
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13407
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Apr 25 22:49:07 CEST 2018 on sn-devel-144
(cherry picked from commit a6fade4e10760284ef56abf45d3fa70038091cbe)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bde663377381fed40bbba5f3e510987d16fa23cf">bde66337</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-07T07:56:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-client: Remove ununsed functions from old client code
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13411
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 01c8dc7e15b8764a9b8c8e34b84d0cab790edf47)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0ccfe32047e0214a262b9392ece677ac0bc085e1">0ccfe320</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-07T07:56:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ceph: VFS: Add asynchronous fsync to ceph module, fake using synchronous call.
This will allow me to ultimately simplify the VFS by removing the synchronous
fsync VFS call.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13412
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Mon Apr 30 21:48:55 CEST 2018 on sn-devel-144
(cherry picked from commit aefe444d17a2eee3c0ff38bd34cf9e3f012ecf51)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dc7b7beeee61beab3d23a7678090208f7d345901">dc7b7bee</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-07T07:56:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:cleanupd: use MSG_SMB_BRL_VALIDATE to signal cleanupd unclean process shutdown
Since 6423ca4bf293cac5e2f84b1a37bb29b06b5c05ed messaging_send_all()
broadcasts messages in a cluster, so cleanupd receives those broadcasts
and acts upon it by re-broadcasting the message. Result: message
storm.
By reactivating the currently unused MSG_SMB_BRL_VALIDATE for the
trigger message to cleanupd we avoid the storm.
Note that MSG_SMB_BRL_VALIDATE was unused only in the sense that noone
*listened* to it, but we were still *sending* the message in
smbd_parent_ctdb_reconfigured(). de6fe2a1dd6ab03b1c369b61da17fded72305b2d
removed listening for MSG_SMB_BRL_VALIDATE from cleanupd. This commits
brings it back.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13414
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit d3b9d11bade8bc52d08688ee66a4a20fe0a31a04)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/02b898e44d3b71670473cd7698b27d7448d0a96e">02b898e4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-07T12:25:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmbclient: Fix hard-coded connection error return of ETIMEDOUT.
We shouldn't hard-code the connection error as ETIMEDOUT when
we have a perfectly good NT_STATUS to map from.
Found by the ChromeOS guys trying to connect an SMB2-only client
to an SMB1-only supporting server.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13419
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu May 3 02:42:20 CEST 2018 on sn-devel-144
(cherry picked from commit 795ec751ac5f6e58966385bec25063c4af4f185d)
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Mon May 7 14:25:28 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/df16777ce4e3d2221b9215c523aa7d63e516db5f">df16777c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-08T08:03:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Fix CID 1435453 Null pointer dereferences
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2073fd0956a1c26220ae05d87e965095b9ce1b2f">2073fd09</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-08T10:55:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Update popt to 1.16 release
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue May 8 12:55:04 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/233d22138bbddc3374b9b2e6b6806c2ee0c51965">233d2213</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-08T21:48:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Rowland Penny <rpenny@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue May 8 23:48:07 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e78aeedb8329953df83fc7f2c191b2c97a051d0">4e78aeed</a></strong>
<div>
<span>by Vandana Rungta</span>
<i>at 2018-05-09T02:28:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Fix memory leak in vfs_ceph.
Centralize error handling.
https://bugzilla.samba.org/show_bug.cgi?id=13424
Signed-off-by: Vandana Rungta <vrungta@amazon.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed May 9 04:28:11 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1174b52b91de045b5c111dff97c49488ac963bfa">1174b52b</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-09T02:29:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Prevent ldb_tdb reuse after a fork()
We may relax this restriction in the future, but for now do not assume
that the caller has done a tdb_reopen_all() at the right time.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/daf79e5b35b354200b26b2b0fac3487287ffa720">daf79e5b</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-09T02:29:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb/tests: add tests for transaction_{start,commit}/lock_read across forks
(Split from a larger commit by Andrew Bartlett)
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3b069156639e4d53f8bd392fe6a21c36ff0caa99">3b069156</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-09T02:29:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Reset errno before checking it in ltdb_connect()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/21366649410c29904a463b57e7d8688ce6e11381">21366649</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-09T02:29:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Allow use of a TDB for ldb_tdb after as fork()
Otherwise we rely on the caller doing tdb_reopen_all() which should
not be their job.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f891b8dc32d24eea81ee5fe6ace02c1cf7129443">f891b8dc</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-09T02:29:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Add tests for ldb_tdb use after a fork()
We need to show that despite the internal cache of TDB pointers that it
is safe to open a ldb_tdb after a fork()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba33d90ed67b787a11b26bc69f9553d0d52dfe45">ba33d90e</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-09T05:27:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Ensure we can open a new LDB after a fork()
Based on work for an mdb-specific test by Gary Lockyer
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed May 9 07:27:24 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a9c164d0abfa30db3f943d1224ca95d87fdf95a">4a9c164d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-09T07:48:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbspool: Improve URI handling code
This also checks that the URI given via the environment variables
starts with smb://
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
(cherry picked from commit a6eac8f64989235e7a297c14e349d98a3fc70e47)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4b793d97642c9831e7f80dfed1d4ec8169a184ff">4b793d97</a></strong>
<div>
<span>by Simo Sorce</span>
<i>at 2018-05-09T08:38:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix Jean François name to be UTF-8
Signed-off-by: Simo Sorce <idra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed May 9 10:38:57 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bb5cee36b67ca78d29474f6f33fab9372203b925">bb5cee36</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-09T12:22:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbspool: Fix cmdline argument handling
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13417
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit a753ccfd946aaad320977ae8c5f483f73077c3f8)
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Wed May 9 14:22:22 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bc2beedfa2fbb473ad9b5c292f7b28f4cfe72a54">bc2beedf</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-09T17:18:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: remove unused se_create_child_secdesc_buf()
Commit e2c9ad93cb914186b89e2055f1bed3cceee1f768 removed the last caller
of this.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed May 9 19:18:44 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f0e6453b0420fe9d062936d4ddc05f44b40cf2ba">f0e6453b</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-05-09T17:30:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_ceph: add fake async pwrite/pread send/recv hooks
As found by Jeremy, VFS modules that don't provide pread_send() or
pwrite_send() hooks result in vfs_default fallback, which is
catastrophic for VFS modules with non-mounted filesystems such as
vfs_ceph.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13425
Reported-by: Jeremy Allison <jra@samba.org>
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/52dc959bb21a102a14437812418bbb75b0bb231f">52dc959b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-09T20:24:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove unused counters for outstanding aio calls.
Only a debug message used this.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed May 9 22:24:38 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/79ba530aaf76be639143530ab6e28d1e3696dfd2">79ba530a</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-10T18:02:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: refactor password attibutes to constant
The password attributes are defined as literal in two places in the
password_hash code. They will also be needed to support password change
logging. This patch replaces the individual definitions with a shared
constant.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1488723a119736ed6401476ebe58afe5ba9953d4">1488723a</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-10T18:02:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Add unique session GUID identifier
Generate a GUID for each successful authorization, this will allow the
tying of events in the logs back to a specific session.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/52a3318be8316a8956d7bb6f62d64e32fed6f952">52a3318b</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-10T18:02:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth log: Log the unique session GUID
Log the unique_session_token GUID on successful Authorizations.
This patch adds the "sessionID" attribute to the Authorization object
and increments the version to 1.1
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fdf827553a003ad02b977c67c46f251e1062d604">fdf82755</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-10T18:02:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth logging tests: Add tests for sessionId
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8cf4e546960ab1493b0e39f0cef822a66d30bf56">8cf4e546</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-10T18:02:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth logging tests: Clean up flake8 warnings
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/daa7b60a60520c94367e9112246482bae71c5ccd">daa7b60a</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-10T18:02:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: pass the remote address to samdb connect
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c0345ea9bb34695dcd7be6c913748323bebe937">5c0345ea</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-10T18:02:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samdb: Add remote address to connect
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/01fab30a9779c7f2bfd3016c9c482d956cde5198">01fab30a</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-10T18:02:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samdb: Add transaction id control
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b07b4e459e95f2609af651e579d3b0b01b8a4c7e">b07b4e45</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-05-10T20:47:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">loadparm: Remove unused realm_original
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu May 10 22:47:15 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/597428943b1b77267243dc69ecea6fda8dfc3163">59742894</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-11T04:01:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Move repeated code into a helper function
Several tests hang all the objects they create off a unique OU.
Having a common OU makes cleanup easier, and having a unique OU (i.e.
adding some randomness) helps protect against one-off test failures
(Replication between testenvs is happening in the background.
Occasionally, when a test finishes on one testenv and moves onto the
next testenv, that testenv may have received the replicated test
objects from the first testenv, but has not received their deletion
yet).
Rather than copy-n-pasting this code yet again, split it out into a
helper function.
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d0a9e19114cfdaa9cd083e46d51f9e5de9e907e5">d0a9e191</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-11T04:01:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Split out setUp code into separate function for reuse
Any test that wants to change a password has to set the dSHeuristics
and minPwdAge first in order for the password change to work. The code
that does this is duplicated in several tests. This patch splits it out
into a static method so that the code can be reused rather than
duplicated.
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78ebfcfa862ba05d18305be07192837681c841cb">78ebfcfa</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-11T04:01:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add tests for Password Settings Objects
a.k.a Fine-Grained Password Policies
These tests currently all run and pass gainst Windows, but fail against
Samba. (Actually, the permissions test case passes against Samba,
presumably because it's enforced by the Schema permissions).
Two helper classes have been added:
- PasswordSettings: creates a PSO object and tracks its values.
- TestUser: creates a user and tracks its password history
This allows other existing tests (e.g. password_lockout, password_hash)
to easily be extended to also cover PSOs.
Most test cases use assert_PSO_applied(), which asserts:
- the correct msDS-ResultantPSO attribute is returned
- the PSO's min-password-length, complexity, and password-history
settings are correctly enforced (this has been temporarily been hobbled
until the basic constructed-attribute support is working).
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f5d67c10c02b9f5023cb58914cbb1af193846178">f5d67c10</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-11T04:01:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add comments to help explain password_lockout tests
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f94f472830d684683f2769d83ad1205720a3029d">f94f4728</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-11T04:01:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add PSO test case to existing password_lockout tests
This checks that the lockout settings of the PSO take effect when one is
applied to a user. Import the password_settings code to create/apply a
PSO with the same lockout settings that the test cases normally use.
Then update the global settings so that the default lockout settings are
wildly different (i.e. so the test fails if the default lockout settings
get used instead of the PSO's).
As the password-lockout tests are quite slow, I've selected test cases
that should provide sufficient PSO coverage (rather than repeat every
single password-lockout test case in its entirety).
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/17d8d475e5376a3c1a313c99cd988b0d1180c5e2">17d8d475</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-11T04:01:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add test for password-lockout via SAMR RPC
The existing password_lockout tests didn't check for changing the
password via the SAMR password_change RPC. This patch adds a test-case
for this, using the default domain lockout settings (which passes), and
then repeats the same test using a PSO (which fails).
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/823dec9d166b3fbe2caacdb699173601603c1101">823dec9d</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-11T04:01:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add a test case for msDS-PasswordReversibleEncryptionEnabled
Add a test for the 'msDS-PasswordReversibleEncryptionEnabled' attribute
on the PSO. The Effective-PasswordReversibleEncryptionEnabled is
based on the PSO setting (if one applies) or else the
DOMAIN_PASSWORD_STORE_CLEARTEXT bit for the domain's pwdProperties.
This indicates whether the user's cleartext password is to be stored
in the supplementalCredentials attribute (as 'Primary:CLEARTEXT').
The password_hash tests already text the cleartext behaviour, so I've
added an additional test case for PSOs. Note that supplementary-
credential information is not returned over LDAP (the password_hash
test uses a local LDB connection), so it made more sense to extend
the password_hash tests than to check this behaviour as part of the
PSO tests (i.e. rather than in password_settings.py).
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fcdb935e3749cab5bc7dcbb83414032c683640ef">fcdb935e</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-11T04:01:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Use attribute-name parameter for error message
We'll reuse this code for working out the msDS-ResultantPSO, so
references to 'tokenGroups' in error messages would be misleading.
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8a105af76c3d432505e0a503cd32feb3808df59a">8a105af7</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-11T04:01:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Split out construct_generic_token_groups() so we can reuse it
construct_generic_token_groups() currently works out the entire group
membership for a user, including the primaryGroupID. We want to do the
exact same thing for the msDS-ResultantPSO constructed attribute.
However, construct_generic_token_groups() currently adds the resulting
SIDs to the LDB search result, which we don't want to do for
msDS-ResultantPSO.
This patch splits the bulk of the group SID calculation work out into
a separate function that we can reuse for msDS-ResultantPSO. basically
this is just a straight move of the existing code. The only real change
is the TALLOC_CTX is renamed (tmp_ctx --> mem_ctx) and now passed into
the new function (so freeing it if an error conditions is hit is now
done in the caller).
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0da9dbbf5a762f0953f1860b8b04810d33557094">0da9dbbf</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-11T04:01:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Small tweak to retrieving pwdProperties
Currently the 'samba-tool domain passwordsettings' command shares a
'set' and 'show' option, but there is very little common code between
the two. The only variable that's shared is pwd_props, but there's a
separate API we can use to get this. This allows us to split the command
into a super-command in a subsequent patch.
Fixed up erroneous comments while I'm at it.
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7255e0ced33826d1e528c3e465105e7e194eb36e">7255e0ce</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-11T04:01:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Split 'domain passwordsettings' into a super-command
The show and set options are not really related to each other at all, so
it makes sense to split the code into 2 separate commands.
We also want to add separate sub-commands for PSOs in a subsequent
patch.
Because of the way the sub-command was implemented previously, it meant
that you could specify other command-line options before the 'set' or
'show' keyword, and the command would still be accepted. However, now
that it's a super-command 'set'/'show' needs to be specified before any
additional arguments, so we need to update the test code to reflect
this.
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/569937b8008ea8b64b4e3ead61ebc97c6c41f6b6">569937b8</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-11T07:06:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add tests for samba-tool passwordsettings commands
I've added a test case for 'samba-tool domain passwordsettings set/show'
to prove I haven't broken it. It's behaviour shouldn't have changed, but
there was no test for it previously.
We'll extend these tests in the very near future, when we add samba-tool
support for managing PSOs.
The base samba_tool test's runsubcmd() only handled commands with
exactly one sub-command, i.e. it would handle the command 'samba-tool
domain passwordsettings' OK, but not 'samba-tool domain passwordsettings
set' (The command still seemed to run OK, but you wouldn't get the
output/err back correctly). A new runsublevelcmd() function now handles
a varying number of sub-commands.
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Fri May 11 09:06:10 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9bc2b922bbc6539341a2056f33f117ac350e61f1">9bc2b922</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-11T07:07:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Make sure we have correct group mappings
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13369
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0d2f743d826b87b369e25fc6bb9ff61f2b0896aa">0d2f743d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-11T07:07:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Add a test looking up the user using the upn
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13369
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0aceca6a94e868f9c01a66f79624ca10d80560ab">0aceca6a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-11T07:07:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Add a test looking up domain sid
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13369
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4fa811ec7bc301e96f5e40ba281e8d4e8709b94f">4fa811ec</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-11T07:07:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Lookup the domain in tests with the wb seperator
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5319cae00096dcecc29aa9fa675a983352ad64d8">5319cae0</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-11T07:07:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add a user with a different userPrincipalName
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13369
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2715f52f54e66a73131a92d752a8c2447da1fd33">2715f52f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-11T07:07:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch:tests: Add test for wbinfo --user-info
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13369
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/789c89e6ecb7d388fb5acdd5abc8fe99c58524f0">789c89e6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-05-11T07:07:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Pass upn unmodified to lookup names
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13369
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/32770e929ace8fe3f2469037ed887be14b3c5503">32770e92</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-11T07:07:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Remove unused function parse_domain_user_talloc()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a05b63db627fdbe0bdea4d144dfaeedb39025592">a05b63db</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-11T07:07:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Fix UPN handling in parse_domain_user()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13369
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1766f77493c5a76e4d7d1e5eedcaa150cc9ea552">1766f774</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-11T10:02:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Fix UPN handling in canonicalize_username()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13369
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri May 11 12:02:37 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e8a04f72a5a123d8837a945b464d2081238c8473">e8a04f72</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-11T18:33:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">printing: Fix CID 1435452 (TAINTED_SCALAR)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/12f6d56c4814fca64e0e3c636018e70d71ad0be5">12f6d56c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-11T18:33:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/smb2: new test for interaction between chown and SD flags
This passes against Windows, but fails against Samba.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13432
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ced55850034a3653525823bf9623912a4fcf18a0">ced55850</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-11T21:30:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: fix interaction between chown and SD flags
A change ownership operation that doesn't set the NT ACLs must not touch
the SD flags (type).
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13432
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri May 11 23:30:32 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ca89d84a7fb281e5d7301cc44a55c0acec5be04">5ca89d84</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix typo for response
reponse --> response
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fe53f0b3d699606f9f72791df40ead997e60af1c">fe53f0b3</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/allows to/allows one to/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b2a1dea09954b4ec12ceb76e25f789dfcf107667">b2a1dea0</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/anwser/answer/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8fc64d4569bf349757e1b09df92ec1d3fce2213a">8fc64d45</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/authenticaiton/authentication/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f74090c817085317ec299f94a8dba61d8d47bf7d">f74090c8</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/conection/connection/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/685f45280af8695c21800ad41230d05fd56c33ad">685f4528</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/coult/could/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3a7b12950ffa066d942a50142bb2cd69da28ecf6">3a7b1295</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/desriptor/descriptor/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2bde81db39181ae190141ec26abdca29f4863fc6">2bde81db</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/doens't/doesn't/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e4764240bff063e1e9680117de66fd0519d916e">4e476424</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/Everytime/Every time/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f5b908d8186b18bb3ec86b4b0db488bf7c6af643">f5b908d8</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/formated/formatted/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fd46fd0941d8ad7a41c7e6823fcce08a331c6e6a">fd46fd09</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/fowarding/forwarding/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2bacc1ca42e23be60fd48c4a0ecabf6957dc106e">2bacc1ca</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/malicous/malicious/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fab4fe9cb4409ba8d5d41bf93ddc3ffe167f09c9">fab4fe9c</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/missmatch/mismatch/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1af896869007deb65d8228d492706185bd99ef65">1af89686</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/openened/opened/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ad87bb43c72520bcf1dcf603b55f6fd0d95697c">7ad87bb4</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/opions/options/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e8a3a43649ea7235aa54be29018ec92f8de628ea">e8a3a436</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/ouput/output/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6fa770fd546c87e588d75cc143be2b20f59f5602">6fa770fd</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/processs/process/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8ed2873400ffa10ed1abd745faa54a0fa8029a40">8ed28734</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/propogate/propagate/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/43ec8c6bbdf95251908e6ba8e00092b04cb56ea3">43ec8c6b</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/protcol/protocol/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/25ac1f192cd7361c7a7b068a8e86a5365c2a5256">25ac1f19</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/receving/receiving/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/44ae08858e6e859f968456576a2b066f05382fcb">44ae0885</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/retrive/retrieve/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8f7749cda72fd3d4a532fdd8f2c9ba99f48ca738">8f7749cd</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/retun/return/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c55248bbbcd0c1f9fbdeccf508900fc0d1dc9ce9">c55248bb</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/specfied/specified/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/66a9b5345799846641069286b3db75feec1542b0">66a9b534</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/succesfully/successfully/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5a0fd87b6bc04e4726d5cfea22c11d38386097b8">5a0fd87b</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/unitialized/uninitialized/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/15d2f4f8178e9cd10deaace19268b0659806340a">15d2f4f8</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/unsuported/unsupported/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d4bbff5ce5705f877be326f32631b466daec5aed">d4bbff5c</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix pidl manpage sections
.TH header should match file name (i.e 3pm and not 3 for Parse::Pidl::NDR).
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/674fd1c2834567d473a0b8483eb20e66a27882c0">674fd1c2</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-12T00:09:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Improve vfs_linux_xfs_sgid manpage
- Add missing refpurpose and describe the "circumstances"
- Replace dangling link by archive.org backup
- Add fixed Linux version and commit link
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a6d14248d6a4f4ebc92e3ff6529fe9f82fb8388">6a6d1424</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">cmd_drsuapi: add dswriteaccountspn command
The dswriteaccountspn command is missing in drsuapi, add it so we can
use it in rpcclient.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/656ec98e5b248f9107af5713495e4aeca17e3155">656ec98e</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pycredentials: add py_creds_get_secure_channel_type
We have only set, need get.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a4261c0527b803173a151bff3b35dbc687db707">2a4261c0</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-12T00:09:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add a test for creds.{get,set}_secure_channel_type()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4d950527f3e68cff7fa7281f3266be0d81cc9bde">4d950527</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: add paged_results control for ldb search
While there are more then 1000 records in the search result from Windows,
a `LDAP_SIZE_LIMIT_EXCEEDED` error will be returned.
Add paged_results control to fix.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ed1682905849f8b1971eac79fa7718aa0f07744">5ed16829</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: set gensec features to encrypt credentials
While running traffic_replay script against windows dc, it will fail
with a `LDAP_UNWILLING_TO_PERFORM` error for adding user.
Windows requires the credentials to be encrypted before sending.
`set_gensec_features` will fix it.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e37336632bd6a26bd960d5ee2e80fa1a22e8440">4e373366</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: fix typo in message string
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8d8ef48650ca5ec49f080be7f1fd813617aa6d31">8d8ef486</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_packets: support NT_STATUS_NO_SUCH_DOMAIN in packet_lsarpc_39
For packet_lsarpc_39, samba will return NT_STATUS_OBJECT_NAME_NOT_FOUND,
however, windows will return NT_STATUS_NO_SUCH_DOMAIN.
Allow both status for now to keep compatiable with both samba and
windows DC.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/34e35c4c80f8722d15770754393ce8673fc74a3b">34e35c4c</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: add credentials to samr
lp and creds are missing in SamrContext and samr connection.
While run traffic_replay against windows, this will cause
`Access Denied` error.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/51333c153844ae22eed645a0ce6c70eef78d1963">51333c15</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_packets: replace level 102 to 101 for packet_srvsvc_21
Level 102 will cause WERR_ACCESS_DENIED error against Windows, because:
> If the level is 102 or 502, the Windows implementation checks whether
> the caller is a member of one of the groups previously mentioned or
> is a member of the Power Users local group.
It passed against Samba since this check is not implemented by Samba yet.
refer to:
https://msdn.microsoft.com/en-us/library/cc247297.aspx#Appendix_A_80
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/14af041c139984591698f9e176ff9ba9a428dc34">14af041c</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_packets: replace share_name from netlogon to IPC$ for packet_srvsvc_16
Sharename list for Windows:
Sharename Type Comment
--------- ---- -------
ADMIN$ Disk Remote Admin
C$ Disk Default share
IPC$ IPC Remote IPC
For Samba:
Sharename Type Comment
--------- ---- -------
netlogon Disk
sysvol Disk
IPC$ IPC IPC Service
While test packet_srvsvc_16 with share_name `netlogon`,
it passed Samba, and got a WERR_NERR_NETNAMENOTFOUND error for Windows.
Change share name to `IPC$` so Samba and Windows have it in common.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eafda9137afba96e2375262f846f79597583ab82">eafda913</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_packets: add windows instructions for ldap 0 simple bind
To run packet_ldap_0 simple bind test against Windows, we need to
install CA on Windows with following PowerShell commands:
Install-windowsfeature ADCS-Cert-Authority
Install-AdcsCertificationAuthority -CAType EnterpriseRootCA
Restart-Computer
Otherwise we will get `NT_STATUS_CONNECTION_RESET` error.
Didn't change any code, just add above instructions in comment.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9cabb16b489b43495472b0e7229ba864daa7d479">9cabb16b</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_packets: add trailing $ to fix packet_rpc_netlogon_30
For `NetrServerPasswordSet2`, the 2nd arg `account_name` must end with a
$, otherwise windows will return an `Access Denied` error.
Use `creds.get_username()` instead of `creds.get_workstation()` to
include the trailing $.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7c93fb57f598a8d0d2528c950b9eec2cf5e14189">7c93fb57</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_packets: provision request data for packet_drsuapi_13
The `drsuapi.DsWriteAccountSpnRequest1` struct in this packet was empty before.
Samba lets it go but Windows will report an invalid parameter error.
Provision the request with proper data, and give user permission to
write account SPN.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fd2bcd5d1033d7801e0b955d25279b2d8849c0ae">fd2bcd5d</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: set domain on user_creds and machine_creds
The domain is missing in traffic user and machine credential, this will cause
some packet tests fail against windows.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7181af9f9459d65df9df59ed447729e1c13a958c">7181af9f</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: fetch domain from creds other than opts
For traffic_replay script, when user provides `--workgroup` or `-W` option,
it will be set on the creds option group, not the default opts one.
The previous code will not work properly when smb.conf file is missing.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4fb5e28b663c57cc4f67b28312a291132dae2fb6">4fb5e28b</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: grant user write permission
Some packets need user to have write permission, e.g.: writeaccountspn
Grant user write permission then we can send packets successfully.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5107e56aa089b51f8d00049b63b2c79ea9e495cc">5107e56a</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: simplify forget_packets_outside_window
Make code compact, and improve performance a little bit.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c1af6a0dada79888d3eb9c820163a6b34e900638">c1af6a0d</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: improve add_short_packet by avoiding str.split
Avoid str.split, which will repeat for each packet.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/38fc8125e2728926da31555386b93a0d5acb1c0e">38fc8125</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-12T00:09:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: improve is_really_a_packet
This function will repeat on each packet.
Avoid exception for getattr, which is expensive for performance.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/454d8148a68049a22b852ead1a3e19c1da56fc5f">454d8148</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-05-12T00:09:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/woks/works
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b3799fb6e60f7b33bd5d03e4c924687a5838d968">b3799fb6</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-05-12T00:09:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Ensure all files are retrieved in fetch
.ini files are normally set as hidden, and will not be found over SMB.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cda3b233372dd72c210a39f6efeaa8dbf26e9c67">cda3b233</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-05-12T02:57:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmb: Add some more documentation for conn.list
There are two options which are undocumented.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat May 12 04:57:29 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/36e7043fb16ac996793545022147f696caedee9c">36e7043f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-12T04:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Continue running if a testcase is not executable
At the moment the whole test run aborts without printing a summary of
results but inexplicably succeeds. Instead, generate a clear failure
for a non-executable testcase.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d7d53b25a1e2d9bfa3b654fe268dc3f30820ede">5d7d53b2</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-12T04:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Don't load CTDB configuration in statd-callout
The only configuration options used by statd-callout are NFS_HOSTNAME,
which comes from the NFS system configuration file, and
CTDB_NFS_CALLOUT, which is exported by the 60.nfs event script.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/574af23e9d56ad009820e7ea103a214c115adc51">574af23e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-12T04:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Don't load CTDB configuration in onnode
onnode does not use any configuration options.
Drop sourcing of functions file since the only function used was
loadconfig().
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/130f37c23f9570c4cf2d87a4bc5502569dab1179">130f37c2</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-12T04:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Don't check for CTDB_PARTIALLY_ONLINE_INTERFACES clash
Just document that NAT gateway and LVS are not compatible with this
option. Update the documentation to make it clear that this is a
10.interface option.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/31f26e970092adeb4e560ec21831fc83e378145f">31f26e97</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-12T04:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Separate support script for 06.nfs
Including 60.nfs was too simple a hack, since we will want to do some
magic to use the configuration from 60.nfs for 06.nfs.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/00f35b7b0d0b341e2ef1c7f699f80bbf0e5dc3e0">00f35b7b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-12T04:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Add global script.options configuration file
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/02444e5f479f2d9705de93006916d9cd1333f21c">02444e5f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-12T04:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Allow load_script_options() to specify an event script
This allows other scripts to use the given options for a particular
event script. One interesting example is that the ctdb_natgw tool
should look for configuration in events.d/11.natgw.options.
In the future this will be something like
events/failover/11.natgw.options, so require the component to be
specified even though it isn't yet used.
Test support is also updated.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ac1c12b5a21ed2666478817b377acf8f5aa48644">ac1c12b5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-12T04:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Use load_script_options() in miscellaneous scripts
Some of these just aim to load the generic script.options file while
others target more specific files.
For NFS configuration, always use 60.nfs.options - even for 06.nfs.
This could be carefully documented but will change a lot before
release so there is no need.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a8ccf41b8796df417c92b157e6c61457768d0e6c">a8ccf41b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-12T04:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Document script.options
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f63f9053efb73375247de49bd396792936cbf1a2">f63f9053</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-12T04:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-config: Add a default script.options file
Include it in the RPM.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/74230c59b6a8add7310c4ec39ef315cc67156b5a">74230c59</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-12T04:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Document system options and resource controls
The existing configuration file is disappearing so these configuration
options need a new home that is not handled by ctdbd_wrapper.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7e31a1382fd5eb45448042960e90885462b1452a">7e31a138</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-12T04:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-config: Add default ctdb.sysconfig file, update ctdb.service
Install ctdb.sysconfig in RPM.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b9d01fddc651798a50c2a2bf0d596d5f9d7eb6a1">b9d01fdd</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-12T07:13:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop CTDB_SUPPRESS_COREFILE and CTDB_MAX_OPEN_FILES options
These should be done using features provided by the operating system.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Sat May 12 09:13:28 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a09162df6bd38098253b50a7ac32bfdc8dbf9d4">6a09162d</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-05-12T07:15:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: removing prior secret from logs
priorSecret, like secret, can contain a machine account password
(for secrets.ldb) and so should not be printed in a debug
trace.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13353
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b72d4c7bbb8462232d685e17612b06b4cca57f2">8b72d4c7</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-05-12T07:15:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samdb rid: clear cache to prevent old ntds_guid
During the new samba-tool domain backup restore the NTDS GUID changes
as the server is taken over by the new DC record.
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77ea31bccfc63980cd112c87b2aaf7eb7b5cf549">77ea31bc</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-05-12T10:05:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">devel: removing unused code from chgkrbtgtpass
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat May 12 12:05:31 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b72d5fc7ba2014e3c37c94a3055a15d0124b45d3">b72d5fc7</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-12T10:06:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-packaging: Package all helpers using wildcard
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/356dacc6d701b6d4ffa91f20f208e0d09a4136e6">356dacc6</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-12T10:06:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Add command line processing abstraction
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fe25aa75386298b50192d91e57844cafe39ee571">fe25aa75</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-12T10:06:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Add utility code to get various paths
This will construct correct paths when running with CTDB_TEST_MODE.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b2eaacaa149913f739c634b55f85c778f957258f">b2eaacaa</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-12T10:06:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Add path tool
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cb64a7ca75fdacc0329326b05ae0049e77d02790">cb64a7ca</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-12T10:06:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Setup $CTDB_BASE/{run,var} directories
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77539b479e4c5ef52a7876f39b075b0f6f8ca7fd">77539b47</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-12T10:06:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">util: Add tini to samba-util-core
So it can be used by CTDB.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/702504118f027bd75e959f4d16428758caf9a108">70250411</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-12T10:06:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Add config file parsing code
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e96e1defbaf6d524c046b3aea90fe150c0fadcd9">e96e1def</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-12T10:06:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Add config options tool
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fec40ea544c5bf87c713a5e70a6997d3edd15a68">fec40ea5</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-12T10:06:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Refactor log backend parsing code
This will allow to add a validator for logging specification.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ef8dbc7fc6f45d09f3813e5c61a4751c1f82a9d">7ef8dbc7</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-12T10:06:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Add a function to validate logging specification
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8f97c17df20af9f70b173d7ebb484197e2538587">8f97c17d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-12T10:06:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Add config options for logging
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fcda17cb42f3384c62d81903e364e8ddb4ce217d">fcda17cb</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-12T13:01:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Add logging config options to config tool
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Sat May 12 15:01:32 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/63648af515df6c62e44ebeaa81d73e49511d03bc">63648af5</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-12T19:38:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: Bulk replace of '.next()' method with function 'next()'
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7399da0b44503d2b5fe3218f9b55c79eac4cefe4">7399da0b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-12T19:38:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba_tool: Py2/Py3 compatability fix tuple assigment
replace
(foo, bar) = e
with
(foo, bar) = e.args
while will run in with both python2 and python3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9410cea310f6ac5089a28b90a93bd3b20ffa2d9b">9410cea3</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-12T19:38:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba_tool: make exception handling statements py2/py3 compatible
Fix some missed conversions of
except Exception, e:
to
except Exception as e:
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a0cd47fdf8819efb2c72e81cb132e2f1308bd395">a0cd47fd</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-12T19:38:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/provision: Fix urllib.quote usage for py2/py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ee363db5716334d759cc7f9f3ef61e4227f3f3e5">ee363db5</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-12T19:38:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: Ensure md5 always provided with bytes
To allow code run in both python3 and python2 we have to ensure
that md5 always receives bytes
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c543376e4fec3db00968fa9d682ac7ad5c9962b">9c543376</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-12T19:38:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: py2/py3 compatability replace xrange with range
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5f330840d0479f9a352d19b15159c10efce9d862">5f330840</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-12T19:38:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests: py2/py3 compatability replace xrange with range
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/504fca732a3ed0865c39772767ee520f99a93cad">504fca73</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-12T19:38:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba_tool: replace xrange -> range
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/521bc6056edc5252f2256664f4eacba13a3749e3">521bc605</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-12T19:38:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Bulk: enclose .keys() method with list where list (from python2) expected
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff1920fb6704a617d03d2a18905a4fb603a351bc">ff1920fb</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-12T19:38:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting/bin: py2/py3 compatability always decode result of b64encode
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf95ecb35dae64e0a07c126f264bdf8a7ccc2a8a">bf95ecb3</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-12T19:38:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting/devel: py2/py3 compatability always decode result of b64encode
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f30a0b5f11b58ab0bb528c7387099171703de4c">6f30a0b5</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-12T19:38:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests: py2/py3 compatability always decode result of b64encode
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c50ccc714a1871ef6eaa3bfc9b16c232127d3fad">c50ccc71</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-12T19:38:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: py2/py3 compatability always decode result of b64encode
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/26c4084ad2d5f35d4e35026c96150759d062969a">26c4084a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-12T22:24:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/credentials/test: py2/py3 compat always decode result of b64encode
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun May 13 00:24:35 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a513304adadd79d1c63d55fcf06b67ed45d43ba">9a513304</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-05-13T08:27:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:lsa_lookup: remove TALLOC_FREE(state) after all dcesrv_lsa_Lookup{Names,Sids}_base_map() calls
This completes the regression fix of commit 7e091e505156381e385235ab4518b4d133a98497.
There might be strings allocated on state, which are part of the
result.
The reason for the TALLOC_FREE(state) was to cleanup the possible
irpc_handle before leaving the function. Now we call
TALLOC_FREE(state->wb.irpc_handle) explicitly in
dcesrv_lsa_Lookup{Names,Sids}_base_done() instead.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13420
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun May 13 10:27:28 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/31cba34a8f0e1301423468c6570530b0e298eb20">31cba34a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-13T21:43:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix "reset on zero vc"
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13340
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sun May 13 23:43:56 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/72f98f9763669887482cf430c7734b0a0d69cc1b">72f98f97</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-14T00:53:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: change machine creds secure channel type
SEC_CHAN_WKSTA --> SEC_CHAN_BDC
This will fix netlogon failure against windows.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2fc6cbb8cb4931f7f4b130817859d2a283ac541c">2fc6cbb8</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-14T00:53:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: fix userAccountControl for machine account
change userAccountControl from
UF_WORKSTATION_TRUST_ACCOUNT | UF_PASSWD_NOTREQD
to
UF_TRUSTED_FOR_DELEGATION | UF_SERVER_TRUST_ACCOUNT
This will fix NetrServerPasswordSet2 failure in packet_rpc_netlogon_30
while testing against windows.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/21c82072ab87e3dee617b3219364e55e9c106432">21c82072</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-14T00:53:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: optimize packet init for better performance
When we run traffic_replay, we are creating millions of Packet objects.
So small change in Packet.__init__ will make big difference.
By initializing packet with converted values without parsing string, the time
cost for 3961148 calls of Packet.__init__ dcrease from 17s to 4s, according
to cProfile.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d444221d67abc05dc9966dd7e0a37d30f9848953">d444221d</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-05-14T03:38:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: improve add_short_packet by avoiding dict.get
dict.get is slower than [].
Avoid get to improve performance.
(For 3989418 calls, total time decease from 9.395 to 8.573)
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon May 14 05:38:06 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1b34b8691896dcfac6be604fdd354c2b2466efb8">1b34b869</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-14T07:58:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:cleanupd: sends MSG_SMB_UNLOCK twice to interested peers
MSG_SMB_UNLOCK should be send to smbd that are waiting on blocked
byte-range-locks when a lock holder died.
In smbd_cleanupd_unlock() we do this twice: once via a broadcast and
then again via brl_revalidate() to processes that are actually recorded
in brlock.tdb.
As brl_revalidate() should already take care of signaling anyone who
would be interested in the message, there's no need to broadcast.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13416
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri May 4 03:02:28 CEST 2018 on sn-devel-144
(cherry picked from commit 53ff08a2cf838c0f1c3f050ac2aa13fc3acc5981)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/234216c1e02dd45d35179235dcef57948b63abfd">234216c1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-14T07:58:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-lsa: Fix use-after-free in LSA server
This is a regression introduced in ab7988aa2fd1a43f576a4b73a6893c61c7ef1957.
The state variable contains the data to be returned to the client
and packed into NDR after the function returned.
This memory needs to be kept (on mem_ctx as parent) until that is
pushed and freed by the caller.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13420
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit 7e091e505156381e385235ab4518b4d133a98497)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/060a04793c3c5cdc902d71619a2ba32fab0bc7c3">060a0479</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-05-14T07:58:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:lsa_lookup: remove TALLOC_FREE(state) after all dcesrv_lsa_Lookup{Names,Sids}_base_map() calls
This completes the regression fix of commit 7e091e505156381e385235ab4518b4d133a98497.
There might be strings allocated on state, which are part of the
result.
The reason for the TALLOC_FREE(state) was to cleanup the possible
irpc_handle before leaving the function. Now we call
TALLOC_FREE(state->wb.irpc_handle) explicitly in
dcesrv_lsa_Lookup{Names,Sids}_base_done() instead.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13420
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun May 13 10:27:28 CEST 2018 on sn-devel-144
(cherry picked from commit 9a513304adadd79d1c63d55fcf06b67ed45d43ba)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/01c335ddd88ccbac2210af1c19f80c76326d168b">01c335dd</a></strong>
<div>
<span>by Vandana Rungta</span>
<i>at 2018-05-14T07:58:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Fix memory leak in vfs_ceph.
Centralize error handling.
https://bugzilla.samba.org/show_bug.cgi?id=13424
Signed-off-by: Vandana Rungta <vrungta@amazon.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed May 9 04:28:11 CEST 2018 on sn-devel-144
(cherry picked from commit 4e78aeedb8329953df83fc7f2c191b2c97a051d0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/54c537a0eebc8a4450cc71b25b605719f44e2af0">54c537a0</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-05-14T07:58:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_ceph: add fake async pwrite/pread send/recv hooks
As found by Jeremy, VFS modules that don't provide pread_send() or
pwrite_send() hooks result in vfs_default fallback, which is
catastrophic for VFS modules with non-mounted filesystems such as
vfs_ceph.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13425
Reported-by: Jeremy Allison <jra@samba.org>
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit f0e6453b0420fe9d062936d4ddc05f44b40cf2ba)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7557c5df797df4d5a0b42bdc7cffc5c02cc5a6a8">7557c5df</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-14T07:58:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Add a cache of the samr and lsa handles for the passdb domain
This domain is very close, in AD DC configurations over a internal ncacn_np pipe
and otherwise in the same process via C linking. It is however very expensive
to re-create the binding handle per SID->name lookup, so keep a cache.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13430
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit d418d0ca33afb41a793a2fff19ca68871aa5e9ef)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/32a5538a525e3a52f2a3b28e623c602ff8a155ce">32a5538a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-14T13:11:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Do re-connect if the RPC call fails in the passdb case
This is very, very unlikely but possible as in the AD case the RPC server is in
another process that may eventually be able to restart.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13430
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit fc9150dcab231fe9beb72e198b0c2742d5f2505f)
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Mon May 14 15:11:11 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e45b5047b94c3f0c812fe7d4931610bcf45bd437">e45b5047</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-05-14T16:27:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool computer: fix wrong computer container in help message
CN=Users --> CN=Computers
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Björn Jacke <bjacke@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9be8ef19553069593c3766177f065d3b9ce06bba">9be8ef19</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-05-14T16:27:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml:samba-tool.8: fix wrong default computer container name
CN=Users --> CN=Computers
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Björn Jacke <bjacke@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/171750e966e040493c8631fcdd65478ab35e6f2e">171750e9</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2018-05-14T19:15:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/wscript: remove test, that we do in lib/replace
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Björn Baumbach <bb@sernet.de>
Autobuild-User(master): Björn Baumbach <bbaumbach@samba.org>
Autobuild-Date(master): Mon May 14 21:15:21 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6fda57d3097e4e02310d7cfdba4f8ee27a69fb93">6fda57d3</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-15T01:36:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Make --with-json-audit the default
Thanks to Rowland for a clear description of the behaviour for the smb.conf manpage.
This means that those not wanting to link to libarchive will just need to
build --without-json-audit.
In general, we prefer that optional libraries be required by default
so that they are not accidentially missed, particularly in packages.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78c8e699a8e34ebe69b704b455733050fd195af6">78c8e699</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-15T01:36:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Make --with-libarchive the default
This means that those not wanting to link to libarchive will just need to
build --without-libarchive.
In general, we prefer that optional libraries be required by default
so that they are not accidentially missed, particularly in packages.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aced4017283e2614e80fb6f20fc85d3a284ad6c1">aced4017</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-15T01:36:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Make --with-gpgme the default
Those wishing to build without gpgme support need simply to build --without-gpgme
This In general, we prefer that optional libraries be required by default
so that they are not accidentially missed, particularly in packages.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a0f0350252fb079d9ffec9b7f3589e97872688f9">a0f03502</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-15T04:31:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Require libarchive for --enable-selftest
This avoids one more case where tests can go missing by removing the conditional.
(Yes, this has happend for other tests in the past).
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue May 15 06:31:03 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8063995a92fffc93aa9d6d1d92a75bf3f3c9592b">8063995a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-15T04:32:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Put "results_store" into a doubly linked list
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13362
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9fbd4672b06de5333a9c44fc126b8edac0b9d31a">9fbd4672</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-15T07:37:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Hold at most 10 outstanding paged result cookies
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13362
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue May 15 09:37:21 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/506c520503eacff33064c1c23a068399f7296d86">506c5205</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-15T10:40:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: fileserver: Change defaults to work with EA support out of the box.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue May 15 12:40:48 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a3d6fdd5355d366f3d23915cecc10c6f039daa44">a3d6fdd5</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-05-15T10:41:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: keytab invalidation test
chgtdcpass should add a new DC password and delete the old ones but the bug
exposed by this test causes the tool to remove only a single record from
the old entries, leaving the old passwords functional. Since the tool is
used by administrators who may have disclosed their domain join password and
want to invalidate it, this is a security concern.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13415
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8bd67c593da5525a63a1d596e2c7fe38bc7cee57">8bd67c59</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-05-15T13:45:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: keytab invalidation fix
chgtdcpass should add a new DC password and delete the old ones but the bug
exposed by this test causes the tool to remove only a single record from
the old entries, leaving the old passwords functional. Since the tool is
used by administrators who may have disclosed their domain join password and
want to invalidate it, this is a security concern.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13415
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue May 15 15:45:08 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e838d8a5c2c0f1c91abb21bca908dbb0b2e2fba4">e838d8a5</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-15T19:12:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Fix CID 1435598 Error handling issues (CHECKED_RETURN)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue May 15 21:12:33 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/28469c0ad4602a0dd4127792a271d293fdcf6a1f">28469c0a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-15T19:13:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool domain provision: Move more OpenLDAP options behind TEST_LDAP
These options controlled the historical LDAP backend, they should not be left
to confuse other users.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/18aa6541c980d8a1be254422940a8d40ae5294cd">18aa6541</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-15T19:13:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool domain: Create a common set of options for provision/join/dcpromo
These commands share much in common, the options should be in common as well.
Start with --targetdir.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ba0f55e9a63c035632956dfa5033233b3b83739">5ba0f55e</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-15T19:13:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool domain: Add --quiet to common options
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b2002b67b809e847d78f8d52d0eae041be61e897">b2002b67</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-15T19:13:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool domain: Add --machinepass to common options
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53c2ed566c19a719caa8d302bbca1ef92a88a29f">53c2ed56</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-15T19:13:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool domain: Extend --plaintext-secrets to dcpromo by moving to common options
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d5d8589f353974fb63caf71ba1d1fdc6f5b453ab">d5d8589f</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-15T19:13:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool domain: Extend --backend-store to join and dcpromo by moving to common options
This allows the choice of ldb backend for a domain join as well as a new provision.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f55eab600fef592204056823ea82d89c11bd0bef">f55eab60</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-15T19:13:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool domain: Create a common --use-ntvfs option for provision, join, dcpromo and classicupgrade
The NTVFS fileserver mode is still integral to the selftest system (often simply used to
make the rest of the command run and not fuss with POSIX ACLs and permissions).
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/72e18d671c48045cbc162e0650926e4038fcbb3f">72e18d67</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-15T19:13:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool domain: Spit out common options between dcpromo and join
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/840eb5b0f5d4092c142546f9f2f940443bd64e38">840eb5b0</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-15T19:23:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Upload 2:4.8.1+dfsg-2 to unstable
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ebe3183fded1ab060ed60baeedeac859d0c137e">5ebe3183</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-15T21:58:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Make setexpiry test much more reliable
Rather than setting all the expiries and expecting that they will be done within 5 seconds,
measure and check the time individually for each record.
This should make this test much less prone to flapping.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue May 15 23:58:17 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f2bebf09cd8056b3f901dd9ff1fc9e9525f3e9d">7f2bebf0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-05-15T22:13:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/ntlmssp: add ntlmssp_client:ldap_style_send_seal option
This will be used to similate a Windows client only
using NTLMSSP_NEGOTIATE_SIGN without NTLMSSP_NEGOTIATE_SEAL
on an LDAP connection, which is indicated internally by
GENSEC_FEATURE_LDAP_STYLE.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13427
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fc1c5bd3be2c3f90eab2f31e43cf053f7ff13782">fc1c5bd3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-05-15T22:13:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:selftest: run test_ldb_simple.sh with more auth options
This demonstrates the broken GENSEC_FEATURE_LDAP_STYLE
handling in our LDAP server.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13427
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c7a3ce95ac4ce837d8fde36578b3b1f56c3ac2fa">c7a3ce95</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-05-16T01:26:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/ntlmssp: fix handling of GENSEC_FEATURE_LDAP_STYLE as a server
This fixes "NTLMSSP NTLM2 packet check failed due to invalid signature!"
error messages, which were generated if the client only sends
NTLMSSP_NEGOTIATE_SIGN without NTLMSSP_NEGOTIATE_SEAL on an LDAP
connection.
This fixes a regession in the combination of commits
77adac8c3cd2f7419894d18db735782c9646a202 and
3a0b835408a6efa339e8b34333906bfe3aacd6e3.
We need to evaluate GENSEC_FEATURE_LDAP_STYLE at the end
of the authentication (as a server, while we already
do so at the beginning as a client).
As a reminder I introduced GENSEC_FEATURE_LDAP_STYLE
(as an internal flag) in order to let us work as a
Windows using NTLMSSP for LDAP. Even if only signing is
negotiated during the authentication the following PDUs
will still be encrypted if NTLMSSP is used. This is exactly the
same as if the client would have negotiated NTLMSSP_NEGOTIATE_SEAL.
I guess it's a bug in Windows, but we have to reimplement that
bug. Note this only applies to NTLMSSP and only to LDAP!
Signing only works fine for LDAP with Kerberos
or DCERPC and NTLMSSP.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13427
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed May 16 03:26:03 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/74cf8f5e3b991292ae592a0786e01914ca162caf">74cf8f5e</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-16T02:07:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth logging: Extract common audit logging code
Extract the common audit logging code into a library to allow it's
re-use in other logging modules.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2ba55f81a9514a9e8adc6904e58d166c98aecaa7">2ba55f81</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-16T02:07:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">logging: add ldb audit classes
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d068123f134e7c7f6ad2433720ba94e18d4f8b5">5d068123</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-16T02:07:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb conf: Add DSDB event notification parameter
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/36800d0903dcb7a8ebb12a347eb1dbbd038adba8">36800d09</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-16T02:07:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">idl messaging: Add DSDB and Password events and message types
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/75097275a705dbfa1ff8f75b701e2968c716eaa8">75097275</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-16T02:07:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth_log: Use common code from audit_logging
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c15fc1442bd9fb0bc7753e3d67f88364653e06de">c15fc144</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-16T02:07:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth_log: tidy up code formatting
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2d47f9e160a3982b21293013b2f66999b62deab8">2d47f9e1</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-16T02:07:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth_log: Rename the json variables
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c6cb4639aba69262a1ad0d098aadb181035e79b">0c6cb463</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-16T02:07:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">messaging idl add group membersip events
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dfa341c1eb2d952adccce6b8f65d6d2ab02112aa">dfa341c1</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-16T02:07:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb.conf: Add dsdb group change notification parameter
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/431e02d006b0d7749a65e04da911bc27961e925d">431e02d0</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:40:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add Fix-pidl-manpage-sections.patch
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e145901d45dd2d76d5f55e1734ecf48f15ac6b36">e145901d</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:41:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add Fix-spelling.patch
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3b2bc960dfc3315ba166c3a52d73160bc0e33465">3b2bc960</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:41:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add Improve-vfs_linux_xfs_sgid-manpage.patch
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff7b4ea1ca4b1803b50f94a0a5ca9ebc4b2f8900">ff7b4ea1</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix pidl manpage sections
.TH header should match file name (i.e 3pm and not 3 for Parse::Pidl::NDR).
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7e730e3f60a086c2479c981a7ca0e743d2f4b5ba">7e730e3f</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/allows to/allows one to/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53816639753feabbbae89b97afa4501aff8d863d">53816639</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/anwser/answer/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f3340420ed92e8ee6640365e572a2fe765b4598c">f3340420</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/authenticaiton/authentication/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ac1497ce009c9dbcc99ffab47e2fd580fd7d0b7b">ac1497ce</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/conection/connection/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/56483cd6098540eba21cf47d56c2e5ad5c4c01ee">56483cd6</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/coult/could/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e5de840d83ae1cf001430fb567ed8ef56986dc5d">e5de840d</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/desriptor/descriptor/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65aa8271f8b1764296c14975acf43fabf467c681">65aa8271</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/doens't/doesn't/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fe976ece4d783be9770389ee4279dec22389ed17">fe976ece</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/Everytime/Every time/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2c72a72307669685e3200433e893e21d60b5ca81">2c72a723</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/formated/formatted/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8952b4e6ee19e8e0353ba8392e4f087a070be238">8952b4e6</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/fowarding/forwarding/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6c8151a893b1d1563f15352543d584dd1b462682">6c8151a8</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/malicous/malicious/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/04827d475b92e85aa8aef57d6ecc0e9a5c3e2896">04827d47</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/missmatch/mismatch/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eca0b0e1b221445d43bb04941d1dd5166e0f3ad4">eca0b0e1</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/openened/opened/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59821d05afd001f36c842bea8bede89c723f3fb9">59821d05</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/opions/options/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0782969aa8a39f1d1dce4f56f52879088db719e4">0782969a</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/ouput/output/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3fd531eb54e410dfd0a5b6175a8ead6440e36d9a">3fd531eb</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/processs/process/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/072083327569a67542fc097bff4d4c3ad32bc984">07208332</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/propogate/propagate/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/48e2b0cbe51c40fff3faebd8a7303e7f963e8e51">48e2b0cb</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/protcol/protocol/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/757106eda2749f1c0863cbeaa4c04ecdba22c8b5">757106ed</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/receving/receiving/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3a60203108856a1ddabecd9d4471e432ecef7050">3a602031</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/retrive/retrieve/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6660d65d9c97f552189305b35bb76d28fd74662f">6660d65d</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/retun/return/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1a9d56a7430e405264105fcb07d202be26f91b85">1a9d56a7</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/specfied/specified/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0241e3fb7d5c3c9d82e233d84e3d81516a2f952b">0241e3fb</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/succesfully/successfully/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f4b34d13a491290448320035786f8782008736fd">f4b34d13</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/unitialized/uninitialized/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f8997fdf51b4efbb2ac12eaaa56486da73cf4b3">7f8997fd</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling s/unsuported/unsupported/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1646272eba797e18d01b970bd3fb9afd2ddf0798">1646272e</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:42:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Improve vfs_linux_xfs_sgid manpage
- Add missing refpurpose and describe the "circumstances"
- Replace dangling link by archive.org backup
- Add fixed Linux version and commit link
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2ccd53dd2a5338f72f1389cad809425476d643ad">2ccd53dd</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T04:44:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Changelog for previous commits
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/472dca29055e02b97684e1d174e688aba2e83b7d">472dca29</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-16T05:02:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debug: Add group logging classes
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed May 16 07:02:20 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/215d8448f0e51c4f5ffdcee6003dcbce4d1440a5">215d8448</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-16T05:03:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Fix CID 1435599
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c853a8071a6efafe92e7df608ec636f43aa9d371">c853a807</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-16T07:51:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Fix CID 1435600
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed May 16 09:51:07 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5be589c6f96bc65eb90f8d214f4d14f7e48143de">5be589c6</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-05-16T10:04:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.8.2.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e64d0d03351ce8fbc1f929fa86dcfd8d56183f35">e64d0d03</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-05-16T10:05:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.8.2 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cc678c4f8fb9b19a7648a3a5fa2d807742a964df">cc678c4f</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-05-16T10:06:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.8.3...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c0fd6cd386215c7d0bf5c6207b9ac2abaee665a7">c0fd6cd3</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-16T11:53:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script: Add 'random-seed' option to traffic_replay
When using a traffic-model file to generate traffic, there is some
randomness in the actual packets that get generated. This means it's
hard to use the tool to detect an increase/decrease in Samba
performance - we don't know whether a decrease in packets sent is due
to a regression in the Samba codebase, or just due to the tool sending
different types of packets (i.e. ones that take longer to process).
This patch adds an option to seed the python random number generator.
This means that exactly the same traffic can be generated across
multiple test runs.
(Previously we were using the '--traffic-summary' option to avoid this
problem - we can generate a summary-file based on the model, and then
use the same summary file across multiple runs. However, this proved
impractical when you want to run multiple combinations of scale/rate
parameters, e.g. 21 x 8 different permutations just fills up disk space
with summary-files.)
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: William Brown <william@blackhats.net.au>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed May 16 13:53:26 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d3cbcbd5c0b22ce8ef368f2278fa4421c91f7502">d3cbcbd5</a></strong>
<div>
<span>by Timur I. Bakeyev</span>
<i>at 2018-05-16T16:06:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Remove extra 0x prefix for the "%p" format specifiers, avoiding 0x0x0 strings in the output.
Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/010cddae6c46d6ece67b80d4f6697a793f9b5350">010cddae</a></strong>
<div>
<span>by Timur I. Bakeyev</span>
<i>at 2018-05-16T19:29:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Convert affected by previous commit lines from DEBUG(10,..) to DBG_DEBUG().
Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed May 16 21:29:24 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b8f5616dbdd7fa593156e000398c00b16dcc84c">9b8f5616</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-16T19:30:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:dsdb:tests: Add return code check
Found by Coverity.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/228ef49324eba83c045be0f4fef323eba977bf6c">228ef493</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-16T19:30:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Initialize validation_level in winbind_dual_SamLogon()
Found by Covertiy.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e7e4362ba24fe0300b2b649949e097c062a58756">e7e4362b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-16T19:30:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: Initialize pointers in vfs_virusfilter
Found by Coverity.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3f1da75f3a0cf0d5c1cce1b987dda6e0115ca8dc">3f1da75f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-16T19:30:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Make sure variable is initialized in oplock test
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/25c4f8c561edb83054218d1eba9f92e41a6573c5">25c4f8c5</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-16T19:30:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: Fix coverity warning in smb2cli_notify_send()
result_independent_of_operands: "(uint16_t)(recursive ? 1 : 0) >> 8" is
0 regardless of the values of its operands. This occurs as the operand
of assignment.
Found by Coverity.
Pair-Programmed-With: Ralph Boehme <slow@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/76d5f78bb8de7ed8dfbc0d6b237c6d63ea15678f">76d5f78b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-16T19:30:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Fix converity warning with _smb_setlen_large()
result_independent_of_operands: "(outsize - 4 & 0xffffff) >> 16 >> 8" is
0 regardless of the values of its operands. This occurs as the bitwise
first operand of "&".
So we should just pass a variable to silence the warning. However for
this, we should calculate it correctly and use size_t for it.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3e3df112d7ae64d77876f2aa9956962d0386a69d">3e3df112</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T20:43:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">New upstream version 4.8.2+dfsg</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/213e16361761107508a6d233901176f4597116bf">213e1636</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T20:49:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge tag 'upstream/4.8.2+dfsg'
Upstream version 4.8.2+dfsg
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/892e76ab9edfeea12d0fd9428c162533b5d75f97">892e76ab</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T20:51:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Wrap very long lines in d/rules
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b7063059df217b4d4b83f2e65c59c05bfefdeb48">b7063059</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-16T20:54:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Bump build-depends ldb >= 1.3.3
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cb9796ffc071c1aa9cd5f1b3ade983978910b29a">cb9796ff</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-16T23:09:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Check return values of tevent_req_set_endtime()
Found by Coverity.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu May 17 01:09:46 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/20c158c1f4c35d5176551aa24007d71fa8d1c84e">20c158c1</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-16T23:10:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmbclient: Use const for setting and getting strings
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a762386ccffaace486d8422656b29a4965e13172">a762386c</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-05-16T23:10:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmbclient: cleanup smbc_setWorkgroup() usage
It now takes a const char *. There's no need to use heap memory here.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4eefd573d24136da37368debb366772c6dbf955f">4eefd573</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-16T23:10:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Do not leak memory in libsmbclient test
Found by Coverity.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c83dad5b12cecfdd51fd573b62c0f1ed2b58855a">c83dad5b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-17T02:03:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Do not leak file descriptor in smb2 oplock test
Found by Coverity.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu May 17 04:03:21 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/31747da5ff69eb3442db6ed9949c49776317ddce">31747da5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-build: Create database directories during installation
Create and package.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/344e6eecb29a00bcdb3d18c62ac99d0b2a405257">344e6eec</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Create database directories for local daemons
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9193a10f05562c756912d59882eac1cea44bb5d9">9193a10f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Do not create database directories
These should be created at installation or, if non-standard, by the
administrator.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/61efed5a7e19825d49130b4e6785cfb29c557a32">61efed5a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop CTDB_MAX_PERSISTENT_CHECK_ERRORS option
This must harken back to the days of yore when corrupt persistent
databases were an issue. We haven't seen this used. If CTDB fails to
start due to a corrupt persistent database then this database can be
removed by hand.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/920f83457861c5f0566e9fb664efe7c715dee09a">920f8345</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop ctdbd --max-persistent-check-errors option
Leave the code with an internal default of 0.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8831f6740e0892d296eaba91805f9d437ecbdb9a">8831f674</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-17T02:04:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Add event daemon config file options
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5eec5e7c1f0dbafbeb627c0ef53944ad9f2d355c">5eec5e7c</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-17T02:04:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Add event daemon config options to config tool
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cf17a48d29a991b7dc7d582e538f11b5a0ac8166">cf17a48d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-cluster: Define cluster configuration file options
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dbdd49da23c78fa12af39f29277f38827b5a6942">dbdd49da</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Add cluster config options to config tool
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/52d27012796474a3ce024a14d10d8c7eceff057c">52d27012</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-database: Define database configuration file options
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65d9d1e743ff1598b66738b64dc18bcc27d9c981">65d9d1e7</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Add database config options to config tool
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d91b9b309ca270dbd60798902fcb45d2e3bb461a">d91b9b30</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Define ctdbd legacy configuration file options
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b42dbadbef1f57e5c59edb1ee094434243c892ba">b42dbadb</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Add legacy config options to config tool
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/239f189b10160c0c176e6e0ebef089c8d544f213">239f189b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Implement ctdb configuration file loading
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/61e288ad70b7bbf16726d703596507137e0417d2">61e288ad</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Integrate configuration file handling
Testing is now broken because command-line options are no longer
respected.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e06610f8c9d8036492028ee0dc74cd8bef0d9e5">4e06610f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Translate old style options into new configuration file
This allows the relevant command-line options to be removed from the
daemon while still leaving the old ctdbd.conf options file in place.
It is a temporary measure to enable testing in an old testing
environment.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78fbbfa4d3892d66c4dc2f02bb2b3200cfcd5159">78fbbfa4</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop most ctdbd command-line options
All except -i/--interactive. This remaining popt option is now neatly
wrapped to fit in 80 columns.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/25f05ced2f70f30bdf2791ddf97efbae75868fd4">25f05ced</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add new variable CTDB_SCRIPTS_HELPER_BINDIR
This will always find a binary helper, as opposed to a script helper,
which currently lives under tools/ in the source tree.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff3d0e70b69d47e62478b3f5a6b8bc3957a01444">ff3d0e70</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add setup of ctdb.conf database directory settings
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7c33f5ec2da3e2995995ffccfa2db4f44e486b26">7c33f5ec</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add setup of ctdb.conf recovery lock setting
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ad82b8abc3a7ee9b72ae51b383ae012e2b8a4bcf">ad82b8ab</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add ctdb-config wrapper stub for event script tests
Create a shim helper around that simply invokes ctdb-config via its
real location.
This is needed because the event script tests set CTDB_HELPER_BINDIR
to the stubs directory because all other helpers used by event script
testing are currently stubs.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/16aa9e7a303e13440d702ae444842af349db961c">16aa9e7a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Add function ctdb_get_db_options()
This pulls database options from the configuration file, caches then
and makes the values available in scripts.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2bc6be1e4f77245441950719757893ac28a984c7">2bc6be1e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Fetch database options from config file in scripts
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b099431fd02c9a8c3a5bfc52fa42d6d891bef59">9b099431</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Fetch recovery lock option from config file in 01.reclock
Put it in a function so it is easy to move to common code just in case
it is needed somewhere else.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/60811d62e5cd37a7aece7d9c63c9434069e76365">60811d62</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Clean up tests to not expose script options
The tests still use the script options but the event scripts no longer
see them exported from the test infrastructure. Testing now depends
on the event scripts successfully fetching the options from the
configuration file.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/72ba7ea887f2fe88521dd653ae618ea6738535e4">72ba7ea8</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Add ctdb.conf(5)
This documents the new Samba-style configuration file.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/409b0b797ef345d270f1b0f55bb8691088245c20">409b0b79</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Add ctdb.conf(5) cross references and documentation tweaks
Minor updates to other manual pages for compatibility.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bd58f7af40f6456555897a87d5946ab60800edb9">bd58f7af</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Add example configuration files
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1aa17eb44774686967b55d3bd19c54646669999b">1aa17eb4</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-config: Add default ctdb.conf file
Install it in RPM.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b184761829dc291cbed696084c271316dca79607">b1847618</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T02:04:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Switch local daemons to use new style configuration file
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87284da7a28172b40504eb50510a8b57da6692a6">87284da7</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-05-17T05:03:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Drop configuration file ctdbd.conf
Drop function loadconfig(), replacing uses with "load_system_config
ctdb". Drop translation of old-style configuration to new
configuration file. Drop export of debugging variables. Drop
documentation and configuration examples.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Thu May 17 07:03:04 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4109236cfdd9cec68acd67d46f2155f27d1549b6">4109236c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-17T06:44:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Introduce "bool_dispatch_table"
This is meant to replace the synchronous "dispatch_table".
The current dispatch_table assumes that every synchronous function does
the request_ok or request_error itself. This mixes two concerns: Doing
the work and shipping the reply to the winbind client. This new dispatch
table will make it possible to centralize shipping the reply to the
client. At a later stage this will enable easier statistics on how long
request processing took precisely.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/214d78a6fab55eac3a80e06daaf91763da135f49">214d78a6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-17T06:44:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: winbindd_interface_version() -> bool_dispatch_table
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/25c365c637776ef2a1fbab1c2ca46dcb7c21bfff">25c365c6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-17T06:44:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: winbindd_info() -> bool_dispatch_table
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c6b9a0fd70e0ba010b1febb7da9c810960c1a887">c6b9a0fd</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-17T06:44:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: winbindd_ping() -> bool_dispatch_table
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/05105ea0f8c5eef4c59e8e65b2b4a1bdaffa5279">05105ea0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-17T06:44:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: winbindd_domain_name() -> bool_dispatch_table
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/762d8ab7595cffd6fda79fd4efabf388f6bc3d13">762d8ab7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-17T06:44:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: winbindd_netbios_name() -> bool_dispatch_table
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de162c033c0708bfc76c1e698474b2f7225f25a9">de162c03</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-17T06:44:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: winbindd_dc_info() -> bool_dispatch_table
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a180f401f8af719c728ae49da94fc18df354f77e">a180f401</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-17T06:44:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: winbindd_ccache_ntlm_auth() -> bool_dispatch_table
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a781596ed663b6a47236684e8688dd3cec0f5f8a">a781596e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-17T06:44:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: winbindd_ccache_save() -> bool_dispatch_table
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4f8ea6da431142ce025a4b9281b8e9189b81f878">4f8ea6da</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-17T06:44:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: winbindd_priv_pipe_dir() -> bool_dispatch_table
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b11e917590ff581143ed8d5e01905aa3fb979bd">7b11e917</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-17T06:44:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: winbindd_list_trusted_domains() -> bool_dispatch_table
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4051b70450b4d6b693e67e4a772911dad3ec0668">4051b704</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-17T06:44:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Make DOMAIN_INFO a proper async request
This has an async code path hidden inside. Expose that properly.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e4e2a088398c6fa3c42b69e009fc40b500c7453">0e4e2a08</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-17T06:44:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Remove the "old" non-bool dispatch table
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70ce35d528d9118f138de6688f94176d18bf6599">70ce35d5</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-17T06:44:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Make "request_ok()" static to winbindd.c
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8f215b8db6600c2e7e1415374eeb0aaa6fcf6860">8f215b8d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-17T06:44:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Make "request_error()" static to winbindd.c
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/23fbc23a06f18fc19f6e60de170e354e5860e741">23fbc23a</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-17T07:59:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Release 2:4.8.2+dfsg-1
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8109857f374250a826a8f260b17e2804f09e95e3">8109857f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-17T09:30:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Remove an unused function prototype
This has been moved to async in 2009
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu May 17 11:30:18 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b28b6a4565870ac402b3678b4eecfe8e30fb0a73">b28b6a45</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-17T09:31:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/setup/tests: Add test for non ascii password setting samba-tool
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13435
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7102732b25dfcd5e6815159e3043eed240e918d3">7102732b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-17T09:31:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: Fix incorrect encode of password
In python2 you can encode a 'str' type which doesn't really make sense
since it is already bytes (as such). In python3 this isn't possible you
can't encode bytes or decode strings. Also because you can call encode
on 'str' in python2 it tries to to what you wanted and it implicity
calls decode('ascii') before performing the encode. This is why we get
mention of ascii codec in the error. This patch should future proof for
python3 also.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13435
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a8d8c6ec439fb64ce33dc2406bb38792050ca3a1">a8d8c6ec</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-17T09:31:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs/blackbox: Add test to set and use password with non-ascii
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/75e1019f6162814eae3edb050d41784179cfa8ab">75e1019f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-17T09:31:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/libnet: Allow passwords containing non ascii characters to be passed
Although we can pass unicode to py_net_change_password unfortunately in
Python2 unicode strings are encoded with the default encoding (e.g. ascii)
when extracting the unicode string to buffer.
In Python3 the default encoding for "s" format is utf8. Use the "es"
format instead of "s" so we can specify the encoding so behaviour is
correct in py2/py3.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e7144f2e115f7d446de880a5680c2f2f02dd9467">e7144f2e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-17T09:31:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: net.change_password should be passed string
password param which in python2 (is str) is incorrectly encoded
before passing to net.change_password.
python2 - password is either unicode or str, if str we should
decode to get unicode (and then pass to net.change_password).
python3 - password is either str or bytes, if bytes then decode
(and pass as 'str' to net.change_password).
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/83bde8a49cf3015c71302fbd209f95006e7535b2">83bde8a4</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-17T12:28:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">FIXUP: Improve memory handling on py_net_change_password
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Thu May 17 14:28:19 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cdd98aa1e2116fb97e16718d115ee883fe1bc8ba">cdd98aa1</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-17T15:28:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Do not segfault on error in DoDNSUpdate()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13440
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu May 17 17:28:28 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a0ad57b211ad87709e5886f319a450c4f9db3fd">2a0ad57b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-17T15:30:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Add sanity check when closing fd
Found by Coverity.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e1dad1d8ddeb9281b267186163dc4109cae3d599">e1dad1d8</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-17T15:30:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Check if we have an open file descriptor
Found by Coverity.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3c6481d75cea175d0a69988577163efb40e2316b">3c6481d7</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-05-17T15:30:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-winbindd: use fill_domain_username_talloc() in winbind.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b24d4eb7afad82afc3a9bab65e1d799edc4b5172">b24d4eb7</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-05-17T15:30:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-winbindd: remove unused fill_domain_username()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6326b3415f3e225aafd5912d0965c80abcd7b22c">6326b341</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-05-17T15:30:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-printing: fix format-truncation in print_queue_update()
../source3/printing/printing.c: In function ‘print_queue_update’:
../source3/printing/printing.c:1809:42: error: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 244 [-Werror=format-truncation=]
snprintf(key, sizeof(key), "MSG_PENDING/%s", sharename);
^~ ~~~~~~~~~
../source3/printing/printing.c:1809:2: note: ‘snprintf’ output between 13 and 268 bytes into a destination of size 256
snprintf(key, sizeof(key), "MSG_PENDING/%s", sharename);
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5729898248041794ffdd0b769332e015baf12cce">57298982</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-05-17T15:30:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-torture: fix format-truncation warning in smb2 session tests.
../source4/torture/smb2/session.c: In function ‘test_session_reauth5’:
../source4/torture/smb2/session.c:645:36: error: ‘\file.dat’ directive output may be truncated writing 9 bytes into a region of size between 1 and 256 [-Werror=format-truncation=]
snprintf(fname, sizeof(fname), "%s\\file.dat", dname);
^~~~~~~~~~
../source4/torture/smb2/session.c:645:2: note: ‘snprintf’ output between 10 and 265 bytes into a destination of size 256
snprintf(fname, sizeof(fname), "%s\\file.dat", dname);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../source4/torture/smb2/session.c:696:38: error: ‘\file2.dat’ directive output may be truncated writing 10 bytes into a region of size between 1 and 256 [-Werror=format-truncation=]
snprintf(fname2, sizeof(fname2), "%s\\file2.dat", dname);
^~~~~~~~~~~
../source4/torture/smb2/session.c:696:2: note: ‘snprintf’ output between 11 and 266 bytes into a destination of size 256
snprintf(fname2, sizeof(fname2), "%s\\file2.dat", dname);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b6dc8f504c406ed8a044e5becca7e8f01da6c84">9b6dc8f5</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-05-17T15:30:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-utils: fix format-truncation in smbpasswd
../source3/utils/smbpasswd.c: In function ‘process_root’:
../source3/utils/smbpasswd.c:414:37: error: ‘$’ directive output may be truncated writing 1 byte into a region of size between 0 and 255 [-Werror=format-truncation=]
slprintf(buf, sizeof(buf) - 1, "%s$", user_name);
^
In file included from ../source3/include/includes.h:23,
from ../source3/utils/smbpasswd.c:19:
../lib/replace/../replace/replace.h:514:18: note: ‘snprintf’ output between 2 and 257 bytes into a destination of size 255
#define slprintf snprintf
../source3/utils/smbpasswd.c:414:3: note: in expansion of macro ‘slprintf’
slprintf(buf, sizeof(buf) - 1, "%s$", user_name);
^~~~~~~~
../source3/utils/smbpasswd.c:397:35: error: ‘$’ directive output may be truncated writing 1 byte into a region of size between 0 and 255 [-Werror=format-truncation=]
slprintf(buf, sizeof(buf)-1, "%s$", user_name);
^
In file included from ../source3/include/includes.h:23,
from ../source3/utils/smbpasswd.c:19:
../lib/replace/../replace/replace.h:514:18: note: ‘snprintf’ output between 2 and 257 bytes into a destination of size 255
#define slprintf snprintf
../source3/utils/smbpasswd.c:397:3: note: in expansion of macro ‘slprintf’
slprintf(buf, sizeof(buf)-1, "%s$", user_name);
^~~~~~~~
cc1: some warnings being treated as errors
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7cec343a89a0862c09f5ddd4707eb442157a4af2">7cec343a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-17T15:30:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Fix string check in mkdir_p()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a00d90d668f53914ffe035c41a5e79e60b51521">7a00d90d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-17T15:30:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use strlcpy() in gen_name()
../source4/torture/basic/mangle_test.c: In function ‘gen_name’:
../source4/torture/basic/mangle_test.c:148:3: error: ‘strncpy’ output
truncated before terminating nul copying 5 bytes from a string of the
same length [-Werror=stringop-truncation]
strncpy(p, "ABCDE", 5);
^~~~~~~~~~~~~~~~~~~~~~
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff7568daaeb19ff30f47f7f600ead247eaf4e826">ff7568da</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-17T15:30:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Use memcpy() in escape_ldap_string()
../source3/lib/ldap_escape.c: In function ‘escape_ldap_string’:
../source3/lib/ldap_escape.c:79:4: error: ‘strncpy’ output truncated
before terminating nul copying 3 bytes from a string of the same length
[-Werror=stringop-truncation]
strncpy (p, sub, 3);
^~~~~~~~~~~~~~~~~~~
We concatenat and do not care about NUL-termination till the loop has
finished.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/728297ca889b39ce2006778bf6a5bf1c3ce82d6d">728297ca</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-17T15:30:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:passdb: Fix size of ascii_p16
../source3/passdb/pdb_smbpasswd.c: In function ‘mod_smbfilepwd_entry’:
../source3/passdb/pdb_smbpasswd.c:1015:7: error: ‘:LCT-’ directive
output may be truncated writing 5 bytes into a region of size between 0
and 255 [-Werror=format-truncat ion=]
"%s:LCT-%08X:",
^~~~~
../source3/passdb/pdb_smbpasswd.c:1015:4: note: using the range [0,
4294967295] for directive argument
"%s:LCT-%08X:",
^~~~~~~~~~~~~~
In file included from ../source3/include/includes.h:23,
from ../source3/passdb/pdb_smbpasswd.c:23:
../lib/replace/../replace/replace.h:514:18: note: ‘snprintf’ output
between 15 and 270 bytes into a destination of size 255
#define slprintf snprintf
../source3/passdb/pdb_smbpasswd.c:1013:3: note: in expansion of macro ‘slprintf’
slprintf(&ascii_p16[strlen(ascii_p16)],
^~~~~~~~
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b728b87bf5726f14100d76956c3df3fd9bb1058">6b728b87</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-17T15:30:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Fix uninitialzed variable warning
Raised by GCC8.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f06a0154f5769cb85f6e189eecd78cd7805090a">6f06a015</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-17T15:30:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Fix parameter aliasing in tfork test
../lib/util/tests/tfork.c:483:24: error: passing argument 1 to
restrict-qualified parameter aliases with argument 4 [-Werror=restrict]
ret = pthread_create(&threads[i],
^~~~~~~~~~~
../lib/util/tests/tfork.c:486:10:
(void *)&threads[i]);
~~~~~~~~~~~~~~~~~~~
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fb6cd9c44ac6fcc9f6abe3b63fc742aeac42969a">fb6cd9c4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-17T15:30:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Fix size types in debug.c
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/609ef35c12900bbd5ecaa557f7b5d71b5784a103">609ef35c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-17T15:30:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:ntvfs: Fix string copy of share_name
../source4/ntvfs/ipc/rap_server.c:70:3: error: ‘strncpy’ specified bound 13 equals destination size [-Werror=stringop-truncation]
strncpy((char *)r->out.info[j].info1.share_name,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
snames[i],
~~~~~~~~~~
sizeof(r->out.info[0].info1.share_name));
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b7c8eb3907e2123acee67949e88c26072afc81a">8b7c8eb3</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-17T18:17:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Fix array size in audit_logging
../lib/audit_logging/audit_logging.c: In function ‘json_add_timestamp’:
../lib/audit_logging/audit_logging.c:603:12: error: ‘%s’ directive
output may be truncated writing up to 9 bytes into a region of size
between 0 and 43 [-Werror=format-truncation=]
"%s.%06ld%s",
^~
../lib/audit_logging/audit_logging.c:606:3:
tz);
~~
../lib/audit_logging/audit_logging.c:600:2: note: ‘snprintf’ output
between 8 and 70 bytes into a destination of size 50
snprintf(
^~~~~~~~~
timestamp,
~~~~~~~~~~
sizeof(timestamp),
~~~~~~~~~~~~~~~~~~
"%s.%06ld%s",
~~~~~~~~~~~~~
buffer,
~~~~~~~
tv.tv_usec,
~~~~~~~~~~~
tz);
~~~
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu May 17 20:17:35 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/48f72803f0e4a797af64bbb2417feb7179b1bcfb">48f72803</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-17T21:41:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: profile: Cleanup - we no longer use read/write/fsync syscalls.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/42aadf42f27053e621f2a6b72448afebb3f5082a">42aadf42</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-17T21:41:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix SMB2-FLUSH against directories.
Directories opened with either FILE_ADD_FILE or
FILE_ADD_SUBDIRECTORY can be flushed even if
they're not writable in the conventional sense.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13428
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d42f467a25e75e5487a00378609a24809ddc83ee">d42f467a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-18T00:38:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbtorture: Add new SMB2-DIR-FSYNC test to show behavior of FSYNC on directories.
Tests against a directory handle on the root of a share,
and a directory handle on a sub-directory in a share.
Check SEC_DIR_ADD_FILE and SEC_DIR_ADD_SUBDIR separately,
either allows flush to succeed.
Passes against Windows.
Regression test for:
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13428
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri May 18 02:38:50 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a52d0c3a14729b923f5488c67255ab069791b268">a52d0c3a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-05-18T03:24:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: Py2/Py3 misc replace range with enumerate
Replace various instances of xrange with enumerate.
Signed-off-by: Noel Power <noel.power@suse.com>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Fri May 18 05:24:42 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ec2a40831359ae93f437ef76f8ba76bbd95bc6dc">ec2a4083</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-18T17:03:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: make psbuf arg to make_default_acl_posix() const
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13175
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f93cc232377d4c686ac35ee5e14e798974bc0700">f93cc232</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-18T20:03:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_zfsacl: return synthesized ACL when ZFS return ENOTSUP
This allows accessing the ZFS .snapshots directory where ZFS returns
ENOTSUP when calling acl(".snapshots").
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13175
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri May 18 22:03:21 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e1ede0b1ffd128707bb4b5ae271c82cb8e2de26c">e1ede0b1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-21T21:48:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Use DBGC_AUTH as DBGC_CLASS for AD DC NTLM auth code.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8cd905d5751457de35010285793a191d10ecdb04">8cd905d5</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-21T21:48:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-drsuapi: Call security_token_debug() with DBGC_DRS_REPL and a proper log level
Selftest logs are full of calls to security_token_debug() with no context
and this is never a log level 0 event, so tidy it up.
The RODC would trigger this each time there is an attempted preload
of a user in the Denied RODC replication group.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/20fda4f600c46e73571709f718c78017b9b037a2">20fda4f6</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-22T00:42:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Use DBGC_AUTH as DBGC_CLASS for AD DC auth session code.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue May 22 02:42:32 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7049b2153b08152f03a0fcbb1817b430fe0a8451">7049b215</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-05-22T11:57:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">socket_wrapper: Add missing dependency on tirpc
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue May 22 13:57:07 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c8d7e4c8985ab08b8f5580c1d823cf6b54b273c7">c8d7e4c8</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-22T22:53:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Clean up ldb on tearDown from each packet in TrafficEmulatorPacketTests
Otherwise the LDB (and so the server resources) are in use until the end of the whole test
due to the way the objects are maintained in python for reporting.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed May 23 00:53:25 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ec491040c7fb7bf779a421fac900ea47a40d489">5ec49104</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-05-23T00:27:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mdb: Implement the lmdb backend for ldb
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e4e6d794ee667b84db9bb1f248bf5ed411e5f5be">e4e6d794</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-05-23T00:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mdb: Enable LDB_FLG_NOSYNC in ldb_mdb
This is used in selftest with 'ldb:nosync = true'.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/95d1e474cfe24ea65f3cd0bca82d531e6f56e363">95d1e474</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-05-23T00:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mdb: Store pid to change destructor on fork
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0d2d1e5bf07bb6c4f2ac741e0a0287a4eab523a7">0d2d1e5b</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-23T00:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mdb: Don't allow modify operations on a read only db
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a5a000b68ec8875bcc86217a6c32a97fc3d2723f">a5a000b6</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-23T00:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mdb/tests: Add tests to check for max key length and DB size
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53d9d4974dda96f2dcbaa29c78ef1407abfe1341">53d9d497</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-23T00:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mdb/tests: Run api and index test also on lmdb
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f9a12b6433f38cfab97c0057d0e9b0d5719d864a">f9a12b64</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-23T00:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mdb: Apply LMDB key length restrictions at key-value layer
We need to enforce the GUID index mode so end-users do not get a
supprise in mid-operation and we enforce a max key length of 511 so
that the index key trunctation is done correctly.
Otherwise the DB will appear to work until a very long key (DN or
index) is used, after which it will be sad.
Because the previous ldb_lmdb_test confirmed the key length by
creating a large DN, those tests are re-worked to use the GUID index
mode. In turn, new tests are written that create a special DN around
the maximum key length.
Finally a test is included that demonstrates that adding entries to
the LMDB DB without GUID index mode fails.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eb1bc2ec0922fe6b86140b1a1ee1f368d222646b">eb1bc2ec</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-23T00:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mdb: Wrap mdb_env_open
Wrap mdb_env_open to ensure that we only have one MDB_env opened per
database in each process
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/14f5c7522caa0006837658a156f090d8dd65bb0d">14f5c752</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-23T00:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mdb: handle EBADE from mdb_env_open
Under some circumstances mdb_env_open returns EBADE, we treat this as
indicating the file is not a valid lmdb format file.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/322e42818b144249084dc3a8d4f7988cd8fcab3e">322e4281</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-23T00:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mdb: prevent MDB_env reuse across forks
MDB_env's may not be reused accross forks. Check the pid that the lmdb
structure was created by, and return an error if it is being used by a
different process.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4dc44659dd290035a5500a13197e9fcee7d9a21b">4dc44659</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-23T00:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mdb: Use mdb_env_get_fd() to get the FD for fstat() and FD_CLOEXEC
This ensures we leave the FD behind if we exec() in a child process.
This deliberatly the same as TDB, as we want the same behaviour as
we have come to expect with that backend.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be335f1fbc8ec1c4fb7b329138e742e5f2403b77">be335f1f</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-23T00:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mdb/tests: Tests for wrap open
Tests to ensure that the mdb_env wrapping code correctly handles
multiple ldb's point to the same physical database file.
The test_ldb_close_with_multiple_connections tests are in
ldb_mod_op_test due to the utility code it uses from
elsewhere in that test.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d8919d2a59e64ebd8f4bfa7c78abfdf865662186">d8919d2a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-23T00:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mdb: Run the ldb_mdb_mod_op_test
ldb_mdb is now able to pass the full ldb_mod_op_test when compiled against lmdb.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65f6ce7a6e187ce45098b7fd88fdcda90b242837">65f6ce7a</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-23T00:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mdb: Remove implicit read lock and remove transaction counter
The way to know if we are in a transaction is if there is a non-NULL
transaction handle.
This allows the ldb_mdb_kv_ops_test test to be run.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/04884a80122fbaf83e60da57ec601585af198d99">04884a80</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-23T00:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mdb/tests: test large index key value
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aeeab1753e6d57cbfb352a3d698cda213ac6c6c9">aeeab175</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-23T00:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mdb/tests: add tests for multiple opens across forks
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/866af3270db8076898fb69bddd6f3699cac9e263">866af327</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-23T00:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Add MDB support to ldb://
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cb5da7a5c610875297a90be7f0b8bcde620990f1">cb5da7a5</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-23T00:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Reject a possible future ldb_mdb with the index in a sub-database
This ensures we do not corrupt such an index by making changes to the
main database without knowing that the index values are now in a
sub-database.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/39b7f1bcf0d3eaf6308b3ebf88e57f52c0d4a68a">39b7f1bc</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-23T00:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb-samba: Handle generic mdb:// url scheme in ldb_relative_path()
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1118fc3b2608469e6086802be9e6b2065462770f">1118fc3b</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-23T00:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Run ad_dc and vampire_dc with --backend-store=mdb
This ensures the LMDB backend is tested in make test
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/754a840946cae308fb97a2927ea263e29de9e7b4">754a8409</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-23T03:11:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: build ldb --without-ldb-lmdb
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed May 23 05:11:13 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c42d3f7165e7532cd95645b7b27173a32fa53df">4c42d3f7</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-23T04:55:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Add msDS-ResultantPSO constructed attribute support
Add support for the msDS-ResultantPSO constructed attribute, which
indicates the PSO (if any) that should apply to a given user. First we
consider any PSOs that apply directly to a user. If none apply directly,
we consider PSOs that apply to any groups the user is a member of. (PSO
lookups are done by finding any 'msDS-PSOAppliesTo' links that apply to
the user or group SIDs we're interested in.
Note: the PSO should be selected based on the RevMembGetAccountGroups
membership, which doesn't include builtin groups. Looking at the spec,
it appears that perhaps our tokenGroups implementation should also
exclude builtin groups. However, in the short-term, I've added a new
ACCOUNT_GROUPS option to the enum, which is only used internally for
PSOs.
The PSO test cases (which are currently only checking the constructed
attribute) now pass, showing that the correct msDS-ResultantPSO value is
being returned, even if the corresponding password-policy settings are
not yet being applied.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f82161caf299059c6d35bf28b9dfd8c1e4ddb30">6f82161c</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-23T04:55:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Extend PSO tests to cover password-history/length/complexity
Unhobble the PSO test cases so that they not only check the
msDS-ResultantPSO constructed attribute, but also that the corresponding
PSO's password-history, minimum password length, and complexity settings
are actually used.
The tests now fail once more, as actually using the PSO's settings isn't
implemented yet.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/442a38c918ae1666b35285013365553b39837f14">442a38c9</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-23T04:55:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb/auth: Use PSO settings for lockOutThreshold/Duration
If a PSO applies to a user, use its lockOutThreshold/Duration settings
instead of the domain setting. When we lookup a user, we now include the
msDS-ResultantPSO attribute. If the attribute is present for a user,
then we lookup the corresponding PSO object to get the lockOutThreshold/
Duration settings.
Note: This is not quite enough to make the PSO lockout tests pass, as
msDS-User-Account-Control-Computed is still constructed based on the
domain lockoutDuration setting rather than the PSO.
Updating the password_hash.c code properly will be done in a subsequent
commit.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5246d480b1e3aba4921b27293f2573bbee380570">5246d480</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-23T04:55:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: PSO support for msDS-User-Account-Control-Computed
msDS-User-Account-Control-Computed uses the effective-lockoutDuration to
determine if a user is locked out or not. If a PSO applies to the user,
then the effective-lockoutDuration is the PSO's msDS-LockoutDuration
setting. Otherwise it is the domain default lockoutDuration value.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/706070274da9054bd0fbd7732b8304dee1d30f20">70607027</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-23T04:55:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb/rpc: Update effective badPwdCount to use PSO settings
The lockOutObservationWindow is used to calculate the badPwdCount. When
a PSO applies to a user, we want to use the PSO's lockout-observation
window rather the the default domain setting.
This is finally enough to get some of the PSO password_lockout tests
to pass.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/05e25a728c9260fe1696500ed26a7c4f9ad85c57">05e25a72</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-23T04:55:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpc/samr: Fix PSO support in SAMR password_change RPC
To get the SAMR password_lockout test passing, we now just need to query
the msDS-ResultantPSO attribute for the user in the SAMR code. The
common code will then determine that a PSO applies to the user, and use
the PSO's lockout settings.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e40af276f8d0eb8fd7e38094101b1874177ea6b0">e40af276</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-23T04:55:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Lookup PSO's lockout settings for password_hash modifies
When a user's password-hash is modified, we need the PSO settings for
that user, so that any lockout settings get applied correctly.
To do this, we query the msDS-ResultantPSO in the user search. Then, if
a PSO applies to the user, we add in a extra search to retrieve the
PSO's settings. Once the PSO search completes, we continue with the
modify operation.
In the event of error cases, I've tried to fallback to logging the
problem and continuing with the default domain settings. However,
unusual internal errors will still fail the operation.
We can pass the PSO result into dsdb_update_bad_pwd_count(), which means
the PSO's lockout-threshold and observation-window are now used. This is
enough to get the remaining lockout tests passing.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0ac464df4543154ee8a1cbf03684d8b99bcb92b3">0ac464df</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-23T04:55:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Move anonymous domain_data struct
Anonymous structs and 80 character line-lengths don't mix well. Allow
the struct to be referenced directly.
With the introduction of PSOs, the password-settings are now calculated
per-user rather than per-domain. I've tried to reflect this in the
struct name.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3b849f87f7237a3677338075309abb1355a4d9ef">3b849f87</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-23T04:55:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Update password_hash to use PSO settings for password changes
Honour the settings in the PSO when changing the password, i.e.
msDS-PasswordComplexityEnabled, msDS-PasswordHistoryLength, etc.
The password_hash code populates dsdb_control_password_change_status's
domain_data with the password settings to use - these are currently
based on the settings for the domain.
Now, if the password_hash code has worked out that a PSO applies to the
user, we override the domain settings with the PSO's values.
This change means the password_settings tests now pass.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1ebfe6957fd8995e7c7690c842e196e6c649b6db">1ebfe695</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-23T04:55:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Use PSO maxPwdAge for operational msDS-PasswordExpiryTimeComputed
When calculating the Password-Expiry-Time, we should use the PSO's
max-password-age setting, if one applies to the user.
This is code may be inefficient, as it may repeat the PSO-lookup work
several times (once for each constructed attribute that tries to use
it). For now, I've gone for the simplest code change, and efficiency can
be addressed in a subsequent patch (once we have a good test to measure
it).
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de131c16a6b8505f8f11783537e9490554de44b2">de131c16</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-23T04:55:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Add samba-tool support for managing PSOs
Add a new command 'samba-tool domain passwordsettings pso', with the
sub-command options: create, delete, set, list, show, show-user, apply,
unapply. The apply and unapply options apply the PSO to a user or group.
The show-user option shows the actual PSO (and its settings) that will
take effect for a given user.
The new commands are pretty self-contained in a new pso.py file. We
decided to add these new commands under the existing 'samba-tool domain
passwordsettings' command, as that's what users would be already
familiar with.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c10e1af005270d6d212f8e703d0fb7c5ff3430bc">c10e1af0</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-23T04:55:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Extend passwordsettings tests to cover PSO command options
Add test cases for the new PSO samba-tool command options.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b7d1c5aae8530126f1e561911ae3adaa527c189f">b7d1c5aa</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-23T04:55:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add tests for domain pwdHistoryLength
This is not related to PSOs at all, but there's a minor discrepancy
between Windows and Samba password-history-length behaviour that I
noticed during PSO testing.
When the pwdHistoryLength changes from zero to non-zero, Windows
includes the user's current password as invalid immediately, whereas
Samba only includes it as invalid *after* it next changes. It's a
fairly obscure corner-case, and we might not care enough about it to
fix it. However, I've added a test case to highlight the difference and
marked it as a known-fail for now.
I also added a general pwdHistoryLength test case to show that the
basics work (this didn't seem to be tested anywhere else).
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3779367329646215065e1608ef065930b581e854">37793673</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-23T04:55:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Avoid performance hit if PSOs aren't actually used
The new PSO code adds some additional overhead in extra lookups. To
avoid penalizing existing setups, we can short-circuit the PSO
processing and return early if there are no actual PSO objects in the
DB. The one-level search should be very quick, and it avoids the need to
do more complicated PSO processing (i.e. expanding the nested groups).
The longer-term plan is to rework the tokenGroups lookup so that it only
gets done once, and the result can then be reused by the resultant-PSO
code (rather than computing the nested-groups again). However, in the
short-term, a slight decrease in performance is the price for any users
that want to deploy PSOs.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2fa2f132ae3de9a403b2d93d586570f59250de23">2fa2f132</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-23T08:09:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Avoid calculating the PSO multiple times
In a typical user login query, the code tries to work out the PSO 2-3
times - once for the msDS-ResultantPSO attribute, and then again for the
msDS-User-Account-Control-Computed & msDS-UserPasswordExpiryTimeComputed
constructed attributes.
The PSO calculation is reasonably expensive, mostly due to the nested
groups calculation. If we've already constructed the msDS-ResultantPSO
attribute, then we can save ourselves extra work by just re-fetching the
result directly, rather than expanding the nested groups again from
scratch.
The previous patch improves efficiency when there are no PSOs in the
system. This should improve the case where there are PSOs that apply to
the users. (Unfortunately, it won't help where there are some PSOs in
the system, but no PSO applies to the user being queried).
Also updated sam.c so the msDS-ResultantPSO gets calculated first,
before the other constructed attributes.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Wed May 23 10:09:11 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2db4cb3596d1dc79a861f6f2be4ef0aeefd00f0f">2db4cb35</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-23T19:22:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci: Include system-info.txt to give info on possible failures
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a092a6650017290efd80eb73bdfc3a09be95f025">a092a665</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-23T19:22:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci: Do not hide a possible out-of-space condition by cleaning up the tree
These are VMs anyway and will soon vanish, so a cleanup is totally wasted in any case.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e11fabbfaf201e733cee7d39559714fb4a18c17">0e11fabb</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-23T22:42:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Include information of disk free in system-info.txt
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu May 24 00:42:48 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ca01643c92a2f96268a39ac27ba2b1ed3422dede">ca01643c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-23T22:43:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Fix CID 1435740 Unchecked return value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b013aa31bf8942fcc46f75d5ffdbcbebf8e7b1b">8b013aa3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-23T22:43:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">audit_logging: Fix CID 1435739 Dereference null return value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c8b4f31105bdbc3186c310eb2535af30f7c00c62">c8b4f311</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-23T22:43:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdbd: Fix CID 1435732 Argument cannot be negative
setenv returns its error in "errno"
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/312faa0b82b9aca6ebd205921266859aa531d94b">312faa0b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-23T22:43:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldap_server: Fix CID 1435731 Unchecked return value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3aae048a43b1987eb2e60de988a8d4c180bfd6f6">3aae048a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-23T22:43:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kdc: Fix CID 1435720 Unchecked return value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/291630126d3358c22bc88d98e5e35c274e6af29d">29163012</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-24T01:35:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldap_server: Fix CID 1435721 Unchecked return value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu May 24 03:35:00 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4bbc5a872192191810e8297967a26a73a09ff2c1">4bbc5a87</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-24T09:29:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Make sure we have correct group mappings
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13369
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 9bc2b922bbc6539341a2056f33f117ac350e61f1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ee22c6fb26182d8f8aca7f82b9b85debe864b3b2">ee22c6fb</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-24T09:29:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Add a test looking up the user using the upn
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13369
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 0d2f743d826b87b369e25fc6bb9ff61f2b0896aa)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a28d7c4110f74f615a2ca7ba7e67db3a74ce3ff0">a28d7c41</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-24T09:29:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Add a test looking up domain sid
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13369
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 0aceca6a94e868f9c01a66f79624ca10d80560ab)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/40a13413eb27f261d608c8071f86175c77e31ce4">40a13413</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-24T09:29:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Lookup the domain in tests with the wb seperator
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 4fa811ec7bc301e96f5e40ba281e8d4e8709b94f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c946ebf9f4141db5e2b6eec6a9912919e712874">5c946ebf</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-24T09:29:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add a user with a different userPrincipalName
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13369
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 5319cae00096dcecc29aa9fa675a983352ad64d8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a52b06751c2dec3d3b04be2b1a969fad24f86a7b">a52b0675</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-24T09:29:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch:tests: Add test for wbinfo --user-info
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13369
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 2715f52f54e66a73131a92d752a8c2447da1fd33)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f1dfb9fe576840cc13163738e59dbe0f39ec6eec">f1dfb9fe</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-05-24T09:29:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Pass upn unmodified to lookup names
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13369
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 789c89e6ecb7d388fb5acdd5abc8fe99c58524f0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b5ba5da438c415d2542434e95463bad4519e6310">b5ba5da4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-24T09:29:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Remove unused function parse_domain_user_talloc()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 32770e929ace8fe3f2469037ed887be14b3c5503)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/124f0e4bdaabd082cffc403b747a8f5eb2b2a4ef">124f0e4b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-24T09:29:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Fix UPN handling in parse_domain_user()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13369
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit a05b63db627fdbe0bdea4d144dfaeedb39025592)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/682a2e265690c3ff8ad52d5ddb24f13b636d31b6">682a2e26</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-24T09:29:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Fix UPN handling in canonicalize_username()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13369
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri May 11 12:02:37 CEST 2018 on sn-devel-144
(cherry picked from commit 1766f77493c5a76e4d7d1e5eedcaa150cc9ea552)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6ea5d164cd9d836cbd36aa43fa2b7f4b270a68f3">6ea5d164</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-24T09:29:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/smb2: new test for interaction between chown and SD flags
This passes against Windows, but fails against Samba.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13432
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 12f6d56c4814fca64e0e3c636018e70d71ad0be5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bcee54726fadd76ee1588c15b29066f66ad9c1c0">bcee5472</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-24T09:29:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: fix interaction between chown and SD flags
A change ownership operation that doesn't set the NT ACLs must not touch
the SD flags (type).
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13432
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri May 11 23:30:32 CEST 2018 on sn-devel-144
(cherry picked from commit ced55850034a3653525823bf9623912a4fcf18a0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2fb77a2b736308c019b7560315ce78c017f6495c">2fb77a2b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-24T14:37:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libgpo: Fix the build --without-ads
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Tue Feb 6 15:36:01 CET 2018 on sn-devel-144
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13331
(cherry picked from commit a222b7506b53e689708834237f18877231dca589)
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Thu May 24 16:37:02 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9084dce29d9e0e76a3485edfca26add361988ba">a9084dce</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-05-24T16:07:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Remove double error check
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Thu May 24 18:07:03 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c354cd551715e98b9d016be6f1c6bc02a931192">4c354cd5</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-25T08:01:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Give extra information on WINBINDD_SHOW_SEQUENCE failure
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/95c117ff1114122aad367adab6c738b835a7c3d3">95c117ff</a></strong>
<div>
<span>by Timur I. Bakeyev</span>
<i>at 2018-05-25T08:01:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Make ldb configuration --disable-python work as intended
Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e9b638c43f006bd48158f21fc9b598c61d615499">e9b638c4</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-25T11:07:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: cover the Gentoo case with python disabled all down the stack
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri May 25 13:07:47 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ae196c5063c9b55fd5991da585fb01b5a95d96ed">ae196c50</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-25T11:08:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_time_audit: Fix a log message
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/33d1ac8546e54a3f1eb30ed9ee0ac8f405ecc80e">33d1ac85</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-25T14:00:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Call smbXsrv_client_global_init in the parent smbd
Otherwise we're missing the clear-if-first optimization for
smbXsrv_client_global.tdb.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri May 25 16:00:08 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a6c03f2a9b21f445ddfda71c5d3619b759093ed3">a6c03f2a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove existing_unx_mode, an unused parameter to open_match_attributes().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/41ee89b2ec76c289dfa5d481870aada27516cf1e">41ee89b2</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Add clarifying comment on mode change on overwritten files.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d03e9a861e207c8c0204e4f76cb4bdaec711f923">d03e9a86</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove use of SMB_VFS_FCHMOD_ACL() in overwrite case.
We have potentially called SMB_VFS_FCHMOD() here in
the file_set_dosmode() call associated with the comment
/* Overwritten files should be initially set as archive */
at line 3755 above, so there is no need to do any POSIX ACL
mask protection.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4f6c71ae886f65c120e628403e24970f0d126fc5">4f6c71ae</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: optimization. Only do the FCHMOD call if needed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2f4e581c3d103633c96cdec35b0a9e7c9d2ae042">2f4e581c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Optimization. Only do the FCHMOD_ACL call if mode bits not equal.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aaed6b4e995bb95fdc3ca6e768e84d14b3a3e446">aaed6b4e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Use FCHMOD call, not FCHMOD_ACL call if mode bits reset needed.
This is a behavior change, it will modify the POSIX ACL mask
from a value of rwx instead of modifying the existing ACE
entries to be ANDed with the passed in mode. However it
will have no effect on the underlying permissions, and
better reflects the proper use of POSIX ACLs (i.e. I
didn't understand the use of the mask entry in the
ACL when I first wrote the POSIX ACL code).
In addition, the vfs_acl_common.c module already
filters these calls for all but POSIX opens, which
means the only place this change is exposed to the
client would be a cifsfs unix extensions client doing
posix acl calls (and they would expect the mask to
be set like this on chmod).
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/90117f25bf10ea47f1bc02c22dc41f2a560d57eb">90117f25</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: modules: vfs_default: Remove CHMOD_ACL in mkdir.
Now I understand the use of the mask in POSIX ACLs
this extra step is no longer needed. If the mkdir
succeeded it's already set the correct mode.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c5060e1ad5fedb26f66bb9da479d46a4b576b9bc">c5060e1a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: modules: vfs_default: Remove CHMOD_ACL in chmod.
Now I understand the use of the mask in POSIX ACLs
this extra step is no longer needed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d50bb46038b4d2c81b2e9623c5b678206856bccd">d50bb460</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: modules: vfs_ceph: Remove CHMOD_ACL in cephwrap_mkdir().
Now I understand the use of the mask in POSIX ACLs
this extra step is no longer needed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b8477abbdefade3e7c005f77cc8aaf7da1bcc25a">b8477abb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: modules: vfs_ceph: Remove CHMOD_ACL in cephwrap_chmod().
Now I understand the use of the mask in POSIX ACLs
this extra step is no longer needed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d3059cd7415c8da429f1f18cc562c6d138d77cf">7d3059cd</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Remove cmd_chmod_acl().
No longer needed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b8fa17f06b2e401584f9d3290d9c14ad120ce39">7b8fa17f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Remove SMB_VFS_CHMOD_ACL().
No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c65f6b8331c064e6f15003ffd8c7b8e5a5f0b6d">0c65f6b8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: modules: vfs_default: Remove FCHMOD_ACL in fchmod.
Now I understand the use of the mask in POSIX ACLs
this extra step is no longer needed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/55f013edbb10cf68289ea23f674af617edcc12ad">55f013ed</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: modules: vfs_ceph: Remove FCHMOD_ACL in cephwrap_fchmod().
Now I understand the use of the mask in POSIX ACLs
this extra step is no longer needed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a3d7544b8c9e31f06de347049757f833afa4c8e5">a3d7544b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Remove cmd_fchmod_acl().
No longer needed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5bbb8310417563b17d83bb9ea9d08940d26e90e1">5bbb8310</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Remove SMB_VFS_FCHMOD_ACL().
No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cfbe3048afbb6557852b7f887c32f10bf283e7ae">cfbe3048</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: posix_acls: Remove dead functions fchmod_acl()/chmod_acl().
No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a41155b005684debe8e2e17e4a97826e78702fa4">a41155b0</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: posix_acls: Remove unused 'connection_struct *conn' parameter to map_acl_perms_to_permset().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/109d94d15e9c3b6606551c62ec6ec97acb821e82">109d94d1</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Make unix_perms_to_acl_perms() extern.
The vfs_fake_acl module will need it to implement chown/fchown.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e85a662eea4122bdc78ee2c6339623e9728d1b1b">e85a662e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T16:39:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Make map_acl_perms_to_permset() extern.
The vfs_fake_acl module will need it to implement chown/fchown.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/52778afdab31c8315a498544b6b11312c8625bb6">52778afd</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-05-25T19:29:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs_fake_acls: Correctly implement the chmod/fchmod algorithm on fake acls.
We now pass samba3hide(nt4_dc), so remove it from knownfail.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri May 25 21:29:32 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ffcbd5ce1222971cb9879f78765d87cdc4102a8">7ffcbd5c</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-05-25T20:52:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add dfq_cache share with 'dfree cache time' set
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a55b3d2fcc2f7737a2702bf908dcf1f80969bf21">a55b3d2f</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-05-25T20:52:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add test for 'dfree cache'
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f5d05562679f6aa691b98b4a75952f7dda7ed343">f5d05562</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-05-25T20:52:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">memcache: Add new cache type for dfree information
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8f121747b06ca78cf51801a3931b2ddd1a424c77">8f121747</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-05-25T20:52:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Cache dfree information based on query path
Sub directories in a SMB share can have different free space information
(e.g. when a different file system is mounted there). Caching the dfree
information per SMB share will return invalid data. Address this by
switching to memcache and store the cached data based on the query path.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e30d0c0e0d11f65b2d1886be3c0fe9e32eaf3926">e30d0c0e</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-05-25T20:52:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Flush dfree memcache on service reload
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a79a61abb08719acde6aec8df9356be36d8dda2">9a79a61a</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-05-25T20:52:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Move dfree_info struct
As the struct is no longer used as part of connection_struct, move it to
dfree.c.
This is not backported, as it would change the VFS ABI.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/01a6aef52227e0f029fa107140e670d8af45ad59">01a6aef5</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-05-25T20:52:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Adjust debug level when get_winattrs returns EBADF
This is returned for a get_winattrs call against a non-gpfs file system.
This can happen for the .. entry when listing a share on the file system
root.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a29a949ac45fab55b8c41dcbe11a5e07fd62c05">4a29a949</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-05-25T20:52:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Remove wrong get_full_smb_filename from ntimes function
Updating the timestamps requires the path to the file, but no stream
information.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1843a2d63259c819eb7a6eefa7f4ab8c46efec37">1843a2d6</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-05-25T20:52:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Remove get_full_smb_filename from is_offline check
No stream information is required here.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1531fcde8252efcb2f69dd5462beb83786bb1135">1531fcde</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-05-25T23:43:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Use full_path_tos instead of talloc_asprintf
full_path_tos avoids the talloc call for most cases; use that instead of
talloc_asprintf.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat May 26 01:43:09 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f052b6057294baed1fdf0e916200d3f653bba8ca">f052b605</a></strong>
<div>
<span>by Kai Blin</span>
<i>at 2018-05-28T14:16:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: Fix some typos in the comments
Now with even more typos fixed. Thanks Rowland.
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Rowland Penny <rpenny@samba.org>
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Mon May 28 16:16:17 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e56b92bd95a586181625df8b5e198c3d560eceba">e56b92bd</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-29T00:31:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Cope with WINBINDD_SHOW_SEQUENCE failure for fake trusts
This test has been flapping and we should not be checking the
sequence number of remote trusts in a loop like this. We can write
a test against the trusts we specifically set up if we want to check
remote sequence numbers (and connectivity) against actually working
domains.
When flapping the previous version of the test gave:
WARNING!: ../source4/torture/winbind/struct_based.c:812: WINBINDD_SHOW_SEQUENCE returned 0, expected 1: WINBINDD_SHOW_SEQUENCE
WARNING!: WINBINDD_SHOW_SEQUENCE on domain torturedom failed
Trust list for WINBINDD_SHOW_SEQUENCE was:
BUILTIN
S4MEMBER
SAMBADOMAIN
torturedom
WARNING!: ../source4/torture/winbind/struct_based.c:812: WINBINDD_SHOW_SEQUENCE returned 0, expected 1: WINBINDD_SHOW_SEQUENCE
WARNING!: WINBINDD_SHOW_SEQUENCE on domain TORTURE302 failed
Trust list for WINBINDD_SHOW_SEQUENCE was:
BUILTIN
S4MEMBER
SAMBADOMAIN
TORTURE302
TORTURE306
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue May 29 02:31:40 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b8e51a8174682149bd8381163a6f1a4658da6271">b8e51a81</a></strong>
<div>
<span>by William Brown</span>
<i>at 2018-05-29T03:34:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd/{forest.py,main.py}: add configuration controls
With samba-tool we should expose ways to easily administer and control
common configuration options. This adds the base framework for modifying
forest settings, generally stored in cn=configuration partition.
An example is:
samba-tool forest directory_service show
samba-tool forest directory_service dsheuristics X
Signed-off-by: William Brown <william@blackhats.net.au>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/289ae87c3bb81b2e1cd30a876a3b694b7264edc5">289ae87c</a></strong>
<div>
<span>by William Brown</span>
<i>at 2018-05-29T03:34:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd/group.py: add group show
The samba-tool user command can show the ldif of a user. This is
useful for groups also, especially to determine the objectSID and
objectGUID. Add support for group show to samba-tool.
Signed-off-by: William Brown <william@blackhats.net.au>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/74d85d4cc246458f51ec9b264310959055f0a0b9">74d85d4c</a></strong>
<div>
<span>by William Brown</span>
<i>at 2018-05-29T03:34:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd/schema.py: add schema query and management.
Schema management in active directory is complex and dangerous. Having
a tool that safely wraps administrative tasks as well as allowing query
of the schema will make this complex topic more accessible to administrators.
Signed-off-by: William Brown <william@blackhats.net.au>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2c65184270500dc99b1697af6e830d62093a627f">2c651842</a></strong>
<div>
<span>by William Brown</span>
<i>at 2018-05-29T03:34:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd/schema.py: add schema show_oc for attribute
Often administrators need to add a specific attribute to an object, but
it may not be possible with the objectClasses present. This tool allows
searching "what objectclasses must or may?" take an attribute to help hint
to an administrator what objectclasses can be added to objects to achieve
the changes they want.
Signed-off-by: William Brown <william@blackhats.net.au>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4b1a86235ba454b0e5e27ca621d87c8644b2a98c">4b1a8623</a></strong>
<div>
<span>by William Brown</span>
<i>at 2018-05-29T03:34:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests/samba_tool/schema.py: Improve schema command testing
Assert the correct stdout content of the schema test commands.
Signed-off-by: William Brown <william@blackhats.net.au>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5b8620307edfd2897dd61c7e860d95662c547ecc">5b862030</a></strong>
<div>
<span>by William Brown</span>
<i>at 2018-05-29T06:30:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd/schema.py: samdb schema update now
When we change schema values, we should trigger a schema update to refresh
the changes applied. This is called after a change is made. A helper to
samdb is added so that it's easier for other locations to call additionally.
Signed-off-by: William Brown <william@blackhats.net.au>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue May 29 08:30:52 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2729b4329af0ad0b6a8bd188450b8abd76670d8a">2729b432</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-29T21:37:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: decrease large resource fork size in test from 1 GB to 64 MB
64 MB is a more realistic value and lets the test pass on FreeBSD with
fruit:resource=stream and vfs_streams_xattr.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cf5d471544f0cb0d072e4af1ee36798580d32897">cf5d4715</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-29T21:37:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: test setting EOF of a stream to 0 with enabled AAPL extensions
macOS SMB server uses xattrs as storage backend for streams, directly
exposing xattr get/set characteristics. Setting EOF on a stream to 0
just deletes the xattr as macOS doesn't support 0-byte sized xattrs.
Note that this does not apply to the AFP_AfpInfo and AFP_Resource
streams, they have even stranger semantics and we have other tests
for those.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13441
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/46d127865f3fb14041797d395db3b3234ed3bd6c">46d12786</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-30T00:34:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: delete 0 byte size streams if AAPL is enabled
macOS SMB server uses xattrs as storage backend for streams, directly
exposing xattr get/set characteristics. Setting EOF on a stream to 0
just deletes the xattr as macOS doesn't support 0-byte sized xattrs.
Note that this does not apply to the AFP_AfpInfo and AFP_Resource
streams, they have even stranger semantics and we have other tests
for those.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13441
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed May 30 02:34:29 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/04e3c4bea2d15aecd88e318573fe563c722dbc28">04e3c4be</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Reset error string before running prepare_commit() hook
This ensures that the error string returned to the caller reflects a failure in this call.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/400abe837c43953bc6e94e98941c4d9a23d365f2">400abe83</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-repl: Try to give more information in the error codes for prepare_commit failure.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9564adb66fb91ab32ee9249409498989ce725286">9564adb6</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">repl_meta_data: Remove el_count from replmd_delete_internals()
Instead, use the actual found attribute (less error prone).
This is an attempt to fix:
./source4/dsdb/repl/replicated_objects.c:945 Failed to prepare commit of transaction:
attribute isDeleted: invalid modify flags on CN=g1_1527558311141,CN=Users,DC=samba,DC=example,DC=com: 0x0
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ea111471aff23c66ab9a62b4e3a4db25b7f5738">5ea11147</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">repl_meta_data: Cope with the strange but unusual case of isDeleted: FALSE in replmd_process_linked_attribute()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13448
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/642dd37d51d8fb69b04ec444a590550b1807a0d8">642dd37d</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-30T02:23:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Fix intermittent error in PSO test
Deleting a group fails if the primaryGroupID of a user is set to that of
the group. This can happen in the PSO tests, as we don't clear the
primaryGroupID before cleaning up. Normally it seems to work OK, but
this is relying purely on the subtree delete order.
Update the test to clear the primaryGroupID before the tearDown is
called, to make things more robust.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13448
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/95a9dbd1febe9d2db9b900945fa1d7dc08f33058">95a9dbd1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samldb: Add useful error string to explain why a group may not be deleted.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2dedd49ca3041970ffe02f9adf69fbbb3cee7a4c">2dedd49c</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samldb: Explain why the odd error code is expected.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/273c55e94912013160ffeb6394e4666d59a683fb">273c55e9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Rework BasicDeleteTests.test_all() into setUp() and a test
This will allow running multiple tests against the same tree. This tree
is very similar to the tree produced by the KCC test that simply does a
tree_delete, and I want to lock down the tree_delete behaviour.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13448
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/16a0582644800fecb52adad05f43014df5607314">16a05826</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Lock down the expected parents in BasicTreeDeleteTests
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13448
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d346e2ee6b154a0dcf4072a3fc1fd6007369a69d">d346e2ee</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Remove sort from subtree_delete and add comments.
The sort was written back when the module did not operate recursivly
over the tree. Now it is just confusing, so replace with useful
comments.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/41d8c563089ac67863c7e48df6a8c92a5724a1be">41d8c563</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">subtree_rename: Correct comments
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d02cd236dcbd8a44ecc85d1f7e95a48c95c0a479">d02cd236</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Save a copy of the index result before calling the callbacks.
Otherwise Samba modules like subtree_rename can fail as they modify the
index during the callback.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13452
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3632775d7ad31e06437ed76b8731d9895930caa1">3632775d</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Indicate that the ltdb_dn_list_sort() in list_union is a bit subtle.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9e143ee9b9f7be53c193cee3153f64c4dedc07e9">9e143ee9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Explain why an entry can vanish from the index
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/88ae60ed186c9c479722ad62d65a07d0c2e71469">88ae60ed</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: One-level search was incorrectly falling back to full DB scan
When no search filter is specified, the code falls back to using
'(|(objectClass=*)(distinguishedName=*)'. ltdb_index_dn() then failed
because matching against '*' is not indexed. The error return then
caused the code to fallback to a full-scan of the DB, which could have a
considerable performance hit.
Instead, we want to continue on and do the ltdb_index_filter() over the
indexed results that were returned.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13448
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e99c199d811e607e7867e7b40d82a1642226c647">e99c199d</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Add tests for when we should expect a full scan
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13448
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/439072d1997cc94b63d269e2760d70c7b1855f2f">439072d1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add test to show that sam.ldb does not do a full scan in startup
We should add some other more complex operations here.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13448
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e2eb5660a11cea215d39495844aa76ffb5a1a2e">4e2eb566</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Release ldb 1.4.0
* New LMDB backend (experimental)
* Comprehensive tests for index behaviour
* Enforce transactions for writes
* Enforce read lock use for all reads
* Fix memory leak in paged_results module.
We hold at most 10 outstanding paged result cookies
(bug #13362)
* Fix compiler warnings
* Python3 improvements
* Restore --disable-python build
* Fix for performance regression on one-level searches
(bug #13448)
* Samba's subtree_rename could fail to rename some entries
(bug #13452)
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ede668e8e24c86f0836dfa5740e76d8aca1e0824">ede668e8</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-30T02:23:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb partition.c: Make partition_copy_all aysnc.
partition_copy_all uses ldb_wait to wait for the update to the primary
partition to complete, when updating a special dn. If a module higher
up the chain inserts a callback, the code blocks in ldb_wait and does
not complete. This change replaces the ldb_wait logic with a callback.
Currently there is no code that triggers this bug, however the up coming
audit logging changes do trigger this bug.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6cce06f3be7bf8c76298ba643691baec32d8c87a">6cce06f3</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Make create_test_ou() return a ldb.Dn
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1eed8c079daef1d2c1ad2c952edecf3efe4fa140">1eed8c07</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Use samba.tests.create_test_ou() in repl_move tests
This may avoid some flapping tests by ensuring that each part of this
test runs in a unique namespace, no matter what may be left behind
or revived via replication.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/57149959277b92d7a97a3932a2809946a1e1cc8a">57149959</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-05-30T02:23:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Use samba.tests.create_test_ou() in replica_sync tests
This may avoid some flapping tests by ensuring that each part of this
test runs in a unique namespace, no matter what may be left behind
or revived via replication.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0196318a1d027f04ed27d7a05dbefa9ded863b24">0196318a</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-05-30T05:03:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Add log when ignoring a replicated object outside of partition
This is probably a note-worthy event for debugging purposes.
(Found while developing the domain rename functionality)
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed May 30 07:03:51 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa096ab70a466388a9947f73a525b2dcbb9821e5">aa096ab7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-30T17:10:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: run smb2.streams tests against a share with vfs_streams_xattr
The tests are currently only run against streams_depot, where stream IO
is handle based, compared to streams_xattr which is path
based. vfs_streams_xattr is also used much more in real world setups, so
we should run our tests against it.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13451
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/00d19bdab15102083b8ba395ede161824c898be1">00d19bda</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-30T17:10:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/smb2/streams: try to rename basefile while is has open streams
This tests the following:
- create a file with a stream
- open the the stream and keep it open
- on a second connection, try to rename the basefile, this should fail
with NT_STATUS_ACCESS_DENIED
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13451
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f166207fc0344b51879d863857055ab7ff36a09b">f166207f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-30T17:10:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: adjust test testing basefile rename to expect failure
Renaming a basefile that has open streams must fail with
NT_STATUS_ACCESS_DENIED.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13451
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/37e7ff05ab9443c0330e68f5c701ffecedf2d738">37e7ff05</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-30T17:10:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: add private option NTCREATEX_OPTIONS_PRIVATE_STREAM_BASEOPEN
This will be used to mark basefile opens of streams opens. This is
needed to later implement a function that can determine if a file has
stream opens.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13451
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd8cf54c79fe8536e34cde15801d60931cd47b8b">dd8cf54c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-30T17:10:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:locking: add file_has_open_streams()
This can be used to check if a file opened by fsp also has stream opens.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13451
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/465b7d07e5db787c3d6330371e5e42ecbb1b57b9">465b7d07</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-05-30T17:10:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: don't allow renaming basefile if streams are open
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13451
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/003f24ee43c733de6c625f708c2ae665d44d1d1f">003f24ee</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-05-30T19:46:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Fix resolv_wrapper config variables
It can't really matter in this case, but it removes confusion
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed May 30 21:46:53 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e646895d2d9097644cc005de1af6e10e2772ebd0">e646895d</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool visualize: group (and colour) DCs by site
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/07302fe03724b98e39f0beca5710b534bcb1582c">07302fe0</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool visualize tests: reduce noise on stdout
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bdc0681eaebab7bc930206c2d2db68d7ca132ad3">bdc0681e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool visualize ntdsconn: add --importldif option
This visualizes the NTDSConnections in an LDIF file exported via
`samba_kcc --exportldif`. This functionality is already available in a
roundabout way -- you can use `samba_kcc --import_ldif`, and use the
DB that generates. This just shortens the process.
The ldif import/export feature is useful for analysing AD networks
offsite without exposing too much sensitive data.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f52c19b807e4961a76fa652aa5b7f660625e65e">9f52c19b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool viusalize: mark RODCs in distance matrix
RODCs should not be replicating out, which means they look alarming
when they are working properly. We label them as RODCs to reminds users
that no outbound replication is expected.
This results in slightly rejigged output formatting.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f7e6902313f1422102a4c68803369af013ff038">7f7e6902</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool visualise: --xdot option for instant graphviz visualisation
This is a convenience for people who have xdot (and X11).
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/23001c2835a3d7e127ce54ffe7a9ef69bcadbf91">23001c28</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs replicate: make pseudo-method a real method
This function can't function without a cmd_drs_replicate class, so it might as well be inside
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/35ab60b82a32f9be18fa49f17a47781989f7cd66">35ab60b8</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs replicate: reformat drs_local_replicate method
line length.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e5d092ea54c0d1c45ba970ad6db96a89b0ade8ce">e5d092ea</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kcc.graph_utils: shift debug noise out of verify()
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c2cac449c89d34f50da98c6eb59442bf63b67477">c2cac449</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb/util: use parse_guid_string, not sscanf()
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2157e8d83e7d32e646e7054d969d6be59053378b">2157e8d8</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">util/charset/iconv: use read_hex_bytes rather than sscanf
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f9308648e9a675205ac57302aa6393a37723cddf">f9308648</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">util_str_hex: use array syntax in guid functions to document usage
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cd2365175f5e9d5b5e2725fecf07b3862d3923df">cd236517</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndr_misc: read syntax_id using strict util_str_hex functions
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/03bd7c20f0846d6b231573b310190d3e0a747f00">03bd7c20</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kcc graphs: site edges in colour, labeled with DNs
This makes it easy to see where the site edges objects are, and
what sites they refer too.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e62cc29b472e7b33d88ece1797eb142e995cfa5b">e62cc29b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kcc graph verifier: use __doc__ description for error explanation
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/105633d4e763d4574dca06cb8fc9cbdc7ede6e74">105633d4</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kcc graph verifiers: improve messages
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3a3929eee6de3c71647abc581d93e8722bbbbe7c">3a3929ee</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python kcc/graph_utils: don't debug in colour
this was somewhat useful during the initial development, but is wrong for a library
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3f67fb5e7e886fd62995b28d9566a59739c80da9">3f67fb5e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool dns cleanup_record: add missing verbose/quiet options
The code for using them is already there
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a3cc5ee85dd213b8a610eaaf2f6bc25316c7cbfa">a3cc5ee8</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: add -v to domain --verbose
Sometimes we accept -v for --verbose, sometimes we don't. Let's be a
bit more consistent.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/432719c6e5bc75557b305d481bb784e792dc807f">432719c6</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: add -v to drs --verbose
Sometimes we accept -v for --verbose, sometimes we don't. Let's be a
bit more consistent.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78fbe1ff3206261063e64fed524fd4cef8b52b90">78fbe1ff</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: be consistent in accepting -q for --quiet
Not all commands accept --quiet, and not all of those that do use it.
Some already accept -q, and it is not used anywhere for anything else.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/408447cc67204fcb06252e7711273a4dd65d3e09">408447cc</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs showrepl: remove unused search
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/81167c0198146e333cac96ef863acc80afacfa55">81167c01</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs: remove 'server' arg from commands without --server
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e58719d13cbaa16c9fa454d5653b4a7dd6915777">e58719d1</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-30T23:57:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/colour: add colourizing and switch functions
When samba.colour is first imported, the function
colour.c_BLUE("samba")
will give you the string "\033[1;34msamba\033[0m", which will show up
as blue on an ANSI terminal. If you then go:
colour.switch_colour_off()
colour.c_BLUE("samba")
the c_BLUE call will return the uncoloured string "samba".
This is so things like samba-tool can do this sort of thing:
if not os.isatty(self.outf):
switch_colour_off()
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8426c428ba2e7cc880392d6cf0e4bae4f603be3f">8426c428</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-05-31T02:34:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">sambatool: heuristics to decided whether colour is wanted
The easy cases are --color=yes and --color=no.
With --color=auto, we use color if it seems we're writing to a TTY.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu May 31 04:34:52 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f55986a59436b2194e86be24697370a33d6239f">9f55986a</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-31T07:54:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth tests: irpc remove "auth_event" name on completion
Remove the "auth_event" name on completion of tests to prevent issues
with tests using messaging.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fcbb3f31fea14798d8b20ae4a3ec034eef3711ba">fcbb3f31</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-31T07:54:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">cldap: clear remote address after cldap_dse_fill
Need to clear the remote address as the ldb handle is shared, and
changes made by internal processes would be logged as coming from the
last cldap requester
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d06ebf646c2a89d2b445f8d4ce85f9151886caa5">d06ebf64</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-31T07:54:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb acl: Copy dsdb_control_password_acl_validation into reply
Copy the dsdb_control_password_acl_validation into the reply so that it
is available to the audit_logging module. The audit logging module
uses it to differentiate between password change and reset operations.
We include it in the result for failed request to allow the logging of
failed attempts.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d48b5d5320807ef394d1d31c3f9e92b4955a4aea">d48b5d53</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-31T07:54:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpc_server: common routine to open ldb in system session
Add a function to open an ldb connection under the system session and
save the remote users session details in a ldb_opaque. This will allow
the audit logging to log the original session for operations performed
in the system session.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fe6e7ce2a21d81ff7622b53d3ec09743bc4ed89e">fe6e7ce2</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-31T07:54:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpc_server lsa: pass remote connection data
Ensure that the session details of the requesting user are available to
the audit logging module for the CreateSecret and OpenSecret operations.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/47a6fe2ea22551c1b8d11a17332244ebdd0f94fb">47a6fe2e</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-05-31T09:19:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update panic-action script message, samba-dbg renamed to samba-dbgsym (Closes: #900242)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/02991b4df91605bf1cb4841238b33a64d42eed43">02991b4d</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-05-31T10:35:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpc_server backupkey: pass remote connection data
Ensure that the requesting session data is passed to the audit logging
module for BackupKey requests.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu May 31 12:35:15 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a0d82b6948930506afd35c4d9fb7e7641adb8ba">7a0d82b6</a></strong>
<div>
<span>by Sachin Prabhu</span>
<i>at 2018-06-01T00:57:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-torture: add test for lease break after file unlink
When deleting a file, all leases granting handle caching lease to the
file should be recalled.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13458
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jun 1 02:57:46 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77e66b86db606ff135c8c76a95c5576feec0fa51">77e66b86</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-06-01T06:28:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib audit_logging: re-factor and add functions.
Re-factor the common calls to json_dumps DEBUGC and audit_message_send
into a separate function.
Add functions to retrieve json object and json array elements
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/48ad90d93be8d863ce4c1be7cab6f1d60ed61257">48ad90d9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-01T06:28:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/audit_logging: Make function prototypes look like the rest of Samba
The previous style is needed sometimes to avoid an 80-col limit, but
is not how most of Samba looks.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0f5f8f1312ee8c52d0a21f5435d92cc8543ef934">0f5f8f13</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-01T06:28:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/audit_logging: Remove #ifdef HAVE_JANSSON from audit_logging_test binary
Instead, we either build or do not build the entire binary.
This is much more likely to raise an error in make test if the build system
changes. The concern is that HAVE_JANSSON can go away and the tests just vanish.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d161aa3522576545d269208426bb0014ee2ab35f">d161aa35</a></strong>
<div>
<span>by Lukas Slebodnik</span>
<i>at 2018-06-01T09:10:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Fix memory leak on module context
Introduced in e8cdacc509016d9273d63faf334d9f827585c3eb
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13459
Signed-off-by: Lukas Slebodnik <lslebodn@fedoraproject.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Jun 1 11:10:24 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/82175c0b9101908b5b258b2e41f322bbfdb68a04">82175c0b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-01T09:28:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dnsupdate: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d3c82e686b18366ffa3db1cd4ed5c33bd3b0e86c">d3c82e68</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-01T09:28:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: Simplify logic a bit
We've done an early return if (!found_tsig) a few lines before.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d8acbe73d93d02887583c0f8d7c4dbff1638520a">d8acbe73</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-01T09:28:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: Simplify logic a bit
We don't need a separate boolean variable
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/341b470854abfc187a752721dcb684e9a91c2d13">341b4708</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-01T09:28:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: TALLOC_FREE already checks for !=NULL
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c56cd283f5796ea22e2cceb0d058473b8fe299fd">c56cd283</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-01T12:05:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: Check for talloc_memdup failure
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Jun 1 14:05:56 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/42f049858f2037aab5b2097036db3e0375fdbf30">42f04985</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-06-01T15:47:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Add DELETE-PRINT test.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13457
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/364175b359f018c8641359440fa07b0ea567b045">364175b3</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-06-01T18:32:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: printing: Re-implement delete-on-close semantics for print files missing since 3.5.x.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13457
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jun 1 20:32:03 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/44f3bf1f6351311b6ed8ad95c1da83df25b05d9b">44f3bf1f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-06-02T01:03:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Remove unused enum value.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Sat Jun 2 03:03:42 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e153636f1af2139e3a87e054a85ff94296cb0c0b">e153636f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-04T07:55:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/ntlmssp: add ntlmssp_client:ldap_style_send_seal option
This will be used to similate a Windows client only
using NTLMSSP_NEGOTIATE_SIGN without NTLMSSP_NEGOTIATE_SEAL
on an LDAP connection, which is indicated internally by
GENSEC_FEATURE_LDAP_STYLE.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13427
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 7f2bebf09cd8056b3f901dd9ff1fc9e9525f3e9d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7faa201daf4a716caeb1c5753bd507589a4dd550">7faa201d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-04T07:55:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:selftest: run test_ldb_simple.sh with more auth options
This demonstrates the broken GENSEC_FEATURE_LDAP_STYLE
handling in our LDAP server.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13427
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit fc1c5bd3be2c3f90eab2f31e43cf053f7ff13782)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9cb645981ca5176a2f64b2a30313871a6b724dc4">9cb64598</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-04T07:55:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/ntlmssp: fix handling of GENSEC_FEATURE_LDAP_STYLE as a server
This fixes "NTLMSSP NTLM2 packet check failed due to invalid signature!"
error messages, which were generated if the client only sends
NTLMSSP_NEGOTIATE_SIGN without NTLMSSP_NEGOTIATE_SEAL on an LDAP
connection.
This fixes a regession in the combination of commits
77adac8c3cd2f7419894d18db735782c9646a202 and
3a0b835408a6efa339e8b34333906bfe3aacd6e3.
We need to evaluate GENSEC_FEATURE_LDAP_STYLE at the end
of the authentication (as a server, while we already
do so at the beginning as a client).
As a reminder I introduced GENSEC_FEATURE_LDAP_STYLE
(as an internal flag) in order to let us work as a
Windows using NTLMSSP for LDAP. Even if only signing is
negotiated during the authentication the following PDUs
will still be encrypted if NTLMSSP is used. This is exactly the
same as if the client would have negotiated NTLMSSP_NEGOTIATE_SEAL.
I guess it's a bug in Windows, but we have to reimplement that
bug. Note this only applies to NTLMSSP and only to LDAP!
Signing only works fine for LDAP with Kerberos
or DCERPC and NTLMSSP.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13427
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed May 16 03:26:03 CEST 2018 on sn-devel-144
(cherry picked from commit c7a3ce95ac4ce837d8fde36578b3b1f56c3ac2fa)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c794a21b1fd845bd63543c88a9a23c07aca72ef">9c794a21</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-04T07:55:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Do not segfault on error in DoDNSUpdate()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13440
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit cdd98aa1e2116fb97e16718d115ee883fe1bc8ba)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8f01d946b49730b40481804b2c60cc0b105c458c">8f01d946</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-04T07:55:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-lib: Remove support for libexc for IRIX backtraces
IRIX is long dead, and this code needs become_root() which is not in
the top level code.
Additionally, the check for libexc never made it into waf, so this
has been dead code since Samba 4.1.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13454
(cherry picked from commit 85dc9ee14023a8fb84b5c74555d43008bb6bb0c0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d14cd61f45564b0a85a1946eb0e39fac02fa227d">d14cd61f</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-04T07:55:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/util: Log PANIC before calling pacic action just like s3
This is like the changes made in s3 by
4fa555980070d78b39711ef21d77628d26055bc2
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13454
(cherry picked from commit 3acc00b6808d5d5ad035d9d43526204db1608c8a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5733e906fa3a55b7676d2229ed322777f94229d3">5733e906</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-04T07:55:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/util: Move log_stack_trace() to common code
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13454
(cherry picked from commit bf9551902afdb32310db4a3381964c435dd08bf0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/20644011ab095a987cdeeaba953992f308175e58">20644011</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-06-04T10:37:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Update reference to lmaster/recmaster capability options
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon Jun 4 12:37:39 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/68999b8e6d1e887761e2ad3cf94ca3419719bac5">68999b8e</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-04T12:30:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/util: Call log_stack_trace() in smb_panic_default()
This matches the AD DC with the behaviour in smbd.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13454
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Apr 11 04:03:07 CEST 2018 on sn-devel-144
(cherry picked from commit 462eb4a44cc51dc17aebbcd5c609c9ff7f088554)
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Mon Jun 4 14:30:55 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3c3b1bc64c642bbb28571621c8ee2e37d8d6556a">3c3b1bc6</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-04T16:18:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pyldb-samba: Use the same smb.conf variable name as the C wrapper users for LDB_FLG_NOSYNC
This was never noticed as most wrappers on make test run with TDB_NO_FSYNC
However ldb_mdb has not been told to use this (naturally) and so we rely
on the smb.conf setting to not force an fsync().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13461
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0f5d93a0baa7ef5fc0ef2404dc9a3cc3438d0b7f">0f5d93a0</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-04T18:58:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Honour LDB_FLG_NOSYNC for metadata.tdb
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13462
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Jun 4 20:58:01 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/12fd8d7a5c5d14d403aac6cd9e318afcd0a8e159">12fd8d7a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-06-05T15:47:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Move event scripts to events/legacy/ directory
This is the initial location that will be used by the new
multi-component aware event daemon.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b23f3f996038626f618c5b5aa552686c1b852f44">b23f3f99</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-06-05T15:47:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Event scripts must end with ".script" suffix
Preparation for recommending configuration for each script next to the
actual script.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4bdf97a935d19454fbd544616640a22f2bafe55f">4bdf97a9</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-06-05T15:47:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Change directory for notifications to events/notification
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f1d07908e2516e2968c6653d5998b34a42979548">f1d07908</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-06-05T15:47:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "ctdb-tests: Continue running if a testcase is not executable"
This reverts commit 36e7043fb16ac996793545022147f696caedee9c.
An recent change broke this and I forgot to test before posting. :-(
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f2e8ab3f02aab7e2550409762800befa4b55cb69">f2e8ab3f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-06-05T18:37:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Continue running if a testcase is not executable
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue Jun 5 20:37:15 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4b04c27377e835a7bccbf2175e94da730374de81">4b04c273</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-06-05T20:34:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Simplify process registration using linked list
The way run_proc abstraction is used in run_event, there can be maximum
of 2 processes active at any given time. So the memory requirements
can be reduced by using a linked list.
New eventd will have multiple run_event instances but will be limited to
3 or 4. Even then the total number of processes will be less than 10.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a883f8b0920d68d2d3b923463de59384a4eb8e8f">a883f8b0</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-06-05T20:34:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Do not initialize run_proc inside run_event
Allowing run_event_init() to take run_proc_context as an argument allows
to create multiple run_event instances with a single run_proc_context.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4d27c11ce26bf835448862b6d901056125b5414f">4d27c11c</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-06-05T20:34:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Rename run_event_script_list to run_event_list
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a3591ed5de145df54cf29027273416876de1b774">a3591ed5</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-06-05T20:34:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Return script_list for zero scripts
When an event script directory is empty, do not return script_list as
NULL. Instead return empty script_list with zero scripts.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/723529e41e3af72f8f42a3a61192c3ef3b86861b">723529e4</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-06-05T20:34:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Improve error handling in run_event
If event script directory does not exist, then return ENOTDIR. If a
directory gets removed at runtime, report error from scandir in
get_script_list().
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e4a5d610b8e81c78b7d98217bc87c4b815b4c4e7">e4a5d610</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-06-05T20:34:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Reset running state on failure
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/366f6703e7474f5b1c6b97b4d77b80897bdc5f69">366f6703</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-06-05T20:34:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Add support to run events through failure
Usually run_event will stop executing event scripts on first failure.
Optionally it can continue to run events even on failure(s).
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d445704050630509208a74fb23297949a4dce779">d4457040</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-06-05T23:13:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: CID 1435732: Argument cannot be negative
Negative parameter passed to function which cannot take negative values.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Christof Schmitt <cs@samba.org>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Wed Jun 6 01:13:18 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ab28a64f5e7f8cd6114350f2577e7e6a768fb11c">ab28a64f</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-06-06T23:46:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd/domain: fix a typo in message
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/00494a65102de10880950e307731a7cbd8cb2827">00494a65</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-06-06T23:46:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd/domain: remove dns records after DC demote
Call `remove_dc.remove_dns_references()` at the end of demote cmd.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0fb122af5094d568c56b0a7814696f3389813bbd">0fb122af</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-06-07T02:21:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/demote: replace demote test bash script to python
Convert bash script to python and add demote and dns remove test on top.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Thu Jun 7 04:21:17 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2e5bc85b3c67e8ccf81648e9d1260448369d5cf2">2e5bc85b</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-06-07T07:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add dfq_cache share with 'dfree cache time' set
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 7ffcbd5ce1222971cb9879f78765d87cdc4102a8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/88d19df48977fecc874f246798364c2ef5ccc013">88d19df4</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-06-07T07:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add test for 'dfree cache'
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit a55b3d2fcc2f7737a2702bf908dcf1f80969bf21)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3fd685e71ac6c73b0af5a650bb6617d4b56ab762">3fd685e7</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-06-07T07:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">memcache: Add new cache type for dfree information
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit f5d05562679f6aa691b98b4a75952f7dda7ed343)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f7e53f864b527245081e31982868d3f9f4645630">f7e53f86</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-06-07T07:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Cache dfree information based on query path
Sub directories in a SMB share can have different free space information
(e.g. when a different file system is mounted there). Caching the dfree
information per SMB share will return invalid data. Address this by
switching to memcache and store the cached data based on the query path.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 8f121747b06ca78cf51801a3931b2ddd1a424c77)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ae4e54563e69d3cd82ad6cf83ededb130a284c40">ae4e5456</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-06-07T11:48:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW.txt: Updated with VFS ABI changes for 4.9.0.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Kai Blin <kai@samba.org>
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Thu Jun 7 13:48:25 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a7a51bd9e6db206644a84f69dc6914a0fb266b0d">a7a51bd9</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-06-07T12:09:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Flush dfree memcache on service reload
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit e30d0c0e0d11f65b2d1886be3c0fe9e32eaf3926)
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Thu Jun 7 14:09:12 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ddbf6035dfec6806536f99d0257245f70661363">7ddbf603</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-06-08T11:23:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-heimdal: Fix the format-truncation errors.
../source4/heimdal/lib/com_err/compile_et.c: In function ‘generate_h’:
../source4/heimdal/lib/com_err/compile_et.c:138:33: error: ‘%s’ directive output may be truncated writing up to 127 bytes into a region of size 126 [-Werror=format-truncation=]
snprintf(fn, sizeof(fn), "__%s__", hfn);
^~ ~~~
../source4/heimdal/lib/com_err/compile_et.c:138:5: note: ‘snprintf’ output between 5 and 132 bytes into a destination of size 128
snprintf(fn, sizeof(fn), "__%s__", hfn);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../source4/heimdal/lib/com_err/compile_et.c: In function ‘main’:
../source4/heimdal/lib/com_err/compile_et.c:234:35: error: ‘.h’ directive output may be truncated writing 2 bytes into a region of size between 1 and 128 [-Werror=format-truncation=]
snprintf(hfn, sizeof(hfn), "%s.h", Basename);
^~
../source4/heimdal/lib/com_err/compile_et.c:234:5: note: ‘snprintf’ output between 3 and 130 bytes into a destination of size 128
snprintf(hfn, sizeof(hfn), "%s.h", Basename);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../source4/heimdal/lib/com_err/compile_et.c:235:35: error: ‘.c’ directive output may be truncated writing 2 bytes into a region of size between 1 and 128 [-Werror=format-truncation=]
snprintf(cfn, sizeof(cfn), "%s.c", Basename);
^~
../source4/heimdal/lib/com_err/compile_et.c:235:5: note: ‘snprintf’ output between 3 and 130 bytes into a destination of size 128
snprintf(cfn, sizeof(cfn), "%s.c", Basename);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Jun 8 13:23:51 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1c0f743c2d51c74b146d5ceea3252683450f639f">1c0f743c</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-06-09T13:02:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: audit samdb and password changes
Add audit logging of DSDB operations and password changes, log messages
are logged in human readable format and if samba is commpile with
JANSSON support in JSON format.
Log:
* Details all DSDB add, modify and delete operations. Logs
attributes, values, session details, transaction id.
* Transaction roll backs.
* Prepare commit and commit failures.
* Summary details of replicated updates.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d4deb800e2f472a91752b764918ffa49b878073d">d4deb800</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-06-09T13:02:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Audit group membership changes
Log details of Group membership changes and User Primary Group changes.
Changes are logged in human readable and if samba has been built with
JANSSON support in JSON format.
Replicated updates are not logged.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1b07f1337291409688815e5261921ee4f557ab7d">1b07f133</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-06-09T13:02:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: add defines for sessionInfo and networkSessionInfo
Replace uses of the string "sessionInfo" with the constant
DSDB_SESSION_INFO, and "networkSessionInfo" with the constant
DSDB_NETWORK_SESSION_INFO.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/81f7ecc2a7fa1d44ef9a1f310eaf890c8fb8b158">81f7ecc2</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-09T15:42:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Use ldb_init() to make the ldb_context in dsdb audit tests
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Jun 9 17:42:38 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e5c0e6da6593fb77d5a16ece9aa85532d855d2be">e5c0e6da</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-06-10T17:02:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/audit_logging fix flapping test
Add an adjustment to the before and after values to cater for the
occasional differences between the calculated times.
The exact value of the time stamp is not important what is important is
that is correctly formatted and that the value is reasonable i.e. it's
close enough to the current time.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f27a700e69974ccc3e1c722050cd8d72d904eeca">f27a700e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-10T17:02:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/kcc/graph_utils: short-cut edge failure test without edges
Otherwise we get an exception because itertools.combinations is asked
to find combinations with negative size.
Instead we assert the graph is connected as-is, which in this case is
the same as asserting there are no vertices.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/92fff57f0c269ff154adc589f395d8328b210e88">92fff57f</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-10T17:02:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs showrepl tests: don't assert existence of DNS partitions
Because their existence is uncertain immediately after provision,
when these tests will run under some circumstances.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99aabf436d62eef990990e6edf95b117bebe0228">99aabf43</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-10T17:02:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs showrepl: generalise the way output mode is chosen
We have a couple more output modes coming along, so it makes senses to
untangle .run() into a number of independent sub-methods.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/50e3bfa4f57e74a1c123b71ab3a79004c83fd01c">50e3bfa4</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-10T17:02:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs showrepl: add a --verbose flag
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3f25e0b2316f41be3695446f3e5ec9d92ac27440">3f25e0b2</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-10T17:02:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/graph: tweak colour schemes for distance charts
This works a bit better in terminals with white text.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7e001b27411ef04304fca3fd25c549a8725df34a">7e001b27</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-10T17:02:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool visualise: helper for getting the partition
Repeated code becomes a function.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9353a580f896c74f60f56d0af555c29fdf8df117">9353a580</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-10T17:02:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool visualize: separate dot options from common options
because not all sub-commands make dot format
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4f7638f8aba737240352199cc253dbd286f7907c">4f7638f8</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-10T17:02:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/graph: use look up table for ascii-art charsets
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6813e1b3c28276721ba7ae49a97ccbdb60d583a7">6813e1b3</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-10T17:02:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/graph: rework shorten_vertex_names to not need edges
This will be necessary for the forthcoming full_matrix function.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/02bca5590cf3cb647df8c9b188a0a2e678933d0c">02bca559</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-10T17:02:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/graph: add full_matrix graph function
This makes an ASCII/ANSI art picture like distance_matrix(), but from
a full matrix, not a list of adjacencies as in the distance_matrix case.
This will be used to visualise up-to-dateness vectors.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87926094040621e46534a305a8eec9dc75551711">87926094</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-10T17:02:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/graph: use '>' for excessive numbers, not '+'
'+' already has another meaning in these graphs.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d8bbe1da93433cf7440d780c7cb4a627c3cbd635">d8bbe1da</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-10T17:02:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/graph: don't crash colourer on bad link
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c3ad137eb6bdbdc99cc2cc615ca3378a19b6cfa9">c3ad137e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-10T17:02:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool visualize: fix wrong variable name in get_partition()
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/04a773f30fdb7d03c0526ca1f73353ce5f0d29d5">04a773f3</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-10T17:02:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool visualize ntdsconn: properly sort/group vertices
The vertex is now a tuple, with the RODC state added.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2d8cc50d392c9434993e2084d4390ce7337cb1b8">2d8cc50d</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-10T17:02:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">sambatool visualize: add up-to-dateness visualization
Or more accurately, out-of-dateness visualization, which shows how far
each DCs is from every other using the difference in the up-to-dateness
vectors.
An example usage is
samba-tool visualize uptodateness -r -S -H ldap://somewhere \
-UAdministrator --color=auto --partition=DOMAIN
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/153252a55e66533d5bdbb419f259c1682801ae53">153252a5</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-10T17:02:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/join: fix a typo
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b9a323a27cff7cca09babdf6dea784e94e25dad7">b9a323a2</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-10T19:41:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/drs_utils: fix repeated typo
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun Jun 10 21:41:33 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3ddd8527104f7364c07816fd9d3f1039a396a2f9">3ddd8527</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-12T06:13:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: export fault_setup() to python bindings
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13469
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/454edac226bc87b9e68bc60add4c16f4bab9c275">454edac2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-12T09:04:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: call fault_setup() if samba.getopt is used
This means we have a samba command line tool written in python,
e.g. samba-tool
We should get the samba typicall backtraces instead of
just "Segmentation fault (core dumped)".
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13469
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Jun 12 11:04:55 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/83cd68c8ae7e4febbfbabd11172f7a2e2eef4368">83cd68c8</a></strong>
<div>
<span>by Timur I. Bakeyev</span>
<i>at 2018-06-13T01:51:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix UDP DNS queries in addns
The addns code tries to use common approach for TCP and UDP queries,
calling connect() for both types of sockets. In case of UDP that
requires to use send() instead of sendto().
Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jun 13 03:51:04 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f754843f51398d4c55ab7cd64b4b53754be3bb5">7f754843</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-13T08:30:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Fix CID 1436920 Unchecked return value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2678b4c25f4a669960af0196f8314ae51ee6347d">2678b4c2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-13T08:30:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Fix CID 1436919 Unchecked return value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c4039232e3393b4509c007e7c85474cfc6c686ef">c4039232</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-13T08:30:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Fix CID 1436918 Unchecked return value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9ec47b3cffcb258f2885a731b49ed1085df508d8">9ec47b3c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-13T08:30:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Fix typos
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/11cac8a21c500a3936a47d355133e347c0a843a0">11cac8a2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-13T08:30:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Fix CID 1435966 Unchecked return value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/15fa8f9f24c69832cc4f309e59ee6292a7c33938">15fa8f9f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-13T11:40:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Fix CID 1435968 Dereference before null check
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jun 13 13:40:56 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c0e4818d68cbc6aea50f0e5a56af29407763bab5">c0e4818d</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-06-13T11:41:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CID 1416478: de-ref NULL value in fruit_pwrite_rsrc
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/808b7e2b0332b4f53597b44e790d0f365cad44c0">808b7e2b</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-06-13T11:41:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CID 1416477: possibly dereferencing NULL in fruit_pwrite_meta
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9715e55e6554c611d858647875d6260c304b5c3a">9715e55e</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-06-13T11:41:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CID 1416476: possibly dereferencing NULL in fruit_ftruncate_rsrc
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d33c355103406ceb4941a479f34ea33eae8e87a7">d33c3551</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-06-13T14:29:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CID 1416475: possibly dereferencing NULL in fruit_pread_meta
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Jun 13 16:29:48 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/72bd6885ab18c920c6ed9e76946fd809e70e2abf">72bd6885</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">printing: remove unused arguments from load_printers()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ebae5e055cfb5ad1286e1ad51732e93a7f3b0c78">ebae5e05</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">printing: remove unused arguments from delete_and_reload_printers()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/66bc2c4332f475d9b614c442223749a499b39c60">66bc2c43</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add create_conn_struct_tos[_cwd]() helper functions
This makes it more obvious that the returned connection_struct
is only temporary (and allocated on talloc_tos()!)
It will never allow async requests on a long term
tevent context! So we create a short term event context.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cbde2e348b68a5d638d9bce3f3912a4828cd90c7">cbde2e34</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: remove useless explicit conn_free() from set_nt_acl_conn()
The following TALLOC_FREE(frame); will do the same via
conn_free_wrapper().
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ef67df3f3f0df313c21cc123223633df3fa3ce7">7ef67df3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: consitently use talloc_stackframe() for temporary memory
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/539f51f0dfbe4ce317a2978982fd0fc9a7fd6922">539f51f0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: fix some talloc_stackframe() memory leaks and clean up the frame hierarchy in make_simple_acl().
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/67ea594843dff559f3709046498c224d16141974">67ea5948</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: remove explicit talloc_stackframe() from get_conn() and name it get_conn_tos()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1566766f38e3cdf84d45285c709236eedcfaa167">1566766f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: make use of create_conn_struct_tos()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/96ac5a80cbedaf8bd6edc5ba7634aa9622eaef6d">96ac5a80</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: make use of create_conn_struct_tos() in get_nt_acl_no_snum()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7983c7084f432c692c43b75f3fee0401c1a87f04">7983c708</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server/fss: use talloc_stackframe() for temporary memory
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ac922ebe1b3b587a2510fb0e0a696f77a72cbdc6">ac922ebe</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server/fss: make use of create_conn_struct_tos()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9f5dcdc6225b1dab3fb6e40f64fe3a8eeb061a9">a9f5dcdc</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add an explicit talloc_stackframe() to {create,remove}_msdfs_link()
This makes further changes simpler.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e3837d36e75f29025155010383e0203d1f7a2388">e3837d36</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add an explicit talloc_stackframe() to get_referred_path()
This makes further changes simpler.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/15ea2c1b6af1f9e5510846bfd986dbcb9a088424">15ea2c1b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add an explicit talloc_stackframe() to count_dfs_links()
This makes further changes simpler.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2401e257bb784f9881cd4b860e377163033ad77b">2401e257</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add an explicit talloc_stackframe() to form_junctions()
This makes further changes simpler.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/42610e0ca704d0a73abca8720c84f654595a2eb6">42610e0c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: convert junction_to_local_path() to use create_conn_struct_tos_cwd()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/73e5d47d32fa6af40667bb151b7c14411bcd987f">73e5d47d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: convert get_referred_path() to use create_conn_struct_tos_cwd()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bcb4d421b237c3d2bb3ffe10965f3a67bfa17c3d">bcb4d421</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: convert count_dfs_links() to use create_conn_struct_tos_cwd()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/36d3de023fa393461e56f7603f052abb8ca9b7fe">36d3de02</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: convert form_junctions() to use create_conn_struct_tos_cwd()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/44e3c03bc1943aaa6b7ba4b9f6c601252daf0942">44e3c03b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server/srvsvc: add an explicit talloc_stackframe() to _srvsvc_NetGetFileSecurity()
This makes further changes simpler.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/185d47159a919b5d267c612b5410b68d9e42558e">185d4715</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server/srvsvc: add an explicit talloc_stackframe() to _srvsvc_NetSetFileSecurity()
This makes further changes simpler.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f9860b67be505bbbff0b56a18d854261c1297e2b">f9860b67</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server/srvsvc: _srvsvc_NetGetFileSecurity() to use create_conn_struct_tos_cwd()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/498830ccd212183a8c352ec5198af948788db519">498830cc</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server/srvsvc: _srvsvc_NetSetFileSecurity form_junctions() to use create_conn_struct_tos_cwd()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d493eaeb11e1652cb1e4d59b3aceb2e33fae400">7d493eae</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">printing: add more 'const' to read only input pointers
This makes it clearer that they won't be changed.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bad43d31316fccd53ccc7671294903cc9c30bd0c">bad43d31</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">printing: add an explicit talloc_stackframe() to get_correct_cversion()
This makes further changes simpler.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a2ad24f8b04bbe581b1f56440bd37c4866e49b27">a2ad24f8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">printing: add an explicit talloc_stackframe() to move_driver_to_download_area()
This makes further changes simpler.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e56bb427d3d21ef03fa50a114c377d837de5f3bb">e56bb427</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">printing: add an explicit talloc_stackframe() to delete_driver_files()
This makes further changes simpler.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/76297c3c17c3b1e1d6515fc83cfea608054aa31c">76297c3c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">printing: convert get_correct_cversion() to use create_conn_struct_tos_cwd()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ae32a2681a684d27f33dc0f620a1c63103467899">ae32a268</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">printing: convert move_driver_to_download_area() to use create_conn_struct_tos_cwd()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/240c47c2aa3f27d7265ae255a4e42377b95c1876">240c47c2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">printing: convert delete_driver_files() to use create_conn_struct_tos_cwd()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cdb875f5f7cc7cd17af34b8dd9352f6e69e492dd">cdb875f5</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove unused create_conn_struct_cwd() function
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b71362b17699a47217a2676153db044d0e5a5a79">b71362b1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfstest: make use of create_conn_struct_tos()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b5302c6bc4a7bec0773dee2695b72a65c720b0c4">b5302c6b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: let create_conn_struct_tos() use create_conn_struct_as_root() directly
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d156483d6440a21dfe52b97006f58bf771be5733">d156483d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove unused create_conn_struct() function
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ee8ea5ce01ab137c8f28cd7d70c59c09ce3f07d3">ee8ea5ce</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use pconn = talloc_move(ctx, &conn) in create_conn_struct_as_root()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/efce5587973f4b03ae63b20c7fd68c7daaf77c3a">efce5587</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: call samba_tevent_context_init() within create_conn_struct_as_root()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/55b1b5568f109f51d7cb3b707bc9ae761b3c44fa">55b1b556</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_glusterfs: use tevent_req_defer_callback() in order to use the correct event context
The callback and _recv() functions should be called from the same
event context that was passed to the _send() function.
In future the completion pipe should be replaced by
tevent_threaded_context_create()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/553df61946ae455839a40201250fb97269712e38">553df619</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: make smbd_setup_sig_{term,hup}_handler() static
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/51407b90d9363341252acdf3663886b22d1ee4c7">51407b90</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: split out a fsp_flush_write_time_update() function from update_write_time_handler()
It's confusing to call update_write_time_handler() from anywhere,
it should only be called from within the event loop when the
timer expires.
This makes it more obvious that fsp_flush_write_time_update()
doesn't really need an tevent context argument.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9393d95f22276a5374f991746d48050fe0be47c5">9393d95f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T18:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove useless allow_access() check for AS_GUEST
We already call allow_access() when we accept the connection
in smbd_add_connection().
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ef6775919e83fdae66385db8d1579fa259602f1">5ef67759</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-14T21:38:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: don't call change_to_root_user() before change_to_guest()
This is just an optimization and it makes it clearer
that calling change_to_root_user() just before change_to_guest()
is useless and confusing.
We call change_to_guest() before set_current_service() now,
but that has no impact as we pass 'do_chdir=false'
as AS_GUEST is never mixed with AS_USER or DO_CHDIR.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Jun 14 23:38:55 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f4f3abfa0e18bb4968b37b1cac40cd8c185c8d7b">f4f3abfa</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-15T02:39:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Use mem_ctx and so avoid leak onto long-term memory on duplicated add.
After a duplicated add a small amount of memory can be leaked onto a
long-term context.
Found by Andrej Gessel https://github.com/andiges
https://github.com/samba-team/samba/commit/e8fb45125e6a279b918694668e0d4fbddac10aee#commitcomment-29334102
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13471
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jun 15 04:39:41 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3ca1c09f686fbfa9257cd95710dba4a98c3eeb8f">3ca1c09f</a></strong>
<div>
<span>by Andrej Gessel</span>
<i>at 2018-06-15T21:07:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix several mem leaks in ldb_index ldb_search ldb_tdb
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13475
Signed-off-by: Andrej Gessel <Andrej.Gessel@janztec.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Jun 15 23:07:25 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4dac6e7cd08ab226eff9415b4924b6dcd8e5178d">4dac6e7c</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-06-15T23:06:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Possible memory leak in map_info6_to_validation
If the call to copy_netr_SamInfo6 returns an error status,
the allocated memory for "validation" needs to be free'd before returning.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ea4b40e65a92f173d5bda8905f99a002a4bd8151">ea4b40e6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-15T23:06:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Align integer types in for loops
Iterate over the same type as the loop limit
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/73b183e1382117f35033bbe65316d30b966e9032">73b183e1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-15T23:06:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Use is_domain_offline() where appropriate
That if-condition is precisely covered by the helper routine
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b394026f478b038e734fd3952909c6337fbb5721">b394026f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-15T23:06:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Do an early TALLOC_FREE
Leave the if-block without leaking
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e67d605b8bc4338ca9f63265588143788c0d4bed">e67d605b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-15T23:06:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Add a missing NULL check
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bced81cd6c2d27fb9fe71fc572098a1b1c933fca">bced81cd</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-15T23:06:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Fix winbindd_ping_dc_recv
tevent_req_simple_recv_ntstatus is only for the one-liner without any
additional functionality.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c4021d09218a5b441677a15ec36e618076ce54d7">c4021d09</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-15T23:06:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/455cd6624ef29b619e50158f3f44ac3a72f25424">455cd662</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-16T02:21:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">addns: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Jun 16 04:21:18 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d4f2294c9eeec31f9d087e4fb70611d8d824db8">5d4f2294</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-06-16T09:56:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-dsdb: fix the build of audit_util.c
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sat Jun 16 11:56:53 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c21371bbbef437cdad987316404ddd08d195f032">c21371bb</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-06-17T20:43:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Ensure /var/lib/samba/dhcp.conf exists (Closes: #901585)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/df5e459299d1eb61879a4bdaf6f600acaab90b6a">df5e4592</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: add caching to set_current_user_info()
Currently we do that in the caller, but we use global
cache anyway, so we can simplify the callers.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/71d5809188e416aeb3e9c67214eae32b4225c2d7">71d58091</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove xconn->client->last_session_id based set_current_user_info() caching
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8e81090789e4cc3ba9e5aa792d4e52971909c894">8e810907</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: split out set_current_case_sensitive() and chdir_current_service() functions
We'll soon use them independend from set_current_service().
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e7456d28655fda118ad3d432e9baf8398206bbe">0e7456d2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: call set_current_case_sensitive() before chdir_current_service()
I guess we better setup conn->case_sensitive before doing the
vfs_ChDir() calls, so we have a consistent result everytime.
Otherwise vfs_Chdir() would get conn->case_sensitive from
last request.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e469d6c73059d53dd10d590db7ab3118e66f731a">e469d6c7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: let check_user_ok() construct ent->session_info in one coherent block
We should finish manipulating ent->session_info before filling
conn->session_info. And conn->session_info should be not be changed.
Use git show -U15.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/35a12e7009d9f1e2eeab06c02ac8227f5b59c778">35a12e70</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: simplify the logic in change_to_user()
We can return early if (vuser == NULL).
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/91a37964814828020ec718bc6b802216f3425a70">91a37964</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: move current_user caching to change_to_user_internal()
Note that (current_user.vuid == vuid) also works with
UID_FIELD_INVALID.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8cfe36eee92255509e61e591761db594de46cdb8">8cfe36ee</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: call set_current_user_info() in change_to_user_internal() and pop_conn_ctx()
change_to_user() should be the one and only function for the whole
impersonation processing. So we also need to stack the
set_current_user_info() information for become_user/unbecome_user.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5472171bdb46f1dcb0a4eae61b1d1b6af6373ee5">5472171b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: make it explicit that make_connection_snum() returns NT_STATUS_OK on success
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0186ff23246cd5332729a80118d87d6a47488259">0186ff23</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remember that the tcon completely setup connection_struct
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ffe1918e8153f5bf429e3d9ebed975c6127f1553">ffe1918e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: call set_current_case_sensitive() before change_to_user() in switch_message()
change_to_user() will soon call chdir_current_service() and we should
make sure conn->case_sensitive is prepared before calling vfs_ChDir().
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e2786a91fb9e3be2248d60b3c32d88fef2d0772">0e2786a9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: make it possible to call vfs_ChDir(conn, conn->cwd_fname);
We should only TALLOC_FREE(old_cwd) at the successful end.
This also avoids calling cp_smb_filename() on the old value.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f407a86b743937d51192bc23917d4c819a9b722a">f407a86b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: let create_conn_struct_as_root() fill in conn->origpath
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a61d0aa35b766f4df4d4f9e6891c3a7516e81100">a61d0aa3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use conn->lastused_count++ directly in process_blocking_lock_queue()
This avoids using set_current_service(), which will be removed shortly.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1b86df90d27557fb8eefb182809c2f78cdb9f0fa">1b86df90</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove useless set_current_service(NULL,0,True) from reload_services()
All this does is 'return false' as conn is NULL...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/58f4bbc103a420a44234a7c12c8a9b11dea4d8d6">58f4bbc1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: call chdir_current_service() directly in smbXsrv_tcon_disconnect()
There's no need to worry about conn->case_sensitive here.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/03f69e82fc81f61d21def4465afa7f4a1b493c8b">03f69e82</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove set_current_service() from defer_rename_done()
The change_to_user() above already called chdir_current_service().
And for smb2 we don't have per packet conn->case_sensitive anyway.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b27d885478245d8bd56ab4f5459908b6c574d15d">b27d8854</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove set_current_service() from smbd_smb2_request_check_tcon()
The change_to_user() above already called chdir_current_service().
And for smb2 we don't have per packet conn->case_sensitive anyway.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d1c8057997f97c6cd537496611dfae4e8b4af520">d1c80579</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: call chdir_current_service() in change_to_user_internal() and pop_conn_ctx()
change_to_user() should be the one and only function for the whole
impersonation processing. So we also need to stack the
chdir_current_service() behaviour for become_user/unbecome_user,
so we may need to call vfs_ChDir(ctx_p->conn, ctx_p->conn->cwd_fname);
in pop_conn_ctx().
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a97448cc9433a4a8e03f8efbe00a404d72c3616">4a97448c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: let switch_message() only call chdir_current_service() for SMBtdis/SMBexit
These are the two opcodes with DO_CHDIR, we don't want the
set_current_case_sensitive() logic for them,
so we don't need the full set_current_service() anymore.
The AS_USER case is already handled before, set_current_case_sensitive()
is called directly before change_to_user(), which already
calls chdir_current_service().
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff7efafe73369ec27ab07307102807818ea48c39">ff7efafe</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove unused set_current_service()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/60dbaa490c2b11047f5d7043ed48363164804d6f">60dbaa49</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: avoid calling set_current_user_info() twice with AS_USER (SMB1)
It will be called via change_to_user().
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3194999f0bf13d7d7c1f2b91bd8c1ec885158666">3194999f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: avoid calling set_current_user_info() twice with .need_tcon (SMB2)
It's already called via change_to_user().
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4af45b8ff6c32bfdfb2eca07fe1b9f158d50fe87">4af45b8f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_default: remove unused checks which are already caught by vfs_offload_token_check_handles()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ac91e487db935d508eb22cc81702c74029a5ad4">5ac91e48</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_btrfs: remove unused checks which are already caught by vfs_offload_token_check_handles()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/231731623392cdcf117ed5febe178b5d7c1fb9c0">23173162</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_btrfs: update s/btrfs_cc_state/btrfs_offload_write_state/ s/cc_state/state/
This matches our naming conventions used for tevent_req based functions.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4512b91897fa1bba60005cc4378ffb5879be28f1">4512b918</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_btrfs: don't keep state->subreq in btrfs_offload_write_send/recv()
This can be a local variable as used in most of our tevent_req based
code.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e4fb4c1d0efe0f9f1c31eac4e57d60f4bcbc7149">e4fb4c1d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add {become,change_to}_user_by_fsp() helper functions
This can be used if a request operates on two fsp's,
e.g. the offload_write_send/recv code.
This is important if (at least) one of
the shares uses "force user".
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2d75da9f61f16eac3c137e16f98e16f4022b79b0">2d75da9f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_btrfs: make use of become_user_by_fsp() in order to switch between src and dst fsp
We can use become_user_by_fsp()/unbecome_user() as it spans only parts of
the btrfs_offload_write_send() function and never goes async in between.
This may matter if at least one share uses "force user".
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/506c9b37df1de784fecc6e01cd30f2b3b693a9fd">506c9b37</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_default: make use of change_to_user_by_fsp() in order to switch between src and dst fsp
This may matter if at least one share uses "force user".
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/db83a8f7c86946d478a55b611779b9666a47cabc">db83a8f7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_default: maintain vfswrap_offload_write_state->{src_ev,dst_ev}
These get filled with impersonation wrappers in the following commits.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/19119a55490bcfacbc7d4be340f650e9eaf212f2">19119a55</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: rename smbXsrv_client->ev_ctx into smbXsrv_client->raw_ev_ctx
That makes it clearer that no tevent_context wrapper is used here
and the related code should really run without any (active) impersonation
as before.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d39f6ce3b1ac9f70040e8140937280f445d2d861">d39f6ce3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: replace xconn->ev_ctx with xconn->client->raw_ev_ctx
This is the same pointer and we don't have a lot of callers,
so we can just use one pointer.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d2adcebda12943b7b4af1b8fca35a2c7aa1524e9">d2adcebd</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: replace xconn->msg_ctx with xconn->client->msg_ctx
This is the same pointer and we don't have a lot of callers,
so we can just use one pointer.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/934b375639c3c0ea17854e870c3458af619cc1da">934b3756</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove unused tevent_context argument from notify_init
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/051c32167ce4a8395daa4ff1eb72eb805da9feab">051c3216</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smb2_server: use req->xconn->client->raw_ev_ctx for smbd_smb2_request_pending_timer()
There's no need to use req->ev_ctx here just to do some network io.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4d5d8d62e4454ceb22884a69f511ae60ac3af698">4d5d8d62</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smb2_server: use req->xconn->client->raw_ev_ctx for smbd_smb2_request_dispatch_immediate()
smbd_smb2_request_dispatch() will redo the impersonation anyway,
so we don't use req->ev_ctx.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c059f0ae729a47883362a1ba01b530b3d743bc45">c059f0ae</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use req->xconn->client->raw_ev_ctx for schedule_deferred_open_message_smb()
process_smb() will redo the impersonation anyway.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6114f9545fa856717220658e87f2a60f6767b7f4">6114f954</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add smbd_server_connection->raw_ev_ctx pointer
This will replace smbd_server_connection->ev_ctx in the next commits.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b0af5715b0a7592a9728e0b76f653b9ab6228708">b0af5715</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_glusterfs: explain that/why we use the raw tevent_context in init_gluster_aio()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7cfafaf190643eb28fc95d21a02a4e5e529e16d1">7cfafaf1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: explain that/why we use the raw tevent_context for update_write_time_handler()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/52f098d38da72d6eff3c4cac61487da897a8651c">52f098d3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: explain that/why we use the raw tevent_context for lease_timeout_handler()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e73eaa3c8004d3d8aff316cdb26b0bef85eceaca">e73eaa3c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: explain that/why we use the raw tevent_context for oplock_timeout_handler()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d5210b615035e46b90758ac7aa4ceec9174bee5">1d5210b6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: explain that/why we use the raw tevent_context for do_break_to_none()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dc517b20f60a156d73fdd551557eb1d4366dfdeb">dc517b20</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: explain that/why we use the raw tevent_context for linux_oplock_signal_handler()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f5f9b719741465c7be3de20a6a69ec106ecc4568">f5f9b719</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use raw_ev_ctx to clear the MSG_SMB_CONF_UPDATED registration
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/146938217ed1ab9a7a9f38c055fec5513cbd5c4d">14693821</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add smbd_server_connection->{root,guest}_ev_ctx pointer
For now these are just the same as smbd_server_connection->ev_ctx,
but this will change in future and we'll use impersonation wrappers.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/182991c26c8149c79b13a277b9822efc49fd1df0">182991c2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use sconn->root_ev_ctx for brl_timeout_fn()
This already calls change_to_root_user(), which can be removed
later.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c835ffa72ddfd2431d22909148913b50f0d829d1">c835ffa7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use sconn->root_ev_ctx for smbd_sig_{term,hup}_handler()
They already call change_to_root_user(), which can be removed
later.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f2df8be16be9dccd3d10ec060f1efbe5007a28c6">f2df8be1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add an effective connection_struct->user_ev_ctx that holds the event context used for the current user
This will be filled with an impersonation wrapper in the next commits.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/894e5001c747ce765dad5517778dda55d7d1f4d9">894e5001</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T06:59:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing
In future this will an impersonation wrapper tevent_context based on the
user session.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/721fbbfa7001b2788602106101f0407483894322">721fbbfa</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-06-18T09:46:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove unused smbd_server_connection->ev_ctx
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Jun 18 11:46:36 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f05a1554b770c6a2c905170347bfb41157f4aa78">f05a1554</a></strong>
<div>
<span>by Jeffrey Altman</span>
<i>at 2018-06-18T11:01:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">heimdal: lib/krb5: do not fail set_config_files due to parse error
Follow Apple's lead and do not fail krb5_set_config_files() simply
because one of the files in the profile list fails to parse correctly.
Doing so can lead to hard to find failures and could lead to an end
user shooting themselves in the foot and no longer be able to login
to their system to fix it.
Parse as many of the files as we can. Only fail krb5_set_config_files()
if init_context_from_config_file() fails.
Change-Id: I122664c6d707a5f926643808ba414bf4f681f8b8
Cherry-pick of Heimdal commit b7cf5e7caf9b270f4d4151d2690177b11a7a1bdf
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11573
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/88cac23e2b767175d94561aaea13ba6200c331df">88cac23e</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-06-18T11:01:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">heimdal: small code adaption to cherry-pick heimdal commit
Check asprintf() return value.
Make use of krb5_enomem().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11573
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0a6e9b6c0e15fa6fe46acdd357d76b8df447317f">0a6e9b6c</a></strong>
<div>
<span>by Nicolas Williams</span>
<i>at 2018-06-18T13:52:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">heimdal: Add include/includedir directives for krb5.conf
Cherry-pick of Heimdal commit fe43be85587f834266623adb0ecf2793d212a7ca
Removed tests and documentation from original commit by
Björn Baumbach <bb@sernet.de>, since we do not ship them.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11573
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Björn Baumbach <bbaumbach@samba.org>
Autobuild-Date(master): Mon Jun 18 15:52:26 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/877266f775004cd43f40a6c46f76b8a85afde0fa">877266f7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-18T16:34:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc/crypto: Fix a misleading comment
Probably cut&paste error
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Jun 18 18:34:51 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3604f3772f461c08b34e4bf8553dfc8835dd86cd">3604f377</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-06-18T19:49:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Check smb.conf with testparm, and also with samba-tool when server role = active directory domain controller (Closes: #900908)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba36a95d09086a28a3b369a5da2565a99ec289aa">ba36a95d</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-06-18T21:40:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Release 2:4.8.2+dfsg-2
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/95dcdd3d4f0f4fbec22d2e61f63af79d443a9309">95dcdd3d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-19T06:59:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testparm: Remove warning from the last century
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ea50825acf10cd528238b09eecf945d61a4a99aa">ea50825a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-19T06:59:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">idmap_hash: Align integer types
Loop-variable and bound should be the same type
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b81990095f44318a4e932778d53c3f7829f420ec">b8199009</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-19T06:59:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Align integer types
Loop-variable and bound should be the same type
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e078991ae7660a05687fc803c8a791d7c4287c3e">e078991a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-19T09:43:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Jun 19 11:43:16 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/016fc48a30900237205cb60ac9ed5d81c4737cbe">016fc48a</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-06-19T22:18:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Increase minPwdAge used for PSO tests
The PSO minPwdAge test was using a 1 second timeout. While this seemed
to work fine most of the time, we did see a rackspace failure that was
presumably due to the test taking longer than 1-second to execute
(which resulted in the password not being correctly rejected).
This patch increases the minPwdAge used, to try to avoid this problem
happening.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a3bf30e3a7852e4e0ced9e347363c71b799752f0">a3bf30e3</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-06-19T22:18:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Increase PSO test timeouts to minimise failures
When PSOs exist in the DB, there is some extra overhead involved in user
logins (an extra expand-nested-groups operation for every user login).
Currently password_lockout tests are quite query-intensive - each call
to _check_account() does ~6 RPC operations/LDB searches (plus sleeps for
20 millisecs). Plus the actual user login attempt being tested. It looks
like the current test needs to do 3 login attempts/_check_account()
calls within a 2-second window. While the PSO test cases usually work
OK, sometimes they fail (presumably they take slightly longer and fall
outside this 2-second window). Presumably this is due to the cloud
instance's CPU being slightly more loaded when the test is run.
Long-term the plan is to refactor the user login so that the extra
expand-nested-groups operation is unnecessary for PSOs. In the
short-term, increase the window the test uses from 2 seconds to 3
seconds.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9650deee03501a4b7f49872ff9917a118de6e7c3">9650deee</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-06-19T22:18:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: Py2|Py3 compat, fix more missed exception tuple issues
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fd35e533f1554c9c8643f62741f25fe7bf8771d5">fd35e533</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-06-19T22:18:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samab: py2/py3 string.upper(astring) -> astring.upper
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9e349fe82ad622aa856695ba0aa5d61dc2ca0d82">9e349fe8</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-06-19T22:18:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: py2/py3 port has_keys usage
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b0c9de820c07d77c03b80505cb811ac1dac0808f">b0c9de82</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-06-19T22:18:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/emulate: py2/py3 .next usage, replace with next() fn
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/09c2b71e47248543b4b9bde8210af9b6a57ce287">09c2b71e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-06-19T22:18:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: Another object.next() to next(object) py2/py3 converstion
fix samba.tests.samba_tool.visualize_drs
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8ecffb61a703ebb31ad5c985174c161b44434a4">f8ecffb6</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-06-19T22:18:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: enclose map.values with list (py2/py3)
Fix errors in samba.tests.samba_tool.visualize_drs that with python 3
will generate exception with messages something like
'can't iterate dict_values'
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a261a2a4294a588b07297f3b75ef98cd14984b99">a261a2a4</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-06-20T02:08:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: Fix NameError exception
Running make test TEST=samba4.drs.samba_tool_drs.python results in
BlackboxProcessError: Command '/tmp/samba-testbase/b12/samba/bin/samba-tool drs clone-dc-database samba.example.com --server=localdc -USAMBADOMAIN/Administrator%locDCpass1 --targetdir=/tmp/samba-testbase/b12/samba/bin/ab/tmp/tmpWPo8r3'; exit status 255; stdout: ''; stderr: 'ERROR(<type 'exceptions.NameError'>): uncaught exception - global name 'logging' is not defined
File "bin/python/samba/netcmd/__init__.py", line 177, in _run
return self.run(*args, **kwargs)
File "bin/python/samba/netcmd/drs.py", line 697, in run
logger.setLevel(logging.INFO)
'
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jun 20 04:08:53 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ce89931796ff0fc52c16b8d9595f83e10e1e80dd">ce899317</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-06-20T07:22:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix SMB2-FLUSH against directories.
Directories opened with either FILE_ADD_FILE or
FILE_ADD_SUBDIRECTORY can be flushed even if
they're not writable in the conventional sense.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13428
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 42aadf42f27053e621f2a6b72448afebb3f5082a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2839bf2ea38a63bebae88611a5766c9d0351d8d3">2839bf2e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-06-20T07:22:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbtorture: Add new SMB2-DIR-FSYNC test to show behavior of FSYNC on directories.
Tests against a directory handle on the root of a share,
and a directory handle on a sub-directory in a share.
Check SEC_DIR_ADD_FILE and SEC_DIR_ADD_SUBDIR separately,
either allows flush to succeed.
Passes against Windows.
Regression test for:
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13428
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri May 18 02:38:50 CEST 2018 on sn-devel-144
(cherry picked from commit d42f467a25e75e5487a00378609a24809ddc83ee)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c5f3606ca2574fc4e16b51eb857aafd8912f12a2">c5f3606c</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-06-20T07:22:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-heimdal: Fix the format-truncation errors.
../source4/heimdal/lib/com_err/compile_et.c: In function ‘generate_h’:
../source4/heimdal/lib/com_err/compile_et.c:138:33: error: ‘%s’ directive output may be truncated writing up to 127 bytes into a region of size 126 [-Werror=format-truncation=]
snprintf(fn, sizeof(fn), "__%s__", hfn);
^~ ~~~
../source4/heimdal/lib/com_err/compile_et.c:138:5: note: ‘snprintf’ output between 5 and 132 bytes into a destination of size 128
snprintf(fn, sizeof(fn), "__%s__", hfn);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../source4/heimdal/lib/com_err/compile_et.c: In function ‘main’:
../source4/heimdal/lib/com_err/compile_et.c:234:35: error: ‘.h’ directive output may be truncated writing 2 bytes into a region of size between 1 and 128 [-Werror=format-truncation=]
snprintf(hfn, sizeof(hfn), "%s.h", Basename);
^~
../source4/heimdal/lib/com_err/compile_et.c:234:5: note: ‘snprintf’ output between 3 and 130 bytes into a destination of size 128
snprintf(hfn, sizeof(hfn), "%s.h", Basename);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../source4/heimdal/lib/com_err/compile_et.c:235:35: error: ‘.c’ directive output may be truncated writing 2 bytes into a region of size between 1 and 128 [-Werror=format-truncation=]
snprintf(cfn, sizeof(cfn), "%s.c", Basename);
^~
../source4/heimdal/lib/com_err/compile_et.c:235:5: note: ‘snprintf’ output between 3 and 130 bytes into a destination of size 128
snprintf(cfn, sizeof(cfn), "%s.c", Basename);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Jun 8 13:23:51 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c70a0d52afbfb600ce2c060379c66d3280b7d5fc">c70a0d52</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-06-20T07:22:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-winbindd: use fill_domain_username_talloc() in winbind.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 3c6481d75cea175d0a69988577163efb40e2316b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/35de20bd3c7f5f4e73dda5070da05b0d081c3090">35de20bd</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-06-20T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-winbindd: remove unused fill_domain_username()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit b24d4eb7afad82afc3a9bab65e1d799edc4b5172)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1b420a212e38760d801449932d1905cd74f98979">1b420a21</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-06-20T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-printing: fix format-truncation in print_queue_update()
../source3/printing/printing.c: In function ‘print_queue_update’:
../source3/printing/printing.c:1809:42: error: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 244 [-Werror=format-truncation=]
snprintf(key, sizeof(key), "MSG_PENDING/%s", sharename);
^~ ~~~~~~~~~
../source3/printing/printing.c:1809:2: note: ‘snprintf’ output between 13 and 268 bytes into a destination of size 256
snprintf(key, sizeof(key), "MSG_PENDING/%s", sharename);
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 6326b3415f3e225aafd5912d0965c80abcd7b22c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/23f19c835e018b85918c0302407da114e9738e31">23f19c83</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-06-20T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-torture: fix format-truncation warning in smb2 session tests.
../source4/torture/smb2/session.c: In function ‘test_session_reauth5’:
../source4/torture/smb2/session.c:645:36: error: ‘\file.dat’ directive output may be truncated writing 9 bytes into a region of size between 1 and 256 [-Werror=format-truncation=]
snprintf(fname, sizeof(fname), "%s\\file.dat", dname);
^~~~~~~~~~
../source4/torture/smb2/session.c:645:2: note: ‘snprintf’ output between 10 and 265 bytes into a destination of size 256
snprintf(fname, sizeof(fname), "%s\\file.dat", dname);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../source4/torture/smb2/session.c:696:38: error: ‘\file2.dat’ directive output may be truncated writing 10 bytes into a region of size between 1 and 256 [-Werror=format-truncation=]
snprintf(fname2, sizeof(fname2), "%s\\file2.dat", dname);
^~~~~~~~~~~
../source4/torture/smb2/session.c:696:2: note: ‘snprintf’ output between 11 and 266 bytes into a destination of size 256
snprintf(fname2, sizeof(fname2), "%s\\file2.dat", dname);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 5729898248041794ffdd0b769332e015baf12cce)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3e42a24ce882a90b3a5d567c47870f53d8e5f265">3e42a24c</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-06-20T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-utils: fix format-truncation in smbpasswd
../source3/utils/smbpasswd.c: In function ‘process_root’:
../source3/utils/smbpasswd.c:414:37: error: ‘$’ directive output may be truncated writing 1 byte into a region of size between 0 and 255 [-Werror=format-truncation=]
slprintf(buf, sizeof(buf) - 1, "%s$", user_name);
^
In file included from ../source3/include/includes.h:23,
from ../source3/utils/smbpasswd.c:19:
../lib/replace/../replace/replace.h:514:18: note: ‘snprintf’ output between 2 and 257 bytes into a destination of size 255
#define slprintf snprintf
../source3/utils/smbpasswd.c:414:3: note: in expansion of macro ‘slprintf’
slprintf(buf, sizeof(buf) - 1, "%s$", user_name);
^~~~~~~~
../source3/utils/smbpasswd.c:397:35: error: ‘$’ directive output may be truncated writing 1 byte into a region of size between 0 and 255 [-Werror=format-truncation=]
slprintf(buf, sizeof(buf)-1, "%s$", user_name);
^
In file included from ../source3/include/includes.h:23,
from ../source3/utils/smbpasswd.c:19:
../lib/replace/../replace/replace.h:514:18: note: ‘snprintf’ output between 2 and 257 bytes into a destination of size 255
#define slprintf snprintf
../source3/utils/smbpasswd.c:397:3: note: in expansion of macro ‘slprintf’
slprintf(buf, sizeof(buf)-1, "%s$", user_name);
^~~~~~~~
cc1: some warnings being treated as errors
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 9b6dc8f504c406ed8a044e5becca7e8f01da6c84)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c16e479f49f5bf010f61a923435ca16393747340">c16e479f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-20T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Fix string check in mkdir_p()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 7cec343a89a0862c09f5ddd4707eb442157a4af2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3ef6d6ab6dc1d8f220d0d9e3c8e47af682f3e115">3ef6d6ab</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-20T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use strlcpy() in gen_name()
../source4/torture/basic/mangle_test.c: In function ‘gen_name’:
../source4/torture/basic/mangle_test.c:148:3: error: ‘strncpy’ output
truncated before terminating nul copying 5 bytes from a string of the
same length [-Werror=stringop-truncation]
strncpy(p, "ABCDE", 5);
^~~~~~~~~~~~~~~~~~~~~~
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 7a00d90d668f53914ffe035c41a5e79e60b51521)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aff126166a1539504e0d471b890f28d21f649648">aff12616</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-20T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Use memcpy() in escape_ldap_string()
../source3/lib/ldap_escape.c: In function ‘escape_ldap_string’:
../source3/lib/ldap_escape.c:79:4: error: ‘strncpy’ output truncated
before terminating nul copying 3 bytes from a string of the same length
[-Werror=stringop-truncation]
strncpy (p, sub, 3);
^~~~~~~~~~~~~~~~~~~
We concatenat and do not care about NUL-termination till the loop has
finished.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit ff7568daaeb19ff30f47f7f600ead247eaf4e826)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa833e8b00cf5ce0b363328a20f42390e0ea63d1">aa833e8b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-20T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:passdb: Fix size of ascii_p16
../source3/passdb/pdb_smbpasswd.c: In function ‘mod_smbfilepwd_entry’:
../source3/passdb/pdb_smbpasswd.c:1015:7: error: ‘:LCT-’ directive
output may be truncated writing 5 bytes into a region of size between 0
and 255 [-Werror=format-truncat ion=]
"%s:LCT-%08X:",
^~~~~
../source3/passdb/pdb_smbpasswd.c:1015:4: note: using the range [0,
4294967295] for directive argument
"%s:LCT-%08X:",
^~~~~~~~~~~~~~
In file included from ../source3/include/includes.h:23,
from ../source3/passdb/pdb_smbpasswd.c:23:
../lib/replace/../replace/replace.h:514:18: note: ‘snprintf’ output
between 15 and 270 bytes into a destination of size 255
#define slprintf snprintf
../source3/passdb/pdb_smbpasswd.c:1013:3: note: in expansion of macro ‘slprintf’
slprintf(&ascii_p16[strlen(ascii_p16)],
^~~~~~~~
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 728297ca889b39ce2006778bf6a5bf1c3ce82d6d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ca1acededa6905927c7768e1a33bee5358013ebe">ca1acede</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-20T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Fix uninitialzed variable warning
Raised by GCC8.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 6b728b87bf5726f14100d76956c3df3fd9bb1058)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/05dab794c2f15701f5ecb3909e4fa714b74c16c8">05dab794</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-20T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Fix parameter aliasing in tfork test
../lib/util/tests/tfork.c:483:24: error: passing argument 1 to
restrict-qualified parameter aliases with argument 4 [-Werror=restrict]
ret = pthread_create(&threads[i],
^~~~~~~~~~~
../lib/util/tests/tfork.c:486:10:
(void *)&threads[i]);
~~~~~~~~~~~~~~~~~~~
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 6f06a0154f5769cb85f6e189eecd78cd7805090a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/15c13f7372ca6c980d38a3be83225eb3cfd18f21">15c13f73</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-20T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Fix size types in debug.c
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit fb6cd9c44ac6fcc9f6abe3b63fc742aeac42969a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fd836721cf2a3d4e08f7fa6486aa98c306a6f8cb">fd836721</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-20T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:ntvfs: Fix string copy of share_name
../source4/ntvfs/ipc/rap_server.c:70:3: error: ‘strncpy’ specified bound 13 equals destination size [-Werror=stringop-truncation]
strncpy((char *)r->out.info[j].info1.share_name,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
snames[i],
~~~~~~~~~~
sizeof(r->out.info[0].info1.share_name));
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 609ef35c12900bbd5ecaa557f7b5d71b5784a103)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e3d52f547805a2ee0ea5389ced05b5237fb0eac">0e3d52f5</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-20T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Fix array size in audit_logging
../lib/audit_logging/audit_logging.c: In function ‘json_add_timestamp’:
../lib/audit_logging/audit_logging.c:603:12: error: ‘%s’ directive
output may be truncated writing up to 9 bytes into a region of size
between 0 and 43 [-Werror=format-truncation=]
"%s.%06ld%s",
^~
../lib/audit_logging/audit_logging.c:606:3:
tz);
~~
../lib/audit_logging/audit_logging.c:600:2: note: ‘snprintf’ output
between 8 and 70 bytes into a destination of size 50
snprintf(
^~~~~~~~~
timestamp,
~~~~~~~~~~
sizeof(timestamp),
~~~~~~~~~~~~~~~~~~
"%s.%06ld%s",
~~~~~~~~~~~~~
buffer,
~~~~~~~
tv.tv_usec,
~~~~~~~~~~~
tz);
~~~
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 8b7c8eb3907e2123acee67949e88c26072afc81a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e5ffffddfe580698624c832ad9b2e32c93fd5974">e5ffffdd</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-06-20T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Add DELETE-PRINT test.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13457
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 42f049858f2037aab5b2097036db3e0375fdbf30)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6121a6fec193b28e04329a4fde4ea058b9b7cfec">6121a6fe</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-06-20T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: printing: Re-implement delete-on-close semantics for print files missing since 3.5.x.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13457
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jun 1 20:32:03 CEST 2018 on sn-devel-144
(cherry picked from commit 364175b359f018c8641359440fa07b0ea567b045)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f32430cb99fdae882889b8dc460883dc1511906">7f32430c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-06-20T11:53:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Fix talloc frame use in make_simple_acl().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13474
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
This was fixed differently by commit
539f51f0dfbe4ce317a2978982fd0fc9a7fd6922 in master.
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Wed Jun 20 13:53:29 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/defc1ced3928e074d7a229bffc168933c513553f">defc1ced</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-06-20T15:48:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">heimdal: remove include/includedir directives for krb5.conf
The original heimdal code introduces a segmentation fault, due to an
uninitialized pointer. This code does not seem to be tested very well.
Revert "heimdal: Add include/includedir directives for krb5.conf"
This reverts commit 0a6e9b6c0e15fa6fe46acdd357d76b8df447317f.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Björn Baumbach <bbaumbach@samba.org>
Autobuild-Date(master): Wed Jun 20 17:48:16 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bca97cc4738fb4461fd27b6df9556f3e1377519d">bca97cc4</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-06-20T19:05:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Possible memory leak in map_info3_to_validation
In case of a failing call to copy_netr_SamInfo3, the allocated memory
for "validation" needs to be free'd before returning.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jun 20 21:05:40 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/76828876faa3cd463023e323983df0be597c7361">76828876</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-20T20:22:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samdb: Fix build error with gcc8
../source4/dsdb/samdb/ldb_modules/samldb.c: In function ‘samldb_add’:
../source4/dsdb/samdb/ldb_modules/samldb.c:424:6: error: ‘found’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
if (found) {
^
../source4/dsdb/samdb/ldb_modules/samldb.c:348:11: note: ‘found’ was declared here
bool ok, found;
^~~~~
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/29f6842ee86b768f3677b38c5640655e312c398e">29f6842e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-20T20:22:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:registry: Fix buffer truncation issues issues with gcc8
../source3/registry/reg_perfcount.c: In function ‘reg_perfcount_get_hkpd’:
../source3/registry/reg_perfcount.c:337:29: error: ‘snprintf’ output may be truncated before the last format character [-Werror=format-truncation=]
snprintf(buf, buflen,"%d%s", key_part1, key_part2);
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a3164e0beea35c1f4ce44fbe43547f7104587d1">4a3164e0</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-20T20:22:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbget: Fix buffer truncation issues with gcc8
../source3/utils/smbget.c: In function ‘smb_download_file’:
../source3/utils/smbget.c:97:27: error: ‘b’ directive output may be truncated writing 1 byte into a region of size between 0 and 19 [-Werror=format-truncation=]
snprintf(buffer, l, "%jdb", (intmax_t)s);
^
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c1c764925e24788905ab91aa455b415765d6f71f">c1c76492</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-20T23:03:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Fix regression introduced with bso #12851
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12851
Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Jun 21 01:03:52 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/47c315551745d624a8bf2eb77c7c829163ac5e9e">47c31555</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-06-21T11:08:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Don't use getcwd() directly. We must always go through the VFS.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5e89a23ffaceccdc83d70a4ab2798ae25c10d580">5e89a23f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-21T13:52:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_plugin: Add winbind localauth plugin for MIT Kerberos
Applications (like OpenSSH) don't know about users and and
their relationship to Kerberos principals. This plugin allows that
Kerberos principals can be validated against local user accounts.
Administrator@WURST.WORLD -> WURST\Administrator
https://web.mit.edu/kerberos/krb5-latest/doc/plugindev/localauth.html
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13480
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Jun 21 15:52:02 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fb3ddb48741e9e9699cf6efab70192a45f49573e">fb3ddb48</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-06-22T09:57:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: replace talloc / memcpy by talloc_memdup
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Jun 22 11:57:19 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/97eaeea6a130871cfac5be42459380c0c4e0fae6">97eaeea6</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-06-22T22:57:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_wrap: fix keep_old_entries logic for older kerberos libraries
MIT kerberos 1.13 and older only stores 8 bits of the KVNO. The change
from commit 35b2fb4ff32 resulted in breakage for these kerberos
versions: 'net ads keytab create' reads a large KVNO from AD, and only
the lower 8 bits are stored. The next check then removed the entry again
as the 8 bit value did not match the currently valid KVNO.
Fix this by limiting the check to only 8 bits.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13478
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Sat Jun 23 00:57:47 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b52d21e6040699a72aff12fd6ebb34534dcb457">6b52d21e</a></strong>
<div>
<span>by Andrej Gessel</span>
<i>at 2018-06-23T00:00:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: check return values
Signed-off-by: Andrej Gessel <Andrej.Gessel@janztec.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f75e8f58cd2390c092631803d333adadb475306a">f75e8f58</a></strong>
<div>
<span>by Andrej Gessel</span>
<i>at 2018-06-23T00:00:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">check return value before using key_values
there are also mem leaks in this function
Signed-off-by: Andrej Gessel <Andrej.Gessel@janztec.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/05b54cc259645f69e14de2703724c284ed25838c">05b54cc2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-06-23T02:56:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc_stack: Call talloc destructors while frame is still around
This fixes "samba-tool ntacl set -d10"
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Jun 23 04:56:44 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1bb2a1c6b3eaccf114ac3f3b5b51f57828a04996">1bb2a1c6</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-25T06:32:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: For NTLM and KDC authentication, log the authentication duration
This is not a general purpose profiling solution, but these JSON logs are already being
generated and stored, so this is worth adding.
Some administrators are very keen to know how long authentication
takes, particularly due to long replication transactions in other
processes.
This complements a similar patch set to log the transaction duration.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b282bcbb759bbb12797922e066aeb12c0df5b2f1">b282bcbb</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-06-25T09:16:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Log the transaction duraton.
This is not a general purpose profiling solution, but these JSON
logs are already being generated and stored, so this is worth adding.
This will allow administrators to identify long running
transactions, and identify potential performance bottlenecks.
This complements a similar patch set to log authentication duration.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Jun 25 11:16:18 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/df16008c2368387c524cab4ff8660c9538a5060a">df16008c</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-06-25T11:07:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">bla
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/228e5d4f75bd8e02ea06fe2ebb1ae41038c369d9">228e5d4f</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-06-25T11:07:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_wrap: fix keep_old_entries logic for older kerberos libraries
MIT kerberos 1.13 and older only stores 8 bits of the KVNO. The change
from commit 35b2fb4ff32 resulted in breakage for these kerberos
versions: 'net ads keytab create' reads a large KVNO from AD, and only
the lower 8 bits are stored. The next check then removed the entry again
as the 8 bit value did not match the currently valid KVNO.
Fix this by limiting the check to only 8 bits.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13478
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Sat Jun 23 00:57:47 CEST 2018 on sn-devel-144
(cherry picked from commit 97eaeea6a130871cfac5be42459380c0c4e0fae6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0196569dbe834a9d3de075fd279f6fdcb1774874">0196569d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-25T11:07:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_plugin: Add winbind localauth plugin for MIT Kerberos
Applications (like OpenSSH) don't know about users and and
their relationship to Kerberos principals. This plugin allows that
Kerberos principals can be validated against local user accounts.
Administrator@WURST.WORLD -> WURST\Administrator
https://web.mit.edu/kerberos/krb5-latest/doc/plugindev/localauth.html
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13480
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 5e89a23ffaceccdc83d70a4ab2798ae25c10d580)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bed29aba47558252eacfe9453d23cc1ab29770aa">bed29aba</a></strong>
<div>
<span>by Andreas Hasenack</span>
<i>at 2018-06-25T14:10:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">- d/samba.logrotate: only try to reload the services if they are running
(Closes: #902149)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be00b892e9183e1980b8445a071003fc56f439e5">be00b892</a></strong>
<div>
<span>by Jeffrey Altman</span>
<i>at 2018-06-25T15:30:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">heimdal: lib/krb5: do not fail set_config_files due to parse error
Follow Apple's lead and do not fail krb5_set_config_files() simply
because one of the files in the profile list fails to parse correctly.
Doing so can lead to hard to find failures and could lead to an end
user shooting themselves in the foot and no longer be able to login
to their system to fix it.
Parse as many of the files as we can. Only fail krb5_set_config_files()
if init_context_from_config_file() fails.
Change-Id: I122664c6d707a5f926643808ba414bf4f681f8b8
Cherry-pick of Heimdal commit b7cf5e7caf9b270f4d4151d2690177b11a7a1bdf
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11573
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit f05a1554b770c6a2c905170347bfb41157f4aa78)
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Mon Jun 25 17:30:14 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5f2859e958e110952b73b785975420a350497cc8">5f2859e9</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-25T19:47:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:registry: Fix buffer truncation issues issues with gcc8
../source3/registry/reg_perfcount.c: In function ‘reg_perfcount_get_hkpd’:
../source3/registry/reg_perfcount.c:337:29: error: ‘snprintf’ output may be truncated before the last format character [-Werror=format-truncation=]
snprintf(buf, buflen,"%d%s", key_part1, key_part2);
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 29f6842ee86b768f3677b38c5640655e312c398e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/941b5663ca9cdbd347d8f65d6c92f4a3f36ed31a">941b5663</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-25T19:47:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbget: Fix buffer truncation issues with gcc8
../source3/utils/smbget.c: In function ‘smb_download_file’:
../source3/utils/smbget.c:97:27: error: ‘b’ directive output may be truncated writing 1 byte into a region of size between 0 and 19 [-Werror=format-truncation=]
snprintf(buffer, l, "%jdb", (intmax_t)s);
^
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 4a3164e0beea35c1f4ce44fbe43547f7104587d1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ee6bd861f3e1f1c3de86fe05976ba22119ba2429">ee6bd861</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-25T19:47:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Fix regression introduced with bso #12851
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12851
Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit c1c764925e24788905ab91aa455b415765d6f71f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8a86aad490a5e28c9fdd74dd01bef06c4b75180f">8a86aad4</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-06-25T20:57:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge branch 'logrotate-with-services-stopped-902149' into 'master'
logrotate: only try to reload the services if they are running
See merge request samba-team/samba!8</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5bb60e2dd714862c3cda69a42f0f58fa4e7d816d">5bb60e2d</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-25T21:01:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Move --without-json-audit and json lib detection to lib/audit_logging
This is the common location of the audit logging code now
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a2783fe1a3a93c6e3d106b2ab23c8c9acd3d382b">a2783fe1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-25T21:01:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/audit_logging: Require jansson JSON library for building the AD DC
This combination is untested and it is reasonable to require this
broadly available library for the AD DC build.
Doing so keeps the combinational complexity down and ensures we test
what we ship. (It was failing to compile).
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b650ea5398bbe11dcf7b75d4bfd04649fb6dae7c">b650ea53</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-25T21:01:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/audit_logging: Only build audit_logging_test for --enable-selftest on the AD DC
This allows a --without-ad-dc --enable-selftest build to compile, still testing some
fileserver-only features.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b9a9a4d08f32ed12655aa930a2a9457d9ece3c3">6b9a9a4d</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-25T21:01:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Ensure a build --without-json-audit --without-ad-dc compiles
We still build some of the ldb_modules even when we are not a DC, so we must
split up the DSDB_MODULE_HELPERS.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f33749fc84dacb164d1ac43f6bfcae7afcca34b3">f33749fc</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-26T00:03:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Build samba-fileserver --without-json-audit
This build target is already --without-ad-dc and is the one we need to ensure is
compatible with a host without the Jansson JSON library.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Jun 26 02:03:30 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b32d297f12ff16bb4139afd0a16548a27ed39b9">8b32d297</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-26T00:26:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samdb: Fix build error with gcc8
../source4/dsdb/samdb/ldb_modules/samldb.c: In function ‘samldb_add’:
../source4/dsdb/samdb/ldb_modules/samldb.c:424:6: error: ‘found’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
if (found) {
^
../source4/dsdb/samdb/ldb_modules/samldb.c:348:11: note: ‘found’ was declared here
bool ok, found;
^~~~~
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 76828876faa3cd463023e323983df0be597c7361)
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Tue Jun 26 02:26:15 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/450210c39a31ac5e0d9cf576fdd4c90965a2f79c">450210c3</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-26T01:27:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">audit_logging: Clarify debug messages
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4f50848680605dfde8233f8b64a4fc1e79df6276">4f508486</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-26T01:27:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">audit_logging: Remove incorrect check for NT_STATUS_OBJECT_NAME_NOT_FOUND
NT_STATUS_OBJECT_NAME_NOT_FOUND is not a case we can ignore, it would mean that event_server
is not initialised.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dad73e0b681cef247c83be5e2d6165922b2fb545">dad73e0b</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-26T01:27:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">audit_logging: Initialise event_server
It is better if this is a known zero value to start, even if we check the errors
correctly.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4b077e07a0d295c8894dc842935612b4b768ebd8">4b077e07</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-26T01:27:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">audit_logging: Remove duplciate error printing
These errors are already logged at DBG_NOTICE in get_event_server()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d38160c968cd78e179754f39576359a51619bc9f">d38160c9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-26T01:27:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Use correct memory context for imessaging_client_init() in audit logging
This is only used for selftest, to send out the log messages for checking.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d2468f732fb8a33fa28648b4928bd3a8a1e599ff">d2468f73</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-26T01:27:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Use customary variable names for audit event contexts
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2c883bd9788d0142836af70599ade4aa3bad3d39">2c883bd9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-26T01:27:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Use customary variable names for the audit private context
The variable name "ac" typically implies the async context, and the long-life
private context is normally denoted private, not context. This aligns better
with other modules.
talloc_get_type_abort() is now also used.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d18bae916981a73cdad1103b866a9afabd9e0519">d18bae91</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-26T01:27:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Use GUID_zero() rather than memset in dsdb audit code
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/120fe41073039e8ed915fde1fff356aeaf2781e9">120fe410</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-26T01:27:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb-audit: Remove flapping part of the tests
Because we have tests for this in the auth audit code, we do not need to have
the complexity of checking that we got DCE/RPC over SMB as an authorization
message here.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/113da7ac67a79deb71e3bfb2def9abd85655f36f">113da7ac</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-06-26T04:09:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb audit: Fix timestamp tests
Fix flapping test:
[242(3560)/242 at 25m3s] samba4.dsdb.samdb.ldb_modules.audit_log
UNEXPECTED(failure):
samba4.dsdb.samdb.ldb_modules.audit_log.test_operation_json_empty(none)
REASON: Exception: Exception: difftime(after, actual) >= 0
../source4/dsdb/samdb/ldb_modules/tests/test_audit_log.c:74: error:
The tests truncate the microsecond portion of the time, so the
difference could be less than 0.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Jun 26 06:09:46 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c1d9b0b9acd5f4a1d2030f23829183cbbeb072d">5c1d9b0b</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-26T07:19:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Save a copy of the index result before calling the callbacks.
Otherwise Samba modules like subtree_rename can fail as they modify the
index during the callback.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13452
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit d02cd236dcbd8a44ecc85d1f7e95a48c95c0a479)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d1b59c266b2076a286ff971769b9380c834c29ee">d1b59c26</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-26T07:19:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Indicate that the ltdb_dn_list_sort() in list_union is a bit subtle.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit 3632775d7ad31e06437ed76b8731d9895930caa1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/703ca1a427a468f763538f1371c388d25745b2dd">703ca1a4</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-26T07:19:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Explain why an entry can vanish from the index
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit 9e143ee9b9f7be53c193cee3153f64c4dedc07e9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b8df3cd999c2dd56f77d90fcdc264decc233834e">b8df3cd9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-26T07:19:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: One-level search was incorrectly falling back to full DB scan
When no search filter is specified, the code falls back to using
'(|(objectClass=*)(distinguishedName=*)'. ltdb_index_dn() then failed
because matching against '*' is not indexed. The error return then
caused the code to fallback to a full-scan of the DB, which could have a
considerable performance hit.
Instead, we want to continue on and do the ltdb_index_filter() over the
indexed results that were returned.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13448
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit 88ae60ed186c9c479722ad62d65a07d0c2e71469)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b4331a3a9e1ceb1765a4b6a4ddeae4971b8a41f1">b4331a3a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-26T07:19:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Add tests for when we should expect a full scan
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13448
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit e99c199d811e607e7867e7b40d82a1642226c647)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1fb72464150bb64effa79a2c07b83f7167e1b75b">1fb72464</a></strong>
<div>
<span>by Lukas Slebodnik</span>
<i>at 2018-06-26T07:19:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Fix memory leak on module context
Introduced in e8cdacc509016d9273d63faf334d9f827585c3eb
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13459
Signed-off-by: Lukas Slebodnik <lslebodn@fedoraproject.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Jun 1 11:10:24 CEST 2018 on sn-devel-144
(cherry picked from commit d161aa3522576545d269208426bb0014ee2ab35f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b5f368a62b644825e6a04ab31d2cbbf72a196ae">9b5f368a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-26T07:19:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Use mem_ctx and so avoid leak onto long-term memory on duplicated add.
After a duplicated add a small amount of memory can be leaked onto a
long-term context.
Found by Andrej Gessel https://github.com/andiges
https://github.com/samba-team/samba/commit/e8fb45125e6a279b918694668e0d4fbddac10aee#commitcomment-29334102
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13471
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jun 15 04:39:41 CEST 2018 on sn-devel-144
(cherry picked from commit f4f3abfa0e18bb4968b37b1cac40cd8c185c8d7b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a1906d92412f32a2e481b1ad4178bed0b87d0ca">7a1906d9</a></strong>
<div>
<span>by Andrej Gessel</span>
<i>at 2018-06-26T07:19:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: check return values
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13475
Signed-off-by: Andrej Gessel <Andrej.Gessel@janztec.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 6b52d21e6040699a72aff12fd6ebb34534dcb457)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a3f91ea027eb1d24568b96036801d3f9e5a13f2">2a3f91ea</a></strong>
<div>
<span>by Andrej Gessel</span>
<i>at 2018-06-26T07:19:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">check return value before using key_values
there are also mem leaks in this function
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13475
Signed-off-by: Andrej Gessel <Andrej.Gessel@janztec.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit f75e8f58cd2390c092631803d333adadb475306a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ccd1eb5393f76642a96db0037d9f4b3bb10709a">7ccd1eb5</a></strong>
<div>
<span>by Andrej Gessel</span>
<i>at 2018-06-26T07:19:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix several mem leaks in ldb_index ldb_search ldb_tdb
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13475
Signed-off-by: Andrej Gessel <Andrej.Gessel@janztec.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Jun 15 23:07:25 CEST 2018 on sn-devel-144
(cherry picked from commit 3ca1c09f686fbfa9257cd95710dba4a98c3eeb8f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fb522c1ba0afa1b2298e66dfde42806cae72e5b9">fb522c1b</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-26T07:19:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">.gitlab-ci.yml: Adapt to current GitLab CI setup
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e25631d6be56374b69209afafda0fc4485bc8b54">e25631d6</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-26T11:31:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: version 1.3.4
* Fix memory leaks and missing error checks (bug 13459, 13471, 13475)
* Fix fallback to full scan (performance regression) on
one-level search (bug 13448)
* Fix read corruption (missing results) during writes, particularly
during a Samba subtree rename (bug 13452)
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Tue Jun 26 13:31:53 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e268d4354bece5b715c1260fe4893471881f607c">e268d435</a></strong>
<div>
<span>by Andreas Hasenack</span>
<i>at 2018-06-26T12:26:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Remove the deprecated "syslog" and "syslog only" options (Closes: #901138)
Remove the deprecated "syslog only" and "syslog" global options from
debian/smb.conf and replace them with the "logging" statement. The same logging
behaviour remains after this change.
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/519bc4de949d0ac9ed1b928e54cc8e493e168ad7">519bc4de</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-06-26T14:37:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.8.3.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1df7f93b6ede803ec01424c48d2f1f3526c9818c">1df7f93b</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-06-26T14:38:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.8.4...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a62c2f3e97d3d779fe0d71162f61987da2645a85">a62c2f3e</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-06-26T14:38:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.8.3 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/89a8b3ecd47b6d9a33e66f22d2786f0ae3b4cb72">89a8b3ec</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2018-06-26T15:43:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:client: Add --quiet option to smbclient
Add quiet command-line argument to allow suppressing the help log
message printed automatically after establishing a smbclient connection
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13485
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Björn Baumbach <bb@sernet.de>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f90f434e041461fbea2e101066c79ec8caf35cce">f90f434e</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2018-06-26T18:29:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:tests: Add test for smbclient --quiet
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13485
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Björn Baumbach <bb@sernet.de>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Jun 26 20:29:19 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/562ec950fc27ae498c53a2188329530651e64e05">562ec950</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-06-26T21:32:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">remove_dc: Fix removal of an old Windows DC
Windows has 'CN=DNS Settings' child object underneath the Server object.
This was causing the removal of the server object in remove_dc() to
fail.
Noticed this problem while testing the backup/restore tool manually
against a Windows VM.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13484
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Tue Jun 26 23:32:51 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d9914b9b6a66aebab367bcdc535bf8eaaa46abeb">d9914b9b</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-27T05:51:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update .travis.yml to match package list used in docker container and Catalyst Cloud builds
The package list has some "strange" things in them, but more important is
using the same list everywhere. We can hopefully harmonise the package lists
to a single file in Samba git soom, merging the docker and packer image creation.
Additionally, Travis CI will probably need to move to Docker once we change
beyond Ubuntu 14.04, so it will simple reference the gitlab.com image then.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Wed Jun 27 07:51:14 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eba2eb8a15c7a25b1436907a5339241492c81097">eba2eb8a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-27T14:00:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_plugin: Install plugins to krb5 modules dir
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13489
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a7e0f259bb7f1ebce48523767262addda08fe14">4a7e0f25</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-27T14:00:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_plugin: Move krb5 locator plugin to krb5_plugin subdir
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13489
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b7fcec01524ea1c4f2d923cc9cc2c17af3c3a21">6b7fcec0</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-27T14:00:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Move winbind_krb5_locator manpage to volume 8
The vfs and idmap manpages are in volume 8 too.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13489
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e88d68c253b4398eaed701d1a9bcc1b83882e127">e88d68c2</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-06-27T16:45:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Add manpage for winbind_krb5_localauth.8
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13489
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Jun 27 18:45:56 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8e58954f2f4a41baaf4007dc09b7cf9349e98077">8e58954f</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-06-28T01:34:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add test that Samba cannot be started with a backup DB
We don't want users to take a backup file, and then simply untar it and
run Samba (Several modifications to the DB need to be made as part of
the restore process, so users should always run the 'backup restore'
command).
To enforce this, prime_ldb_databases() now refuses to start Samba if the
backupDate marker is present in the DB. This patch adds a test-case that
proves this basic behaviour works.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f0aad4a18736cbcbb3c87dd03cf24ae190fe8b4f">f0aad4a1</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-06-28T01:34:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba: read backup date field on init and fail if present
This prevents a backup tar file, created with the new official
backup tools, from being extracted and replicated.
This is done here to ensure that samba-tool and ldbsearch can
still operate on the backup (eg for forensics) but starting
Samba as an AD DC will fail.
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5728867ddcc4487bde53a11cf865563b59624eb1">5728867d</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-06-28T01:34:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">param: Add non-global smb.cfg option (support 2 different smb.confs)
The default behaviour is that there is only a single global underlying
LoadParm object. E.g. if you create 2 different LoadParm objects in
python, they both modify the same underlying object.
This patch adds a mechanism to override this and create a separate
non-global LoadParm object. The use-case is the backup tool, where we
want to manipulate 2 different smb.conf files (the one used to create
the backup, and the smb.conf in the backup itself).
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/66f8c86e9af21102a86a22343350e4ff1b1daf61">66f8c86e</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-06-28T01:34:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add basic test for non-global LoadParm behaviour
Add a simple test to show that the new non-global LoadParm behaviour
works, i.e.
- by default all LoadParm objects are linked to the same underlying
object
- using a non-global LoadParm creates a separate underlying object.
- using a non-global LoadParm with a bad filename fails.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c9cf62bd3a046fef67c1fcea6432f2ee71333876">c9cf62bd</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-06-28T01:34:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Update MAX_WRAPPED_INTERFACES comment to match code
Commit 19606e4dc657b0baf3ea84d updated the MAX_WRAPPED_INTERFACES define
in the C code from 40 to 64.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b07ddde47432cb4637325c6606f46922b8fe3da">8b07ddde</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-06-28T04:22:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">provision: set 'binddns dir' when making new smb.conf
When creating a new smb.conf from scratch during a join/clone/etc, the
'binddns dir' setting still uses the source smb.conf/default setting,
instead of the targetdir sub-directory.
I noticed this problem when trying to create a new testenv - the
provision() was trying to create /usr/local/samba/bind-dns directory,
which would fail if samba hadn't already been installed on the host
machine.
Now that this is fixed, we also need to fix tests that were explicitly
asserting that no unexpected directories were left behind after the test
completes.
This change also breaks the upgradeprovision script. The upgrade-
provision calls newprovision() to create a reference provision in a
temporary directory. However, previously this temporary provision was
creating the bind-dns directory in the actual upgrade directory as a
side-effect, e.g. it did a provision() with
targetdir=alpha13_upgrade_full/private/referenceprovisionLBKBh2 and this
ended up creating alpha13_upgrade_full/bind-dns as a side-effect.
The provision() now creates bind-dns in the specified targetdir, but
this means check_for_DNS() fails (it tries to create bind-dns sub-
directories, but the upgrade's bind-dns doesn't exist). I've avoided
this problem by making sure bind-dns exists as part of the
check_for_DNS() processing.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Jun 28 06:22:16 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2403b7c4fd5bdb77493a581115f4e902dba6528f">2403b7c4</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-28T04:29:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs showrepl: add a --color flag
Nothing is using it yet, but the next commit will
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b62b3da976e1d14f809406ce0e87aac3d38846da">b62b3da9</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-28T04:29:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs showrepl --summary for a quick local check
The default output ("classic") gives you a lot of very uninteresting
detail when everything is fine. --summary shuts up about things that
are fine but shouts a little bit when things are broken. It doesn't
provide any new information, just tries to present it in a more useful
format.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3a1b710eacc38c868e4b09848e751fdb5733cd98">3a1b710e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-28T04:29:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs show_repl: simplify the collection of DC lists
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/79c1c0c914d5658d9981cb76d671e7f3a4ae8678">79c1c0c9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-28T04:29:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs showrepl: Skip deleted DSAs when checking for success
The deleted DSAs are ignored by the server replication code, so ignore past failures
here also.
The repsFrom and repsTo entries will eventually be removed by the KCC.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f08e3d6db56fd4c64af8ba0d2d6a99b98fb696ad">f08e3d6d</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-28T04:29:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs showrepl test: remove useless print
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da30b37e68baee90102a95a3e62ef537b36c06af">da30b37e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-28T04:29:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs/python: don't double-call enable/disable replication
This is repeating work done in setup/teardown or doubling up in place (self._enable_all_repl includes self._enable_inbound_repl)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5fcd374602bf75facfe98cc4736cbcdd3c2bba4a">5fcd3746</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-28T04:29:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/samba_tool_drs_showrepl: use assertRegexpMatches
rather than a local rewrite special to this file.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2c9eeedc84820d2d99c5e5fe5c19c0d58901b754">2c9eeedc</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-06-28T04:29:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs showrepl: add --pull-summary and --notify-summary
These separate the two halves of --summary (which is still there),
allowing the repsto and repsfrom to be separately queried.
One motivation for this is testing: it is difficult to assert the
success of repsfrom (--notify-summary) in the test framework, because
we can't rely on the other end behaving properly and promptly.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/211275fae6895cdedbbe25ca3e41d0a856c1a370">211275fa</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-06-28T07:23:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool showrepl tests: test all-good with --pull-summary
We test the all-good case with --pull-summary, which is the only one
we can be reasonably certain about.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Thu Jun 28 09:23:10 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4320dcc4bc32ef26c2bd512b94e3bc9aedb9d192">4320dcc4</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-06-28T07:25:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmb: add py_smb_unlink and test
Add unlink api to delete a file with a smb connection.
Test added.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f1566c2ef9af0ca86778a58f855e1602ac43c3c2">f1566c2e</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-06-28T07:25:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: add py_smbd_mkdir
Add mkdir for smbd API.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/747c3f1fb379bb68cc7479501b85741493c05812">747c3f1f</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-06-28T07:25:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: extract init_files_struct function
Extract initialization code from set_nt_acl_conn for reuse.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1078c969abfa2f6c24e66eb7c2cafa6d1dc31f81">1078c969</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-06-28T07:25:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: add py_smbd_create_file
Add create_file function to smbd API.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/132fa04c77c9428dcbc30c3b4abc4ff91467c3cf">132fa04c</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-06-28T07:25:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ntacls: add functions to backup and restore ntacls
1. backup a share online from a smb connection with ntacls using pysmb API.
2. backup a share offline from service path with ntacls using pysmbd API.
3. restore from tarfile with pysmdb API.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b3346158c6fde072b9cfbd888d24c268eae326f3">b3346158</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-06-28T07:25:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ntacls: add extra test file for ntacls backup
The ntacls backup tests have to run in ad_dc:local env, which is
different from existing ntacls tests. Add a separate file for backup
tests.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/178c7d4f2b3d904f62525a30c431678bb0ec0230">178c7d4f</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-06-28T07:25:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntacls_backup: register test
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3262f01d3667debe1b273f509c92ef55ac024d81">3262f01d</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-06-28T07:25:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntacls: use global vars to make code DRY
Move acl and dommain_sid to global vars so we don't repeat them in every
test.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/975b751bb60c935f2ef5b86fa27dc19b38cdc9d2">975b751b</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-06-28T10:14:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntacls: fix pep8 warnings
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Jun 28 12:14:59 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/396f123121ddb290f4a5536a2224aa4a651c072f">396f1231</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-06-28T13:04:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">README.Coding: Fix link to Python coding style guide (PEP 8)
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: David Mulder <dmulder@suse.com>
Autobuild-User(master): Björn Baumbach <bbaumbach@samba.org>
Autobuild-Date(master): Thu Jun 28 15:04:44 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b6b1226d394445c21e01fdf3010642c85dbe85dd">b6b1226d</a></strong>
<div>
<span>by Carlos O'Donell</span>
<i>at 2018-06-29T04:47:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Improve robust mutex test
This avoids some of the undefined behaviour, like initializing the same mutex
twice which happens when the low and high priority processes start (both
do the initialization and that's dangerous.) Instead now we start an
"init" process to start the shared memory segment, and then everything
else just uses it without truncation or unlinking (same mutex).
Signed-off-by: Carlos O'Donell <codonell@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Jun 29 06:47:00 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e84b5020a410b9c2cf736efee60ee704f8ea8f9c">e84b5020</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-06-29T13:12:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Correctly handle conf->reload()
Configuration reload should reset the values of configuration options
missing from the config file to default.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Jun 29 15:12:37 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c0a8098a923f8e3d83fffadeef4d07d47edba1c6">c0a8098a</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-07-01T12:16:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">New upstream version 4.8.3+dfsg</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f4254a0115b1f944821e164a97e2a80425c3489f">f4254a01</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-07-01T12:31:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge branch 'drop-deprecated-syslog-options' into 'master'
Drop deprecated syslog options from default smb.conf
See merge request samba-team/samba!7</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bc987f2c43a3104044ded619ce9a31d03d1ed17b">bc987f2c</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-07-01T12:31:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge tag 'upstream/4.8.3+dfsg'
Upstream version 4.8.3+dfsg
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f4f81546b2186f6a9fc87a300290b1156ab0b5e4">f4f81546</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-07-01T12:32:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Bump build-depends ldb >= 1.3.4
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fc0bfbb560160da6df3c15daa01dec03494533f0">fc0bfbb5</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-07-01T12:35:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb.conf: Remove wins support and wins server comments
WINS protocol is outdated and DNS is recommended.
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/43c26f853151ffe536e6a17fddfe4316452bd0a6">43c26f85</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-07-01T12:40:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb.conf: Improve "logging" comments
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/24b1422df678cac757429be9ffd9099236e1f77a">24b1422d</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-07-01T12:44:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Changelog for previous commits
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e21bce86a54fa943ef252ca01a8b1e831c74ba7d">e21bce86</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-07-01T12:47:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb.conf: Remove "dns proxy = no", only usefull as a WINS server
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/15a1abf3f7006efb2a552d04e09ead3dc359d973">15a1abf3</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-07-01T13:07:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb.conf: Propose better idmap config
We use tdb backend, as rid consumes too much uids, and ads requires SFU server-side.
We reserve uid < 3000 for local users. We reserve 65534 for nobody.
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/244976bf7969531eae8057957a7024be35d9deab">244976bf</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-07-01T13:12:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb.conf: Remove "passdb backend = tdbsam" as this is the default
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9e165f2738f15fe32319a6e6a7e745014e4c7f63">9e165f27</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-07-01T13:18:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb.conf: Fix "usershare max shares" default (patched to 100 instead of 0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7eeba9c5a4541e581b062fb9ee26f13b7373c541">7eeba9c5</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-02T06:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Add test for sin6_len in sockaddr_in6 structure
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/79992dbb73ac9749ac987cb6a88964fa600b4c35">79992dbb</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-02T06:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Use sin6_len only if the structure supports it
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/14868df9e5669eba3918f3bc27b73c8adcae432b">14868df9</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-02T06:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-build: Add checks for raw pkt handling support
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f697c2e1c6aa481b3619f4c3dfefcc850af69eb4">f697c2e1</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-02T06:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-build: Add ipv6 headers check for packet details
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/57834c64bef96d67dabe1ce22ced67e6544b8035">57834c64</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Rename system utility files
system_socket.[ch] will contain all the raw socket code and other
functions that use ctdb_sock_addr. system.[ch] will contain other
platform dependent functions.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2f0a4d20954bdcd5a6e8ea5c11224f5a2d4fe3d9">2f0a4d20</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Move parse_ip_mask() to system_socket.[ch]
This uses ctdb_sock_addr so belongs here.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8fcd12ba29cd1d23e0283cad187ae8d35c8c6fcc">8fcd12ba</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Move ctdb_system_check_iface_exists() to system.[ch]
The system_<os>.c files contain a lot of duplication, making
maintenance difficult. These functions are being merged into
system_socket.[ch] and system.[ch].
This function doesn't need ctdb_sock_addr so put it with general
system utilities.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d7d80451bc4fea12d313b911924ae89901d99a7">1d7d8045</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Move ctdb_get_peer_pid() to system.[ch]
The system_<os>.c files contain a lot of duplication, making
maintenance difficult. These functions are being merged into
system_socket.c and system.c.
This function doesn't need ctdb_sock_addr so put it with general
system utilities.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c51b278b1700cd5f3e2addc19b7c711cc2ea10b">9c51b278</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Move ctdb_sys_send_arp() to ctdb_socket.[ch]
The system_<os>.c files contain a lot of duplication, making
maintenance difficult. These functions are being merged into
system_socket.c and system.c.
Bring a copy of tcp_checksum6(), renamed to ip6_checksum().
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eafcc98b03f59e242d0bb004f765005a35190b6d">eafcc98b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Move ctdb_sys_send_tcp() to ctdb_socket.[ch]
The system_<os>.c files contain a lot of duplication, making
maintenance difficult. These functions are being merged into
system_socket.c and system.c.
Bring across tcp_checksum(), renamed to ip_checksum().
uint16_checksum() becomes static.
Use the BSD struct tcphdr field names for portability. See the
comment in the code for more details about how we get this to compile
on older glibc versions.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fa94a49dbbec4a65c368a533a534f952a9f147a7">fa94a49d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Move capture_socket functions to ctdb_socket.[ch]
The system_<os>.c files contain a lot of duplication, making
maintenance difficult. These functions are being merged into
system_socket.c and system.c.
Bring across ctdb_sys_open_capture_socket(),
ctdb_sys_close_capture_socket() and ctdb_sys_read_tcp_packet().
Remove empty system_<os>.c files.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/05a908d71c4b7484ba0243fa51bc05c79c8fb357">05a908d7</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Switch fake_ctdbd to use ctdb_get_peer_pid()
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/40a8ab1ce0c1b291af7263da13c25c37cee69670">40a8ab1c</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-02T06:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Fix build on AIX
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/edffe4d16514fa0c87655e040842f6c20d89791c">edffe4d1</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-02T06:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Fix build on AIX
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Here is the build error on AIX 7.1.
../../lib/tdb/tools/tdbtool.c:39:12: error: 'disable_lock' redeclared as different kind of symbol
static int disable_lock;
^~~~~~~~~~~~
In file included from /usr/include/sys/gfs.h:24:0,
from /usr/include/sys/vfs.h:27,
from ../../lib/replace/system/filesys.h:48,
from ../../lib/tdb/tools/tdbtool.c:26:
/usr/include/sys/lock_def.h:314:5: note: previous declaration of 'disable_lock' was here
int disable_lock(int,simple_lock_t);
^~~~~~~~~~~~
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/23adbaad998eef1d5dd327b77f83de290e18bb20">23adbaad</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop check for invalid event in 00.test event script
This isn't necessary and complicates the code.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/acd10a5d47bd3aae18bbe60c44481c7d2e264813">acd10a5d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Clean up argument validation in 00.test event script
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8888711e5749b2d949b819cc8142951c475adc51">8888711e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop unnecessary code in 00.test event script
This script is only used with local daemons.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/673b0e78e1c13bbf78a6a78698de1ca7a450c023">673b0e78</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add generic logging of event details in 00.test event script
No need for a separate case for each event just to log details.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9e1cbd922e10622511aec430a97d923f444aee58">9e1cbd92</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Clean up startup event in 00.test event script
Rewrite interface initialisation to avoid an error when there are no
interfaces configured. Re-indent case label.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f09579a5cddec2b678c8b1520d7ce7136b305ab">9f09579a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Support CTDB_RUN_TIMEOUT_MONITOR=yes in simple tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dfd39c9cd71648126f66be3c3b66c9589c3021b3">dfd39c9c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Enable event script debugging in local daemon tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff181a82f2b5907b6d98768f72ff2769c358c2c3">ff181a82</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Switch 90_debug_hung_script.sh to be a simple test
This test only runs against local daemons. Configuration is done via
script.options, which simplifies things quite a bit.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cd9930ea1d1cabbfa1a97c484c13b6773560dbbe">cd9930ea</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop 99.timeout event script
This is now implemented in local daemon testing.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b318cf22bad5ca2da54518e989b49b8e92f74646">b318cf22</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Set the process name correctly
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77db0b15b56f9921961bd753c210e6fdbaf97f6d">77db0b15</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-client: Fix typo where CTDB_BROADCAST_ALL is repeated
Surely this is meant to be CTDB_BROADCAST_CONNECTED?
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13499
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4b008556d6b1f07fd5057af845526bf941497f18">4b008556</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add check for non-lmaster node status in integration tests
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13499
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ec72fadecd5233234947633360fe46a3a4053c07">ec72fade</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add a simple test for database traverses
This tests that volatile databases traverse correctly, including the
case where a record was updated on a non-lmaster node.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13499
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/36938bfdd075a174daecb466085702adfe6a6c09">36938bfd</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-server: Rename CTDB_BROADCAST_VNNMAP -> CTDB_BROADCAST_ACTIVE
This broadcast is misnamed. Both places where this type of broadcast
is used expect the broadcast to go to all active nodes.
Make the corresponding change to the semantics in the daemon by
sending to all active nodes.
There is a mismatch between the ideas of VNN map and active nodes. A
node that is not in the VNN map but is active can still host database
records. These were the same until the LMASTER capability was
introduced and then the logic was not updated.
The only place where the VNN map is relevant is when finding the
location master of a record in the migration code.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13499
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/af446d5209e37a38363911e5f339869b73d87963">af446d52</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Fix the documentation for VNN map
It is incorrectly says that nodes not in the VNN map can not be
DMASTER.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13499
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/63255ef92552da92956c05160f33622d0bbc3a28">63255ef9</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T06:51:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Only consider client ID for local database attach
The comment immediately above this code says "don't allow local
clients to attach" and then looks up the client ID regardless of
whether the request is local or remote.
This means that an intentional remote attach from a client will not
work correctly. No real client should ever do that since clients
attach so they an access databases locally. Perhaps some sanity
checks should be added.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13500
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0b4a071ed1817bbc5523b259ca41c62a9e9b1f0b">0b4a071e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-02T09:30:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Teach strace packet parser about non-octal escapes
strace output also encodes characters 7 to 13 as \a, \b, \t, \n, \v,
\f, \r.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Mon Jul 2 11:30:29 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c7fd68088d84232a2f4074ca278b5448ef624afd">c7fd6808</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-03T03:24:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: Use symbolic control name for DSDB_CONTROL_DBCHECK_FIX_DUPLICATE_LINKS
While we do not wish to encourage use of this control, manually typed OIDs are
even more trouble, so pass out via pydsdb.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/22208f52e6096fbe9413b8ff339d9446851e0874">22208f52</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-03T03:24:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbchecker: Fixing up incorrect DNs wasn't working
dbcheck would fail to fix up attributes where the extended DN's GUID is
correct, but the DN itself is incorrect. The code failed attempting to
remove the old/incorrect DN, e.g.
NOTE: old (due to rename or delete) DN string component for
objectCategory in object CN=alice,CN=Users,DC=samba,DC=example,DC=com -
<GUID=7bfdf9d8-62f9-420c-8a71-e3d3e931c91e>;
CN=Person,CN=Schema,CN=Configuration,DC=samba,DC=bad,DC=com
Change DN to <GUID=7bfdf9d8-62f9-420c-8a71-e3d3e931c91e>;
CN=Person,CN=Schema,CN=Configuration,DC=samba,DC=example,DC=com?
[y/N/all/none] y
Failed to fix old DN string on attribute objectCategory : (16,
"attribute 'objectCategory': no matching attribute value while deleting
attribute on 'CN=alice,CN=Users,DC=samba,DC=example,DC=com'")
The problem was the LDB message specified the value to delete with its
full DN, including the GUID. The LDB code then helpfully corrected this
value on the way through, so that the DN got updated to reflect the
correct DN (i.e. 'DC=example,DC=com') of the object matching that GUID,
rather than the incorrect DN (i.e. 'DC=bad,DC=com') that we were trying
to remove. Because the requested value and the existing DB value didn't
match, the operation failed.
We can avoid this problem by passing down just the DN (not the extended
DN) of the value we want to delete. Without the GUID portion of the DN,
the LDB code will no longer try to correct it on the way through, and
the dbcheck operation will succeed.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13495
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Pair-programmed-with: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b2dc8e5d58e66b88b9e43cf628ce8b43639d7fdb">b2dc8e5d</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-03T03:24:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">provision: Small refactor to host-IP logic
Split out the code that determines the host-IP of the new server into
separate functions. This will allow us to re-use the same logic in the
backup/restore case.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bea990d296e3877d0517e03dbb6d4b02403dfed5">bea990d2</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-07-03T03:24:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">join: Pipe through dns_backend option for clones
Allow join_clone() calls to specify a dns_backend parameter for the new
cloned DB.
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3ee38df87d7a75ac72400c8f95d84e0622e074f5">3ee38df8</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-03T03:24:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">join: Rename dc_join() so it looks like an object
dc_join() is creating an object, but it currently looks like it's
just a function call. Rename it to look more object-like.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3230c345da33a6ebd444791d04df5e0e408102dd">3230c345</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-03T03:24:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">join: Refactor clone_only case to simplify code
Currently for DC clones, we create a regular DCJoinContext, se a
'clone_only' flag, and then make lots of special checks for this flag
throughout the code. Instead, we can use inheritance to create a
DCCloneContext sub-class, and put the specialization there.
This means we can remove all the 'clone_only' checks from the code. The
only 2 methods that really differ are do_join() and join_finalize(), and
these don't share much code at all. (To avoid duplication, I split the
first part of do_join() into a new build_nc_lists() function, but this
is a pretty trivial code move).
We still pass the clone_only flag into the __init__() as there's still
one case where we want to avoid doing work in the case of the clone.
For clarity, I'll refactor this in a subsequent patch.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c2422593f46a7f4c1bd7421919f48b1fe7550e59">c2422593</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-03T06:12:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">join: Remove unnecessary clone_only flag
For the clone-only case, we have been avoiding a block of code in the
DCJoinContext's __init__(). The main reason we do this is because the
netbios_name is None for clones, and this block of code tries to derive
a bunch of values based on the netbios_name (otherwise, a few lines into
this block, it tries to do NoneType.lower(), which Python doesn't like
very much).
This code is not particularly clone-specific - it is just never going to
work if the netbios_name is None. So we can change the conditional
check, which allows us to get rid of the clone_only flag.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Tue Jul 3 08:12:10 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e0301df111c5adbaa77299bb5d43c180cdd9df2c">e0301df1</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-07-03T08:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: domain backup online command
This adds a samba-tool command that can be run against a remote DC to
produce a backup-file for the current domain. The backup stores similar
info to what a new DC would get if it joined the network.
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7844074621348b778ee0f8b73652f035cc5ec9ad">78440746</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-07-03T08:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: domain backup restore command
Add a command option that restores a backup file. This is only intended
for recovering from a catastrophic failure of the domain. The old domain
DCs are removed from the DB and a new DC is added.
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70b73f3ca6c3dc5425d224a826135dae6b536b11">70b73f3c</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-07-03T08:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add tests for the domain backup online/restore commands
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ccba77a9d8ead63acee11b15e1ca5f70afe168ad">ccba77a9</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-03T08:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add testenv for testing backup/restore
This adds a new testenv for testing that a DC created using the
samba-tool backup/restore can actually be started up. This actually
requires 2 new testenvs:
1. A 'backupfromdc' that solely exists to make a online backup of.
2. A 'restoredc' which takes the backup, and then uses the backup file
to do a restore, which we then start the DC based on.
The backupfromdc is just a plain vanilla AD DC. We use a separate test
env purely for this purpose, because the restoredc will use the same
domain (and so using an existing testenv would potentially interfere
with existing test cases).
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/00d22122e5c0eb0c4e45c40b6a292628ab023f2d">00d22122</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-03T08:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add a sub-set of tests to show the restored DC is sound
+ Add a new ldapcmp_restoredc.sh test that asserts that the original DC
backed up (backupfromdc) matches the new restored DC.
+ Add a new join_ldapcmp.sh test that asserts we can join a given DC,
and that the resulting DB matches the joined DC
+ Add a new login_basics.py test that sanity-checks Kerberos and NTLM
user login works. (This reuses the password_lockout base code, without
taking as long as the password_lockout tests do). Basic LDAP and SAMR
connections are also tested as a side-effect.
+ run the netlogonsvc test against the restored DC to prove we can
establish a netlogon connection.
+ run the same subset of rpc.echo tests that we do for RODC
+ run dbcheck over the new testenvs at the end of the test run
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/417fe47a910f2b8aa3c5e1121a55d8ebace0012b">417fe47a</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-03T08:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">drs_utils: Add infrastructure to support 'clone with rename'
Our end goal is to create a backup clone of a DB, but rename the
domain/realm so we can startup the backup DC without interferring with
the existing Samba network. The basic strategy to do this is to leverage
DRS replication - by renaming the first object in the partition, all
subsequent objects will automatically be renamed.
This patch adds the infrastructure to do this. I've used object
inheritance to handle the special case of renaming the partition
objects. This means the domain-rename special case doesn't really
pollute the existing DRS replication code. All it needs is a small
refactor to create a new 'process_chunk()' function that the new
sub-class can then override.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3287bfe2b4ab0676b40666594b00b64ab027e04d">3287bfe2</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2018-07-03T11:24:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: bundle and reduce huge number of EA function tests
It's sufficient to check for one basic function of an EA implementation and a
use a single ifdef for each group of EA functions. This makes more sense than
checking for each EA function on each platform.
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Jul 3 13:24:51 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c5fa4b1531b2f9a3584a1ac5689dc66190f82eb5">c5fa4b15</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-03T23:19:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: lib/ctdbd_conn: include .h, not .c
Probably a copy/paste mistake. Detected by a failing autobuild on
sn-devel and a local make test:
Build failed: default/examples/libsmbclient/testbrowse2: Symbol
tevent_req_is_unix_error linked in multiple libraries
['samba-cluster-support', 'tevent-util']
UNEXPECTED(failure): wafsamba.duplicate_symbols.duplicate_symbols(none)
Wonder why this didn't fail before in autobuild.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Jul 4 01:19:50 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ec69abec7cb1323ac33329dd113bdcccaa048293">ec69abec</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-04T02:43:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs showrepl: correctly report failing repsFrom
Hopefully this fixes the flapping test.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Wed Jul 4 04:43:39 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/56d9b1a533b8d3ebd4e686145883c7ed62c08ce0">56d9b1a5</a></strong>
<div>
<span>by Amit Kumar</span>
<i>at 2018-07-04T05:38:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">MAN: Adding entry for net ads lookup
There is no man page description for net ads lookup.
This PR adds entry for the same.
Signed-off-by: Amit Kumar amitkuma@redhat.com
Reviewed-by: Ralph Böhme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jul 4 07:38:04 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c8621948f65d09cd3461cfacc4aa00051abb0796">c8621948</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-07-04T08:22:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba_gpoupdate: Rename the command to samba-gpupdate
On a Windows client, this command is called 'gpupdate'
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a958dc35bbeea61fa1344a10602e7d40c8339764">a958dc35</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-07-04T11:23:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-gpupdate: Change machine option to target
On a Windows client, you designate machine/user
apply with a 'target' parameter. This change
makes gpupdate work more like that command.
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jul 4 13:23:09 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e311801e0e7171a2b50e39d3e0c2d2137f8b3d7e">e311801e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-04T19:07:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: smb_threads: fix access before init bug
talloc_stackframe_internal() calls SMB_THREAD_GET_TLS(global_ts) which
calls smb_get_tls_pthread() in the POSIX pthread wrapper implementation.
If SMB_THREAD_SET_TLS() hasn't been called before, global_ts is NULL and
smb_get_tls_pthread dereferences it so it crashes.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13505
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8e96e9ea46351de34ad5cac9a9a9ece4226b462c">8e96e9ea</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-07-04T19:07:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Add tests to lookup user via getpwnam
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13503
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f28d30633af721efec02d8816a9fa48f795a01c">9f28d306</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-07-04T21:55:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Do not lookup local system accounts in AD
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13503
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Jul 4 23:55:56 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b977ded38a79e1eadd6965e8b7fd49f86322b4d6">b977ded3</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-04T21:56:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Use correct return type for tevent_queue_add_entry
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/af697008531bd74546656841dd3a1ed92522fc57">af697008</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-04T21:56:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid segfault by initializing logging
Setting DEBUGLEVEL before calling debug_init() causes segmentation
violation with gcc8. DEBUGLEVEL_CLASS is statically initialized to
debug_class_list_initial which is defined as const. Only after
debug_init() is called, DEBUGLEVEL_CLASS becomes a talloc'd array.
So before modifying DEBUGLEVEL, ensure debug_init() is called via
setup_logging(). (debug_init is a static function.)
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a4393ddef763382ae0315792421cae0638949f29">a4393dde</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-04T21:56:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Avoid closing stdin when running in interactive mode
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/271407ab16f17282b3e63b6459d5511ec00c6d2d">271407ab</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-04T21:56:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Set environment variable if running in interactive mode
CTDB_INTERACTIVE will be used to tell the other daemons if the ctdb daemon
is started in interactive mode. This is primarily used only for testing.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c08d65c3eea997d52e311f027d84bdc3f9c93059">c08d65c3</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-04T21:56:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Add strict option to CHECK_CODE
Some compilers (e.g. xlc) ignores unsupported features, generates a
warning, but does not fail compilation.
This ensures that any compiler warnings are treated as errors and the
feature support is correctly identified. This adds equivalent compiler
option to -Werror for xlc.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9775c2429554e029164ad9b98dc8c8c749c50fe">a9775c24</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-04T21:56:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Be strict when checking __attribute__ features
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77cdfe3ecc06a9aef9ea4201a1a76a9a7b47a73f">77cdfe3e</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-04T21:56:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">socket_wrapper: Be strict when checking __attribute__ features
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59dfd2d797b7fa1610610ad1db2f31d5dfae4f06">59dfd2d7</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-04T21:56:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Be strict when checking __attribute__ features
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a670bde563b269587c051c655a7b3778c008c87">9a670bde</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-04T21:56:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nss_wrapper: Be strict when checking __attribute__ features
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65b0746694a0cbd8f40c5e89dc9a680044f7a1a9">65b07466</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-04T21:56:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pam_wrapper: Be strict when checking __attribute__ features
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c220e310b40c67b73248141b3af544bad19fd39d">c220e310</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-04T21:56:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">resolv_wrapper: Be strict when checking __attribute__ features
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/734ea271ab01e74d0694f3fbc9acdf980d866b30">734ea271</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T01:01:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">uid_wrapper: Be strict when checking __attribute__ features
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Thu Jul 5 03:01:33 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/634a72df24e74bce07d2481fb86b0ce4b7ebaa38">634a72df</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-05T02:01:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">join: Add more framework for renaming a domain
Add a DCCloneContext subclass which will rename the DB objects as they
get cloned. This uses the drs_ReplicateRenamer class added to drs_utils
in an earlier patch. Where the drs_Replicate object currently gets
created has been split out into a simple new function, which we can then
override in the rename case.
The other important difference is overriding the provision step, so that
we use the new domain-DN/realm when setting up the initial SAM DB (and
smb.conf, secrets.ldb, etc).
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/850bba4d329d062c8a79824c0a9987fa51340e2b">850bba4d</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-05T02:01:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">drs_utils: Always set the GET_TGT flag for clone renames
The DCCloneAndRenameContext replication was a little inefficient, in
that it would essentially replicate the entire DB twice. This was due to
resolving the link targets - it finds a target object it doesn't know
about, so retries the entire replication again with the GET_TGT flag set
this time.
Normally, the repl_meta_data code will use the target object's GUID,
however, it can't do this for cross-partition links (if it hasn't
replicated the target partition yet). The repl_md code can normally
detect that the link is a cross-parition link by checking the base-DN,
however, this doesn't work in the DCCloneAndRenameContext case because
we have renamed the base-DN.
This is not a big deal - it just means extra work. However, because the
domains being backed up could potentially be quite large, it probably
makes sense to just always set the GET_TGT in the rename case and skip
this extra work.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cd727c95a288995686cf4300b9a069ccf76b8e46">cd727c95</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-05T02:01:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Tweak the backup online tests so they're generic
Update backup-online tests to be more generic. We can then re-use the
common framework for other types of backups (offline, rename), and just
change what's specific to those particular cases.
This change includes asserting the restored backup's domain/realm are
correct, which we weren't doing previously but makes sense.
The new 'return samdb' is for convenience, so that child classes can
easily extend the checks we run over the restored DB.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ab65647a8b146832eea6e98ee9e1b891f9c36788">ab65647a</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-05T02:01:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Add 'samba-tool domain backup rename' command
Add a new command that takes a clone of the domain's DB, and renames the
domain as well. (We rename the domain during the clone because it's
easier to implement - the DRS code handles most of the renaming for us,
as it applies the received replication chunks).
The new option is similar to an online backup, except we also do the
following:
- use the new DCCloneAndRenameContext code to clone the DB
- run dbcheck to fix up any residual old DNs (mostly objectCategory
references)
- rename the domain's netBIOSName
- add dnsRoot objects for the new DNS realm
- by default, remove the old realm's DNS objects (optional)
- add an extra backupRename marker to the backed-up DB. In the restore
code, if the backup was renamed, then we need to register the new
domain's DNS zone at that point (we only know the new DC's host IP
at the restore stage).
Note that the backup will contain the old DC entries that still use the
old dnsHostname, but these DC entries will all be removed during the
restore, and a new DC will be added with the correct dnsHostname.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6681f904aaf0cd9d757572a4f41376bd2e1c01fd">6681f904</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-05T02:01:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Extend 'backup restore' command to handle renamed domains
When restoring a renamed domain backup, we need to register the new
realm's DNS zone. We do this in the restore step because we don't know
the new server's IP/hostname in the backup step.
Because we may have removed the old realm's DNS entries in the rename
step, the remove_dc() code may fail to find the expected DNS entries for
the DC's domain (the DCs' dnsHostname still maps to the old DNS realm).
We just needed to adjust remove_dns_references() as it was getting a
slightly different error code.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/20568e00e68631cf7b514024ba2926fd8c73c8e1">20568e00</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-05T02:01:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add dedicated RENAMEDC testenv for 'backup rename'
Add a new testenv that's similar to the existing restoredc, except we
use 'backup rename' to rename the domain as we back it up.
Restoring this backup then proves that a valid DC can be started from a
renamed backup.
Run the same sub-set of RESTOREDC tests to prove that the new testenv is
sound.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/62948a3099cbb6073f3e5e454eaaaadd134e3082">62948a30</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-05T02:01:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add new tests for backup-rename command
Extend the existing 'backup online' tests to also test the domain
rename case. This mostly involves some extra assertions that the
restored DB has been modified appropriatelt (i.e. domain NetBIOS
name is updated, etc).
I've also added an extra test case that creates a few objects and
links and specifically asserts that they get renamed appropriately.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2860bd0777eff1bff85f2000adf8fe4d788aad56">2860bd07</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-05T02:01:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Use dbcheck to fix DB problems introduced by restore itself
As part of the restore process, we remove all the old DCs from the DB.
However, this introduces some dbcheck errors - there are some DN
attributes and one-way links that reference the deleted objects that
need fixing up. To resolve this, we can run dbcheck as part of the
restore process. This problem affects both renames and plain restores.
The dbcheck.sh test didn't spot this problem because it fixes this type
of DB error first, before it checks the DB.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/64e350219826355bb2d4f3c7b42ea4f29439526e">64e35021</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-07-05T02:01:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs showrepl test: turn subprocess error into failure
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/41d86e5f2bf537f72f8a543492fcafe38c936657">41d86e5f</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-07-05T02:01:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba_tool_showrepl_pull_summary_all_good is flapping
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a7e9e527f5fa50883137f7acc33ba72627aae16">9a7e9e52</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-05T04:51:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Fix random-sleep.sh invocation in autobuild.py
The scripts were not running with the correct path and this causes sn-devel to hit
a very high load as many of the compile jobs start at once.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Thu Jul 5 06:51:26 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/046d4688231c6a2338e581f0d87f2611c1e9f877">046d4688</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T04:52:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Separate protocol-basic subsystem
This includes marshalling code for basic data types. This will be used
by other daemons.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cbf7e2f0f241f525496101179ba553c3763b14da">cbf7e2f0</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T04:52:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-build: Add ctdb prefix to build target
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5586e035f2793cee80e6fb1abbdff3d16451101c">5586e035</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T04:52:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Separate testing code for basic data types
This will be used for testing other daemons' protocol code.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f42106fb49deea9a0b185788b07934aff17ef4fd">f42106fb</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T04:52:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Add client pid to connect callback in sock_daemon
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/281bc8491216b3be4026ec0ab58a62ef104a6f35">281bc849</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T04:52:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Add event daemon protocol
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/24ba8e7c31b0ed142fdf57fe17b08f76643ed8a0">24ba8e7c</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T04:52:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Add event daemon implementation
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99c33e6f984e6431cbeeab006e61ea99ce15ff47">99c33e6f</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T04:52:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Add event daemon client code
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/587a1e045e5cf632abef0c1ee14231bae32837b1">587a1e04</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T04:52:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Add event daemon client tool
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f9104d46596919dd0e55c841533b26c7f90526fe">f9104d46</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T04:52:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Rename eventd testsuite to ctdb_eventd
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6eaef8491e4dbef2d5e7467e9e7dc40a971ec84a">6eaef849</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T04:52:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Add tests for event daemon
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/efc5d3caddc3952b30b709f4f24c51e42e8c9bdb">efc5d3ca</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T04:52:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Switch to starting new event daemon
>From this patch onwards, CTDB daemon is broken till the client code for
new eventd is integrated. This requires getting rid of the old eventd
protocol and client code and then switching to the new eventd protocol
and client code.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/26b19401622d751a56d9a8df4d4102b5df1f6519">26b19401</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T04:52:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Switch to using new event daemon tool
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99fa3a343f61213cf4cf214751ede0a7568f3167">99fa3a34</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T04:52:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Remove tests for old event daemon
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ce3db0d4698c77808448dce1f762e7157de9395f">ce3db0d4</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T04:52:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Remove old event daemon
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b6938c0976d3d4150f683cabb8dc5dc5b3b4944f">b6938c09</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T04:52:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Remove old event daemon tool
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e444c961c0755129d614963fb23cff737cfcaf1">0e444c96</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T04:52:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-client: Remove client code for old event daemon
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8250072a8116e04031e6a161c3bbc2af73fae431">8250072a</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T04:52:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Remove protocol for old event daemon
This breaks the build. The new eventd protocol cannot be introduced without
removing the old eventd protocol.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/db548f4852533bfbe250cd7b3281f16e2c34d14e">db548f48</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T04:52:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Add client code to talk to new event daemon
This fixes the build and now new eventd is integrated completely in CTDB.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dda99e49e3be6295cf91d4dffe010361469f8eb1">dda99e49</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T07:39:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Switch to using new event daemon
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Thu Jul 5 09:39:33 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/32e5b18d49332dff67833a9177032f85a4287717">32e5b18d</a></strong>
<div>
<span>by Timur I. Bakeyev</span>
<i>at 2018-07-05T07:40:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Make sure that vfs*audit modules recognize and accept all the syslog facilities.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13436
Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d63b24d5ae7898d93cc5428b029bff83bd59e5dc">d63b24d5</a></strong>
<div>
<span>by Timur I. Bakeyev</span>
<i>at 2018-07-05T07:40:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Make "none" the default setting for the successful and failed operations in the vfs_full_audit, so you don't blow up your server by just adding this module to the configuration.
Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f38df8337d694a1ac543629efb004ed52f07047">9f38df83</a></strong>
<div>
<span>by Timur I. Bakeyev</span>
<i>at 2018-07-05T07:40:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Document that vfs_full_audit defaults are "none" for the successful and failed operations.
Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9ff1fa56f68044142b6664fd703ebbb3f53d4725">9ff1fa56</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-05T07:40:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Use self.account_lockout_duration in self.update_lockout_settings for password_lockout tests
This allows the account_lockout_duration and
lockout_observation_window to be updated with longer values to cope
with slower build servers.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f03364570fd96eca636a85019107e970065260b8">f0336457</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-05T10:29:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Use a longer self.account_lockout_duration and self.lockout_observation_window
This matches the changes made in the PSO tests and slows down the
whole testsuite but may make it more reliable on slower build hosts.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Jul 5 12:29:31 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b2d75c0108f6edc7234bfa23a82b2c6c228a836f">b2d75c01</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T10:30:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Fix CID 437606
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a30ac853ff9bca023c53ad98775eabb23156c566">a30ac853</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-05T13:22:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid segfault by initializing logging
This is in addition to af697008531.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Thu Jul 5 15:22:16 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77be96379bcef56ea580010f1d60fe54e5647ff4">77be9637</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-07-06T15:14:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Use a swtich in the wbinfo test to lookup users
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13503
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Jul 6 17:14:44 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/20a837e87714f329d121f5de96b260ade651419c">20a837e8</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-07-06T18:37:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/service: use lp_const_servicename() where possible
The majority of these lp_servicename(talloc_tos(), ...) callers leak
onto the talloc stackframe. Drop the unnecessary heap allocations.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ce6c77d63a7e361f8c3233d7d5b439ad6796a09b">ce6c77d6</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-07-06T18:37:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/uid: use lp_const_servicename() where possible
The majority of these lp_servicename(talloc_tos(), ...) callers leak
onto the talloc stackframe. Drop the unnecessary heap allocations.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c53646bccd87ef3b3133d3f7526ef85591909528">c53646bc</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-07-06T18:37:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/service: convert lp_force_group() to const
set_conn_force_user_group() and change_to_user_internal() leak onto
the callers' talloc stackframe. Drop the unnecessary heap allocations.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c58194e3d296f4e14e7689bdf192c561635ae161">c58194e3</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-07-06T18:37:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/service: convert lp_force_user() to const
Avoid set_conn_force_user_group() talloc stackframe leaks in doing so.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/887f9147b4ccb6498b0e93efd7ea3696d3d36df2">887f9147</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-07-06T18:37:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/loadparm: fix a few talloc stackframe leaks
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/926ae50627d536735cee9b3931ee35bc19060261">926ae506</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-07-06T18:37:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_ceph: don't lie about flock support
Instead, match vfs_gluster behaviour and require that users explicitly
disable "kernel share modes".
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13506
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0cd44821f3889067620d685344c3eaf913a31329">0cd44821</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-07-06T21:19:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs/vfs_ceph: add CTDB_SAMBA_SKIP_SHARE_CHECK=yes caveat
Mostly copied from the vfs_gluster manpage: the CephFS share path is not
locally mounted, which breaks the ctdb_check_directories_probe() check.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jul 6 23:19:02 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4ad2a716fb0733e44f5bc000fb85e31aff83e682">4ad2a716</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-07T11:41:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: fix a check in stat_cache_add()
As the comment above the if condition says:
/*
* If we are in case insentive mode, we don't need to
* store names that need no translation - else, it
* would be a waste.
*/
Ie if stat_cache_add() is called as
stat_cache_add("foo/bar", "foo/bar", false)
There's no need to cache the path, as a simple stat() on the client
supplied name (full_orig_name) matches the name used in the
filesystem (passed to stat_cache_add() as translated_path).
So fix the if condition to match the comment.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3430c9c3c27b4c5fe5d38797acc7aa6aeb03c2b4">3430c9c3</a></strong>
<div>
<span>by Christof Schmitt via samba-technical</span>
<i>at 2018-07-07T11:41:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:charset: Fix error messages from charset conversion
When e.g. trying to access a filename through Samba that does not adhere
to the encoding configured in 'unix charset', the log will show the
encoding problem, followed by "strstr_m: src malloc fail". The problem
is that strstr_m assumes that any failure from push/pull_ucs2_talloc is
a memory allocation problem, which is not correct.
Address this by removing the misleading messages and add a missing
message in convert_string_talloc_handle.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0a91ade5272698c094137fa28d2ad4723b5963cf">0a91ade5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-07T11:41:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd/durable: remove dev and inode check from vfs_default_durable_reconnect_check_stat()
On a cluster filesystem the device numbers may differ on the cluster
nodes. We already verify the file_id in vfs_default_durable_reconnect(),
so we can safely remove the dev/inode checks.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13318
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e8b7aecf460a0c09cadbefda0a9b5fe1432f4089">e8b7aecf</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-07-07T14:24:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind_krb5_localauth: Fix a compiler warning
This can't used uninitialized but some compiler complains about it.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Sat Jul 7 16:24:30 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2e4878a69a62fb59d843ee53a1a9469b987e3a59">2e4878a6</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-07-09T16:46:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmbclient: Initialize written value before use.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13511
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fe25bc793d30a64f06b19f737c652b0c7389ca92">fe25bc79</a></strong>
<div>
<span>by Bailey Berro</span>
<i>at 2018-07-09T19:29:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmbclient: Initialize written in cli_splice_fallback()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13511
Signed-off-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: David Mulder <dmulder@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon Jul 9 21:29:48 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3e5e775321e6c432d92d459219ecebbb9713890d">3e5e7753</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-07-09T19:30:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "s3/service: convert lp_force_user() to const"
This reverts commit c58194e3d296f4e14e7689bdf192c561635ae161.
As mentioned by Andrew, we shouldn't break environments where
"force user" has been configured to use substituted variables.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3796bb0048a276259e30e44f7e0e071c1516727a">3796bb00</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-07-09T22:12:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "s3/service: convert lp_force_group() to const"
This reverts commit c53646bccd87ef3b3133d3f7526ef85591909528.
As mentioned by Andrew, we shouldn't break environments where
"force group" has been configured to use substituted variables.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jul 10 00:12:19 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/47e57249717677aed0afd9564cc349a70e125191">47e57249</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-10T02:40:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">README.Coding disable include sorting in clang format
Update the clang format configuration to disable include sorting. This
is enabled by default and breaks samba code.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Tue Jul 10 04:40:51 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/03c7d1e91efe9ba932334f32102230fc9481eb0b">03c7d1e9</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-10T02:42:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Add no-secrets option to domain backups
By default we include all the domain's secrets in the backup file. This
patch adds an extra option to exclude these secrets. In particular, this
is for the use case of creating a lab domain (where you might not feel
comfortable with the secrets for all your users being present).
Mostly this just involves passing the correct option to the join/clone.
I've also made sure that a password is also set for the Admin user
(samba does seem to start up without one set, but this behaviour is
closer to what happens during a provision).
The tests have been extended to use the new option, and to assert that
secrets are/aren't included as expected for some of the builtin testenv
users.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a154fc5328d1746490172e07dff497ae1ce8563">6a154fc5</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-10T02:42:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Add brief log file of what the backup actually contains
There are now several different permutations of backup file that can be
created (i.e. online, rename, with/without secrets). Hopefully the admin
users would organize their backup files sensibly, but it can't hurt to
keep track of what the backup-file actually contains in a simple
human-readable file within the backup tar. E.g. We really don't want
backups with secrets-included and secrets-excluded getting mixed up.
Recording the DC used to make the domain backup may be useful in the
event of a catastrophic failure of the domain, e.g. DC replication may
have been broken for some time prior to the failure.
Recording the samba-tool version string may also be useful if there are
ever any backwards-compatibility issues introduced to the backup files.
The intention is to say we only support restoring a backup with the same
version of samba-tool that actually created the backup, however, it'd be
polite to users to actually record that version somewhere.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b70637e9ffab2a99e7d0d4df95409b1f411b93b">7b70637e</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-10T02:42:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add a 'LABDC' testenv to mimic a preproduction test-bed
One of the use-cases for the domain rename tool is to produce a lab
domain that can be used for pre-production testing of Samba.
Basically this involves taking a backup rename with --no-secrets (which
scrubs any sensitive info), and then restoring it.
This patch adds a testenv that mimics how a user would go about creating
a lab-domain. We run the same tests that we run against the restore and
rename testenvs.
Note that the rpc.echo tests for the testallowed and testdenied users
fail, because we don't backup the secrets for these users. So these
tests failing proves that the lab-DC testenv is correct.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c8f0b88571e6573bea7f20ade2f62c60525ca800">c8f0b885</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-10T02:42:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Add sanity-check for invalid domain rename args
We are suggesting to users that it's safe to run a renamed domain in
parallel with the old backed-up domain. However, this would not be the
case if the user (foolishly) "renames" their domain using the exact same
NetBIOS name or DNS realm.
Using the same DNS realm fails later on (updating the dnsRoot values),
but using the same NetBIOS name actually succeeds. While we can't make
samba tools completely idiot-proof, we can protect users from the most
basic of (potentially unintended) errors with some simple sanity-checks.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b84c0a896f48ba31eb4b2874e5c9c9b61d3bc2a7">b84c0a89</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-07-10T05:30:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">heimdal: Fix build with system provided heimdal library
Trying to compile with a system provided heimdal library
results in this compile error:
[ 876/3043] Compiling source4/auth/kerberos/srv_keytab.c
In file included from /usr/include/heimdal/krb5.h:949:0,
from ../lib/replace/system/kerberos.h:33,
from ../source4/auth/kerberos/srv_keytab.c:31:
/usr/include/heimdal/krb5-protos.h:3894:1: error: unknown type name ‘HEIMDAL_WARN_UNUSED_RESULT_ATTRIBUTE’; did you mean ‘_WARN_UNUSED_RESULT_’?
HEIMDAL_WARN_UNUSED_RESULT_ATTRIBUTE KRB5_LIB_FUNCTION krb5_error_code KRB5_LIB_CALL
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
_WARN_UNUSED_RESULT_
/usr/include/heimdal/krb5-protos.h:3895:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘krb5_generate_random’
krb5_generate_random (
The problem is that Samba provides a minimal krb5-types.h file
for the internal build that gets used during the build with
the system provided heimdal library. As the minimal file
does not provide all definitions, the build fails.
Fix this by having the krb-types.h file simply include the
include file from the system library, if the build is done
using the system provided heimdal library.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Jul 10 07:30:26 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de5bde9fdecf462af449312e2098f634ffa6f52a">de5bde9f</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2018-07-10T08:44:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:client: Add --quiet option to smbclient
Add quiet command-line argument to allow suppressing the help log
message printed automatically after establishing a smbclient connection
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13485
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Björn Baumbach <bb@sernet.de>
(cherry picked from commit 89a8b3ecd47b6d9a33e66f22d2786f0ae3b4cb72)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eaa3c9a22f6199ae45b2431e9d6cc3da00744300">eaa3c9a2</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2018-07-10T08:44:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:tests: Add test for smbclient --quiet
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13485
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Björn Baumbach <bb@sernet.de>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Jun 26 20:29:19 CEST 2018 on sn-devel-144
(cherry picked from commit f90f434e041461fbea2e101066c79ec8caf35cce)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f4d7abd5a76aca82e98c714806a649fee80f8cba">f4d7abd5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-10T08:44:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-client: Fix typo where CTDB_BROADCAST_ALL is repeated
Surely this is meant to be CTDB_BROADCAST_CONNECTED?
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13499
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 77db0b15b56f9921961bd753c210e6fdbaf97f6d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1f25b710a83cb9549b52a45cc4981e3fd3188ba5">1f25b710</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-10T08:44:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add check for non-lmaster node status in integration tests
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13499
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 4b008556d6b1f07fd5057af845526bf941497f18)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a2d359358ddb20d57c76ac13376a1c1469be329e">a2d35935</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-10T08:44:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add a simple test for database traverses
This tests that volatile databases traverse correctly, including the
case where a record was updated on a non-lmaster node.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13499
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit ec72fadecd5233234947633360fe46a3a4053c07)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a701e28aea4c392f2e121e4b007fd85760484e6">7a701e28</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-10T08:44:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-server: Rename CTDB_BROADCAST_VNNMAP -> CTDB_BROADCAST_ACTIVE
This broadcast is misnamed. Both places where this type of broadcast
is used expect the broadcast to go to all active nodes.
Make the corresponding change to the semantics in the daemon by
sending to all active nodes.
There is a mismatch between the ideas of VNN map and active nodes. A
node that is not in the VNN map but is active can still host database
records. These were the same until the LMASTER capability was
introduced and then the logic was not updated.
The only place where the VNN map is relevant is when finding the
location master of a record in the migration code.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13499
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 36938bfdd075a174daecb466085702adfe6a6c09)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2819c0d9a3c7fa35ce272a0e7e06e7a1c9f7011b">2819c0d9</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-10T08:44:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Fix the documentation for VNN map
It is incorrectly says that nodes not in the VNN map can not be
DMASTER.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13499
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit af446d5209e37a38363911e5f339869b73d87963)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf7ae2fb5d4bdd4d3110f28b96130f54fe98daa5">bf7ae2fb</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-10T08:44:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Add test for sin6_len in sockaddr_in6 structure
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 7eeba9c5a4541e581b062fb9ee26f13b7373c541)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9974975faccdceddd8f37b75eb39099636685486">9974975f</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-10T08:44:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Use sin6_len only if the structure supports it
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 79992dbb73ac9749ac987cb6a88964fa600b4c35)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ac5ca1d3cbb51488bb437d7014f7134745a983a4">ac5ca1d3</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-10T08:44:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Fix build on AIX
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 40a8ab1ce0c1b291af7263da13c25c37cee69670)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a95e5286a4c06cf447f6943a01063863b61a99fa">a95e5286</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-10T08:44:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Fix build on AIX
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Here is the build error on AIX 7.1.
../../lib/tdb/tools/tdbtool.c:39:12: error: 'disable_lock' redeclared as different kind of symbol
static int disable_lock;
^~~~~~~~~~~~
In file included from /usr/include/sys/gfs.h:24:0,
from /usr/include/sys/vfs.h:27,
from ../../lib/replace/system/filesys.h:48,
from ../../lib/tdb/tools/tdbtool.c:26:
/usr/include/sys/lock_def.h:314:5: note: previous declaration of 'disable_lock' was here
int disable_lock(int,simple_lock_t);
^~~~~~~~~~~~
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit edffe4d16514fa0c87655e040842f6c20d89791c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4561e668a0b31aef2d812804c4c26343a40d3b14">4561e668</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-10T08:44:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Use correct return type for tevent_queue_add_entry
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit b977ded38a79e1eadd6965e8b7fd49f86322b4d6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/89de78eedfbb1a11e4c6f94f1838d78576d2dd86">89de78ee</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-10T08:44:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Add strict option to CHECK_CODE
Some compilers (e.g. xlc) ignores unsupported features, generates a
warning, but does not fail compilation.
This ensures that any compiler warnings are treated as errors and the
feature support is correctly identified. This adds equivalent compiler
option to -Werror for xlc.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit c08d65c3eea997d52e311f027d84bdc3f9c93059)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a0807d68b1e9543f059d90638119a39174538d4">7a0807d6</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-10T08:44:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Be strict when checking __attribute__ features
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit a9775c2429554e029164ad9b98dc8c8c749c50fe)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a4ada0b6318dae85075c8a76a6989a4d4b27d889">a4ada0b6</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-10T08:44:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">socket_wrapper: Be strict when checking __attribute__ features
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 77cdfe3ecc06a9aef9ea4201a1a76a9a7b47a73f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d3b773d757d836ce9189e61e9c010d6154513d59">d3b773d7</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-10T08:44:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nss_wrapper: Be strict when checking __attribute__ features
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 9a670bde563b269587c051c655a7b3778c008c87)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/81a05ba6d16af22eade72892b608cfaa2e227ecf">81a05ba6</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-10T08:44:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pam_wrapper: Be strict when checking __attribute__ features
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 65b0746694a0cbd8f40c5e89dc9a680044f7a1a9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e021b4371eee29201c369d633aa3ef6f09c0cb33">e021b437</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-10T08:44:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">resolv_wrapper: Be strict when checking __attribute__ features
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit c220e310b40c67b73248141b3af544bad19fd39d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8af4bac8ec602df413d2b2a02e4b37c6558f0ce5">8af4bac8</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-10T08:44:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">uid_wrapper: Be strict when checking __attribute__ features
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Thu Jul 5 03:01:33 CEST 2018 on sn-devel-144
(cherry picked from commit 734ea271ab01e74d0694f3fbc9acdf980d866b30)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/35128a93e7b1efd10f691e1f3ef12a48116c1c0c">35128a93</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-10T08:44:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Switch fake_ctdbd to use ctdb_get_peer_pid()
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 05a908d71c4b7484ba0243fa51bc05c79c8fb357)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f46b392bf499b3f21b6e48e90f2bfa0877e8a2a">7f46b392</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-10T08:44:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Only consider client ID for local database attach
The comment immediately above this code says "don't allow local
clients to attach" and then looks up the client ID regardless of
whether the request is local or remote.
This means that an intentional remote attach from a client will not
work correctly. No real client should ever do that since clients
attach so they an access databases locally. Perhaps some sanity
checks should be added.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13500
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 63255ef92552da92956c05160f33622d0bbc3a28)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e3f149a09201ae53d489fd48eec705df0ffdcca">0e3f149a</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-10T08:44:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">socket_wrapper: Add missing dependency on tirpc
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue May 22 13:57:07 CEST 2018 on sn-devel-144
(cherry picked from commit 7049b2153b08152f03a0fcbb1817b430fe0a8451)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6600f4b1641160c902e8318c64a33575610deb31">6600f4b1</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-10T08:44:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-pmda: Use modified API in pcp library 4.0
Support backward compatibility by checking for __pmID_int type, which
was previously in <pcp/impl.h>. In the new version, this type is not
defined anymore and there is no need to include <pcp/impl.h>.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Mar 2 00:38:52 CET 2018 on sn-devel-144
(cherry picked from commit 426e4a5a20cff73a80d80b46f15826deac3f934f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a19d52e6c827b78d3883d37fcdaa76013e5c3177">a19d52e6</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-10T08:44:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid segfault by initializing logging
Setting DEBUGLEVEL before calling debug_init() causes segmentation
violation with gcc8. DEBUGLEVEL_CLASS is statically initialized to
debug_class_list_initial which is defined as const. Only after
debug_init() is called, DEBUGLEVEL_CLASS becomes a talloc'd array.
So before modifying DEBUGLEVEL, ensure debug_init() is called via
setup_logging(). (debug_init is a static function.)
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit af697008531bd74546656841dd3a1ed92522fc57)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b12f6c6f76440788cadda1fca4fe30531301f668">b12f6c6f</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-10T10:53:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW add entries audit logging and lmdb.
Add WHATSNEW entries for dsdb, password and group change audit logging,
as well as the ldb lmdb backend
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Jul 10 12:53:54 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b5d333c26484cff8f933ba8389e46514ea501282">b5d333c2</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-10T13:09:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid segfault by initializing logging
This is in addition to af697008531.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Thu Jul 5 15:22:16 CEST 2018 on sn-devel-144
(cherry picked from commit a30ac853ff9bca023c53ad98775eabb23156c566)
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Tue Jul 10 15:09:25 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/93f61639a64f0b3156437b75c31330aa189d3db7">93f61639</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-10T18:31:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: close the correct pipe fd in a test
This was discovered in an autobuild with a patched tevent that used the
"poll" backend by default. Test failure:
$ bin/sock_daemon_test /dev/shm/sock_daemon_test.pid /dev/shm/sock_daemon_test.sock 5
test5[28011]: daemon started, pid=28011
test5[28011]: listening on /dev/shm/sock_daemon_test.sock
sock_daemon_test: ../ctdb/tests/src/sock_daemon_test.c:980: test5: Assertion `ret == i+1' failed.
Abgebrochen (Speicherabzug geschrieben)
metze@SERNOX14:~/devel/samba/4.0/master4-test$ test5[28011]: PID 28010 gone away, exiting
test5[28011]: Shutting down
sock_daemon_test: ../ctdb/tests/src/sock_daemon_test.c:964: test5:
Assertion `ret == EINTR' failed.
After an epic debugging session we spotted the problem.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d08efa7f90e97f1f797d09f7519076646110cb45">d08efa7f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-10T18:31:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests: make the test_assoc_group_fail2() test more resilient against timing
On a busy system [e]poll() on the server will mark both the
old connection fd and also the listening fd as readable.
epoll() returns the events in order, so the server processes the
disconnect first.
With poll() we don't have an order of the events and the
server is likely to process the connect before the disconnect.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0503bbab958754bc8ba32da8578602927ebf25c0">0503bbab</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-10T18:31:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:messaging: add local.messaging.multi_ctx.multi_ctx test
This tests the usage of multiple imessaging_contexts in one process
and also freeing two of them during a message handler.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13514
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1a9d6ce58939678f88b3081fb91c3309ff3cddb7">1a9d6ce5</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-10T18:31:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:messages: make the loop in msg_dgm_ref_recv() more robust against stale pointers
The interaction between msg_dgm_ref_recv() and msg_dgm_ref_destructor()
doesn't allow two references from messaging_dgm_ref() to be free'd
during the loop in msg_dgm_ref_recv().
In addition to the global 'refs' list, we also need to
have a global 'next_ref' pointer, which can be adjusted in
msg_dgm_ref_destructor().
As AD DC we hit this when using irpc in auth_winbind,
which uses imessaging_client_init().
In addition to the main messaging_dgm_ref() in smbd,
source3/auth/auth_samba4.c: prepare_gensec() and
make_auth4_context_s4() also generate a temporary
imessaging_context for auth_context->msg_ctx from within
auth_generic_prepare().
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13514
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/621349d559053e86064d2502d114d107914c189f">621349d5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-10T21:17:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/rpc_server: Character Encode Spotlight Queries
Fix path escaping in Spotlight so paths with spaces or special
characters can be properly matched to tracker paths.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12688
Based-on-a-patch-from: Mike M Pestorich <mmpestorich@gmail.com>
(similar to github.com/netatalk/netatalk/commit/90aa43d)
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jul 10 23:17:20 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/36b4b5655400df48f539d882b7c820ae109b3605">36b4b565</a></strong>
<div>
<span>by Pooja Mahadik</span>
<i>at 2018-07-11T00:22:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pass 'rdonly' or 'directory' flag to open a directory file.
Signed-off-by: Pooja Mahadik <pooja.mahadik@veritas.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Jul 11 02:22:18 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0940f8560fc67caf79c1b4090bf6cbfc644ddc93">0940f856</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-07-11T00:23:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Added entries for PSOs, domain backup/restore, and rename
Added WHATSNEW blurbs for the following features:
- Password Settings Objects
- Domain backup and restore
- Domain rename tool
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c58ccba71022e165b2617674a1225ec9b960183">5c58ccba</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-07-11T03:18:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript: Add --with-system-heimdalkrb5
Add the configure option --with-system-heimdalkrb5 to build Samba
explicitly with a system Heimdal kerberos library. This does the same as
the more complicated syntax
--bundled-libraries='!heimdal,!asn1,!com_err,!roken,!hx509,!wind,!gssapi,!hcrypto,!krb5,!heimbase,!asn1_compile,!compile_et,!kdc,!hdb,!heimntlm'
and it also enforces the conflicts with MIT Kerbros and the AD DC
build.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jul 11 05:18:59 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3d0ed62f91fa9490b9209ac36cd9935f6d541b22">3d0ed62f</a></strong>
<div>
<span>by Timur I. Bakeyev</span>
<i>at 2018-07-11T06:44:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_audit: Extend list of recognized syslog(3) facilities and wrap them into #ifdef's. That list should be comprehensive enough to cover most of the existing OSes.
Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Wed Jul 11 08:44:10 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99ea80d281b8fcd61da8663bcfacd4d0eb283f6b">99ea80d2</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-07-11T06:45:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: samba-tool drs showrepl and visualize changes
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/998c4afd2d7b1a5df12f2e4d3ff1197ce1717a5f">998c4afd</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-07-11T06:45:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">doc: samba-tool visualize uptodateness
and --xdot option.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c20278b6779be4d7b1f629f3892a16595827f733">c20278b6</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-07-11T06:45:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">doc: samba-tool drs showrepl --json and --summary
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/094c239fe73737abfeda7bf4f4b67eaff96574d8">094c239f</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-11T09:47:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add more text about work done by Catalyst developers
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jul 11 11:47:09 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1061f48d03e5f02d11ec302153fdf36209b15084">1061f48d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Replace hardcoded IP address in test results
Parameterise them with a variable instead.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b20c9173169659b948913c4e0480c50612b65e56">b20c9173</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Setup public addresses in 60.nfs unit tests
Even the monitor event runs update_tickles(), which needs public IP
addresses and FAKE_CTDB_NUMNODES to be initialised. Currently this
works by default but soon we'll need FAKE_CTDB_NUMNODES in another
context.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d0739b2ea81140f6514a8a48dd2ce5184f6bdb54">d0739b2e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Change default for tunable NoIPHostOnAllDisabled to 1
Defaulting to host public IP addresses when all nodes are unhealthy
does not obey the principle of least surprise. It has caused much
confusion over the years. It often leads to problems when all nodes
are unhealthy due to something like a cluster filesystem being
unmounted.
Change the default value for this tunable as the first step of
completely removing this behaviour.
Remove tests that set NoIPHostOnAllDisabled=1 and update the expected
result for other tests where no nodes are healthy.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/070469beb812501dd44847b7facc9dfab436616c">070469be</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Mark NoIPHostOnAllDisabled tunable as obsolete
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fda059108356bb97168f2cc61d94a18098cab0c4">fda05910</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop plumbing for obsolete tunable NoIPHostOnAllDisabled
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/709ef6b7cc63ad272b959404d755af82c56d4ea0">709ef6b7</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Stop inactive/disabled nodes from reporting available IPs
This can be done now that NoIPHostOnAllDisabled is gone and will allow
the public IP address failover logic to be simplified.
In the test code, still filter available IP addresses by node state.
This code can't currently read information about available IP
addresses but that will change in future
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7c4848a4b3c7b073727f633863e0a92d413c3513">7c4848a4</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop the noiphost "node flags" bitmap
This is no longer needed because inactive/disabled nodes no longer
report any available public IP addresses.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be1c3400587ccf4f04fa56f438cf815a12e04326">be1c3400</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-build: Add CTDB_DATADIR
Signed-off-by: Martin Schwenke <martin@meltin.net>
Pair-programmed-with: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3bebc5d8a034f085bd53d7169a69129851b8f140">3bebc5d8</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Add path support for datadir
Signed-off-by: Martin Schwenke <martin@meltin.net>
Pair-programmed-with: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6742bf6cf65cf40b54910ee254a3e863be141e85">6742bf6c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Update event tool to handle symbolic links
Supports the case when scripts are installed in the data directory and
are linked to when enabled.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Pair-programmed-with: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2546c439599565f33e4c905d1c73858026e37439">2546c439</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Allow tool to enable/disable scripts without daemon
Only open the client socket when it is needed. Note that this only
works for enabling/disabling event scripts via symlinks.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/15c6552aa92c03a12de816b187b3f0fe0ca7d64c">15c6552a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: All ctdb event commands to run without ctdbd
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/19071ac8ad93111f50fc45be9731cd7f03a80a08">19071ac8</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: New install path CTDB_SCRIPT_DATA_DIR
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f029e2a76debaf663c40537bd850918802bfd1e0">f029e2a7</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop an unused case
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a3610d1cbcebb0fe81505d42276604804a112d9a">a3610d1c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Clean up define_test() for event scripts
Factor out a little bit of common code. More coming.
Most of this is whitespace changes.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/06be1c8593fc84068896b428bdc39e7033bd85e2">06be1c85</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-build: Install event scripts in CTDB_DATADIR
Signed-off-by: Martin Schwenke <martin@meltin.net>
Pair-programmed-with: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0937ce04222ee726a2ca7d87e3b2bf176b883340">0937ce04</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-build: Enable some standard event scripts if none are enabled
CTDB needs the legacy/00.ctdb event script to be able to function
properly. If this script is not enabled then assume a first-time
install or an upgrade to a version that requires events scripts to be
enabled via symlinks. In these cases enable this script and other
commonly used scripts.
Only do this for a direct install. If DESTDIR is being used then
assume a package is being built and let the packager handle this case.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8fe6a0274bdd1f40f2c38462f23ca876807f6fd9">8fe6a027</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-packaging: Enable some standard event scripts if none are enabled
CTDB needs the legacy/00.ctdb event script to be able to function
properly. If this script is not enabled then assume a first-time
install or an upgrade to a version that requires events scripts to be
enabled via symlinks. In these cases enable this script and other
commonly used scripts.
Remove links during uninstall (but not during upgrade).
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a757e07600d38692c600847d8a169936a7268f4b">a757e076</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Ensure some event scripts are enabled for cluster tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c08c95c9e5b091bf77ff6e8ced0a7bf1e0e82f74">c08c95c9</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop event script tests where CTDB_MANAGED_<service>=no
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e081cafc9c4fcf5c8cfc0032e3c73eb145a09a9e">e081cafc</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop event script CTDB_MANAGED_<service> variables
Enable required event scripts to manage services.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/451c6b668fb076eb0bb99ad70cf1546c4450cc5d">451c6b66</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T09:48:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop residual CTDB_MANAGED_<service> variables
These no longer do anything.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4628afa3f563924434ccae9918cf60778b8ab91f">4628afa3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-11T12:47:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Provide a gstack function if gstack is not available
gstack isn't widely available, so provide a simple function that does
the same thing if it gstack can't be found.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed Jul 11 14:47:21 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8fe2fdc73a8b441e0850289eb547db2926cd7fda">8fe2fdc7</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-07-11T20:39:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Remove ads.h include from nss_info
nss_info does not use libads. Removing this include
fixes a compile error when trying to compile with a
system provided heimdal library:
[2188/3043] Compiling source3/winbindd/nss_info.c
In file included from ../source3/libads/kerberos_proto.h:33:0,
from ../source3/include/ads.h:154,
from ../source3/winbindd/nss_info.c:24:
../lib/replace/system/kerberos.h:33:10: fatal error: krb5.h: No such file or directory
#include <krb5.h>
^~~~~~~~
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Wed Jul 11 22:39:36 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2cbed651d421ca47f3c86dc75adcaea10519c128">2cbed651</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: make use of tevent_common_wakeup() in the poll and poll_mt backends
This simplifies the "poll_mt" logic a lot.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f69bca61d582a62de3a9718983362f53992e4c27">f69bca61</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: rewrite/simplify tevent_poll and maintain ev->fd_events correctly
The following patches will rely on having all valid fd events in
ev->fd_events, even if they are temporary disabled with
tevent_set_fd_flags(fde, 0);
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cd517516b79f97d6f31c368e61565326a5c70af7">cd517516</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-11T21:04:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent.h: improve tevent_req documentation
Document tevent_req naming conventions.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1eccb2dd1c24073bb7353c1ec9280347d6259331">1eccb2dd</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent/testsuite: return after torture_fail()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8578e012c17b1513f09de97a12d1126e77aac79">f8578e01</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: allow tevent_abort() to cope with ev == NULL
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/add485e47cf4c082eb117d64fd7a7a397484a66a">add485e4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: make tevent_abort() available for backends
We'll undo the 0.9.36 ABI change on the 0.9.37 release
at the end of this patchset.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/049a06e621adf01b0762217031c509aa7a4ec863">049a06e6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: use struct initializers for tevent_fd
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b983aca86d368c5e86f081315f28a42482b8e47d">b983aca8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: use struct initializers for tevent_timer
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1c9a7a77591a5d742e81ba17875480e6fcb2b476">1c9a7a77</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: use struct initializers for tevent_signal
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/788187c0309bf3bfcc7e056a3d78c2f4c2df7588">788187c0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: use struct initializers for tevent_immediate
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0b91f6f0e4eeff7bbff24b33dd2087e2903e969b">0b91f6f0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: use _tevent_schedule_immediate() to move events from a thread to the main_ev
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/157df4da26aeb46eedf1a0f3895cc5fbc751f1dc">157df4da</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: add tevent_threaded_schedule_immediate_destructor that just aborts
This will be active while the event is part of the ev->scheduled_immediates
list.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/58fa08c80562490bd774f4dc774dc1ce3a042f3c">58fa08c8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: add tevent_common_check_double_free() helper function
This will be used to generically support TALLOC_FREE() on
event which are currently running.
It aborts on every explicit talloc_free(), but ignores implicit
cleanup when the talloc parent is about to go.
We'll undo the 0.9.36 ABI change on the 0.9.37 release
at the end of this patchset.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8a947939e11cacde7c4b4dce03bf12348642ee7f">8a947939</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: simplify tevent_cleanup_pending_signal_handlers()
Calling tevent_signal_destructor() does the same as se->event_ctx is already
NULL.
This also makes sure we correctly cleanup the SA_SIGINFO array.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/601fd81ef274ee42121d71d2167a62fdcb759409">601fd81e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: use talloc_zero() in tevent_signal.c
This might not be strictly required, but it might
avoid problems in future...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d1b347c4ca6fc0640952f1d639c2a321d6feff53">d1b347c4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: simplify tevent_signal_destructor()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ddab21987d3edb17333a5759bd7bcbb7b5126b53">ddab2198</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: split out tevent_common_invoke_signal_handler()
As side effect this avoids tricks with tevent_se_exists_destructor() to
figure out if the event handler removed itself.
We'll undo the 0.9.36 ABI change on the 0.9.37 release
at the end of this patchset.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a85ee852accd9137dbffa1e41df8618123b00450">a85ee852</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: split out tevent_common_invoke_timer_handler()
As side effect this avoids tricks with an extra
tevent_common_timed_deny_destructor().
We'll undo the 0.9.36 ABI change on the 0.9.37 release
at the end of this patchset.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6740718e0e7db82563870ff398de90dac8f09228">6740718e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: split out tevent_common_invoke_immediate_handler()
We'll undo the 0.9.36 ABI change on the 0.9.37 release
at the end of this patchset.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/072e3b28ce029dd103ef2ea9836b6c6254825a8e">072e3b28</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: split out tevent_common_invoke_fd_handler()
We'll undo the 0.9.36 ABI change on the 0.9.37 release
at the end of this patchset.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e239cbc1fd7ad3008ecb423f7dcb82651d2df420">e239cbc1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: make use of #include "system/threads.h"
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ac9569b1a61319166e497d51917db7f04a2746ce">ac9569b1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: add tevent_context_wrapper_create() infrastructure
This allows to specify wrapper tevent_contexts, which adds the ability
to run functions before and after the event handler functions.
This can be used to implement impersonation hooks
or advanced debugging/profiling hooks.
We'll undo the 0.9.36 ABI change on the 0.9.37 release
at the end of this patchset.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4991c935c03236f60183d37b4a24c68713ee4962">4991c935</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-11T21:04:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: add a simple wrapper test
This checks that for all supported event types the before and after
handlers are called.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6189446abe27acda82afb6d9eb43b0b01c5ce4bc">6189446a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-11T21:04:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: add a test that frees wrapper_ev with pending events
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3dae5061b593c3ee1f80481a40fa2d556440c117">3dae5061</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-11T21:04:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: Add tevent_req_profile
This allows detailed reporting where a tevent_req spends its time
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f4fe3f77669875070cd7ba4a28ad33f6a058f105">f4fe3f77</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: version 0.9.37
* simplify "poll" and "poll_mt" backends
* make tevent_abort() reachable for backends
* add tevent_common_invoke_*_handler() functions
* add tevent_context_same_loop() function
* add tevent_context_wrapper_create() infrastructure
* add tevent_req_profile infrastructure
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9847848cca1fc0ca2091764b6e80631c4f1f6864">9847848c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-11T21:04:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Multi-line a long line in wscript_build
Why? I'll add another file in a later commit
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1e206553eba04abc6906bfb67b7c4132144473f8">1e206553</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-11T21:04:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Add tevent_req_profile helpers
Print and marshall/unmarshall tevent_req_profile structs
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/86a548c693852300eed4e53b83ed2fe76b4a5d08">86a548c6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-11T21:04:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Test tevent_req_profile
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5af9ecf6f021552f38021b138850bc4020693270">5af9ecf6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-11T21:04:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Convert process_request() to tevent_req
Having a central tevent_req per winbind child request is prerequisite
for request profiling
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bb683535f1e97b2f5a401575e38c78ad917a286c">bb683535</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-11T21:04:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Do request profiling
By default we log a request that takes more than 60 seconds. This can be
changed by setting
winbind:request profile threshold = <seconds>
Another parameter controls the depth of the request hierarchy printed:
winbind:request profile depth = <n>
The default request logged to syslog via DEBUG(0) looks like the
following for a wbinfo -P:
[struct process_request_state] ../source3/winbindd/winbindd.c:683 [2018/06/19 13:33:14.190365] ../source3/winbindd/winbindd.c:853 [2018/06/19 13:33:14.192737] [0.002372] -> TEVENT_REQ_DONE (2 0))
[struct winbindd_ping_dc_state] ../source3/winbindd/winbindd_ping_dc.c:41 [2018/06/19 13:33:14.190369] ../source3/winbindd/winbindd_ping_dc.c:112 [2018/06/19 13:33:14.192681] [0.002312] -> TEVENT_REQ_DONE (2 0))
[struct dcerpc_wbint_PingDc_state] default/librpc/gen_ndr/ndr_winbind_c.c:4335 [2018/06/19 13:33:14.190383] default/librpc/gen_ndr/ndr_winbind_c.c:4396 [2018/06/19 13:33:14.192680] [0.002297] -> TEVENT_REQ_DONE (2 0))
[struct dcerpc_wbint_PingDc_r_state] default/librpc/gen_ndr/ndr_winbind_c.c:4251 [2018/06/19 13:33:14.190385] default/librpc/gen_ndr/ndr_winbind_c.c:4285 [2018/06/19 13:33:14.192678] [0.002293] -> TEVENT_REQ_DONE (2 0))
[struct dcerpc_binding_handle_call_state] ../librpc/rpc/binding_handle.c:371 [2018/06/19 13:33:14.190387] ../librpc/rpc/binding_handle.c:520 [2018/06/19 13:33:14.192675] [0.002288] -> TEVENT_REQ_DONE (2 0))
[struct dcerpc_binding_handle_raw_call_state] ../librpc/rpc/binding_handle.c:149 [2018/06/19 13:33:14.190400] ../librpc/rpc/binding_handle.c:203 [2018/06/19 13:33:14.192646] [0.002246] -> TEVENT_REQ_DONE (2 0))
[struct wbint_bh_raw_call_state] ../source3/winbindd/winbindd_dual_ndr.c:89 [2018/06/19 13:33:14.190402] ../source3/winbindd/winbindd_dual_ndr.c:204 [2018/06/19 13:33:14.192644] [0.002242] -> TEVENT_REQ_DONE (2 0))
[struct wb_domain_request_state] ../source3/winbindd/winbindd_dual.c:473 [2018/06/19 13:33:14.190404] ../source3/winbindd/winbindd_dual.c:708 [2018/06/19 13:33:14.192640] [0.002236] -> TEVENT_REQ_DONE (2 0))
[struct wb_child_request_state] ../source3/winbindd/winbindd_dual.c:198 [2018/06/19 13:33:14.190411] ../source3/winbindd/winbindd_dual.c:273 [2018/06/19 13:33:14.192638] [0.002227] -> TEVENT_REQ_DONE (2 0))
[struct tevent_queue_wait_state] ../lib/tevent/tevent_queue.c:336 [2018/06/19 13:33:14.190412] ../lib/tevent/tevent_queue.c:355 [2018/06/19 13:33:14.190415] [0.000003] -> TEVENT_REQ_DONE (2 0))
[struct wb_simple_trans_state] ../nsswitch/wb_reqtrans.c:375 [2018/06/19 13:33:14.190424] ../nsswitch/wb_reqtrans.c:432 [2018/06/19 13:33:14.192630] [0.002206] -> TEVENT_REQ_DONE (2 0))
[struct req_write_state] ../nsswitch/wb_reqtrans.c:158 [2018/06/19 13:33:14.190425] ../nsswitch/wb_reqtrans.c:194 [2018/06/19 13:33:14.190472] [0.000047] -> TEVENT_REQ_DONE (2 0))
[struct writev_state] ../lib/async_req/async_sock.c:263 [2018/06/19 13:33:14.190432] ../lib/async_req/async_sock.c:412 [2018/06/19 13:33:14.190470] [0.000038] -> TEVENT_REQ_DONE (2 0))
[struct resp_read_state] ../nsswitch/wb_reqtrans.c:222 [2018/06/19 13:33:14.190475] ../nsswitch/wb_reqtrans.c:275 [2018/06/19 13:33:14.192629] [0.002154] -> TEVENT_REQ_DONE (2 0))
[struct read_packet_state] ../lib/async_req/async_sock.c:458 [2018/06/19 13:33:14.190476] ../lib/async_req/async_sock.c:546 [2018/06/19 13:33:14.192626] [0.002150] -> TEVENT_REQ_DONE (2 0))
[struct resp_write_state] ../nsswitch/wb_reqtrans.c:307 [2018/06/19 13:33:14.192693] ../nsswitch/wb_reqtrans.c:344 [2018/06/19 13:33:14.192734] [0.000041] -> TEVENT_REQ_DONE (2 0))
[struct writev_state] ../lib/async_req/async_sock.c:263 [2018/06/19 13:33:14.192694] ../lib/async_req/async_sock.c:412 [2018/06/19 13:33:14.192732] [0.000038] -> TEVENT_REQ_DONE (2 0))
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f2afc20e1b6397c364a98d1be006377c95e4665">7f2afc20</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:messages: protect against usage of wrapper tevent_context objects for messaging
This makes a lot of assumtion easier to understand and the introduction
of wrapper tevent contexts will not change the existing behaviour.
We'll relax this a bit in the next commits.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/660cf86639753edaa7a7a21a5b5ae207ae7d4260">660cf866</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:messages: allow messaging_{dgm,ctdb}_register_tevent_context() to use wrapper tevent_context
This is only allowed if the raw tevent context is already registered.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9dc332060cf5f249ea887dbc60ec7a39b6f91120">9dc33206</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:messages: allow messaging_dgm_ref() to use wrapper tevent_context
This is only allowed if the raw tevent context is already registered.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2b05f1098187e00166649c8ea7c63e6901b9d242">2b05f109</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:messages: allow messaging_filtered_read_send() to use wrapper tevent_context
As it gets 'messaging_context' as argument, we're sure a messaging context
with a raw tevent context already exist.
It means we can allow a wrapper tevent context that wrapps the main tevent
context of the messaging context.
The use of tevent_req_defer_callback() makes sure that the callers
callback function calls messaging_filtered_read_recv() from the
correct "wrapped" environment.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a08ab2940051ae47ce71149087a24d060227ef19">a08ab294</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-11T21:04:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:messaging: allow imessaging_post_handler() to free the messaging context from a handler
In usecases like using messaging_client_init() with irpc processing we may
free the imessaging_context during the messaging handler.
imessaging_post_handler() is not yet really used, but it will change in
the next commits. imessaging_post_state is a child of imessaging_context
and might be implicitly free'ed before the explicit TALLOC_FREE(state).
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e186d6a06b1b300256a2cb4138f0532d518d0597">e186d6a0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T00:23:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:messaging: make sure only imessaging_client_init() can be used with a wrapper tevent_context wrapper
imessaging_client_init() can be used with a wrapper tevent_context,
but only if a global messaging_dgm_ref() already exist.
All other uses of imessaging_init() and imessaging_client_init()
require a raw tevent_context.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Jul 12 02:23:37 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d871e0c84c761877563652558f44d8a3df4c49a3">d871e0c8</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-12T02:31:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb.conf: add dns_zone_scavenging
Add parameter dns_zone_scavenging to control dns zone scavenging.
Scavenging is disabled by default, as due to
https://bugzilla.samba.org/show_bug.cgi?id=12451 the ageing properties of
existing DNS entries are incorrect.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c1552c70c5a34584ffb23a9a48b6bf1501e1eea4">c1552c70</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-07-12T02:31:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: record aging tests
First basic DNS record aging tests. These check that we can
turn aging on and off, and that timestamps are written on DNS
add and update calls, but not RPC calls.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10812
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/19910bea876d2e9797d1e0e3e6594a56662e1e9e">19910bea</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-07-12T02:31:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpc dns: setting timestamp to 0 on RPC processed records
All records created by RPC DNS server calls should have timestamp set to 0
according to [MS-DNSP]
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12451
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10812
Signed-off-by: Aaron Haslett<aaronhaslett@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b841da04e217646c8bf1eaa3985857ce4207965c">b841da04</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-12T02:31:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: Reformat DNS with clang-format
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10812
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b22ce976862500fcfe56d60698ce9572b50feef9">b22ce976</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-07-12T02:31:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpc dns: reading zone properties from LDB
Reading zone properties from LDB on server connection initialisation, instead
of them being volatile fields.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10812
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d6e111ff4212bbab6f8fdc67828afe4d1c154ac4">d6e111ff</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-07-12T02:31:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpc dns: reset dword aging related zone properties
This allows a user to set zone properties relevant to DNS record aging over RPC.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10812
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/350029bdd8fe90f64d8581b39599d8b8430d7f61">350029bd</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-07-12T02:31:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: moving name_equal func into common
This function is duplicated in the BIND9 and RPC DNS servers.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10812
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/418cd93f4c9c90b0f5002e32203be8281af660cf">418cd93f</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-07-12T02:31:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: server side implementation of record aging
Code for retrieving aging properties from a zone and using them for timestamp
setting logic during processing of DNS requests.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10812
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/00002b8df9b865b896d264ee22bf6f22cf935f56">00002b8d</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-07-12T02:31:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: custom match rule for DNS records to be tombstoned
A custom match rule for records to be tombstoned by the scavenging process.
Needed because DNS records are a multi-valued attribute on name records, so
without a custom match rule we'd have entire zones into memory to search for
expired records.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10812
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6bd2f82b9ff7629effe8280ab8f6bf9d721cf767">6bd2f82b</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-07-12T02:31:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: Use ldb.SCOPE_SUBTREE in ldap_get_records() routine in tests/dns.py
DNS records have the odd property that the DN can be reliably determined by the
name only, so we do not need a subtree search.
However by using a subtree search under the zone we can without
trapping exceptions confirm if the record exists or not in the tests.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10812
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/50d961c1a2de87067606897b794a47c80513bb64">50d961c1</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-07-12T02:31:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: dns record scavenging function (without task)
DNS record scavenging function with testing. The logic of the custom match rule
in previous commit is inverted so that calculations using zone properties can
be taken out of the function's inner loop. Periodic task to come.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10812
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/86b61551b381520335977cd129955587758f02a3">86b61551</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-07-12T02:31:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns+kcc: adding dns scavenging to kcc periodic run
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10812
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Pair-Programmed-With: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8ef42d4dab4dfaf5ad225b33f7748914f14dcd8c">8ef42d4d</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-07-12T02:31:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: update tool changed for scavenging
Now that scavenging is implemented, the DNS update tool needs to be changed so
that it always updates every name required by the DC. Otherwise, the records
might be scavenged.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10812
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f0210f5d17f27641bccb651313f30087d53c6ef0">f0210f5d</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-07-12T02:31:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: static records
Modifies bind9 and internal dns to match windows static records behaviour.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10812
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bc2e645a382d17c9cdf0120751490fa68263f445">bc2e645a</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-12T02:31:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests dns: fix rpc null byte test
Fix update_add_null_char_rpc_to_dns so that the test matches the name.
It was not passing the embedded null to the rpc call.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ae9dee4ca0ae94ba1ad40952a2772dede8453772">ae9dee4c</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-12T02:31:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests dns: dns.py remove flake8 warnings
Remove flake8 warnings from the code, this highlighted the issue with
test_update_add_null_char_rpc_to_dns fixed in the preceding commit.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aaffc4d1aadc643d8587159e716b0f35ea3413cf">aaffc4d1</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-12T02:31:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests dns: dns_base.py remove flake8 warnings
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59657418107e40d5b95e85dcff164db5bb60e504">59657418</a></strong>
<div>
<span>by Bob Campbell</span>
<i>at 2018-07-12T02:31:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests: check setting values on dnsRecord attributes
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12451
Signed-off-by: Bob Campbell <bobcampbell@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/356f39534036064a5aef49c524b6395469f7098f">356f3953</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-12T02:31:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add entry for "Dynamic DNS record scavenging support"
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10812
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/760e36ddbcb8543f99fd34d97e8b6851dd022c1f">760e36dd</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-07-12T02:31:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: add session_info arg to get_conn_tos
Add session_info arg, so caller can pass it in to reuse authentication info
later. This will improve performance a lot while doing ntacl operations
on large amount of files, e.g.: sysvolreset.
Modification for upstream caller will come in following patches.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13521
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aec40e3a39e27766015113d0f6978faaaaa92e88">aec40e3a</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-07-12T02:31:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: add session_info arg to py_smbd_set_nt_acl
Add session_info arg as optional and pass it down to get_conn_tos.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13521
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9c6ec66bc52d288dcd9f26371e3639345ffe8b5">a9c6ec66</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-07-12T02:31:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd/msdfs: add null check for session_info.unix_info
When a session_info passed down to here, the unix_info could be NULL.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13521
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c9876defe6c641adc9935d85fca50702974a14d6">c9876def</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-07-12T02:31:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd/posix_acls: reuse secutiry token from session info if exist
If session info was passed down from upstream, then try to use it to get
security token, other then creating token every time.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13521
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e2e6dd9d865b97bd5c574181f02208b79c895006">e2e6dd9d</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-07-12T02:32:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ntacls: reuse predefined SECURITY_SECINFO_FLAGS
Use predefined SECURITY_SECINFO_FLAGS to replace bitwise or operations
on flag list.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13521
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8dc8b8d7f9dda3e83632e18bca002b71552a8fa7">8dc8b8d7</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-07-12T02:32:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ntacls: add session_info arg to setntacl and pass down to set_nt_acl api
Then underneath code can reuse the authentication info in session to
improve performance.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13521
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5dd25a654f01797607d82c44e0fff0a5c390f67d">5dd25a65</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-07-12T02:32:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">provision/setsysvolacl: build session_info and pass down to setntacl
Get the admin session info, and pass it down to setntacl.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13521
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8fb821521eea6a4a9ee4f06c1916085dbcdec09d">8fb82152</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-07-12T02:32:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">provision/setsysvolacl: create helper function to simplify code
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13521
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cd9f6c5f74b7f4d5da0e2d892ac1d8b57ddd96f8">cd9f6c5f</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-07-12T02:32:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/posixacl: rm commented code
The example is already in code, no need to keep it here.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13521
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/197b4b8508f5a1e9ed6b538966afd237c328e091">197b4b85</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-07-12T02:32:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/posixacl: define global DOM_SID to make code DRY
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13521
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d68c294ac4b313fd97d8de4e9a814944da0f8c6d">d68c294a</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-07-12T02:32:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/posixacl: define global ACL to make code DRY
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13521
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/11e2c32b4cdd5e3b44d29b86ad3ed1f9d69d66ec">11e2c32b</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-07-12T02:32:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/posixacl: remove unused imports
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13521
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/002987ab3d49a20d96b8318f8cfa1ca78c2a280e">002987ab</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-07-12T02:32:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/posixacl: use assertRaises to simplify code
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13521
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6875f4354a356ccdf11b8a08aa9e197e51a3c40f">6875f435</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-07-12T02:32:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/posixacl: rm duplicated test
There are 2 copy of `test_setposixacl_getposixacl`, this patch removed
the first copy, which was overwritten by the second one.
They are 99% the same except in the last line a_perm is 6 vs 7, and 7 is
the correct number.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13521
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1c09fc2de3cb4cb18cba35ea410fb74742cd9065">1c09fc2d</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-07-12T02:32:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/posixacl: move setUp and tearDown to top
Make it clear to find out what we have in test.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13521
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a8a9bb553c8195425f385eee1cc8efab8cd889e9">a8a9bb55</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-07-12T02:32:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/posixacl: derive a new testcase to run same tests with session
1. existing tests still run with session_info=None
2. new class override `get_session_info` to return a session, so same
set of tests will run again, but with session.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13521
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9502b72af61b0437fb5dbf4f44defd4c1151f41d">9502b72a</a></strong>
<div>
<span>by Timur I. Bakeyev</span>
<i>at 2018-07-12T02:32:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add note about defaults changes for the vfs_full_audit and acceptance of all syslog facilities for all audit modules.
Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f87cde1e70f1f5204dedd45e0cc04ae0b7463813">f87cde1e</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-12T02:32:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Explain that "max xmit" is SMB1 only
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c02023fbbc320e1c25803da94e7dcc9c9376c36d">c02023fb</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-12T02:32:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Fix spelling
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77ffadd3a04d442c19549611dc8cdf253db3863b">77ffadd3</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-12T02:32:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add tests for samba.auth.admin_session()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Pair-programmed-with: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eb6cb6e673e430cb8bb0be326f61c547ae42dfa1">eb6cb6e6</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-12T02:32:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Add samba.auth.session_info_fill_unix()
This fills in the unix portions of the token needed by smbd and the pysmbd bindings
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Pair-programmed-with: Joe Guo <joeg@catalyst.net.nz>
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7422df43bbe0b09f6e7cf57984ea523f4e10249b">7422df43</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-12T02:32:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/posixacl: Test with and without filling in the unix_token
Sadly the unix token cannot be created without a running winbindd,
which is not available during provision and a domain restore.
(Internally in smbd a backup API via passdb is used, but this
is not connected to this function at this time)
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/932dc282d4527e06ab5f8b69b486b339828def60">932dc282</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-12T02:32:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: document sysvolreset improvement
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13521
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5a3690a48f60d68b66d9a76591382a66e62e1668">5a3690a4</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-12T02:32:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Explain that Jansson is requied for AD DC, mention --without-json-audit
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d55b1dc1be661a5e1d429f06b5e1557d6f106326">d55b1dc1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-12T02:32:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Remove mention of --without-json-audit from the AD DC
This is no longer optional for the AD DC.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1a559fd6a9026d72c3cd50d97c454081e9532068">1a559fd6</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-12T02:32:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Ban ldb 1.4.x with Samba 4.8 and earlier
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13519
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/52efa796538ae004ca62ea32fc8c833472991be6">52efa796</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-12T02:32:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Refuse to build Samba against a newer minor version of ldb
Samba is not compatible with new versions of ldb (except release versions)
Other users would not notice the breakages, but Samba makes many
more assuptions about the LDB internals than any other package.
(Specifically, LDB 1.2 and 1.4 broke builds against released
Samba versions)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13519
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b9efc5a628007f84c650789027385faaace913e8">b9efc5a6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T02:32:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: version 1.3.16
* Fix build on AIX
* Python3 compatibility fixes
* Use tdb_wipe_all in "erase" command
* Harden allocating the tdb recovery area
* Make sure the hash size fits
* Harden tdb_check_used_record against overflow
* Harden tdb_rec_read
* Handle TDB_NEXT_LOCK_ERR in tdb_traverse_internal
* Fix build warnings
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/df858ec17e1d86ac983f0e74f7b80fbac64cab30">df858ec1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T02:32:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: version 2.1.14
* Fix some typos in the comments
* Remove extra 0x prefix for the "%p" format specifiers,
avoiding 0x0x0 strings in the output.
* make sure we link extra-python versions of libraries
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3eecdbcc38dbe084b285c9720443d819304f7b97">3eecdbcc</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T05:43:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: version 1.4.1
* add some missing return value checks
* Fix several mem leaks in ldb_index ldb_search ldb_tdb (bug#13475)
* ldb_tdb: Use mem_ctx and so avoid leak onto long-term memory
on duplicated add. (bug#13471)
* ldb: Fix memory leak on module context (bug#13459)
* Refused build of Samba 4.8 with ldb 1.4 (bug #13519)
* Prevent similar issues in the future at configure time (bug #13519)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Jul 12 07:43:22 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c4be5a81c17a18d7afdec473e8e5e7a49b599c1e">c4be5a81</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-12T08:02:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW.txt: CTDB updates for 4.9
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de30faecd0c97ac4996787194f99d7345731428c">de30faec</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-12T08:02:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add information on new GPO features
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d578e5069516d44e6bb89c8706a60addb04f96a1">d578e506</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-07-12T08:08:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.9.0rc1.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7bc8b7f30d35929eb6e84686fdf4abe79e9ac19d">7bc8b7f3</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-07-12T08:09:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.9.0rc1...
and disable GIT_SNAPSHOT for the release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ef0cae1f79e42b68d5581aa2e27f1388b087a973">ef0cae1f</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-07-12T08:27:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.9.0rc2...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2ea15c55816aa1964c44dcc57d5b363018316502">2ea15c55</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-12T11:10:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: decrease large resource fork size in test from 1 GB to 64 MB
64 MB is a more realistic value and lets the test pass on FreeBSD with
fruit:resource=stream and vfs_streams_xattr.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 2729b4329af0ad0b6a8bd188450b8abd76670d8a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c88aa5fb76ae74aefa5ef7a06281f1120d19a8d5">c88aa5fb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-12T11:10:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: test setting EOF of a stream to 0 with enabled AAPL extensions
macOS SMB server uses xattrs as storage backend for streams, directly
exposing xattr get/set characteristics. Setting EOF on a stream to 0
just deletes the xattr as macOS doesn't support 0-byte sized xattrs.
Note that this does not apply to the AFP_AfpInfo and AFP_Resource
streams, they have even stranger semantics and we have other tests
for those.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13441
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit cf5d471544f0cb0d072e4af1ee36798580d32897)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/af4cb57d4f713990973f44678dc5e6d2f9cfa984">af4cb57d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-12T11:10:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: delete 0 byte size streams if AAPL is enabled
macOS SMB server uses xattrs as storage backend for streams, directly
exposing xattr get/set characteristics. Setting EOF on a stream to 0
just deletes the xattr as macOS doesn't support 0-byte sized xattrs.
Note that this does not apply to the AFP_AfpInfo and AFP_Resource
streams, they have even stranger semantics and we have other tests
for those.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13441
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed May 30 02:34:29 CEST 2018 on sn-devel-144
(cherry picked from commit 46d127865f3fb14041797d395db3b3234ed3bd6c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/00b001b0ce9b606eb4cc8f93747ee70fd0eccfa3">00b001b0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-12T11:10:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: run smb2.streams tests against a share with vfs_streams_xattr
The tests are currently only run against streams_depot, where stream IO
is handle based, compared to streams_xattr which is path
based. vfs_streams_xattr is also used much more in real world setups, so
we should run our tests against it.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13451
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(backported from commit aa096ab70a466388a9947f73a525b2dcbb9821e5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/36972fd61d4bf3e1b24575f8ec54610d32d815e1">36972fd6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-12T11:10:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/smb2/streams: try to rename basefile while is has open streams
This tests the following:
- create a file with a stream
- open the the stream and keep it open
- on a second connection, try to rename the basefile, this should fail
with NT_STATUS_ACCESS_DENIED
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13451
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 00d19bdab15102083b8ba395ede161824c898be1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/93ec87ec2ae750071f139728c44c951f86c9a728">93ec87ec</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-12T11:10:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: adjust test testing basefile rename to expect failure
Renaming a basefile that has open streams must fail with
NT_STATUS_ACCESS_DENIED.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13451
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit f166207fc0344b51879d863857055ab7ff36a09b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/85571d08b2683ee2c9bf8f2abc76af8bc6055a86">85571d08</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-12T11:10:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: add private option NTCREATEX_OPTIONS_PRIVATE_STREAM_BASEOPEN
This will be used to mark basefile opens of streams opens. This is
needed to later implement a function that can determine if a file has
stream opens.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13451
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 37e7ff05ab9443c0330e68f5c701ffecedf2d738)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd78d9a602e2a088b3a3b7ce0f0a9520ce926268">dd78d9a6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-12T11:10:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:locking: add file_has_open_streams()
This can be used to check if a file opened by fsp also has stream opens.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13451
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit dd8cf54c79fe8536e34cde15801d60931cd47b8b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/425f513e98a9446e487dd5cd5d9de7ee58404bff">425f513e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-12T11:10:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: don't allow renaming basefile if streams are open
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13451
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 465b7d07e5db787c3d6330371e5e42ecbb1b57b9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/adef988e517384f80dd21f187bf63a54efe8efbd">adef988e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-07-12T11:10:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: pysmbd: Additional error path leak fix.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13474
Signed-off-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c7bedb9c603ebcec339290ba475bc344928fbff5">c7bedb9c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-12T11:10:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: smb_threads: fix access before init bug
talloc_stackframe_internal() calls SMB_THREAD_GET_TLS(global_ts) which
calls smb_get_tls_pthread() in the POSIX pthread wrapper implementation.
If SMB_THREAD_SET_TLS() hasn't been called before, global_ts is NULL and
smb_get_tls_pthread dereferences it so it crashes.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13505
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit e311801e0e7171a2b50e39d3e0c2d2137f8b3d7e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/40c978434cae84b8d762025b954227e0fccfd8e4">40c97843</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-07-12T11:10:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmbclient: Initialize written value before use.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13511
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
(cherry picked from commit 2e4878a69a62fb59d843ee53a1a9469b987e3a59)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6930bb96f5ac2b0a50947478c9bcb79fa58a8b08">6930bb96</a></strong>
<div>
<span>by Bailey Berro</span>
<i>at 2018-07-12T11:10:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmbclient: Initialize written in cli_splice_fallback()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13511
Signed-off-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: David Mulder <dmulder@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon Jul 9 21:29:48 CEST 2018 on sn-devel-144
(cherry picked from commit fe25bc793d30a64f06b19f737c652b0c7389ca92)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c5680ba4b27b35d403cceb6f34cd383352292428">c5680ba4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-12T15:42:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd/durable: remove dev and inode check from vfs_default_durable_reconnect_check_stat()
On a cluster filesystem the device numbers may differ on the cluster
nodes. We already verify the file_id in vfs_default_durable_reconnect(),
so we can safely remove the dev/inode checks.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13318
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 0a91ade5272698c094137fa28d2ad4723b5963cf)
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Thu Jul 12 17:42:50 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/516a440b156e7ec586256067427efbe99fd9bc1a">516a440b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-26T19:24:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs: bump to version 39, Samba 4.9 will ship with that
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit b2ae22a310c07da61ca5d57cba1b403851e928d9)
Autobuild-User(v4-9-test): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(v4-9-test): Thu Jul 26 21:24:08 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bc280e8afc2187cbcf60facda8b9a3cfcd3c2d4f">bc280e8a</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-07-31T10:36:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-dns_server: Only build dns server Python code for AD DC
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13542
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c6a325c97c82c867df2b17f48e565b73f9045c44">c6a325c9</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-07-31T10:36:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-dsdb: only build dsdb Python modules for AD DC
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13542
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d85dd18592a4d1609b186bbaeaec0b43cf1372fd">d85dd185</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-07-31T10:36:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: make sure samba.tests can be imported without SamDB
We are using samba.tests Python module __init__.py file as a catch-all
for all types of helpers. Some of these helpers are only usable with
Samba AD DC targets.
When SamDB is not available in a non-Samba AD DC target, provide a
dummy replacement that simply returns None. This allows to complete
initialization for non-Samba AD DC target tests which do not use
connect_samdb() helper.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13542
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7e9602100ec06ff38e2dc45137e42881ef802598">7e960210</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-31T10:36:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: add binding handle support for [smb1]
This will be used to force smb1.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 062b518cabd9fb5f72f96cdf400c978c0b844619)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a8cd7046efa19f535c076b997f145306c85d2fd3">a8cd7046</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-31T10:36:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: split out smb_raw_negotiate_fill_transport()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 17b12a9b9a9dfd859679de77aa0c7ffbc782f1bc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/00e5ea1fac691e1bd20be313ad4ba3a0c39bb55b">00e5ea1f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-31T10:36:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: add smbcli_transport_raw_init()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit b7e99c2571e31971a6d7f1898e7458c16dc1031e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/71a1355172bd568bc83db3cbf41920f34115cd77">71a13551</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-31T10:36:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: use talloc_zero() for struct smb_composite_connect in fetchfile.c
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 87d73397f9a9dee8fa0055a2ff08244b2c85e120)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f9b685e9a5dfdb58be692c653ff41184415ea622">f9b685e9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-31T10:36:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: allow passing an already negotiated connection to smb_composite_connect()
It will just do the session setup and tree connect steps.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 2b68f9b8b0dd944fa89b9e0037886ddd4fb4e5f9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c85c9b58e7188a44da2662b3caa7cedb071c09ad">c85c9b58</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-31T10:36:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: add smb2_transport_raw_init()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit ce2248c4b5aad2d00155a2e77b3e6340ce824979)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a3a5797e2874eb14e918961e7e46f2d288930d5f">a3a5797e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-31T10:36:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: split out smb2_connect_session_start()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 5ad5b81b6ef601596583b4ad7d6a14241fa99a71)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4d7023f8ab70d00f1321d99d64c87665fdf4cab1">4d7023f8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-31T10:36:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: allow passing an already negotiated connection to smb2_connect_send()
It will just do the session setup and tree connect steps.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit f20e607c15b4c8ae56ade5d7e68d832542a2cd5e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/02f7b65279f1d7b8a57cec498901bd96f22c2206">02f7b652</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-31T10:36:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: add fallback_to_anonymous to smb2_connect_send()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit ca000d8901e6acb8a7c59d26d4f75c9d92bafece)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3d8c4bf85ee41f4c01b8b752c81eb2f0b645c45b">3d8c4bf8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-31T10:36:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: allow a fallback to NTLMSSP if SPNEGO is not supported locally
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 5188454bdce80f6e2bfc45deca18bd1b7289a7a6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b1753afa311fe0c97fd1208cb39de9575a3f2ceb">b1753afa</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-31T10:36:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: add smb_connect_nego_{send,recv}()
This can be used to create a connection up to a negotiated
smbXcli_conn.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit e4910f35eab008a41cfcac3d97b3647c721ac679)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/373406a18ef7bc02953b68a96eda7090713c8029">373406a1</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-07-31T10:36:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/auth_log: Permit SMB2 service description if empty binding is used for kerberos authentication
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 70a9cf9ccfc4075cc08209191db1bce2c9b432fc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/25405ee6c1c4f422e91e051c8638aca41b29769d">25405ee6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-31T10:36:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests: use explicit "client ipc max protocol = NT1" for samba.tests.net_join_no_spnego
The tests rely on SMB1.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 802e43bf742e756896fa73fcd139feca9ae293dd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e3e64256a15ab05dfd69f2b3b6d8fe32ea794f04">e3e64256</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-31T10:36:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:librpc: autonegotiate SMB1/2/3
Windows Server 1709 defaults to SMB2 and does not have SMB1 enabled.
When establishing trust, samba-tool does not specify SMB protocol
version and fail by default.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 4422f7382aad3090cb959ade030a02bf4fef81ac)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a3c26b35d6839d6aabcc8c862200270b11d2b22c">a3c26b35</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-31T10:36:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:selftest: run rpc.lsa.lookupsids also with explicit [smb1] and [smb2]
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 6800077c5c57c257326573537d1f2bb7a8066149)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0b3e00a622ce5af3acf9cba936b6993123955002">0b3e00a6</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-07-31T10:36:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool trust: support discovery via netr_GetDcName
In case a remote DC does not support netr_DsRGetDCNameEx2(),
use netr_GetDcName() instead.
This should help with FreeIPA where embedded smbd runs as a domain
controller but does not implement full Active Directory compatibility.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13538
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Tue Jul 24 09:55:23 CEST 2018 on sn-devel-144
(cherry picked from commit c390728819e73cefbf02e0d52d22805930f4c45b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5abe6e6713161a44c37f8c98191e9c7c6fc31dc8">5abe6e67</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Simplify pstree output in eventd unit tests
pstree truncates output when it exceeds a maximum width - the default
is 132 columns. A couple of recent
commits (12fd8d7a5c5d14d403aac6cd9e318afcd0a8e159,
b23f3f996038626f618c5b5aa552686c1b852f44) lengthened the command
string in the output so that it is more likely to exceed this limit
and be truncated, as below:
==================================================
Running "cat /memdisk/autobuild/fl/b1851760/ctdb/ctdb/tests/var/eventd/debug_script.log"
--------------------------------------------------
Output (Exit status: 0):
--------------------------------------------------
02.enabled.scri,PID /memdisk/autobuild/fl/b1851760/ctdb/ctdb/tests/var/eventd/events/random/02.enabled.script ...
`-sleep,PID 99
01.disabled DISABLED
02.enabled TIMEDOUT DATETIME
OUTPUT: Sleeping for 99 seconds
--------------------------------------------------
Required output (Exit status: 0):
--------------------------------------------------
02.enabled.scri,PID /memdisk/autobuild/fl/b1851760/ctdb/ctdb/tests/var/eventd/events/random/02.enabled.script verbosetimeout
`-sleep,PID 99
01.disabled DISABLED
02.enabled TIMEDOUT DATETIME
OUTPUT: Sleeping for 99 seconds
FAILED
It isn't clear that the above example exceeds 132 characters, given
that the PID has been filtered into a fixed string, but it certainly
goes close. Whether or not it is truncated probably depends on the
width of the PID in the unfiltered output. This would explain why the
test flaps.
Avoid the output truncation by dropping the -a and -p options to
simplify the pstree output.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13531
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit da115efd2b89e10767e9bec7343dce65ffd3c68b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c775cda689c31d57292ef299979787b58a83cc19">c775cda6</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Loosen match against pstree output in simple test
As per previous commit, pstree can truncate output if it gets too
wide. Instead of matching against the script's full path and
arguments, just match against the script name.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13531
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed Jul 18 14:53:39 CEST 2018 on sn-devel-144
(cherry picked from commit 359e52187fbc9b5f94570ff8d12607b4fc42e4f2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3b7a39bd5668b77be29b812cdb0bb9ab6e2c84e6">3b7a39bd</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-31T10:36:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: run test_durable_v2_open_reopen2_lease() in a subdirectory
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13535
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 725319743f1f2de934cbde477ca84430f5b2b4b4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9ad7af6899c2fd7b9498a0f0db8189a6c2f59015">9ad7af68</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-31T10:36:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: fix path check in smbd_smb2_create_durable_lease_check()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13535
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit e60e9368cb3cb512e2506620d814187a692108e0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/14963928ffb908ff49e0261915c7d651ba9b7b97">14963928</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-31T10:36:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns wildcards: tests to confirm BUG 13536
DNS wildcard matching failing if more than one label to the left of the
wildcard. This commits adds tests to confirm the bug.
Wildcard entry: *.example.org
bar.example.com matches
foo.bar.example.com does not, but it it should.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 0d3aec18679a2637430263a55de5e210a9201e21)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a6dab26aa852a17198688ce4966ce9969d8590af">a6dab26a</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-31T10:36:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns wildcards: fix BUG 13536
The current position in the dns name was not advanced past the '.'
character
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jul 20 04:40:31 CEST 2018 on sn-devel-144
(cherry picked from commit cef1b31cd1f33074e8ab6de52aa0fb74e9b57a9f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/76d3abeecaecaf33ace0db9149dcebc7bdefe6d5">76d3abee</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-07-31T10:36:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix Linux sendfile() for SMB2. Ensure we don't spin on EAGAIN.
For SMB2 the socket is set non-blocking. Ensure sendfile()
calls complete if they return EAGAIN by saving the socket state,
setting it blocking, doing the sendfile until completion and then
restoring the socket state.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 809967b3eab7a1b48c186517701538ca93536246)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8652ab1be380faa2e1a08c64eb723f6aa1a4bbe9">8652ab1b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-07-31T10:36:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix Solaris sendfile() for SMB2. Ensure we don't spin on EAGAIN.
For SMB2 the socket is set non-blocking. Ensure sendfile()
calls complete if they return EAGAIN by saving the socket state,
setting it blocking, doing the sendfile until completion and then
restoring the socket state.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 16a587075c8c62c1160869358ca56a133e90247a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b54ad07aad4840aba6379d5e6b655929c828c97">8b54ad07</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-07-31T10:36:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix HPUX sendfile() for SMB2. Ensure we don't spin on EAGAIN.
For SMB2 the socket is set non-blocking. Ensure sendfile()
calls complete if they return EAGAIN by saving the socket state,
setting it blocking, doing the sendfile until completion and then
restoring the socket state.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit d222caa449d9c00bb2dd9da6c79ea509960d47c6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a221165ede44d8bdc1c52dc2d931ea3b857c0530">a221165e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-07-31T10:36:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix FreeBSD sendfile() for SMB2. Ensure we don't spin on EAGAIN.
For SMB2 the socket is set non-blocking. Ensure sendfile()
calls complete if they return EAGAIN by saving the socket state,
setting it blocking, doing the sendfile until completion and then
restoring the socket state.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 456e520a3be7e4b54f1f144324c3671b8f6e35ea)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c2e666af7a882f6884e29beec39a328d224608a">4c2e666a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-07-31T10:36:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix AIX sendfile() for SMB2. Ensure we don't spin on EAGAIN.
For SMB2 the socket is set non-blocking. Ensure sendfile()
calls complete if they return EAGAIN by saving the socket state,
setting it blocking, doing the sendfile until completion and then
restoring the socket state.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Jul 20 15:14:24 CEST 2018 on sn-devel-144
(cherry picked from commit 582ce5d6b599516d6d8d619529a2aa809139a175)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/23b5be4f9947f257b7cfa8d60491fb0a3fd23b72">23b5be4f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Improve portability by not using /bin/bash directly
FreeBSD and others do not have /bin/bash, so use "/usr/bin/env bash"
for better flexibility.
There are still many integration tests that use /bin/bash but this at
least lets FreeBSD start running tests.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 73298ac8a9a87dcf3b3699dfdd39a8e865291620)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d28f016441dfbb3371beb58e0b722c3742097bd">7d28f016</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Improve portability by not using /bin/bash directly
FreeBSD and others do not have /bin/bash, so use "/usr/bin/env bash"
for better flexibility.
There are still many integration tests that use /bin/bash but this at
least lets FreeBSD start running tests.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit dd9d8a20aa6948a5d1e7fb532842b7ff5bc0f550)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e4b703ede52c9b3345ff875230c57461a4db20dc">e4b703ed</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Avoid use of non-portable getopt in onnode
getopt is being used with non-portable options. Use simpler,
POSIX-compliant getopts instead.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 4a39bc4aaad541f1e89c0eb3e98d4104bcc25025)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/04a9667fc8b0624ea1138bbf881879f3e48f5d4e">04a9667f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid use of non-portable getopt in run_tests.sh
getopt is being used with non-portable options. Use simpler,
POSIX-compliant getopts instead.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 56ffca3e79923a028ff96fbd50706d808b9dd215)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ebeecc34318d4046ca28573da76a933e9a54a840">ebeecc34</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid use of non-portable getopt in stubs
getopt is being used with non-portable options. In most cases use
simpler, POSIX-compliant getopts instead.
In the case of the ctdb test stub command, options can appear after
other arguments, so this requires an additional nested loop.
In the case of smnotify, there are no short options, so handle the
long options manually.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 896c77df1ce2645c6dd7898b59ea802e204dc7d9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/58671b0079f1d754111015efd91e45599d5da3b6">58671b00</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Improve portability by not using mktemp --tmpdir option
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 2f2c35a1cb4afe38e869882e8f18a62d4daac981)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f6be6615c0b3153b9dda8e7a424bac7ae514d301">f6be6615</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Switch some test stubs to use /bin/sh
They don't use any bash features.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit f13824b291fca9cdaa936c238d7e9bcb73927da7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3f757916bc61e833cfa1b406de38fb27c076bba4">3f757916</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add errno matching utility
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit af8c31ead80d6c74b0e9d057cb47dff6552178a9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d49d03db06cf80e331c935abc95f36e361ac8c41">d49d03db</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add required_error() to match on error codes
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit e8a1b3db7abfa9e4a53e98a0aa21dfc268a21c92)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/43cd4e47ae92f0f71f94790a31588cd170e2348c">43cd4e47</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Switch to ETIMEDOUT from ETIME
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit a42a7232990fa163d046fb07be351ea3e0467046)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0782860bb5013928469bf56056679d2323c92a55">0782860b</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Switch to ETIMEDOUT instead of ETIME
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit c8756ec17be11e40bc7e75aac7afdb323acb42e2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/60ef296034e517de4343d54030d47319c7a200cc">60ef2960</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Switch to using ETIMEDOUT instead of ETIME
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit b886a95eca306d0062240e5710ae0ed4505b1068)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ed503603df6f2618e1bdc1f7cc66e2815af05f67">ed503603</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-client: Switch to ETIMEDOUT instead of ETIME
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit e1236a855ffc493efb5e9cb7b295034376e56d3a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/adc4c784f03f974176cc01fd8664883360e949f1">adc4c784</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add ps output filter for freebsd
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit b7dbe9f306fda0d8f1dcc8dd81864539f6ff2632)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0ec4783c32f3ed3947a70efb1a5e5c684c769af5">0ec4783c</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add signal code matching utility
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit b0028dd5bf2d5466a50dfd12a82a23f30e9ccf48)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/16838f3cf312ff7b1f5f90586c948c2054339c94">16838f3c</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use sigcode to match signals
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 23952c9165bbdcae8f34b7dfefdbb4a499a55362)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fcae5c60af1197ad4a26607f56b681dfbec7c5d8">fcae5c60</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Porting tests should ignore unsupported features
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 0273171c30a5bcfdfc0b3f74c1d5a89dbaa5b204)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b21efa24ac0b798a19a02df0a63c9a107cdc43d9">b21efa24</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Add line based I/O
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit c7041b0faf490661818244dd032ad413ce906e5c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ea5643fe165b958545cdc31de9aeab53309182c6">ea5643fe</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Avoid fgets in ctdb_connection_list_read
C library buffering API can behave in unexpected fashion if underlying
fd for stdin, stdout or stderr is closed and re-opened.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit c9b42d27e6cf9e6ae36f44970f0a388edc737a7a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eb1279e6dfcd02222ff9643dc2fa165d98e115d0">eb1279e6</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Add fd argument to ctdb_connection_list_read()
This makes testing easier.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 3bf753e830c20183ef4f3278880d3be362e53bef)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/18aa65484ba7c5f8c1ac4c43d0504c1d1563f041">18aa6548</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Do not try to match pstree output in eventd tests
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 4152e98c0e95a938e17f95c543c2114bbf54b136)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/33df4f987f2f2ff18a9ab0fbbd18296e03baecde">33df4f98</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Simplify pattern matching for ctime output
On freebsd, sed does not accept multiple pattern strings.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 68542dbb5ab7b9d17b476937d1c84fe19d893255)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/55fe4b5641bf91edefb5b42f5d9f9603d68ea9ca">55fe4b56</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: date "+%N" is non-portable
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 96d5c7de82f795e33e9998e0fe94ddcb50e7421d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/862aedcd302ec31ba8c3d108eb7672f78c08a8d1">862aedcd</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use portable wc -c instead of stat -c "%s"
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 07844c2ec9583362594241e607d81aaead8f1a99)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0be07aec5b4524673948f34f621a2d78fb9c2a06">0be07aec</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Replace md5sum with posix cksum
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 22c3078c8b10c88f8aff22caa7c92a06f387f17d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0733f13398b976ff8117b270b677341aa5d01a5e">0733f133</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use errcode to translate ETIMEDOUT
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 65cc36f24d8a92c749dbc3700802e1d83a9ceb9f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/23e41315192a3cb99eb8f3b783b5b9f24e942c2f">23e41315</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Fix a typo
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 6f5ed2b8b829e01fc675537e47095868ff8b5aa2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e4aa9b98d7543d116f7fc5a1697e6f38717fa6bc">e4aa9b98</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Strip all spaces from od output
On freebsd, there are trailing spaces in od output.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 3047202ce733d1a767fbc83c7021cb83bb83e0e1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eb3f8ae42e8bbf7e37529a97e0111dd5d173d32a">eb3f8ae4</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-31T10:36:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Fix the TCP packet length check
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit be43e08072ebce937ed0a02cd8d9d1c6072b178d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d4e9454f107df8ea0c1c132bb91d37586b3429cf">d4e9454f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Fix compilation issue with strncpy()
When configured with --picky-developer and using -O3 with gcc 8.1:
../common/system_socket.c: In function ‘parse_ip_mask’:
../common/system_socket.c:229:2: error: ‘strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
strncpy(s, str, len+1);
^~~~~~~~~~~~~~~~~~~~~~
../common/system_socket.c:223:8: note: length computed here
len = strlen(str);
^~~~~~~~~~~
Use strlcpy() instead and check the result.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13545
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 5dd84bf5d73e4afab094834bc317da7884b9b9b3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c2513d82c4555e2a970b4a65bd4f2616735e040">5c2513d8</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Fix compilation issue with strncpy()
When configured with --picky-developer and using -O3 with gcc 8.1:
../protocol/protocol_util.c: In function ‘ctdb_sock_addr_from_string’:
../protocol/protocol_util.c:282:2: error: ‘strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
strncpy(s, str, len+1);
^~~~~~~~~~~~~~~~~~~~~~
../protocol/protocol_util.c:277:8: note: length computed here
len = strlen(str);
^~~~~~~~~~~
Use strlcpy() instead and check the result.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13545
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 3b56f2002a35b55b46958178c79aee519f0c5880)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d197d11a6ce9c15c576f4980f54d38f5c1d25c63">d197d11a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Replace obsolete reference to CTDB_DEBUG_HUNG_SCRIPT option
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13546
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Sat Jul 28 07:26:24 CEST 2018 on sn-devel-144
(cherry picked from commit a44e6987b1e469ae202777cd575fd81c19e1ac6c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cb1292d6aac633e3f94832f194d48b5f2d7723d4">cb1292d6</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add further CTDB updates for 4.9
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f24f0f13005ae2ad6c40500b830ae8b383870427">f24f0f13</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-doc: Provide an example script for migrating old configuration
Include an example ctdbd.conf-style file for testing.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13550
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Mon Jul 30 14:30:06 CEST 2018 on sn-devel-144
(cherry picked from commit 4fcbaae57b129deaacfab0a226cefca99aa78256)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/34aba6f9ef373b1e654e13f0bbe802087c1a4ec6">34aba6f9</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Fix "ctdb event status" usage message
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13551
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 56e248de6072063308786ea83282aaecc8d7e62a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4cce86e872b10f387988dbf6c06303c55bfb6018">4cce86e8</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Factor out basic script abstraction
Provides for listing of scripts and chmod enable/disable.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13551
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit a7a4ee439dc1cf262b4da9fbcb38a2f69c62744c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c65347e949b27d2532361e9395ac8ab9d3394ef">0c65347e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Use script abstraction in run_event
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13551
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 82e62488027302e541739628210292c2d95717e1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/792e170278134f030996cdab5607a88e53a52b00">792e1702</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Change event-tool script enable/disable to chmod file directly
They no longer go over the socket to eventd to enable and disable
scripts. Use the event script abstraction to chmod them directly.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13551
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 295826f1b83b6e59d24e4da43b290242c17f44af)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8932003d606bd7bfbac55cc92a72f95db79623d1">8932003d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T10:36:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Implement event tool "script list" command
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13551
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 5017325c2ef84b10ccd23328f5d62ac5b246bbb3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d666a5e0b1d8529b88bf7cabbcfdf8cebbce5ff1">d666a5e0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-31T13:27:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Update documentation for "ctdb event" command
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13551
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Sat Jul 28 20:03:52 CEST 2018 on sn-devel-144
(cherry picked from commit e3ce1a2dfc4cbba4bf22381b91e9a14c8f240f5d)
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Tue Jul 31 15:27:32 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9fc6a2eba2fa23237e6db7a7b80015c4ff32bc14">9fc6a2eb</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-07-31T16:27:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.9.0rc2.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f744ab6f89c60b1c5733fa17ffc82ab91237f5d">7f744ab6</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-07-31T16:27:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.9.0rc2 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7894067dd8d1a4928d7be42ae786e25282f2eca4">7894067d</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-07-31T16:27:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.9.0rc3...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4954a6da82e13459b0756f1b29c8a9b417bcca8d">4954a6da</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-08-11T06:16:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.8.4...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
(cherry picked from commit 1df7f93b6ede803ec01424c48d2f1f3526c9818c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/677fad5e51ab1f9782f2d7a8fa3c708a2d2bd4a0">677fad5e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-11T06:16:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10858: libsmb: Ensure smbc_urlencode() can't overwrite passed in buffer.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13453
CVE-2018-10858: Insufficient input validation on client directory
listing in libsmbclient.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5923c3ccfc11462b841db9e015a33e5f96459e47">5923c3cc</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-11T06:16:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10858: libsmb: Harden smbc_readdir_internal() against returns from malicious servers.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13453
CVE-2018-10858: Insufficient input validation on client directory
listing in libsmbclient.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87aa836153e6fb48ea05d3fd98b8e05c527daf72">87aa8361</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-11T06:16:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10918: cracknames: Fix DoS (NULL pointer de-ref) when not servicePrincipalName is set on a user
This regression was introduced in Samba 4.7 by bug 12842 and in
master git commit eb2e77970e41c1cb62c041877565e939c78ff52d.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13552
CVE-2018-10918: Denial of Service Attack on AD DC DRSUAPI server.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bbb72cfc343a2da135402536739ad4fbb5ee5c1c">bbb72cfc</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-11T06:16:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 security: Move object-specific access checks into separate function
Object-specific access checks refer to a specific section of the
MS-ADTS, and the code closely matches the spec. We need to extend this
logic to properly handle the Control-Access Right (CR), so it makes
sense to split the logic out into its own function.
This patch just moves the code, and should not alter the logic (apart
from ading in the boolean grant_access return variable.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a81f32e73026c02491983a3136834c3c72d1d03f">a81f32e7</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-11T06:16:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 security: Add more comments to the object-specific access checks
Reading the spec and then reading the code makes sense, but we could
comment the code more so it makes sense on its own.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77421f33f853aed254ed67a6541f86e4070c4128">77421f33</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-11T06:16:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 tests: Add tests for guessing confidential attributes
Adds tests that assert that a confidential attribute cannot be guessed
by an unprivileged user through wildcard DB searches.
The tests basically consist of a set of DB searches/assertions that
get run for:
- basic searches against a confidential attribute
- confidential attributes that get overridden by giving access to the
user via an ACE (run against a variety of ACEs)
- protecting a non-confidential attribute via an ACL that denies read-
access (run against a variety of ACEs)
- querying confidential attributes via the dirsync controls
These tests all pass when run against a Windows Dc and all fail against
a Samba DC.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/03dba18bc99f5e37821bfde9c138b012e730d4c7">03dba18b</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-11T06:16:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 tests: Add test case for object visibility with limited rights
Currently Samba is a bit disclosive with LDB_OP_PRESENT (i.e.
attribute=*) searches compared to Windows.
All the acl.py tests are based on objectClass=* searches, where Windows
will happily tell a user about objects they have List Contents rights,
but not Read Property rights for. However, if you change the attribute
being searched for, suddenly the objects are no longer visible on
Windows (whereas they are on Samba).
This is a problem, because Samba can tell you about which objects have
confidential attributes, which in itself could be disclosive.
This patch adds a acl.py test-case that highlights this behaviour. The
test passes against Windows but fails against Samba.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a90cb03e19e06eeb32536d02c111bdb0bc3d927d">a90cb03e</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-11T06:16:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 security: Fix checking of object-specific CONTROL_ACCESS rights
An 'Object Access Allowed' ACE that assigned 'Control Access' (CR)
rights to a specific attribute would not actually grant access.
What was happening was the remaining_access mask for the object_tree
nodes would be Read Property (RP) + Control Access (CR). The ACE mapped
to the schemaIDGUID for a given attribute, which would end up being a
child node in the tree. So the CR bit was cleared for a child node, but
not the rest of the tree. We would then check the user had the RP access
right, which it did. However, the RP right was cleared for another node
in the tree, which still had the CR bit set in its remaining_access
bitmap, so Samba would not grant access.
Generally, the remaining_access only ever has one bit set, which means
this isn't a problem normally. However, in the Control Access case there
are 2 separate bits being checked, i.e. RP + CR.
One option to fix this problem would be to clear the remaining_access
for the tree instead of just the node. However, the Windows spec is
actually pretty clear on this: if the ACE has a CR right present, then
you can stop any further access checks.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7016bfd31abc16b6d190ec9b6c9be4b0fb1d3a69">7016bfd3</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-08-11T06:16:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 tests: test ldap searches for non-existent attributes.
It is perfectly legal to search LDAP for an attribute that is not part
of the schema. That part of the query should simply not match.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6e35ae37611590cbebabf30c173071f1ee9b9766">6e35ae37</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-11T06:16:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 acl_read: Split access_mask logic out into helper function
So we can re-use the same logic laster for checking the search-ops.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f9fa4e5c9325c68e97f51ac76855b1d92a4f1cba">f9fa4e5c</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-11T06:16:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 acl_read: Small refactor to aclread_callback()
Flip the dirsync check (to avoid a double negative), and use a helper
boolean variable.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1575ba4234a7fbb0d2cc7b23e361c4e753939a6b">1575ba42</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-11T06:16:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 acl_read: Flip the logic in the dirsync check
This better reflects the special case we're making for dirsync, and gets
rid of a 'if-else' clause.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9891df452e53b5e7b52ef6a0ce40b7b64aee28bf">9891df45</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-11T06:16:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 acl_read: Fix unauthorized attribute access via searches
A user that doesn't have access to view an attribute can still guess the
attribute's value via repeated LDAP searches. This affects confidential
attributes, as well as ACLs applied to an object/attribute to deny
access.
Currently the code will hide objects if the attribute filter contains an
attribute they are not authorized to see. However, the code still
returns objects as results if confidential attribute is in the search
expression itself, but not in the attribute filter.
To fix this problem we have to check the access rights on the attributes
in the search-tree, as well as the attributes returned in the message.
Points of note:
- I've preserved the existing dirsync logic (the dirsync module code
suppresses the result as long as the replPropertyMetaData attribute is
removed). However, there doesn't appear to be any test that highlights
that this functionality is required for dirsync.
- To avoid this fix breaking the acl.py tests, we need to still permit
searches like 'objectClass=*', even though we don't have Read Property
access rights for the objectClass attribute. The logic that Windows
uses does not appear to be clearly documented, so I've made a best
guess that seems to mirror Windows behaviour.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a915e23addbb37c199d6dbde6c6283642e742841">a915e23a</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-11T06:16:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 tests: Add extra test for dirsync deleted object corner-case
The acl_read.c code contains a special case to allow dirsync to
work-around having insufficient access rights. We had a concern that
the dirsync module could leak sensitive information for deleted objects.
This patch adds a test-case to prove whether or not this is happening.
The new test case is similar to the existing dirsync test except:
- We make the confidential attribute also preserve-on-delete, so it
hangs around for deleted objcts. Because the attributes now persist
across test case runs, I've used a different attribute to normal.
(Technically, the dirsync search expressions are now specific enough
that the regular attribute could be used, but it would make things
quite fragile if someone tried to add a new test case).
- To handle searching for deleted objects, the search expressions are
now more complicated. Currently dirsync adds an extra-filter to the
'!' searches to exclude deleted objects, i.e. samaccountname matches
the test-objects AND the object is not deleted. We now extend this to
include deleted objects with lastKnownParent equal to the test OU.
The search expression matches either case so that we can use the same
expression throughout the test (regardless of whether the object is
deleted yet or not).
This test proves that the dirsync corner-case does not actually leak
sensitive information on Samba. This is due to a bug in the dirsync
code - when the buggy line is removed, this new test promptly fails.
Test also passes against Windows.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c775bd8b26ef91238cb69d055930d3434ed049a0">c775bd8b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-08-11T06:16:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/tests.py: remove always-needed, never-set with_cmocka flag
We have cmocka in third_party, so we are never without it.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(Backported from commit 33ef0e57a4f08eae5ea06f482374fbc0a1014de6
by Andrew Bartlett)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3454eae9d41b23f856b350d1aac88795f339bdc3">3454eae9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-11T06:16:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1139 libcli/auth: Add initial tests for ntlm_password_check()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13360
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5fb35b7f8e184879c3c8931e9af31befdc75aeac">5fb35b7f</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-08-11T06:16:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1139 libcli/auth: fix debug messages in hash_password_check()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13360
CVE-2018-1139: Weak authentication protocol allowed.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f0bd8cc723d8f119f90367f6d0258ff250a6075c">f0bd8cc7</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-08-11T06:16:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1139 s3-utils: use enum ntlm_auth_level in ntlm_password_check().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13360
CVE-2018-1139: Weak authentication protocol allowed.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6993f39d20de0944c557336a99ac8e63551c808c">6993f39d</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-08-11T06:16:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1139 selftest: verify whether ntlmv1 can be used via SMB1 when it is disabled.
Right now, this test will succeed.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13360
CVE-2018-1139: Weak authentication protocol allowed.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a5245e464d710ecb41c759d04ae1c762fbd8d2e9">a5245e46</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-08-11T06:16:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1139 libcli/auth: Do not allow ntlmv1 over SMB1 when it is disabled via "ntlm auth".
This fixes a regression that came in via 00db3aba6cf9ebaafdf39ee2f9c7ba5ec2281ea0.
Found by Vivek Das <vdas@redhat.com> (Red Hat QE).
In order to demonstrate simply run:
smbclient //server/share -U user%password -mNT1 -c quit \
--option="client ntlmv2 auth"=no \
--option="client use spnego"=no
against a server that uses "ntlm auth = ntlmv2-only" (our default
setting).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13360
CVE-2018-1139: Weak authentication protocol allowed.
Guenther
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/95c95a4a99a41e175784319259f646f3deffcfe9">95c95a4a</a></strong>
<div>
<span>by Andrej Gessel</span>
<i>at 2018-08-11T06:16:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1140 Add NULL check for ldb_dn_get_casefold() in ltdb_index_dn_attr()
Signed-off-by: Andrej Gessel <Andrej.Gessel@janztec.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13374
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7331723918018a40904ab7339b051e7ebb136a6e">73317239</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-11T06:16:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1140 ldb: Check for ldb_dn_get_casefold() failure in ldb_sqlite
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13374
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a36db4fceb3235047f190f6d23841394b17aafec">a36db4fc</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-11T06:16:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1140 ldb_tdb: Ensure the dn in distinguishedName= is valid before use
ldb_dn_from_ldb_val() does not validate this untrusted input, so a later
call to ldb_dn_get_casefold() can fail if the input is not valid.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13374
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ebc3a1a137f0182d5c0b2b60d65578864b441e54">ebc3a1a1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-11T06:16:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1140 ldb_tdb: Check for DN validity in add, rename and search
This ensures we fail with a good error code before an eventual ldb_dn_get_casefold() which
would otherwise fail.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13374
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/47bf6f6e411668b62ad6dfd9c01f19ad8e3a6829">47bf6f6e</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-11T06:16:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1140 ldb: Add tests for search add and rename with a bad dn= DN
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13374
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ad366eb3db510d7e2dd54a7a796180416dea315">5ad366eb</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-11T06:16:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Release LDB 1.3.5 for CVE-2018-1140
* Security fix for CVE-2018-1140 (NULL pointer de-reference, bug 13374)
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/43aba6bd8e32fd03bd1cbb6c0304f0e75f8ab9c1">43aba6bd</a></strong>
<div>
<span>by Kai Blin</span>
<i>at 2018-08-11T06:16:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1140 dns: Add a test to trigger the LDB casefolding issue on invalid chars
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13466
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/032a6a4689d77034dc8827c8764c2f913e47b56c">032a6a46</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-08-11T06:16:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.8.4.
o CVE-2018-1139 (Weak authentication protocol allowed.)
o CVE-2018-1140 (Denial of Service Attack on DNS and LDAP server.)
o CVE-2018-10858 (Insufficient input validation on client directory
listing in libsmbclient.)
o CVE-2018-10918 (Denial of Service Attack on AD DC DRSUAPI server.)
o CVE-2018-10919 (Confidential attribute disclosure from the AD LDAP
server.)
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/626c489c2c879aef8b82efe9f7e832cca0183f4d">626c489c</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-08-11T06:16:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the Samba 4.8.4 release.
o CVE-2018-1139 (Weak authentication protocol allowed.)
o CVE-2018-1140 (Denial of Service Attack on DNS and LDAP server.)
o CVE-2018-10858 (Insufficient input validation on client directory
listing in libsmbclient.)
o CVE-2018-10918 (Denial of Service Attack on AD DC DRSUAPI server.)
o CVE-2018-10919 (Confidential attribute disclosure from the AD LDAP
server.)
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b336179c60631b26da6b0ea5472d919c990c1198">b336179c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-08-13T10:56:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: always set vuid in check_user_ok()
A SMB session reauth will have invalidated conn->vuid via
conn_clear_vuid_caches().
Ensure conn->vuid always has the vuid of the current user in
check_user_ok().
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13351
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Mar 22 18:26:04 CET 2018 on sn-devel-144
(cherry picked from commit 42d6dd2f30b6c3b3176bd1f378422a2eb62b1008)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d23a1c1ff8279bdfce7ee48ecca2e6862690448a">d23a1c1f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-08-13T10:56:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: add binding handle support for [smb1]
This will be used to force smb1.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 062b518cabd9fb5f72f96cdf400c978c0b844619)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b5e4a71dfa763d61aab1f92dae215ac27fecaaf">6b5e4a71</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-08-13T10:56:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-tldap: do not install test_tldap
Guenther
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13529
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Jul 14 03:09:00 CEST 2018 on sn-devel-144
(cherry picked from commit 26fd7096b1f99a2754f634669d5432109023bfa5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/92b6b9098c510de1b7e4e4183b2b3dda8ca45eab">92b6b909</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-08-13T10:56:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: split out smb_raw_negotiate_fill_transport()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 17b12a9b9a9dfd859679de77aa0c7ffbc782f1bc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b98831d0fafc86b5308c204d672cc6ead85f0e0">8b98831d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib: Fix misleading typo in debug message
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/19e65aff16bf57ab007ab101bc6094ab54123f01">19e65aff</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-08-13T10:56:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: add smbcli_transport_raw_init()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit b7e99c2571e31971a6d7f1898e7458c16dc1031e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d7b1dc0f5735f4d4192e80a0389eea1ba399bc0">1d7b1dc0</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: Avoid potential smbpanic calling parse_user_quota_list.
Calling parse_user_quota_list with a NULL buffer can cause a panic, while
this shouldn't happen, I managed to trigger this with an early implementation
of SMB2 quota support in smbd which didn't pass back NT_STATUS_NO_MORE_ENTRIES
when handling a SMB2_0_INFO_QUOTA GETINFO message.
OTHOH the Windows client handled the same situation gracefully.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77ab463cba24482c049b6977fec82917f68b569a">77ab463c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-08-13T10:56:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: use talloc_zero() for struct smb_composite_connect in fetchfile.c
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 87d73397f9a9dee8fa0055a2ff08244b2c85e120)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6c24eaeab1f3864efa57b44177241101e7d82974">6c24eaea</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: Don't stat when doing a quota operation (as it's a fake file)
calling SMB_VFS_STAT on the quota fake file fails and caused
FS_INFO/FileFsControlInfo request to error out early, in turn stopped a
Win8.1 client from proceeding with quota queries.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1136ff225fb021c39d9752bb06cbf397a1a0439a">1136ff22</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-08-13T10:56:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: allow passing an already negotiated connection to smb_composite_connect()
It will just do the session setup and tree connect steps.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 2b68f9b8b0dd944fa89b9e0037886ddd4fb4e5f9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59bb7dde27040d12ac33c4693cb3acabf4132005">59bb7dde</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc/idl Add some query [getset]info quota related structures
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dbf268e6e62d758f0ee9aec0ca758303fe10a240">dbf268e6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-08-13T10:56:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: add smb2_transport_raw_init()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit ce2248c4b5aad2d00155a2e77b3e6340ce824979)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0ccd34a5b4f5783e319490b57ca37df038933732">0ccd34a5</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: adjust smb1 cli code to use idl structs and ndr push/pull funcs.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2635c62553bdc59bf646a958226ea523eb610a16">2635c625</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-08-13T10:56:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: split out smb2_connect_session_start()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 5ad5b81b6ef601596583b4ad7d6a14241fa99a71)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bdfcecc3c507b0129a9e73ca3dfbb1c09b8c9bc9">bdfcecc3</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: adjust smb2 code for new idl structs & generated ndr push/pull funcs.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2fd61b0e8645a832aeb963b8f437f279f7eaa735">2fd61b0e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-08-13T10:56:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: allow passing an already negotiated connection to smb2_connect_send()
It will just do the session setup and tree connect steps.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit f20e607c15b4c8ae56ade5d7e68d832542a2cd5e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3212bc7694cf8f683f436f129289671122cbf92f">3212bc76</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-08-13T10:56:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: add fallback_to_anonymous to smb2_connect_send()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit ca000d8901e6acb8a7c59d26d4f75c9d92bafece)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/046d3a3d05ba2e2737b56f54f953c31d93d22eab">046d3a3d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: adjust smb1 server to use idl structs and generated ndr push/pull funcs
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dcaa67ffa4d8e4dc311de683dc68922a2e343b08">dcaa67ff</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-08-13T10:56:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: allow a fallback to NTLMSSP if SPNEGO is not supported locally
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 5188454bdce80f6e2bfc45deca18bd1b7289a7a6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b65c3de5942a026afc953f7e82ec688977f44527">b65c3de5</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: smb2 server implementation for query get/set info.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5b60ffce1812381fd8207aaa1af5d775391d8943">5b60ffce</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-08-13T10:56:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: add smb_connect_nego_{send,recv}()
This can be used to create a connection up to a negotiated
smbXcli_conn.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit e4910f35eab008a41cfcac3d97b3647c721ac679)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9d0df49faa13fb6bfffb0295776bb3e5e3f04e1">a9d0df49</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/script/test: modify existing smbcquota test to use SMB2 in addition to SMB1.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/94ab84fff490bdcd96bc26e920c8813976869c54">94ab84ff</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-08-13T10:56:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/auth_log: Permit SMB2 service description if empty binding is used for kerberos authentication
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 70a9cf9ccfc4075cc08209191db1bce2c9b432fc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/951722d6eeac55dfa01056ce96be0c4ba3f1fbfa">951722d6</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/script/tests: Add simple (smb1 & smb2) get/set/list tests for smbcquotas
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e9494f9b096f6469a3ce0c5c628577ae7e011b96">e9494f9b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-08-13T10:56:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests: use explicit "client ipc max protocol = NT1" for samba.tests.net_join_no_spnego
The tests rely on SMB1.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 802e43bf742e756896fa73fcd139feca9ae293dd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/134f17cee10c6db09e637e775945c8a7d230121c">134f17ce</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: allow set quota for non root user (when built with --enable-selftest)
Currently it appears you need to be root to set quotas, for test purposes
this requirement needs to be relaxed.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ecf9e20e8bf94cf476aeba425b3a554b15d0eee4">ecf9e20e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-08-13T10:56:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:librpc: autonegotiate SMB1/2/3
Windows Server 1709 defaults to SMB2 and does not have SMB1 enabled.
When establishing trust, samba-tool does not specify SMB protocol
version and fail by default.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 4422f7382aad3090cb959ade030a02bf4fef81ac)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b0c0a19da81dbf5b963f9524aa015547adb15bb9">b0c0a19d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/utils: fix regression where specifying -Unetbios/root works
Usually you need to be root on a linux server to modify quotas. Even
with a linux server joined to a windows AD you could always log in as
local root with smbcquotas. However in recent builds this has changed.
This patch fixes this
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Tue Jul 31 19:45:59 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4b3ac377a6e8aed03a8e8c478768a32bf6b78fba">4b3ac377</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-08-13T10:56:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:selftest: run rpc.lsa.lookupsids also with explicit [smb1] and [smb2]
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 6800077c5c57c257326573537d1f2bb7a8066149)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/04a8995fd0b8fe4f9ab59e91b51b0d9bdf1a04c4">04a8995f</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-08-13T10:56:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool trust: support discovery via netr_GetDcName
In case a remote DC does not support netr_DsRGetDCNameEx2(),
use netr_GetDcName() instead.
This should help with FreeIPA where embedded smbd runs as a domain
controller but does not implement full Active Directory compatibility.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13538
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Tue Jul 24 09:55:23 CEST 2018 on sn-devel-144
(cherry picked from commit c390728819e73cefbf02e0d52d22805930f4c45b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a546235712bc475df1abd0f92c07dd656bb5338">2a546235</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-13T10:56:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Refuse to build Samba against a newer minor version of ldb
Samba is not compatible with new versions of ldb (except release versions)
Other users would not notice the breakages, but Samba makes many
more assuptions about the LDB internals than any other package.
(Specifically, LDB 1.2 and 1.4 broke builds against released
Samba versions)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13519
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
(cherry picked from commit 52efa796538ae004ca62ea32fc8c833472991be6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ec2249635a356437594321f3f95aa1deedb5ff53">ec224963</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-13T10:56:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Fix a cut&paste error
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13554
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 33d012c3cebb5625e02450ac3b08c4245a3e985d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/35587653149f23144f3348cb4a86267d3c1bd807">35587653</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-08-13T10:56:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_ceph: don't lie about flock support
Instead, match vfs_gluster behaviour and require that users explicitly
disable "kernel share modes".
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13506
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 926ae50627d536735cee9b3931ee35bc19060261)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/39dc0db85f5e8ae4466c828eba9650e3610bf422">39dc0db8</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-08-13T10:56:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-eventd: Fix CID 1438155
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13554
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Aug 3 11:14:01 CEST 2018 on sn-devel-144
(cherry picked from commit f7b2e5eec5ba1fa5f26694e6555a98cab0594a27)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a96f69a346a4d7a46873c1d3d65d90578fdf15e6">a96f69a3</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-08-13T10:56:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs/vfs_ceph: add CTDB_SAMBA_SKIP_SHARE_CHECK=yes caveat
Mostly copied from the vfs_gluster manpage: the CephFS share path is not
locally mounted, which breaks the ctdb_check_directories_probe() check.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jul 6 23:19:02 CEST 2018 on sn-devel-144
(cherry picked from commit 0cd44821f3889067620d685344c3eaf913a31329)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b1558f175600c041d4bff7f07df941f42c97e549">b1558f17</a></strong>
<div>
<span>by Oleksandr Natalenko</span>
<i>at 2018-08-13T10:56:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">systemd: Only start smb when network interfaces are up
For smb, if the smb.conf contains explicit bindings to the network
interfaces, the service must wait till network interfaces are up,
otherwise the service won't be operational.
The 0e571054a61e commit and the BZ 13184 have fixed this for nmb and
samba, so do exactly the same here, for smb.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13559
Signed-off-by: Oleksandr Natalenko <oleksandr@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit a3d248f284eb2e5f4fe886310e481b28c9f1c392)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/41302b40301b410ca618c92df67394de51d6b1bc">41302b40</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-13T10:56:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Test SMB1 cli_splice() fallback path when doing a non-full file splice.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13527
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
(cherry picked from commit 1c8d1cceff852acaca4a0ec0da37b053ed03fe4a)
(cherry picked from commit 49d6c3f061284aac31c3ef21f88f9d69bdd86bd8)
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Jul 14 00:14:13 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1a0d1421a3ced92decbe6be6397316ebfe96131b">1a0d1421</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-13T10:56:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:waf: Install eventlogadm to /usr/sbin
The eventlogadm binary needs write access to the registry which, by
default, is only possible as root.
https://bugzilla.samba.org/show_bug.cgi?id=13561
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 0530cccc41f683cb35d065ddcb3968cf4ef759f4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a970d45d1774b5b55bea23488035ca44de0cb7f2">a970d45d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-13T10:56:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmbclient: Fix cli_splice() fallback when reading less than a complete file.
We were always asking for SPLICE_BLOCK_SIZE even when the
remaining bytes we wanted were smaller than that. This works
when using cli_splice() on a complete file, as the cli_read()
terminated the read at the right place. We always have the
space to read SPLICE_BLOCK_SIZE bytes so this isn't an overflow.
Found by Bailey Berro <baileyberro@google.com>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13527
Signed-off-by: Bailey Berro <baileyberro@google.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Fri Jul 13 14:57:14 CEST 2018 on sn-devel-144
(cherry picked from commit c9656fd2977557ab20ec4e3d87c385a9b2f1bf43)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/31e07ebfb688ac62f71f5023be8d14ca93d4191b">31e07ebf</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2018-08-13T10:56:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Shorten description in vfs_linux_xfs_sgid manual
this fixes a lexgrog parse error, the NAME subheader description
of the vfs_linux_xfs_sgid(8) manual was too long, this will shorten
the description and allow it to be correctly detected by mandb.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13562
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 9b105651c754c7c98297a23c0c1e43d7d2e28139)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a734876315bc294da8a0d72988f6de92e99ee6e6">a7348763</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-08-13T10:56:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: run test_durable_v2_open_reopen2_lease() in a subdirectory
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13535
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 725319743f1f2de934cbde477ca84430f5b2b4b4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/25e23c273c4c7c20cc297f04eaab8e9e8cad0bdb">25e23c27</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-08-13T10:56:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: fix path check in smbd_smb2_create_durable_lease_check()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13535
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit e60e9368cb3cb512e2506620d814187a692108e0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a01a98182a5d4eaeddd7b127b8beb5028f7b08b2">a01a9818</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-08-13T10:56:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns wildcards: tests to confirm BUG 13536
DNS wildcard matching failing if more than one label to the left of the
wildcard. This commits adds tests to confirm the bug.
Wildcard entry: *.example.org
bar.example.com matches
foo.bar.example.com does not, but it it should.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 0d3aec18679a2637430263a55de5e210a9201e21)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/357d2b658225825227c5d8ff35704e902c17cf01">357d2b65</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-08-13T10:56:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns wildcards: fix BUG 13536
The current position in the dns name was not advanced past the '.'
character
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jul 20 04:40:31 CEST 2018 on sn-devel-144
(cherry picked from commit cef1b31cd1f33074e8ab6de52aa0fb74e9b57a9f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/37e2ff724ed0c295c80ce0707596e3d0b3e70aa4">37e2ff72</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-13T10:56:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix Linux sendfile() for SMB2. Ensure we don't spin on EAGAIN.
For SMB2 the socket is set non-blocking. Ensure sendfile()
calls complete if they return EAGAIN by saving the socket state,
setting it blocking, doing the sendfile until completion and then
restoring the socket state.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 809967b3eab7a1b48c186517701538ca93536246)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e0c9718b0fd02117e7e22b5d191c9750809c4ce">4e0c9718</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-13T10:56:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix Solaris sendfile() for SMB2. Ensure we don't spin on EAGAIN.
For SMB2 the socket is set non-blocking. Ensure sendfile()
calls complete if they return EAGAIN by saving the socket state,
setting it blocking, doing the sendfile until completion and then
restoring the socket state.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 16a587075c8c62c1160869358ca56a133e90247a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b21e833e83281f58b734296e965c38aa676babdb">b21e833e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-13T10:56:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix HPUX sendfile() for SMB2. Ensure we don't spin on EAGAIN.
For SMB2 the socket is set non-blocking. Ensure sendfile()
calls complete if they return EAGAIN by saving the socket state,
setting it blocking, doing the sendfile until completion and then
restoring the socket state.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit d222caa449d9c00bb2dd9da6c79ea509960d47c6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/91c15b49ced2c25ecc6e162223ae79eea0d3209e">91c15b49</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-13T10:56:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix FreeBSD sendfile() for SMB2. Ensure we don't spin on EAGAIN.
For SMB2 the socket is set non-blocking. Ensure sendfile()
calls complete if they return EAGAIN by saving the socket state,
setting it blocking, doing the sendfile until completion and then
restoring the socket state.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 456e520a3be7e4b54f1f144324c3671b8f6e35ea)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aeb57feb6534819d4311929762795f0dd4a04d3f">aeb57feb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-13T10:56:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix AIX sendfile() for SMB2. Ensure we don't spin on EAGAIN.
For SMB2 the socket is set non-blocking. Ensure sendfile()
calls complete if they return EAGAIN by saving the socket state,
setting it blocking, doing the sendfile until completion and then
restoring the socket state.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Jul 20 15:14:24 CEST 2018 on sn-devel-144
(cherry picked from commit 582ce5d6b599516d6d8d619529a2aa809139a175)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/acacc78678b5a8442a49ac8f5730c5ebb6cb825c">acacc786</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib: Fix misleading typo in debug message
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f4a456a969082d47c3c0d7ff5d881a6e8b883830">f4a456a9</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: Avoid potential smbpanic calling parse_user_quota_list.
Calling parse_user_quota_list with a NULL buffer can cause a panic, while
this shouldn't happen, I managed to trigger this with an early implementation
of SMB2 quota support in smbd which didn't pass back NT_STATUS_NO_MORE_ENTRIES
when handling a SMB2_0_INFO_QUOTA GETINFO message.
OTHOH the Windows client handled the same situation gracefully.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d10a32cf881049e0e949dd5236380b0758ab02da">d10a32cf</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: Don't stat when doing a quota operation (as it's a fake file)
calling SMB_VFS_STAT on the quota fake file fails and caused
FS_INFO/FileFsControlInfo request to error out early, in turn stopped a
Win8.1 client from proceeding with quota queries.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/964626ec57799216f24b54b429071acd75a3e862">964626ec</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc/idl Add some query [getset]info quota related structures
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f1e7ffd833d2ccb4e87cccef88f336e4fe074c13">f1e7ffd8</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: adjust smb1 cli code to use idl structs and ndr push/pull funcs.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/34208d31bfd7150f6330315e3897b02a50fb8ea4">34208d31</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: adjust smb2 code for new idl structs & generated ndr push/pull funcs.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa7fb239243db4d9b49a31d628aa9e705ebe49f8">aa7fb239</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: adjust smb1 server to use idl structs and generated ndr push/pull funcs
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87bf24407ab39941d7a827c982bbc13cd09e9321">87bf2440</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: smb2 server implementation for query get/set info.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6938ec995469a1b577a8781c33308fbf2bd5a669">6938ec99</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/script/test: modify existing smbcquota test to use SMB2 in addition to SMB1.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2162b45bd27b0e2eaf73ffb71e085e61b76a973c">2162b45b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/script/tests: Add simple (smb1 & smb2) get/set/list tests for smbcquotas
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/807611fe3bc9647e82feeb1d2b2d909fa35ad8ef">807611fe</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: allow set quota for non root user (when built with --enable-selftest)
Currently it appears you need to be root to set quotas, for test purposes
this requirement needs to be relaxed.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4b91f85260ef9f505e70f7e119c9760e68213e78">4b91f852</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T10:56:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/utils: fix regression where specifying -Unetbios/root works
Usually you need to be root on a linux server to modify quotas. Even
with a linux server joined to a windows AD you could always log in as
local root with smbcquotas. However in recent builds this has changed.
This patch fixes this
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Tue Jul 31 19:45:59 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e93a716a98ff6e88cffb7167e8dc142c5d299ceb">e93a716a</a></strong>
<div>
<span>by Oleksandr Natalenko</span>
<i>at 2018-08-13T10:56:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">systemd: Only start smb when network interfaces are up
For smb, if the smb.conf contains explicit bindings to the network
interfaces, the service must wait till network interfaces are up,
otherwise the service won't be operational.
The 0e571054a61e commit and the BZ 13184 have fixed this for nmb and
samba, so do exactly the same here, for smb.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13559
Signed-off-by: Oleksandr Natalenko <oleksandr@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit a3d248f284eb2e5f4fe886310e481b28c9f1c392)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77519371fe98404c081a58354ef0664f6be59ca2">77519371</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T13:53:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: Ensure quota code is only called when quota support detected
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13563
Signed-off-by: Noel Power <noel.power@suse.com>
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Mon Aug 13 15:53:27 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f44ef8511490f9ad9f849c09aededf0f0b38dff">6f44ef85</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-13T15:25:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: Ensure quota code is only called when quota support detected
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13563
Signed-off-by: Noel Power <noel.power@suse.com>
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Mon Aug 13 17:25:23 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/47081d9de81339d4e940c4747f6e2d735386e651">47081d9d</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-08-14T10:16:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge tag 'samba-4.8.4' into v4-8-test
samba: tag release samba-4.8.4
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/04c66d8080452f11e8fe142956ea716843823b09">04c66d80</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-08-14T10:19:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.8.5.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3579ac445ab25c319dc520f01b516b103b140c07">3579ac44</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-14T15:42:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1139 libcli/auth: Add initial tests for ntlm_password_check()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13360
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d171f8d1938393982b6645afc095a06a30ef8420">d171f8d1</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-08-14T15:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1139 libcli/auth: fix debug messages in hash_password_check()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13360
CVE-2018-1139: Weak authentication protocol allowed.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/48f5dbd7dbc397c16056e1466998b31ed75b5bad">48f5dbd7</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-08-14T15:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1139 s3-utils: use enum ntlm_auth_level in ntlm_password_check().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13360
CVE-2018-1139: Weak authentication protocol allowed.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e2b2c00626ff677c430d49c0454bc70be5f40d28">e2b2c006</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-08-14T15:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1139 selftest: verify whether ntlmv1 can be used via SMB1 when it is disabled.
Right now, this test will succeed.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13360
CVE-2018-1139: Weak authentication protocol allowed.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3e89172fc75d5b2f5d5ec2b7b7efdf3be5c174eb">3e89172f</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-08-14T15:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1139 libcli/auth: Do not allow ntlmv1 over SMB1 when it is disabled via "ntlm auth".
This fixes a regression that came in via 00db3aba6cf9ebaafdf39ee2f9c7ba5ec2281ea0.
Found by Vivek Das <vdas@redhat.com> (Red Hat QE).
In order to demonstrate simply run:
smbclient //server/share -U user%password -mNT1 -c quit \
--option="client ntlmv2 auth"=no \
--option="client use spnego"=no
against a server that uses "ntlm auth = ntlmv2-only" (our default
setting).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13360
CVE-2018-1139: Weak authentication protocol allowed.
Guenther
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/31a001f2e2f8eadd3e652984e30b7c0cccfe4f1c">31a001f2</a></strong>
<div>
<span>by Andrej Gessel</span>
<i>at 2018-08-14T15:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1140 Add NULL check for ldb_dn_get_casefold() in ltdb_index_dn_attr()
Signed-off-by: Andrej Gessel <Andrej.Gessel@janztec.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13374
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/504cff7aa875df67385fb4fcd4f7f1f461d377b4">504cff7a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-14T15:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1140 ldb: Check for ldb_dn_get_casefold() failure in ldb_sqlite
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13374
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8fed2cc0a96a2ccde675a8f72bb5db31174189e2">8fed2cc0</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-14T15:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1140 ldb_tdb: Ensure the dn in distinguishedName= is valid before use
ldb_dn_from_ldb_val() does not validate this untrusted input, so a later
call to ldb_dn_get_casefold() can fail if the input is not valid.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13374
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dc2898f114dbd7bdff7f29c758819500a6238136">dc2898f1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-14T15:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1140 ldb_tdb: Check for DN validity in add, rename and search
This ensures we fail with a good error code before an eventual ldb_dn_get_casefold() which
would otherwise fail.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13374
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf988acd2e7e79fd6c53954bbcb9472db422c9cb">bf988acd</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-14T15:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1140 ldb: Add tests for search add and rename with a bad dn= DN
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13374
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e2d6ad5147e0bf5869e94eb60c49c385e91eba5d">e2d6ad51</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-14T15:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Release LDB 1.4.2 for CVE-2018-1140
* Security fix for CVE-2018-1140 (NULL pointer de-reference, bug 13374)
* Fix memory leaks and missing error checks (bug 13459, 13471, 13475)
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/164766b8800c59a3f981aeb3ea1b3ab4e2e31a54">164766b8</a></strong>
<div>
<span>by Kai Blin</span>
<i>at 2018-08-14T15:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1140 dns: Add a test to trigger the LDB casefolding issue on invalid chars
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13466
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5bcbf5a308cb5e516b257bf1769728d22e9b6f36">5bcbf5a3</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T15:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 security: Move object-specific access checks into separate function
Object-specific access checks refer to a specific section of the
MS-ADTS, and the code closely matches the spec. We need to extend this
logic to properly handle the Control-Access Right (CR), so it makes
sense to split the logic out into its own function.
This patch just moves the code, and should not alter the logic (apart
from ading in the boolean grant_access return variable.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/17b7206a6d1399185a3b1d90aba5f2e26a9e7236">17b7206a</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T15:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 security: Add more comments to the object-specific access checks
Reading the spec and then reading the code makes sense, but we could
comment the code more so it makes sense on its own.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/10a2c8da54adc85a9d567e8b805a2cce16893d9e">10a2c8da</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T15:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 tests: Add tests for guessing confidential attributes
Adds tests that assert that a confidential attribute cannot be guessed
by an unprivileged user through wildcard DB searches.
The tests basically consist of a set of DB searches/assertions that
get run for:
- basic searches against a confidential attribute
- confidential attributes that get overridden by giving access to the
user via an ACE (run against a variety of ACEs)
- protecting a non-confidential attribute via an ACL that denies read-
access (run against a variety of ACEs)
- querying confidential attributes via the dirsync controls
These tests all pass when run against a Windows Dc and all fail against
a Samba DC.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e2574d092dc91ee1ba7ee04938c63b3ee811c5af">e2574d09</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T15:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 tests: Add test case for object visibility with limited rights
Currently Samba is a bit disclosive with LDB_OP_PRESENT (i.e.
attribute=*) searches compared to Windows.
All the acl.py tests are based on objectClass=* searches, where Windows
will happily tell a user about objects they have List Contents rights,
but not Read Property rights for. However, if you change the attribute
being searched for, suddenly the objects are no longer visible on
Windows (whereas they are on Samba).
This is a problem, because Samba can tell you about which objects have
confidential attributes, which in itself could be disclosive.
This patch adds a acl.py test-case that highlights this behaviour. The
test passes against Windows but fails against Samba.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c9f50b362f28869e374378baa8362218de11a48">9c9f50b3</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-08-14T15:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 tests: test ldap searches for non-existent attributes.
It is perfectly legal to search LDAP for an attribute that is not part
of the schema. That part of the query should simply not match.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/605a7f3b3c03e2f1efb49f5dea400a38a03339f9">605a7f3b</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T15:42:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 security: Fix checking of object-specific CONTROL_ACCESS rights
An 'Object Access Allowed' ACE that assigned 'Control Access' (CR)
rights to a specific attribute would not actually grant access.
What was happening was the remaining_access mask for the object_tree
nodes would be Read Property (RP) + Control Access (CR). The ACE mapped
to the schemaIDGUID for a given attribute, which would end up being a
child node in the tree. So the CR bit was cleared for a child node, but
not the rest of the tree. We would then check the user had the RP access
right, which it did. However, the RP right was cleared for another node
in the tree, which still had the CR bit set in its remaining_access
bitmap, so Samba would not grant access.
Generally, the remaining_access only ever has one bit set, which means
this isn't a problem normally. However, in the Control Access case there
are 2 separate bits being checked, i.e. RP + CR.
One option to fix this problem would be to clear the remaining_access
for the tree instead of just the node. However, the Windows spec is
actually pretty clear on this: if the ACE has a CR right present, then
you can stop any further access checks.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/03950558a4566c4044e374d37f2b8f5a80005bf6">03950558</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T15:42:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 acl_read: Split access_mask logic out into helper function
So we can re-use the same logic laster for checking the search-ops.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c201d0a09a082f47ddfdcb021ac4d82a9a3dc77">4c201d0a</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T15:42:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 acl_read: Small refactor to aclread_callback()
Flip the dirsync check (to avoid a double negative), and use a helper
boolean variable.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a5cd47d85c77a095ec99412dd6538929b7c39248">a5cd47d8</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T15:42:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 acl_read: Flip the logic in the dirsync check
This better reflects the special case we're making for dirsync, and gets
rid of a 'if-else' clause.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/52b5ed820c874eadadb88fd0db2103718cb8ebc0">52b5ed82</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T15:42:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 acl_read: Fix unauthorized attribute access via searches
A user that doesn't have access to view an attribute can still guess the
attribute's value via repeated LDAP searches. This affects confidential
attributes, as well as ACLs applied to an object/attribute to deny
access.
Currently the code will hide objects if the attribute filter contains an
attribute they are not authorized to see. However, the code still
returns objects as results if confidential attribute is in the search
expression itself, but not in the attribute filter.
To fix this problem we have to check the access rights on the attributes
in the search-tree, as well as the attributes returned in the message.
Points of note:
- I've preserved the existing dirsync logic (the dirsync module code
suppresses the result as long as the replPropertyMetaData attribute is
removed). However, there doesn't appear to be any test that highlights
that this functionality is required for dirsync.
- To avoid this fix breaking the acl.py tests, we need to still permit
searches like 'objectClass=*', even though we don't have Read Property
access rights for the objectClass attribute. The logic that Windows
uses does not appear to be clearly documented, so I've made a best
guess that seems to mirror Windows behaviour.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4897bf3de3a9ad467658f2af26a3b6eb489509fc">4897bf3d</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T15:42:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 tests: Add extra test for dirsync deleted object corner-case
The acl_read.c code contains a special case to allow dirsync to
work-around having insufficient access rights. We had a concern that
the dirsync module could leak sensitive information for deleted objects.
This patch adds a test-case to prove whether or not this is happening.
The new test case is similar to the existing dirsync test except:
- We make the confidential attribute also preserve-on-delete, so it
hangs around for deleted objcts. Because the attributes now persist
across test case runs, I've used a different attribute to normal.
(Technically, the dirsync search expressions are now specific enough
that the regular attribute could be used, but it would make things
quite fragile if someone tried to add a new test case).
- To handle searching for deleted objects, the search expressions are
now more complicated. Currently dirsync adds an extra-filter to the
'!' searches to exclude deleted objects, i.e. samaccountname matches
the test-objects AND the object is not deleted. We now extend this to
include deleted objects with lastKnownParent equal to the test OU.
The search expression matches either case so that we can use the same
expression throughout the test (regardless of whether the object is
deleted yet or not).
This test proves that the dirsync corner-case does not actually leak
sensitive information on Samba. This is due to a bug in the dirsync
code - when the buggy line is removed, this new test promptly fails.
Test also passes against Windows.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/61e34a2002e069527011e254434e044d2e12cda4">61e34a20</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-14T15:42:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Ensure smbc_urlencode() can't overwrite passed in buffer.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13453
CVE-2018-10858: Insufficient input validation on client directory
listing in libsmbclient.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a2880b670b261ca9fbc70b4665aa86ee2a2c07a">4a2880b6</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-14T15:42:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Harden smbc_readdir_internal() against returns from malicious servers.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13453
CVE-2018-10858: Insufficient input validation on client directory
listing in libsmbclient.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ed470b1ad90174166ab561ab95751ffc6e240d9">7ed470b1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-14T15:42:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">cracknames: Fix DoS (NULL pointer de-ref) when not servicePrincipalName is set on a user
This regression was introduced in Samba 4.7 by bug 12842 and in
master git commit eb2e77970e41c1cb62c041877565e939c78ff52d.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13552
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/81b0d5cda82eb5ef284bd9083fa4f9e83e188e5a">81b0d5cd</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2018-08-14T15:42:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: Explicitly set delete_on_close token for rmdir
The current implementation of `rmdir` hopes to get the directory deleted
on closing last open handle when FILE_DELETE_ON_CLOSE is set on it. But
for non-empty directories Windows doesn't error out during an open call.
Following that we internally refuse to set initial delete_on_close while
opening a non-empty directory. This prevents us from trying to delete
the directory when last open handle is closed.
Instead of relying on FILE_DELETE_ON_CLOSE during an open we explicitly
set delete_on_close token on directory handle once it is available. This
ensures that NT_STATUS_DIRECTORY_NOT_EMPTY is returned for `rmdir` on
non-empty directories while closing open directory handle.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13204
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 6b68e3eca631c04d6d57c489daf60f64732fc86d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/921a5bbd3c70ab16ad47fda94f054e113f49bc7c">921a5bbd</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2018-08-14T15:42:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture: Add new test for DELETE_ON_CLOSE on non-empty directories
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13204
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 6a7f11746c9cc3cdc5307e540bdd1f3f10fed05b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b09fdd039b6608c9c8de877e6ce1300b8cae55f3">b09fdd03</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-14T15:42:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: tests: smbclient. Regression test to ensure we get NT_STATUS_DIRECTORY_NOT_EMPTY on rmdir.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13204
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Aug 10 21:08:14 CEST 2018 on sn-devel-144
(cherry picked from commit bca400847f2fcc3dd1398e166c1964cb88822071)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/609109ddfbea8cccd058f7bfed525ae7ea4cb155">609109dd</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-08-14T15:42:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/build: link ctdb_mutex_ceph_rados_helper against ceph-common
ceph-common linkage is needed with new versions of Ceph.
Also respect the --libcephfs_dir=<path> parameter when provided.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit bd64af6b8861f892e6ae2840a493f037d1e0a06c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eae828b3dd75c8fb699a0da4cc3c15808775afdd">eae828b3</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-08-14T15:42:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb_mutex_ceph_rados_helper: Set SIGINT signal handler
Set a handler for SIGINT to release the lock.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 85706bd27535eaa4ec653f99b1910fbd8f2aab88)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5f3548bc33f5044b91217b1bcdc674029d2e3ecb">5f3548bc</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-08-14T15:42:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb_mutex_ceph_rados_helper: use talloc destructor for cleanup
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 8d30fd591600ac17c742cd78c7bc4056bba6b877)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2849d5778561b70bb01c03f1978c5f4e8ba419d6">2849d577</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-08-14T15:42:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb_mutex_ceph_rados_helper: rename timer_ev to ppid_timer_ev
In preparation for adding a lock refresh timer.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 91a89c146453ca203a83dc2ba555bb93276c4d7f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/37b4e0bcebfa9741b2862f09d20e363eaad611db">37b4e0bc</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-08-14T15:42:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb_mutex_ceph_rados_helper: fix deadlock via lock renewals
RADOS locks without expiry persist indefinitely. This results in CTDB
deadlock during failover if the recovery master dies unexpectedly, as
subsequently elected recovery master nodes can't obtain the recovery
lock.
Avoid deadlock by using a lock expiration time (10s by default), and
renewing it periodically.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13540
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit ce289e89e5c469cf2c5626dc7f2666b945dba3bd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2d5c574f459769ea11d1f26b2b2c5f45ce5f6bd7">2d5c574f</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-08-14T15:42:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: add expiry test for ctdb_mutex_ceph_rados_helper
Kill the ctdb_mutex_ceph_rados_helper with SIGKILL and then confirm
that the lock is automatically released following expiry.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Thu Aug 9 16:26:36 CEST 2018 on sn-devel-144
(cherry picked from commit 4abf348ec4cbb78d3216d5e8c5f3020d4499f10a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e30cf1a253ddde90d3d305799f544312872ae03f">e30cf1a2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-14T15:42:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Align integer types
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0eaef7eeb0f7eef67ce80955deafc9da23bf153e">0eaef7ee</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-14T15:42:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix CID 1438246 Unchecked return value
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/33c7d3ceff929a55a27b28d0ce5a31e7ef8b89e7">33c7d3ce</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-14T15:42:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix CID 1438245 Dereference before null check
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/601eb6bc3fa5b44841bdbc31f31c42f21feb0982">601eb6bc</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-14T15:42:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Fix CID 1438244 Unsigned compared against 0
ndr_size_dom_sid returns a size_t, so that can't be <0. Also, the only
case that ndr_size_dom_sid returns 0 is a NULL sid
pointer. ndr_size_dom_sid can reasonably be assumed to not overflow, the
number of sub-auths is a uint8. That times 4 plus 8 always fits into a
size_t.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf3bb82d8a7e31950f01a3508787a8e6951ea9a4">bf3bb82d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-14T18:49:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Fix CID 1438243 Unchecked return value
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Aug 8 23:10:22 CEST 2018 on sn-devel-144
Autobuild-User(v4-9-test): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(v4-9-test): Tue Aug 14 20:49:09 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd609d77cf101d98409c002f0a56b8acc064e427">dd609d77</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-08-15T01:50:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Changelog for previous commits
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ce9eaf978eb9500aaed72f668b51eeb942ec4f16">ce9eaf97</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-08-15T02:09:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">New upstream version 4.8.4+dfsg</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/031cbc5b55af116cc3c1890f670838d18a817c27">031cbc5b</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-08-15T02:16:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge tag 'upstream/4.8.4+dfsg'
Upstream version 4.8.4+dfsg
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f1fdf95e908f75a6746062471f03e63b69afae4">6f1fdf95</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-08-15T09:40:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.9.0rc3.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba2ef7fab48ecaa3cc77af77c2b815075c078dd7">ba2ef7fa</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-08-15T09:42:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERISON: Disable GIT_SNAPSHOT for 4.9.0rc3 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6244e6ab6b5dfc8ab47420e47fab5d8cff053516">6244e6ab</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-08-15T09:43:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.9.0rc4...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5dc3c24f44e81b1256ab9d90dac0de3dea6938cf">5dc3c24f</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-08-16T21:11:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Bump ldb Build-depends to 2:1.4.0+really1.3.5
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f981954911292034c5ed078b0b999a58299872e1">f9819549</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-08-17T14:29:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Standards-Version: 4.2.0
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/25a59f4e94d0a8e7b19eafbcd7a5c564b51fa861">25a59f4e</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-08-17T14:29:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Set Rules-Requires-Root: binary-targets as chmod is used
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c00ec4d1d67c6d1e509f9287f028041c3ac5cef7">c00ec4d1</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-08-17T14:29:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Remove override_dh_strip target as dbgsym migration is complete
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/47ad83c01ded7b9530524935786d0c2c8ac9f0a6">47ad83c0</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-08-17T14:31:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Release 2:4.8.4+dfsg-1
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f5705fadffda539b1ab9e4dc9000e0362e82d3a0">f5705fad</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-08-17T23:47:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix typo in previous release: s/usefull/useful/
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f262fc54c9e3bf6fe52ca9da5ee6e04c954d1d7d">f262fc54</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-08-19T08:07:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Prepend 1.4.0+really to ldb version to allow samba-dsdb-modules install (Closes: #906562, #906568)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7c183619f7e2d2b3fb280da605ea944874791fa2">7c183619</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-08-19T08:09:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Release 2:4.8.4+dfsg-2
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8bf5c11c892e1f8c1d77fe2efa2acf49c60b1241">8bf5c11c</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2018-08-23T08:38:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: Explicitly set delete_on_close token for rmdir
The current implementation of `rmdir` hopes to get the directory deleted
on closing last open handle when FILE_DELETE_ON_CLOSE is set on it. But
for non-empty directories Windows doesn't error out during an open call.
Following that we internally refuse to set initial delete_on_close while
opening a non-empty directory. This prevents us from trying to delete
the directory when last open handle is closed.
Instead of relying on FILE_DELETE_ON_CLOSE during an open we explicitly
set delete_on_close token on directory handle once it is available. This
ensures that NT_STATUS_DIRECTORY_NOT_EMPTY is returned for `rmdir` on
non-empty directories while closing open directory handle.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13204
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 6b68e3eca631c04d6d57c489daf60f64732fc86d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/694c8908b0c595ee4550b05ab6c6c1f51b9e45cf">694c8908</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2018-08-23T08:38:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture: Add new test for DELETE_ON_CLOSE on non-empty directories
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13204
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 6a7f11746c9cc3cdc5307e540bdd1f3f10fed05b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9e3bc4e5a68adb2fe527680d6f7e5522bd87087f">9e3bc4e5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-23T08:38:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: tests: smbclient. Regression test to ensure we get NT_STATUS_DIRECTORY_NOT_EMPTY on rmdir.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13204
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Aug 10 21:08:14 CEST 2018 on sn-devel-144
(cherry picked from commit bca400847f2fcc3dd1398e166c1964cb88822071)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f9f1102bb2b8b21b8efa16c7b024855687079005">f9f1102b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-23T08:38:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_plugin: Install plugins to krb5 modules dir
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13489
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit eba2eb8a15c7a25b1436907a5339241492c81097)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/756feb9069d35e8cd27b7b4f8b1c9eb079d11bb4">756feb90</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-23T08:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_plugin: Move krb5 locator plugin to krb5_plugin subdir
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13489
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 4a7e0f259bb7f1ebce48523767262addda08fe14)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e9e85a183c7b4602e89f741bba9e4ed8c63974d4">e9e85a18</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-23T08:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Move winbind_krb5_locator manpage to volume 8
The vfs and idmap manpages are in volume 8 too.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13489
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 6b7fcec01524ea1c4f2d923cc9cc2c17af3c3a21)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0a49817dd4216978dc34f7a381a2c35b01cc77f9">0a49817d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-23T08:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Add manpage for winbind_krb5_localauth.8
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13489
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Jun 27 18:45:56 CEST 2018 on sn-devel-144
(cherry picked from commit e88d68c253b4398eaed701d1a9bcc1b83882e127)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/30c37fcacc212c9eb38746727a85e250d9448769">30c37fca</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-08-23T08:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/build: link ctdb_mutex_ceph_rados_helper against ceph-common
ceph-common linkage is needed with new versions of Ceph.
Also respect the --libcephfs_dir=<path> parameter when provided.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit bd64af6b8861f892e6ae2840a493f037d1e0a06c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6dc7dc9300014485ec5e6e1e9bfb8eb2d89c4033">6dc7dc93</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-08-23T08:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb_mutex_ceph_rados_helper: Set SIGINT signal handler
Set a handler for SIGINT to release the lock.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 85706bd27535eaa4ec653f99b1910fbd8f2aab88)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/af08da45716f713ed1897a23d814cb679f3f24bf">af08da45</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-08-23T08:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb_mutex_ceph_rados_helper: use talloc destructor for cleanup
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 8d30fd591600ac17c742cd78c7bc4056bba6b877)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c245fdce393c9c11b52576335802a5fdceeeaf96">c245fdce</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-08-23T08:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb_mutex_ceph_rados_helper: rename timer_ev to ppid_timer_ev
In preparation for adding a lock refresh timer.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 91a89c146453ca203a83dc2ba555bb93276c4d7f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7cebb4897550e2dd8109c4dcc5c9f885dcbefb83">7cebb489</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-08-23T08:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb_mutex_ceph_rados_helper: fix deadlock via lock renewals
RADOS locks without expiry persist indefinitely. This results in CTDB
deadlock during failover if the recovery master dies unexpectedly, as
subsequently elected recovery master nodes can't obtain the recovery
lock.
Avoid deadlock by using a lock expiration time (10s by default), and
renewing it periodically.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13540
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit ce289e89e5c469cf2c5626dc7f2666b945dba3bd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c57c54eb52d6611e67559aec5df5539c0fd2a300">c57c54eb</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-08-23T08:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: add expiry test for ctdb_mutex_ceph_rados_helper
Kill the ctdb_mutex_ceph_rados_helper with SIGKILL and then confirm
that the lock is automatically released following expiry.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Thu Aug 9 16:26:36 CEST 2018 on sn-devel-144
(cherry picked from commit 4abf348ec4cbb78d3216d5e8c5f3020d4499f10a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c45fb4b658890f03a045519f95df160f27f96183">c45fb4b6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-23T08:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Align integer types
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2e285845ea03c5505092b8de5f6097e5845b25ec">2e285845</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-23T08:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix CID 1438246 Unchecked return value
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d4e8fd5fd246a80e1a13a2bf3965d0335d4dc2c4">d4e8fd5f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-23T08:38:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix CID 1438245 Dereference before null check
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b1b882c2c459b206e2455f53b3926ff9a13f7335">b1b882c2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-23T08:38:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Fix CID 1438244 Unsigned compared against 0
ndr_size_dom_sid returns a size_t, so that can't be <0. Also, the only
case that ndr_size_dom_sid returns 0 is a NULL sid
pointer. ndr_size_dom_sid can reasonably be assumed to not overflow, the
number of sub-auths is a uint8. That times 4 plus 8 always fits into a
size_t.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0eaf84a4f5c313776c6feab2968f241b5ce55a91">0eaf84a4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-23T08:38:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Fix CID 1438243 Unchecked return value
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Aug 8 23:10:22 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e35fd2687e802d6961118f30670d7f8584337193">e35fd268</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-23T08:38:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Fix missing NULL terminator in ldb_mod_op_test testsuite
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13575
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
(cherry picked from commit f8b368c9f0c2a34b6d15303a9d6facd762e1a517)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b37dea927f4bfc98919282215004def7891687b">6b37dea9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-23T08:38:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Release LDB 1.3.6
* make test fails on ldb 1.3.4 due to missing NULL terminator in tests (bug 13575)
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fd137bc1073c4d3110c356e6778c73f5cda884aa">fd137bc1</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-08-23T08:38:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">unittests.lib_util_modules: test module probe with "skel", not "unix"
The unix module is not available as a module on some systems.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit cb5f1f3b262467faba59b3b323e240d1351d5fc0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/84b786553799c494c77aefc03f44f4e10afb35d0">84b78655</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-08-23T08:38:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: subunithelper needs to follow the subunit spec more closely
In particular allow ]\n without \n]\n as used by cmocka
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 7d79575de8e47a0ce03e30c3ea84176be696269f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/06cf8c46842a877d3098aaa4ab4d4014d8ceecee">06cf8c46</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2018-08-23T08:38:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs: time_audit: fix handling of token_blob in smb_time_audit_offload_read_recv()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13568
Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 4909b966050c921b0a6a32285fee55f5f14dc3ff)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/03e73ff65f110ba58250e84c4a3f23efe224653e">03e73ff6</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-08-23T08:38:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Load time_audit and full_audit modules for all tests
Previously the only test was to load these modules to trigger the
smb_vfs_assert_all_fns check. As these modules just pass through the
calls, they can be loaded for all tests to ensure that the codepaths are
exercised. This would have found the problem in
smb_time_audit_offload_read_recv.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13568
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Aug 13 22:35:20 CEST 2018 on sn-devel-144
(cherry picked from commit a98f09a09db2fc7be85f9171b586e65344a39e92)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3cc8f9d7c7a65a6cf62ac9075803a962ee777d72">3cc8f9d7</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-23T08:38:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Do not lookup local system accounts in AD
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13503
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 9f28d30633af721efec02d8816a9fa48f795a01c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1c0be1fc41e9f8c3e36e94e470140b178083227b">1c0be1fc</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-23T08:38:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: Fix a leak of "br_lck"
Fix a panic if fruit_access_check detects a locking conflict.
do_lock() returns a valid br_lck even in case of a locking conflict.
Not free'ing it leads to a invalid lock order panic later, because
"br_lck" corresponds to a dbwrap lock on brlock.tdb.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13584
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 51d57073798f76ec4f1261945e0ba779b2530009)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ec475511389aca66549ee403880408a8230ae31f">ec475511</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-23T08:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Improve domain backup targetdir checks
+ Added check that specified targetdir is actually a directory (if it
exists)
+ Deleted a redundant 'Creating targetdir' check that would never be hit
+ Move code into a separate function so we can reuse it for offline
backups (which take a different set of parameters, but still have a
targetdir)
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
(cherry picked from commit 4f532cc177cd1e95d8ccf8e69f50b315354df34c)
Backported to v4.9 for:
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13566
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/69583d1d32e01472b52543a730af63a99ef9c3f6">69583d1d</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-23T08:39:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: domain backup didn't support prompting for password
The online/rename backups only worked if you specified both the username
and password in the actual command itself. If you just entered the
username (expecting to be prompted for the password later), then the
command was rejected.
The problem was the order the code was doing things in. We were checking
credopts.creds.get_password() *before* we'd called
credopts.get_credentials(lp), whereas it should be the other way
around.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13566
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit 14077b6682d7dc1b16e1ccb42ef61e9f4c0a1715)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/15e1a41130281ff32e727e2aafef37cfc7816e5a">15e1a411</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-23T08:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Fix kerberos option for domain backups
The previous fix still didn't work if you specified --kerberos=yes (in
which case the creds still doesn't have a password).
credopts.get_credentials(lp) should be enough to ensure a user/password
is set (it's all that the other commands seem to do).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13566
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit 8fb706c34682bf6dc6033963518c7eccffc3944f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b9315fa19eb6d422b12258aef65cfecd7806d517">b9315fa1</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-23T08:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Delete unnecessary function
Minor code cleanup. The last 2 patches gutted this function, to the
point where there's no longer any value in keeping it.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13566
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit d2d039515119523192676b311d5997afd34f4c90)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/12a8f206b8e7a6cd61bf8e89f170e77c845b1afb">12a8f206</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-23T08:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Fix --kerberos=yes and --no-secrets domain backups
The --kerberos=yes and --no-secrets options didn't work in combination
for domain backups. The problem was creds.get_username() might not
necessarily match the kerberos user (such as in the selftest
environment). If this was the case, then trying to reset the admin
password failed (because the creds.get_username() didn't exist in
the DB).
Because the admin user always has a fixed RID, we can work out the
administrator based on its object SID, instead of relying on the
username in the creds.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13566
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Aug 15 10:19:09 CEST 2018 on sn-devel-144
(cherry picked from commit f249bea1e0538300288e7cf1dcb6037c45f92276)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2431f54365a85581b6829f8d589b17f183b47cc0">2431f543</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-23T08:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wbinfo: Free memory when we leave wbinfo_dsgetdcname()
Found by covscan.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567
Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit e6689c3e14c2dfaebaf1109f21e53184fea45d41)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1000cbe1c7acf8e018ff1ed7a150532a7ba2ee83">1000cbe1</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-23T08:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:passdb: Don't leak memory on error in fetch_ldap_pw()
Found by covscan.
A candidate to use tallac ...
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567
Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit e4f4f5eb7303a0cce4f426dd9cfd1d6a488495b0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cdb6f015d4341b86965f20fca0fde78a55e0a28e">cdb6f015</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-23T08:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Do not overflow the destination buffer in net_idmap_restore()
Found by covsan.
error[invalidScanfFormatWidth]: Width 128 given in format string (no. 2)
is larger than destination buffer 'sid_string[128]', use %127s to
prevent overflowing it.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567
Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit f20150fb1ea5292f099862af6268d06844954d5e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6ffa700070be7dfbbca2022823b62790fd7f11ad">6ffa7000</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-23T08:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Do not leak memory in new_user()
Found by covscan.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567
Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit b7b4fc51d0eadbbc94576dda75ae80098a205a24)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/98e7021744e1b22c49b40613058d22ab7bfe02d2">98e70217</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-23T08:39:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:lib: Fix a possible fd leak in gp_get_file()
Found by covscan.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567
Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit d4fb124adfc10de8b7eb1f72b74d7ca83f8415dd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f1c2e6829a1abc2ebeb47b0a800c6928a344fd1a">f1c2e682</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-23T08:39:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:client: Avoid a possible fd leak in do_get()
Found by covscan.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567
Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 3d32c0263b072e19335eba1451840284409ecb61)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8f6557885ab9fbc7096d8bb2fc9138afe76e0a2f">8f655788</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-23T08:39:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Fix memory leaks in ads_krb5_chg_password()
Found by covscan.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567
Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit dbdbd4875ecac3e7334750f46f1f494b7afe6628)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bd0b693723810f6f37de536e7169d9d1e8738653">bd0b6937</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-23T08:39:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:registry: Fix possible memory leak in _reg_perfcount_multi_sz_from_tdb()
Found by covscan.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567
Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Aug 11 04:43:15 CEST 2018 on sn-devel-144
(cherry picked from commit 3e6ce5c6e679fdb39ed8142bf5e1ed4105164826)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/14eed16e3d972b6897321c86752851195c438536">14eed16e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-23T08:39:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Fix memory leak in nss_init()
Found by covscan.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567
Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 4c0b49b3f982a3a3013a3b6fef3c10b1ca7d2ab0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/96a74abefaa95c75e5669148b26fedd0736061ea">96a74abe</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-23T08:39:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Free addr before we free the context
Introduced by dbdbd4875ecac3e7334750f46f1f494b7afe6628
CID 1438395
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Aug 14 22:02:06 CEST 2018 on sn-devel-144
(cherry picked from commit 9eccf6a16f5b198181a4fa80b835b1a65b40ed76)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b0e1a034b4ab1ebb5f7272215d5ff771e87a18a5">b0e1a034</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2018-08-23T08:39:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs: time_audit: fix handling of token_blob in smb_time_audit_offload_read_recv()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13568
Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 4909b966050c921b0a6a32285fee55f5f14dc3ff)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a89ec4ea2cd8838634570b1cdd32e28142032dd7">a89ec4ea</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-08-23T08:39:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Load time_audit and full_audit modules for all tests
Previously the only test was to load these modules to trigger the
smb_vfs_assert_all_fns check. As these modules just pass through the
calls, they can be loaded for all tests to ensure that the codepaths are
exercised. This would have found the problem in
smb_time_audit_offload_read_recv.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13568
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Aug 13 22:35:20 CEST 2018 on sn-devel-144
(cherry picked from commit a98f09a09db2fc7be85f9171b586e65344a39e92)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ccbc9c1973b47fc66d6d7e8f117cdf3d66e60e3d">ccbc9c19</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-08-23T08:39:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba/samba_abi: always hide ABI symbols which must be local
binutils 2.31 is going to change how shared libraries are linked, such
that they always provide their own local definitions of the _end, _edata
and _bss_start symbols. This would all be fine, except for shared
libraries that export all symbols be default. (Rather than just
exporting those symbols that form part of their API).
According to binutils developers, we should only export the symbols we
explicitly want to be used. We don't use this principle for all our
libraries and deliberately don't want to have ABI versioning control for
all of them, so the change I introduce here is to explicitly mark those
symbols that will always be added by default linker configuration with
binutils 2.31 as local. Right now these are '_end', '_edata', and
'__bss_start' symbols.
Fixes: https://bugzilla.samba.org/show_bug.cgi?id=13579
Cherry-picked from commit 4e123c46820e737968fa3d1c594aa016cca39637
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/018550f1c116b46a401c24e29f0467b32107ed20">018550f1</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-23T08:39:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Fix print in dns_invalid.py
https://bugzilla.samba.org/show_bug.cgi?id=13580
Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Sat Aug 18 15:21:39 CEST 2018 on sn-devel-144
(cherry picked from commit 9ee4d9466e42ef419ddbb39efbc476532cd221d3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2f9324688821a02f32c94a01f58c995465a9aa1c">2f932468</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-23T08:39:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: Fix a leak of "br_lck"
Fix a panic if fruit_access_check detects a locking conflict.
do_lock() returns a valid br_lck even in case of a locking conflict.
Not free'ing it leads to a invalid lock order panic later, because
"br_lck" corresponds to a dbwrap lock on brlock.tdb.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13584
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 51d57073798f76ec4f1261945e0ba779b2530009)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/729ac56bb4175698c79945c9f0c3711a6ff8886d">729ac56b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-23T12:28:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Demonstrate the invalid lock order panic
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13584
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Aug 21 02:33:05 CEST 2018 on sn-devel-144
(cherry picked from commit ec3c37ee53f21d8c0e80b1d3b3d7e95a4ac8e0bc)
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Thu Aug 23 14:28:49 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2ce60d72a5887656cfc1beffcff60b35ab6ce8af">2ce60d72</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-23T13:39:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Demonstrate the invalid lock order panic
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13584
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Aug 21 02:33:05 CEST 2018 on sn-devel-144
(cherry picked from commit ec3c37ee53f21d8c0e80b1d3b3d7e95a4ac8e0bc)
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Thu Aug 23 15:39:45 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/020b14acf07709a9f678c8c7949ea61f149e1511">020b14ac</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-08-24T07:53:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.8.5.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9fc7ccfb33d6bc326be32acfc40fda66b85d3a09">9fc7ccfb</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-08-24T07:54:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.8.5 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d207d4798a7760fc3347b311ae4a69dc3e6e90cc">d207d479</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-08-27T12:35:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">New upstream version 4.8.5+dfsg</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1084035e7cc4fec60a0494ea23275cdc5323893b">1084035e</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-08-27T12:41:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge tag 'upstream/4.8.5+dfsg'
Upstream version 4.8.5+dfsg
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/950b95a12297ed36ee33612ecb84825b753dc0c1">950b95a1</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-08-27T12:44:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Bump ldb Build-depends to 2:1.4.0+really1.3.6
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b5c8c3431c1719a3bdd1d4cfa775c9dcdbf95fea">b5c8c343</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-08-27T13:04:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Standards-Version: 4.2.1
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3fd839aeba4ab5fe70837c16ff5320c0e1d132fa">3fd839ae</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-28T08:59:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Ensure get_real_filename() copes with empty pathnames.
Needed for vfs_glusterfs, as Gluster requires "." not '\0'.
Based on a fix from Anoop C S <anoopcs@redhat.com>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13585
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Aug 22 21:50:41 CEST 2018 on sn-devel-144
(cherry picked from commit 9c71f61ed8a31d287d343d4f2e68cb40c57a2b89)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7e38e9503a28c6bf6314f84b28d89a15d23e524d">7e38e950</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-28T08:59:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Fix aliasing issue in IPv6 checksum
Since commit 9c51b278b1700cd5f3e2addc19b7c711cc2ea10b the compiler has
been able to inline the affected call to uint16_checksum(). Given
that the data (phdr) is being accessed by an incompatible
pointer (data) there is an aliasing problem when the call is inlined.
This results in incorrect behaviour with -O2/-O3 when compiling with
at least GCC 6, 7, and 8.
Fix this by making the types compatible.
Also fixes CID 1437604 (Reliance on integer endianness). This is a
false positive because the uint16_checksum doesn't depend on the order
of the input uint16_t items.
https://bugzilla.samba.org/show_bug.cgi?id=13588
Pair-programmed-with: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 48335725deecdbdb24a9176cf31e9611c9deda49)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/97048c0c856911b897679030afd757e2c14a5b46">97048c0c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-28T08:59:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-doc: Make config migration script notice removed CTDB_BASE option
This should never have been a user-level option, but some people used
it.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit d4afb60a24b932a0b7a0c2f27526f41d0bf38fc2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/34b4bdcf81c35be999c7f469f605b0c7cf76444c">34b4bdcf</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-28T08:59:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-doc: Handle boolean options in config migration more carefully
Values for ctdb.conf options are now returned by
get_ctdb_conf_option(). The main goal is to allow old boolean options
to be replaced by new logically negated options.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 64d4a7ae5ac3aed2b1b9e7ab85c372e6900826ac)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d51434b59e0fca75c51338178df47279cca93a4c">d51434b5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-28T08:59:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-config: Change option "no realtime" option to "realtime scheduling"
Negative options can be confusing, so switch to a positive option.
This was supposed to be done months ago but was forgotten.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 17068e756b9e46f7a6c77d533ef1777173bb3795)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/73c884c5daf0ad6a715d4e3f1849efe05973eace">73c884c5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-28T08:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-doc: Change option "no realtime" option to "realtime scheduling"
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 43adcd717cee689c2d0386bd2aa2878006aa9217)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5f346ce08db333d35b5dc18725fe976eb5cac8c7">5f346ce0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-28T08:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-doc: Add support for migrating tunables to ctdb.conf options
This will become common, so will be useful to have support for.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 8ddfc26d79fda2fd0265f370a4c08dc584e6a6ac)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/75261d6a6d324f5424df7810268b633531b7e72d">75261d6a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-28T08:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-config: Switch tunable TDBMutexEnabled to a config option
Use the "database:tdb mutexes" option instead.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit f42486e8912eee45eb75d27b753bb74c3b37d80b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/55674458d245314b458e30449972ec3821ddd1d1">55674458</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-28T08:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-doc: Switch tunable TDBMutexEnabled to a config option
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit a9758f413d06b0d114f4e5a0e053bbc8956c60b7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/624b4d15577daf68976cf3674699a948da969ea8">624b4d15</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-28T08:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Allow boolean configuration values to have yes/no values
This make the new configuration style more consistent with the old one.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 21de59ab7fe53240380b9a9a5b32d5af32d34237)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/089d3b900f22265ba31041b07902f95021b4faf1">089d3b90</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-28T08:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Pass DisableIPFailover tunable via environment variable
Preparation for obsoleting this tunable.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 914e9f22d85b9274871b7c7d5486354928080e51)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a30fb0a1a5ed28ca9c864ff34310537cd5d879e">4a30fb0a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-28T08:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop DisableIPFailover simple test
This is about to become a config file option that can't be dynamically
changed at run-time, so drop this test for now. This test will be added
once the tunable becomes a config file option.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 8e160d331aaccd64b1a767c0bde9e310c80afe06)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f518865e97722737b988e6e56ac72a04cdcd7464">f518865e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-28T08:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-failover: Add failover configuration options
Only a "disabled" option for now. Not documented because it isn't
used yet.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 893dd623dfdec4d5c5da07f933069e4534fe58ae)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/83b79f5bfb5af906f23ca81e13e4d3682e6a3a58">83b79f5b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-28T08:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-config: Integrate failover options into conf-tool
Update and add tests accordingly.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit d003a41a9cb9ea97a7da9dbb5bd3138f82da6cf1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/79a3befc052d0da27e7ef21e6366758f65121007">79a3befc</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-28T08:59:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-config: Switch tunable DisableIPFailover to a config option
Use the "failover:disabled" option instead.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 929634126a334e380f16c080b59d062873b4e5f9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/512149a8f44c305054573a6772f84165d16862ae">512149a8</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-28T08:59:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-doc: Switch tunable DisableIPFailover to a config option
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 78aad7623e100f05a7dfc142fba7ff2b0eba1913)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6620173e7f1fab76199fb970ca85ed246a7fb15b">6620173e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-28T08:59:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add an extra conf loading test case
This shows that config file loading continues in spite of unknown keys
if ignore_unknown is true.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 55893bf8d2cc7e01b3a93d8e1fde16408244cb65)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e67b397f85c624b0eaf5e5161337c58ce858d639">e67b397f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-28T08:59:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Check that no IPs are assigned when failover is disabled
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Aug 24 14:13:12 CEST 2018 on sn-devel-144
(cherry picked from commit 6fb80cbffb9cb8cba6abc3fbce228811d36e8c9a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/927c199630b41b932009656ce146f404b8f2ea5d">927c1996</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-28T12:08:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: More CTDB updates for 4.9
This includes descriptions of some final configuration changes as well
as an overall mapping between old and new configuration options.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Tue Aug 28 14:08:58 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/46aedae1b0df20346c923501539194a3c75aa85a">46aedae1</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-08-29T08:57:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add changes since RC3.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8fd169a3b5d41dfb9cd14d7d2174df143f8d0444">8fd169a3</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-08-29T10:00:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.9.0rc4 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3b31caefd7dd0dae9cdf9a987fae09541c64603c">3b31caef</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-08-29T10:02:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.9.0rc5...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ceff9a1b2f844b73de854ddc5b3e5293ae357ba3">ceff9a1b</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-08-30T17:32:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">d/rules: winbind_krb5_locator is now in the correct path
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/57f7ff2979f72ecef36d68c3a7b0f029a0b6105e">57f7ff29</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-08-30T17:32:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind_krb5_locator manpage has moved from section 7 to 8
See e9e85a183c7b4602e89f741bba9e4ed8c63974d4
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/25ee556ae2aee73f50c9aa9040219573bb755657">25ee556a</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-08-30T17:32:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Release 2:4.8.5+dfsg-1
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/46297461963ae7e445bfebd9651c27d495872847">46297461</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-31T10:08:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit: Add $cwd arg to smb_fname_str_do_log().
Not yet used.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13565
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 59f13347260f5c4367c709eb07139f2ba7ddad72)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c2dfd7165ba1295c1975b6c7b3c3ef4bf3e2c48">4c2dfd71</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-31T13:29:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit: Ensure smb_fname_str_do_log() only returns absolute pathnames.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13565
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Aug 27 20:23:55 CEST 2018 on sn-devel-144
(cherry picked from commit 4d72ebb821518c25e4759ad697d5e18257f80765)
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Fri Aug 31 15:29:32 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8d9c661989dd6faf8841620c077c44fb612e4e05">8d9c6619</a></strong>
<div>
<span>by Paulo Alcantara</span>
<i>at 2018-09-04T10:14:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: util: Do not take over stderr when there is no log file
In case we don't have either a /var/log/samba directory, or pass a
non-existent log directory through '-l' option, all commands that are
daemonized with '-D' option hang when executed within a subshell.
An example on how to trigger that:
# rm -r /var/log/samba
# s=$(nmbd -D -s /etc/samba/smb.conf -l /foo123)
(never returns)
So, when the above command is executed within a subshell the following
happens:
(a) Parent shell creates a pipe, sets write side of it to fd 1
(stdout), call read() on read-side fd, forks off a new child process
and then executes nmbd in it.
(b) nmbd sets up initial logging to go through fd 1 (stdout) by
calling setup_logging(..., DEBUG_DEFAULT_STDOUT). 'state.fd' is now
set to 1.
(c) reopen_logs() is called by the first time which then calls
reopen_logs_internal()
(d) in reopen_logs_internal(), it attempts to create log.nmbd file in
/foo123 directory and fails because directory doesn't exist.
(e) Regardless whether the log file was created or not, it calls
dup2(state.fd, 2) which dups fd 1 into fd 2.
(f) At some point, fd 0 and 1 are closed and set to /dev/null
The problem with that is because parent shell in (a) is still blocked in
read() call and the new write side of the pipe is now fd 2 -- after
dup2() in (e) -- and remains unclosed.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13578
Signed-off-by: Paulo Alcantara <palcantara@suse.de>
Reviewed-by: Jim McDonough <jmcd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Aug 18 01:32:25 CEST 2018 on sn-devel-144
(cherry picked from commit 41aa55f49233ea7682cf14e5a7062617274434ce)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0070d21bd3c2aee8e27d7728619b4f9bac6cfc38">0070d21b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-04T10:14:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop incorrect log message
The message is incorrect because the actual failure was loading the
config file. Instead of fixing the message, drop it because
ctdb_config_load() already logs the failure.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit b5453bc27add11a7288772a59adcc605328b9098)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b711e8d296a085c62e04a1ce5398bb3985290ac">8b711e8d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-04T10:14:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Fix log message for conf option with unknown section
This covers both options that appear before a section and options in
unknown sections.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 421d828f6cb7c13d5f33c6cc1c6be254554588a4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/42b2c12f56c7e0a2e62e2d2f0ea8ad3c6272336c">42b2c12f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-04T10:14:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Log a message for unknown conf option
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit ebb28c57a17777ea15afab63cd0742dd79b30ffe)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/372b79c4f004c04221ca5e584c2b839428107c20">372b79c4</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-04T10:14:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Log a message when an invalid conf value is encountered
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit a017d3181ac1062b66ae506a8a523f7455630fce)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/40dff2ce058b13a1a531d85d43b9f5638c09615a">40dff2ce</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-04T10:14:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Avoid ENOENT for unknown conf type tags
Only use ENOENT for missing configuration file.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit f1084400387c0b1257b6d92ee6e8a89504d788fc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7db0f189d64de651dc665ba3f507e56e1dc27964">7db0f189</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-04T10:14:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Avoid ENOENT for unknown conf options
Only use ENOENT for missing configuration file.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 920ed66ba7e874ca23d72fff9342fbd64a1e329f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a242e1016271fcae17b3c2b5af607bb7c614cb3a">a242e101</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-04T10:14:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Process the whole config file even if an error occurs
At the moment multiple errors will be encountered one at a time, on
each load or validate. Instead, allow all configuration errors to
printed in a single pass.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 4f1727fe0bf2b0962a5d131d60a416b8f459ad94)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/35242cfbf40589eb619e8915ed30564272f7cc10">35242cfb</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-04T10:14:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Add support for sock daemon to notify of successful startup
The daemon writes 0 into the specified file descriptor when it is up
and listening. This can be used to avoid loops in clients that
attempt to connect until they succeed.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit dc6040c121c65d5551c686f3f1be2891795f48aa)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1a171bc54c07ec092d02c2ab89ae5c7263b97b86">1a171bc5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-04T10:14:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Add support to eventd for the startup notification FD
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 11ee92d1bfd73c509d90e7a7386af60a4e1a7fca)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/abb633701c518bd850c80ae519a38adcd2822edf">abb63370</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-04T10:14:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Improve error handling consistency
Other errors free argv, so do it here too.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit e357b62fe556609750bdb8d27cf48dfb85c62ec8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0155635c79defe37d0332ca46865cdd8eaa0d73b">0155635c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-04T10:14:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Open eventd pipe earlier
The pipe will soon be needed earlier, so initialise it earlier.
Ensure the file descriptors are closed on error.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit c446ae5e1382d5e32c33ce92243daf6b4338e15a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/46de8d248ff5e45bd6957c27a78b4160213c1432">46de8d24</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-04T10:14:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Wait for eventd to be ready before connecting
The current method of retrying the connection to eventd means that
messages get logged for each failure.
Instead, pass a pipe file descriptor to eventd and wait for it to
write 0 to the pipe to indicate that it is ready to accept client
connections.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 62ec1ab1470206d6a2cf300f30ca0b4a39413a38)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9987cc39ea777dec95e9f4a8836515722ba263fc">9987cc39</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-04T10:14:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Do not retry connection to eventd
Confirmation is now received from eventd that it is accepting
connections, so this is no longer needed.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit b430a1ace69bcef3336907557ab5bf04271c1110)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/02f01fa7a602f6f996c857a3b2e55420ae888a0c">02f01fa7</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-04T10:14:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Log complete eventd startup command
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 6d3d9a85e5630ba398ac953ad1515155f10224d9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/176c9c38011a5b5fee557ce12cc307902acb746f">176c9c38</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-04T10:14:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix a memleak in async search ask sharemode
fetch_share_mode_unlocked_parser() takes a "struct
fetch_share_mode_unlocked_state *" as
"private_data". fetch_share_mode_send() used a talloc_zero'ed "struct
share_mode_lock". This lead to the parser putting a "struct
share_mode_lock on the NULL talloc_context where nobody really picked it
up.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13602
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 0bd109b733fbce774feae2142d25f7e828b56bcb)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0a1df2a4294da8bd67131da1fb1d9bd3b0c2c4c6">0a1df2a4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T10:14:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/rpc/netlogon: assert that cli_credentials_get_{workstation,password} don't return NULL
This is better that generating a segfault while dereferencing a NULL
pointer later.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11517
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit dffc182c6943d21513d8db9f6cf66bdc09206b17)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5556a67fdf44a89c4e410d1210d4b9811638a948">5556a67f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T10:14:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/rpc/netlogon: verify the trusted domains output of LogonGetDomainInfo()
This makes sure we don't treat trusted domains in the same way we treat
our primary domain.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11517
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit d5dd8fdc647d6a202c5da0451d395116c2cd92b9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53f225cd59bd78ae96d269080865916911e4ec25">53f225cd</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T10:14:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb/util_trusts: domain_dn is an input parameter of dsdb_trust_crossref_tdo_info()
We should not overwrite it within the function.
Currently it doesn't matter as we don't have multiple domains
within our forest, but that will change in future.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11517
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit f5f96f558b499770cdeb3d38998167a387e058b9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7aab1f1918f9e94c384b378332007f5afebe8399">7aab1f19</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T10:14:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb:util_trusts: add dsdb_trust_local_tdo_info() helper function
This is similar to dsdb_trust_xref_tdo_info(), but will also work
if we ever support more than one domain in our forest.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11517
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit c1b0ac95db5c6112d90356c7ada8c3d445e9b668)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c7ca8588f65eaa857d2c957f4c07b88047bbf0ba">c7ca8588</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T10:14:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:dsdb/common: add samdb_domain_guid() helper function
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11517
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 0e442e094240abbf79aaca00a9d1a053a200a7e8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/39823476937e58debdd5e5dd5f0ef3e5ec87e9d6">39823476</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T10:14:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/netlogon: use samdb_domain_guid()/dsdb_trust_local_tdo_info() to build our netr_OneDomainInfo values
The logic for constructing the values for our own primary domain differs
from the values of trusted domains. In order to make the code easier to
understand we have a new fill_our_one_domain_info() helper that
only takes care of our primary domain.
The cleanup for the trust case will follow in a separate commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11517
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 61333f7787d78e3ec5c7bd2874d5a0f1f536275a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c6cfdf0db6f1406635694532d6870cf4ed004474">c6cfdf0d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T10:14:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/netlogon: make use of talloc_zero_array() for the netr_OneDomainInfo array
It's much safer than having uninitialized memory when we hit an error
case.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11517
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit ef0b489ad0d93199e08415dd895da5cfe2d1c11a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a3dbadb4b836ab080f811f5d53be7de14f38faf">7a3dbadb</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T10:14:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/netlogon: don't treet trusted domains as primary in LogonGetDomainInfo()
We need to handle trusted domains differently than our primary
domain. The most important part is that we don't return
NETR_TRUST_FLAG_PRIMARY for them.
NETR_TRUST_FLAG_{INBOUND,OUTBOUND,IN_FOREST} are the relavant flags
for trusts.
This is an example of what Windows returns in a complex trust
environment:
netr_LogonGetDomainInfo: struct netr_LogonGetDomainInfo
out: struct netr_LogonGetDomainInfo
return_authenticator : *
return_authenticator: struct netr_Authenticator
cred: struct netr_Credential
data : f48b51ff12ff8c6c
timestamp : Tue Aug 28 22:59:03 2018 CEST
info : *
info : union netr_DomainInfo(case 1)
domain_info : *
domain_info: struct netr_DomainInformation
primary_domain: struct netr_OneDomainInfo
domainname: struct lsa_StringLarge
length : 0x0014 (20)
size : 0x0016 (22)
string : *
string : 'W2012R2-L4'
dns_domainname: struct lsa_StringLarge
length : 0x0020 (32)
size : 0x0022 (34)
string : *
string : 'w2012r2-l4.base.'
dns_forestname: struct lsa_StringLarge
length : 0x0020 (32)
size : 0x0022 (34)
string : *
string : 'w2012r2-l4.base.'
domain_guid : 0a133c91-8eac-4df0-96ac-ede69044a38b
domain_sid : *
domain_sid : S-1-5-21-2930975464-1937418634-1288008815
trust_extension: struct netr_trust_extension_container
length : 0x0000 (0)
size : 0x0000 (0)
info : NULL
dummy_string2: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_string3: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_string4: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_long1 : 0x00000000 (0)
dummy_long2 : 0x00000000 (0)
dummy_long3 : 0x00000000 (0)
dummy_long4 : 0x00000000 (0)
trusted_domain_count : 0x00000006 (6)
trusted_domains : *
trusted_domains: ARRAY(6)
trusted_domains: struct netr_OneDomainInfo
domainname: struct lsa_StringLarge
length : 0x000e (14)
size : 0x0010 (16)
string : *
string : 'FREEIPA'
dns_domainname: struct lsa_StringLarge
length : 0x0018 (24)
size : 0x001a (26)
string : *
string : 'freeipa.base'
dns_forestname: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
domain_guid : 00000000-0000-0000-0000-000000000000
domain_sid : *
domain_sid : S-1-5-21-429948374-2562621466-335716826
trust_extension: struct netr_trust_extension_container
length : 0x0010 (16)
size : 0x0010 (16)
info : *
info: struct netr_trust_extension
length : 0x00000008 (8)
dummy : 0x00000000 (0)
size : 0x00000008 (8)
flags : 0x00000022 (34)
0: NETR_TRUST_FLAG_IN_FOREST
1: NETR_TRUST_FLAG_OUTBOUND
0: NETR_TRUST_FLAG_TREEROOT
0: NETR_TRUST_FLAG_PRIMARY
0: NETR_TRUST_FLAG_NATIVE
1: NETR_TRUST_FLAG_INBOUND
0: NETR_TRUST_FLAG_MIT_KRB5
0: NETR_TRUST_FLAG_AES
parent_index : 0x00000000 (0)
trust_type : LSA_TRUST_TYPE_UPLEVEL (2)
trust_attributes : 0x00000008 (8)
0: LSA_TRUST_ATTRIBUTE_NON_TRANSITIVE
0: LSA_TRUST_ATTRIBUTE_UPLEVEL_ONLY
0: LSA_TRUST_ATTRIBUTE_QUARANTINED_DOMAIN
1: LSA_TRUST_ATTRIBUTE_FOREST_TRANSITIVE
0: LSA_TRUST_ATTRIBUTE_CROSS_ORGANIZATION
0: LSA_TRUST_ATTRIBUTE_WITHIN_FOREST
0: LSA_TRUST_ATTRIBUTE_TREAT_AS_EXTERNAL
0: LSA_TRUST_ATTRIBUTE_USES_RC4_ENCRYPTION
dummy_string2: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_string3: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_string4: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_long1 : 0x00000000 (0)
dummy_long2 : 0x00000000 (0)
dummy_long3 : 0x00000000 (0)
dummy_long4 : 0x00000000 (0)
trusted_domains: struct netr_OneDomainInfo
domainname: struct lsa_StringLarge
length : 0x0016 (22)
size : 0x0018 (24)
string : *
string : 'S1-W2012-L4'
dns_domainname: struct lsa_StringLarge
length : 0x0036 (54)
size : 0x0038 (56)
string : *
string : 's1-w2012-l4.w2012r2-l4.base'
dns_forestname: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
domain_guid : afe7fbde-af82-46cf-88a2-2df6920fc33e
domain_sid : *
domain_sid : S-1-5-21-1368093395-3821428921-3924672915
trust_extension: struct netr_trust_extension_container
length : 0x0010 (16)
size : 0x0010 (16)
info : *
info: struct netr_trust_extension
length : 0x00000008 (8)
dummy : 0x00000000 (0)
size : 0x00000008 (8)
flags : 0x00000023 (35)
1: NETR_TRUST_FLAG_IN_FOREST
1: NETR_TRUST_FLAG_OUTBOUND
0: NETR_TRUST_FLAG_TREEROOT
0: NETR_TRUST_FLAG_PRIMARY
0: NETR_TRUST_FLAG_NATIVE
1: NETR_TRUST_FLAG_INBOUND
0: NETR_TRUST_FLAG_MIT_KRB5
0: NETR_TRUST_FLAG_AES
parent_index : 0x00000004 (4)
trust_type : LSA_TRUST_TYPE_UPLEVEL (2)
trust_attributes : 0x00000020 (32)
0: LSA_TRUST_ATTRIBUTE_NON_TRANSITIVE
0: LSA_TRUST_ATTRIBUTE_UPLEVEL_ONLY
0: LSA_TRUST_ATTRIBUTE_QUARANTINED_DOMAIN
0: LSA_TRUST_ATTRIBUTE_FOREST_TRANSITIVE
0: LSA_TRUST_ATTRIBUTE_CROSS_ORGANIZATION
1: LSA_TRUST_ATTRIBUTE_WITHIN_FOREST
0: LSA_TRUST_ATTRIBUTE_TREAT_AS_EXTERNAL
0: LSA_TRUST_ATTRIBUTE_USES_RC4_ENCRYPTION
dummy_string2: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_string3: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_string4: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_long1 : 0x00000000 (0)
dummy_long2 : 0x00000000 (0)
dummy_long3 : 0x00000000 (0)
dummy_long4 : 0x00000000 (0)
trusted_domains: struct netr_OneDomainInfo
domainname: struct lsa_StringLarge
length : 0x0006 (6)
size : 0x0008 (8)
string : *
string : 'BLA'
dns_domainname: struct lsa_StringLarge
length : 0x0010 (16)
size : 0x0012 (18)
string : *
string : 'bla.base'
dns_forestname: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
domain_guid : 00000000-0000-0000-0000-000000000000
domain_sid : *
domain_sid : S-1-5-21-4053568372-2049667917-3384589010
trust_extension: struct netr_trust_extension_container
length : 0x0010 (16)
size : 0x0010 (16)
info : *
info: struct netr_trust_extension
length : 0x00000008 (8)
dummy : 0x00000000 (0)
size : 0x00000008 (8)
flags : 0x00000022 (34)
0: NETR_TRUST_FLAG_IN_FOREST
1: NETR_TRUST_FLAG_OUTBOUND
0: NETR_TRUST_FLAG_TREEROOT
0: NETR_TRUST_FLAG_PRIMARY
0: NETR_TRUST_FLAG_NATIVE
1: NETR_TRUST_FLAG_INBOUND
0: NETR_TRUST_FLAG_MIT_KRB5
0: NETR_TRUST_FLAG_AES
parent_index : 0x00000000 (0)
trust_type : LSA_TRUST_TYPE_UPLEVEL (2)
trust_attributes : 0x00000008 (8)
0: LSA_TRUST_ATTRIBUTE_NON_TRANSITIVE
0: LSA_TRUST_ATTRIBUTE_UPLEVEL_ONLY
0: LSA_TRUST_ATTRIBUTE_QUARANTINED_DOMAIN
1: LSA_TRUST_ATTRIBUTE_FOREST_TRANSITIVE
0: LSA_TRUST_ATTRIBUTE_CROSS_ORGANIZATION
0: LSA_TRUST_ATTRIBUTE_WITHIN_FOREST
0: LSA_TRUST_ATTRIBUTE_TREAT_AS_EXTERNAL
0: LSA_TRUST_ATTRIBUTE_USES_RC4_ENCRYPTION
dummy_string2: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_string3: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_string4: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_long1 : 0x00000000 (0)
dummy_long2 : 0x00000000 (0)
dummy_long3 : 0x00000000 (0)
dummy_long4 : 0x00000000 (0)
trusted_domains: struct netr_OneDomainInfo
domainname: struct lsa_StringLarge
length : 0x000c (12)
size : 0x000e (14)
string : *
string : 'S4XDOM'
dns_domainname: struct lsa_StringLarge
length : 0x0016 (22)
size : 0x0018 (24)
string : *
string : 's4xdom.base'
dns_forestname: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
domain_guid : 00000000-0000-0000-0000-000000000000
domain_sid : *
domain_sid : S-1-5-21-313966788-4060240134-2249344781
trust_extension: struct netr_trust_extension_container
length : 0x0010 (16)
size : 0x0010 (16)
info : *
info: struct netr_trust_extension
length : 0x00000008 (8)
dummy : 0x00000000 (0)
size : 0x00000008 (8)
flags : 0x00000022 (34)
0: NETR_TRUST_FLAG_IN_FOREST
1: NETR_TRUST_FLAG_OUTBOUND
0: NETR_TRUST_FLAG_TREEROOT
0: NETR_TRUST_FLAG_PRIMARY
0: NETR_TRUST_FLAG_NATIVE
1: NETR_TRUST_FLAG_INBOUND
0: NETR_TRUST_FLAG_MIT_KRB5
0: NETR_TRUST_FLAG_AES
parent_index : 0x00000000 (0)
trust_type : LSA_TRUST_TYPE_UPLEVEL (2)
trust_attributes : 0x00000008 (8)
0: LSA_TRUST_ATTRIBUTE_NON_TRANSITIVE
0: LSA_TRUST_ATTRIBUTE_UPLEVEL_ONLY
0: LSA_TRUST_ATTRIBUTE_QUARANTINED_DOMAIN
1: LSA_TRUST_ATTRIBUTE_FOREST_TRANSITIVE
0: LSA_TRUST_ATTRIBUTE_CROSS_ORGANIZATION
0: LSA_TRUST_ATTRIBUTE_WITHIN_FOREST
0: LSA_TRUST_ATTRIBUTE_TREAT_AS_EXTERNAL
0: LSA_TRUST_ATTRIBUTE_USES_RC4_ENCRYPTION
dummy_string2: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_string3: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_string4: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_long1 : 0x00000000 (0)
dummy_long2 : 0x00000000 (0)
dummy_long3 : 0x00000000 (0)
dummy_long4 : 0x00000000 (0)
trusted_domains: struct netr_OneDomainInfo
domainname: struct lsa_StringLarge
length : 0x0014 (20)
size : 0x0016 (22)
string : *
string : 'W2012R2-L4'
dns_domainname: struct lsa_StringLarge
length : 0x001e (30)
size : 0x0020 (32)
string : *
string : 'w2012r2-l4.base'
dns_forestname: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
domain_guid : 0a133c91-8eac-4df0-96ac-ede69044a38b
domain_sid : *
domain_sid : S-1-5-21-2930975464-1937418634-1288008815
trust_extension: struct netr_trust_extension_container
length : 0x0010 (16)
size : 0x0010 (16)
info : *
info: struct netr_trust_extension
length : 0x00000008 (8)
dummy : 0x00000000 (0)
size : 0x00000008 (8)
flags : 0x0000001d (29)
1: NETR_TRUST_FLAG_IN_FOREST
0: NETR_TRUST_FLAG_OUTBOUND
1: NETR_TRUST_FLAG_TREEROOT
1: NETR_TRUST_FLAG_PRIMARY
1: NETR_TRUST_FLAG_NATIVE
0: NETR_TRUST_FLAG_INBOUND
0: NETR_TRUST_FLAG_MIT_KRB5
0: NETR_TRUST_FLAG_AES
parent_index : 0x00000000 (0)
trust_type : LSA_TRUST_TYPE_UPLEVEL (2)
trust_attributes : 0x00000000 (0)
0: LSA_TRUST_ATTRIBUTE_NON_TRANSITIVE
0: LSA_TRUST_ATTRIBUTE_UPLEVEL_ONLY
0: LSA_TRUST_ATTRIBUTE_QUARANTINED_DOMAIN
0: LSA_TRUST_ATTRIBUTE_FOREST_TRANSITIVE
0: LSA_TRUST_ATTRIBUTE_CROSS_ORGANIZATION
0: LSA_TRUST_ATTRIBUTE_WITHIN_FOREST
0: LSA_TRUST_ATTRIBUTE_TREAT_AS_EXTERNAL
0: LSA_TRUST_ATTRIBUTE_USES_RC4_ENCRYPTION
dummy_string2: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_string3: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_string4: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_long1 : 0x00000000 (0)
dummy_long2 : 0x00000000 (0)
dummy_long3 : 0x00000000 (0)
dummy_long4 : 0x00000000 (0)
trusted_domains: struct netr_OneDomainInfo
domainname: struct lsa_StringLarge
length : 0x0016 (22)
size : 0x0018 (24)
string : *
string : 'S2-W2012-L4'
dns_domainname: struct lsa_StringLarge
length : 0x004e (78)
size : 0x0050 (80)
string : *
string : 's2-w2012-l4.s1-w2012-l4.w2012r2-l4.base'
dns_forestname: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
domain_guid : 29daace6-cded-4ce3-a754-7482a4d9127c
domain_sid : *
domain_sid : S-1-5-21-167342819-981449877-2130266853
trust_extension: struct netr_trust_extension_container
length : 0x0010 (16)
size : 0x0010 (16)
info : *
info: struct netr_trust_extension
length : 0x00000008 (8)
dummy : 0x00000000 (0)
size : 0x00000008 (8)
flags : 0x00000001 (1)
1: NETR_TRUST_FLAG_IN_FOREST
0: NETR_TRUST_FLAG_OUTBOUND
0: NETR_TRUST_FLAG_TREEROOT
0: NETR_TRUST_FLAG_PRIMARY
0: NETR_TRUST_FLAG_NATIVE
0: NETR_TRUST_FLAG_INBOUND
0: NETR_TRUST_FLAG_MIT_KRB5
0: NETR_TRUST_FLAG_AES
parent_index : 0x00000001 (1)
trust_type : LSA_TRUST_TYPE_UPLEVEL (2)
trust_attributes : 0x00000000 (0)
0: LSA_TRUST_ATTRIBUTE_NON_TRANSITIVE
0: LSA_TRUST_ATTRIBUTE_UPLEVEL_ONLY
0: LSA_TRUST_ATTRIBUTE_QUARANTINED_DOMAIN
0: LSA_TRUST_ATTRIBUTE_FOREST_TRANSITIVE
0: LSA_TRUST_ATTRIBUTE_CROSS_ORGANIZATION
0: LSA_TRUST_ATTRIBUTE_WITHIN_FOREST
0: LSA_TRUST_ATTRIBUTE_TREAT_AS_EXTERNAL
0: LSA_TRUST_ATTRIBUTE_USES_RC4_ENCRYPTION
dummy_string2: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_string3: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_string4: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_long1 : 0x00000000 (0)
dummy_long2 : 0x00000000 (0)
dummy_long3 : 0x00000000 (0)
dummy_long4 : 0x00000000 (0)
lsa_policy: struct netr_LsaPolicyInformation
policy_size : 0x00000000 (0)
policy : NULL
dns_hostname: struct lsa_StringLarge
length : 0x0036 (54)
size : 0x0038 (56)
string : *
string : 'torturetest.w2012r2-l4.base'
dummy_string2: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_string3: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
dummy_string4: struct lsa_StringLarge
length : 0x0000 (0)
size : 0x0000 (0)
string : NULL
workstation_flags : 0x00000003 (3)
1: NETR_WS_FLAG_HANDLES_INBOUND_TRUSTS
1: NETR_WS_FLAG_HANDLES_SPN_UPDATE
supported_enc_types : 0x0000001f (31)
1: KERB_ENCTYPE_DES_CBC_CRC
1: KERB_ENCTYPE_DES_CBC_MD5
1: KERB_ENCTYPE_RC4_HMAC_MD5
1: KERB_ENCTYPE_AES128_CTS_HMAC_SHA1_96
1: KERB_ENCTYPE_AES256_CTS_HMAC_SHA1_96
0: KERB_ENCTYPE_FAST_SUPPORTED
0: KERB_ENCTYPE_COMPOUND_IDENTITY_SUPPORTED
0: KERB_ENCTYPE_CLAIMS_SUPPORTED
0: KERB_ENCTYPE_RESOURCE_SID_COMPRESSION_DISABLED
dummy_long3 : 0x00000000 (0)
dummy_long4 : 0x00000000 (0)
result : NT_STATUS_OK
Best viewed with: git show --histogram -w
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11517
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 2099add0657126e4a5427ec2db0fe8025478b355)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7c5883a572a8979ddeebcc6dc2999585b4588490">7c5883a5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-04T10:14:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_delay_inject: adding delay to VFS calls
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13549
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 44840ba5b32a2ce7959fd3d7c87822b3159416d3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99ef099d0d60272fdeb976e5244f35547d1dae19">99ef099d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-04T10:14:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:selftest: reformat smb2_s3only list
No change besides reformatting the list to one entry per line.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13549
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 3255822f75163cb38e53f634a5c6b03d46bfaff1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c77edea016b1df8357dfe273a2688612a51ade4b">c77edea0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-04T10:14:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: add a durable handle test with delayed disconnect
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13549
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 5508024a861e7c85e6c837552ad142aa1d5e8eca)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b5d78343fb26ade4783e214c877ea837910e5d8e">b5d78343</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-04T10:14:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: reorder tcon global record deletion and closing files of a tcon
As such, this doesn't change overall behaviour, but in case we ever add
semantics acting on tcon record changes via an API like
dbwrap_watch_send(), this will make a difference as it enforces
ordering.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13549
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit b70b8503faded81b10859131f08486349876d132)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/71b7745111551e0076ac33b81c1c8eef3b4594cd">71b77451</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-04T10:14:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: let session logoff close files and tcons before deleting the session
This avoids a race in durable handle reconnects if the reconnect comes
in while the old session is still in the tear-down phase.
The new session is supposed to rendezvous with and wait for destruction
of the old session, which is internally implemented with
dbwrap_watch_send() on the old session record.
If the old session deletes the session record before calling
file_close_user() which marks all file handles as disconnected, the
durable handle reconnect in the new session will fail as the records are
not yet marked as disconnected which is a prerequisite.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13549
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 8f6edcc1645e0ed35eaec914bd0b672500ce986c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/52657164ac05c26c3879da8e57a0c606eeb77911">52657164</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-04T10:14:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: add a comment stating that file_close_user() is redundant for SMB2
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13549
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Sep 1 01:26:35 CEST 2018 on sn-devel-144
(cherry picked from commit 5d95f79f604d90c2646225a0f2470f05dd71e19e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5dad448c7cc6a90d08bfa53cd027b9418d396bac">5dad448c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-04T10:14:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Make sure that fruit_ftruncate only unlinks streams
Follow-up to
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13441
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit c39ec64231b261fe4ada02f1f1b9aa344cf35bb5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bcba25d3ea0d9af2e131397e640b2bd5d793825d">bcba25d3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-04T13:59:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: Don't unlink the main file
The original fix for bug 13441 was missing a check that verifies that
fruit_ftruncate() is actually called on a stream.
Follow-up to
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13441
Pair-Programmed-With: Volker Lendecke <vl@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Aug 23 15:28:48 CEST 2018 on sn-devel-144
(cherry picked from commit 8c14234871820eacde46670d722a676fb5f3a46c)
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Tue Sep 4 15:59:02 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ab0e26af17d36ef5e5e708d2c6461f07d7ff7e1c">ab0e26af</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T08:32:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:selftest: test kinit with the interdomain trust user account
To test it, add a blackbox test that ensures we pass a keytab-based
authentication with the trust user account for a trusted domain.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13539
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 7df505298f71432d5adbcffccde8f97c117a57a6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/58b3c86497373752b41b46b98dcdaa1c51242a11">58b3c864</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-05T08:32:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: add virtualKerberosSalt attribute to 'user getpassword/syncpasswords'
This might be useful for someone, but at least it's very useful for
tests.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13539
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 39c281a23673691bab621de1a632d64df2c1c102)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a8be75bd08a1276a2e27c4b82b2f22c1069e1e8f">a8be75bd</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-05T08:32:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs/blackbox: add testit[_expect_failure]_grep() to subunit.sh
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13539
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 8526feb100e59bc5a15ceb940e6cecce0de59247)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3dba82d3e631c55b71fdfb8bc278d1dfa697a49b">3dba82d3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-05T08:32:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs/blackbox: let test_trust_user_account.sh check the correct kerberos salt
This demonstrates the bug we currently have.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13539
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 1b31fa62567ec549e32c9177b322cfbfb3b6ec1a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c53bf98a629dfa1592aa12cca8166201c872f0db">c53bf98a</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T13:40:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5-samba: interdomain trust uses different salt principal
Salt principal for the interdomain trust is krbtgt/DOMAIN@REALM where
DOMAIN is the sAMAccountName without the dollar sign ($)
The salt principal for the BLA$ user object was generated wrong.
dn: CN=bla.base,CN=System,DC=w4edom-l4,DC=base
securityIdentifier: S-1-5-21-4053568372-2049667917-3384589010
trustDirection: 3
trustPartner: bla.base
trustPosixOffset: -2147483648
trustType: 2
trustAttributes: 8
flatName: BLA
dn: CN=BLA$,CN=Users,DC=w4edom-l4,DC=base
userAccountControl: 2080
primaryGroupID: 513
objectSid: S-1-5-21-278041429-3399921908-1452754838-1597
accountExpires: 9223372036854775807
sAMAccountName: BLA$
sAMAccountType: 805306370
pwdLastSet: 131485652467995000
The salt stored by Windows in the package_PrimaryKerberosBlob
(within supplementalCredentials) seems to be
'W4EDOM-L4.BASEkrbtgtBLA' for the above trust
and Samba stores 'W4EDOM-L4.BASEBLA$'.
While the salt used when building the keys from
trustAuthOutgoing/trustAuthIncoming is
'W4EDOM-L4.BASEkrbtgtBLA.BASE', which we handle correct.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13539
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Sep 5 03:57:22 CEST 2018 on sn-devel-144
(cherry picked from commit f3e349bebc443133fdbe4e14b148ca8db8237060)
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Wed Sep 5 15:40:53 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/85edcc5637ff81128da0a556d7e0c2682ebc779e">85edcc56</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-09-06T07:56:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.9.0rc5.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/71aa4d1578f3b233975a36c7b00e24a0e664791b">71aa4d15</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-09-06T07:56:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.9.0rc5 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fa4c7f43b7ae93b55458a62c89f2e61542b36d5e">fa4c7f43</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-09-06T07:57:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.9.0rc6...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c9743bacfe873558e7fe17e45e0124a134266d09">c9743bac</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-09-11T10:01:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Fix 'make -j<jobs>'
Currently only 'make -j' enables parallel builds and e.g. 'make -j4'
results in no parallel compile jobs at all.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13606
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Sep 7 20:24:46 CEST 2018 on sn-devel-144
(cherry picked from commit 70169d4789fe8b2ee4efe5e88eeaa80e1a641b32)
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Tue Sep 11 12:01:22 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b94c676eb1a8e50255cf5e23c8178bcf1270e8d2">b94c676e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-13T06:38:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW.txt: announce 4.9.0 trust improvements
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9bb128fc78527d77ddabc4c4dc21f77788b6cc22">9bb128fc</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-09-13T06:38:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba_dnsupdate: honor 'dns zone scavenging' option, only update if needed
Since scavenging is implemented the samba_dnsupdate command always updates all
dns records required by the dc. This is not needed if dns zone scavenging
is not enabled.
This avoids the repeating TSIG error messages:
# samba_dnsupdate --option='dns zone scavenging = yes' 2>&1 | uniq -c
29 ; TSIG error with server: tsig verify failure
1 Failed update of 29 entries
# echo ${PIPESTATUS[0]}
29
# samba_dnsupdate --option='dns zone scavenging = no' 2>&1 | uniq -c
# echo ${PIPESTATUS[0]}
0
Note that this results in about 60 lines in the log file,
which triggered every 10 minutes ("dnsupdate:name interval=600" is the default).
This restores the behavior before 8ef42d4dab4dfaf5ad225b33f7748914f14dcd8c,
if "dns zone scavenging" is not switched on (which is still the default).
Avoiding the message from happening at all is subject for more debugging,
most likely they are caused by bugs in 'nsupdate -g' (from the bind package).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13605
Pair-programmed-with: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Björn Baumbach <bb@sernet.de>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/efbb84245bb68aee4b3542481534a1108059a798">efbb8424</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-09-13T09:36:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: 'samba-tool ou' command: manage organizational units
Signed-off-by: Björn Baumbach <bb@sernet.de>
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Thu Sep 13 11:36:40 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/834631be87a7839d65b4af49962f5dbd91272e2c">834631be</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-09-13T09:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Fix typo.
Thanks to garming@catalyst.net.nz for catching!
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ea7784ab2d062f83c430a1009b5814290d9e9600">ea7784ab</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-09-13T09:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.9.0.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4fc4ae2924aaa2fc184b7385069274526fa8a4c2">4fc4ae29</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-09-13T09:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.9.0 release
and bump version up to 4.9.0.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cab67cb61fc0f8dfdab24dc90b1155b26d8d2be3">cab67cb6</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-09-13T09:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.9.1...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f66ecfc8de392e681fc2fb212f7da9369618f7d3">f66ecfc8</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-09-14T15:02:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update d/gbp.conf, d/watch and d/README.source for 4.9
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/76c3e172c5cde14bba9893b63cb5db361d18a43e">76c3e172</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-09-14T15:04:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">New upstream version 4.9.0+dfsg</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5a0bdef6954306c916bf97c6d2f42d3d3ba07fac">5a0bdef6</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-09-14T15:09:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update upstream source from tag 'upstream/4.9.0+dfsg'
Update to upstream version '4.9.0+dfsg'
with Debian dir 931b7faf0cfd4bee0cf432c0e906f8c28bfa71c3</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/52b820c777ab2f30abbb2d0097b4fab2afb652fb">52b820c7</a></strong>
<div>
<span>by Jelmer Vernooij</span>
<i>at 2018-09-14T15:10:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Always specify rpath for private libraries
Last-Update: 2012-02-24
Applied-Upstream: no
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0ac09d861f00c9222bda7d45c1a4a7e0d2b4f5ea">0ac09d86</a></strong>
<div>
<span>by Christian Perrier</span>
<i>at 2018-09-14T15:10:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">64 bit fix for libsmbclient
Bug-Debian: http://bugs.debian.org/221618
Forwarded: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=221618#27
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d39f437aa3826c87c9444629b79f71274c475f25">d39f437a</a></strong>
<div>
<span>by Christian Perrier</span>
<i>at 2018-09-14T15:10:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Mention smbldap-tools package in examples/LDAP/README
Bug-Debian: http://bugs.debian.org/341934
Forwarded: not-needed
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/06d9035e7fadec1b09c3604ea2b584e15b703360">06d9035e</a></strong>
<div>
<span>by Steve Langasek</span>
<i>at 2018-09-14T15:10:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Use the pager alternative as pager is PAGER is undefined
Bug-Debian: http://bugs.debian.org/135603
Forwarded: not-needed
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/10fc0f700425f93d7f6ceafb80f4ae184aa8dea5">10fc0f70</a></strong>
<div>
<span>by mathiaz@ubuntu.com</span>
<i>at 2018-09-14T15:10:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Enable net usershares by default at build time
Enable net usershares by default at build time, with a limit of 100, and update
the corresponding documentation.
Bug-Debian: http://bugs.debian.org/443230
Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/128548
Forwarded: not-needed
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/732167717910f36ad8520c96f120b659f515719a">73216771</a></strong>
<div>
<span>by Eloy A. Paris</span>
<i>at 2018-09-14T15:10:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add "Debian" as vendor suffix
Forwarded: not-needed
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b76aa6b271e6d5a0b12ddbdb58cc04b4921d53c0">b76aa6b2</a></strong>
<div>
<span>by Jeroen Dekkers</span>
<i>at 2018-09-14T15:10:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add so version number to private libraries for dpkg-shlibdeps
We also want dpkg-shlibdeps to generate correct dependency information
for the private libraries in our binary packages, but dpkg-shlibdeps
only works when the library has a version number.
Origin: vendor
Forwarded: not-needed
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e0e955e9e0f530a629884a4d411026c6f5ea29ae">e0e955e9</a></strong>
<div>
<span>by Brian May</span>
<i>at 2018-09-14T15:10:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Patch in symbol table from rfc3454, for Heimdal scripts
Status: cherry-picked from heimdal package
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4601585750789f3b3bc9c7a61ba717e92e9fbee6">46015857</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-09-14T15:14:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Remove Fix-pidl-manpage-sections.patch, Fix-spelling.patch and Improve-vfs_linux_xfs_sgid-manpage.patch, merged upstream
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2bc7186420af49146abc09cdb76f4005ed1bb847">2bc71864</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-09-14T16:00:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Bump build-depends talloc >= 2.1.14, tdb >= 1.3.16, tevent >= 0.9.37 and ldb >= 2:1.4.2
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/54ff77371949c178b1a03f3db180f96fa7871bb0">54ff7737</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-09-17T13:31:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "Prepend 1.4.0+really to ldb version to allow samba-dsdb-modules install"
We now use 1.4 really :-P
This reverts commit f262fc54c9e3bf6fe52ca9da5ee6e04c954d1d7d.
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/054c973e6f53285565568392ff8afd41a3997d0f">054c973e</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-09-17T13:31:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Changelog for previous commits
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78fbf101a1a17e433ca7067383beee2da4a297fc">78fbf101</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-09-20T07:11:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-spoolss: Make spoolss client os_major,os_minor and os_build configurable.
Similar to spoolss server options, make the client advertised OS version
values configurable to allow overriding the defaults provided to the print server.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13597
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/06c566c5bae97ebb37fa5d0d8eaf760e26d61128">06c566c5</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2018-09-20T07:11:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-rpc_client: Advertise Windows 7 client info
Client printing operations currently fail against Windows
Server 2016 with Access Denied if a client os build number
lower than 6000 is advertised. Increase the default build number,
major, and minor versions to values associated with client
OS versoins Windows 7 and Windows Server 2008 R2.
The build number value specifically needs to be increased to
allow these operations to succeed.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13597
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff7b23144273cf4a28f90f44fd1e7757cbe79590">ff7b2314</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-09-20T07:11:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-rpcclient: Use spoolss_init_spoolss_UserLevel1 in winspool cmds
Use spoolss initialization function to set client version information for
iremotewinspool printer operations
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/042095582f8bb5c3a20a6cad08187b95fbc29416">04209558</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2018-09-20T07:11:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-doc: Remove PIDFILE option from ctdbd_wrapper man page
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13610
Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Ralph Böhme <slow@samba.org>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Wed Sep 12 21:50:57 CEST 2018 on sn-devel-144
(cherry picked from commit e52abc8a44de6791dceb6f43af1db472a3d9ec37)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de45241352425862d186fc9d052af6786522196d">de452413</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-20T07:11:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-cluster-mutex: Reset SIGTERM handler in cluster mutex child
If SIGTERM is received and the tevent signal handler setup in the
recovery daemon is still enabled then the signal is handled and a
corresponding event is queued. The child never runs an event loop so
the signal is effectively ignored.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 5a6b139884f08ee2ee10f9d16fe56ad8fb5352a6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7187d7dbdcc46200196107b23355d62f820497c4">7187d7db</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-20T07:11:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-cluster-mutex: Block signals around fork
If SIGTERM is received and the tevent signal handler setup in the
recovery daemon is still enabled then the signal is handled and a
corresponding event is queued. The child never runs an event loop so
the signal is effectively ignored.
Resetting the SIGTERM handler isn't enough. A signal can arrive
before that.
Block SIGTERM before forking and then immediately unblock it in the
parent.
In the child, unblock SIGTERM after the signal handler is reset. An
explicit unblock is needed because according to sigprocmask(2) "the
signal mask is preserved across execve(2)".
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit e789d0da57fc3fc6d22bfa00577a2e65034ca27a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3819f795254558db298022bd6ff7900e7b883229">3819f795</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-20T07:11:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Clean up taking of recovery lock
No functional changes, just coding style cleanups and debug message
tweaks.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 59fc01646c7d65ba90b0a1a34c3795ff842351c5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7bd0e802455d567374084339d3835197eac5212e">7bd0e802</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-20T07:11:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Re-check master on failure to take recovery lock
If the master changed while trying to take the lock then fail gracefully.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit c516e58ce92c420dc993bd9b7f1433641bd764bd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/773a64741d63e9ff24f681e243afe72b2dd3a561">773a6474</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-20T07:11:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Rename hold_reclock_state to ctdb_recovery_lock_handle
This will be a longer lived structure.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit af22f03dbe9040f5f743eb85bb50d411269bbab4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/54820e3d4024d5ffb0be36db026845a8c4dd6e5c">54820e3d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-20T07:11:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Use talloc() to allocate recovery lock handle
At the moment this is still local and is freed after the mutex is
successfully taken.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit a53b264aee7d620ee8ecf9114b0014c5bb678484)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/491304027110a89a14415cfab62dc50d38b9131d">49130402</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-20T07:11:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Store recovery lock handle
... not just cluster mutex handle.
This makes the recovery lock handle long-lived and with allow the
releasing code to cancel an in-progress attempt to take the recovery
lock.
The cluster mutex handle is now allocated off the recovery lock
handle.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit c52216740bd81b68876de06e104822bbbca86df9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9c7c64116ad0031aa132bceee08cec9adc37ad8">a9c7c641</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-20T07:11:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Return early when the recovery lock is not held
This makes upcoming changes simpler.
Update to modern debug macro while touching relevant line.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit a755d060c13b65dfb6d73979aaf111c489882bfb)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e6bcccbca29a98af134a5f9e3ef620ef48411240">e6bcccbc</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-20T07:11:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Handle cancellation when releasing recovery lock
If the recovery lock is in the process of being taken then free the
cluster mutex handle but leave the recovery lock handle in place.
This allows ctdb_recovery_lock() to fail.
Note that this isn't yet live because rec->recovery_lock_handle is
still only set at the completion of the attempt to take the lock.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit b1dc5687844e90b0e3c39cb46a1116c86118fbf4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/10d1b4d9a2e24f5bd6d5009f9ee6b4a8e1114af6">10d1b4d9</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-20T10:35:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Set recovery lock handle at start of attempt
This allows the attempt to be cancelled if an election is lost and an
unlock is done before the attempt is completed.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Tue Sep 18 02:18:30 CEST 2018 on sn-devel-144
(cherry picked from commit 486022ef8f43251258f255ffa15f1a01bc6aa2b7)
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Thu Sep 20 12:35:23 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/95b08d103d1c76b49b4872948cca98939f81a954">95b08d10</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-09-21T10:15:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: nmbd: Stop nmbd network announce storm.
Correct fix for. On announce, work->lastannounce_time is set
to current time t, so we must check that 't >= work->lastannounce_time',
not 't > work->lastannounce_time' otherwise we end up not
doing the comparison, and always doing the announce.
Reported by Reuben Farrelly
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13620
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Revviewe-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 1d1cd28adaba691ba434a47031fb52ff8887c728)
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Fri Sep 21 12:15:13 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f4ef2c4f1f113da34c447ecf666a60e77d065017">f4ef2c4f</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-09-21T18:32:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update paths
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0a05762f8b811dabdab1580cb5e084f263106cca">0a05762f</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-09-22T05:56:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add ctdb.NEWS: "Configuration has been completely overhauled"
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff3dc790707dead673e191968953f6ba77aa8a50">ff3dc790</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-09-22T06:57:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update libsmbclient.symbols
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d9e313cf999fd171cb4973bee4e58c35543ce12">7d9e313c</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-09-22T15:06:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb.lintian-override: Remove script-not-executable override
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2c218c70cca0bd9629d537ba49c36fba61f29f25">2c218c70</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-09-22T21:03:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Enable/disable legacy script in postinst/presinst
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e5f5e13b355357846493e7029c7d29ddf32c8c4a">e5f5e13b</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-09-22T21:05:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Release 2:4.9.0+dfsg-1 to experimental
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7483205ba8ba1f10bc8b8ebb73069a61152a79e8">7483205b</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-09-24T06:40:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.9.1.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8fb6b0f42eef05614926cfc2b82117441fd06678">8fb6b0f4</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-09-24T06:40:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.9.1 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/02013cb9437a9db3259000d18b35057130de9918">02013cb9</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-09-24T10:46:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">New upstream version 4.9.1+dfsg</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/61ac884bf0027786b3b8b8c8c2d8030c0fdbab8e">61ac884b</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-09-24T10:52:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge tag 'upstream/4.9.1+dfsg'
Upstream version 4.9.1+dfsg
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3816cbac6b8db286e065663f6008ce60e47a19fc">3816cbac</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-09-24T11:33:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Release 2:4.9.1+dfsg-1
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6bb871706c238b77d0064aabf906e22ef6d2aa12">6bb87170</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-10-08T20:01:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Enable --accel-aes=intelaesni on DEB_HOST_ARCH_CPU=amd64 instead of DEB_HOST_ARCH=amd64. This matches samba-libs.install and adds x32</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8985806523e7cd94de96939ea3b6d165038f984e">89858065</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-10-09T07:58:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Update pam_wrapper to version 1.0.7
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 1fd2a79a92fc30d7667eb97d0846043a9d29b5cf)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7c170cd2f52c2b3261a81bd3c7e831afdafa2c63">7c170cd2</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-10-09T07:58:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Add pam_set_items.so from pam_wrapper
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 7dd388a1f9fa30beb2f814bd16463d1643638587)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0702d237d4dcdee2cc7cab2216adcd4ea672f29d">0702d237</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-10-09T07:59:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Add try_authtok option to pam_winbind
Same as the use_authtok option, except that if the new password is not
valid, PAM will prompt for a password.
Bug-Debian: https://bugs.debian.org/858923
Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/570944
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit ad5debcbe5215e9a45f92ea45f20cc93781e93fa)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5403c81c2df714dce0668e9f5f2b9d6f6955eecd">5403c81c</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-10-09T08:01:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Check pam_winbind pw change with different options
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Oct 2 17:30:29 CEST 2018 on sn-devel-144
(cherry picked from commit 6240022488464deee8ac5924059a593e377bc538)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/106bf049102eaa77d26cb305264674759ae7696c">106bf049</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-10-09T08:05:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Patch for previous 4 commits
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9677ef154ac26bf357f80bbb1e3d73c502ec726c">9677ef15</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-10-09T08:06:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pam_winbind: Use the new try_authtok option allowing password change while preserving current behavior with password strength modules (Closes: #858923, LP: #570944)
</pre>
</li>
</ul>
<h4>30 changed files:</h4>
<ul>
<li class="file-stats">
<a href="#1e7f0290c43feede36a7d7f90d5535909356001b">
<span class="new-file">
+
.gitlab-ci-private.yml
</span>
</a>
</li>
<li class="file-stats">
<a href="#587d266bb27a4dc3022bbed44dfa19849df3044c">
.gitlab-ci.yml
</a>
</li>
<li class="file-stats">
<a href="#dea01dd89a3b602828e630677fde5d77c06441c8">
.travis.yml
</a>
</li>
<li class="file-stats">
<a href="#73f8abedbab7412a39ca2fd49cdcd1ad3f339122">
.ycm_extra_conf.py
</a>
</li>
<li class="file-stats">
<a href="#5df5b4eb5cc165c5531c59175cdabb2aafb2050a">
README.Coding
</a>
</li>
<li class="file-stats">
<a href="#b33892fbddeffc3368077b4904ad0b3d562a7312">
VERSION
</a>
</li>
<li class="file-stats">
<a href="#3277e12b5a9f9ff632d229e2629d34ad21dd93fc">
WHATSNEW.txt
</a>
</li>
<li class="file-stats">
<a href="#8949504a58f9f540cf1b88389d4f731790dd8d7f">
auth/auth_log.c
</a>
</li>
<li class="file-stats">
<a href="#b92a94ee4472cf33f2bd4ac352ea7c22dfd2662c">
auth/auth_sam_reply.c
</a>
</li>
<li class="file-stats">
<a href="#2fc4f46a1019913492bab407f088f2ba94eb6ef6">
auth/auth_sam_reply.h
</a>
</li>
<li class="file-stats">
<a href="#537370e7e9d868507093bf1a758bef98a2e919b0">
auth/common_auth.h
</a>
</li>
<li class="file-stats">
<a href="#0789ffa2f9e10b296a93e28057e96840974fc1f1">
auth/credentials/credentials.c
</a>
</li>
<li class="file-stats">
<a href="#fcf792b723f1fb082b2ae957ef92e787131776f7">
auth/credentials/credentials_krb5.c
</a>
</li>
<li class="file-stats">
<a href="#3ba9adbf308925d07210b46e0970bb35ccea3643">
auth/credentials/credentials_secrets.c
</a>
</li>
<li class="file-stats">
<a href="#9283eb682b67801707177e777c6175a149627c4c">
auth/credentials/pycredentials.c
</a>
</li>
<li class="file-stats">
<a href="#d1e9c57babd173c3a3ecdb72c4a6a0016f04a691">
auth/credentials/tests/bind.py
</a>
</li>
<li class="file-stats">
<a href="#a052e04fd40f1081b95872e2bee962fb500f6f42">
auth/credentials/wscript_build
</a>
</li>
<li class="file-stats">
<a href="#66295ac674be94d435ac3bf2e41ecd51bac9b984">
auth/gensec/spnego.c
</a>
</li>
<li class="file-stats">
<a href="#8eab3d716e7a2f262ad99b521ccdce169e9f5fd5">
auth/kerberos/gssapi_pac.c
</a>
</li>
<li class="file-stats">
<a href="#15134c88b253ed6be6ba1a2124f0de061b4168d5">
auth/ntlmssp/gensec_ntlmssp_server.c
</a>
</li>
<li class="file-stats">
<a href="#0b14a47777d0310e81b8550bb8ab5dd91a7303cb">
auth/ntlmssp/ntlmssp_client.c
</a>
</li>
<li class="file-stats">
<a href="#df1151fa8fcf1360a4878d0376c50ac14f9e97f6">
auth/ntlmssp/ntlmssp_server.c
</a>
</li>
<li class="file-stats">
<a href="#6fc48ce87d1155227246b415e50902d38c0caff7">
auth/wscript_build
</a>
</li>
<li class="file-stats">
<a href="#406ef235207eae535d574f9e8496ca6ee2a5ac52">
<span class="deleted-file">
−
auth/wscript_configure
</span>
</a>
</li>
<li class="file-stats">
<a href="#01417ad184e28fd32ee5f5843ed11b52f92988a2">
buildtools/wafsamba/nothreads.py
</a>
</li>
<li class="file-stats">
<a href="#b79992e65043f07dc261275da3b4234e99db9225">
buildtools/wafsamba/samba_abi.py
</a>
</li>
<li class="file-stats">
<a href="#717e4435bfe6c4ce86a7ac15a5461119235be37b">
buildtools/wafsamba/samba_autoconf.py
</a>
</li>
<li class="file-stats">
<a href="#2e91a720ad2ef0fa7f65c42041b385e315aa9728">
buildtools/wafsamba/samba_bundled.py
</a>
</li>
<li class="file-stats">
<a href="#26ef5117e855ed70eaa252bb89b0d1a6dc1d4bfe">
buildtools/wafsamba/samba_conftests.py
</a>
</li>
<li class="file-stats">
<a href="#58475a1ef0835a765def7dff0dbaba0eda5152ab">
buildtools/wafsamba/samba_dist.py
</a>
</li>
</ul>
<h5>The diff was not included because it is too large.</h5>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
<a href="https://salsa.debian.org/samba-team/samba/compare/7808a17c18221d3fd95f09bcd3ab18f4a4011165...9677ef154ac26bf357f80bbb1e3d73c502ec726c">View it on GitLab</a>.
<br>
You're receiving this email because of your account on salsa.debian.org.
If you'd like to receive fewer emails, you can
adjust your notification settings.
</p>
</div>
</body>
</html>