<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<h3>
Mathieu Parent pushed to branch selftest
at <a href="https://salsa.debian.org/samba-team/samba">Debian Samba Team / samba</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a39bcd0ba2b967d5eac58202f49d4624e739aeb">7a39bcd0</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-09-24T06:40:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.9.2...
...and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7249a4e54b290bb2d3081d2cbcee3ebcd6f198a9">7249a4e5</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-09-26T11:01:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: Check for -fstack-protect-strong support
The -fstack-protector* flags are compiler only flags, don't pass them to
the linker.
https://developers.redhat.com/blog/2018/03/21/compiler-and-linker-flags-gcc/
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13601
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 38e97f8b52e85bdfcf2d74a4fb3c848fa46ba371)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/29883c7bcbdc742bf22d6205543321f57200a20e">29883c7b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-09-26T13:55:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: Add -fstack-clash-protection
https://developers.redhat.com/blog/2018/03/21/compiler-and-linker-flags-gcc/
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13601
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit fc4df251c88365142515a81bea1120b2b84cc4a0)
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Wed Sep 26 15:55:52 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/240586b6a20d9d94182398d0c03b57c0ee4eac76">240586b6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T13:51:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib/server_contexts: make server_event_ctx and server_msg_ctx static
server_event_ctx and server_msg_ctx static shouldn't be accessible from
outside this compilation unit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
(cherry picked from commit d920a725ee19215190bbccaefd5b426bedc98860)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7791f204c7158650e93eb46abb598141fc6f4d6d">7791f204</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-10-10T13:51:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib:popt_common: Move setup_logging to common callback
The flag is set in the common callback, so be consistent
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit dff1028e8ba4c70e726283c12531853681034014)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c247ae0169e572bc22f99a06e71cb0dc54260924">c247ae01</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-10-10T13:51:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Move popt_common_credentials to separate file
This is only used by command line utilities and has additional
dependencies. Move to a separate file to contain the dependencies to the
command line tools.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit b7464fd89bc22b71c82bbaa424bcbfcf947db651)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b63a2006526b928c4d89b15383eab57a69b57702">b63a2006</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-10-10T13:51:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Introduce cmdline context wrapper
Command line tools need acccess to the same messaging context provided
by server_messaging_context, as common code for db_open uses that
context. We want to have additional checking for command line tools
without having that code part of the servers. Introduce a wrapper
library to use for command line tools with the additional checks, that
then acquires the server_messaging_context.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 8c3b62e6231e62feafacf2a7ee4c9d41cd27a4a1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b02c52cc513af03af27a4173a623c7e61d9eac17">b02c52cc</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T13:51:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:loadparm: reinit_globals in lp_load_with_registry_shares()
This was set to false in 0e0d77519c27038b30fec92d542198e97be767d9 based
on the assumption that callers would have no need to call
lp_load_initial_only() with a later call to lp_load_something().
This is not quite correct, since for accessing registry config on a
cluster with include=registry, we need messaging up and running which
*itself* requires loadparm to be initialized to get the statedir,
lockdir asf. directories.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
(cherry picked from commit 3aca3f24d4bdacc11278388934b0b411d518d7b0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bbdefe855af17e8cbbeb473baf939d2b415e8e09">bbdefe85</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T13:51:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: pass configfile to pdbedit
This is needed otherwise pdbedit fails to initialize messaging in
autobuild.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
(cherry picked from commit 10e1a6ebb3d95b8a1584a9b90c2584536aa9c96d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9329a288185162c237f65f8dcaa72e6d52a142c3">9329a288</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T13:51:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:popt_common: use cmdline_messaging_context() in popt_common_credentials_callback()
This adds a call to cmdline_messaging_context() to the popt
popt_common_credentials_callback() hook and ensures that any client tool
that uses POPT_COMMON_CREDENTIALS gets an implicit messaging context,
ensuring it doesn't crash in the subsequent lp_load_client() with
include=registry in a cluster.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
(cherry picked from commit 2c63ce94ef3a55ab0aa1aae4f6fee88e29ac2efe)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8251e95c1ad7481cbc729338156fd027d9305748">8251e95c</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-10-10T13:51:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test:doc: Skip 'clustering=yes'
As testparm will error out when running clustering=yes as non-root, skip
this step to avoid a test failure.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(backported from commit 3ecb9ed7b079fc1bf74c311cf5f1684086b36883)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/49f962f515b50411b181d5cbc9289f4368aa96da">49f962f5</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-10-10T13:51:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbpasswd: Use cmdline_messaging_context
smbpasswd does not use POPT_CREDENTIALS. Call cmdline_messaging_context
to initialize a messaging_context with proper error checking before
calling lp_load_global.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 29fd2c2e5ad3c2d44f3629c6b7b4139772fe350c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/55886f7855a6d4b6e9edafce3598f3187a0f0b0a">55886f78</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-10-10T13:51:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbstatus: Use cmdline_messaging_context
Use cmdline_messaging_context to initialize a messaging context instead
of open coding the same steps.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit d7fa3815a83a50fd9e3d78cac0d5ef3eb79235e5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c2dd495aaac6c7ed3f426c5682b8df4502f21400">c2dd495a</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-10-10T13:51:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpcclient: Use cmdline_messaging_context
Use cmdline_messaging_context with its error checking instead of open
coding the same steps.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit dd3ae2ffdc66be4707471bfccf27ef446b5599cb)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/79fe78828b505a0de730955972d7adffa10ee462">79fe7882</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-10-10T13:51:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:net: Use cmdline_messaging_context
Use cmdline_messaging_context with its error checking instead of open
coding the same steps.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit f2b659e4f518ccb06f221dd028f99883ca1a1847)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2e78c3a76ee7eec6d6b4663c8909e362c9815861">2e78c3a7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T13:51:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:messaging: remove unused messaging_init_client()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
(cherry picked from commit f56496b11469f0e9af9ba81cefb796ca1febabb1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/212a5bc620a4bc3ea668ea293d700346b94a242e">212a5bc6</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-10-10T13:51:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pdbedit: Use cmdline_messaging_context
Initialize the messaging context through cmdline_messaging_context to
allow access to config in clustered Samba.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 4661537c201acebee991d219d151cb481f56265c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4881ca3d72bf6660df9d319a66e2dba28dfa8ae0">4881ca3d</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-10-10T13:51:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:testparm: Use cmdline_messaging_context
Call cmdline_messaging_context to initialize a messaging config before
accessing clustered Samba config.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit ea7a4ff7ae5ef2b22fb7ef5640d6b946c064cfc3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b71c6d2c279eb195d6111f82b184e7482091f8c6">b71c6d2c</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-10-10T13:51:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:sharesec: Use cmdline_messaging_context
Call cmdline_messasging_context to initialize messaging context before
accessing clustered Samba config.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit cab8f27bbc927e48c52bac6350325e8ec38092b2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0442b1f938469917afdb020024af8859cb74c597">0442b1f9</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-10-10T13:51:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: ntlm_auth: Use cmdline_messaging_context
Call cmdline_messaging_context to initialize the messaging context
before accessing clustered Samba config.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 9ed617474f588ceb42c8929ee8a51071a408c219)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e39945075eec5e0f63636fa1edf67add0b94e780">e3994507</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-10-10T13:51:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:eventlogadm: Use cmdline_messaging_context
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 095123df945270bc51635a19125a7abdfcd4ab80)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/def7d7cee44ad557741111f936499942d70f9537">def7d7ce</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-10-10T13:51:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:dbwrap_tool: Use cmdline_messaging_context
Initialize the messaging context through cmdline_messaging_context to
allow access to config in clustered Samba.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 7eeff96b826711b5a8d44ab24603dafcc0343d84)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/217373b05d36afe3162fc64514580186114bc1db">217373b0</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-10-10T13:51:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbcontrol: Use cmdline_messaging_context
Initialize the messaging context through cmdline_messaging_context to
allow access to config in clustered Samba.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit de040eafbd7d729316d757c14c44df163a4b36ad)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2e602d77fef3cce94460926ddf0b70ab3b3b4b3f">2e602d77</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-10-10T13:51:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbget: Use cmdline_messaging_context
Initialize the messaging context through cmdline_messaging_context to
allow access to config in clustered Samba.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 20ed13923ed3c55e1b293e5440028d29384e9d3a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1131c14aed6f7c35f18dd06db2ec4476df2ea2f9">1131c14a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-10T13:51:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">examples: Fix the smb2mount build
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 94852e3544bf2cace3ddba8b9c89d986d77fdab5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b81cf0191eebd2e90f53157f187e9c6b7b7b1da1">b81cf019</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-10-10T13:51:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Prevent valgrind errors in smbtorture3 POSIX test.
Missing fsp talloc free and linked list delete in error
paths in close_directory(). Now matches close_normal_file()
and close_fake_file().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13633
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Sep 29 05:32:41 CEST 2018 on sn-devel-144
(cherry picked from commit 660dbfaeff493359474ebdb36098ac49b3f7ba0c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/75d97d491131c6ad895518677ca4bf539220e7f6">75d97d49</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-10T13:51:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Add invalid_records flag to ctdb_db_context
If a node becomes INACTIVE, then all the records in volatile databases
are invalidated. This avoids the need to include records from such
nodes during subsequent recovery after the node comes out INACTIVE state.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 71896fddf10a92237d332779ccbb26c059caa649)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0dffb5c7427c376b79fb673d369aca7d516044bf">0dffb5c7</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-10T13:51:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Don't pull any records if records are invalidated
This avoids unnecessary work during recovery to pull records from nodes
that were INACTIVE just before the recovery.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 040401ca3abfa266261130f6c5ae4e9718f19cd7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d8087c060389ff017c307f5e3249019bbabaa8f1">d8087c06</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-10T13:51:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Invalidate records if a node becomes INACTIVE
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit c4ec99b1d3f1c5bff83bf66e3fd64d45a8be7441)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e0071465b59d1f3c1bf60532ff2666927bf3c83">4e007146</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-10T13:51:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add recovery record resurrection test for volatile databases
Ensure that deleted records and vacuumed records are not resurrected
from recently inactive nodes.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit dcc9935995a5a7b40df64653a605d1af89075bd1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/485fa6b29eafbdc2c6937196bfffd68e0f274f40">485fa6b2</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-10T13:51:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-vacuum: Simplify the deletion of vacuumed records
The 3-phase deletion of vacuumed records was introduced to overcome
the problem of record(s) resurrection during recovery. This problem
is now handled by avoiding the records from recently INACTIVE nodes in
the recovery process.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 202b9027ba44eee33c2fde2332126be10f719423)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cbfb00bc44c966905b657aa6647408ba706da02d">cbfb00bc</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-10T13:51:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-vacuum: Fix the incorrect counting of remote errors
If a node fails to delete a record in TRY_DELETE_RECORDS control during
vacuuming, then it's possible that other nodes also may fail to delete a
record. So instead of deleting the record from RB tree on first failure,
keep track of the remote failures.
Update delete_list.remote_error and delete_list.left statistics only
once per record during the delete_record_traverse.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit ef052397173522ac2dd0d0bd9660a18a13a3e4fc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e209cfc43feaeaf2ad3b068a085791cf76001042">e209cfc4</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-10T13:51:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-vacuum: Remove unnecessary check for zero records in delete list
Since no records are deleted from RB tree during step 1, there is no
need for the check. Run step 2 unconditionally.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit e15cdc652d76b37c58cd114215f00500991bc6b4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6294ea4a519607333c05f679a4229dcad913f4f0">6294ea4a</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-10T13:51:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop implementation of RECEIVE_RECORDS control
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit d18385ea2aa93770996214d056a384a0244e7d73)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a1a679563bab8b7e715d9a52653b0e26bae0de34">a1a67956</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-10T13:51:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Mark RECEIVE_RECORDS control obsolete
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 81dae71fa74bfd83a5701e4841b5a0a13cbe87a1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0147504ff77cd4dd284242a8fa8a289aae0c4f12">0147504f</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-10T13:51:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Drop marshalling code for RECEIVE_RECORDS control
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 2f89bd96fb6c5e50cfc09604ceb6b96a94cb4f56)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/07c97238bc7bf3e7ac02c8159b9599d938f5a7fc">07c97238</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-10T13:51:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop code for RECEIVE_RECORDS control
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 83b3c5670d85c607c1cf1ab8cfc2c967d4d16721)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8657e558a2edc65e7a05f7bf4c0896a70845b36b">8657e558</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-10T13:51:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: split smb2.session.expire{1,2} to run with signing and encryptpion
This reproduces the problem we have with expired encrypted sessions.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13624
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 01b868455c9bae309d1ca7ddad54077fc5d7f4b1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/33515c39b316c5658cd23b7ed0d24c5a83bba15d">33515c39</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-10T13:51:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb2_server: set req->do_encryption = true earlier
The STATUS_SESSION_EXPIRED error was returned unencrypted,
if the request was encrypted.
If clients use SMB3 encryption and the kerberos authenticated session
expires, clients disconnect the connection instead of doing a reauthentication.
>From https://blogs.msdn.microsoft.com/openspecification/2012/10/05/encryption-in-smb-3-0-a-protocol-perspective/
The sender encrypts the message if any of the following conditions is
satisfied:
- If the sender is sending a response to an encrypted request.
- If Session.EncryptData is TRUE and the request or response being
sent is not NEGOTIATE.
- If Session.EncryptData is FALSE, the request or response being sent
is not NEGOTIATE or SESSION_SETUP or TREE_CONNECT, and
<TreeConnect|Share>.EncryptData is TRUE.
[MS-SMB2] 3.3.4.1.4 Encrypting the Message
If Connection.Dialect belongs to the SMB 3.x dialect family and
Connection.ClientCapabilities includes the SMB2_GLOBAL_CAP_ENCRYPTION
bit, the server MUST encrypt the message before sending, if any of the
following conditions are satisfied:
- If the message being sent is any response to a client request for which
Request.IsEncrypted is TRUE.
- If Session.EncryptData is TRUE and the response being sent is not
SMB2_NEGOTIATE or SMB2 SESSION_SETUP.
- If Session.EncryptData is FALSE, the response being sent is not
SMB2_NEGOTIATE or SMB2 SESSION_SETUP or SMB2 TREE_CONNECT, and
Share.EncryptData for the share associated with the TreeId in the SMB2
header of the response is TRUE.
The server MUST encrypt the message as specified in section 3.1.4.3,
before sending it to the client.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13624
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Oct 2 14:11:30 CEST 2018 on sn-devel-144
(cherry picked from commit 4ef45e5334d5874f5d0fdc69286b745ebcdc612d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a1a4e54cf0ee5c753425fbf7c3b1f78e98ed78c0">a1a4e54c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-10T16:57:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Avoid the use of open_memstream in tevent_req_profile_string
Solaris does not have it.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13629
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit e7d3678ddb5916416193d553f3cc562627e7d8ab)
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Wed Oct 10 18:57:59 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4772ba81be2bd7f7c01907758bf89427027ee7ed">4772ba81</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: FinderInfo conversion test with AppleDouble without xattr data
This testcase demonstrates that the AppleDouble conversion in vfs_fruit
doesn't correctly convert the FinderInfo data from the AppleDouble file
to a stream.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 8b9728480f6ab22da0831400796f3c39ec543df8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b2759221039da901eb39f1707413e3f70af4973b">b2759221</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: fix two comments
Thanks to the recent addition of ad_convert_xattr() we now correctly
handle this case.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 7e010abbaad79643f31361de47340c218fa39505)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6ee5df28cb354496a0da2b54576d97c5cfa52864">6ee5df28</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: store filler bytes from AppleDouble file header in struct adouble
This can later be used to distinguish between macOS created AppleDouble
files and AppleDouble files created by Samba or Netatalk.
macOS: "Mac OS X "
Samba: "Netatalk "
Netatalk: "Netatalk "
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 8ee7e6135e39520f486e8f8f4ba36009c9113229)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9426833a87dce1f5b559e1d9db4c8bd97a961af">a9426833</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: move setting ADEID_FINDERI length to ad_convert_xattr()
ad_convert_xattr() does the conversion of the xattr data in the
AppleDouble file, so we should update it's size there and should not
defer it to the caller.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit d161e047710322491802d75f47598f96727cd004)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f1090976484d5d491080bd52063080557ea68ce1">f1090976</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: do direct return from error checks in ad_convert()
Subsequent commits will move the mmap() into the subfunctions. This
change just prepares for that.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 8bc36d723ff41afe768f42b833aa951e1ee8fb38)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4679371f8c1aaa227636cb6ed8f45e4b551ef285">4679371f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: remove unneeded fd argument from ad_convert()
Use the struct adouble member ad_fd instead of passing it as an
argument. Who did that in the first place? :)
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 99cc9ef82b50b57149f71a40d4b22a3fc32a5a97)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/10232d0da022e6387426b865759eaf002f8d5272">10232d0d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: move storing of modified struct adouble to ad_convert()
ad_convert() modified it, so let ad_convert() also save it to disk. No
change in behaviour.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit b355a09576563d0f681d0bf830d0e2c769533399)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fb345c2b36405eed944a9a444dbf6a7b9b5967dd">fb345c2b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: move FinderInfo conversion to helper function and call it from ad_convert()
No change in behaviour.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit d27d0326c3c8cb6d217e6c8056fae2c98ef82803)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/50dfdfac17739631f6fd1c5f99a9eea82d41e97f">50dfdfac</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: move FinderInfo lenght check to ad_convert()
The final step in consolidating all conversion related work in
ad_convert(). No change in behaviour.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 4f1174b6eb2257d789a1eb9c925ccc561bab2f16)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d9c79bedd95b73a67a51145a7ef7d571d6e786f1">d9c79bed</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: split out truncating from ad_convert()
This may look a little ill-advised as this increases line count, but
the goal here is modularizing ad_convert() itself and making it as slick
as possible helps achieving that goal.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 98bd7c0a46f72b097011a5c59e899ac4862ff651)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c65198980ceddc1f57652a7921b223551bffc5a5">c6519898</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: use ADEDOFF_RFORK_DOT_UND offset macro in ad_convert_truncate()
We really want the fixed size offset here, not a calculated one. Note
that "ad_getentryoff(ad, ADEID_RFORK)" is equal to ADEDOFF_RFORK_DOT_UND
in this case.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit b948681b2bbaba202843858857fb9edbb543bdf2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b228d661362f976a469662a83eaed28a6d7105bf">b228d661</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: split out moving of the resource fork
No change in behaviour.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 4c7e1de46f4287818ef525c8939029ccb09adf65)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/393a773ad374eff1533429f1cdd4a124fe54cac2">393a773a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: use ADEDOFF_RFORK_DOT_UND offset macro in ad_convert_move_reso()
We really want the fixed size offset here, not a calculated one. Note
that "ad_getentryoff(ad, ADEID_FINDERI) + ADEDLEN_FINDERI" is equal to
ADEDOFF_RFORK_DOT_UND.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 93b7e0562159eae40e196f6be8d82283f0be2888)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/84374fbb3983deb371da27967dede672ec963d5b">84374fbb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: fix error returns in ad_convert_xattr()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit f91e0c857a5a44a5eab7696fafda758044739978)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/655e147cd9be5aba993a1d213f9dda16b6df1aec">655e147c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: let the ad_convert_*() subfunctions mmap as needed
This may mean that we mmap twice when we convert an AppleDouble file,
but this is the only sane way to cleanly modularize ad_convert().
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 918c6c59901d0bf939dcc178b661b6ae8201e903)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/548004896a50af01f5c7c57a32f762310c55bbf2">54800489</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: let the ad_convert_*() subfunction update the on-disk AppleDoube header as needed
Another step in simplifying ad_convert() itself. It means that we may
write to disk twice, but is only ever done once per AppleDouble file.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 1692ca5fd8ae2560dae6828f3c5c05a65c530726)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bee12e2e14041118048ac1788e0e2f0eda7b7fbd">bee12e2e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: call ad_convert_move_reso() from ad_convert_xattr()
ad_convert_xattr() is the place that triggers the need to move the
resource fork, so it should also call ad_convert_move_reso().
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 70d3ae5a89fc62db192c44b92a5b7fb67a93d88e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0807a89698963e402cc71c1ecce5a693ef4c0885">0807a896</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: add check for OS X filler in FinderInfo conversion
This ensures that the function only acts on AppleDouble files created by
macOS and not AppleDouble files created by us that are already in the
correct format (only using the Resource Fork).
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 5598e6bc3583a88f474afa2996d1f9362d1bd9fb)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/01353f6d2829ca67e3a16312d77967ce16ef4eaa">01353f6d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: add out arg "converted_xattr" to ad_convert_xattr
Used to let the caller know if a conversion has been done. Currently not
used in the caller, that comes next.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit acb72c1ea7fecc9a7e8eb0219096b1bbdfd8850e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9304dfae00abe593fb5bc2815311437159b5072d">9304dfae</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T10:59:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: make call to ad_convert_truncate() optional
Call ad_convert_truncate() based on whether the previous call
ad_convert_xattr() returned converted_xattr=true.
Upcoming fixes for a different Samba bug (#13642) will hook into calling
ad_convert_truncate() in other cases, this also prepares for that.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 9cf087a474bb2d7d29ca0daeaef412f6b545d0e0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/21e3e8b3cee9f48de0659e14135136ee3c1e7faf">21e3e8b3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-18T14:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: move check in ad_convert() to ad_convert_*() subfunctions
Currently the whole conversion is skipped if the FinderInfo entry in the
AppleDouble file is of the default size (ie not containing xattrs).
That also means we never converted FinderInfo from the AppleDouble file
to stream format. This change finally fixes this.
Note that this keeps failing with streams_depot, much like the existing
known-fail of "samba3.vfs.fruit streams_depot.OS X AppleDouble file
conversion". Fixing the conversion to work with vfs_streams_depot is a
task for another day.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Oct 11 01:30:13 CEST 2018 on sn-devel-144
(cherry picked from commit 31daab88e6a415e72ead69844e3eccf5dc02e53c)
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Thu Oct 18 16:16:16 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0cf64bd2ea8c989d83fdcddf4dd77ca72f015461">0cf64bd2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-24T11:59:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd_cache: Fix timeout calculation for sid<->name cache
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13662
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit fb573c682353daf5b343b6a0f4832dcbc96ebc57)
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Wed Oct 24 13:59:02 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a835e64f2e76837d9da2c51c1612e485f0b9047b">a835e64f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-25T05:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Return early when refusing to run an event script
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13659
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit a3d12252fa8e0a7e900b819dec30bdb9da458254)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1616cbd522c05355394064426d7947cba72dc7ec">1616cbd5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-25T05:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Exit if eventd goes away
ctdbd enters a broken state if eventd goes away. A clean shutdown is
not possible because that involves running events. Restarting eventd
is possible but this might mask a serious problem and it is possible
that eventd might keep on disappearing. Just exit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13659
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit c9e1603a5d0c1a216439d4a2b0e7cdc05181e898)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ec028efc66c454d5ee675b2cda21046af016c98c">ec028efc</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-25T05:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Set close-on-exec for startup fd
The startup_fd should not be propagated to the child processes created
from a daemon. It should only be used in the daemon code to return the
status of the startup. Another use of startup_fd is to notify the
parent if the daemon process has exited.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13659
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 80549927bc1741a4b8af8b8e830de4d37fa0c4a8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c3179a1db28fe34527cb34afaf479e8457e16649">c3179a1d</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-25T05:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Check the return status of sock_daemon_set_startup_fd
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13659
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit a1909603808b994b7822b697494e39e8da4aaa66)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6c44382e5fa889fb13085075755a7aa245ffff03">6c44382e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-25T09:05:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Fix valgrind hit in event code
==25741== Syscall param write(buf) points to uninitialised byte(s)
==25741== at 0x4939291: write (write.c:27)
==25741== by 0x4868285: sys_write (sys_rw.c:68)
==25741== by 0x13915D: sock_queue_trigger (sock_io.c:316)
==25741== by 0x4DE6478: tevent_common_invoke_immediate_handler (in /usr/lib/x86_64-linux-gnu/libtevent.so.0.9.37)
==25741== by 0x4DE64A2: tevent_common_loop_immediate (in /usr/lib/x86_64-linux-gnu/libtevent.so.0.9.37)
==25741== by 0x4DEBE5A: ??? (in /usr/lib/x86_64-linux-gnu/libtevent.so.0.9.37)
==25741== by 0x4DEA2D6: ??? (in /usr/lib/x86_64-linux-gnu/libtevent.so.0.9.37)
==25741== by 0x4DE57E3: _tevent_loop_once (in /usr/lib/x86_64-linux-gnu/libtevent.so.0.9.37)
==25741== by 0x15D1BA: ctdb_event_script_args (eventscript.c:821)
==25741== by 0x13B437: ctdb_start_daemon (ctdb_daemon.c:1315)
==25741== by 0x110642: main (ctdbd.c:393)
==25741== Address 0x57888a4 is 100 bytes inside a block of size 144 alloc'd
==25741== at 0x48357BF: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==25741== by 0x4B9B7C0: talloc_named_const (in /usr/lib/x86_64-linux-gnu/libtalloc.so.2.1.14)
==25741== by 0x15CCC6: eventd_client_write (eventscript.c:430)
==25741== by 0x15CCC6: eventd_client_run (eventscript.c:556)
==25741== by 0x15CCC6: ctdb_event_script_run (eventscript.c:649)
==25741== by 0x15D198: ctdb_event_script_args (eventscript.c:812)
==25741== by 0x13B437: ctdb_start_daemon (ctdb_daemon.c:1315)
==25741== by 0x110642: main (ctdbd.c:393)
==25741==
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13659
Pair-programmed-with: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon Oct 22 09:27:15 CEST 2018 on sn-devel-144
(cherry picked from commit fbea9d36996f248ba2b077f12ad16c199b853134)
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Thu Oct 25 11:05:48 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f70610968c1948bbe8498166c5d6f18f80d47ba">7f706109</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-01T16:14:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Changelog for previous changes
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/daa4d0f558aed843a75ca03a6a47f9ee9b82ffb0">daa4d0f5</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-01T20:14:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Upload 2:4.9.1+dfsg-2 to unstable
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1e7520f4e50ab369769d11b7d65a3752d6aeeda5">1e7520f4</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-05T11:44:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Add --site option when restoring a domain
Restoring a backup only worked if the Default-First-Site-Name site was
still present. When the new restored DC account is created, it was
trying to add the new server's DN under CN=Default-First-Site-Name.
However, if the original domain was setup using a different site, then
the restore would fail because the DN didn't exist.
When running the restore command, you should be able to specify the
site that you want the new/restored DC to be in (same as during a
DC 'join'). Passing the correct --site argument is one way to avoid
this problem. (A subsequent patch will further improve the tool so it
can work around non-default sites automatically).
Note we also need to pass the site through to where the new DNS entries
get registered (in the rename case).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit e1f255a4d54b59924295ea875fdef62ccebb8811)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c077dfaa6066ea0131ff50e514759fbdbba311cb">c077dfaa</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-05T11:44:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add test-case for restore into non-default site
Add a test-case that exercises the new '--site' restore option and
ensures the restored DC gets added to the correct site.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit ad69aaf7e13435111fc990954ff0bc81ed5325c5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dfc07455c2a31988012d6369107bf44efd0f8354">dfc07455</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-05T11:44:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Re-create default site for backup-restore (if missing)
Normally when a new DC joins a domain, samba-tool works out the new
DC's site automatically. However, it does this by querying the existing
DC using CLDAP. In the restore case, there is no DC running. We could
still query the DB on disk and work out the correct site based on the
new DC's IP, however:
- comparing between the CN=Subnet DNs and an IP-address string seems
like it'd be non-trivial to write, and
- in the lab-domain rename case, chances are the user will want a
completely different subnet to what's already in the DB.
The restore command now has a --site option so the user can specify an
appropriate site for the restored DC. This patch makes the restore
command work by default (i.e. without a --site option) even if the
default Default-First-Site-Name doesn't exist. Basically the solution is
to just check Default-First-Site-Name exists and create it if it
doesn't. As the recommended workflow is to use the restored DC as a
temporary seed that you'll later throw away, this approach seems
acceptable. Subsequent DCs will then be joined to the running restored
DC, so an appropriate site will be determined using CLDAP. The only
side-effect is potentially an extra Site object.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit ce57a800c9bed7e6876cdc0baf3a2d5fdc879ecf)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4933bc841a17bca79cbf5aac2e6baad1343ba528">4933bc84</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-05T11:44:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Change backup testenvs to use non-default site
Previously (i.e. up until the last patch) the backup/restore commands
only worked if the Default-First-Site-Name site was present. If this
site didn't exist, then the various restore testenvs would fail to
start. This is now fixed, but this patch changes the backupfrom testenv
so that it uses a non-default site. This will detect the problem if it
is ever re-introduced.
To do this we need to change provision_ad_dc() so the
extra_provision_options can be specified as an argument. (Note that Perl
treats undef the same as an empty array).
By default, the restore will add the new DC into the
Default-First-Site-Name site. This means the backupfromdc and restored
testenvs will now have different sites, so we need to update the ldapcmp
filters to exclude site-specific attributes.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 696fa6a1e6c615a992a3016ff32405b864b62eec)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/db233146d55af15b09e4ca99c04e8e7c78945a04">db233146</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-11-05T11:44:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Allow forced signing via smb.SMB()
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 4c7348e44d10ca519dd1322fd40b12c69e17a8e6)
Back-ported as a dependency required for:
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d3be8e21e66f98dce8c4989b01159e6099cf7ee4">d3be8e21</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-05T11:44:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Make sure SMB connection is signed when backing up sysvol
i.e. protect the client against man-in-the-middle attacks by default.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 0122f45f053ecc545950c31bf1fb33fba143478c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4b42e0ee4c19f042c27e786d28ee5465e00c8a4c">4b42e0ee</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-05T11:44:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: Server responds incorrectly if no SMB protocol chosen
The SMBnegprot response from the server contains the DialectIndex of the
selected protocol from the client's request message. Currently, if no
protocol is selected, the server is responding with a DialectIndex=zero,
which is a valid index (PROTOCOL_CORE by default). The Windows spec, and
historically the code, should return DialectIndex=0xffff if no protocol
is chosen. The following commit changed it recently (presumably
inadvertently), so that it now returns DialectIndex=zero.
06940155f315529c5b5 s3:smbd: Fix size types in reply_negprot()
This results in somewhat confusing error messages on the client side:
ERROR(runtime): uncaught exception - (3221225997, 'The transport
connection has been reset.')
or, when signing is configured as mandatory:
smbXcli_negprot: SMB signing is mandatory and the selected protocol
level (1) doesn't support it.
ERROR(runtime): uncaught exception - (3221225506, '{Access Denied} A
process has requested access to an object but has not been granted those
access rights.')
This patch restores the old behaviour of returning 0xffff.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621
Pair-Programmed-With: Ralph Boehme <slow@samba.org>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 378706266496ce79c1887fe96ab3b15f56770244)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5e4e3daad5a906127c332516508ce4fc3de1ab18">5e4e3daa</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-05T11:44:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: Add debug message if fail to negoatiate SMB protocol
Currently if the client and server can't negotiate an SMB protocol, you
just get the followiing error on the client-side, which doesn't tell you
much.
ERROR(runtime): uncaught exception - (3221225667, 'The network responded
incorrectly.')
This patch adds a debug message to help highlight what's actually going
wrong.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Sep 28 11:25:29 CEST 2018 on sn-devel-144
(cherry picked from commit 34cbd89fec836f5de0cb5ba3f289b1f4ae00c5d7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/24a02a31b5c2506fbbdfeec4ab773e433088a108">24a02a31</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-05T11:44:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add corner-case test: fromServer points to dead server
The fromServer attribute is slightly unique, in that it's a DN (similar
to a one-way link), but it is also a mandatory attribute.
Currently, if fromServer gets a bad value (i.e. a dead server that has
been expunged), the DSDB rejects any attempts to modify the associated
nTDSConnection object (regardless of whether or not you're actually
changing the fromServer attribute).
This patch adds a test-case that demonstrates how the DB can get into
such a state.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
(cherry picked from commit dec3eda1f74f5bf7ea91c1be3d5dfd832e9672b9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/40533f0552f243d5478b63b78c8bfc762701100b">40533f05</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-11-05T11:44:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Ensure that a DN (now) pointing at a deleted object counts for objectclass-based MUST
Add the 'reveal_internals' controls when performing objectclass-based
checks of mandatory attributes. This prevents the extended_dn DSDB
module from suppressing attributes that point to deleted (i.e.
non-existent/expunged) objects.
This ensures that, when modifying an object (and often not even
touching the mandatory attribute) that the fact that an attribute is a
DN, and the DN target is deleted, that the schema check will still pass.
Otherwise a fromServer pointing at a dead server can cause failures,
i.e. you can't modify the affected object at all, because the DSDB
thinks a mandatory attribute is missing.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
(cherry picked from commit 4092b369aeeb7058d78b8d6f41dbbc6d69203ecc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4b461cd3133d5826cd7e2017543176a35c39de3a">4b461cd3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-05T11:44:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: remove check for number of xattrs from ad_convert_xattr
Turns out that there exist AppleDouble files with an extended FinderInfo
entry that includes the xattr marshall buffer, but the count of xattrs
in the buffer is just zero.
We do want to discard this extended FinderInfo entry and convert it to a
simple fixed size FinderInfo entry, so remove the check.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 5d565f636fcf49fc1bbbfbc24ef730d2f7cc2cf0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0103f91d8b0acd58598689dbd3f8a831ab2ef02e">0103f91d</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-11-05T11:44:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:socket: If returning early, set ifaces
Prevents a segfault in load_interfaces() when total interfaces == 1.
Fixes regression caused by da68a1b2f417ec82ea4ed3e7a4d867cef8ca8f93.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13665
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Ralph Böhme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sun Oct 28 00:35:35 CEST 2018 on sn-devel-144
(cherry picked from commit 5391e21dea3168691cee1e6ef6c5959e46d62d1e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bedb34a617bfd4255af6072232fb031083355bfd">bedb34a6</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-05T11:44:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Check return code of initialize_password_db()
See https://retrace.fedoraproject.org/faf/reports/1577174/
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13668
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit ba17cae4cab686b8d018c39d16706e621f9f93ac)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e1f09ff387686c88a286804c70dfba6fb8bc7e43">e1f09ff3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-05T11:44:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs:vfs_fruit: add "wipe_intentionally_left_blank_rfork" option
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13642
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit f7a98094f05dd4b9abf5dc9704222aa5a07584d4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b04e558fffcf338c09fa1d06dcbfa18ac2153fe">7b04e558</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-05T11:44:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs:vfs_fruit: add "delete_empty_adfiles" option
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13642
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 2a9574b138f620e0a65cd61a957b99653c8dcd78)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/66aaa6ae1d7e5a69fc921f8ea338d44eaa5b1367">66aaa6ae</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-05T11:44:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:selftest: list vfs testssuites one per line
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13642
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit c3a1f3ec9ba2402de2a876ca06086b2d53e122f0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8a4f9233981f5e3e674d6917e98bec9ae3399d8">f8a4f923</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-05T11:44:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: add test for AppleDouble ResourceFork conversion
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13642
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 6f022e61597994bc032e61876f24150d7acb3fc2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a56be105ba9da08917b38f624a6392b8d58e9bd">4a56be10</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-05T11:44:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: add option "wipe_intentionally_left_blank_rfork"
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13642
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 2dbb2d287399e9c829a4fd4908a6dfba9fdfd7e8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/902202155fa73def59cb00baae5645c9df95052e">90220215</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-05T11:44:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: detect empty resource forks in ad_convert()
For some reason the macOS client often writes AppleDouble files with a
non-zero sized resource fork, but the resource fork data is just
boilerplate data with the following string close to the start
This resource fork intentionally left blank
A dump with apple_dump looks like this:
Entry ID : 00000002 : Resource Fork
Offset : 00000052 : 82
Length : 0000011E : 286
-RAW DUMP--: 0 1 2 3 4 5 6 7 8 9 A B C D E F : (ASCII)
00000000 : 00 00 01 00 00 00 01 00 00 00 00 00 00 00 00 1E : ................
00000010 : 54 68 69 73 20 72 65 73 6F 75 72 63 65 20 66 6F : This resource fo
00000020 : 72 6B 20 69 6E 74 65 6E 74 69 6F 6E 61 6C 6C 79 : rk intentionally
00000030 : 20 6C 65 66 74 20 62 6C 61 6E 6B 20 20 20 00 00 : left blank ..
00000040 : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
00000050 : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
00000060 : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
00000070 : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
00000080 : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
00000090 : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
000000A0 : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
000000B0 : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
000000C0 : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
000000D0 : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
000000E0 : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
000000F0 : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
00000100 : 00 00 01 00 00 00 01 00 00 00 00 00 00 00 00 1E : ................
00000110 : 00 00 00 00 00 00 00 00 00 1C 00 1E FF FF : ..............
We can safely discard this Resource Fork data.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13642
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 7be979f958295474f0c0df6a4db0b5bca9a6676d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a457df1fbfa32b78ad46dc93c38ab3a4fc1a493">6a457df1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-05T11:44:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: add option "delete_empty_adfiles"
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13642
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit e00e61345ccd88022cd24e62ac29e2c56a8f6117)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/69fb6c1c8b37b7964a66d5d63693f22e4096eecc">69fb6c1c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-05T11:44:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: optionally delete AppleDouble files without Resourcefork data
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13642
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 3649f1a41a299b14609318ef52b44e2d53cba4b5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eadd15a5a03e3994c2ebc218f6f70c2f72f63d40">eadd15a5</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-05T11:44:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">schema_samba4.ldif: add allocation of DSDB_CONTROL_DBCHECK_FIX_LINK_DN_NAME
This was already allocated in source4/dsdb/samdb/samdb.h with
commit 22208f52e6096fbe9413b8ff339d9446851e0874.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 0189f23f5bda263c7462366ee16b2fe4bcda0119)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2d682e4ced7f5041418b892b525b2cb5142f1fec">2d682e4c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-05T11:44:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:dsdb: fix comment on DSDB_CONTROL_DBCHECK_FIX_LINK_DN_NAME
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 60131b4452d43b3792e7f27a4190c88e7aabb1b4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3fb4c6846b9ccf116fd8ae794e4eacbf517e2251">3fb4c684</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-05T11:44:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs/blackbox: add samba4.blackbox.test_primary_group test
This demonstrates the bug, that happens when the primaryGroupID
of a user is changed.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 364ed537e0bcb3a97cae0f2d1ff72de9423ce0e6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c73aca88b5357f774ab199dd0a62379eda9a7c17">c73aca88</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-05T11:44:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:dsdb: add DSDB_CONTROL_DBCHECK_FIX_LINK_DN_SID oid
This will be used to fix missing <SID=> components in future.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit bb9c9e49a5e82f19626cb1b12ec9189fff5114e8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ea9b694dd9a0c1b22a6b2832b3be9836d7526835">ea9b694d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-05T11:44:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbchecker: improve verbose output of do_modify()
This makes it easier to debug dbcheck problems.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit c5c99b569569ce36cac94e967ca53e3182abd6f7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4da901d10cd5067c09b6b94adf2dc0bcaab7c72a">4da901d1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-05T11:44:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbchecker: Fix missing <SID=...> on linked attributes
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit a801799ebe26780653f4ed3fa3fc633e31871f7d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2d77e4f1034831c06ab33cede55e6b14945c3b22">2d77e4f1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-05T11:44:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">blackbox/dbcheck-links: Test broken links with missing <SID=...> on linked attributes
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit f81771c8593327e058b9cb4330d7e77083df3ea9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9d760fe15528506fb1f318ca778a21215de56692">9d760fe1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-05T11:44:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:repl_meta_data: pass down struct replmd_replicated_request to replmd_modify_handle_linked_attribs()
This will simplify further changes.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 966c7febaf0245516481bde924ea6cd738eeb78b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/98f2319bda254b7664c80f6ceb9ef5e7b2fc8e7a">98f2319b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-05T11:44:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:repl_meta_data: pass down struct replmd_replicated_request to replmd_modify_la_add()
This will simplify further changes.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 42e69a86ca583e3cb20c63b9c6930b4b3425485d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8095ffec94ecd978a642fd722af87e7a2137df13">8095ffec</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-05T11:44:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:repl_meta_data: add missing \n to a DEBUG message in replmd_modify_la_add()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 70a306d0bd6806d1fd00d45e3d8cc70c73d09f79)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fcafbe75cd83f37d8db5523267e1e5404aee4e88">fcafbe75</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-05T11:44:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:repl_meta_data: pass down struct replmd_replicated_request to replmd_modify_la_delete()
This will simplify further changes.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 738b52eb0856c8fcdbb8589e8061bcc14700c23a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/66169416c4b3d2f64a1134dc1b3cf9937348a9af">66169416</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-05T11:44:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:repl_meta_data: pass down struct replmd_replicated_request to replmd_modify_la_replace()
This will simplify further changes.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 1ef145d9d72d847055f6aba8a0070b3e1cfdabbc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c9e0e43180aa098376a66ccdee57196530cb0e70">c9e0e431</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-05T11:44:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:repl_meta_data: add support for DSDB_CONTROL_DBCHECK_FIX_LINK_DN_SID
This will be used by dbcheck in the next commits.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 0386307e34097f5d9233c970983c7306d1705a87)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/556b2c8ecb3af36cb7adbea060ea0db30a29af60">556b2c8e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-05T11:44:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:samldb: internally use extended dns while changing the primaryGroupID field
This is important, otherwise we'll loose the <SID=> component of the
linked attribute.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 7a36cb30b716d56b84e894851c1a18e9eb3a0964)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d88db0d481d4434d6400035a225cbcb4cba11897">d88db0d4</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-11-05T11:44:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Add comments explaining the limitations of our current backlink behaviour
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Tim Beale <timbeale@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Oct 30 10:32:51 CET 2018 on sn-devel-144
(cherry picked from commit 852e1db12b0afa04a738c03bb2609c084fe96a7f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/339a86a6a0c6285e34848621a338b794581ec35e">339a86a6</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-05T11:44:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/ldb: Test correct variable for no mem condition
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit d786e1fca95395e793867278bc0408e33c19908b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1f7757ef4eae87fbc8c35fd2bd5ba9e3e55124ce">1f7757ef</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-05T11:44:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/ldb/tests: add test for ldb.Dn passed utf8 unicode
object dn format should be a utf8 encoded string
Note: Currently this fails in python2 as the c python binding for
the dn string param uses PyArg_ParseTupleAndKeywords() with 's'
format, this will accept str *or* unicode in the default encoding.
The default encoding in python2 is... ascii.
Also adding here a knownfail to squash the error produced by the test.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit d1492ab919b19d1ca72f1d7c97ac0ca3bee13a2a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4908da4f518fbbafe9efc514f52534b1f8d854ec">4908da4f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-05T11:44:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/ldb: Ensure ldb.Dn can accept utf8 encoded unicode
Additionally remove the associated known fail.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13616
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit cddd54e8654c94dedd57c08af1987ce03212ce20)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c20b587a3bb2b339468fefd3f60c5ca85e1873c6">c20b587a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-05T11:44:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Bump ldb version to 1.4.3
* Python: Ensure ldb.Dn can accept utf8 encoded unicode (bug 13616)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13616
Signed-off-by: Noel Power <noel.power@suse.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/19e17ff2dd687c03d28e85d031333eb9c02e458a">19e17ff2</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-05T11:44:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python tests Blackbox: add random_password
Add the random_password method to the BlackboxTestCase class and remove
duplicated copies from other test cases. Also use SystemRandom so that
the generated passwords are more cryptographically sound.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit b6e45fb479689cff028b1fe626533b035e313ce3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0945b9babd7ac28f238b22a84b430589aab1d424">0945b9ba</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-05T11:44:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb encrypted_secrets tests: Allow "ldb://" in file path
When creating a new user and specifying the local file path of the
sam.ldb DB, it's possible to create an account that you can't actually
login with.
This commit contains tests to verify the bug.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13653
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit e1eee614ca8a3f0f5609a3d9d8ce7ae926de1f9e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b7bd1cdc3cf78efc3478333ee8da6fe6ede8a66">9b7bd1cd</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-05T11:44:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb encrypted_secrets: Allow "ldb:// and "mdb://" in file path
Correctly handle "ldb://" and "mdb://" schemes in the file path when
determining the path for the encrypted secrets key file.
When creating a new user and specifying the local file path of the
sam.ldb DB, it was possible to create an account that you could not
login with. The path for the key file was incorrectly calculated
for the "ldb://" and "mdb://" schemes, the scheme was not stripped from
the path and the subsequent open of the key file failed.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13653
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Oct 19 09:34:46 CEST 2018 on sn-devel-144
(cherry picked from commit 7b59cd74f9f75d85b91c6ca517d0243e7f6bd2e1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fd43fd88a8df96f8ad31159bd2ee13ef96a1d070">fd43fd88</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-05T11:44:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb group_audit: Test to replicate BUG 13664
The group audit code incorrectly logs member additions and deletions.
Thanks to metze for the debugging that isolated the issue, and for
suggesting the fix to dn_compare.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13664
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit eeb4089dafc45277d8af19073ef9348451c1836a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d06550108c119c7b79e30e9a6e17d19ed63e477">5d065501</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-05T11:44:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb group audit: align dn_compare with memcmp
Rename the parameter names and adjust the return codes from dn_compare
so that:
dn_compare(a, b) =>
LESS_THAN means a is less than b.
GREATER_THAN means a is greater than b.
Thanks to metze for suggesting the correct semantics for dn_compare
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13664
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 8420a4d0fddd71af608635a707ef20f37fa9b627)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a29074fd52f51156eb0d0a50cd55743430f80ef0">a29074fd</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-05T11:44:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb group audit tests: check_timestamp improve diagnostics
Change check_timestamp to display the expected, actual along with the
line and name of the failing test, rather than the line in
check_timestamp.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit e2970887140d558c6359fd9b3f8c2a4c26d2cf35)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/155433882adbf6908e8a125643234388b49279a0">15543388</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-05T11:44:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb group audit tests: check_version improve diagnostics
Change check_version to display the expected, actual along with the
line and name of the failing test, rather than the line in check_version
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit c952fc1273397c04fddf177bcd809551d6324bdd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a0a3ce5c2164b3c352598b28df22268161462c6c">a0a3ce5c</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-05T14:47:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb group audit tests: log_membership_changes extra tests
Add extra tests to ensure better test coverage of log_membership_changes
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit aeef8b41fa03a32859f824f4a09560ad83bd2b50)
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Mon Nov 5 15:47:40 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/786b6c79444d6e0fc1b78a0813fa651bc3426e3d">786b6c79</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: add smbXcli_req_endtime
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13667
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 94ad5ee662a5bfe1c79d8a9c3fcf51d0a1d652c7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7e99105948149d42e075db11de0fcdbce3c2e770">7e991059</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: fill endtime if smbXcli_req_create() timeout is non-zero
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13667
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit e7eec24d27b8694fd7626577a2aca05e99045964)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/82a7e00c086b4e8bf36f08db23c2a4899dcb4a48">82a7e00c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli/smb2: reapply request endtime
tevent_req_finish() removed a possible request timeout, make sure to
reinstall it. This happened when an interim SMB2 response was received.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13667
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit a6de555c51ca34ef24ac4b4cb672cd748d3197a1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6fa0ab1f439e4e8f68f4b7f057b91c0bdb7367b8">6fa0ab1f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_delay_inject: implement pread_send and pwrite_send
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13667
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 35f9bc06722fb07143c832442d784beb204bd367)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9bb62020255fabdb04fdc22996f3a142542e721">a9bb6202</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/smb2/read: add test for cancelling SMB aio
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13667
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit e37ff8c5fe18d400e378bf2591e209b30473d9f9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c1e441e69cfc7cbca8586da3c70f0088762bf5a3">c1e441e6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: fix SMB2 aio cancelling
As we currently don't attempt to cancel the internal aio request, we
must ignore the SMB2 cancel request and continue to process the SMB2
request, cf MS-SM2 3.3.5.16:
If the target request is not successfully canceled, processing of the
target request MUST continue and no response is sent to the cancel
request.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13667
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 07eb805cde4db6ac74740e3cfbc56ab6f8e2118a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d72319d5cfd360ea573a05e162410d56d73f92b4">d72319d5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: remove now unused check if fsp is NULL
This was used internally to mark an aio request as cancelled. As the aio
cancellation functionality has been removed, we can now also remove this
check.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13667
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 3fa45900c0ada6596daf09aa4c5054974f3394b0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53104cbc32bf633d18ce5cae3bcd16d74419fa72">53104cbc</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T08:11:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recovery: Ban a node that causes recovery failure
... instead of applying banning credits.
There have been a couple of cases where recovery repeatedly takes just
over 2 minutes to fail. Therefore, banning credits expire between
failures and a continuously problematic node is never banned,
resulting in endless recoveries. This is because it takes 2
applications of banning credits before a node is banned, which
generally involves 2 recovery failures.
The recovery helper makes up to 3 attempts to recover each database
during a single run. If a node causes 3 failures then this is really
equivalent to 3 recovery failures in the model that existed before the
recovery helper added retries. In that case the node would have been
banned after 2 failures.
So, instead of applying banning credits to the "most failing" node,
simply ban it directly from the recovery helper.
If multiple nodes are causing recovery failures then this can cause a
node to be banned more quickly than it might otherwise have been, even
pre-recovery-helper. However, 90 seconds (i.e. 3 failures) is a long
time to be in recovery, so banning earlier seems like the best
approach.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13670
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon Nov 5 06:52:33 CET 2018 on sn-devel-144
(cherry picked from commit 27df4f002a594dbb2f2a38afaccf3e22f19818e1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e03bdef32153215fe3d9075f1a3ab25e385647d9">e03bdef3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_streams_xattr: fix open implementation
Since a long time the modules's open function happily returned success
when opening a non existent stream without O_CREAT.
This change fixes it to return -1 and errno=ENOATTR if
o get_ea_value() returns NT_STATUS_NOT_FOUND (eg mapped from
getxattr() = -1, errno=ENOATTR) and
o flags doesn't contain O_CREAT
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 9f58997d7a1ab0358963a45cb8bf291e7afa8068)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd2a1d04c4436d7e5ad06212301ae898fe2a0659">dd2a1d04</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: skip a few tests when running against a macOS SMB server
These tests are designed to test specific vfs_fruit functionality.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 242f42ef79e51e35ab33331e2f2d7c9feaac36f8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/718317bdf3182fe68a65ad24d5e0ff2a904f0273">718317bd</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: fix a few error checks in "delete AFP_AfpInfo by writing all 0"
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 394d1fc9ac8373ea7419ea9514750422bd6e504d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7717809db47e55715d29e4173f4f76862544a693">7717809d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: set share_access to NTCREATEX_SHARE_ACCESS_MASK in check_stream_list
Avoid sharing conflicts with other opens on the basefile.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 1d4e50649b02c7c2314aa04e08f9946e21b6b37d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cca88421a5ddb207b60afa8c77c24089064b8119">cca88421</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: update test "SMB2/CREATE context AAPL" to work against macOS
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit dba9a4743fc42b57f03b6ace24753ce8091f629f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1e3f8a6fca6207d9a5c163f41dfea2d97187b2e6">1e3f8a6f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: update test "stream names" to work with macOS
o create the basefile before trying to create a stream on it, otherwise
this fails on macOS
o write something to the stream, otherwise the stream is not listed as
macOS hides 0-byte sized streams
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 125498861abeeed5bde727ff98d88d9ce4af6c75)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b5a4c3d6d3c4953c2757a58acb05e3d187627c9">8b5a4c3d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: ensure a directory handle is closed in all code paths
Otherwise we get a sharing violation when running against Samba and
opening the directory a second time.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit f7551d8fb3599a6a71dd0570bad02bdc48324107)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/756da49288f64f5de466a7647bcbc1c88b9f3434">756da492</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: update test "read open rsrc after rename" to work with macOS
macOS SMB server seems to return NT_STATUS_SHARING_VIOLATION in this
case while Windows 2016 returns NT_STATUS_ACCESS_DENIED.
Lets stick with the Windows error code for now in the Samba fileserver,
but let the test pass against macOS.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 9cd9859dc10d425d29774d221ec9ad697192b466)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/530c24f880693e4e76a39775108d66d62064b42d">530c24f8</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: expand existing test "setinfo delete-on-close AFP_AfpInfo" a little bit
Add a check that verifies a create on a stream gets
NT_STATUS_DELETE_PENDING after delete-on-close has been set.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 0d9a80b6b2e3f51cad122ee0dc78c2f4dfdebcb5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cc9956ef6f2f969b90e13aa5b8bf010ec010199a">cc9956ef</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: expand existing vfs_test "null afpinfo"
This adds a check that a read on a seperate handle also sees the
previously created AFP_AfpInfo stream.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 6f428607e35055b9ce1a04a625d43740bf5c76b2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/816651be1187c1cc36e6fb07a85cb901d247cadc">816651be</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: update test "creating rsrc with read-only access" for newer macOS versions
While this operation failed against older macOS versions, it passes
against versions 10.12 and newer. Update the test accordingly, a
subsequent commit will then update our implementation.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit c3cf09a0791ed4dfb7ca18d175396ac1aca5d2ed)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/abfc2110d8af8523a6a8b6bd4b7a570407b133b9">abfc2110</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: update handling of read-only creation of resource fork
macOS SMB server versions supports this since 10.12, so we adapt our
behaviour.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 055ca448f1a2bd995291af1810c9ec94f90f32dd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e2fe019762a0548c446a3588bc9f0c9e9559d1e7">e2fe0197</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: expand test "setinfo eof stream"
o Adds checks verifying that after setting eof to 0 on a stream, a
subsequent open gets ENOENT, before and after closing the handle that
had been used to set eof to 0.
o Verify that a write to a handle succeeds after that handle has been
used to set eof to 0 on a stream.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit b35d9e74028727da24f349242cb0bc62403a9b09)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/535abb333ef1dd67614d9eb7e0bf7e05420fdbfb">535abb33</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: write some data to a just created teststream
Doesn't currently make a difference, but this prepares for a later
change in vfs_fruit that will filter out empty streams (which is the
macOS behaviour).
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 3195ff9547824dd129e3fbcbbb8823fb10a0a5d4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a09f0a80589a7c362cb8aca6b3bd22e5318ec58d">a09f0a80</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: don't unlink 0-byte size truncated streams
This caused all sort of havoc with subsequent SMB request that acted on
the handle of the then deleted backend storage (file or blob, depending
on the used streams module).
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 287082d739362ad068df37076712927ccd7ca90c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/71d8b4a2f49274e1f7eca8ce6fbf7a3aa935e9ef">71d8b4a2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: enable AAPL extensions in a bunch of tests
These tests check for macOS SMB server specific behaviour. They work
currently against Samba without enabling AAPL because in vfs_fruit we're
currently don't check whether AAPL has been negotiated in one place. A
subsequent commit will change that and this commit prepares for that
change.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 7485007bb0a69dc8237c78be90f4bae06aad49b2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e8f1df015d6335aad02f846d39e86ef94eefdfb7">e8f1df01</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: use check on global_fruit_config.nego_aapl for macOS specific behaviour
Ensure any non MS compliant protocol behaviour targetted at supporting
macOS clients are only effective if the client negotiated AAPL.
Currently this only guards the resource fork which only macOS client are
going to use, but subsequent commits add more this at this place.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 046456fca60b9fef38a0cdf5a116883fb1c7dffe)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e03f36aac4587e0620a6e3d577c10c111f6137a1">e03f36aa</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: filter empty streams
First step in achieving macOS compliant behaviour wrt to empty streams:
- hide empty streams in streaminfo
- prevent opens of empty streams
This means that we may carry 0-byte sized streams in our streams
backend, but this shouldn't really hurt.
The previous attempt of deleting the streams when an SMB setinfo eof to
0 request came in, turned out be a road into desaster.
We could set delete-on-close on the stream, but that means we'd have to
check for it for every write on a stream and checking the
delete-on-close bits requires fetching the locking.tdb record, so this
is expensive and I'd like to avoid that overhead.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit ebfcf75e993b1a792db76b94aa898532e1c81eeb)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0a16d4fc03b903a536581fa15066860a4e0cbb90">0a16d4fc</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/util: add torture_smb2_open()
This seems to be missing: a simple wrapper to just open a file without
fancy options.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 64b28e4a94365092f46052712a38e6fcfbb9f20c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5076abb55072532e3cb31fdd38b51c4d1d329d93">5076abb5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: add check_stream_list_handle()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit aba502d440ae3478543d3be5c5bbcea39fb0a463)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/42a5dbdb461326b2e859004b46223e9f31fe8443">42a5dbdb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: add test "empty_stream"
One to rule them all: consistently test critical operations on all
streams relevant to macOS clients: the FinderInfo stream, the Resource
Fork stream and an arbitrary stream that macOS maps to xattrs when
written to on a macOS SMB server.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 9d8751db64de75a0de442365b317c1b9ce194170)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c8e1405c82f609dc77cb9c071f8b00c6a2524c0c">c8e1405c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: add some debugging of dev/ino
Aids in debugging dev/ino mismatch failures in open_file_ntcreate.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 993c7c4e711612225bd07b8fa5544c4bfef88a9e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c7ce8c871a15295a6a0a5195c6a165a925486467">c7ce8c87</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: remove resource fork special casing
Directly unlinking a file with open handles is not good, don't do it.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit a26032c3f68028b01fb6a7d38851409db1858161)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a57e29e38c0771f61cd6e6b3e9e2caad80d91113">a57e29e3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: add fio->created
fio->created tracks whether a create created a stream.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 1e055a79541eb69eb2deeae897dde3665c5ffee2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/44834da34b23aa92c8405b3433bc85c1e6fbc50b">44834da3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: prepare struct fio for fake-fd and on-demand opening
Not used for now, that comes in the subsequent commits.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 96320eccc9a63b793ff8d05842bce54f120286f9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a5b677d383b88072b789bb4c6ec0f590de0ab153">a5b677d3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: prepare fruit_pwrite_meta() for on-demand opening and writing
This avoid creating files or blobs in our streams backend when a client
creates a stream but hasn't written anything yet. This is the only sane
way to implement the following semantics:
* client 1: create stream "file:foo"
* client 2: open stream "file:foo"
The second operation of client 2 must fail with NT_STATUS_NOT_FOUND.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 4a5c9a9e73230f640eb045a3c47af75b5be9f1d6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c23f1da9ca37b5dae64350afab96b4e5f6a1fb0f">c23f1da9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: prepare fruit_pread_meta() for reading on fake-fd
If the read on the stream fails we may have hit a handle on a just
created stream (fio->created=true) with no data written yet.
If that's the case return an empty initialized FinderInfo blob.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit d7d92710711f6e555ed45c1dda528cd6a83e1bf5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d405dc3833b5100c1a39f24a86d45bf5030b63bb">d405dc38</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: do ino calculation
As we'll start returning fake fds in open shortly, we can't rely on the
next module to calculat correct inode numbers for streams and must take
over that responsibility.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 80afafe398566fd622f431966808d08ba9ec6473)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/029f64f9dc7febe7fd1d976a3f48a4249e0e1a3a">029f64f9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: let fruit handle all aio on the FinderInfo metadata stream
This will be required to support using fake fds for the FinderInfo
metadata stream.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 6fd256afcd5fedc894036efbfba1fc6d2264fba9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/27a5a834fafd9baf297558f2110c390fe424ff80">27a5a834</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: pass stream size to delete_invalid_meta_stream()
delete_invalid_meta_stream() is meant to guard against random data being
present in the FinderInfo stream. If the stream size is 0, it's likely a
freshly created stream where no data has been written to yet, so don't
delete it.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 6e13dbddaec9f8118e11309297f85c3cdfd22e43)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eacbfe94ae821d1ffa9e94eccd4cabb24ae21714">eacbfe94</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: let fruit_pwrite_meta_stream also ftruncate empty FinderInfo
fruit_streaminfo currently filters out the FinderInfo stream is
delete-on-close is set. We set it here internally, but the client may
also set it over SMB. Turns out that the macOS SMB server does NOT
filter out FinderInfo stream with delete-on-close set, so we must change
the way filtering is done in fruit_streaminfo.
Filtering is now done based on the FinderInfo stream being 0-bytes large which
is why I'm adding the ftruncate here.
No idea why the tests that check the filtering passed the commits
leading up to this one, but if you revert this commit after applying the
whole patchset, the "delete AFP_AfpInfo by writing all 0" test will fail.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 480695cd723cc4949e0b39ddb83560efac393412)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cf43b5dbb9489c6717fe7c90c4c2da940ad8e604">cf43b5db</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: don't check for delete-on-close on the FinderInfo stream
macOS SMB server doesn't filter out the FinderInfo stream if it has
delete-on-close set.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit d8c1bb52018289878b9397d513ebbae63933a05f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/73540974bc8fc03bb1860581449bd6509f36d3ad">73540974</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-06T08:11:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: let fruit_open_meta() with O_CREAT return a fake-fd
This is the final step in implementing the needed macOS semantics on the
FinderInfo stream: as long as the client hasn't written a non-zero
FinderInfo blob to the stream, there mustn't be a visible filesystem
entry for other openers.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Nov 1 01:14:23 CET 2018 on sn-devel-144
(cherry picked from commit 1b2de44ea8114cf2025e8b8c843131e2f2dbed27)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2dd3c3341a6f0fa577571955ed9ed24a6b63d5ac">2dd3c334</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-06T11:16:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Fix the clang build
It's used uninitialized if an early torture_assert fails
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Nov 1 17:34:31 CET 2018 on sn-devel-144
(cherry picked from commit 9b28d47b0d86570be5a7c5628e460e01207afb00)
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Tue Nov 6 12:16:07 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9603a098a16aabd01ce053a6b3119f757994e285">9603a098</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-11-07T07:42:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbtorture: Add test for DELETE_ON_CLOSE on files with READ_ONLY attribute
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13673
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit dc9bbbe4141d8425e66fe9290ff611845f4bd1ce)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/03518d2ff2cb8cf45052a3ddb710df2bf321881d">03518d2f</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-11-07T07:42:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix DELETE_ON_CLOSE behaviour on files with READ_ONLY attribute
MS-FSA states that a CREATE with FILE_DELETE_ON_CLOSE on an existing
file with READ_ONLY attribute has to return STATUS_CANNOT_DELETE. This
was missing in smbd as the check used the DOS attributes from the CREATE
instead of the DOS attributes on the existing file.
We need to handle the new file and existing file cases separately.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13673
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 162a5257c48f20d3752f644e86c9e626b46436c0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/380badf80fb5df41e8e0293a63f3508f92671d53">380badf8</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-11-07T07:42:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add share to test "delete readonly" option
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13673
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit a8e79decbcfbae1b1a53ec81b942ee06db26bf8f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1a3b20d0b33e020ea43f9a433767d998cb4a0ef8">1a3b20d0</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-11-07T10:44:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Run smb2.delete-on-close-perms also with "delete readonly = yes"
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13673
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Sat Nov 3 05:55:45 CET 2018 on sn-devel-144
(cherry picked from commit 7dd3585f9c3ae04df45d98bfdc62663c7a69d3e0)
Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-9-test): Wed Nov 7 11:44:24 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8c0389369efecff23d6ffa9fec9b10e62e7da0b">f8c03893</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-11-08T07:54:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.9.2.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/865cc283d1b2c7ae3cf504b541e5a36248291095">865cc283</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-11-08T07:55:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.9.2 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3ca272de0dcb302c9dc614c5d42e7de03fc1ac21">3ca272de</a></strong>
<div>
<span>by Salsa Pipeline Bot</span>
<i>at 2018-11-09T06:43:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Remove workaround for gitlab include
Gbp-Dch: Ignore
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c6c81b83d1d496badeba51ea67922e3f809658c">9c6c81b8</a></strong>
<div>
<span>by Salsa Pipeline Bot</span>
<i>at 2018-11-09T06:43:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update pipeline
Gbp-Dch: Ignore
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dc9a0d77f6da2e222323115dea3799d90c6697e6">dc9a0d77</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-10T13:21:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge branch 'salsa-ci-1541745824' into 'master'
Update salsa-ci pipeline
See merge request samba-team/samba!13</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0de87181e8746d17783883d068ce80d502721af3">0de87181</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-10T13:23:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci.yml: allow_failure for reprotest until #912340 is fixed</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/003fdfe6e62ac55e29ee2b10c01873dea1de64f9">003fdfe6</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-10T14:55:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge branch 'reprotest-allow_failure' into 'master'
gitlab-ci.yml: allow_failure for reprotest until #912340 is fixed
See merge request samba-team/samba!14</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/daedac997f73d5e647e10d3247032571bb8a0c30">daedac99</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-10T19:27:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">New upstream version 4.9.2+dfsg</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2c3b8f94cd8c4cb52767f75e786ca3d75fa6ddf8">2c3b8f94</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-10T19:31:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge tag 'upstream/4.9.2+dfsg'
Upstream version 4.9.2+dfsg
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8c1bd98589587e22e28c2195d7eca2c08c1c2b82">8c1bd985</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-10T19:43:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">d/rules: Replace override_dh_perl by override_dh_perl-arch (Closes: #913143)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a6fd7022b44367ccb1e3286daa273b646a6f6af">2a6fd702</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-10T19:43:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Changelog for previous commits
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c624d53379422d3065e9f7b884b74d1ee78a79cb">c624d533</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-10T19:45:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">d/changelog: Fix version
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/abfa44acb48a945d2c92d755807d5b59696e91dd">abfa44ac</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-10T19:47:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Release 2:4.9.2+dfsg-1
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/47e05bfd4fe7f566b4b68ca784548171f5b6b779">47e05bfd</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-11T05:23:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Bump build-dependencies to ldb 1.4.2
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2f8f4e887569389be08f040761ec69b4c9e03992">2f8f4e88</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-11T05:25:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Un-release 2:4.9.2+dfsg-1, and previous commits
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/90339259ca7a871df79c893f2acc2794de66df66">90339259</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-15T21:32:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update debian/samba-libs.install
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b430cb0551be91b1ffde8d5ca565966dbbda9f3f">b430cb05</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-15T21:32:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debian/gitlab-ci.yml: Samba sometimes needs ldb from experimental
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d18f28946f2e5be947537a3b236f39117c370817">d18f2894</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-16T06:03:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Use ldb from experimental in piuparts
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/055c1320ef61294fdd55588fd9846c3d08a234bb">055c1320</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-16T06:04:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add a pkg.samba.selftest build profile
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ffec52756aca3a06857e7238343ae933c313183d">ffec5275</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-16T06:10:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add "build selftest package" job to gitlab-ci.yml
</pre>
</li>
</ul>
<h4>30 changed files:</h4>
<ul>
<li class="file-stats">
<a href="#b33892fbddeffc3368077b4904ad0b3d562a7312">
VERSION
</a>
</li>
<li class="file-stats">
<a href="#3277e12b5a9f9ff632d229e2629d34ad21dd93fc">
WHATSNEW.txt
</a>
</li>
<li class="file-stats">
<a href="#717e4435bfe6c4ce86a7ac15a5461119235be37b">
buildtools/wafsamba/samba_autoconf.py
</a>
</li>
<li class="file-stats">
<a href="#5d6072a0ca09b121f9f444eb7654b7e202352b68">
ctdb/common/sock_daemon.c
</a>
</li>
<li class="file-stats">
<a href="#8e8a5d283a625a212d353a3a26a54db154a3cf50">
ctdb/common/sock_daemon.h
</a>
</li>
<li class="file-stats">
<a href="#7621aa1ce515b0afdaffdf0eca777ff6f439e31a">
ctdb/doc/ctdb-etcd.7
</a>
</li>
<li class="file-stats">
<a href="#5cbe2af7f9551bd8ba760b3978da68f98bcca8d1">
ctdb/doc/ctdb-script.options.5
</a>
</li>
<li class="file-stats">
<a href="#6f372b1da785e9b62534d3ddc2b1cc994e1edea1">
ctdb/doc/ctdb-statistics.7
</a>
</li>
<li class="file-stats">
<a href="#bff45f5b0a1ff6f2cac0546191f2199bad760297">
ctdb/doc/ctdb-tunables.7
</a>
</li>
<li class="file-stats">
<a href="#cf03e1c00a6ff50094bf342fee6dbac15b3a4e0f">
ctdb/doc/ctdb.1
</a>
</li>
<li class="file-stats">
<a href="#ab0737fb37c5f24c1a655306d7f3cf9b28970fa1">
ctdb/doc/ctdb.7
</a>
</li>
<li class="file-stats">
<a href="#355570170158b89f755ad8c2655ff1b55be32cfb">
ctdb/doc/ctdb.conf.5
</a>
</li>
<li class="file-stats">
<a href="#f3298e106280fd2e988e57b01b9f5697370b66b1">
ctdb/doc/ctdb.sysconfig.5
</a>
</li>
<li class="file-stats">
<a href="#027f7ec3db27f736464febdb40a2f5784278e923">
ctdb/doc/ctdb_diagnostics.1
</a>
</li>
<li class="file-stats">
<a href="#944489b6fed794d85434d7748c57ff12c56034db">
ctdb/doc/ctdb_mutex_ceph_rados_helper.7
</a>
</li>
<li class="file-stats">
<a href="#b3f02388c7b39adb49f0f55dbc87a0b75e7f21c3">
ctdb/doc/ctdbd.1
</a>
</li>
<li class="file-stats">
<a href="#2097dbfda6f5cb780a636fd916929b31054ddd8c">
ctdb/doc/ctdbd_wrapper.1
</a>
</li>
<li class="file-stats">
<a href="#1abbc4563e217dafc807f4824b2e10419a31fcf7">
ctdb/doc/ltdbtool.1
</a>
</li>
<li class="file-stats">
<a href="#0a2e2417e72340b1b7bea2f903aa804c91c6386b">
ctdb/doc/onnode.1
</a>
</li>
<li class="file-stats">
<a href="#cfbec512f592346951273f1f00fd0300153259f8">
ctdb/doc/ping_pong.1
</a>
</li>
<li class="file-stats">
<a href="#ad3a00b9ff0321b4c2fd56716434c7c3a9f53619">
ctdb/event/event_daemon.c
</a>
</li>
<li class="file-stats">
<a href="#5242d600f0c3a261d7c8ebdc01e94a869794cf03">
ctdb/include/ctdb_private.h
</a>
</li>
<li class="file-stats">
<a href="#e46d78be092b917953695e34e3db6d11159adda9">
ctdb/protocol/protocol.h
</a>
</li>
<li class="file-stats">
<a href="#7c0540b5f80f133970dc20e66f2eb370042a9de9">
ctdb/protocol/protocol_api.h
</a>
</li>
<li class="file-stats">
<a href="#54adf9696b7d7f672d9f8d4496c63a112647125b">
ctdb/protocol/protocol_client.c
</a>
</li>
<li class="file-stats">
<a href="#8c5060626731c2f9a32d68120bca697638e0a874">
ctdb/protocol/protocol_control.c
</a>
</li>
<li class="file-stats">
<a href="#7d7149480693865b55b7cff8b1ca975b1e08d0d0">
ctdb/server/ctdb_control.c
</a>
</li>
<li class="file-stats">
<a href="#b9970e9a7b4026606ab69a7fb713ea763ae9a9b4">
ctdb/server/ctdb_freeze.c
</a>
</li>
<li class="file-stats">
<a href="#a3cbe547a0df7bd5ac5b447381943f98f05d6baa">
ctdb/server/ctdb_recover.c
</a>
</li>
<li class="file-stats">
<a href="#9f46ce56bbee4ff3db03b05e0850dcc0ecb38013">
ctdb/server/ctdb_recovery_helper.c
</a>
</li>
</ul>
<h5>The diff was not included because it is too large.</h5>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777777;">
—
<br>
<a href="https://salsa.debian.org/samba-team/samba/compare/b7103ed48719096f240cbecb99409dbe15478658...ffec52756aca3a06857e7238343ae933c313183d">View it on GitLab</a>.
<br>
You're receiving this email because of your account on salsa.debian.org.
If you'd like to receive fewer emails, you can
adjust your notification settings.
</p>
</div>
</body>
</html>