<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<h3>
Mathieu Parent pushed to branch stretch
at <a href="https://salsa.debian.org/samba-team/samba">Debian Samba Team / samba</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3de773efc3cafeef164f6455f042ea2c941d81fd">3de773ef</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-12T11:41:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.5.13...
and re-enable GIT_SNAPSHOTS.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/911e3abdf362bfc6c8524c144bd35ba900383c6e">911e3abd</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-07-13T08:51:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: let non_widelink_open() chdir() to directories directly
If the caller passes O_DIRECTORY we just try to chdir() to smb_fname
directly, not to the parent directory.
The security check in check_reduced_name() will continue to work, but
this fixes the case of an open() for a previous version of a
subdirectory that contains snapshopt.
Eg:
[share]
path = /shares/test
vfs objects = shadow_copy2
shadow:snapdir = .snapshots
shadow:snapdirseverywhere = yes
Directory tree with fake snapshots:
$ tree -a /shares/test/
/shares/test/
├── dir
│ ├── file
│ └── .snapshots
│ └── @GMT-2017.07.04-04.30.12
│ └── file
├── dir2
│ └── file
├── file
├── .snapshots
│ └── @GMT-2001.01.01-00.00.00
│ ├── dir2
│ │ └── file
│ └── file
└── testfsctl.dat
./bin/smbclient -U slow%x //localhost/share -c 'ls @GMT-2017.07.04-04.30.12/dir/*'
NT_STATUS_OBJECT_NAME_NOT_FOUND listing \@GMT-2017.07.04-04.30.12\dir\*
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12885
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit b886a9443d49f6e27fa3863d87c9e24d12e62874)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2cae38b094e4b2e2dd5dbbb63a8f10245c1883c7">2cae38b0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-07-13T08:51:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: add a test for accessing previous version of directories with snapdirseverywhere
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12885
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Sat Jul 8 00:33:51 CEST 2017 on sn-devel-144
(cherry picked from commit cc9ba98c08665e0ed6927fd81fa43a7bb7842e45)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/82f9cbab3444c547d38ca1900464e48e449a73ab">82f9cbab</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: consistently use talloc_tos() memory for rpc_pipe_open_interface()
The result is only used temporary and should not be leaked on a long term
memory context as 'conn'.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12890
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 77cbced5d2f8bf65c8d02f5edfaba8cbad519d08)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3a491cd6ac12e37ce9e719a7b26a2eabee994f52">3a491cd6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_wrap: add smb_krb5_free_data_contents() compat define (for v4-5)
4.6 and higher have renamed kerberos_free_data_contents() into
smb_krb5_free_data_contents() in commit
e8632e2af50588dd47dc00fb72e85a398c844622.
But here we don't want to backport that commit,
while making it easy to backports patches from master.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/941aaa99ce058feda396b00042a67203d4e25ba4">941aaa99</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2017-07-13T08:51:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">werror: replace WERR_SETUP_NOT_JOINED with WERR_NERR_SETUPNOTJOINED in source3/libnet/libnet_join.c
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
(cherry picked from commit 3bb394f3d62aaeda5c71cf1d508a7b67fd6e742d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c8ae8360fe2de1faa99f5a98cd6a8882e73ad29">0c8ae836</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl:NDR/Parser: add missing {start,end}_flags() to ParseElementPrint()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 81bbfb010599b65308aca89cc50532372ca4cb00)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b3bfd5d73038e067c08ce91bdedf227873779d6">7b3bfd5d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc/ndr: align the definition of LIBNDR_STRING_FLAGS with currently defined flags
The range included the unused (1<<14) before.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 91d8272e8604b5d87bcc0ce365b553bc760c8ed3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9bbacf5770eb185b473b2e8d93891b602560b089">9bbacf57</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc/ndr: add LIBNDR_FLAG_IS_SECRET handling
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 32aa3a199dfd61eb5982e158008964b4747599b8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/899c0d5e42ae5da61c1752358f6efd3dd705605b">899c0d5e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">idl_types.h: add NDR_SECRET shortcut
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 969ab12c56cd12dcc0e63e9b662397c1604a0cc0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/208c7719b436041c9d1ad5faa5aa5749fac13cbd">208c7719</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:librpc: let NDR_SECRETS depend on NDR_SECURITY
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 4260b52a399667bcdbaa375a20952237ff68449c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/88abba9fb6e7d20fea68bd3f982a97643f25bfa7">88abba9f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: remove unused kerberos_secrets_store_salting_principal()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit c56043a94a10c76a220ce3c7eb7cb8cf2e992cab)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5b9625277d66910eadaaca8b12aa76798755e3d5">5b962527</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_wrap: add smb_krb5_salt_principal()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 5df46700cfb0a15fec2d366e12728cd497188741)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cef8c677b7efc4f644ddad00e471560659e0d497">cef8c677</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_wrap: add smb_krb5_salt_principal2data()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit ec2da944d304852d76137e8f9d234462bc807c6b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77980addb9c4e713420ed470291a2ebc52d91e76">77980add</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet_join: remove dead code from libnet_join_connect_ads()
username[strlen(username)] is *always* '\0'!
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 5958c6790fbceb39065353c07fe25f74ddf09ef0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/35b6d50cccce7c873d771b6b306cb5fba1d423e2">35b6d50c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet_join: calculate r->out.account_name in libnet_join_pre_processing()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 826223cc8d36871c2bcb37fe23241f1dbe99a0db)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d68b34ba68d4c17d37ee0bf2c595ce09f4770de4">d68b34ba</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet_join.idl: return the domain_guid in libnet_JoinCtx
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 03e455f5a815ce2134e216dc28929646a964384f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f18c0caf6ef654df6c6eaf94d5cbbe9b2f4fc14e">f18c0caf</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet_join: remember the domain_guid for AD domains
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit fc2bad0cf34fca5e65fba7e036acf1d8c61f05c0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/18cd9780fd1f9fd44f2df670f48e1784ac3dbc8d">18cd9780</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet_join.idl: add krb5_salt to libnet_JoinCtx
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 3b13e4d2d0f73c6374ffdae57528cd1a7f333792)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9d818ce22e504b2a38306a0904d47dd045e32586">9d818ce2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet_join: remember r->out.krb5_salt in libnet_join_derive_salting_principal()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 549c9d9a07d3002442cbbb7a90d0a7fef4a92bff)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4765cb4cc4ebbaa009b0662e0a15932b8fe2654c">4765cb4c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet_join: move kerberos_secrets_store_des_salt() out of libnet_join_derive_salting_principal()
We should separate the calculation and the storing steps.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 0c65d5f41023076fd201c3a179df77dd615cdb01)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7110ea3673bdbb6f84d687aac2688972e7f7dc4c">7110ea36</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet_join: split libnet_join_post_processing_ads() into modify/sync
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 0ab7944a2b00df4aa155a239c86f97e4e731b864)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a210289630d2201150c53acd98a4bb4ed96da34c">a2102896</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet_join: call do_JoinConfig() after we did remote changes on the server
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 559de1e7236fd4a38f2a1f9980216db95d0430ce)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/00a2ce6f29f01addc639bae70808613f798095fe">00a2ce6f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet_join: move libnet_join_joindomain_store_secrets() to libnet_join_post_processing()
We should not store the secrets before we did all remote changes
(except the optional dns updates).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit a922e01baeccedc3ffc8a893f1d6072bb203220f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87b27a5be78bc41b5f3144440f4634ce967ccf27">87b27a5b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet_join: move kerberos_secrets_store_des_salt() to libnet_join_joindomain_store_secrets()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 7d2eea39112fd69d2b710181b23301562efea387)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0f4d1818e20d2a1db47589abb2dc7f6b236d32e0">0f4d1818</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: remove kerberos_secrets_fetch_salting_principal() fallback
The handling for per encryption type salts was removed in
Samba 3.0.23a (Jul 21, 2006). It's very unlikely that someone
has such an installation that got constantly upgraded over 10 years
with an automatic password change nor rejoin. It also means
that the KDC only has salt-less arcfour-hmac-md5 key together
with the salted des keys. So there would only be a problem
if the client whould try to use a des key to contact the smb server.
Having this legacy code adds quite some complexity for no
good reason.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 487b4717b58a6f1ba913708ce8419145b7f4fac8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2ef7d5ab0f15f127dbcb2a2393e486a72ca4b436">2ef7d5ab</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: provide a simpler kerberos_fetch_salt_princ() function
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 5fe939e32cdaf7bb5b6dac67e7b0118ce65846be)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0aa6bfdec2334beaf17a3c818f183015f9141f1f">0aa6bfde</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:gse_krb5: simplify fill_keytab_from_password() by using kerberos_fetch_salt_princ()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 1d1cf9792f9227e65857c85ff66a961331e3c16e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa2f79bee68249d96b0b137f6528b8db35529cd5">aa2f79be</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet: make use of kerberos_secrets_fetch_salt_princ()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 51ae7b42d4d52016b39b79447a3e28d473e676cb)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/24478a5533704a50876ad1aa4fc7477964bc0e80">24478a55</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: make use of kerberos_secrets_fetch_salt_princ() in ads_keytab_add_entry()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit b0928a2687a9ffe92ebdce7b5252781d62e7e02d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/701361c6809934fe0ada8bdbd436d95e504664d0">701361c6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: remove unused kerberos_fetch_salt_princ_for_host_princ()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 1a26805ad9f19f02a52d9eaa4f2f11ff20ee76ac)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fd161f1506aacbbf42a16359206d035012585218">fd161f15</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:secrets: move kerberos_secrets_*salt related functions to machine_account_secrets.c
These don't use any krb5_context related functions and they just
work on secrets.tdb, so they really belong to machine_account_secrets.c.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 504b446d8dc7410ad63eba9d214e9cf271cf3b2f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de0f7301daf1c58f758140170a8be6d6a0c72c66">de0f7301</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:secrets: rework des_salt_key() to take the realm as argument
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 072dd87e639d7dbfc583ede5ddf6559d9d433b8b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ec6b9392166b2228b61947f1803ed6125c4d111e">ec6b9392</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:secrets: split out a domain_guid_keystr() function
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit d37e30cef7906b7b2b14351ad81d0d884811557b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0a363257b896d01529e4eaddc36224c81c0c8f91">0a363257</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:secrets: add some const to secrets_store_domain_guid()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 99013685a1114829579e420df3625ed79eb7ee94)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f30adda2b4a1c23e0747839bd23e9036552f8f76">f30adda2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:secrets: make use of des_salt_key() in secrets_store_machine_pw_sync()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 4e37d7805b345d80ca6e8a598e39fc81f72a27ce)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f5dc61c9ffa501c3a0bd41281f45db47a172458e">f5dc61c9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:secrets: rename secrets_delete() to secrets_delete_entry()
secrets_delete_entry() fails if the key doesn't exist.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit cd1e888773c4fd3db63ce38a496fc3d54eb8e021)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1bbefc1c46ecc511d25d41e1788ab2e9549d8f50">1bbefc1c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:secrets: re-add secrets_delete() helper to simplify deleting optional keys
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit fde4af1c329655d7ef3f55727632b3f026a3ea73)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/96319f6d21dcd092f414392809b4b5f35b8a2bb5">96319f6d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:secrets: make use of secrets_delete() in secrets_store_machine_pw_sync()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit c5ded1123797b2bd152b0989e24eba7cae6a5792)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fdbf0dee0a31c2659dc422e231495f4c4f835e06">fdbf0dee</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:secrets: let secrets_store_machine_pw_sync() delete the des_salt_key when there's no value
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 45eea321a6faa6db1c9c706a27527cc0766dc831)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a920733cf6aca9f9e9e6f1bedbe36b9ceec5499c">a920733c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:secrets: replace secrets_delete_prev_machine_password() by secrets_delete()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 5b95cb74e7b2838d228f9773c0e20982b81d1e7d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/04384a477bc348d0cd875c2bc27067ec029c2d40">04384a47</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:secrets: rewrite secrets_delete_machine_password_ex() using helper variables
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 5bc2764fe517748c03a57b61f2f7ef889c92825d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/64b3919668474852b40dd04ef018ae7a9f7eab7c">64b39196</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:secrets: let secrets_delete_machine_password_ex() remove SID and GUID too
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit cf8a4646fe71a974b6a5ee13ae7d7751a5a0adc9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3c3765fb10c51ce6ea22f0b8343ade79fa8d1d68">3c3765fb</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:secrets: let secrets_delete_machine_password_ex() also remove the des_salt key
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit dfaadc81925e313901c9b30cd98a4b4fd2404f9d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9afd00e79f4cd282f489a54e84bed0a7f748e332">9afd00e7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:secrets: use secrets_delete for all keys in secrets_delete_machine_password_ex()
We just want all values to be removed at the end, it doesn't matter
if they didn't existed before.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit bfe35abc1fb15e70a99fa74d064051a1ad541ed0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c1d6f18d1999add7df9bd5cc3bce44be4fb93007">c1d6f18d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:trusts_util: pass dcname to trust_pw_change()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 1421abfc733247a6b71eefd819dfeae7151a6d78)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/09461fe4bc614fb06841d1f9bfda37b80cd499b1">09461fe4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/auth: pass an array of nt_hashes to netlogon_creds_cli_auth*()
This way the caller can pass more than 2 hashes and can only
know which hash was used for a successful connection.
We allow up to 4 hashes (next, current, old, older).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit ddd7ac68ccae8b4df6c6a65b3dad20e21924f538)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c7de3ca9009fb62e0296d00d6aa59e79b835992">0c7de3ca</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/auth: add const to set_pw_in_buffer()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 1b48c8515ed8fd29204c82cc47f958f4636cd494)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/399945b47d1f9eeaae00ce60d4ef98ac23e13df6">399945b4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/auth: pass the cleartext blob to netlogon_creds_cli_ServerPasswordSet*()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 0f5945a06df4bef501ca5085c621294057007225)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1e5489d91850397a04cd96bbe11ba6b58ba716d3">1e5489d9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:trusts_util: also pass the previous_nt_hash to netlogon_creds_cli_auth()
Even in the case where only the password is known to the server, we should
try to leave a valid authentication behind.
We have better ways to indentify which password worked than only using
the current one.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit d60404b032eca5384d889352f52b9b129861b4af)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e635a4fb7054dbffd85d21c740cc0a49f78ca11b">e635a4fb</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lsa.idl: make lsa_DnsDomainInfo [public]
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit ea0798881a7aaf5897a3a3806149536d3d54fc3b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/19addd11fee15ec4ce979df5f05ac3dc951da895">19addd11</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netlogon.idl: make netr_TrustFlags [public]
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 60274475332dafdfb829a7c086ea09cd9ed00540)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4d66652062f57292a259258a9536dd2941e9e0e2">4d666520</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netlogon.idl: use lsa_TrustType and lsa_TrustAttributes in netr_trust_extension
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 28ac10503476de3c000b3deee2c1f67e0b305578)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/97b72e3f1cdddcd11964e96b9d549a1b6ebfbbd3">97b72e3f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">secrets.idl: add secrets_domain_info that will be used in secrets.tdb for machine account trusts
This blob will be store in secrets.tdb. It makes it possible to store much
more useful details about the workstation trust.
The key feature that that triggered this change is the ability
to store details for the next password change before doing
the remote change. This will allow us to recover from failures.
While being there I also thought about possible new features,
which we may implement in the near future.
We also store the raw UTF16 like cleartext buffer as well as derived
keys like the NTHASH (arcfour-hmac-md5 key) and other kerberos keys.
This will allow us to avoid recalculating the keys for an in memory
keytab in future.
I also added pointer to an optional lsa_ForestTrustInformation structure,
which might be useful to implement multi-tenancy in future.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit a59c9cba31a801d90db06b767cfd44776f4ede77)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f3da29546508024971153081f7714b6846b4d1fa">f3da2954</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:secrets: add infrastructure to use secrets_domain_infoB to store credentials
We now store various hashed keys at change time and maintain a lot of details
that will help debugging failed password changes.
We keep storing the legacy values:
SECRETS/SID/
SECRETS/DOMGUID/
SECRETS/MACHINE_LAST_CHANGE_TIME/
SECRETS/MACHINE_PASSWORD/
SECRETS/MACHINE_PASSWORD.PREV/
SECRETS/SALTING_PRINCIPAL/DES/
This allows downgrades to older Samba versions.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 5f0038fba612afd7fc15b7ab321df979891170d8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d9a23941c389904f87285cbbc7ba442460920532">d9a23941</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: add "net primarytrust dumpinfo" command that dumps the details of the workstation trust
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit c7c17d9f503d6037aa8ed0bd7ab7cf52f5f28382)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/75a05ad5c73de9020fda80c4b0c8a80777795812">75a05ad5</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet: make use of secrets_store_JoinCtx()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit c3ad8be5d5192070c599350d6ab28c064206b6cf)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ab5109fd4600a37cc6ae0375db13d279b0b20ae1">ab5109fd</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:trusts_util: make use the workstation password change more robust
We use secrets_{prepare,failed,defer,finish}_password_change() to make
the process more robust.
Even if we just just verified the current password with the DC
it can still happen that the remote password change will fail.
If a server has the RefusePasswordChange=1 under
HKLM\SYSTEM\CurrentControlSet\Services\Netlogon\Parameters,
it will reject NetrServerPasswordSet2() with NT_STATUS_WRONG_PASSWORD.
This results in a successful local change, but a failing remote change,
which means the domain membership is broken (as we don't fallback to
the previous password for ntlmssp nor kerberos yet).
An (at least Samba) RODC will also reject a password change,
see https://bugzilla.samba.org/show_bug.cgi?id=12773.
Even with this change we still have open problems, e.g. if the password was
changed, but we didn't get the servers response. In order to fix that we need
to use only netlogon and lsa over unprotected transports, just using schannel
authentication (which supports the fallback to the old password).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 40c42af11fda062fef9df96a9b5ae3e02709f07c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d86014e10399df3aae90e1c6a0c114d1364d83f">7d86014e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: make use of secrets_*_password_change() for "net changesecretpw"
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 4ae6a3ffb233c9b9576a3b5bb15a51ee56e4dbc3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ad1e456f306a29c47526d987308aec34daec1bee">ad1e456f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: make use of secrets_*_password_change() in ads_change_trust_account_password()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit b874dc90c91dd41c35e99bf7c4fe04220465edca)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6c728cc38f19265d67637d4bf517c0bb4446d9f6">6c728cc3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T08:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:secrets: remove unused secrets_store_[prev_]machine_password()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit f513c20ee04fe896900c99ae804753d445414d7d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65120599d845ebf1e3f9159320ca841dd16224f8">65120599</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-07-13T13:03:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest:Samba3: call "net primarytrust dumpinfo" setup_nt4_member() after the join
Here we check that we get 'REDACTED SECRET VALUES' printed, in order
to avoid regression on the non '-f' behavior.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 9530284383f252efd64bfdf138579964c6500eba)
Autobuild-User(v4-5-test): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(v4-5-test): Thu Jul 13 15:03:29 CEST 2017 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/35cba471582be47b040e057ea875200c6d0ff1d9">35cba471</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2017-07-24T00:25:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: add fruit:model = <modelname> parametric option
fruit:model = iMac
fruit:model = MacBook
fruit:model = MacPro
fruit:model = Xserve
will all display a different icon inside Finder.
Formerly, we used "Samba" which resulted in a "?" icon in Finder, with
the new default "MacSamba" we appear with a computer box icon at least.
Guenther
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12840
Signed-off-by: Guenther Deschner <gd@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Wed Jul 12 03:17:57 CEST 2017 on sn-devel-144
(cherry picked from commit 259e1706e3206b215e136ea9d5beef4c9e3fcdee)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dbb28145f0259465f520c80e10c96a23e72ab3b1">dbb28145</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-07-24T00:25:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: don't use MS NFS ACEs with Windows clients
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12897
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Thu Jul 13 22:21:08 CEST 2017 on sn-devel-144
(cherry picked from commit df0db9d8f893f9245c6289200303b94a6e2d48d0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/565932852ee486b981d462ca24dadf531a2cb704">56593285</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-07-24T00:25:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/notifyd: ensure notifyd doesn't return from smbd_notifyd_init
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12910
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 7f4e7cfd1b0bd917395c631a1a8195fffd13bbad)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d740e45c4ecb8d6acdb6e429bd35d0e9f91e1be">5d740e45</a></strong>
<div>
<span>by Thomas Jarosch</span>
<i>at 2017-07-24T04:24:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: Fix use-after-free when accessing pointer *p.
talloc_asprintf_append() might call realloc()
and therefore move the memory address of "path".
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12927
Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Jul 22 22:45:05 CEST 2017 on sn-devel-144
(cherry picked from commit 890137cffedcaf88a9ff808c01335ee14fcfd8da)
Autobuild-User(v4-5-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-5-test): Mon Jul 24 06:24:58 CEST 2017 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cfa8c189da1a4dbbf00d76068fbf2a11c0837747">cfa8c189</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2017-07-25T03:32:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix a read after free if a chained SMB1 call goes async.
Reported to the Samba Team by Yihan Lian <lianyihan@360.cn>, a security
researcher of Qihoo 360 GearTeam. Thanks a lot!
smb1_parse_chain() incorrectly used talloc_tos() for the memory
context of the chained smb1 requests. This gets freed between
requests so if a chained request goes async, the saved request
array also is freed, which causes a crash on resume.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12836
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 5fe76a5474823ed7602938a07c9c43226a7882a3)
Autobuild-User(v4-5-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-5-test): Tue Jul 25 05:32:53 CEST 2017 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3475d11fe95b4b1afc8ba2731f2853503f44c02b">3475d11f</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2017-07-25T13:53:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_ceph: fix cephwrap_chdir()
When provided a '/' path (i.e. CephFS root), vfs_ceph does a *local*
chdir() to the share path. This breaks smb client directory listings.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12911
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Fri Jul 21 19:10:46 CEST 2017 on sn-devel-144
(cherry picked from commit 1dcacff083019810e207a3d123a81fe32d9dde1a)
Autobuild-User(v4-5-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-5-test): Tue Jul 25 15:53:04 CEST 2017 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9792ec26373869f7613a12b09a911366442746d4">9792ec26</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2017-08-14T08:50:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: Reverse sense of 'clear all attributes', ignore attribute change in SMB2 to match SMB1.
SMB1 uses attr == 0 to clear all attributes
on a file (end up with FILE_ATTRIBUTE_NORMAL),
and attr == FILE_ATTRIBUTE_NORMAL to mean ignore
request attribute change.
SMB2 uses exactly the reverse. Unfortunately as the
cli_setatr() ABI is exposed inside libsmbclient,
we must make the SMB2 cli_smb2_setatr() call
export the same ABI as the SMB1 cli_setatr()
which calls it. This means reversing the sense
of the requested attr argument if it's zero
or FILE_ATTRIBUTE_NORMAL.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12899
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
(cherry picked from commit f1cc79a46d56bda99c392d491d88479cd6427a32)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5b3f03171a56c876cfae35163f46bcd406b3ea76">5b3f0317</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-08-14T08:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: handling of failed DOS attributes reading
Only fall back to using UNIX modes if we get NOT_IMPLEMENTED. This is
exactly what we already do when setting DOS attributes.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12944
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
(cherry picked from commit 9de1411d9e7c7ac3da544345d4dea7fd73dff01b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c493d8e6405f6a2dd33a24f7f5237d18aab3a576">c493d8e6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-08-14T08:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: handle EACCES when fetching DOS attributes from xattr
When trying to fetch the DOS attributes xattr via SMB_VFS_GETXATTR() if
the filesystem doesn't grant read access to the file the xattr read
request fails with EACCESS.
But according to MS-FSA 2.1.5.1.2.1 "Algorithm to Check Access to an
Existing File" FILE_LIST_DIRECTORY on a directory implies
FILE_READ_ATTRIBUTES for directory entries.
So if the user can open the parent directory for reading this implies
FILE_LIST_DIRECTORY and we can safely call SMB_VFS_GETXATTR() as root,
ensuring we can read the DOS attributes xattr.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12944
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
(backported from commit c54fcb7cbd0de244eed4134e877da6e9c16e7aab)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ad113e076b2a4875cbf056903a741ee913fd1688">ad113e07</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-08-14T08:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: handle EACCES when fetching DOS attributes from xattr
When trying to fetch the DOS attributes via gpfswrap_get_winattrs_path()
if the filesystem doesn't grant READ_ATTR to the file the function fails
with EACCESS.
But according to MS-FSA 2.1.5.1.2.1 "Algorithm to Check Access to an
Existing File" FILE_LIST_DIRECTORY on a directory implies
FILE_READ_ATTRIBUTES for directory entries.
So if the user can open the parent directory for reading this implies
FILE_LIST_DIRECTORY and we can safely call gpfswrap_get_winattrs_path()
with DAC_OVERRIDE_CAPABILITY.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12944
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Aug 9 01:21:14 CEST 2017 on sn-devel-144
(cherry picked from commit 62d73f5b936550d623ef4f31c7438ac3c90105b9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bfa7ac0ab5b9295df3102bca99edeb198decd0cb">bfa7ac0a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2017-08-14T08:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmbclient: Fix cli_setpathinfo_basic() to treat mode == -1 as no change.
This is only called from SMBC_setatr(), so bring it into line with
the specification for that function.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12913
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 812006fa8f26004609901b0ddef1c3ed05eff35e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a6f4924b471c2e0f81506f6ad4e91e2f4c378a5d">a6f4924b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2017-08-14T08:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: Add cli_smb2_setpathinfo(), to be called by cli_setpathinfo_basic().
Fix to prevent libsmbclient from accidently making SMB1 calls inside an SMB2
connection.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12913
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 2a15c70603bb23a68a2e3de0b00bfd98508f78e0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/57f129b4b5011c4c5a52bbf7e3a3b9aeea9d336f">57f129b4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2017-08-14T08:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: Implement cli_smb2_setatr() by calling cli_smb2_setpathinfo().
This removes duplicate code paths and ensures we have only one
function calling the underlying smb2cli_set_info() for setting
info levels by path.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12913
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit b1e5b894b089433e59c96915a27559d179bdb6c5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/715e1c917a3988883c5a2e92edef1cd1989b7213">715e1c91</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2017-08-14T08:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Add a test for cli_setpathinfo_basic() to smbtorture3.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12913
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit bfa07323590357542eb06ad5faa2dc5a5736e3f1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da22be9167a342e2edfbdb49a9b9d34e5bde9b66">da22be91</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-08-14T08:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_streams_xattr: invalidate stat info if xattr was not found
We stat the basefile so we leave valid stat info from the base file
behind, even though the xattr for the stream was not there.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12791
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
(backported from commit ec32f33ea6d50d9cb504400c3ef1e78643502e1a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c6422830d6b059841373e531d5a91aa708ba8073">c6422830</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-08-14T08:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_streams_xattr: remove all uses of fd, use name based functions
We don't really need an fd in this module, all calls to the VFS xattr
API can just use the name based versions.
This paves the way for removing the open of the basefile in
streams_xattr_open() in a later commit.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12791
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
(backported from commit ea906bb476516c05e7cbda478afd32acb443c03e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/10b04e9bd914e840f47705f60adf4604bdbac4e7">10b04e9b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-08-14T08:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_streams_xattr: remove fsp argument from get_xattr_size()
Still in the process of changing all handle based operations to use path
based operations.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12791
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
(backported from commit 4cc59e6d011cd3804499ba82bb4071973aa9d494)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/62c9719647a0eb01874f418bd00b0ebe7d845fc6">62c97196</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-08-14T08:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_streams_xattr: always pass NULL as fsp arg to get_ea_value()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12791
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
(backported from commit 0ed3075ee7edfecde7455a2c64e9df882828343b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f7e96aed260bf8c332b6302880a875fc49e85a71">f7e96aed</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-08-14T08:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_streams_xattr: implement all missing handle based VFS functions
Implement all missing handle based VFS function. If the call is on a
named stream, implement the appropriate action for the VFS function, in
most cases a no-op.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12791
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(backported from commit 9647af6bec62c9f61d541aad4a9b8f25fd5bc627)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/38d8b62dcd3f6bcf6e3a0a155fe3b25a88b6ebd5">38d8b62d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-08-14T08:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_streams_xattr: return a fake fd in streams_xattr_open()
The final step in changing vfs_streams_xattr to not call open() on the
basefile anymore. Instead, we just return a fake file fd based on
dup'ing a pipe fd. Previous commits ensured all calls to VFS API
functions use pathname based versions to do their work.
This ensures we don't trigger kernel oplock breaks for client "open
stream" requests when needlessly opening the basefile.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12791
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 0a8559d4c9e4fc73c30a06b5f45f3b870afe4439)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c03af9fcd98244e863ebd8eba74742ac981fd116">c03af9fc</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-08-14T08:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture: reproducer for kernel oplocks issue with streams
test_smb2_kernel_oplocks3() wouldn't have failed without the patches,
I'm just adding it to have at least one test that tests with 2
clients. All other tests use just one client.
test_smb2_kernel_oplocks4() is the reproducer.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12791
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
(backported from commit a334fff8a8c779704ee04ae784024efb67a6e9c9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/12c818b642ba19c4d9edca803e21cc786bb4dc01">12c818b6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-08-14T08:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture: additional tests for kernel-oplocks
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
(backported from commit bbc225de83e7b0e5eaeb1b843532d1f0fca91a3c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d6c991628ba68341acc84540a3f8a15e0336e00b">d6c99162</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-08-14T08:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: use path based setxattr call in ad_fset()
This allows later commits to remove opening of the basefile which
conflict with "kernel oplocks = yes".
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12791
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
(backported from commit aff6fc49f4ac244aef162200a37bd846719e1e4f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/379dbb5fe8c05d6bea0d332e0395bb07c0c5b07a">379dbb5f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-08-14T08:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: don't open basefile in ad_open() and simplify API
We never need an fd on the basefile when operating on the metadata, as
we can always use path based syscalls. Opening the basefile conflicts
with "kernel oplocks" so just don't do it.
Additional changes:
- remove the adouble_type_t argument to ad_open(), the type is passed
and set when allocating a struct adouble with ad_alloc()
- additionally pass an optional fsp to ad_open() (so the caller can pass
NULL). With this change we can move the fd inheritance from fsp to ad
into ad_open() itself where it belongs and remove it from the caller
ad_fget()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12791
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
(backported from commit e92a39255e66f655e2758f0a71a01eaf258cf711)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b559efc42bb736b12c5fac4e92d4301486f48f3d">b559efc4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-08-14T08:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: return fake pipe fd in fruit_open_meta_netatalk()
Do not open the basefile, that conflict with "kernel oplocks = yes". We
just return a fake file fd based on dup'ing a pipe fd and ensure all VFS
functions that go through vfs_fruit and work on the metadata stream can
deal with it.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12791
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
(backported from commit 7583ee6e1c558067e4c7a7351085fcc0e4240366)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2339d4bc05e65d871cd19a58ef4f28bb1e46cad8">2339d4bc</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2017-08-14T12:52:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: factor out common code from ad_get() and ad_fget()
As a result of the previous changes ad_get() and ad_fget() do completey
the same, so factor out the common code to a new helper function. No
change in behaviour.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12791
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Aug 9 22:33:36 CEST 2017 on sn-devel-144
(backported from commit d55c27abc5a7357f740c7065bbe12e7f36b57125)
Autobuild-User(v4-5-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-5-test): Mon Aug 14 14:52:17 CEST 2017 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0247ece5e2f2ae38ffbe2bfbf9a8776f39242639">0247ece5</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2017-08-30T10:32:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.5.13.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3c9bc040e234bfe3a645a06630ee2258572f3f56">3c9bc040</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2017-08-30T10:32:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOTS for the 4.5.13 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c645ed69e285ff911edad4e4ea9606537668e5e">5c645ed6</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2017-08-30T10:33:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.5.14...
and re-enable GIT_SNAPSHOTS.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f14a94b5cd3e9977e8483e8a6ba06f48045edc15">f14a94b5</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-09-04T09:34:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2017-12150: s3:lib: get_cmdline_auth_info_signing_state smb_encrypt SMB_SIGNING_REQUIRED
This is an addition to the fixes for CVE-2015-5296.
It applies to smb2mount -e, smbcacls -e and smbcquotas -e.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12997
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f82c235484d03e22ad78a79e9cf2f14c8455df56">f82c2354</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-09-04T09:34:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2017-12150: s3:pylibsmb: make use of SMB_SIGNING_DEFAULT for 'samba.samba3.libsmb_samba_internal'
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12997
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d296e6ea32ca2df035dd35e6f21b82390f87f86">5d296e6e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-09-04T09:34:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2017-12150: libgpo: make use of SMB_SIGNING_REQUIRED in gpo_connect_server()
It's important that we use a signed connection to get the GPOs!
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12997
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dc24ef0fc4292a365900270d6b9b66c9cfc0609e">dc24ef0f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-09-04T09:34:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2017-12150: auth/credentials: cli_credentials_authentication_requested() should check for NTLM_CCACHE/SIGN/SEAL
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12997
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f30ea84489e9ee6ab65279bc3ea62ce4f954f965">f30ea844</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-09-04T09:35:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2017-12150: libcli/smb: add smbXcli_conn_signing_mandatory()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12997
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/609e6b09feb4b00ee52db4a9df258cb9061f4ad8">609e6b09</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-09-04T09:35:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2017-12150: s3:libsmb: only fallback to anonymous if authentication was not requested
With forced encryption or required signing we should also don't fallback.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12997
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/282a1d122f9861b0521fa5a389ad467f8da93bd1">282a1d12</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-09-04T09:35:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2017-12151: s3:libsmb: add cli_state_is_encryption_on() helper function
This allows to check if the current cli_state uses encryption
(either via unix extentions or via SMB3).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12996
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/157f2a703bcaca9495d50cbd4d48c24b1ceed80d">157f2a70</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-09-04T09:36:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2017-12151: s3:libsmb: make use of cli_state_is_encryption_on()
This will keep enforced encryption across dfs referrals.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12996
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a43b36f5514de38b8a072bfbeb172316045c2ad0">a43b36f5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2017-09-12T03:31:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2017-12163: s3:smbd: Prevent client short SMB1 write from writing server memory to file.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13020
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b5178cb03bf66ccfed4d6b68b5df5f5626f64801">b5178cb0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-09-12T03:31:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: make samba3.blackbox.smbclient_s3.*follow.symlinks.*no as flapping
This is fixed in master and 4.7. For the backports we can just ignore
failures.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12914
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bb90fee8f63afa6b9f77f892810e19b153239f24">bb90fee8</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2017-09-13T16:39:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.5.14.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f261c9a5ef07a0a4230b891b2585c5f21945e196">f261c9a5</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2017-09-13T16:42:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOTS for the 4.5.14 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cea68b699baa6f404ba368c2feaaa4035b5d635e">cea68b69</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2017-09-19T14:54:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Patches for CVE-2017-12150, CVE-2017-12151 and CVE-2017-12163
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/34f93fcb466e496010d791a9290d4e44bb1436af">34f93fcb</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2017-09-19T15:52:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Adapt patches to 4.5.8
See 0d0d9820531aca17a5300f4e4eb47f07a999aaca
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/29a501b8defd84004f9b76f0235e31cff62c12c4">29a501b8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-09-19T15:52:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2017-12150: s3:lib: get_cmdline_auth_info_signing_state smb_encrypt SMB_SIGNING_REQUIRED
This is an addition to the fixes for CVE-2015-5296.
It applies to smb2mount -e, smbcacls -e and smbcquotas -e.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12997
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/354e22634a0ad3d26d6a28cf6f3a281a71026856">354e2263</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-09-19T15:52:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2017-12150: s3:pylibsmb: make use of SMB_SIGNING_DEFAULT for 'samba.samba3.libsmb_samba_internal'
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12997
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a85975ede5afbc550e253856b5f16dd6d0b4ebd4">a85975ed</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-09-19T15:52:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2017-12150: libgpo: make use of SMB_SIGNING_REQUIRED in gpo_connect_server()
It's important that we use a signed connection to get the GPOs!
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12997
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/27701be2555d76bd5a4ce4ee772e1f285c991eaf">27701be2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-09-19T15:52:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2017-12150: auth/credentials: cli_credentials_authentication_requested() should check for NTLM_CCACHE/SIGN/SEAL
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12997
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ee72f46b329efc2cd9ea27dd06b754fcc8f6680c">ee72f46b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-09-19T15:52:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2017-12150: libcli/smb: add smbXcli_conn_signing_mandatory()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12997
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/58ea302cd4cec1f96e16b4c6fbbbd21b3bd2b041">58ea302c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-09-19T15:52:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2017-12150: s3:libsmb: only fallback to anonymous if authentication was not requested
With forced encryption or required signing we should also don't fallback.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12997
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/38c98c74d1980ad86afedda436fc24d5a139ac23">38c98c74</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-09-19T15:52:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2017-12151: s3:libsmb: add cli_state_is_encryption_on() helper function
This allows to check if the current cli_state uses encryption
(either via unix extentions or via SMB3).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12996
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/17b3e3af8ff6d3c608a101e556f9227799d4ed74">17b3e3af</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2017-09-19T15:52:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2017-12151: s3:libsmb: make use of cli_state_is_encryption_on()
This will keep enforced encryption across dfs referrals.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12996
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3f357e45d8eef84b46bc61c254f3d4be7ded42ab">3f357e45</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2017-09-19T15:52:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2017-12163: s3:smbd: Prevent client short SMB1 write from writing server memory to file.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13020
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/612c59023d0a858cd97b386f0d80d41c0815a918">612c5902</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2017-09-19T19:56:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Release 2:4.5.8+dfsg-2+deb9u2
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/21811ac6882ccb8def448f80a03b699cae81a251">21811ac6</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2017-11-17T11:04:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.5.15...
and re-enable GIT_SNAPSHOTS.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c28d92278842b5b29f954996c6e45d61cd5c35a8">c28d9227</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2017-11-17T11:04:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">blackbox tests: method to check specific exit codes
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit 74ebcf6dfc84b6aab6838fa99e12808eb6b913d9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bd200ea5d2fb7e3948fae8fbeb114de557a14313">bd200ea5</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2017-11-17T11:04:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: use communicate to fix Popen deadlock
`Popen.wait()` will deadlock when using stdout=PIPE and/or stderr=PIPE and the
child process generates large output to a pipe such that it blocks waiting for
the OS pipe buffer to accept more data. Use communicate() to avoid that.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Oct 19 09:27:16 CEST 2017 on sn-devel-144
(cherry picked from commit 5dc773a5b00834c7a53130a73a48f49048bd55e8)
Autobuild-User(v4-5-test): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(v4-5-test): Tue Nov 14 14:35:22 CET 2017 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/007f5b54d76bf69f441cc277b7f41f478e258aab">007f5b54</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2017-11-17T11:04:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix SMB1 use-after-free crash bug. CVE-2017-14746
When setting up the chain, always use 'next->' variables
not the 'req->' one.
Bug discovered by 连一汉 <lianyihan@360.cn>
CVE-2017-14746
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13041
Signed-off-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c1a22e59f87783d88dfbaeeb132b89be166b2754">c1a22e59</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2017-11-17T11:04:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Chain code can return uninitialized memory when talloc buffer is grown.
Ensure we zero out unused grown area.
CVE-2017-15275
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13077
Signed-off-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d7526d66f5412c3421a95e716183eea7c7f50d14">d7526d66</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2017-11-17T11:04:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.5.15.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f333815481d8f5354f605751b627379ed3b8ae6e">f3338154</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2017-11-17T11:13:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.5.15 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d97780678cd289f9e46f2f693bbd6e5a20e99b10">d9778067</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-03-05T13:33:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Rebaselined stretch-security from stretch
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fbe5e3596757d8711a149251ca0d5924873d396b">fbe5e359</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-05T13:40:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1050: s3: RPC: spoolss server. Protect against null pointer derefs.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11343
Signed-off-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/121b86406db7e16c342b1ebe0e7ca67132a79f3e">121b8640</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-03-05T14:33:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Patch for CVE-2018-1050: "Codenomicon crashes in spoolss server code"
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8f11248f63da88166fe30514dcb03cdf868fe25">f8f11248</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-05T14:33:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/tests: add a test for password change with empty delete
Note that the request using the clearTextPassword attribute for the
password change is already correctly rejected by the server.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ef60d6a9059a81be31bce50bd57fb4453c4269bb">ef60d6a9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-05T14:33:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/password_hash: add a helper variable for LDB_FLAG_MOD_TYPE
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff0f0cc1176ac1cc96b92bac6d2bd092b42c81ec">ff0f0cc1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-05T14:33:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/password_hash: add a helper variable for passwordAttr->num_values
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e47fb74efff7cda7e547081b3528e153c6ee5732">e47fb74e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-05T14:33:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: only call dsdb_acl_debug() if we checked the acl in acl_check_password_rights()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a04ea99848f8aa960946599e07fb23aa2bd3a98">9a04ea99</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-05T14:33:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: remove unused else branches in acl_check_password_rights()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1dc0d1ca3db778c2b6d16edd07f922d2c7aff6a5">1dc0d1ca</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-05T14:33:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: check for internal controls before other checks
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d79dba9d85cd5762e63e4ccc6778339a20e8768d">d79dba9d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-05T14:33:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: add check for DSDB_CONTROL_PASSWORD_HASH_VALUES_OID control
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5387ee93366c689e7b7868ff858dbeaca3304d7a">5387ee93</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-05T14:33:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: add a NULL check for talloc_new() in acl_check_password_rights()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/272f85773f3b2165b6cbfc3d0f8cdc351a56a60b">272f8577</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-05T14:33:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4/dsdb: correctly detect password resets
This change ensures we correctly treat the following LDIF
dn: cn=testuser,cn=users,...
changetype: modify
delete: userPassword
add: userPassword
userPassword: thatsAcomplPASS1
as a password reset. Because delete and add element counts are both
one, the ACL module wrongly treated this as a password change
request.
For a password change we need at least one value to delete and one value
to add. This patch ensures we correctly check attributes and their
values.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9bdeb028e7e90e685a3ead35b419b4ed14ef3ad7">9bdeb028</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-05T14:33:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: run password checking only once
This is needed, because a later commit will let the acl module add a
control to the change request msg and we must ensure that this is only
done once.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4f41ee2580cdae70f5c45c6b81d50cf613e8cd60">4f41ee25</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-05T14:33:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/samdb: define DSDB_CONTROL_PASSWORD_ACL_VALIDATION_OID control
Will be used to pass "user password change" vs "password reset" from the
ACL to the password_hash module, ensuring both modules treat the request
identical.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2455be1cc0785e51d7bb00b72b70047faa1000e1">2455be1c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-05T14:33:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb: use DSDB_CONTROL_PASSWORD_ACL_VALIDATION_OID
This is used to pass information about which password change operation (change
or reset) the acl module validated, down to the password_hash module.
It's very important that both modules treat the request identical.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/022068fcde95523909f611ae301b9bf864c41187">022068fc</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-05T14:33:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: changing dBCSPwd is only allowed with a control
This is not strictly needed to fig bug 13272, but it makes sense to also
fix this while fixing the overall ACL checking logic.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/10d58b4480c63b8b66c7b917c236901da3496d86">10d58b44</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-03-05T14:33:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Patches for CVE-2018-1057: "Unprivileged user can change any user (and admin) password"
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/218e3c0babce4479d4f3d4641b83e63a3bc3d6aa">218e3c0b</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-03-05T14:33:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Release 2:4.5.12+dfsg-2+deb9u2
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f3ec20fdbea88f9de7731d9566ecce7f2916883a">f3ec20fd</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-03-12T12:01:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.5.16.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
(cherry picked from commit 8376a89e40b82c0b4b365b8daf155159f59945cb)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/64b6a9f6e1c472bb3f0ae052658b4532b81a9242">64b6a9f6</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-03-12T12:02:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dff5d43907fd9825f0ba03dab9aa63c31f5a014c">dff5d439</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-03-12T12:06:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1050: s3: RPC: spoolss server. Protect against null pointer derefs.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11343
Signed-off-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e5774640b0b93f6b03fee0734241192b8a02b73a">e5774640</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-12T12:06:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/tests: add a test for password change with empty delete
Note that the request using the clearTextPassword attribute for the
password change is already correctly rejected by the server.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7eabe3d477fd9c439ad160f42f537f404019b420">7eabe3d4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-12T12:06:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/password_hash: add a helper variable for LDB_FLAG_MOD_TYPE
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/abf925c2d10d29b9a68017f89b4970c8a2d43310">abf925c2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-12T12:06:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/password_hash: add a helper variable for passwordAttr->num_values
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d552abe8a2b34e528a3b810f3d1f600495e73466">d552abe8</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-12T12:06:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: only call dsdb_acl_debug() if we checked the acl in acl_check_password_rights()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99f46aabe571a96c3d5334929b069d8b81bd5d5d">99f46aab</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-12T12:06:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: remove unused else branches in acl_check_password_rights()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6d5caffbf5fe546b2f648f957ca8a41b12214f3f">6d5caffb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-12T12:06:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: check for internal controls before other checks
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/54c363e01210b478e1da74e446763153a61e56d0">54c363e0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-12T12:06:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: add check for DSDB_CONTROL_PASSWORD_HASH_VALUES_OID control
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6c980a03e54293d3044d32b0715c384903ed2baf">6c980a03</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-12T12:06:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: add a NULL check for talloc_new() in acl_check_password_rights()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/67fa44aaf2d81001260af85ed803f0ff6444397d">67fa44aa</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-12T12:06:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4/dsdb: correctly detect password resets
This change ensures we correctly treat the following LDIF
dn: cn=testuser,cn=users,...
changetype: modify
delete: userPassword
add: userPassword
userPassword: thatsAcomplPASS1
as a password reset. Because delete and add element counts are both
one, the ACL module wrongly treated this as a password change
request.
For a password change we need at least one value to delete and one value
to add. This patch ensures we correctly check attributes and their
values.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bb43ab081a539b088afb8c82658d2d8f3715bae8">bb43ab08</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-12T12:06:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: run password checking only once
This is needed, because a later commit will let the acl module add a
control to the change request msg and we must ensure that this is only
done once.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4adcba5f6aecacde5b405bdd1bdc662d303137e3">4adcba5f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-12T12:06:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/samdb: define DSDB_CONTROL_PASSWORD_ACL_VALIDATION_OID control
Will be used to pass "user password change" vs "password reset" from the
ACL to the password_hash module, ensuring both modules treat the request
identical.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e5b8c81d2951401691ea6a5e8082edf81354d1a1">e5b8c81d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-12T12:06:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb: use DSDB_CONTROL_PASSWORD_ACL_VALIDATION_OID
This is used to pass information about which password change operation (change
or reset) the acl module validated, down to the password_hash module.
It's very important that both modules treat the request identical.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/36639815f34c374f6d6cf002e19ba1754035e7d1">36639815</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-03-12T12:06:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1057: s4:dsdb/acl: changing dBCSPwd is only allowed with a control
This is not strictly needed to fig bug 13272, but it makes sense to also
fix this while fixing the overall ACL checking logic.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3e0aa7587ccaf061180ea08e089eeb2aa18cf5c0">3e0aa758</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-03-12T12:09:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.6.16.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4b43ad87039c0e94522b2baa7381255e28935f4e">4b43ad87</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-03-12T12:10:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.6.16 release.
CVE-2018-1050 (Denial of Service Attack on external print server.)
CVE-2018-1057 (Authenticated users can change other users' password.)
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fc0672f3a15b049ce82b5683563e7c4af802ff9a">fc0672f3</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-21T19:14:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 security: Move object-specific access checks into separate function
Object-specific access checks refer to a specific section of the
MS-ADTS, and the code closely matches the spec. We need to extend this
logic to properly handle the Control-Access Right (CR), so it makes
sense to split the logic out into its own function.
This patch just moves the code, and should not alter the logic (apart
from ading in the boolean grant_access return variable.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a8682ff5bf6a208d3698f1eb62fdccf667d85b4">4a8682ff</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-21T19:14:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 security: Add more comments to the object-specific access checks
Reading the spec and then reading the code makes sense, but we could
comment the code more so it makes sense on its own.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d4cf41199f539a73e00c3996f9e5cf9754d51b64">d4cf4119</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-21T19:14:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 tests: Add tests for guessing confidential attributes
Adds tests that assert that a confidential attribute cannot be guessed
by an unprivileged user through wildcard DB searches.
The tests basically consist of a set of DB searches/assertions that
get run for:
- basic searches against a confidential attribute
- confidential attributes that get overridden by giving access to the
user via an ACE (run against a variety of ACEs)
- protecting a non-confidential attribute via an ACL that denies read-
access (run against a variety of ACEs)
- querying confidential attributes via the dirsync controls
These tests all pass when run against a Windows Dc and all fail against
a Samba DC.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f2d392cde6ac3720af8396a3e35f144191e98962">f2d392cd</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-21T19:14:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 tests: Add test case for object visibility with limited rights
Currently Samba is a bit disclosive with LDB_OP_PRESENT (i.e.
attribute=*) searches compared to Windows.
All the acl.py tests are based on objectClass=* searches, where Windows
will happily tell a user about objects they have List Contents rights,
but not Read Property rights for. However, if you change the attribute
being searched for, suddenly the objects are no longer visible on
Windows (whereas they are on Samba).
This is a problem, because Samba can tell you about which objects have
confidential attributes, which in itself could be disclosive.
This patch adds a acl.py test-case that highlights this behaviour. The
test passes against Windows but fails against Samba.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0150c9bf4578ec761b854a035ee30a157de0a6c6">0150c9bf</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-21T19:14:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 tests: test ldap searches for non-existent attributes.
It is perfectly legal to search LDAP for an attribute that is not part
of the schema. That part of the query should simply not match.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/90729bccec363f635fc92d62253208a09c253fba">90729bcc</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-21T19:14:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 security: Fix checking of object-specific CONTROL_ACCESS rights
An 'Object Access Allowed' ACE that assigned 'Control Access' (CR)
rights to a specific attribute would not actually grant access.
What was happening was the remaining_access mask for the object_tree
nodes would be Read Property (RP) + Control Access (CR). The ACE mapped
to the schemaIDGUID for a given attribute, which would end up being a
child node in the tree. So the CR bit was cleared for a child node, but
not the rest of the tree. We would then check the user had the RP access
right, which it did. However, the RP right was cleared for another node
in the tree, which still had the CR bit set in its remaining_access
bitmap, so Samba would not grant access.
Generally, the remaining_access only ever has one bit set, which means
this isn't a problem normally. However, in the Control Access case there
are 2 separate bits being checked, i.e. RP + CR.
One option to fix this problem would be to clear the remaining_access
for the tree instead of just the node. However, the Windows spec is
actually pretty clear on this: if the ACE has a CR right present, then
you can stop any further access checks.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/81f55cce593cfa3063f576bd828a8c992caf4342">81f55cce</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-21T19:14:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 acl_read: Split access_mask logic out into helper function
So we can re-use the same logic laster for checking the search-ops.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d67483e166d0ddf8baabf34439b13c4d649e56f1">d67483e1</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-21T19:14:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 acl_read: Small refactor to aclread_callback()
Flip the dirsync check (to avoid a double negative), and use a helper
boolean variable.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2b713d01afdd800af80f371835f028a00e784c4d">2b713d01</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-21T19:14:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 acl_read: Flip the logic in the dirsync check
This better reflects the special case we're making for dirsync, and gets
rid of a 'if-else' clause.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a4930079c367a51e8a277232fbda9559c303d1dc">a4930079</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-21T19:14:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 acl_read: Fix unauthorized attribute access via searches
A user that doesn't have access to view an attribute can still guess the
attribute's value via repeated LDAP searches. This affects confidential
attributes, as well as ACLs applied to an object/attribute to deny
access.
Currently the code will hide objects if the attribute filter contains an
attribute they are not authorized to see. However, the code still
returns objects as results if confidential attribute is in the search
expression itself, but not in the attribute filter.
To fix this problem we have to check the access rights on the attributes
in the search-tree, as well as the attributes returned in the message.
Points of note:
- I've preserved the existing dirsync logic (the dirsync module code
suppresses the result as long as the replPropertyMetaData attribute is
removed). However, there doesn't appear to be any test that highlights
that this functionality is required for dirsync.
- To avoid this fix breaking the acl.py tests, we need to still permit
searches like 'objectClass=*', even though we don't have Read Property
access rights for the objectClass attribute. The logic that Windows
uses does not appear to be clearly documented, so I've made a best
guess that seems to mirror Windows behaviour.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/df536ffff97df859c1d41a231a0ef00e8786950d">df536fff</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-21T19:14:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 tests: Add extra test for dirsync deleted object corner-case
The acl_read.c code contains a special case to allow dirsync to
work-around having insufficient access rights. We had a concern that
the dirsync module could leak sensitive information for deleted objects.
This patch adds a test-case to prove whether or not this is happening.
The new test case is similar to the existing dirsync test except:
- We make the confidential attribute also preserve-on-delete, so it
hangs around for deleted objcts. Because the attributes now persist
across test case runs, I've used a different attribute to normal.
(Technically, the dirsync search expressions are now specific enough
that the regular attribute could be used, but it would make things
quite fragile if someone tried to add a new test case).
- To handle searching for deleted objects, the search expressions are
now more complicated. Currently dirsync adds an extra-filter to the
'!' searches to exclude deleted objects, i.e. samaccountname matches
the test-objects AND the object is not deleted. We now extend this to
include deleted objects with lastKnownParent equal to the test OU.
The search expression matches either case so that we can use the same
expression throughout the test (regardless of whether the object is
deleted yet or not).
This test proves that the dirsync corner-case does not actually leak
sensitive information on Samba. This is due to a bug in the dirsync
code - when the buggy line is removed, this new test promptly fails.
Test also passes against Windows.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ffd8797db98ae28c1c2ae8395acf99853934d308">ffd8797d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-11-21T19:14:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Ensure smbc_urlencode() can't overwrite passed in buffer.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13453
CVE-2018-10858: Insufficient input validation on client directory
listing in libsmbclient.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/52175a075c477c227b2343120c037b66c25da914">52175a07</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-11-21T19:14:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Harden smbc_readdir_internal() against returns from malicious servers.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13453
CVE-2018-10858: Insufficient input validation on client directory
listing in libsmbclient.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/55634757485cd0840f57119d6d4b7b997d2368c0">55634757</a></strong>
<div>
<span>by Salvatore Bonaccorso</span>
<i>at 2018-11-21T19:14:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Import Debian changes 2:4.5.12+dfsg-2+deb9u3
samba (2:4.5.12+dfsg-2+deb9u3) stretch-security; urgency=high
* Non-maintainer upload by the Security Team.
* Confidential attribute disclosure from the AD LDAP server (CVE-2018-10919)
* Insufficient input validation on client directory listing in libsmbclient
(CVE-2018-10858)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bed4807248b16f86a50c855e8c68af76994984e3">bed48072</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-11-23T21:58:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-14629 dns: CNAME loop prevention using counter
Count number of answers generated by internal DNS query routine and stop at
20 to match Microsoft's loop prevention mechanism.
(backport to Samba 4.5)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13600
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/07f588bfc2a8d155f8243157cd1521c1447c9780">07f588bf</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-11-23T21:58:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/dns_forwarder: Wait for port for 15 seconds
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 668e4e4a436756d73d64790fd0a7e79fa4769ffe)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/12d46bca5eddcb14693bac9eed5127321e4f59a5">12d46bca</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-11-23T21:58:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/dns_forwarder: Check that the subprocess is still living
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit ad3b3e978ebf0692580166f9deba0368a922362d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a5f1343fff24149ca825a16a02ce783864e1beb">2a5f1343</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-11-23T21:58:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/dns_forwarder: Fail out with an assertion instead OOB error
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Tue Sep 6 15:41:54 CEST 2016 on sn-devel-144
(cherry picked from commit 451907739cc14717c12875b88fbbe63a53e9cbec)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70eb7ecc9180c51ec4840a3ef87ad1a83edd3d3e">70eb7ecc</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-11-23T21:58:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16841 heimdal: Fix segfault on PKINIT with mis-matching principal
In Heimdal KRB5_KDC_ERR_CLIENT_NAME_MISMATCH is an enum, so we tried to double-free
mem_ctx.
This was introduced in 9a0263a7c316112caf0265237bfb2cfb3a3d370d for the
MIT KDC effort.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13628
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/24906f1c5e284e8774e46d75b0573b14c1d47e87">24906f1c</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-11-23T21:58:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16841 selftest: Check for mismatching principal in certficate compared with principal in AS-REQ
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13628
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/229dae305a56e26b83621a3dfa7d031a8caa56f0">229dae30</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-11-23T21:58:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16851 ldap_server: Check ret before manipulating blob
In the case of hitting the talloc ~256MB limit, this causes a crash in
the server.
Note that you would actually need to load >256MB of data into the LDAP.
Although there is some generated/hidden data which would help you reach that
limit (descriptors and RMD blobs).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13674
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4d0080e0dacc6cd18831f443b6eb0f01c4d30ad3">4d0080e0</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-23T21:58:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add patches for previous fixes
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9014cb5484b9fe550ce6547e05135626fbd5d179">9014cb54</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-11-23T21:58:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Release 2:4.5.12+dfsg-2+deb9u4 to stretch-security
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1ed75f6f77215cea2c612c66d30ac37c7ebf19f2">1ed75f6f</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-12-29T20:58:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">New upstream version 4.5.16+dfsg</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff9d35877b81c99d65c5a8d2e5d47a9160a6b540">ff9d3587</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-12-29T21:01:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge tag 'upstream/4.5.16+dfsg' into stretch
Upstream version 4.5.16+dfsg
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5b2a9c9432e0c3de3b616b8678e9ca4d76974bb9">5b2a9c94</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-12-29T21:19:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Preparare 2:4.5.16+dfsg-1
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2dcb0d3216ba74f7e22f4f4b1ec1595f568c8d07">2dcb0d32</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-12-29T21:39:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Drop merged patches
</pre>
</li>
</ul>
<h4>21 changed files:</h4>
<ul>
<li class="file-stats">
<a href="#b33892fbddeffc3368077b4904ad0b3d562a7312">
VERSION
</a>
</li>
<li class="file-stats">
<a href="#3277e12b5a9f9ff632d229e2629d34ad21dd93fc">
WHATSNEW.txt
</a>
</li>
<li class="file-stats">
<a href="#6f372b1da785e9b62534d3ddc2b1cc994e1edea1">
ctdb/doc/ctdb-statistics.7
</a>
</li>
<li class="file-stats">
<a href="#55a4d664aa02f3258cabec7bcee3b5fe0182994f">
ctdb/doc/ctdb-statistics.7.html
</a>
</li>
<li class="file-stats">
<a href="#bff45f5b0a1ff6f2cac0546191f2199bad760297">
ctdb/doc/ctdb-tunables.7
</a>
</li>
<li class="file-stats">
<a href="#705fcff3407770d8a8e6112e22ff7812302a5bf1">
ctdb/doc/ctdb-tunables.7.html
</a>
</li>
<li class="file-stats">
<a href="#cf03e1c00a6ff50094bf342fee6dbac15b3a4e0f">
ctdb/doc/ctdb.1
</a>
</li>
<li class="file-stats">
<a href="#be17d7a91250685646ace67c40160a444cbd03d2">
ctdb/doc/ctdb.1.html
</a>
</li>
<li class="file-stats">
<a href="#ab0737fb37c5f24c1a655306d7f3cf9b28970fa1">
ctdb/doc/ctdb.7
</a>
</li>
<li class="file-stats">
<a href="#344ebccf758b009700df26de67ae0d9e9c342481">
ctdb/doc/ctdb.7.html
</a>
</li>
<li class="file-stats">
<a href="#027f7ec3db27f736464febdb40a2f5784278e923">
ctdb/doc/ctdb_diagnostics.1
</a>
</li>
<li class="file-stats">
<a href="#a378d88acbd00a61f917946dac43e53c71abb801">
ctdb/doc/ctdb_diagnostics.1.html
</a>
</li>
<li class="file-stats">
<a href="#b3f02388c7b39adb49f0f55dbc87a0b75e7f21c3">
ctdb/doc/ctdbd.1
</a>
</li>
<li class="file-stats">
<a href="#6a4db11c5f17f064ab654c12e916d25b8c9f92e8">
ctdb/doc/ctdbd.1.html
</a>
</li>
<li class="file-stats">
<a href="#5e4acee8bd522b931b0ac52250b40b8c62061087">
ctdb/doc/ctdbd.conf.5
</a>
</li>
<li class="file-stats">
<a href="#54f0d4da30d21a0b893d298341c09f79760f1ff4">
ctdb/doc/ctdbd.conf.5.html
</a>
</li>
<li class="file-stats">
<a href="#2097dbfda6f5cb780a636fd916929b31054ddd8c">
ctdb/doc/ctdbd_wrapper.1
</a>
</li>
<li class="file-stats">
<a href="#38dffe33c9623756474b250fa61b9bbe8644fd75">
ctdb/doc/ctdbd_wrapper.1.html
</a>
</li>
<li class="file-stats">
<a href="#1abbc4563e217dafc807f4824b2e10419a31fcf7">
ctdb/doc/ltdbtool.1
</a>
</li>
<li class="file-stats">
<a href="#372a62843b848cad91fb13ba14730ca1d9fa88a3">
ctdb/doc/ltdbtool.1.html
</a>
</li>
<li class="file-stats">
<a href="#0a2e2417e72340b1b7bea2f903aa804c91c6386b">
ctdb/doc/onnode.1
</a>
</li>
</ul>
<h5>The diff was not included because it is too large.</h5>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777777;">
—
<br>
<a href="https://salsa.debian.org/samba-team/samba/compare/6b982e98dd4f8fd189ff82fcb21706462810472d...2dcb0d3216ba74f7e22f4f4b1ec1595f568c8d07">View it on GitLab</a>.
<br>
You're receiving this email because of your account on salsa.debian.org.
If you'd like to receive fewer emails, you can
adjust your notification settings.
</p>
</div>
</body>
</html>