<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>



<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">

<h3>
Mathieu Parent pushed to branch master
at <a href="https://salsa.debian.org/samba-team/samba">Debian Samba Team / samba</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/37d056f4d36dab5787c34a5d846a124c4885fc1d">37d056f4</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-07-12T08:11:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.0pre1...

and re-enable GIT_SNAPSHOT.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/710ce1c39a8885846cc0b62504419405f22f63d2">710ce1c3</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2018-07-12T08:15:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Start release notes for Samba 4.10.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b5a47b84696e8e5c26207bd398742b883e598c2">7b5a47b8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add [un]become_guest() helper functions

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/23319ef5a2eff4811b685d4ab54179efc49bac99">23319ef5</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add smbd_impersonate_debug_create() helper

This will be used to implement no-op impersonation
for the create_conn_struct_as_root() case were we
don't really have other unrelated events in the loop
and only need a valid tevent wrapper context to avoid
double free on the raw event context on teardown.

This also adds useful debugging instead of being
a full no-op wrapper.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5285966e67cbee8519015df12a15e938e85e6ee7">5285966e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add simple noop smbd_impersonate_{conn_vuid,conn_sess,root,guest}_create() wrappers

As a start these are just wrappers arround
smbd_impersonate_debug_create(), without any real impersonation.
But this will change shortly.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0dcaa0707bad67f7bfaa10ccaf167bfefbe87a0c">0dcaa070</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: make use of smbd_impersonate_{conn_vuid,conn_sess,root,guest}_create() wrappers

For now they just add debugging, but that will change shortly.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1b804f7ae23f54a6c1004e5ff17b9df1376b5adb">1b804f7a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: implement smbd_impersonate_{conn_vuid,conn_sess,root,guest}_create() wrappers

This makes sure we're doing the correct impersonation for async
requests, which is a requirement to start adding path based
async SMB_VFS calls.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e37e41b3cac52e3623f0c79f83733a51edb35c10">e37e41b3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: avoid explicit change_to_user() in defer_rename_done() already done by impersonation

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d0b1f96f086bdd613644f64b3f75ee8c4388f674">d0b1f96f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove unused change_to_root_user() from smbd_sig_hup_handler()

This is handled by using the root_ev_ctx in order to register
the signal event.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c310647e560abc2343ef2ff0ab15daab0fba2650">c310647e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-12T12:25:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove unused change_to_root_user() from brl_timeout_fn()

This is handled by using the root_ev_ctx in order to register
the timer event.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/19e4a0857779dd7502d044fc76859bbc202276e2">19e4a085</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: correctly handle pthreadpool_tevent_register_ev() failures

It returns errno values instead of setting 'errno'.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5e723bc6f122223252b8d3c67b7b1f17121dd49a">5e723bc6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: use unsigned for num_idle, num_threads and max_threads

These can't get negative.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53a9f3cac646c1034a15d2b54531b9be46dde923">53a9f3ca</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: explicitly use max_thread=unlimited for pthreadpool_tevent_init() tests

Currently 0 also means unlimited, but that will change soon,
to force no thread and strict sync processing.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65faef959d93221909d3d4031f685a442935ee90">65faef95</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:messages: explicitly use max_thread=unlimited for pthreadpool_tevent_init() in messaging_dgm_init()

Currently 0 also means unlimited, but that will change soon,
to force no thread and strict sync processing.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/03830a3226d43f13e58dcf68874d50e19793144d">03830a32</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: consitently use unlock_res for pthread_mutex_unlock() in pthreadpool_add_job()

This makes further restructuring easier to implement and understand.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e45d33e92e47995faa7c523cf82dfb65efb190f8">e45d33e9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: use strict sync processing only with max_threads=0

Otherwise it's an error if not at least one thread is possible.

This gives a much saner behaviour and doesn't end up with
unexpected sync processing.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c9f54db10911762298d1d4fe681d0aaf705f6f55">c9f54db1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: use talloc_zero() in tests_cmocka.c setup_pthreadpool_tevent()

This was found with valgrind.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f1dac71a866857bc70a0477861997cc6174a00d9">f1dac71a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: fix helgrind error in pthreadpool_free()

We need to pthread_mutex_lock/unlock the pool mutex
before we can destroy it.

The following test would trigger this.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/76474a6fad43c791293f4fb30dc7c155619c5dec">76474a6f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: expand test_create() to check unlimited, sync and one thread pool

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/505d298e81570bb118a9b82e5166a8f11139750b">505d298e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: add pthreadpool_max_threads() and pthreadpool_queued_jobs() helpers

These can be used to implement some kind of flow control in the caller.
E.g. unless pthreadpool_queued_jobs() is lower than
pthreadpool_max_threads() is good to prepare new jobs.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e4dfd3da94c097fa9cd3fea4ad6dfc4af8ca2a45">e4dfd3da</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: add pthreadpool_tevent_max_threads() and pthreadpool_tevent_queued_jobs()

These can be used to implement some kind of flow control in the caller.
E.g. unless pthreadpool_tevent_queued_jobs() is lower than
pthreadpool_tevent_max_threads() is good to prepare new jobs.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e54543b54ea2bc71f5524a41d359376b8f59125">4e54543b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: add pthreadpool_cancel_job()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59768416148f72d87cba80ae21afbb2861ca9442">59768416</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: don't process further jobs when shutting down

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f19552e2390636518dc762bb9dfe25d3407dc521">f19552e2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: split out a pthreadpool_stop() from pthreadpool_destroy()

This can be used in combination with pthreadpool_cancel_job() to
implement a multi step shutdown of the pool.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cdbad9041b8afd3f0436fbeb5d6b50f9f1ada60d">cdbad904</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: let pthreadpool_tevent_job_send() fail with an invalid pool

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/245d684d28dab630f3d47ff61006a1fe3e5eeefa">245d684d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: split out pthreadpool_tevent_job from pthreadpool_tevent_job_state

This makes it much easier to handle orphaned jobs,
we either wait for the immediate tevent to trigger
or we just keep leaking the memory.

The next commits will improve this further.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/791c05144ee9296024cc0fdebe4afeaaf67e26bc">791c0514</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: add pthreadpool_tevent_job_cancel()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fa070d90074629cb8262bc4e2a6ceef57a9fbd5c">fa070d90</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: make use of pthreadpool_stop() in pthreadpool_tevent_destructor()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/25756425aaf5465e56ea809cd415b6a387848919">25756425</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T12:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: maintain a global list of orphaned pthreadpool_tevent_jobs

Instead of leaking the memory forever, we retry the cleanup,
if other pthreadpool_tevent_*() functions are used.

pthreadpool_tevent_cleanup_orphaned_jobs() could also be called
by external callers.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3eee52b44daa8544e1c1fb609f901a3a96b29b25">3eee52b4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-12T15:18:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: allocate glue->tctx on glue as memory context.

This means it will go aways together with glue and thte event context.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Jul 12 17:18:01 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ce9ac51ee223271a789fa7aee215acd383fa33a3">ce9ac51e</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-07-12T20:11:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Fix asserts in gpo testing

These tests weren't using python's unit testing
asserts.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2494e33822276cc6a8836121b3012f9e94b9fddf">2494e338</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-07-12T20:11:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Disable python3 testing

The gpo module doesn't work in python3 yet,
causing this test to fail on python3.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13525

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c7348e44d10ca519dd1322fd40b12c69e17a8e6">4c7348e4</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-07-12T20:11:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Allow forced signing via smb.SMB()

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/57faf35cf836e675e088b3a6e6e455c1309fd4ea">57faf35c</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-07-12T20:11:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Read GPO versions locally, not from sysvol

Non-kdc clients cannot read directly from the
sysvol, so we need to store the GPT.INI file
locally to read each gpo version.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2412c70481fe22fb9e266e6ef1a1cd86fb39a1e5">2412c704</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-07-12T20:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Offline policy application via cache

Read policy files from the cache, rather than
the sysvol. This enables offline policy apply.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/46629f53217f269c3bea044b054e62381149443c">46629f53</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-07-12T20:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">param: Add python binding for lpcfg_state_path

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/387dc358d3a2bd33bca7d7bcbcb2668eae6c0bd5">387dc358</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-07-12T20:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: add register_gp_extension for registering gp extensions

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b4f09af27abc8da260a1c1b2ea074f9f6e5ce56b">b4f09af2</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-07-12T20:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: add unregister_gp_extension for unregistering gp extensions

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4436b6703c081d0479af407d4c8ea28f5a323f88">4436b670</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-07-12T20:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: add list_gp_extensions for listing registered gp extensions

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fb6c250bdeebfd00d1605dd76ac54d1013ea4ba2">fb6c250b</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-07-12T20:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Tests for gp_ext register/unregister

Adds testing for the gp_ext register and
unregister functions, as well as testing
the list function.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/126b789268a3a21ee4d5769290b69d45860bb608">126b7892</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-07-12T20:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Dynamically load gp_exts

This loads Group Policy Client Side Extensions
similar to the way that they are loaded on a
Windows client. Extensions are installed to a
configuration file in the samba cache path where
they receive a unique GUID matched with the path
to the python gp_ext file. Classes which inherit
from the gp_ext class (as defined in gpclass.py)
will be dynamically loaded.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de8b30a726bcef3f8c5e37b1f27c97020f4fb051">de8b30a7</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-07-12T20:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Add user policy extensions

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b05b6198a3fa480e7026145bfd0608e41fd3f326">b05b6198</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-07-12T20:11:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Don't duplicate guids in the apply log

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f3358f048d7583bb63cb0f09efdd68fbbe49d32e">f3358f04</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-07-12T23:05:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Specify samba module when importing from gpclass

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Jul 13 01:05:22 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b164637f03b5d19054d286f883b9ce3bc30d76d">9b164637</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-07-12T23:12:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samdb: use int for get and set methods instead of digit str

This will make the API work in a nature way.

Also, because of a defect in ldb API, code like `res[0]["maxPwdAge"][0]`
will return bytes even in Python3, which will cause trouble. By casting
the value to int, we avoid the str/bytes issue.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5b96e349817eb28060b16095c907319c438cd670">5b96e349</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: Py2/Py3 allow import of ndr_(un)pack to work

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d5cd9af7b502f8cb3b0a6917bf5cc0a741bac454">d5cd9af7</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: Py2/Py3 port for hexdump

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d435711692a7c6485bb13e626727400d01d21e3">7d435711</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/emulate: Fix some more missed exception tuple assignments

In python3 we need to change

    except LdbError as e:
-        (status, _) = e
to
    except LdbError as e:
+        (status, _) = e.args

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/337ae8cd586aeb43721f79485f6a35a68b6060f2">337ae8cd</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: remove Py2 specific imports.

Remove some python2 specific import, probably this was due to
previous unavailability for some c-modules in python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b170206b45e2c10af1591f3a8d6565a1ae3853c">7b170206</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/ldb: Implement a bytes derived object for attributes py2/py3

ldb attributes are either bytes (py3) or str (py2)

Some places in the code do str(res[0]['attribute'][0])
which results in
   'result' (py2)
  b'result' (py3)

or more commonly the attribute is used to construct a string e.g.
   "blah=" + res[0]['attribute'][0] + ",foo,bar=...."

giving
   "blah=result,foo,bar=...." (py2)
and very unhelpfully
   "blah=b'result',foo,bar=...." (py3)

lots of code already constructs various strings for passing to other
api using the above. To avoid many excessive
    res[0]['attribute'][0].decode('utf8')

code like 'res[0]['attribute'][0]'

will now return LdbBytes (a new object subclassing 'bytes') in py3
instead of bytes. This object has a custom '__str__' method which
attempts to return a string decoded to uft8. In Py2 this will behave as
it did previously (this is the safer option at the moment)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e915d18e559370ee661d24d9682f0ba8e138ace8">e915d18e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs/python: Py2/Py2 fix tab/space also incorrect unicode usage

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/352eee57ae0b3cd48ea8bab33d483812d57b8efd">352eee57</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: fix py2/py3 bytes usage for replace

base64.b64encode returns bytes in py3 make sure associated replace
uses 'b' for strings passed to replace

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c46fd168fc1c0021e97f849088ac634c1b077f27">c46fd168</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: Protect variable that can be None

In py3 None variable cannot be compared with '>' '<' etc operators

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bbc5d3147064e211df0619689945ea32468f5460">bbc5d314</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: Fix relative module import

Part of future changes needed to enable samba4.drs.replica_sync_rodc
for PY3.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/883c3d8d646135c182db3c6f4085edb052929bcf">883c3d8d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/librpc/ndr: allow GUID to accept unicode also

This needed since _GUID_string method change
(in source4/torture/drs/python/drs_base.py) which makes use use
a unicode guid at times now

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a2c22136ba63eb994faa6b2eeda342dd5491d49">2a2c2213</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests/python: base64.b64encode returns bytes

adjust to unicode for py2/py3 compat needed as part of changes
to ensure samba4.ldap.password_settings will work with PY3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/343dc311486a07be0830e15311c548d1ab53b7cf">343dc311</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs: ndr_upack needs bytes in py3 (samba4.drs.repl_move)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/06d3eac8a1f74b2954f6ca01a8ee3c33c23f1df5">06d3eac8</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs/python: py2/py3 port map / ord usage

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e930dfb477b121b69351cc9a011dfb71bcd10c0">0e930dfb</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: Add cmp_fn and cmp_to_key_fn functions for py2/py3

the cmp function and the cmp paramater (e.g. to sort functions)
no longer exist in python3.

cmp_fn is provides the missing functionality of the py2 cmp builtin
function.

cmp_to_key_fn allows the key paramater (e.g. for sort) to use the
old py2 cmp function for sorting. Note: the cmp_to_key is present in
since 2.7 (hence the inclusion of the source code for this function pre
that version)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77ee94c3df1180da5cb6c7cc478bd814e1d02258">77ee94c3</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs/python: use cmp_fn and key=cmp_to_key_fn for py2/py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/409ad5c0f07445ea7d12466b56fbfbccfe71c2d1">409ad5c0</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs/python: use cmp_fn for cmp (for py2/py3 compat)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/08c9ce41e91c5e68aa116e5b5b2bae97353f2fbc">08c9ce41</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs/python: long is not used in py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fee61c57348d6964f61b27feef9d27b70889ed49">fee61c57</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs/python: xrange -> range for py2/py3 compat

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f59a20eb3b20b12fbf128b93c2a7a768be89e656">f59a20eb</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torure/drs/python: Fix incorrect use of unicode which doesn't exist in py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1a9786fe585d0354c20585768e8bd057a1473650">1a9786fe</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: various py3 porting for ord/chr

various messages are lists of ints that need converting to str or bytes
depending on py2/py3, others are str/bytes that need modification and
are converted to lists or string char or ints for modificate (and then
reconstructed as str/bytes again)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d96d85a22be6da5b627ea6de212e99b8d08dca94">d96d85a2</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-12T23:12:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/kcc: md5 needs to be passed bytes in py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8d9751344c75f1f343b857db82f689847628adc">f8d97513</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-13T02:01:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: Fix wrong exception referenced in code

post commit: 52729d35495db638c84caa8cc6f5ffdf0b670353 wrong
exception name was referenced.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Jul 13 04:01:59 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c406a5bef93da2c36d5635115170b23d33ecd974">c406a5be</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2018-07-13T09:44:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: mention that the echo handler is for SMB1 only

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Karolin Seeger <kseeger@samba.org>

Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Fri Jul 13 11:44:02 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1c8d1cceff852acaca4a0ec0da37b053ed03fe4a">1c8d1cce</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-07-13T09:45:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Test SMB1 cli_splice() fallback path when doing a non-full file splice.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13527

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c9656fd2977557ab20ec4e3d87c385a9b2f1bf43">c9656fd2</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-07-13T12:57:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmbclient: Fix cli_splice() fallback when reading less than a complete file.

We were always asking for SPLICE_BLOCK_SIZE even when the
remaining bytes we wanted were smaller than that. This works
when using cli_splice() on a complete file, as the cli_read()
terminated the read at the right place. We always have the
space to read SPLICE_BLOCK_SIZE bytes so this isn't an overflow.

Found by Bailey Berro <baileyberro@google.com>

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13527

Signed-off-by: Bailey Berro <baileyberro@google.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>

Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Fri Jul 13 14:57:14 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e123c46820e737968fa3d1c594aa016cca39637">4e123c46</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-07-13T15:45:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba/samba_abi: always hide ABI symbols which must be local

binutils 2.31 is going to change how shared libraries are linked, such
that they always provide their own local definitions of the _end, _edata
and _bss_start symbols.  This would all be fine, except for shared
libraries that export all symbols be default.  (Rather than just
exporting those symbols that form part of their API).

According to binutils developers, we should only export the symbols we
explicitly want to be used. We don't use this principle for all our
libraries and deliberately don't want to have ABI versioning control for
all of them, so the change I introduce here is to explicitly mark those
symbols that will always be added by default linker configuration with
binutils 2.31 as local. Right now these are '_end', '_edata', and
'__bss_start' symbols.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Jul 13 17:45:36 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/49d6c3f061284aac31c3ef21f88f9d69bdd86bd8">49d6c3f0</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-07-13T22:14:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: adjust SMB1 cli_splice() test sizes

The test writes 20M and then splices just over 1M (13M is intended,
but there's a 1024*0124 typo). Fix the type and reduce the size of the
dataset to make it run faster - cli_splice works with 1M chunks
(SPLICE_BLOCK_SIZE), and the reproducer only requires that the splice
size is not chunk-aligned.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Jul 14 00:14:13 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/26fd7096b1f99a2754f634669d5432109023bfa5">26fd7096</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-07-14T01:09:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-tldap: do not install test_tldap

Guenther

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13529

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Jul 14 03:09:00 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8cb96438bf1540ec76e759135863202bdef6ee35">8cb96438</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-07-16T19:11:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap: determine basename once instead of three times

Currently determined twice in the clear-if-first codepath and once in
the ctdb code path. Do it once at the top of the function.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Mon Jul 16 21:11:30 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3761d42e4fe563ad893f14468e98bd1f5a807604">3761d42e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-17T11:33:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: fix CID 1437976 dereference before null check

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba991da43469a1844b67fcec19a15ceda409fc3f">ba991da4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-17T14:21:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: fix CID 1437974 dereference after null check

Probably a copy/paste error from the tevent_debug() statement a few
lines above as at this place we want to pass main_ev directly to
tevent_debug() anyway.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Jul 17 16:21:21 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/725319743f1f2de934cbde477ca84430f5b2b4b4">72531974</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-17T22:04:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: run test_durable_v2_open_reopen2_lease() in a subdirectory

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13535

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e60e9368cb3cb512e2506620d814187a692108e0">e60e9368</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-17T22:04:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: fix path check in smbd_smb2_create_durable_lease_check()

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13535

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2e65a1262a23c200fdbc0bc6ef90eb116e3068a8">2e65a126</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-17T22:04:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kcc: Fix the 32-bit build

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b0c1f8f19c52e97dc987d16cc438eecf6cb830f">7b0c1f8f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-18T01:12:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Fix the 32-bit build

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jul 18 03:12:02 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da115efd2b89e10767e9bec7343dce65ffd3c68b">da115efd</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-18T09:51:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Simplify pstree output in eventd unit tests

pstree truncates output when it exceeds a maximum width - the default
is 132 columns.  A couple of recent
commits (12fd8d7a5c5d14d403aac6cd9e318afcd0a8e159,
b23f3f996038626f618c5b5aa552686c1b852f44) lengthened the command
string in the output so that it is more likely to exceed this limit
and be truncated, as below:

==================================================
Running "cat /memdisk/autobuild/fl/b1851760/ctdb/ctdb/tests/var/eventd/debug_script.log"
--------------------------------------------------
Output (Exit status: 0):
--------------------------------------------------
02.enabled.scri,PID /memdisk/autobuild/fl/b1851760/ctdb/ctdb/tests/var/eventd/events/random/02.enabled.script ...
  `-sleep,PID 99
01.disabled          DISABLED
02.enabled           TIMEDOUT   DATETIME
  OUTPUT: Sleeping for 99 seconds
--------------------------------------------------
Required output (Exit status: 0):
--------------------------------------------------
02.enabled.scri,PID /memdisk/autobuild/fl/b1851760/ctdb/ctdb/tests/var/eventd/events/random/02.enabled.script verbosetimeout
  `-sleep,PID 99
01.disabled          DISABLED
02.enabled           TIMEDOUT   DATETIME
  OUTPUT: Sleeping for 99 seconds

FAILED

It isn't clear that the above example exceeds 132 characters, given
that the PID has been filtered into a fixed string, but it certainly
goes close.  Whether or not it is truncated probably depends on the
width of the PID in the unfiltered output.  This would explain why the
test flaps.

Avoid the output truncation by dropping the -a and -p options to
simplify the pstree output.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13531

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/359e52187fbc9b5f94570ff8d12607b4fc42e4f2">359e5218</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-18T12:53:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Loosen match against pstree output in simple test

As per previous commit, pstree can truncate output if it gets too
wide.  Instead of matching against the script's full path and
arguments, just match against the script name.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13531

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed Jul 18 14:53:39 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0d3aec18679a2637430263a55de5e210a9201e21">0d3aec18</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-19T23:47:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns wildcards: tests to confirm BUG 13536

DNS wildcard matching failing if more than one label to the left of the
wildcard. This commits adds tests to confirm the bug.

Wildcard entry: *.example.org
bar.example.com matches
foo.bar.example.com does not, but it it should.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cef1b31cd1f33074e8ab6de52aa0fb74e9b57a9f">cef1b31c</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-20T02:40:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns wildcards: fix BUG 13536

The current position in the dns name was not advanced past the '.'
character

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jul 20 04:40:31 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/809967b3eab7a1b48c186517701538ca93536246">809967b3</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-07-20T10:25:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix Linux sendfile() for SMB2. Ensure we don't spin on EAGAIN.

For SMB2 the socket is set non-blocking. Ensure sendfile()
calls complete if they return EAGAIN by saving the socket state,
setting it blocking, doing the sendfile until completion and then
restoring the socket state.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/16a587075c8c62c1160869358ca56a133e90247a">16a58707</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-07-20T10:25:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix Solaris sendfile() for SMB2. Ensure we don't spin on EAGAIN.

For SMB2 the socket is set non-blocking. Ensure sendfile()
calls complete if they return EAGAIN by saving the socket state,
setting it blocking, doing the sendfile until completion and then
restoring the socket state.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d222caa449d9c00bb2dd9da6c79ea509960d47c6">d222caa4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-07-20T10:25:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix HPUX sendfile() for SMB2. Ensure we don't spin on EAGAIN.

For SMB2 the socket is set non-blocking. Ensure sendfile()
calls complete if they return EAGAIN by saving the socket state,
setting it blocking, doing the sendfile until completion and then
restoring the socket state.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/456e520a3be7e4b54f1f144324c3671b8f6e35ea">456e520a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-07-20T10:25:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix FreeBSD sendfile() for SMB2. Ensure we don't spin on EAGAIN.

For SMB2 the socket is set non-blocking. Ensure sendfile()
calls complete if they return EAGAIN by saving the socket state,
setting it blocking, doing the sendfile until completion and then
restoring the socket state.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/582ce5d6b599516d6d8d619529a2aa809139a175">582ce5d6</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-07-20T13:14:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix AIX sendfile() for SMB2. Ensure we don't spin on EAGAIN.

For SMB2 the socket is set non-blocking. Ensure sendfile()
calls complete if they return EAGAIN by saving the socket state,
setting it blocking, doing the sendfile until completion and then
restoring the socket state.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Jul 20 15:14:24 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2114768a8e64647e4f429e0b4e464e0cfc056feb">2114768a</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-07-23T14:24:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-dns_server: Only build dns server Python code for AD DC

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13542

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1faaeb00b5b8217c7a2cb145673ceba847b94cf2">1faaeb00</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-07-23T14:24:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-dsdb: only build dsdb Python modules for AD DC

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13542

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6de9d878b5f63e5b5ac7f8b5dd2ca50e4ba8fa1a">6de9d878</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-07-23T17:36:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: make sure samba.tests can be imported without SamDB

We are using samba.tests Python module __init__.py file as a catch-all
for all types of helpers. Some of these helpers are only usable with
Samba AD DC targets.

When SamDB is not available in a non-Samba AD DC target, provide a
dummy replacement that simply returns None. This allows to complete
initialization for non-Samba AD DC target tests which do not use
connect_samdb() helper.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13542

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Mon Jul 23 19:36:56 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/062b518cabd9fb5f72f96cdf400c978c0b844619">062b518c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T04:55:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: add binding handle support for [smb1]

This will be used to force smb1.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/17b12a9b9a9dfd859679de77aa0c7ffbc782f1bc">17b12a9b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T04:55:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: split out smb_raw_negotiate_fill_transport()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b7e99c2571e31971a6d7f1898e7458c16dc1031e">b7e99c25</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T04:55:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: add smbcli_transport_raw_init()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87d73397f9a9dee8fa0055a2ff08244b2c85e120">87d73397</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T04:55:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: use talloc_zero() for struct smb_composite_connect in fetchfile.c

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2b68f9b8b0dd944fa89b9e0037886ddd4fb4e5f9">2b68f9b8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T04:55:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: allow passing an already negotiated connection to smb_composite_connect()

It will just do the session setup and tree connect steps.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ce2248c4b5aad2d00155a2e77b3e6340ce824979">ce2248c4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T04:55:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: add smb2_transport_raw_init()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ad5b81b6ef601596583b4ad7d6a14241fa99a71">5ad5b81b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T04:55:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: split out smb2_connect_session_start()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f20e607c15b4c8ae56ade5d7e68d832542a2cd5e">f20e607c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T04:55:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: allow passing an already negotiated connection to smb2_connect_send()

It will just do the session setup and tree connect steps.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ca000d8901e6acb8a7c59d26d4f75c9d92bafece">ca000d89</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T04:55:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: add fallback_to_anonymous to smb2_connect_send()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5188454bdce80f6e2bfc45deca18bd1b7289a7a6">5188454b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T04:55:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: allow a fallback to NTLMSSP if SPNEGO is not supported locally

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e4910f35eab008a41cfcac3d97b3647c721ac679">e4910f35</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T04:55:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: add smb_connect_nego_{send,recv}()

This can be used to create a connection up to a negotiated
smbXcli_conn.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70a9cf9ccfc4075cc08209191db1bce2c9b432fc">70a9cf9c</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-07-24T04:55:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/auth_log: Permit SMB2 service description if empty binding is used for kerberos authentication

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/802e43bf742e756896fa73fcd139feca9ae293dd">802e43bf</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T04:55:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests: use explicit "client ipc max protocol = NT1" for samba.tests.net_join_no_spnego

The tests rely on SMB1.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4422f7382aad3090cb959ade030a02bf4fef81ac">4422f738</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T04:55:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:librpc: autonegotiate SMB1/2/3

Windows Server 1709 defaults to SMB2 and does not have SMB1 enabled.
When establishing trust, samba-tool does not specify SMB protocol
version and fail by default.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6800077c5c57c257326573537d1f2bb7a8066149">6800077c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T04:55:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:selftest: run rpc.lsa.lookupsids also with explicit [smb1] and [smb2]

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c390728819e73cefbf02e0d52d22805930f4c45b">c3907288</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-07-24T07:55:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool trust: support discovery via netr_GetDcName

In case a remote DC does not support netr_DsRGetDCNameEx2(),
use netr_GetDcName() instead.

This should help with FreeIPA where embedded smbd runs as a domain
controller but does not implement full Active Directory compatibility.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13538

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Tue Jul 24 09:55:23 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9d31bbf9793ca9d2041eb8769511aca6c9684e94">9d31bbf9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T15:38:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: use talloc_zero_size() for the private state in tevent_context_wrapper_create()

This is watch tevent_req_create() uses and what callers of
tevent_context_wrapper_create() would therefore also expect.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/26b35cb20c604afa6db19912e3ff43978dbece61">26b35cb2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T15:38:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: make sure a pthreadpool is marked as stopped in child processes

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/617d9c877df4af1ccc5b36f95dea3301e9a46d9d">617d9c87</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T15:38:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: test pthreadpool_tevent_max_threads() returns the expected result

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c51cae583fd119db613c62bd53070d7d53227c56">c51cae58</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T15:38:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: replace assert_return_code(ret, 0); with assert_int_equal(ret, 0);

We need to assert the exact value!

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2ebb5847defce888c3177d6564a3d7dcc0ed47e4">2ebb5847</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T15:38:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/replace: check for __thread support

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f8c1b6736875d63c11f8630ecf1c8d3dcd70fc5">6f8c1b67</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T15:38:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party/*_wrapper/wscript: remove redundant configure checks

HAVE___THREAD and HAVE_DESTRUCTOR_ATTRIBUTE are already checked
as part of Samba.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5fa5764f30c47b46f12ceb7637985e8def0190ca">5fa5764f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T15:38:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: add checks for atomic_thread_fence(memory_order_seq_cst) and add possible fallbacks

This implements a full memory barrier.
On ubuntu amd64 with results in an 'mfence' instruction.

This is required to syncronization between threads, where
there's typically only one write of a memory that should be
synced between all threads with the barrier.

Much more details can be found here:
https://gcc.gnu.org/onlinedocs/gcc-7.3.0/gcc/_005f_005fatomic-Builtins.html#g_t_005f_005fatomic-Builtins
https://gcc.gnu.org/onlinedocs/gcc-7.3.0/gcc/_005f_005fsync-Builtins.html#g_t_005f_005fsync-Builtins

The main one we use seems to be in C11 via stdatomic.h,
the oldest fallback is __sync_synchronize(), which is available
since 2005 in gcc.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9656b8d8ee11ee351870286f16ea8fbe49112292">9656b8d8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T15:38:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: add some lockless coordination between the main and job threads

In the direction from the main process to the job thread, we have:

- 'maycancel', which is set when tevent_req_cancel() is called,
- 'orphaned' is the job request, tevent_context or pthreadpool_tevent
  was talloc_free'ed.

The job function can consume these by using:

   /*
    * return true - if tevent_req_cancel() was called.
    */
   bool pthreadpool_tevent_current_job_canceled(void);

   /*
    * return true - if talloc_free() was called on the job request,
    * tevent_context or pthreadpool_tevent.
    */
   bool pthreadpool_tevent_current_job_orphaned(void);

   /*
    * return true if canceled and orphaned are both false.
    */
   bool pthreadpool_tevent_current_job_continue(void);

In the other direction we remember the following points
in the job execution:

- 'started'  - set when the job is picked up by a worker thread
- 'executed' - set once the job function returned.
- 'finished' - set when pthreadpool_tevent_job_signal() is entered
- 'dropped'  - set when pthreadpool_tevent_job_signal() leaves with orphaned
- 'signaled' - set when pthreadpool_tevent_job_signal() leaves normal

There're only one side writing each element,
either the main process or the job thread.

This means we can do the coordination with a full memory
barrier using atomic_thread_fence(memory_order_seq_cst).
lib/replace provides fallbacks if C11 stdatomic.h is not available.

A real pthreadpool requires pthread and atomic_thread_fence() (or an
replacement) to be available, otherwise we only have pthreadpool_sync.c.
But this should not make a real difference, as at least
__sync_synchronize() is availabe since 2005 in gcc.
We also require __thread which is available since 2002.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/30c97da7a7ff96777f6fdfc13a791b6893cf8c48">30c97da7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T15:38:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:wscript: don't check for valgrind related headers twice

We already check them in lib/replace/wscript.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/66aaa22f0f6746d2ef9a719adfdad70600287c9d">66aaa22f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T15:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/replace: also check for valgrind/helgrind.h

This will be used in lib/pthreadpool/pthreadpool_tevent.c
in order to avoid extected helgrind/drd warnings.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b73fda926eb8493e80012794483039be66d4e6c">9b73fda9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T15:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: add helgrind magic to PTHREAD_TEVENT_JOB_THREAD_FENCE_*()

This avoids the expected helgrind/drd warnings on the job states which
are protected by the thread fence.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa9b64eccfd037941512bad108c4e3946714a502">aa9b64ec</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T15:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: maintain a list of job_states on each pthreadpool_tevent_glue

We should avoid traversing a linked list within a thread without holding
a mutex!

Using a mutex would be very tricky as we'll likely deadlock with
the mutexes at the raw pthreadpool layer.

So we use somekind of spinlock using atomic_thread_fence in order to
protect the access to job->state->glue->{tctx,ev} in
pthreadpool_tevent_job_signal().

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f23cac39b36b026650e0922c78fe0fd3fe567e35">f23cac39</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T15:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: add a comment about a further optimization in pthreadpool_tevent_job_destructor()

This seems to be a really rare race, it's likely that the immediate
event will still trigger and cleanup.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/40d15260d24d0071732f47873f395fce29b8a6f4">40d15260</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-24T15:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: test cancelling and freeing pending pthreadpool_tevent jobs/pools

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7cb27238fe4e6dfc45cf3128ccd4a392aaf4e877">7cb27238</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-24T15:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">configure: check for Linux specific unshare() with CLONE_FS

Note we still need some kind of runtime detection as
it can fail in some constraint container setups, which
reject the whole unshare() syscall instead of just the
once used for container features.

In case unshare(CLONE_FS) works, we can have a per thread
current working directory and use [f]chdir() safely in
worker threads.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65e4742d168454df6507d9e74993749063435dd6">65e4742d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-24T15:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: call unshare(CLONE_FS) if available

This paves the way for pthreadpool jobs that are path based.

Callers can use pthreadpool_per_thread_cwd() to check if
the current pool supports it.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/12a45ee1a66379ba7562729b835ce0e2e4bfb3b3">12a45ee1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T15:38:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: add pthreadpool_tevent_[current_job_]per_thread_cwd()

This can be used to check if worker threads run with
unshare(CLONE_FS).

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fbafdc99ef2cef11a1a28e795ffe965cb53ef7fa">fbafdc99</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T15:38:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: add tests for pthreadpool_tevent_[current_job_]per_thread_cwd()

Note this currently this doesn't enforce the support for
unshare(CLONE_FS) as some contraint container environment
(e.g. docker) reject the whole unshare() system call.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3c4cdb290723432b00ff9ff88b892cb4e66e76cd">3c4cdb29</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T15:38:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: add pthreadpool_restart_check[_monitor_{fd,drain}]()

This makes it possible to monitor the pthreadpool for exited worker
threads and may restart new threads from the main thread again.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f9745d8b5234091c38e93ed57a255120b61f3ad7">f9745d8b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T15:38:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: implement pthreadpool_tevent_wrapper_create() infrastructure

This can be used implement a generic per thread impersonation
for thread pools.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fb6b6cf3e43165ced4b1039f2683d19f277c0792">fb6b6cf3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-24T15:38:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: test cancelling and freeing jobs of a wrapped pthreadpool_tevent

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0d2eeb9422bf3fb3097637c63d9e7c8bd20417af">0d2eeb94</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-24T15:38:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/util: rename USE_LINUX_THREAD_CREDENTIALS to HAVE_LINUX_THREAD_CREDENTIALS

The define reflects the results of a feature test, not a configure
option.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/10fc65b74d7b94e0e6454c704b63c138d1d54bd1">10fc65b7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T18:35:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:util_sec: add a cache to set_thread_credentials()

Calling set_thread_credentials() with the same values,
skips syscalls the 2nd time.

We only do this if '__thread' is supported to provide
thread local storage.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Jul 24 20:35:17 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a91ba4f7eacf2a2043068c3680a3bc47fb5d26c">6a91ba4f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-24T18:36:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove an #include "includes.h"

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a845e9614742dbde40070ab0f2589505ee0ed2aa">a845e961</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-24T18:36:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove an #include "includes.h"

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7daf5e627690350f19482cf0b72b070a09fd4235">7daf5e62</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-24T18:36:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Fix prototype of srprs_str

Many callers use "-1" as the "len" argument. That's what ssize_t is for.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3c9b88ba1c79c6927e5e905afbef225de02eee9d">3c9b88ba</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-24T18:36:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Remove IRIX support

According to wikipedia, IRIX has seen the last patch update in August 2006. As
of now, www.sgi.com is unreachable. Probably this code has not been built in
years. If someone wants to revive it, it can be found in the git history.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d4c6b009223c1ed6caf538c35b42e16c98e2bded">d4c6b009</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-24T18:36:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Make two functions static

nss_irix was the only external user

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da179b1e4c54bec67214546973ced7a16e4caec5">da179b1e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-24T18:36:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Correct users of "ctx->is_privileged"

winbindd_context->is_privileged is a bool

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8a530433e0499f2c1a14a801e49e5ecf0a13dc74">8a530433</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-24T18:36:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Align integer types

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d40f6079926ae93406b0c09ea5111e643b29a00">7d40f607</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-24T21:31:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Move variable declarations close to their use

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jul 24 23:31:43 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/010bbe536e26a31bcb7d36cc946b1982247b4443">010bbe53</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-24T22:23:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: add some basic tests for the all static build

This makes sure each module is at least loaded once
and registers itself as a module.

It means that the skel_opaque and skel_transparent vfs examples
are loaded.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b294c7c666d56f64d55b71bf9bf2e1223df1d6ef">b294c7c6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-24T22:23:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">examples/VFS/skel_opaque: add missing audit_file_fn

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d1633532a929c04c54c64ce49061e2eed590c3c2">d1633532</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-24T22:23:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">examples/VFS/skel_opaque: add missing durable handle functions

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f9db9aeeab9ce1e36b5af8784fd5e5c9c4014fe8">f9db9aee</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T22:23:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">examples/VFS/skel_opaque: call smb_vfs_assert_all_fns()

This template should always implement all calls.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/68b8e5a5197898091041af887211caad4196ae07">68b8e5a5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-24T22:23:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">examples/VFS/skel_transparent: add missing audit_file_fn

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/829fdf10303fed8ed0e972cc2391bc88eebb3bb6">829fdf10</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-24T22:23:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">examples/VFS/skel_transparent: add missing durable handle functions

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/42e99ec331dd667f145389683d7a0d8d310a8275">42e99ec3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T22:23:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">examples/VFS/skel_transparent: call smb_vfs_assert_all_fns()

This template should always include all calls.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1bc92d1090cb26b66c84e46b76411e6481869866">1bc92d10</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-24T22:23:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_default: call smb_vfs_assert_all_fns()

This module needs to implement every call.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d1de8bd48c0ea1e0ddd9f103d6fb1c7c3855c93">7d1de8bd</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-24T22:23:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: lib/xattr_tdb: fix listing xattrs

If there's no record in the xattr.tdb, dbwrap_fetch() will return
NT_STATUS_NOT_FOUND. That should not result in an error in callers of
xattr_tdb_load_attrs().

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/76c68bc20f06e3e6244ef1a6b0d4b43be8ebea42">76c68bc2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-24T22:23:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: libcli/smb2: calculate correct credit charge for finds

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/580ff206431969dc2924d520053b956b7169ca07">580ff206</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-24T22:23:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: use smb2cli_conn_max_trans_size() in cli_smb2_list()

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/27bb2cbc2ed6e5f3309a4abb1d7f74e3c4a21830">27bb2cbc</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-24T22:23:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_default: fix async fsync idle/busy time profiling

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/83f01b0212cbdd9af88a46a8f1c5c27626e63537">83f01b02</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-24T22:23:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs: add missing tevent_req_received() to SMB_VFS_PREAD_RECV()

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d769e9ea4087dc8e7224f440db6801e0a8a2d801">d769e9ea</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-24T22:23:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs: add missing tevent_req_received() to SMB_VFS_PWRITE_RECV()

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/55097f7d1d836471363011a8777224af0c772905">55097f7d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-24T22:23:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs: add missing tevent_req_received() to SMB_VFS_FSYNC_RECV()

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b2ae22a310c07da61ca5d57cba1b403851e928d9">b2ae22a3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-24T22:23:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs: bump to version 39, Samba 4.9 will ship with that

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1e78cb57f663fa3592655d9b8dfa25ae9a81ff7d">1e78cb57</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-25T01:23:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs: bump to version 40, Samba 4.10 will ship with that

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Jul 25 03:23:44 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f1de9ff09b819a07dbee4945499b1f00217970b">7f1de9ff</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-07-25T01:24:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: SGI IRIX is officially dead. Remove the kernel oplock code for IRIX.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e2ebfd8e082fef59791947a24d61bfc50eec8596">e2ebfd8e</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-07-25T04:28:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs/kerneloplocks: drop Irix references

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jul 25 06:28:21 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/79f494e51eabb5176747fcf3b9f2efad10ec7f97">79f494e5</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-25T04:29:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">json: Modify API to use return codes

Modify the auditing JSON API to return a response code, as the consensus
was that the existing error handling was aesthetically displeasing.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f4f8c51e0acd92aae1b57041cf787706820db77">6f4f8c51</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-25T04:29:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">json: Add unit tests for error handling

Add cmocka unit tests to exercise the error handling in the JSON
routines.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a5172ee74971bda3c9f7c94bce3afbcc89ae288a">a5172ee7</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-25T04:29:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb audit logging: remove HAVE_JANSSON from audit_log

This modules is ADDC only and JANSSON is required for the ADDC builds,
so the ifdef is no longer necessary.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77fa34080c4a9fa39134ea0997870b82a49b500c">77fa3408</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-25T04:29:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb group auditing: remove HAVE_JANSSON from group_audit

This modules is ADDC only and JANSSON is required for the ADDC builds,
so the ifdef is no longer necessary.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a5346f166ac1a9b03bca76dc40d3645432377df">6a5346f1</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-25T04:29:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb group_audit_test: Remove redundant mocking code

Remove a place holder test and unused mocking code.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a5e02f7264a5feb9f0a5bb3d84de0153dc0758a0">a5e02f72</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-25T07:28:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib audit_logging: add _WARN_UNUSED_RESULT_

Have the compiler issue a warning when the return code from the API is
ignored.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Wed Jul 25 09:28:31 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3fd1a41f6867f0b9b62d0eeee82fcbbfcf38c003">3fd1a41f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-25T15:49:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: add a missing include

Reported-by: David Disseldorp <ddiss@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5cb94ca028c3fccd9a778123834bb2681aa73136">5cb94ca0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-25T15:49:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: only pass struct smbXsrv_client to smb1srv_tcon_disconnect_all()

That's all it needs.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/984872731a235cf4c37c18b09a4e70795a76da93">98487273</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-25T15:49:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: only pass struct smbXsrv_client to smbXsrv_session_logoff_all()

That's all it needs.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8d4792e68604c2ea96bb179774e4745d49d8bade">8d4792e6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-25T15:49:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: disconnect/destroy all connections before calling smbXsrv_session_logoff_all()

This means the pending requests are destroyed before tevent_context
impersonation wrapper are destroyed.

Otherwise, with a pending struct tevent_req that is a child of
client->xconn like this in exit_server_common():

conn[ipv4:127.0.0.11:40745] reason[NT_STATUS_CONNECTION_RESET] at ../source3/smbd/smb2_server.c:4015
full talloc report on 'struct smbXsrv_connection' (total   6085 bytes in  43 blocks)
    struct smbd_smb2_request       contains    648 bytes in   1 blocks (ref 0) 0x55ed41634740
    struct smbd_smb2_request       contains   3438 bytes in  32 blocks (ref 0) 0x55ed416331e0
        struct tevent_req              contains   1824 bytes in  20 blocks (ref 0) 0x55ed41635860
            struct smb_filename            contains    206 bytes in   2 blocks (ref 0) 0x55ed41635560
                lease_v2_complex2.dat          contains     22 bytes in   1 blocks (ref 0) 0x55ed4161b950
            struct smbd_smb2_create_state  contains   1386 bytes in  16 blocks (ref 0) 0x55ed41635a10
                struct deferred_open_record    contains    804 bytes in  12 blocks (ref 0) 0x55ed41633090
                    struct defer_open_state        contains    764 bytes in  11 blocks (ref 0) 0x55ed41634f10
                        struct tevent_req              contains    748 bytes in  10 blocks (ref 0) 0x55ed41636390
                            struct tevent_timer            contains     96 bytes in   1 blocks (ref 0) 0x55ed41636ad0
                            struct dbwrap_watched_watch_state contains    420 bytes in   7 blocks (ref 0) 0x55ed41636540
                                struct tevent_req              contains    296 bytes in   5 blocks (ref 0) 0x55ed41636700
                                    struct messaging_filtered_read_state contains     64 bytes in   3 blocks (ref 0) 0x55ed416368b0
                                        struct messaging_dgm_fde       contains      8 bytes in   2 blocks (ref 0) 0x55ed41636950
                                            reference to: struct messaging_dgm_fde_ev

we crash when freeing the xconn as the the tevent_req child has a
cleanup function that tries to access a (wrapped) tevent context that
was already destroyed via smb1srv_tcon_disconnect_all() for SMB1 or
smbXsrv_session_logoff_all() for SMB2 a few lines above.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e900d60822d2050fa52b8c4dddf67c0d134f662">0e900d60</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-25T15:49:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add missing DO_PROFILE_INC(disconnect) to smbd_server_connection_terminate_ex()

For multi channel connections we should increment the disconnect count
also if we're not closing the last channel.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2be7518ae5a3c046f5fca04ecc83f9f7044eac74">2be7518a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-25T15:49:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: rename sconn->pool to sconn->raw_thread_pool

This should in future not be used directly, we'll provide
wrapper pools, which will provide impersonation for
path based async calls.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c97226356f2ba5f01a58d361371055caf11e2a7">0c972263</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-25T15:49:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: introduce sconn->sync_thread_pool

This just simulates a threadpool, but executes the
job functions inline (blocking) in the main thread.

This will be used to work arround some OS limitations,
e.g. if per thread credentials or per thread working directory
are not supported.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1251a536df4b1df58d9ddacab03d3ebe6f4e5b60">1251a536</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-25T15:49:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs: add smb_vfs_ev_glue

This adds VFS helper functions and that work on a struct smb_vfs_ev_glue
object which bundles two event contexts and a few threadpools.

This will be used to streamline the use of impersonating wrappers
in the SMB_VFS.

Notice the verbose comments in source3/smbd/vfs.c.

This will allow us to introduce path based async operations
to the SMB_VFS layer.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2dd95c1c38b9e1ce32d3d1081b6ec177910087a4">2dd95c1c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-25T15:49:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs: add user_vfs_evg to connection_struct

This will be used to in order to pass down the
impersonation magic from the SMB layer through
the SMB_VFS layer.

This includes the following options:

smbd:force sync user path safe threadpool
smbd:force sync user chdir safe threadpool
smbd:force sync root path safe threadpool
smbd:force sync root chdir safe threadpool

They can be used in order to test the non linux code
path on linux, once we get code that makes full use
of the new infrastructure.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cd37badc02b3e56f974168b28447444cd54ee541">cd37badc</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-25T15:49:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_aio_pthread: use event context and threadpool from user_vfs_evg

Or the root glue in case we're already root.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bd79564af10052e5b7bf4c446118b6eeb1b1e589">bd79564a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-25T15:49:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: add vfs_not_implemented module

This provides helper functions, which can be used by other modules,
if they don't implement a specific function.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53d78225ffd81e24fe00a013f7497851965c8171">53d78225</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-25T15:49:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">examples/VFS/skel_opaque: fix a likely a copy/paste error

This line was probably copied over from skel_transparent.c, remove it.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f37f8cca3ba70db326caabc27397719bca6fcc68">f37f8cca</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-25T15:49:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">examples/VFS/skel_opaque: make vfs_fn_pointers static

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ab0b4af9edbd50c0c7747840f9b3aca9cb01da8">5ab0b4af</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-25T18:44:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">examples/VFS/skel_transparent: make vfs_fn_pointers static

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Jul 25 20:44:12 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e711d18c8e9953aca2ca64179c3d0b305a41c62">4e711d18</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-25T23:29:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: don't client->connections without checking client != NULL first in exit_server_common()

exit_server_common() can be called also in smbd processes without a
smbXsrv_client structure, e.g. the parent or some background tasks.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Jul 26 01:29:38 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fa9e6a50da49bcab1da7533c72cee0687b4bb048">fa9e6a50</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-26T20:44:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">idmap: Make pointer initialization explicit

Took me a few seconds to find this NULL initializer

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a3b42db982651c235fb9b9c2e01d384fa2f7b13e">a3b42db9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-26T20:44:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">popt: popt 1.16 needs -liconv

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3bff0494e1097a7f0aeade74b89361e3d319819f">3bff0494</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-26T20:44:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Pass "share_mode_data" to share_entry_forall callback

Quite a bit of the contents have been passed explicitly anyway.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6ed119eccf9356ba91c883b50a38adc1bf4deb00">6ed119ec</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-26T20:44:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbstatus: Use share_mode_data->leases

This is the only user of share_mode_entry->lease

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2dffcde408008d2bbac8e796ea7ce770c7e97f63">2dffcde4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-07-26T23:42:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove "share_mode_entry->lease"

smbstatus was the only user, and this could be solved by adapting
share_entry_forall.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jul 27 01:42:31 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5dd84bf5d73e4afab094834bc317da7884b9b9b3">5dd84bf5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-27T03:45:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Fix compilation issue with strncpy()

When configured with --picky-developer and using -O3 with gcc 8.1:

../common/system_socket.c: In function ‘parse_ip_mask’:
../common/system_socket.c:229:2: error: ‘strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
  strncpy(s, str, len+1);
  ^~~~~~~~~~~~~~~~~~~~~~
../common/system_socket.c:223:8: note: length computed here
  len = strlen(str);
        ^~~~~~~~~~~

Use strlcpy() instead and check the result.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13545

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3b56f2002a35b55b46958178c79aee519f0c5880">3b56f200</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-27T03:45:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Fix compilation issue with strncpy()

When configured with --picky-developer and using -O3 with gcc 8.1:

../protocol/protocol_util.c: In function ‘ctdb_sock_addr_from_string’:
../protocol/protocol_util.c:282:2: error: ‘strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
  strncpy(s, str, len+1);
  ^~~~~~~~~~~~~~~~~~~~~~
../protocol/protocol_util.c:277:8: note: length computed here
  len = strlen(str);
        ^~~~~~~~~~~

Use strlcpy() instead and check the result.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13545

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a1fb7296ca1c32fbb85ade2d5f104690b83929b">4a1fb729</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-27T03:45:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Add function ctdb_sock_addr_mask_from_string()

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/efaa7690d01faa1f24c21920666f644c9d42ca11">efaa7690</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-27T03:45:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Switch to using ctdb_sock_addr_mask_from_string()

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b1fed7e14c7e2bdfa88f8e502d5256c555dcae90">b1fed7e1</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-27T03:45:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Switch to using ctdb_sock_addr_mask_from_string()

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77242e7631514b80a84146b2f4f232dab28d978b">77242e76</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-27T03:45:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Drop function parse_ip_mask() and supporting functions

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e7ef0c97e981ff6097eeca5b7ecf5136955b23fe">e7ef0c97</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-27T06:42:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Drop unused function mkdir_p_or_die()

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Jul 27 08:42:20 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/591d72f9c7981350eba19221398dbe7bcf0c098b">591d72f9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-27T11:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_mdb: #ifdef EBADE as it is not portable

E.g. FreeBSD 11.2 doesn't have it.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff863f2d98ac5e12073af824b794404c3d7198c5">ff863f2d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-27T11:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: we need to use pthreadpool_tevent_per_thread_cwd() on the callers pool

In pthreadpool_tevent_job_send() we remember if the job will be chdir
safe. It means we means we need to ask the callers pool when calling
pthreadpool_tevent_per_thread_cwd(), as the callers pool might
be a wrapper using pthreadpool_tevent_force_per_thread_cwd().

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7e1f9c9d83a91f67925d7ba504b434eaf682e8a7">7e1f9c9d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs: add SMB_VFS_GETXATTRAT_SEND/RECV

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c1c8a1f635266a954ea3de08d6d03de7f0ce503b">c1c8a1f6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_default: implement SMB_VFS_GETXATTRAT_SEND/RECV

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8a6013f612f3a5ae8dccfab8aa07baf09450b59a">8a6013f6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_xattr_tdb: implement SMB_VFS_GETXATTRAT_SEND/RECV

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/47d77432e4e0c61ba93390a5e33641a401154b54">47d77432</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs: add SMB_VFS_GET_DOS_ATTRIBUTES_SEND/RECV

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0d1fb6a73820e44c53c45e0b7f4455105ef2afb2">0d1fb6a7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: split out public parse_dos_attribute_blob() from get_ea_dos_attribute()

In preperation of adding an async version of get_ea_dos_attribute() that
will then call parse_dos_attribute_blob() too.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1265b5167328db1bf6d64f50c39276cc19278d70">1265b516</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_default: implement SMB_VFS_GET_DOS_ATTRIBUTES_SEND/RECV

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0feef1684e5a3a1889182e68597298a0e25df4ba">0feef168</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: factor out dosmode post processing

We apply some post processing to the dosmode returned from the VFS
function. Move this to a seperate function which will be reused in the
next commit in the async dos_mode_send/recv post processing.

Best viewed with: git show --histogram

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0fbeac035676b164c9b582ec181f51f525b39e3a">0fbeac03</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add dos_mode_at_send/recv()

Signed-off-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8de5018c9f54af5694d91f6884c1d71d09a258c3">8de5018c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add "get_dosmode" argument to smbd_dirptr_lanman2_entry()

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a2294bbdfff754403f9381388cbb71cde3a9694">2a2294bb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: pass get_dosmode to smbd_dirptr_get_entry()

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8954085ad713546ea84237bbe355973226fc3cb8">8954085a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: pass get_dosmode to mode_fn in smbd_dirptr_get_entry()

This finally uses "get_dosmode" as passed in from the SMB2 layer, but
all callers still pass true, so no change in behaviour.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bcfc830c284e4eaa76e1a562bf60d8ecdf8d11ab">bcfc830c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: rework error exit in smbd_dirptr_lanman2_entry()

The next commit will add code that must be run if status is NT_STATUS_OK
or STATUS_MORE_ENTRIES.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/abef6ca70610fbc2f0a527ff2084fe8eda43031b">abef6ca7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: factor out smb2_query_directory_next_entry() from smbd_smb2_query_directory_send()

This paves the way for adding async functions into the enumeration loop.

Best viewed with: git show -w

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e1d11eebd72bc28b733fb76107a43facb76c492">0e1d11ee</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: fix a long line in smb2_query_directory_next_entry()

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/00a26ac9856d4ec483736ae7c4bf17d08feed5f8">00a26ac9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: deal with fsp->aio_requests in close_directory()

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8884036ba297f504eb2e427db8247719ffb7a713">8884036b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: let smbd_dirptr_lanman2_entry return smb_fname

Note that smb_fname is relative to fsp, not conn!

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0736fdcdb0b9f072a482074ff69bb0054e16ffb2">0736fdcd</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use async dos_mode_at_send in smbd_smb2_query_directory_send()

Finally: use the new dos_mode_at_send() in the directory enumeration
loop. This means that fetching the DOS attributes for directory entries
is done asynchronously with regard to the enumeration loop.

As the DOS attribute is typically read from an extended attribute in the
filesytem, this avoids sequentially blocking on IO. If the IO subsystem
is slow servicing these request, enabling async processing can result in
performance improvements.

A parametric option

  smbd:async dosmode = true | false (default: false)

can be used to enable the new async processing.

Simulating slow IO with usleep(5000) in the synchronous and asynchronous
versions of SMB_VFS_GET_DOS_ATTRIBUTES(), the results of enumerating a
directory with 10,000 files are:

    smbd:async dosmode = no:

        $ time bin/smbclient -U slow%x //localhost/test -c "ls dir\*" > /dev/null
        real    0m59.597s
        user    0m0.024s
        sys     0m0.012s

    smbd:async dosmode = yes:

        $ time bin/smbclient -U slow%x //localhost/test -c "ls dir\*" > /dev/null
        real    0m0.698s
        user    0m0.038s
        sys     0m0.025s

Performance gains in real world workloads depends on whether the actual
IO requests can be merged and parallelized by the kernel. Without such
wins at the IO layer, the async processing may even be slower then the
sync processing due to the additional overhead.

The following parameters can be used to adapt async processing behaviour
for specific workloads and systems:

        aio max threads = X (default: 100)
        smbd:max async dosmode = Y (default: "aio max threads" * 2)

By default we have at most twice the number of async requests in flight
as threads provided by the underlying threadpool. This ensures a worker
thread that finishes a job can directly pick up a new one without going
to sleep.

It may be advisable to reduce the number of threads to avoid scheduling
overhead while also increasing "smbd:max async dosmode".

Note that we disable async processing for certain VFS modules in the VFS
connect function to avoid the overhead of triggering the sync fallback
in dos_mode_at_send(). This is done for VFS modules that implement the
sync SMB_VFS_GET_DOS_ATTRIBUTES(), but not the async version (gpfs), and
for VFS modules that don't share a real filesystem where fchdir() can be
used (ceph, gluster). It is disabled for catia, because we realized that
the catia name translation macros used on
fsps (CATIA_FETCH_FSP_[PRE|POST]_NEXT) have a bug (#13547).

We use threadpool = smb_vfs_ev_glue_tp_chdir_safe() and then
pthreadpool_tevent_max_threads(threadpool) to get the number of maximum
worker threads which matches the pool used by the low level
SMB_VFS_GETXATTRAT_[SEND|RECV] implementation in vfs_default.

This is a terrible abstraction leak that should be removed in the future
by maybe making it possible to ask a VFS function which threadpool it
uses, internally suporting chaining so VFS function FOO that internally
uses BAR can forward the question to BAR.

On a hyphotetical system that had a getxattrat(dirfd, path, ...)
syscall and at the same time doesn't support per-thread current working
directories (eg FreeBSD doesn't have the latter) but has support for
per-thread-credentials, pthreadpool_tevent_max_threads() on the
tp_chdir_safe threadpool returns 1.

So when hooking the hyphotetical getxattrat() into the async
SMB_VFS_GETXATTRAT_[SEND|RECV] implementation in an VFS module, the
implementation could use the tp_path_safe threadpool, but the SMB2
layer would use the wrong threadpool in the call to
pthreadpool_tevent_max_threads(), resulting in no parallelism.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0b32efcd9976d2352a71b314a7445c2e6e13578f">0b32efcd</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: test closing dir handle with in-flight find

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cbb7eb1fa27da053e0fe4ffd84df39754ecbdfd4">cbb7eb1f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T11:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: set "smbd:async dosmode = no" in the vfs_aio_pthread share

This just explicitly sets the current default, to ensure the tests that
use this share always use the same "smbd:async dosmode" setting even if
the default changes in the future.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/409d462f4976334189c751287a9fadc314a3a20e">409d462f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-07-27T14:04:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: run smbtorture3 SMB2-BASIC tests against additional shares

This runs the smbtorture3 SMB2-BASIC and smb2.compound_find tests against shares
with "smbd:async dosmode" enabled.

On the vfs_aio_pthread_async_dosmode_force_sync* shares we
force a sync threadpool which ensures we test behaviour on systems that
don't support unshare(CLONE_FS) and also don't support
per-thread-credentials. This simulates the code path of non linux
systems. And makes sure that we don't regress there.

We also test with xattr_tdb and without.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Jul 27 16:04:02 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/100fe9e9991136143c12abec688c607266eb9f51">100fe9e9</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-27T22:25:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">popt: Check for headers only if building in-tree version

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/156ac24453d6f6026757a518941f1df6c44135f8">156ac244</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-27T22:25:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">popt: Add check for iconv library

On glibc based systems, there is no separate iconv library.  Adding a
dependency without checking for the library breaks build on glibc based
systems.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2ba5fb20318580e0dad58357a7c9eb947a42f008">2ba5fb20</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-07-28T01:39:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Test with and without building bundled popt

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Jul 28 03:39:48 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/73298ac8a9a87dcf3b3699dfdd39a8e865291620">73298ac8</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-28T01:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Improve portability by not using /bin/bash directly

FreeBSD and others do not have /bin/bash, so use "/usr/bin/env bash"
for better flexibility.

There are still many integration tests that use /bin/bash but this at
least lets FreeBSD start running tests.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd9d8a20aa6948a5d1e7fb532842b7ff5bc0f550">dd9d8a20</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-28T01:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Improve portability by not using /bin/bash directly

FreeBSD and others do not have /bin/bash, so use "/usr/bin/env bash"
for better flexibility.

There are still many integration tests that use /bin/bash but this at
least lets FreeBSD start running tests.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a39bc4aaad541f1e89c0eb3e98d4104bcc25025">4a39bc4a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-28T01:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Avoid use of non-portable getopt in onnode

getopt is being used with non-portable options.  Use simpler,
POSIX-compliant getopts instead.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/56ffca3e79923a028ff96fbd50706d808b9dd215">56ffca3e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-28T01:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid use of non-portable getopt in run_tests.sh

getopt is being used with non-portable options.  Use simpler,
POSIX-compliant getopts instead.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/896c77df1ce2645c6dd7898b59ea802e204dc7d9">896c77df</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-28T01:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid use of non-portable getopt in stubs

getopt is being used with non-portable options.  In most cases use
simpler, POSIX-compliant getopts instead.

In the case of the ctdb test stub command, options can appear after
other arguments, so this requires an additional nested loop.

In the case of smnotify, there are no short options, so handle the
long options manually.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2f2c35a1cb4afe38e869882e8f18a62d4daac981">2f2c35a1</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-28T01:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Improve portability by not using mktemp --tmpdir option

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f13824b291fca9cdaa936c238d7e9bcb73927da7">f13824b2</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-28T01:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Switch some test stubs to use /bin/sh

They don't use any bash features.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/af8c31ead80d6c74b0e9d057cb47dff6552178a9">af8c31ea</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add errno matching utility

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e8a1b3db7abfa9e4a53e98a0aa21dfc268a21c92">e8a1b3db</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add required_error() to match on error codes

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a42a7232990fa163d046fb07be351ea3e0467046">a42a7232</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Switch to ETIMEDOUT from ETIME

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c8756ec17be11e40bc7e75aac7afdb323acb42e2">c8756ec1</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Switch to ETIMEDOUT instead of ETIME

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b886a95eca306d0062240e5710ae0ed4505b1068">b886a95e</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Switch to using ETIMEDOUT instead of ETIME

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e1236a855ffc493efb5e9cb7b295034376e56d3a">e1236a85</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-client: Switch to ETIMEDOUT instead of ETIME

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b7dbe9f306fda0d8f1dcc8dd81864539f6ff2632">b7dbe9f3</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add ps output filter for freebsd

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b0028dd5bf2d5466a50dfd12a82a23f30e9ccf48">b0028dd5</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add signal code matching utility

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/23952c9165bbdcae8f34b7dfefdbb4a499a55362">23952c91</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use sigcode to match signals

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0273171c30a5bcfdfc0b3f74c1d5a89dbaa5b204">0273171c</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Porting tests should ignore unsupported features

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c7041b0faf490661818244dd032ad413ce906e5c">c7041b0f</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Add line based I/O

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c9b42d27e6cf9e6ae36f44970f0a388edc737a7a">c9b42d27</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Avoid fgets in ctdb_connection_list_read

C library buffering API can behave in unexpected fashion if underlying
fd for stdin, stdout or stderr is closed and re-opened.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3bf753e830c20183ef4f3278880d3be362e53bef">3bf753e8</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Add fd argument to ctdb_connection_list_read()

This makes testing easier.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4152e98c0e95a938e17f95c543c2114bbf54b136">4152e98c</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Do not try to match pstree output in eventd tests

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/68542dbb5ab7b9d17b476937d1c84fe19d893255">68542dbb</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Simplify pattern matching for ctime output

On freebsd, sed does not accept multiple pattern strings.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/96d5c7de82f795e33e9998e0fe94ddcb50e7421d">96d5c7de</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: date "+%N" is non-portable

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/07844c2ec9583362594241e607d81aaead8f1a99">07844c2e</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use portable wc -c instead of stat -c "%s"

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/22c3078c8b10c88f8aff22caa7c92a06f387f17d">22c3078c</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Replace md5sum with posix cksum

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65cc36f24d8a92c749dbc3700802e1d83a9ceb9f">65cc36f2</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use errcode to translate ETIMEDOUT

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f5ed2b8b829e01fc675537e47095868ff8b5aa2">6f5ed2b8</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Fix a typo

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3047202ce733d1a767fbc83c7021cb83bb83e0e1">3047202c</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Strip all spaces from od output

On freebsd, there are trailing spaces in od output.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be43e08072ebce937ed0a02cd8d9d1c6072b178d">be43e080</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-07-28T01:50:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Fix the TCP packet length check

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13520

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a44e6987b1e469ae202777cd575fd81c19e1ac6c">a44e6987</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-28T05:26:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Replace obsolete reference to CTDB_DEBUG_HUNG_SCRIPT option

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13546

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Sat Jul 28 07:26:24 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/56e248de6072063308786ea83282aaecc8d7e62a">56e248de</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-28T15:14:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Fix "ctdb event status" usage message

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13551

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a7a4ee439dc1cf262b4da9fbcb38a2f69c62744c">a7a4ee43</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-28T15:14:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Factor out basic script abstraction

Provides for listing of scripts and chmod enable/disable.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13551

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/82e62488027302e541739628210292c2d95717e1">82e62488</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-28T15:14:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Use script abstraction in run_event

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13551

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/295826f1b83b6e59d24e4da43b290242c17f44af">295826f1</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-28T15:14:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Change event-tool script enable/disable to chmod file directly

They no longer go over the socket to eventd to enable and disable
scripts.  Use the event script abstraction to chmod them directly.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13551

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5017325c2ef84b10ccd23328f5d62ac5b246bbb3">5017325c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-28T15:14:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Implement event tool "script list" command

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13551

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e3ce1a2dfc4cbba4bf22381b91e9a14c8f240f5d">e3ce1a2d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-28T18:03:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-docs: Update documentation for "ctdb event" command

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13551

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Sat Jul 28 20:03:52 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d881f0c8a0ce2fc7cabf1966c5724e72c70d6694">d881f0c8</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2018-07-30T05:34:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Add net ads leave keep-account option

Add the ability to leave the domain with --keep-account argument to avoid
removal of the host machine account.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13498

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8025467bb3d3ee6998ccbe5d054454e9b951d0bd">8025467b</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2018-07-30T08:22:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Add net ads keep-account test

Add test for the new --keep-account net ads leave operation

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13498

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Jul 30 10:22:59 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4fcbaae57b129deaacfab0a226cefca99aa78256">4fcbaae5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-07-30T12:30:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-doc: Provide an example script for migrating old configuration

Include an example ctdbd.conf-style file for testing.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13550

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Mon Jul 30 14:30:06 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1c8ea099ce57ae35879e9a1cebcfd2de5c89bfdf">1c8ea099</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-30T12:31:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: Rename functions to ldb_kv

Rename the ldb key value functions from ltdb_* to ldb_kv_*. The renaming
is preparation for the separation of the tdb specific code from the key
value code.  This work is a follow on from the addition of the lmdb
backend.

Note that the next commit tidies up the code formatting.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9e6294668aa58408863bc6bb2c2510608bf916f3">9e629466</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-30T12:31:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: fix formatting of ldb_kv rename.

Clean up the code format after the rename in the previous commit.
Hopefully doing a rename commit followed by a reformat commit makes the
code easier to review.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e8aa764ea7dffbb499882f6bdf986322cd17c20d">e8aa764e</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-30T12:31:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: rename struct ltdb_reindex_context

Rename struct ltdb_reindex_context to ldb_kv_reindex_context, as this is
a key value level structure and not a tdb specific structure.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e969de0797bed4a3663f0b638ac49b3b6ef2952f">e969de07</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-30T12:31:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: reformat ltdb_reindex_context rename

Fix up the formatting after the rename of ltdb_reindex_context to
ldb_kv_reindex_context.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c782d710e97ffaed8fef18524b468e801be053d3">c782d710</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-30T12:31:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: rename ltdb_context to ldb_kv_context

Rename ltdb_context to ldb_kv_context as it is a key value level
structure and not tdb specific.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/17a84d12e2cef7a42c94d0df404f1ec4854fb65c">17a84d12</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-30T12:31:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: rename ltdb_req_spy to ldb_kv_req_spy

Rename ltdb_req_spy to ldb_kv_req_spy, as it is key value level and not
tdb specific.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/641b38e458b1f9ce848f76e2f226d42e7507a529">641b38e4</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-30T12:31:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: format rename of ltdb_req_spy

Fix up the code formatting after the rename of ltdb_req_spy to
ldb_kv_req_spy

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e0186d1f2da7d946ee140e6bb54b1d62766b43aa">e0186d1f</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-30T12:31:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: rename ltdb_private to ldb_kv_private

Rename ltdb_private to ldb_kv_private as it contains key value operation
context.

Note there is still some tdb specific context that can be refactored into a
separate structure along the lines of the lmdb context.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b8c9c305b3a1fa5103fb8af63768f8abf681106c">b8c9c305</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-30T12:31:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: format rename ldb_kv_private

Tidy up the code format after the rename of ltdb_private to
ldb_kv_private

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/72724f75ce97a1bf0b106bdf2e30cfb1729af765">72724f75</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-30T12:31:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: rename ltdb_cache to ldb_kv_cache

Rename ltdb_cache to ldb_kv_cache as it's key value level and not tdb
specific

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f6d5cf5eb11533ac1e3388dbb21c7f0757fff969">f6d5cf5e</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-30T12:31:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: rename tdb_key_ctx to key_ctx

Rename tdb_key_ctx to key_ctx, as it's key value level and not tdb
specific.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d3bfd374a65b93f5a7d9f3bf3c356871a5879a12">d3bfd374</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-30T12:31:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: rename ltdb_idxptr to ldb_kv_idxptr

Rename ltdb_idxptr to ldb_kv_idxptr as it's key value level and not tdb
specific.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9191d3baf513f9cd2d15206f1378c24a5e7de2e3">9191d3ba</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-30T12:31:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: remove unused function prototypes

Remove unused function prototypes

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/67c055406c7ad6b92c89337acd72a751962e99f0">67c05540</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-30T12:31:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: rename ltdb_parse_data_unpack_ctx

Rename ltdb_parse_data_unpack_ctx to ldb_kv_parse_data_unpack_ctx, as
it's a key value level structure and not ltdb specific.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/19be0be232c25250e79dc313fd43829de049b491">19be0be2</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-30T12:31:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: move key value code to lib/ldb/ldb_key_value

Move the key value code to a separate subdirectory.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f2d5c2c5cc52788a60fb2c390f681ea4cc767e58">f2d5c2c5</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-30T12:31:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: rename LTDB_* constants to LDB_KV_*

Rename all the LTDB_* constants to LDB_KV_* as they are key value level
constants and not tdb specific.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c891df421813781b32081b566600076562525261">c891df42</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-07-30T15:23:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb key value: convert TDB_DATA structs to ldb_val

Convert the key value functions to use ldb_val instead of TDB_DATA.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Jul 30 17:23:22 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/80c9219d6079532f31c4e415906a606d395af6e8">80c9219d</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2018-07-31T02:23:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/locking: Fix assertion check on lock reference count

lock_ref_count will always hold the old value prior to change. Thus it
would mean that if lock_ref_count is 0 the new value is already -1 which
is not expected here. Therefore it is better to make sure that it is
always greater than 0 rather than >= 0.

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jul 31 04:23:47 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6da0d68f49bbd82f5a08427779c9f5ebd6f755aa">6da0d68f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-31T09:26:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: ignore the return value of poll(NULL, 0UL, 1)

Otherwise Coverity reports this:

CID 1438160:    (CHECKED_RETURN)
Calling "poll(NULL, 0UL, 1)" without checking return value. This
library function may fail and return an error code.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f68b5ee75f002ed542a8423070fb01e3b0e83f65">f68b5ee7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-31T09:26:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: reset monitor_fd after calling tevent_fd_set_auto_close()

This tries to convince Coverity that we don't have a resource leak:

CID 1438157:    (RESOURCE_LEAK)
Handle variable "monitor_fd" going out of scope leaks the handle.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8dac16e82d04a64d8dee42285fe3fd32cc26f0af">8dac16e8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-07-31T12:20:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb2_query_directory: make 'return true' explicit in smb2_query_directory_next_entry()

'return req' should do the same as 'return true' for a bool function,
it's implicitly expanded as 'return (req!=NULL)?true:false.

There's no point in that as 'req' is always a valid pointer.

This was most likely just a copy and paste bug.

So we make this explicit now and avoid that Coverity reports this:

CID 1438158:  Null pointer dereferences  (REVERSE_INULL)
Null-checking "req" suggests that it may be null, but it has already
been dereferenced on all paths leading to the check.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Jul 31 14:20:49 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2bfb9b4081fff1ef816bbfdd3ebb989d1c56ec1b">2bfb9b40</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-31T14:56:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib: Fix misleading typo in debug message

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b93408246252fe1e3a72de33bcaa8ebb5fe7a1d2">b9340824</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-31T14:56:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: Avoid potential smbpanic calling parse_user_quota_list.

Calling parse_user_quota_list with a NULL buffer can cause a panic, while
this shouldn't happen, I managed to trigger this with an early implementation
of SMB2 quota support in smbd which didn't pass back NT_STATUS_NO_MORE_ENTRIES
when handling a SMB2_0_INFO_QUOTA GETINFO message.
OTHOH the Windows client handled the same situation gracefully.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1033dd9e303fc91b97e2054713b714ed5f356eb8">1033dd9e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-31T14:56:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: Don't stat when doing a quota operation (as it's a fake file)

calling SMB_VFS_STAT on the quota fake file fails and caused
FS_INFO/FileFsControlInfo request to error out early, in turn stopped a
Win8.1 client from proceeding with quota queries.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fd7c6f9bc7eb2de565ae9dc0aae6932904d53ec9">fd7c6f9b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-31T14:56:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc/idl Add some query [getset]info quota related structures

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/07e9113291213831f489aac7cffe3ee99dfb3cea">07e91132</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-31T14:56:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: adjust smb1 cli code to use idl structs and ndr push/pull funcs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd21b4fcfef4a663c43cf8e8601da350cbb0cfd3">dd21b4fc</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-31T14:56:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: adjust smb2 code for new idl structs & generated ndr push/pull funcs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b8802e271337e5cec4f13ad4f505ae1905e09ca7">b8802e27</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-31T14:56:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: adjust smb1 server to use idl structs and generated ndr push/pull funcs

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/907038417673dc0076838586e620b88513d78cb0">90703841</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-31T14:56:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: smb2 server implementation for query get/set info.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/90da2e599b1e46beea1d3dc4b6e9338786250882">90da2e59</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-31T14:56:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/script/test: modify existing smbcquota test to use SMB2 in addition to SMB1.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/801c1856a39cbc2fd65183a7d6d8b7526dbc251e">801c1856</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-31T14:56:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/script/tests: Add simple (smb1 & smb2) get/set/list tests for smbcquotas

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/705086d83c847c707e8230ce6a58e840a70d93c3">705086d8</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-31T14:56:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: allow set quota for non root user (when built with --enable-selftest)

Currently it appears you need to be root to set quotas, for test purposes
this requirement needs to be relaxed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e053aad4ae46dfcda6143d55e8e913e923fa34be">e053aad4</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-07-31T17:45:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/utils: fix regression where specifying -Unetbios/root works

Usually you need to be root on a linux server to modify quotas. Even
with a linux server joined to a windows AD you could always log in as
local root with smbcquotas. However in recent builds this has changed.
This patch fixes this

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Tue Jul 31 19:45:59 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/33d012c3cebb5625e02450ac3b08c4245a3e985d">33d012c3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-03T06:24:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Fix a cut&paste error

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13554

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f7b2e5eec5ba1fa5f26694e6555a98cab0594a27">f7b2e5ee</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-08-03T09:14:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-eventd: Fix CID 1438155

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13554

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Aug  3 11:14:01 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a3d248f284eb2e5f4fe886310e481b28c9f1c392">a3d248f2</a></strong>
<div>
<span>by Oleksandr Natalenko</span>
<i>at 2018-08-03T15:28:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">systemd: Only start smb when network interfaces are up

For smb, if the smb.conf contains explicit bindings to the network
interfaces, the service must wait till network interfaces are up,
otherwise the service won't be operational.

The 0e571054a61e commit and the BZ 13184 have fixed this for nmb and
samba, so do exactly the same here, for smb.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13559

Signed-off-by: Oleksandr Natalenko <oleksandr@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Aug  3 17:28:52 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/97702ffc1eb4fe0773ee7d7bbf681e9e032ee965">97702ffc</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2018-08-06T00:46:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add net lookup options

Add missing net lookup options to net man page

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jim McDonough <jmcd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dea788e521e01f900defe0b0a6c8c2908b92352e">dea788e5</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-08-06T03:36:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns scavenging: Add extra tests for custom filter

Add extra tests for the custom ldb filter used by the dns scavenging
code.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Aug  6 05:36:43 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8f83933f6ea1edfdaff2da26ef264cc028b9e6a2">8f83933f</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-08-06T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: adding readonly locks mode to tdbbackup tool

The netcmd 'domain backup offline' command will use the tdbbackup tool but
require readonly locking of tdb databases, otherwise all database access would
be blocked during a backup.  This patch adds the option.  A backup script
should use this tool with the readonly locks option after taking a transaction
lock on the target database.

Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/04217372f4114bd7583ba56a3860ebbe22ae0719">04217372</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-08-06T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: test for readonly locks mode on tdbbackup command

Simple bash test for readonly locks on tdbbackup:
1. Running tdbbackup on a database with and without readonly locks enabled.
2. Dump both backups and original.
3. Check all three dumps match.

A binary sample_tdb.tdb file is included for the test because the existing
sample tdbs in lib/tdb/test are either corrupt or empty.

Signed-off-by: Aaron Haslett <aaron.haslett@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4f532cc177cd1e95d8ccf8e69f50b315354df34c">4f532cc1</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-06T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Improve domain backup targetdir checks

+ Added check that specified targetdir is actually a directory (if it
exists)
+ Deleted a redundant 'Creating targetdir' check that would never be hit
+ Move code into a separate function so we can reuse it for offline
backups (which take a different set of parameters, but still have a
targetdir)

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f17d20123a4dc6b3b798456775c9449a2afd4921">f17d2012</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-08-06T03:37:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: domain backup offline command

Unlike the existing 'domain backup online' command, this command allows an
admin to back up a local samba installation using the filesystem and the
tdbbackup tool instead of using remote protocols.  It replaces samba_backup
as that tool does not handle sam.ldb and secrets.ldb correctly.  Those two
databases need to have transactions started on them before their downstream
ldb and tdb files are backed up.

Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2104818ea60d51c54c9243ace5a28d2a087996f1">2104818e</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-06T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: New offline backup tests with tweaks to old online classes

Offline backups have a slightly different syntax, as they don't take the
server or user-creds parameters. In the untar case, the offline backup
will actually have the secrets present, so making asserting on this
more flexible.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2800611df3295d5ba4c82b2ecd0f8a77d6a5c658">2800611d</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-08-06T03:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: domain backup offline command - offline test with ldapcmp

This test checks that when you do an offline backup and restore or untar it,
the restored database is the same as the original.  Test is repeated for
'mdb' and 'tdb' database backends.

Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eb4161d701465800beca2400aed292baa91bd936">eb4161d7</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-08-06T06:45:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: offline backup restore target

This is a selftest target built from a restored offline backup.
Other backup routines are modified to remove the assumption that every backup
requires server and credentials arguments, since offline backup doesn't
want them.  Also, prepare_dc_testenv now returns the generated ctx so we can
run or re-run routines that require it later.

Signed-off-by: Aaron Haslett <aaron.haslett@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Mon Aug  6 08:45:19 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d76c7b204e30a38747679ccd2597dd3a2b8bd394">d76c7b20</a></strong>
<div>
<span>by Richard Sharpe</span>
<i>at 2018-08-06T06:46:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Minor, really small, documentation fix.

Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c6b95c3672505924e9d5754457d6125f44406f4c">c6b95c36</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-08-06T09:37:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: remove queue destructor as it isn't needed anymore

After

commit e097b7f8ff1a9992de1d11474dac4969e30cd679
Author: David Disseldorp <ddiss@suse.de>
Date:   Sun Jul 31 03:14:54 2011 +0200

    io: Make queue_io_read() safe for reentry

the destructor has no purpose anymore, therfore, remove it.

Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: David Disseldorp <ddiss@samba.org>

Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Mon Aug  6 11:37:32 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0530cccc41f683cb35d065ddcb3968cf4ef759f4">0530cccc</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-06T23:49:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:waf: Install eventlogadm to /usr/sbin

The eventlogadm binary needs write access to the registry which, by
default, is only possible as root.

https://bugzilla.samba.org/show_bug.cgi?id=13561

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Aug  7 01:49:34 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5b54ced31678999842f621e0023674dc920e28a9">5b54ced3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-08T18:22:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Align integer types

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/60c0a2b384d935e2ef6ffe5d167a423b1b2e7af8">60c0a2b3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-08T18:22:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix CID 1438246 Unchecked return value

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/01d9be278796e6ce73dd48939118ca492f08445c">01d9be27</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-08T18:22:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix CID 1438245 Dereference before null check

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ee3dd90a76f649b3bec5063cddf9293ed4d5a82c">ee3dd90a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-08T18:22:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Fix CID 1438244 Unsigned compared against 0

ndr_size_dom_sid returns a size_t, so that can't be <0. Also, the only
case that ndr_size_dom_sid returns 0 is a NULL sid
pointer. ndr_size_dom_sid can reasonably be assumed to not overflow, the
number of sub-auths is a uint8. That times 4 plus 8 always fits into a
size_t.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c8174cf9221ce5635073bb4a29e782f81f67dc5">0c8174cf</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-08T21:10:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Fix CID 1438243 Unchecked return value

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Aug  8 23:10:22 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf9cb64d513d2cdbda558a4cbc65d21fd0c9abbb">bf9cb64d</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2018-08-08T23:16:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/locking: Corrections and improvements to inline comments

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Jim McDonough <jmcd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b105651c754c7c98297a23c0c1e43d7d2e28139">9b105651</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2018-08-09T02:06:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Shorten description in vfs_linux_xfs_sgid manual

this fixes a lexgrog parse error, the NAME subheader description
of the vfs_linux_xfs_sgid(8) manual was too long, this will shorten
the description and allow it to be correctly detected by mandb.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13562

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Aug  9 04:06:17 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bd64af6b8861f892e6ae2840a493f037d1e0a06c">bd64af6b</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-08-09T11:29:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/build: link ctdb_mutex_ceph_rados_helper against ceph-common

ceph-common linkage is needed with new versions of Ceph.
Also respect the --libcephfs_dir=<path> parameter when provided.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/85706bd27535eaa4ec653f99b1910fbd8f2aab88">85706bd2</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-08-09T11:29:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb_mutex_ceph_rados_helper: Set SIGINT signal handler

Set a handler for SIGINT to release the lock.

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8d30fd591600ac17c742cd78c7bc4056bba6b877">8d30fd59</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-08-09T11:29:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb_mutex_ceph_rados_helper: use talloc destructor for cleanup

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/91a89c146453ca203a83dc2ba555bb93276c4d7f">91a89c14</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-08-09T11:29:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb_mutex_ceph_rados_helper: rename timer_ev to ppid_timer_ev

In preparation for adding a lock refresh timer.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ce289e89e5c469cf2c5626dc7f2666b945dba3bd">ce289e89</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-08-09T11:29:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb_mutex_ceph_rados_helper: fix deadlock via lock renewals

RADOS locks without expiry persist indefinitely. This results in CTDB
deadlock during failover if the recovery master dies unexpectedly, as
subsequently elected recovery master nodes can't obtain the recovery
lock.
Avoid deadlock by using a lock expiration time (10s by default), and
renewing it periodically.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13540

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4abf348ec4cbb78d3216d5e8c5f3020d4499f10a">4abf348e</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-08-09T14:26:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: add expiry test for ctdb_mutex_ceph_rados_helper

Kill the ctdb_mutex_ceph_rados_helper with SIGKILL and then confirm
that the lock is automatically released following expiry.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Thu Aug  9 16:26:36 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8479401b028fe61f514c42aa9d238c0c630f0d94">8479401b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-09T17:57:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Add support to parse MS Catalog files

Signed-off-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Aug  9 19:57:02 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c13125467b03d3a5a862654c2bacacd1e32578d">9c131254</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-08-10T00:43:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: Ensure quota code is only called when quota support detected

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13563

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Aug 10 02:43:33 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/94ffd4b7ad6680d0352d5cbdcda7dd61fd981809">94ffd4b7</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-08-10T00:44:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dlz-bind: Add support for BIND 9.12.x

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1a86733d034019083cadb137cb81dba661f96b66">1a86733d</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-08-10T03:36:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">provision: Add support for BIND 9.12.x

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Aug 10 05:36:19 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/75287495f2e16e333ce1afe9d1b168b951350053">75287495</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-08-10T07:27:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs showrepl tests: improve debugging for mystery error

Under some circumstances the samba-tool command is failing with no
stdout output at all, leaving few clues in the logs.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>

Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Fri Aug 10 09:27:03 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b68e3eca631c04d6d57c489daf60f64732fc86d">6b68e3ec</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2018-08-10T16:05:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: Explicitly set delete_on_close token for rmdir

The current implementation of `rmdir` hopes to get the directory deleted
on closing last open handle when FILE_DELETE_ON_CLOSE is set on it. But
for non-empty directories Windows doesn't error out during an open call.
Following that we internally refuse to set initial delete_on_close while
opening a non-empty directory. This prevents us from trying to delete
the directory when last open handle is closed.

Instead of relying on FILE_DELETE_ON_CLOSE during an open we explicitly
set delete_on_close token on directory handle once it is available. This
ensures that NT_STATUS_DIRECTORY_NOT_EMPTY is returned for `rmdir` on
non-empty directories while closing open directory handle.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13204

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a7f11746c9cc3cdc5307e540bdd1f3f10fed05b">6a7f1174</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2018-08-10T16:05:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture: Add new test for DELETE_ON_CLOSE on non-empty directories

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13204

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bca400847f2fcc3dd1398e166c1964cb88822071">bca40084</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-10T19:08:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: tests: smbclient. Regression test to ensure we get NT_STATUS_DIRECTORY_NOT_EMPTY on rmdir.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13204

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Aug 10 21:08:14 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e6689c3e14c2dfaebaf1109f21e53184fea45d41">e6689c3e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-10T23:49:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wbinfo: Free memory when we leave wbinfo_dsgetdcname()

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e4f4f5eb7303a0cce4f426dd9cfd1d6a488495b0">e4f4f5eb</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-10T23:49:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:passdb: Don't leak memory on error in fetch_ldap_pw()

Found by covscan.

A candidate to use tallac ...

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f20150fb1ea5292f099862af6268d06844954d5e">f20150fb</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-10T23:49:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Do not overflow the destination buffer in net_idmap_restore()

Found by covsan.

error[invalidScanfFormatWidth]: Width 128 given in format string (no. 2)
is larger than destination buffer 'sid_string[128]', use %127s to
prevent overflowing it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b7b4fc51d0eadbbc94576dda75ae80098a205a24">b7b4fc51</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-10T23:49:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Do not leak memory in new_user()

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d4fb124adfc10de8b7eb1f72b74d7ca83f8415dd">d4fb124a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-10T23:49:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:lib: Fix a possible fd leak in gp_get_file()

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3d32c0263b072e19335eba1451840284409ecb61">3d32c026</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-10T23:49:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:client: Avoid a possible fd leak in do_get()

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dbdbd4875ecac3e7334750f46f1f494b7afe6628">dbdbd487</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-10T23:49:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Fix memory leaks in ads_krb5_chg_password()

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3e6ce5c6e679fdb39ed8142bf5e1ed4105164826">3e6ce5c6</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-11T02:43:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:registry: Fix possible memory leak in _reg_perfcount_multi_sz_from_tdb()

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Aug 11 04:43:15 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c0b49b3f982a3a3013a3b6fef3c10b1ca7d2ab0">4c0b49b3</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-13T17:46:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Fix memory leak in nss_init()

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4909b966050c921b0a6a32285fee55f5f14dc3ff">4909b966</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2018-08-13T17:46:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: vfs: time_audit: fix handling of token_blob in smb_time_audit_offload_read_recv()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13568

Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a98f09a09db2fc7be85f9171b586e65344a39e92">a98f09a0</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-08-13T20:35:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Load time_audit and full_audit modules for all tests

Previously the only test was to load these modules to trigger the
smb_vfs_assert_all_fns check. As these modules just pass through the
calls, they can be loaded for all tests to ensure that the codepaths are
exercised. This would have found the problem in
smb_time_audit_offload_read_recv.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13568

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Aug 13 22:35:20 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b3cc7916b81e001b886b9c632babe345ca21d76">6b3cc791</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-14T06:54:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">g_lock: Avoid a double call to serverid_exist

If we try to G_LOCK_READ while a G_LOCK_WRITE is active, we do the
serverid_exists call twice. Avoid that.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/00513daf78eb29996c81ca4d3be9e71a8e872829">00513daf</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-14T09:42:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">g_lock: Simplify g_lock_trylock

While chasing a bug in g_lock (not in master) I saw some opportunity to
simplify g_lock_trylock a bit. This is array handling, and array
handling is just extremely error-prone. This *might* be a little less
efficient or large numbers of READ locks, but this remains to be
seen. For now, simplify the code.

First, we make two passes now: One to remove ourselves, and the other
one to search for conflicts. Mixing up both made it pretty hard for me
to follow the code.

Second, I've removed the _mylock and mylock pointer/struct logic and
replaced it with the "mylock.pid.pid != 0 ? &mylock : NULL" when calling
g_lock_store. To me, this focuses the logic whether to add ourselves in
one place instead of spreading it around in the whole routine.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Aug 14 11:42:10 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5edcaece4130a00d8cdd8e8b10c2c2d86a74afe0">5edcaece</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-14T11:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1139 libcli/auth: Add initial tests for ntlm_password_check()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13360

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d89fe91a7336950b1ba84b8680f015e228047f5">1d89fe91</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-08-14T11:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1139 libcli/auth: fix debug messages in hash_password_check()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13360

CVE-2018-1139: Weak authentication protocol allowed.

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/947cf385978d9cae43fe7f59a6dcf3b28dc036f1">947cf385</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-08-14T11:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1139 s3-utils: use enum ntlm_auth_level in ntlm_password_check().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13360

CVE-2018-1139: Weak authentication protocol allowed.

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c88f7795b34eef6d2432f8e9c2fffc14f419dfcd">c88f7795</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-08-14T11:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1139 selftest: verify whether ntlmv1 can be used via SMB1 when it is disabled.

Right now, this test will succeed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13360

CVE-2018-1139: Weak authentication protocol allowed.

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c25460ee1f1b10bf69eaaf1ac937da225854d1d1">c25460ee</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-08-14T11:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1139 libcli/auth: Do not allow ntlmv1 over SMB1 when it is disabled via "ntlm auth".

This fixes a regression that came in via 00db3aba6cf9ebaafdf39ee2f9c7ba5ec2281ea0.

Found by Vivek Das <vdas@redhat.com> (Red Hat QE).

In order to demonstrate simply run:

smbclient //server/share -U user%password -mNT1 -c quit \
--option="client ntlmv2 auth"=no \
--option="client use spnego"=no

against a server that uses "ntlm auth = ntlmv2-only" (our default
setting).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13360

CVE-2018-1139: Weak authentication protocol allowed.

Guenther

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0998f2f1bced019db4000ef4b55887abcb65f6d2">0998f2f1</a></strong>
<div>
<span>by Andrej Gessel</span>
<i>at 2018-08-14T11:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1140 Add NULL check for ldb_dn_get_casefold() in ltdb_index_dn_attr()

Signed-off-by: Andrej Gessel <Andrej.Gessel@janztec.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13374
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3f95957d6de321c803a66f3ec67a8ff09befd16d">3f95957d</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-14T11:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1140 ldb: Check for ldb_dn_get_casefold() failure in ldb_sqlite

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13374
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b27d973341144a03db8dc824bfb3e5c65868fe7e">b27d9733</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-14T11:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1140 ldb_tdb: Ensure the dn in distinguishedName= is valid before use

ldb_dn_from_ldb_val() does not validate this untrusted input, so a later
call to ldb_dn_get_casefold() can fail if the input is not valid.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13374
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3c1fbb18321f61df44d7b0f0c7452ae230960293">3c1fbb18</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-14T11:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1140 ldb_tdb: Check for DN validity in add, rename and search

This ensures we fail with a good error code before an eventual ldb_dn_get_casefold() which
would otherwise fail.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13374
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b6b72d0063107bf9008203d8c2843033a5edb6da">b6b72d00</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-14T11:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1140 ldb: Add tests for search add and rename with a bad dn= DN

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13374
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b7f0ee93f58e663bb8fc0b39985aa49b254582d9">b7f0ee93</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-14T11:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Release LDB 1.5.0 for CVE-2018-1140

* Security fix for CVE-2018-1140 (NULL pointer de-reference, bug 13374)
* Fix memory leaks and missing error checks (bug 13459, 13471, 13475)

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be4c0938b0f47d246d3aaacdc6c9a3fedf8ab6e0">be4c0938</a></strong>
<div>
<span>by Kai Blin</span>
<i>at 2018-08-14T11:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-1140 dns: Add a test to trigger the LDB casefolding issue on invalid chars

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13466

Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/21d628e045712405663e77e6e01084234df6a99c">21d628e0</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T11:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 security: Move object-specific access checks into separate function

Object-specific access checks refer to a specific section of the
MS-ADTS, and the code closely matches the spec. We need to extend this
logic to properly handle the Control-Access Right (CR), so it makes
sense to split the logic out into its own function.

This patch just moves the code, and should not alter the logic (apart
from ading in the boolean grant_access return variable.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c107e2d6751b8e6b40f23c50ca4f0e28a0ac9196">c107e2d6</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T11:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 security: Add more comments to the object-specific access checks

Reading the spec and then reading the code makes sense, but we could
comment the code more so it makes sense on its own.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/375f48f779fd6c62080efb03949cc25fa9515c3b">375f48f7</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T11:57:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 tests: Add tests for guessing confidential attributes

Adds tests that assert that a confidential attribute cannot be guessed
by an unprivileged user through wildcard DB searches.

The tests basically consist of a set of DB searches/assertions that
get run for:
- basic searches against a confidential attribute
- confidential attributes that get overridden by giving access to the
  user via an ACE (run against a variety of ACEs)
- protecting a non-confidential attribute via an ACL that denies read-
  access (run against a variety of ACEs)
- querying confidential attributes via the dirsync controls

These tests all pass when run against a Windows Dc and all fail against
a Samba DC.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9eb8340e328757b1a1c6238f47d2a2404f7fbe38">9eb8340e</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T11:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 tests: Add test case for object visibility with limited rights

Currently Samba is a bit disclosive with LDB_OP_PRESENT (i.e.
attribute=*) searches compared to Windows.

All the acl.py tests are based on objectClass=* searches, where Windows
will happily tell a user about objects they have List Contents rights,
but not Read Property rights for. However, if you change the attribute
being searched for, suddenly the objects are no longer visible on
Windows (whereas they are on Samba).

This is a problem, because Samba can tell you about which objects have
confidential attributes, which in itself could be disclosive.

This patch adds a acl.py test-case that highlights this behaviour. The
test passes against Windows but fails against Samba.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/563e454e8c55e94a9509c935468b636fe0d8eb97">563e454e</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-08-14T11:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 tests: test ldap searches for non-existent attributes.

It is perfectly legal to search LDAP for an attribute that is not part
of the schema.  That part of the query should simply not match.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba46578f97ab35ac12ea0bd298c4180363224675">ba46578f</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T11:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 security: Fix checking of object-specific CONTROL_ACCESS rights

An 'Object Access Allowed' ACE that assigned 'Control Access' (CR)
rights to a specific attribute would not actually grant access.

What was happening was the remaining_access mask for the object_tree
nodes would be Read Property (RP) + Control Access (CR). The ACE mapped
to the schemaIDGUID for a given attribute, which would end up being a
child node in the tree. So the CR bit was cleared for a child node, but
not the rest of the tree. We would then check the user had the RP access
right, which it did. However, the RP right was cleared for another node
in the tree, which still had the CR bit set in its remaining_access
bitmap, so Samba would not grant access.

Generally, the remaining_access only ever has one bit set, which means
this isn't a problem normally. However, in the Control Access case there
are 2 separate bits being checked, i.e. RP + CR.

One option to fix this problem would be to clear the remaining_access
for the tree instead of just the node. However, the Windows spec is
actually pretty clear on this: if the ACE has a CR right present, then
you can stop any further access checks.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/80c4e17f0f28fd13c92938216bca0543c361bd9e">80c4e17f</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T11:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 acl_read: Split access_mask logic out into helper function

So we can re-use the same logic laster for checking the search-ops.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4234579a5d9d3e27e90cd019f85a78a214b96314">4234579a</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T11:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 acl_read: Small refactor to aclread_callback()

Flip the dirsync check (to avoid a double negative), and use a helper
boolean variable.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/98c2e6a14fa28d0fe64641227065cd44beb55f96">98c2e6a1</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T11:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 acl_read: Flip the logic in the dirsync check

This better reflects the special case we're making for dirsync, and gets
rid of a 'if-else' clause.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fc45da529dc6794d27007a92df30f475fcea9849">fc45da52</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T11:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 acl_read: Fix unauthorized attribute access via searches

A user that doesn't have access to view an attribute can still guess the
attribute's value via repeated LDAP searches. This affects confidential
attributes, as well as ACLs applied to an object/attribute to deny
access.

Currently the code will hide objects if the attribute filter contains an
attribute they are not authorized to see. However, the code still
returns objects as results if confidential attribute is in the search
expression itself, but not in the attribute filter.

To fix this problem we have to check the access rights on the attributes
in the search-tree, as well as the attributes returned in the message.

Points of note:
- I've preserved the existing dirsync logic (the dirsync module code
  suppresses the result as long as the replPropertyMetaData attribute is
  removed). However, there doesn't appear to be any test that highlights
  that this functionality is required for dirsync.
- To avoid this fix breaking the acl.py tests, we need to still permit
  searches like 'objectClass=*', even though we don't have Read Property
  access rights for the objectClass attribute. The logic that Windows
  uses does not appear to be clearly documented, so I've made a best
  guess that seems to mirror Windows behaviour.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7070aa384bc0f8c9979d01d64dee097dc3ad2878">7070aa38</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-14T11:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-10919 tests: Add extra test for dirsync deleted object corner-case

The acl_read.c code contains a special case to allow dirsync to
work-around having insufficient access rights. We had a concern that
the dirsync module could leak sensitive information for deleted objects.
This patch adds a test-case to prove whether or not this is happening.

The new test case is similar to the existing dirsync test except:
- We make the confidential attribute also preserve-on-delete, so it
  hangs around for deleted objcts. Because the attributes now persist
  across test case runs, I've used a different attribute to normal.
  (Technically, the dirsync search expressions are now specific enough
  that the regular attribute could be used, but it would make things
  quite fragile if someone tried to add a new test case).
- To handle searching for deleted objects, the search expressions are
  now more complicated. Currently dirsync adds an extra-filter to the
  '!' searches to exclude deleted objects, i.e. samaccountname matches
  the test-objects AND the object is not deleted. We now extend this to
  include deleted objects with lastKnownParent equal to the test OU.
  The search expression matches either case so that we can use the same
  expression throughout the test (regardless of whether the object is
  deleted yet or not).

This test proves that the dirsync corner-case does not actually leak
sensitive information on Samba. This is due to a bug in the dirsync
code - when the buggy line is removed, this new test promptly fails.
Test also passes against Windows.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/860f575fa5987413b5d5efa9a218a4cc3bf2edb9">860f575f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-14T11:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Ensure smbc_urlencode() can't overwrite passed in buffer.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13453

CVE-2018-10858: Insufficient input validation on client directory
                listing in libsmbclient.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be3d4b2d8526add6a487c9977de5a42704895833">be3d4b2d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-14T11:57:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Harden smbc_readdir_internal() against returns from malicious servers.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13453

CVE-2018-10858: Insufficient input validation on client directory
                listing in libsmbclient.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a45de51c9d2e30055b3653936fcd387b28b72a34">a45de51c</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-14T15:02:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">cracknames: Fix DoS (NULL pointer de-ref) when not servicePrincipalName is set on a user

This regression was introduced in Samba 4.7 by bug 12842 and in
master git commit eb2e77970e41c1cb62c041877565e939c78ff52d.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13552

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Tue Aug 14 17:02:38 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e4f38b067020213671b5d712efc1a99726420b7f">e4f38b06</a></strong>
<div>
<span>by Timur I. Bakeyev</span>
<i>at 2018-08-14T17:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb tests: fix assertion on wrong pointer

We are allocating msg02, but check in assertion msg01, which makes no
sense here.

Signed-off-by: Timur I. Bakeyev <timur@freebsd.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9eccf6a16f5b198181a4fa80b835b1a65b40ed76">9eccf6a1</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-14T20:02:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Free addr before we free the context

Introduced by dbdbd4875ecac3e7334750f46f1f494b7afe6628

CID 1438395

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Aug 14 22:02:06 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b9e2a2de247add415b4681c93849a9c9ba6f3c4a">b9e2a2de</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-15T05:08:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: no need to call del_transaction in ldb_transaction_commit

No matter commit succeeded or failed, transation will be delete afterwards.
So there is no need to delete it here.

Aganst Samba this causes an `LDAP error 51 LDAP_BUSY` error when the transaction
fails, say while we try to add users to groups in large amount and
the original error is lost.

In Samba, the rootdse module fails early in the del part of the
start/end/del pattern, and in ldb_tdb and ldb_mdb a failed commit
always ends the transaction, even on failure.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d645546aef452fc372b7cc7e1602562f0e88943c">d645546a</a></strong>
<div>
<span>by Andrej Gessel</span>
<i>at 2018-08-15T05:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">fix mem leak in ltdb_index_dn_base_dn and ltdb_search_indexed

Signed-off-by: Andrej Gessel <Andrej.Gessel@janztec.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d71c655eecc7bc7963a8858dd3a631ac1e580046">d71c655e</a></strong>
<div>
<span>by Andrej Gessel</span>
<i>at 2018-08-15T05:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">fix mem leak in ldbsearch

Signed-off-by: Andrej Gessel <Andrej.Gessel@janztec.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/542e7c179112933f82ea68ce6c04c2a596522617">542e7c17</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-15T05:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_tdb: Remove pointless check of ldb_dn_is_valid()

If the DN is not valid the ltdb_search_dn1() will catch it with ldb_dn_validate() which
is the only safe way to check this.  ldb_dn_is_valid() does not actually check, but instead
returns only the result of the previous checks, if there was one.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2dafbd32136b7d4253bcadde4c038272350f7bb2">2dafbd32</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-15T05:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Add new function ldb_dn_add_child_val()

This is safer for untrusted input than ldb_dn_add_child_fmt()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13466

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9d46795b208487028ce4cce6ed893de7b665b347">9d46795b</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-15T05:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: extend API tests

These additional API tests just check that an invalid base DN
is never accepted.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bdbb9422c0430d74c3173822257e23a9dfb2713e">bdbb9422</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-15T05:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Release LDB 1.5.1

* New API ldb_dn_add_child_val() avoids passing untrusted input to
  ldb_dn_add_child_fmt() (bug 13466)
* Free memory nearer to the allocation in calls made by ldbsearch
* Do not overwrite ldb_transaction_commit failure error messages
  with a pointless del_transaction()

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa01203ff51ec49dfdfeed6ab02bbe0cb3198d70">aa01203f</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-15T05:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns_server: Be strict when constructing a LDB DN from an untrusted DNS name

This changes our DNS server to be much more careful when constructing DNS names
into LDB DN values.

This avoids a segfault deep in the LDB code if the ldb_dn_get_casefold() fails there.

A seperate patch will address that part of the issue, and a later patch
will re-work this code to use single API: ldb_dn_add_child_val().  This
is not squahed with this work because this patch does not rely on a new
LDB release, and so may be helpful for a backport.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13466

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/28e2a518ff3233f49f1b61210754d044c670087b">28e2a518</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-15T05:08:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns_server: Avoid ldb_dn_add_child_fmt() on untrusted input

By using the new ldb_dn_add_child_val() we ensure that the user-controlled values are
not parsed as DN seperators.

Additionally, the casefold DN is obtained before the search to trigger
a full parse of the DN before being handled to the LDB search.

This is not normally required but is done here due to the nature
of the untrusted input.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13466

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/badd7a23ed968dbf9f05c518f8c65a81ab796609">badd7a23</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-15T05:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool/drs: set dns_backend to SAMBA_INTERNAL in cmd_drs_clone_dc_database

The default value is "NONE", need to specify it to use SAMBA_INTERNAL so
that the DNS partitions are replicated.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8084f1838cee774fc79a4c7ff2d1182388105fcb">8084f183</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-15T05:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">emulate/traffic: fix next usage

In commit b0c9de820c07d77c03b80505cb811ac1dac0808f, line 343:

    self.next_conversation_id = itertools.count().next

was changed to:

    self.next_conversation_id = next(itertools.count())

which is not correct, the first one is a function, the second one is a
int. This patch fixed it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13573

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/68c64c634ad7576b2ab5ef838c203320afd90f44">68c64c63</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-15T05:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: uniform stats output

The original code is trying to output different data format for tty or file.
This is unnecessary and cause confusion while writing script to parse result.

The human-readable one is also easy for code to parse.
Remove if check for isatty(), just make output the same.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ceed07fe89d6bf80440b9951549c7247cb952388">ceed07fe</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-15T05:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic-replay: add extra check

Make sure --average-groups-per-user is not more than --number-of-users

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/371c5c70f78a65af6fcc4d124eae8c10b26bdc48">371c5c70</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-15T05:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">emulate/traffic: add sAMAccountName in create_group

While using script/traffic_replay to generate users and groups, we get
autogenerated group name like:

    $2A6F42B2-39FAF4556E2BE379

This patch specify sAMAccountName to overwriten the name.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1da4ff2e64469dc8494ba895453d60206f030db4">1da4ff2e</a></strong>
<div>
<span>by Timur I. Bakeyev</span>
<i>at 2018-08-15T05:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party:build: Test for the flags, recognized by Clang.

Make amd64 SYSTEM_UNAME_MACHINE an alias for x86_64.

Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/14077b6682d7dc1b16e1ccb42ef61e9f4c0a1715">14077b66</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-15T05:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: domain backup didn't support prompting for password

The online/rename backups only worked if you specified both the username
and password in the actual command itself. If you just entered the
username (expecting to be prompted for the password later), then the
command was rejected.

The problem was the order the code was doing things in. We were checking
credopts.creds.get_password() *before* we'd called
credopts.get_credentials(lp), whereas it should be the other way
around.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13566

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8fb706c34682bf6dc6033963518c7eccffc3944f">8fb706c3</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-15T05:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Fix kerberos option for domain backups

The previous fix still didn't work if you specified --kerberos=yes (in
which case the creds still doesn't have a password).

credopts.get_credentials(lp) should be enough to ensure a user/password
is set (it's all that the other commands seem to do).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13566

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d2d039515119523192676b311d5997afd34f4c90">d2d03951</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-15T05:08:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Delete unnecessary function

Minor code cleanup. The last 2 patches gutted this function, to the
point where there's no longer any value in keeping it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13566

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f249bea1e0538300288e7cf1dcb6037c45f92276">f249bea1</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-15T08:19:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Fix --kerberos=yes and --no-secrets domain backups

The --kerberos=yes and --no-secrets options didn't work in combination
for domain backups. The problem was creds.get_username() might not
necessarily match the kerberos user (such as in the selftest
environment). If this was the case, then trying to reset the admin
password failed (because the creds.get_username() didn't exist in
the DB).

Because the admin user always has a fixed RID, we can work out the
administrator based on its object SID, instead of relying on the
username in the creds.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13566

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Aug 15 10:19:09 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/739691fd1e34fda0280d068e1693fa6a2c61f9b6">739691fd</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-16T21:42:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools: Split git ls-files output on newline, not any whitespace

This allows files to have a space in the filename within the Samba git tree.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6d52ef8dcfef44c500571f2c62386ba5ae3189a5">6d52ef8d</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">git: Treat .dump files as binary

This means that git grep will no longer show TDB dumps. This can be
changed at runtime using -a for all to include these files, while -I
will also omit any references to the files (no Binary file * matches).

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ea297d0ce382af7f45b176faa3f33f36a921371b">ea297d0c</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winreg: Add hyper REG_QWORD to parsing routines

This will be useful when exporting registry.pol files.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/572fd6319fd60fbca99db42169b80aa0135be058">572fd631</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">preg: Build python preg bindings

These will be used in the GPO import/export.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/463dcc909417f91a576b12b96adfc16e18ffc9a0">463dcc90</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">preg: Unpack winreg_Data for parsing

It seems that there might be pre-existing endianness issues which would be fixed by the ndr_push.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c71ba94cb13f2a2ff18ddabee19e46fb2cf646a3">c71ba94c</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">preg: Using winreg_Data_GPO instead of DATA_BLOB

We need to make a duplicate in order to have reasonable python bindings.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8140a7bb762d049dfe0fd84858f7fd5b357351c7">8140a7bb</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">preg: Use gensize to allow modification of winreg data to be repacked

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7047f457dc8febec3270a37471e8d9cad52b6dec">7047f457</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gp_parse: Introduce new module for parsing GPO files

This is the default parser which will cause the file to be restored
as-is -- leaving only an effectively blank XML file as a placeholder.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/34453a082ed0ed06cd4e2a7a3c313404fc85ee8e">34453a08</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Add a backup command (similar to fetch)

The idea behind this command is that you will eventually backup a number
of XML files which can be user-editable and have generic entities to be
later restored in the same domain or a different domain.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aac6cd37808fd79b9ea51bff6501ad575740494f">aac6cd37</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Add a restore command (for backups) from XML

Currently because no parsers have been written, this just copies the old
files and puts them in their places.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6c5a50779d111fab048a957a5fd1374f07beae1a">6c5a5077</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gp_pol: Parse the .pol files (PReg) which stored winreg settings

Currently, we do not look inside the .pol files for any settings (and do
not generalize any so far).

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e27c8689f7fafdeb5f7b5e4fbebe131e056bb7c0">e27c8689</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gp_ini: Parse .ini files in SYSVOL

These are fdeploy, scripts + psscripts as well as the GPT.ini at the top
level. Note that GPT.ini has a different character encoding and we
specify it here.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a69308b7a5fa3f14681fd951999500129ee5bea">4a69308b</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gp_csv: Parse the audit.csv file which records audit settings

Based on the setting, the csv will omit certain fields. Using this we
can later infer as to how to generalize the ACLs and SIDs.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dac3c204bef32a524b442db877dcd8af9757ddea">dac3c204</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gp_inf: Parse the GptTmpl.inf file which stores security settings

This is NOT an ini file and CANNOT be parsed by Python ConfigParser
without losing information (it would likely eat meaningful whitespace
and so should not be done).

There are three main types of settings:

 * Name,Mode,ACL
 * key = value
 * registry key and value

   Note: This appears as key=value, but registry keys in the general
   case may have = in their names, so we record the entire string in
   order to be as safe as possible.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/497db985382475b114266896c07fb09730d41a30">497db985</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gp_aas: Leave a placeholder for the .aas files for now

This is to be implemented, but the documentation is somewhat lacking for
the .aas files and we so we leave this for now. In particular, the
documentation doesn't seem to describe all the possible sections, nor do
we understand what happens if we replace certain aspects of the file --
and whether or not it will remain functional.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/854c3eb2aaac9553981488d4f313d3b76c7473d5">854c3eb2</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Enable more specific parsers of GPO files

* .pol files
* .ini (and GPT.ini)
* audit.csv
* GptTmpl.inf

.aas is currently not handled.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ee010392d5e8072acc1623c5eab453599af88656">ee010392</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gp_csv: Add CSV generalization metadata

There are user identifiers and ACLs which may be stored in the audit CSV.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4edb1769b0beb1a76e5b393facc3aee4406a3fc8">4edb1769</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gp_ini: Allow better overriding of behaviour in inherited classes

We will need this to parse the parameters or section names as SIDs for fdeploy1.ini

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/806e3e60e04d393b72d1c2422c57b93a0d242440">806e3e60</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gp_ini: Add a fdeploy1 parser for better generalization

We still fail to handle entities in fdeploy.ini (version 0) files. Here we
manage to factor out some of the SIDs, but not all of them. This will be
completed in a later patch. The overall idea is to split the SID values into
individual XML elements and annotate them. We also note down network paths for
the redirection folders.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/57dd88ce5cde29462b77f2f1a5d0035573721c4e">57dd88ce</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gp_ini: Add a scripts ini parser for better generalization

We mark the command path argument as a network path.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/abff0c4f4d2620b2fb86c8325950f8e95b5992d7">abff0c4f</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gp_parse: Add a generalize XML function to the top level parser

In this function we take XML and using the required metadata, we rewrite
it into a generic form using entities. ElementTree unfortunately does
not allow us to store unescaped entities, and so we must do a textual
replace on the output XML.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3ff695fd363b9d6cff1e17d8f4c0278e29b3b62d">3ff695fd</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">fdeploy_ini: Generalize the share name SIDs

This overrides the custom entity handler defined in the top level parser.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/07de156598b614aa0ecbbc542ff87dae43a0e08f">07de1565</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Add a --generalize to the backup command

This normally prints out the entities in DTD form to be given to the restore
command with --entities. Specifying --entities during the backup conveniently
writes these entities to a file. Generalizing occurs after the standard backup
on the XML files, which will then re-write the XML file.

There are a number of files which can be further handled, including many of the
preferences XML files. This will require more annotation and parsing.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9977b4bc7c3fa7ef93f4f42fcc707d9b2d84f9cb">9977b4bc</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitattributes: Ignore .SAMBABACKUP files

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cedfea1b077a7cb068d884e17f2d9c22e7e97cd5">cedfea1b</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Make restore with entities more robust

Sometimes the restore fails for unknown reasons, but rearranging the XML
such that the DTD is after the xml header appears to fix it. This might
be the case in certain files where no entities are used perhaps.

This could probably be made more tolerant using regex, but for the most
part we expect the fixed output from the minidom pretty-printed XML.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a844137e6828aebf21a94d843b31ac11309f3fd5">a844137e</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/gpo: Add a backup for showing that GPO backup and restore works

This will be used to write a test in the coming patches.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53ee5157b162fc103ff16fb7d3c8364d0d9975b1">53ee5157</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/gpo: Tests using a static backup directory from gpo backup

In particular, we want to see that the binary matches, that the XML will
backup to the same values, that the fallback with copy-restore works,
and that the generalize will generalize over different restored
entities.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f4f0a5d925bed9d803a33d33da9d7a197dc61c9a">f4f0a5d9</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-08-16T21:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Maintain an XML DTD for reference of the backup

This may or may not actually parse, but is mostly for reference

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cdff99b949b574ff96a8514b3514f1261bb42ca3">cdff99b9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-16T21:42:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Always use an SMB signed connection

This ensures data integrity in the backup.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3990df0850525e5b45cafac13e26e3a2ac516f41">3990df08</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-17T00:44:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add information on new GPO features

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Aug 17 02:44:41 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d313e0e48dac6d517227cf1eff241bd7016b0dde">d313e0e4</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-17T00:58:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">descriptor: add missing backslash for long sddl str

Find this bug while doing PEP8.
We are lucky this code was not used yet.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2f37149341afae74738bfd6560333b75edf2b89f">2f371493</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-17T00:58:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: fix SamDB dummy replacement

In commit 6de9d878b, a dummy SamDB lambda was added:

    SamDB = lambda *x: None

The `*x` will only cover positional args. If we call it with kwargs:

    samdb = SamDB(url=url)

We will get TypeError:

    <lambda>() got an unexpected keyword argument 'url'

This commit fix this. It also fix PEP8 E731:

    do not assign a lambda expression, use a def

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13542

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cd3b06fab0a3b5ac0730f8d025b7f20fdf1b3b30">cd3b06fa</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-17T00:58:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python3: reuse cmp_fn defined in compat.py

This will also fix PEP8 E306:

    expected 1 blank line before a nested definition, found 0

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a39c8f44319b2bdff376ce690ec0fd4f94d0e6bc">a39c8f44</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-17T00:58:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix PEP8 warning E711 comparison to None

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/96b726ea86071004d22980b017a03746f39fc25f">96b726ea</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-17T00:58:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix PEP8 warning E201/202/203 array/dict whitespace

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b86c5f8bc0eec4d0b818430adea6195bfa6922c">9b86c5f8</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-17T00:58:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix PEP8 warning E122/E126/E127 wrong indent for continuation lines

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/078bd79501d0d4f3c60db7fcab7999eabdcf4cd6">078bd795</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-17T00:58:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/pso tests: use  string .format() style rather than C-style %s/%d.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3a050542688bc50a0cef463ff468014218ab919f">3a050542</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-17T00:58:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool domain passwordsettings: Avoid except Exception

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/30e6e04c4c0dd9ed4277f88006f2d59247e86590">30e6e04c</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-17T00:58:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix PEP8 warning F841 local variable 'blah' is assigned to but never used

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1a30a68b4a33b5aaacf768b489bf4e444d03ff5a">1a30a68b</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-17T00:58:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix PEP8 warning E225 missing whitespace around operator

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e741a1939c13bbd3c9f4ef4ec8c44a32d0c1661b">e741a193</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-17T00:58:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix PEP8 warning F401 'blah' imported but unused

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/092130be0f5cc5b206abc254543d19661cabc071">092130be</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-17T00:58:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix PEP8 warning E231 missing whitespace after ','

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b8920aab21325010fe161a9fd7a279fc3de7790d">b8920aab</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-17T00:58:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix PEP8 warning E302 expected 2 blank lines

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87b919b6192c17e14f1663d3512db34417c7de97">87b919b6</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-17T00:58:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix PEP8 warning E303 too many blank lines

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/26ece82e5ec40b8f150c888c6e8fba1c85639e4c">26ece82e</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-17T00:58:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix PEP8 warning W291 trailing whitespace

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2bd0a208dffabe6193c03b912feb7cb86769be04">2bd0a208</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-17T00:58:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix PEP8 warning W503 line break before binary operator

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a86e2b347a1dc0f7baeae57ff86f6832852d6660">a86e2b34</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-17T00:58:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Refactor for PEP8 warning E501 line too long

The attribute names here are so long it means there's not a very nice
way to wrap the long lines, so add a helper function

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7065f5299f04f4a7f766f97cf90cb3c913491005">7065f529</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-17T00:58:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Refactor for PEP8 warning E501 line too long

Rename a parameter that an internal function takes so that the function
call doesn't overrun 80 chars.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/68f8a1c2747fd51a633b34dc4301b1f6acae5de6">68f8a1c2</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-17T00:58:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix PEP8 warning E501 line too long

Mostly involves splitting up long strings or comments so that they
span multiple lines. Some place-holder variables have been added in a
few places to avoid exceeding 80 chars.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/60b4a1be063888ddac0f484158517aa10b219b5a">60b4a1be</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-17T00:58:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Refactor for PEP8 warning E501 line too long

Add a wrapper function to avoid long lines. This also helps
a little to manage/contain the complexity of the code.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f9ff50ae7c493f84d9ac7271e86efd7aba2b7ce9">f9ff50ae</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-08-17T00:58:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Refactor for PEP8 warning E501 line too long

Rename a couple of really long functions.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b0130fe4a8aa26919f254dc8a9af80ef942099be">b0130fe4</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-17T03:53:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs smb.conf: Clarify that wreplsrv:periodic_interval is in seconds

As requested by oota on samba-technical

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Aug 17 05:53:54 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fc41281e4fe6f71692678a63a3287f25ba4787f3">fc41281e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-17T05:39:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture3: Simplify the g_lock6 test

Do string_term_tdb_data just once, this is a leftover from a sweeping
change from "char *" to TDB_DATA as g_lock key.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13195
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8734970c31d3e44d2b882c41bdfe5ff22186c9ea">8734970c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-17T05:39:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture3: Enhance g_lock6 to run without CLEAR_IF_FIRST

CLEAR_IF_FIRST doesn't really work in the cluster. This needs to be
applied to all tests, but lock6 is what I care about right now.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13195
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/682fafe2b3a7b196975897d6e162392d64bec4d1">682fafe2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-17T08:34:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture3: Extend the g_lock6 test to also cover upgrades

The fixes for #13195 were incomplete and did not cover upgrades
properly. It's all gone in master with the new code.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13195
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Aug 17 10:34:53 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0f6b4b43711522f4770fb256f328b4b1a3893ffc">0f6b4b43</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-17T09:30:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pygpo: Fix a talloc_tos() leak in py_gpo_get_unix_path

cache_path() implicitly puts its result on talloc_tos(). As in
py_gpo_get_unix_path the talloc_stackframe() is only created after the
cache_path() call, we leak the result of cache_path() on
talloc_tos() (which might or might not exist).

This converts the function to the pattern used elsewhere: Create the
stackframe as the very first action and remove it as the very last
action in the function.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0a9273f888d42f4826c41f098bf692b3d977167f">0a9273f8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-17T09:30:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Pass "mem_ctx" down to xx_path

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f986a73b240ea61df1d4664b9c3c6d0858b17111">f986a73b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-17T09:30:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Pass mem_ctx to lock_path()

Fix a confusing API: Many places TALLOC_FREE the path where it's not
clear you have to do it.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c2ea10077715fb2a554a9f39b2ff49338bd8a124">c2ea1007</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-17T09:30:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Pass mem_ctx to state_path()

Fix a confusing API: Many places TALLOC_FREE the path where it's not
clear you have to do it.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6ca5ba5272cc6ff5fbada1b9a801ccc16861eb0e">6ca5ba52</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-17T12:28:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Pass mem_ctx to cache_path()

Fix a confusing API: Many places TALLOC_FREE the path where it's not
clear you have to do it.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Aug 17 14:28:51 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/29eb2fc67c7c0b26390ddeda76f4d3aa8c0846c4">29eb2fc6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-17T16:25:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Enhance debugging in set_file_size

I've stumbled over a case where VFS_FTRUNCATE wasn't called due to an
unchanged size. Make that easier to detect. Also, get rid of an ancient
cast to (double).

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/04f62984fe7c76dd409197fb72f1697c4d7e1755">04f62984</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-17T16:25:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix a typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a56bd0a90f46f384052326f6facc1d8c18a5f537">a56bd0a9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-17T16:25:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix a typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fea8ebce485c6cdd5c312e7d5caef72d52c904fd">fea8ebce</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-17T16:25:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">g_lock: Fix DEBUG messages

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0d38e9e84831759ebcd13b40bfe4d70f127b724d">0d38e9e8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-17T16:25:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap: Fix a typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Rowland Penny <rpenny@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/22be863ba3ad2c9269b0154f7540300c37fb1ff0">22be863b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-17T16:25:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix a few DEBUG statements

%u is not necessarily correct for uint32_t, avoid casts

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/14f9e6f833f806cb87d8562e8e1d29e78c549ead">14f9e6f8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-17T19:29:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap: Clarify db_open_watched API

Point out in the API that "backend" talloc_moves into the watched
database.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Aug 17 21:29:15 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/41aa55f49233ea7682cf14e5a7062617274434ce">41aa55f4</a></strong>
<div>
<span>by Paulo Alcantara</span>
<i>at 2018-08-17T23:32:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: util: Do not take over stderr when there is no log file

In case we don't have either a /var/log/samba directory, or pass a
non-existent log directory through '-l' option, all commands that are
daemonized with '-D' option hang when executed within a subshell.

An example on how to trigger that:

  # rm -r /var/log/samba
  # s=$(nmbd -D -s /etc/samba/smb.conf -l /foo123)
  (never returns)

So, when the above command is executed within a subshell the following
happens:

  (a) Parent shell creates a pipe, sets write side of it to fd 1
    (stdout), call read() on read-side fd, forks off a new child process
    and then executes nmbd in it.
  (b) nmbd sets up initial logging to go through fd 1 (stdout) by
    calling setup_logging(..., DEBUG_DEFAULT_STDOUT). 'state.fd' is now
    set to 1.
  (c) reopen_logs() is called by the first time which then calls
    reopen_logs_internal()
  (d) in reopen_logs_internal(), it attempts to create log.nmbd file in
    /foo123 directory and fails because directory doesn't exist.
  (e) Regardless whether the log file was created or not, it calls
    dup2(state.fd, 2) which dups fd 1 into fd 2.
  (f) At some point, fd 0 and 1 are closed and set to /dev/null

The problem with that is because parent shell in (a) is still blocked in
read() call and the new write side of the pipe is now fd 2 -- after
dup2() in (e) -- and remains unclosed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13578

Signed-off-by: Paulo Alcantara <palcantara@suse.de>
Reviewed-by: Jim McDonough <jmcd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Aug 18 01:32:25 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8262efbc96b06535b5d29395c71d5fa4e0d8bc63">8262efbc</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-08-18T00:01:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Replace calculation of bytes to read from socket by MIN() macro

The calculation of the bytes to read from the socket can be done easier
by the usage of the common MIN() macro.

Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d0ed4a536ee0ddce2e27dffe301304b8fa55ccce">d0ed4a53</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-08-18T02:58:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: calculate queue input buffer size correctly

The queue's input buffer is calculated in an iterative way.
This can result in a few back and forth jumping and
a few memory allocations and mem-free cycles.
This is very time consuming and not required, because the required
memory size can be calculated right away.

Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Aug 18 04:58:05 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9ee4d9466e42ef419ddbb39efbc476532cd221d3">9ee4d946</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-18T13:21:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Fix print in dns_invalid.py

https://bugzilla.samba.org/show_bug.cgi?id=13580

Signed-off-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Sat Aug 18 15:21:39 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/51d57073798f76ec4f1261945e0ba779b2530009">51d57073</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-20T21:28:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: Fix a leak of "br_lck"

Fix a panic if fruit_access_check detects a locking conflict.

do_lock() returns a valid br_lck even in case of a locking conflict.
Not free'ing it leads to a invalid lock order panic later, because
"br_lck" corresponds to a dbwrap lock on brlock.tdb.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13584

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ec3c37ee53f21d8c0e80b1d3b3d7e95a4ac8e0bc">ec3c37ee</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-21T00:33:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Demonstrate the invalid lock order panic

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13584

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Aug 21 02:33:05 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7460d9b97e11b710ce1ce95777f30e940629050b">7460d9b9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-21T22:57:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove koplocks->contend_level2 callbacks

This was only implemented by onefs in this way. If we get around to use
for example fanotify or something similar, we can either re-add them or
do it in a different way. For now, simplify the code.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Aug 22 00:57:31 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f16d917297031d6fc92667b83b9c842195c63bf8">f16d9172</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-21T22:58:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libgpo: Fix CID 1438462 Error handling issues (CHECKED_RETURN)

Yes, this creates a leak of "data", but the other error exits in this
function are the same.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/09acfb762a734bb71f2623da55230006bfda35e0">09acfb76</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-21T22:58:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Fix CID 1438461 Error handling issues (CHECKED_RETURN)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/781faca0cb9b11a048c843e35ee98c82b912e05b">781faca0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-21T22:58:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Fix a typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/75ced0d15514b2d4707eb1813c461f135d9d20bf">75ced0d1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-21T22:58:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libads: Fix an error path talloc leak

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fb81fb2d93be7fdf5081a057e4d70d9f53a72df3">fb81fb2d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-22T01:59:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libads: Simplify parse_spn()

A few lines less and quite some bytes less .text

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Aug 22 03:59:51 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c71f61ed8a31d287d343d4f2e68cb40c57a2b89">9c71f61e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-22T19:50:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Ensure get_real_filename() copes with empty pathnames.

Needed for vfs_glusterfs, as Gluster requires "." not '\0'.

Based on a fix from Anoop C S <anoopcs@redhat.com>

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13585

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Aug 22 21:50:41 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c39ec64231b261fe4ada02f1f1b9aa344cf35bb5">c39ec642</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-23T10:08:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Make sure that fruit_ftruncate only unlinks streams

Follow-up to

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13441

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8c14234871820eacde46670d722a676fb5f3a46c">8c142348</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-23T13:28:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: Don't unlink the main file

The original fix for bug 13441 was missing a check that verifies that
fruit_ftruncate() is actually called on a stream.

Follow-up to

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13441

Pair-Programmed-With: Volker Lendecke <vl@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Aug 23 15:28:48 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/831bb3575d7e2151d670a1cc2ecae8e6e06a573d">831bb357</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E271: multiple spaces after keyword

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e551f5f50295e16aa56e80a5991a55d2d7b8a36d">e551f5f5</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E713: test for membership should be 'not in'

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5027405d0c3c738a42afc4a10938b8d22ab8e240">5027405d</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E714: test for object identity should be 'is not'

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d7863ffe5d9d6ac7d1312ca55dd0a0203de09491">d7863ffe</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E731: do not assign a lambda expression, use a def

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3606a49c7338fd6b0bf96280bfd1ace001f8f24e">3606a49c</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix W601: .has_key() is deprecated, use 'in'

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1c5fa5dc0ee47de0bb6edc39a4dfe2295afb4bff">1c5fa5dc</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix W602: deprecated form of raising exception

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/086daf5f36bb832ced6b5e38ccdbb66e7a2a459e">086daf5f</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E101: indentation contains mixed spaces and tabs

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ada5af53f7502aaacd9cebb35a3e3288ec5b24bc">ada5af53</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: whitespace fixes in wintest.py

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4fc08d8f14e281fb7492d5a196e456637406c514">4fc08d8f</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E111: indentation is not a multiple of four

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eba81f7fa92ec807da6a78976fc3105157f592a4">eba81f7f</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E115: expected an indented block (comment)

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5037731e0dad92c9d538eb3cd437b8b672df865b">5037731e</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E116: unexpected indentation (comment)

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b43408b383d06d7c0c87b8f6e9549544fc057bc2">b43408b3</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E121: continuation line under-indented for hanging indent

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/297faf325225e06f9658457513044631d62e3dbe">297faf32</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E122: continuation line missing indentation or outdented

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/484ce0634b020853edf0c5432e08523884199b1e">484ce063</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E123: closing bracket does not match indentation of opening bracket's line

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dba0c7ebe5e91a6124e48a62a28f460c2fc9bf79">dba0c7eb</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E124: closing bracket does not match visual indentation

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa163f1a9c858203d900bbeda0e76ca247d0eace">aa163f1a</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E125: continuation line with same indent as next logical line

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bbb9f57603de490b39e5ad1b71e36f127291194b">bbb9f576</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E127: continuation line over-indented for visual indent

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d532543abdcb605fd1432eeaa36135bdac8a884">5d532543</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E128: continuation line under-indented for visual indent

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/944d70435e4859a626b875c18535c1adb7c3e66f">944d7043</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E131: continuation line unaligned for hanging indent

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9551edaeebdb2e8c209a843bae7088e60946e96">a9551eda</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E201: whitespace after '('

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/562411bd9587bdd011bd70e25f9763c38a8af401">562411bd</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E202: whitespace before ')'

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba0827b560c8165bcbb4017a6377778934ad9bb9">ba0827b5</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E203: whitespace before ':'

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d9c282a9a599c48bd4c772d80059a364e1d2d61b">d9c282a9</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E211: whitespace before '('

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fb5ea356dd2dcf7651ff2b0fb861042ed828821c">fb5ea356</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E222: multiple spaces after operator

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/32266d2d48c1c38e54bcfaf1cad36f09e9cff355">32266d2d</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E225: missing whitespace around operator

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87bbc2df972d112870bb7d5c8839663affe62b21">87bbc2df</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E226: missing whitespace around arithmetic operator

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e1edeae83c0519c5865247500b8432ff2ab47dab">e1edeae8</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E227: missing whitespace around bitwise or shift operator

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/35de42275bc8475466ef29d1e2c2c7391c9f769b">35de4227</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E228: missing whitespace around modulo operator

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/12d3fbe15cb58b57c60499103101e3a845378859">12d3fbe1</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E231: missing whitespace after ','

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/40ef91fb410e609c1dc02d95daeafbd5f7ef28a9">40ef91fb</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E241: multiple spaces after ','

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1ccc36b4010cd63b1b63f4c0145466b8e09eb798">1ccc36b4</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E251: unexpected spaces around keyword / parameter equals

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c809a86023a2eb1c6802c8b3aa68c00f1ea03952">c809a860</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E261: at least two spaces before inline comment

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a07d4223028ed34cca20d2fcdf4f1bca1856c8b">7a07d422</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E265: block comment should start with '# '

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/542e91ef9222302303d2ecc10dceb96d1b0d5bab">542e91ef</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E301: expected 1 blank line, found 0

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/211c9a5f85bffbb012b4567bad265c9339588fbf">211c9a5f</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E302: expected 2 blank lines, found 1

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fd6b2086cbf03d8dd0b46160f345bf7cc5551aeb">fd6b2086</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E303: too many blank lines (2)

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/115f2a71b883567dcf324da5cd02cfc3c86431b4">115f2a71</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E305: expected 2 blank lines after class or function definition, found 1

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4d529c400ba966ff633812a0f9f6a46862bd9e56">4d529c40</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E306: expected 1 blank line before a nested definition, found 0

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/95c36d825c68505dd28fda2a1bf7bcc707c523ad">95c36d82</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E401: multiple imports on one line

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b031b01a1fa458cb118e5fb38faf20bd5379e5c">7b031b01</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E502: the backslash is redundant between brackets

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d23170c961194234ef6131482233405cdd55a349">d23170c9</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E701: multiple statements on one line (colon)

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cabb299749388ebfda74571753e7b0209d32b266">cabb2997</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E703: statement ends with a semicolon

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e940e4cd48fa866cdb81e38d7786aac953f30bdf">e940e4cd</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E711: comparison to None should be 'if cond is not None:'

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1676a4dcae505142036dff49eb4d65ff6e9854b2">1676a4dc</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E712: comparison to False should be 'if cond is False:' or 'if not cond:'

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f5bbcc10a82f409f41cce5685458332674e2010">9f5bbcc1</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E713: test for membership should be 'not in'

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa243d1a7f64c474265b7f735601139ab9ff7b92">aa243d1a</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix W291: trailing whitespace

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f9eb617e375c2272547517af22775dd7afee428">6f9eb617</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix W293: blank line contains whitespace

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c9f2fdea1dc91bf692fba2b74882371b0b35e1dc">c9f2fdea</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix W391: blank line at end of file

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4284f6042976a8d4a6fdb58edb66d198f64c87ae">4284f604</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-08-24T05:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: add pycodestyle config in setup.cfg

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c750ad7caa99a028b10c81ac709918f1028f40b">9c750ad7</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-08-24T05:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: more space before equals

This dropped out during rebase

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2ccb0b0384304e88ff390b1a8974a9dca09c6528">2ccb0b03</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-08-24T05:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: improve spacing around colons

These dropped out of Joe's patches during rebase and review.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d0dc38cfed6b1966d41201d93bc321fbf80f0f6">5d0dc38c</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-08-24T05:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb tests: remove unused code from match_rules.py

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/333bc327c0256b505c5ee651968deba06a046036">333bc327</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-08-24T05:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: better formatting of (CONST1|CONST2)

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/08d1573bd5b0dd3982dfe0971a1cf2aef234cfa7">08d1573b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-08-24T05:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: add spaces after operators

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d246eec035fd5c3e46acd1c1f027bdd20a1523bc">d246eec0</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-08-24T05:49:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dcerpc/dns_server tests: use record malformed as probably intended

Both ways the record is malformed, but it is more likely we meant
AAAAAAAAAA... 1
than
A 1A 1A 1A 1A ...

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/944a4609c71493250e2fa27cdf9a665dd503da99">944a4609</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-08-24T05:49:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dcerpc py tests: improve argument formatting

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/06320851424a8d1368565f63b3c12a5ea273a111">06320851</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-08-24T05:49:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: improve formatting around bit-wise OR ("|")

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa5db3da2b399cdcfaa1d9bf0cb0d3ea34140975">aa5db3da</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-08-24T05:49:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: improve formatting around various operators

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0f3f63f2d80b023eab9da0db14d65a9069f9e2c4">0f3f63f2</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-08-24T08:58:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: line up a couple of lists

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Fri Aug 24 10:58:16 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/48335725deecdbdb24a9176cf31e9611c9deda49">48335725</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-24T08:59:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Fix aliasing issue in IPv6 checksum

Since commit 9c51b278b1700cd5f3e2addc19b7c711cc2ea10b the compiler has
been able to inline the affected call to uint16_checksum().  Given
that the data (phdr) is being accessed by an incompatible
pointer (data) there is an aliasing problem when the call is inlined.
This results in incorrect behaviour with -O2/-O3 when compiling with
at least GCC 6, 7, and 8.

Fix this by making the types compatible.

Also fixes CID 1437604 (Reliance on integer endianness).  This is a
false positive because the uint16_checksum doesn't depend on the order
of the input uint16_t items.

https://bugzilla.samba.org/show_bug.cgi?id=13588

Pair-programmed-with: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d4afb60a24b932a0b7a0c2f27526f41d0bf38fc2">d4afb60a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-24T08:59:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-doc: Make config migration script notice removed CTDB_BASE option

This should never have been a user-level option, but some people used
it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/64d4a7ae5ac3aed2b1b9e7ab85c372e6900826ac">64d4a7ae</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-24T08:59:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-doc: Handle boolean options in config migration more carefully

Values for ctdb.conf options are now returned by
get_ctdb_conf_option().  The main goal is to allow old boolean options
to be replaced by new logically negated options.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/17068e756b9e46f7a6c77d533ef1777173bb3795">17068e75</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-24T08:59:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-config: Change option "no realtime" option to "realtime scheduling"

Negative options can be confusing, so switch to a positive option.

This was supposed to be done months ago but was forgotten.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/43adcd717cee689c2d0386bd2aa2878006aa9217">43adcd71</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-24T08:59:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-doc: Change option "no realtime" option to "realtime scheduling"

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8ddfc26d79fda2fd0265f370a4c08dc584e6a6ac">8ddfc26d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-24T08:59:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-doc: Add support for migrating tunables to ctdb.conf options

This will become common, so will be useful to have support for.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f42486e8912eee45eb75d27b753bb74c3b37d80b">f42486e8</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-24T08:59:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-config: Switch tunable TDBMutexEnabled to a config option

Use the "database:tdb mutexes" option instead.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9758f413d06b0d114f4e5a0e053bbc8956c60b7">a9758f41</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-24T08:59:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-doc: Switch tunable TDBMutexEnabled to a config option

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/21de59ab7fe53240380b9a9a5b32d5af32d34237">21de59ab</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-24T08:59:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Allow boolean configuration values to have yes/no values

This make the new configuration style more consistent with the old one.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/914e9f22d85b9274871b7c7d5486354928080e51">914e9f22</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-24T08:59:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Pass DisableIPFailover tunable via environment variable

Preparation for obsoleting this tunable.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8e160d331aaccd64b1a767c0bde9e310c80afe06">8e160d33</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-24T08:59:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop DisableIPFailover simple test

This is about to become a config file option that can't be dynamically
changed at run-time, so drop this test for now.  This test will be added
once the tunable becomes a config file option.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/893dd623dfdec4d5c5da07f933069e4534fe58ae">893dd623</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-24T08:59:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-failover: Add failover configuration options

Only a "disabled" option for now.  Not documented because it isn't
used yet.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d003a41a9cb9ea97a7da9dbb5bd3138f82da6cf1">d003a41a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-24T08:59:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-config: Integrate failover options into conf-tool

Update and add tests accordingly.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/929634126a334e380f16c080b59d062873b4e5f9">92963412</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-24T08:59:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-config: Switch tunable DisableIPFailover to a config option

Use the "failover:disabled" option instead.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78aad7623e100f05a7dfc142fba7ff2b0eba1913">78aad762</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-24T08:59:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-doc: Switch tunable DisableIPFailover to a config option

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/55893bf8d2cc7e01b3a93d8e1fde16408244cb65">55893bf8</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-24T08:59:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add an extra conf loading test case

This shows that config file loading continues in spite of unknown keys
if ignore_unknown is true.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6fb80cbffb9cb8cba6abc3fbce228811d36e8c9a">6fb80cbf</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-24T12:13:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Check that no IPs are assigned when failover is disabled

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Aug 24 14:13:12 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7c89edfe54b0c5b44635c27371eeb29370270448">7c89edfe</a></strong>
<div>
<span>by Bernd Kuhls</span>
<i>at 2018-08-24T15:22:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix uClibc build on 64bit platforms by including stdint.h

Fixes an error detected by buildroot autobuilders:
http://autobuild.buildroot.net/results/573/573e2268e205e10d1352fa81122d8f225fdb4575/build-end.log

/home/rclinux/rc-buildroot-test/scripts/instance-1/output/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/stdint.h:122:27:
error: conflicting types for 'uintptr_t'
 typedef unsigned long int uintptr_t;
                           ^
In file included from ../lib/ldb/tests/ldb_msg.c:17:0:
../third_party/cmocka/cmocka.h:126:28: note: previous declaration of 'uintptr_t' was here
       typedef unsigned int uintptr_t;

The define __WORDSIZE is missing when cmocka.h decides how to
define uintptr_t, this patch includes stdint.h when needed.

Patch sent upstream:
https://lists.samba.org/archive/samba-technical/2018-January/125306.html

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Aug 24 17:22:10 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e5e66191f214b521f67a19401a72171d9952616a">e5e66191</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-08-25T01:23:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove unused KOPLOCK flags

This effectively reverts commit 17eba16b. It looks like these flags have
been introduced as part of the onefs support which has been removed
again. As there is no other use for the flags, remove them.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Sat Aug 25 03:23:05 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a4f9e3805e2e22d5f100a3ac4d9b7ecfaa3b5f4e">a4f9e380</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-25T07:00:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Ensure winbindd is talking to the DC (itself) at startup

This might reduce issues with the first winbind-using test failing

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a19563eaacd660f09a49a775bdbc5ba1b25925c">9a19563e</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-25T07:00:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Ensure all python3 tests are tagged (named) python3

This will help when splitting them into a distinct build.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da6530d9d18e5923ebd94c8a3f2865a193b37a73">da6530d9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-25T07:00:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Move samba.tests.dcerpc.rpcecho to chgdcpass:local

Before this patch, no python3-compatible tests ran against any of fl2000dc, vampire_2000_dc or chgdcpass
and so an autobuild of the samba-ad-dc-2-py3 environment would fail with no tests to run.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3d2baa9c95c8e2b3f8952e5e0bf6984408961b13">3d2baa9c</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-25T07:00:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Move samba.tests.lsa_string to none environment, it does not contact a server

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/05389bcbf854eaad1e299d5bea7d68806f7b72ba">05389bcb</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-25T09:53:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Allow automatic handling of autobuild tasks ending in -py3

This will allow splitting up of the python2 and python3 tests without
duplication of this already complex file.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Aug 25 11:53:15 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a3b64707f368f17df2d0a0b95627d076c96a273">9a3b6470</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-27T06:53:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Fix -py3 support to look in tasks (the table with the tests) not tasknames (the requested list)

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c833ec4c9349eec1d71de9a1fc21fbbc60f00829">c833ec4c</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-27T10:00:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">travis-ci: Add python3-crypto to package list

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Aug 27 12:00:11 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59f13347260f5c4367c709eb07139f2ba7ddad72">59f13347</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-27T15:28:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit: Add $cwd arg to smb_fname_str_do_log().

Not yet used.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13565

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4d72ebb821518c25e4759ad697d5e18257f80765">4d72ebb8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-08-27T18:23:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit: Ensure smb_fname_str_do_log() only returns absolute pathnames.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13565

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Aug 27 20:23:55 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a5c4d91ebf6527001a2cc8a316db931768ec8249">a5c4d91e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-27T21:09:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Add protocol-agnostic cli_read

So far only cli_pull could be called directly without looking at the
protocol. We did not have a simple read that did the right thing
depending on the protocol

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fd203725cab0b5b604a4ae8adccc084dfcad9639">fd203725</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-27T21:09:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Rename cli_writeall_send/recv to cli_smb1_writeall_send/recv

Preparing a protocol agnostic writeall

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/082f60af26f1822c815e70c189aa42d54228e414">082f60af</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-27T21:09:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Expose protocol-agnostic cli_writeall_send/recv

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ffa1c040c625336209a6310e234f5087dd62e984">ffa1c040</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-28T00:03:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">examples: Add winexe re-implemented on current Samba libs

winexe from https://sourceforge.net/projects/winexe/ is a project
based on Samba libraries from 2012. According to the winexe git
repository the last Samba commit winexe was updated to is 47bbf9886f0c
from November 6, 2012. As winexe uses unpublished Samba internal
libraries, it broke over time.

This is a port of the winexe functionality to more modern Samba
versions. It still uses internal APIs, but it being part of the tree
means that it is much easier to keep up to date.

The Windows service files were taken literally from the original
winexe from the sourceforge git. Andrzej Hajda chose GPLv3 only and
not GPLv3+. As GPL evolves very slowly, this should not be a practical
problem for quite some time.

To build it under Linux, you need mingw binaries on your build
system. Under Debian stretch, the package names are gcc-mingw-w64 and
friends.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Aug 28 02:03:07 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0da15fa764c61bece2c99e1816ba0e782f2753de">0da15fa7</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-29T03:28:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Implement a split python2 and python2 build pattern

The default tasks will run the tests without --extra-python specified and
the new -py3 tasks will run the python3 tests only.

This will reduce the complexity of the build combinations

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ce53dd9cf41f195ba784f40f74910891895bf695">ce53dd9c</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-29T03:28:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci: Run the new python3 autobuild tasks

These additional tasks should be less complex than the full build and help get us to
a pure python3 build eventually

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/38784f2b371af2471ec08cf38bbcaea004efcce3">38784f2b</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-29T03:28:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Reduce duplication of task list in autobuild

The defaulttasks or builddirs are often updated out of sync, which causes confusion until
it is resolved.

We simply choose "." as the builddir for the tasks that
are not in the default set.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f9e494a6f2999641f386f658351c539d1ad9edae">f9e494a6</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-29T03:28:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Move ad_dc_no_nss into to samba-ad-dc-2 autobuild job

This tries to to split up the tasks more evenly and may help with the python3 tests
against this environment if started from a more isolated job.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b11643617dcdf75740be9218f83254d8826c14b">6b116436</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-29T03:28:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Move backup/restore environments into to samba-ad-dc-2 autobuild job

This tries to to split up the tasks more evenly and may help with the python3
work by isolating them from the long samba job.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/acb8cf1eaf7232a994aafc83fc12d723b71d981b">acb8cf1e</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-29T03:28:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">travis-ci: Add py3 jobs to match new jobs in autobuild.py

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/47c14ef64e0037ad3e5ac9d8ddf9801501dcdcab">47c14ef6</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-29T03:28:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: use close_fds=True to avoid *.stderr and *.stdout inheriting into every process

This closes fds other than 0, 1, 2.

This ensures only the correct *.stderr and *.stdout is attached, via
the stdout/stderr parameter to Popen(), but not every other FD
currently open in python at the time Popen is called.

For the tail invocation and other calls to Popen(), because fds 0, 1,
2 are still attached, these function as before.

Per https://docs.python.org/2.6/library/subprocess.html:

"If close_fds is true, all file descriptors except 0, 1 and
2 will be closed before the child process is executed. (Unix only)."

And regarding the passed in parameters:

"stdin, stdout and stderr specify the executed programs’ standard
input,
standard output and standard error file handles, respectively.  "
...

"With None (the default), no redirection will occur;
the child’s file handles will be inherited from the parent. "

(The unwanted inherited files would be on a random high FD, where the
program wouldn't know what to do with them, but counting towards the
process FD limit).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13591

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/825d67fd35a809e779b916a82e63df8c8de01772">825d67fd</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-08-29T06:20:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Avoid subshell for tail -f invocation

This should mean one less process in the process tree, and less places to hold
FDs open.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13591

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Aug 29 08:20:55 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/81f4971fc9a0cd597fcfaf5285170447a6482808">81f4971f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-29T16:33:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Improve torture_libsmbclient_init_context()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/30ee1d3dad611610adfbb60669d723adcaad0db5">30ee1d3d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-29T16:33:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Schedule libsmbclient tests against ad_dc

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a7d95fc2c2f65f5c1268229595a523627eac96c">7a7d95fc</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-08-29T19:28:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Add a test for listing shares

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Aug 29 21:28:41 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99d6237a63fb59bf851fe846633f2a041d0d9a4d">99d6237a</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-08-30T02:48:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl/tests: fix ndr_push_init_ctx() usage

The code in libndr got rid of the second argument quite some time ago
(2010): f9ca9e46ad24036bf00cb361a6cef4b2e7e98d7d

However, pidl tests did include a code that passed two arguments.
Recently GCC started to fail to compile such code.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Aug 30 04:48:00 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dc6040c121c65d5551c686f3f1be2891795f48aa">dc6040c1</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Add support for sock daemon to notify of successful startup

The daemon writes 0 into the specified file descriptor when it is up
and listening.  This can be used to avoid loops in clients that
attempt to connect until they succeed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/11ee92d1bfd73c509d90e7a7386af60a4e1a7fca">11ee92d1</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Add support to eventd for the startup notification FD

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e357b62fe556609750bdb8d27cf48dfb85c62ec8">e357b62f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Improve error handling consistency

Other errors free argv, so do it here too.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c446ae5e1382d5e32c33ce92243daf6b4338e15a">c446ae5e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Open eventd pipe earlier

The pipe will soon be needed earlier, so initialise it earlier.
Ensure the file descriptors are closed on error.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/62ec1ab1470206d6a2cf300f30ca0b4a39413a38">62ec1ab1</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Wait for eventd to be ready before connecting

The current method of retrying the connection to eventd means that
messages get logged for each failure.

Instead, pass a pipe file descriptor to eventd and wait for it to
write 0 to the pipe to indicate that it is ready to accept client
connections.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b430a1ace69bcef3336907557ab5bf04271c1110">b430a1ac</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Do not retry connection to eventd

Confirmation is now received from eventd that it is accepting
connections, so this is no longer needed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/032593487f750b60f51462c4f5133ccdbbe1f78f">03259348</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Fix CID 1414745 - Out-of-bounds access

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7c361f4866ca9a2989d214cf132df56a78a8c638">7c361f48</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Restore dropped copyright attributions

Commit fa94a49dbbec4a65c368a533a534f952a9f147a7 accidentally dropped
some copyright attributions.  The original version of system_socket.c
was based on system_linux.c but many parts have been taking from
system_freebsd.c, which had these additional copyright attributions.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0927b382265191a756f131e7c81ac687d85353eb">0927b382</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add basic test to sanity check types in socket marshalling

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/172b87cb1be460a06b7bea0b598a5bf159d3faab">172b87cb</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Initialise structures when declared

Instead of using ZERO_STRUCT().

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2ebb25dfc890923180ecb06d6e17ddb2948e7d2b">2ebb25df</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Factor out common ARP code

Finding the interface and the MAC address are obvious.  Might as well
set up the common parts of the destination address structure.

Continue to open the socket and find the MAC address first.  This
might seem odd because marshalling and other subsequent steps may
fail.  However, in the future this code might be optimised to open a
single socket to send ARPs for a list of addresses on each interface,
so don't change the logic.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/50a6d15256a22a8116b48b40c17c8c8620c2cd84">50a6d152</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Fix error handling when sending ARPs

There are numerous places in the code where errno can be lost causing
the wrong error to be printed by a caller.  Change ctdb_sys_send_arp()
to always return a useful errno on error instead of returning -1 and
sometimes having errno set correctly.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/39cfd51143b5bddc154b1d22b3768a2f4eef2161">39cfd511</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Separate ARP and IPv6 NA marshalling code

This can be tested separately.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87088af6e49e9ce973cfe77d36cfbf42f9101854">87088af6</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add tests for ARP and IPv6 NA marshalling

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e2a00feca3565d3071424246bb25ad1623bdfe6c">e2a00fec</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Be more careful with packet sizes

Ethernet packets must be at least 64 bytes.

For ARP the packet size was limited to 64 bytes.  This is probably OK
but the code might as well be a little more general.

For IPv6 NA there was no guarantee that the packet is at least 64
bytes.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b1e9a43dcd0e4aa158f1e03351b9fefc2db1162">6b1e9a43</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Use struct ether_arp to avoid manual offset calculations

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ca0db67df9a122528a37558ddfe8f9a34e7ff684">ca0db67d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Clarify offset and packet length calculations

Calculate each offset from the beginning of the buffer and explicitly
use the sizes of structures.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/af5a42bf028b2159eed740c1e7d8baae11eb4c06">af5a42bf</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Set version more obviously in IPv6 NA packet

Version is the top 4 bits of this field.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a67899573a4386c212949303e26d0bed506abd8f">a6789957</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Avoid single line multi-assignment

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d7d23e78ed2aa24d1807c2718d44afe3d8c70da6">d7d23e78</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Factor out TCP packet marshalling code

This can be tested separately.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a02cba1c8a716d8e939d9bfb59e038e14f96e69a">a02cba1c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add tests for TCP packet marshalling

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8fcf1af559f2a716ebcfb8277668d6539fd432f0">8fcf1af5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Avoid magic numbers when building TCP packets

Most packet sizes and offsets are multiples of 32-bit words.  The IPv6
payload length is in octets.  The IPv6 version is the top 4 bits of
the relevant field.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0beb16f34ea538519213bb2f81d2cd04467c5baa">0beb16f3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Don't modify a const argument

The current code might be slightly more efficient but
intentionally (although temporarily) modifying a const argument just
seems wrong.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f3a1f1e1fa9a8a0fe6ffd3809a64d8185cb561b7">f3a1f1e1</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Fix a bug in non-Linux (PCAP) TCP packet capturing

Captured packets include a link-layer header, which is considered in
the Linux code but not the PCAP code.  Also, the actual captured
length is in caplen, not len.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cb4848e35951d8dc232643b45116fb54655ffa30">cb4848e3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Fix error handling when parsing TCP packets

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/028fdc12e7399dae23fec20deb3ec0284f9d0ce2">028fdc12</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Clean up types/declarations in TCP socket reading

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e2ac36867d616d06ac37498534ba89eb77f5d833">e2ac3686</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Factor out TCP packet parsing code

This can be tested separately.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/43a2022596ed3bde1e2c833070b531a4b7289b84">43a20225</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Extend TCP packet test to also do packet extraction

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/924a655b2a56edea66064dd1fdf67d9b7e093b64">924a655b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Improve TCP packet size and offset calculations

The IPv4 check for short packets was strange.  It appeared to ensure
that the capture included everything up to and including the window
size.  The checksum field immediately follows the window size field,
so just ensure that the packet is large enough to contain everything
up to the start of the checksum.

Add a similar check for IPv6 packets.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53ceac9694f2f530e875ec56ec15867205ae088e">53ceac96</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T02:48:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Check the version field in IPv6 packets

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/58b8f2a31e30a9fe9180f3758acaebf7deffbd91">58b8f2a3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-08-30T05:50:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Clean up comments in TCP packet parsing

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Thu Aug 30 07:50:04 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f60a77e0b4c8ad06a8156ff5b5ebc5902d4ec17">9f60a77e</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-08-30T16:07:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Fix lstat check in directory_create_or_exist

The lstat check in directory_create_or_exist did not verify whether an
existing object is actually a directory. Also move the check to only
apply when mkdir returns EEXIST; this fixes CID 241930 Time of check
time of use.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/83f0ac5c6da48c1a68f6a7b29992398735abb421">83f0ac5c</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-08-30T19:19:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Add test for directory_create_or_exist

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Thu Aug 30 21:19:31 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b7d77ce4b38de7deae4875122c40cb038f4f4c98">b7d77ce4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-08-31T16:42:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Fix the build on FreeBSD

FreeBSD needs to explicitly #include <unistd.h> for geteuid() and close()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Aug 31 18:42:31 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/44840ba5b32a2ce7959fd3d7c87822b3159416d3">44840ba5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-08-31T20:22:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_delay_inject: adding delay to VFS calls

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13549

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3255822f75163cb38e53f634a5c6b03d46bfaff1">3255822f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-08-31T20:22:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:selftest: reformat smb2_s3only list

No change besides reformatting the list to one entry per line.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13549

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5508024a861e7c85e6c837552ad142aa1d5e8eca">5508024a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-08-31T20:22:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: add a durable handle test with delayed disconnect

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13549

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b70b8503faded81b10859131f08486349876d132">b70b8503</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-08-31T20:22:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: reorder tcon global record deletion and closing files of a tcon

As such, this doesn't change overall behaviour, but in case we ever add
semantics acting on tcon record changes via an API like
dbwrap_watch_send(), this will make a difference as it enforces
ordering.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13549

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8f6edcc1645e0ed35eaec914bd0b672500ce986c">8f6edcc1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-08-31T20:22:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: let session logoff close files and tcons before deleting the session

This avoids a race in durable handle reconnects if the reconnect comes
in while the old session is still in the tear-down phase.

The new session is supposed to rendezvous with and wait for destruction
of the old session, which is internally implemented with
dbwrap_watch_send() on the old session record.

If the old session deletes the session record before calling
file_close_user() which marks all file handles as disconnected, the
durable handle reconnect in the new session will fail as the records are
not yet marked as disconnected which is a prerequisite.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13549

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d95f79f604d90c2646225a0f2470f05dd71e19e">5d95f79f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-08-31T23:26:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: add a comment stating that file_close_user() is redundant for SMB2

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13549

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Sep  1 01:26:35 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cfb19e98b1afe8c23fb65dd3e1448f51cc0ab591">cfb19e98</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-09-03T01:22:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Set NSS_WRAPPER_HOSTS when creating the trusts

Otherwise this relies on the order that tests run to cause the environment variable
to be left behind.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/85ef0590a544e97f2c800589d05646002c48b95a">85ef0590</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-09-03T01:22:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Set RESOLV_WRAPPER_CONF/RESOLV_WRAPPER_HOSTS when running dcpromo

Otherwise this relies on the order that tests run to cause the environment variable
to be left behind.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ac30d7b6c43bd194f029a6d8f34b4bb1bece9953">ac30d7b6</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-09-03T01:22:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Remove excption for NSS_WRAPPER_HOSTS and RESOLV_WRAPPER_HOSTS

These must be set correctly for each command in provision also.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/45c0ec855f80a4e1c61e28ec52a23542caa8a0bc">45c0ec85</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: Fix py2/3 relative module import issue

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9688480dab2fef7124297e676ec2ea4e1f7a47c7">9688480d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: port open to io.open for PY2/PY3 compat

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/596db3a5bbca2e93e22a4405d2ad60144bcaf273">596db3a5</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: open files in binary mode as appropriate

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/27df0e81c2b79ff4e2a1f990375a7e2a7d210b07">27df0e81</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: port changes to allow samba.tests.dsdb_lock to work with PY3/PY2

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/999b6db6e3aa3371a1ed42a92e7b7efebb2514bf">999b6db6</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.dsdb_lock for python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/48f3801c207e6c172a75f27da29aa0f0001d51b5">48f3801c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: port samba.tests.unix for py3

L for long literal is no longer valid in Python3, also
long keyword has been removed. int and long have been unified
in python3. A duplicated test has been removed (for long and
int) only the int test remains now.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5efb5ad9abc95d9da73f200720316b1e244334eb">5efb5ad9</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.dcerpc.unix for python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e53629ff3f07880dfb2933919c3d913aa0d016d">0e53629f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest/tests: enable samba.tests.samba_tool.timecmd for python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/563c10ee63c401345bed707b9f14b41d5d2799f7">563c10ee</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: Use io.StringIO for py3 and StringIO.StrinIO for py2

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/94c23ee046ca9cfa36ab5aedfeb56faf8eee459c">94c23ee0</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/compat: use cStringIO instead of StringIO in compat.py

Using cStringIO for py2 seems to incur alot less problems and less changes
to the py2/py3 code then using StringIO.StringIO

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c6100d777bbd73c9e58adb372972f02d7655ee13">c6100d77</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: changes to make samba.tests.samba_tool.join run under py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bff4d80a23dcd7d61f24a7a4b6284ed980ee6a4c">bff4d80a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: Enable samba.tests.samba_tool.join for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/471163e82e1651f9051622be349a5e868db420bd">471163e8</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: changes needed for samba.tests.samba_tool.visualize PY2/PY3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e59ed0a375e974ebcea80f5f23cb9b3651a3c651">e59ed0a3</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">enable samba_tool.visualize_drs samba_tool.visualize_drs for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a701a253269f959c9faa9e4faa888cbecc2dcfe6">a701a253</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: Port fsmo test to python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f0f1872ee129a484641ceff95c253ad90d5e0f92">f0f1872e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/selftest: Enable samba.tests.samba_tool.fsmo for python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/783d8565b424f5ac8bd640357b11929c944e708f">783d8565</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.samba_tool.processes for PY3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/210b950c81d252c0af0fb82cb9241fad0ead5280">210b950c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: Add some helper functions to encode/decode strings

Sometimes in PY3 we have variables whose content can be 'bytes' or
'str' and we can't be sure which. Generally this is because the
code variable to be used can be initialised (or reassigned) a value
from different api(s) or functions depending on complex conditions or
logic. Or another common case is in PY2 the variable is 'type <str>'
and in PY3 it is 'class <str>' but the function to use e.g. b64encode
requires 'bytes' in PY3. In such cases in PY3 it would be nice to avoid
excessive testing in the client code, in PY2 we would like to ensure the
code runs unchanged. In otherwords we wish to avoid in PY2 unnecessary
decode() calls which convert otherwise 'str' types to 'unicode'.
Mixing 'str' and 'unicode' can cause strange and unexpected problems,
sometimes we can't avoid this but it we should avoid if we can.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/638476f86d4f8072de186eac562c176bacef68ef">638476f8</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: PY3 port for samba.tests.samba_tool.user_wdigest test

In addition to the attributes that caused some issues specifically
with the test some other ldb.bytes objects (those seen to be
used as strings) have been adjusted (with str()) to ensure they should
work correct in PY3.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d29fdb02e6aeee9d229367dc2133cfaffc3bc8cd">d29fdb02</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.samba_tool.user_wdigest for python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/765b17627c0b1475ebb206526d2ee5433dcebb18">765b1762</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.samba_tool.user_check_password_script py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd1fce7cdb1d1b05c37409fcb185e3bd6ed88d28">dd1fce7c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/sambe/tests/samba_tool: PY3 port for tests.samba_tool.group

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a167c449d152e232e47ee076b24fd9d7e539af64">a167c449</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.group for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4764ac05e67dd770894e563fbca31314fb196695">4764ac05</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.samba_tool.ou for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/683d51fb5cd7c859cff718d671832247b0a8b3a4">683d51fb</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: changes for samab.tests.samba_tool.computer

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/84c890b244c6a72c9be18e91b508e186ae51046c">84c890b2</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/provision: remove use of str() func for binary data

Python 2 code works with str(policy["nTSecurityDescriptor"]) however
this cannot work with Python 3. One could argue even the str method
doesn't make sense at all (returning a string) for data.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a2df705f6a834194e2e50210bf36a0d425a8fa1">7a2df705</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.samba_tool.ntacl for Py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/252950ac08554d7c86a5cfc2c7fbc626c4c5f863">252950ac</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: Fix password usage for py2/py3 compatability

getpass returns str (e.g. bytes) in python2 and str (unicode) in
py3. Adapt code to so we don't do illegal things (like try and decode)
a string in python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4188a02bc21dcef37da1e31da731d8473f2becf5">4188a02b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: Enable samba.tests.samba_tool.provision_password_check for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f86693c84c51b39e8303d06eb3510e016efaab87">f86693c8</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: Py2/Py2 enable samba.tests.samba_tool.help to run

Ensure bytes output is converted to text type for PY3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9bded41d2ae0174a40596ffdb8122bc58b2aabb2">9bded41d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.samba_tool.help for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ffdbc4aa67ceba983f4eb45595a6d0c0eaa00e04">ffdbc4aa</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: Enable samba.tests.samba_tool.sites for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f304a273d64fb27f5d7de7a3fd2b630b6141bf70">f304a273</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.samba_tool.dnscmd for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/945359bc6fac52339a49ba3e224b02faa823decc">945359bc</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Update known fail with py3 variant of samba.tests.dcerpc.dnsserver

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/179cd3dbdb7cb95ea15a93abaf3552d347ade42e">179cd3db</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.dcerpc.dnsserver for python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b3a5dac3e3f617bc49fcd33cf56e3ea466cfe6ad">b3a5dac3</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.dcerpc.dnsserver(ad_dc) for python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c958a04327b4c6598cf8666edfbd44fc5fa15c96">c958a043</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: ensure byte content (not strings)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a467dc2a3135a8140cff7a655bd195f1df0762a1">a467dc2a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/test/dcerpc: Py3 port of samba.tests.dcerpc.raw_protocol

Port code to allow this test run with either py2 or py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f5726ddc9da131125d4c6d5598a866fbd225db3c">f5726ddc</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.dcerpc.raw_protocol for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9df799d1b2c0d1d211b105ac43b8f7332622d547">9df799d1</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: PY2/PY3 required changes for samba.tests.samba_tool.user

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c6fd15e2337e821cdb102d08cd889aa11336e145">c6fd15e2</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: Adjust teardown so second run of tests succeeds

A second run of this test (e.g. with --extra-python) or even
an manual re-run and the cache is still there.
use of '--cache-ldb-initialize'  will fail and so with the test
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/17290a3770f1dacdded2fe7821a3afe4f523b424">17290a37</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.samba_tool.user for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/82408fdc1f6c92baacd207438ffbcf9710e127ac">82408fdc</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: PY2/PY3 changes required for user_virtualCryptSHA test

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9eb26065d0c64c21bf09023d0c199445adb7e8a8">9eb26065</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-03T01:22:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.samba_tool.user_virtualCryptSHA for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a740a6131c967f9640b19a6964fd5d6f85ce853a">a740a613</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-09-03T01:22:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Prepare to allow override of lockout duration in password_lockout tests

This will make it easier to avoid flapping tests.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/74357bf347348d3a8b7483c58e5250e98f7e8810">74357bf3</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-09-03T04:14:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Split up password_lockout into tests with and without a call to sleep()

This means we can have a long observation window for many of the tests and
so make them much more reliable.  Many of these cause frustrating flapping
failures in our CI systems.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Sep  3 06:14:55 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6d3d9a85e5630ba398ac953ad1515155f10224d9">6d3d9a85</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-03T08:52:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Log complete eventd startup command

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b5453bc27add11a7288772a59adcc605328b9098">b5453bc2</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-03T08:52:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop incorrect log message

The message is incorrect because the actual failure was loading the
config file.  Instead of fixing the message, drop it because
ctdb_config_load() already logs the failure.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/421d828f6cb7c13d5f33c6cc1c6be254554588a4">421d828f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-03T08:52:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Fix log message for conf option with unknown section

This covers both options that appear before a section and options in
unknown sections.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ebb28c57a17777ea15afab63cd0742dd79b30ffe">ebb28c57</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-03T08:52:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Log a message for unknown conf option

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a017d3181ac1062b66ae506a8a523f7455630fce">a017d318</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-03T08:52:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Log a message when an invalid conf value is encountered

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f1084400387c0b1257b6d92ee6e8a89504d788fc">f1084400</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-03T08:52:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Avoid ENOENT for unknown conf type tags

Only use ENOENT for missing configuration file.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/920ed66ba7e874ca23d72fff9342fbd64a1e329f">920ed66b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-03T08:52:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Avoid ENOENT for unknown conf options

Only use ENOENT for missing configuration file.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4f1727fe0bf2b0962a5d131d60a416b8f459ad94">4f1727fe</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-03T08:52:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Process the whole config file even if an error occurs

At the moment multiple errors will be encountered one at a time, on
each load or validate.  Instead, allow all configuration errors to
printed in a single pass.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13589

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eed738a37a6f40ca259153979f364c17e77f52ea">eed738a3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-03T08:52:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: If bin/ isn't in ctdb/ then look one level higher

CTDB's test suite doesn't work from a top-level compile.  The first
step to fixing this is to correctly locate the bin/ directory.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8aacde3c5d86d8a0216b3bba200a39ca9a561653">8aacde3c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-03T08:52:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use known install paths in local daemon tests

The in-tree local daemons tests don't work from a top-level Samba
compile.  The simple test suite was the first test suite and things
have generally worked, so it has been slow to adopt general test
infrastructure changes.

Instead of re-calculating script and helper locations, use the paths
from script_install_paths.sh.  The bin/ directory is already added to
PATH in common.sh, so don't add it here.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/30eb28818d5fbbb35d0965a92f721243aca6ab54">30eb2881</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-03T12:04:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Don't run valgrind or other tracing in simple_test_command()

This function is used to run a extra command to check a result.  This
command is usually a script (often a stub) or an external command, so
no need to trace it with valgrind or whatever else might be specified.
In the worst case the command being run is a shell function, which
valgrind won't be able to find.

There is little use running the event script tests under valgrind.
However, when the whole test suite is being run under valgrind then it
should work.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon Sep  3 14:04:00 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0bd109b733fbce774feae2142d25f7e828b56bcb">0bd109b7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-03T16:44:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix a memleak in async search ask sharemode

fetch_share_mode_unlocked_parser() takes a "struct
fetch_share_mode_unlocked_state *" as
"private_data". fetch_share_mode_send() used a talloc_zero'ed "struct
share_mode_lock". This lead to the parser putting a "struct
share_mode_lock on the NULL talloc_context where nobody really picked it
up.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13602
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/89f9c163f32a409a40ae73455af892e58cd0e214">89f9c163</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-03T16:44:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_tool: Simplify dbwrap_tool_erase

That's what dbwrap_wipe is for :-)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/46819e2628a1439a94ed3a63bc164ce1d7b67706">46819e26</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-03T16:44:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_tool: Simplify listkey_fn

To me dbwrap_record_get_key(rec).dsize just looks a bit ugly

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/02d448429cc7f715b34d42aa425b74a715221202">02d44842</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-03T16:44:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_tool: Simplify persistent/non-persistent check

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0ce26c75cb0329d013365dcff973d6ebe2261775">0ce26c75</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-03T16:44:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_tool: Avoid an unnecessary "else"

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/05e618cbaf5b28e9db7f7e1f47bd98943f71c40a">05e618cb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-03T19:38:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_tool: We don't do "listwatchers" anymore

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Mon Sep  3 21:38:40 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dffc182c6943d21513d8db9f6cf66bdc09206b17">dffc182c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T00:31:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/rpc/netlogon: assert that cli_credentials_get_{workstation,password} don't return NULL

This is better that generating a segfault while dereferencing a NULL
pointer later.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11517

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d5dd8fdc647d6a202c5da0451d395116c2cd92b9">d5dd8fdc</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T00:31:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/rpc/netlogon: verify the trusted domains output of LogonGetDomainInfo()

This makes sure we don't treat trusted domains in the same way we treat
our primary domain.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11517

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f5f96f558b499770cdeb3d38998167a387e058b9">f5f96f55</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T00:31:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb/util_trusts: domain_dn is an input parameter of dsdb_trust_crossref_tdo_info()

We should not overwrite it within the function.
Currently it doesn't matter as we don't have multiple domains
within our forest, but that will change in future.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11517

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c1b0ac95db5c6112d90356c7ada8c3d445e9b668">c1b0ac95</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T00:31:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb:util_trusts: add dsdb_trust_local_tdo_info() helper function

This is similar to dsdb_trust_xref_tdo_info(), but will also work
if we ever support more than one domain in our forest.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11517

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e442e094240abbf79aaca00a9d1a053a200a7e8">0e442e09</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T00:31:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:dsdb/common: add samdb_domain_guid() helper function

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11517

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/61333f7787d78e3ec5c7bd2874d5a0f1f536275a">61333f77</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T00:31:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/netlogon: use samdb_domain_guid()/dsdb_trust_local_tdo_info() to build our netr_OneDomainInfo values

The logic for constructing the values for our own primary domain differs
from the values of trusted domains. In order to make the code easier to
understand we have a new fill_our_one_domain_info() helper that
only takes care of our primary domain.

The cleanup for the trust case will follow in a separate commit.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11517

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ef0b489ad0d93199e08415dd895da5cfe2d1c11a">ef0b489a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T00:31:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/netlogon: make use of talloc_zero_array() for the netr_OneDomainInfo array

It's much safer than having uninitialized memory when we hit an error
case.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11517

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2099add0657126e4a5427ec2db0fe8025478b355">2099add0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T00:31:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/netlogon: don't treet trusted domains as primary in LogonGetDomainInfo()

We need to handle trusted domains differently than our primary
domain. The most important part is that we don't return
NETR_TRUST_FLAG_PRIMARY for them.

NETR_TRUST_FLAG_{INBOUND,OUTBOUND,IN_FOREST} are the relavant flags
for trusts.

This is an example of what Windows returns in a complex trust
environment:

     netr_LogonGetDomainInfo: struct netr_LogonGetDomainInfo
        out: struct netr_LogonGetDomainInfo
            return_authenticator     : *
                return_authenticator: struct netr_Authenticator
                    cred: struct netr_Credential
                        data                     : f48b51ff12ff8c6c
                    timestamp                : Tue Aug 28 22:59:03 2018 CEST
            info                     : *
                info                     : union netr_DomainInfo(case 1)
                domain_info              : *
                    domain_info: struct netr_DomainInformation
                        primary_domain: struct netr_OneDomainInfo
                            domainname: struct lsa_StringLarge
                                length                   : 0x0014 (20)
                                size                     : 0x0016 (22)
                                string                   : *
                                    string                   : 'W2012R2-L4'
                            dns_domainname: struct lsa_StringLarge
                                length                   : 0x0020 (32)
                                size                     : 0x0022 (34)
                                string                   : *
                                    string                   : 'w2012r2-l4.base.'
                            dns_forestname: struct lsa_StringLarge
                                length                   : 0x0020 (32)
                                size                     : 0x0022 (34)
                                string                   : *
                                    string                   : 'w2012r2-l4.base.'
                            domain_guid              : 0a133c91-8eac-4df0-96ac-ede69044a38b
                            domain_sid               : *
                                domain_sid               : S-1-5-21-2930975464-1937418634-1288008815
                            trust_extension: struct netr_trust_extension_container
                                length                   : 0x0000 (0)
                                size                     : 0x0000 (0)
                                info                     : NULL
                            dummy_string2: struct lsa_StringLarge
                                length                   : 0x0000 (0)
                                size                     : 0x0000 (0)
                                string                   : NULL
                            dummy_string3: struct lsa_StringLarge
                                length                   : 0x0000 (0)
                                size                     : 0x0000 (0)
                                string                   : NULL
                            dummy_string4: struct lsa_StringLarge
                                length                   : 0x0000 (0)
                                size                     : 0x0000 (0)
                                string                   : NULL
                            dummy_long1              : 0x00000000 (0)
                            dummy_long2              : 0x00000000 (0)
                            dummy_long3              : 0x00000000 (0)
                            dummy_long4              : 0x00000000 (0)
                        trusted_domain_count     : 0x00000006 (6)
                        trusted_domains          : *
                            trusted_domains: ARRAY(6)
                                trusted_domains: struct netr_OneDomainInfo
                                    domainname: struct lsa_StringLarge
                                        length                   : 0x000e (14)
                                        size                     : 0x0010 (16)
                                        string                   : *
                                            string                   : 'FREEIPA'
                                    dns_domainname: struct lsa_StringLarge
                                        length                   : 0x0018 (24)
                                        size                     : 0x001a (26)
                                        string                   : *
                                            string                   : 'freeipa.base'
                                    dns_forestname: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    domain_guid              : 00000000-0000-0000-0000-000000000000
                                    domain_sid               : *
                                        domain_sid               : S-1-5-21-429948374-2562621466-335716826
                                    trust_extension: struct netr_trust_extension_container
                                        length                   : 0x0010 (16)
                                        size                     : 0x0010 (16)
                                        info                     : *
                                            info: struct netr_trust_extension
                                                length                   : 0x00000008 (8)
                                                dummy                    : 0x00000000 (0)
                                                size                     : 0x00000008 (8)
                                                flags                    : 0x00000022 (34)
                                                       0: NETR_TRUST_FLAG_IN_FOREST
                                                       1: NETR_TRUST_FLAG_OUTBOUND
                                                       0: NETR_TRUST_FLAG_TREEROOT
                                                       0: NETR_TRUST_FLAG_PRIMARY
                                                       0: NETR_TRUST_FLAG_NATIVE
                                                       1: NETR_TRUST_FLAG_INBOUND
                                                       0: NETR_TRUST_FLAG_MIT_KRB5
                                                       0: NETR_TRUST_FLAG_AES
                                                parent_index             : 0x00000000 (0)
                                                trust_type               : LSA_TRUST_TYPE_UPLEVEL (2)
                                                trust_attributes         : 0x00000008 (8)
                                                       0: LSA_TRUST_ATTRIBUTE_NON_TRANSITIVE
                                                       0: LSA_TRUST_ATTRIBUTE_UPLEVEL_ONLY
                                                       0: LSA_TRUST_ATTRIBUTE_QUARANTINED_DOMAIN
                                                       1: LSA_TRUST_ATTRIBUTE_FOREST_TRANSITIVE
                                                       0: LSA_TRUST_ATTRIBUTE_CROSS_ORGANIZATION
                                                       0: LSA_TRUST_ATTRIBUTE_WITHIN_FOREST
                                                       0: LSA_TRUST_ATTRIBUTE_TREAT_AS_EXTERNAL
                                                       0: LSA_TRUST_ATTRIBUTE_USES_RC4_ENCRYPTION
                                    dummy_string2: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    dummy_string3: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    dummy_string4: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    dummy_long1              : 0x00000000 (0)
                                    dummy_long2              : 0x00000000 (0)
                                    dummy_long3              : 0x00000000 (0)
                                    dummy_long4              : 0x00000000 (0)
                                trusted_domains: struct netr_OneDomainInfo
                                    domainname: struct lsa_StringLarge
                                        length                   : 0x0016 (22)
                                        size                     : 0x0018 (24)
                                        string                   : *
                                            string                   : 'S1-W2012-L4'
                                    dns_domainname: struct lsa_StringLarge
                                        length                   : 0x0036 (54)
                                        size                     : 0x0038 (56)
                                        string                   : *
                                            string                   : 's1-w2012-l4.w2012r2-l4.base'
                                    dns_forestname: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    domain_guid              : afe7fbde-af82-46cf-88a2-2df6920fc33e
                                    domain_sid               : *
                                        domain_sid               : S-1-5-21-1368093395-3821428921-3924672915
                                    trust_extension: struct netr_trust_extension_container
                                        length                   : 0x0010 (16)
                                        size                     : 0x0010 (16)
                                        info                     : *
                                            info: struct netr_trust_extension
                                                length                   : 0x00000008 (8)
                                                dummy                    : 0x00000000 (0)
                                                size                     : 0x00000008 (8)
                                                flags                    : 0x00000023 (35)
                                                       1: NETR_TRUST_FLAG_IN_FOREST
                                                       1: NETR_TRUST_FLAG_OUTBOUND
                                                       0: NETR_TRUST_FLAG_TREEROOT
                                                       0: NETR_TRUST_FLAG_PRIMARY
                                                       0: NETR_TRUST_FLAG_NATIVE
                                                       1: NETR_TRUST_FLAG_INBOUND
                                                       0: NETR_TRUST_FLAG_MIT_KRB5
                                                       0: NETR_TRUST_FLAG_AES
                                                parent_index             : 0x00000004 (4)
                                                trust_type               : LSA_TRUST_TYPE_UPLEVEL (2)
                                                trust_attributes         : 0x00000020 (32)
                                                       0: LSA_TRUST_ATTRIBUTE_NON_TRANSITIVE
                                                       0: LSA_TRUST_ATTRIBUTE_UPLEVEL_ONLY
                                                       0: LSA_TRUST_ATTRIBUTE_QUARANTINED_DOMAIN
                                                       0: LSA_TRUST_ATTRIBUTE_FOREST_TRANSITIVE
                                                       0: LSA_TRUST_ATTRIBUTE_CROSS_ORGANIZATION
                                                       1: LSA_TRUST_ATTRIBUTE_WITHIN_FOREST
                                                       0: LSA_TRUST_ATTRIBUTE_TREAT_AS_EXTERNAL
                                                       0: LSA_TRUST_ATTRIBUTE_USES_RC4_ENCRYPTION
                                    dummy_string2: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    dummy_string3: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    dummy_string4: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    dummy_long1              : 0x00000000 (0)
                                    dummy_long2              : 0x00000000 (0)
                                    dummy_long3              : 0x00000000 (0)
                                    dummy_long4              : 0x00000000 (0)
                                trusted_domains: struct netr_OneDomainInfo
                                    domainname: struct lsa_StringLarge
                                        length                   : 0x0006 (6)
                                        size                     : 0x0008 (8)
                                        string                   : *
                                            string                   : 'BLA'
                                    dns_domainname: struct lsa_StringLarge
                                        length                   : 0x0010 (16)
                                        size                     : 0x0012 (18)
                                        string                   : *
                                            string                   : 'bla.base'
                                    dns_forestname: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    domain_guid              : 00000000-0000-0000-0000-000000000000
                                    domain_sid               : *
                                        domain_sid               : S-1-5-21-4053568372-2049667917-3384589010
                                    trust_extension: struct netr_trust_extension_container
                                        length                   : 0x0010 (16)
                                        size                     : 0x0010 (16)
                                        info                     : *
                                            info: struct netr_trust_extension
                                                length                   : 0x00000008 (8)
                                                dummy                    : 0x00000000 (0)
                                                size                     : 0x00000008 (8)
                                                flags                    : 0x00000022 (34)
                                                       0: NETR_TRUST_FLAG_IN_FOREST
                                                       1: NETR_TRUST_FLAG_OUTBOUND
                                                       0: NETR_TRUST_FLAG_TREEROOT
                                                       0: NETR_TRUST_FLAG_PRIMARY
                                                       0: NETR_TRUST_FLAG_NATIVE
                                                       1: NETR_TRUST_FLAG_INBOUND
                                                       0: NETR_TRUST_FLAG_MIT_KRB5
                                                       0: NETR_TRUST_FLAG_AES
                                                parent_index             : 0x00000000 (0)
                                                trust_type               : LSA_TRUST_TYPE_UPLEVEL (2)
                                                trust_attributes         : 0x00000008 (8)
                                                       0: LSA_TRUST_ATTRIBUTE_NON_TRANSITIVE
                                                       0: LSA_TRUST_ATTRIBUTE_UPLEVEL_ONLY
                                                       0: LSA_TRUST_ATTRIBUTE_QUARANTINED_DOMAIN
                                                       1: LSA_TRUST_ATTRIBUTE_FOREST_TRANSITIVE
                                                       0: LSA_TRUST_ATTRIBUTE_CROSS_ORGANIZATION
                                                       0: LSA_TRUST_ATTRIBUTE_WITHIN_FOREST
                                                       0: LSA_TRUST_ATTRIBUTE_TREAT_AS_EXTERNAL
                                                       0: LSA_TRUST_ATTRIBUTE_USES_RC4_ENCRYPTION
                                    dummy_string2: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    dummy_string3: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    dummy_string4: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    dummy_long1              : 0x00000000 (0)
                                    dummy_long2              : 0x00000000 (0)
                                    dummy_long3              : 0x00000000 (0)
                                    dummy_long4              : 0x00000000 (0)
                                trusted_domains: struct netr_OneDomainInfo
                                    domainname: struct lsa_StringLarge
                                        length                   : 0x000c (12)
                                        size                     : 0x000e (14)
                                        string                   : *
                                            string                   : 'S4XDOM'
                                    dns_domainname: struct lsa_StringLarge
                                        length                   : 0x0016 (22)
                                        size                     : 0x0018 (24)
                                        string                   : *
                                            string                   : 's4xdom.base'
                                    dns_forestname: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    domain_guid              : 00000000-0000-0000-0000-000000000000
                                    domain_sid               : *
                                        domain_sid               : S-1-5-21-313966788-4060240134-2249344781
                                    trust_extension: struct netr_trust_extension_container
                                        length                   : 0x0010 (16)
                                        size                     : 0x0010 (16)
                                        info                     : *
                                            info: struct netr_trust_extension
                                                length                   : 0x00000008 (8)
                                                dummy                    : 0x00000000 (0)
                                                size                     : 0x00000008 (8)
                                                flags                    : 0x00000022 (34)
                                                       0: NETR_TRUST_FLAG_IN_FOREST
                                                       1: NETR_TRUST_FLAG_OUTBOUND
                                                       0: NETR_TRUST_FLAG_TREEROOT
                                                       0: NETR_TRUST_FLAG_PRIMARY
                                                       0: NETR_TRUST_FLAG_NATIVE
                                                       1: NETR_TRUST_FLAG_INBOUND
                                                       0: NETR_TRUST_FLAG_MIT_KRB5
                                                       0: NETR_TRUST_FLAG_AES
                                                parent_index             : 0x00000000 (0)
                                                trust_type               : LSA_TRUST_TYPE_UPLEVEL (2)
                                                trust_attributes         : 0x00000008 (8)
                                                       0: LSA_TRUST_ATTRIBUTE_NON_TRANSITIVE
                                                       0: LSA_TRUST_ATTRIBUTE_UPLEVEL_ONLY
                                                       0: LSA_TRUST_ATTRIBUTE_QUARANTINED_DOMAIN
                                                       1: LSA_TRUST_ATTRIBUTE_FOREST_TRANSITIVE
                                                       0: LSA_TRUST_ATTRIBUTE_CROSS_ORGANIZATION
                                                       0: LSA_TRUST_ATTRIBUTE_WITHIN_FOREST
                                                       0: LSA_TRUST_ATTRIBUTE_TREAT_AS_EXTERNAL
                                                       0: LSA_TRUST_ATTRIBUTE_USES_RC4_ENCRYPTION
                                    dummy_string2: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    dummy_string3: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    dummy_string4: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    dummy_long1              : 0x00000000 (0)
                                    dummy_long2              : 0x00000000 (0)
                                    dummy_long3              : 0x00000000 (0)
                                    dummy_long4              : 0x00000000 (0)
                                trusted_domains: struct netr_OneDomainInfo
                                    domainname: struct lsa_StringLarge
                                        length                   : 0x0014 (20)
                                        size                     : 0x0016 (22)
                                        string                   : *
                                            string                   : 'W2012R2-L4'
                                    dns_domainname: struct lsa_StringLarge
                                        length                   : 0x001e (30)
                                        size                     : 0x0020 (32)
                                        string                   : *
                                            string                   : 'w2012r2-l4.base'
                                    dns_forestname: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    domain_guid              : 0a133c91-8eac-4df0-96ac-ede69044a38b
                                    domain_sid               : *
                                        domain_sid               : S-1-5-21-2930975464-1937418634-1288008815
                                    trust_extension: struct netr_trust_extension_container
                                        length                   : 0x0010 (16)
                                        size                     : 0x0010 (16)
                                        info                     : *
                                            info: struct netr_trust_extension
                                                length                   : 0x00000008 (8)
                                                dummy                    : 0x00000000 (0)
                                                size                     : 0x00000008 (8)
                                                flags                    : 0x0000001d (29)
                                                       1: NETR_TRUST_FLAG_IN_FOREST
                                                       0: NETR_TRUST_FLAG_OUTBOUND
                                                       1: NETR_TRUST_FLAG_TREEROOT
                                                       1: NETR_TRUST_FLAG_PRIMARY
                                                       1: NETR_TRUST_FLAG_NATIVE
                                                       0: NETR_TRUST_FLAG_INBOUND
                                                       0: NETR_TRUST_FLAG_MIT_KRB5
                                                       0: NETR_TRUST_FLAG_AES
                                                parent_index             : 0x00000000 (0)
                                                trust_type               : LSA_TRUST_TYPE_UPLEVEL (2)
                                                trust_attributes         : 0x00000000 (0)
                                                       0: LSA_TRUST_ATTRIBUTE_NON_TRANSITIVE
                                                       0: LSA_TRUST_ATTRIBUTE_UPLEVEL_ONLY
                                                       0: LSA_TRUST_ATTRIBUTE_QUARANTINED_DOMAIN
                                                       0: LSA_TRUST_ATTRIBUTE_FOREST_TRANSITIVE
                                                       0: LSA_TRUST_ATTRIBUTE_CROSS_ORGANIZATION
                                                       0: LSA_TRUST_ATTRIBUTE_WITHIN_FOREST
                                                       0: LSA_TRUST_ATTRIBUTE_TREAT_AS_EXTERNAL
                                                       0: LSA_TRUST_ATTRIBUTE_USES_RC4_ENCRYPTION
                                    dummy_string2: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    dummy_string3: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    dummy_string4: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    dummy_long1              : 0x00000000 (0)
                                    dummy_long2              : 0x00000000 (0)
                                    dummy_long3              : 0x00000000 (0)
                                    dummy_long4              : 0x00000000 (0)
                                trusted_domains: struct netr_OneDomainInfo
                                    domainname: struct lsa_StringLarge
                                        length                   : 0x0016 (22)
                                        size                     : 0x0018 (24)
                                        string                   : *
                                            string                   : 'S2-W2012-L4'
                                    dns_domainname: struct lsa_StringLarge
                                        length                   : 0x004e (78)
                                        size                     : 0x0050 (80)
                                        string                   : *
                                            string                   : 's2-w2012-l4.s1-w2012-l4.w2012r2-l4.base'
                                    dns_forestname: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    domain_guid              : 29daace6-cded-4ce3-a754-7482a4d9127c
                                    domain_sid               : *
                                        domain_sid               : S-1-5-21-167342819-981449877-2130266853
                                    trust_extension: struct netr_trust_extension_container
                                        length                   : 0x0010 (16)
                                        size                     : 0x0010 (16)
                                        info                     : *
                                            info: struct netr_trust_extension
                                                length                   : 0x00000008 (8)
                                                dummy                    : 0x00000000 (0)
                                                size                     : 0x00000008 (8)
                                                flags                    : 0x00000001 (1)
                                                       1: NETR_TRUST_FLAG_IN_FOREST
                                                       0: NETR_TRUST_FLAG_OUTBOUND
                                                       0: NETR_TRUST_FLAG_TREEROOT
                                                       0: NETR_TRUST_FLAG_PRIMARY
                                                       0: NETR_TRUST_FLAG_NATIVE
                                                       0: NETR_TRUST_FLAG_INBOUND
                                                       0: NETR_TRUST_FLAG_MIT_KRB5
                                                       0: NETR_TRUST_FLAG_AES
                                                parent_index             : 0x00000001 (1)
                                                trust_type               : LSA_TRUST_TYPE_UPLEVEL (2)
                                                trust_attributes         : 0x00000000 (0)
                                                       0: LSA_TRUST_ATTRIBUTE_NON_TRANSITIVE
                                                       0: LSA_TRUST_ATTRIBUTE_UPLEVEL_ONLY
                                                       0: LSA_TRUST_ATTRIBUTE_QUARANTINED_DOMAIN
                                                       0: LSA_TRUST_ATTRIBUTE_FOREST_TRANSITIVE
                                                       0: LSA_TRUST_ATTRIBUTE_CROSS_ORGANIZATION
                                                       0: LSA_TRUST_ATTRIBUTE_WITHIN_FOREST
                                                       0: LSA_TRUST_ATTRIBUTE_TREAT_AS_EXTERNAL
                                                       0: LSA_TRUST_ATTRIBUTE_USES_RC4_ENCRYPTION
                                    dummy_string2: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    dummy_string3: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    dummy_string4: struct lsa_StringLarge
                                        length                   : 0x0000 (0)
                                        size                     : 0x0000 (0)
                                        string                   : NULL
                                    dummy_long1              : 0x00000000 (0)
                                    dummy_long2              : 0x00000000 (0)
                                    dummy_long3              : 0x00000000 (0)
                                    dummy_long4              : 0x00000000 (0)
                        lsa_policy: struct netr_LsaPolicyInformation
                            policy_size              : 0x00000000 (0)
                            policy                   : NULL
                        dns_hostname: struct lsa_StringLarge
                            length                   : 0x0036 (54)
                            size                     : 0x0038 (56)
                            string                   : *
                                string                   : 'torturetest.w2012r2-l4.base'
                        dummy_string2: struct lsa_StringLarge
                            length                   : 0x0000 (0)
                            size                     : 0x0000 (0)
                            string                   : NULL
                        dummy_string3: struct lsa_StringLarge
                            length                   : 0x0000 (0)
                            size                     : 0x0000 (0)
                            string                   : NULL
                        dummy_string4: struct lsa_StringLarge
                            length                   : 0x0000 (0)
                            size                     : 0x0000 (0)
                            string                   : NULL
                        workstation_flags        : 0x00000003 (3)
                               1: NETR_WS_FLAG_HANDLES_INBOUND_TRUSTS
                               1: NETR_WS_FLAG_HANDLES_SPN_UPDATE
                        supported_enc_types      : 0x0000001f (31)
                               1: KERB_ENCTYPE_DES_CBC_CRC
                               1: KERB_ENCTYPE_DES_CBC_MD5
                               1: KERB_ENCTYPE_RC4_HMAC_MD5
                               1: KERB_ENCTYPE_AES128_CTS_HMAC_SHA1_96
                               1: KERB_ENCTYPE_AES256_CTS_HMAC_SHA1_96
                               0: KERB_ENCTYPE_FAST_SUPPORTED
                               0: KERB_ENCTYPE_COMPOUND_IDENTITY_SUPPORTED
                               0: KERB_ENCTYPE_CLAIMS_SUPPORTED
                               0: KERB_ENCTYPE_RESOURCE_SID_COMPRESSION_DISABLED
                        dummy_long3              : 0x00000000 (0)
                        dummy_long4              : 0x00000000 (0)
            result                   : NT_STATUS_OK

Best viewed with: git show --histogram -w

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11517

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/38e97f8b52e85bdfcf2d74a4fb3c848fa46ba371">38e97f8b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-09-04T00:31:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: Check for -fstack-protect-strong support

The -fstack-protector* flags are compiler only flags, don't pass them to
the linker.

https://developers.redhat.com/blog/2018/03/21/compiler-and-linker-flags-gcc/

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13601

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fc4df251c88365142515a81bea1120b2b84cc4a0">fc4df251</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-09-04T00:31:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: Add -fstack-clash-protection

https://developers.redhat.com/blog/2018/03/21/compiler-and-linker-flags-gcc/

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13601

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fb047b3d0886cd45e142ae6b8f031ae2245b4505">fb047b3d</a></strong>
<div>
<span>by Robert Scheck</span>
<i>at 2018-09-04T00:31:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update Samba URLs from http:// to https://

Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f98f8e3e8145cf117a133c429d6238a2ba91942e">f98f8e3e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-09-04T00:31:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: Ensure all notify tests use separate directories.

Makes it much easier to find tests that error out whilst
leaving directories behind.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1799633cb9ac574c8c3f44bbfebc59b8033243f1">1799633c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-09-04T00:31:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: Ensure we can't exit without deleting our directory.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c86f6c2916c0c87efffe2d5b48f231a073b8c33e">c86f6c29</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-09-04T03:23:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: Ensure we close the handle on the correct tree-id.

Otherwise we leave a directory behind on exit.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Sep  4 05:23:57 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7356e814dfd3921e465a16cfe4b7998bc6f92dd1">7356e814</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T08:45:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:vfs: fix valgrind warning in SMB_VFS_{PREAD,PWRITE,FSYNC}_RECV()

tevent_req_received() destroys 'state', so we need helper variables
to hold the return value.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Sep  4 10:45:10 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/80324ff6e2fab7adb30073fc48a0c512232f1443">80324ff6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-04T22:48:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">examples: Fix mingw64 detection

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7df505298f71432d5adbcffccde8f97c117a57a6">7df50529</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-04T22:48:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:selftest: test kinit with the interdomain trust user account

To test it, add a blackbox test that ensures we pass a keytab-based
authentication with the trust user account for a trusted domain.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13539

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/39c281a23673691bab621de1a632d64df2c1c102">39c281a2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T22:48:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: add virtualKerberosSalt attribute to 'user getpassword/syncpasswords'

This might be useful for someone, but at least it's very useful for
tests.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13539

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8526feb100e59bc5a15ceb940e6cecce0de59247">8526feb1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T22:48:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs/blackbox: add testit[_expect_failure]_grep() to subunit.sh

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13539

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1b31fa62567ec549e32c9177b322cfbfb3b6ec1a">1b31fa62</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-04T22:48:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs/blackbox: let test_trust_user_account.sh check the correct kerberos salt

This demonstrates the bug we currently have.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13539

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f3e349bebc443133fdbe4e14b148ca8db8237060">f3e349be</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T01:57:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5-samba: interdomain trust uses different salt principal

Salt principal for the interdomain trust is krbtgt/DOMAIN@REALM where
DOMAIN is the sAMAccountName without the dollar sign ($)

The salt principal for the BLA$ user object was generated wrong.

dn: CN=bla.base,CN=System,DC=w4edom-l4,DC=base
securityIdentifier: S-1-5-21-4053568372-2049667917-3384589010
trustDirection: 3
trustPartner: bla.base
trustPosixOffset: -2147483648
trustType: 2
trustAttributes: 8
flatName: BLA

dn: CN=BLA$,CN=Users,DC=w4edom-l4,DC=base
userAccountControl: 2080
primaryGroupID: 513
objectSid: S-1-5-21-278041429-3399921908-1452754838-1597
accountExpires: 9223372036854775807
sAMAccountName: BLA$
sAMAccountType: 805306370
pwdLastSet: 131485652467995000

The salt stored by Windows in the package_PrimaryKerberosBlob
(within supplementalCredentials) seems to be
'W4EDOM-L4.BASEkrbtgtBLA' for the above trust
and Samba stores 'W4EDOM-L4.BASEBLA$'.

While the salt used when building the keys from
trustAuthOutgoing/trustAuthIncoming is
'W4EDOM-L4.BASEkrbtgtBLA.BASE', which we handle correct.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13539

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Sep  5 03:57:22 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8077f462c9854bf8ff3e5ce09c0f22f02cb21910">8077f462</a></strong>
<div>
<span>by Thomas Nagy</span>
<i>at 2018-09-05T04:37:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build:wafsamba: Build on waf 1.9

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d99786151a6ed10baa85173c2a4e35a1db76097">5d997861</a></strong>
<div>
<span>by Thomas Nagy</span>
<i>at 2018-09-05T04:37:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build:wafsamba: Update dist/distcheck commands

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9aa8f2badd660d4ec464d052a0a2ca84387aad88">9aa8f2ba</a></strong>
<div>
<span>by Thomas Nagy</span>
<i>at 2018-09-05T04:37:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build:wafsamba: detail where we are processing the autobuild

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59673353877569a163a95ccf9cf6730c0099e772">59673353</a></strong>
<div>
<span>by Thomas Nagy</span>
<i>at 2018-09-05T04:37:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script/autobuild: use --out instead of -b when calling configure

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/48cf9ccd2b086f902286668738d07455044f466b">48cf9ccd</a></strong>
<div>
<span>by Thomas Nagy</span>
<i>at 2018-09-05T04:37:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/tests.py: Update path to waflib

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cbc6534682829b3115147f73ca9a7eb41008374c">cbc65346</a></strong>
<div>
<span>by Thomas Nagy</span>
<i>at 2018-09-05T04:37:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">thirdparty:waf: New files for waf 1.9.10

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/247d12c4facc59d4d31ebea62234663f8b938ac0">247d12c4</a></strong>
<div>
<span>by Thomas Nagy</span>
<i>at 2018-09-05T04:37:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build:wafsamba: Ignore cfg_file absolute paths differences

Due to build variants, cfg_file paths are written as absolute paths.

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/faef27506977db01cc4619140a71652463914378">faef2750</a></strong>
<div>
<span>by Thomas Nagy</span>
<i>at 2018-09-05T04:37:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build:wafsamba: Remove unnecessary parameters to cmd_and_log

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e65b33c1d40bb2c243f775f388056aed31d8671">4e65b33c</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party:waf: update to upstream 2.0.4 release

Update third_party/waf/ to 2.0.4 to bring us closer to Python 3

This change requires a number of changes in buildtools/ too.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65074d8901d348a6614657e0d3e23c2280ac22e7">65074d89</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/efa94eb39a6d49f4f73d5ab83899f11b6e1e5de8">efa94eb3</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml/wscript_build: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/18c3598b66a5b29486a2c7c8c465620d77b5818c">18c3598b</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dynconfig/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b999fd3c25648af902d57e921e5d3efc1cc6a81c">b999fd3c</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/crypto/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b0a12c81b1afb3fab3ce9ecb4d3ddfe59b624fa8">b0a12c81</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/crypto/wscript_configure: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c703f1d3a75bd975463459f1d53b916ddcc166b">0c703f1d</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/ldb/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ea578830ceebb0b4606dbde1359008d176819cd5">ea578830</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/replace/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/62bb5734b50384637e682ac7219947dacad4aa07">62bb5734</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/talloc/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/15288c38b3e89b889dfc0f5c20fff2b4e749188c">15288c38</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/tdb/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d4cef3b10314615f775d64bb2445958e8d513b10">d4cef3b1</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/tevent/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5f5771408477d627a0cdfc9a7cb221a729d5956a">5f577140</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/util/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e6761832f44ac4cec99f527e84b5d2e7b67b730b">e6761832</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/util/wscript_configure: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8a7411633e175bdc97174fbca2f5366816fbef8f">8a741163</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch/wscript_build: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e1e5b57f72029751951991d358da777594237168">e1e5b57f</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">packaging/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f6ce8f834f7448364fb465ecfc2d5640ffb2b09">7f6ce8f8</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fa1ca713542747d8f6fa7f9e7c1ad2faf993d7c8">fa1ca713</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0de67cf1c71b633dc78b54b1a83bd056a178dc0d">0de67cf1</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c898f18f801fb3dfd7a33b07c1714a6d860457ae">c898f18f</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source3/build/charset.py: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/91e099d61f8044668f7f37244337f6f2f835a2e8">91e099d6</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source3/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b5ad021b49815d7dabe44d5f28475e8c1e32050">8b5ad021</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source3/wscript_configure_system_ncurses: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/029ac7d63590571ef808254d47ec542f691191df">029ac7d6</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4/dsdb/samdb/ldb_modules/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/055aae90062f12d6304614515949099bfcd4d19d">055aae90</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4/heimdal_build/wscript_build: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c797e92127cd52453a41c072135dad9c2864b275">c797e921</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4/heimdal_build/wscript_configure: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c423a3a9285497c5ec4fb40142020ff0fbcece5">0c423a3a</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4/lib/tls/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ca5008a49d72ea2078d0b35dc28dfade17fbdbad">ca5008a4</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testsuite/headers/wscript_build: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba03d12094075ba1e448720f8bc1ae4782625797">ba03d120</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party/aesni-intel/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3e71f06a86c850c6ffdf910817c51a678e8f4df7">3e71f06a</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party/cmocka/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2b21e67e1574e0afed26070f48b88d426237a3c5">2b21e67e</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party/nss_wrapper/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2847a382d8ad79c80f8bf3c7cd80c978fbe6d0c2">2847a382</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party/pam_wrapper/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7e2deed7c5709d1f73ec001d5ec36fd086aa70ad">7e2deed7</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party/popt/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c441530475daf23a71b70a7fc93ec04b1941f99">4c441530</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party/resolv_wrapper/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/051e7e74fdf99673d00a7a02a62e5099fc38f198">051e7e74</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party/socket_wrapper/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f14b8cb0dc1e590ee32c862e4efb839515b55d51">f14b8cb0</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party/uid_wrapper/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0119a8791ca0ec728df8f7b7de00d813fec30857">0119a879</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c73b7795b8769ec038f2ed61ce192148d12b5646">c73b7795</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1dc80eb15cd967aef41ae9c0be02d623b1280528">1dc80eb1</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript_build: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e58ca30bc0352ace41072cf07a85c40cb370a837">e58ca30b</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript_build_embedded_heimdal: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ef4b2d4574efafaf7f74f92cd2d7f6e4a5144fd4">ef4b2d45</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript_configure_system_mitkrb5: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c5ab9ead8b982aba506436656baed0ebaac4b2ea">c5ab9ead</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">heimdal wscript changes

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/79c4ba26b0e75f632ba5a60fd2a4d5783630bd2a">79c4ba26</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/wscript: fix options use

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3b7dfc51acc2dc0ea52cbf1733107f14405828e0">3b7dfc51</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party/waf: upgrade to waf 2.0.8

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7eab91a068ec9c95f8be3ae08e6d1d2f60ea0727">7eab91a0</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: adopt to waf 2.0.8

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/69c655fe9823fae3965bdb9538778253916301a0">69c655fe</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: reduce imports

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3fc478665800e0055365f356dd077a34091b4f52">3fc47866</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: add install_dir to build context

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/944fce2596fa0a2a73f53f03ebb4128b8d4220d6">944fce25</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/wscript: import from waflib

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d00ba4003125898d0c4928ac6ad205bad79ee3c2">d00ba400</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch/libwbclient/wscript: import from waflib

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f2f5b4d5d44ba2f42251f54ba88c7e0d13372f7">9f2f5b4d</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source3/libsmb/wscript: remove unneeded import

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7aaa1e680e978c63136c0f7c6d230d9f60599a09">7aaa1e68</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba/samba_abi: always_run helper was deprecated in waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/175be9377ebfb8b2fac87de2d68d06a9f5b80a0f">175be937</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/wscript: adopt to waf-2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2e401d2475ce019a8e964ae6379dcc61c7334934">2e401d24</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript: adopt to waf-2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/850ceec8109580279e4e1493aac835d86f1f597f">850ceec8</a></strong>
<div>
<span>by Thomas Nagy</span>
<i>at 2018-09-05T04:37:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: compile asn1 files by adding missing code from compat15

Signed-off-by:    Thomas Nagy <tnagy@waf.io>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1fdcbd0696e7acb1bca42099606aeec9c5a8dedd">1fdcbd06</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: use correct context for APPNAME

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a63619c1fdfe15d196ebf077522a05990abe53d">2a63619c</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf heimdal: use absolute path to compile_et

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/35ebfd3d4ef1b32ef1ac51c6e20506b24fd3abc3">35ebfd3d</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/wscript: handle lists in environmental variables in waf

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cdda0d9048b8d4bf0f12b13453f2c85413d8d808">cdda0d90</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: change SAMBA_BUILD_ENV to use bldnode.abspath()

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0fdba4be9c425220ba459ad421f03cce4ab7ae70">0fdba4be</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: use top for waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/699977a2e7e49eb9cf15141075726134e5ddd34c">699977a2</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript: adopt to waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c3d31eb14a621f1a8999f531532e77109e5ead5">5c3d31eb</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">cdtb/wscript: use top and out for waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fb43723bc1f054bb29194b1a569037dd1db71459">fb43723b</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: use top and out for waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aebcd698764d9c8e55db14b7650481a1992ee938">aebcd698</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: crosscompile should use Utils.subprocess in waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d25ae580b4a625c8ce0ab183c04d599090ee073">1d25ae58</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: use context instead of options for cross-compile checks for waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77f3a1387fac0503007ba6e3e26b9d3576b29387">77f3a138</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: use cflags instead of ccflags for waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/31f8945aa6611160d72b24a0f82c40a2419f1362">31f8945a</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: install Python modules back to bin/python, not bin/python_modules

Partially revert 80fce353e740c793619005ac102ab07fb5e7d280 which started
installing generated Python modules into python_modules directory back
in 2013. This, unfortunately, does not work anymore as Python gets quite
confused with our setup even when both bin/python and bin/python_modules
directories are part of sys.path.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/75d5bcb4d84f697bed5e13569b10a893fe487ff3">75d5bcb4</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/wscript: properly handle env.cwd which is a list, not a string

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a3fcdf1ef16f2efc936bed61fe85e3bb9e7fba9">2a3fcdf1</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: generate build options output with waf 2.0

With WAF 2.0 we get all defines in environment at the same level.
Fix build options source code generator to handle this.

I felt uneasy at filtering out some defines so instead the code
is mangling generic defines to be correct for C compiler by
replacing '-', '.', and '()' with an underscore ('_').

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7944ed6e7be60803eb4f0073ac6ac2e79413b4ab">7944ed6e</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: port stale_files to waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1efe68908dcdae9551cb0f7f56a9ce0d08a9fe09">1efe6890</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript: port build_system_mitkrb5 to waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/72a9e6d115603ecb9de3ebaf9a56ff2fa0b41b9e">72a9e6d1</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript: port build_system_heimdal to waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fdd89fefb523ebbb78247c84289a4894c34b7213">fdd89fef</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/tests.py: update to support waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0a9d98ba1521b711e4987d6709327bcf6ec64b6c">0a9d98ba</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/wscript: rework how version number is retrieved

Using default context functions before waf initialization occured
is prone to error. Postpone calling samba_version.* code until we
got default context initialized.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f495f64e2ea831cdc5c2a1a4954df738754de72b">f495f64e</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: remove ENFORCE_GROUP_ORDERING

ENFORCE_GROUP_ORDERING is not needed with waf 2.0 anymore

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c7c10b2c53b85ca257515abc5544d22b7ab0865">4c7c10b2</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/audit_logging: update to waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6fc9f1a89d2826f690db2118703935e48e01b2d3">6fc9f1a8</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/mscat: fix logging in wscript
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/72c3ff9ae2090652e9f3e77374494103e1fd2723">72c3ff9a</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: use CACHE_SUFFIX instead of a hard-coded name

waflib.Build provides CACHE_SUFFIX constant to append to the target
name. We have a reference to samba-specific cache suffix (.cache.py)
while original WAF uses _cache.py as a cache suffix since 2011 (see
commit 44a967e326cc2e670a31b3712e4763b72d65e81b in WAF project code).

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/67ed1ea6c468ce537e61183771dbc76241acfe67">67ed1ea6</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script/autobuild: re-use CACHE_SUFFIX from waflib

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8f022a0be81333fcaa7ac20147028eef73e2179e">8f022a0b</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-05T04:37:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script/autobuild: Fix formatting in send_email

Commit cb40e2bbc8a34a1ec3584ab585c5bf44c037ef0e introduced a print
statement with a broken formatting. Reported by pylint.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8de348e9d025d336a7985a9025fe08b7096c0394">8de348e9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-09-05T07:29:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Import exact files from waf-2.0.8/waflib

wget https://waf.io/waf-2.0.8.tar.bz2
tar -xf waf-2.0.8.tar.bz2
rsync -a waf-2.0.8/waflib/ third_party/waf/waflib/

The previous import was damaged by auto-strip/correct of whitespace
and had other small corrections.

Check with git show -w.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Sep  5 09:29:39 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/630cc6e6268cfed08b9f21cd77181f82f36ea44b">630cc6e6</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-09-05T09:42:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Add tests to prove that kinit to an SPN is not allowed (unless it is also a UPN)

The krb5.kdc.canon testsuite has been updated to pass against Windows
Server 1709 in four modes:

* A normal user
* A user with a UPN
* A user with an SPN (machine account)
* A user with an SPN as the UPN

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/364c13ac3d2d1cd05d0f5f375697807c8585f844">364c13ac</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-09-05T09:42:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/samba4.blackbox.export.keytab: Remove stray exit 0 and so run cleanup

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a6182bd9512e6c78cfd2127790419418ab776be9">a6182bd9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-09-05T09:42:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "s4/heimdal: allow SPNs in AS-REQ"

This reverts commit 20dc68050df7b1b0c9d06f8251183a0a6283fcaf.

Tests (the krb5.kdc testsuite) show this behaviour is incorrect.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/71ba7cb9b1a5896e6fcdcd6d607339c40d335027">71ba7cb9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-09-05T09:42:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add new test to run krb5.kdc.canon against a user with an SPN for a UPN

The failures in this test compared with Windows Server 1709 are added to
knownfail.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3e5ad20260f8366f1b1bc954f0199b7fd812bec7">3e5ad202</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-09-05T09:42:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/samba4.blackbox.export.keytab: Update to use a principal with SPN as UPN

The ability the kinit with an SPN (not also being a UPN) has gone away as
windows doesn't offer this functionality.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9e1ba904d00cc71d5a14c8ec830052cb091302f5">9e1ba904</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-09-05T09:42:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Confirm that this element of the krb5.kdc test does not pass against Windows

This should be fixed, but in the meantime add clue to avoid regressions on
bug 11539.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f7c409c4c833615abbe0291e700b0a9fad55dd13">f7c409c4</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-09-05T09:42:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture krb5.kdc.canon: Correct principal being checked in TEST_AS_REQ_SELF stage

We have already checked the client principal.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/41473daf09efbc4aed7ab0961ef536f15fca84f6">41473daf</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-09-05T09:42:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">heimdal: Change KDC to respect HDB server name type if f.canonicalize is set

This changes behaviour flagged as being for Java 1.6.  My hope is that this does not
set f.canonicalize

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa07400f733effc4d42c6d81b6eeb9af8394b38b">aa07400f</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-09-05T14:17:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kdc: Improve code clarity with extra brackets

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Sep  5 16:17:59 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e0e86e8ae6245341ffd2b32d6abbade1371046e5">e0e86e8a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-09-05T16:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbclient: Fix errors printed if we can connect with SMB1

smbclient -L //server

before:

Reconnecting with SMB1 for workgroup listing.
Connection to earth.milkyway.site failed (Error NT_STATUS_RESOURCE_NAME_NOT_FOUND)
Failed to connect with SMB1 -- no workgroup available

after:

Reconnecting with SMB1 for workgroup listing.
Unable to connect with SMB1 -- no workgroup available

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eddcbfea91d012f70a00c3ff2865fb1a23bec023">eddcbfea</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-09-05T16:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbclient: Do not call cli_RNetShareEnum if SMB1 is disabled

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/50f89bcdc9473abf69da1fee6f9014df63adc3e3">50f89bcd</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-09-05T16:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmbclient: Do not call cli_RNetShareEnum if SMB1 is disabled

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0dae4e2f5c65167fdb2405e232436921a0bb17e6">0dae4e2f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-09-05T16:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmbclient: Add function to set protocol levels

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/931e64d2e9e42707c53d32a6cc5006ec734ae4ab">931e64d2</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-09-05T16:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Set credentials for libsmbclient correctly

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/778878a39621d88edaf2167719292bb75b86b2be">778878a3</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-09-05T19:56:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Run libsmbclient tests with NT1 and SMB3

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep  5 21:56:11 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/36c3c7d1a46df07af1f94d99fb7f22222e70506b">36c3c7d1</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable tdb.python for python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ccbecac3b22d6039e2196ba766ad4113220cbde5">ccbecac3</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: make password_hash.py py2/py3 compatible

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5bb286ab79562594eac86a2b463a1f987f98c792">5bb286ab</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.password_hash_gpgme for python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d18ef26562615f91dd1065f9213a2a57285e605">1d18ef26</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: py3 port for samba.test.password_hash_ldap

user samba.compat.text_type instead of unicode

in py2 text_type is an alias for unicode
in py3 text_type is an alias for str (which does nothing if
the input is already str)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0854cca4ff375612614b38b1fecc6cd9677f5e2f">0854cca4</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.password_hash_fl2008 for python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b7909eb29dc4be813561d84c2205ba38d5c06109">b7909eb2</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.password_hash_ldap for python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c719b0362bbdd0e587bbc9d1d45a68e98e5452b1">c719b036</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/knownfail.d: Add PY3 rule for samba.tests.encrypted_secrets

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e96fcb88c23b470c5d26cf18b4da1ef2a38c0def">e96fcb88</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: PY3 port of samba.tests.encrypted_secrets

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ffcc323b1d1e48d21dbe575e3ffeb828584ced8">5ffcc323</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.encrypted_secrets for python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8970ec195c6a3a18486bd7f4fada3adf90ff8f13">8970ec19</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/knownfail.d: Add PY3 rule for samba.tests.py_credentials

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3fd9b77ad49aa8c482c15f7b408c3599c157716b">3fd9b77a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/credentials: py2/py3 credential key needs to return bytes

new_client_authenticator returns a dictionary. The key
'credential' needs to return bytes in Python3, without this
change the the code will attempt to convert the binary data to
a string (resulting sometimes in decode errors).

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c73c9be14feb58fcac9bb2298ed5372d6b60a59d">c73c9be1</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: port samba.tests.py_credentials for py2/py3 compat

+ ord takes 'str' param
+ unicode doesn't exist in py3
+ py3 bytes class doesn't have encode method, try to ensure py2
  code runs unchanged while adapting code (by using get_string)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9dd1271a35a1ce4939a61fdae237e20ad5776d94">9dd1271a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.py_credentials for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/94c982004f8182bcbe8ade897b2128efde28168d">94c98200</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: fix traffic for py2/py3 compatability

load/save operations return randomly sorted dictionaries in python3
these changes make sure the already sorted expected results are
compared with sorted actual values.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a97996c0aa0aa40cb2280145327cb17bd08df49">2a97996c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/emulate: PY3 port of samba.tests.emulate.traffic_packet

Fixes
+ None cannot be used with '<' or '>' operators
+ ord expects 'str'
+ unicode doesn't exist in py3
+ bytes class does not have encode method

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c2e06f78ca8fb2d5564ee57f594ac2ce10832b4">5c2e06f7</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.emulate.traffic for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6401eba1850fc271cf7e624a7c6fa71c413bcf75">6401eba1</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: samba.tests.emulate.traffic_packet enable for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4ca09e43bf75b895c16a96b90b6dd9f333cb7873">4ca09e43</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: samba.tests.blackbox.traffic_replay enabled for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ad1728417434d437da3e207d838ab8253403359d">ad172841</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: Change native string to binary for py2/py3 compat

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d0553847fdb4b3ebf8e0a1f11736f5a050da5375">d0553847</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: Enable samba.tests.blackbox.traffic_learner for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/06f43e9b9d1c3cb5714558c64fe25fde227d4764">06f43e9b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.blackbox.traffic_summary for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/42dfc985424358061542cdccfadb88f8abc223e9">42dfc985</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-05T21:27:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: Enable samba.tests.blackbox.smbcontrol for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/05862b7bb0e62ba500b68cfc3403a85b00aa61dc">05862b7b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-06T00:27:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba4.schemaInfo.python for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Sep  6 02:27:51 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bc62182ff46023494f710a78d5a57a7baffa8780">bc62182f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-06T06:33:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Check result of write() in ARP and TCP tests

CTDB -O3 --picky-developer build is failing.  Not sure how this
slipped through.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Thu Sep  6 08:33:59 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c4c6ca5e0c06d616c995d6c6ff803b74caec513a">c4c6ca5e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-09-06T10:06:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Support clang as C compiler

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>

Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Thu Sep  6 12:06:05 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bc188dd7a9fed4eb57a8259c56ca4de2d9a687f1">bc188dd7</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-09-06T10:10:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: ignore rules and exclude files

Will fix other ones and come back to these later.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/23b3c5b65b57f1c0b671b0617831c94dd674809d">23b3c5b6</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-09-06T10:10:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix comment indent

The comments in this file will make different PEP8 rules fight.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d02ec9f2ad90f3d4eae041e078cc228730b3d34f">d02ec9f2</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-09-06T10:10:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E101: indentation contains mixed spaces and tabs

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0f67b6e4b90d54fb75e078972baf392fca643056">0f67b6e4</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-09-06T10:10:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E111: indentation is not a multiple of four

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/24fe85041f053dd6f835a3a99afa7169a8cc0654">24fe8504</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-09-06T10:10:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E122: continuation line missing indentation or outdented

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8678fde5821b524578dab0fa7db097b9e5148af2">8678fde5</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-09-06T10:10:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E123: closing bracket does not match indentation of opening bracket's line

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ff6c198776e904aea5e9aa60d6aa26335c0f6ab">7ff6c198</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-09-06T10:10:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E124: closing bracket does not match visual indentation

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dc02a4c35fbc92df0d8797eca4135ed22b14db29">dc02a4c3</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-09-06T10:10:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E125: continuation line with same indent as next logical line

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/deb819913d1749563ba2e0ebb53aa788fc0388ea">deb81991</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-09-06T10:10:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E127: continuation line over-indented for visual indent

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8c2c9794ec02eeb9eeecaa6dcd9e96dca3a9ac66">8c2c9794</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-09-06T13:50:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PEP8: fix E128: continuation line under-indented for visual indent

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Sep  6 15:50:17 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e5afa011fd7d5000f5b25ce31478c751e8144f6d">e5afa011</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-06T13:51:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: port samba.tests.dsdb_schema_attributes to PY3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett abartlet@samba.org
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b4db7464222378642dd61a66e80d5f168119ee3">7b4db746</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-06T13:51:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.dsdb_schema_attributes for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett abartlet@samba.org
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2b4d2810eb8017866816069d37fd2f48790e8055">2b4d2810</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-06T13:51:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs: PY3 port for samba4.drs.replica_sync_rodc

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett abartlet@samba.org
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d18c9dc61cb0c78ce2a0dc72c716fa75fd1ab119">d18c9dc6</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-06T13:51:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba4.drs.replica_sync_rodc.python for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett abartlet@samba.org
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59ff17cc75b675d22b2e46e25da125b83f274c26">59ff17cc</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-06T13:51:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/selftst: enable samba4.tombstone_reanimation for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett abartlet@samba.org
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2200b22b345213539d49d374731cf076a8ce4a70">2200b22b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-06T13:51:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests: port samba4.tombstone_reanimation for PY3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett abartlet@samba.org
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a63ab95ca4240cdb808c189c29b5b3809270041">4a63ab95</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-06T17:24:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest/tests: Enabled samba.tests.samba_tool.computer

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett abartlet@samba.org

Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Thu Sep  6 19:24:54 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e7612710d1e94d18f80649deb17e6defae9a5b23">e7612710</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-07T09:37:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/wscript: fix bison detection

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/193fdbf181ad7848cabf56db9780571aeb91aa3a">193fdbf1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-07T09:37:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/wscript: fix flex detection

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/311e1eb67306d6a639ce80b94a16ea2ef19592f0">311e1eb6</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-07T09:37:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba/samba_autoconf: when setting undefined result, use empty tuple

A difference between waf 1.x and 2.x is that we gained 0 as an undefined
variable in the cache file. This does not allow to differentiate unset
and set to 0 defines.

Force to use empty tuple () to signify unset defines.

Also, fix handling of extra cflags in case of 'strict=True': if
extra_cflags were not defined, we'd append None to the cflags list and
it confuses conf.check() later. 'None' is added to the command line of a
tool executed by the conf.check() which, depending on a tool, may be
treated as an error and cause wrong test result.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/364077d262012af0346afad6d9b9c3999054563f">364077d2</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-07T09:37:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/replace/wscript: fix detection of a fallthrough attribute for clang

clang issues a warning but otherwise allows our test to be compiled and
linked. We consider this case a successful pass for a fallthrough
attribute detection while it is an error.

Turn missing declaration warning into an error so that we actually do
not define fallthrough attribute support in case it doesn't really work.

Fixes FreeBSD 11.2 with clang.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4847daf0b762db205812347c8e31edd3a3ef5039">4847daf0</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-07T13:45:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba/samba_waf18: redefine flex function

There is a bug in waf: flex routine adjusts its inputs against
the task's current working directory but assumes it is being called from
within the build variant directory.

For Samba this means we adjust one level up than the actual work
directory we use to run (bin/ vs bin/default) and flex doesn't find the
source files.

Fix the issue by creating a local override of flex definition that
utilizes the same workd directory for both path adjustment and running
the flex itself.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Sep  7 15:45:36 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d920a725ee19215190bbccaefd5b426bedc98860">d920a725</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-07T15:26:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib/server_contexts: make server_event_ctx and server_msg_ctx static

server_event_ctx and server_msg_ctx static shouldn't be accessible from
outside this compilation unit.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dff1028e8ba4c70e726283c12531853681034014">dff1028e</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib:popt_common: Move setup_logging to common callback

The flag is set in the common callback, so be consistent

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b7464fd89bc22b71c82bbaa424bcbfcf947db651">b7464fd8</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Move popt_common_credentials to separate file

This is only used by command line utilities and has additional
dependencies. Move to a separate file to contain the dependencies to the
command line tools.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8c3b62e6231e62feafacf2a7ee4c9d41cd27a4a1">8c3b62e6</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Introduce cmdline context wrapper

Command line tools need acccess to the same messaging context provided
by server_messaging_context, as common code for db_open uses that
context. We want to have additional checking for command line tools
without having that code part of the servers. Introduce a wrapper
library to use for command line tools with the additional checks, that
then acquires the server_messaging_context.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3aca3f24d4bdacc11278388934b0b411d518d7b0">3aca3f24</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-07T15:26:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:loadparm: reinit_globals in lp_load_with_registry_shares()

This was set to false in 0e0d77519c27038b30fec92d542198e97be767d9 based
on the assumption that callers would have no need to call
lp_load_initial_only() with a later call to lp_load_something().

This is not quite correct, since for accessing registry config on a
cluster with include=registry, we need messaging up and running which
*itself* requires loadparm to be initialized to get the statedir,
lockdir asf. directories.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/10e1a6ebb3d95b8a1584a9b90c2584536aa9c96d">10e1a6eb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-07T15:26:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: pass configfile to pdbedit

This is needed otherwise pdbedit fails to initialize messaging in
autobuild.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2c63ce94ef3a55ab0aa1aae4f6fee88e29ac2efe">2c63ce94</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-07T15:26:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:popt_common: use cmdline_messaging_context() in popt_common_credentials_callback()

This adds a call to cmdline_messaging_context() to the popt
popt_common_credentials_callback() hook and ensures that any client tool
that uses POPT_COMMON_CREDENTIALS gets an implicit messaging context,
ensuring it doesn't crash in the subsequent lp_load_client() with
include=registry in a cluster.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3ecb9ed7b079fc1bf74c311cf5f1684086b36883">3ecb9ed7</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test:doc: Skip 'clustering=yes'

As testparm will error out when running clustering=yes as non-root, skip
this step to avoid a test failure.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/29fd2c2e5ad3c2d44f3629c6b7b4139772fe350c">29fd2c2e</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbpasswd: Use cmdline_messaging_context

smbpasswd does not use POPT_CREDENTIALS. Call cmdline_messaging_context
to initialize a messaging_context with proper error checking before
calling lp_load_global.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d7fa3815a83a50fd9e3d78cac0d5ef3eb79235e5">d7fa3815</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbstatus: Use cmdline_messaging_context

Use cmdline_messaging_context to initialize a messaging context instead
of open coding the same steps.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd3ae2ffdc66be4707471bfccf27ef446b5599cb">dd3ae2ff</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpcclient: Use cmdline_messaging_context

Use cmdline_messaging_context with its error checking instead of open
coding the same steps.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f2b659e4f518ccb06f221dd028f99883ca1a1847">f2b659e4</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:net: Use cmdline_messaging_context

Use cmdline_messaging_context with its error checking instead of open
coding the same steps.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f56496b11469f0e9af9ba81cefb796ca1febabb1">f56496b1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-07T15:26:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:messaging: remove unused messaging_init_client()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4661537c201acebee991d219d151cb481f56265c">4661537c</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pdbedit: Use cmdline_messaging_context

Initialize the messaging context through cmdline_messaging_context to
allow access to config in clustered Samba.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ea7a4ff7ae5ef2b22fb7ef5640d6b946c064cfc3">ea7a4ff7</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:testparm: Use cmdline_messaging_context

Call cmdline_messaging_context to initialize a messaging config before
accessing clustered Samba config.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cab8f27bbc927e48c52bac6350325e8ec38092b2">cab8f27b</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:sharesec: Use cmdline_messaging_context

Call cmdline_messasging_context to initialize messaging context before
accessing clustered Samba config.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9ed617474f588ceb42c8929ee8a51071a408c219">9ed61747</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: ntlm_auth: Use cmdline_messaging_context

Call cmdline_messaging_context to initialize the messaging context
before accessing clustered Samba config.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/095123df945270bc51635a19125a7abdfcd4ab80">095123df</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:eventlogadm: Use cmdline_messaging_context

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7eeff96b826711b5a8d44ab24603dafcc0343d84">7eeff96b</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:dbwrap_tool: Use cmdline_messaging_context

Initialize the messaging context through cmdline_messaging_context to
allow access to config in clustered Samba.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de040eafbd7d729316d757c14c44df163a4b36ad">de040eaf</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbcontrol: Use cmdline_messaging_context

Initialize the messaging context through cmdline_messaging_context to
allow access to config in clustered Samba.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/20ed13923ed3c55e1b293e5440028d29384e9d3a">20ed1392</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbget: Use cmdline_messaging_context

Initialize the messaging context through cmdline_messaging_context to
allow access to config in clustered Samba.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/94852e3544bf2cace3ddba8b9c89d986d77fdab5">94852e35</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-07T15:26:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">examples: Fix the smb2mount build

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13465

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ae7db3e543d412864fafb0d0303c2219ce344526">ae7db3e5</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: Rename server_event_context() to global_event_context()

This reflects that the event context is also used outside of the server
processes.

The command used for the rename:
find . -name '*.[hc]' -print0 | xargs -0 sed -i 's/server_event_context/global_event_context/'

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cc76aaeb6234698bca5d6520bb14a9306c9131cd">cc76aaeb</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: Rename server_messaging_context() to global_messaging_context()

This reflects that the messaging context is also used outside of the
server processes.

The command used for the rename:
find . -name '*.[hc]' -print0 | xargs -0 sed -i 's/server_messaging_context/global_messaging_context/'

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a7c19bca8cf480d35948ae061d4dfcf959ce5b59">a7c19bca</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib/server_contexts: Rename variables

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b88290cd3e1cd82bacfae75f078f551ef017bb1d">b88290cd</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-07T15:26:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Rename server_contexts to global_contexts

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c2281341cb8a3bbe9f94a4b92cd83eb557214e97">c2281341</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-07T15:26:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Factor out file_has_read_oplocks()

Why? This makes it clearer to me that we're not interested in the actual
number of read oplocks. We only want to know if there are any read
oplocks at all.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a7820141908084aaa002d3f4b8a984fcb67d2d9">6a782014</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-07T15:26:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Simplify logic in smb2_lease_break_send

If/else if chains are hard to follow to me. Simplify the code by using
early returns.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9108572039e42fbc0ec540d8a89764d81597dd5d">91085720</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-07T15:26:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Simplify logic in fsp_lease_update

One if-condition is better than two

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/45a2e3eb536f07cec1447b2de566c5840cd71074">45a2e3eb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-07T15:26:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Simplify lease_match() a bit

This has been implicitly initialized to 0 with the explicit struct
initializer above.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a76a317793d6ae8fa1ce05f4faacbd0978fd5cb">6a76a317</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-07T15:26:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Simplify share_mode_stale_pid

This loop does not need to count valid share modes. A single valid one
is sufficient for keeping the delete token around

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6be25d5683d5fbfddab4f22c4dbe6299969d1978">6be25d56</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-07T15:26:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Simplify logic in remove_stale_share_mode_entries

To me, an early "continue" is easier to follow than a "else".

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a5f9b33cb47d7cb91a201e058b18bc5d45c397ef">a5f9b33c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-07T15:26:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: fix an uninitialized variable error

clang does not recognize "smb_panic" as an "exit()" equivalent

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/95682e2fdd55b390170ec4ccd6ad679738e97c20">95682e2f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-07T15:26:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap: Remove a pointless "return;"

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b487979f89cd4dffabfb68b60955ff65de94b02f">b487979f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-07T15:26:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Fix CTDB -O3 --picky-developer build on CentOS 7

gcc 4.8.5 complains:

[319/381] Compiling ctdb/tests/src/system_socket_test.c
../tests/src/system_socket_test.c: In function ‘test_tcp’:
../tests/src/system_socket_test.c:196:20: error: ‘rst_out’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  assert((rst != 0) == (rst_out != 0));
                    ^
cc1: all warnings being treated as errors

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70169d4789fe8b2ee4efe5e88eeaa80e1a641b32">70169d47</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-09-07T18:24:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Fix 'make -j<jobs>'

Currently only 'make -j' enables parallel builds and e.g. 'make -j4'
results in no parallel compile jobs at all.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13606

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Sep  7 20:24:46 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a2aa7d6d65351a887b438d57ff509aaa05a28251">a2aa7d6d</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-09-07T23:43:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-spoolss: Make spoolss client os_major,os_minor and os_build configurable.

Similar to spoolss server options, make the client advertised OS version
values configurable to allow overriding the defaults provided to the print server.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13597

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1da770848753c172d0c790911b97dbe9c3ccee06">1da77084</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2018-09-07T23:43:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-rpc_client: Advertise Windows 7 client info

Client printing operations currently fail against Windows
Server 2016 with Access Denied if a client os build number
lower than 6000 is advertised. Increase the default build number,
major, and minor versions to values associated with client
OS versoins Windows 7 and Windows Server 2008 R2.

The build number value specifically needs to be increased to
allow these operations to succeed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13597

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b8279f6525b806d8f91aa8ce016bd528fff917f4">b8279f65</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-09-07T23:43:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-rpcclient: Use spoolss_init_spoolss_UserLevel1 in winspool cmds

Use spoolss initialization function to set client version information for
iremotewinspool printer operations

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4fc0602d975277287ef5257929dff49d21b05adc">4fc0602d</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2018-09-07T23:43:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">iremotewinspool-tests: Allow modification of OS client version information

Add test_get_client_info() function to set and, or modify the client OS
version values advertised in the iremotewinspool torture tests.

The OS build numbers are used from the table in:

  [MS-RPRN] <168> Section 2.2.3.10.1

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2b9707413f541231ac8e14f4bfba24f66253c082">2b970741</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2018-09-07T23:43:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">iremotewinspool-tests: Add client os build number validation test

Add test validating the AsyncOpenPrinter result based on the provided
client info build number

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b1bf9c5d850457dce1d5a38bdb800f0280c54d68">b1bf9c5d</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2018-09-08T02:35:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">spoolss-iremotewinspool-tests: Use more recent client OS version

Set torture test client info build, major, and minor
version numbers to Windows 7 and Windows Server 2008 R2 values

 buildnum: 7007
 major: 6
 minor: 1

Build number taken from
 [MS-RPRN] <168> Section 2.2.3.10.1

Major/Minor numbers taken from
 https://docs.microsoft.com/en-us/windows/desktop/sysinfo/operating-system-version

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Sep  8 04:35:56 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/95ba6b97441b75f28aef5ec1ee5a9442683f3763">95ba6b97</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-08T06:44:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba/samba_autoconf: when setting undefined result, use empty tuple

A difference between waf 1.x and 2.x is that we gained 0 as an undefined
variable in the cache file. This does not allow to differentiate unset
and set to 0 defines.

Force to use empty tuple () to signify unset defines.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8ec7eb0c0129518557d1f446191860a62ef3ff79">8ec7eb0c</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-08T06:44:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/replace: force to unset defines if check has failed

For HAVE_WORKING_STRPTIME and HAVE_INCOHERENT_MMAP we always want to
have their defines unset as the code is using '#ifdef' rather than just
'#if'. Setting them to 0 means #ifdef will succeed due to a difference
how '#ifdef' and '#if' are working.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8c00c017cb5dc930b229a6fff8e541322a63494e">8c00c017</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-09-08T09:37:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: Ensure raw notify tests use different directories.

Should help track down flapping tests.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Sep  8 11:37:44 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e5d6f81e34d3a6f33eba7becd36f2cc6ee4645f">4e5d6f81</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-09-10T14:51:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftext: Mark py3 visualize test as flapping

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Sep 10 16:51:09 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/200ddf8e731af3d30d844ad0f8e5e73d46aba52c">200ddf8e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-10T17:28:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "lib/replace: force to unset defines if check has failed"

This reverts commit 8ec7eb0c0129518557d1f446191860a62ef3ff79.

There was already a better fix under discusion.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/93b23570358e143a90a8aaaa007bb0d482a531ec">93b23570</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-10T17:28:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "wafsamba/samba_autoconf: when setting undefined result, use empty tuple"

This reverts commit 95ba6b97441b75f28aef5ec1ee5a9442683f3763.

There was already a better fix under discusion.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/230796d7ee7384aa7310d5601b2136679857b277">230796d7</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-09-10T17:28:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: undefine a define for a failed test unless asked to keep it

If conf.CHECK_CODE() is called without `always=True` and the test has
failed, undefine the define already set to '0' by conf.check_code().

This restores expectations that undefined symbols are not considered to
be set by CONFIG_SET() method.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0cd9452ea6b6e402124bee970df5484c4a264368">0cd9452e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-10T17:28:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: fix generic_cc.py to work with waf 2

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/420d0b5606b998df006f30966dffa5877175f608">420d0b56</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-10T17:28:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: remove irixcc.py as we don't support IRIX any more

There's still a irixcc.py in waf itself.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b35ac32b2e378baf06353aeb101cc7c75a82338d">b35ac32b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-10T17:28:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: remove hpuxcc.py as it's not compatible with waf 2

third_party/waf/waflib/Tools/compiler_c.py proposed
gcc for HPUX.

If there's more needed on HPUX someone with a HPUX box needs to
provide a waf 2 compatible fix.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ad0427576903b002193afd3eef0cbb40d768129c">ad042757</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-09-10T20:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: remove tru64cc.py as it's not compatible with waf 2

third_party/waf/waflib/Tools/compiler_c.py proposed
gcc for osf1V/Tru64.

If there's more needed on Tru64 someone with a Tru64 box needs to
provide a waf 2 compatible fix.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Sep 10 22:49:31 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a122428a585281ebaf0135f11bd9377af9f6ab97">a122428a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-11T04:59:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-build: Use wafsamba's INSTALL_DIR()

install_dir() doesn't work (doesn't respect $DESTDIR) and is only
available for backward compatibilty.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/26ea0f58daace4adef7c5bb17f19476083bf3b7b">26ea0f58</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-11T04:59:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Make INSTALL_DIR() respect $DESTDIR

INSTALL_DIR() currently ignores $DESTDIR and just installs directories
into the final destination.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b4fa3f982a38bce10d471c5b309f4f0f631c300c">b4fa3f98</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-11T04:59:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Have INSTALL_DIR() log directory creation

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/587bbd3eb17d41c4c78a068d16c7f4182f196f47">587bbd3e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-11T08:00:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Drop unused, broken install_dir()

This is broken because it doesn't respect $DESTDIR.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Alexander Bokovoy <ab@samba.org>

Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Tue Sep 11 10:00:05 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/94c6a7d744764813226c437876af6d24f082b865">94c6a7d7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-11T16:36:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove an unneeded #include

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd89034f6d2a33b3b106046011b90db3c1ae1423">dd89034f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-11T16:36:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Simplify close_directory()

Same patch as in 8541829a9ab20c7fa8c

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ef3610f7b5d10d437601a18660109af032bb630">5ef3610f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-11T16:36:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove an unneeded #include

ndr_open_files already includes open_files.h

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f741f4d1950c0c08069aba58dcf4fa1dd7517162">f741f4d1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-11T16:36:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Factor out "has_other_nonposix_opens"

This is exactly the same in both file and directory cases

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e84da7ec51e1be4414569c052310a42fa308495b">e84da7ec</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-11T16:36:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use has_other_nonposix_opens in smb_posix_unlink

Almost the same code as in close.c. has_other_nonposix_opens() is a bit
more general, but the purpose is the same.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e24f3ff4e4a595c05181457f58042afee255dc0b">e24f3ff4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-09-11T16:36:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: Fix "flakey" notify test on slow cloud filesystems.

Ensure we keep asking for change notifies until we get them all
(or the request times out).

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/885435e8a4dc561749b880f8be7a32041fa954ec">885435e8</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-09-11T19:43:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmbclient: Fix a typo

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Sep 11 21:43:28 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/204e054b3ba9c452fb99a97bb5788ca10e2ce5a8">204e054b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-09-11T20:45:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Initialization cleanup.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de7541059360b597c3d2ea383b0eb2fc2f7018d5">de754105</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-09-11T20:45:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Restructure check_parent_exists() to ensure all non-optimization returns go to one place.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba9d293ccf524b12c4f03cdb6a6acab3e46bc696">ba9d293c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-09-11T20:45:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Ensure dirpath is set to ".", not "\0" so it is always a valid path.

Cleanup of the internals of unix_convert().

Ensure check_parent_exists() returns this in the non-optimization
case. Ensure unix_convert() initializes dirpath to ".".

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0993141c55ad788c5f9de3b96a6ddeca6bfbc453">0993141c</a></strong>
<div>
<span>by Michael Adam</span>
<i>at 2018-09-12T00:05:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd:vfs: fix mis-spellings of hierarchy in comments

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep 12 02:05:47 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3903f6c365014af804066f916a27fa6d886846e3">3903f6c3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-12T03:50:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-build: Fix version handling when building tarball

Split get_version() into 2 functions, so that .distversion file can be
created.

Pair-programmed-with: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed Sep 12 05:50:46 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cc30805e5c57a4440dc318a6a25c8c80cde0cef7">cc30805e</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-09-12T16:03:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba_dnsupdate: honor 'dns zone scavenging' option, only update if needed

Since scavenging is implemented the samba_dnsupdate command always updates all
dns records required by the dc. This is not needed if dns zone scavenging
is not enabled.

This avoids the repeating TSIG error messages:

 # samba_dnsupdate --option='dns zone scavenging = yes' 2>&1 | uniq -c
     29 ; TSIG error with server: tsig verify failure
      1 Failed update of 29 entries
 # echo ${PIPESTATUS[0]}
 29

 # samba_dnsupdate --option='dns zone scavenging = no' 2>&1 | uniq -c
 # echo ${PIPESTATUS[0]}
 0

Note that this results in about 60 lines in the log file,
which triggered every 10 minutes ("dnsupdate:name interval=600" is the default).

This restores the behavior before 8ef42d4dab4dfaf5ad225b33f7748914f14dcd8c,
if "dns zone scavenging" is not switched on (which is still the default).

Avoiding the message from happening at all is subject for more debugging,
most likely they are caused by bugs in 'nsupdate -g' (from the bind package).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13605

Pair-programmed-with: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Björn Baumbach <bb@sernet.de>
Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Björn Baumbach <bb@sernet.de>
Autobuild-Date(master): Wed Sep 12 18:03:10 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e52abc8a44de6791dceb6f43af1db472a3d9ec37">e52abc8a</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2018-09-12T19:50:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-doc: Remove PIDFILE option from ctdbd_wrapper man page

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13610

Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Ralph Böhme <slow@samba.org>

Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Wed Sep 12 21:50:57 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b1838b15750da7b5d2627f7f8093e19000ddbb3c">b1838b15</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-12T20:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap: move sockname variable and call to lp_ctdbd_socket into context

sockname is only needed in a cluster.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6617b2db35ec6f5f5acb979bf672414a1f9e5657">6617b2db</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-12T20:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap: early return, removes an indentation level

No change in behaviour.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a9620bb4252a76385284092a1497920e86b34eb">9a9620bb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-12T20:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_tdb: move a function call out of an if condition

At least for me this improves readability somewhat. No change in
behaviour.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/382620d42dd12fc9bb946b15044ae09a569abca7">382620d4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-12T20:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_tdb: use struct initializer

This ensures all struct members are implicitly initialized.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7cafbc50d9cc4c1b3b985cc1398d184e0a1a75b7">7cafbc50</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-12T20:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_ctdb: add error checking to ctdbd_dbpath()

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/daea9655ef9fc5a0b7b9389f9c4a4b4114261933">daea9655</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-12T20:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_ctdb: simplify if condition

This just moves the talloc_memdup() out of the if condition as per
README.Coding.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dcc50d670702ccbd14f9e58857499911fa215e0b">dcc50d67</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-12T20:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_ctdb: README.Coding fixes in traverse_callback()

NULL initialize pointers, check function return values, explicit
variable check against NULL.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fce54bf071a7cf86dfdec7b858a0c5254542e6d4">fce54bf0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-12T20:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_ctdb: use struct initializer in db_ctdb_traverse_read()

This ensures all struct members are implicitly initialized.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eaaee00a068257b6d130518a2a228fab07df259e">eaaee00a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-12T20:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_ctdb: use struct initializer in db_ctdb_traverse()

This ensures all struct members are implicitly initialized.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7c0607e96d9bb77522d7d8f4f452dc14880a5b0d">7c0607e9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-12T20:25:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_ctdb: increment record count in traverse_callback()

state->count wasn't incremented and is returned at the end of a
dbwrap_traverse().

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f84e372a5ba154c524c63a2da07410c036fd0222">f84e372a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-09-12T23:34:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_ctdb: return correct record count for a persistent db read-only traverse

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Sep 13 01:34:30 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/93d72bcfb0dea3d7734771bbb550c45d642955c9">93d72bcf</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-13T07:37:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Only use $DESTDIR in INSTALL_DIR() if it is set

Otherwise the leading '/' is stripped and directories are created
relative to the current directory.

This fixes a regression introduced in recent commit
26ea0f58daace4adef7c5bb17f19476083bf3b7b.

Reported-by: Ralph Böhme <slow@samba.org>
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Alexander Bokovoy <ab@samba.org>

Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Thu Sep 13 09:37:23 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5e4f34e707709ba84be30cd271b10033989b0cbb">5e4f34e7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-14T05:49:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Add some structure protection for durable reconnect

We should consume all data, and the ndr_pull function fills in all
fields. Thus the ZERO_STRUCT(cookie) is not required.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b6b7c157583dae815e57781cbc4f66bd8d71e201">b6b7c157</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-14T05:49:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_tdb: Avoid double-call to talloc_get_type_abort

We've already retrieved "ctx" in the callers of db_tdb_fetch_locked_internal().

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/551f85464bbd6275a1d645a06089f4c7db55b866">551f8546</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-14T05:49:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Add a paranoia check for leases

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e4498de16341fc049c50e3df13690dddc9efcdd6">e4498de1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-14T05:49:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Avoid casts in DEBUG statements

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/41f2d1d1bdf51699cab774e103fcf00a32bc7071">41f2d1d1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-14T05:49:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Avoid casts in DEBUG statements

Some indentation changed, best viewed with "git show -w"

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa30fd54a22db8535b661563cab1adb15826239d">aa30fd54</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-14T05:49:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove "file_sync_all" function

Replace with a call to files_forall. Why? I just came across this
function that only has one pretty obscure user. This does not justify
a full library function, IMHO at least.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/92b01adf0933d6940126ad94d2334d214efde39c">92b01adf</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-14T05:49:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: Fix a docu typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/89e500d8ad75d29ab7242947f7b869488ba76192">89e500d8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-14T05:49:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix a false comment

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9e515f7c66d950be0ad3839c50fff1329aebc002">9e515f7c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-14T05:49:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Simplify share_mode_lock.c

"the_lock_id" is not required here. The share mode data carry the file
id, so use that.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/50adbbe0c841360f6d29f66dcdffdaa872c7780d">50adbbe0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-14T05:49:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Simplify parse_share_modes

Since 823bc4c07ad pidl initializes the [skip] entries

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/36055dbb660a1a1086e06b3849e4deb93f2a99ef">36055dbb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-14T05:49:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">streams_xattr: Make error handling more obvious

Do the NULL check right after the alloc call

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aca0f2a18bf39e703a5cf8383ff2089fa0e97221">aca0f2a1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-14T05:49:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">streams_xattr: Make error handling more obvious

Do the NULL check right after the alloc call

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/92d3e3a81094f69d1de9a09c8d75bf6a797facb3">92d3e3a8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-14T05:49:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">mdssvc: Simplify sl_unpack_loop

Move a variable declaration closer to its use, avoid a redundant
?true:false;

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/71c70607982981338252e529c39c13b94b9eb497">71c70607</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-14T05:49:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">mdssvc: Move a variable declaration closer to its use

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/98cf04c7d140a015fdd4d9cc5d90eb445bd9c58c">98cf04c7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-14T05:49:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">mdssvc: Move a variable declaration closer to its use

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8df3f3499fd7421260fbe532bd6947d3c0ea8bd">f8df3f34</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-09-14T08:48:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">mdssvc: Move a variable declaration closer to its use

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Sep 14 10:48:47 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/18ab3ea7bcc0ae8c66ece8094446017c7ceb736b">18ab3ea7</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-15T13:18:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Remove unnecesssary #include <fcntl.h>

This is now provided through system/filesys.h.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/181e3966fbbeb571e9b15cb34d29ff3d95d8e7c6">181e3966</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/provision: PY3 port to run samba.tests.upgradeprovisionneeddc

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5517d5262001899aa8e5edf09123475ad519e05b">5517d526</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.upgradeprovisionneeddc for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/12949bb0ad503ba31cfaafc967aadcd75136cdaa">12949bb0</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.samba_tool.rodc for PY3
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5e21334d60c23178cbf13b5222c19cd38283e181">5e21334d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb: py_dsdb_DsReplicaAttribute should deal with bytes in py3

Seems the underlying c code expects binary blob, so.. we should
handle str for py2 and byte for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b30bcf7b71538a7e933453681e13eb407896efc">6b30bcf7</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">fallout from py_dsdb_DsReplicaAttribute to -> bytes

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cea2fd6ce732b44651ce7ab84a6363acaf564e84">cea2fd6c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/param: py2/p3 compat override_prefixmap should be string/bytes
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dcbdae15b2dbf71458d81aa39575cbd7aa579732">dcbdae15</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: ndr_unpack has to take bytes not string

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fc13a1268a4a9de94efd312a8309aa55d331ae19">fc13a126</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: PY3 port for ridalloc_exop test to work

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf2c60294baf23ca8061196f8ef02e253e7a6858">bf2c6029</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba4.drs.ridalloc_exop for python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/939957fc9d808dde60956cc9b1451f908bfcd6cb">939957fc</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: PY3 fix test samba.tests.samba_tool.passwordsettings
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7afa2d93260bdf74fec108ceca4e6add357454c0">7afa2d93</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.samba_tool.passwordsetting for Py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8db43696e70d7c4cb21172b7e7461cf6a72914a2">8db43696</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: extra ndr_unpack needs bytes function
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6941544a1c5ac0e8311ca9c655a445bbcf8abebe">6941544a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest/tests.py enable samba.tests.getdcname for py3
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ed1fd60781f7b1db42cb28d144b89058141c895f">ed1fd607</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.net_join_no_spnego for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2f5db304df80f839afe7dbe9df7105009844801f">2f5db304</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.net_join for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3530dad658cd28aaeb860eb18c43a1116faec8cd">3530dad6</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/knownfail.d: add PY3 entry for samba4.ldap.password_settings

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4deb61d63f6311df9b68d54a5a11e0d544fc2fc3">4deb61d6</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba4.ldap.password_settings for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1e23962adb1ca776d67a6e13b2bf22a48928d435">1e23962a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs: port samba4.drs.samba_tool_drs for py2/py3 compat

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/12ff5df1521452900294c1bca4bf3198682ebbcb">12ff5df1</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba4.drs.samba_tool_drs for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0728cce0832c69c1e6ff2e1449ce8f9eabd4230d">0728cce0</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs: PY3 port for test samba_tool_drs_showrepl

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/111fd4598f00e4f8bb2ac34a9c9f773a0d9fb788">111fd459</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs/python: make test code run in py2/py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c0b187982f2c02eda0860c677c98a38293dee988">c0b18798</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs: PY3 fix error with test_samba_tool_showrepl_json

some versions of json.loads appear to need to be passed string.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e20bf3df7bd220fe083664e59ef87e7e8265b52">0e20bf3d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/knownfail.d: PY3 rule for replica_sync
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/13dc820cb94ff12eb91de3335d06e8df3334e83c">13dc820c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba4.drs.samba_tool_drs_showrepl py2/py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/89f5f53f568c931a6fdf4df5c5c9f05e09172266">89f5f53f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: samba4.drs.replica_sync.python enable for python3.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/03deaae2fcfecb70a9a859f700783805816cc603">03deaae2</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.samba_tool.forest for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9295541148f3606a3e814eb761abd51f820a677">a9295541</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.samba_tool.schema for py2/py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/72497e1f9dc9a4bb15e392325ada14359f3f86df">72497e1f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs: port samba4.drs.delete_object test for py2/py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6db0d67f2b948b865e37868c3c5bdb78035812e3">6db0d67f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable test samba4.drs.delete_object for py2/py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/496fc547ae8a1cd293893416acc725128891c931">496fc547</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs: py2/py3 compat changes for test samba4.drs.fsmo

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a299ff58864d97ea7450cbf2019c5a1637142b9d">a299ff58</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba4.drs.fsmo for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4de325760f330ed7add4789900f9f67c6ee7d5fd">4de32576</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs: py2/py3 compat for test samba4.drs.repl_move

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/40638fe74fa3dec5de5129ee114cebbbbb05d1fb">40638fe7</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba4.drs.repl_move for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e6987e54d4a948503f5b5fdfa58d02d079ef21c">4e6987e5</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs/python: ndr_unpack needs bytes samba4.drs.getnc_exop

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/30be125b8e6096dbb62857fc6f81857308952ae9">30be125b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba4.drs.getnc_exop for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/050ba20f450341f7e476c273d16a5fa465225988">050ba20f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba4.drs.getnc_unpriv for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/71900d92bb167399367a1d49e6d357f6026587e5">71900d92</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs: py2/py3 compat porting for samba4.drs.link_conflicts

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a5a2e069e6c98e2b8aeb6ce6048377fc4830c54">9a5a2e06</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba4.drs.link_conflicts for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/50c5c47aae6f2fba0c412b6752c3c17f0e34a6be">50c5c47a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba4.drs.repl_schema for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/186b7addb470a9268fd7d43ac6e459fc2171bd76">186b7add</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs/python: py2/py3 porting needed for samba4.drs.getncchanges

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7943e5326ac7390b1ffcd04056d8ff8b21e75293">7943e532</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/knownfail.d: PY3 entry fro getncchanges

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bcefbbb3abf37a0a466b476af1762a22fb4674f8">bcefbbb3</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba4.drs.getncchanges for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0ed0c07dd58568b7a1a757fb4eb20613002136a8">0ed0c07d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/drs/python: py2/py3 compat changes for samba4.drs.repl_rodc

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3451c5e7fb0becd1b01462fe7480027816a1a75e">3451c5e7</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba4.drs.repl_rodc for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0fd8c69ec1ca470d273064f432c573d20a0dd6ba">0fd8c69e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: py_gensec_update takes bytes as param

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2eac2f13bc9e2d515b98e2380bece6dd78da7749">2eac2f13</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.join for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f18674db3c60a08f99200f5e119e4bdd903628fb">f18674db</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftetst: enable samba4.drs.cracknames for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b2665d569e35957aa2433e010175ed1fe361ee7b">b2665d56</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.kcc for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5884ef29552c547c684fb554955b820386c2cb00">5884ef29</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.kcc.kcc_utils for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d5413d5b6173207cbf0fb3326e8ab4567e902467">d5413d5b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.netlogonsvc for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7208d4a4362b050c36ab66d335cf1c7d31e7f6b6">7208d4a4</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T13:18:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/knownfail: Add PY3 entries for samba.tests.ntlmdisabled

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4038e7bd8b2a8a66ae38b8c75ebf439351fc0e14">4038e7bd</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-15T16:10:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.ntlmdisabled for py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Sep 15 18:10:42 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3cc284b2af15dbf7fee87ce56403ec53ef754b61">3cc284b2</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: fix some octal literals

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/693834f7313471b62371a9517c05438b0c8f3e5c">693834f7</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: fix iteritems usage, not supported in python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c6884138e4c1aec80e8f99ef0978b43919ae9d3a">c6884138</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: dict has no iterkeys method

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d20e85d008e1b7badbea5ada8b22639f7767a097">d20e85d0</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: iterkeys -> keys

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b2b0f8191dde58fe234b0147c4a0bd39020aa504">b2b0f819</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: iterkeys -> keys

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/82c84513331da9d0f42ba73d03e58dce5d0f76d3">82c84513</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: dict doesn't have has_key

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0358d57db4705b2330e294b5d6318c1a78a8518c">0358d57d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: dict_keys doesn't have a sort method

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59f69a7c21fa90354699b8752d1473e8af6bf0d3">59f69a7c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py2/py3 enclose map with list

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bb9e945e4a6f69c204ac48621e9b7c5567dd62ec">bb9e945e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: fix string.rsplit usage (doens't exist in PY3)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9fc6759792e631d73d1ccd7b22de8314bad42624">9fc67597</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: enclose filter with list as len on result of filter fails

filter returns an iterator in PY3 (and a list in PY2)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b342e6f038b5277cf30115f11cf0f30d238c12ea">b342e6f0</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: bytes.maketrans, string.maketrans is a PY2 only function

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a0c8c8c8331856d9f09d18b389b7dd01c8d33de2">a0c8c8c8</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: string.translate string.upper don't exist in PY3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eceb99708f1f49b54cb2e8a3e829fe5fd8e5c05a">eceb9970</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: decode output of cmd_output for easier string manip

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/899ef5d186c2c44f63c1cbf415daa33e9f668a5b">899ef5d1</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: string.upper not in PY3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e2c0af6bcdf271ff75c455695c129bc18322bd5a">e2c0af6b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: xrange->range

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0df8ef41a336a232d2e348462174434d7d7ec610">0df8ef41</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: use pyembed_libname for library names (otherwise missing deps)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6c62e22c1c751a6a2472a996316656ec5d03aa51">6c62e22c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: detect talloc_utils (for version of python running the build)

It seems all combinations have potential to fail here :/ however for
the moment making the assumption
  *  if python2 driving the build you are building against libpython2 (with the option of having python3 as 'extra-python'
  *  if python3 driving the build you are building against libpython3 (with the option of having python3 as 'extra-python' NOTE: this isn't inforced it probably should be !!!! In a system with python2 and python3 installed it seems waf needs PYTHON env variable to decide which libpython to build against. It's also an option that configure should use that too (to figure out which talloc_util to use or build)

However.... right now I just want the thing to build

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dc9117e41835048c1f445f9fd5b9b8aa6d712016">dc9117e4</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: ensure output of subprocess.Popen is decoded

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a0851c5fdcd8463b571a00929a9bf492f35a92c0">a0851c5f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T04:16:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: wrap filter calls with list where list is expected

filter in PY2 returns list in PY3 it returns an iterator

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0cb341321fcdd2d6d7281d591ebcaa540da48134">0cb34132</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-16T07:21:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/librpc: Fix py2 dependecies leaking into py3 libraries

Caused strange crashes when using python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun Sep 16 09:21:59 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5a6b139884f08ee2ee10f9d16fe56ad8fb5352a6">5a6b1398</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-17T20:58:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-cluster-mutex: Reset SIGTERM handler in cluster mutex child

If SIGTERM is received and the tevent signal handler setup in the
recovery daemon is still enabled then the signal is handled and a
corresponding event is queued.  The child never runs an event loop so
the signal is effectively ignored.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e789d0da57fc3fc6d22bfa00577a2e65034ca27a">e789d0da</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-17T20:58:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-cluster-mutex: Block signals around fork

If SIGTERM is received and the tevent signal handler setup in the
recovery daemon is still enabled then the signal is handled and a
corresponding event is queued.  The child never runs an event loop so
the signal is effectively ignored.

Resetting the SIGTERM handler isn't enough.  A signal can arrive
before that.

Block SIGTERM before forking and then immediately unblock it in the
parent.

In the child, unblock SIGTERM after the signal handler is reset.  An
explicit unblock is needed because according to sigprocmask(2) "the
signal mask is preserved across execve(2)".

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59fc01646c7d65ba90b0a1a34c3795ff842351c5">59fc0164</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-17T20:58:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Clean up taking of recovery lock

No functional changes, just coding style cleanups and debug message
tweaks.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c516e58ce92c420dc993bd9b7f1433641bd764bd">c516e58c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-17T20:58:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Re-check master on failure to take recovery lock

If the master changed while trying to take the lock then fail gracefully.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/af22f03dbe9040f5f743eb85bb50d411269bbab4">af22f03d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-17T20:58:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Rename hold_reclock_state to ctdb_recovery_lock_handle

This will be a longer lived structure.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a53b264aee7d620ee8ecf9114b0014c5bb678484">a53b264a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-17T20:58:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Use talloc() to allocate recovery lock handle

At the moment this is still local and is freed after the mutex is
successfully taken.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c52216740bd81b68876de06e104822bbbca86df9">c5221674</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-17T20:58:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Store recovery lock handle

... not just cluster mutex handle.

This makes the recovery lock handle long-lived and with allow the
releasing code to cancel an in-progress attempt to take the recovery
lock.

The cluster mutex handle is now allocated off the recovery lock
handle.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a755d060c13b65dfb6d73979aaf111c489882bfb">a755d060</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-17T20:58:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Return early when the recovery lock is not held

This makes upcoming changes simpler.

Update to modern debug macro while touching relevant line.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b1dc5687844e90b0e3c39cb46a1116c86118fbf4">b1dc5687</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-17T20:58:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Handle cancellation when releasing recovery lock

If the recovery lock is in the process of being taken then free the
cluster mutex handle but leave the recovery lock handle in place.
This allows ctdb_recovery_lock() to fail.

Note that this isn't yet live because rec->recovery_lock_handle is
still only set at the completion of the attempt to take the lock.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/486022ef8f43251258f255ffa15f1a01bc6aa2b7">486022ef</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-18T00:18:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Set recovery lock handle at start of attempt

This allows the attempt to be cancelled if an election is lost and an
unlock is done before the attempt is completed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13617

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Tue Sep 18 02:18:30 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d0d1eafae9a9232b4a9314d854d56b98098e7f8e">d0d1eafa</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-18T08:33:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci: Correct the ctdb tasks

They're swapped.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Tue Sep 18 10:33:57 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8453c61789b4950e3eda4ff50dd12b233359d09b">8453c617</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-18T22:54:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Check for GPFS file system on connect

The vfs_gpfs modules uses GPFS API calls that only succeed when using
the module with the GPFS file system. Add an explicit statfs check for
the file system type on connect, to make it obvious when the file system
is missing or not mounted. The check can be skipped by setting
gpfs:check_fstype to 'no'.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b4ec1c26e9f1a29eefff497409847894bfc2369">8b4ec1c2</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-09-19T01:56:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Add gpfs:check_fstype to vfs_gpfs manpage

Signed-off-by; Christof Schmit <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Wed Sep 19 03:56:47 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e5298c8bc1221f4f02ac1c1d7fd6de7a2b95af97">e5298c8b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-19T15:49:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">uid_wrapper: Fix Tab/indent error with python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Wed Sep 19 17:49:33 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/48ad1db3c5b513863a8f7868d2a92ebb8df2a27e">48ad1db3</a></strong>
<div>
<span>by Richard Sharpe</span>
<i>at 2018-09-19T15:52:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: Don't copy back the stat struct from stat_cache_lookup if we did not get a hit on the full path.

Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c3211c8e592468916550283026044867359157cb">c3211c8e</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2018-09-19T20:23:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/locking: Fix comments to reflect code flow

* posix_pending_close_db is an in-memory database and not a tdb.
  Therefore adjusting comments to convey the correct meaning of the
  database.
* we do not have posix_locking_close_file() any more which got renamed
  to locking_close_file(). Thus fixing comment to mention the new name.

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep 19 22:23:28 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2e59a3343fe162639b103f35ac87b3193927fab5">2e59a334</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-19T20:25:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: make sure print stmt is enclosed by '(' & ')'

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d1cd28adaba691ba434a47031fb52ff8887c728">1d1cd28a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-09-19T20:25:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: nmbd: Stop nmbd network announce storm.

Correct fix for. On announce, work->lastannounce_time is set
to current time t, so we must check that 't >= work->lastannounce_time',
not 't > work->lastannounce_time' otherwise we end up not
doing the comparison, and always doing the announce.

Reported by Reuben Farrelly

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13620

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Revviewe-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cf7e7710e15016ce5528d7eed8b58d4d3f4934d3">cf7e7710</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-09-19T23:29:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix pdb_samba_dsdb build on Ubuntu 16.04 with -O3 -Werror=strict-overflow

../source3/passdb/pdb_samba_dsdb.c: In function ‘pdb_samba_dsdb_set_trusteddom_pw’:
../source3/passdb/pdb_samba_dsdb.c:2778:6: error: assuming signed overflow does not occur when simplifying conditional to constant [-Werror=strict-overflow]
   if (i == 0) {
      ^
cc1: all warnings being treated as errors

gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10)

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Sep 20 01:29:48 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b6efa1507c38d316e8cf05025b47a555ca0d0d0a">b6efa150</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-09-21T01:06:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">heimdal-build: Avoid using python str.format()

In python 2.6, the format fields need to be numbered explicitly.  This
causes the build to fail on RHEL6/Centos6 with following error:

 File "/home/amitay/samba.git/source4/heimdal_build/wscript_build", line 87, in HEIMDAL_ASN1
    os.path.join(bld.path.abspath(), option_file)))
ValueError: zero length field name in format

To use str.format() in HEIMDAL_ASN1(),

   "--option-file='{}'"  needs to be   "--options-file='{0}'"

Or this fix which avoids str.format() completely.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>

Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Sep 21 03:06:44 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3b94d31d2478455cd4f370be76da2733216e7041">3b94d31d</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-09-21T18:04:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Fix dependency of ldb module

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13626
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/198bcfbac3985e38a705b101d79713831172a64c">198bcfba</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-09-21T18:04:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python tests: fix format() strings for Python 2.6

Python 2.6 wants "{0}".format(x), not "{}".format(x).

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/93bbe2d219d66f395023945cb0c67814178c14a3">93bbe2d2</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-09-21T18:04:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Minor code cleanups to confidential_attr test

+ fix a couple of flake8 warnings
+ add some extra code comments (particularly around the cases where the
  child class overrides a particular method, to avoid confusion when
  browsing the code).
+ assert_not_in_result() was duplicated (it's only needed for the deny
  ACL tests)
+ skip redundant if in dirsync's assert_search_result() (it always has
  to use the base-DN - we never pass it this as an args).

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6c1ff5909948d7fd3c06e8809980eb505feaa403">6c1ff590</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-09-21T18:04:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">acl_read: Rework Samba code to reflect Windows logic

This patch should not alter functionality. It is just updating the Samba
code to better match the Windows specification docs.

When fixing Samba BUG #13434, the Microsoft behaviour wasn't clearly
documented, so we made a best guess based on observed behaviour.
The problem was an exception was made to allow "objectClass=*" searches
to return objects, even if you didn't have Read Property rights for the
object's objectClass attribute. However, the logic behind what
attributes were and weren't covered by this exception wasn't clear.

I made a guess that it was attributes belonging to the Public Info
property-set that also have the systemOnly flag set.

Microsoft have confirmed the object visibility behaviour. It turns out
that an optimization is made for the 4 attributes that are always
present for every object (i.e. objectClass, distinguishedName,
name, objectGUID). They're updating their Docs to reflect this.

Now that we know the Windows logic, we can update the Samba code.
This simplifies the code somewhat.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d8667514af9db5283eb9cfe07e9881ff4cf46f3">5d866751</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-09-21T18:04:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: test ldap search requesting non-existent attribute

As an after-thought to commit 563e454e8c55e94a950, we thought it
might be a good idea to add a test case that requests an non-existent
attribute in the attribute-filter as well the search-filter.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/188541076a1a19acb8a3dd572a5bd4f69350cf41">18854107</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-09-21T20:58:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Tweak PSO test-suite name

There are 2 different PSO tests:
- make test TESTS=ldap.password_settings
- make test TESTS=samba_tool.passwordsettings

There's also another test that's completely unrelated to PSOs:
- make test TESTS=blackbox.password_settings

This patch renames ldap.password_settings --> ldap.passwordsettings.
This means 'make test TESTS=passwordsettings' will run both PSO tests,
but not the unrelated blackbox test.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Sep 21 22:58:17 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d50aafe932b79bc406501757e780ae1c7d9dddfc">d50aafe9</a></strong>
<div>
<span>by Philipp Gesang</span>
<i>at 2018-09-22T04:05:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/audit_logging: make json_{is_invalid,to_string}() accept a const*

Allow for json_is_invalid() and json_to_string() to be used on a
const pointer. Neither function requires for the json object to
be mutable so constraining them to non-const* is unnecessary.

Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Signed-off-by: Philipp Gesang <philipp.gesang@intra2net.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2e00ad44aa6822817f7e988cdfa7c87fc3aa5257">2e00ad44</a></strong>
<div>
<span>by Philipp Gesang</span>
<i>at 2018-09-22T04:05:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: net: implement json output for ads info

Add the switch '--json' to 'net' to format the output as JSON.

The rationale is to supply the information in a machine-readable
fashion to complement the text version of the output which is
neither particularly well defined nor locale-safe.

The output differs from that of plain 'info' in that times are
not formatted as timestamps.

Currently affects only the 'net ads info' subcommand.

Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Signed-off-by: Philipp Gesang <philipp.gesang@intra2net.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5534b9248fa375799ad4bc6f45a69dcf14e6419e">5534b924</a></strong>
<div>
<span>by Philipp Gesang</span>
<i>at 2018-09-22T04:05:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: net: implement json output for ads lookup

Add JSON printer (option '--json') for the 'net ads lookup'
command. This outputs the same information as the plain version,
with integral ({LMNT,LM20} Token, NT Version) and boolean values
(Flags) not stringified.

Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Signed-off-by: Philipp Gesang <philipp.gesang@intra2net.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a19b4e31b52d5d58ff3266b758ec8294d6c497c">2a19b4e3</a></strong>
<div>
<span>by Philipp Gesang</span>
<i>at 2018-09-22T04:05:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: net: normalize output of lookup subcommand

Use spaces and tabs consistently following the majority of the
printed output: tabs only for indenting, no space before the
colon separator, a single space after the separator.

The irregularities in formatting date back to the original commit
2c029a8b96..

Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Signed-off-by: Philipp Gesang <philipp.gesang@intra2net.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6dc9f70bbb733519bcd57a69cc87133224a9d2fe">6dc9f70b</a></strong>
<div>
<span>by Philipp Gesang</span>
<i>at 2018-09-22T07:20:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/blackbox: add test for net ads JSON output

Implement blackbox tests for

    $ net ads info --json
    $ net ads lookup --json

that validate

    a) JSON wellformedness (by feeding it into the JSON library
       that ships with Python), and
    b) equality of the set of keys printed to that of the
       non-JSON version.

Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Signed-off-by: Philipp Gesang <philipp.gesang@intra2net.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Sep 22 09:20:09 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/08a5fbd86702c28b51eeac6c2b1bd1f3713fe10d">08a5fbd8</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-09-24T05:03:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: Fix the build when compiling without JSON support

[3762/3895] Compiling source3/utils/net_ads_gpo.c
../source3/utils/net_ads.c: In function ‘net_ads_cldap_netlogon_json’:
../source3/utils/net_ads.c:311:2: error: parameter name omitted
  (ADS_STRUCT *, const char *,
  ^
../source3/utils/net_ads.c:311:2: error: parameter name omitted
../source3/utils/net_ads.c:312:16: error: parameter name omitted
   const struct NETLOGON_SAM_LOGON_RESPONSE_EX *)
                ^
../source3/utils/net_ads.c: In function ‘net_ads_info_json’:
../source3/utils/net_ads.c:520:1: error: parameter name omitted
 static int net_ads_info_json(ADS_STRUCT *)
 ^

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Mon Sep 24 07:03:09 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2055b710abe768bfb170987f38f05af1a35df866">2055b710</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-09-26T05:49:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Tweak backup-offline output to avoid subunit truncation

Currently a backup-offline test is occasionally flapping in autobuild,
however, the output is truncated so we can't see what the actual problem
is. The output only ever contains the list of backup dirs. I suspect
that the ']' character printed at the end of the python list might be
getting interpretted by subunit as the end of *all* the output.

If so, we should be able to avoid the problem by printing the list items
without the '['/']'s, i.e. join the list into a single string.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e1f255a4d54b59924295ea875fdef62ccebb8811">e1f255a4</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-09-26T05:49:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Add --site option when restoring a domain

Restoring a backup only worked if the Default-First-Site-Name site was
still present. When the new restored DC account is created, it was
trying to add the new server's DN under CN=Default-First-Site-Name.
However, if the original domain was setup using a different site, then
the restore would fail because the DN didn't exist.

When running the restore command, you should be able to specify the
site that you want the new/restored DC to be in (same as during a
DC 'join'). Passing the correct --site argument is one way to avoid
this problem. (A subsequent patch will further improve the tool so it
can work around non-default sites automatically).

Note we also need to pass the site through to where the new DNS entries
get registered (in the rename case).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ad69aaf7e13435111fc990954ff0bc81ed5325c5">ad69aaf7</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-09-26T05:49:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add test-case for restore into non-default site

Add a test-case that exercises the new '--site' restore option and
ensures the restored DC gets added to the correct site.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ce57a800c9bed7e6876cdc0baf3a2d5fdc879ecf">ce57a800</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-09-26T05:49:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Re-create default site for backup-restore (if missing)

Normally when a new DC joins a domain, samba-tool works out the new
DC's site automatically. However, it does this by querying the existing
DC using CLDAP. In the restore case, there is no DC running. We could
still query the DB on disk and work out the correct site based on the
new DC's IP, however:
- comparing between the CN=Subnet DNs and an IP-address string seems
  like it'd be non-trivial to write, and
- in the lab-domain rename case, chances are the user will want a
  completely different subnet to what's already in the DB.

The restore command now has a --site option so the user can specify an
appropriate site for the restored DC. This patch makes the restore
command work by default (i.e. without a --site option) even if the
default Default-First-Site-Name doesn't exist. Basically the solution is
to just check Default-First-Site-Name exists and create it if it
doesn't. As the recommended workflow is to use the restored DC as a
temporary seed that you'll later throw away, this approach seems
acceptable. Subsequent DCs will then be joined to the running restored
DC, so an appropriate site will be determined using CLDAP. The only
side-effect is potentially an extra Site object.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/696fa6a1e6c615a992a3016ff32405b864b62eec">696fa6a1</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-09-26T05:49:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Change backup testenvs to use non-default site

Previously (i.e. up until the last patch) the backup/restore commands
only worked if the Default-First-Site-Name site was present. If this
site didn't exist, then the various restore testenvs would fail to
start. This is now fixed, but this patch changes the backupfrom testenv
so that it uses a non-default site. This will detect the problem if it
is ever re-introduced.

To do this we need to change provision_ad_dc() so the
extra_provision_options can be specified as an argument. (Note that Perl
treats undef the same as an empty array).

By default, the restore will add the new DC into the
Default-First-Site-Name site. This means the backupfromdc and restored
testenvs will now have different sites, so we need to update the ldapcmp
filters to exclude site-specific attributes.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/89543af0e8ec392a9f50599ee819496eef53f02f">89543af0</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-09-26T05:49:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Test join against DC with non-default site

Recent changes around restoring a domain that lacked
Default-First-Site-Name highlighted a problem. Normally when you join a
DC to a domain, samba-tool works out the correct site to use
automatically. However, if the join uses '--server' to select a DC, then
this doesn't work. It defaults back to Default-First-Site-Name, and the
join command fails if this site doesn't exist.

All the testenvs had Default-First-Site-Name present, so this was never
tested. Now the backupfromdc no longer has a Default-First-Site-Name
site, so running a simple join against that DC fails, highlighting the
problem.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9e81d43ac34049c602e18c03b8332bcee48ba8ce">9e81d43a</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-09-26T05:49:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">join: Avoid duplicating "Default-First-Site-Name" string

The provision code already defines "Default-First-Site-Name" so we might
as well reuse it.

The join.py already uses a suitable default, so assigning the default in
the domain netcmd code is unnecessary.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/26dd30d6d3e677ce465de174ebbfad38bbb15140">26dd30d6</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-09-26T05:49:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">join: Support site detection when --server is specified

When a new DC is joined to the domain, samba-tool would automatically
detect an appropriate site for the new DC. However, it only did this if
the --server option wasn't specified. The new DC's site got
automatically updated as part of the finddc() work, however, this step
gets skipped if we already know the server DC to join to.

In other words, if Default-First-Site-Name doesn't exist and you specify
--server in the join, then you have to also specify --site manually,
otherwise the command fails. This is precisely what's happening in the
join_ldapcmp.sh test, now that the backupfromdc testenv no longer has the
Default-First-Site-Name present.

This patch adds a new find_dc_site() function which uses the same
net.finddc() API (except based on the server-address rather than
domain-name). Assigning DEFAULTSITE has been moved so that it only
gets done if finddc() can't determine the site.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e592c91677db506761e872ef428ce02fca340da">4e592c91</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-09-26T05:49:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">domain_backup test: fix py2.6 incompatible format

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/36cb85be726e03c482b82f0af7eed2c81f8df35a">36cb85be</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-09-26T08:40:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool domain backup: fix py2.6 incompatible format

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Sep 26 10:40:49 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cb8e61b5234a614c1203db6e5ac55afb7513985d">cb8e61b5</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-09-26T18:10:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Only build vfs manpages if the module is enabled

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Wed Sep 26 20:10:07 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c98f9971922342cbcfd2f55ca076835ba2305c63">c98f9971</a></strong>
<div>
<span>by Philipp Gesang</span>
<i>at 2018-09-26T18:41:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">turn --with-json-audit into global --with-json

Fold the build option --with-json-audit into the toplevel wscript
to reflect the fact that JSON support is no longer local to the
audit subsystem.

Signed-off-by: Philipp Gesang <philipp.gesang@intra2net.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5a73f904e192c44e304850287ac439d0b52f7be5">5a73f904</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-09-26T21:40:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py3 kcc tests: mark verify test as flapping

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Sep 26 23:40:58 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d786e1fca95395e793867278bc0408e33c19908b">d786e1fc</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-26T23:54:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/ldb: Test correct variable for no mem condition

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d1492ab919b19d1ca72f1d7c97ac0ca3bee13a2a">d1492ab9</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-26T23:54:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/ldb/tests: add test for ldb.Dn passed utf8 unicode

object dn format should be a utf8 encoded string
Note: Currently this fails in python2 as the c python binding for
      the dn string param uses PyArg_ParseTupleAndKeywords() with 's'
      format, this will accept str *or* unicode in the default encoding.
      The default encoding in python2 is... ascii.

Also adding here a knownfail to squash the error produced by the test.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cddd54e8654c94dedd57c08af1987ce03212ce20">cddd54e8</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-26T23:54:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/ldb: Ensure ldb.Dn can accept utf8 encoded unicode

Additionally remove the associated known fail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13616
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e8fec94827c933041acd5b447eeeefd0b7b507ef">e8fec948</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-26T23:54:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: fix "TabError: inconsistent use of tabs and spaces"

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2d94839f9f5b34f951d9b15532cecbdf3334a7b1">2d94839f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-26T23:54:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: decode bytes in py3 where strings are needed

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d28b4fa3611a8b2aaac4c37ec79907a724d6f0f7">d28b4fa3</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-26T23:54:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: md5 related functions need to be passed bytes

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f71675dcbee6cef5b1c6972d1281feb37e8e70b0">f71675dc</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-26T23:54:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: PY3 add compat function urllib_join to replace urllib.urljoin

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2ea47f3e0f8c39a1c1bd651c7bd60b152f9b611c">2ea47f3e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-26T23:54:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/web_server: PY3: port to python3

Note: Unlike other libraries this library is been only built for the
configured python version. It depends on availability of 'swat' python
module.

The swat module is hosted externally, it seems not to have been modified
for a number of years, I don't think swat is python3 compatabile. These
changes are enough to get allow the samba binary to launch a web server
(which will just display a placeholder page announcing you need to install
swat). It maybe that removing this functionality is what we should do, but
that is a decision that can be made at a later time.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a6052b5218f4179173008c7122d1f5c9da9b000">9a6052b5</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-26T23:54:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: fix basestring not defined error in PY3

Test for str first (which exists in py3 & py2) this avoids
the undefined runtime error.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8514b5b1c69792a7bb3108506cc2510911eece70">8514b5b1</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-26T23:54:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: add_manual_dependency needs bytes for value

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1c16c0cfafb11cb3468401431ab84329102a632d">1c16c0cf</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-09-26T23:54:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: domain backup offline bug fix - ignore sock files

Ignoring autogenerated .sock files and directories during file system based
offline domain backup.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13604
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8c754b4396d958cb153c792615769efb00ed4bbd">8c754b43</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-09-27T02:47:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dlz_bind9: torture tests exploring rndc reload behaviour

These tests establish that the process triggered by the command 'rndc reload'
does not cause samba's bind9 dlz plugin to crash.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13214

Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Sep 27 04:47:16 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6400c8c695cc7db8cc680b87932c68fced086a50">6400c8c6</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-27T23:01:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: Finally fix reference to basestring PY3 error.

While a previous attempt squashed the error on the config & make
phase, make install threw up this error again.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/47634a25a03b44a5212f9552fb72115f1c1436d0">47634a25</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-27T23:01:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: We support python3 now, remove error when python3 detected

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de1e6d7856130112cf7b877cb610c917d70afe0f">de1e6d78</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-27T23:01:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script: add new autobuild task for building pure python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f08ba3a4a3f0df8653d025372972f237fa0ade13">f08ba3a4</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-27T23:01:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">add new gitlab CI job for building pure python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c0a9c697f2ebce25de693573c0124addd5755fd">9c0a9c69</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-09-28T01:57:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/web_server: fix panic from wrong type extracted from conn

enabling
  server services = +web

and we get a panic

web_server.c:251: Type mismatch: name[struct web_server_data] expected[struct task_server]
smb_panic_default: PANIC (pid 29137): ../source4/web_server/web_server.c:251: Type mismatch: name[struct web_server_data] expected[struct task_server]

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Sep 28 03:57:47 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0122f45f053ecc545950c31bf1fb33fba143478c">0122f45f</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-09-28T06:30:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Make sure SMB connection is signed when backing up sysvol

i.e. protect the client against man-in-the-middle attacks by default.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/378706266496ce79c1887fe96ab3b15f56770244">37870626</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-09-28T06:30:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: Server responds incorrectly if no SMB protocol chosen

The SMBnegprot response from the server contains the DialectIndex of the
selected protocol from the client's request message. Currently, if no
protocol is selected, the server is responding with a DialectIndex=zero,
which is a valid index (PROTOCOL_CORE by default). The Windows spec, and
historically the code, should return DialectIndex=0xffff if no protocol
is chosen. The following commit changed it recently (presumably
inadvertently), so that it now returns DialectIndex=zero.

06940155f315529c5b5 s3:smbd: Fix size types in reply_negprot()

This results in somewhat confusing error messages on the client side:
ERROR(runtime): uncaught exception - (3221225997, 'The transport
connection has been reset.')

or, when signing is configured as mandatory:
smbXcli_negprot: SMB signing is mandatory and the selected protocol
level (1) doesn't support it.
ERROR(runtime): uncaught exception - (3221225506, '{Access Denied} A
process has requested access to an object but has not been granted those
access rights.')

This patch restores the old behaviour of returning 0xffff.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621

Pair-Programmed-With: Ralph Boehme <slow@samba.org>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/34cbd89fec836f5de0cb5ba3f289b1f4ae00c5d7">34cbd89f</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-09-28T09:25:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: Add debug message if fail to negoatiate SMB protocol

Currently if the client and server can't negotiate an SMB protocol, you
just get the followiing error on the client-side, which doesn't tell you
much.
ERROR(runtime): uncaught exception - (3221225667, 'The network responded
incorrectly.')

This patch adds a debug message to help highlight what's actually going
wrong.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Sep 28 11:25:29 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/660dbfaeff493359474ebdb36098ac49b3f7ba0c">660dbfae</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-09-29T03:32:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Prevent valgrind errors in smbtorture3 POSIX test.

Missing fsp talloc free and linked list delete in error
paths in close_directory(). Now matches close_normal_file()
and close_fake_file().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13633

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Sep 29 05:32:41 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/46e171e2e07e61d1184b185989bca5e5e29313d4">46e171e2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-02T08:40:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Remove smb_share_modes.[ch]

This was declared nonfunctional in 2014. Finally remove it.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/380066d2e5065e987f9249d8edb68f545b3b6b76">380066d2</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2018-10-02T08:40:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/locking: Fix logging of lock reference count

lock reference count is always increased and reduced by a value of 1.
But lock_ref_count variable holds the old value prior to change and
was being logged wrongly under debug level 10. DEBUG statement must
log lock_ref_count+1 and lock_ref_count-1 respectively when value
gets increased and decreased.

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/01b868455c9bae309d1ca7ddad54077fc5d7f4b1">01b86845</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-02T08:40:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: split smb2.session.expire{1,2} to run with signing and encryptpion

This reproduces the problem we have with expired encrypted sessions.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13624

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4ef45e5334d5874f5d0fdc69286b745ebcdc612d">4ef45e53</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-02T12:11:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb2_server: set req->do_encryption = true earlier

The STATUS_SESSION_EXPIRED error was returned unencrypted,
if the request was encrypted.

If clients use SMB3 encryption and the kerberos authenticated session
expires, clients disconnect the connection instead of doing a reauthentication.

>From https://blogs.msdn.microsoft.com/openspecification/2012/10/05/encryption-in-smb-3-0-a-protocol-perspective/

  The sender encrypts the message if any of the following conditions is
  satisfied:

    - If the sender is sending a response to an encrypted request.
    - If Session.EncryptData is TRUE and the request or response being
      sent is not NEGOTIATE.
    - If Session.EncryptData is FALSE, the request or response being sent
      is not NEGOTIATE or SESSION_SETUP or TREE_CONNECT, and
      <TreeConnect|Share>.EncryptData is TRUE.

[MS-SMB2] 3.3.4.1.4 Encrypting the Message

 If Connection.Dialect belongs to the SMB 3.x dialect family and
 Connection.ClientCapabilities includes the SMB2_GLOBAL_CAP_ENCRYPTION
 bit, the server MUST encrypt the message before sending, if any of the
 following conditions are satisfied:

 - If the message being sent is any response to a client request for which
   Request.IsEncrypted is TRUE.

 - If Session.EncryptData is TRUE and the response being sent is not
   SMB2_NEGOTIATE or SMB2 SESSION_SETUP.

 - If Session.EncryptData is FALSE, the response being sent is not
   SMB2_NEGOTIATE or SMB2 SESSION_SETUP or SMB2 TREE_CONNECT, and
   Share.EncryptData for the share associated with the TreeId in the SMB2
   header of the response is TRUE.

 The server MUST encrypt the message as specified in section 3.1.4.3,
 before sending it to the client.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13624

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Oct  2 14:11:30 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/20302506324f11b55d21f14cba9e6476c6152da6">20302506</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-02T12:12:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests: turn GraphError into failure inside of test_verify()

That test was already marked as flapping in commit
5a73f904e192c44e304850287ac439d0b52f7be5.

However the test generates an UNEXPECTED(error)
instead of an UNEXPECTED(failure).

  [67(594)/75 at 36m28s] samba.tests.kcc.python3(vampire_dc)
  repsFrom source DSA guid (62f01940-a784-4e60-947a-a661c787c8cc) not found
  repsFrom source DSA guid (62f01940-a784-4e60-947a-a661c787c8cc) not found
  repsFrom source DSA guid (62f01940-a784-4e60-947a-a661c787c8cc) not found
  repsFrom source DSA guid (62f01940-a784-4e60-947a-a661c787c8cc) not found
  repsFrom source DSA guid (62f01940-a784-4e60-947a-a661c787c8cc) not found
  UNEXPECTED(error): samba.tests.kcc.python3.samba.tests.kcc.KCCTests.test_verify(vampire_dc)
  REASON: Exception: Exception: Traceback (most recent call last):
    File "bin/python/samba/tests/kcc/__init__.py", line 80, in test_verify
      attempt_live_connections=False)
    File "bin/python/samba/kcc/__init__.py", line 2659, in run
      ('connected',))
    File "bin/python/samba/kcc/__init__.py", line 2513, in plot_all_connections
      vertex_colors=vertex_colours)
    File "bin/python/samba/kcc/graph_utils.py", line 334, in verify_and_dot
      for p, e, doc in errors)))
  samba.kcc.graph_utils.GraphError: The 'dsa_final CN=NTDS Settings,CN=LOCALVAMPIREDC,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com' graph lacks the following properties:
  connected: the graph is not connected, as the following vertices are unreachable:

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1fd2a79a92fc30d7667eb97d0846043a9d29b5cf">1fd2a79a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-10-02T12:12:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Update pam_wrapper to version 1.0.7

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7dd388a1f9fa30beb2f814bd16463d1643638587">7dd388a1</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-10-02T12:12:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Add pam_set_items.so from pam_wrapper

Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ad5debcbe5215e9a45f92ea45f20cc93781e93fa">ad5debcb</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-10-02T12:12:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Add try_authtok option to pam_winbind

Same as the use_authtok option, except that if the new password is not
valid, PAM will prompt for a password.

Bug-Debian: https://bugs.debian.org/858923
Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/570944

Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6240022488464deee8ac5924059a593e377bc538">62400224</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2018-10-02T15:30:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Check pam_winbind pw change with different options

Pair-Programmed-With: Andreas Schneider <asn@samba.org>

Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Oct  2 17:30:29 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e7c5464631cee3a7eda0d03a941b5179981019c">0e7c5464</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-02T16:13:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Move downgrade_share_lease() to smbd/oplock.c

This function is pretty closely entangled with its only caller. In
particular the NT_STATUS_OPLOCK_BREAK_IN_PROGRESS triggers acitivity
in the caller, and that's the only case where "*_l" is being set to
non-NULL. Prepare for cleanup

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4980e60dfc5b9e6b96ea8c8de4d2e911c9c2f011">4980e60d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-02T16:13:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use find_share_mode_lease() in downgrade_share_lease

Simple simplification: In locking/ we did not have the direct
reference to find_share_mode_lock.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/664808af09bf42206af2ce15c9e9b5d773ab56ca">664808af</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-02T16:13:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Slightly simplify downgrade_lease()

As much as I dislike }else{ and prefer early returns, I even more
dislike asking for the same condition in two different ways.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/56139b8ec621d47d542042e7aa512aa07fd53fd0">56139b8e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-02T16:13:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Simplify downgrade_lease

To me, the "additive" SMB2_LEASE_WRITE|SMB2_LEASE_HANDLE is easier to
read than the negated ~SMB2_LEASE_READ.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a93aa1511fe71a7d43facb79cca7e89aed289075">a93aa151</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-02T16:13:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Move downgrade_share_lease into downgrade_lease

The next step will simplify the logic of the code.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cff1b31c2a82d7e07b7d413bed8a2843f1cd6508">cff1b31c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-02T20:22:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Simplify downgrade_share_lease

Coalesce the NT_STATUS_OPLOCK_BREAK_IN_PROGRESS case into just one
if-condition

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Oct  2 22:22:37 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1853fd4f9750d5b1997471baf1ef74fa88931da3">1853fd4f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-10-02T23:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Update cmocka to version 1.1.3

* Added function to filter tests (cmocka_set_test_filter)
* Fixed fixture error reporting
* Some improvement for API documentation -> https://api.cmocka.org/
* Fixed subunit output on failures
* Do not abort if a test is skipped

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/965d7e905f9bca0779de09d2788ac0cb5dfc6e2b">965d7e90</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-02T23:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">includes: Remove an unused #define

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8fab07c89e3b61bcf225a1438e8134420b8b9be">f8fab07c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-02T23:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">includes: Fix a typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4060e2637b8bac99aba01bb2d337d493a6cc06d0">4060e263</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-02T23:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">includes: Remove an unused #define

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/826a212771e521eadc0229ed8631a7f9a7f96215">826a2127</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-02T23:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove unused tdb_pack_append()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e22d5e5b7fd6af75a7b46c0b9fed7e65025930a2">e22d5e5b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-02T23:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix a warning

gcc complains that the "const" is ignored on function return
types. Right now I'm compiling this file a lot, so silence this
warning :-)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/43a0e635ea6b7b1d246664248641a4b96955a4d4">43a0e635</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-03T02:11:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">leases: Streamline leases_db_key a bit

We don't need to talloc the blob, it's always the same size

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Oct  3 04:11:59 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/54207bb3b2e18cf36c2a5585f9847326930b33ed">54207bb3</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2018-10-05T11:08:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/auth/tests: Fix kerberos test string size

>>> len("user0@samba.example.com")
23

But the string definition does not take a final '\0' into account.
As per Volker's suggestion, use compiler's support to allocate
the string properly.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6784ff24b8a31b9d597d24cab6e34feea2b83e29">6784ff24</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-05T14:16:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdbd_conn: Generalise inaccurate error message

Seeing:

  ctdb_read_packet failed: Cannot allocate memory
  [...,  0] ../source3/lib/ctdbd_conn.c:121(cluster_fatal)
  cluster fatal event: ctdbd died

The error is due to a memory allocation failure rather than ctdbd
dying.  However, the error message makes people wonder why ctdbd died.

Another alternative would be to wrap cluster_fatal() and have the
wrapper interpret the return value from ctdb_read_packet() to choose
from a set of more precise messages to pass to cluster_fatal().  For a
memory allocation it isn't strictly necessary to call cluster_fatal(),
but all is probably lost and it is still probably better to try to
exit cleanly as soon as possible instead of crashing somewhere.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Oct  5 16:16:29 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/71896fddf10a92237d332779ccbb26c059caa649">71896fdd</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-08T00:46:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Add invalid_records flag to ctdb_db_context

If a node becomes INACTIVE, then all the records in volatile databases
are invalidated.  This avoids the need to include records from such
nodes during subsequent recovery after the node comes out INACTIVE state.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/040401ca3abfa266261130f6c5ae4e9718f19cd7">040401ca</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-08T00:46:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Don't pull any records if records are invalidated

This avoids unnecessary work during recovery to pull records from nodes
that were INACTIVE just before the recovery.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c4ec99b1d3f1c5bff83bf66e3fd64d45a8be7441">c4ec99b1</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-08T00:46:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Invalidate records if a node becomes INACTIVE

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dcc9935995a5a7b40df64653a605d1af89075bd1">dcc99359</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T00:46:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add recovery record resurrection test for volatile databases

Ensure that deleted records and vacuumed records are not resurrected
from recently inactive nodes.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/202b9027ba44eee33c2fde2332126be10f719423">202b9027</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-08T00:46:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-vacuum: Simplify the deletion of vacuumed records

The 3-phase deletion of vacuumed records was introduced to overcome
the problem of record(s) resurrection during recovery.  This problem
is now handled by avoiding the records from recently INACTIVE nodes in
the recovery process.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ef052397173522ac2dd0d0bd9660a18a13a3e4fc">ef052397</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-08T00:46:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-vacuum: Fix the incorrect counting of remote errors

If a node fails to delete a record in TRY_DELETE_RECORDS control during
vacuuming, then it's possible that other nodes also may fail to delete a
record.  So instead of deleting the record from RB tree on first failure,
keep track of the remote failures.

Update delete_list.remote_error and delete_list.left statistics only
once per record during the delete_record_traverse.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e15cdc652d76b37c58cd114215f00500991bc6b4">e15cdc65</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-08T00:46:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-vacuum: Remove unnecessary check for zero records in delete list

Since no records are deleted from RB tree during step 1, there is no
need for the check.  Run step 2 unconditionally.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d18385ea2aa93770996214d056a384a0244e7d73">d18385ea</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-08T00:46:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop implementation of RECEIVE_RECORDS control

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/81dae71fa74bfd83a5701e4841b5a0a13cbe87a1">81dae71f</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-08T00:46:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Mark RECEIVE_RECORDS control obsolete

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2f89bd96fb6c5e50cfc09604ceb6b96a94cb4f56">2f89bd96</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-08T00:46:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Drop marshalling code for RECEIVE_RECORDS control

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/83b3c5670d85c607c1cf1ab8cfc2c967d4d16721">83b3c567</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-08T00:46:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop code for RECEIVE_RECORDS control

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13641

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a66a96934a5ea778e72554a143aa23fd0b1ac746">a66a9693</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T00:46:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop ps_ctdbd()

This was used for debugging tests by ensuring that the arguments to
ctdbd were as expected.  It no longer outputs anything useful because
ctdbd is now started without arguments.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f57e5bbde7c6436d32e648bf25a66caf67155f6f">f57e5bbd</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T00:46:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Rename ctdb_start_all() -> ctdb_init()

There are too many functions to start/stop daemons.  Simplify this.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4642a347d0b7bf90241c82b12454edc3d4afd257">4642a347</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T00:46:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Rename _ctdb_start_all() -> ctdb_start_all()

There are too many functions to start/stop daemons.  Simplify this.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f1ede41adff57624120f8f8a09358bd516bcebea">f1ede41a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T00:46:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Don't used daemons_start()/daemons_stop() directly in tests

There are too many functions to start/stop daemons.  Simplify this.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/90f6b0a1ede1480d3aac911817f12825b87cb947">90f6b0a1</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T00:46:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop functions daemons_start(), daemons_stop()

There are too many functions to start/stop daemons.  Simplify this.

Inline the functionality into ctdb_start_all() and ctdb_stop_all().

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2cd6a00399d4303f19aa2eafe8560185a4248b35">2cd6a003</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T00:46:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Explicitly check for local daemons when shutting down

This is clearer if the logic is explicit...  and...

There are too many functions to start/stop daemons.  Simplify this.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f2e4a5e9fae071b4ea5fad3015c84ba05fe6edcf">f2e4a5e9</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T00:46:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop unused function maybe_stop_ctdb()

There are too many functions to start/stop daemons.  Simplify this.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8bde6fa09c93b601cf463c0e25691e8396445cca">8bde6fa0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T00:46:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Don't remove non-existent test database directory

This directory is no longer used.  Lack of removal doesn't seem to
cause a problem.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9ac33015b64b7cf4f8d9e69576f8237a9b62684">a9ac3301</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T00:46:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Do not use ctdbd_wrapper in local daemon tests

Run the daemon directly and shut it down using ctdb shutdown.

The wrapper waits for ctdbd to reach >=FIRST_RECOVERY runstate within
a timeout period and shuts ctdbd down if that doesn't happen.  This is
only really used to ensure that ctdbd doesn't exit early after an
apparently successful start.  There are no known cases where ctdbd
will continue running but fail to reach >=FIRST_RECOVERY runstate.

When ctdbd is started in tests, the test code will wait until ctdbd is
in a healthy state on all nodes before proceeding, so there is
effectively no change in behaviour.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0eabac52955a191ef931ee739eff3ae7eafbf7b9">0eabac52</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T00:46:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Be more efficient about starting/stopping local daemons

Don't loop, just use onnode all.

For shutting down, use onnode -p all.  This results in a significant
time saving for stopping many deamons because "ctdb shutdown" is now
synchronous.

onnode -p all can be used to start daemons directly because they
daemonize.  However, this does not work under valgrind because the
valgrind process does not exit, so onnode will wait forever for it.
In this case, use onnode without the -p option.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/03dddc37b5f0f7e9a56fbe5299816b31053c2480">03dddc37</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T00:46:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Don't format IPv4 octets as hex digits

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/36eb7388775f7e931d102d71b867c4985830df17">36eb7388</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T00:46:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Be more careful when building node addresses

The goal is to allow more local daemons by expanding the address range
rather than generating invalid addresses.

For IPv6, use all 4 trailing hex digits.

For IPv4, use the last 2 octets.  Although 127.0.0.0 is a /8 network,
avoid unexpected issues due to 0 and 255 in the last octet.  Use a
maximum of 100 addresses per "subnet" starting at .1.  Keep the first
group of addresses in 127.0.0.0/24 to continue to allow a reasonable
number of nodes to be tested with socket-wrapper.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0dfb3c87b50745012c6c8bab5e0af262ce3f5f87">0dfb3c87</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T00:46:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Be more careful when building public IP addresses

The goal is to allow more local daemons by expanding the address range
rather than generating invalid addresses.

For IPv6, use a separate address space instead of an offset for the
2nd address.

For IPv4, use the last 2 octets with addresses starting at
192.168.100.1 and 192.168.200.1.  Avoid addresses with 0 and 255 in
the last octet by using a maximum of 100 addresses per "subnet"
starting at .1.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6ac5124b0117b7b5f3c5402934c93633ce186896">6ac5124b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T00:46:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Support closing of stdin in local daemons ssh stub

Not sure this is needed but this makes it behave the same as ssh.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2aa006a31117769dd440661cf54394590c4b8f11">2aa006a3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T00:46:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Have onnode pass -n option even when regular ssh not in use

ONNODE_SSH is really a test hook, so it doesn't need to support
completely random values.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d67d8ed44ac9beba7fdec0ceda56136f781fe19b">d67d8ed4</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T00:46:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Shut down transaction_loop clients more cleanly

A transaction_loop client can exit with a transaction active when its
time limit expires.  This causes a recovery and causes problems with
the test cleanup, which detects unwanted recoveries and fails.

Set a flag when the time limit expires and exit cleanly before the
next transaction is started.

Pair-programmed-with: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/52dcecbc923ec16e85f01f822b1450ab7b91900d">52dcecbc</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T00:46:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add extra debug to large database recovery test

This test sometimes fails, probably because the test is flakey.
Either the records aren't being added correctly or the counting of
records loses records.  Try to debug both possibilities.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/80f3f7c1889d225dcc1e7841e28e9a3f7918c99c">80f3f7c1</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-08T03:36:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Improve counting of database records

Record counts are sometimes incomplete for large databases when
relevant tests are run on a real cluster.

This probably has something to do with ssh, pipes and buffering, so
move the filtering and counting to the remote end.  This means that
only the count comes across the pipe, instead of all the record data.

Instead of explicitly excluding the key for persistent database
sequence numbers, just exclude any key starting with '_'.  Such keys
are not used in tests.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon Oct  8 05:36:11 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f5c6bd5c843ce519170a16f885bfb0d742af6b97">f5c6bd5c</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: abstract methods are defined in the parent class

These methods don't need redefined in the child
class.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5dddb784f8214e2b6753b7544cf4cb9eb3829a90">5dddb784</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Initialize SamDB in the gp_sec_ext

The SamDB is only used by the gp_sec_ext, and
isn't needed elsewhere, so initialize it where
we need it and avoid passing it around
everywhere.
It makes the most sense to put this in the setter
class that uses it, so pass our creds down so we
have access to it, then initialize it there.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa9b07ba0f8c906e99bef3ce584c7c16d3620f5f">aa9b07ba</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: gp_sec_ext should check whether to apply

Whether an extension should apply should be
determined by the extension, not by the
calling script.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f702ad943eb94d9d7964e8dec91a4708a43c81a3">f702ad94</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpupdate: Remove the unnecessary url parameter

The samdb object isn't initialized here anymore,
but in the gp_sec_ext, so this parameter to
gpupdate does nothing.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4354071b7a862e5e459b1be8bec9ec185e6a784f">4354071b</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Initialize gp_ext variables in constructor

Initialize variables for the gp_ext in the
constructor instead of passing them via the parse
function.
This is a dependency of the "gpo: Implement
process_group_policy() gp_ext func" patch, since
the parse() function is now called by the ext,
instead of by gpupdate within apply_gp(). The
parse() function should only take the path
variable, to simplify writing Client Side
Extensions.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fb22582aef50491e48ab3d8ed69f15b7500d10c2">fb22582a</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Remove unused methods from gp_sec_ext

These functions were added by Luke, but have
never actually done anything. If/when we
read from these *.pol files, we won't need these
separate functions to do it.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7bb326a60d2bd2210e76bb20071df114f9c30462">7bb326a6</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Implement process_group_policy() gp_ext func

MS spec describes the policy callback as a
function called ProcessGroupPolicy which accepts
a pDeletedGPOList and a pChangedGPOList param.
The Group Policy Client Side Extension then
iterates over the deleted, then the changed gpo
lists and applies/unapplies policy. We should do
this also.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7cef695368f587573d22b4143fc176fac2ac55b6">7cef6953</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Remove unused gp_ext.list() function

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78601b3516c495c87455732fec8c19c4d21e48f8">78601b35</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Move policy application to the gp_ext

Policy specific setting application should be
handled by the group policy extension, not the
read/parse handler.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/96ffc9690bdeb6b37885addeac9fd699857d350e">96ffc969</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: remove unreached non-DC branch in gp_sec_ext.apply_map()

We don't get this far if we are not a DC, and if somehow we do the
errors will be no more informative due to this special case.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8a21ae62807c49b890fd677aba74cbed432c0590">8a21ae62</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: apply_map should not be required for gp_ext

The apply_map function should not be a requirement
to implement the gp_ext class, since only the
gp_sec_ext uses it now.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cc02de6bfa53af09140a59023f63c2d8bf221ff4">cc02de6b</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Create a function for returning applied settings

This returns a list of guids for gpos applied
plus settings applied and their previous values.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9d7a0bb3de2478b7bb7cc1e2bf56e116c4f52588">9d7a0bb3</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-08T16:17:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: avoid quadratic behaviour in guid retrieval

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: David Mulder <dmulder@suse.com>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/30f6ac9c1632d4e7522576d64c6dff2f205dbf96">30f6ac9c</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Use the new process_group_policy() for unapply

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cab1650539a790ec3d3016d4281b0b4e0a7da15a">cab16505</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Calculate deleted gpos and unapply them

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d07d8bf33754748ccf1703bb4d8564ab062de6c">7d07d8bf</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: add unapply to the gp_sec_ext

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/471089eed45cbda3163f570d3cea37474a27f0ef">471089ee</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Remove unused apply_log_pop() and list() funcs

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e98d18bea527cc6314469d438fe9e44e2a47765">4e98d18b</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpupdate: Add the --force option

This option forces the reapplication of policy,
and works the same as MS 'gpupdate /force'

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6ac1445a99f3a9d22aa98e46e5708bd32dc78d65">6ac1445a</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpupdate: test the new --force option

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba87e23b3842d03dbc1e1cb16f293a3f3eb2bee4">ba87e23b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-08T16:17:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo PEP8: balance whitespace around equals

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: David Mulder <dmulder@suse.com>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cb3eb79eff4304e9f112354db5ffa4d526ee9f29">cb3eb79e</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Test the new get_applied functions

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f390dbfa2c0bc9514eba9d3449e0d106bde90d8c">f390dbfa</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T16:17:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: test the get_deleted_gpos_list() function

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a5a4f979351a99de92b277a60e7680d64e5a1bc6">a5a4f979</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-08T19:25:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo: Test process_group_policy in gp_sec_ext

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>

Autobuild-User(master): Aurélien Aptel <aaptel@samba.org>
Autobuild-Date(master): Mon Oct  8 21:25:59 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8f211efb3a79f24d9542e1c2472633cce2334208">8f211efb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb_unpack: Convert to size_t for internal calculations

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c0c79b32e6c28f5e87caf57d9302c263952db71">0c0c79b3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb_unpack: Correct "len" arg for "B" format

All but one of the users of the "B" format specifier passed in a pointer
to uint32_t instead of what tdb_unpack expected, an "int". Because this
is a purely internal API, change the tdb_unpack function and adjust that
one caller.

To reviewers: Please check carefully, thanks :-)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba787dc4ad3fd7195aee56567be9317358197bab">ba787dc4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb_unpack: Protect against overflow

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1fb2d10d381cf0dd8e66fc4867e936ef37011e64">1fb2d10d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">registry: Fix a typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a35cbb02f09e490f2b533849a08100881f12230">2a35cbb0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">registry: Add error checks to regdb_fetch_keys_internal

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9ed0e93bbd6cd32ed1d35b1279b401d1755d1e5">a9ed0e93</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">registry: Add error checks to regdb_unpack_values

This makes "regdb_unpack_values" take a size_t as buflen. The only
caller calls it with TDB_DATA.dsize, which *is* size_t. Convert the
internal "len" variable to the unsigned size_t as well and add overflow
checks. This depends on tdb_unpack to either return -1 or a positive
value less than or equal to the passed-in "size_t" buflen;

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f20d018aa9989f28a3f0ac53b6130c327b210224">f20d018a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">registry: Print failure of regdb_unpack_values

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ba7b2042b831931c9f88a5c740ad778a7e5f5e7">5ba7b204</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">registry: Don't use an uninitialized value

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b83763d175057f3400c8ae2785efdab612a51b9a">b83763d1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Add tdb_chainwalk_check

This captures the tdb_rescue protection against circular hash chains
with a slow pointer updated only on every other record traverse

If a hash chain has a loop, eventually the next_ptr
will cycle around and be identical to the 'slow' pointer.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e63f7bd3a98023e2400ebb99a0f83098eb708eb5">e63f7bd3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Make tdb_find circular-safe

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6502f7a3d2ac384adf45b8bfbe47516cfa973c16">6502f7a3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Make tdb_dump_chain circular-list safe

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e02c4a417ed36373e0cbeb0d6c789444677b0c1e">e02c4a41</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Make tdb_find_dead circular-safe

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ade339c8c396dbeff44b24a3d0eb4e59f40ff25d">ade339c8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Make get_hash_length circular-safe

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/75e79ca54866ae41107607ebe4427a5bad2a499b">75e79ca5</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Align integer types

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7e1ad4c58890fce29f9a03347b74b651b8b20305">7e1ad4c5</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Make the freelist walk circular-safe

We can't really do the full check while the freelist is modified on the
fly. As long as we don't merge any freelist entries, we should be good
to apply this check.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bdacc41f4610478bb184815b89a26d875d075bf8">bdacc41f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Basic test for circular hash chain fix

This just walks tdb_find by searching for a nonexistent record

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f36a538cbd46e1652bfbd80862f2f03fa3e2f2d0">f36a538c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Basic test for circular freelist fix

Try to store a record for which the (circular) freelist does not have
any entry.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e7d3678ddb5916416193d553f3cc562627e7d8ab">e7d3678d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Avoid the use of open_memstream in tevent_req_profile_string

Solaris does not have it.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13629
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2329518f32d3c772ddd8d6a27c62b18ff4de221a">2329518f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pdb: Use "sid_compose" where appropriate

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f6137454b5aa0e3bac696723b785003ede19c9ef">f6137454</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T20:17:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pdb: Fix some "(ret == true)" to just "(ret)"

"ret" is a boolean, so this should not change semantics

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d25f88f7baa4f463b73eac77ac96c2a724125e43">d25f88f7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-08T23:22:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pdb: Reduce code duplication in make_user_info()

10 lines less and a few hundred (-O0) bytes .text less

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Oct  9 01:22:53 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d46a5d6344a0cd752e8892a0990297ebde68392b">d46a5d63</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-09T20:32:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Multi-line deps

We'll add one in the next commit

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9e26f6ded2938fef8f46df4b91bdd8554fcb6a64">9e26f6de</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-09T20:32:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Use the zlib version of crc32

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dfa51233aa1dbfbfa2a2af21a0fa1750c8b8024c">dfa51233</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-09T20:32:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">drsuapi: Use the zlib version of crc32

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/37f6e2a35172ea85ad9f043f3ce9f88e46bdf9fe">37f6e2a3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-09T23:41:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove lib/crypto/crc32.[ch]

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Oct 10 01:41:52 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ea6421d734ec538325560cf2bd9a0a03280a8cee">ea6421d7</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-10-10T04:16:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">emulate/traffic: allow traffic_replay to run users and groups generate multiple times

When we run `traffic_replay --generate-users-only`, if we cancel it or
it breaks in middle, it won't do anything when we try to run it again.

This is because the code will check the first user/group to create. If
it's already there, then it thought task already done, and break the loop.

This commit change the behavior:
We search existing users/groups first, skip existing ones, and
create non-existing ones. So we can run it multi-times to make sure the
expected users and groups are actually created.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e5cf5a687042d4898166ce3c8e1ad3bd810b91ca">e5cf5a68</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-10-10T04:16:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba/logger: add logger module for python

We need a consitent way for logging in Samba Python code.

This module provides a factory method `get_samba_logger` to create logger,
with a reasonable default format and optional color.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e8a1773ce238cef8735ddcd445e591c33e17d37e">e8a1773c</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-10-10T04:16:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">emulate/traffic: apply new logger to replace print

These print are actually progress infomation, should use logger to
print to stderr, other than stdout.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/33ce1fa23e8dfc0e392aa09733f36c5f2418a6fe">33ce1fa2</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-10-10T04:16:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script/traffic_replay: print packets data to stderr

This is debug info, should print to stderr.
Otherwise it will flood stdout.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/57594c8772aac6341516fb78f452564f83cec54a">57594c87</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-10-10T04:16:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script/traffic_replay: get debug level via api

The -d option will set samba global debug level automatically.
We should not parse and use the passed in value.

Use samba.get_debug_level instead.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4260fb87edd1719ecf6d07b3b5230a070410f629">4260fb87</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-10-10T04:16:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script/traffic_replay: apply new logger to replace print

Use logger to replace print

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0979d96006b7220fb8838dc34f57dcb6f1ad011a">0979d960</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-10-10T04:16:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: modify Command.get_logger to use get_samba_logger

By doing this, we don't need to repeat the log level convert code any more.
Also, logs have colors now.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/126a14b443d7fd238d693a3e4e434b83bba96065">126a14b4</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-10-10T04:16:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: apply the new get_logger to cmds

This is an example of how to use the new logger.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/473c1c00f977d135fae241e6ddc0bc13d582fb08">473c1c00</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-10T04:16:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">popt_common_creds: actually use the ignore_missing_conf flag

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Pair-programmed-with: Olly Betts <olly@survex.com>
Reviewed-by: Noel Power <nopower@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77ef686f59fb5f227a57838221d1857433c74c65">77ef686f</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-10-10T04:16:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pyauth: Remove imessaging_ctx parameter to new

The pyauth code assumes the messaging context code is a py_talloc
object.  But the code in pymessaging returns a wrapped talloc object.
Removing the parameter as it's not currently used by any code.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Noel Power <nopower@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/79e1ed1ffa172c9ed4d79668d7fb6adb56770ef7">79e1ed1f</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-10T04:16:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/upgradehelpers: use int not long for PY3

int works OK for py2 also.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <nopower@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/131f98ed1601c925b5a689606e55b078d7b4e9e2">131f98ed</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-10T07:28:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/python/ldap: use int instead of long for time_t

Python int is at least a C long; Python long disappears in Py3.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <nopower@suse.com>

Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Wed Oct 10 09:28:20 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b9728480f6ab22da0831400796f3c39ec543df8">8b972848</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: FinderInfo conversion test with AppleDouble without xattr data

This testcase demonstrates that the AppleDouble conversion in vfs_fruit
doesn't correctly convert the FinderInfo data from the AppleDouble file
to a stream.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7e010abbaad79643f31361de47340c218fa39505">7e010abb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: fix two comments

Thanks to the recent addition of ad_convert_xattr() we now correctly
handle this case.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8ee7e6135e39520f486e8f8f4ba36009c9113229">8ee7e613</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: store filler bytes from AppleDouble file header in struct adouble

This can later be used to distinguish between macOS created AppleDouble
files and AppleDouble files created by Samba or Netatalk.

macOS:    "Mac OS X        "
Samba:    "Netatalk        "
Netatalk: "Netatalk        "

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d161e047710322491802d75f47598f96727cd004">d161e047</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: move setting ADEID_FINDERI length to ad_convert_xattr()

ad_convert_xattr() does the conversion of the xattr data in the
AppleDouble file, so we should update it's size there and should not
defer it to the caller.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8bc36d723ff41afe768f42b833aa951e1ee8fb38">8bc36d72</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: do direct return from error checks in ad_convert()

Subsequent commits will move the mmap() into the subfunctions. This
change just prepares for that.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99cc9ef82b50b57149f71a40d4b22a3fc32a5a97">99cc9ef8</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: remove unneeded fd argument from ad_convert()

Use the struct adouble member ad_fd instead of passing it as an
argument. Who did that in the first place? :)

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b355a09576563d0f681d0bf830d0e2c769533399">b355a095</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: move storing of modified struct adouble to ad_convert()

ad_convert() modified it, so let ad_convert() also save it to disk. No
change in behaviour.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d27d0326c3c8cb6d217e6c8056fae2c98ef82803">d27d0326</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: move FinderInfo conversion to helper function and call it from ad_convert()

No change in behaviour.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4f1174b6eb2257d789a1eb9c925ccc561bab2f16">4f1174b6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: move FinderInfo lenght check to ad_convert()

The final step in consolidating all conversion related work in
ad_convert(). No change in behaviour.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/98bd7c0a46f72b097011a5c59e899ac4862ff651">98bd7c0a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: split out truncating from ad_convert()

This may look a little ill-advised as this increases line count, but
the goal here is modularizing ad_convert() itself and making it as slick
as possible helps achieving that goal.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b948681b2bbaba202843858857fb9edbb543bdf2">b948681b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: use ADEDOFF_RFORK_DOT_UND offset macro in ad_convert_truncate()

We really want the fixed size offset here, not a calculated one. Note
that "ad_getentryoff(ad, ADEID_RFORK)" is equal to ADEDOFF_RFORK_DOT_UND
in this case.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c7e1de46f4287818ef525c8939029ccb09adf65">4c7e1de4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: split out moving of the resource fork

No change in behaviour.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/93b7e0562159eae40e196f6be8d82283f0be2888">93b7e056</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: use ADEDOFF_RFORK_DOT_UND offset macro in ad_convert_move_reso()

We really want the fixed size offset here, not a calculated one. Note
that "ad_getentryoff(ad, ADEID_FINDERI) + ADEDLEN_FINDERI" is equal to
ADEDOFF_RFORK_DOT_UND.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f91e0c857a5a44a5eab7696fafda758044739978">f91e0c85</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: fix error returns in ad_convert_xattr()

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/918c6c59901d0bf939dcc178b661b6ae8201e903">918c6c59</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: let the ad_convert_*() subfunctions mmap as needed

This may mean that we mmap twice when we convert an AppleDouble file,
but this is the only sane way to cleanly modularize ad_convert().

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1692ca5fd8ae2560dae6828f3c5c05a65c530726">1692ca5f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: let the ad_convert_*() subfunction update the on-disk AppleDoube header as needed

Another step in simplifying ad_convert() itself. It means that we may
write to disk twice, but is only ever done once per AppleDouble file.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70d3ae5a89fc62db192c44b92a5b7fb67a93d88e">70d3ae5a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: call ad_convert_move_reso() from ad_convert_xattr()

ad_convert_xattr() is the place that triggers the need to move the
resource fork, so it should also call ad_convert_move_reso().

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5598e6bc3583a88f474afa2996d1f9362d1bd9fb">5598e6bc</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: add check for OS X filler in FinderInfo conversion

This ensures that the function only acts on AppleDouble files created by
macOS and not AppleDouble files created by us that are already in the
correct format (only using the Resource Fork).

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/acb72c1ea7fecc9a7e8eb0219096b1bbdfd8850e">acb72c1e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: add out arg "converted_xattr" to ad_convert_xattr

Used to let the caller know if a conversion has been done. Currently not
used in the caller, that comes next.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9cf087a474bb2d7d29ca0daeaef412f6b545d0e0">9cf087a4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T20:22:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: make call to ad_convert_truncate() optional

Call ad_convert_truncate() based on whether the previous call
ad_convert_xattr() returned converted_xattr=true.

Upcoming fixes for a different Samba bug (#13642) will hook into calling
ad_convert_truncate() in other cases, this also prepares for that.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/31daab88e6a415e72ead69844e3eccf5dc02e53c">31daab88</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-10T23:30:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: move check in ad_convert() to ad_convert_*() subfunctions

Currently the whole conversion is skipped if the FinderInfo entry in the
AppleDouble file is of the default size (ie not containing xattrs).

That also means we never converted FinderInfo from the AppleDouble file
to stream format. This change finally fixes this.

Note that this keeps failing with streams_depot, much like the existing
known-fail of "samba3.vfs.fruit streams_depot.OS X AppleDouble file
conversion". Fixing the conversion to work with vfs_streams_depot is a
task for another day.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Oct 11 01:30:13 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/96b5bf1370fc7975e766dccb1ad70aa57f1d9c6a">96b5bf13</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-10-11T08:28:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: move copy_session_info() from source3 into the global auth context

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ea38be487e64dcdac65f7080ac86f9e0699432b9">ea38be48</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-10-11T08:28:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Add samba.auth.copy_session_info()

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a44be636e3f5ac02c8683ff483cbf924e8bf340">9a44be63</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-10-11T08:28:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-auth: fix a typo in a comment

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/29af2df4e138b4088532e898a152bacfd3a2c830">29af2df4</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-10-11T08:28:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-auth: use TALLOC_FREE() shortcut

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/29e757aca23933c52f9420d2cffbe5be17cf585d">29e757ac</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-10-11T08:28:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-auth: fetch possible out of memory error

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f3b7ba1746a33d058901dd8274953e6c5379e2b1">f3b7ba17</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-10-11T08:28:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-auth: allow to create unix token from system session info

Without this patch security_token_to_unix_token() fails with
NT_STATUS_ACCESS_DENIED, because the system session does only
have one SID.
For a typical token are at least two or more SIDs expected.

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f08cb6693b744bfd8cbf66415957baabd07ec3a">6f08cb66</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-10-11T08:28:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-auth: allow to pass original_user_name=NULL to auth_session_info_fill_unix()

With this patch the auth_session_info_fill_unix() uses the "unix_name"
from the session_info->unix_info if no original_user_name was specified.

This is used to process a system session info where no original_user_name
is given.

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ab558fa14c296b90f182ea4f53b2fb410d851837">ab558fa1</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-10-11T08:28:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: add option to pass a session info to set_nt_acl() function

A filled session info is needed by some vfs modules, e.g. full_audit.

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bc8d0d51602831976d426aee53e9ab83a6813497">bc8d0d51</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-10-11T08:28:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: handle file not found error

Avoid PANIC: internal error

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/38fe315bcf7c20ae00f2b1ad5e497a8d1046850d">38fe315b</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-10-11T08:28:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool ntacl: pass system session to get/set-ntacl functions

The filled session is needed in different vfs modules.

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/01ff09adccc88367e807bbf5d5e8cd2eae6a38b0">01ff09ad</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-10-11T08:28:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/py_passdb: add get_domain_sid() to get domain sid from secrets database

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e54d4ffbaa3fb1ab9e80d4d107bf2a4d9c3d2d8f">e54d4ffb</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-10-11T08:28:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool ntacl: allow to run get/set-ntacl command in non-AD-DC role

Can be used to get and apply NT-ACLs on Samba member servers.

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e57862760ea71792856222b6754d3b251ff44581">e5786276</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-10-11T08:28:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: test samba-tool ntacl get/set on AD member server

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b773be3371ef9014511b58951986f92f59bd6975">b773be33</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-10-11T08:28:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns update: add missing newline in error debug message

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff3e2fa84f1c083d4eaa057c8f0ba518ff1fe086">ff3e2fa8</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2018-10-11T11:40:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_full_audit: ntimes: log a-, m-, c- and creation-time

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Björn Baumbach <bb@sernet.de>
Autobuild-Date(master): Thu Oct 11 13:40:27 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cb5ad7fefedb85b21e19475851819b0021e06276">cb5ad7fe</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-12T02:16:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/script/samba_upgradeprovision: use int not long for Python 3

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1851c35e99b84c057859d736dd3d1cda6a428281">1851c35e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-12T02:16:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/script/samba_upgradeprovision: remove duplicate (contradictory) dict key

The second, winning, entry says '"defaultSecurityDescriptor": replace + add'

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/69fad8bff0be5efc5a3cc4339bff66af8734f38f">69fad8bf</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-12T02:16:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/script/samba_upgradeprovision: remove unused variable

A similarly named variable is always set two lines down, so we don't need this

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1139a4a6a0fedfbbc7a7d822e845927c6af52905">1139a4a6</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-12T02:16:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/script/samba_upgradeprovision: set global dnNotToRecalculateFound var

as probably intended. Without this the local variable shadows the
global one and is never used while the global one is never changed.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dec3eda1f74f5bf7ea91c1be3d5dfd832e9672b9">dec3eda1</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-10-12T02:16:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add corner-case test: fromServer points to dead server

The fromServer attribute is slightly unique, in that it's a DN (similar
to a one-way link), but it is also a mandatory attribute.

Currently, if fromServer gets a bad value (i.e. a dead server that has
been expunged), the DSDB rejects any attempts to modify the associated
nTDSConnection object (regardless of whether or not you're actually
changing the fromServer attribute).

This patch adds a test-case that demonstrates how the DB can get into
such a state.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4092b369aeeb7058d78b8d6f41dbbc6d69203ecc">4092b369</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-10-12T02:16:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Ensure that a DN (now) pointing at a deleted object counts for objectclass-based MUST

Add the 'reveal_internals' controls when performing objectclass-based
checks of mandatory attributes. This prevents the extended_dn DSDB
module from suppressing attributes that point to deleted (i.e.
non-existent/expunged) objects.

This ensures that, when modifying an object (and often not even
touching the mandatory attribute) that the fact that an attribute is a
DN, and the DN target is deleted, that the schema check will still pass.

Otherwise a fromServer pointing at a dead server can cause failures,
i.e. you can't modify the affected object at all, because the DSDB
thinks a mandatory attribute is missing.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/24669e57fcb5eb592e86746c9451977752d37f23">24669e57</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-10-12T02:16:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Remove redundant variable/check

Previously, this code used to live inside the loop, so the
checked_reveal_control was needed to save ourselves unnecessary work.

However, now that the code has been moved outside the loop, the
checked_reveal_control variable is just unnecessary complication.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b2c4b829a75001ec939f9ecbc0db0712758ece80">b2c4b829</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-10-12T02:16:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Change Py3 incompatible long() for tombstone expunge

The code to expunge tombstones uses long(), which is not Python3
compatible. Python3 uses int() instead, and works out how big it needs
to be.

As long as we don't run the samba-tool command on a 32-bit machine
after the year 2038, then we should avoid any integer overflow on
Python 2.x.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3efb4588abaf55c0b58b035790d9da822f62b09d">3efb4588</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-10-12T05:23:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Add dsdb_request_has_control() helper function

Most of the DSDB modules only want to check the existence of a control,
rather than access the control itself. Adding a helper function allows
the code to ask more natural-sounding yes/no questions, and tidies up
an ugly-looking long-line in extended_dn_out.c.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Fri Oct 12 07:23:26 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2fc855e7d2458249ca6fc8ffdf1d7633ab84cc55">2fc855e7</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-12T13:27:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs showrepl: do not crash if no dnsHostName found

This should not happen, but it does sometimes in an autobuild
environment. Rather than reporting this by crashing, we report it by
showing there is no DNS name.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Fri Oct 12 15:27:07 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/84615c19826895ab57e40ab2b2cdfdc625376097">84615c19</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-10-16T06:42:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Add memset_s() if not available

See https://en.cppreference.com/w/c/string/byte/memset

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9291a3330a1e0876b73182b4e5e44e7d6d450b55">9291a333</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-10-16T09:38:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib:popt: Use memset_s() to burn password string

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Oct 16 11:38:40 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fb573c682353daf5b343b6a0f4832dcbc96ebc57">fb573c68</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-16T16:00:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd_cache: Fix timeout calculation for sid<->name cache

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fdb50817cac2423adae3daf94759ecf1e6580760">fdb50817</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-16T16:00:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">namemap_cache: Absorb the expired calculation into namemap_cache.c

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2557ae53edcdb723a400f12d54081ef0c13b7600">2557ae53</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-16T19:20:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Move the "expired" for gencache_parse calculation into gencache.c

Make it more robust

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Oct 16 21:20:19 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3713905f8b4baa56b1bf571f71009cd77ccda6eb">3713905f</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-10-17T03:40:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: dlz_bind9 reference count logging

dlz_bind9 has to count the number of times the plugin is 'created' by bind's
plugin manager so it doesn't repeat setup.  Logging doesn't reflect this
reference counting logic properly and so messages like "samba_dlz: shutdown"
can, confusingly, come up when the database connection has not actually been
severed.  This patch adds the necessary logging.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13655
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/539daefaf3f7edb6a630f3d57fb590f57a6ab688">539daefa</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-10-17T03:40:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnet/drs: Update replication debug to report link progress

Update the replication debug (for joins/backups) so that it's easier to
see how far through syncing the links we are. E.g. with 150,000 links,
you just get screeds of debug like this, with no real idea how far
through the replication is.

Partition[DC=addom,DC=samba,DC=example,DC=com] objects[11816/11720]
linked_values[1500/150024]
Partition[DC=addom,DC=samba,DC=example,DC=com] objects[11816/11720]
linked_values[1500/150024]
Partition[DC=addom,DC=samba,DC=example,DC=com] objects[11816/11720]
linked_values[1500/150024]

This patch now applies to links the same debug logic we use for objects,
and changes it to look like:

Partition[DC=addom,DC=samba,DC=example,DC=com] objects[11816/11720]
linked_values[57024/150024]
Partition[DC=addom,DC=samba,DC=example,DC=com] objects[11816/11720]
linked_values[58524/150024]
Partition[DC=addom,DC=samba,DC=example,DC=com] objects[11816/11720]
linked_values[60024/150024]

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fdb6b86b8e326e1d9d1ca4be780ff374b6dddde2">fdb6b86b</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-10-17T06:56:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">drs_util: Improve memory usage when joining large DB

drs_Replicate.replicate() could consume a large amount of memory when
replicating a large DB. This is not a leak - the memory gets freed when
the function returns (i.e. once the partition is fully replicated).
However, while the partition is in the process of being replicated, it
accumulates memory for each replication chunk it receives. This can have
considerable overhead with 1000s of objects/links in the partition.

This was exhausting memory when joining a VM with 1Gb RAM to a DC with
25K users (average ~15 group memberships per user).

It seems that by storing a reference to something that's on the ctr's
talloc tree, it doesn't free up the memory for each ctr message (until
the function actually returns and req is destroyed).

With 10K users (and average 15 group memberships per user), .replicate()
consumed 211Mb of memory, according to talloc.report_full(). With this
patch, it goes down to just the current ctr message (1-2Mb).

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Oct 17 08:56:42 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/410ec70bb308980c2f2c5d555a64c44b8b610744">410ec70b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-17T17:22:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netsamlogon_cache: Fix talloc_stackframe error return leaks

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b6166f772c647fc72742e13ecd4c04d002b1d8f">9b6166f7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-17T17:22:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netsamlogon_cache: Use "goto fail", save some lines

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/030a3e506ec8dbe1808609b215f66b5e7e19951b">030a3e50</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-17T17:22:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netsamlogon_cache: Add some error checks

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fa1f959321ae3df9a133e4c2b8992e1233337a2e">fa1f9593</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-17T17:22:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netsamlogon_cache: Improve a DBG message

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4df055bbbb231dc77ca698614fd836ba4c113691">4df055bb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-17T17:22:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth3: Avoid an explicit ZERO_STRUCT

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a29ffc3e0527733217a6f62d1669f60fab6e2ac">2a29ffc3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-17T17:22:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gencache: Avoid counting characters manually

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/140a0e053719e1482211d5937c73e6303c2397bd">140a0e05</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-17T17:22:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gencache: Swap tests: Do cheapest first

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6007c444d946ed7eb7572fed02e448c61f86a394">6007c444</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-17T17:22:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gencache: Call string_term_tdb_data() only once

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/34fe8b1ac6a79680fcbb34e9fcad2869d66d88e6">34fe8b1a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-17T17:22:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gencache: Make gencache_pull_timeout a bit more robust

The previous version assumed a well-formed "val", we just handed it to
strtol without properly checking that it contains the delimiter. So
strtol could well run off the end of "val" in case of data corruption.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78b8b9164679d782ed0eb2608961972eb08f73f9">78b8b916</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-17T17:22:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gencache: Make gencache_pull_timeout return a payload DATA_BLOB

Both relevant callers created one anyway.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0817d107a4af2640dbbf28b8316545a007660db8">0817d107</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-17T17:22:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gencache: Remove a redundant check

gencache_pull_timeout checks for NULL ptr already

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/85ec8644251eff0174c973747b59043180ac58c7">85ec8644</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-17T20:22:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gencache: Remove a redundant check

tdb_storev itself is robust against overflow due to multiple buffers

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Oct 17 22:22:51 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d8ea16a3fb6d8ad9b738e8e71adc07079a292079">d8ea16a3</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-10-18T04:15:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">join: LDAP connection to remote DC can timeout in large join

When joining a very large domain (e.g. 100K users), the replication can
take so long that the LDAP connection to the remote DC times out.

This patch avoids the problem by adding in a sanity-check after the
replication finishes that the LDB connection is still alive. If not,
then we reconnect.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13612

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/30277feb839f7460638c777b048e45d557dfdea0">30277feb</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-10-18T04:15:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">join: Avoid searching for more than strictly required during sanity check

We check for the default base DN as this does require authentication, but
we do not need to search for more than just that (so use SCOPE_BASE) and
we need no attributes, so ask for none

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/10a9cc44abd29f46f075823fce55b496e760c7bd">10a9cc44</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-10-18T04:15:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">join: Sanity-check LDB connection before failed join cleanup

Joining a large DB can take so long that the LDAP connection times out.
The previous patch fixed the 'happy case' where the join succeeds.
However, if the commit or replication fails (throwing an exception),
then the cleanup code can also fail when it tries to delete objects from
the remote DC. This then gives you an error pointing to
cleanup_old_accounts() rather than what actually went wrong.

This patch adds a sanity-check that if the join fails, that the LDB
connection to the remote DC is still alive, before we start deleting
objects.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13612

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da875eda6a65f283492497f57df06c7ff57562a3">da875eda</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-10-18T04:15:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">uptodateness: add new module and migrate functions from visualize

Both visualize and drs cmd will have uptodateness functions.
Create a new module to reuse code.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13658
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6ed82c7c0dae5f6c0feca1d94f85ca88237f3d1d">6ed82c7c</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-10-18T04:15:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">uptodateness: migrate more methods from visualize

Move methods from cmd_uptodateness to new module.
Will reuse in drs cmd later.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13658
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff311f1dc7229497b3b0fb05933177459370372e">ff311f1d</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-10-18T04:15:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd/visualize: rm unused code line

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13658
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ac1fba31c4e87070cfc0dee32150785bedb8e249">ac1fba31</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-10-18T04:15:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">uptodateness: extract function get_utdv_edges

Extract function to reuse later.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13658
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bbef7d6727bee12c3dee14cd9b67440d0548a8b4">bbef7d67</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-10-18T04:15:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">uptodateness: extract function get_utdv_distances

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13658
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/90975eb0887562bd704b95a4ff34882670de09c7">90975eb0</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-10-18T04:15:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">uptodateness: extract get_utdv_max_distance

To avoid returning 2 values from get_utdv_distances.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13658
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/74f7080b1593b446c89f0d940bbdcdb025168cfd">74f7080b</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-10-18T04:15:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">uptodateness: migrate get_kcc_and_dsas as a function

We need to reuse it in drs cmd.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13658
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f4f5f17450f6890b4ba0192c95edab473039816a">f4f5f174</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-10-18T04:15:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">uptodateness: add get_utdv_summary function

Get utdv summary from distances matrix and support attr filters.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13658
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/219b52cfb5419ee6649d4739dd6d8d9576d5b3a5">219b52cf</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-10-18T04:15:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd/drs: add cmd_drs_uptodateness with json support

Add cmd to print uptodateness summary with json support.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13658
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e404b6aaf51015f43e1a1f8434c42bcbbe05efdb">e404b6aa</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-10-18T08:02:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: add tests for samba-tool drs uptodateness

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13658

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Oct 18 10:02:19 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/204bd0e447b5a83f603eac9dd317bdb026539cbc">204bd0e4</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-18T08:04:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py3/tests/kcc: turn error into failure for flapping.d/kcc

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/30e9c00f2d8ba6395deb4fe8734e41b1000f13f0">30e9c00f</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-18T08:04:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py3_tests/kcc : test_verify can hit KCCError as well as GraphError

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ce518f387f9f6742f642ce33901cd778375bb4fd">ce518f38</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-18T11:17:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_ldif: be less horribly efficient in debugging

perf said all the time was in strlen.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Thu Oct 18 13:17:30 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a0bad1364a9403afc5f457bf71a1eae48ab7b54e">a0bad136</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-19T01:43:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_ldif: avoid strlen(NULL)

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Martin Schwenke <martin@meltin.net>

Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Oct 19 03:43:58 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b6e45fb479689cff028b1fe626533b035e313ce3">b6e45fb4</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-10-19T04:17:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python tests Blackbox: add random_password

Add the random_password method to the BlackboxTestCase class and remove
duplicated copies from other test cases. Also use SystemRandom so that
the generated passwords are more cryptographically sound.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e1eee614ca8a3f0f5609a3d9d8ce7ae926de1f9e">e1eee614</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-10-19T04:17:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb encrypted_secrets tests: Allow "ldb://" in file path

When creating a new user and specifying the local file path of the
sam.ldb DB, it's possible to create an account that you can't actually
login with.

This commit contains tests to verify the bug.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13653

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b59cd74f9f75d85b91c6ca517d0243e7f6bd2e1">7b59cd74</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-10-19T07:34:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb encrypted_secrets: Allow "ldb:// and "mdb://" in file path

Correctly handle "ldb://" and "mdb://" schemes in the file path when
determining the path for the encrypted secrets key file.

When creating a new user and specifying the local file path of the
sam.ldb DB, it was possible to create an account that you could not
login with. The path for the key file was incorrectly calculated
for the "ldb://" and "mdb://" schemes, the scheme was not stripped from
the path and the subsequent open of the key file failed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13653

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Oct 19 09:34:46 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e310ad7e1ebabfb6d5f1a3cfd096da6cfe4a286c">e310ad7e</a></strong>
<div>
<span>by Philipp Gesang</span>
<i>at 2018-10-19T11:59:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:secrets: clean up sid before storing

SIDs may contain non-zero memory beyond SubAuthorityCount:

    {
    key(15) = "SECRETS/SID/FOO"
    data(68) = "\01\04\00\00\00\00\00\05\15\00\00\00}u@\8C\08\A3\06nx\95\16\FE\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00`F\92\B7\03\00\00\00\18e\92\B7\03\00\00\00@H\92\B7\00\00\00\00"
    }

These parts are lost when converting to ``string format syntax``
so a roundtrip conversion does not result in the same binary
representation.

Ensure that these never reach the tdb by using an initialized
copy. This allows bitwise comparisons of secrets.tdb after
dumping SIDs as text and reading them back.

Signed-off-by: Philipp Gesang <philipp.gesang@intra2net.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Oct 19 13:59:04 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5b2c3f2f422f4f99036e9584a0fd398a30c8618a">5b2c3f2f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-19T16:52:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove gencache.h from proto.h

It's a pain to recompile the world if gencache.h changes

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Oct 19 18:52:50 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9e03fb60dca0ebafa8bf8095d6e21659bdf453ee">9e03fb60</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2018-10-19T21:11:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: deprecate talloc_set_memlimit()

The memlimit functionality was never utilized by Samba. It adds unneeded
complexity, so flag it as deprecated.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2679dd0fd87903822f7ed29cfb88834838e69346">2679dd0f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-10-19T21:11:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:registry: Avoid a double-free in reg_perfcount

Found by covscan.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f040d660c0312dddbf03a9a6762044425d82fcb6">f040d660</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-10-19T21:11:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndr: Init variables of GUID_from_data_blob()

Found by covscan.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1ca21b98231d8ea9473f7cb8838cdb21f4663657">1ca21b98</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-10-19T21:11:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Fix the scope of the req variable in drsuapi test

Found by covscan.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d15a00babf3e2940a03fd9a70c1c54951f4f8660">d15a00ba</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-10-20T00:17:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbcontrol: Simplify the return code check

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Oct 20 02:17:56 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a3d12252fa8e0a7e900b819dec30bdb9da458254">a3d12252</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-22T04:04:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Return early when refusing to run an event script

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13659

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c9e1603a5d0c1a216439d4a2b0e7cdc05181e898">c9e1603a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-22T04:04:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Exit if eventd goes away

ctdbd enters a broken state if eventd goes away.  A clean shutdown is
not possible because that involves running events.  Restarting eventd
is possible but this might mask a serious problem and it is possible
that eventd might keep on disappearing.  Just exit.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13659

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/80549927bc1741a4b8af8b8e830de4d37fa0c4a8">80549927</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-22T04:04:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Set close-on-exec for startup fd

The startup_fd should not be propagated to the child processes created
from a daemon.  It should only be used in the daemon code to return the
status of the startup.  Another use of startup_fd is to notify the
parent if the daemon process has exited.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13659

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a1909603808b994b7822b697494e39e8da4aaa66">a1909603</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-10-22T04:04:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Check the return status of sock_daemon_set_startup_fd

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13659

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fbea9d36996f248ba2b077f12ad16c199b853134">fbea9d36</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-10-22T07:27:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Fix valgrind hit in event code

==25741== Syscall param write(buf) points to uninitialised byte(s)
==25741==    at 0x4939291: write (write.c:27)
==25741==    by 0x4868285: sys_write (sys_rw.c:68)
==25741==    by 0x13915D: sock_queue_trigger (sock_io.c:316)
==25741==    by 0x4DE6478: tevent_common_invoke_immediate_handler (in /usr/lib/x86_64-linux-gnu/libtevent.so.0.9.37)
==25741==    by 0x4DE64A2: tevent_common_loop_immediate (in /usr/lib/x86_64-linux-gnu/libtevent.so.0.9.37)
==25741==    by 0x4DEBE5A: ??? (in /usr/lib/x86_64-linux-gnu/libtevent.so.0.9.37)
==25741==    by 0x4DEA2D6: ??? (in /usr/lib/x86_64-linux-gnu/libtevent.so.0.9.37)
==25741==    by 0x4DE57E3: _tevent_loop_once (in /usr/lib/x86_64-linux-gnu/libtevent.so.0.9.37)
==25741==    by 0x15D1BA: ctdb_event_script_args (eventscript.c:821)
==25741==    by 0x13B437: ctdb_start_daemon (ctdb_daemon.c:1315)
==25741==    by 0x110642: main (ctdbd.c:393)
==25741==  Address 0x57888a4 is 100 bytes inside a block of size 144 alloc'd
==25741==    at 0x48357BF: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==25741==    by 0x4B9B7C0: talloc_named_const (in /usr/lib/x86_64-linux-gnu/libtalloc.so.2.1.14)
==25741==    by 0x15CCC6: eventd_client_write (eventscript.c:430)
==25741==    by 0x15CCC6: eventd_client_run (eventscript.c:556)
==25741==    by 0x15CCC6: ctdb_event_script_run (eventscript.c:649)
==25741==    by 0x15D198: ctdb_event_script_args (eventscript.c:812)
==25741==    by 0x13B437: ctdb_start_daemon (ctdb_daemon.c:1315)
==25741==    by 0x110642: main (ctdbd.c:393)
==25741==

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13659

Pair-programmed-with: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon Oct 22 09:27:15 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d114ca1e64cd811b6d7a893dfc26a6dca49c1d2c">d114ca1e</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-10-23T03:50:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add expected-value testing for userParameters

This does not means that bugs like https://bugzilla.samba.org/show_bug.cgi?id=11881
are fixed, however we do not wish to cause further issues
without noticing it, eg during python3 fixes for dbcheck.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f5f8676b630e595532e188a559448478c0702ec7">f5f8676b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting/bin: PY3 Make sure print statements are enclosed by '()'

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff3f5411fa15080c5f0c6b9f3112ab1e0e58525a">ff3f5411</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: PY3 iterable has no sort method

map in python3 returns an iterable, in python2 it returned
a list. Iterable has no sort method, use sort function instead or
construct a list from the iterable so you can use list.sort

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/842f09aaa7b5f0210d3250facbdf745feedd6ef2">842f09aa</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: PY3 dict view doesn't have sort method,

Can't sort a dict view, create a list from view then use list.sort
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/412002629eb849638d929668f96d5e2dab50f1cc">41200262</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/gp_parse: PY3 fdeploy_sids needs to use key method for sort

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dcf787b26354d133a26dcad74cc62fe62b59a87d">dcf787b2</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting: PY3 need to convert cmp funct to key func for sort.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e53821793074691e92d71e49023dd4b61efd5f1c">e5382179</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: In a pure PY3 build filter-subunit was getting called without 'python'

tests were getting called with "| ${src}/selftest/filter-subunit" which
resulted in filter-subunit getting execve'd without a calling python. This
resulted in /usr/bin/python (default python) getting called and subsequent
imports failing.
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f8a570f906ca787ba4044c0f2fbe88b2c6afd5e">9f8a570f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/target: Make sure samba-tool is called with ${PYTHON}

Ensure python scripts are called with the python version that
is defined by $PYTHON

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c8403f3360ba0d028700d6186c604ca95bf04c0b">c8403f33</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: make sure samba-tool is called with ${PYTHON}

Ensure python scripts are called with the python version that
is defined by $PYTHON

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c751013fa5a0b9ca3248f1177d107e05f5094393">c751013f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs/blackbox: Use PYTHON env variable for calling python scripts

Ensure samba-tool is called with correct python that is
defined by $PYTHON

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/15b2ab04b7a97fe948aec9169d5d49f22fdb8289">15b2ab04</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting: PY3 Ensure python scripts are run with correct python ver.

As part of port samba4.blackbox.samba3dump to python2/3
make sure test_samba3dump.sh runs samba3dump with $PYTHON which should
define the correct python version.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ee595e9b7cea888a978831076e9de3111afccd42">ee595e9b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/setup/tests: PY3 samba-tool needs to be called with correct python ver.

Ensure samba-tool python version defined by $PYTHON

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ade47b3df0a173743ed4ff0633e8544f08774253">ade47b3d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: Only decode when necessary
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9ea6cb187305877af33dc629a4cf894e572e6a13">9ea6cb18</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: PY3 only possible to decode bytes

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/95dbe1177fd82e3a553ac98fd25ee06ca20f8776">95dbe117</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: PY2/PY3 port samba.tests.dcerpc.integer

Python3 no longer has a long type so the 'L' postfix is no
longer valid. Additionally in python2 an int that exceeds will
be transparently converted into a long when necessary
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/23239727734bbc7f58dcba3d8e9f160849885276">23239727</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: py_strcasecmp_m & py_strstr_m don't handle unicode properly

py_strcasecmp_m & py_strstr_m use PyArg_ParseTuple() with 's' which
in Py2 tries to decode string with the default (e.g. ascii) encoding

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8d7830b6fc1b0cfb2f1dd9e9315aff67dbef3c93">8d7830b6</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: convert samba.tests.strings to Py2/Py3

Previously the py2 api for strcasecmp_m/strstr_m required strings/unicode
 but couldn't actually handle unicode with anything other than the default
encoding (e.g. ascii). The c-api as been fixed and the encoding steps
(which were unnecessary and causing errors in PY3) have been removed
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/600fde58ab616f7c786b43da23acb0b441bd6885">600fde58</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: add alias for ConfigParser for PY2/PY3 compatability

ConfigParser module changed name to configParser in PY3, additionally
the behaviour regarding interpolation has changed. ConfigParser now
has a default interpolation param whose behaviour demands that '%' is
escaped. To maintain behaviour with the python2 version this default
param needs to be changed. Add some alias(s) and 'shim' Configparser
symbol in samba.compat to cater for this.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/04c118cf0eefebe5e25cdd687c0d970c7ba70b67">04c118cf</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/gp_parse: PY2/PY3 compat porting for gp_init.py

Fixes
1) use compat versions of ConfigParser and StringIO
2) open file needs to be opened in binary mode as write_pretty_xml
   routine uses BytesIO() object.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/72c5b270668a07d7591ea033e811ec09ebb3652d">72c5b270</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: use PY3 version of ConfigParser

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4287d119b02defb3ae5b18d1f1c44be098537cba">4287d119</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: port samba.tests.samba3sam
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9ae5fd65a8cc5e08d318dff1773b04194115a039">9ae5fd65</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting/bin: PY3 Fix exception tuple assignments.

In Python3 to access the exception arguments you need to now use
Exception.args, in Python2 you could access these direcly with the
'except' declaration.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ca12342b0a07ca707823cd35be12dc806fa46a89">ca12342b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: relative import fixes
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8eae420fbc0377e7d64a16defe31b0f9e7976121">8eae420f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: ensure StringIO usage is py2/py3 compatible
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/17728c2f53acbb2a128440152d8d2d954f85f67a">17728c2f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: ldb attribute string fix for wafsamba.tests
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e5cac2b843d18bc0d67562460366e0abf9484b3c">e5cac2b8</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: misc use of str for ldb.bytes

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/370dcbb791153ff725bd1e254e610ce43dfcd7f1">370dcbb7</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba_tool: Enclose iterator with list

Really strange bug caused by map being updated while being iterated.
This caused keys to be skipped and inconsistent and incorrect
results from ldapcmp.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/557ff7b7fffc86718b27fbdb3c3b34f894b5f593">557ff7b7</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: samba4.blackbox.dbcheck.release-4-1-0rc3

* Various string related fixed py2/py3
* Fix strange double decode followed by encode code (see comments
  in change)
* Added dump_attr_values, simply printing attribute values (from
  sequence) doesn't work (when using string '%s' format codes in
  existing string). We need to print out string from bytes in PY3
  and fallback to repr(which will print b'blah') if we get a decode error

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0febd003b5762339e491017afe65661b2709ef97">0febd003</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting: PY2/PY3 port for samba4.blackbox.upgradeprovision.current

o Fix various ldb attribute that need to be converted to string
o dict has no 'has_key' method
o ndr_unpack needs bytes not string
o b64encode needs bytes (so open file with binary mode)
o StandardError was removed in python3 use Exception instead
o fix octal literals
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f94a81379666db7145ae0495bf16fb4f95c6cb31">f94a8137</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting: Py2/Py3 for samba4.blackbox.upgradeprovision.alpha13

fixup source4/scripting/bin/samba_upgradedns
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1a4e95da2b57c43c89a08aae18765ebf5a7f0f88">1a4e95da</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting/bin: PY3 make sure GUID result of format is string

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c377bcd487c59555633041624683a3c958897dbc">c377bcd4</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting/bin: PY3 fix samba4.blackbox.upgradeprovision.alpha13
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/60e7aa86d8777a4f5d61f45686ec8cda3a59ea99">60e7aa86</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting/bin: blobs needs to be bytes

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b142e28e35628fb815cdb16830b12c77d5142455">b142e28e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: PY3 fix samba4.blackbox.upgradeprovision.release-4-0-0

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/55f51476ac6ed9a653bd9e9695b1dc4783b32ce3">55f51476</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/filter: PY3 Make filter-subunit forgiving of decoding errors

samba4.local.ndr for one is a test that outputs string in an encoding
that stdin.readline() guesses to be utf8 (but it isn't) filter subunit
can afford to be forgiving of some random text that can't be decoded as
utf8 so lets do that.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7562a5518fe8ea49991ca0af8b977f7b9940d014">7562a551</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: PY3 Fix error in samba4.blackbox.schemaupgrade

Getting Exception: must be str, not ldb.bytes error in scheme_upgrade
phase of test
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/09f6b86403cdb8cee3d999dfac1455bb87a4bdac">09f6b864</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: PY3 port samba4.blackbox.functionalprep

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7aa40311d737d6ac90503b835280af6dcd85e026">7aa40311</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: PY3 fix samba.tests.domain_backup_offline

Fix attributes that need to be treated as str not bytes

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a114ff2182a7de1a49416136b2b8e9280f7768da">a114ff21</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/samba3: PY3 tdb.Tdb.get method expects bytes in PY3

part of PY3 port samba4.blackbox.upgrade.samba3-upgrade*

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2c0f7f07c60209cd3e32b9f17737e72fcc02fdc9">2c0f7f07</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: PY3 make sure get_testparm_var returns 'str'

part of PY3 port samba4.blackbox.upgrade.samba3-upgrade*

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/86e22c060655bde73b24223e790bd27c5fd4afe7">86e22c06</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/provision: PY3 port samba4.blackbox.provision-backend

Fix some attibrutes that need to be treated as str

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cf38a067e8b1a3308c2c11dbecae8efbc7be02ba">cf38a067</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: PY3 port samba4.blackbox.provision-backend

convert ldif content to str when necessary

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c11e90a123fce5cf8d29d59ae96dfc84d5ce0d04">c11e90a1</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/provision: PY3 PY3 port samba4.blackbox.provision-backend

Enclose filter with list as filter object has no 'len' method

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/25b16fa0649579f17789e4f06e40b840d77942aa">25b16fa0</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: PY3 fix CI error for samba.tests.samba_tool.help

Strangely the test was failing on CI only, looks like there is an
issue with order of elements returned from dict.items() with python3.4
(version of python in CI docker instance) and python3.6 (version on my
development machine). Changed code to sort the keys so order of help
printed out should be the same for each invocation.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8b5dd954460cccc7f482e9988b6f13e84a60e9c">f8b5dd95</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script: Add new (temporary) autobuild task for none-env tests.

Ideally we want all the tests to run under python3 by default (no
special task for this) and then convert the existing '-py3' tasks
to run the python tests with python3.
However at the moment the convertion process is not ready to do this,
for a while we need to run separate autobuild tasks for this.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8ba6bb59c159bf1ac5aab4be1939e7d0657ae4cb">8ba6bb59</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T03:50:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add new CI job for new purepy3-none-env autobuild task

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d3571415469ece5341a330c8987139d0f5749e52">d3571415</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-10-23T07:10:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CI/Autobuild: Remove samba-none-env-py3 test

We now run a purepython3 none-env test, later when the whole
build is running under python3 we will resurrect this job
but as (samba-none-env-py2) for python2

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Oct 23 09:10:22 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ec209d28a2cd2f00546035ac6aa2fa4e14068570">ec209d28</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-25T15:58:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Avoid casts

We have %PRIu32 and %zu these days

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c37bf2f93852780113ab882f14a099aeb204c458">c37bf2f9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-25T15:58:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Use explicit initialization

Let the compiler figure out the optimal code

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a895cc2a59a1fc87dc2d824185713d7af11aa879">a895cc2a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-25T15:58:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Fix a typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8df11518c0df90aa0c223b2e964fc86015f77e2c">8df11518</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-25T15:58:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Remove "USE_RIGHT_MERGES" code

This has not been activated by default for ages and can be very
inefficient. With check_merge_with_left_record() we have an
alternative that will merge freelist records while we walk it
anyway. This has reduced fragmentation significantly

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/afc616b67b9f0cd6b535cb12d20f4752e7c4ade9">afc616b6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-25T15:58:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdbtorture: No transaction with mutexes

Right now we don't do transactions with mutexed tdbs. tdbtorture -m
locks up. I haven't really investigated why that is the case. The lockup
confused me quite a bit until I figured out it works fine as long as it
does not do transactions, which is all we need right now.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e2d9abd4212903bf1cbae0f49fc96e6d3a0ee530">e2d9abd4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-25T15:58:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdbtorture: Align integer types

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/34b0f41cda5ef856f074c67de906d7541a1dbfff">34b0f41c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-25T15:58:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Replace some GUID_string by GUID_buf_string

It's only debug statements, but I would like to promote the
stack-allocation routines as good practice where they make sense.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/74de5a5d25e4dc767875ff5a2c66fe3ba313c8bb">74de5a5d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-25T15:58:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Avoid an "includes.h"

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/05954fce4265bab68d78bb335e5b8d63259ce9f4">05954fce</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-25T15:58:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Slightly optimize delay_rename_for_lease_break

Do the checks with increasing cost, possibly avoid more expensive ones

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a03804c4fcd47ef7c077864c2c469396645ebd7a">a03804c4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-25T19:44:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Move a variable declaration closer to its use

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Oct 25 21:44:17 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b3e913ed74c3b794e7cc0c909f18eaaae92398ce">b3e913ed</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/unix: fix spelling and import of text_type

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3f56dc1a1fa59334f37ce0ab372278094624eaee">3f56dc1a</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/gpo: import what we need (errno, not gp_log)

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2ce9890126332d89c4af46157b4793ca6dc12199">2ce98901</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/__init__: import what we need

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/24a3acb248e7f886e9024d6d423d259d16babb63">24a3acb2</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool drs: remove duplicate and unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ca40183d0c552e601c69b427470403302cd2bd3d">ca40183d</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool ldapcmp: remove unused import

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c3b53264cc560789d243be51fa8df406085f09b5">c3b53264</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool user: remove unused import

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fe6daff22a3f39c4ded9be109c8ed384ab8bc5de">fe6daff2</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool domain: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/db6ab2cf6f19b5f3bd656a2bece73960368cf5d2">db6ab2cf</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/domain_update: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/daea7c1b2c2f0fe2d231823471a3925dd903b6b4">daea7c1b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/forest_update: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/74a5448bd0464173353971ac158c732a46006649">74a5448b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/gp_ext_loader: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8519502cb589e0feb270cd15d0b1413690507eb2">8519502c</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/ntacls: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9d24ded27da4675092740ef59f9c293be8e5a435">9d24ded2</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/schema: remove unused import

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1ecdde4f102711d0faec31047fec58d2e930595b">1ecdde4f</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/gp_parse/gp_pol: remove unused import

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f5df55d24412fda9f3d85b82da0a62ab8c86b9f1">f5df55d2</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/provision: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/018c0138c224dc3aa3782dfaed9080d9f25fc578">018c0138</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/dns*: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c18c3738a2e104b0bdf5eb99e8edb188e1f7172">0c18c373</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/dsdb_schema_attr: remove unused/duplicate imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4fc99a04d21b950ed7bd8b8cf27303759f29b92f">4fc99a04</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/getdcname: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eac85232e2dafdcc579174b184ef42db191e167c">eac85232</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/netbios: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b9161e52605b7ad1595ed13f3b7f48145b1d3d25">b9161e52</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/*: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/135a3c2944f140c5c2e2a996df12942f6eda7994">135a3c29</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/samdb: avoid useless local variable

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/68b284f690d550f1772eb6111387b515ddfea138">68b284f6</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5773290a6f011b5a3408c6f34f791cebfb4bfac2">5773290a</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script/generate_param.py: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd99bfd866ad5b00caec6085094cd6ef4d40a23d">dd99bfd8</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wintest/test-s3: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b88685f6baa15221378c579c8dfded9505fa351">6b88685f</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb-samba/tests/match-rules: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eef11c4479510f992d6a6dee1f3173d592183740">eef11c44</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb/tests/_ldb_text: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/02ed259942bdc70d47b09adc31b7658c023b06cd">02ed2599</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc/test/pytalloc: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87272cf17e506e601daab4b632bf527e58939274">87272cf1</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb/test/_tdbtext: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cb2c5843bc2c2eac8250588a0d29c0532d784eea">cb2c5843</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/blackbox/py: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff1bff9e8ba40cdbbbdf5489b3dcad34883f0192">ff1bff9e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py/tests: remove unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/742c786d74a70852d10dc025ff42899257127783">742c786d</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/pytest/dirsync: do not double import

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/682b223d8383e89bb9656ca7d60d68a6adc59e2a">682b223d</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/pytest/dsdb_schema_info: do not double import

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/86aca4dbf8e5f20d45b10eae52a6278cca2d3364">86aca4db</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/pytest/: unused imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3d5ba7fcfa093f96c883bb99ca218857ba0def8b">3d5ba7fc</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/cred/tests/bind: remove unused import

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da9fe70da7a166b65d7789ef357f27d94bfc15e8">da9fe70d</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: samba.getopt is not used here

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e9a57a5b014eaa41a2ac6405b10e37313341d26a">e9a57a5b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting/pfm_verify: remove duplicate import

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b90b2fcda81449f653f90d5f96ce8c1a603f251a">b90b2fcd</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/kcc.graph: avoid import *

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bbf1740b33d133ace54258122ad858c5f275046e">bbf1740b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/kcc_*: avoid * imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aff2afd46ef92b8733185a3b02ef0fec54b9c4fe">aff2afd4</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/perftests: avoid import *

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c9c3a9ce9136e0318a127470b6e234948ce2e2ce">c9c3a9ce</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/common: avoid import *

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8818b21ea544e675a6922ee896fb8d2258017168">8818b21e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/tests.py: avoid import *

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f7247d84699519a5817de5c498058a844b4536e">9f7247d8</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/selftest/tests: don't use import *

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/91bab6f8980433aa4ddefe1b264264723ee3daf2">91bab6f8</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest/tests: don't use import *

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a1450f2c0fc280c3d01b46333546955cfd9261b7">a1450f2c</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pytest/dcerpc.integer: force py2 long int without incompatible syntax

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2412ca517da36e660c685a8ac001118775672a52">2412ca51</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python tests: always use Python's unicodedata

We had our own special version with very few entries, but only
used it in one place.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bc8201bdf46f487e88812e6adc7b3d2d66a2c900">bc8201bd</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool ldapcmp: use ValueError, not obsolete StandardError

The error is in the value, and StandardError is not in Python 3

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/71825bc9aacc05b14b303c6fa92a1dc127666bd1">71825bc9</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/common: py3 compat raw_input

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d6072cbf9808723e1054f3533371aac078a6dd08">d6072cbf</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/remove_dc: use a local variable in offline_remove_server

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/159fdcb6010020b06e5a55b66c3e72071183152d">159fdcb6</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/kcc: use compat.cmp_fn (PY3)

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cd5ac17654467531e2dde85a738c5a170277f841">cd5ac176</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script/show_test_time: approach python 3 compatibility

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/41844d13fe9c5749b04dc5fede0b9f4fcc0d8df2">41844d13</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/pytests: Py3 compatitble except clauses

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d121c68a4b27314f8eb4ed1da7ed24f72cd8e814">d121c68a</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/pytest/ad_dc_medley: do not use xrange

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4fdccc0d35f0d009e07a9b08edc34dc0fb37c89c">4fdccc0d</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/pytest/sort: use compat.cmp_fn instead of cmp

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6ab7a3beb36b9b5e4f2e24835558ddcf765aafae">6ab7a3be</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting: py3 style 0o123 octal, not 0123

this works with py2.6+ too.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/105e14cbd1865578bdaad150f2254ceed88abab1">105e14cb</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting/demodirsync: fix syntax error

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bab4f3a129eac6d701112968e63f195407583f28">bab4f3a1</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/gp_parse/gp_inf: remove shadowed method

The 'from_xml()' definition is replaced a few lines down

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f12fd900db6e761bf4faf9f6c24c335b97830849">f12fd900</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/gp_parse/gp_inf: remove unused variables

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/03f45656fd298a7569a08ab4bb7feaff36780a39">03f45656</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/lsa_string: remove duplicate method

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d042a300391478b72c763bd2e16228ba8a75c266">d042a300</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/kcc_utils: disambiguate/unshadow a test

Pair-programmed-with: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d2fadfd6e45de60ef78e29a9dd359ff3f3bfe778">d2fadfd6</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb/tests/py/api: reveal shadowed casefold test

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/311727947799e896e05d644103c9db80a665de88">31172794</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/pytest/ldap_schema: remove duplicate test

The tests differ in two lines, thus:

     def test_subClassOf(self):
     -        """ Testing usage of custom child schamaClass
     +        """ Testing usage of custom child classSchema

[...]

   -governsId: 1.3.6.1.4.1.7165.4.6.2.6.3.""" + str(random.randint(1, 100000)) + """
   +governsId: 1.3.6.1.4.1.7165.4.6.2.6.7.""" + str(random.randint(1, 100000)) + """

with the governsId OID changed because it was noticed they were colliding.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99be8e9871c8730ef71f4ac18133003d221f8b22">99be8e98</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/raw_protocol: reveal shadowed test via disambiguation

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/add4068fb79c0459e94edcc7fd001adc514509cb">add4068f</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool tests: fix bytes/str issue in masked test

This test will be revealed to the world in the next commit.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/654cc08cf0e31478463bb4bfdc95623a990ac88d">654cc08c</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T19:45:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/ou: unshadow a test

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/adf73d34a3e51c2a3ce93f144cd898423e190236">adf73d34</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-25T22:50:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pytests/samba3sam: unshadow and fix a search_non_mapped test

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>

Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Fri Oct 26 00:50:37 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/525b19fafb43bd97e3dfc1d3e7dc13955c0f387f">525b19fa</a></strong>
<div>
<span>by Christian Ambach</span>
<i>at 2018-10-26T04:59:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:script/tests reduce code duplication

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b89732c31be350828110fe46f2c655f77cb488f3">b89732c3</a></strong>
<div>
<span>by Christian Ambach</span>
<i>at 2018-10-26T04:59:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils/smbget add error handling for mkdir() calls

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fce0d1b290c7a2205f2454b268b55909d1044f1b">fce0d1b2</a></strong>
<div>
<span>by Christian Ambach</span>
<i>at 2018-10-26T07:58:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils/smbget fix recursive download with empty source directories

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13199
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Oct 26 09:58:07 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ec4b2ac5126a89a3b0bb37886d127616ba8669b7">ec4b2ac5</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-10-27T19:24:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:selftest: Fix test names of smbtorture_s3.plain

The env name will be appended. There is no need to have it twice. Can't
we remove the tests againa ad_dc_ntvfs completely?

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4db918b44d8779af7c6738537cf7cce3a240b41b">4db918b4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-10-27T19:24:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:torture: Don't use the same testdir twice

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d48a2bc376a36b1ee00ed929c2317d72c96e3ee5">d48a2bc3</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-10-27T19:24:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:torture: Rename the test file and remove it if it exists

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/94f8a690f66718f14e3bddab40215d1d4ce72cfb">94f8a690</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-27T19:24:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove unused tdb_trans_* functions

The transactions have all moved to dbwrap

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5391e21dea3168691cee1e6ef6c5959e46d62d1e">5391e21d</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2018-10-27T22:35:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:socket: If returning early, set ifaces

Prevents a segfault in load_interfaces() when total interfaces == 1.
Fixes regression caused by da68a1b2f417ec82ea4ed3e7a4d867cef8ca8f93.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13665

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Ralph Böhme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sun Oct 28 00:35:35 CEST 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba17cae4cab686b8d018c39d16706e621f9f93ac">ba17cae4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-10-29T19:09:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Check return code of initialize_password_db()

See https://retrace.fedoraproject.org/faf/reports/1577174/

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13668

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0b60afec7b6c21df58a8efa2c54f033badb4cd7e">0b60afec</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-29T19:09:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samdb: properly use property()

Python's property() function works like this:

property([getter[, setter[, delete[, doc]]]])

but we have been forgetting the delete function, or rather setting it
to be a string. A string is not callable and is unlikely to succeed at
deleting the property.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b37f8f88eaf26a4d12fe9728e09aed68ddaaf1c0">b37f8f88</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-10-29T22:13:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: do not use "is" for string equality

This is not always going to work, and is not guaranteed to be
consistent even between minor versions.

Here is a simple counterexample:

>>> a = 'hello'
>>> a is 'hello'
True
>>> a is 'hello'.lower()
False
>>> a == a.lower()
True

Possibly it always works for the empty string, but we cannot rely
on that.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Oct 29 23:13:36 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d565f636fcf49fc1bbbfbc24ef730d2f7cc2cf0">5d565f63</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-29T22:36:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: remove check for number of xattrs from ad_convert_xattr

Turns out that there exist AppleDouble files with an extended FinderInfo
entry that includes the xattr marshall buffer, but the count of xattrs
in the buffer is just zero.

We do want to discard this extended FinderInfo entry and convert it to a
simple fixed size FinderInfo entry, so remove the check.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/14abead3ca13923c6ec7951afb18b97fabeee9f1">14abead3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-29T22:36:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Fix a typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c18e2ed00f199a6c48d3e9c9dd7213b723e80f5b">c18e2ed0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-29T22:36:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Align an integer type

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/96f6768e05493bc47431fb954335349f56af822e">96f6768e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-29T22:36:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Don't delete dead records in traverse

The next commit will change the handling of dead records, removing the
"tdb_do_delete" function. As traverses should not happen in normal
operations, dead records from them should be rare, and relying on
traverses to remove them is a very bad idea IMHO.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4ed2a67a59d826292e7d4d6991942b4cc15d72dc">4ed2a67a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-29T22:36:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Purge dead records whenever we block the freelist

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/05212658baef695448a22f43250c1268fe3310e3">05212658</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-29T22:36:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Do early RDONLY error check for tdb_delete

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/500a729a5566a1c8afc36e6f3e73910b13c8b9ad">500a729a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-10-30T01:48:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Make record deletion circular-chain safe

Before this patch we had 3 loops walking a hash chain to delete
records:

tdb_do_delete() to find the predecessor of the record that was to be
deleted. tdb_count_dead(), the name says it all and tdb_purge_dead()
to give back all dead records from a chain to the freelist.

This patch introduces tdb_trim_dead that walks a hash chain just
once. While it does so it counts the number of dead records, and all
records beyond tdb->max_dead_records are moved to the freelist.

Normal record deletion now works by always marking a record as dead in
step 1 and then calling tdb_trim_dead. This is made safe against
circular chains by doing the slow chain walk only in the case when we
did not delete a dead record during our walk.

It changes our dynamics a bit:

When deleting a record with non-zero max_dead_records, now we always
leave that number of records around when deleting, doing a blocking
lock on the freelist when we found too many dead records.

Previously when exceeding max_dead_records we wiped all dead records
to start accumulating them from scratch, assuming we could lock the
freelist in a nonblocking fashion.

The net effect for an uncontended freelist is the same: In
tdb_allocate() we still completely hand over all dead records to the
freelist when we could lock it, it just happens later than without
this patch.

This means for a lightly loaded system we will potentially leave more
dead records around in databases like locking.tdb. However, on a
heavily loaded system we become more predictable: If the freelist is
so heavily contended that across many deletes we can't get hold of it,
previously we accumulated more dead records than max_dead_records
would allow. This is a really lowlevel tradeoff that is likely hard to
measure, but to me becoming more deterministic without sacrificing too
much parallelism (we keep more dead records around) is worth trying.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Oct 30 02:48:38 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0189f23f5bda263c7462366ee16b2fe4bcda0119">0189f23f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-30T06:30:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">schema_samba4.ldif: add allocation of DSDB_CONTROL_DBCHECK_FIX_LINK_DN_NAME

This was already allocated in source4/dsdb/samdb/samdb.h with
commit 22208f52e6096fbe9413b8ff339d9446851e0874.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/60131b4452d43b3792e7f27a4190c88e7aabb1b4">60131b44</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-30T06:30:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:dsdb: fix comment on DSDB_CONTROL_DBCHECK_FIX_LINK_DN_NAME

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/364ed537e0bcb3a97cae0f2d1ff72de9423ce0e6">364ed537</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-30T06:30:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs/blackbox: add samba4.blackbox.test_primary_group test

This demonstrates the bug, that happens when the primaryGroupID
of a user is changed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bb9c9e49a5e82f19626cb1b12ec9189fff5114e8">bb9c9e49</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-30T06:30:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:dsdb: add DSDB_CONTROL_DBCHECK_FIX_LINK_DN_SID oid

This will be used to fix missing <SID=> components in future.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c5c99b569569ce36cac94e967ca53e3182abd6f7">c5c99b56</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-30T06:30:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbchecker: improve verbose output of do_modify()

This makes it easier to debug dbcheck problems.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a801799ebe26780653f4ed3fa3fc633e31871f7d">a801799e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-30T06:30:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbchecker: Fix missing <SID=...> on linked attributes

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f81771c8593327e058b9cb4330d7e77083df3ea9">f81771c8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-30T06:30:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">blackbox/dbcheck-links: Test broken links with missing <SID=...> on linked attributes

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/966c7febaf0245516481bde924ea6cd738eeb78b">966c7feb</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-30T06:30:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:repl_meta_data: pass down struct replmd_replicated_request to replmd_modify_handle_linked_attribs()

This will simplify further changes.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/42e69a86ca583e3cb20c63b9c6930b4b3425485d">42e69a86</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-30T06:30:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:repl_meta_data: pass down struct replmd_replicated_request to replmd_modify_la_add()

This will simplify further changes.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70a306d0bd6806d1fd00d45e3d8cc70c73d09f79">70a306d0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-30T06:30:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:repl_meta_data: add missing \n to a DEBUG message in replmd_modify_la_add()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/738b52eb0856c8fcdbb8589e8061bcc14700c23a">738b52eb</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-30T06:30:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:repl_meta_data: pass down struct replmd_replicated_request to replmd_modify_la_delete()

This will simplify further changes.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1ef145d9d72d847055f6aba8a0070b3e1cfdabbc">1ef145d9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-30T06:30:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:repl_meta_data: pass down struct replmd_replicated_request to replmd_modify_la_replace()

This will simplify further changes.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0386307e34097f5d9233c970983c7306d1705a87">0386307e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-30T06:30:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:repl_meta_data: add support for DSDB_CONTROL_DBCHECK_FIX_LINK_DN_SID

This will be used by dbcheck in the next commits.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a36cb30b716d56b84e894851c1a18e9eb3a0964">7a36cb30</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-10-30T06:30:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:samldb: internally use extended dns while changing the primaryGroupID field

This is important, otherwise we'll loose the <SID=> component of the
linked attribute.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/852e1db12b0afa04a738c03bb2609c084fe96a7f">852e1db1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-10-30T09:32:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Add comments explaining the limitations of our current backlink behaviour

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13418

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Tim Beale <timbeale@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Oct 30 10:32:51 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eeb4089dafc45277d8af19073ef9348451c1836a">eeb4089d</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-10-30T15:40:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb group_audit: Test to replicate BUG 13664

The group audit code incorrectly logs member additions and deletions.

Thanks to metze for the debugging that isolated the issue, and for
suggesting the fix to dn_compare.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13664

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8420a4d0fddd71af608635a707ef20f37fa9b627">8420a4d0</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-10-30T15:40:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb group audit: align dn_compare with memcmp

Rename the parameter names and adjust the  return codes from dn_compare
so that:
dn_compare(a, b) =>

LESS_THAN means a is less than b.
GREATER_THAN means a is greater than b.

Thanks to metze for suggesting the correct semantics for dn_compare

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13664

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e2970887140d558c6359fd9b3f8c2a4c26d2cf35">e2970887</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-10-30T15:40:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb group audit tests: check_timestamp improve diagnostics

Change check_timestamp to display the expected, actual along with the
line and name of the failing test, rather than the line in
check_timestamp.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c952fc1273397c04fddf177bcd809551d6324bdd">c952fc12</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-10-30T15:40:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb group audit tests: check_version improve diagnostics

Change check_version to display the expected, actual along with the
line and name of the failing test, rather than the line in check_version

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aeef8b41fa03a32859f824f4a09560ad83bd2b50">aeef8b41</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-10-30T19:20:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb group audit tests: log_membership_changes extra tests

Add extra tests to ensure better test coverage of log_membership_changes

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Oct 30 20:20:26 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b40daca6d4c886f2cea5efce38a5e945410d65d8">b40daca6</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-10-30T23:30:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Generate users faster by writing to local DB

We can create user accounts much faster if the LDB connection talks
directly to the local sam.ldb file rather than going via LDAP. This
patch allows the 'host' argument to the tool to be a .ldb file (e.g.
"/usr/local/samba/private/sam.ldb") instead of a server name/IP.

In most cases, the traffic_replay tool wants to run on a remote device
(because the point of it is to send traffic to the DC). However, the
--generate-users-only is one case where the tool can be run locally,
directly on the test DC. (The traffic_replay user generation is handy
for standalone testing, because it also handles assigning group
memberships to the generated user accounts).

Note that you also need to use '--option="ldb:nosync = true"' to get
the improvement in performance.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4943473102883245fb2c286dfebe8a685d5b2026">49434731</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-10-30T23:30:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Change print() to use logger()

This reduces noise, so the messages only come out if you specify
--debug.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a8a0ab32be3372888b02a4f0632246e483aa491">4a8a0ab3</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-10-30T23:30:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: logger was ignoring smb.conf log-level

We were trying to access the debug-level (in python C bindings) before
the smb.conf had been loaded and actually set the debug-level. So it
would default to zero, regardless of what was in the smb.conf.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5a57378d342e690c8736877fb481ef34b27d4ea4">5a57378d</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-10-30T23:30:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Add backend-store option to domain backup/rename cmds

Currently the online/rename backup files always use the default backend
(TDB) and there is no way to change this.

This patch adds the backend-store option to the backup commands so that
you can create a backup with an MDB backend, if needed.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9a65adb023bde5567152101a7244968284b57d9">a9a65adb</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-10-30T23:30:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Specify different DB backends for restored testenvs

Vary the DB backend that we use for the renamed DCs. The labdc and
renamedc are fairly similar, so let's have each of them use a different
backend.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ca570bd4827aa8f61ceb137fbe748ac2f7929c44">ca570bd4</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-10-30T23:30:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Include num-members in 'samba-tool group list --verbose'

This adds an easy way for users to see (via samba-tool) how many members
are in various groups, without querying the members for each individual
group.

For example, you could pipe this output to grep to check for groups with
zero or one members (i.e. historic groups that may no longer make
sense).

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c910245fca70948a33eda99c9bc198d8b34675f">0c910245</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-10-31T02:40:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Add 'samba-tool group stats' command

With large domains it's hard to get an idea of how many groups there
are, and how many users are in each group, on average. However, this
could have a big impact on whether a problem can be reproduced or not.

This patch dumps out some summary information so that you can get a
quick idea of how big the groups are.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Wed Oct 31 03:40:41 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bda98b38464458a513148f0bf356d9f2150c1607">bda98b38</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-10-31T20:27:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Update nss_wrapper to version 1.1.5

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a4c1888a9c2d3b5797902adcf519855204ebe24">9a4c1888</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: remove "0x" string prefix from dev/ino

We used %llu as conversion specifier which results in a decimal number
being printed, so remove the misleading "0x" prefix.

While at it, I'll change %llu to the terse %ju.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f7a98094f05dd4b9abf5dc9704222aa5a07584d4">f7a98094</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs:vfs_fruit: add "wipe_intentionally_left_blank_rfork" option

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13642

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a9574b138f620e0a65cd61a957b99653c8dcd78">2a9574b1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs:vfs_fruit: add "delete_empty_adfiles" option

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13642

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c3a1f3ec9ba2402de2a876ca06086b2d53e122f0">c3a1f3ec</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:selftest: list vfs testssuites one per line

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13642

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f022e61597994bc032e61876f24150d7acb3fc2">6f022e61</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: add test for AppleDouble ResourceFork conversion

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13642

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2dbb2d287399e9c829a4fd4908a6dfba9fdfd7e8">2dbb2d28</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: add option "wipe_intentionally_left_blank_rfork"

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13642

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7be979f958295474f0c0df6a4db0b5bca9a6676d">7be979f9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: detect empty resource forks in ad_convert()

For some reason the macOS client often writes AppleDouble files with a
non-zero sized resource fork, but the resource fork data is just
boilerplate data with the following string close to the start

  This resource fork intentionally left blank

A dump with apple_dump looks like this:

Entry ID   : 00000002 : Resource Fork
Offset     : 00000052 : 82
Length     : 0000011E : 286

-RAW DUMP--:  0  1  2  3  4  5  6  7  8  9  A  B  C  D  E  F : (ASCII)
00000000   : 00 00 01 00 00 00 01 00 00 00 00 00 00 00 00 1E : ................
00000010   : 54 68 69 73 20 72 65 73 6F 75 72 63 65 20 66 6F : This resource fo
00000020   : 72 6B 20 69 6E 74 65 6E 74 69 6F 6E 61 6C 6C 79 : rk intentionally
00000030   : 20 6C 65 66 74 20 62 6C 61 6E 6B 20 20 20 00 00 :  left blank   ..
00000040   : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
00000050   : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
00000060   : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
00000070   : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
00000080   : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
00000090   : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
000000A0   : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
000000B0   : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
000000C0   : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
000000D0   : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
000000E0   : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
000000F0   : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : ................
00000100   : 00 00 01 00 00 00 01 00 00 00 00 00 00 00 00 1E : ................
00000110   : 00 00 00 00 00 00 00 00 00 1C 00 1E FF FF       : ..............

We can safely discard this Resource Fork data.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13642

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e00e61345ccd88022cd24e62ac29e2c56a8f6117">e00e6134</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: add option "delete_empty_adfiles"

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13642

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3649f1a41a299b14609318ef52b44e2d53cba4b5">3649f1a4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: optionally delete AppleDouble files without Resourcefork data

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13642

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f58997d7a1ab0358963a45cb8bf291e7afa8068">9f58997d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_streams_xattr: fix open implementation

Since a long time the modules's open function happily returned success
when opening a non existent stream without O_CREAT.

This change fixes it to return -1 and errno=ENOATTR if

o get_ea_value() returns NT_STATUS_NOT_FOUND (eg mapped from
  getxattr() = -1, errno=ENOATTR) and

o flags doesn't contain O_CREAT

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/242f42ef79e51e35ab33331e2f2d7c9feaac36f8">242f42ef</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: skip a few tests when running against a macOS SMB server

These tests are designed to test specific vfs_fruit functionality.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/394d1fc9ac8373ea7419ea9514750422bd6e504d">394d1fc9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: fix a few error checks in "delete AFP_AfpInfo by writing all 0"

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d4e50649b02c7c2314aa04e08f9946e21b6b37d">1d4e5064</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: set share_access to NTCREATEX_SHARE_ACCESS_MASK in check_stream_list

Avoid sharing conflicts with other opens on the basefile.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dba9a4743fc42b57f03b6ace24753ce8091f629f">dba9a474</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: update test "SMB2/CREATE context AAPL" to work against macOS

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/125498861abeeed5bde727ff98d88d9ce4af6c75">12549886</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: update test "stream names" to work with macOS

o create the basefile before trying to create a stream on it, otherwise
  this fails on macOS

o write something to the stream, otherwise the stream is not listed as
  macOS hides 0-byte sized streams

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f7551d8fb3599a6a71dd0570bad02bdc48324107">f7551d8f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: ensure a directory handle is closed in all code paths

Otherwise we get a sharing violation when running against Samba and
opening the directory a second time.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9cd9859dc10d425d29774d221ec9ad697192b466">9cd9859d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: update test "read open rsrc after rename" to work with macOS

macOS SMB server seems to return NT_STATUS_SHARING_VIOLATION in this
case while Windows 2016 returns NT_STATUS_ACCESS_DENIED.

Lets stick with the Windows error code for now in the Samba fileserver,
but let the test pass against macOS.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0d9a80b6b2e3f51cad122ee0dc78c2f4dfdebcb5">0d9a80b6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: expand existing test "setinfo delete-on-close AFP_AfpInfo" a little bit

Add a check that verifies a create on a stream gets
NT_STATUS_DELETE_PENDING after delete-on-close has been set.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f428607e35055b9ce1a04a625d43740bf5c76b2">6f428607</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: expand existing vfs_test "null afpinfo"

This adds a check that a read on a seperate handle also sees the
previously created AFP_AfpInfo stream.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c3cf09a0791ed4dfb7ca18d175396ac1aca5d2ed">c3cf09a0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: update test "creating rsrc with read-only access" for newer macOS versions

While this operation failed against older macOS versions, it passes
against versions 10.12 and newer. Update the test accordingly, a
subsequent commit will then update our implementation.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/055ca448f1a2bd995291af1810c9ec94f90f32dd">055ca448</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: update handling of read-only creation of resource fork

macOS SMB server versions supports this since 10.12, so we adapt our
behaviour.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b35d9e74028727da24f349242cb0bc62403a9b09">b35d9e74</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: expand test "setinfo eof stream"

o Adds checks verifying that after setting eof to 0 on a stream, a
  subsequent open gets ENOENT, before and after closing the handle that
  had been used to set eof to 0.

o Verify that a write to a handle succeeds after that handle has been
  used to set eof to 0 on a stream.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3195ff9547824dd129e3fbcbbb8823fb10a0a5d4">3195ff95</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: write some data to a just created teststream

Doesn't currently make a difference, but this prepares for a later
change in vfs_fruit that will filter out empty streams (which is the
macOS behaviour).

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/287082d739362ad068df37076712927ccd7ca90c">287082d7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: don't unlink 0-byte size truncated streams

This caused all sort of havoc with subsequent SMB request that acted on
the handle of the then deleted backend storage (file or blob, depending
on the used streams module).

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7485007bb0a69dc8237c78be90f4bae06aad49b2">7485007b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: enable AAPL extensions in a bunch of tests

These tests check for macOS SMB server specific behaviour. They work
currently against Samba without enabling AAPL because in vfs_fruit we're
currently don't check whether AAPL has been negotiated in one place. A
subsequent commit will change that and this commit prepares for that
change.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/046456fca60b9fef38a0cdf5a116883fb1c7dffe">046456fc</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: use check on global_fruit_config.nego_aapl for macOS specific behaviour

Ensure any non MS compliant protocol behaviour targetted at supporting
macOS clients are only effective if the client negotiated AAPL.

Currently this only guards the resource fork which only macOS client are
going to use, but subsequent commits add more this at this place.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ebfcf75e993b1a792db76b94aa898532e1c81eeb">ebfcf75e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: filter empty streams

First step in achieving macOS compliant behaviour wrt to empty streams:
- hide empty streams in streaminfo
- prevent opens of empty streams

This means that we may carry 0-byte sized streams in our streams
backend, but this shouldn't really hurt.

The previous attempt of deleting the streams when an SMB setinfo eof to
0 request came in, turned out be a road into desaster.

We could set delete-on-close on the stream, but that means we'd have to
check for it for every write on a stream and checking the
delete-on-close bits requires fetching the locking.tdb record, so this
is expensive and I'd like to avoid that overhead.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/64b28e4a94365092f46052712a38e6fcfbb9f20c">64b28e4a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/util: add torture_smb2_open()

This seems to be missing: a simple wrapper to just open a file without
fancy options.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aba502d440ae3478543d3be5c5bbcea39fb0a463">aba502d4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: add check_stream_list_handle()

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9d8751db64de75a0de442365b317c1b9ce194170">9d8751db</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: add test "empty_stream"

One to rule them all: consistently test critical operations on all
streams relevant to macOS clients: the FinderInfo stream, the Resource
Fork stream and an arbitrary stream that macOS maps to xattrs when
written to on a macOS SMB server.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/993c7c4e711612225bd07b8fa5544c4bfef88a9e">993c7c4e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: add some debugging of dev/ino

Aids in debugging dev/ino mismatch failures in open_file_ntcreate.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a26032c3f68028b01fb6a7d38851409db1858161">a26032c3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: remove resource fork special casing

Directly unlinking a file with open handles is not good, don't do it.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1e055a79541eb69eb2deeae897dde3665c5ffee2">1e055a79</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: add fio->created

fio->created tracks whether a create created a stream.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/96320eccc9a63b793ff8d05842bce54f120286f9">96320ecc</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: prepare struct fio for fake-fd and on-demand opening

Not used for now, that comes in the subsequent commits.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a5c9a9e73230f640eb045a3c47af75b5be9f1d6">4a5c9a9e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: prepare fruit_pwrite_meta() for on-demand opening and writing

This avoid creating files or blobs in our streams backend when a client
creates a stream but hasn't written anything yet. This is the only sane
way to implement the following semantics:

* client 1: create stream "file:foo"

* client 2: open stream "file:foo"

The second operation of client 2 must fail with NT_STATUS_NOT_FOUND.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d7d92710711f6e555ed45c1dda528cd6a83e1bf5">d7d92710</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: prepare fruit_pread_meta() for reading on fake-fd

If the read on the stream fails we may have hit a handle on a just
created stream (fio->created=true) with no data written yet.

If that's the case return an empty initialized FinderInfo blob.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/80afafe398566fd622f431966808d08ba9ec6473">80afafe3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: do ino calculation

As we'll start returning fake fds in open shortly, we can't rely on the
next module to calculat correct inode numbers for streams and must take
over that responsibility.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6fd256afcd5fedc894036efbfba1fc6d2264fba9">6fd256af</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: let fruit handle all aio on the FinderInfo metadata stream

This will be required to support using fake fds for the FinderInfo
metadata stream.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6e13dbddaec9f8118e11309297f85c3cdfd22e43">6e13dbdd</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: pass stream size to delete_invalid_meta_stream()

delete_invalid_meta_stream() is meant to guard against random data being
present in the FinderInfo stream. If the stream size is 0, it's likely a
freshly created stream where no data has been written to yet, so don't
delete it.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/480695cd723cc4949e0b39ddb83560efac393412">480695cd</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: let fruit_pwrite_meta_stream also ftruncate empty FinderInfo

fruit_streaminfo currently filters out the FinderInfo stream is
delete-on-close is set. We set it here internally, but the client may
also set it over SMB. Turns out that the macOS SMB server does NOT
filter out FinderInfo stream with delete-on-close set, so we must change
the way filtering is done in fruit_streaminfo.

Filtering is now done based on the FinderInfo stream being 0-bytes large which
is why I'm adding the ftruncate here.

No idea why the tests that check the filtering passed the commits
leading up to this one, but if you revert this commit after applying the
whole patchset, the "delete AFP_AfpInfo by writing all 0" test will fail.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d8c1bb52018289878b9397d513ebbae63933a05f">d8c1bb52</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-10-31T20:27:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: don't check for delete-on-close on the FinderInfo stream

macOS SMB server doesn't filter out the FinderInfo stream if it has
delete-on-close set.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1b2de44ea8114cf2025e8b8c843131e2f2dbed27">1b2de44e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-01T00:14:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: let fruit_open_meta() with O_CREAT return a fake-fd

This is the final step in implementing the needed macOS semantics on the
FinderInfo stream: as long as the client hasn't written a non-zero
FinderInfo blob to the stream, there mustn't be a visible filesystem
entry for other openers.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Nov  1 01:14:23 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8d14714cc5e4c2b439e973faf602afb2fc1e7488">8d14714c</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-11-01T00:59:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: winbind: Remove fstring from wb_acct_info struct

The group enumeration backend functions try to allocate an array of
wb_acct_info structs with a number of elements equal to the number of
groups. In domains with a large number of groups this allocation may
fail due to the size of the chunk.

Found while trying to enumerate the groups in a domain with more than
700k groups.

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2cfb58d7535e63c5ef9f3970ebaa189741b715cb">2cfb58d7</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2018-11-01T00:59:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: use goto to have only one function return

Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e82b3ac0ae5b50993db3c85d77dd317f957beb7e">e82b3ac0</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2018-11-01T00:59:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: make wb_global_ctx private add add get/put functions to access global context

Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/988182c3b8dab6511c75622e3484c9ef71e6d0db">988182c3</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2018-11-01T00:59:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: protect access to wb_global_ctx by a mutex

This change will make libwbclient thread safe for all API calls not using a
context. Especially there are no more conflicts with threads using nsswitch
and libwbclient in parallel.

Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b5ea7946f844ff6b9337fea57fd002b716595703">b5ea7946</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2018-11-01T00:59:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: add test for parallel NSS & libwbclient calls

Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/40bd0a930b2990a6c4e10a5e0db27608cff198c8">40bd0a93</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-01T04:06:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Run nsswitch thread test

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Nov  1 05:06:23 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/371297a59b2b70cd539b20f7ec55bd53557bb21d">371297a5</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/samba_tool/provision_password_check: follow super inheritance

We were skipping a level in the inheritance chain, which had no effect
in this case (no .setUps or .tearDowns were missed) but it would be
confusing if the parents ever changed.

Note: in python 3, you just call super() with no args, and it works
out the right thing.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99eee0a669e285bfa0a7f385f2a2e7893b6c94df">99eee0a6</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/format_subunit_json: py3 print()

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a6368ae6d4520f6be29068b3d3e6f26f1366f1d8">a6368ae6</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/pytest/ldap_schema: fix typo in docs

Commit 311727947799e896e05d644103c9db80a665de88 removed a duplicate
test but it removed the wrong one, leaving this dreadful typo.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e694079e5f3a662c678cce0e87769c62ddeefeb">4e694079</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/python/notification: safer use of super()

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6c1d605348fde3970ff81804369a17574d7a5564">6c1d6053</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/python/sec_descriptor: safer use of super()

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/853230888324f17513ebe7d9001a87e690e63042">85323088</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/script/depfilter.py: use py3 compatible regex import

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f109fde362c81a9e0e248a244a75a9a7dbaa8f43">f109fde3</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting/autoidl: py3 compatible except

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2e6fccbb93dc7e31fcf1d056e0ac964d0c9f01f8">2e6fccbb</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting/minschema: whitespace reformat and py3 compatible print

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b4fff0ac7d4fd8072d0ed8028b4d4f7a3722ae83">b4fff0ac</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting/samba_upgradedns: avoid .has_key()

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b1ba193dd0afdcf1d7320277527b652fcb762d32">b1ba193d</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting/pfm_verify: PY3: use compat.text_type

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2013cd2889df484efbfb106fea38085bfbb0315c">2013cd28</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script/show_test_time: attempt py3 compat

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2fedb9502238009522cdb12ce6f131f46be82662">2fedb950</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: PY3 Exceptions don't have .message

but str(e) is the same as str(e.message), so we can use that
on 2 and 3.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9057b1c45e66698dd86bc3fd830e6c7533d59c45">9057b1c4</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: fix message formatting

previously these would have raised an exception

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e621472cc89702bd01ad9c88beab0c3986a78d2c">e621472c</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: fix function call (right arguments)

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e25878ecca2d73a75204979e2d53bc766e8b7e4f">e25878ec</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: let self.usage() find argv[0] by itself

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ced6b6c9dd8b1d4952aef5147131b8f485c1410c">ced6b6c9</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool user: fix message format

There were 2 % formats and 3 arguments.
Also reformat for line length

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cf7f14a4be12f2e677d8ce5f2a7b00102f69b87d">cf7f14a4</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/subnets: use the correct variable name

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5304ea44c97507822edac2ccf0ec5a49d0692627">5304ea44</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/dsdb: use correct variable names

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f129ca9892ac8f547ecd60c0b086c925a0890d25">f129ca98</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/dnscmd: don't use undefined name

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fc64f2586dd7b624a19bb5fb6797be19d525ae92">fc64f258</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb/tests/py/api: use proper name for ldb.LdbError

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78ead841bfb8a37d50fbeb186deb6ce529ebeb21">78ead841</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb/tests/py/index: remove dup value in dictionary

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9148ec7d658d306c8d98eb92d918c554adeae165">9148ec7d</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/pytest/sites: do not use variables out of scope

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4be0bcb12bddb0a5d8dedb591f7c1af697fbacf8">4be0bcb1</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python join: use the sd_utils we imported

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7058e21ebecaaf397d4ff502f4ba6bb2e4c0e564">7058e21e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: avoid useless work in dsdb_Dn.__cmp__

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f0c45e0831f502e04e4100d795d0a06ff06eb3fe">f0c45e08</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python dbcheck: use real exception name

and conventional indent

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d9b457941667bf011ab15e33567a6034133e5dde">d9b45794</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Python provision: remove "ExistingBackend"

This was unused and broken. e.g. here:

-    def init(self):
-        # Check to see that this 'existing' LDAP backend in fact exists
-        ldapi_db = Ldb(self.ldapi_uri)

there is no attribute self.ldapi_uri, so this would always raise an
exception.

It was being left around in case it became useful, but that doesn't
seem to be happening.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f6f98ed2d3a436745bc8e3f8131d9b9de4092d4b">f6f98ed2</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">provision: fix string format syntax

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/67c5ab1752eb9e64fd46eb28589af6c9f5546828">67c5ab17</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">provision: fix string formatting (number of args)

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/71f91ccda4867fd2f010be885504146ab334bee6">71f91ccd</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">provision/backend: fix formating syntax

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7db224bdc23122b99cfd632d990e4e153e6be8ab">7db224bd</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">provision/backend: LDAPBackendResult takes no creds

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7fafd57998a19e4d7d92a7aebeb70d69bb427389">7fafd579</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/remove_dc: fix formating syntax (missing %s)

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b1d878f4c11c412af15e53ee41e8a4b2f7f0b02">7b1d878f</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/remove_dc: fix Exception construction

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d4e06603542623045c8811d14d5e25fc434435da">d4e06603</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waflib: add necessary imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aafe6bf96ac9e14b5546c31b51dcfd010b9a5717">aafe6bf9</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waflib: fix syntax error in string format

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c2447e2d8fbc183bc399f7fe1c79bee5e0d96cd">9c2447e2</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py/tests/dcerpc_rpc: Py3 compat integer types

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9055602e639cdc39c71e13c35ca93c9a1b51eb70">9055602e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Exception has no .message

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1a66eeb1242ef6715c362c430e619c015334ced5">1a66eeb1</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/rodc_rwdc: fix message format

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1ca5bf32ad872673c7f2d33c8710238c3a19488b">1ca5bf32</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/kcc/graph: import KCCError, which is used somewhere

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/68a43a189ed3329146ab0f3bed6ae9d27e73ffed">68a43a18</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba3: import passdb in the manner it is used

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/866d5b3cd84359eb3e1a1ab8d28d93c0f4978cf7">866d5b3c</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool rodc: remove unused variable

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/202be5994ef2fe7b79d14830468b1eac005938c3">202be599</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool spn: remove unused variables

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d5f1ea607757967dae136a8148163443c322fd0e">d5f1ea60</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbchecker: remove unused variables

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d7f26be93c640487fed2865561180bf49c1584c2">d7f26be9</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool dbcheck: remove unused variable

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/55aaa9c8498ded15250377f5b1e0c0d4abe1c9a7">55aaa9c8</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/upgradehelpers: remove unused variable

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78f0860cff176d1d5842cb65684a49139c87a4ed">78f0860c</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/xattr: remove unused variable

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cf3d35c8a9604c6b2211d552bc9e02433844ea44">cf3d35c8</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/credentials: remove unused variables

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e37edb7639b7b7ddec0cbed9d0f1b235b22f2eed">e37edb76</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/source: remove useless local variable

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5e796308229f6fc13610f8e8378f29db0b6418e7">5e796308</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: remove unused variables

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e19b69b4df07f95c5df23b2c08c58ba988d3e43">4e19b69b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py/tests/dcerpc_integer: remove dup tests

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77b9b5e89d8756c5c213a295dabcb05eefcb5aa0">77b9b5e8</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool domain: remove unused variables

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/00eaea56f6b9088d2024abf77960171953ad6909">00eaea56</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool processes: remove unused imports and variables

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d1777971010621e750d352d219a344fef4a11c33">d1777971</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/upgradehelpers: remove unused provision imports

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eeb1e81e25ff8477fe00b36ba8c90a81e6241df9">eeb1e81e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/join: remove unused imports and variables

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5f19bf63dc85c59d324aaa820df783baaaf8712b">5f19bf63</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T04:08:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/docs: remove unused import, variables

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/790acef279dedbd93fb98165094002f038e3d265">790acef2</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T08:40:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool ntacl: remove unused imports and variables

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>

Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Thu Nov  1 09:40:02 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d29d2f2f70223e585eb645caa8bfc18993c47fdc">d29d2f2f</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-01T08:41:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pytests: allow blackbox subcommands without a shell

When given a list, it will use the list directly as an argument list,
avoiding shell-expansion and the intermediatory process.

This removes shell expansion trouble, and saves the machine a little
bit of work.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1451b696ee332b49edf691221b97962c95a10fd6">1451b696</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-01T08:41:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add new customdc testenv that can load any backup-file

This adds a new testenv that can be used for sandpit/manual testing.
This testenv can be based off any backup-file that you like.

The main use case is large databases. Populating 1000s of users is
time-consuming (it can take hours to create a really large DB). Instead
of having to manually add users to the testenv every time you want to
try something, this allows you to populate the users just once, take a
backup/snapshot of the DB, and then spin up the backup multiple times.

In theory this testenv could be useful for other situations too, e.g.
dealing with a corrupted database, testing DB migration (e.g. 4.7 -->
4.8), or if (for some reason) you wanted to create a realistic
lab-domain within a testenv.

To run-up the testenv you need to specify a BACKUP_FILE environment
variable (the same way we specify the SELFTEST_TESTENV), e.g.
  BACKUP_FILE=/files/backup-10k-ad_dc.tar.bz2 \
    SELFTEST_TESTENV=customdc make testenv

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c35fb3a88b5c92c343d09f1a707806ea6e46db60">c35fb3a8</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-01T08:41:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dnsupdate: Pass smb.conf through to samba-tool commands

If you call samba_dnsupdate with a --configfile option, this wasn't
passed through to the samba-tool commands the script tries to run.
Normally, samba_dnsupdate would only be run on the DC itself, so it
shouldn't be a big deal, however, this may be a problem if you install
the samba database into a non-default location (i.e. not
/usr/local/samba).

This patch passes through the smb.conf file, if one was specified.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/018ff496e4be6ed536e56b2e6b1940c048f09762">018ff496</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-01T08:41:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dnsupdate: Skip kerberos step if use-file specified

If there's a problem in get_credentials() (getting the machine account
Kerberos credentials), then we fallback to use_samba_tool (essentially
ignoring use-file). However, there's no need to do this, as use-file
shouldn't require Kerberos credentials.

This was making bootstrapping issues starting a testenv harder to debug.
Obviously, Kerberos is dependent on DNS functioning correctly, but
running dnsupdate was also dependent on having a working Kerberos KDC.
In my case, the testenv had a bad krb5.conf file, but the problem
appeared as resolv-wrapper errors (due to a missing RESOLV_WRAPPER_HOSTS
file, which should've been generated by dnsupdate).

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Pair-Programmed-With: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e2ee595202fb338e3ecc9bd8c37e1b89d33d091f">e2ee5952</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-01T12:06:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Remove unnecessary code for backup testenvs

setup_namespaces() already gets done for the backupfromdc's domain, so
this step is unnecessary for the restoredc and offlinebackupdc testenvs
(which are based off the backupfromdc's database).

The setup_namespaces() step is still necessary for the renamedc/labdc,
as these don't have the UPN/SPN suffixes for the new realm yet.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Nov  1 13:06:01 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b28d47b0d86570be5a7c5628e460e01207afb00">9b28d47b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-01T16:34:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Fix the clang build

It's used uninitialized if an early torture_assert fails

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Nov  1 17:34:31 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5528a4cce4f7520bec3305f5ba2951378184687d">5528a4cc</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-01T19:38:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Add more debug for replicating links

During a join of a large DB, processing the linked attributes can take a
long time. The join hangs in 'Committing SAM database' for many minutes
with no indication of whether it's making progress or not.

This patch adds some extra debug to show how far through processing the
linked attributes we are, when there are many thousands of links.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/628b9f71c7d5cf2b76cd9f6a87bc30ac8fa14167">628b9f71</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-01T19:38:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Group together link attribute processing by source object

Instead of processing each link attribute one at a time, we want to
group them together by source object. This will mean we only have to
look-up the source object once, and only perform one DB 'modify'
operation. With groups with 1000s of members, this will help improve
performance.

This patch takes the first step of group together the links by
source-object. A new 'la_group' struct is added to help track what links
belong to the same source object. The la_list essentially becomes a
'list of lists' now.

Note that only related links *in the same chunk* are only grouped together.
While it is trivial to groups together links that span different
replication chunks, this would be a fairly insignificant efficiency gain,
but seems to have a fairly detrimental memory overhead, once you get
into groups with 10,000+ members.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0ba028681dc337acf9c8c7f71fa33a8a09b87c58">0ba02868</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-01T19:38:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Split apart source/target checks for links

We've grouped the linked attributes by source-object. Next, we want to
avoid duplicated processing for the source object, i.e. we only need to
check the source object exists once, not once per link.

Before we can do this, we need to tease apart
replmd_extract_la_entry_details(), which is doing both source and target
object processing. Split out extracting the target DSDB-DN so that it's
done separately.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d54956fd51f356439173b24833ee88b38719fb80">d54956fd</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-01T19:38:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Move talloc context one level up

Eventually we want to combine multiple link attributes, that apply to the
same source object, into a single DB 'modify' operation. This will mean
the memory context needs to hang around until we have performed the DB
operation (instead of allocating a temporary context for each link).

This patch moves the talloc context one level up, so a temp context gets
allocated for each link *group*, instead of for each link *attribute*.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/775054afbe15129691c76f3b276ab4473cbc995b">775054af</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-01T22:48:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Single DB operation per source object during link processing

Move the source object checks and DB modify operation up a level, so we
only do them once per source object rather than once per link.

This allows LMDB joins to succeed with ~15,000 members in a group.
Previously LMDB would fail with the error:

 Failed to apply linked attribute change '(-30792) - MDB_MAP_FULL:
  Environment mapsize limit reached at ../lib/ldb/ldb_mdb/ldb_mdb.c:203'

Rewriting the same object ~15000 times seemed to completely fill up
the LMDB 8Gb buffer. Presumably this was because LMDB is 'copy on
write', so it was storing ~15,000 copies of the same object. Strangely,
we don't see this problem writing the backlinks (which this patch won't
have helped with at all, because that's modifying the target object).

Note uSNChanged was only being added to the msg once, so the code has
been modified to replace the usnChanged each time (i.e. remove it and
re-add it).

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Nov  1 23:48:21 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4731c3382122eac2894fda764891c4903211592f">4731c338</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-01T22:49:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">windbindd: reword error message

Reword the asprintf() out of memory message to make it clear where the
issue is.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d6777a66c0dbd0c356059644b57070d4587d83ea">d6777a66</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-01T22:49:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 smbd: Make the service_details structure constant.

Make the service_details structure a static const.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99aea42520fc10564dbba013c365adb3059febad">99aea425</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-01T22:49:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 smdb: Add a post fork hook to the service API

Add a post fork hook to the service API this will be called:

 - standard process model
   immediately after the task_init.

- single process model
  immediately after the task_init

- prefork process model, inhibit_pre_fork = true
  immediately after the task_init

- prefork process model, inhibit_pre_fork = false
  after each service worker has forked. It is not run on the service
  master process.

The post fork hook is not called in the standard model if a new process
is forked on a new connection. It is instead called immediately after
the task_init.

The task_init hook has been changed to return an error code. This ensures
the post_fork code is only run if the task_init code completed successfully.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7366de3310046b246f3c8e88309d55a18a3edfd5">7366de33</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-01T22:49:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 smbd kdc: allow the kdc to run in prefork

Modify the kdc to allow it to run in the prefork process model. The
task_init function has been split up and code moved into the post_fork
function.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/325e928db94bb6292cd819e92bb5ec1525c81343">325e928d</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-01T22:49:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kdc: Update debug calls

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/28826ec49cc9f90ec514e9398d9bcf7f46a99a56">28826ec4</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-02T02:47:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: KDC prefork support

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Fri Nov  2 03:47:57 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f17a77af4602af02ebb05b8f6d6344c2dadf62f0">f17a77af</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-02T02:48:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python dbcheck: don't use mutable default args

In this code

def f(a, b=[]):
    b.append(a)
    return b

all single argument calls to f() will affect the same copy of b.

In the controls case, controls=None has the same effect as
controls=[].

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1cf142c30abaec2e99cebca15ac61685723032ed">1cf142c3</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-02T02:48:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftesthelpers: fix py3 tests with extra_path

If a test was supplied with extra_path, a PYTHONPATH= env variable was
prepended to the args list, but the py3_compatible clause assumed the
first args element was /usr/bin/python.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78f5b6e3999a0bf4a118df36a2aabcb696049792">78f5b6e3</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-02T02:48:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting/*: py3 compatible print

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/537a26d6d1d1c04456ec0f0b28f04a7de86af027">537a26d6</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-02T05:56:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/py/rodc_rwdc: Fix py2/py3 .next compat issues

Python 3 does not have .next(), which we rely on, change the
code slightly so it works in py2/py3 (using builtin next function)

Pair-programmed-with: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Fri Nov  2 06:56:24 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/831ee63f54959168cf34f12d4590102f40448cc5">831ee63f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T16:03:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Add error checks in dom_sid_string_buf

Also, avoid casts by using PRIxxx macros

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b9d36221930a487ca5c51bf2e38ed04de9d50f7">8b9d3622</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T19:11:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Add dom_sid_str_buf

This is modeled after server_id_str_buf, which as an API to me is easier to
use: I can rely on the compiler to get the buffer size right.

It is designed to violate README.Coding's "Make use of helper variables", but
as this API is simple enough and the output should never be a surprise at all,
I think that's worth it.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Nov  2 20:11:11 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/94ad5ee662a5bfe1c79d8a9c3fcf51d0a1d652c7">94ad5ee6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-02T20:21:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: add smbXcli_req_endtime

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13667

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e7eec24d27b8694fd7626577a2aca05e99045964">e7eec24d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-02T20:21:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: fill endtime if smbXcli_req_create() timeout is non-zero

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13667

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a6de555c51ca34ef24ac4b4cb672cd748d3197a1">a6de555c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-02T20:21:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli/smb2: reapply request endtime

tevent_req_finish() removed a possible request timeout, make sure to
reinstall it. This happened when an interim SMB2 response was received.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13667

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/35f9bc06722fb07143c832442d784beb204bd367">35f9bc06</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-02T20:21:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_delay_inject: implement pread_send and pwrite_send

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13667

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e37ff8c5fe18d400e378bf2591e209b30473d9f9">e37ff8c5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-02T20:21:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/smb2/read: add test for cancelling SMB aio

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13667

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/07eb805cde4db6ac74740e3cfbc56ab6f8e2118a">07eb805c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-02T20:21:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: fix SMB2 aio cancelling

As we currently don't attempt to cancel the internal aio request, we
must ignore the SMB2 cancel request and continue to process the SMB2
request, cf MS-SM2 3.3.5.16:

  If the target request is not successfully canceled, processing of the
  target request MUST continue and no response is sent to the cancel
  request.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13667

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3fa45900c0ada6596daf09aa4c5054974f3394b0">3fa45900</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-02T20:21:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: remove now unused check if fsp is NULL

This was used internally to mark an aio request as cancelled. As the aio
cancellation functionality has been removed, we can now also remove this
check.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13667

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/07d052024a08e3817bda17c74731e621c8c6cd83">07d05202</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T20:21:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nbt_server: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b9c590a68ec85c2a99cf2c70d4f840235044ad0b">b9c590a6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T20:21:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpc_server4: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4602605323e76f853320e360632d644b310dd93b">46026053</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T20:21:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c1d10760d9d0cc788eb8994b99ce238ba25bbd0">4c1d1076</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T20:21:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/71549537b7a91ed61ae519b07b719f539a441fc0">71549537</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T20:21:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">idmap: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dbc9a1a772d36447414b68bb9a860f0b4fe4723c">dbc9a1a7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T20:21:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d0a56a55b613ac701bd39236fc7550d87252559b">d0a56a55</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T20:21:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">audit_tests: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/602d247e0ba9a69c22f087abaf44de7d12114538">602d247e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T20:21:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth4: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bd1e43f7cb8a3a641f064259f7c2831b83262b5a">bd1e43f7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T20:21:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/528170ef6bf1dabc6aef793790dd9bd2d4018db3">528170ef</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T20:21:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ce18cd2a3be78ef9d3abe87539e27c6d81dbb944">ce18cd2a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T20:21:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/039aef708382ac3c09859ea28b54b195bfc19dc2">039aef70</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T20:21:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be6f45ca5ed66ef5f168bafa2046f400cfbea911">be6f45ca</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T20:21:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7963e409cc231922f90f57477c2414674c917bdc">7963e409</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T20:21:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">passdb: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/74c7e3d19a590c64e0bedbb3756f23c8d6f6369e">74c7e3d1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T20:21:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">audit_logging: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ab542ed2c9883fdfe709be4dd0b37ef8d5862695">ab542ed2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T20:21:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d958162bf45fe582b1a4fe30f0e5ffba1325e97">7d958162</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T20:21:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Use dom_sid_str_buf

This is the one place where we have to do another strpcy. Many of the
sid_to_fstring calls should be replacable by dom_sid_str_buf, so this
will get less.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c2b9b574b2d5215fdf431cc5be106c58c0a4eefe">c2b9b574</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-02T23:23:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Make dom_sid_string_buf static

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Nov  3 00:23:31 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dc9bbbe4141d8425e66fe9290ff611845f4bd1ce">dc9bbbe4</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-11-03T02:01:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbtorture: Add test for DELETE_ON_CLOSE on files with READ_ONLY attribute

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13673

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/162a5257c48f20d3752f644e86c9e626b46436c0">162a5257</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-11-03T02:01:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix DELETE_ON_CLOSE behaviour on files with READ_ONLY attribute

MS-FSA states that a CREATE with FILE_DELETE_ON_CLOSE on an existing
file with READ_ONLY attribute has to return STATUS_CANNOT_DELETE. This
was missing in smbd as the check used the DOS attributes from the CREATE
instead of the DOS attributes on the existing file.

We need to handle the new file and existing file cases separately.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13673

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a8e79decbcfbae1b1a53ec81b942ee06db26bf8f">a8e79dec</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-11-03T02:01:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add share to test "delete readonly" option

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13673

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7dd3585f9c3ae04df45d98bfdc62663c7a69d3e0">7dd3585f</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-11-03T04:55:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Run smb2.delete-on-close-perms also with "delete readonly = yes"

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13673

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Sat Nov  3 05:55:45 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e3e84b0f6dc4964f0ac9576051cc88422e548020">e3e84b0f</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-04T22:55:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Add helper class for group assignments

Wrap up the group assignment calculations in a helper class. We're going
to tweak the internals a bit in subsequent patches, but the rest of the
code doesn't really need to know about these changes.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/18740ec0dd5c0ed59fa03b2d9d0d34ea11436b00">18740ec0</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-04T22:55:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Split out random group membership generation logic

This doesn't change functionality at all. It just moves the probability
calculations out into separate functions.

We want to tweak the logic/implementation behind this code, but the
rest of assign_groups() doesn't really care how the underlying
probabilities are worked out, so long as it gets a suitably random
user/group membership each time round the loop.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/898e6b4332e4641ed8377ff2db398a295c37cebf">898e6b43</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-04T22:55:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Improve assign_groups() performance with large domains

When assigning 10,000 users to 15 groups each (on average),
assign_groups() would take over 30 seconds. This did not include any DB
operations whatsoever. This patch improves things, so that it takes less
than a second in the same situation.

The problem was the code was looping ~23 million times where the
'random.random() < probability * 10000' condition was not met. The
problem is individual group/user probabilities get lower as the number
of groups/users increases. And so with large numbers of users, most of
the time the calculated probability was very small and didn't meet the
threshold.

This patch changes it so we can select a user/group in one go, avoiding
the need to loop multiple times.

Basically we distribute the users (or groups) between 0.0 and 1.0, so
that each user has their own 'slice', and this slice is proporational to
their weighted probability. random.random() generates a value between
0.0 and 1.0, so we can use this to pick a 'slice' (or rather, we use
this as an index into the list, using .bisect()). Users/groups with
larger probabilities end up with larger slices, so are more likely to
get picked.

The end result is roughly the same distribution as before, although the
first 10 or so user/groups seem to get picked more frequently, so the
weighted-probability calculations may need tweaking some more.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fdd75407afdde4db6177a981c2d91f2b113e2a19">fdd75407</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-04T22:55:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Change user distribution to use Pareto Distribution

The current probability we were assigning to users roughly approximates
the Pareto Distribution (with shape=1.0). This means the code now uses a
documented algorithm (i.e. explanation on Wikipedia). It also allows us
to vary the distribution by changing the shape parameter.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ad7fc73355604daafddcf074f6b998a43aac9f7">5ad7fc73</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-04T22:55:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Prevent users having 1000+ memberOf links

When adding 10,000 users, one user would end up in over 1000 groups.
With 100,000 users, it would be more like 10,000 groups. While it makes
sense to have groups with large numbers of users, having a single user
in 1000s of groups is probably less realistic.

This patch changes the shape of the Pareto distribution that we use to
assign users to groups. The aim is to cap users at belonging to at most
~500 groups. Increasing the shape of the Pareto distribution pushes the
user assignments so they're closer to the average, and the tail (with
users in lots of groups) is not so large).

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a29ee3a7458de89ae548077013c31cc08cb747f9">a29ee3a7</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-04T22:55:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Re-organize assignments to be group-based

We can speed up writing the group memberships by adding multiple users
to a group in a single DB modify operation.

To do this, we first need to reorganize the assignments so instead
of being a set of tuples, it's a dictionary where key=group and
value=list-of-users-in-group.

add_users_to_groups() now iterates through the users/groups slightly
differently, but mostly it's just indentation changes. We haven't
changed the number of DB operations yet - we'll do that in the next
patch.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/32e58227cd10d9a91c349433fc20bd0cb36869f1">32e58227</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-04T22:55:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Write group memberships once per group

Each user-group membership was being written to the DB in a single
operation. With large numbers of users (e.g. 10,000 in average 15 groups
each), this becomes a lot of operations (e.g. 150,000). This patch
reworks the code so that we write the memberships for a group in
one operation. E.g. instead of 150,000 DB operations, we might make
1,500. This makes writing the group memberships several times
faster.

Note that rthere is a performance vs memory tradeoff. When we hit
10,000+ members in a group, memory-usage in the underlying DB modify
operation becomes very inefficient/costly. So we avoid potential memory
usage problems by writing no more than 1,000 users to a group at once.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/71c66419bb243605ff240e0b7cd5d5a32ba2441f">71c66419</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-04T22:55:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Convert print() to logger.info()

Using logger is more helpful here because it includes timestamps, so we
can see how long things are taking. It's also more consistent with the
rest of the traffic_replay logging.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1906312c097812fbdca1e04f6fe70f5af6bbd596">1906312c</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-04T22:55:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Improve user generation debug

When creating 1000s of users you currently get a lot of debug, but at
the same time you have no idea how far through creating the users you
actually are.

Instead of logging every single user account that's created, log every
50th (as well as how far through the overall generation we are).

Logger already includes timestamps, so we can remove generating the
timestamp diff manually. User creation is the slowest operation - adding
groups/memberships is much faster, so we don't need to log as
frequently.

Note that there is a usability trade-off on how frequently we log
depending on whether the user is using the slower (but more common)
method of going via LDAP, vs the much faster (but more obscure) method
of writing directly to sam.ldb with ldb:nosync=true. In my tests, we end
up logging every ~30-ish secs with LDAP, and every ~3 seconds with
direct file writes.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be51b51263a460e9790b8a210914a68499af7953">be51b512</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-04T22:55:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Generate machine accounts as well as users

Currently the tool only generates the machine accounts needed for
traffic generation. However, this isn't realistic if we're trying to use
the tool to generate users to simulate a large network.

This patch generates machine accoutns along with the user accounts.
Note we assume there will be more computer accounts than users in a real
network (e.g. work laptops, servers, etc), so generate slightly more
computer accounts.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3338a3e257fa9f285ae639d6ac382e3e234be90e">3338a3e2</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-05T02:43:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: Machine accounts were generated as critical objects

Due to the userAccountControl flags we were specifying, the machine
accounts were all created as critical objects. When trying to populate
1000s of machine accounts in a DB, this makes replication unnecessarily
slow (because it has to replicate them all twice).

This patch changes it so when we're just creating machine accounts for
the purpose of populating a semi-realistic DB, we jsut use the default
WORKSTATION_TRUST_ACCOUNT flag.

Note that for the accounts used for traffic-replay, we apparently need
the existing flags in order for the DC to accept certain requests.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Tim Beale <timbeale@samba.org>
Autobuild-Date(master): Mon Nov  5 03:43:24 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/27df4f002a594dbb2f2a38afaccf3e22f19818e1">27df4f00</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-05T05:52:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recovery: Ban a node that causes recovery failure

... instead of applying banning credits.

There have been a couple of cases where recovery repeatedly takes just
over 2 minutes to fail.  Therefore, banning credits expire between
failures and a continuously problematic node is never banned,
resulting in endless recoveries.  This is because it takes 2
applications of banning credits before a node is banned, which
generally involves 2 recovery failures.

The recovery helper makes up to 3 attempts to recover each database
during a single run.  If a node causes 3 failures then this is really
equivalent to 3 recovery failures in the model that existed before the
recovery helper added retries.  In that case the node would have been
banned after 2 failures.

So, instead of applying banning credits to the "most failing" node,
simply ban it directly from the recovery helper.

If multiple nodes are causing recovery failures then this can cause a
node to be banned more quickly than it might otherwise have been, even
pre-recovery-helper.  However, 90 seconds (i.e. 3 failures) is a long
time to be in recovery, so banning earlier seems like the best
approach.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13670

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon Nov  5 06:52:33 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0934fc14ef6ed94a100caa8a622b370d41bc1182">0934fc14</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-05T19:05:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/gp_parse: PY2/PY3 compat changes for __init__.py

Fixes.

1) sorting of xml.etree.ElementTree.Element, in PY2 sort
   seems to sort lists of these. In PY3 this no longer works.
   Choosing tag as the sort key for py3 so at least in python3
   there is a consistent sort (probably won't match how it is
   sorted in PY2 but nothing seems to depend on that)
2) md5 requires bytes
3) tostring returns bytes in PY3, adjust code for that

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/388bddf4a6471f17f32af209bec36713f0b75d20">388bddf4</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-05T19:05:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/gp_parse: PY3 file -> open

'file' no longer exists in PY3 replace with 'open'

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d40ef736d5ee34ad5b575dc32f89d0f4cc1885b8">d40ef736</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-05T19:05:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/gp_parse: PY3 open file non-binary mode for write_binary

Although this is unintuitive it's because we are writing unicode
not bytes (both in PY2 & PY3). using the 'b' mode causes an error in
PY3.

In PY3 we can define the encoding, but not in PY2.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cf79e6ae1516a76cf8b7403a8372fbc6dc3a3a6a">cf79e6ae</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-05T19:05:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/gp_parse: PY2/PY3 compat porting for gp_init.py

Fixes
1) use compat versions of ConfigParser and StringIO
2) fix sort list of XML Elements
3) open file needs to be opened in binary mode as write_pretty_xml
   routing uses BytesIO() object.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/df578e1554630f6781d40d4820c9026bb7b01d2d">df578e15</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-05T19:05:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/gp_parse: Use csv.reader for parsing cvs files

The previous version here was using UnicodeReader which was
wrapping the UTF8Recoder class and passing that to csv.reader.
It looks like the intention was to read a bytestream in a
certain encoding and then reencode it to a different encoding.
And then UnicodeReader creates unicode from the newly encoded stream.
This is unnecssary, we know the encoding of the bytesstream and
codec.getreader will happily consume the bytstream and give back
unicode. The unicode can be fed directly into csv.writer.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/54e2bb707bc998e9017ab3818f8df45c95fad3ce">54e2bb70</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-05T19:05:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samab/gp_parse: remove unused code

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/19a459bac3932427afc65661d06dd7a6eda8865e">19a459ba</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-05T19:05:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: misc PY2/PY3 compat changes for gpo.py

Fixes:
1) various ldb.bytes that should be displayed as strings in PY3
2) sorting of lists of xml Element in PY3
3) various 'open' need to be opened in binary mode (to accept binary
   data)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/16596842a62bec0a9d974c48d64000e3c079254e">16596842</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-05T19:05:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/gp_parse: Fix mulitple encode step with write_section

In python2 as far as I can see GptTmplInfParser.write_binary more
or less works by accident.

write_binary creates a writer for the 'utf8' codec, such a writer
should consume unicode and emit utf8 encoded bytes. This writer
is passed to each of the sections managed by GptTmplInfParser as
follows

    def write_binary(self, filename):
        with codecs.open(filename, 'wb+',
                         self.encoding) as f:
            for s in self.sections:
                self.sections[s].write_section(s, f)

And each section type itself is encoding its result to 'utf-16-le'
e.g.
    class UnicodeParam(AbstractParam):
         def write_section(self, header, fp):
            fp.write(u'[Unicode]\r\nUnicode=yes\r\n'.encode(self.encoding)

But this makes little sense, it seems like sections are encoded to one
encoding but the total file is supposed to be encoded as ut8??? Also
having an encoding per ParamType doesn't seem correct.

Bizarely in PY2 this works and it actually encodes the whole file as utf-16le
In PY3 you can't do this as the writer wants to deal with strings not bytes
(after the extra encode phase in 'write_section'.

So, changes here are to remove the unnecessary encoding in each 'write_section'
method, additionally in GptTmplInfParser.write_binary the
codecs.open call now uses the correct codec (e.g. 'utf-16-le') to write

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6476ef589ee093640e93f6c673b432fcab576888">6476ef58</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-05T19:05:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests/samba_tool: PY2/PY3 compat port for test

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fc047c2cf458e08e2689ff27677d8622f4507c82">fc047c2c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-05T19:05:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/gp_parse: PY2/PY3 Decode only when necessary

In python2 we decode str types in load_xml, in python3 these are
str class(s) which we cannot decode.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e355a6bc59624f9328a6dbf33b335c57e9c8e10f">e355a6bc</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-05T22:04:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: enable samba.tests.samba_tool.gpo for PY3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Mon Nov  5 23:04:48 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/02d41fea33e3ad521fbef2d4f00af2db35edd9d9">02d41fea</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-06T02:39:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">join: Fix join large-DB timeout against Windows

The LDAP connection can also timeout when trying to join a Windows DC
with a very large database. However, in this case Windows gives a
slightly different error message (NT_STATUS_CONNECTION_RESET instead of
NT_STATUS_CONNECTION_DISCONNECTED).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13612

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c21a8ed5948d04881a8900e41386dcdfbdeef326">c21a8ed5</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-06T02:39:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnet: Reset debug counters after replicating critical objects

Reset the debug counters once we have finished replicating a given
partition. This helps if we replicate the same partition immediately
afterward with different options.

This helps the DC join debug look less weird. Because it replicates the
critical objects first, and then the base partition, previously it
always ended up overcounting, e.g.

Partition[DC=addom,DC=samba,DC=example,DC=com] objects[314/218]
  linked_values[48/24]

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/63bfdb3c1150eec64bf3d78e1f2b9749ef077831">63bfdb3c</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-06T02:39:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">drs_utils: Fix some long lines

Tweak the code slightly to avoid some 80+ character lines.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2229f4620d563ce0f0ea256dd89ce248c6656b9e">2229f462</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-06T06:15:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">drs_utils: Avoid invalid dereference of v8 requests

req.more_flags only exists for v10 requests, so we throw an exception if
we try to dereference that field on a v8 (or v5) request. Unfortunately,
we were checking that we support v10 *after* we had tried to access the
more_flags. This patch fixes up the order of the checks.

This may be a problem trying to replicate with an older Windows DC
(pre-2008R2), and was reported on the samba mailing-list at one point:
https://lists.samba.org/archive/samba/2018-June/216541.html

Unfortunately this patch doesn't help the overall situation at all (the
join will fail because we can't resolve the link target and we can't use
GET_TGT). But it now gives you a more meaningful error, i.e.

  ERROR(runtime): uncaught exception - (8639, "Failed to process 'chunk'
    of DRS replicated objects: DOS code 0x000021bf"
instead of:
  ERROR(<type 'exceptions.AttributeError'>): uncaught exception -
    'drsuapi.DsGetNCChangesRequest8' object has no attribute 'more_flags'

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Tim Beale <timbeale@samba.org>
Autobuild-Date(master): Tue Nov  6 07:15:33 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/32c2ec8fa25ad21b9739a288f4a11db2bac1dc6f">32c2ec8f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Allow path_socket() to use $CTDB_SOCKET

Use of CTDB_SOCKET is being generally removed.  However, this override
is being added to allow test code outside of ctdb/ to be able to
specify the socket, if desired.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d4a1f897af2688409f8ed6fd492603cb0f6f7301">d4a1f897</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use ctdb-path-like values for local daemons socket and PID file

However, don't use ctdb-path itself because some tests use nested
instances of onnode.  The outermost instance would set CTDB_SOCKET and
any inner instance would pick up that value, regardless of CTDB_BASE.

This is a temporary measure to avoid breaking testing while use of the
path functions is added to ctdbd and the ctdb tool.  When this is
complete these variables can be removed altogether because the code
will just depend on CTDB_TEST_MODE and CTDB_BASE.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/38566780d27a744c5c47737f8f6e9d99c794801d">38566780</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use ctdb-path for fake_ctdbd directory setup

This needs to be done before any of the code changes are made,
including updating the ctdb tool.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cc3aedd307037e20f3d2e452ebf25927cea29708">cc3aedd3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Use path_socket() in ctdb tool

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cd021596da68baf4ef6be7c2a18c64077c5c8ade">cd021596</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use path_socket() in test client tools

Just leak the memory allocated by path_socket().  This is only used in
short-lived test programs, so it isn't worth the hassle of plumbing a
talloc context through several layers to get here.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5f478b7c5ff66da27cfc12e5272f72c8fbb95c62">5f478b7c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Use path functions for socket and PID file

Drop the use of ctdb_set_sockname() because it complicates the memory
allocation and this is the only place it is used.  Just assign to the
relevant pointer.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d75fa2c3fd7150b35c0a2ca646e83e947605166c">d75fa2c3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop unused function ctdb_set_socketname()

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/82e589e3883d861ae74c104d0226feed4593c47c">82e589e3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop setting of CTDB_SOCKET and CTDB_PIDFILE

The local daemons ssh stub doesn't need to do this because the ctdbd
and the ctdb tool now only need CTDB_TEST_MODE and CTDB_BASE for local
daemon tests.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3b1e5977d81a23553ce63e6aa3ee4c157b6f73dd">3b1e5977</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop incorrect comment, unused function

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d246b1dadfca00e09bdd3d8bae2d03e108a70276">d246b1da</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use path_socket() in dummy client

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4f4a835c3411b6e7c4ed55aba31eaf2a44624fdc">4f4a835c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Remove export of CTDB_SOCKET

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/08469408c379e37523e76a07ac7264bded1dbf01">08469408</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: README updates

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1bbc4fad434a850565fb4f74e529f8824840988a">1bbc4fad</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Detect unknown node number

If there aren't enough addresses in the list then the shift will
silently fail and the printed address will be the unshifted value of
$1, which is incorrect/unexpected.  So, sanity check the node number.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c84254d23d62d57be8ebdd24659c426210ca0213">c84254d2</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Avoid unnecessarily spamming the logs when in test mode

Logging the logging location to syslog can be useful on production
systems when the configuration goes unexpectedly missing.  However, in
test mode this just adds noise to the logs on the test system.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c41481f219acd2439d12f6a767dca153b9cd0ee">9c41481f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Don't set log_to_stdout for become_daemon()

ctdbd logs to stderr in interactive mode, not stdout.  This way stdout
is always closed.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e6bd4249395a153c1e279a77b7a02e9574c091b">4e6bd424</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Improve documentation for -i option

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e952f0316b34b89a754b6805dad5c33adea7e157">e952f031</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Never fork to become daemon in eventd

This stops ctdbd from being able to shut down eventd, since the PID it
records will be invalid.  There's no need for eventd to fork.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/44019b55779f3e36a10c8dbbf89991177ac6a15d">44019b55</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Only run talloc report if CTDB_INTERACTIVE is set

This is only really wanted for interactive testing when logging to
stderr.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f420e8d56fac5b74712700a88ad59da069ef4c92">f420e8d5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-11-06T06:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: talloc: Mark talloc_autofree_context() as deprecated.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/698a9ef36e0b0f24c1cfb07ac554c942960fac35">698a9ef3</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-11-06T06:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: ldb: Remove use of talloc_autofree_context().

Just use NULL in test case. talloc_autofree_context() is deprecated.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eda1296d678f03409471bb3419552865b805edd9">eda1296d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add function wait_until_node_has_no_ips()

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5fdac517fa8a945eb272a645bf1e7d3f10812153">5fdac517</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use wait_until_node_has_no_ips() in some tests

This strengthens those tests to ensure that released IPs aren't
replaced with others.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba86eacb66e8979781f4b1c3a486c17ca52624f1">ba86eacb</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Rationalise ctdb stop/continue/disable/enable simple tests

The "continue" and "enable" tests are just extensions of the "stop"
and "disable" tests, so drop the latter 2.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/43c26e1e645f1f2ac85c7b03a148158534eee567">43c26e1e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Rationalise tunable simple tests

These 3 tests duplicate various checks and can easily be handled as a
single test.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9ebcebe519af29e2ee06430d162b16328e2f625f">9ebcebe5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop useless "ctdb version" test

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/520568051c143065dd35449ba324eb5d1d38e7ac">52056805</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop use of confusing testfailures variable

Exit on first test failure instead of setting a variable.  The bizarre
logic in ctdb_test_exit() makes this worth dropping.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6d9c89bfa3f2bbf0dcb1b33f519e40d96acc4244">6d9c89bf</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop setting of unused variable scriptname

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e733e4cb746c15af17f6df110c0163c565427983">e733e4cb</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Ignore SIGPIPE during simple test cleanup

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e9ead8f28fced3ebfa888786a1dc5bb59e734a3">0e9ead8f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Start daemons in ctdb_test_init(), stop them in ctdb_test_exit()

This makes tests self-contained.  They can also now be individually
looped, if necessary.

Most tests (all but 1 complex, more than 50% of simple) restart the
daemons anyway, so this simplification is worth it.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/92337234e5ebe06397e34861b10cda5dfc5b7ed5">92337234</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop cleanup_handler()

Running testsuite-specific code here isn't a good option.

Daemons are now shut down in ctdb_test_exit(), even when testing is
interrupted.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa2ee4bea8d87f7095c97622b1382ef27e9105fb">aa2ee4be</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Improve signal handling trap

Interrupting a test run currently moves on to the next test.  It
should exit.

Follow the practice of exiting with 128 + signal number.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/412fb7b7d50db0ec5b68e849fc08bcb58de038d1">412fb7b7</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move enabling of event scripts to setup_ctdb()

This is for the real cluster case.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bc8df7191c0e3acb9763aff7cb659bbb8292b950">bc8df719</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop tests that only start and stop daemons

Integration test cases now start and shut down the cluster.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/79db138de5f1d9c95edf436d828725fc68f2d104">79db138d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop dependency on variable ctdb_test_restart_scheduled

The remainder of the scheduled restart logic is about to be removed,
so produce debugging information any time the cluster is not healthy.

While here, reindent and drop the else since there is already an early
return before it.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d762e52e65a574091f498e1305d3125cdab2c392">d762e52e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop ctdb_restart_when_done()

This no longer does anything.  Integration test cases now start and
shut down the cluster.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a2910c60b0ae3f6bccf133ae210a7c4b9f1a7fc">9a2910c6</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop passing of test arguments to ctdb_test_init()

Arguments are currently ignored anyway.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2cb82ef4533a7c10a0ccac5df36f7176f78f9e7b">2cb82ef4</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Change all cluster setup to use ctdb_test_init()

ctdb_test_init() now passes any arguments to setup_ctdb().

Update tests that have custom local daemon configuration to call
ctdb_test_init() directly.  Remove the redundant, initial call to
ctdb_test_init() to avoid starting the cluster an extra time.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bde73c7a044a9508bf08bb8c55a37f38d034afe0">bde73c7a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add new variable CTDB_SCRIPTS_TESTS_BINDIR

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ac5e7ae4413b23c17044cd16ca5db755d3934df">7ac5e7ae</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use $CTDB_SCRIPTS_TESTS_BINDIR

Don't calculate this locally as _test_bin_dir.  Just calculate
top_dir, source script_install_paths.sh and use
$CTDB_SCRIPT_TESTS_BINDIR.

Don't bother sanity checking if TEST_BIN_DIR is set.  It will go away
soon.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d86fd537ac8990ad6babe55911aaa534cae93b6">1d86fd53</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use $CTDB_SCRIPTS_TOOLS_BIN_DIR

Don't calculate this locally as _tools_dir.  Add it to PATH
unconditionally - this may result in duplicate entries in PATH but the
resulting code is simpler.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa0c7ccfc8314919437c0c587b2669bf9847798c">aa0c7ccf</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move setting of ctdb_dir and top_dir

These are only used in script_install_paths.sh.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9679c9e9b6c4e41d55dbe326dba9cc8c9321895b">9679c9e9</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-build: Don't set unused variable TEST_BIN_DIR

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/25efb924bf0c551e3097a116ae8f1cb46d62993f">25efb924</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Allow use of setup_ctdb_base() outside of test cases

Always create an empty event script directory.  If $TEST_SUBDIR is
unset then don't use it to look for etc-ctdb/.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/46fd4f144e7c881887db0deca0ae3b340e19afb3">46fd4f14</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add local_daemons.sh

This provides a separate script for handling local daemons.  It can be
used for testing outside of the CTDB simple test suite.  It is
installed as ctdb_local_daemons.

The logic is copied from ctdb/tests/simple/scripts/local_daemons.bash.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/19de5f463d97673a15fecb97af84fc9c288af8ee">19de5f46</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use local_daemons.sh in local_daemons.bash

The etc-ctdb/ subdirectory containing the event script moves into the
top-level tests/ directory because the subdirectory is really now
owned by local_daemons.sh instead of simple/.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/804bdf9719cdc128df7ba4dfe7564e5339426b35">804bdf97</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add local_daemons.sh onnode and socket commands

These aren't used by simple tests but they will be useful for
integrating ctdbd local daemons into other test suites and for
debugging.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/01f6fbba4e5823f2cc028ba6f094b55812dff6ee">01f6fbba</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T06:16:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Switch interactive variable to a bool

popt uses an int in place of a bool, so declare an extra int and make
the conversion explicit.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6e16e95f74c06bf381db666007a30ecb0e1ff7ce">6e16e95f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-06T09:30:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Do not fork when CTDB_TEST_MODE is set

Explicitly background ctdbd instead.

This has the advantage of leaving stdin open.  ctdbd can then be
enhanced to exit when stdin closes, allowing better cleanup in a test
environment.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue Nov  6 10:30:14 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/46a87f2cbafdc84199e7e131f1d88961b37a2f78">46a87f2c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-06T17:57:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Add tdb_traverse_chain

This is a lightweight readonly traverse of a single chain, see the
comment in the header file.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3daf9c85b742ec9365faa123e38e23a0d80a69a0">3daf9c85</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-06T17:57:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Add test for tdb_traverse_chain

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e814fb6bcba8687dafb7d0d1654df8225b2e6229">e814fb6b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-06T17:57:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Version 1.3.17 for tdb_traverse_chain

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/72ec893d0aaa518a2cf22aa68b16c3907a17dfc8">72ec893d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-06T17:57:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Allow !CLEAR_IF_FIRST & MUTEX_LOCKING

This is a prerequisite to allow gencache to run on a non-transactioned
database with mutexes.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0d7f67f07cd96943dfe58e91254145e28e047ace">0d7f67f0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-06T17:57:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gencache: Convert to a binary timestamp

Two reasons:

The ascii conversion shows up on profiles.

In a further commit we will get checksums for gencache entries to
protect at hidden corruption due to a crash on the non-transactioned
gencache.tdb. Next to the timestamp this is a second field that is
gencache metadata, and I don't want to deal with a second ascii number
when at least some of the gencache values are binary already.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a1e13b4a5dd98bd13790c52e5745b8d04e1bda15">a1e13b4a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-06T17:57:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gencache: Add crc check

This covers key, timestamp and data. This will detect silent
corruption of gencache data after a system crash

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1386200be5c583c680c3894a11688a0e0a3d2285">1386200b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-06T17:57:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gencache: Remove transaction-based tdb

At more than one large site I've seen significant problems due to
gencache_stabilize. gencache_stabilize was mainly introduced to
survive machine crashes with the cache still being in place. Given
that most installations crash rarely and this is still a cache, this
safety is overkill and causes real problems.

With the recent changes to tdb, we should be safe enough to run on
completely corrupted databases and properly detect errors. A further
commit will introduce code that wipes the gencache.tdb if such a
corruption is detected.

There is one kind of corruption that we don't properly handle:
Orphaned space in the database. I don't have a good idea yet how to
handle this in a graceful and efficient way during normal operations,
but maybe this idea pops up at some point.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c13eb55253a00d9472c749ccf58dd13e0efd1518">c13eb552</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-06T17:57:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gencache: Wipe corrupt databases

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/608df97d5dbc4e56456b83a28e3b2251a9aa4007">608df97d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-06T17:57:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gencache: Prune expired entries

This solves the problem that gencache never shrinks right
now. Whenever we write an entry, we now walk that entry's chain and
delete expired entries. This should be a good balance between
performance and cleanup actions: Reading is still unaffected, and
those who write pay a small penalty while keeping gencache size under
control.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8d787f73bbcaff181583eadb9b15dcaf863c032c">8d787f73</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-06T20:52:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Align integer types

tdb->max_dead_records is "int", as is the corresponding parameter to
tdb_set_max_dead(). Not that a signed variable makes any sense, but
this is old code and tdb_set_max_dead() is a public API which we
should not change for this.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Nov  6 21:52:32 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5870c642cea94de1e7231678d033dfbb0cb83b8e">5870c642</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-07T00:29:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add README documenting the customdc testenv

Also documented the other backup/restore testenvs as well.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3ca13997e5017fb00032c6044d8dc8eab2a13221">3ca13997</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-07T03:39:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add some more testenv descriptions

This still doesn't cover all the testenvs comprehensively, but it
pretty much exhausts my knowledge of what the various testenvs do.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Wed Nov  7 04:39:05 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9682f94d40f715a1ea06898ca42c27437b5610b">a9682f94</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-07T16:55:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/upgradehelpers: use mkstemp, not mktemp

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e3320b6d3df7a0c7b78e71cb5bc2d18f31839573">e3320b6d</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-07T16:55:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool gpo: do not use predictable temp directory

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/94610330947d4a8a654638886929c15de314cd8b">94610330</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-07T16:55:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool gpo: add helper method for tmpdir construction

A few of the gpo commands use an identical temporary directory structure
that can be constructed using shared code.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fd089c37a118e58d09fc04c16fdc3eee9d62d3d2">fd089c37</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-07T16:55:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool gpo: convert pseudo-method into method

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/85b6d8898993c45726dd6c1afc2536ab79ba5a3c">85b6d889</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-07T16:55:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Move machine account creation

I was assuming that generate_users_and_groups() only gets called in the
--generate-users-only case. However, it also gets called in the default
traffic replay case.

This patch reworks the code so that the number of machine accounts to
create gets passed in, and the 'create 25% more computers than users'
assumption only applies to the --generate-users-only case.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/51917fc07f2322786d21f9987f52366d9005c1d3">51917fc0</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-07T16:55:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Move 'traffic account' flag up a level

We create machine accounts for 2 different purposes:
1). For traffic generation, i.e. testing realistic network packets.
2). For generating a realistic large DB.

Unfortunately, we want to use different userAccountControl flags for
the 2 different cases. Commit 3338a3e257fa9f28 changed the flags used
for case #2, but this breaks case #1.

The problem is generate_users_and_groups() is called in both cases,
so we want the 'traffic account' flag passed into that function.
This ensures that the machine accounts get created with the appropriate
userAccountControl flags for the particular case you want to test.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c7fe4814777696be06e455de5d04ced9a3366d27">c7fe4814</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-07T16:55:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Make sure naming assumptions are in a single place

The traffic_replay group/user/machine account names follow a standard
format. This adds a function to generate the machine-name. It also makes
sure the existing user_name() function gets called in all applicable
places.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d7fb66f7630a994dbb261ce417c26d17b409593">1d7fb66f</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-07T16:55:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Make packet generation work on a pre-populated DB again

Generate separate machine accounts for populating a large DB vs
replaying network traffic.

We want to use different userAccountControl flags in each of the above
cases (i.e. commit 3338a3e257fa9f28). However, this means that once you
use the --generate-users-only option, you can't replay network packets
against the machine accounts.

We can avoid this problem by creating separate machine accounts for each
of 2 different cases, e.g. STGM-0-x machines for traffic-replay, and
PC-0-x machines for padding out the database.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a0b5f4b7b05b8ea2bf061b8af5b702aa14a7a5a5">a0b5f4b7</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-07T16:55:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Rework machine accounts to remove redundant code

generate_users_and_groups() now generates the machine acounts as well as
the user accounts, so it seems there's no need to also have
generate_traffic_accounts(), which does the same job.

Instead, we can just pass through the number of machine acounts to
generate_users_and_groups() and delete the other function.

Also updated generate_users_and_groups() so that machine_accounts is
no longer optional (we want to create machine accounts in all cases).

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de1f49752cd2a7c8d7f015785af1d3529753dacf">de1f4975</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-07T16:55:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: make ad_dc use prefork process model

Convert the ad_dc environment from single process model to the prefork
process model.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/700b4ce98163b4840bbcc7ec7c9bbc070ab8b143">700b4ce9</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-07T16:55:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 smbd prefork: Increase default worklers to 4

Increase the default number of worker processes started by the pre-fork
process model from 1 to 4.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b543563ddf46e776fa4996fa4e4635684076cf80">b543563d</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-07T16:55:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: 'prefork children' default

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b003134e0d1cdc235e00a602edd2e745233f98b8">b003134e</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-07T16:55:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 smbd: pass instance number to post_fork

Pass the instance number to the post_fork hook. This is required to
allow the rpc_server to support the prefork process model.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/58c4490e24c2a0429052e131ba8022c58ea02ecf">58c4490e</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-07T16:55:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 smdb rpc_server: Support prefork process model.

Allow the rpc_server to run in the prefork process model. Due to the use
of shared handles and resources all of the rpc end points are serviced
in the first worker process. Those end points that can be run in
multiple processes (currently only Netlogon and management) are serviced in
the first and any subsequent workers.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e650c40e11401f5ff8477292a46f14dfd06a2a29">e650c40e</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-07T20:17:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: NETLOGON prefork support

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Nov  7 21:17:59 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f4b400237437b690a64c8864ac4df3d4b88b67b">9f4b4002</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-08T07:07:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch:tests: Pass the envname to the script

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/71ef09c1afdbf967b829cb66b33c3a5cb1c18ba0">71ef09c1</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-08T07:07:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Fix DEBUGCLASS pointer initializiation

This fixes a segfault in pyglue:

==10142== Process terminating with default action of signal 11 (SIGSEGV)
==10142==  Bad permissions for mapped region at address 0x6F00A20
==10142==    at 0x6F1074B: py_set_debug_level (pyglue.c:165)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13679

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2d512b278e5905964c1294c587ba405678c3d10c">2d512b27</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-08T10:03:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debug: Use debuglevel_(get|set) function

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Nov  8 11:03:11 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/593fdd21923b1065b7cfbedc69a214720f190e03">593fdd21</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-08T23:47:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Add "hide new files" option

See the manpage for the description

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f21bc3addaafc857f0645378d4635d91c620c2f9">f21bc3ad</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-09T02:49:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Test hide new files timeout

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Nov  9 03:49:55 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8f2c5620c0a45f4ffc3a09ed1f72b4e7afa8763">f8f2c562</a></strong>
<div>
<span>by Philipp Gesang</span>
<i>at 2018-11-09T16:52:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-kdc: restore MIT KDC backend

Fix fallout from the KDC prefork patchset (99aea42520fc..).

GCC warns when Samba is being built with --with-system-mitkrb5.
Fix this by adapting the signature of mitkdc_task_init() to match
task_init which has been extended to return a status code.

Status codes try to mimick those of kdc-heimdal.c:kdc_task_init()
as closely as possible.

Signed-off-by: Philipp Gesang <philipp.gesang@intra2net.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/96d47c21d503e08b00659d8b35f46e8409dc0172">96d47c21</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-09T16:52:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add README note: always use --configfile in testenv creation

We always need to specify "env->{CONFIGURATION}" when running a samba-tool
command to setup a testenv. Add a note to the README as this wasn't at
all clear.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/55fa7bc01df1e167af8795bba37f12be6c2e5056">55fa7bc0</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-09T16:52:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Fix backup testenv creation on certain host machines

When we created the backup-file for the restoredc/renamedc/labdc
testenvs we weren't explicitly a --configfile on the samba-tool command.
This meant the command tried to use the smb.conf form the default
install location, i.e. /usr/local/samba/etc/smb.conf. On the gitlab CI
runner, there's no samba installed, so it ends up using the default
settings, which is fine. However, if the host machine had an invalid
smb.conf installed there, creating the testenv would fail with an error
like:

ERROR(runtime): uncaught exception - Unable to load default file
File "bin/python/samba/netcmd/__init__.py", line 184, in _run
return self.run(*args, **kwargs)
File "bin/python/samba/netcmd/domain_backup.py", line 222, in run
lp = sambaopts.get_loadparm()
  File "bin/python/samba/getopt.py", line 94, in get_loadparm
    self._lp.load_default()

We can avoid this by always explictly specifying the backupfromdc's
smb.conf when creating the backup file.

Likewise, labdc/customdc also need the config specified when the admin
password is reset.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b161b3a89154a9529404f5ee31d8679ddd1c48b0">b161b3a8</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-09T20:07:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">mdb_util: Better error message if lmdb-utils not installed

mdb_copy() was dutifully checking the PATH for the mdb_copy executable,
then, if it didn't find it, blindly proceeding anyway and trying to run
a non-existent executable. This resulted in a cryptic error:

  ERROR(<type 'exceptions.OSError'>): uncaught exception - [Errno 2] No
    such file or directory

Add in an extra check that we actually find the executable and raise a
better human-readable exception if we don't.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Nov  9 21:07:47 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b30350489cdcd496fa08e5e1116ad3e19ca3ba3">9b303504</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2018-11-09T21:42:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Fix CID 1441072 Error handling issues (CHECKED_RETURN)

Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d53870da1cb35f16f7eb9460e181593b5c0cf67">5d53870d</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2018-11-09T21:42:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Fix CID 1441070 Error handling issues (CHECKED_RETURN)

Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/221133b0e9ed28274f7513d9416f13a81b7b458b">221133b0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-09T21:42:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: torture writing AFP_AfpInfo stream

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13677

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4901d71c3de754a106662d01481b960ed7c2c4dd">4901d71c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-09T21:42:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: move a comment to the right place

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13677

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a7c877847f855be5ee6673e541a181b818013abf">a7c87784</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-09T21:42:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: validation of writes on AFP_AfpInfo stream

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13677

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e8743444f797b3b1db3b53d1054473b1e4fba162">e8743444</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-09T21:42:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/21bfc7743970f985ffef1b558120203c76739ec3">21bfc774</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-09T21:42:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/58e77b542257342139069210092ae92e8f153680">58e77b54</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-09T21:42:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1ff8598d46ad6efabb07feba0dba017adea204d6">1ff8598d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-09T21:42:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/efcd3ae682b3fff155fcdf8202bb2c47a8d2707e">efcd3ae6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-09T21:42:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">passdb: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/94cfb4ded18ead3035963d0a23a70a4537ebf7ba">94cfb4de</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-09T21:42:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">passdb: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9060b26caca327c7dc1f3b69b28a7acfcf2f7d3d">9060b26c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-09T21:42:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">passdb: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/beba440c0ed6eae9cad86da2863b730a00a23a6f">beba440c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-09T21:42:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">passdb: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f564776ebd14de12f5f1f5cddb6d5286ab2b776d">f564776e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-09T21:42:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">idmap: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1e484da7921e84dc0bb8939401de0188c9cbde5f">1e484da7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-09T21:42:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">idmap: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87ae595b3880862589743e07dd2d08bfc0d35883">87ae595b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-09T21:42:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">idmap: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5cad0fc6c0bbca861cbed04acc940af7121317f3">5cad0fc6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-09T21:42:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libgpo: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a979bb28b301d3ecf72b958f8a114d24c5203544">a979bb28</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-10T01:19:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Nov 10 02:19:29 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/899d00e6be5af48b93c15beb43f7383eeb8508b1">899d00e6</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2018-11-10T11:48:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-auth-tests: Fix test_kerberos with MIT krb

When a keytab of type MEMORY is used, the MIT kerberos krb5_kt_add_entry()
library function adds a keytab entry to the beginning of the keytab table,
instead of the end.

This adds a MIT kerberos conditional to reverse iterate through
the keytable entries to address this.

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>

Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Sat Nov 10 12:48:02 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c8e27b6f334931d5a609af6b50c9e0756e88b672">c8e27b6f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-12T08:50:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:replace: Add getprogname()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba9ad1266561d7003727dfb12915234d75a575f5">ba9ad126</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-12T08:50:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wbclient: Send the client process name talking to winbind

This is for better debugging messages.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/305f3bc492b2d0664cafbd805f3a668a37d4ebc1">305f3bc4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-12T08:50:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbindd: Also log the process name in winbindd

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d26caa27e1cf286475a0d09621cc38d2b4e4335d">d26caa27</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-12T08:50:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Log client process name

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ec87ca8bdc14a1ac0895f4333a2b00ef866edd66">ec87ca8b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-12T08:50:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Log client process name in winbind_misc

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f49b62b44dd5dceb537a5364b1ff107db9a7aea4">f49b62b4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-12T08:50:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Log client process name for PAM auth

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1834513ebe394f4e5111665a21df652e59b3b0b6">1834513e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-12T08:50:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wbclient: Add wbcSetClientProcessName()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f257f958fe448f6cf12008ad8c380aeb748c657">6f257f95</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-12T08:50:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_plugin: Set the wbclient process name

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a918a64f055562db40cf34029f2216812b54281">2a918a64</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-12T08:50:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nss_winbind: Set the client process name

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ffc8b4ac8d418b44da7206469ae076398e12b7ac">ffc8b4ac</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-12T08:50:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nss_wins: Set client process name

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c10d70c43c935c5388654f78b3ac51ec43bbdf02">c10d70c4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-12T12:44:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pam_winbind: Set the request type as client name

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Nov 12 13:44:09 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/751c0cc7c4482b0546329b9aac49e76b529f0302">751c0cc7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-12T19:20:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Fix crash when taking profiles

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13629
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Björn Baumbach <bbaumbach@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Nov 12 20:20:52 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/716715496c4744ffe2565f0c1c99335ea1f53867">71671549</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-13T03:10:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use wire_perms_to_unix in unix_perms_from_wire

Same code, less lines

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Nov 13 04:10:54 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a9d003d01adebaf089ca975b04b9d8d4e7640a2">7a9d003d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-13T06:37:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:replace: Do not leak the file pointer in rep_getprogname()

And return NULL on error.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/63a9fe1d445f04eb83a7d0f9d27355c2baf9c5bf">63a9fe1d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-13T06:37:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Handle possible NULL return value of getprogname()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f5768106fd43935bc2725ec1b2ecce5c69f1a34">9f576810</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-13T10:11:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Add check for variable program_invocation_short_name

It appears that wafsamba's configure() defines _GNU_SOURCE
unconditionally, so checking _GNU_SOURCE isn't enough to know if this
variable is available.

For example, it isn't available on AIX with the xlc compiler:

  [ 6/10] Compiling lib/replace/replace.c
  ...
  "../../lib/replace/replace.c", line 991.16: 1506-045 (S) Undeclared identifier program_invocation_short_name.

Instead, add a configure check for program_invocation_short_name and
use it.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Nov 13 11:11:11 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d0a8899ed57c2b368c3870b3899a3422251222aa">d0a8899e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-13T10:13:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:selftest: split "raw.session" and "smb2.session"

The next commit is going to add a testsuite to "smb2.session".

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13661

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b86c94f0b929f2d9e521d41396c4e1611f5a4c5b">b86c94f0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-13T10:13:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:selftest: also run smb2.session torture testsuite against ad_member

The next commit adds a subtest to the smb2.session testsuite that
requires Kerberos (ad_dc would work), but where neither SMB2 server or
client must require signing (ad_dc, being an AD DC, requires signing).

The ad_member environment supports Kerberos with the SMB2 server not
mandating signing, that'll do.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13661

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d407201d9bd4ee5ae5609dd107e3ab9ee7afbeb0">d407201d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-13T10:13:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/smb: add smb2cli_session_require_signed_response()

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13661

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/67cfb01611869b7590ccd836dd13a80e53545714">67cfb016</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-13T10:13:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/smb: maintain require_signed_response in smbXcli_req_state

Not used for now, that comes next.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13661

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7abf3900218e3d27c075b405735b2c38ec0fc4ca">7abf3900</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-13T10:13:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/smb: defer singing check a little bit

This allows adding an additional condition to the if check where the
condition state may be modified in the "if (opcode ==
SMB2_OP_SESSSETUP)" case directly above.

No change in behaviour.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13661

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53fe148476a5566b7a8204d7e44b6e75ce7d45bc">53fe1484</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-13T10:13:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/smb: use require_signed_response in smb2cli_conn_dispatch_incoming()

This can be used by the upper layers to force checking a response is
signed. It will be used to implement verification of session setup
reauth responses in a torture test. That comes next.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13661

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/368e1860654e737aa2fa9516cdd3668fa644009a">368e1860</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-13T10:13:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/smb2/session: invalidate credential cache

Invalidate credential cache before connecting to the server, otherwise
we will reuse the credentials from the credential cache populated by the
preceeding tests.

Also invalidate it at the end, otherwise subsequent tests might run into
problems if the credentials expire while authenticating.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13661

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ffc424ee6bedc3c208acb4c0c83da836a12d6123">ffc424ee</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-13T10:13:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/smb2/session: require a signed session setup reauth response

All existing tests using this function require signing, so currently
this passes. A subsequent commit adds a test where neither client nor
server require signing and that's where this trap will explode.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13661

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5fdea4095ac82536192c8d91c411b22e2683a5c1">5fdea409</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-13T10:13:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/smb2/session: add force_signing to test_session_expire1i

Existing callers pass true, so no change in behaviour. The next commit
adds an additional test that passes force_signing=false.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13661

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/181f18c4bf70754a6f3132375d06250baab2871b">181f18c4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-13T10:13:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/smb2/session: session reauth response must be signed

This test checks that a session setup reauth is signed even when neither
client nor server require signing.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13661

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bb93e691ca9b1922bf552363a1e7d70792749d67">bb93e691</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-13T13:22:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smb2_sesssetup: check session_info security level before it gets talloc_move'd

We talloc_move() session_info to session->global->auth_session_info
which sets session_info to NULL.

This means security_session_user_level(NULL, NULL) will always return
SECURITY_ANONYMOUS so we never sign the session setup response.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13661

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Nov 13 14:22:46 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a5d1bb5c5b5a57a2d7710dc5ab962683fe5c8e68">a5d1bb5c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-13T13:32:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/smb2/session: test smbXcli_session_set_disconnect_expired() works

This adds a simple test that verifies that after having set
smbXcli_session_set_disconnect_expired() a session gets disconnected
when it expires.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=9175

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5a8583ed701be97c33a20b2a20f6bbb8ac2f8e99">5a8583ed</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-13T16:28:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/smb: don't overwrite status code

The original commit c5cd22b5bbce724dcd68fe94320382b3f772cabf from bug
9175 never worked, as the preceeding signing check overwrote the status
variable.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=9175

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Nov 13 17:28:45 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3634e20c7603103b0f2e00e5b61cc63f905d780d">3634e20c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-11-13T19:54:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: lib: nmbname: Ensure we limit the NetBIOS name correctly. CID: 1433607

Firstly, make the exit condition from the loop explicit (we must
never write into byte n, where n >= sizeof(name->name).

Secondly ensure exiting from the loop that n==MAX_NETBIOSNAME_LEN,
as this is the sign of a correct NetBIOS name encoding (RFC1002)
in order to properly read the NetBIOS name type (which is always
encoded in byte 16 == name->name[15]).

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>

Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Tue Nov 13 20:54:56 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/56ac8944eb58f234422b4bd4dd9a64b8e51e874d">56ac8944</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-14T04:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpcclient: Initialize domain_name

This could be passed uninitialized to dcerpc_netr_DsRGetDCName()

Found by cppcheck.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13680

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c37ed26f0a814f77c934ae190f48d0a1e673f83">9c37ed26</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-14T04:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc:ndr: Initialize inblob

Found by cppcheck.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13680

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/159f753732cdc1e4491f93617779861fb9d73bc7">159f7537</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-14T04:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libgpo: Make sure status is intialized

Found by cppcheck.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13680

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/050d1e7d53c068efac109ec4ff7a686d152e6a45">050d1e7d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-14T04:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util Always initialize start and space

Found by cppcheck.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13680

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/008b9652cacdfd99e68db9d88f4e0c33eefa87e9">008b9652</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-14T04:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Fix an out of bound array access

Found by cppcheck.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13680

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5b4c664856602e411bf2897e44e5453c7831035f">5b4c6648</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-14T04:07:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/provision: PY3 port samba4.dlz_bind9.version

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0ef6e3da4b6dd8e36ced3ad344f9981901aaa2f2">0ef6e3da</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-14T04:07:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs/blackbox: PY3 bulk change for python scripts use correct python

Change all instance where python scripts are called so that the
correct python version as specified by $PYTHON is used

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/108109360a5b8ca45b8bf0eef020fe001af61d1d">10810936</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-14T04:07:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: Port samba.tests.blackbox.samba_dnsupdate for PY2/PY3

Make sure either the output of tests and/or the item we are searching match
in type. Output of cmd in python3 is bytes, depending on the was the test is
written it may be easier just to convert all output or just a single string
that is used in the test

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b16043f57d5e0b9a769de61d512c6e01c5e05a7d">b16043f5</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-14T04:07:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: PY3 port samba.tests.blackbox.netads_json

convert output from check_output to text
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a25367685d82437b6535d762eb0628c47bef2cc8">a2536768</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-14T04:07:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/torture: PY3 port samba.ntlm_auth

Use bytes in test rather than str

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fdb3aa487f0ceb9989959036efd98f54563cd3ce">fdb3aa48</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-14T04:07:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: PY3 port samba.tests.samba_tool.edit

Need to write bytes to file

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/32a490d6818a805b781290cf1ee03f4b870a78be">32a490d6</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-14T04:07:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: PY3 port samba4.blackbox.ldapcmp_restore

Convert attribute from bytes to str
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1715812915820aa089fbcfd5b8c326e0838727a9">17158129</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-14T04:07:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests/python: PY3 port samba4.ldap_schema.python

+ Misc attributes needed to be converted to strings from bytes to
ensure various asserts work as expected.
+ Fix ndr_unpack call which needs bytes not str

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e6ea052c8cbb5981aa02158745c361d0d33880dc">e6ea052c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-14T04:07:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests/python: PY3 port samba4.ldap.secdesc

User str/bytes as needed for various asserts

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fe859a44772054975d46c63c14f3f5c20c221dfa">fe859a44</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-14T04:07:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests: PY3 port of samba4.ldap.acl.python

convert various attribute results to str so assert function
as expected for tests.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f176461cf29908f3555eecc2463d00e2ffdc693d">f176461c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-14T04:07:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: PY3 fix can't compare string with int

Testing a string against an int value is illegal and
is not necessary in this case, this patch removes the
problematic test.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8bf82d9f8584673a00529166263b39ff796d1985">8bf82d9f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-14T04:07:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: PY3 Fix str/bytes issue for json.loads

Python 3.4 seems to need a string

    parsed = json.loads (out_jsobj)
  File "/usr/lib/python3.4/json/__init__.py", line 312, in loads
    s.__class__.__name__))
TypeError: the JSON object must be str, not 'bytes'

however Python 3.5 seems to be happy to consume bytes (or string)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/48cc8a4e3214a571b2917dc3b677b44cccfa7286">48cc8a4e</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-14T04:07:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting/bin: PY3 convert servicePrincipalName attr to string

res[0]["servicePrincipalName"] is an instance of ldb.bytes in PY3
If we wish to get the string value we need to call the custom
str function which attempts to decode the bytes to 'utf8'

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a5c8ab277b1fa75289ca6a7ee2c87e079b9a6b7d">a5c8ab27</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-14T04:07:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: Ensure samba_dnsupdate called with correct python version

We need to examine the contents of PYTHON env variable which should defined the
python version to be used when running tests.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3495f3fc838376b9a2dd3b43976a8884574842fb">3495f3fc</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-14T04:07:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting/bin: gensec_client.update needs bytes

PY3 test was failing as param passed to update was str rather than bytes

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2ca3b3ebd8ac31e1b3a33b57d706740ed0edf110">2ca3b3eb</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-14T04:07:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script: Add new (temporary) pure python3 ad-dc-2 test

Ideally we want all the tests to run under python3 by default (no
special task for this) and then convert the existing '-py3' tasks
to run the python tests with python3.
However at the moment the convertion process is not ready to do this,
for a while we need to run separate autobuild tasks for this.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/321002e37e3cb467c44dc927b081f2e6c64cfcce">321002e3</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-14T04:07:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CI: Add new CI job for new purepy3-ad-dc-2 autobuild task

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/483d5ea5c88a0cd9a107957883534b2e5b65f3b0">483d5ea5</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-14T07:20:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CI: Autobuild: Remove build_samba_ad_dc_2_py3 CI job

We now run a purepython3 ad-dc-2 test job, later when the whole
build is running under python3 we will resurrect build_samba_ad_dc_2_py3
but as (build_samba_ad_dc_py2) for python2

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Nov 14 08:20:55 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0595129b8e36a62dd46d543e33866cda8293f2a9">0595129b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-14T07:45:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libldb: Fix const char in pyldb

../lib/ldb/pyldb.c: In function ‘PyDict_AsMessage’:
../lib/ldb/pyldb.c:90:22: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
 #define PyStr_AsUTF8 PyUnicode_AsUTF8
                      ^~~~~~~~~~~~~~~~
../lib/ldb/pyldb.c:1359:19: note: in expansion of macro ‘PyStr_AsUTF8’
   char *key_str = PyStr_AsUTF8(key);
                   ^~~~~~~~~~~~
../lib/ldb/pyldb.c: In function ‘py_ldb_msg_getitem_helper’:
../lib/ldb/pyldb.c:3336:7: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
  name = PyStr_AsUTF8(py_name);
       ^
../lib/ldb/pyldb.c: In function ‘py_ldb_msg_setitem’:
../lib/ldb/pyldb.c:3502:12: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
  attr_name = PyStr_AsUTF8(name);
            ^

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/50fdf67b3442d1690c312c5e34eee92e03cf6da9">50fdf67b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-14T07:45:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:librpc: Use discard_const_p for ndr/py_misc

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a6e7f3a5f76a74464161666b38c35e3f9aa1386">2a6e7f3a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-14T07:45:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:dsdb: Use const char in py_dsdb_garbage_collect_tombstones()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a272b83af6958a436821daacaa3876dd991e6ba">4a272b83</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-14T10:46:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:passdb: Use discard_const_p() in py_passdb

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Nov 14 11:46:06 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a4a85aca3242f56e94a487e7eb3e09684bd397da">a4a85aca</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-11-14T20:35:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Remove logically dead code. Coverity CID: 1419117

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Nov 14 21:35:45 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ce6b5919b71e0e5ee8c32696da3cf5243fd810eb">ce6b5919</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-15T00:47:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use 65520 for maxopenfiles

The socket_wrapper limit is 65535 open sockets.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e3b6402b8b60f5af22a1097847aa7389f147e580">e3b6402b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-15T03:50:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Update socket_wrapper to version 1.2.1

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Nov 15 04:50:31 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c1dd6382e3211792e313f7d559b943f55c9cb0e1">c1dd6382</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-15T07:15:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Make the debug hung script test cope with unreadable stacks

Ideally this would just involve using "test -r".  However, operating
system security features may mean that kernel stacks are not readable
even though they appear to be.

Instead, try reading that stack of a process on the test node.  If
that succeeds then so should reading the stack of the "stuck" sleep
process in the test.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13684

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Tim Beale <timbeale@catalyst.net.nz>

Autobuild-User(master): Tim Beale <timbeale@samba.org>
Autobuild-Date(master): Thu Nov 15 08:15:32 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b79d5f2a2f8af75ef13bdc41d2dc296e19ba098">9b79d5f2</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2018-11-15T15:30:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: fake_acls: Fix Coverity CID 1435850 Uninitialized pointer read.

map_acl_perms_to_permset() can return an error, check it.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0872f140c4a354511b25bb5ed937b9e9409ade3a">0872f140</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-15T18:45:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Fix the 32-bit build

Unfortunately there's no off_t printf specifier as there's one for
size_t. So we have to use intmax_t.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Nov 15 19:45:24 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da1d7af1a7b15c91742568849c07f796512a93cf">da1d7af1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-16T17:35:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Fix CID 1441264 Error handling issues (CHECKED_RETURN)

This is not worth keeping a CID around :-)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/579ce3eb4e5b14159cfe20d00f0ba7e4801f2944">579ce3eb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-16T17:35:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Slightly simplify samdb_check_password

Avoid an "else" where we have the early return

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Björn Baumbach <bbaumbach@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be46a42774590f68f8560d82f8425a43fecda98b">be46a427</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-11-16T20:52:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbtorture: Close unused pipe fds in kernel_oplocks8

This fixes a hang of the testcase when hitting an error in the child (e.g.
localdir does not exist)

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Nov 16 21:52:13 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cc9f1d46e445c739bc08077721d4cde208a39ec4">cc9f1d46</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-20T00:33:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Added samba-tool 'backup offline' and 'groups stats'

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65e7476a87b4d5f5c4f98ac08e17621dc7a70a8d">65e7476a</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-20T00:33:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add assertion that replUpToDateVector is present after backup

We noticed that offline backups were missing a replUpToDateVector for
the original DC, if the backup was taken on a singleton DC. This patch
adds an assertion to the existing test-cases to highlight the problem.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6e5ebbfb65344661ae4bcee02abc9143fb61bb84">6e5ebbfb</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-20T00:33:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Add backupType marker to backed-up DB

We are starting to hit restore cases that are only applicable to a
particular type of backup. We already had a marker to differentiate
renames, but differentiating offline backups would also be useful.

Note that this raises a slight compatibility issue for backups created
on v4.9, as the marker won't exist. However, it's only offline backups
we will use this marker for (at the moment), and this option doesn't
exist on v4.9, so there's no problem.

Removing the markers has been refactored out into a separate function to
handle the optional presence of the new marker.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ca2726a402f061a73ab7b52064d8b1e4028caca">5ca2726a</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-20T00:33:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Small backup refactor to avoid compatiblity problems

It will be easy to forget that the backupType marker doesn't exist on
v4.9. However, this seems like a dumb reason not to support v4.9
backup-files. Add a wrapper function to avoid potential problems
cropping up in future.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/008449d99f7f0bcc165cdf9dc479eb9dc5e1a856">008449d9</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-20T00:33:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Flush replUpToDateVector when restoring offline backup

The replUpToDateVector could be incorrect after an offline backup was
restored. This means replication propagation dampening doesn't work
properly. In the worst case, a singleton DC would have no
replUpToDateVector at all, and so *all* objects created on that DC get
replicated every time a new DRS connection is established between 2 DCs.
This becomes a real problem if you used that singleton DC to create 100K
objects...

This patch flushes the replUpToDateVector when an offline backup gets
restored. We need to do this before we add in the new DC and remove the
old DCs.

Note that this is only a problem for offline backups. The online/rename
backups are received over DRS, and as part of the replication they
receive the latest replUpToDateVector from the DC being backed up.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eea1d4b7782fd2a7741e0c3144900b8b9272bfec">eea1d4b7</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-20T00:33:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb group_audit tests: fix use of strncmp

Replace the uses of:
   strncmp(expected, value, strlen(expected))
With:
    strcmp(expected, value)

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1dc06aaa2d6ceff494045034235aaf1c99252cf1">1dc06aaa</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-20T00:33:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:heimdal_build: make use of libreplace getprogname() replacement

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5bb48cb650cce8331976051123027a359f1feac8">5bb48cb6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-20T00:33:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: fix CHECK_MAKEFLAGS() with waf 2.0.8

Changing Options.options.jobs in the build() hook
is too late in waf 2.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1cb782119a314dd5a4e0344695b87e26c1d322c7">1cb78211</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-20T00:33:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: add a fix for broken python threading if just one job is forced

This fixes random failures during (at least) configure on AIX.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c0104a4a04ae5c4fc847209e51b2ccfcb9b11336">c0104a4a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-20T00:33:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: remove hardcoded '..' and '/default/' from SAMBA_PIDL()

This makes it possible to remove some move waf 1.8 compat code.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8e1135f99b34712fe4cce8039d2bb82df131ce40">8e1135f9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-20T00:33:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: remove the need of BuildContext.bdir

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/076afab4cfe06e4215649c9368293d855b26c9af">076afab4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-20T00:33:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: remove unused Build.BuildContext.pre_build overload

This is not needed and also fixed the interaction between
vim and ':make'

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65f7f7ffe577390ed27a232eb4a14fa354c9289e">65f7f7ff</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-20T00:33:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: simplify SAMBA_PIDL_TABLES() rule

The builddir is not bin/default/ instead of just bin/,
so we don't need to strip 'default/' anymore.

And the '--output ${TGT}' part is not really implemented.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aafc15c3c34e178aa29e04ddbe2a393319767b38">aafc15c3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-11-20T00:33:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc/tables.pl: remove unused $opt_output option

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0025e8e96a788bef49dca08a8ebc4929a165069b">0025e8e9</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-20T03:47:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: Load the C compiler correctly

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Nov 20 04:47:24 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/af1f24acf783c293d3af6de8e10a64a036d7be38">af1f24ac</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-20T03:48:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Split up replmd_verify_linked_attribute() into src/target checks

Refactor replmd_verify_linked_attribute() so we split out the link
attribute source/target checks. This patch should not alter
functionality.

The source object check has been moved out to where
replmd_verify_linked_attribute() was called.

replmd_verify_linked_attribute() has been renamed, as it's now only
checking the link target.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ffe7707675fe91830bea59725e324d029cf2988d">ffe77076</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-20T03:48:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Skip redundant source object link checks

We receive the links grouped together by source object. We can save
ourselves some work by not looking up the source object for every single
link (if it's still the same object we're dealing with).

We've already made this change to replmd_process_linked_attribute().
This patch makes the same change to replmd_store_linked_attributes().
(We verify that we know about each link source/target as we receive each
replication chunk. replmd_process_linked_attribute() kicks in later as
the transaction completes).

Note some care is needed to hold onto the tmp_ctx/src_msg across
multiple passes of the for loop.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c49c0c300ce2d4b9f11039640bfd58265c7477af">c49c0c30</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-20T03:48:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Minor change to replmd_verify_link_target() args

We were passing in the entire src_msg, but all we really need is the
source object's DN (and even then, it's only used in error messages).

Change it so we only pass in what the function actually needs. This
makes it a bit easier to see what src_msg is actually used for.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/062ac12a31010436953ebe0b31351f7ec0844415">062ac12a</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-20T03:48:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Split some code out into create_la_entry() helper function

replmd_store_linked_attributes() has gotten in szie and complexity. This
refactors some code out into a separate function to make things a bit
more manageable.

This patch should not alter functionality.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b47443b871c8cfcae60f4d098ff27e561ee6cd4">8b47443b</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-20T07:40:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Cache recycle-bin state to avoid DB lookup

By caching the recycle-bin state we can save ~6% of the join time.

Checking whether the recycle-bin is enabled involves an underlying DSDB
search. We do this ~4 times for each link we replicate (twice for the
link source and target). By caching the recycle-bin's state over the
duration of the replication, we can save 1000s of unnecessary DB
searches.

With 5K users this makes the join time ~5 secs faster.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Tim Beale <timbeale@samba.org>
Autobuild-Date(master): Tue Nov 20 08:40:16 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b7a0d3b110697923a31e353905d3b1bd9385ea9b">b7a0d3b1</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-11-20T21:14:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dirsync: Allow arbitrary length cookies

The length of the cookie is proportional to the number of DCs ever in
the domain (as it stores the uptodateness vector which has stale
invocationID).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13686

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ac90c9faa783fc133229e7c163471d96440ff30e">ac90c9fa</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-11-20T21:14:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">sync_passwords: Remove dirsync cookie logging for continuous operation

Under normal operation, users shouldn't see giant cookies in their logs.
We still log the initial cookie retrieved from the cache database, which
should still be helpful for identifying corrupt cookies.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13686

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ad8bb6fcd08be28c40f2522d640333e9e69b7852">ad8bb6fc</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-11-20T21:14:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_controls: Add some talloc error checking for controls

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13686

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a1277c1ecd76ab50ef0c509f6834ae9311c8daf">9a1277c1</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-20T21:14:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests samr: Extra tests for samr_QueryDisplayInfo

Add extra tests to test the content returned by samr_QueryDisplayInfo,
which is not tested for the ADDC.  Also adds tests for the result
caching added in the following commit.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d9f7b6d63f9c3622c857ccb80092f6f1c21d1431">d9f7b6d6</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-20T21:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests samr: remove PEP8 warnings

Remove PEP8 warnings from the samr tests.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/10efdac356dcb15c7ab233412bafc5853effc31a">10efdac3</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-20T21:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 samr: cache samr_QueryDisplayInfo results

Add a cache of GUID's that matched the last samr_QueryDisplayInfo made on a
domain handle.  The cache is cleared if the requested start index is
zero, or if the level does not match that in the cache.

The cache is maintained in the guid_caches array of the dcesrv_handle.

Note: that currently this cache exists for the lifetime of the RPC
      handle.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fc1a16ff61ac57079d7e31fc2266b35b2fdeaae0">fc1a16ff</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-11-20T21:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-samr: Use dom_sid_split_rid() to get the RID in dcesrv_samr_QueryDisplayInfo

Signed-off-by: Andrew Bartlett <abartlet@samba.org>

Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7dd7800a88e6ece0606d6d94718318e2dc067d58">7dd7800a</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-20T21:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test samr: Extra tests for samr_EnumDomainGroups

Add extra tests to test the content returned by samr_EnumDomainGroups,
and tests for the result caching added in the following commit.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/564813b58830142699edb4f82539f0834434c2e4">564813b5</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-20T21:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 samr: cache samr_EnumDomainGroups results

Add a cache of GUID's that matched the last samr_EnunDomainGroups made on a
domain handle.  The cache is cleared if resume_handle is zero, and when the
final results are returned to the caller.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b6241852937e7e2d6254b3e9bba221d34edc5571">b6241852</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-20T21:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-samr: Use dom_sid_split_rid() to get the RID in dcesrv_samr_EnumDomainGroups

Signed-off-by: Andrew Bartlett <abartlet@samba.org>

Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8d8303b0aecb472de33f7dbd87c80e939e98034a">8d8303b0</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-11-20T21:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-samr: Use GUID_buf_string() in dcesrv_samr_EnumDomainGroups()

This avoids memory allocation

Signed-off-by: Andrew Bartlett <abartlet@samba.org>

Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fa3ea1cfc181dc9119c5fb0c6a1a12a7d31bfac2">fa3ea1cf</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-20T21:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests samr: Extra tests for samr_EnumDomainUserss

Add extra tests to test the content returned by samr_EnumDomainUsers,
and tests for the result caching added in the following commit.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/64007aa3825be8a3c5678cbc636efa8ecb09c4b1">64007aa3</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-20T21:14:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 samr: cache samr_EnumDomainUsers results

Add a cache of GUID's that matched the last samr_EnunDomainUsers made on a
domain handle.  The cache is cleared if resume_handle is zero, and when the
final results are returned to the caller.

The existing code repeated the database query for each chunk requested.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53c20e1096d8aa4879ddf22df3cc3651eb73f8f7">53c20e10</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-11-20T21:14:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-samr: Use dom_sid_split_rid() to get the RID in dcesrv_samr_EnumDomainUsers

Signed-off-by: Andrew Bartlett <abartlet@samba.org>

Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1719f8b9cd98cf54a297ef59c68db68945bf6f0f">1719f8b9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-11-20T21:14:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-samr: Use GUID_buf_string() in dcesrv_samr_EnumDomainUsers()

This avoids memory allocation.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>

Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ad57cac7db0873cbe1c42173ed36ad41a75ed9a4">ad57cac7</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-21T00:50:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 samr: Tidy DBG_WARNING calls

Move the calls to GUID_buf_string and dom_sid_str_buf into the
coresponding DBG_WARNING call, instead of using an intermediate variable.
While this violates the coding guidelines, doing this makes the code less
cluttred and means the functions are only called if the debug message is
printed.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Nov 21 01:50:11 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cb3520fbaf9413da71645e653f9501d1645405b4">cb3520fb</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-21T00:51:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: replmd_process_link_attribute() returns type of change made

In order to share work across related link attribute updates, we need
replmd_process_link_attribute() to let the caller know what actually
changed.

This patch adds an extra return type that'll be used in the next patch.
What we're interested in is: the update was ignored (i.e. it's old news),
a new link attribute was added (because this affects the overall
msg/element memory), and an existing link attribute was modified (due to
how links are actually stored, this includes deleting the link, as in
reality it simply involves setting the existing link to 'inactive').

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c371fef58638a7570becf29dd0df651004219d0a">c371fef5</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-21T00:51:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Only modify the object if it actually changed

Commit 775054afbe1512 reworked replmd_process_link_attribute() so that
we batch together DB operations for the same source object. However, it
was possible that the object had not actually changed at all, e.g.
- link was already processed by critical-objects-only during join, or
- we were doing a full-sync and processing info that was already
  up-to-date in our DB.

In these cases we modified the object anyway, even though nothing had
changed. This patch fixes it up, so we check that the object has
actually changed before modifying the DB.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f53954d0fd4d67c73336e9fda81429df9c55d77a">f53954d0</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-21T00:51:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Move where we update the usnChanged/whenChanged

Move this closer to where the source object actually gets modified.

The main reason to do this is that adding fields can cause the
msg->elements to be reallocated, which will invalidate all the
old_el and pdn_list pointers which are derived from the msg.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/19a36b367f1a33f1eb65e0c5164a3209fcef16e6">19a36b36</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-21T00:51:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Remove some redundant code

At first glance, this code seemed completely unnecessary. However, it
was added (by commit f6bc4c08b19f5615) for a valid reason: adding the
whenChanged/uSNChanged attributes to the message can cause msg->elements
to be reallocated, which means the old_el pointer (which points to
msg->elements memory) can be out of date.

whenChanged/uSNChanged now get added to the msg last, just before the DB
modify operation. So old_el can no longer become out of date within
replmd_process_link_attribute(), so re-fetching it is now redundant.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/90f5e49a8797f821b07ae761056ec0c5235f8978">90f5e49a</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-21T00:51:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Pass old_el into replmd_process_linked_attribute()

We should only need to lookup the msg attribute once per source object.
The old_el->values may change due to link-processing, but old_el itself
should not.

This is not aimed at improving performance, but we need to change how
old_el is used before we can change pdn_list (which is more costly
processing-wise).

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/698cf271f439c252c77f67fb88b09c9dcc84139d">698cf271</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-21T00:51:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Minimize get_parsed_dns_trusted() calls during replication

When a group has 10,000+ links, get_parsed_dns_trusted() can be costly
(simply the talloc calls alone are expensive). Instead of re-generating
the pdn_list for every single link attribute, we can change to only
re-generate it when we really need to.

When we add a new link, it reallocates old_el->values, and so we need to
recreate the pdn_list because all the memory pointers will have changed.
However, in the other cases, where we're simply updating the existing
link value (or ignoring the update, if it's already applied), we can
continue using the same pdn_list (rather than re-parsing it again).

This would generally only save time with a full-sync - it won't really
help with the join case (because every link processed results in a
realloc).

On a DB with 5000 users, this makes a full-sync about ~13% faster.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/05147d25e7b4a9343378c59927f443b723606960">05147d25</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-21T00:51:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Avoid redundant dsdb_get_deleted_objects_dn() checks

Quite a bit of time was spent in dsdb_get_deleted_objects_dn()
processing during either a join (~9%) or a full-sync (~28%).

The problem is we're *always* doing the dsdb_get_deleted_objects_dn()
call for each object, regardless of whether it's actually deleted or
not. i.e. we were doing an expensive query and a lot of the time just
ignoring the query result.

If it's not a deleted object we're dealing with, we can just return
early and skip the unnecessary processing.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a370f217bb94601345ad5700ea546259e1d04bfd">a370f217</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-21T04:31:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Make replmd_process_linked_attribute() mem dependencies clearer

This patch should not alter functionality - it is just making memory
assumptions used in replmd_process_linked_attribute() clearer.

When adding/removing msg->elements we have to take care, as this will
invalidate things like the parsed-DN array or old ldb_message_element
pointers. This has always been the case (i.e. f6bc4c08b19f5615a49),
however, now we need to take even more care, as the msg being modified
is re-used and split across 2 different functions.

Add more code comments to highlight this. We can also free
pdn_list/old_el to prevent them being incorrectly used after realloc.
It seems appropriate to also add a sanity-check that the tmp_ctx alloc
succeeds (which all the other memory hangs off).

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Tim Beale <timbeale@samba.org>
Autobuild-Date(master): Wed Nov 21 05:31:10 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5f47c04cf3e7ef90a3521c097f60af49bd37615d">5f47c04c</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-11-21T06:46:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd/ldapcmp: fix typo for Bundle

Bundel -> Bundle

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/683342b7a000f370cdc7456ce51cfb69783ced58">683342b7</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-11-21T06:46:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd/ldapcmp: rename __eq__ to diff

This method actually changed both objects and print info.
__eq__ is not a proper name and is not designed for this case.
Rename to diff.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/263f02078471a29cad97889a28c02db4ea06a422">263f0207</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-11-21T06:46:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd/ldapcmp: add choices arg to --scope option

So we don't need to validate ourselves.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e71d0d71203474b1b30c8c8250c28ba4889b1f20">e71d0d71</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-11-21T06:46:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd/ldapcmp: add choices arg to --view option

So we don't need to validate ourselves.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/86882bd12e506e3a7ceac4f3e9e282df55398a7f">86882bd1</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-11-21T06:46:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd/ldapcmp: avoid list comprehension in for loop

The list comprehension will repeat for each item.
For large database, this make the command freeze.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f821f84f2e9a8489dcf8842ce716546f6f8c5ff0">f821f84f</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-11-21T06:46:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd/ldapcmp: use set instead of list to find missing DNs

This simplify the logic and improve performance a lot.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/047138708965d61c122dce64d57a42419e21e501">04713870</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-11-21T06:46:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd/ldapcmp: rm unused global var summary

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bbd082e7929010545deb5ce59e370ebe934aa23e">bbd082e7</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-11-21T06:46:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd/ldapcmp: avoid modifying data while looping on dict

Just define another dict for return value, seems no need to modify
original dict.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2851cd5bccde53a049bbd3774911b7dc4b970467">2851cd5b</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-11-21T06:46:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd/ldapcmp: pass --skip-missing-dn to LDAPBase

This option has default value False, and was actually not passed down from cli
to LDAPBase. However, LDAPBase.__init__ has default value True for it.

After the change, a few tests using ldapcmp are affected.
Add --skip-missing-dn explicitly to keep the behavior consistent,
otherwise test will fail.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/10855509852f8e6bc42d5410e59e76fbf2f14657">10855509</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-11-21T06:46:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd/ldapcmp: fix wrong way for string copy

Two mistakes here:

- res[:-1] will copy but lost the last char
- string is immutable in python, there is no need to copy it explicitly

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d9282bf7c02df351f976701ac6b4ed121be72f1">7d9282bf</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-11-21T06:46:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd/ldapcmp: use set instead of list to compare attrs

This will simplify the logic and improve performance.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/26f0992c24281514dd3ef079c1951a56277373a4">26f0992c</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-11-21T06:46:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd/ldapcmp: promote re object to global

Then we can reuse the re obj.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ebbd3731d0f510c040e7dc59532a8fb5c0f609a">7ebbd373</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-11-21T06:46:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd/ldapcmp: make code pythonic

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c4bd785ac12fe80e11e985c8c50e459be4ec9898">c4bd785a</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-11-21T06:46:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool ldapcmp: print DNs on predictable order

Rather than unstable hash order. Ideally we'd do them in proper DN order.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/24b1aa9da2e53e0dba89811f6a8d14b810bd48a8">24b1aa9d</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-11-21T09:46:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">logger: use color automatically for a tty

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Nov 21 10:46:20 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bb843be3bfe4a9e15f345edb8acb290d63b28781">bb843be3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-21T15:53:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Make cli_trans a normal subreq function

A lot of "state" variables, but still I don't think the additional complexity
is justified by saving a few lines. Make this a completely regular tevent_req
"req/subreq" function.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c9ccf234989a28e0f3d8f46fa7bce070e44c5a4">9c9ccf23</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-21T15:53:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Make cli_trans_send cancellable

Required to cancel SMB1 notify

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/499d97b38c4477751d2dd38e9882bc7a5c7a8337">499d97b3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-21T15:53:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: Make smb2cli_notify_send cancellable

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d4a8bed85512b6d80e2a256f0343b4f59e3f63ad">d4a8bed8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-21T15:53:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Introduce cli_smb2_notify_send/recv

This only existed as a sync wrapper where the underlying function could do
send/recv already.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c984f3f50c74a9f9fc35583ac00576faab1d0c5">4c984f3f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-21T15:53:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Make cli_notify_send/recv smb2-aware

smb2-awareness only existed in the sync wrapper

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/88d82b44c326cfb3ab1cf1f7288eada2566ab4bc">88d82b44</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-21T19:50:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Make cli_notify_send cancellable

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Nov 21 20:50:13 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/02514427dba74325510137655a3788e70e29c82d">02514427</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-11-22T07:22:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libads: set proper ads_keytab_flush() return code on error

The return code was left on success when the calls to
ads_get_machine_kvno() or ads_clear_service_principal_names()
failed and the processing had to be aborted.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a3dd28c635206272673ea1f62b35121c7e808db4">a3dd28c6</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-11-22T07:22:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbspool: Free kerberos context on error

If processing cannot continue and the function returns
the kerberos context must be free'd.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1295e2b754da6aeb1b5d2c6b07c8cc9afbba21f9">1295e2b7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-22T07:22:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">README.Coding: Approve DBG statements using dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f902798a7f43ea84fb7757ea6b917a4717f99e0">7f902798</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-11-22T07:22:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: Free principal if smb_krb5_principal_get_realm() fails

If smb_krb5_principal_get_realm() fails, procesing is aborted and
resources have to be free'd. In this context free'ing the principal
was missing.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1a6451decfbffe10d72ad1c1221a4e9bccf04055">1a6451de</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-11-22T07:22:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Free krb5 context on error

If the call to krb5_cc_resolve() fails and processing is aborted,
the krb5 conext must be free'd before return.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c73c345f6f47cc124109925f87536fdf0febc702">c73c345f</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-11-22T07:22:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">utils: Free krb5 context for net_lookup_kdc

In case of an error while processing and at the end of processing
the krb5 conext must be free'd.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/64fbc4c151158a1bc8864b3db56c79c4367cd7f2">64fbc4c1</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-11-22T10:18:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">utils: Free host realm after processing

In case of error and at the end of processing the list
of realms have to be free'd again.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Nov 22 11:18:41 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3e58e83be5a52b70d6cb409a87401b52ae365b01">3e58e83b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-22T21:13:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:bind_dlz: Only copy the dn once

../source4/dns_server/dlz_bind9.c:1132:4: error: 'dn' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    state->log(ISC_LOG_INFO, "failed to find dnsRecord for %s",
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        ldb_dn_get_linearized(dn));
        ~~~~~~~~~~~~~~~~~~~~~~~~~~

Found by Undefined Sanitizer.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dbeb806d4a3374076a9edf8c504e6e3f88fe9da7">dbeb806d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-22T21:13:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Initialize pointers in libnetapi user test

Found by Undefined Sanitizer.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dbdd57e31c09c71460eb2f7b0c646795682ebd88">dbdd57e3</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-22T21:13:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:tests: Initialize pointers with NULL in netdisplay test

Found by Undefined Sanitizer

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a418f731b220d75f27c9885c373d7a2c0b41b57">2a418f73</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-22T21:13:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Always include unistd.h for setgroups

This is needed to pass configure checks

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1642dc2fd4c3e89bab127c5c1d0b675d1c5cb6f9">1642dc2f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-22T21:13:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Do not redefine bool and use stdbool.h

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ee6497574a0b5a7fcaf8171fea50dd169f468158">ee649757</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-22T21:13:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:crypto: Fix undefined behavior in md4

runtime error: left shift of 145 by 24 places cannot be represented in type 'int'

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/502f56c1ce0077cf31b64831ae787cf91ffc4ab1">502f56c1</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-22T21:13:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Fix undefined behavior in messages_dgm

source3/lib/messages_dgm.c:1290:7: runtime error: variable length array
bound evaluates to non-positive value 0

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/02913d088879500a149ef733eb618561434a9f3a">02913d08</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-22T21:13:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Fix undefined behavior in asn1 parser

lib/util/asn1.c:969 runtime error: left shift of negative value -1

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/470a9b891acfa4ec8426f703912652ee2e4b5d86">470a9b89</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-22T21:13:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Fix undefined behavior in idtree

lib/util/idtree.c:84 runtime error: left shift of 1 by 31 places cannot
be represented in type 'int'

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/93ab0cef2a0f68788f77d8fce7e4f795e9921a9b">93ab0cef</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-22T21:13:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Fix undefined behavior in bitmap.c

lib/util/bitmap.c:77: runtime error: left shift of 1 by 31 places cannot
be represented in type 'int'

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aab5034a9ddc57ee9ce14ce584e53bd9b96b7a58">aab5034a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-22T21:13:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:compression: Fix undefined behavior in lzxpress

lib/compression/lzxpress.c:228 runtime error: store to misaligned
address 0x5631d53ca9fe for type 'uint32_t', which requires 4 byte
alignment

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f48bc840c11c0d4cfbd6b7eada15cc69218ca0f">6f48bc84</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-23T00:23:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc:ndr: Fix undefined behavior in ndr.c

librpc/ndr/ndr.c:1430 runtime error: left shift of 1 by 31 places cannot
be represented in type 'int'

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Fri Nov 23 01:23:09 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b8ff4a0881bd6a12ba43ece27b8d3d9e5750b81f">b8ff4a08</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-23T04:00:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add better error for DRS tests

We've got a flappy test hitting this assertion failure, but we can't
tell why it's failing intermittently (probably because we're bumping the
RID-Set, but there's no way to confirm this).

Add some extra debug info if the test assertion fails.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1a45e5b136bedfed1fa3a8b87b79da759c3958c4">1a45e5b1</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-23T04:00:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Fix flappiness in DRS tests due to RID Set changing

The test_link_utdv_hwm test case in getnc_exop has started getting
slightly flappy (8 failures in the last 2 weeks). The problem is the
test case creates a new computer, which can occasionally result in a new
RID pool being allocated.

The problem can be reproduced by running the test case repeatedly (it
usually fails after ~250 times).

This patch updates the _check_ctr6() assertion to filter out the 'CN=RID
Set' object, if it happens to be present.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b9c5417b523c4c53cb275c12ec84bbc849705bec">b9c5417b</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-23T04:00:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Avoid passing msg to replmd_process_linked_attribute()

We can prevent anyone from inadvertently adding/removing msg->elements[]
in replmd_process_linked_attribute() by just not passing msg into the
function. Currently we only actually need the source DN and a memory
context for reallocating old_el->values.

The warning comment has been moved to a more appropriate place.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9d5af87e66c4e936ddd06607cc98f20c24e035b1">9d5af87e</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-23T04:00:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: Move logic into new replmd_should_apply_isDeleted() function

It's easier to follow the logic involved here when it's split out into a
separate function.

This patch should not alter the existing logic/functionality.

Note the 'else' case is somewhat redundant, but it avoids excessive
whitespace changes to the function. It'll be tidied up in the next
patch.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b136a8184d6f703405d0f53613b061af3601725">6b136a81</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-23T07:10:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replmd: remove unnecessary indent

The previous refactor now means we return early if we don't need to
re-apply isDeleted to the object. The 'else' is redundant and we can
remove it to avoid unnecessary indent.

This patch is basically just a whitespace change. It should not alter
functionality.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Nov 23 08:10:41 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5fa134dc83e0fae21c1b20d722d6040f49a152e4">5fa134dc</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-23T07:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 smbd test: prefork process restart

Add tests for the restarting of failed/terminated process, by the
pre-fork process model.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1adb5b2122a2026a5910852ac33b83f656f9b4c2">1adb5b21</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-23T07:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 smbd prefork: Pass restart information

Pass information about the pre-fork master and worker processes that
will allow them to be restarted.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d4641c8f76b7764f81ce246d2a2b8103593d0dac">d4641c8f</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-23T07:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 smbd prefork: Restart failed processes

Restart any pre-forked master or worker process that terminated with SIGABRT,
SIGBUS, SIGFPE, SIGILL or SIGSYS

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3315a28ea92438eca499fb87b863cbd2db50a6a6">3315a28e</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-23T07:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 smbd process: pass the fatal flag to terminate

Pass the fatal flag supplied to task_server_terminate to the process
task_terminate method.  It will be used by the task_terminate methods to
set an appropriate exit code.  The process_prefork model will use a non
zero exit code to indicate that the process should be restarted.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6c850b77c4ae6c4aa6d914f7ccedc2bcce939217">6c850b77</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-23T07:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 smbd prefork: restart on non zero exit code

Restart any pre-fork master or worker process that exits with a non
zero exit code.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/40941e98f8508daf59b83e05461ebeab4bebaacd">40941e98</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-23T07:25:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 smbd prefork: Add backoff to process restart

Add new smbd.conf variables 'prefork backoff increment' and
'prefork maximum backoff' to control the rate at which failed pre-forked
processes are restarted.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/11d424e1999e50f036ce2b33411f6f607c60a487">11d424e1</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-23T07:25:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 messaging: clean up terminated processes

Now that the smbd pre-fork process model restarts failed processes rather than
terminating, we end up with names registered to defunct processes.
This patch adds a function to clean up all the names registered to a process.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/46b164de67689c57d316701557b9847a0b9e45c1">46b164de</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-23T07:25:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 smbd prefork: Cleanup messaging on restart

Clean up names registered in messaging for a terminated process.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c10c0e17a11b7a33c1de20ecd8b37830af909f7">0c10c0e1</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-23T07:25:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 dcerpc_server: remove irpc_add_name

Remove the irpc_add_name from dcesrv_sock_accept, as it results in two
identical names being registered for a process.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2db38370e3f6f4c91e87c8c469f3b3c59c0f3a68">2db38370</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-23T07:25:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool processes: display pre-fork masters and workers

Tag prefork work processes with "(worker 0)", and sort the process list
on server name to get a consistent order.

 Service:                          PID
 --------------------------------------
 cldap_server                     15588
 ...
 ldap_server                      15584
 ldap_server(worker 0)            15627
 ldap_server(worker 1)            15630
 ldap_server(worker 2)            15632
 ldap_server(worker 3)            15634
 nbt_server                       15576
 notify-daemon                    15638
 ...
 samba                                0
 ...
 wrepl_server                     15580

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/830a65020475886af6bd1edc347c0a2b96d14a38">830a6502</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-23T07:25:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: prefork restart

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fabc3c9d3827fd30d7cec674105218c97c04e801">fabc3c9d</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-23T10:40:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4 smbd prefork: Add code comments

Add some comments to the prefork code explaining what's going on.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Nov 23 11:40:49 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d629c67dd3c3acaa7329cceff83ad035f696c08a">d629c67d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-23T16:14:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libads: Use dom_sid_string_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/baacc7039408e07efcfbade13750cc9f717b2777">baacc703</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-23T19:23:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libads: Align integer types

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Nov 23 20:23:57 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/632b3ab7d492b9ed0b2f9709a91397104e227d4a">632b3ab7</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-27T02:43:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Be explicit about which testenvs use ntvfs

If a testenv didn't specify any other provision arguments, then it
defaulted to using the NTVFS file server.

This patch makes it explicit, so we just pass through "--use-ntvfs" as
extra provision args in the cases we want.

(Whether all these testenvs really need to use NTVFS or not is another
question, but at least now it's easy to see which testenvs use it).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da933b7664c5ae6afa81993d9dcd7127567992de">da933b76</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-27T02:43:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Make chgdcpass's NTVFS usage more obvious

The chgdcpass testenv was not passing --use-ntvfs to the provision
command, but it was still actually using NTVFS.

The reason is the smb.conf generated by provision_raw_step1() would
always try to use the s4/NTVFS file server. Because the smb.conf already
existed, this trumped what was passed to the provision command.

This patch doesn't change the chgdcpass file server. It just makes it
more obvious that chgdcpass is using NTVFS.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bfb138e9be6e28cce88c4ef2221cc5712e0593a1">bfb138e9</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-27T02:43:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Make testenv NTVFS usage match --use-ntvfs

Regardless of whether the testenv uses --use-ntvfs as part of its
provision options, the s4 testenvs all default to using the NTVFS file
server.

It's not particularly obvious that this is happening. The new restore
DCS (restoredc, renamedc, labdc) were all using NTVFS unintentionally.

The problem is the s4 testenvs default to using services '-s3fs +smb".
provision_ad_dc() explicitly overrides this to use s3fs again
(technically it ends up with both in its smb.conf and just uses whatever
comes last).

This patch changes the testenv setup to check for the presence of the
'--use-ntvfs' option and to set the 'server services' config option
appropriately. This way, the provision command and the smb.conf options
should always line up, with respect to NTVFS.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/88ccd418fdee67ef8f2e4c06acc1488a875c641e">88ccd418</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-27T02:43:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Use s3 smbclient for testenv smoketests

smbclient4 doesn't support SMBv2 connections, i.e. it won't work against
a DC with SMBv1 disabled. The smoke-test here is that the DC accepts
the connection, so we don't really care what SMB tool we use to connect.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/160031f7b7e4e14a1b9ff9316b166fd52b7d401d">160031f7</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-27T02:43:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Designate one testenv as having SMBv1 disabled

We recommend users disable SMBv1 to avoid potential security holes.
However, none of the AD DC testenvs have SMBv1 disabled.

This patch disables SMBv1 on an arbitrarily-chosen testenv (restoredc).

I chose restoredc as we'll want to run the backup tool tests against
this target, and it might be useful to check we can backup a DC if it's
already been restored once.

Note that SMBv2 doesn't support POSIX extensions (only SMBv1 does),
which is why we haven't just disabled SMBv1 on *all* testenvs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/93c2a9522357e7d70d028cbd6bbeda103f40c69e">93c2a952</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-27T02:43:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Rework backup test_backup_invalid_args test-case

self.create_backup() uses self.run_cmd(), which is a wrapper around
self.check_output(). Rework the code to call the underlying
check_output() function directly instead.

The reason we're doing this is we want run_cmd() to catch exceptions and
fail the test (i.e. in the next patch). However, we can't do that because
this test case relies on receiving the exceptions.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70dee4c1c14ea3eb5c8c81887c6caaa6dc288807">70dee4c1</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-27T02:43:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Handle backup command exceptions as test failures, not errors

If the backup command fails (i.e. throws an exception), we want the test
to fail. This makes it easier to mark tests as 'knownfail' (because we
can't knownfail test errors).

In theory, this should just involve updating run_cmd() to catch any
exceptions from the command and then call self.fail().

However, if the backup command fails, it can leave behind files in the
targetdir. Partly this is intentional, as these files may provide clues
to users as to why the command failed. However, in selftest, it causes
the TestCaseInTempDir._remove_tempdir() assertion to fire. Because this
assert actually gets run as part of the teardown, the assertion gets
treated as an error rather than a failure (and so we can't knownfail the
backup tests). To get around this, we remove any files in the tempdir
prior to calling self.fail().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2e235bda9f7e0aa8bce4846264eecd2e051a6c57">2e235bda</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-11-27T02:43:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/test: PY3 port samba.tests.domain_backup

The restoredc already runs under python3, so before we can run the
domain_backup tests against the restoredc, we need to make sure they
work under python3.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Noel Power <noel.power@suse.com>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/738418ea3ee669b1b917f4b8a6da1f69fa3558f1">738418ea</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-27T02:43:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Run backup tests against restoredc (SMBv1 disabled)

Running the backup tests against the restoredc highlights that the
backup online/rename commands don't work if SMBv1 is disabled. Note that
the offline commands still work because they don't rely on an SMB
connection to the server.

(Note that running the backup tests against the restoredc is probably a
good idea anyway, to prove that there's no limit to the number of times
you can restore a domain from backup, i.e. we support more than just a
one-off restore).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cbcd8eec6ea7eb32d4860eefdec5009ff274e967">cbcd8eec</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-27T02:43:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Work out DOMSID via samdb rather than environs

Not all testenvs have the DOMSID set as an environment variable.
However, it's easy enough to work out from querying the samdb.

This is a slight change in that we use a source4-generated loadparm
to connect to the DB (self.lp is source3-generated, presumably for
some SMB connection dependency).

This change is so we can run the ntacls_backup tests against a DC with
SMBv1 disabled (the restoredc). Note that currently the tests fail in
the smb.SMB() connection in the setUp(), so we can't run them as part
of autobuild just yet (because we can't known-fail test errors).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0d15c2be6a2b8b70b9898326e8c5176cbcdb1ca6">0d15c2be</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-27T05:57:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Rework backup test inheritance to make LP constraints clearer

The backup tests have a special constraint where we always want to use
check_output() over runcmd(). The reason is we need the samba-tool
backup/restore commands executed in a separate process. Otherwise the
global underlying LoadParm can accumulate settings from earlier test
case runs.

We can avoid someone in future inadvertently running runcmd() by
mistake, by simply changing the inheritance so we no longer inherit from
SambaToolCmdTest (so the runcmd functions are no longer present).

The comment explaining this has been moved to the top of the file.

Note that the TestCaseInTempDir inheritance was redundant.
BlackboxTestCase inherits from TestCaseInTempDir (and SambaToolCmdTest
was inheriting from BlackboxTestCase).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Tim Beale <timbeale@samba.org>
Autobuild-Date(master): Tue Nov 27 06:57:03 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/55a82f907f6410ff478e82b0cf7f1caeacaf5ddd">55a82f90</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-27T06:13:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_error_inject: add pwrite

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13688

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/523a9b312c9f09178a5afefb48343e684e41d817">523a9b31</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-27T06:13:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_error_inject: add EBADF error

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13688

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/48ddb87a32ca44c2fcc5aac0cc28c5527dc7eade">48ddb87a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-27T06:13:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: add a test-suite for VSS

This test will not be run from the main torture test runner in selftest,
as there we don't pass the required arguments 'twrp_file' and
'twrp_snapshot'.

The test needs a carefully prepared environment with provisioned
snapshot data, so the test will be started from a blackbox test
script. That comes next.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13688

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/12778f015988f7e8755016c72c26939998758dae">12778f01</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-27T06:13:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:script/tests: add a test for VSS write behaviour

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13688

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87bf06ed790dad8a4f650c0cd1b6781864666cbf">87bf06ed</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-27T06:13:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_shadow_copy2: add _already_converted arg to shadow_copy2_strip_snapshot_internal()

Not used for now, all existing callers pass NULL.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13688

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/14d6488d355e960ab02e72c414cbbc316f1db718">14d6488d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-27T06:13:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_shadow_copy2: add shadow_copy2_strip_snapshot_converted

Can be used by callers to determine if a path is in fact pointing at a
file in a snapshot. Will be used in the next commit.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13688

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cf95756235f718478e556ce1fbf7c032f9c9acfb">cf957562</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-27T06:13:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_shadow_copy2: nicely deal with attempts to open previous version for writing

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13688

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cfffa2e2428b42db65a4ece00602e0cef8ceb5a3">cfffa2e2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-27T06:13:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:selftest: add a VSS test reading a stream

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13455

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bffc540bc8459cbb1bd1a98528fb1d3b2b54d1d2">bffc540b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-27T06:13:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: prepare filename_convert_internal() for twrp

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13455

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c69bd336a17ca04dbfb4f5d04a963d25b9925118">c69bd336</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-27T06:13:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: add twrp processing to filename_convert_internal()

Not used for now, existing callers pass NULL.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13455

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/14b6e6842b76d7c3e53249ba026a3ff51615ebd7">14b6e684</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-27T06:13:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: add twrp args to filename_convert()

All existing callers pass NULL, no change in behaviour.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13455

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c462e1b324ebad60c51bd6e8e659b39a31ec02e">9c462e1b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-27T06:13:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: pass down twrp from SMB2_CREATE to filename_convert()

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13455

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa1fac696956f96e89e54ddd4535a6e2844161b0">aa1fac69</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-27T06:13:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_shadow_copy2: in fstat also convert fsp->fsp_name and fsp->base_fsp->fsp_name

Stacked VFS modules might use the file name, not the file
handle. Looking at you, vfs_fruit...

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13455

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f2e939b65b4cd79f8f06a49297853d6896176664">f2e939b6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-27T06:13:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libads: Give krb5_errs.c its own header

The protos were declared in lib/krb5_wrap but the functions are not
available there.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1de97717893fd9619b46eaa04c3024f3d6461295">1de97717</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-27T06:13:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libgpo: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d5484573725cb97b0c16e32985c44b15807028d">1d548457</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-27T06:13:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libgpo: Align integer types

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d2b2d89770ae1c9175564cf165e0cf2ea1898399">d2b2d897</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-27T06:13:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f14465333697f24bce8fb8430b72c64bfcb519d6">f1446533</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-27T06:13:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a1ca40e63cfc7e575091fae5522639722086b0b8">a1ca40e6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-27T06:13:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Use dom_sid_str_buf

Also fix a DBG format string specifier

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e168a6738b287524738615046f65a3298d717b70">e168a673</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-27T06:13:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Fix "wbint_Principals" definition

A signed integer does not make any sense for an IDL array length

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8be87034d40e51a8dd897fa5dae01e1ec8ebc648">8be87034</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-27T06:13:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">idmap_cache: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b289d15b85cd7d2e92b4d63d53eb6ea4d97d72b9">b289d15b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-27T06:13:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0d5287fb96a7ac9c29ff65af90a7e0c4d099fde1">0d5287fb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-27T06:13:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bb7c3b7c8f600c8e5e0c35325968163d7ffa3c53">bb7c3b7c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-27T09:38:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Nov 27 10:38:11 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1f42e62e46f733f1df460f9427ea86bcb429462e">1f42e62e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-27T20:42:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">notifyd: Improve a debug message

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Nov 27 21:42:24 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c3f6085991938488b9e48611b4beb5bdc9cbfb04">c3f60859</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-11-28T07:22:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: prevent self-referencing CNAME

Stops the user from adding a self-referencing CNAME over RPC, which is an easy
mistake to make with samba-tool.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13600

Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/97b426babaa2a812946c77bd841a33c1a9399ab5">97b426ba</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-11-28T07:22:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-14629 dns: CNAME loop prevention using counter

Count number of answers generated by internal DNS query routine and stop at
20 to match Microsoft's loop prevention mechanism.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13600

Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b6e9c4b8bbd63fbf29f576d98ee7ff1154a90565">b6e9c4b8</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-11-28T07:22:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16841 heimdal: Fix segfault on PKINIT with mis-matching principal

In Heimdal KRB5_KDC_ERR_CLIENT_NAME_MISMATCH is an enum, so we tried to double-free
mem_ctx.

This was introduced in 9a0263a7c316112caf0265237bfb2cfb3a3d370d for the
MIT KDC effort.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13628

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c835e27a998fa6bfb49a48581c65224c4c02880e">c835e27a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-11-28T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16841 selftest: Check for mismatching principal in certficate compared with principal in AS-REQ

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13628
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d2c98abde12d11d64cc62697f633fc5db75502ef">d2c98abd</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2018-11-28T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16851 ldap_server: Check ret before manipulating blob

In the case of hitting the talloc ~256MB limit, this causes a crash in
the server.

Note that you would actually need to load >256MB of data into the LDAP.
Although there is some generated/hidden data which would help you reach that
limit (descriptors and RMD blobs).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13674

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c1d4033e09acd5f7edfbafaf04b3b410a5b8e574">c1d4033e</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-28T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16852 dcerpc dnsserver: Verification tests

Tests to verify
Bug 13669 - (CVE-2018-16852) NULL
            pointer de-reference in Samba AD DC DNS management

The presence of the ZONE_MASTER_SERVERS property or the
ZONE_SCAVENGING_SERVERS property in a zone record causes the server to
follow a null pointer and terminate.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13669

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2b00f8fa9fdcecbd6951f09d528531c5585b9778">2b00f8fa</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-28T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16852 dcerpc dnsserver: Ensure properties are handled correctly

Fixes for
Bug 13669 - (CVE-2018-16852) NULL
            pointer de-reference in Samba AD DC DNS management

The presence of the ZONE_MASTER_SERVERS property or the
ZONE_SCAVENGING_SERVERS property in a zone record causes the server to
follow a null pointer and terminate.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13669

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a12a001466b21cfb27cb77ee01b11d84bcb36b4">9a12a001</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-28T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16852 dcerpc dnsserver: refactor common properties handling

dnsserver_common.c and dnsutils.c both share similar code to process
zone properties.  This patch extracts the common code and moves it to
dnsserver_common.c.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13669

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/07c49d25cdca605bd84294603713d51f913a7ed2">07c49d25</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-11-28T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16853 build: The Samba AD DC, when build with MIT Kerberos is experimental

This matches https://wiki.samba.org/index.php/Running_a_Samba_AD_DC_with_MIT_Kerberos_KDC

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13678

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c5370a4349d381ba3b64b063dc28a2c54cfacdfc">c5370a43</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-11-28T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16853 WHATSNEW: The Samba AD DC, when build with MIT Kerberos is experimental

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13678

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf0e9041becde3ad15e03d820cd2919c708dd9f5">bf0e9041</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2018-11-28T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16853: Fix kinit test on system lacking ldbsearch

By fixing bindir variable name.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13571

Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6c453aeb0c771d14fe501e9a37d9f51b9403872b">6c453aeb</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2018-11-28T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16853: The ticket in check_policy_as can actually be a TGS

This happens when we are called from S4U2Self flow, and in that case
kdcreq->client is NULL.  Use the name from client entry instead.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13571

Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c556ac5c66bf31e9065e723541ff6173e16ca70b">c556ac5c</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2018-11-28T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16853: Add a test to verify s4u2self doesn't crash

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13571

Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7cddbcf039a7a67df2bae1779254e2a136f673f0">7cddbcf0</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T07:22:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16853: Do not segfault if client is not set

This can be triggered with FAST but we don't support this yet.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13571

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6ab51b2af90f5dca11b8587b2a16215ab4497069">6ab51b2a</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2018-11-28T07:22:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16853: fix crash in expired passowrd case

When calling encode_krb5_padata_sequence() make sure to
pass a null terminated array as required.

Fixes expired passowrd case in samba4.blackbox.kinit test.

Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77de8278e4b467b66a477c09945a9bcc6b08b194">77de8278</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-28T07:22:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16857 tests: Sanity-check password lockout works with default values

Sanity-check that when we use the default lockOutObservationWindow that
user lockout actually works.

The easiest way to do this is to reuse the _test_login_lockout()
test-case, but stop at the point where we wait for the lockout duration
to expire (because we don't want the test to wait 30 mins).

This highlights a problem currently where the default values don't work.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13683

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c7b937c5aae40483f2f37727758ed50877f17a5b">c7b937c5</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-28T07:22:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16857 dsdb/util: Correctly treat lockOutObservationWindow as 64-bit int

Commit 442a38c918ae1666b35 refactored some code into a new
get_lockout_observation_window() function. However, in moving the code,
an ldb_msg_find_attr_as_int64() inadvertently got converted to a
ldb_msg_find_attr_as_int().

ldb_msg_find_attr_as_int() will only work for values up to -2147483648
(about 3.5 minutes in MS timestamp form). Unfortunately, the automated
tests used a low enough timeout that they still worked, however,
password lockout would not work with the Samba default settings.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13683

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/13014aea13a77f6a75ab948e2a29d814ebd9dd22">13014aea</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-28T07:22:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16857 dsdb/util: Fix lockOutObservationWindow for PSOs

Fix a remaining place where we were trying to read the
msDS-LockoutObservationWindow as an int instead of an int64.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13683

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fde9f7c81b42419e71b2fc8c31d92db4a05176af">fde9f7c8</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-11-28T10:31:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16857 dsdb/util: Add better default lockOutObservationWindow

Clearly the lockOutObservationWindow value is important, and using a
default value of zero doesn't work very well.

This patch adds a better default value (the domain default setting of 30
minutes).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13683

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Wed Nov 28 11:31:14 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8e24596d53b41827135fc48d0603173265b41b1">f8e24596</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-28T11:59:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tfork/test: ensure all threads start with SIGCHLD unblocked

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b6cd7f8c2c92b8fd1a8371abde79acbe0007676c">b6cd7f8c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-28T11:59:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tfork: TFORK_ANNOTATE_BENIGN_RACE

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b92d790515306c6458b56cd7341e87134821f5cd">b92d7905</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-28T11:59:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tfork: add a suppresssions file for helgrind

tfork_atexit_unknown[1|2]:

  No idea what triggers this, definitely not tfork itself.

tfork_pthread_get_specific:

 Helgrind reports:

 Possible data race during read of size 4 at 0x5141304 by thread #3
 Locks held: none
    at 0x50E602E: tfork_global_get (tfork.c:301)
    by 0x50E69B1: tfork_create (tfork.c:737)
    by 0x2F7419: tfork_thread (tfork.c:431)
    by 0x4C35AC5: mythread_wrapper (hg_intercepts.c:389)
    by 0x8D38593: start_thread (pthread_create.c:463)
    by 0x9A70E6E: clone (clone.S:95)

 This conflicts with a previous write of size 4 by thread #2
 Locks held: none
    at 0x8D3F7B7: pthread_key_create (pthread_key_create.c:41)
    by 0x50E5F79: tfork_global_initialize (tfork.c:280)
    by 0x8D3FEA6: __pthread_once_slow (pthread_once.c:116)
    by 0x50E6999: tfork_create (tfork.c:728)
    by 0x2F7419: tfork_thread (tfork.c:431)
    by 0x4C35AC5: mythread_wrapper (hg_intercepts.c:389)
    by 0x8D38593: start_thread (pthread_create.c:463)
    by 0x9A70E6E: clone (clone.S:95)
  Location 0x5141304 is 0 bytes inside global var "tfork_global_key"
  declared at tfork.c:122

  This is nonsense, tfork_global_get() calls pthread_getspecific, so
  we're looking at the pthread_key_create()/pthread_[g|s]etspecific()
  API here which works with threads by design.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0a0daebaab81343e66d0c48faa336b69b8e13e3b">0a0daeba</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-28T11:59:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tfork: add a suppresssions file for drd

drd reports:

 initialized twice: cond 0x514f188
    at 0x4C3A399: pthread_cond_init_intercept (drd_pthread_intercepts.c:1022)
    by 0x4C3A399: pthread_cond_init@* (drd_pthread_intercepts.c:1030)
    by 0x50F3FF3: tfork_atfork_child (tfork.c:250)
    by 0x9A4B95D: fork (fork.c:204)
    by 0x50F4834: tfork_start_waiter_and_worker (tfork.c:581)
    by 0x50F4CDB: tfork_create (tfork.c:780)
    by 0x2F7469: tfork_thread (tfork.c:431)
    by 0x4C358F8: vgDrd_thread_wrapper (drd_pthread_intercepts.c:444)
    by 0x8D46593: start_thread (pthread_create.c:463)
    by 0x9A7EE6E: clone (clone.S:95)
 cond 0x514f188 was first observed at:
    at 0x4C3A399: pthread_cond_init_intercept (drd_pthread_intercepts.c:1022)
    by 0x4C3A399: pthread_cond_init@* (drd_pthread_intercepts.c:1030)
    by 0x50F413A: tfork_global_initialize (tfork.c:287)
    by 0x8D4DEA6: __pthread_once_slow (pthread_once.c:116)
    by 0x4C377FD: pthread_once_intercept (drd_pthread_intercepts.c:800)
    by 0x4C377FD: pthread_once (drd_pthread_intercepts.c:806)
    by 0x50F4C0E: tfork_create (tfork.c:743)
    by 0x2F7469: tfork_thread (tfork.c:431)
    by 0x4C358F8: vgDrd_thread_wrapper (drd_pthread_intercepts.c:444)
    by 0x8D46593: start_thread (pthread_create.c:463)
    by 0x9A7EE6E: clone (clone.S:95)

This is intentional, the reinit is in a child process. Cf the comment in
tfork.c.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8bde5ea169afa62e82fb2443877b4eef6f28fece">8bde5ea1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-11-28T14:57:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tfork: add a README how to run test torture test under valgrind

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Nov 28 15:57:43 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f43ac073b28606c823a101d4f3a83444af879647">f43ac073</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-28T16:44:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">credentials: Only do shallow copies of valid ccaches

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c59f5f2977341ea0aa5a16bcd14b657bfdf59907">c59f5f29</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-28T16:44:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">credentials: Fix an error path memleak

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/730beac16200b92dc6dd85a11747940d6f50600d">730beac1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-28T16:44:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">credentials: Fix set_ccache with empty creds cache

This is an extension of bb2f7e3aee7e9b8: Without this fix in the
"empty ccache" case we never set cred->ccache, so the whole call to
cli_credentials_set_ccache became pointless

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c39526eb7d19e97f001690834e8f3bfa03f4d20e">c39526eb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-28T16:44:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">credentials: Remove an unnecessary talloc_steal()

ccc was already allocated off cred, this talloc_steal was a no-op.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a167014554c9cac1ed751adce488dce164da5979">a1670145</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-28T16:44:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_wrap: Add a talloc_ctx to smb_krb5_principal_get_realm()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/899bbb44074b843e144b3f61795d4ac43268e599">899bbb44</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-28T16:44:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Align integer types

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/130e034fbb7d13a54deb2421bf36eba4ed816f1b">130e034f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-28T16:44:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Align integer types

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3be9ffe44565bc58fa7733fcd1b86952d9f7b138">3be9ffe4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-11-28T20:15:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_wrap: Fix a typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Nov 28 21:15:31 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/63a48e64871cbfa36c4f9686a36a951711135114">63a48e64</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:replace: Check if HAVE_DECL_ENVIRON is defined first

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f28d8e89637b870d788e5259539d8e8bec74bd5">9f28d8e8</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: Remove unsused MMAP_BLACKLIST ifdef checks

This doesn't get defined by anything.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bebab0760905f7251a1bf22ad88741043d642901">bebab076</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Do not always set _FORTIFY_SOURCE=2

This requires to be compiled with optimization (-O).

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9477eb3bd1faabe182710859201cbacb9f76763">a9477eb3</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Add _FORTIFY_SOURCE=2 to the -O3 build

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ab5f26f3f3bf14462dd8fbe645397e236640c615">ab5f26f3</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ded788bccbb1bfc749f7edcdad6ec2113b992356">ded788bc</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_wrap: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f2cd92c8e9527b0e45e6017345c0551776133a4">9f2cd92c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e8e17209051b6a1c8c95cb21b31f85afb61a17e">4e8e1720</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/80750253032843f919ea8ab48698f54c98968e4d">80750253</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e7f0b6e41fa3db68f588b91a6a7c25cf58aa815a">e7f0b6e4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Avoid name confusion with config.h

The HAVE_* is normally used for config.h definitions, so rename it to
USE_ASM_BYTEORDER.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aee760cdc93934225acd0cd8eb5cb0fafaae7717">aee760cd</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b51e8b980801f635bffe57a648606ad388f22923">b51e8b98</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smbreadline: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d035f2492e306ddc74b1b9fe533608e0f37a1cd0">d035f249</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_plugin: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c56b16906ce56bebeac8a4f90c7671dee02b144a">c56b1690</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wbclient: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4dd2349c1171a2c09d6b4cdebe5c3242d4fd67b8">4dd2349c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wins: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0433576dfd3ce955834332c61822a4d85e61b5c9">0433576d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nss_winbind: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be04480e0872a70c7ddca0eb14ba28b9bee98990">be04480e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99a9b092ca2da884cfeae92162f2aa5f72ec3fb8">99a9b092</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:ldap: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f4694b61f2c93ec655da0a4422f133b3d7e60a51">f4694b61</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:include: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/72c6cd2d39a09966e2e3d728120283e785002c61">72c6cd2d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3f3cc42b517a2ed42e37f140a8f4186936ba44a5">3f3cc42b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77b88fd05939871c3e72bf52f3bbc96d38cd42c1">77b88fd0</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/32fda4fc64cceb8b0c268322edc9ce86cc9dfed0">32fda4fc</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c69078f3ccf46ffe897d753332e6e46a2dc37e2">0c69078f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:nmbd: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a7e10f7853a4afe628a31a8a440572fc059ef37d">a7e10f78</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/95432e30e9b2f1aa4832b045ff70bac3853f4d17">95432e30</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fce92606b356883ed9fbea6948d426345ede79cf">fce92606</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3872d4ab495027fe42790c76cf749f1809323bcc">3872d4ab</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbindd: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/788d9f31d5c5def8a042a937b730b5be31543809">788d9f31</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:lib: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c4d588f4777548f81881024e4ed0c08e3ac20b6">4c4d588f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:ntvfs: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/342c3b7dae269645a7629719ad6c1948f2e0e09e">342c3b7d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-28T22:19:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:smbd: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dbbf978ae062b49504d257a5e8c247c7f135d4db">dbbf978a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-29T01:20:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use #ifdef instead of #if for config.h definitions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Thu Nov 29 02:20:48 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e99402235da3ab0ea77f0a68393294088939ab78">e9940223</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2018-11-29T10:52:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/testparm: Reduce debug level to 1

Adhere to what we document in manual page for testparm that default
debug level is set to reasonable value 1.

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Nov 29 11:52:22 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1cf84b6b99082907596c511c86e4e8c22314b08c">1cf84b6b</a></strong>
<div>
<span>by Olly Betts</span>
<i>at 2018-11-30T02:35:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: Add support for a credentials file

Add support for the same -A authfile/--authentication-file authfile
option that most of the other tools already do.

Signed-off-by: Olly Betts <olly@survex.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/669249ae93bd492559b25539830773af3fa5cca7">669249ae</a></strong>
<div>
<span>by Olly Betts</span>
<i>at 2018-11-30T02:35:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">New testcase samba3.blackbox.net_rpc_join_creds

Tests that you can now use a credentials file with net.

Signed-off-by: Olly Betts <olly@survex.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/28aeb86a9fbc102007e3152bc6c574232204803a">28aeb86a</a></strong>
<div>
<span>by Olly Betts</span>
<i>at 2018-11-30T02:35:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix spelling mistakes

Signed-off-by: Olly Betts <olly@survex.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6af599223c51b27d5b8b6d72f52e9c273f82768d">6af59922</a></strong>
<div>
<span>by Olly Betts</span>
<i>at 2018-11-30T02:35:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net rpc share allowedusers: Allow restricting shares

The help already implies that you can specify "targets" for net rpc
share allowedusers, but actually the tail end of the command line
is just ignored.

This patch allows a list of shares to be specified, and only those
shares are checked, which can be much faster if you're only interested
in a few shares on a server which exports lots.

This subcommand already accepts an optional filename for the output
of net usersidlist, with a default of stdin.  Typically you'd just pipe
one command to the other so stdin is most likely what you want.  This
patch adds support for a filename of "-" to mean stdin so that you can
specify stdin explicitly when you provide a list of shares, since in
this case the filename can't be omitted.

Signed-off-by: Olly Betts <olly@survex.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3d9ba1b7e6cbc0833b8ff2f92673c9403b6f9038">3d9ba1b7</a></strong>
<div>
<span>by Olly Betts</span>
<i>at 2018-11-30T02:35:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix net rpc share allowedusers short description

This command allows one to list allowed users, not modify them.

Signed-off-by: Olly Betts <olly@survex.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/06061d39c1031b223edc126ccb960ceb4b0b3d59">06061d39</a></strong>
<div>
<span>by Olly Betts</span>
<i>at 2018-11-30T02:35:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add simple tests for net rpc share allowedusers

Signed-off-by: Olly Betts <olly@survex.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f03392a0aef9da195b1f9cb2442802d82e2dcb55">f03392a0</a></strong>
<div>
<span>by Daniel Southward-Ellis</span>
<i>at 2018-11-30T06:07:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Converted README to markdown

Signed-off-by: Daniel Southward-Ellis <danielsouthwardellis@catalyst.net.nz>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Fri Nov 30 07:07:36 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d8b3280780cf9b4b67b31839cc4f34b5539194dd">d8b32807</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-11-30T07:12:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">util: Fix include file order

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b3490049574d2e9651a402d6335fa23cefb182c5">b3490049</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-11-30T10:41:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Correctly check for 'extern char **environ' in unistd.h

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Nov 30 11:41:44 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2381b4ff6794ba514cca57d3995459bc2cef8352">2381b4ff</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-30T10:42:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4 smbd standard tests: limit forked processes

Tests to confirm the standard process model honours the smbd.conf
variable "max smbd processes", when forking a new process on accept.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f90cf49970a0edf4dce5d145726a04e798530a2e">f90cf499</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-30T10:42:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4 smdb standard: Limit processes forked on accept.

Limit the number of processes started by the standard model on accept.
For those services that support fork on accept, the standard model forks
a new process for each new connection. This patch limits the number of
processes to the value specified in 'max smbd processes', a value of
zero indicates that there is no limit on the number of processes that
can be forked.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5b627edc55683417e7ac56d3aff7b7aa7cec5d92">5b627edc</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-11-30T14:05:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: standard process limits

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Nov 30 15:05:04 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/46a6c6ff6d2fc68e313bcb2cd2c65b5a6e7c1782">46a6c6ff</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-02T06:52:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: avoid dereferencing fsp->base_fsp in fruit_fstat_meta_stream()

This helps avoiding a NULL dereference on systems where additional
patches modify the following condition in open_file()

  if ((open_access_mask & (FILE_READ_DATA|FILE_WRITE_DATA|FILE_APPEND_DATA|FILE_EXECUTE)) ||
      (!file_existed && (local_flags & O_CREAT)) ||
      ((local_flags & O_TRUNC) == O_TRUNC) ) {

to

  if ((open_access_mask & (FILE_READ_DATA|FILE_WRITE_DATA|FILE_APPEND_DATA|FILE_EXECUTE|DELETE_ACCESS)) ||
      (!file_existed && (local_flags & O_CREAT)) ||
      ((local_flags & O_TRUNC) == O_TRUNC) ) {

Ie addtionally check open_access_mask against DELETE_ACCESS. As a result
opens with DELETE_ACCESS go through the code that does an fd_open() plus
a subsequent fstat().

That will trigger a crash in fruit_fstat_meta_stream() when a client
wants to delete a file for deletion. When we open base file for delete,
we call open_streams_for_delete() which internally calls create-file
with NTCREATEX_OPTIONS_PRIVATE_STREAM_DELETE which prevents opening of
the base_fsp. Voila, combined with the change described above you get a
NULL deref.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sun Dec  2 07:52:34 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd7574afd1b2fb6a88defa154bc3d15e94f9ce0d">dd7574af</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-12-03T05:56:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Exit with error if a database directory does not exist

Since 4.9.0, the log messages can be confusing if a required database
directory does not exist.  Explicitly check for database directories,
logging a clear error and exiting if one is missing.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13696

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon Dec  3 06:56:41 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e9b3ed4126fad653f219334cbca2dbf53ddfc20">4e9b3ed4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-03T20:16:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Fix uninitialized variable

util_tdb.c:116:7: error: ‘len’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
   buf += len;
       ^~
../../source3/lib/util_tdb.c:44:6: note: ‘len’ was declared here
  int len;
      ^~~

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/86592673fbd3399b35832ca138681b06cb007b2c">86592673</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-03T20:16:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Fix undefined behavior in tdb_pack()

util_tdb.c:98:5: runtime error: null pointer passed as argument 2, which
is declared to never be null

This means the second argument of memcpy() can't be NULL.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2b2edccb5a90f23db0bd733551ac645d6ac4e44f">2b2edccb</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-03T23:23:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Fix undefined behavior in tdb_unpack()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Tue Dec  4 00:23:03 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/14399fd818b130a6347eec860460929c292d5996">14399fd8</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-12-04T04:32:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-14629: Tests to expose regression from dns cname loop fix

These tests expose the regression described by Stefan Metzmacher in
discussion on the bugzilla paged linked below.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13600
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/34f4491d79b47b2fe2457b8882f11644cf773bc4">34f4491d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-04T07:52:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-14629 dns: fix CNAME loop prevention using counter regression

The loop prevention should only be done for CNAME records!

Otherwise we truncate the answer records for A, AAAA or
SRV queries, which is a bad idea if you have more than 20 DCs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13600

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Dec  4 08:52:29 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b0af029504d0c8bee6d7a1976356e4ac19a52c91">b0af0295</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-12-04T08:17:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Minor changes to 'group stats' command

These changes were inadvertently left off 0c910245fca70948a3.
(They were made to the 2nd patch-set iteration posted to the
mailing-list, but for some reason the first patch-set got delivered).

Changes are:
+ rework some variable names for better readability
+ Average members defaulted to int, so lost any floating point
precision.
+ Replace 'Min members' (which was fairly meaningless) with 'Median
members per group'.
+ Fix flake8 long line warnings

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d662c411e12fe9a81cdb2504af2a81d1d7b8c092">d662c411</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-12-04T08:17:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add test-case for 'group list --verbose'

Check that the number of members reported is correct.
(This change somehow got left off the ca570bd4827aa commit that was
actually delivered).

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/13f57a7f80ea49830509e16b6fb8776962eba74f">13f57a7f</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-12-04T08:17:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: Rework how assignments are generated slightly

We want to cap the number of members that can be in a group. But first,
we need to tweak how the assignment dict gets generated, so that we get
rid of the intermediary set.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5517d60653b0aa25a354c3a35cbfb2aa89afb41a">5517d606</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-12-04T11:22:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Add a max-members option to cap group size

traffic_replay tries to distribute the users among the groups in a
realistic manner - some groups will have almost all users in them.
However, this becomes a problem when testing a really large database,
e.g. we may want 100K users, but no more than 5K users in each group.

This patch adds a max-member option so we can limit how big the groups
actually get.

If we detect that a group exceeds the max-members, we reset the group's
probability (of getting selected) to zero, and then recalculate the
cumulative distribution. The means that the group should no longer get
selected by generate_random_membership(). (Note we can't completely
remove the group from the list because that changes the
list-index-to-group-ID mapping).

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Dec  4 12:22:50 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dfbfb7eb941b68ce75adc3ece25915b2eefaf886">dfbfb7eb</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-12-04T17:45:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: Utils package not defined

Fix the package name for the WafError routine.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>

Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Tue Dec  4 18:45:38 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3b38dddff2c1d1b51aed96368b358f349682bea0">3b38dddf</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-05T00:38:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add gooduser and eviluser to Samba3

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13699

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cc471448df91c43fe38e2fcdf9b3874636ca51a6">cc471448</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-05T00:38:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:tests: Test for users connecting to their 'homes' share

This adds a test for CVE-2009-2813.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13699

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99695528f7453023446956d5f8f0656574e243af">99695528</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-05T00:38:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Make sure we do not export "/" (root) as home dir

If "/" (root) is returned as the home directory, prevent exporting it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13699

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a92f0ccce606be12e851a4100fbb44b069c5fe87">a92f0ccc</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-05T04:22:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:tests: Add test for checking that root is not allowed as home dir

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13699

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Dec  5 05:22:43 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c46b6b111e8adcd7cf029e5c3293cbdc471793db">c46b6b11</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-05T07:12:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: test wbinfo -n and --gid-info with "NT Authority"

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12164

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2de5f06d399109009c343b0acfef822db38502a1">2de5f06d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-05T07:12:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/security: add dom_sid_lookup_is_predefined_domain()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12164

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e0f784baeaa73096534d9a1ed941028d99f84ece">e0f784ba</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-05T07:12:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: add some braces

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12164

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b512a58bbd7361cbbcf68f6713943377338fc2a1">b512a58b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-05T07:12:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: fix predefined domains routing in find_lookup_domain_from_sid()

Route predefined domains through the BUILTIN domain child, not passdb.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12164

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b8d9fdad4a4e2c479141b3d40e9a7320a49c0dd">8b8d9fda</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-05T10:27:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Route predefined domains through the BUILTIN domain child

Without this eg "NT Authority" didn't work:

  $ bin/wbinfo -n "NT Authority/Authenticated Users"
  failed to call wbcLookupName: WBC_ERR_DOMAIN_NOT_FOUND
  Could not lookup name NT Authority/Authenticated Users

  $ bin/wbinfo --group-info="NT Authority/Authenticated Users"
  failed to call wbcGetgrnam: WBC_ERR_DOMAIN_NOT_FOUND
  Could not get info for group NT Authority/Authenticated Users

With the patch:

  $ bin/wbinfo -n "NT Authority/Authenticated Users"
  S-1-5-11 SID_WKN_GROUP (5)

  $ bin/wbinfo --group-info="NT Authority/Authenticated Users"
  NT AUTHORITY\authenticated users:x:10002:

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12164

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Dec  5 11:27:22 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a83e4a24abd4116c78b7fa775b7f05511d843481">a83e4a24</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-05T12:35:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools: remove unused buildtools/bin/waf-1.9

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8ba0a9a1abb8bbe1df5ff808645adf305bc4e0b3">8ba0a9a1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-05T12:35:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/wscript: use python 3.6 compatible functions

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/19d71597b078544e0527a5d07b65c454e4534931">19d71597</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-05T12:35:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: add MODE_{744,_777}

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f87d6cbfff3ebb74fe09b9547676f16ecd8547a8">f87d6cbf</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-05T12:35:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/wscript: make use of MODE_{644,744,755,777}

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5674c21c1156bab0c0ec461e4db147f431ec50d6">5674c21c</a></strong>
<div>
<span>by Daniel Southward-Ellis</span>
<i>at 2018-12-05T15:35:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Added redirect from GitHub to GitLab

Signed-off-by: Daniel Southward-Ellis <danielsouthwardellis@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Dec  5 16:35:33 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1327e2f40f4b7b05f8e636922c2b1cf17edc2903">1327e2f4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-06T00:43:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests:docs: reindent special_cases to one by line

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/69521c17bb62c6c35498083470bf00277a3cec89">69521c17</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-06T00:43:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests:docs: add a exceptions set

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ea36967c04daba6fdc349222240a0847b6ca2385">ea36967c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-06T00:43:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml: add "smbd search ask sharemode"

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ea41bf46d8ad43dacd71422acfe184d5262a497a">ea41bf46</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-06T00:43:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: use lp_smbd_search_ask_sharemode()

Parametric options have a performance impact, use the normal options
added in the previous commit.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/040a2c1729609837a4946f009d7b5a88515a9ba7">040a2c17</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-06T00:43:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml: add "smbd async dosmode"

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/54b7132d10605102f69b3dbb4c79c7aa9e4fdd62">54b7132d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-06T00:43:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: use lp_smbd_async_dosmode()

Parametric options have a performance impact, use the normal options
added in the previous commit.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/14132e89b4b9ac6712fe6f49945da3f4d987cc14">14132e89</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-06T00:43:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml: add "smbd max async dosmode"

The parameter is added to the lists of ignored-paremteres in the
samba.docs tests, as the given default "aio max threads * 2" works only
as manpage string.

"aio max threads" can only be calculated at run time and requires a
handle to a pthreadpool_tevent which loadparm will never have.

Because of that lp_smbd_max_async_dosmode() will always return 0 as
default and it's up to the caller to calculate "aio max threads * 2" if
lp_smbd_max_async_dosmode() returns 0. Cf the next commit.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/941d7e159a8098b12294ca561fd8e4b8f235c18f">941d7e15</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-06T00:43:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: use lp_smbd_max_async_dosmode()

Parametric options have a performance impact, use the normal options
added in the previous commit.

"aio max threads" can only be calculated at run time and requires a
handle to a pthreadpool_tevent which loadparm will never have.

Because of that lp_smbd_max_async_dosmode() will always return 0 as
default and it's up to us to calculate "aio max threads * 2" if
lp_smbd_max_async_dosmode() returns 0.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/38d819e89924e2a93d7e3fca14471497d5d24d25">38d819e8</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-06T00:43:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml: add "smbd getinfo ask sharemode"

Counterpart for "smbd search ask sharemode" for getinfo.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a6606d87739b29962d09c7954c07cb4c25811afd">a6606d87</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-06T00:43:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use lp_smbd_getinfo_ask_sharemode()

Counterpart for "smbd:search ask sharemode" for getinfo.

Pair-Programmed-With: Volker Lendecke <vl@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9aad13cbad06e753a79610996cbe64823f5eda35">9aad13cb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-06T04:14:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: document changes in SMB server parametric options

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Dec  6 05:14:03 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d9e95849e3e09fd4dc40cf9c82030b033117ae98">d9e95849</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-06T07:48:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc:ndr: Fix undefined behavior in ndr_basic

librpc/ndr/ndr_basic.c:723:2: runtime error: null pointer passed as
argument 2, which is declared to never be null

The following triggered the undefined behavior:

(gdb) bt
    at librpc/gen_ndr/ndr_drsuapi.c:2318
    fn=0x7ffff6e72983 <ndr_push_drsuapi_DsReplicaObjectIdentifier3Binary>) at ../../librpc/ndr/ndr.c:1337
    at ../../source4/dsdb/schema/schema_syntax.c:2136
    drs_str=<optimized out>) at ../../source4/dsdb/schema/tests/schema_syntax.c:122
    already_setup=<optimized out>, restricted=restricted@entry=0x0) at ../../lib/torture/torture.c:442
    at ../../lib/torture/torture.c:507
    suite=0x5555563d9490, matched=0x7fffffffcef7) at ../../source4/torture/smbtorture.c:93
    matched=0x7fffffffcef7) at ../../source4/torture/smbtorture.c:95
    at ../../source4/torture/smbtorture.c:143
(gdb) f 1
1335            NDR_CHECK(ndr_push_bytes(ndr, blob.data, blob.length));
(gdb) p blob
$2 = {data = 0x0, length = 0}

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Thu Dec  6 08:48:28 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bd4bdced5ff310a5e5e3fe05ed491cf1826407d1">bd4bdced</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-12-06T11:03:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Don't run KCC on backup testenvs (to avoid flappiness)

KCC onthe backup domain (i.e. backupfromdc, restoredc, offlinebackupdc)
can establish new connections for replication. Depending on timing,
this can cause the join_ldapcmp test to fail, because there's an extra
object under the NTDS Settings, at the point the ldapcmp is done.

We don't need any replication to happen on the backup domain. The
backup/restore workflow in the real world should mean that the restored DC
is never run in the same network as the original DC.

This patch updates the default KCC command for the backup testenvs to be
a no-op, so the DCs won't create new connection objects.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Dec  6 12:03:53 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2f68c436cc857dd6c56ec75e03664388f5d1da2b">2f68c436</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-06T15:53:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript_configure_system_mitkrb5: reject a system heimdal krb5-config

Review with: git show -w

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Dec  6 16:53:33 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dcd68bce1826641d4d881ad5c94c251a6ab175f0">dcd68bce</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-12-07T06:07:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: complex expression testing

Tests that prepare complex ldap expressions and equivalent python expressions,
then compare the results of the two.

Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>

Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Fri Dec  7 07:07:08 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3ef29bed78c2b65050639bc060cdf1ed6e4b6491">3ef29bed</a></strong>
<div>
<span>by Daniel Southward-Ellis</span>
<i>at 2018-12-07T06:08:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Changed web page to webpage

Signed-off-by: Daniel Southward-Ellis <danielsouthwardellis@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a628c2c4e1f690dd37849548d54048ecfc30697">9a628c2c</a></strong>
<div>
<span>by Daniel Southward-Ellis</span>
<i>at 2018-12-07T06:08:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Added link to How to do Samba: Nicely

Signed-off-by: Daniel Southward-Ellis <danielsouthwardellis@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2ba30ee22d55317204601a33955eddbd630776af">2ba30ee2</a></strong>
<div>
<span>by Daniel Southward-Ellis</span>
<i>at 2018-12-07T06:08:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Updated Website section

Signed-off-by: Daniel Southward-Ellis <danielsouthwardellis@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/684b530aa729011a52af760658ab7169ae0b004c">684b530a</a></strong>
<div>
<span>by Daniel Southward-Ellis</span>
<i>at 2018-12-07T06:08:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Changed GitHub info to GitLab

Signed-off-by: Daniel Southward-Ellis <danielsouthwardellis@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/61068ada6f863f0517664f7cf4dc9b6ba15a7bd6">61068ada</a></strong>
<div>
<span>by Daniel Southward-Ellis</span>
<i>at 2018-12-07T06:08:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Updated "About Samba" Info in README

Signed-off-by: Daniel Southward-Ellis <danielsouthwardellis@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d5f9bc45e22d687c03d77afe9ada21ed79366df3">d5f9bc45</a></strong>
<div>
<span>by Daniel Southward-Ellis</span>
<i>at 2018-12-07T09:12:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Removed dead groups link from Mail List Etiquette

Signed-off-by: Daniel Southward-Ellis <danielsouthwardellis@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Dec  7 10:12:42 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b60d72f67231e7675b0fad724edd59a0b3f4444">7b60d72f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-07T14:33:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc:ndr: Give the optimizer hints for ndr_push_bytes()

Also remove the redundant check in ndr_push_DATA_BLOB.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Dec  7 15:33:38 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/382705f495dd7f196efc8bb24b9cee3649b44836">382705f4</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-12-07T18:56:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Introduce buffer.offset to avoid memmove

The memmove operation is quite expensive, therefore,
a new buffer attribute "offset" is introduced to support
an optimized buffer processing.
The optimization is to "walk" through the buffer and process
each packet until the buffer is fully processed (empty)
without requiring any memmove.
Only if a packet is in-complete, the buffer content is moved
and the new data is read from the queue.
This way almost all memmove operations are eliminated.

Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/353a947b4a983f6664391da6769b914d42612567">353a947b</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-12-07T22:27:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Adding memory pool for queue callback

The received packet is copied into a newly allocated memory chunk for further
processing by the assigned callback. Once this is done, the memory is free'd.
This is repeated for each received packet making the memory allocation / free
an expensive task. To optimize this process, a memory pool is defined which
is sized identically to the queue's buffer.
During tests it could be seen that more than 95% of all messages were sized
below the standard buffer_size of 1k.

Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Christof Schmitt <cs@samba.org>

Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Fri Dec  7 23:27:16 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99a7756598fd84bc2b62f646745b991585209815">99a77565</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-07T22:29:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net_rpc: Use dom_sid_equal where appropriate

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b080389f3ed29cde717ada6ae025672cf29fefce">b080389f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-07T22:29:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net_rpc: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a32564eaf9241d2572ce1a7023b8ceec5846f97d">a32564ea</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-07T22:29:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net_usershare: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/263edf7fe96ab7b072bd3733074e44e6ab60a80b">263edf7f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-07T22:29:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd_cache: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70b9477922ec2de81876f40bf1c8b75b085a0c3a">70b94779</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-07T22:29:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">idmap_tdb: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/166b40b2ef30aee075f609f7862f9e32f7243c80">166b40b2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-07T22:29:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f7f350ec3a25ed6af1aeac34f8eab83787fff35e">f7f350ec</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-07T22:29:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pdb_ldap: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1b3ee68b790b4a07ef4b681693fab726f98b990c">1b3ee68b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-07T22:29:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e5a3364834d425b25c6e77ac28e33dfe996234be">e5a33648</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-07T22:29:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnet: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/90de1431b91231c2ef0013fb3cfac537ca9830f1">90de1431</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-08T01:43:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpcclient: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Dec  8 02:43:48 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/81de8f0641484729e4fbfc055a1a52dcd15cd32e">81de8f06</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-12-10T01:01:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Fix hex to int conversion in h2i

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d271450f71a168898482d8c8a0f1f6bbf875804">7d271450</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2018-12-10T04:02:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Remove <file> parameter from pfetch usage info

The code does not implement saving the record data to a file, so update
the usage info accordingly.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon Dec 10 05:02:13 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6e46d9770edec2fd821df31bfe92937097ba03c6">6e46d977</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba.tests: Ensure samba-tool is called with correct python ver.

* remove unnecessary 'bin/' part of path as base BlackBox class
  will do this anyway and also ensure correct detection that
  command needs to have 'PYTHON=blah' addeded
* modify shell script so PYTHON variable if set is prepended

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/af8077e807d41042229bb3b318b93d1a0d3579b1">af8077e8</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs/blackbox: make sure samba-tool is called with correct python

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/277dbd9cffbcb5f7be3818ac34f95ac03a9f7a09">277dbd9c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch/tests: PY3 samba_tool call correct python

fix samba4.blackbox.rfc2307_mapping

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3519fcb9b79c2af38a1225bdcda742f6812ec545">3519fcb9</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/utils/test: PY3 make sure we call correct python version for samba-tool

fixes samba4.blackbox.samba_tool blackbox test

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/351ca11b0645ed167b4df0433387d24a59bbe595">351ca11b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/setup/tests: make sure samba-tool is called with correct py version

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1fb9887ea87de11515029d65c7f78873c8396e95">1fb9887e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: PY3 ord needs 'str' type not int

string_to_byte_array returns not a bytearray (as the name suggests)
but a list of byte values (int). Some code expects the list so even
using a 'real' bytearray wont work.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fdf2deb3ba18932d255e19acb08b67cb3f24f6f4">fdf2deb3</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: PY3 compat py2/p3 symbol for SocketServer/socketserver

SocketServer was renamed to socketserver in Py3, this patch
create a samba.compat.SocketServer which can be used in py2 or
py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b10c7137165c3da10f908c250c0a59d4cca821b">8b10c713</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: Py3 Use new compat.sockerserver symbol

SocketServer symbol changed in PY3 to socketserver so
we need to use a compat symbol for PY2/PY3 code.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b18748c703593a3c257c47b626966b0bd6caa3f">9b18748c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/credentials: PY3 set_password should decode from unicode 'utf8'

set_password processes input using ParseTuple with "s" format, this
accepts string or unicode but...

Some py2 code is incorrectly using code like

   credentials.set_password(pass.encode('utf8'))

however that won't work in PY3. We should just make sure the string
retrieved from unicode passed in is encoded with 'utf8'
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d253e84a41b9f18243d57c41656d28fcd07e476a">d253e84a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: PY3 Credential.set_password takes string

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0d73a2b0a29c108c3a0efbbe0473142046302b71">0d73a2b0</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: net.change_password & net.set_password take string not bytes

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a25bd836ee601ca704d2899f17259b9b5cd440cf">a25bd836</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: PY3 port samba.tests.dns

Misc hanges needed to get make test TEST=samba.tests.dns &
samb.tests.dns_fowarder to run and pass under PY3

* socket.send needs bytes not string
* rec.dwTimeStamp expects int not float (in PY3 / operator
  will give float results, for int use '//' instead)
* re.match using bytes needs a bytes search term

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/00133791d542f3c89aa4b7c2272d2150a252c3ab">00133791</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: wrap filter calls with list where list is expected

filter in PY2 returns list in PY3 it returns an iterator

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/679b640ac5e4da883d30be50cbf5c2efc7515774">679b640a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: Py3 port for samba.tests.auth_log_netlogon_bad_creds.samba

fix unicode doesn't exist error in PY3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/72921682558b0eafc1e8cd7b9ae74e81c5c2b9dc">72921682</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: PY3 fix samba4.blackbox.trust_utils test

In python3 we are using ldb.bytes where we need strings
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ac7baa6e92d46bf2b8734d25db49dc28e1bfd2c9">ac7baa6e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests/python: PY3 port samba4.sam.python test

Misc changes to ensure samba4.sam.python test will run under
python2/python3

* various objectSID values when formatted need to be treated
as strings for tests.

* DOMAIN_RID_USERS, DOMAIN_RID_DOMAIN_MEMBERS, DOMAIN_RID_DCS,
  DOMAIN_RID_READONLY_DCS are all integers (but attibutes are
  ldb.bytes in PY3, need to adust various assertEquals.
* Make sure password is encoded correctly

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/55a381716677adbd4f526769b77d9840b87a4e99">55a38171</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests: PY3 port samba4.ldap.passwordsettings test

* Fix various assertEquals comparing ldb.bytes with string
  when running with PY3
* Fix a couple of tuple assignments to exception (not supported
  in PY3)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0cd885c1ec71c4f9cbed96328cd82de27cdc091f">0cd885c1</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: fix default params for PY3 ConfigParser

The default params for the python3 version of the compat ConfigParser
are not correct. Code like
   foo = ConfigParser()
fails because of this.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d6350897d2a2ac6f2f4024f92ce9266bc4edeff">1d635089</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture/gpo: Use existing code to 'run' external commands

Noticed when the smb.conf defined 'gpo update command' contained
the $PYTHON version then the exec_wait function failed to run the
command. Seems there is some issue with the arg handling. Also
there is already existing code (samba_runcmd_send) that works fine
in similar situation (e.g. when running dnsupdate etc.) so replaced
the homebrewed exec_wait functionality with the samba_runcmd util
function.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c99450db4eed3abc3a69833a82b1c906e066e27a">c99450db</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: PY3 port gpo.apply smbtorture test

1) configparser.set requires string values
2) self.gp_db.store() etc. neex to pass str object for
   xml.etree.ElementTree.Element text attribute which needs
   to be text
3) tdb delete method needs bytes key
4) configparser.write needs a file opened in text mode

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/744acb276c7cfc2e8f859ea960282c6395362602">744acb27</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: PY3 don't call str for bytes (or str)

Note: Fix needed also for gpo.apply

minPwdAge, maxPwdAge, minPwdLength & set_pwdProperties all
have a line like

value = str(value).encode('utf8')

this is a generic type statement I guess to convert int, float etc
to utf8 encoded bytes representing the string value for those.

This worked fine in PY2 but in py3 some routine already are passing
bytes into these methods, in these cases e.g. b'200' will get converted
to "b'200'", this change only performs the conversion above for non
bytes (or str) types by replacing the above with

        if not isinstance(value, binary_type):
            value = str(value).encode('utf8')

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/750540fd5c2ca0a033373d637531a283a2be6ae6">750540fd</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/kcc: PY3 fix some str versus ldb.bytes comparisons

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0cafa9bf943c3980ffe10b1fa0bb325bb36a6fad">0cafa9bf</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: PY3 fix failing py3 samba.tests.group_audit test

Fix bytes being compared against ldb.bytes

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/991f8bfe5fba3838ace9138fa0fb59c07ffc9e45">991f8bfe</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: PY3 port failing samba.tests.auth_log_netlogon

Fix password encoding

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de9dcb12954f4f37c287991bf0f425b0a63f1ba6">de9dcb12</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: PY3 port failing samba.tests.auth_log_samlogon.py

Make sure correctly encode password to utf16 and not use
unicode (which doesn't exist in PY3)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/81043cdf0e90b77a104edddb388fb4f94eb81d28">81043cdf</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: Fix auth_log messaging problems in py3

Some tests (especially samba.tests.auth_log_netlogon_bad_creds) are
failing due to not receiving expected messages. There seems to be
some timing issue or race around the messaging bus being set up and
getting the expected events resulting from the failed netlogon.

Specifically the the order of destruction of the messaging.Messaging()
c-py objects is different under python2. Under python2 all of the
messaging.Messaging() objects are destructed *after* all the tests
are run. Note: each instance of the TestCase has it's own Messaging()
instance which is created by TestCaseXYZ.setUp, so it appears the unittest
destroys the test instances when all the tests have run whereas in
python3 we see each messaging.Messaging() instance destroyed after
each test runs.
Ok, what difference does that make ? well it seems in python3 because
each Messaging() instance is destructed after a test runs that the
associated messaging_dgm_destroy() also runs, this destroys the
global_dgm_context context which means when the next test runs the whole
messaging infrastructure needs to be built again when the next Messaging()
object is created. On the server-side this seems to result in attempts
to send messages to the listener failing first with

get_event_server: Failed to find 'auth_event' registered on the message bus to send JSON audit events to: NT_STATUS_CONNECTION_REFUSED

and subsequently with

get_event_server: Failed to find 'auth_event' registered on the message bus to send JSON audit events to: NT_STATUS_UNSUCCESSFUL

client doesn't get any more messages, test fails :-(

So, what's the difference in python2, well because the destructors for the
(4 in the case of netlogon_bad_creds) instances of Messagaging() don't run
till the end of the tests this doesn't happen and the global_dgm_context
never gets destroyed untill all the tests complete. There is some race
condition at play here, a simple sleep at the start of a failing test
fixes the problem. But... ok that isn't a possible solution here, instead
I have adjusted the base auth tests to store the Messaging() objects in a
global list forcing them to remain in scope until the tests are complete.
This ensure the behaviour is consistent across python2 & python3.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fd87c89c643f51dc37540b26e40c47f16152d96f">fd87c89c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script: Add new (temporary) pure python3 ad-dc test

Ideally we want all the tests to run under python3 by default (no
special task for this) and then convert the existing '-py3' tasks
to run the python tests with python3.
However at the moment the convertion process is not ready to do this,
for a while we need to run separate autobuild tasks for this.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c36af9c129d525be8f1840a5fab927f168fc5861">c36af9c1</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CI: Add new CI job for new build_samba_purepy3-ad-dc job

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/89c63386365c4cc38e9615b63839128f73699f05">89c63386</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CI: Remove build_samba_ad_dc_py3 CI job

We now run a purepython3 ad-dc test job, later when the whole
build is running under python3 we will resurrect build_samba_ad_dc_py3
but as (build_samba_ad_dc_py2) for python2

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fdf75084e42ee1f9162abe80cd712b3b5392e819">fdf75084</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/test: Make sure traffic_replay is called with correct python

PY3 fix samba4.blackbox.rfc2307_mapping

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd62f4b66760e574be568516c087e04577121a94">dd62f4b6</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/tests: PY3 make sure traffic_learner is called with correct python

Also path to traffic_learner is not in the normal 'bin' path so
also adjusted the insertion of PYTHON version to cover this

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b920d80ecaeee98c5e562a2c0b384fe8ace635d4">b920d80e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script: PY3 port traffic_learner

Use python3 compatable print

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9db3ad9ea1c45d9e47ca819672c9dd1a291a3cda">9db3ad9e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/blackbox: PY3 port for samba.tests.blackbox.traffic_learner

The order of the values in the TrafficModel is different,
but... also unfortunately output of json.dump is also
different (even when using sorted versions of the associated
dictionaries before dumping), these changes reimport the output
files into TrafficModel objects rather than comparing the actual
raw files.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4186335cd88e36b9e4981905e80ce2ae9f2639f7">4186335c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests: Port PY3 ldap tests

Fix various assertTrue/assertEquals so ldb.bytes (PY3)
comparaisons work both in PY3 & PY2

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/32c8c820a23966ae4137b3d6adde8e88a8751ed7">32c8c820</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests/python: PY3 port samba4.tokengroups.krb5

gensec.Security.update takes bytes as param not string with py3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/60a9998ea3de19f88e281a35aff19b17be55a872">60a9998e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests: PY3 port samba4.user_account_control test

Fix dict_items are not combinable with '+' operator error, need
to convert to list first.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/42cb270b48f11c8ac8104125acd2719f307c4a39">42cb270b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/ldb-samba/tests: PY3 port samba4.ldap.match_rules

Various fixes

a) schema_format_value can return bytes (esp. for objectSid,
   objectGUID
b) embedded NULL now cause ValueError in py3 (was TypeError in py2)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/397ab3afbd107e3e5a33b87d2b1221221d21b7d5">397ab3af</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests: PY3 fix failing samba4.ldap.notification

Convert ldb.bytes object to string for further processing

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/74aabacc34916452eadec1ca5e911e5afdb82d50">74aabacc</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests/python: PY3 port samba4.ldap.sites

Fix comparison of ldb.bytes with string
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c83e1a6aea91f1886b87e657d5ec03221ef343c7">c83e1a6a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests: PY3 port samba4.ldap.vlv

Misc changes mostly around use of ldb.bytes, bytes and string to get
the test to work. Additionally results of a range cannot be combined
with a list using the '+' operator (need to enclose the range with
list).

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cc8a4eeb530ba9893acdaf272e1bd4cd018bdb64">cc8a4eeb</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests/python: PY3 port for samba4.ldap.linked_attributes

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2b09cfe083940cdcd5fbd6a93693289a8d32bb29">2b09cfe0</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests/python: PY3 port for samba4.ldap.rodc_rwdc.python

* Make sure samba-tool is called with correct PYTHON version
* Convert ldb.bytes results to string for comparison with expected
  results

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e8413056d339100f1c0c0ce917661681c6108c1b">e8413056</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests/python: PY3 Port samba4.ldap.password_lockout

use Exception.args member as exception is no longer supports
indexing.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8c05eb75a57649b3865d3d95bdaabfd14640c97">f8c05eb7</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests/python: PY3 port samba4.deletetest

Fix misc ldb.bytes needing to be stringified for tests to succeeed

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/06ef2d51a1b48952e7c443504cf03cbea2716ad1">06ef2d51</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: PY3 port for samba4.drs.samba_tool_drs_showrepl

Fix various ldb.bytes that need to be stringified in order to get
tests to pass

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d7dba6f701fa128803d7f7ead5bb6ddd3372393b">d7dba6f7</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba: PY3 port samba.tests.samba_tool.visualize_drs

* Fix calling samba-tool with correct PYTHON version
* Fix integer division needs '//' operator (this was causing
  'uncaught exception - list indices must be integers or slices,
   not float'

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c319684d5166db944b5b9e88a876d22f4f856993">c319684d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests/python: partial PY3 port for samba4.ldap.sort

Test still fails after applying the following fixes

a) only decode byte or (py2) str objects
b) fix sorted function no longer use cmp func, use compat
   cmp_to_key_fn instead
c) convert ldb.bytes returned from ldb search results
d) convert sort_functions.keys() to list so array slicing works

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/34ca15fb042e42773854c093ad9f1e67696c90ac">34ca15fb</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests/python: PY3 allow test samba4.ldap.sort pass

Adjust test data to remove use of embedded NULLs.

We are getting the following exception when running the test
under python3

Exception: Exception: Traceback (most recent call last):
  File "source4/dsdb/tests/python/sort.py", line 181, in setUp
    key=cmp_to_key_fn(locale.strcoll))
ValueError: embedded null character

Looking at the source code for locale.strcoll the lhs & rhs
params are processed using 'PyUnicode_AsWideCharString(s, NULL)'

Documentation for PyUnicode_AsWideCharString states:

"Convert the Unicode object to a wide character string.
 The output string always ends with a null character. If size is
 not NULL, write the number of wide characters (excluding the
 trailing null termination character) into *size. Note that the
 resulting wchar_t string might contain null characters, which
 would cause the string to be truncated when used with most C
 functions. If size is NULL and the wchar_t* string contains null
 characters a ValueError is raised."

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/61adb75b9ffacf25637e2b4519316093e61a4a82">61adb75b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CI: Add new (TEMP) pure python3 autobuild jobs for samba-build & samba-nt4

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a522d7e03d369a0e97c7683078112b3cb6a714c5">a522d7e0</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CI: Add new CI jobs for samba-purepy3 & samba-purepy3-nt4

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d01d85ccb255cbdfd3d379dfe0cd7ac58af7f284">d01d85cc</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CI: Remove purepy3 temporary jobs

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b209def154c5427a62362ae903d432959e7260d2">b209def1</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/selftest: Reenable samba.tests.gpo to run with --extra-python

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cc11f71820c9669488bed9f1b02c815776d6d0c3">cc11f718</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/credentials/tests: Python 3.6 avoid deepcopy error

In PY3 both deepcopy & (shallow)copy fail with

  Traceback (most recent call last):
    File "auth/credentials/tests/bind.py", line 42, in <module>
      creds_machine = copy.copy(creds)
    File "/usr/lib64/python3.6/copy.py", line 96, in copy
      rv = reductor(4)
  TypeError: can't pickle credentials.Credentials objects

This patch avoids the nasty copies but creating and populating the
Credential objects instead of copying

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9bdeb95f2c615643c03073921e3cb13dab54f49a">9bdeb95f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Remove temporary purepy3 tasks

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c316738f2652af8375e40b760d011a0e932a18ab">c316738f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CI: Remove the remainder py3 jobs

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a7cb10e4b475e0a41517f3e7be502be5e2ebb54e">a7cb10e4</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3 pure build fix some str/bytes wobblies

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/447276e2974ae5288eaf5dbe448bf52b27ec0839">447276e2</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">adjust ldb config for py3 build

waf code is making assumptions that main build is py2 and extra build
is py3, this results in wrong library names being used.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3eb7281ff369e36abf466066d403c48082fdb80d">3eb7281f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: Decode result of Popen as unicode/string

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f4c0343dc4288e9cd00d7325633949020c3d300b">f4c0343d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Always set PYTHON to something sensible (if it isn't set)

Lots of test scripts need to run with the correct version
of python. With the correct shebang the script should run with the
correct version, the problem is that not all scripts are part
of the installation, some scripts are part of the source code,
and the shebang is not dynamically generated as yet.
It is safer if we are somewhat version neutral at the moment and
ignore the shebang and always run scripts from the test environment
with the python version (determined by PYTHON env variable) If this
env variable isn't set then set it according to the python version
that is running the tests

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/19ac50ba2d7d193816c79d44e472e8cf4acb8aeb">19ac50ba</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: Ensure we detect the correct python.

In order to support a default python3 build we need to ensure
we detect python3 if no PYTHON env variable is set up.

Currently we detect python with

conf.find_program('python', var='PYTHON', mandatory=mandatory)

which uses PYTHON as as hint and falls back to the program name
'python' otherwise

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3e017aa7e51df02d257fbac352ae79fc29aadc68">3e017aa7</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba Provide proper pc file

To support building by default python3 we need to fix assumption
that only extra-python with py3 has valid PYTHON_SO_ABI_FLAG used to
create alt name for pc file.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a660b7fb8e519bd3be558fd0425bff8f287fca1f">a660b7fb</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: switch current build to use python3

Make sure default make and configure for all now defaults
to building with python3.

To build a samba (or sub component e.g. talloc etc.) with python3
  ./configure && make

To build a samba (or sub component e.g. talloc etc.) with python2
  PYTHON=python ./configure && PYTHON=python make

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0186f2733aa59f70278747a6fd4ae9e66b8fd4e4">0186f273</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CI: Run autobuild jobs with python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e35d741934eb1626f9a7aeacd9eb1a96e27546f">0e35d741</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script: Fix failing build_xc job

build_xc job uses compare_cc_results.py to compare cache
files, the cache files are stringified hash maps, the results
in python 3.4 don't compare well due to inconsistent order of
dict key/value pairs when the cache files are created. While
comparing the file contents works fine in python3.6 it fails
with python3.4. This patch detects problematic dict lines and
rewrites the value for comparison

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ae5dd18162acaf4a0d2123d571f690c644791218">ae5dd181</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Modify old samba_buildpy3_only job to python2

Since autobuild now builds python3 by default we need to change
the previously buildpy3 only job to python2

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/23db658ebccebd2349b7da53c4d52c379ccb8ccc">23db658e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CI: convert the purepy3 job to a py2 one

With patches to have python3 as default we need a
pure python2 build

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dfe5787c255eaab3d8022c972a1afa1dd83e62ef">dfe5787c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Adjust autobuild for PY2/PY3 get_python_lib behaviour

The resuls of get_python_lib are different between python2 & python3
and this results in autobuild generating the wrong PYTHONPATH with
python3.

python2
=======
print ("%s" % get_python_lib(standard_lib=1, prefix='/my/prefix'))
/my/prefix/lib64/python2.7

python3
print ("%s" % get_python_lib(standard_lib=1, prefix='/my/prefix'))
/my/prefix/lib/python3.6

But with addition of plat_specific param the results are the same

python2
=======
print ("%s" % get_python_lib(plat_specific=1, standard_lib=0, prefix='/my/prefix'))
/my/prefix/lib64/python2.7/site-packages

python3
=======
print ("%s" % get_python_lib(plat_specific=1, standard_lib=0, prefix='/my/prefix'))
/my/prefix/lib64/python3.6/site-packages

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2fb74e6ad32db46d907bb75ea35107c0e348ed78">2fb74e6a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: Support --extra-python with python2

Relax restriction on extra_python version

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e3c37bbad4f45124a4ae7316a67e4c223e16faf1">e3c37bba</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: don't hardcode '.python3' for extra-python tests

Instead of hardcoding '.python3' we now hardcode the extra python
exe (which will be python2 for a default python3 build)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b0b9c62e1cfcadb1189559e3b4834f2b4a053f8a">b0b9c62e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Convert old py3 tasks to py2

Now that we are building with python3 by default we need to
convert the old python3 test tasks to python2 (e.g. reverse how
we used do it)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5a804050717e9e885c6354ffacac7827236c81e4">5a804050</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CI: Add new py2 CI jobs to replace old py3 ones

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/35aef220ceb16eea7c495c3c105c0ff02146ea3e">35aef220</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/knownfail: Add python2 version of known fails

Post build & test running under python3 we now run with
 '--extra-python=/usr/bin/python2',  these tests will get
python2 appended to the test name so we need also to create
new knownfails for these. We will keep the python3 versions
in case we create (and we probably should) some CI job(s)
with
  PYTHON=python configure.developer --extra-python=/usr/bin/python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9ac432d4bc5b57660204aace375a32d58ac076df">9ac432d4</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/flapping.d: Add python2 versions for flapping tests

Post build & test running under python3 we now run with
'--extra-python=/usr/bin/python2',  these tests will get
python2 appended to the test name so we need also to create
new flapping*/* entries for these. We will keep the python3
versions in case we create some CI job(s)
with
    PYTHON=python configure.developer --extra-python=/usr/bin/python3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bc92277a79bd393b9e1389e0069e4a4725675eff">bc92277a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T09:38:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: We should run autobuild with python3 by default

sn-devel autobuild runing autobuild.py (via git hooks I suppose) but
if run directly (e.g. depending on script shebang) then 'python' aka
python2 will run. This will cause an error when building some targets
because the autobuild script itself sometimes builds paths based
on the version of python executing the script e.g ${PYTHON_PREFIX}.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f7516971b566f6099abcaf4e6ad42102cc6c9b07">f7516971</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-10T13:32:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CI: Adjust CI tasks for new python3 autobuild.py default

Now that autobuild has defaulted to python3 (via shebang) we no longer
need to explicity call autobuild.py with 'python3'

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Mon Dec 10 14:32:24 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a68055528644fbbbe94487385e23aaa70b0f3afa">a6805552</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pdb_ldap: Fix typos

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2b1125fa81676b05b6fd76fd537f1229a714d1cf">2b1125fa</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">passdb: dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d833403139e145701942fb47db29bb61246739bc">d8334031</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de331ce92b4129615bd6f84a18ec605980d10f90">de331ce9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eaa035b8c4b936d751d916dadb7f541286382c9b">eaa035b8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c48d6345e32fb8f5727f8545c60d58bd7570b056">c48d6345</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">profiles: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/302840173714420efeef219ebdf8bd13b850aaa4">30284017</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/49f7dc01f239cd5900e1e2dcee9e9a7f5373990a">49f7dc01</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d20c57c2d63cd2d042452ab8e81eac1693388b73">d20c57c2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">sharesec: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2c179bcdecb56881b5e533d6e5b0b1999586ca91">2c179bcd</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pdbedit: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/56afb781cdee1b882419f5e7088aec1b77021305">56afb781</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pdb_ldap: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/38a3970132587827da71ab367d6ed9463dad8b7a">38a39701</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnet: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b0077bb05928a3ff0526043537abca5f9f36ef73">b0077bb0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpc_server3: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/918602e0f88db3ec5ac226ca5e3206ab3a75f4db">918602e0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpcclient: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bea43789bcb826006f38f2f96989953107dbbc74">bea43789</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture3: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f4ee95517e37cd7c6bf2a3de87bfefb432204828">f4ee9551</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da1d1e80772559f490887f131c2d02d94d681dd9">da1d1e80</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove sid_string_tos

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ba64d4968da8001c54d697f142231872a88481f">5ba64d49</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netapi: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/12f3a37a1a623a56fc6d397f1fac08effe9b7c79">12f3a37a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libads: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6e55ca9e6f488d6996511e34e0fc7ffa1cb8fcac">6e55ca9e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/939d64b9f830e9da88caf24d97299e379f3cdcd2">939d64b9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9ffa6d49a56f9a55ad34f4c687429c8fd14e9d8c">9ffa6d49</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-10T23:40:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libgpo: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a7a993317119f54e1b1d6e4aa6b295a9827c15f">6a7a9933</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-11T03:22:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove sid_string_talloc

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Dec 11 04:22:33 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/884eeca39e9f084eca5885182ce1690811c66f6c">884eeca3</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-11T12:58:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:web_server: Fix build error

source4/web_server/wsgi.c:149:8: error: assignment discards 'const'
qualifier from pointer target type [-Werror=discarded-qualifiers]
    str = PyStr_AsUTF8AndSize(item, &size);
            ^

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Dec 11 13:58:30 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/75d15484f3b71b1a2684c4a73e53aaa467f9932b">75d15484</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-12-11T16:26:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-vfs: Prevent NULL pointer dereference in vfs_glusterfs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13708

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Tue Dec 11 17:26:31 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/923010d99bd79c36b8d6dbedef4228df4d6fa1b4">923010d9</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-11T19:07:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">various: Remove references to about to be deleted thirdparty/dnspython

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8d333f43055daf5e18623f2ad9e379f58ef5f8cd">8d333f43</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-11T22:37:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party/dnspython: Remove dnspython library from third_party

This version of dnspython isn't python3 compatible and is
quite old.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Dec 11 23:37:43 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/25ab429371f7cd4d4cd572d843d3607f2ce1db6f">25ab4293</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-12-12T03:38:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: py3: cope with bytes when compiling system-info.txt

The command output looks like b'foo\nbar' in string-space.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/35e1a7989d2af4508abe589ca4dcb1e73342b875">35e1a798</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2018-12-12T03:38:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: convert top_commit_msg to str for Py 3

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fa77209dea48c623fa3052a65b2d8dad9f146198">fa77209d</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-12-12T03:38:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add SMB Py binding .chkpath() test case

chkpath was only tested incidentally (and that assertion was wrong). Add
a proper test to prove it works correctly. We can then clean-up the
incorrect assertion in the next patch.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b84cea18fcc54f599db9580fd027b8d530d6b4bd">b84cea18</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-12-12T03:38:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Fix SMB Py binding .unlink() test case assertion

The current assertion would never detect if the unlink API is broken.
The chkpath() API is only useful for checking if directories exist, so
it will always return False for a regular file (regardless of whether
the file actually exists or not).

Rework the test case so we assert that the file exists by trying to read
its contents (which will throw an error if the file doesn't exist).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/629a41fc6542cda9c2d60f99e8d7856aa1e081e5">629a41fc</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-12-12T03:38:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Extend SMB Py binding .list() test-case

Extend the tests to better reflect some of the .list() functionality we
expect.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da30c824b8240e92ad4bcdcd174d56c39235412e">da30c824</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-12-12T03:38:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Extend SMB test_save_load_text case to check overwrite

Extend the test case to check overwriting a file as well. Currently this
has the behaviour of appending to the existing file, rather than
overwriting the file with new contents.

It's not clear from the API that this is the intended behaviour in this
case, so I've marked it as a failure.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/31d4f692ad94cc5dfb82433cf6e3bd82ff805a4a">31d4f692</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-12-12T03:38:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: Fix error in smbcli_deltree()

Commit 094afe614b6282 fixed an uninitialized variable, which meant we
tried to delete the file twice. The 2nd time fails, so the function
returns an error, instead of success (even though the file is now gone).

Note we want to be using the source3 SMB library code going forward.
However, fixing this bug makes it easier to write tests against the
(currently s4) SMB python bindings.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bc179e6b5e748042c9c247b1abc1c326e9c61d29">bc179e6b</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-12-12T07:23:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add SMB Py binding .deltree test case

Add a more thorough test case that .deltree works as expected.

Note that we get a slightly different NT_STATUS error in file_exists()
if the parent directory doesn't exist, e.g.
/non-existent-dir/nonexistent.txt

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Dec 12 08:23:07 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9abe35ce565fe2811b4367b6526dcf95a9209c68">9abe35ce</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-12T08:13:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: Remove superfloues sha256.h include in vfs_acl_tdb

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0a001515bfc974d2ea109e8a13f9acf8fe86543a">0a001515</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-12T08:13:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: Remove superfloues sha256.h include in vfs_acl_xattr

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/55b2f247f9ba56516efba52481418966a777343e">55b2f247</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-12T08:13:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Do not check if the alloc_size is 0 on empty files

The allocation size might not be zero. This depends on the file system
behavior and also on the size of the extended attributes stored on the
file. E.g. If a large user.DOSATTRIB xattr is stored on XFS/ext4 then 8
blocks are used and we will round up to several megabytes.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a80fee5054db917050e0bda0482f8d17791d30dd">a80fee50</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2018-12-12T11:51:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/smb2/session: Fix expire tests

When run with MIT kerberos, the smb2 session expire tests fail when run
against the ad_member test environment. The krb5 library initializes
values from the private krb5.conf profile
st/ad_member/lockdir/smb_krb5/krb5.conf.ADDOMAIN, this file does not
contain a defined clockskew setting. The expire tests require a low
clockskew value that is set in st/ad_member/lib/krb5.conf.

This patch disables the creation of the private krb5.conf for the
ad_member_idmap_rid testenv, and runs the smb2.session tests
against ad_member_idmap_rid instead of ad_member.

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Dec 12 12:51:24 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eabe6d534c5c8c6ca38f3dc846f17aad6395da8c">eabe6d53</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-12T17:34:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:talloc: Fix undefined behavior in talloc_memdup

lib/talloc/talloc.c:2419: runtime error: null pointer passed as argument
2, which is declared to never be null

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e7a8e4e6433bf26f6eac46e6a5f65f421a8981bb">e7a8e4e6</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-12T17:34:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:security: Do not duplicate invalid aces

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c507e98f03eabe59df774a9a5f51411fc23d4e5">9c507e98</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-12T21:18:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:security: Return early if there are no aces to duplicate

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Dec 12 22:18:52 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c71417a0ebf563f649e1a8fdc599b33cd33e62dd">c71417a0</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-12-13T00:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf-py3: Allow waf build --dup-symbol-check to operate in python3

Use the b prefix on output from subcommands to match bytes with bytes.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a42f18cc3e671242329a22dc53044fe8ff3e6d4b">a42f18cc</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-12-13T00:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Run waf build --dup-symbol-check under $PYTHON

This would often be python3 in the new build

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/19a4d3ca692e864a2ae6c8c496e7eb08cded612f">19a4d3ca</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-12-13T00:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Workaround python3 hash order issues (for now)

This works around python3 having a new hash seed each time it starts to allow
a second "make" not to rebuild the world.

This should probably be reverted once we find the hash that is causing
the issue, but should reduce frustration for now.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/676a8fdefc9977535b1b28fedd3c567b252b0693">676a8fde</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-13T00:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: Use C99 initializers for last element in ndr_interface_call(_pipes)

librpc/gen_ndr/ndr_witness.c:1421:2: warning: missing initializer for
field ‘in_pipes’ of ‘const struct ndr_interface_call’
[-Wmissing-field-initializers] <--[gcc]
  { NULL, 0, NULL, NULL, NULL }
  ^

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5508c19c5cbcde13f1239e1e2f167bdaf894b8dc">5508c19c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-13T00:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: Fix function for py_<name>_ndr_print_(in|out)

The function takes two PyObject arguments, See:

https://docs.python.org/3/c-api/structures.html#c.PyCFunction

and

https://docs.python.org/2/c-api/structures.html#c.PyCFunction

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/57783d6295d1dcfcd4bd99951599c0765ae8c61b">57783d62</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-13T04:00:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: Fix unsigned integer comparison warning

bin/default/librpc/gen_ndr/py_wkssvc.c:27344:33: warning:
comparison of integer expressions of different signedness: ‘long int’
and ‘long long unsigned int’ [-Wsign-compare] <--[gcc]
    if (test_var < 0 || test_var > uint_max) {
                                 ^

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Dec 13 05:00:20 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/660b872163c9aee99627cd2952ac06c8df85cf22">660b8721</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-13T07:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: fix pidl dependencies to rebuild on pidl changes

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59cb025e61abfe28a9d17616d10641cc74975375">59cb025e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-13T07:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: pass self to py_tevent_req_wait_exc()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Tim Beale <timbeale@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1bccbfcff78c49c74cf986a8b9e9a33d295d557c">1bccbfcf</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-13T07:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: only use poll_mt backend if multi_threaded=True is specified

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Tim Beale <timbeale@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/247a71b63aea9fe03e4e6ba22102eeb0cd648a2a">247a71b6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-13T07:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: add sign=True to require signing

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Tim Beale <timbeale@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/790dab571c426abc1004d1c338e0b94382a2a2c0">790dab57</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-13T07:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: add force_smb1=True in order to control forcing of SMB1

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Tim Beale <timbeale@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fdc62b03ca5eac3f98f0e1f2db45a7df0b29095e">fdc62b03</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-13T07:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: remember that a connection uses SMB1

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Tim Beale <timbeale@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aaf7aaa6e26c62c62650dc01fff902d3a949a315">aaf7aaa6</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-12-13T07:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: .get_oplock_break API is dependent on multi_threaded=True

The .get_oplock_break is dependent on the pthread code, which is only
used when creating a SMB connection with multi_threaded=True.

Add an explicit error to the .get_oplock_break() if someone tries to use
it in non-multithreaded mode.

Initializing self->oplock_waiter in non-multithreaded mode is similarly
redundant if the API can never be used.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/60148c9ee147105b36cbb8164cbb7b1c2249acb8">60148c9e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-13T07:52:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: make use of PyBytes_FromStringAndSize() in py_cli_read()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Tim Beale <timbeale@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0af6b335448f6ee4f4db6aa857666689e87f00ad">0af6b335</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-13T07:52:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: make use of PYARG_BYTES_LEN in py_cli_write()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Tim Beale <timbeale@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a3d2c3345a7ed4a9c4c9ad5ce767cc2ffd9413f">6a3d2c33</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-13T07:52:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: add cli_write_send/recv which work with SMB1/2/3

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Tim Beale <timbeale@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9fb0d8e7e2e5c7a9485368f26d2fff05d51f32d8">9fb0d8e7</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2018-12-13T07:52:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: add comments for cli_write_send/cli_push_send

Added a code comment highlighting this 2 APIs do similar jobs, and tried
to explain why you might want to use one over the other.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3c3b44004fd39a890f2bdfadf3ebb68a53f3403f">3c3b4400</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-13T07:52:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: make use of protocol independent cli_write_send/recv in py_cli_write()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Tim Beale <timbeale@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/64e68abdc9e7d991809e6eab57826b4456d8e973">64e68abd</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-13T07:52:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: make use of protocol independent cli_read_send/recv in py_cli_read()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Tim Beale <timbeale@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be464c1dc8675f6e362b7a5b51c6776dc682e3b9">be464c1d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-13T07:52:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: pass impersonation_level to cli_smb2_create_fnum_send()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Tim Beale <timbeale@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/850aef94dc4d9370d03f18510de93116221a0feb">850aef94</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-13T07:52:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: pass impersonation_level to cli_smb2_create_fnum()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Tim Beale <timbeale@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ed0deadf6287c4c56e99503bf78f20db2f297401">ed0deadf</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-13T07:52:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: pass ImpersonationLevel to cli_ntcreate1_send()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Tim Beale <timbeale@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c8a5e89d9f6575c4e9eb770997172e9c25f8e9d0">c8a5e89d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-13T07:52:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: pass impersonation_level to cli_ntcreate_send()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Tim Beale <timbeale@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ecafdcb39143b6b3a74f2b9d578241a0170f8486">ecafdcb3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-13T11:35:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: allow ImpersonationLevel argument to create()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Tim Beale <timbeale@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Dec 13 12:35:06 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e9a13d7fc84beb9546c75c8de15aa7246bed71e5">e9a13d7f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-13T23:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/knownfail.d/smb: avoid explicit python version

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Tim Beale <timbeale@samba.org>

Autobuild-User(master): Tim Beale <timbeale@samba.org>
Autobuild-Date(master): Fri Dec 14 00:49:31 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d20f06986ee8f176106446c8ae32f0900ea4e4cf">d20f0698</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-13T23:51:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Convert samba4.ldap.sort.python to planoldpythontest

Currently the test only runs fully under python2. As an interim
measure while we figure out how to get this to work property under
python3 I have converted the test to planoldpythontest so it also
can run under python2

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2b3c9b8e6a44420795768d6476ce843886222768">2b3c9b8e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-13T23:51:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/tests/python: Restore embed NULL tests for Python3

commit: 34ca15fb042e42773854c093ad9f1e67696c90ac changed the
test so embedded NULLs were avoided when python3 was used.
This was due to the fact the string comparison function
'locale.strcoll' cannot handle embedded NULLs. This commit

a) Restores the test data using embedded NULLs which was
   not used depending on the python runtime version
b) Removes the problematic calculation of expected sorting order
   and instead uses sort order data stored in files.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/28ecdd977735a02740e67861bc69d5b461d6c77f">28ecdd97</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-13T23:51:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: Decode output of cmd_output (which is bytes)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/166d119d48efd6b7b4f8f5978c71c50bad2109ca">166d119d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-13T23:51:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dynconfig/wscript: python3 fix string.find instance

string.find doesn't exist in python3. Instead use the 'find' method
of the string instance itself

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9116cc8cc81dd96ed6c303577c9e66fb3a10db3e">9116cc8c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-13T23:51:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting: python3 fix string.find instance

    string.find doesn't exist in python3. Instead use the 'find' method
    of the string instance itself

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0756b59f810ee9d4bf9b6d5eac02d8951751ff79">0756b59f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-13T23:51:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: document build system default python version change.

build now uses python3 by default instead of python2

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bae5364bf39f863d25e3c7caac59c6af28b4f441">bae5364b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2018-12-13T23:51:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: re-write shebang for delivered python scripts

Can't see how the orig code would have worked though
a)
  task.env["PYTHON"] is a list
b) task.env["PYTHON_SPECIFIED"] can (and is in our case false) looks
   like it would only be true for python2 but in anycase no harm we
   always rewrite the shebang

So now it works as follows,

1. PYTHON (which is where the shebang is got) is set to python3 by default
2. To override the default you need to set PYTHON (e.g. to build with python2)
3. If you give a full path in PYTHON then shebang is of the format
   "#!{FULL_PYTHON_INTERPRETER_PATH)
4. If you specify PYTHON=python or PYTHON=python2 etc. shebang format is
   "#!!/usr/bin/env python", "#!!/usr/bin/env python2" etc.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/90f0460c69e4966195edb19ca98c5e774c8af5c5">90f0460c</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-12-13T23:51:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: Ensure default python picked up is python3

1) set the default python searched for samba waf to be python3
2) remove default setting of PYTHON variable if not defined (not needed)

Signed-off-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/288338b42926f1d4fc7885eb6558a6f82586a02d">288338b4</a></strong>
<div>
<span>by amitkuma</span>
<i>at 2018-12-13T23:51:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Correction of comment in winbindd_pam.c

Internal comment corrected.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/89705734432eec6c458f53b1dc7a10b4833f2215">89705734</a></strong>
<div>
<span>by Brian Candler</span>
<i>at 2018-12-13T23:51:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add #include <unistd.h> to provide prototype for getopt()

Signed-off-by: Brian Candler <b.candler@pobox.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/49c1c0c38bc572d1b543a3e71e8beb4677d5c4a0">49c1c0c3</a></strong>
<div>
<span>by Philipp Gesang</span>
<i>at 2018-12-13T23:51:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/smbcontrol: fix typo in class name

Signed-off-by: Philipp Gesang <philipp.gesang@intra2net.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f183fd328314d90a92659720adebf034917962ec">f183fd32</a></strong>
<div>
<span>by Brian Candler</span>
<i>at 2018-12-14T03:13:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Change order of flags in Makefile so that crackcheck builds under Ubuntu

Signed-off-by: Brian Candler <b.candler@pobox.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Dec 14 04:13:38 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/edab1318f9138c0d87de7cc7cfa5da8e29c906f8">edab1318</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-12-14T09:27:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">audit_logging: Remove debug log header and JSON Authentication: prefix

Feedback from real-world users is that they really want raw JSON
strings in the log.

We can not easily remove the leading "  " but the other strings above
and before the JSON are really annoying to strip back off

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13714

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b776ba8042ac94b1fdda2d4073283a5609c8239c">b776ba80</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-12-14T09:27:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/audit_logging: Use talloc_stackframe() in audit_log_json()

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/31957c7fe9d0f67bef08177e982043a23b172c7d">31957c7f</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-12-14T13:32:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">audit_logging: auth_json_audit required auth_json

To log JSON the human-readable logs must also have been enabled

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13715

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Dec 14 14:32:25 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5ddff307b4af5c82d5064745f5bd2c33bd340ced">5ddff307</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-12-14T13:40:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Move python detection back into waf (instead of in configure and Makefile)

This avoids creating a mini-configure in the configure script.

Users wishing to use python2 to build need to specify PYTHON=
to both ./configure and make

After we merged the python3 change, it became clear that relying on systems prefixing
the correct python just causes trouble and make debugging harder, so only use $PYTHON
for the override, not the default case

This essentially reverts a660b7fb8e519bd3be558fd0425bff8f287fca1f but
leaves the files more consistent.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/934e336a951a9e6eea00dee9a74059f6a9a37224">934e336a</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-12-14T13:40:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:test: make sids2xids test compatible with py2 and py3

define a wrapper function for subprocess.check_output,
to return bytes for py2 and unicode for py3, and replace Popen with it.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a19d5bd771c1727b037d28d24af0b85e49bdafb2">a19d5bd7</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-12-14T13:40:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: change shebang to python3 in source4/scripting/bin dir

Samba default python is 3 now.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/359d832e8981bce350cd7f1d9b087baa57e47cd7">359d832e</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-12-14T13:40:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: change shebang to python3 in source4/torture dir

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/338413ad5aba0b6fa2f0419eb99b4d00ebf6ebc7">338413ad</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-12-14T13:40:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: change shebang to python3 in source4/scripting dir

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8e3c194453f206152b40fa7a5efb1436b13424e9">8e3c1944</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-12-14T13:40:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: change shebang to python3 in source4/dsdb dir

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9d8e35ab97c0e613761136a3495515b18c85a157">9d8e35ab</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-12-14T13:40:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: change shebang to python3 in script dir

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c65a70781da987b4ea445b3ad79784b508170bf5">c65a7078</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-12-14T13:40:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: change shebang to python3 in wintest dir

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a07279b78a83d7e62eb0c58a2ac989407a40fb6b">a07279b7</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-12-14T13:40:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: change shebang to python3 in lib dir

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/edfb6cb8223be430360c8372457880471a198630">edfb6cb8</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2018-12-14T17:00:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PY3: change shebang to python3 in misc dirs

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>

Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Fri Dec 14 18:00:40 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cb23a0345f1ef4297f6643c25ebe955b9aaee54c">cb23a034</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-12-14T17:57:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">idl: Add Windows event code ids

Add idl definitions for Windows Event Code Ids, and Logon Types. This
intial commit adds:

Event Ids
        4264    Successful logon
        4625    Unsuccessful logon

Logon Types
         2      Interactive
         3      Network
         4      Batch
         5      Service
         7      Unlock
         8      NetworkCleartext
         9      NewCredentials
        10      RemoteInteractive
        11      CachedInteractive

The intention is to add Windows Event Codes to the JSON log messages, to
provide a common event identifier in mixed Windows and Samba networks.
And to assist security personnel with a windows background.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b7baf96bd7248b1d34416e3ae86f4613c5ed0934">b7baf96b</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-12-14T17:57:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth log: Add windows event codes

Add a new "eventId" element to the Authorisation JSON log messages.
This contains a Windows Event Code Id either:
        4624    Successful logon
        4625    Unsuccessful logon

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ac51f1551dafd90d7c71393f9a8ec2f87da72c18">ac51f155</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-12-14T17:57:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth log: Add windows logon type codes

Add a new "logonType" element to the Authorisation JSON log messages.
This contains a Windows Logon Type, the supported logon types are:
        2       Interactive
        3       Network
        8       NetworkCleartext

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/105cdd6c1cbc5e5889669e29a3c9fcbebdce55f9">105cdd6c</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-12-14T17:57:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth log: Increment Authentication version

Update the minor version of the Authorisation to reflect the addition of
the "eventId" and "logonType" elements.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e97acc714d9052b56b947cc3a54510d3d3eb36fe">e97acc71</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-12-14T17:57:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb audit_log: Add windows event codes to password changes

Add a new "eventId" element to the PasswordChange JSON log messages.
This contains a Windows Event Code Id either:
        4723    Password changed
        4724    Password reset

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8cdfc7bbbde1e3a4a79827bf33cfce49440de0be">8cdfc7bb</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-12-14T21:04:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">travis-ci: Remove hooks for Travis CI (typically used with GitHub)

These will get out of date pretty quickly, so better to remove them now
that GitLab CI is the documented and supported solution.

This was our first public CI system, used because it is cost-free
to Open Source projects and integrated with GitHub.

It has served it's purpose now.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Dec 14 22:04:20 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b0cabfd265c475c2726dfc7d7cfb22050bb21f5e">b0cabfd2</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-16T20:04:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Fix checking for config.h #define in readline.h

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd048f917040d5b6e42b93e67b944c073f9db949">dd048f91</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-16T20:04:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Fix checking for config.h #define in gssapi.h

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/80c4bc35a5cfbab173e93f833b620b7d855d78e2">80c4bc35</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-16T20:04:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Fix checking for config.h #define in replace.h

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9005943a12dae8e32fed5269331eb5580388aa02">9005943a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-16T20:04:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Fix checking for config.h #define in fault.c

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/20d279fc161bd2e1a0bdaec613e139df9b6b6590">20d279fc</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-16T20:04:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_samba: Fix checking for config.h #define in krb5_samba.h

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/648e70ba7bf891421299bb7e2b8a20f2e9769b97">648e70ba</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-16T20:04:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Fix checking for config.h #define in nsstest.h

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ea82eaca092e2f9aafef7c35227b7d1d35f9afe">7ea82eac</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-16T20:04:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Fix checking for config.h #define in winbind_nss.h

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2f6ed306ff4068da8f348c0dbc9ae8abd5850428">2f6ed306</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-16T20:04:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: Fix checking for config.h #define in includes.h

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3da98cb19112fe98612035792f68fead8c2d6ec5">3da98cb1</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-16T20:04:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Fix checking for config.h #define in system.c

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8a313bbdd5c5e3ec2410387cb4fe528071c60149">8a313bbd</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-16T23:10:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:tsocket: Check for DOXYGEN as a #define

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Mon Dec 17 00:10:10 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ce33dd1196e4be5350675aa6ba8acbccb12f703e">ce33dd11</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-12-17T00:24:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Remove readOnlySchema concept from Samba

This is a hold-over from the LDAP backend project, which has not yet been revived.

There will be bigger issues than what to do if the schema changes if this ever comes back
and our schema code is way to complex at the moment.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0a449c2b7438ad6012e16d7764edf12cc7277474">0a449c2b</a></strong>
<div>
<span>by Guo Qiao</span>
<i>at 2018-12-17T00:24:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:scripting:bin: rm rpcclient

This file only works in py2, and no one use it. Just delete it.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/97c5a698aa2ba99bc07c7db8bc12bfcb7afa662e">97c5a698</a></strong>
<div>
<span>by Adam Nielsen</span>
<i>at 2018-12-17T00:24:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">manpage: Advise vfs_fruit:veto_appledouble=yes can break rsync

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/440ddf8470b11a46066d282bf8945201d547c192">440ddf84</a></strong>
<div>
<span>by Marcos Mello</span>
<i>at 2018-12-17T00:24:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Send status to systemd on daemon start

systemd service files run in no-forking mode (--foreground) since
8b6f58194da7e849cdb9d20712dff49b17a93a77.

Rearrange sd_notify() call in become_daemon() to only send status to systemd
in this mode (Type=notify is not designed to monitor forking). Drop READY=0
(it does nothing) and MAINPID= (unnecessary because the process spawned by
systemd is already the main PID).

Also remove STATUS= prefix from debug messages.

Signed-off-by: Marcos Mello <marcosfrm@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f460bb52ed4393722d58f9e6d30bd0c7e6a51f1d">f460bb52</a></strong>
<div>
<span>by Will</span>
<i>at 2018-12-17T00:24:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Conditionally disable macOS incompatible tests

Symbols _getgrent_r and _getpwent_r in
source4/torture/local/nss_tests.c are undefined in macOS. It seems
that checking HAVE_GETGRENT_R and HAVE_GETPWENT_R and conditionally
disabling those tests as suggested by hirochachacha in the referenced
bug allows samba on both `master` and `samba-4.7.1` to build properly
on macOS/darwin.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11984

Signed-off-by: Will Haley <willhy@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1fd4cdfafaa6a41c824d1b3d76635bf3e446de0f">1fd4cdfa</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-12-17T00:24:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">drepl: schema repl race condition fix

Adds final schema consistency check before committing changes.
Aborts if corruption found.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12889
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1cff50febecfb3c0443a17da29a047eea2e09e61">1cff50fe</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-12-17T03:30:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: sort DSDB_EXTENDED defines by OID

This helps avoid duplicate values and clearly indicates what value to select next.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Dec 17 04:30:39 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b77fae3281a06a99a7e298378a68d273ee28355c">b77fae32</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-18T01:00:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Don't try to release a kernel oplock for a leased file

If we have

[global]
  smb2 leases = yes
  kernel oplocks = no
[share]
  kernel oplocks = yes

for clients requesting leases we don't even try to acquire kernel
oplocks, because the kernel API is not compatible. Kernel oplocks are
per fd, leases are roughly "per inode".

We don't however special-case the LEASE_OPLOCK case in
release_file_oplock, leading to nasty error messages like "bad file
descriptor" on the fcntl(fd,F_SETLEASE,F_UNLCK) call. They are
harmless, but they raise eyebrows.

To simplify the if-condition, I factored out the kernel call and
applied early returns.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Dec 18 02:00:44 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/93284ed0321ff96a97d4b56deedbca62c5852c06">93284ed0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-12-18T01:02:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Divide by 2 when calculating hop count bucket

This provides finer resolution while still maintaining a reasonable
maximum.  In this case the top bucket contains any hop counts
>= 16384, compared to the current situation where the top bucket contains
hop counts >= 268435456.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9d1d5fa4ac3abfe464dda1c7adc4616927855b57">9d1d5fa4</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-12-18T01:02:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-doc: Add non-breaking space to lock_buckets documentation

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da8aaf2aee2ff145f3001ae1fcf3626d6a9bc17d">da8aaf2a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-12-18T01:02:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Call an election when the recovery lock is lost

The lock may have been lost due to a failure in the underlying locking
mechanism.  This could be due to quorum loss or similar.  It is best
to call an election to confirm that this node should still be master.
At worst, the node will reelect itself, fail to take the lock and then
ban itself.  This is a suitable outcome for a node that has been
partitioned from others in the cluster.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba83aa9d8b20b11f1febb77d2607ee2a38456f6e">ba83aa9d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-12-18T01:02:03Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Force script directory to be absolute

If TEST_VAR_DIR is relative then symbolic link targets will be
incorrect.

Don't force TEST_VAR_DIR to be absolute because this can result in
Unix domain socket names that are too long.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/45f96c73463a1f17e48610e88a6e103f845fb0c1">45f96c73</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-12-18T01:02:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Force EVENTSCRIPTS_TESTS_VAR_DIR to be absolute

Event scripts (well, statd_callout) can change directory, causing
stubs to be unable to locate EVENTSCRIPTS_TESTS_VAR_DIR if it is
relative.

Don't force TEST_VAR_DIR to be absolute because this can result in
Unix domain socket names that are too long.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/63a4c634a65afbf04080d3958d1b91d3a8770cc7">63a4c634</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-12-18T01:02:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Force symbolic link targets to be absolute

If CTDB_BASE is relative then the symbolic link target will be
incorrect.

Don't force CTDB_BASE to be absolute because this can result in Unix
domain socket names that are too long.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/108aca0a9e71f2efb699dfeb5e3a1d7e24002de7">108aca0a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-12-18T01:02:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Declare and construct data_script only if needed

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/61b54193fe4e7c122bd06b98a7090a245d54250e">61b54193</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-12-18T01:02:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-event: Force symbolic link targets to be absolute

If CTDB_BASE is relative then symbolic link targets will be incorrect.

Don't force CTDB_BASE to be absolute because this can result in Unix
domain socket names that are too long.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1ed91f0e102e3cb67b69e146b8b587e4d0222a8a">1ed91f0e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-12-18T04:31:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Do not force TEST_VAR_DIR to be absolute

This can result in Unix domain socket names that are too long.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue Dec 18 05:31:00 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1e061ff1e3fcfcd020df1a35c1c0697c114cb209">1e061ff1</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-12-18T06:12:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tool: Avoid data uninitialized warnings

../../tools/ctdb.c: In function 'str_to_data':
../../tools/ctdb.c:624: warning: 'data.dsize' may be used uninitialized in this function
../../tools/ctdb.c:624: warning: 'data.dptr' may be used uninitialized in this function

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9912709eca29d21cf56f342079db6b5cc02bbea2">9912709e</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-12-18T06:12:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-build: Use open() instead of file() for python3

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4443124fe8d7c12dfab62f9962939d14cbed1291">4443124f</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-12-18T06:12:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-packaging: Call waf with python wrapper

This allows to build packages even when python3 is not available by
setting PYTHON variable.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59e244c9d0402062ae77c882e2af28d00da44449">59e244c9</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-12-18T06:12:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-packaging: Match configure command as per spec file

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9bdd6814e4c64f3be04daa7e8739e141d2d664b7">9bdd6814</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2018-12-18T06:12:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-packaging: Update library versions to upstream versions

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f1b594dce1c081924b16c52c8c50c984a16df098">f1b594dc</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-12-18T06:12:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Do not force full vacuum on first vacuuming run

When the number of fast path vacuuming runs is 0 then a full vacuuming
run is done.  This means the first one is a full run, which is almost
certainly not what is intended.

Combine the 2 conditionals to only flag a full vacuuming run when the
count exceeds the configured limit.  This means that the
full_vacuum_run flag is set in both parent and child, but this is
harmless... and is better than getting it wrong.

Also tweak the comparison to be less-than-or-equal, since the zeroth
run needs to be counted.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2e3ad8c20d2964fba14d0d5b0b36c334ac22caa5">2e3ad8c2</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-12-18T06:12:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Minimise chances of test interfering with itself

Checking that the database contains 0 records cause a traverse.  This
may take a lock and cause vacuuming to fail (or be deferred for a
particular record/chain).  Minimise the chance of this happening by
only checking for 0 records every 10 seconds.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cdca0d7e78a4cad797ff457f860a37de78bcdb44">cdca0d7e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-12-18T06:12:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon Add extra debug during record deletion for vacuuming

It isn't currently possible to distinguish these 2 cases.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/944c92a15dbbcaaea1cd4e63bf2a109a33126437">944c92a1</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-12-18T09:13:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Modernise debug during record deletion for vacuuming

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue Dec 18 10:13:50 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/90fab07f0710bb2061d3f14326c874dd049823fc">90fab07f</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-12-18T19:11:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-smbd: avoid assuming fsp is always intact after close_file call.

Instead use the already copied smb_fname directly.

https://bugzilla.samba.org/show_bug.cgi?id=13720

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Tue Dec 18 20:11:07 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c817deca0c7afc51a42b97c19ba31e495944a120">c817deca</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-12-19T03:51:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: Remove double init of kerberos error table

The initialization of the kerberos error table
is already performed in smb_krb5_init_context_basic(),
therefore, it can be removed from of its callees.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Dec 19 04:51:27 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8741af7af68b2d74123dc3f82dad3ca746f4caf5">8741af7a</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-12-19T03:52:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4 messaging tests: Add inject fault command

Test for processing of the smbcontrol inject fault message in the samba
daemon.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8167486b99920f48db48ebc1574b5c8032647555">8167486b</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-12-19T03:52:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4 messaging: support smbcontrol inject fault command

Add support of the smbcontrol inject fault command to the samba daemon.
This is useful for manual testing of process restart etc.

command is only enabled for developer and self test builds

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b578fad88e3b5a62fa060474b52dbc7e59fd6a24">b578fad8</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-12-19T03:52:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4 messaging tests: Tests for smbcontrol sleep command

Add a sleep command that pauses the target process for the specified
number seconds

This command is only enabled on developer and self test builds.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff9052c923d1f474696022527663b64f60195a05">ff9052c9</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-12-19T03:52:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3 smbcontrol: Add sleep command

Add a sleep command that pauses the target process for the specified
number of seconds

This command is only enabled on developer and self test builds.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a70deab0fb3726611a041c83d616cda2594264c7">a70deab0</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-12-19T03:52:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3 server: Add support for smbcontrol sleep

Add a sleep command that pauses the target process for the specified number
of seconds

This command is only enabled on self test and developer builds.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b3e4e094261c039320f6ad999043f78695e56021">b3e4e094</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-12-19T03:52:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4 messaging: Add support for smbcontrol sleep

Add a sleep command that pauses the target process for the specified
number of seconds

This command is only enabled on developer and self test builds.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5118985841aa0363147d552f243ab5a7d90dbdaf">51189858</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2018-12-19T07:08:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/util: Count a trailing line that doesn't end in a newline

If the final line of a file does not contain a newline then it isn't
included in the line count.

Change i to point to the next slot in the array instead of the current
one.  This means that that the current line won't be thrown away if no
newline is seen.

Without changing i to unsigned int, the -O3 --picky -developer build
fails with:

[ 745/4136] Compiling lib/util/util_file.c

==> /builds/samba-team/devel/samba/samba-o3.stderr <==
../../lib/util/util_file.c: In function ‘file_lines_parse’:
../../lib/util/util_file.c:251:8: error: assuming signed overflow does not occur when simplifying conditional to constant [-Werror=strict-overflow]
  while (i > 0 && ret[i-1][0] == 0) {
        ^
cc1: all warnings being treated as errors

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13717

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Dec 19 08:08:28 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b1ad5a880fd571c970a0fff33e20f4ea0c469f4c">b1ad5a88</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-19T11:40:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_wrap: Fix bit shifting

lib/krb5_wrap/enctype_convert.c:93:27: runtime error: left shift of 1 by
31 places cannot be represented in type 'int'

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Dec 19 12:40:40 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d0b5e216b0732a95c0fee3e04659ee7d3792baf6">d0b5e216</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Create included files during provision

Files included from smb.conf have to exists, otherwise python fails to
load the configuration. Found while trying to run a python test before
samba3.blackbox.smbd_error creates the included file.

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e8144129111b026444052713618fc5837d43fd96">e8144129</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add a new base class for ntlm_auth tests

The class is based on test_ntlm_auth.py script.

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Pair-programmed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/247592f7162d0e22e8edb889adce1eac5a4cf5f1">247592f7</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth and ntlm_auth with specified domain

Port ntlm_auth bash script tests to python

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a11ab373b309ae7b97c03e367ba509897c20fcc">4a11ab37</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth against winbindd

Port ntlm_auth bash script tests to python

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d3fd3d01f19c227d78f9ba77660c2e73e067aab2">d3fd3d01</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth with NTLMSSP client and gss-spnego server

Port ntlm_auth bash script tests to python

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c9a5bf3c82c988aa424e804305aafa127749837f">c9a5bf3c</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth with NTLMSSP gss-spnego-client and gss-spnego server

Port ntlm_auth bash script tests to python

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4ce9371f5fa99d49f16e0563d0cd185459b58ea3">4ce9371f</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth with NTLMSSP gss-spnego-client and gss-spnego server against winbind

Port ntlm_auth bash script tests to python

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/06d101e3f087ee82ead8f7792a3ddd2a655b7a4b">06d101e3</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth ccached credentials with NTLMSSP client and gss-spnego server

Port ntlm_auth bash script tests to python

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1f704496ea6948b503c3c01eec7812eb8cb12b79">1f704496</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth against winbindd with require-membership-of

Port ntlm_auth bash script tests to python

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Signed-off-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8d11a54e3707e77c78a2f0005c9f4b1922a791b1">8d11a54e</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth with NTLMSSP gss-spnego-client and gss-spnego server against winbind with require-membership-of

Port ntlm_auth bash script tests to python

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/377e87a2347a96a75adf8932651ca607114c95a1">377e87a2</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth against winbindd with failed require-membership-of

Port ntlm_auth bash script tests to python

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/caa505302f5e8752f997fe8aef6cef878f2e3f35">caa50530</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth with NTLMSSP gss-spnego-client and gss-spnego server against winbind with failed require-membership-of

Port ntlm_auth bash script tests to python

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dfa149276f1e2c1a64208ff33ca161008f012d6d">dfa14927</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth plaintext authentication with require-membership-of

Port ntlm_auth bash script tests to python

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3794c1c5274f88c32fa8937b92f30a1308d57bb0">3794c1c5</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth plaintext authentication with failed require-membership-of

Port ntlm_auth bash script tests to python

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/28ea2f7220dfc4f90bc099f306c8a0e5324fee5a">28ea2f72</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth ntlm-server-1 with fixed password

Port ntlm_auth bash script tests to python

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7c0c683b2eafc6f5c8474a4547d970ad3ce5a759">7c0c683b</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth ntlm-server-1 with incorrect fixed password

Port ntlm_auth bash script tests to python

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8d4258f43dea153cc60a6b9dbd36f0ca0b5abf0e">8d4258f4</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth ntlm-server-1 with plaintext password against winbind

Port ntlm_auth bash script tests to python

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3ae7095bbee9ca19056c00a61084d49e5e278728">3ae7095b</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth ntlm-server-1 with plaintext password against winbind but wrong sid

Port ntlm_auth bash script tests to python

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/91c4f2603607a917c1f1006b2f9f83232ac489c4">91c4f260</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth ntlm-server-1 with incorrect fixed password against winbind

Port ntlm_auth bash script tests to python and remove bash test script

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/129ab34baf0b1554dea3d93506b95439bffcb30f">129ab34b</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth_krb5 tests to python

Port ntlm_auth_krb5 bash script tests to python

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4846d4a713679957f31b8da179be192d8b6e7506">4846d4a7</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T11:42:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Remove test_ntlm_auth.py helper

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fe7ab7d5132b2312f617b3c51db9d4c9f9271a51">fe7ab7d5</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2018-12-19T15:21:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ntlm_auth: Port ntlm_auth_diagnostics tests to python

Port ntlm_auth_diagnostics bash script tests to python

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Noel Power <npower@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Wed Dec 19 16:21:32 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/49dc04f9f553c443c78c8073c07ea2a38cde61b2">49dc04f9</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2018-12-19T19:58:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: don't print backtrace on simple DNS errors

samba-tool throws backtraces even for simple DNS error
messages, we should not frighten users for no good reason.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13721

Signed-off-by: Bjoern Jacke <bj@sernet.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Wed Dec 19 20:58:52 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a800baece74fc9d3766af8432adf8efad05ed9d6">a800baec</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-12-19T20:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add MIT kerberos tracing capability

HEIMDAL kerberos offers already tracing via a logging facility
through smb_krb5_init_context().
MIT kerberos offers to register a callback via krb5_set_trace_callback
with which tracing information can be routed to a common logging facility.
This is now integrated into smb_krb5_init_context_basic() offering
the same functionality for both kerberos fragrances.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5056b9622416311535578a481af800afe8c8c729">5056b962</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-12-19T20:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Add kerberos tracing

Add krb5 tracing to samba krb5 wrapper.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2cc561fbbf157ce9bddb702d46f5dba1bf46311b">2cc561fb</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-12-19T20:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">client: Add kerberos tracing

Replace kerberos context initialization from
raw krb5_init_context() to smb_krb5_init_context_basic()
which is adding common tracing as well.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3df7789e4b34f08b21d7d5d294831c795f0145d4">3df7789e</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-12-19T20:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libads: Add kerberos tracing

Replace kerberos context initialization from
raw krb5_init_context() to smb_krb5_init_context_basic()
which is adding common tracing as well.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8887a68031070e0d6b93f7283b7ab409977206de">8887a680</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-12-19T20:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnet: Add kerberos tracing

Replace kerberos context initialization from
raw krb5_init_context() to smb_krb5_init_context_basic()
which is adding common tracing as well.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f33864770ee973ab35da07494c1100f628070be">9f338647</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-12-19T20:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Add kerberos tracing

Replace kerberos context initialization from
raw krb5_init_context() to smb_krb5_init_context_basic()
which is adding common tracing as well.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf67593892402fc469ecb7930795dafe273e60e7">bf675938</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-12-19T20:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">passdb: Add kerberos tracing

Replace kerberos context initialization from
raw krb5_init_context() to smb_krb5_init_context_basic()
which is adding common tracing as well.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5eefb0885c935854fd3ddc1fcbab2c456745ee0f">5eefb088</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-12-19T20:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">utils: Add kerberos tracing

Replace kerberos context initialization from
raw krb5_init_context() to smb_krb5_init_context_basic()
which is adding common tracing as well.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0b0a22ddad0e5f1542aee6ed65efaedb08471cc5">0b0a22dd</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-12-19T20:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Add kerberos tracing

Replace kerberos context initialization from
raw krb5_init_context() to smb_krb5_init_context_basic()
which is adding common tracing as well.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/357fe04bd477858bb21cfb5e8a5e0efc556864d6">357fe04b</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2018-12-20T00:31:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: Add kerberos tracing

Replace kerberos context initialization from
raw krb5_init_context() to smb_krb5_init_context_basic()
which is adding common tracing as well.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>

Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Thu Dec 20 01:31:17 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a2562fd2b426ec25131f5fd83d4f835ad604847">7a2562fd</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-20T02:19:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debug: move some definitions around

They will be needed by some function in a subsequent commit.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3b293c669024e55d2c5343e85f1f43a03682b478">3b293c66</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-20T02:19:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debug: rename DEBUGLEVEL_CLASS variable to dbgc_config

Variable names should not be given in uppercase.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d346cf94a44a7a4fd45b33d9369dbbc404e0ebb0">d346cf94</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-20T02:19:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debug: README.Coding fixes

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/63f330761e7bebf9ee9200a9e1302c373519d226">63f33076</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-20T02:19:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debug: convert dbgc_config to an array of struct debug_class

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e6655f0887313a9ad99406a89a66c6950ba970bb">e6655f08</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-20T02:19:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debug: track current debug message class

This is analog to current_msg_level.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/240b08c414c375c16ad0b1524202f1337b7e9e6d">240b08c4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-20T02:19:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debug: factor out a function that opens and closes the new and old logfile

The new function reopen_one_log() will also be used for per-class
logfiles in subsequent commmits.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2bc7e254a62cfc6a60ecff425fc71173c6d21a10">2bc7e254</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-20T02:19:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debug: add an empty line

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4341f24069f991dc7119093e418aac392e0a1b50">4341f240</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-20T02:19:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debug: add a call to debug_parse_levels() to reopen_logs()

This allows correct refresh of the "log level" setting when reloading config.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7369674787d91c40f8eff7bc71f6d73dab341315">73696747</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-20T02:19:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debug: factor out logfile size check

The new function will also be used for upcoming per-debug-class logfiles.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/43c693511d971210107535644b975a465b012373">43c69351</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-20T02:19:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debug: add logfile and fd to struct debug_class

Initialized to -1. Already checked in debug_file_log() without affecting
behaviour until subsequent commits set per-debug-class fds.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/abfb3c6bbf5d3d27ca61cd973ffb15c3d8e2be4f">abfb3c6b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-20T02:19:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debug: add resource cleanup for per debug-class logfiles

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/249bdd9378306c146dca0eec6711e2c6b8eae29a">249bdd93</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-20T02:19:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debug: add support for per debug-class logfiles

This adds support for per debug-class logfiles to the function parsing
the "log level" option.

The enhanced syntax is:

  log level = CLASS:LEVEL[@PATH] [CLASS:LEVEL[@PATH] ... ]

Eg

  log level = full_audit:1@/var/log/audit.logfile

While the option is already parsed and stored in in the dbgc_config[]
array, the feature is still effectively disabled, as
reopen_logs_internal() still doesn't open the per debug-class logfiles.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d792f15ff1406cde7f38ddc5febb08a8b39b90e8">d792f15f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-20T02:19:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debug: update need_to_check_log_size() for per debug-class logfiles

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/781f5a95edde4cd27627515869bfe2fc626fbb3a">781f5a95</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-20T02:19:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debug: update logsize checking for per debug-class logfiles

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3dbda63284cdeb2f060931c85388842627c955a1">3dbda632</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-20T02:19:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debug: remove fd and debugf from state, use dbgc_config[DBGC_ALL]

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/08d37b4a44bc7daed3c1c5774a3d7e796de582ef">08d37b4a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-20T02:19:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">debug: enable per debug-class logfiles

This finally enables per debug-class logfiles by hooking into
reopen_logs_internal() calls to reopen_one_log() per configured
debug-class.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/35349fecbd075a5e5dd4c87be465d61c5104fb21">35349fec</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2018-12-20T02:19:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml: document "log level" changes

"log level" now takes an optional per debug-class logfile:

  log level = 1 full_audit:1@/var/log/audit.log winbind:2

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c928d7cd1d0ac994fe95892eec235b939ad2ec9">5c928d7c</a></strong>
<div>
<span>by Philipp Gesang</span>
<i>at 2018-12-20T02:19:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/audit_logging: actually create talloc

Heal damage of 79f494e51e..

That context is being passed around and freed but is never
actually allocated on that stack.

Signed-off-by: Philipp Gesang <philipp.gesang@intra2net.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1b263ed631c86bf4117c9388fce3fa1f24cea4c9">1b263ed6</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-12-20T06:18:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-vfs-streams_xattr: add close call

https://bugzilla.samba.org/show_bug.cgi?id=13725

We cannot always rely on vfs_default to close the fake fds. This mostly is
relevant when used with another non-local VFS filesystem module such as
gluster.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Dec 20 07:18:20 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/865538fabaea33741f5fa542dbc3f2e08308c2c1">865538fa</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-20T07:41:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: ignore create_builtin_guests() failing without a valid idmap configuration

This happens on standalone servers, where winbindd is automatically
started by init scripts if it's installed. But it's not really
used and may not have a valid idmap configuration (
"idmap config * : range" has no default!)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13697

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f3bac8c91121871bf8ce852bc3e3ea2e834d3f27">f3bac8c9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-20T07:41:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth_winbind: remove fallback to optional backend

This is not possible anymore, as the trustdomain backend
was removed in commit 75c152c0d764165a4a9dd0a85390af063dd0192a.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13722
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13723

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ec3adc1e5b3cc953576efa795dfb25af08a8ab79">ec3adc1e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-20T07:41:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth_winbind: return NT_STATUS_NO_LOGON_SERVERS if winbindd is not available

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13722
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13723

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/63dc60767eb13d8fc09ed4bc44faa538581b18f1">63dc6076</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-20T11:15:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth_winbind: ignore a missing winbindd as NT4 PDC/BDC without trusts

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13722

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>

Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Thu Dec 20 12:15:09 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a35a6874add19277647fff70c0d730ef1efa85a">7a35a687</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-20T11:16:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: Add missing libreplace deps to pyldb*

This will require memset_s() because of a later commit moving
ZERO_STRUCT to use memset_s().

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7eaa59686bb9707678d3dba2f8e9565b91256235">7eaa5968</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-20T11:16:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Do not remove BUILTINS as duplicates

BUILTINS add object files to the target, so we can't remove them as
duplicates.

The issue e.g happens when tevent wants to link libreplace:

   20:04:10 deps removing dups from tevent of type LIBRARY: {'replace'}
   also in LIBRARY talloc

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9968217b88016c223ecae64f6790d6cfaa4bd340">9968217b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-20T11:16:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Add memset_s to replacement functions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/255117a14f117fa91fc68bf349962e3235a96acf">255117a1</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-20T11:16:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Cleanup comments for ZERO_*

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3611f18f136b14833cc650856c8d86904299eb5a">3611f18f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-20T11:16:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Use memset_s for ZERO_* macros

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e99ca99dfed85bdc5c2206f59aec3782f4f5a62b">e99ca99d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-20T11:16:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Cleanup comments in memory.h

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/161d14f200933855ccd3b12ff228079333bc72f7">161d14f2</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-20T11:16:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Sync memory.h with replace.h

We can't remove memory.h as this is a public header file. So we need to
duplicate them from replace.h

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b2c6c0e56b048e29d97e7efe535ba56b41b10b5">6b2c6c0e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-20T11:16:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Use C99 initializers or ZERO_ARRAY instead of ZERO_STRUCT

ZERO_STRUCT is not wrong here, it will give the same result, but better
use macros with correct naming as it makes clear what happens when you
read the code.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/39bff1f90b9bdae02986fad10bd44384447bece9">39bff1f9</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-20T11:16:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Avoid explicit ZERO_STRUCT

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f9c15350998bfcb9e71d3ab225c525c7cf589fca">f9c15350</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2018-12-20T15:11:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Use memset_s() in data_blob_clear()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Dec 20 16:11:03 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/454d7d00ec7be792ad637c51ef0a9e0e24bb7360">454d7d00</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/69a3b899f1190a5517be0218068532430c7e7077">69a3b899</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbcacls: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/444fc0bfcc83a911a7ceeac3d3a24af9254d6bd6">444fc0bf</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d5c00a34d85b530852ae2544de6fd73e9ff9bce">1d5c00a3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libads: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/534620d160f1a481ac2146b479e2d327f7676a09">534620d1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/09efea3cb6395c99a8818ff75837e556e6fc8fa4">09efea3c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">groupdb: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6438819609d1373da54a4efd4346fcd49ab91ff4">64388196</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">passdb: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/998d1d1ac4e25114a8d93975ec285d58c4d9b81b">998d1d1a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pdb_smbpasswd: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4cd68f3d16c97760e8b5d13262876a679b80ad0a">4cd68f3d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pdb_ldap: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c45c6d09370a15021e0158a0356af84913b068f4">c45c6d09</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lookup_sid: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59f29acb2cd947d2f594a5af3d73d0cbe8298d92">59f29acb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6af7d7ffda8025a2d270ba1d01b0708efca511a2">6af7d7ff</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth3: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da3e3c5e05770330f69f75a97443477b1d028d78">da3e3c5e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Avoid sid_string_dbg

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4d4a59ece289065aa31d9342cb9666b0b7bd779c">4d4a59ec</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1ab6c336a3f242eebb64b88407be86fa2e00da46">1ab6c336</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnet: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d425cd5b683feeb7fd2d9a532fe7fe9b28c077c8">d425cd5b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wkssvc: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/58f76ab13760947ddf2e8298e8191fa084105a7f">58f76ab1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/31da287b1c8134227ad9371a922881a7b99dba87">31da287b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">spoolss: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fa6690e90cdbbb4af2f0d6abedc4fdb5574a4571">fa6690e9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lsasrv: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fc51f82407d2b9716336db39a508cfba395ff65d">fc51f824</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samr: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/131ee1b2dbfab5267bb601d935c6af249d7ec6bd">131ee1b2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2018-12-20T22:40:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove sid_string_dbg

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd6175a273c7376ec6960f9a8f519fcfcf79ed37">dd6175a2</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-12-20T22:40:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: test for treating fully qualified zones same as unqualified

Failing test that checks if fully qualified zone names are treated the same
as unqualified zone names by the dns zone creation RPC method. Fix to follow.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13214
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ebc42cb140ca7477428798678f8552ef76a04dec">ebc42cb1</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-12-20T22:40:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: treating fully qualified and unqualified zone as identical.

"zone.com." and "zone.com" should be treated as the same zone.  This patch
picks the unqualified representation as standard and enforces it, in order to
match BIND9 behaviour.
Note: This fixes the failing test added previously, but that test still fails
on the rodc test target so we modify the expected failure but don't remove it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13442
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bd2d6b2bbed1b5b676232c2094c2c65ed86d21e2">bd2d6b2b</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-12-20T22:40:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: JSON logging changes

Add details of the Windows Event Id's and Logon Types added to the
Authorization qnd PasswordChange JSON messages.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/05c981f0b4acd7b27e72098def023c82b92b6e59">05c981f0</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-12-20T22:40:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests (audit_auth)_log: PEP8 cleanup.

Remove Flake8 warnings from the audit and authentication JSON log
tests.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/390871602d244510c941f3c978d2f4371bb62bb7">39087160</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-12-21T02:39:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4 messaging tests: Fix race condition in smbcontrol tests

The test for the smbcontrol sleep command and the inject fault command
both used the "rpc_server" process as a target.  As the inject fault
command caused the process to restart there was a race condition between
the process restarting and the sleep test running.  To prevent this the
tests now use different target processes.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Dec 21 03:39:24 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba016939aa91e0806f509c8b8ce9506bebceb7e5">ba016939</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2018-12-21T06:20:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-vfs-fruit: add close call

https://bugzilla.samba.org/show_bug.cgi?id=13725

We cannot always rely on vfs_default to close the fake fds. This mostly is
relevant when used with another non-local VFS filesystem module such as
gluster.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Dec 21 07:20:49 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/96c03c75329e03bdbb1049522207cfca76d4489d">96c03c75</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-12-21T06:21:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vlv: tests for delete, add, and modify cases

More vlv testing for cases involving modifying, deleting, and adding records
while observing the effect on already initialised views.

Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/975807001e91f75906ccc8a01bc4093aea46e9eb">97580700</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-12-21T06:21:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">paged results: new paged results module using GUID list

Replacing paged results module to use GUID list instead of storing
result list in memory, in order to improve memory performance.

Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/22f1c4005caae5c5a376fd180be98b1be0db2afc">22f1c400</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2018-12-21T10:10:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">paged results: testing suite for new paged results module

Testing the new GUID list based paged results module

Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Fri Dec 21 11:10:30 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b99b51400c3e3e40b848d57d01f67b8d72d772b5">b99b5140</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-12-21T21:16:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Remove --timestamp-dependencies (BROKEN)

Remove this code marked as broken, we do not need broken configure options making Samba
appear to be more complex than it already is.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87a8325a0d511ec2177ef501828b50deb0ce50b9">87a8325a</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-12-21T21:16:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4 group_audit: Add Windows Event Id's to Group membership changes

Generate a GroupChange event when a user is created with a PrimaryGroup
membership.  Log the windows event id in the JSON GroupChange message.

Event Id's supported are:
        4728    A member was added to a security enabled global group
        4729    A member was removed from a security enabled global
                group
        4732    A member was added to a security enabled local group
        4733    A member was removed from a security enabled local group
        4746    A member was added to a security disabled local group
        4747    A member was removed from a security disabled local group
        4751    A member was added to a security disabled global group
        4752    A member was removed from a security disabled global
                group
        4756    A member was added to a security enabled universal
                group
        4757    A member was removed from a security enabled universal
                group
        4761    A member was added to a security disabled universal
                group
        4762    A member was removed from a security disabled universal
                group

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/27273a55dd0634db9324c74a73b80a1989a64372">27273a55</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2018-12-21T21:16:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests group_audit: PEP8 cleanup.

Remove Flake8 warnings from the group  audit JSON log tests.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/42dde0bdd3af8aaa6350fec36fb99b98ab501aa1">42dde0bd</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2018-12-22T00:58:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">group_audit: Ensure we still log membership changes (with an error) where status != LDB_SUCCESS

This restores the previous behaviour.  It causes (only) the event ID
to be omitted if status != LDB_SUCCESS or there was a problem getting
the group type.

Errors at this stage are exceedingly rare, because the values have
already been checked by the repl_meta_data module, but this is
cosistent with the rest of the module again.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Dec 22 01:58:48 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b9496ddb39e685d1f742c26ba390d26f5a3eabfb">b9496ddb</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2018-12-22T02:11:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind_nss_aix: support also S_GROUPSIDS

which is used by lsuser up to AIX 5.2, see also https://bugzilla.samba.org/show_bug.cgi?id=5157

Signed-off-by: Bjoern Jacke <bj@sernet.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9b71194fb1842be09841f0f29470f42f2ea97c2">a9b71194</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-22T02:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch/winbind_nss_aix: reimplement fetching the SID of a user

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Bjoern Jacke <bj@sernet.de>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/245b494cebf0fb2c21a4e874141178573a086cfb">245b494c</a></strong>
<div>
<span>by Bjoern Jacke</span>
<i>at 2018-12-22T02:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind introduce WBFLAG_FROM_NSS

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Bjoern Jacke <bj@sernet.de>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f95495e1f7d31dd32a979514d150ecb755a8c1a1">f95495e1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-22T02:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: honor WBFLAG_FROM_NSS along with winbind enum users/groups

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Bjoern Jacke <bj@sernet.de>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4a7368501a9df8f0b8f29a94faa0c1099c0a477a">4a736850</a></strong>
<div>
<span>by Bjoern Jacke</span>
<i>at 2018-12-22T02:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch/winbind_nss_linux.c use WBFLAG_FROM_NSS

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Bjoern Jacke <bj@sernet.de>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fcda61bb41be5e638b9124cb5570bbb2fa214a13">fcda61bb</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2018-12-22T02:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind_nss_netbsd: use WBFLAG_FROM_NSS

Signed-off-by: Bjoern Jacke <bj@sernet.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/faf50b2d70228cce6b95a068bbe7da2a40d63419">faf50b2d</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2018-12-22T02:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind_nss_solaris: use WBFLAG_FROM_NSS

Signed-off-by: Bjoern Jacke <bj@sernet.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c36cf69d5911b86d73a495308c1bed14004b0659">c36cf69d</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2018-12-22T02:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind_nss_aix: use WBFLAG_FROM_NSS

Signed-off-by: Bjoern Jacke <bj@sernet.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2e1bc87b13c491f47a6fbcf9549ffa8250a2508b">2e1bc87b</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2018-12-22T02:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind_nss_aix: add incomplete attr_flag initializations

Found by Jürgen Starek, see https://bugzilla.samba.org/show_bug.cgi?id=5157

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Bjoern Jacke <bj@sernet.de>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ccd4759aaff340321792e3b5acab6bc3c8d8cfbb">ccd4759a</a></strong>
<div>
<span>by Bjoern Jacke</span>
<i>at 2018-12-22T05:22:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nss/waf: check for secmethod_table.method_{attrlist,version} for aix >= 5.2

The original commit 02c9b46fab46ab401a3cf6bb74c8260801c41032 was not ported to waf yet.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Bjoern Jacke <bj@sernet.de>

Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Sat Dec 22 06:22:22 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/48815cc16a5471c85236d05e3f0bea013d39f3bd">48815cc1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: do an early return if we don't have a password for ads_kinit_password()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4114d2d044ef8eaca5899b84e4dd52bf4dd005b0">4114d2d0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:librpc: add python witness bindings

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8b153f844030e0268f315e27154abda51c7931f8">8b153f84</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:librpc: add python spoolss bindings

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e27b62762d4382b88b77aa1e80364e515fa54e0e">e27b6276</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:librpc: add python winspool bindings

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/deb0c2bdcbad32cb573d72ad540ba47ced2e0807">deb0c2bd</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: add settimeout()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c91446cf7af586a7f4731773649e1628acf08010">c91446cf</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/tests: rename dcerpc/string.py -> string_tests.py

Otherwise it's not possible to run the raw_protocol tests anymore:

python/samba/tests/dcerpc/raw_protocol.py
Traceback (most recent call last):
  File "python/samba/tests/dcerpc/raw_protocol.py", line 26, in <module>
    import samba.dcerpc.dcerpc as dcerpc
  File "bin/python/samba/__init__.py", line 32, in <module>
    from samba.compat import string_types
  File "bin/python/samba/compat.py", line 151, in <module>
    from urllib import quote as urllib_quote
  File "/usr/lib/python2.7/urllib.py", line 25, in <module>
    import string
  File "/abs/path/samba/python/samba/tests/dcerpc/string.py", line 22, in <module>
    # Some strings for ctype-style character classification
  File "bin/python/samba/tests/__init__.py", line 36, in <module>
    from samba.compat import text_type
ImportError: cannot import name text_type

This allows the following again:

SMB_CONF_PATH=/dev/null \
    SERVER=172.31.9.188 \
    TARGET_HOSTNAME=w2012r2-188.w2012r2-l6.base \
    USERNAME=administrator \
    PASSWORD=A1b2C3d4 \
    DOMAIN=W2012R2-L6 \
    REALM=W2012R2-L6.BASE \
    python/samba/tests/dcerpc/raw_protocol.py -v -f TestDCERPC_BIND

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/71450d85123417464798ad63c9e9bd59214a79ef">71450d85</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_protocol: rename test_spnego_packet_bind_sign_privacy => test_spnego_packet_bind_seal

This makes it consistent with other tests like
test_spnego_integrity_bind_seal.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cc2dc2e2b32967f5590bf59146520d760fecbab4">cc2dc2e2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: disconnect on tearDown() of RawDCERPCTest

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fc4a8c17ef34aa3690510642277b7203c1973e7e">fc4a8c17</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_protocol: explicitly disconnect additional connections

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/460a9d379ff7fb857535520f28cdcc4e49102c13">460a9d37</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: add assertPadding() that allows IGNORE_RANDOM_PAD=1

Sometimes Windows returns non zero bytes in padding fields,
we won't allow that by default, but IGNORE_RANDOM_PAD=1 will
will only do the length check.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dae9c53fffaa41124a3fa96cb95280c8ddcbecba">dae9c53f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: make use of assertPadding()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da82aa2fe48291e14059e3092d5416bb552b9325">da82aa2f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_protocol: make use of assertPadding()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1ba90daeb426df0273d1870e2893d691d42fe59b">1ba90dae</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: let do_single_request() check stub length against alloc_hint

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59b84d6499c5c22f76c203525a3994ab29038e7e">59b84d64</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_protocol: let self._test_spnego_bind_auth_level() return auth_context

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/20ed4bd920095ddb9b89a3c04d27c6fba2990cf7">20ed4bd9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: pass auth_context and stub_len to parse_auth() in order to assert

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8fc1f5626077c94226d82e7807fdc36d63ee9ab6">8fc1f562</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_protocol: rename _test_spnego_bind_auth_level to_test_auth_bind_auth_level

We now pass down dcerpc.DCERPC_AUTH_TYPE_SPNEGO from callers
instead of having SPNEGO specific functions.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b1c385865fd5371d332cb562d800ce1abab1cb5">6b1c3858</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_protocol: rename _test_spnego_signing_auth_level_request to _test_auth_signing_auth_level_request

We now pass down dcerpc.DCERPC_AUTH_TYPE_SPNEGO from callers
instead of having SPNEGO specific functions.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fed1cdbe8bcf87f5227d9c79f228e03d13dfcb71">fed1cdbe</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: add check_response_auth() helper function

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/168aa7c325e25b9136970d4282297b501873cced">168aa7c3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: add generate_request_auth() helper function

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0b741c49c125a55380fa29d61deb8ff739b3e5f5">0b741c49</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: use check_response_auth() in do_single_request()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/87197f0c51a2b81c4a8683984f3464a8081dcda4">87197f0c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: use generate_request_auth() in do_single_request()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3924924e610ee1c5b9ebb914e45b8c3bc996fa4f">3924924e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: use require DOMAIN/REALM in get_user_creds()

This is the usage now:

SMB_CONF_PATH=/dev/null \
    SERVER=172.31.9.188 \
    TARGET_HOSTNAME=w2012r2-188.w2012r2-l6.base \
    USERNAME=administrator \
    PASSWORD=A1b2C3d4 \
    DOMAIN=W2012R2-L6 \
    REALM=W2012R2-L6.BASE \
    IGNORE_RANDOM_PAD=1 \
    python/samba/tests/dcerpc/raw_protocol.py -v -f TestDCERPC_BIND

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/68e5dbe78455bb2b83d5cb03f0d8e737a6564c7c">68e5dbe7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: prepare do_generic_bind() for raw NTLMSSP and Kerberos authentication

They just use 3 legs (messages) for the authentication, while SPNEGO
uses 2 or 4 messages.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78a5e4ec6e2bd486f64358f10c79bad240f34ac5">78a5e4ec</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: prepare get_auth_context_creds() and do_generic_bind() for header signing

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f819df4de59f63deea00d802a365b09b9c738ff0">f819df4d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_protocol: test signing with and without header signing

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6574d2daef9fc7b4b6b3b1c31261b8ea645a0911">6574d2da</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_protocol: test signing also with raw NTLMSSP and Kerberos

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a83cb02a1c5eb61624e53b127134ccd6f9b3fc8">7a83cb02</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: add start_with_alter to do_generic_bind()

This will allow do_generic_bind() to be used to test
security context multiplexing.

Check with git show -w

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7fb5c575fbecc4f7ab9703946fe64911d610c847">7fb5c575</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: support DCERPC_AUTH_LEVEL_CONNECT in do_single_request()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/196cc4dbd3ffdc7c52c90c2b060c3e9ab1310380">196cc4db</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: maintain self.max_{xmit,recv}_frag

This was it's easier to alter once add support for SMB connections.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/df7d4787152eb2ef91d34633c3caf25f8ef68d3c">df7d4787</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: maintain self.secondary_address

This was it's easier to alter once add support for SMB connections.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b34eb437fe2508ad445125bc7139300981c43002">b34eb437</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T17:15:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: add helper functions for ncacn_np: SMB connection support

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be2a67319d1b0f423d8fa19137c9a953398ddd50">be2a6731</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2018-12-23T20:33:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/gensec: enforce that all DCERPC contexts support SIGN_PKT_HEADER

That's currently always the case and will simplifies the callers.

WORKS now???
TDB_NO_FSYNC=1 buildnice make -j test FAIL_IMMEDIATELY=1 SOCKET_WRAPPER_KEEP_PCAP=1 TESTS='samba4.rpc.lsa.secrets.*ncacn_np.*Kerberos.*Samba3.*fl2000dc'
and
TDB_NO_FSYNC=1 buildnice make -j test FAIL_IMMEDIATELY=1 SOCKET_WRAPPER_KEEP_PCAP=1 TESTS='samba3.rpc.lsa.*ncacn_ip_tcp.*nt4_dc'

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sun Dec 23 21:33:51 CET 2018 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3d016d6f327058db49f6920e92102df4dcc85945">3d016d6f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-01T15:02:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Happy New Year 2019!

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Jan  1 16:02:05 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f353c930969f08a5aabe6a7c409f98dbcf90fe9e">f353c930</a></strong>
<div>
<span>by Bjoern Jacke</span>
<i>at 2019-01-02T13:10:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: let CHECK_SIZEOF check for 64 bit also

wafsamba: utmp can be 64 bit also (like on AIX)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12017

Signed-off-by: Bjoern Jacke <bj@sernet.de>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Jan  2 14:10:41 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b7d350b45bc032bf1b61f0184500d068631b7329">b7d350b4</a></strong>
<div>
<span>by Bjoern Jacke</span>
<i>at 2019-01-04T15:29:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Fix build on AIX

AIX makes a define of ip_len in netinet/ip.h (sic!)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13731

Signed-off-by: Bjoern Jacke <bj@sernet.de>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Jan  4 16:29:50 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6fff2c26dacb49da749a4ee8261639f518342573">6fff2c26</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T00:23:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Make lp a mandatory param for the SMB connection

Currently establishing the SMB connection relies on having initialized
the global source3 loadparm.

This patch makes the lp param mandatory, so that you always have to pass
the parameter in when establishing the SMB connection.

It also makes the source3 API more consistent with the current source4
API, which will make it easier to replace the source4 version later.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8096419c712a66ee2d577a98dfba108a3bd7d6fe">8096419c</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T00:23:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Add .unlink() API to SMB Py bindings

Add a basic .unlink() API to the source3 bindings. This is based on the
source4 python bindings, but uses the source3 client library APIs.
(We use a helper function to do most of the work, because we will need
to reuse it in order to support the deltree API).

Update the source4 test to use the source3 API. We will gradually
convert it over, and then delete the source4 python bindings.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a40e538df5ba51355a4c4a9949e66b0893f06c0">6a40e538</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T00:23:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Add .mkdir(), .rmdir() APIS to SMB py bindings

I kept these separate from the chkpath API because it's a nice way to
use the old s4 API in the tests to verify the new s3 API works
correctly.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c4dee3437afcf4ccba70cb3fd5848b65fd229781">c4dee343</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T00:23:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Add .chkpath() API to SMB py bindings

Note that this is checking the existence of *directories*, not *files*.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/40f4e52732f73b8b7b90d3176e4a4536ef6bc678">40f4e527</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T00:23:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Consolidate .readdir()/.list() py bindings API

Rename the .readdir API to .list and make the parameters match up with
the s4 python bindings, i.e. 'mask' is optional and separate from the
directory parameter.

Note that nothing uses the .readdir source3 API currently, so it's safe
to rename.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2033208a4a936912343f4dcc23576687a2a82c3a">2033208a</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T00:23:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Split out code into list_helper()

Refactor out the code so we can re-use it for the synchronous API as
well.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/057161039f45baf4acb582a6a8e6d41e3de317bd">05716103</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T00:23:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Split code out into do_listing() helper

We'll want to reuse the directory listing function for the deltree API.
This patch splits the bulk of the work out into a do_listing() helper
function.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3ac4866d15af3ddebdfa2d9611fc094bf357bc3e">3ac4866d</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T00:23:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Make .list() work for SMBv2

In order for .list() to work on an SMBv2 connection we need to
use the synchronous API.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5f1ed29d6b7388e5ce0ad0023daa39cb8c4cb4dc">5f1ed29d</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T00:23:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Don't return '.'/'..' in .list()

The source4 .list() API wasn't doing this. This makes source3 and source4
have *almost* equivalent functionality, so we can start usign the
source3 API in the tests.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6bcd64a4f14332de3259204b78c5b68988e98b6f">6bcd64a4</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T00:23:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Make s3 and s4 listings return the same dict

Make the python dictionary generated by the s3 .list() use the same keys
as the current source4 dict. The reason for using the source4 dict is
that other python code depends on these keys (e.g. ntacls.py), whereas
the source3 API is currently unused.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e4d1d53597ac093d56ad9d528e2e580e626ab359">e4d1d535</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T00:23:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Free async .list() memory

finfos was being allocated but never freed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0af78faf5c9424514ba5bc0baa18701c65c884e7">0af78faf</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T00:23:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Add .savefile() API to SMB py bindings

This provides a simple API for writing a file's contents and makes the
s3 API consistent with the s4 API.

All the async APIs here support SMBv2 so we don't need to use the sync
APIs at all.

Note that we have the choice here of using either cli_write_send() or
cli_push_send(). I chose the latter, because that's what smbclient uses.
It also appears to handle writing a large file better (i.e. one that
exceeds the max write size of the underlying connection).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d7c7d6203ba85785d23481f3926aa6ddb29a7311">d7c7d620</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T00:23:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Add .loadfile() API to SMB py bindings

Add a .loadfile API to read a file's contents. This provides a
convenient way to read a file and is consistent with the existing
source4 API, which is used by things like the GPO python code and the
ntacls backup.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d0d1a758bacaf160f320f39156923ab4c273fd5">1d0d1a75</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T00:23:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: Avoid duplicated code by making cli_read_sink() public

cli_read_sink() and pull_helper() were essentially identical. By making
cli_read_sink() non-static, we can delete the latter.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ea00215d53891215e20531f75a7ec7e5dec3df5e">ea00215d</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T00:23:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Minor refactor to py_cli_list() variables

Add a define for the file attribute mask (we'll reuse it in a subsequent
patch), and make the variable type explicit.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a3e640bbaa45f2b6cd2e9a2ff514fdfa26759d0">9a3e640b</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T00:23:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Add .deltree() API to SMB py bindings

This basically re-uses the underlying functionality of existing APIs in
order to support a .deltree() API, i.e.
- we use the .list() functionality (i.e. do_listing()) to traverse every
  item in the given directory.
- we then use either .unlink() (i.e. unlink_file()) or .rmdir() (i.e.
  remove_dir()) to delete the individual item.
- sub-directories are handled recursively, by repeating the process.

Note that the .deltree() API is currently only really used for testing
(and deleting GPO files). So the recursion is never going to be
excessive.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c95a869e85201f836c1579e0f50021e3ffc4cbe0">c95a869e</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T00:23:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Completely replace s4 connection in smb tests

This test now uses the s3 python bindings completely, so we can remove
the s4 connection.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f731d7642de3b1e4cbe43dcd354f0e9dc902787">7f731d76</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T00:23:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Avoid hardcoding domain in test

Currently the sysvol domain directory is hard-coded, so the tests can
only ever run on the ad_dc.

This patch makes things marginally better by using the REALM
environmental variable instead. This allows us to run it against other
testenvs (like the SMBv2-only restoredc).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/01079b50a9413d85eb8295159f036248bdd0edf2">01079b50</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T03:29:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Run SMB Py bindings tests against testenv with SMBv1-disabled

Sanity-check that the SMBv2 connection actually works by running it
against a testenv with SMBv1 disabled.

I've dropped 'local' from the ad_dc target, because it shouldn't be
needed. We're trying to test the client-side SMB connection, so running
it without 'local' is probably a better test.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Tim Beale <timbeale@samba.org>
Autobuild-Date(master): Mon Jan  7 04:29:51 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8662ff6720189fae9b7f7ef8afad8c2ed41bd350">8662ff67</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T21:48:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Rename libsmb_samba_internal Py bindings to libsmb

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bd66d46a399ac3e78ab49ebede867f160c67e774">bd66d46a</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T21:48:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Rename libsmb_samba_internal test to libsmb

So that it better matches the updated Python bindings name.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/27e2b5c6c0c8daada0763fd2c90b3b17c0a68cd6">27e2b5c6</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T21:48:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Rename 'credentials' param to match s4

s4 just calls it 'creds'. Renaming it will make it easier to convert
existing SMB connections over to use the new bindings.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3ba32aa55fa6bcd89a2ae9ed73e748ea8ca30b26">3ba32aa5</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T21:48:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Add flags used by .list() to SMB Py bindings

These flags are exposed by the s4 code. Python code that calls .list()
checks the returned attribs/mode for the directory listing, e.g. to work
out whether something is a sub-directory:

  if item['attrib'] & libsmb.FILE_ATTRIBUTE_DIRECTORY...

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/af1fe6fdd95153dd74415a4d20b3c3cd428bd16d">af1fe6fd</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T21:48:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/ntacls: Convert ntacls to use s3 flags

This helper code is just using the flags defined by the Python bindings.
Convert it over to use s3 bindings instead of s4.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5a6fcdd8feea3505407b5130174ff3547a88915d">5a6fcdd8</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T21:48:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Avoid hardcoding domain in GPO tests

The realm varies by testenv. Currently the GPO tests will only run on
the ad_dc testenv.

A slightly better solution is to use the REALM environmental variable,
so that the test can run on any testenv.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/888c6080c5fed1a85374090f7389fc4cb9d36782">888c6080</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-07T21:48:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Refactor duplicated SMB connect in GPO commands

Do the SMB connection in a single helper function.

Note: this highlights that perhaps we want all SMB connections to be
signed, but we can fix that up separately.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/24cfa0baf515cf81f21c3f7547b66fd7a44a8ea1">24cfa0ba</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-08T02:13:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Small refactor to SMB connection in domain backup

Rework the code so we only do this in one place.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Tim Beale <timbeale@samba.org>
Autobuild-Date(master): Tue Jan  8 03:13:48 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/facd6f2daf6df0f9c82bcbe36946507736e9648c">facd6f2d</a></strong>
<div>
<span>by Aliaksei Karaliou</span>
<i>at 2019-01-08T02:40:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture:base:bench-readwrite: fix uninitialized memory causing segfault

Allocation of 'struct smb_composite_connect' happens without zeroing
so that smb_composite_connect_send() thinks that connection
already exists and fails on its handling.

Signed-off-by: Aliaksei Karaliou <akaraliou@panasas.com>
Reviewed-by: Douglas Bagnall <dbagnall@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fa945bc1e09829d8ef8a4454d420cbd07ca47002">fa945bc1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T02:40:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Use strlcpy instead of StrnCpy

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e74ad1b74514b23e11ebc46c1234f5421eda798f">e74ad1b7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T02:40:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nmbd: Use strlcpy instead of StrnCpy

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2cc2a75305955cf0974c7de801ec440a8e45e3fb">2cc2a753</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T02:40:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use strlcpy instead of StrnCpy

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cc0664dd0453c85147b4b270bddb418bb1d4d0a9">cc0664dd</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T02:40:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove StrnCpy

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/12ffef9fc2d6deba8e39e7097ab0e94750f8e7b3">12ffef9f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T02:40:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth3: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/af95db60dec913fb509194e8c8f70d81c2e4e859">af95db60</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T02:40:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b8c77152e901de97c182285a698a67fad7bb7b3">6b8c7715</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T02:40:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: Simplify smblsa_lookup_name

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/08be989aa91682956133270a6ee41bd1ae1622d1">08be989a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T02:40:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbclient: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c9036f2597b90103df9469ffed637ed132c39846">c9036f25</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T02:40:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libndr: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0d208f42cc695570cc6403554f231a6b9a051623">0d208f42</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T02:40:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pydsdb: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a74946e3007259e42d296fc1209860d7aee90281">a74946e3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T02:40:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Fix a typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/542da7e8002133ab5ef16befa04bc7d9f4e68b9d">542da7e8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T02:40:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">passdb: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/62bc70d18c395101876bcad519982ed6ef473aac">62bc70d1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T02:40:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ntpd: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/186fff5fc3537eedf03a26f1419f2d4844648662">186fff5f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T02:40:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth4: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f4b2cc9659ff9da7f1e6c60678a0d4d4f453611">6f4b2cc9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T02:40:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysecurity: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f1e71a2c1e012596a0a753ea5f11df06244a3cb1">f1e71a2c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T02:40:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind4: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b06f0912fc6873d3f7ca49d57267005c0f5c6c19">b06f0912</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T02:40:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnet4: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a2402f9714449f9dcb86f40dc178a5b5d8384469">a2402f97</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2019-01-08T02:40:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: net: Do not set NET_FLAGS_ANONYMOUS with -k

This affects net rpc getsid and net rpc changetrustpw commands.
This avoids an anonymous IPC connection being made when -k is used,
this only affects net rpc getsid and net rpc changetrustpw commands.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13726

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99c030bce6e246dfa1821a79abe751013b4bd2ef">99c030bc</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-01-08T02:40:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: fix waf errors with sendfail detection on Solaris

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f23287bcb69d7c1318aad2472487066e6e6751f4">f23287bc</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-01-08T06:03:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: fix tri-state of --with-sendfile-support being auto the default

--with-sendfile-support should be used automatically if it's found.

Configure now also fails reliably for all platforms when sendfile was
explicitly requested but failed to be detected.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9707

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jan  8 07:03:49 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e2e6352054a9b4f2c211e9fa3ca3563421e792b">0e2e6352</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T08:32:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Test sids-to-xids with one failing sid

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Volker Lendecke <vl@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f2ccb59734440e5844d6ef703a41e032f7d1663">6f2ccb59</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T08:32:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">idmap_tdb: If one SID fails to map, try the rest

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ee4a33a4fff1ba86f353d72970fe990774dee893">ee4a33a4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-08T12:15:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">idmap: In _wbint_Sids2UnixIDs, pass back what we have

SOME_UNMAPPED does not mean that nothing worthwhile is in here. We
need to pass what we have.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Jan  8 13:15:35 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c57f3794e240704621c67418e018fee2775d1844">c57f3794</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/blackbox: check_exit_code() explains by default

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8760168aa842c1e883e2059036c7e6621c77d887">8760168a</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/traffic: remove duplicate test file

The other one is python/samba/tests/blackbox/testdata/traffic-sample-very-short.model

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c463334997d184f6186d26258bdde84d216e136">4c463334</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic replay: allow --random-seed=0

Zero is a valid seed.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/79e8459817246a80918dca73b109549475e128fc">79e84598</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: drop summary replay

The traffic_replay script has been able to replay a replay log as well
as a model, which was not used in practice and complicated the script.

If we want that feature, we can make a new script for it.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f6b91d5b21b660217e792bf75b6fcb435232c383">f6b91d5b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: use default value for --duration

We could not do this when we replayed traffic summaries (as opposed to
models), but now this script does not do that.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3b3b4fa6f960d2bc06d830266671b582ddf186a1">3b3b4fa6</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_learner: return an error code

And use it in tests, rather than expecting exact strings.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b275baebd7e7fa8576cb49737a886f02e3615640">b275baeb</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_learner: use samba.logger, not print(file=sys.stderr)

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d1a1c5d60113727fad1208c91060f4d318dea412">d1a1c5d6</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic learner: avoid truncated output files on error

add_argument(type=argparse.FileType('w'), ...) will open the file
and leave it empty if the script fails.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/709d2c84cb3b3c7a570b0f915b578bb98e48e3f0">709d2c84</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: Packet.from_line classmethod uses cls var

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9da79b54fa4ec31d82b7d1a23568b576140a7e9b">9da79b54</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: fix mk_masked_dir doc and comments

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/158f172845f6b2cbe0b392cc23fde9bdd32960d4">158f1728</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: use namedtuple for ConversationAccounts namespace class

Saving memory, which reduces fork overhead.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b77ee628cc893bea64f72e7035d21904909e8cc1">b77ee628</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: delete empty temp directories

even if someone asked to keep the temporary data, they don't want
to see 5000 empty directries. Non-empty directories will remain.


Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4f7ae5d925650149769aa42fedba56b9c3ee8d3e">4f7ae5d9</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: make random_colour_print more deterministic, silent on demand

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/24d09d1df8474cd3ef011bbc4cd342ac2561198b">24d09d1d</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: give Packet __slots__ for reduced memory

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e866782a15360784f495ac2e1451aa1b98d94f8b">e866782a</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: split is_a_real_packet() function out of class

So we can use it to determine whether a packet should be a Packet before
making the leap.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a352060f9748cd8f26dbd48f57eff9edf62e52b4">a352060f</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: initialise conversation specific lists after the fork

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a430b11ca2e450792ae9617453f4971ce50e36c1">a430b11c</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: rename packet_rate -> replay_speed for accuracy and room

We are soon going to have a self.packet_rate, and replay_speed is more
accurate in this case.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ef747953d4b30bcfa691a52170caae1062b68502">ef747953</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: Conversation gets given id, list of short packets

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/273eb3dffbaff02b9cc4246783153e26d68485c5">273eb3df</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: fix hash non-determinism when loading JSON

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Tim Beale <timbeale@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7edf58dc58630eca4f9b11242035aa5d6d24e285">7edf58dc</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: new version of model with packet_rate, version number

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7b03e81c615a9b3ae24f90019c9b269b498bafc0">7b03e81c</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: generate sparser descriptions of conversations

Rather than building all the packets at this point, we stick to the
barest details of the packets (which is all the model gives us
anyway).

The advantage is that will take a lot less memory, which matters
because this process forks into many clients that were sharing and
mutate the conversation list.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c4d5bb59527366061a795e99667091018bd6cc99">c4d5bb59</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: rework conversation generation to better use memory

Use less memory altogether and don't allocated shared mutable before
the fork.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6268effb110598375f4f04b8b8758143532e35cb">6268effb</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: avoid generating conversations without packets

Some "packets" don't generate any actual traffic. If we have a
conversation consisting only of those, we can avoid forking a client
for it.

This *slightly* increases the load over that which would be generated
otherwise for a given traffic rate, but that's OK.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/35bc6ee0a105845a74d0475ed5d3f5aca81bf7d1">35bc6ee0</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: reinitialise RNG in each child

Otherwise they all replay using the same random sequence.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/22cba7011caa50b32f35d221ea1020e18f506c1d">22cba701</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: evoke OS error codes by name, not number

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b737552ed3a60c66d44e0b6d93da66a52682db39">b737552e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: --stop-on-any-error option to not ignore client trouble

Sometimes you want to know if any client is crashing for any reason.
In those times use --stop-on-any-error for an early exit.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/17579dd81052813cde2ed3aad0738540d417e60b">17579dd8</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: traffic_replay --latency-timeout to control final wait

Conversations that haven't finished within some acceptable margin of
on-time can be said to have failed. This is where you specify that
margin.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65c02fd68c337779b2482f3bfc7138372eac2d70">65c02fd6</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: assign context domain at start

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/41b0cfce2c63ebc8f0c061448f58499b47e14485">41b0cfce</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: simplify tests for badpassword_frequency

x <= 0 will fail one or both of the other test clauses.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/31c0809e4f1760f731006be6aca8c6da34edab24">31c0809e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: avoid bare except: clauses

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d727dcc82a8843d72922ae3f89b6a778dff9d565">d727dcc8</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: generate more statistics in replay

Add more "header" values indicating the progress of the run as a
whole.

The new fields are:

Max sleep miss            - the longest sleep() oversleep. Indicates client load.
Maximum lag               - the longest gap between a planned packet
                            time and its actual time.
Start lag                 - the longest gap between intended and actual
                            conversation start.
Planned conversations     - how many conversations we meant to have.
Planned packets           - how many "packets" we thought we were making. Not
                            all "packets" result in actual operations or packets.
Unfinished conversations  - how many conversations had not finished
                            when they were killed.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/db51004307a19447bb0ca2259cd7a49f4efc1874">db510043</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: remove useless branch in stats report

This completes the work of 68c64c634ad7576b2ab5ef838c203320afd90f44,
but differs from that in that it makes no actual change because isatty
was not being called so was always evaluated as true.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b5d493f92723c1c52616d2497953e4b7da0932ec">b5d493f9</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: Conversation.add_short_packet is discerning about packets

If the packets really wouldn't do anything, we might as well not add them.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9e0effc1757cd1c5f839a90eb04c4a481d518207">9e0effc1</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: improve debug messages in traffic_replay

tracebacks and less nonsense at higher debug levels.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bda7f35a5e1418a3e9d4f582f72d2bbe9cb10f44">bda7f35a</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_model: don't report generation errors as parse errors

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/524777e681b1fecf5686843f10ae01637285a891">524777e6</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: add option to reanimate dying conversations

The traffic model is generated from a window in time, which makes
conversations appear to start and stop unnaturally at the window
boundaries. When the window is short compared to the traffic replay
time and the true expected conversation length, this has a significant
distorting effect, leading to more conversations than would be
expected to generate a given number of packets.

To offset this slightly we add the --conversation-persistence option
which tries to convert apparent death into a longish wait.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/affaeb944fd77ea67d6fb9ece2c53e6433e3b4a7">affaeb94</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: --old-scale to mimic the old traffic_replay

traffic_replay had a broken sense of traffic scale. That is fixed, but
in order to compare old and new tests, it helps to be able to
approximate the old behaviour.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/71cb2605e86d04e489fbb8081daff8f7b8e56ae1">71cb2605</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests: add TestCaseInTempdir.mktemp()

This gives you a name of a temporary file within the test case's tempdir.
Use it like this:

  with self.mktemp() as filename:
     self.check_run("samba-tool foo --output %s" % filename)
     self.assertStringsEqual(open(filename).read(), expected)

and filename will flick out of existence when the with block ends.

This is based on an idea used in the traffic_runner tests, which will
soon be adapted to use this method.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/daf039afcb1ba21ce49eaaff9589c5e7c667279d">daf039af</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic tests: use TestCaseInTempdir.mktemp()

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c672a922618507d41e2630c3b3c1407b274b153d">c672a922</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic: assert json equality in learner test

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3c10cecac1005d1340f1a389284c30b88cd73910">3c10ceca</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-08T22:55:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: use packets per second as primary scale

The old -S/--scale-traffic is relative to the original model, which made
its relationship to true traffic volumes quite opaque

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b2a9d4c1f69ef5453cec5771c2a68d50ab83434f">b2a9d4c1</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-01-09T02:53:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">xml_docs: update traffic script documentation

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Tim Beale <timbeale@samba.org>

Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Wed Jan  9 03:53:58 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/84069c8a5476a47d45ab946d82abb0d6c04635c3">84069c8a</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2019-01-09T09:15:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd/user: python[3]-gpgme unsupported and replaced by python[3]-gpg

python[3]-gpgme is deprecated since ubuntu 1804 and debian 9.
use python[3]-gpg instead, and adapt the API.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13728

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a9def5c6971fa1dea3aaa2da0e5dfd9246dd0c87">a9def5c6</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-09T13:30:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: Revert SMB Py bindings name back to libsmb_samba_internal

In order to make it clear that the APIs in these Python bindings are
unstable and should not be used by external consumers, this patch
changes the name of the Python bindings back to libsmb_samba_internal.

To make the Python code that uses these bindings (i.e. samba-tool, etc)
look a little cleaner, we can just change the module name as we import
it, e.g.

  from samba.samba3 import libsmb_samba_internal as libsmb

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Jan  9 14:30:31 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78f51a1d3c53248159c1e7643364b62e52457bb9">78f51a1d</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2019-01-09T17:40:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: Check disable_netbios in socket connect

If the disable_netbios option is set then return NT_STATUS_NOT_SUPPORTED
for a port 139 connection in the low level socket connection code.

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Noel Power <nopower@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/499f051c9d527a14f9712365f8403a1ee0662c5b">499f051c</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2019-01-09T17:40:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: Print debug message about Netbios

With a preceding patch, cli_connect_nb() will return
NT_STATUS_NOT_SUPPORTED when 'disable netbios' is set in smb.conf.

Print an informative error message to indicate Netbios is disabled
if this occurs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13727

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Noel Power <nopower@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ecbb2f78cec6d9e6f5180c8ba274a1da2152f098">ecbb2f78</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2019-01-09T17:40:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbpasswd: Print debug message about Netbios

With a preceding patch, cli_connect_nb() will return
NT_STATUS_NOT_SUPPORTED when 'disable netbios' is set in smb.conf.

Print an informative error message to indicate Netbios is disabled
if this occurs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13727

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Noel Power <nopower@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/08867de2efde05e4730b41a335d13f775e44e397">08867de2</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2019-01-09T21:38:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils:net: Print debug message about Netbios

With a preceding patch, cli_connect_nb() will return
NT_STATUS_NOT_SUPPORTED when 'disable netbios' is set in smb.conf.

Print an informative error message to indicate Netbios is disabled
if this occurs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13727

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Noel Power <nopower@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Wed Jan  9 22:38:21 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf229de7926f12e329cdb3201f68f20ae776fe32">bf229de7</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-09T21:39:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: Add error log if insufficient SMB2 credits

Although it's unusual to hit this case, I was seeing it happen while
working on the SMB python bindings. Even with debug level 10, there was
nothing coming out to help pin down the source of the
NT_STATUS_INTERNAL_ERROR.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13736

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fd355dff906f5f4832901bce76544f1a4e50c33d">fd355dff</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-10T01:40:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: cli_smb2_list() can sometimes fail initially on a connection

cli_smb2_list() appears to be a slightly unique SMB operation in that it
specifies the max transaction size for the response buffer size. The
Python bindings highlighted a problem where if cli_smb2_list() were one
of the first operations performed on the SMBv2 connection, it would fail
due to insufficient credits. Because the response buffer size is
(potentially) so much larger, it requires more credits (128) compared
with other SMB operations.

When talking to a samba DC, the connection credits seem to start off at
1, then increase by 32 for every SMB reply we receive back from the
server. After cli_full_connection(), the connection has 65 credits. The
cli_smb2_create_fnum() in cli_smb2_list() adds another 32 credits, but
this is still less than the 128 that smb2cli_query_directory() requires.

This problem doesn't happen for smbclient because the cli_cm_open() API
it uses ends up sending more messages, and so the connection has more
credits.

This patch changes cli_smb2_list(), so it requests a smaller response
buffer size if it doesn't have enough credits available for the max
transaction size. smb2cli_query_directory() is already in a loop, so it
can span multiple SMB messages if for some reason the transaction size
isn't big enough for the listings.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13736

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Jan 10 02:40:16 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f1ff40752486a5207e3dfb322282243343c25ab7">f1ff4075</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-10T01:41:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: Do NULL checks in dns_sign_tsig

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78214d3ccb3ff3391b472316a46bab69e7484aa6">78214d3c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-10T01:41:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Print strerror in addition to errno

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6e0acc7c3989dfd3842bc1509af7c1b854e71340">6e0acc7c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-10T01:41:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Remove duplicate dependency definition

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e29cb5095b519cd12ecc1029b22a120f14d93db5">e29cb509</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-01-10T01:41:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix typos and ban the rams from samba

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/08fd05615346637e0600d2c7475e86dee95c721b">08fd0561</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-01-10T05:14:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix typo and remove the sun and the clouds

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jan 10 06:14:27 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a5b65c88d3b7bf713bd4837e77b0cecc9c2fe11">7a5b65c8</a></strong>
<div>
<span>by Ladislav Michl via samba-technical</span>
<i>at 2019-01-10T05:15:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: replace: snprintf: Whitespace clean up

Remove spaces before tab, spaces at the end of line and white
chars on blank line.

Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d7d3ee18a5979168b6cab42d692eb39fa5d44154">d7d3ee18</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-01-10T08:40:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">statvfs: fix bsize and frsize mixup

the block size (the real one) is the "fundamental file system block size" and
that is the frsize struct member in the statvfs struct. The bsize struct member
of the statvfs struct is *different* from the same named one of the statfs
struct.

See also http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_statvfs.h.html

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11810

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Jan 10 09:40:06 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/36ff1a5126605e14c3a77337b654c95c668c573a">36ff1a51</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-10T15:21:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Fix broken samba-tool gpo commands

samba-tool gpo create|fetch|backup commands throw exceptions due to a
missing Python import:

ERROR(<class 'NameError'>): uncaught exception - name 'tempfile' is not
defined
  File "bin/python/samba/netcmd/__init__.py", line 184, in _run
    return self.run(*args, **kwargs)
  File "bin/python/samba/netcmd/gpo.py", line 980, in run
    tmpdir, gpodir = self.construct_tmpdir(tmpdir, gpo)
  File "bin/python/samba/netcmd/gpo.py", line 386, in construct_tmpdir
    tmpdir = tempfile.mkdtemp()

Introduced by commit e3320b6d3df7a0c7b refactor.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>

Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Thu Jan 10 16:21:23 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c53e8de43ce1c86111993f791e5440a656dc75a8">c53e8de4</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-01-10T21:46:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: check for utmpx struct member ut_host

BUG: https://bugzilla.samba.org/show_bug.cgi?id=2489

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7643ee2ea857cfbf727f9bf03f9e3e8cddf84a21">7643ee2e</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-01-10T21:46:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd: fix utmp hostname logging on Solaris

BUG: https://bugzilla.samba.org/show_bug.cgi?id=2489

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/121db8c08f45ca15310d9d62b868b4e38353bcc6">121db8c0</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-01-10T21:46:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf:lib/replace: fix a build error with non-gcc compilers

3a175830e579ab10231439657b23733338cd5634 added that variable which should have
been an empty initialization here. -Wno-format-zero-length (which might be
unsupported by the compiler) should not be set if we really only want to
initialize the cflags.

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/93c54a4b3c4b08ad8a80235ffcffb9bc89fd9ecf">93c54a4b</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-01-11T01:53:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">statvfs: rename linux_statvfs to posix_statvfs

the statvfs call is posix standard and not Linux specific

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Björn Jacke <bjacke@samba.org>
Autobuild-Date(master): Fri Jan 11 02:53:57 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ef379880037c10589ceeab7f985e3245817908a4">ef379880</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2019-01-11T01:55:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: changing onelevel search for wildcard to subtree

SCOPE_ONELEVEL is used on wildcard dns searches, but onelevel searches
currently have a performance problem related to GUID indexing, so this
patch changes the search scope to SCOPE_SUBTREE.
In this case, as the onelevel and subtree sets of records are roughly
the same, and the query is matching against the DN itself, we don't
believe there's any benefit in using SCOPE_ONELEVEL over SCOPE_SUBTREE.

The onelevel performance problem will be fixed separately later, but in
the meantime this solves the DNS performance problem.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13738

Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8af4ec752a55b376c81a4946bb44081a933bee91">8af4ec75</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-11T05:01:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Improve an error message

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Fri Jan 11 06:01:01 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ad04a6ce49fc3811a62a3c736305cc06fb2611b9">ad04a6ce</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: add root_unix_token()

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/92c2ed4db29c8fa4e5989b5f6d611752bdaa523d">92c2ed4d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-11T22:11:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: add per_thread_cwd_{check,supported,disable,activate}() helper functions

Only Linux it's possible to have a per thread current working directory
using unshare(CLONE_FS).

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/16166542753264ae21115790744af535e6f2c859">16166542</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-11T22:11:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: prepare the usage of per_thread_cwd_*() functions

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a62bc3f221bd7d9db6cdbeb89f2c03c6e81eb98d">a62bc3f2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-11T22:11:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:torture: call per_thread_cwd_check() in vfstest.c main()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f7ce0ec2f3e3cfb46314e5ad3ea6b5c49085f1d">7f7ce0ec</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: let SMB_VFS_GETXATTRAT_SEND() do explicit impersonation

SMB_VFS_GETXATTRAT_SEND() gets passed a raw event context and the
default implementation uses that as well a raw threadpool. Impersonation
is done explicitly instead of by the tevent and pthreadpool wrappers.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/56dee840e48c327b0d2136f1d7dd36c63f439f7e">56dee840</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: pass (raw) ev to SMB_VFS_GET_DOS_ATTRIBUTES_SEND() instead of smb_vfs_ev_glue

This also removes smb_vfs_ev_glue_[push|pop]_use() as the only caller
got removed.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f3d9ba49b015e9958c5995e18300b396cadaf81">9f3d9ba4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: pass (raw) ev to dos_mode_at_send() instead of smb_vfs_ev_glue

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/edb75eeb56d97c9b8b47df731626984ae7553411">edb75eeb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: pass (raw) ev to fetch_dos_mode_send instead of smb_vfs_ev_glue

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/57c7aaa36d2d146065cee78306cd38c0df34cd93">57c7aaa3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "pthreadpool: reset monitor_fd after calling tevent_fd_set_auto_close()"

This reverts commit f68b5ee75f002ed542a8423070fb01e3b0e83f65.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a75f5de15dba1c9f41a2d86c4fa6573764d4cb8d">a75f5de1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "pthreadpool: ignore the return value of poll(NULL, 0UL, 1)"

This reverts commit 6da0d68f49bbd82f5a08427779c9f5ebd6f755aa.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/96332ed100013cb89e92ae3f01a2f46136af3bd2">96332ed1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "pthreadpool: we need to use pthreadpool_tevent_per_thread_cwd() on the callers pool"

This reverts commit ff863f2d98ac5e12073af824b794404c3d7198c5.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/56f7694481765d9f99311c381efe5261d7158d2d">56f76944</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "vfs_aio_pthread: use event context and threadpool from user_vfs_evg"

This reverts commit cd37badc02b3e56f974168b28447444cd54ee541.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/29dd6f3e59055a17fa3d6a63619773f940e63374">29dd6f3e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "s3: vfs: add user_vfs_evg to connection_struct"

This reverts commit 2dd95c1c38b9e1ce32d3d1081b6ec177910087a4.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cedbfbd9b86c9c4f915b19b341cada4c93db7cff">cedbfbd9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "s3: vfs: add smb_vfs_ev_glue"

This reverts commit 1251a536df4b1df58d9ddacab03d3ebe6f4e5b60.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8074922c267677434e6174a2e74b2b7959762014">8074922c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: introduce sconn->sync_thread_pool"

This reverts commit 0c97226356f2ba5f01a58d361371055caf11e2a7.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/29fc7c7db788b1bb200e3a4019d42c045ad0d582">29fc7c7d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: rename sconn->raw_thread_pool to sconn->pool

This is basically a revert of commit
2be7518ae5a3c046f5fca04ecc83f9f7044eac74.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d032210d9725a9fa267c34093f95def074dc22f3">d032210d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "pthreadpool: test cancelling and freeing jobs of a wrapped pthreadpool_tevent"

This reverts commit fb6b6cf3e43165ced4b1039f2683d19f277c0792.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b7d2257996c805e63b3d612141c1799f8eb2faa">9b7d2257</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "pthreadpool: implement pthreadpool_tevent_wrapper_create() infrastructure"

This reverts commit f9745d8b5234091c38e93ed57a255120b61f3ad7.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/67015e13ca24a23d66ef4e465672288ba59fb889">67015e13</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "pthreadpool: add pthreadpool_restart_check[_monitor_{fd,drain}]()"

This reverts commit 3c4cdb290723432b00ff9ff88b892cb4e66e76cd.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e94cd84bbf87ee42495286d6ab9712ba35eaf23d">e94cd84b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "pthreadpool: call unshare(CLONE_FS) if available"

This reverts commit 65e4742d168454df6507d9e74993749063435dd6.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f4d6c48c65bee34a6b4a433914008fe0a08e414d">f4d6c48c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "pthreadpool: add tests for pthreadpool_tevent_[current_job_]per_thread_cwd()"

This reverts commit fbafdc99ef2cef11a1a28e795ffe965cb53ef7fa.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/622ba5191d97409bd50f53169ebdadb2a4c2a84f">622ba519</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "pthreadpool: add pthreadpool_tevent_[current_job_]per_thread_cwd()"

This reverts commit 12a45ee1a66379ba7562729b835ce0e2e4bfb3b3.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7fd9bc3b6e51b818a0c2e39631f6667a993081ff">7fd9bc3b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "pthreadpool: test cancelling and freeing pending pthreadpool_tevent jobs/pools"

This reverts commit 40d15260d24d0071732f47873f395fce29b8a6f4.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/42e2ab7e9973e271cd7df4a1a22feaac1b8c0fd7">42e2ab7e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "pthreadpool: add a comment about a further optimization in pthreadpool_tevent_job_destructor()"

This reverts commit f23cac39b36b026650e0922c78fe0fd3fe567e35.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7882941b7336c97cc68c915e07c535d2b69f181c">7882941b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "pthreadpool: maintain a list of job_states on each pthreadpool_tevent_glue"

This reverts commit aa9b64eccfd037941512bad108c4e3946714a502.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d818e51174e8d5684719b7e09dcd2d83c315944d">d818e511</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "pthreadpool: add helgrind magic to PTHREAD_TEVENT_JOB_THREAD_FENCE_*()"

This reverts commit 9b73fda926eb8493e80012794483039be66d4e6c.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/991ca9b56460912ff1024f9ff443200195e507fa">991ca9b5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "pthreadpool: add some lockless coordination between the main and job threads"

This reverts commit 9656b8d8ee11ee351870286f16ea8fbe49112292.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9e4bc1f4a9b0f9400e198680dfddfa8cd112ce2b">9e4bc1f4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "pthreadpool: maintain a global list of orphaned pthreadpool_tevent_jobs"

This reverts commit 25756425aaf5465e56ea809cd415b6a387848919.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/44900b043388461cc1777a57452848fd67d2892f">44900b04</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "pthreadpool: add pthreadpool_tevent_job_cancel()"

This reverts commit 791c05144ee9296024cc0fdebe4afeaaf67e26bc.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8e03cbe868de35055fa228af906330a3e0ac0c5e">8e03cbe8</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "pthreadpool: split out pthreadpool_tevent_job from pthreadpool_tevent_job_state"

This reverts commit 245d684d28dab630f3d47ff61006a1fe3e5eeefa.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/718cc7a0d70e57b32db986e2cb3ae3007c4294c5">718cc7a0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: remove unused change_to_root_user() from brl_timeout_fn()"

This reverts commit c310647e560abc2343ef2ff0ab15daab0fba2650.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3747dcb41f1973f291b812343b3130619331210c">3747dcb4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: remove unused change_to_root_user() from smbd_sig_hup_handler()"

This reverts commit d0b1f96f086bdd613644f64b3f75ee8c4388f674.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ac17919ae306514aeb668cf422ce46daa3897ae3">ac17919a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: avoid explicit change_to_user() in defer_rename_done() already done by impersonation"

This reverts commit e37e41b3cac52e3623f0c79f83733a51edb35c10.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/864e985168d0622c51b351974180c5b1dfd5dc60">864e9851</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: implement smbd_impersonate_{conn_vuid,conn_sess,root,guest}_create() wrappers"

This reverts commit 1b804f7ae23f54a6c1004e5ff17b9df1376b5adb.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/97a7f8864f34d3dcf3c31fb16b7f39f047580bd8">97a7f886</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: make use of smbd_impersonate_{conn_vuid,conn_sess,root,guest}_create() wrappers"

This reverts commit 0dcaa0707bad67f7bfaa10ccaf167bfefbe87a0c.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e717c9035ef643b8de97c0ee473670d693690900">e717c903</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: add simple noop smbd_impersonate_{conn_vuid,conn_sess,root,guest}_create() wrappers"

This reverts commit 5285966e67cbee8519015df12a15e938e85e6ee7.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3aaf7c1470644ad91b456125ee046333f1f051f1">3aaf7c14</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: add smbd_impersonate_debug_create() helper"

This reverts commit 23319ef5a2eff4811b685d4ab54179efc49bac99.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78fa44083218adef59a27c35794be51b8bfd1caa">78fa4408</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: add [un]become_guest() helper functions"

This reverts commit 7b5a47b84696e8e5c26207bd398742b883e598c2.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0bd10a48e4c08d1eb3a20e79d952b3c0f12be46a">0bd10a48</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "s4:messaging: make sure only imessaging_client_init() can be used with a wrapper tevent_context wrapper"

This reverts commit e186d6a06b1b300256a2cb4138f0532d518d0597.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e2a5272ac6831b407a0c51bb8615252ec68be6a8">e2a5272a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "s3:messages: allow messaging_filtered_read_send() to use wrapper tevent_context"

This reverts commit 2b05f1098187e00166649c8ea7c63e6901b9d242.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/26107832cd9d200fb171ef1f991d7ef5478cac18">26107832</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "s3:messages: allow messaging_dgm_ref() to use wrapper tevent_context"

This reverts commit 9dc332060cf5f249ea887dbc60ec7a39b6f91120.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1c3676f3aa9c1564eb140a24ced5ee72b859b87f">1c3676f3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "s3:messages: allow messaging_{dgm,ctdb}_register_tevent_context() to use wrapper tevent_context"

This reverts commit 660cf86639753edaa7a7a21a5b5ae207ae7d4260.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a62a98f5c7107f2f83c0bfc2892243d83e2c88a">2a62a98f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "s3:messages: protect against usage of wrapper tevent_context objects for messaging"

This reverts commit 7f2afc20e1b6397c364a98d1be006377c95e4665.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/122e141b465d90b76334eaf75331949e34fd91d3">122e141b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: remove unused smbd_server_connection->ev_ctx"

This reverts commit 721fbbfa7001b2788602106101f0407483894322.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/88016bac86a727de16af72766e859c5821a0b20c">88016bac</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"

This reverts commit 894e5001c747ce765dad5517778dda55d7d1f4d9.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de10c61105391940baecb9b4c6980e5e630550c1">de10c611</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: add an effective connection_struct->user_ev_ctx that holds the event context used for the current user"

This reverts commit f2df8be16be9dccd3d10ec060f1efbe5007a28c6.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9d47128f7c9346cc673e341967a1cd7a53ecabbc">9d47128f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: use sconn->root_ev_ctx for smbd_sig_{term,hup}_handler()"

This reverts commit c835ffa72ddfd2431d22909148913b50f0d829d1.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/50995917905988843074b44d82e59a1f927ccb58">50995917</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: use sconn->root_ev_ctx for brl_timeout_fn()"

This reverts commit 182991c26c8149c79b13a277b9822efc49fd1df0.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/296a15a00e4dc7a530cc8b895d767867ab8d4c12">296a15a0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: add smbd_server_connection->{root,guest}_ev_ctx pointer"

This reverts commit 146938217ed1ab9a7a9f38c055fec5513cbd5c4d.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/523a64e25d88b9924f34ecb24925b400bac6d8d7">523a64e2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: use raw_ev_ctx to clear the MSG_SMB_CONF_UPDATED registration"

This reverts commit f5f9b719741465c7be3de20a6a69ec106ecc4568.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ac597b0706926850f8d599c54077946b3a726a9a">ac597b07</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: explain that/why we use the raw tevent_context for linux_oplock_signal_handler()"

This reverts commit dc517b20f60a156d73fdd551557eb1d4366dfdeb.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5afd19198b8605ad921777aed0c2f9c89a1305db">5afd1919</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: explain that/why we use the raw tevent_context for do_break_to_none()"

This reverts commit 1d5210b615035e46b90758ac7aa4ceec9174bee5.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4036fc894f7ebbad37607b8661aa064009f8e0d3">4036fc89</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: explain that/why we use the raw tevent_context for oplock_timeout_handler()"

This reverts commit e73eaa3c8004d3d8aff316cdb26b0bef85eceaca.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bcb4723aacd165a3eb5d5bf3e9b68f444813f7f7">bcb4723a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: explain that/why we use the raw tevent_context for lease_timeout_handler()"

This reverts commit 52f098d38da72d6eff3c4cac61487da897a8651c.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/46d3a1541a62bf0b2ae4d4ebc5f615b679dd7335">46d3a154</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: explain that/why we use the raw tevent_context for update_write_time_handler()"

This reverts commit 7cfafaf190643eb28fc95d21a02a4e5e529e16d1.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6ec96ac70989fcd65abbde04b233d2282f6bf398">6ec96ac7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "vfs_glusterfs: explain that/why we use the raw tevent_context in init_gluster_aio()"

This reverts commit b0af5715b0a7592a9728e0b76f653b9ab6228708.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d8f495b01cb4d6797f9165b1e45dcaa31da7e44">5d8f495b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: use passed in ev in smbd_smb2_query_directory_send()

The ev argument is also a raw ev.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/57e2fb018f2040d1e2d487a4590f103022496b44">57e2fb01</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: don't use async dosmode if per-thread cwd is not available

The additional overhead for the async processing should be avoided when
we know the lower level has to fallback to sync processing anyway.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bc539d8104fcf7954331df1d4385ad84343c919a">bc539d81</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_default: add sync fallback to pread_send/recv

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4673a8b9e36647500428a0283edb5ed645ff0da4">4673a8b9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_default: add sync fallback to pwrite_send/recv

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2f406fee523692e4dc4b11b13637dcbabaabe8c7">2f406fee</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_default: add sync fallback to fsync_send/recv

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e2f46c9333e2919fbdfddc1f6049478fe07765aa">e2f46c93</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_aio_pthread: use struct initializer for aio_open_private_data

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a307e798ddfc4f8fa32e22827c39f5e1f0e87d47">a307e798</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_aio_pthread: store conn instead of sconn in aio_open_private_data

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/47c443b479566bafc01ec6e3f94f2481d9659806">47c443b4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_aio_pthread: add sync fallback

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dcd0edfdc90a009a87fc8b0bafbd09e2711ebccb">dcd0edfd</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-11T22:11:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "smbd: add smbd_server_connection->raw_ev_ctx pointer"

This reverts commit 6114f9545fa856717220658e87f2a60f6767b7f4.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/168079b2c3693c08ac994e4ee61be101986a4bae">168079b2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:12:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: deprecate tevent_wrapper api again

Samba doesn't use it anymore and we don't want to
invite new users of that api without further discussion.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sat Jan 12 03:12:09 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a2f718fb753b7ee38e30acebb02ef931a89f279f">a2f718fb</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-01-12T02:13:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: remove unused function nttime_from_string()

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7817e42d94140af8151cafa608398e4974489730">7817e42d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: add dcerpc_get_auth_length() helper function

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c919514d2d9b358a8bb1ab152d34c5345677ba78">c919514d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: add dcerpc_get_auth_{type,level,context_id}() helper functions

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a94c4e55b7347ce5a524eeed78db632c5a251f4d">a94c4e55</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: add SMB_ASSERT(blob->length >= DCERPC_NCACN_PAYLOAD_OFFSET) protection

A lot of functions rely on having the 16 bytes dcerpc header to operate
on. This makes it more obvious and makes sure they can't be misused in
future.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/36d5268a94315e3f6d32a11e225ab8dbd055157a">36d5268a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: make test_GetUserName() more strict

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0b972ec69431a9801d8ab885ce102c48f2d1a0f5">0b972ec6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/samr: Fix the O3 developer build

Different gcc versions complain at different places.

I recently got these:

../source4/rpc_server/samr/dcesrv_samr.c: In function
‘dcesrv_samr_QueryDisplayInfo2’:
../source4/rpc_server/samr/dcesrv_samr.c:4117:2: error: ‘q.out.result.v’
may be used uninitialized in this function [-Werror=maybe-uninitialized]
  return result;
  ^
../source4/rpc_server/samr/dcesrv_samr.c: In function
‘dcesrv_samr_QueryDisplayInfo3’:
../source4/rpc_server/samr/dcesrv_samr.c:4151:2: error: ‘q.out.result.v’
may be used uninitialized in this function [-Werror=maybe-uninitialized]
  return result;
  ^
cc1: all warnings being treated as errors

../source4/rpc_server/samr/dcesrv_samr.c: In function
‘dcesrv_samr_QueryDisplayInfo3’:
../source4/rpc_server/samr/dcesrv_samr.c:4151:2: error: ‘q.out.result.v’
may be used uninitialized in this function [-Werror=maybe-uninitialized]
  return result;
  ^
In file included from ../source4/rpc_server/samr/dcesrv_samr.c:4447:0:
default/librpc/gen_ndr/ndr_samr_s.c: In function ‘samr__op_dispatch’:
default/librpc/gen_ndr/ndr_samr_s.c:597:18: error: ‘q.out.result.v’ may
be used uninitialized in this function [-Werror=maybe-uninitialized]
   r2->out.result = dcesrv_samr_QueryDisplayInfo2(dce_call, mem_ctx,
r2);
                  ^
cc1: all warnings being treated as errors

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f17cd478024939efd64e49bc56e5dc7ff3ce3c6c">f17cd478</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: remove dcerpc_remote dependency from dcerpc_server

dcerpc_remote is just an implementation and does not belong to the
core dcerpc server.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6739d1b8e4e5fd90febb9c9535416cffedd9a86a">6739d1b8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: let test_rpc_dns_server_dnsutils depend on dcerpc_server

The core dcerpc server is required here, which also implies
DCERPC_COMMON.

This is required to move common/reply.c dcesrv_auth.c from
DCERPC_COMMON to dcerpc_server in the next commit.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a71558cf8f7e24d35ba5459fecc82d6ecd0839c6">a71558cf</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: move dcesrv_auth.c and common/reply.c to dcerpc_server

They belong to the core dcerpc server.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5f33379ee87bcc8fd9a633b5e3cc90d9b071e9b8">5f33379e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: remove unused dcesrv_connection->transport_session_key

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/961ebf229af5345d86f60cb82e773271040cdcad">961ebf22</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: add dcesrv_call_session_info()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/707105d0dee2cc4d86fc583065b03dec6f75b371">707105d0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/backupkey: make use dcesrv_call_session_info()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c989e35c630536231fb4f6c95cc61b4d6b38dd9f">c989e35c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/dnsserver: make use dcesrv_call_session_info()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e1caa51146935884080726650d0647b8c1f3dba7">e1caa511</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/drsuapi: make use dcesrv_call_session_info()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/73bda4b6d6b1f96fd7d381a36849e934461152e6">73bda4b6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: make use dcesrv_call_session_info()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa6d9e49bbf6056f20d44247364eaf586765ad09">aa6d9e49</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/netlogon: make use dcesrv_call_session_info()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/89c8870c6a3bbffdba1c4e9cbbc11ec127455623">89c8870c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/samr: make use dcesrv_call_session_info()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba127cab2cfb9770a5ab06ee8f3a42d4ac660ac2">ba127cab</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/srvsvc: make use dcesrv_call_session_info()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/014e55b8e9d339b364337b1638359d126267d523">014e55b8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/winreq: make use dcesrv_call_session_info()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/905417c2a77e85287e435ed9c11480c39bc7f230">905417c2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/common: make use dcesrv_call_session_info()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/13c534bd9382131ac97cd687caa0cc6990367e65">13c534bd</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: add dcesrv_{auth,transport}_session_key() functions

They take struct dcesrv_call_state as argument and will replace
dcesrv_{inherited,fetch}_session_key() which take dcesrv_connection
as argument.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8a171c692f3dd8e66b450473aa4dac5a33987566">8a171c69</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: make use of dcesrv_transport_session_key()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dbb381ad37a3792568fdfd142d790caf512bc2d2">dbb381ad</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/samr: make use of dcesrv_transport_session_key()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2f5c344bfc75b945e469f3d89b31383f61ab32fa">2f5c344b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/drsuapi: make use of dcesrv_auth_session_key()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/851c06f40b1494440d8b404f5af38f9e080fead1">851c06f4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: allow a NULL function pointer in dcesrv_fetch_session_key()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6df71436068eb548ac211e8a1f5104a52bc7c901">6df71436</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: split out a dcesrv_session_info_session_key() helper function

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d2aecd8755413fb32c3e05a4b644a7015a6dc47b">d2aecd87</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: only AUTH_TYPE_NONE should get a transport session key

There's only a logic change for NCALRPC and NCACN_UNIX_STREAM.
dcesrv_generic_session_key() already returned
NT_STATUS_NO_USER_SESSION_KEY for all other cases.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/00e92045674c664f2deed14a23829acefd72ba42">00e92045</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: make dcesrv_endpoint_connect() static

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e0a963a7ce7f68a0589f366b9623bc2604a3b08c">e0a963a7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: only setup the auth_state.session_key fn in dcesrv_endpoint_connect()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/57edc9a0d5fe092252b102c6bb34d94e5d5c13c1">57edc9a0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: only pass dcesrv_auth to auth_state.session_key_fn()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b8eae043dde33b080257766807c6d66ae29ff862">b8eae043</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: remove unused dcesrv_inherited_session_key()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ace0672968707db0349f77c89a2a48c3219ef73b">ace06729</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: merge dcesrv_fetch_session_key() into dcesrv_transport_session_key()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d1f5e5d5b48f9cdcddedce8e22f930264397e602">d1f5e5d5</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: add some const to dcesrv_handle_fetch()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/47a941cafbe9e8a6cbf3eef375297859db7ccf53">47a941ca</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: add dcesrv_handle_{create,lookup}() functions

They take struct dcesrv_call_state as argument and will replace
dcesrv_handle_{new,fetch}() which take dcesrv_connection_context
as argument.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ec3e404a806fd3aa5da19dc8696878281e6e08fa">ec3e404a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/drsuapi: make use of dcesrv_handle_create()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/89a42fc011c28a20054df7dd8655bc93aef1d3d8">89a42fc0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/eventlog: make use of dcesrv_handle_create()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/884a18fa397821fb1e9570d608ca707dcb7170c8">884a18fa</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: make use of dcesrv_handle_create()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70a5d21d744960aa60612b7f0af39c57c28d25f7">70a5d21d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/samr: make use of dcesrv_handle_create()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/86661abacf8ba0dea7a7b050facb2dfe8ea7bf79">86661aba</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/winreg: make use of dcesrv_handle_create()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/237ae037f4e5683213f3ef0d02ac3d411ca1889f">237ae037</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: only use the new dcesrv_handle_{create,lookup}() api

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8639d73025e5f567d8366546b8c0c944ffe2407d">8639d730</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: remove the old dcesrv_handle_{new,fetch}() api

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f6a296863f34e0fd6c5273bdd25e1faad8e3af52">f6a29686</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/handles: make use dcesrv_call_session_info()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/62d45e16e0c993e830048478b0f370e1be4d3b45">62d45e16</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: add dcesrv_call_auth_info()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/10816794c0210c622d6f2f75ac518a651ef7ce7c">10816794</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/samr: make use of dcesrv_call_auth_info()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fc596ef1c733c75e56a4790b70641f7ca8fb9828">fc596ef1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: make use of dcesrv_call_auth_info()

It's enough to check the auth_type for DCERPC_AUTH_TYPE_SCHANNEL,
there's no need to also check the auth_level for integrity or privacy.

The gensec layer already required at least DCERPC_AUTH_LEVEL_INTEGRITY,
see schannel_update_internal().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cd380d8adad8cea7df8ee2cfb33dab86ba3900b6">cd380d8a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/netlogon: simplify logic of dcesrv_netr_creds_server_step_check()

It's enough to check the auth_type for DCERPC_AUTH_TYPE_SCHANNEL,
there's no need to also check the auth_level for integrity or privacy.

The gensec layer already required at least DCERPC_AUTH_LEVEL_INTEGRITY,
see schannel_update_internal().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b49e325f11847ba3a3efa7ba79c7a4992b81714">6b49e325</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/netlogon: make use of dcesrv_call_auth_info()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c621a87322c60811483c735a23922f85064a684a">c621a873</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/remote: make use of dcesrv_call_credentials()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/72643248d9aef3ce793e156ec80021a2163bdce3">72643248</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: use helper variables to access 'struct dcesrv_auth' in dcesrv_auth.c

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b8d384177cad0d962d6ac6c0bb2fd260ea82e898">b8d38417</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: use helper variables to access 'struct dcesrv_auth' in common/reply.c

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/93ae817a02eadc637e13bf371241c0bf91afffc9">93ae817a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: use helper variables to access 'struct dcesrv_auth' in dcerpc_server.c

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a3ea90cc5cc83dd411a819f3448c3bef1ab20fe">9a3ea90c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: introduce dcesrv_call_state->auth_state

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8ec932923b1c1c5dab214b93720d04b83cdc3886">8ec93292</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: make use of dcesrv_call_state->auth_state in dcesrv_auth.c

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/097299ae7a48dd7cd9242c283a14969a53c0a5ce">097299ae</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: make use of dcesrv_call_state->auth_state in common/reply.c

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/58021612583e087ecbc2885bc1b258bced6009b5">58021612</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: make use of dcesrv_call_state->auth_state in dcerpc_server.c

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e2a05c3ad8668ee723c71378ccf83a612f9cb255">e2a05c3a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: allocate struct dcesrv_auth with talloc

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2640f60e885335b47bc7a1d509c8b26ba95a86ed">2640f60e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: split out dcesrv_auth_prepare_gensec()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/76976eab01cd64ccf3ea2a2247a77997db3094ed">76976eab</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: add some protection checks to dcesrv_auth_prepare_gensec()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b46df3a85c39240d33ecb2ea0d54afcaa97c5815">b46df3a8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: split out log_successful_dcesrv_authz_event()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0191516efcbcb0c71b63cd8a9d3be60f8dc564b1">0191516e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: set auth_invalid = true on disconnect

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/13e52cc9292a46ebcabf4e6ff385fd89cadc0fa7">13e52cc9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: replace dce_conn->allow_auth3 with auth->auth_started

auth3 is allowed if auth_started is true and auth_finished is false.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d8293acdb4f738a5fe66c53bfd01715ebf7952ba">d8293acd</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: replace dce_conn->allow_request with auth->auth_finished

They both had the same lifetime and the disconnect case is now
caught by auth->auth_invalid = true.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b02b94d037429e7bdca67377e390fb636c63f64">6b02b94d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: add a min_auth_level to context handles

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/38e0c06abc71620af7c8cfc44af326d10ff9ff14">38e0c06a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: move bind_time_features to dcesrv_assoc_group

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c76a5be87bf8985d54e82a32df3abf855a616134">c76a5be8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: add dcesrv_iface_state_{store,find}_{assoc,conn}() helpers

They can be used instead of
dcesrv_connection_context->private_data and
dcesrv_assoc_group->proxied_id.

This is the first step to hide internal details of
the core dcerpc server from the interface implementations.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5cbcc78a40e46651c6d0a35e02448e172aae7c2c">5cbcc78a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/netlogon: make use of dcesrv_iface_state_{create,find}_conn()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/245a0ef73f87cdfbfe98c05dde1976c67272248c">245a0ef7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/dnsserver: make use of dcesrv_iface_state_{create,find}_conn()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/965abe8e1a55b2631ea3e8bf03134a567f02ac5c">965abe8e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/remote: introduce remote_get_private()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1f348d077b25eb674c099c9b3a7776750b39f4a2">1f348d07</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/remote: remote_op_bind already has the table available

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d9b88ccd8110e5dc6a09e5f29fbffb2c5b41e3c3">d9b88ccd</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/remote: reformat code to get "dcerpc_remote:binding"

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/23d1393a5f27a3329005f3d560339f85ad780e41">23d1393a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/remote: reformat code to get "dcerpc_remote:use_machine_account"

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3a17389e1bef67361dd152793e85e00a6efb9cb5">3a17389e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/remote: add dcerpc_remote:allow_anonymous_fallback option

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/954dd89f511865c14bd5160f8f6c26bc28691d40">954dd89f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: use "dcerpc_remote:allow_anonymous_fallback = yes" for rpc_proxy

This already uses anonymous credentials as the remote connection is done
during the bind before the realm authentication has started.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/199d4ba7ac45d2740987be0b85438d2b4c532035">199d4ba7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/remote: fail the connection if the remote server don't support MPX

If we already negotiated with our client to support concurent multiplexing (MPX),
we need a remote connection that also supports it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a8134191ec000b236948b93d2e2290cc4dc8b110">a8134191</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/remote: defer the connect to the first client request

This means we have a chance to use delegated credentials from the client
if available, as the authentication is already completed.

Before we only ever used the transport inherited credentials
via SMB or anonymous.

Note: most times we still fallback to anonymous...

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9d387919f61b64c24c99d9ea3db2425001377c30">9d387919</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/remote: introduce struct dcesrv_remote_call

This holds the state for async requests.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9616f6b8bc97bd59b2b934d5dc56cd0599b4e781">9616f6b8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/remote: make use dcesrv_iface_state_{store,find}_{assoc,conn}() helpers

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2ed7db445bf2bd1b4ecab437cb1e860d51a58879">2ed7db44</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/winreg: don't cache an ldb connection per presentation context

We should do this per context handle, as these are available on all
connections of the association group.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/792b6b9d6970682154d8c7c7f613fce39e69152d">792b6b9d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: remove unused dcesrv_assoc_group->proxied_id

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/28f4cb442c3c08ea761776012036b30f7b9dbd7d">28f4cb44</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: remove unused dcesrv_connection_context->private_date

dcesrv_iface_state_{create,find}_{assoc,conn}() should be used instead.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70b00c7567aeef4027f3d4d55c74bb37a2e9e673">70b00c75</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: only use context within op_bind() hooks and dcesrv_interface_bind_*() functions

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e9eb8e6a4474018ece6ac3550275cec9839557ab">e9eb8e6a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: only pass context to op_bind() hooks

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6f53c9937233f18c0c18a6680d455157b8025bec">6f53c993</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: SMB_ASSERT(auth->auth_finished); in order to get auth details

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d47f9af7cbb09ed015abcfc6ea7d19ec443bdcf2">d47f9af7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: add pfc_flags_2nd and use_auth3 options to do_generic_bind()

This makes it more flexible and allows to write complex tests in an
easier fashion.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5466ed1232ee5e13335a79bf04e6205f901f6e21">5466ed12</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_protocol: add tests for delayed header signing activation

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fb9f613364d6ec32ae22b12b1d6785f094154de2">fb9f6133</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_protocol: consistently call self.recv_pdu(timeout=0.01) after auth3

When we don't expect a FAULT, we should wait a little bit to check
there's no response to auth3 request. This reduces the raw_procol
test from 45s down to 35s total runtime against Windows.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/975e8e1f25456302bddc7245bb1f0570518b4af1">975e8e1f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: fix DCERPC_PFC_FLAG_SUPPORT_HEADER_SIGN negotiation to match Windows

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa3f1f86c0ce5c46be85168de6c6c188b4193b19">aa3f1f86</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_protocol: enable tests with the DCERPC_PFC_FLAG_SUPPORT_HEADER_SIGN bit

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/276286caa9785c82a597cffe7c7fb7702d0e0505">276286ca</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest:Samba4: allow dcerpc auth level connect:lsarpc = yes in chgdcpass

This is required to explore the details of security context multiplexing
using lsa_GetUserName().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b1c6b954a153232dbee0cb20cb02cab22a0fbb82">b1c6b954</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_protocol: add test_assoc_group_ok2 to check assoc groups over ncacn_np

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c192dc1c9d22e2f7602fd98926026b092eaa6241">c192dc1c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: don't replace '\\pipe\\' with '\\PIPE\\'

This is not what Windows returns (at least for \\pipe\lsass).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a8feb556318049ee0da2db372bbc58cb5bdc63e4">a8feb556</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_protocol: add test_assoc_group_fail3()

This demonstrates that assoc groups are only shared on the
same transport (endpoint).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b3659fb52d8da81cf68f45c163d9d232b1d48425">b3659fb5</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: only share assoc group ids on the same transport

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a650120d2ecd70ae4a1bc0b29f177db9ff526703">a650120d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_protocol: demonstrate that \\pipe\lsarpc returns \\pipe\lsass as secondary_address

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/98d58722933a2929fb8564f9c8526f7ae45f6059">98d58722</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: make it possible to specify ncacn_np_secondary_endpoint

Even a connect to \\pipe\lsarpc should return a secondary_address
of '\\pipe\\lsass'. But that will be implemented in a following commit.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4bb3a66ae13ad90101034451c2200fc669fb3dec">4bb3a66a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server/lsa: specify \\pipe\lsass as ncacn_np_secondary_endpoint

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ae467704f3fe6794f1f4e31b1d5c4fd3f1a14053">ae467704</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:pyrpc: make use of pytalloc_get_type() in py_dcerpc_syntax_init_helper()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8bd0f4405a3545437a9b52adff775696b542e1bf">8bd0f440</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:pyrpc: add py_dcerpc_ndr_pointer_deref/wrap() infrastructure

Some idl files use more than one layer of unique pointers. e.g.

    NTSTATUS lsa_GetUserName(
            [in,unique] [string,charset(UTF16)] uint16 *system_name,
            [in,out,ref] lsa_String **account_name,
            [in,out,unique] lsa_String **authority_name
            );

In order to specify *io.in.authority_name = NULL,
we need to wrap the pointer value (lsa_String or None)
into an base.ndr_pointer() object.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d7930c8ad2ac5b7f5139b471ebc0b96c8d8b773">1d7930c8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl/Python: use py_dcerpc_ndr_pointer_wrap/deref if multiple pointer levels are used

This will help the raw_protocol test to explore lsa_GetUserName.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3f535ed1adfe9c7088852a2c6aa56988440ce8fa">3f535ed1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_testcase: add assertEqualsStrLower()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a0b230631bcb0fd9b0299aa41711af08cc2594c3">a0b23063</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py:dcerpc/raw_protocol: add tests to demonstrate how security context multiplexing works

Important things are this:
- It's not required to use the bind time feature negotiation in order
  to use it, it's only a hint for the client, but nothing is really
  negotiated, unlike the request multiplexing with the
  DCERPC_PFC_FLAG_CONC_MPX.
- There's special handling related to AUTH_LEVEL_CONNECT
  and requests without auth trailer
- An security context is identified by the unique
  tuple of auth_type, auth_level and auth_context_id (all together!),
  not just the auth_context_id.
- There's a limit of 2049 explicit authentication contexts.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7bc6ec81c85eb51f5d6948b9266a7db2918892d4">7bc6ec81</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: implement security context multiplexing

There're some systems like Cisco ISE use security multiplexing
without checking (via bind time feature negotiation)
the server supports it.

Others like VMWare View, fallback to NT4 style netlogon
connections without using netlogon secure channel,
which then triggers an error, with "server schannel = yes",
see https://bugzilla.samba.org/show_bug.cgi?id=13464.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ea0a7041771c43724e469ba95341c3a966f3d910">ea0a7041</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T02:13:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest:Samba4: run the raw_protocol test with a limit of 8 auth contexts

This is much faster than exploring the limit of 2049 during autobuild.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e61f9406de17a037106ce5f81feb85a8b477a986">e61f9406</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-12T05:25:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest:Samba4: run fl2003dc without security context multiplexing

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Jan 12 06:25:37 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5232979de8394944dccae848207aae65c1a65ec1">5232979d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-01-12T23:40:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Fix memory leak with ParseTuple (using 'es' format)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/253af8b85450c2830a442084e98734ca338c1b2f">253af8b8</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-01-12T23:40:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Add new compat PYARG_STR_UNI format

In python2 PYARG_STR_UNI evaluates to et which allows str type
(e.g bytes) pass through unencoded and accepts unicode objects
encoded as utf8
In python3 PYARG_STR_UNI evaluates to es which allows str type
encoded as named/specified encoding

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/efc4570d6ff1f1b0f12869d65ccf4aed92773ee2">efc4570d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-01-12T23:40:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/credentials: use 'et' as format for ParseTuple with python2

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a799377029077a1749cb9cddbb81962c8479b3df">a7993770</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-01-12T23:40:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: use 'et' as format for ParseTuple with python2

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b6c8ef5fb70c65c04c8269ff95e661e219968767">b6c8ef5f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-01-12T23:40:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/libnet: use 'et' as format for ParseTuple with python2

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8758b3b1f98476469501dd45a7c898950294e05">f8758b3b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-01-12T23:40:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/ldb/tests/python: Add test to pass utf8 encoded bytes to ldb.Dn

This test should demonstrate an error with the 'es' format in python
where a 'str' byte-string is passed (containing utf8 encoded bytes)
with some characters that cannot be decoded as ascii. The same
code if run in python3 should generate an error (needs string not
bytes)

Also Add knownfail for ldb.Dn passed utf8 encoded byte string
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/45f5337f9f02faa9bc8f5501601df399c229732e">45f5337f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-01-12T23:40:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Enable ldb.python for PY3

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8900e0b4cb05613df9cbeeb8b8253273b06b3c17">8900e0b4</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-01-13T02:53:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/ldb: Use new PYARG_ES format for parseTuple

While 'es' format works great for unicode (in python2) and
str (in python3) The behaviour with str (in python2) is unexpected.
In python2 the str type is (re-encoded) with the specified encoding.
In python2 the 'et' type would be a better match, that ensures 'str'
type is treated like it was with 's' (no reencoding) and unicode is
encoded with the specified encoding. However in python3 'et' allows
byte (or bytearray) params to be accepted (with no reencoding), we
don't want this. This patch adds a new PYARG_STR_UNI format code which
is a hybrid, in python2 it evaluates to 'et' and in python3 'es' and
so gives the desired behaviour for each python version.

Additionally remove the associated known fail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13616
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Sun Jan 13 03:53:00 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bae415453e13ee1c54d40459c8239b72dea9fa7b">bae41545</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-14T02:30:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Add .get_acl() API to SMB py bindings

There is no obvious async-equivalent of cli_query_security_descriptor(),
so it will throw an error if anyone tries to use it in multi-threaded
mode. Currently only samba-tool and tests use the (s4) .get_acl() API,
both of which will be fine using the synchronous API.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/15013ff9537cc1103afd1afd59c2da722e655b52">15013ff9</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-14T02:30:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Change ntaclsbackup tests over to use s3 Py bindings

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/792b8d3f8338988c2288bc3dc58e72cacbba2154">792b8d3f</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-01-14T05:49:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Change domain backup commands to use s3 SMB Py bindings

This means we can now backup a DC that has SMBv1 disabled.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Tim Beale <timbeale@samba.org>
Autobuild-Date(master): Mon Jan 14 06:49:09 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3672f02e4769da244d5c2ba82b46921a88fa9472">3672f02e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-14T18:13:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: use struct initializer in smb_vfs_call_get_dos_attributes_send

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2720d95d1fd921ae43c881369d10ea6ada499690">2720d95d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-14T18:13:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: perform impersonation in smb_vfs_call_get_dos_attributes_done()

This is needed as the callback might be called in an arbitrary
impersonation state.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/333a180b6a550ae7422c1199a515095c42ff1738">333a180b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-14T18:13:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: use struct initializer in smb_vfs_call_getxattrat_send()

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0b7c6d500991afebf15c5c6d9bb256ff234076de">0b7c6d50</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-14T18:13:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: perform impersonation in smb_vfs_call_getxattrat_done()

This is needed as the callback might be called in an arbitrary
impersonation state.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d21be78ef9248de70f53eee46fc8e02b3a955436">d21be78e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-14T18:13:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_default: use change_to_user_by_fsp() instead of change_to_user()

Cosmetic change.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/75e2e242de83fc880b91dacdc7622e646b05b1a0">75e2e242</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-14T18:13:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: perform impersonation in dos_mode_at_vfs_get_dosmode_done()

This is needed as the callback might be called in an arbitrary
impersonation state.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c6728403b07361a276078a264c576edeebd92abf">c6728403</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-14T18:13:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: perform impersonation in smb2_query_directory_dos_mode_done()

This is needed as the callback might be called in an arbitrary
impersonation state.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6619cec3dec8c8a2116d111aea7e5440875d0fa8">6619cec3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-01-14T21:30:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: perform impersonation in smb2_query_directory_fetch_write_time_done()

This is not strictly required, as we ne never trigger additional VFS
requests via this codepath. But for safety reasons ensure we're running
in the correct impersonation state.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Jan 14 22:30:24 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/12398a2d1ddcd326e02e5d8b0749e0e796145165">12398a2d</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2019-01-15T03:13:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fileid: fix get_connectpath_ino

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13741

Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Jan 15 04:13:15 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a7e28a7eb56dc3279af52a6edd50cc59c771f1f1">a7e28a7e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-15T06:53:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">addns: Centralize siteless lookup fallback

We had the same logic 3 times, coalesce into one

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ff2dbe24b80b24bdb4897d0152e76ed3931048f2">ff2dbe24</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-15T06:53:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns_update: samba_dnsupdate's exit code is not an errno

This avoids confusing messages, samba_dnsupdate returns the number of
failed updates

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e9e4aeafc0cf7030dbd885710d6e8a179110f9ce">e9e4aeaf</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-15T06:53:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/dns: Add resolv.conf parsing

Right now this only looks at the nameserver setting. It is initally made for
asynchronous AD DC lookup routines, where we don't need the "search", "domain"
and other settings. When we convert general "net", "smbclient" and others to
use this, we might either add "domain" handling to this code or look at
something like c-ares which already does it.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5f393deb3095ac0c0b0a6d57e7182c104b061404">5f393deb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-15T06:53:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/dns: Add dns_lookup

Wrapper function to parse resolv.conf and talk to multiple nameservers. This is
the code where we might want to add a "working nameserver" cache. glibc always
looks at the first configured nameserver. If that's dead, glibc runs into a
timeout and only then asks the second one that might succeed. When more than
one dns query is to be performed, these timeouts add up.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b7418203eebafd4027abc45e27b411dfc51c1f3e">b7418203</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-15T06:53:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns_lookup: Let make test override the resolv.conf location

Make this a separate commit: That is the feature that libc unfortunately does
not give us.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/237c06aad817f495fe57fcf2df434e4852c878cd">237c06aa</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-15T06:53:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/dns: Make "clidns" a library

This will be linked into the SAMBA_LIBRARY "addns" in the next step. Because
the other user, "dnsserver_common", is also a library, we can't link this as a
subsystem anymore.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dbbce1a4545714cff0dad9e8c011800d0a66376e">dbbce1a4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-15T06:53:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/dns: clidns must depend on ndr_standard, not on NDR_DNS

Otherwise we can't link this into other libraries

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a8191f88ca82cc259b593d69980df76c3c30b1fa">a8191f88</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-15T06:53:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/dns: Add dns_res_rec_get_sockaddr

Pull the address from a res_rec if it's there

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/61e64791294f0ef6597c9fc5359221f915de542f">61e64791</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-15T06:53:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: add central dns forwarder

This is a small DNS server that has hard redirects to the different domain
controllers based on domain names. This is required because future commits will
avoid calling into libresolv's code which resolv_wrapper takes care of.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/62584f3d081a3318841ec16855dbf4396d3fc0aa">62584f3d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-15T06:53:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: setup_dns_hub

Start the central dns forwarder on interface 64

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5f02a6af948bacebd659b4356ea7bc6d3b2419f3">5f02a6af</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-15T06:53:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add dns_hub deps

All the DCs want the dns forwarder

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/99b775336b72c6a7d0ce121b2eeb027901482a6d">99b77533</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-15T06:53:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Use dns_hub's resolv.conf

Pass it as RESOLV_CONF envvar everywhere

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9563fcf6ffae4a6d3595a1207513bbf0742203f4">9563fcf6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-15T06:53:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba_dnsupdate: With dns_hub, we don't need resolv_wrap

Best viewed with git show -b

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4b4ae005b2029d55ad95809a535d13eb5ff51174">4b4ae005</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-15T06:53:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">addns: Async ads_dns_lookup_srv

Use dns_lookup_send/recv to get SRV records. This avoids synchronous libresolv
calls and provides the infrastructure to get dsgetdcname async.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3f4bd61b8408f8d97817023f07de20746ce54f90">3f4bd61b</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-01-15T09:59:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release note for Samba 4.10.0rc1.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9537e5d2a14a35bcba659d679d2d156de6c678cc">9537e5d2</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-01-15T10:01:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.0rc1...

and disable GIT_SNAPSHOT for the release.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/75106e05b42e5d4629aacfa941213745d9d6e819">75106e05</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-01-15T10:02:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.0rc2...

and re-enable GIT_SNAPSHOT.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f2d8308c22c8d6feb6b4396f69feabcdbcb5b99c">f2d8308c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-01-15T10:16:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">addns: Async ads_dns_lookup_ns

Use dns_lookup_send/recv to get NS records

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Jan 15 11:16:00 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/118b492d3ecbf1672daa8fc578dbeac4f48c4022">118b492d</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-01-15T10:19:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "VERSION: Bump version up to 4.10.0rc2..."

This reverts commit 75106e05b42e5d4629aacfa941213745d9d6e819.
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a4e37680d35fcb2073846c74a90a2a644bcde25a">a4e37680</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-01-15T10:19:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "VERSION: Bump version up to 4.10.0rc1..."

This reverts commit 9537e5d2a14a35bcba659d679d2d156de6c678cc.
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/08f27a00832245e637e0696fb27e23459b8ca820">08f27a00</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-01-15T10:19:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "WHATSNEW: Add release note for Samba 4.10.0rc1."

This reverts commit 3f4bd61b8408f8d97817023f07de20746ce54f90.
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/33de2f0727e939d404781672633c360b5fa81709">33de2f07</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-15T10:23:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge remote-tracking branch 'origin/v4-10-test' into HEAD

This is a noop just to get the history of origin/v4-10-test
inline with master before the real 4.10.0rc1.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b915626087c2340c7cd89cd2ecb7a8b20a756c0a">b9156260</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-15T10:28:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: version 2.1.15

* Deprecate talloc_set_memlimit() and talloc_autofree_context()
* Fix undefined behavior in talloc_memdup
* The build uses python3 by default:
* --extra-python would take python2 now
* To build with python2 only use:
  PYTHON=python2 ./configure
  PYTHON=python2 make
  PYTHON=python2 make install

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1c73f38633ce40bcf19775fbeaf5e3baacdba9ab">1c73f386</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-15T10:29:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: version 0.9.38

* Deprecate tevent wrapper api again
* Build fixes
* The build uses python3 by default:
* --extra-python would take python2 now
* To build with python2 only use:
  PYTHON=python2 ./configure
  PYTHON=python2 make
  PYTHON=python2 make install

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/340cb9ca97bc2a23f102f80897a8d8f4809f0072">340cb9ca</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-01-15T10:29:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: version 1.5.2

* Build fixes
* dirsync: Allow arbitrary length cookies
  (bug #13686)
* The build uses python3 by default:
* --extra-python would take python2 now
* To build with python2 only use:
  PYTHON=python2 ./configure
  PYTHON=python2 make
  PYTHON=python2 make install

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/86253ce38455cc6eb8d6a5b5f536a8ced81504e4">86253ce3</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-01-15T10:31:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release note for Samba 4.10.0rc1.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

(replaces commit 3f4bd61b8408f8d97817023f07de20746ce54f90)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1c9e1bcda1c365df9b33c4ea984d48728615e353">1c9e1bcd</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-01-15T10:33:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.0rc1...

and disable GIT_SNAPSHOT for the release.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

(replaces commit 9537e5d2a14a35bcba659d679d2d156de6c678cc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/248c234e06bf09a7f6ca3f6cafbac47baea7b302">248c234e</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-01-15T10:34:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.0rc2...

and re-enable GIT_SNAPSHOT.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

(replaces commit 75106e05b42e5d4629aacfa941213745d9d6e819)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/529b29203d4263bb2e3263e7d873f74f5236814a">529b2920</a></strong>
<div>
<span>by Justin Stephenson</span>
<i>at 2019-02-04T08:50:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: Honor disable_netbios option in smbsock_connect_send

If disable_netbios is set, return before the tevent timer is triggered
to prevent outgoing netbios connections.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13727

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit c324f84a2fa25e29d2f7879fbcd35ce0e76a78f8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f43abe39d56b772628a6b9f803f0bf68f5870d08">f43abe39</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-04T08:50:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/gpclass: Convert gpclass to use s3 SMB Python bindings

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 3b2e86bba1f6b22b144b07db454b842f0c0779ae)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3ed03bd24eb6c236df23025aa25b9618a2d76a25">3ed03bd2</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-04T08:50:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Add .set_acl API to SMB py bindings

This is pretty similar code to py_smb_getacl(), except it's calling
cli_set_security_descriptor() instead of cli_query_security_descriptor()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit b982811b60521624f1f600841ffa05e306eb936a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b47e42e04006549ae24360191e3b36f6cc01dc2f">b47e42e0</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-04T08:50:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Change SMB flags from s4 Py bindings to s3

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 345746ea5f4cca2620421ac0c8a649a596f5c19d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c9fdea2e361c842d566d662255a361c07932d003">c9fdea2e</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-04T08:50:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:pylibsmb: Add FILE_READ_ATTRIBUTES access to .loadfile() API

Add FILE_READ_ATTRIBUTES when opening the file handle, as we need to
read the file's size.

The .loadfile() API can end up calling cli_qfileinfo_basic() to get the
file size. This can end up doing a 'FILE_ALL_INFORMATION' SMBv2 request
underneath, which the MS-SMB2 spec (section 3.3.5.20.1 Handling
SMB2_0_INFO_FILE) says the file handle must have FILE_READ_ATTRIBUTES
access granted.

I noticed this problem when running .loadfile() against the NTVFS
server.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 0304b08de5ba1b4a6e08568a559c52f7d9e943d3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c4323c00ec59112bcd2160b87ae5fe37a95cd34b">c4323c00</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-04T08:50:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Change GPO commands to use s3 SMB Py bindings

This means we can now use GPO commands on a DC that has SMBv1 disabled.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 08f1627cb3fa1c9ff7a0f74e32874d305647dc42)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9d9b00566c1e7795600075f7a7c572d67fb0714d">9d9b0056</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-04T08:50:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:pysmb: Add error log that the s4 bindings are deprecated

We plan to delete the s4 SMB Python bindings in the next Samba release
after v4.10, but first give external consumers a heads-up, just in case
they are currently using the s4 bindings.

Note the auth_log tests still use the s4 bindings, but all user-facing
tools should now be updated to use the s3 bindings.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 6a29e63f32c0024587020fc1f92b3d1ecaa0afbc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6158ca6e2994c5090312cf4677024b43df6bcc7e">6158ca6e</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-04T08:50:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Run samba_tool.gpo tests against backup testenvs

Run the GPO tests against the backup/restore testenvs.

Because the backup/restore preserves the NTACLs of the sysvol files,
running the GPO tests against the backup testenvs is a good sanity-
check. If fact it highlights that there is currently a problem with
restoring the GPO files - this shows up in 'samba-tool gpo aclcheck',
but we never noticed it until now.

NTACL backup works slightly different for offline backups, and rename
backups end up with more sysvol files, so run the tests against both
these envs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 2a7372da7b84921b247cefc23d7003b8056d74a4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e682347bc1863a800373703f33866ea9c1f11626">e682347b</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-04T08:50:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ntacls: Pass correct use_ntvfs through to setntacl()

We were already checking the smb.conf to see if it uses the NTVFS file
server or the default smbd server. However, we weren't passing this
through to the setntacl() call.

This fixes the problem we noticed with 'samba-tool gpo aclcheck' failing
after a restore.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit f3fe96fc2e2d942b4a2e241777b5ee12b2295b97)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/349cfec01df89f0591b04a5f39a9876b73d217d9">349cfec0</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-04T08:50:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Run GPO commands against testenv with SMBv1 disabled

Just to prove that they work across SMBv2.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit da33c2c4e4849f0985b08fbdc58cbd59b8426ec6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7399fe07feadfe7adf76c650a511fb7948554d18">7399fe07</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-04T08:50:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Give the backup testenvs a 'test1' share

The ntacls_backup tests use the test1 share, and we want to run them
against the restoredc (which has SMBv1 disabled).

The xattr.tdb file is needed for the backend_obj.wrap_getxattr() call
(in ntacls.py) to work.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit a310de2db13c02a602e74139cb47ea9a25628e01)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f088f070b4cb5a18fdb6f819c5857ef325f53033">f088f070</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-04T08:50:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Run ntacls_backup tests against testenv with SMBv1 disabled

Just to prove that the NTACL backup works over SMBv2.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 7fb93eaca74ffe17bbe7255210dd3090afe8d5dc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/26cd687f14d70676c41e038b98551944ebd95356">26cd687f</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-04T08:50:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Try to improve domain backup error message

I ran this command as non-root by mistake and didn't find the error
message particularly helpful. Tweak the error message so it reminds the
user that they should be root. Also display the path we're looking for
the sam.ldb file in, to give them more clues.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>

Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Mon Jan 21 16:34:06 CET 2019 on sn-devel-144

(cherry picked from commit 10e54a095f005c0988a7e5e8a35cea6200197854)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/16b1971ea0ae76d0738f1dae9997b58af1bd5eac">16b1971e</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-04T08:50:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Update for Bug 13676 changes in Samba 4.10

Although it's unlikely that users will be using the 'smb' Python
bindings, it's probably worth noting in the release notes that these
bindings will be deprecated in future releases.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a4466ec428265be9b31cec0820ce44c6c9bbc61e">a4466ec4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-02-04T12:09:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Print locks latency in machinereadable stats

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13742
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Jan 16 05:34:17 CET 2019 on sn-devel-144

(cherry picked from commit 193a0d6f01372604b925d1972591062a0bb2400f)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Mon Feb  4 13:09:49 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9859cc5c1b052180435c1e11a89023726698f51c">9859cc5c</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2019-02-05T19:41:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add missing parenthesis

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13757

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/94aff506747acdc98582ca6426d34a68090077d3">94aff506</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-02-05T19:41:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: fix typo.

Guenther

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13757

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9ae7ffa5f053c5f39691dd881d1adb290859bcad">9ae7ffa5</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2019-02-05T19:41:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_glusterfs: Adapt to changes in libgfapi signatures

VFS module for GlusterFS fails to compile due to recent changes done to
some API signatures. Therefore adding missing arguments to those APIs
adapting to new signatures.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13330

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sun Feb  3 17:00:33 CET 2019 on sn-devel-144

(cherry picked from commit 0e3eda5bab5ae9316a42725aea048fb350020ec7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/334f1e6f56a10097ce918620dc484e9eb0a5b83b">334f1e6f</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-05T19:41:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">join: Fix TypeError when handling exception

When we can't resolve a domain name, we were inadvertently throwing a
TypeError whilst trying to output a helpful message. E.g.

ERROR(<class 'TypeError'>): uncaught exception - 'NTSTATUSError' object
does not support indexing

Instead of indexing the object, we want to index the Exception.args so
that we just display the string portion of the exception error.

The same problem is also present for the domain trust commands.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13747

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Rowland Penny <rpenny@samba.org>
Reviewed-by: Jeremy Allison <rpenny@samba.org>
(cherry picked from commit 3bb7808984c163a7bba66fb983411d1281589722)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/56549fd07d690e8fe615f5dd291c1d798045a03b">56549fd0</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-05T19:41:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">join: Throw CommandError instead of Exception for simple errors

Throwing an exception here still dumps out the Python stack trace, which
can be a little disconcerting for users.

In this case, the stack trace isn't going to really help at all (the
problem is pretty obvious), and it obscures the useful message
explaining what went wrong.

Throw a CommandError instead, which samba-tool will catch and display
more nicely.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13747

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Rowland Penny <rpenny@samba.org>
Reviewed-by: Jeremy Allison <rpenny@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jan 16 22:11:04 CET 2019 on sn-devel-144

(cherry picked from commit 9e4b08f4c384b8cae5ad853a7be7cf03e2749be5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6990f5018d90ba9be680f50cc812fafc73f67d7c">6990f501</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-02-05T19:41:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: dns_hub: Fix indentation of 'raise' on error.

Remove second socket.sendto().

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13750
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit dd231a16a338cfe63d12cadf0fc3e2ebe7cac828)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/520c062db5fa67789133eaed0887367392b14fa6">520c062d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-02-05T19:41:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: dns: Change internal DNS_REQUEST_TIMEOUT from 2 to 10 seconds.

Should make us more robust when dealing with slow DNS servers.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13750

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jan 22 23:37:16 CET 2019 on sn-devel-144

(cherry picked from commit 36c42e6d629a0d4b0e5c60bdd68e08a8e60c477a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9d2e05b1a6d8872d6f059097ce5125d7f25c29aa">9d2e05b1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-02-05T19:41:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">manpages/samba.7.xml: smbcontrol can also work with 'samba'

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13752

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Baumbach <bbaumbach@samba.org>
(cherry picked from commit 12b9adec3ff48f4356f9ff865891dc3c652ff86b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f105c379545ad51227126a239a60f946a2ab4a09">f105c379</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-02-05T19:41:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:messaging: add support 'smbcontrol <pid> debug/debuglevel'

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13752

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Baumbach <bbaumbach@samba.org>
(cherry picked from commit 3a0c1da432c53de234b54bac90a3fb84534994eb)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/45c19f4c25393bcc9db56e93a79ac25cef7e6280">45c19f4c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-02-05T19:41:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:server: avoid using pid=0 for the parent 'samba' process

It confuses the 'samba-tool processes' output and log messages.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13752

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Baumbach <bbaumbach@samba.org>
(cherry picked from commit 5bd7a8e5685caa09067745b108ef7e53e3108e97)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/902de86daa685b864594df5026f60d7cd7171b2e">902de86d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-02-05T19:41:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:server: add support for 'smbcontrol samba shutdown'

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13752

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Baumbach <bbaumbach@samba.org>
(cherry picked from commit 832776c0fcf7cc658c128765514755c2d15b06a6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a2e889740b3fa42e0287b499992366a73a3cae43">a2e88974</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-02-05T19:41:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest:Samba4: use 'smbcontrol samba shutdown'

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13752

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Baumbach <bbaumbach@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Jan 30 01:51:48 CET 2019 on sn-devel-144

(cherry picked from commit d03991f569b54ae0a11911b622107fbae701715d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8773e8a78e6dc666f9b6b49e897b1a070898113">f8773e8a</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-02-05T19:41:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-vfs: add glusterfs_fuse vfs module.

This module only implements the get_real_filename function by accessing
a distinct extended attribute that is available over a glusterfs fuse
mount.

By implementing this vfs function users of a glusterfs fuse mount
achieve a much better performance in create based workloads where samba
then can avoid trying multiple case folding options to detect the real
filename.

Patch is based on an initial patch provided by
Poornima G <pgurusid@redhat.com>

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13774

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Tue Jan 22 18:37:56 CET 2019 on sn-devel-144

(cherry picked from commit adffe0dcf002aa4721dc7897261895e3486d5271)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/676b549321abe61c63cb07681bd566b05369a876">676b5493</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2019-02-05T22:59:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-vfs: Use ENOATTR in errno comparison for getxattr

* ENODATA is not defined in FreeBSD
* ENOATTR is defined to be a synonym for ENODATA in Linux
* In its absence Samba already defines ENOATTR to either
  ENODATA or ENOENT

Thus it is safe and correct to compare with ENOATTR rather
than ENODATA.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13774

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jan 23 21:59:10 CET 2019 on sn-devel-144

(cherry picked from commit c99402724a65f4e1f8ed4dcd236a43e0603bef0a)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Tue Feb  5 23:59:06 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d902eec5bae7e862ee8a19460f028189c8eb39d2">d902eec5</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-02-06T07:57:04Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.10.0rc2.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/61e654828c1340a6b5814a62ada39491ca2c6380">61e65482</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-02-06T07:59:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Diable GIT_SNAPSHOT for the 4.10.0rc2 release.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c75bfe674b9e2d3fc9671fb85b334c0a392e13d">0c75bfe6</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-02-06T08:00:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.0rc2...

and re-enable GIT_SNAPSHOT.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7fc3481765720d2fa0324f297e4a658520fb092f">7fc34817</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-13T10:41:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Avoid inefficient one-level searches

Commit 88ae60ed186c9 introduced a problem that made one-level
searches inefficient if there were a lot of child objects in the same
level, and the requested object didn't exist. Basically, it ignored the
case where ldb_kv_index_dn() returned LDB_ERR_NO_SUCH_OBJECT, i.e. the
indexed lookup was successful, but didn't find a match. At which point,
there was no more processing we needed to do.

The behaviour after 88ae60ed186c9 was to fall-through and run the
ldb_kv_index_filter() function over *all* the children. This still
returned the correct result, but could be costly if there were a lot of
children.

The case 88ae60ed186c9 was trying to fix was where we could not do
an indexed search (e.g. trying to match on a 'attribute=*' filter). In
which case we want to ignore the LDB_ERR_OPERATIONS_ERROR and just run
ldb_kv_index_filter() over all the children. This is still more
efficient than the fallback of doing a full database scan.

This patch adds in a short-circuit for the NO_SUCH_OBJECT case, so we
can skip the unnecessary ldb_kv_index_filter() work.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13762

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 9a893f9613bd6440abd8e487d22a39ab5b82a7b9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f7774530936bc3e9795b2f0089c984641ab5c5c9">f7774530</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-13T10:41:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Remove comment that no longer makes sense

This comment was written before the GUID_index_attribute block of code
existed. So we now *do* load the index values and *do* check for a
strict intersect, so the comment is redundant.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13762

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 72928444823c5b18ac9ef98e7432c999d70aa571)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/62fea7e9c3f94d254e6c9f72cd690137c2ee556c">62fea7e9</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-13T10:41:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Elaborate on ldb_kv_search_indexed() comments

Disclaimer: this is based on my limited understanding of what the code
is doing.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13762

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 132600685b8c5d4964f20634cd7a64b14f41cfa7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2a915942295e6cdc87dc9aab6cf2c8c78741f26e">2a915942</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-13T10:41:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Rename variable

The old name confused me because it's not really related to the
one-level index at all. It's the result from evaluating the indexed
search specified in the ac->tree.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13762

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 57a565b2fd680fc1a34f4ab91c6f6314f68ef67f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bb850a075024ad8ac26a25681339f6ce88334aba">bb850a07</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-02-13T10:41:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Add even more comments on what strict does to the list intersections

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13762

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit e7f524fd2128aacb82e980652af8eb6fd275e1a8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e21e24d8345e441d639020affc1f6ee59762725d">e21e24d8</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-02-13T15:24:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Release ldb 1.5.3

* Avoid inefficient one-level searches (bug 13762)
* The test api.py should not rely on order of entries in dict (bug 13772)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13762
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13772

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit 5e716c0256a6bec92e7855ccfc077a328320f2ea)

Autobuild-User(v4-10-test): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(v4-10-test): Wed Feb 13 16:24:32 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7621c622f83f90c213bfbf2b17b8b3a78510ecf2">7621c622</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-02-21T11:30:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-smbd: use fruit:model string for mDNS registration

With this change we now allow to modify the icon to represent Samba in
Finder. Possible values are at least:

fruit:model = iMac
fruit:model = MacBook
fruit:model = MacPro
fruit:model = Xserve
fruit:model = RackMac

Prior to this change we only displayed the correct icon when a mac
client negotiated the apple create context over SMB.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13746

Based on proposed patch from Rouven WEILER <Rouven_Weiler@gmx.net>

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Tue Jan 15 21:27:20 CET 2019 on sn-devel-144

(cherry picked from commit 538ce72f1b2fa78450e3b711e58bd0e238faf466)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3d0450ef3c54d31d4a1aafaebf415e7f9d727c7b">3d0450ef</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2019-02-21T11:30:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">printing: drop pcap_cache_loaded() guard around load_printers()

Add the pcap_cache_loaded() check to load_printers() and return early
if it returns false. This simplifies callers in preparation for checking
lp_load_printers() in the printcap cache update code-path.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13766

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
(cherry picked from commit 0ae7c3144a30910adb1e54cf46d54d42a1036839)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d6dbd33fdcd6a4763a95d448405c54a2170c2616">d6dbd33f</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2019-02-21T11:30:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">printing: check lp_load_printers() prior to pcap cache update

Avoid explicit and housekeeping timer triggered printcap cache updates
if lp_load_printers() is disabled.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13766

Signed-off-by: David Disseldorp <ddiss@samba.org>

Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Fri Feb  1 19:25:03 CET 2019 on sn-devel-144

(cherry picked from commit 6a77237c50dd258521f356af0b5dc9942dd5592e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f68aab42318381fe42b90bff8962e6d77470cbd3">f68aab42</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-02-21T11:30:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: tests: Add regression test for smbd crash on share force group change with existing connection.

Mark as known fail for now.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13690

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 7b21b4c1f538650f23ec77fb3c02fe1e224d89aa)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eba5d055376b6f53f784dadbe71a8bfbdcee8b4a">eba5d055</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-02-21T11:30:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: uid: Don't crash if 'force group' is added to an existing share connection.

smbd could crash if "force group" is added to a
share definition whilst an existing connection
to that share exists. In that case, don't change
the existing credentials for force group, only
do so for new connections.

Remove knownfail from regression test.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13690

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Jan 25 16:31:27 CET 2019 on sn-devel-144

(cherry picked from commit e37f9956c1f2416408bad048a4618f6366086b6a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/72bcae77752b3918a5eb3f56e0aef0c76135a556">72bcae77</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-02-21T11:30:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit. Fix the NetAtalk deny mode compatibility code.

This exhibited itself as a problem with OFD locks reported
as:

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13770

However, due to underlying bugs in the vfs_fruit
code the file locks were not being properly applied.

There are two problems in fruit_check_access().

Problem #1:

Inside fruit_check_access() we have:

flags = fcntl(fsp->fh->fd, F_GETFL);
..
if (flags & (O_RDONLY|O_RDWR)) {

We shouldn't be calling fcntl(fsp->fh->fd, ..) directly.
fsp->fh->fd may be a made up number from an underlying
VFS module that has no meaning to a system call.

Secondly, in all POSIX systems - O_RDONLY is defined as
*zero*. O_RDWR = 2.

Which means flags & (O_RDONLY|O_RDWR) becomes (flags & 2),
not what we actually thought.

Problem #2:

deny_mode is *not* a bitmask, it's a set of discrete values.

Inside fruit_check_access() we have:

if (deny_mode & DENY_READ) and also (deny_mode & DENY_WRITE)

However, deny modes are defined as:

/* deny modes */
define DENY_DOS 0
define DENY_ALL 1
define DENY_WRITE 2
define DENY_READ 3
define DENY_NONE 4
define DENY_FCB 7

so if deny_mode = DENY_WRITE, or if deny_mode = DENY_READ
then it's going to trigger both the if (deny_mode & DENY_READ)
*and* the (deny_mode & DENY_WRITE) conditions.

These problems allowed the original test test_netatalk_lock code to
pass (which was added for BUG: https://bugzilla.samba.org/show_bug.cgi?id=13584
to demonstrate the lock order violation).

This patch refactors the fruit_check_access()
code to be much simpler (IMHO) to understand.

Firstly, pass in the SMB1/2 share mode, not old
DOS deny modes.

Secondly, read all the possible NetAtalk locks
into local variables:

netatalk_already_open_for_reading
netatalk_already_open_with_deny_read
netatalk_already_open_for_writing
netatalk_already_open_with_deny_write

Then do the share mode/access mode checks
with the requested values against any stored
netatalk modes/access modes.

Finally add in NetATalk compatible locks
that represent our share modes/access modes
into the file, with an early return if we don't
have FILE_READ_DATA (in which case we can't
write locks anyway).

The patch is easier to understand by looking
at the completed patched fruit_check_access()
function, rather than trying to look at the
diff.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
(cherry picked from commit 3204dc66f6801a7c8c87c48f601e0ebdee9e3d40)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fbc8ea71c5c32bc87e07d0550f8bb8d08227fc5b">fbc8ea71</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-02-21T11:30:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: vfs_fruit. Change test_fruit_locking_conflict() to match the vfs_fruit working server code.

Originally added for BUG: https://bugzilla.samba.org/show_bug.cgi?id=13584
to demonstrate a lock order violation, this test
exposed problems in the mapping of SMB1/2 share modes
and open modes to NetATalk modes once we moved to OFD locks.

Change the test slightly (and add comments)
so it demonstrates working NetATalk share modes
on an open file.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13770

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Feb  8 23:26:46 CET 2019 on sn-devel-144

(cherry picked from commit 28990e4ba23695ecf264117efad90cc4e573302e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fcd5865f3ff7e966b376a2073d8477b1ef37fc25">fcd5865f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-02-21T11:30:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:vfs: Initialize pid to 0 in test_netatalk_lock()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13770

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 2ff2594b2bd878928cec30bc72a95a6d38bee154)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1ed75df5711c67565bfe70e4e82de9df208a4a7c">1ed75df5</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-02-21T11:30:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:vfs: Correctly check if OFD locks should be enabled or not

Also the smb.conf options should only be checked once and a reload of
the config should not switch to a different locking mode.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13770

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Feb  9 03:43:50 CET 2019 on sn-devel-144

(cherry picked from commit 7ff94b18e2e39567ef7a208084cc5c914c39d3bd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a530ee4f917a6a0d37359587ad99ef8d1befd2f">9a530ee4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-02-21T11:30:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tldap: avoid a use after free crash

I saw the following crash in tldap in the winbindd idmap child on a
member server after messing with the LDAP server on the DC:

0  0x00007f77ea9a307a in __GI___waitpid (pid=9815, stat_loc=stat_loc@entry=0x7ffe77569eb0, options=options@entry=0) at ../sysdeps/unix/sysv/linux/waitpid.c:29
1  0x00007f77ea91bfbb in do_system (line=<optimized out>) at ../sysdeps/posix/system.c:148
2  0x00007f77edd8c24b in smb_panic_s3 (why=0x7f77f08e6e88 "Bad talloc magic value - access after free") at ../source3/lib/util.c:828
3  0x00007f77f15afe85 in smb_panic (why=0x7f77f08e6e88 "Bad talloc magic value - access after free") at ../lib/util/fault.c:170
4  0x00007f77f08e2678 in talloc_abort (reason=0x7f77f08e6e88 "Bad talloc magic value - access after free") at ../lib/talloc/talloc.c:472
5  0x00007f77f08e268b in talloc_abort_access_after_free () at ../lib/talloc/talloc.c:477
6  0x00007f77f08e2710 in talloc_chunk_from_ptr (ptr=0x55da7605a020) at ../lib/talloc/talloc.c:494
7  0x00007f77f08e4a19 in _talloc_free (ptr=0x55da7605a020, location=0x7f77e181474d "../source3/lib/tldap.c:1918") at ../lib/talloc/talloc.c:1716
8  0x00007f77e180b65c in tldap_search_all_done (subreq=0x55da7605a020) at ../source3/lib/tldap.c:1918
9  0x00007f77f0af0fd0 in _tevent_req_notify_callback (req=0x55da7605a020, location=0x7f77e1813e50 "../source3/lib/tldap.c:47") at ../lib/tevent/tevent_req.c:125
10 0x00007f77f0af10a5 in tevent_req_finish (req=0x55da7605a020, state=TEVENT_REQ_USER_ERROR, location=0x7f77e1813e50 "../source3/lib/tldap.c:47") at ../lib/tevent/tevent_req.c:162
11 0x00007f77f0af1113 in _tevent_req_error (req=0x55da7605a020, error=9780923860630110289, location=0x7f77e1813e50 "../source3/lib/tldap.c:47") at ../lib/tevent/tevent_req.c:180
12 0x00007f77e180781a in tevent_req_ldap_error (req=0x55da7605a020, rc=...) at ../source3/lib/tldap.c:47
13 0x00007f77e180b2c4 in tldap_search_done (subreq=0x55da76058280) at ../source3/lib/tldap.c:1813
14 0x00007f77f0af0fd0 in _tevent_req_notify_callback (req=0x55da76058280, location=0x7f77e1813e50 "../source3/lib/tldap.c:47") at ../lib/tevent/tevent_req.c:125
15 0x00007f77f0af10a5 in tevent_req_finish (req=0x55da76058280, state=TEVENT_REQ_USER_ERROR, location=0x7f77e1813e50 "../source3/lib/tldap.c:47") at ../lib/tevent/tevent_req.c:162
16 0x00007f77f0af11cd in tevent_req_trigger (ev=0x55da760526c0, im=0x55da76058360, private_data=0x55da76058280) at ../lib/tevent/tevent_req.c:219
17 0x00007f77f0af0378 in tevent_common_loop_immediate (ev=0x55da760526c0) at ../lib/tevent/tevent_immediate.c:135
18 0x00007f77f0af8b8f in epoll_event_loop_once (ev=0x55da760526c0, location=0x7f77f0af92b0 "../lib/tevent/tevent_req.c:269") at ../lib/tevent/tevent_epoll.c:911
19 0x00007f77f0af5925 in std_event_loop_once (ev=0x55da760526c0, location=0x7f77f0af92b0 "../lib/tevent/tevent_req.c:269") at ../lib/tevent/tevent_standard.c:114
20 0x00007f77f0aef201 in _tevent_loop_once (ev=0x55da760526c0, location=0x7f77f0af92b0 "../lib/tevent/tevent_req.c:269") at ../lib/tevent/tevent.c:725
21 0x00007f77f0af1361 in tevent_req_poll (req=0x55da7605eed0, ev=0x55da760526c0) at ../lib/tevent/tevent_req.c:269
22 0x00007f77e180fec9 in tldap_gensec_bind (ctx=0x55da76051ec0, creds=0x55da76052250, target_service=0x7f77e18164b3 "ldap", target_hostname=0x55da7605d182 "dc1.sdom1.site", target_principal=0x0, lp_ctx=0x55da76052180, gensec_features=6) at ../source3/lib/tldap_gensec_bind.c:358
23 0x00007f77e1810d21 in idmap_ad_get_tldap_ctx (mem_ctx=0x55da76050510, domname=0x55da76051d50 "sdom1", pld=0x55da76050518) at ../source3/winbindd/idmap_ad.c:326
24 0x00007f77e1811056 in idmap_ad_context_create (mem_ctx=0x55da76059c00, dom=0x55da76059c00, domname=0x55da76051d50 "sdom1", pctx=0x7ffe7756a5f8) at ../source3/winbindd/idmap_ad.c:374
25 0x00007f77e18119c0 in idmap_ad_get_context (dom=0x55da76059c00, pctx=0x7ffe7756a640) at ../source3/winbindd/idmap_ad.c:554
26 0x00007f77e181275b in idmap_ad_sids_to_unixids (dom=0x55da76059c00, ids=0x55da760518a0) at ../source3/winbindd/idmap_ad.c:784
27 0x00007f77e1813217 in idmap_ad_sids_to_unixids_retry (dom=0x55da76059c00, ids=0x55da760518a0) at ../source3/winbindd/idmap_ad.c:947
28 0x000055da7459ce05 in _wbint_Sids2UnixIDs (p=0x7ffe7756a870, r=0x55da76050860) at ../source3/winbindd/winbindd_dual_srv.c:202
29 0x000055da7460aa5e in api_wbint_Sids2UnixIDs (p=0x7ffe7756a870) at default/librpc/gen_ndr/srv_winbind.c:391
30 0x000055da7459c7f4 in winbindd_dual_ndrcmd (domain=0x0, state=0x7ffe7756abb8) at ../source3/winbindd/winbindd_dual_ndr.c:369
31 0x000055da7459828c in child_process_request (child=0x55da74874bc0 <static_idmap_child>, state=0x7ffe7756abb8) at ../source3/winbindd/winbindd_dual.c:666
32 0x000055da7459ae58 in child_handler (ev=0x55da7602c2b0, fde=0x55da7603f8a0, flags=1, private_data=0x7ffe7756abb0) at ../source3/winbindd/winbindd_dual.c:1567
33 0x00007f77f0af85f1 in epoll_event_loop (epoll_ev=0x55da76048b00, tvalp=0x7ffe7756aab0) at ../lib/tevent/tevent_epoll.c:728
34 0x00007f77f0af8c29 in epoll_event_loop_once (ev=0x55da7602c2b0, location=0x55da74628b08 "../source3/winbindd/winbindd_dual.c:1766") at ../lib/tevent/tevent_epoll.c:930
35 0x00007f77f0af5925 in std_event_loop_once (ev=0x55da7602c2b0, location=0x55da74628b08 "../source3/winbindd/winbindd_dual.c:1766") at ../lib/tevent/tevent_standard.c:114
36 0x00007f77f0aef201 in _tevent_loop_once (ev=0x55da7602c2b0, location=0x55da74628b08 "../source3/winbindd/winbindd_dual.c:1766") at ../lib/tevent/tevent.c:725
37 0x000055da7459b9e9 in fork_domain_child (child=0x55da74874bc0 <static_idmap_child>) at ../source3/winbindd/winbindd_dual.c:1766
38 0x000055da74596e96 in wb_child_request_waited (subreq=0x0) at ../source3/winbindd/winbindd_dual.c:188
39 0x00007f77f0af0fd0 in _tevent_req_notify_callback (req=0x55da7604f820, location=0x7f77f0af90f8 "../lib/tevent/tevent_queue.c:355") at ../lib/tevent/tevent_req.c:125
40 0x00007f77f0af10a5 in tevent_req_finish (req=0x55da7604f820, state=TEVENT_REQ_DONE, location=0x7f77f0af90f8 "../lib/tevent/tevent_queue.c:355") at ../lib/tevent/tevent_req.c:162
41 0x00007f77f0af10cd in _tevent_req_done (req=0x55da7604f820, location=0x7f77f0af90f8 "../lib/tevent/tevent_queue.c:355") at ../lib/tevent/tevent_req.c:168
42 0x00007f77f0af0cc1 in tevent_queue_wait_trigger (req=0x55da7604f820, private_data=0x0) at ../lib/tevent/tevent_queue.c:355
43 0x00007f77f0af06f2 in tevent_queue_immediate_trigger (ev=0x55da7602c2b0, im=0x55da760466a0, private_data=0x55da76046580) at ../lib/tevent/tevent_queue.c:149
44 0x00007f77f0af0378 in tevent_common_loop_immediate (ev=0x55da7602c2b0) at ../lib/tevent/tevent_immediate.c:135
45 0x00007f77f0af8b8f in epoll_event_loop_once (ev=0x55da7602c2b0, location=0x55da74612630 "../source3/winbindd/winbindd.c:1803") at ../lib/tevent/tevent_epoll.c:911
46 0x00007f77f0af5925 in std_event_loop_once (ev=0x55da7602c2b0, location=0x55da74612630 "../source3/winbindd/winbindd.c:1803") at ../lib/tevent/tevent_standard.c:114
47 0x00007f77f0aef201 in _tevent_loop_once (ev=0x55da7602c2b0, location=0x55da74612630 "../source3/winbindd/winbindd.c:1803") at ../lib/tevent/tevent.c:725
48 0x000055da74561431 in main (argc=2, argv=0x7ffe7756c968) at ../source3/winbindd/winbindd.c:1803

subreq is a child of the state of req which will already be free by the
callback of req.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13776

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 9465292d4109f710f8fcd141a076f5c8278577bc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6d2af886f405ab7dbd2bf9022cadf8e12e0a26b5">6d2af886</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-02-21T11:30:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tldap: avoid more use after free errors

See the previous commit for an explanation. :)

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13776

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Feb  6 10:19:12 CET 2019 on sn-devel-144

(cherry picked from commit bf91ee0a9727cc392583fe84ad069204be758515)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2ba1d9dd8d2ab2b11e13a1e1355cbc391226e084">2ba1d9dd</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-02-21T11:30:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc:ndr: Implement ndr_zero_memory()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13778

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 2a7086f1ac4ad91fb7cd958e9386abb996794ed1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f6a44c807a9cf9061ab82930c7b0799c785ff6b2">f6a44c80</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-02-21T11:30:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc:ndr: Add NDR_ZERO_STRUCT(P) macros

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13778

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 666802a3db3115ca09f3ffed58c8e4a8cabd65de)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/66bf14d832286f5f5b9b4b68cd9b5b96975dbbed">66bf14d8</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-02-21T11:30:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: Use NDR_ZERO_STRUCT(P) macros

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13778

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 532ce0d20a8016c1270ea689de627da8aa4abfdd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9bf434a941be2f3b13b5cc59b5ad6f77f0c0fb8d">9bf434a9</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-02-21T11:30:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Move discard_const(_p) to own header for libndr.h

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13778

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 96df6878ed521b7e744d703abb32a585500d3b94)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be6f8d41ca7452840545356c7320355be815b5cd">be6f8d41</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-02-21T11:30:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: Do not install internal header

We should not install header files without an public API:

- memory.h
- safe_strings.h
- talloc_stack.h

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13778

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 6d232f3f7c64f9b01439326e0e9b6d9df9a0bcbb)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d8911eaa54d5c82046311e856cbc8e7269477aa4">d8911eaa</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-02-21T11:30:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add note that python2 support will be dropped on v4.11

Add a warning to Samba users that v4.10 will be the last Samba release
with python2 support.

I've reworked the existing text describing the different python2 build
options for 4.10. Hopefully this makes it slightly clearer.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13785

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a3a9630a464979159cac2ea6783982584d3a450e">a3a9630a</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-02-21T15:26:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: Check for libnscd

The check was in the old autoconf, but not in waf. As the code is still
in source3/lib/util_nscd.c, add the check for libnscd to allow building
and using the code.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13787

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Wed Feb 13 17:58:33 CET 2019 on sn-devel-144

(cherry picked from commit 3a793497796395ffa3efda5807bdb1ca8e09e35b)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Thu Feb 21 16:26:51 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1f749eb6f6a56eb0a184bce6f924f5d03d024b08">1f749eb6</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-02-22T07:59:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.10.0rc3.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3d91947b53e78d2b08a8b85726dee8025208d4de">3d91947b</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-02-22T07:59:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.10.0rc3 release.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9dde00c3e0ae7c095f61e1499c9ab939047f17bd">9dde00c3</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-02-22T08:00:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.0rc4...

and re-enable GIT_SNAPSHOT.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fb1d5988e30fffe9c4965b3112b9f43fdbf5ec33">fb1d5988</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-02-22T12:44:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba: Avoid decode when using python2

To avoid problematic type checking for 'str' types which fail
when result from str.decode is used.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13777

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 244e2a02796b2ee85b9db01cbea7043a7448a110)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Fri Feb 22 13:44:34 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba5a93c860af07f2a3534513133702b53c6b63f8">ba5a93c8</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2019-02-26T12:00:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Search for location of waf script

When calling make from the ldb, talloc, tdb, and
tevent bundles, we need to first find the
location of the waf script. Currently the build
fails since it can't find waf.

Fixes regression caused by a660b7f.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 8ecd7f756f0fafe5fd79dc4deb445883450c7cca)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/50be2c5827482592ee059c9f4000708250be19b0">50be2c58</a></strong>
<div>
<span>by Lukas Slebodnik</span>
<i>at 2019-02-26T12:00:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Fix compatibility of wscript with older python

Traceback (most recent call last):
  File "tdb-1.3.17/third_party/waf/waflib/Scripting.py", line 158, in waf_entry_point
    run_commands()
  File "tdb-1.3.17/third_party/waf/waflib/Scripting.py", line 251, in run_commands
    ctx = run_command(cmd_name)
  File "tdb-1.3.17/third_party/waf/waflib/Scripting.py", line 235, in run_command
    ctx.execute()
  File "tdb-1.3.17/third_party/waf/waflib/Context.py", line 204, in execute
    self.recurse([os.path.dirname(g_module.root_path)])
  File "tdb-1.3.17/third_party/waf/waflib/Context.py", line 286, in recurse
    user_function(self)
  File "tdb-1.3.17/wscript", line 225, in testonly
    cmd = "BINDIR={} {}".format(blddir, sh_test)
ValueError: zero length field name in format

Signed-off-by: Lukas Slebodnik <lslebodn@fedoraproject.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun Jan 20 03:49:59 CET 2019 on sn-devel-144

(cherry picked from commit 0628ca2a558871402f9a17cc7f7a0c69d857ae19)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b6bb285d9a9b18fd668659936803f1be4a34f948">b6bb285d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-02-26T12:00:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:tdb: Use C99 initializer for PyGetSetDef in pytdb

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit 651ee7f205f4a7e31c791f7bb235275816747463)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a5284f9ce32ce3ce930ebf920a63a99a602d028e">a5284f9c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-02-26T12:00:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:tdb: Use C99 initializer for tdb_header

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit a1ce666d68745a9bc65bd2709c581ed5105f656d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0130b999d2aacdcfbc7115e3367cdad5b2395178">0130b999</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-02-26T12:00:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:tdb: Use C99 initializer for tdb_logging_context

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit 47b57a2fc87664366099913305dd8d3783734a1a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dd2ec6de72d9fc0b82425576f19ad17efad39b03">dd2ec6de</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-02-26T12:00:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: version 1.3.18

* Fix build problems with older python versions.
* C99 build fixes.
* Fix standalone build of tdb.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit f0d26dd1816f35a00abf52b640f42547ffdfa01b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7bc0d67e2f536d3eb2495462657a28947bbbf267">7bc0d67e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-02-26T12:00:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: version 2.1.16

* Fix standalone build of talloc.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 3fe1551b5347934a20b9161a23e6a16220c3aeb6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6b125f6ce2dc2f095fa8842be0790e82656de796">6b125f6c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-02-26T12:00:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:tevent: Use correct C99 initializer for tevent_req

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit 0da2e9c215f882ea4c331ac4f17738913beb7404)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f868654638a32afcb4bfb9b03b4dc87f37f323b0">f8686546</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-02-26T12:00:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py_tevent: add_timer takes float argument

We were already using it that way.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
(cherry picked from commit 8294e68a4175e6116b38869866c42a1b7ba55b6a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0da2d830806da2ae092d9a094820861ffd3254a0">0da2d830</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-02-26T12:00:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: version 0.9.39

* py_tevent: add_timer takes float argument
* C99 build fixes.
* Fix standalone build of tevent.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit db58a50296041ca57675daee15caea8850f1d3f8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d0902c2a2bba7fc290d963cb771173adf8b5715">7d0902c2</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-02-26T12:00:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:ldb: Use C99 initializer for PyGetSetDef in pyldb

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit 85a5dc56e34298a60d7ef96f4178ccff20d40c82)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d16b81cf5865b983905653383ff6de14b00b698d">d16b81cf</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-02-26T12:00:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:ldb: Use C99 initializer for tdb_logging_context

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit 3cd5d4b39713559d2f88e21a24f8190fe9ce075c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/942822e7165565d9e9d462a7babb277c023bc2b5">942822e7</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-02-26T12:00:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:ldb: Use correct C99 initializer for 'struct tm'

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit 146ed0894e640fe1791f75fa8f50167b6cdfc06e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bfa9353ce1d2fa7925b0efa0baafb34fcc29bb65">bfa9353c</a></strong>
<div>
<span>by Lukas Slebodnik</span>
<i>at 2019-02-26T12:00:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: The test api.py should not rely on order of entries in dict

Test failed on s390x but there is a simple reproducer for any
architecture.

The built-in function repr returns the canonical string representation
of the object. We needn't care about order attributes in string
representation. Therefore test should pass for any order.

    for i in {1..30}; do
        PYTHONHASHSEED=random \
        python2 -c 'import ldb; msg = ldb.Message(); msg.dn = ldb.Dn(ldb.Ldb(), "dc=foo29"); msg["dc"] = b"foo"; print(repr(msg)) '
    done

  ======================================================================
  FAIL: test_repr (__main__.LdbMsgTests)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "tests/python/api.py", line 2322, in test_repr
      "Message({'dn': Dn('dc=foo29'), 'dc': MessageElement(['foo'])})")
  AssertionError: "Message({'dc': MessageElement(['foo']), 'dn': Dn('dc=foo29')})" != "Message({'dn': Dn('dc=foo29'), 'dc': MessageElement(['foo'])})"
  ----------------------------------------------------------------------
  Ran 1025 tests in 29.146s
  FAILED (failures=1)

Signed-off-by: Lukas Slebodnik <lslebodn@fedoraproject.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 7a7a5ccf501f89c530970bde072509ed86d7bd89)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aa13a46221adc66c0abeeb9f70e3859b248085aa">aa13a462</a></strong>
<div>
<span>by Lukas Slebodnik</span>
<i>at 2019-02-26T12:00:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-3824 ldb: Out of bound read in ldb_wildcard_compare

There is valgrind error in few tests tests/test-generic.sh
 91 echo "Test wildcard match"
 92 $VALGRIND ldbadd $LDBDIR/tests/test-wildcard.ldif  || exit 1
 93 $VALGRIND ldbsearch '(cn=test*multi)'  || exit 1
 95 $VALGRIND ldbsearch '(cn=*test_multi)'  || exit 1
 97 $VALGRIND ldbsearch '(cn=test*multi*test*multi)'  || exit 1

e.g.
  ==3098== Memcheck, a memory error detector
  ==3098== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
  ==3098== Using Valgrind-3.14.0 and LibVEX; rerun with -h for copyright info
  ==3098== Command: ./bin/ldbsearch (cn=test*multi)
  ==3098==
  ==3098== Invalid read of size 1
  ==3098==    at 0x483CEE7: memchr (vg_replace_strmem.c:890)
  ==3098==    by 0x49A9073: memmem (in /usr/lib64/libc-2.28.9000.so)
  ==3098==    by 0x485DFE9: ldb_wildcard_compare (ldb_match.c:313)
  ==3098==    by 0x485DFE9: ldb_match_substring (ldb_match.c:360)
  ==3098==    by 0x485DFE9: ldb_match_message (ldb_match.c:572)
  ==3098==    by 0x558F8FA: search_func (ldb_kv_search.c:549)
  ==3098==    by 0x48C78CA: ??? (in /usr/lib64/libtdb.so.1.3.17)
  ==3098==    by 0x48C7A60: tdb_traverse_read (in /usr/lib64/libtdb.so.1.3.17)
  ==3098==    by 0x557B7C4: ltdb_traverse_fn (ldb_tdb.c:274)
  ==3098==    by 0x558FBFA: ldb_kv_search_full (ldb_kv_search.c:594)
  ==3098==    by 0x558FBFA: ldb_kv_search (ldb_kv_search.c:854)
  ==3098==    by 0x558E497: ldb_kv_callback (ldb_kv.c:1713)
  ==3098==    by 0x48FCD58: tevent_common_invoke_timer_handler (in /usr/lib64/libtevent.so.0.9.38)
  ==3098==    by 0x48FCEFD: tevent_common_loop_timer_delay (in /usr/lib64/libtevent.so.0.9.38)
  ==3098==    by 0x48FE14A: ??? (in /usr/lib64/libtevent.so.0.9.38)
  ==3098==  Address 0x4b4ab81 is 0 bytes after a block of size 129 alloc'd
  ==3098==    at 0x483880B: malloc (vg_replace_malloc.c:309)
  ==3098==    by 0x491048B: talloc_strndup (in /usr/lib64/libtalloc.so.2.1.15)
  ==3098==    by 0x48593CA: ldb_casefold_default (ldb_utf8.c:59)
  ==3098==    by 0x485F68D: ldb_handler_fold (attrib_handlers.c:64)
  ==3098==    by 0x485DB88: ldb_wildcard_compare (ldb_match.c:257)
  ==3098==    by 0x485DB88: ldb_match_substring (ldb_match.c:360)
  ==3098==    by 0x485DB88: ldb_match_message (ldb_match.c:572)
  ==3098==    by 0x558F8FA: search_func (ldb_kv_search.c:549)
  ==3098==    by 0x48C78CA: ??? (in /usr/lib64/libtdb.so.1.3.17)
  ==3098==    by 0x48C7A60: tdb_traverse_read (in /usr/lib64/libtdb.so.1.3.17)
  ==3098==    by 0x557B7C4: ltdb_traverse_fn (ldb_tdb.c:274)
  ==3098==    by 0x558FBFA: ldb_kv_search_full (ldb_kv_search.c:594)
  ==3098==    by 0x558FBFA: ldb_kv_search (ldb_kv_search.c:854)
  ==3098==    by 0x558E497: ldb_kv_callback (ldb_kv.c:1713)
  ==3098==    by 0x48FCD58: tevent_common_invoke_timer_handler (in /usr/lib64/libtevent.so.0.9.38)
  ==3098==
  # record 1
  dn: cn=test_multi_test_multi_test_multi,o=University of Michigan,c=TEST
  cn: test_multi_test_multi_test_multi
  description: test multi wildcards matching
  objectclass: person
  sn: multi_test
  name: test_multi_test_multi_test_multi
  distinguishedName: cn=test_multi_test_multi_test_multi,o=University of Michiga
   n,c=TEST

  # returned 1 records
  # 1 entries
  # 0 referrals

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13773

Signed-off-by: Lukas Slebodnik <lslebodn@fedoraproject.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
(cherry picked from commit 3674b0891afb016c83763520b87e9f190dcfe884)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e9afae48efa52579635aa7004f6c4a3a22dc57df">e9afae48</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-02-26T12:00:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-3824 ldb: Extra comments to clarify no pointer wrap in wildcard processing

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13773

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
(cherry picked from commit 745b99fc6b75db33cdb0a58df1a3f2a5063bc76e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4cd0abe3c709e4600fbd74da63a6647c7427c68b">4cd0abe3</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-02-26T12:00:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-3824 ldb: Improve code style and layout in wildcard processing

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13773

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
(cherry picked from commit 9427806f7298d71bd7edfbdda7506ec63f15dda1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a0ace323908104b01840c4ff3e01376d20cb5c3">9a0ace32</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-02-26T12:00:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-3824 ldb: ldb_parse_tree use talloc_zero

Initialise the created ldb_parse_tree with talloc_zero, this ensures
that it is correctly initialised if inadvertently passed to a function
expecting a different operation type.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13773

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 8d34d172092f71baad0d777567e49aebfa07313d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/41fd2cde0c7e422381c7ae62296b1767feec9dcb">41fd2cde</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-02-26T12:00:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-3824 ldb: wildcard_match check tree operation

Check the operation type of the passed parse tree, and return
LDB_INAPPROPRIATE_MATCH if the operation is not LDB_OP_SUBSTRING.

A query of "attribute=*" gets parsed as LDB_OP_PRESENT, checking the
operation and failing ldb_wildcard_match should help prevent confusion
writing tests.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13773

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 34383981a0c40860f71a4451ff8fd752e1b67666)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aecd14f8bdc00519c981f17d398df3054fcab9da">aecd14f8</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-02-26T12:00:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-3824 ldb: wildcard_match end of data check

ldb_handler_copy and ldb_val_dup over allocate by one and add a trailing '\0'
to the data, to make them safe to use the C string functions on.

However testing for the trailing '\0' is not the correct way to test for
the end of a value, the length should be checked instead.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13773

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 42f0f57eb819ce6b68a8c5b3b53123b83ec917e3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/21a449892743994487f70dd67914f87cd83e4fc1">21a44989</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-02-26T12:00:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-3824 ldb: Add tests for ldb_wildcard_match

Add cmocka tests for ldb_wildcard_match.

Running test_wildcard_match under valgrind reproduces
 CVE-2019-3824 out of bounds read in wildcard compare (bug 13773)

 valgrind --suppressions=lib/ldb/tests/ldb_match_test.valgrind\
          bin/ldb_match_test

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13773

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 45b75db50f5c1a7c8c38af59a62fccee5401c845)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/97fcdfb58a751046541c370d68d6c52114fd702b">97fcdfb5</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-02-26T15:09:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-3824 ldb: version 1.5.4

* Fix standalone build of ldb.
* C99 build fixes.
* CVE-2019-3824 out of bounds read in wildcard compare (bug 13773)

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(v4-10-test): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(v4-10-test): Tue Feb 26 16:09:12 CET 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a2f740691a77d0d7a141d8bd1ab25d75e946b811">a2f74069</a></strong>
<div>
<span>by Jiří Šašek</span>
<i>at 2019-03-05T19:29:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">notifyd: Fix SIGBUS on sparc

Problem is the structure "struct notify_instance" can lay in message buffer on
address not dividable by 8 but this structure begins by uint_64 (secs in
time-stamp). Structure should be re-packed to standalone buffer before the use.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13704
Signed-off-by: jiri.sasek@oracle.com
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/da238723afee34581f9bb45daba5f3cfe5ef0edb">da238723</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-03-05T19:29:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">man pages: document prefork process model

Document the process model options -M

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13765

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Tim Beale <timbeale@samba.org>
Autobuild-Date(master): Thu Jan 31 04:25:14 CET 2019 on sn-devel-144

(cherry picked from commit 4ecdcc4b462d03bec3ec36ba1b90f45d9977be8b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5b7e33f0556a4c8514309a4e2cd0cf852aa59fe9">5b7e33f0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-03-05T19:29:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">messages_dgm: Use saved errno value

In this case this is just a cleanup, the value has just been set by
messaging_dgm_sendmsg. But as that already saves errno into a local
variable, use that.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13786

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit c27afc098398274abaed6dc9bef2019091c1b635)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d3a849880730e70ebf35b8afaee4627df14692f2">d3a84988</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-03-05T19:29:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture3: Extend read3 for the "messaging target re-inits" failure

Do ping_pong a hundred times, re-initializing the msg_ctx every time.

https://bugzilla.samba.org/show_bug.cgi?id=13786

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 8d8f62c4b9dea381ce9f5833bc794553ae358173)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/caf15a440a2b2800ebb6c00802def5886d7cd386">caf15a44</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-03-05T19:29:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">messages_dgm: Properly handle receiver re-initialization

This only properly covers the small-message nonblocking case. Covering
the large-message and the blocking case is a much larger effort assuming
we want to re-send the failed message if parts of the message has gone
through properly. Don't do that for now.

This was found by sanba_dnsupdate constantly recreating its irpc handle to
winbindd in the RODC case.

The messaging_dgm code cached connected datagram sockets based on the
destination pid for 1 second. Which means the IRPC responses from
winbindd are never delivered to samba_dnsupdate,
which will then hit a timeout.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13786

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 2543bba0364d8054e9ad316f5611621841bc061d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b69bb1f7619b84fb4f6bd50cfa56fdcc39c30c26">b69bb1f7</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-03-05T19:29:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-config: Change example recovery lock setting to one that fails

ctdbd will start without a recovery lock configured.  It will log a
message saying that this is not optimal.  However, a careless user may
overlook both this message and the importance of setting a recovery
lock.  If the existing example configuration is uncommented then the
directory containing it will be created (by 01.reclock.script) and the
failure (i.e. multiple nodes able to take the lock) will be confusing.

Instead, change the example setting to one that will result in banned
nodes, encouraging users to consciously configure (or deconfigure) the
recovery lock.  Tweak the corresponding comment.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13790

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 82e7f38214896c2c200132bc6dde3348cfac16cc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8d28f78bfd73245471d90a1e779844997965c43c">8d28f78b</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-03-05T19:29:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: buffer write beyond limits

In order to calculate the number of bytes correctly which
are to be read into the buffer, the buffer.offset must be taken
into account.

This patch fixes a regression introduced by 382705f495dd.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13791

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit fa8e69ac9538980c441b7fbefe0979027ecc8eac)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a4a8351c1f3fdbf43a1b55d611472a62b393fdcb">a4a8351c</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-03-05T19:29:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add test for ctdb_io.c

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13791

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>

Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Feb 22 03:51:37 CET 2019 on sn-devel-144

(cherry picked from commit 92a90524373a0348c1912d5019254dd18c07e207)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6ee34859e86ddc5870be9b9034b1e5a3901a2e4b">6ee34859</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-03-05T19:29:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Free cluster mutex handler on failure to take lock

If nested events occur while the file descriptor handler is still
active then chaos can ensue.  For example, if a node is banned and the
lock is explicitly cancelled (e.g. due to election loss) then
double-talloc-free()s abound.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13800

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 621658cbed5d91d7096fc208bac2ff93a1880e7d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/04baa822c4034772573e6b7e0a1079aa43ef1ced">04baa822</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-03-05T19:29:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Clean up logging on failure to take recovery lock

Add an explicit case for a timeout and clean up the other messages.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13800

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 7e4aae6943291c3144c8a3ff97537e8d4c7dc7c9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5a060f07469ce477a43723d4d7d004b0cfb5cd31">5a060f07</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-03-05T19:29:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Make recoverd context available in recovery lock handle

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13800

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit c0fb62ed3954fc6e8667480aba92003fc270f257)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf774b81051bfe1f3e58c3b5d5c074415a9abf51">bf774b81</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-03-05T19:29:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Ban node on unknown error when taking recovery lock

We really shouldn't see unknown errors.  They probably represent a
misconfigured recovery lock or similar.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13800

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 45a77d65b2e39b4af94da4ab99575f4ee08a7ebd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d7fe81405aa82cc7c623629b3419387671370725">d7fe8140</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-03-05T19:29:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Time out attempt to take recovery lock after 120s

Currently this will wait forever.  It really needs a timeout in case
the cluster filesystem (or other lock mechanism) is completely wedged.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13800

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 13a1a4808935290dceb219daccd7aac3fda4e184)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6ac4507654960829469f6dbd11cd729a9521a7e0">6ac45076</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-03-05T19:29:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Force test failure if local daemon setup fails

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13800

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit ce09d9c3e4c72ebec7a21686ae913398a5c9020f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/75fcaea7251ea02bc8cd575e9ec6787e45fe72cd">75fcaea7</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-03-05T19:29:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add -R option for local daemons to use recovery lock command

Under the covers, a command is always used.  However, there is no way
of testing of the code path where a command is explicitly configured.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13800

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit e74f5243fcb7594939769c16f3c79ab167dd1227)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c39430b0ae6218dd987410b045fed65e18f39709">c39430b0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-03-05T19:29:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add a test for configuring the recovery lock as a command

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13800

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit ebc082122fb34ffb8cbcafde9ad39bcc241d33ed)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e0720c16c430693b6eb444131560ff6661a65aba">e0720c16</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-03-05T19:29:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-cluster-mutex: Separate out command and file handling

This code is difficult to read and there really is no common code
between the 2 cases.  For example, there is no need to split a
filename into words.  Separating each of the 2 cases into its own
function makes the logic much easier to understand.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13800

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon Feb 25 03:40:16 CET 2019 on sn-devel-144

(cherry picked from commit c93430fe8fe530a55b9a04cf6cc660c3d420e333)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/07820a3144f24253f9ddb64f40d76a3e80e6535d">07820a31</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-03-05T19:29:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: make a copy of xid's in wb_xids2sids_send()

This is in preparation of setting the result of the mapping in the top-
level callback wb_xids2sids_done(), not in the per-idmap-domain callback
wb_xids2sids_dom_done().

When caching the mapping we need the id-type from the backend, so we
need a way to pass up that information from wb_xids2sids_dom_done() up
to wb_xids2sids_done()

The xids array copy gets passed from wb_xids2sids_send() to
wb_xids2sids_dom_send(), so wb_xids2sids_dom_done() can then directly
update the top-level copy.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13802

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit f5a8bc2f945be45cdade5f70d4f975bae8337f67)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f877231507eae5e68def7fa4948d2b2792c14a0d">f8772315</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-03-05T19:29:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: make xids a const argument to wb_xids2sids_send()

The previous commit made an internal copy of xids, this commit makes it
more obvious that we must not mess with the xids argument but treat it as
an in-parameter and don't write to it.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13802

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 5d277ea7ea258676b9ea5081a451a5874af115f6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/406a1cdff424c407d7e7a33f32941184dadf62dd">406a1cdf</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-03-05T19:29:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: convert id to a pointer in wb_xids2sids_dom_done()

No change in behaviour.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13802

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit f8bf4fc608639695651f75c52b31f95e796a5a26)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e9ffadb2b21c18bbd33c184947288d824d48dec1">e9ffadb2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-03-05T19:29:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: update xid in wb_xids2sids_state->xids with what we got

In preparation of priming the idmap cache in the top-level
wb_xids2sids_done(), not in the per-idmap-domain callback
wb_xids2sids_dom_done().

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13802

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 7f23ef7b2cf7bd6e8dc087aa15137292b421a689)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3577293313ccfbbc85226e1e1f8eeb208d9f9623">35772933</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-03-05T19:29:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: switch send-next/done order

In preparation of adding more logic to the done step. No change in
behaviour.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13802

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 8e9c2a1f6ceb06d695a6572701b96a3e3821ac42)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3b9ef9090a9577a8d081d20532213ca28d29815c">3b9ef909</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-03-05T19:29:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: track whether a result from xid2sid was coming from the cache

This is needed in preparation of moving the step to update the idmap
cache from the per-idmap-domain callback wb_xids2sids_dom_done() to the
top-level callback wb_xids2sids_done().

Currently the sequence of action is:

* check cache, if not found:
  * ask backends
  * cache result from backend
* return results

Iow, if we got something from the cache, we don't write the cache.

The next commit defers updating the cache to the top-level callback, so
the sequence becomes

* check cache, if not found:
  * ask backends
* cache results
* return results

This has two problems:

* it needlessly writes to the cache what we just got from it

* it possibly overwrites the ID_TYPE_BOTH for a SID-to-xid mapping in
  the following case:

  - existing ID_TYPE_BOTH mapping in the cache, eg:

    IDMAP/SID2XID/S-1-5-21-2180672342-2513613279-2566592647-512 -> Value: 3000000:B

  - someone calls wb_xids2sids_send() with xid.id=3000000,xid.type=ID_TYPE_GID

  - cache lookup with idmap_cache_find_gid2sid() succeeds

  - when caching results we'd call idmap_cache_set_sid2unixid() with the
    callers xid.type=ID_TYPE_GID, so idmap_cache_set_sid2unixid() will
    overwrite the SID-to-xid mapping with ID_TYPE_GID

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13802

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 62f54229fced20102e11ad1da02faef45c2a7c2e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ce4c9c40fabd5094fa5c28939897e34bc720b4f8">ce4c9c40</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-03-05T19:29:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: set idmap cache entries as the last step in async wb_xids2sids

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13802

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sat Feb 23 09:23:22 CET 2019 on sn-devel-144

(cherry picked from commit 9b9565c3e69b92c298c7168e516387bb249c9e36)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f765b515814b6b9884e8e563ac4a61c9d34a39b3">f765b515</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-03-05T19:29:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbtorture3: Add POSIX-MKDIR test for posix_mkdir case sensitive bug.

Test does:

mkdir POSIX_foo
mkdir POSIX_Foo
mkdir POSIX_foo/Foo
mkdir POSIX_foo/foo
mkdir POSIX_Foo/Foo
mkdir POSIX_Foo/foo

Which should pass a SMB1 POSIX extensions server
as posix mkdir should always be case sensitive
no matter what the share is set to.

Mark as knownfail for now.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13803

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit f0decb31fff24ceb57d23bebbfb87aa0e5103947)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/230c557e2f741136d418fa227d2dddd26d243b9a">230c557e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-03-05T19:29:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: SMB1-POSIX: Add missing info-level SMB_POSIX_PATH_OPEN for UCF_UNIX_NAME_LOOKUP flag.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13803

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 980db8debde68f9edce13fc01bc45a904379cffd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/179db55a3bb601e400d932955087da0dc6acee17">179db55a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-03-05T19:29:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: unix_convert: Ensure we don't call get_real_filename on POSIX paths.

For posix_pathnames don't blunder into the name_has_wildcard OR
get_real_filename() codepaths as they may be doing case insensitive lookups.
So when creating a new POSIX directory 'Foo' they might
match on name 'foo'.

Remove POSIX-MKDIR from knownfail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13803

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sun Feb 24 14:04:14 CET 2019 on sn-devel-144

(cherry picked from commit 12da33e2bbce657f25abe9bc4cb936ca4615b30f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b58c6f1f8b06847a0e5997ccbf31d1458828afaa">b58c6f1f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-03-05T19:29:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Add additional POSIX mkdir tests.

Ensure that if POSIX_foo exists as a file
we return the correct error code NT_STATUS_OBJECT_PATH_NOT_FOUND
if we try and traverse it as a directory.

Also ensure creation/deletion of POSIX_foo/foo fails
for directories and files with NT_STATUS_OBJECT_PATH_NOT_FOUND
if the directory POSIX_foo/ doesn't exist.

knownfail is back :-).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13803

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 632d0db8c42d50f5eecd002d9573f739cd945960)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c034112280af8d309ba68bcae2473ebae0fa1ef">0c034112</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-03-05T19:29:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: filenames - ensure we replace the missing '/' if we error in an intermediate POSIX path.

Previous regression test ensures we still return the correct
error code for POSIX pathname operations.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13803

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Feb 25 09:33:27 CET 2019 on sn-devel-144

(cherry picked from commit 3f1a13a94a753c5cb3b9f2cf795df5adb0f74205)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0a784f28b466e31c62156a37f5b39c933a06aa2c">0a784f28</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2019-03-05T19:29:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_ceph: add missing fallocate hook

SMB_VFS_FALLOCATE() calls atop a vfs_ceph share currently fall through
to vfs_default, which results in a local filesystem I/O attempt using a
libcephfs file-descriptor. Add the missing fallocate hook to vfs_ceph.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13807

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 5a7e7280813559fb70a9fc8e4238cb6015ee3b53)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3332a895ed1f1f831ed723cec101b25039364f0c">3332a895</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2019-03-05T19:29:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_ceph: fix strict_allocate_ftruncate()

The vfs_ceph "strict allocate = yes" ftruncate wrapper may attempt
*local* filesystem ftruncate(). Fix this.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13807

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 70329c36ed91dd0e50ff66f9b0a85c62ac8a621e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/19b2885de7c0ea8ea720603238a40f1f15e895e0">19b2885d</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2019-03-05T19:29:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_ceph: remove ceph_fallocate/ceph_ftruncate fallback

Both libcephfs functions are supported and capable of extending files,
so fallback can be dropped.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13807

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 155f1289ba7a4802fbb99fbc9ea90d8bc6cff0c9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3fe0c3031e6cc4848e069c7ab916ac79d7f2692c">3fe0c303</a></strong>
<div>
<span>by Denis Cardon</span>
<i>at 2019-03-05T19:29:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">fix samba-tool gpo backup syntax in WHATSNEW.txt

Signed-off-by: Denis Cardon <dcardon@tranquil.it>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a65f7b71a2533b393e4d150fc1d0b07576dd95a0">a65f7b71</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2019-03-05T19:29:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add some detail on the changes to paged results

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/74aa2abf8614a0a5f6352959d4fc5af61cf1df8e">74aa2abf</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-03-05T19:29:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.10.0rc4.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e399a0209f4607ddaaec2ba8f6efd56149495652">e399a020</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-03-05T19:29:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.10.0rc4 release.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9169e9722d65209a4fcb22a63823a813e9690f0f">9169e972</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-03-06T00:34:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.0rc5...

and re-enable GIT_SNAPSHOT.

Signed-off-by: Karolin Seeger <kseeger@samba.org>

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Wed Mar  6 00:34:53 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e80b245bf4af890f275f1cc7409063983a12a78">0e80b245</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-03-06T14:00:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: mention new vfs_glusterfs_fuse module

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Wed Mar  6 14:00:05 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2f4d82146018a6bed6ea447e023fe1949208bbe2">2f4d8214</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-03-11T07:55:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-server: Open and close a transaction on sam.ldb at startup

This fixes upgrading from 4.7 and earlier releases, and makes the DB
reindexing more transparent. It should also make it easier to handle
future normalisation rule changes, e.g. if we change the pack-format
of integer indexes in a future release.

Without this change, the  should have still handled reindexing the
database. We don't know why exactly this wasn't happening correctly,
but opening a transaction early in the samba process startup should
now guarantee that the DB is correctly reindexed by the time the main
samba code runs.

An alternative fix would have been to open a transaction in the the
DSDB module stack every time we connect to the database. However, this
would add an extra write lock every time we open the DB, whereas
starting samba happens much more infrequently.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13760

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Mar  7 04:58:42 UTC 2019 on sn-devel-144

(cherry picked from commit 8b18da27cf261b0283fe66d2b827cab542488ac7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ea33a7b091132f0cf9b1e21464728d2dc1dab99b">ea33a7b0</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-03-11T07:55:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">sambaundoguididx: use the right escaped oder unescaped sam ldb files

the correct filename is taken from the partition database before, we should not
unescape that because this can result in a new unescaped ldb file being created
and the script not to work at all.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13759

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit cd1ac3668cd164bd5f7cadf7b59df9541aaef83e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f85efa76d3bb781fccd72f59c273c6800396206">9f85efa7</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-03-11T07:55:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Split backup/restore testenvs out into separate job

The samba-ad-dc-2 job was reaching its limits with the number of
testenvs and what the resource-limited CI machines can handle.
Samba processes were getting swapped out of memory, causing CI runs
to fail.

This patch splits the backup/restore testenv targets into a separate
autobuild job: samba-ad-dc-backup.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13780

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Feb  5 12:23:31 CET 2019 on sn-devel-144

(cherry picked from commit 95b2c9d7751ae1e5a00e1fb096f045dd73c03d72)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/49bac77e78988bf23c21fe54fe311c92180e4a72">49bac77e</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-03-11T07:55:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Add -py2 tests for new split backup/restore testenvs

This ensures Python2 coverage for this code while it remains supported.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13780

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3b52cba505ac494f64a6b17f7e98abfeca717a80">3b52cba5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-03-11T07:55:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli: remember return code from maximum access

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13812

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
(cherry picked from commit 9f4ee05295827c9a607e1f63694a17906f777176)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ac08949dcdf37645fdb736e17179a20f04c41a39">ac08949d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-03-11T07:55:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: add a Maximum Access check with an Owner Rights ACE

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13812

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
(cherry picked from commit 3ca38d2cd1189a5040e13ddab016063280be2b4d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7e95499d39a5ed69bb9cea6bbf61897eb11c71c1">7e95499d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-03-11T07:55:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/security: add "Owner Rights" calculation to access_check_max_allowed()

This was missing in 44590c1b70c0a24f853c02d5fcdb3c609401e2ca.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13812

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>

Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Thu Feb 28 19:18:16 UTC 2019 on sn-devel-144

(cherry picked from commit 5cf0764bc4b65dbc59d8626760dbe946a2234833)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/63f0db772044862f3fe4fec08de6b888f4865501">63f0db77</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-03-11T07:55:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Fix the test_owner_rights() test to show permissions are additive.

Tested against Windows.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13812

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 2e181e34c48c879235c5dc64bd7ab2b59781810c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3026c1a36c310ab9759a9700fb023e439dd6b335">3026c1a3</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-03-11T07:55:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Add test_owner_rights_deny().

Shows that owner and SID_OWNER_RIGHTS ACE
entries interact in max permissions requests.

Tested against Windows.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13812

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit fadc4c1bc5fcc3b2d9daea44ef8daf8a8ae0fbe2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1dc2e296f1749c3efff8b2e779b0c5e0f50cef34">1dc2e296</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-03-11T07:55:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/security: correct access check and maximum access calculation for Owner Rights ACEs

We basically must process the Owner Rights ACEs as any other ACE wrt to the
order of adding granted permissions and checking denied permissions. According
to MS-DTYP 2.5.3.2 Owner Rights ACEs must be evaluated in the main loop over
the ACEs in an ACL and the corresponding access_mask must be directly applied
to bits_remaining. We currently defer this to after the loop over the ACEs in
ACL, this is wrong.

We just have to do some initial magic to determine if an ACL contains and
Owner Rights ACEs, and in case it doesn't we grant SEC_STD_WRITE_DAC |
SEC_STD_READ_CONTROL at the *beginning*. MS-DTYP:

-- the owner of an object is always granted READ_CONTROL and WRITE_DAC.
CALL SidInToken(Token, SecurityDescriptor.Owner, PrincipalSelfSubst)
IF SidInToken returns True THEN
   IF DACL does not contain ACEs from object owner THEN
       Remove READ_CONTROL and WRITE_DAC from RemainingAccess
       Set GrantedAccess to GrantedAccess or READ_CONTROL or WRITE_OWNER
   END IF
END IF

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13812

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 9722f75757c0e38c7f42c7cc310d56aa6eaf6392)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c9b6b7ed4be46d7b63947a6bbcef1ab72b6bdd68">c9b6b7ed</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-03-11T07:55:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Add test_owner_rights_deny1().

Creates a 3-element ALLOW + ALLOW + DENY ACE showing that when
calculating maximum access already seen allow bits are not removed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13812

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 0ebd8c99aed28a0ba43a22c429837f66f7e94409)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cc7629a20e93408f79a8522f2c482c7258afc18c">cc7629a2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-03-11T07:55:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Add test_deny1().

Creates a 2-element ALLOW + DENY ACE showing that when calculating
effective permissions and maximum access already seen allow bits are not
removed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13812

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit b205d695d769e910a91bec87451dec189ec33740)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d0e2bf81901013f4052094bca180717a5213f16">5d0e2bf8</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-03-11T07:55:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/security: fix handling of deny type ACEs in access_check_max_allowed()

Deny ACEs must always be evaluated against explicitly granted rights
from previous ACEs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13812

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 8d355dd9769e8990ce998b4c9f28977669b43616)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7bd135d25d67c96b92f732bee1d4acad67db241c">7bd135d2</a></strong>
<div>
<span>by Joe Guo</span>
<i>at 2019-03-11T07:55:38Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/scripting/bin: open unicode files with utf8 encoding and write unicode string

In files like `libcli/util/werror_err_table.txt` and `libcli/util/ntstatus_err_table.txt`,
there were unicode quote symbols at line 6:

    ...(“this documentation”)...

In `libcli/util/wscript_build`, it will run `gen_werror.py` and `gen_ntstatus.py`
to `open` above files, read content from them and write to other files.

When encoding not specified, `open` in both python 2/3 will guess encoding from locale.

When locale is not set, it defaults to POSIX or C, and then python will use
encoding `ANSI_X3.4-1968`.

So, on a system locale is not set, `make` will fail with encoding error
for both python 2 and 3:

    File "/home/ubuntu/samba/source4/scripting/bin/gen_werror.py", line 139, in main
        errors = parseErrorDescriptions(input_file, True, transformErrorName)
      File "/home/ubuntu/samba/source4/scripting/bin/gen_error_common.py", line 52, in parseErrorDescriptions
        for line in file_contents:
      File "/usr/lib/python3.5/encodings/ascii.py", line 26, in decode
        return codecs.ascii_decode(input, self.errors)[0]
    UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 318: ordinal not in range(128)

In this case, we have to use `io.open` with `encoding='utf8'`.
However, then we got unicode strs and try to write them with other strs
into new file, which means the new file must also open with utf-8 and
all other strs have to be unicode, too.

Instead of prefix `u` to all strs, a more easier/elegant way is to enable
unicode literals for the python scripts, which we normally didn't do in samba.

Since both `gen_werror.py` and `gen_ntstatus.py` are bin scripts and no
other modules import them, it should be ok for this case.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>

Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Fri Feb  8 06:34:47 CET 2019 on sn-devel-144

(cherry picked from commit 87149445af26b8577566dfe5e311b32e3650c6e6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c2a243d3e74c2c7c82e2ae63010f59f77757aea">5c2a243d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-03-11T11:50:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CI: don't use swap

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Mon Mar  4 13:59:42 UTC 2019 on sn-devel-144

(adapted from from commit 7798bc14fbdae3461eb30421923d53978b3f781d
by Andrew Bartlett)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Mon Mar 11 11:50:37 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/41c1870a8c20e20697feec25b5407381d5f723ca">41c1870a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-03-13T08:34:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Make idmap_cache return negative mappings

Without this we'd query non-existent mappings over and over
again.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813
(cherry picked from commit d9303e8eb90d48f09f2e2e8bdf01f4a7c3c21d11)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1df6720d74b325cf1c2eb61723fbf687b06c1c10">1df6720d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-03-13T08:34:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">idmap_cache: Only touch "sid" on success in find_xid_to_sid

Why? This makes the negative mapping condition (is_null_sid) more
explicit in the code.

The callers in lookup_sid initialized "psid" anyway before, and the ones
in wb_xids2sids now do as well. This is more in line with other APIs we
have: Only touch output parameters if you have something to say.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813
(cherry picked from commit 4faf3e9f6da7515fc263d79f77226d105c2f8524)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/465bd07ff70cacac7bbaac79ce1dddedd917279a">465bd07f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-03-13T08:34:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Initialize "expired" parameter to idmap_cache_xid2sid

The code in idmap_cache only touches its output parameters upon success

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813
(cherry picked from commit 8c28c12702c0935a852c7fed6565987623f09fee)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6434de2b76dcda8ea917e75709d90cd04250b63e">6434de2b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-03-13T08:34:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Now we explicitly track if we got ids from cache

This now properly makes us use negative cache entries

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813
(cherry picked from commit 95d33ca79cc315f1a2e41cd60859ef01d6548c77)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f6f0994a597b76e03d6af8290d2b1845d4320fef">f6f0994a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-03-13T08:34:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">idmap_cache: Introduce idmap_cache_find_xid2sid

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813
(cherry picked from commit bb8122dd8c53bb307819a79b7888cc0940a7c13b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a20e68bcc635e04ff42dfa3a44819dacc1a8c970">a20e68bc</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-03-13T08:34:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Add tests for idmap cache

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813
(cherry picked from commit e5a903bab6eda8f7ff2a7c8149d51022d9d8aede)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ba6dd781d4ae3d6111b16a8c8cd22132ee3e945e">ba6dd781</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-03-13T08:34:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Use idmap_cache_find_xid2sid

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813
(cherry picked from commit bc9824bd42d9370279819ea0d927e236f6041324)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/10a0d77f17caf49ba35f2f23974c9518c2f37c83">10a0d77f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-03-13T08:34:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Introduce winbind_xid_to_sid

This does not merge a winbind communication error into
"global_sid_NULL" (S-1-0-0), which by the way non-intuitively does not
go along with is_null_sid(). Instead, this just touches the output sid
when winbind returned success. This success might well be a negative
mapping indicated by S-0-0, which *is* is_null_sid()...

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813
(cherry picked from commit ef706a3e63b3e25edd27e0f99c3e2d8ff7209cb6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8c0268a5fec09e546b98cc88f8fce28dc4543d36">8c0268a5</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-03-13T08:34:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">passdb: Introduce xid_to_sid

This explicitly avoids the legacy_[ug]id_to_sid calls, which create
long-term cache entries to S-1-22-x-y if anthing fails. We can't do
this, because this will turn temporary winbind communication failures
into long-term problems: A short hickup in winbind_uid_to_sid will
create a mapping to S-1-22-1-uid for a week. It should be up to the
lower layers to do the caching.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813
(cherry picked from commit 92f27ebb14c0c18b1d0fd49544ad851aeb14781c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2021080a41d296e9ba8a648e10a418cfce6200ae">2021080a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-03-13T08:34:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">passdb: Make [ug]id_to_sid use xid_to_sid

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813
(cherry picked from commit 40de67f1fcc46b7a64a7364c91dcedb474826d51)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/545914afefa41708b423299a33730b6f3e46f684">545914af</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-03-13T08:34:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">passdb: Update ABI to 0.27.2

This change is for the backport only. The change in master increased the
ABI version to 0.28.0 and removed some functions; this should not happen
in a backport.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3c32774b9254dc58801d5a734d148eade1223aaf">3c32774b</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-03-13T08:34:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/winbind_util: Move include out of ifdef

This fixes compile errors about missing prototypes with
--picky-developer and --without-winbind

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 4b1e4c22128bdefe549a58b181e9b755854f4c3e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6d901af0f1ca5ffe349f50c72ad33987f009a73f">6d901af0</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-03-13T08:34:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/winbind_util: Add winbind_xid_to_sid for --without-winbind

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13813

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Mar  6 01:53:16 UTC 2019 on sn-devel-144

(cherry picked from commit 4125ff89e44a3e98882cfc38c06e559a6e1e56a5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/00ea6a7d24ed7f6fbbc585a73755070f38d07a2a">00ea6a7d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-03-13T12:15:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Move debug message for mkdir failing to log level 1

If you connnect to a host with smbclient this gets always printed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13823

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

(cherry picked from commit c71334ec0c92e791022a9b7c900aa0dd649226c2)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Wed Mar 13 12:15:10 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5da71ca11d4369b611d5421ea50908fbb7fdd8c1">5da71ca1</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-03-19T09:54:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.10.0.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/983bcc352cb6d4f894e4b0b3cc90fde48b8a443b">983bcc35</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-03-19T09:55:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.0.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/25f2fe02a615e2cf906b6fa495acd8ea0aa9998a">25f2fe02</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-03-19T09:57:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.10.0 release.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3170d75b5f110259383244fb4a4cb0474302f5e3">3170d75b</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-03-19T09:57:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.1...

and re-enable GIT_SNAPSHOT.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5b2a3764d4ef3ea3f1c61b2ffeda54a4555a0de2">5b2a3764</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-03-22T05:43:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">New upstream version 4.10.0+dfsg</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/444b318380999e986c79436d8cbf49adfdb3767d">444b3183</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-03-22T05:44:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update upstream source from tag 'upstream/4.10.0+dfsg'

Update to upstream version '4.10.0+dfsg'
with Debian dir 1539f54b7577ebc9fbf0e479b7e750334d822f49</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e2e9f176b7fdf16f4a0c1acbaed5d661c8118c5">4e2e9f17</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-03-22T05:58:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update patches
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1b209f95a61a811e7765d66cecfd58d138e30aa2">1b209f95</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-03-22T06:02:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Drop nsswitch-Add-try_authtok-option-to-pam_winbind.patch, merged
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5695ad2a00afcec699ca261bc2bd2f58b125c338">5695ad2a</a></strong>
<div>
<span>by Jelmer Vernooij</span>
<i>at 2019-03-22T06:02:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Always specify rpath for private libraries

Last-Update: 2012-02-24
Applied-Upstream: no
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c3a22dce698c4afb5571445f74b70d7809318278">c3a22dce</a></strong>
<div>
<span>by Christian Perrier</span>
<i>at 2019-03-22T06:02:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">64 bit fix for libsmbclient

Bug-Debian: http://bugs.debian.org/221618
Forwarded: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=221618#27
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3116fb8871bcf2d546800b10cded0f84c298ea75">3116fb88</a></strong>
<div>
<span>by Christian Perrier</span>
<i>at 2019-03-22T06:02:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Mention smbldap-tools package in examples/LDAP/README

Bug-Debian: http://bugs.debian.org/341934
Forwarded: not-needed
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/43318471839eabb5d01596d1f8b5a230a22a3a0e">43318471</a></strong>
<div>
<span>by Steve Langasek</span>
<i>at 2019-03-22T06:02:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Use the pager alternative as pager is PAGER is undefined

Bug-Debian: http://bugs.debian.org/135603
Forwarded: not-needed
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f9f142708b501bd55e4426ec1e75a0e0e86fe81">9f9f1427</a></strong>
<div>
<span>by mathiaz@ubuntu.com</span>
<i>at 2019-03-22T06:02:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Enable net usershares by default at build time

Enable net usershares by default at build time, with a limit of 100, and update
the corresponding documentation.

Bug-Debian: http://bugs.debian.org/443230
Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/128548
Forwarded: not-needed
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/194f18bc8ba27d2d6942aba31970851052b3ce0e">194f18bc</a></strong>
<div>
<span>by Eloy A. Paris</span>
<i>at 2019-03-22T06:02:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add "Debian" as vendor suffix

Forwarded: not-needed
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a7cc5255c447233558718f931264985aab1e5629">a7cc5255</a></strong>
<div>
<span>by Jeroen Dekkers</span>
<i>at 2019-03-22T06:02:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add so version number to private libraries for dpkg-shlibdeps

We also want dpkg-shlibdeps to generate correct dependency information
for the private libraries in our binary packages, but dpkg-shlibdeps
only works when the library has a version number.

Origin: vendor
Forwarded: not-needed
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8fbdb162d5593e066ba1a2d7c1b0d4cc180da74d">8fbdb162</a></strong>
<div>
<span>by Brian May</span>
<i>at 2019-03-22T06:02:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Patch in symbol table from rfc3454, for Heimdal scripts

Status: cherry-picked from heimdal package
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ac1215b015cf772cd02541bc4da2c203c7037146">ac1215b0</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-03-22T06:02:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd.service: Run update-apparmor-samba-profile before start

Bug-Debian: https://bugs.debian.org/896080
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/56b65385f4eeb6371da2afd7775e942e8c54eead">56b65385</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-03-22T06:58:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Changelog for previous commits
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2b30986174d721796b40aaedb3b9eda1b25af778">2b309861</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-03-22T08:14:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-build: use a fixed ctdb_version.h using SAMBA_VERSION_STRING

This way we don't get constant rebuild as SAMBA_VERSION_STRING
is "4.7.0pre1.DEVELOPERBUILD" for the binaries under bin/
instead of "4.7.0pre1.GIT.59e51f6".

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13789

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 05c28fee21c0cc986cb8301f4199595cdb13faee)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6401d80956630c58ff6941858b382cabfed48ab2">6401d809</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-03-22T08:14:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-build: Drop creation of .distversion in tarball

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13789

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 148306674d0e4706adca3e5dcbb779c51a2c03da)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f515f1a5486b04521a919e2962a0d288bbc08abc">f515f1a5</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-03-22T08:14:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-version: Simplify version string usage

There is no need to write SAMBA_VERSION_STRING as CTDB_VERSION_STRING.
Wherever required use SAMBA_VERSION_STRING directly.

Avoids the confusion with two version.h files.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13789

Signed-off-by: Amitay Isaacs <amitay@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Mar 15 06:31:50 UTC 2019 on sn-devel-144

(cherry picked from commit edd4a23d7632af51f4d7b4287917b7fa0dced963)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5f1d98c233e968c1495fe222d8bbc9d035b6bb73">5f1d98c2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-03-22T08:14:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndr_spoolss_buf: fix out of scope use of stack variable in NDR_SPOOLSS_PUSH_ENUM_OUT()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13818

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit 6da3664f8a11397fd3fb38e89c2432b8bf321e59)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4cafdc7f2eb810b34159642d988d23ed76762070">4cafdc7f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-03-22T08:14:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Build cluster mutex path manually

CTDB_CLUSTER_MUTEX_HELPER can't be depended on because it is only set
when the tests are not installed and setting it unconditionally for
this particular use would be wrong.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13800

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@samba.org>
(cherry picked from commit a215d2017f95974913a7e97c25e5fc613bb79c26)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d3ed17e74e7a24edbd7fc0f34ebd3221fe4e09f5">d3ed17e7</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-03-22T08:14:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:script: Fix jobid check in test_smbspool.sh

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13832

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bryan Mason <bmason@redhat.com>
Signed-off-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit fad5e4eaeb9202c1b63c42ea09254c17c473e33a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/18515064c9bc91259fb56c5efef42855d32a8bf8">18515064</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-03-22T08:14:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:client: Pass DEVICE_URI and AUTH_INFO_REQUIRED env to smbspool

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13832

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bryan Mason <bmason@redhat.com>
Signed-off-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 43160184d254a57f87bb2adeba47f48d8539533a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0db9487434a27da6cce956a7a6b68e4d00093b9d">0db94874</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-03-22T08:14:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:client: Evaluate the AUTH_INFO_REQUIRED variable set by cups

This should not switch to username,password if cups has been configured
to use negotiate (Kerberos authentication).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13832

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bryan Mason <bmason@redhat.com>
Signed-off-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 5274b09fbaa5e45cc58f3301818d4e9f6a402845)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c6f1719b5e25984afc3168bdcd8efdb301108afd">c6f1719b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-03-22T08:14:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:client: Make sure we work on a copy of the title

We can't be sure we can write to the input buffer.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13832

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bryan Mason <bmason@redhat.com>
Signed-off-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 129ae27946318a075e99c9e6d1bacf8963f72282)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/84aad2ea7d53d8d7645bbd9e4c9ce6b09f6016c5">84aad2ea</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-03-22T08:14:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:client: Fix smbspool device uri handling

If we are executed as a CUPS backend, argv[0] is set to the device uri.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13832

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bryan Mason <bmason@redhat.com>
Signed-off-by: Guenther Deschner <gd@samba.org>

(cherry picked from commit 69d7a496d3bf52eaa10e81132bb61430863fdd8a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/755f624e2bbca22da44b9b9352aa095bc3603db3">755f624e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-03-22T08:14:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-packaging: ctdb package should not own system library directory

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13838

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@samba.org>
(cherry picked from commit b2b8dce4fc56c27ef0131104b316346565369dd7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fc4e3273316e252585fcd0119e84780d4ff704dc">fc4e3273</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-03-22T08:14:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-packaging: Test package requires tcpdump

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13838

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@samba.org>
(cherry picked from commit 957c38b65ca060eabe1e676f8dfb54839d706155)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/909cecd3606c0811bd91a631569441681f05e568">909cecd3</a></strong>
<div>
<span>by Zhu Shangzhong</span>
<i>at 2019-03-22T08:14:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Initialize addr struct to zero before reparsing as IPV4

Failed to kill the tcp connection that using IPv4-mapped IPv6 address
(e.g. ctdb_killtcp eth0 ::ffff:192.168.200.44:2049
::ffff:192.168.200.45:863).

When the ctdb_killtcp is used to kill the tcp connection, the IPs and
ports in the connection will be parsed to conn.client and conn.server
(call stack: main->ctdb_sock_addr_from_string->ip_from_string). In
the ip_from_string, as we are using IPv4-mapped IPv6 addresses, the
ipv6_from_string will be used to parse ip to addr.ip6 first. The next
step the ipv4_from_string will be used to reparse ip to addr.ip.

As a result, the data that dump from conn.server is "2 0 8 1 192 168
200 44 0 0 0 0 0 0 0 0 0 0 255 255 192 168 200 44 0 0 0 0", the data
from conn.client is "2 0 3 95 192 168 200 45 0 0 0 0 0 0 0 0 0 0 255 255
192 168 200 45 0 0 0 0". The connection will be add to conn_list by
ctdb_connection_list_add. Then the reset_connections_send uses conn_list
as parameter to start to reset connections in the conn_list.

In the reset_connections_send, the database "connections" will be
created. The connections from conn_list will be written to the
database(call db_hash_add), and use the data that dump from conn_client
and conn_server as key.

In the reset_connections_capture_tcp_handler, the
ctdb_sys_read_tcp_packet will receive data on the raw socket. And
extract the IPs and ports from the tcp packet. when extracting IP and
port, the tcp4_extract OR tcp6_extract will be used. Then we got the
new conn.client and conn.server. the data that dump from the
conn.server is "2 0 8 1 192 168 200 44 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0", the data from conn.client is "2 0 3 95 192 168 200 45 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0". Finally, we use the data as key to check
if this connection is one being reset(call db_hash_delete). The
db_hash_delete will return ENOENT. Because the two key that being used
by db_hash_delete and db_hash_add are different.

So, the TCP RST will be NOT sent for the connection forever. We should
initialize addr struct to zero before reparsing as IPV4 in the
ip_from_string.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13839

Signed-off-by: Zhu Shangzhong <zhu.shangzhong@zte.com.cn>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@samba.org>
(cherry picked from commit 539b5ff32b32b7c75dfaaa119e41f5af6ff1e6fc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/eb63275483035550ac7760d83fbbdef357f3860b">eb632754</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-03-22T08:14:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add some testing for IPv4-mapped IPv6 address parsing

ctdb_sock_addr values are hashed in some contexts.  This means that
all of the memory used for the ctdb_sock_addr should be consistent
regardless of how parsing is done.  The first 2 cases are just sanity
checks but the 3rd case involving an IPv4-mapped IPv6 address is the
real target of this test addition.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13839

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@samba.org>
(cherry picked from commit d9286701cd9253bf3b42cac3d850ae8c23743e6d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f6df8d976866cad14da492d6f581c9fdeb0c82b3">f6df8d97</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-03-22T08:14:08Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:librpc: Fix installation of Samba

This breaks installation of Samba 4.10 on Fedora.

https://bugzilla.samba.org/show_bug.cgi?id=13847

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>

(cherry picked from commit bf469343f577e2d78df0e38d80e7976b351eaf0d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c8e8d97959dd5f3ae9ac7556ee0282baec861326">c8e8d979</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-03-22T12:50:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Fix the debug message for adding cache entries.

To get correct values, we need to cast 'timeout' to 'long int' first in
order to do calculation in that integer space! Calculations are don in
the space of the lvalue!

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13848

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 5822449a7340f53987ce4c04851652427f5b49e8)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Fri Mar 22 12:50:24 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/084d2f1bc4fb5ee82706bb2960ba9ab20e2c4e87">084d2f1b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-04-02T09:10:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Use C99 initializer for poptOption in smbstatus

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit 83d25ca9d90897925a4431dd55e68c78244900b3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b866bdbe4fa80a17887701ac62c1b955973c9145">b866bdbe</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-04-02T09:10:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Add 'smbstatus -L --resolve-uids' to show usernames

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13793

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit ffad76ae260ac33926db87c61aede5b66d9b09e6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/79d3de4de41f6cce09917f071057d54cfaa28a40">79d3de4d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-04-02T09:10:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add smbstatus to testhelper

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13793

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 6106b8a053e06699c332fd1a6d7636f550422cc7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a21e9754c74c92d47ce805c0b747a9da2c043cec">a21e9754</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-04-02T09:10:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:tests: Add test for smbstatus and smbstatus --resolve_uids

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13793

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Mar 27 14:33:35 UTC 2019 on sn-devel-144

(cherry picked from commit 2e7f4b1d3701b9da32e03dcee1095711945f22b8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2d4820f0a8eb480f02576bed167da230f0e3824a">2d4820f0</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-04-02T09:10:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:waf: Fix the detection of makdev() macro on Linux

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13853

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit eace58b539a382c61edd7c2be6fdfab31114719f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/18f4167198a666876dace140c33bb19f3eeacb9e">18f41671</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-02T09:10:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: force running with TZ=UTC

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Feb 27 11:24:59 UTC 2019 on sn-devel-144

(cherry picked from commit 4f307f2302b0fe8fd0fc6379eb8e6491faf8520c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8d1241dac6bdfec953f3778ff006c85add85bd2b">8d1241da</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-02T09:10:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">blackbox/*.sh: pass -u to 'diff'

This is what we work with every day...

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 8ba6f1c895ee9b6b592578f21e7f79ed36236bef)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4fc1780408803ca77b4c5544b7e0503a7f4aba6d">4fc17804</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-02T09:10:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">blackbox/dbcheck-links.sh: reproduce lost deleted object problem

When a parent object is removed during the tombstone garbage collection
before a child object and samba-tool dbcheck runs at the same time, the
following can happen:

- If the object child had DISALLOW_MOVE_ON_DELETE in systemFlags,
  samba-tool dbcheck moves the object under the LostAndFound[Config]
  object (as an originating update!)
- The lastKnownParent attribute is removed (as an originating update!)

These originating updates cause the object to have an extended time
as tombstone. And these changes are replicated to other DCs,
which very likely already removed the object completely!

This means the destination DC of replication has no chance to handle
the object it gets from the source DC with just 2 attributes (name, lastKnownParent).

The destination logs something like:

  No objectClass found in replPropertyMetaData

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 5357f591accffbf8c62335c308b985811b66f0b5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3e539f756ac0d59e5b62ae752ec825900903fc10">3e539f75</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-02T09:10:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb:repl_meta_data: allow CONTROL_DBCHECK_FIX_LINK_DN_NAME to by pass rename

We need a way to rename an object without updating the replication meta
data.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 3e8a435d27da899d0e3dab7cbc0a1c738067eba3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8736fb5eb4e4bf2afcd52451f5250a47e515201c">8736fb5e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-02T09:10:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: use DSDB_CONTROL_DBCHECK_FIX_LINK_DN_NAME when renaming deleted objects

We should never do originating updates on deleted objects.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 07a8326746f0c444eedf3860b178fc29d84e8d16)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/95f5b9f246a46e5233108251a4122809aa0f1220">95f5b9f2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-02T09:10:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: do isDeleted, systemFlags and replPropertyMetaData detection first

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 9afcd5331ce567bd80d35175f8e4e21c506e9347)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c2f7224e075538fc0fd70e4405cafc82f037909">0c2f7224</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-02T09:10:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: don't move already deleted objects to LostAndFound

This would typically happen when the garbage collection
removed a parent object before a child object (both with
the DISALLOW_MOVE_ON_DELETE bit set in systemFlags),
while dbcheck is running at the same time as the garbage collection.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 6d50ee74920c39cdb18b427bfaaf200775bf2d73)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a47b27b2c96a7823f5283b3a523c8eed71653e02">a47b27b2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-02T09:10:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: don't remove dangling one-way links on already deleted objects

This would typically happen when the garbage collection
removed a parent object before a child object (both with
the DISALLOW_MOVE_ON_DELETE bit set in systemFlags),
while dbcheck is running at the same time as the garbage collection.
In this case the lastKnownParent attributes points a non existing
object.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit e388e599495b6d7c38b8b6966332e27f8b958783)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/caf0caba4e42657abd8f908d7fb201fa20726cb1">caf0caba</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-02T09:10:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: add find_repl_attid() helper function

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 598e38d2a5e0832429ba65b4e55bf7127618f894)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4f0b554b9552a326fe07a69fdd98aa8e5c826e79">4f0b554b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-02T09:10:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">blackbox/dbcheck-links.sh: add regression test for lost deleted object repair

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 1ccc21a34d295be3bb2ab481a5918003eae88bf4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/89fb9d0a81bbb736f74e2cc19c578ae2028f7d09">89fb9d0a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-02T09:10:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: detect the change after deletion bug

Old versions of 'samba-tool dbcheck' could reanimate
deleted objects, when running at the same time as the
tombstone garbage collection.

When the (deleted) parent of a deleted object
(with the DISALLOW_MOVE_ON_DELETE bit in systemFlags),
is removed before the object itself, dbcheck moved
it in the LostAndFound[Config] subtree of the partition
as an originating change. That means that the object
will be in tombstone state again for 180 days on the local
DC. And other DCs fail to replicate the object as
it's already removed completely there and the replication
only gives the name and lastKnownParent attributes, because
all other attributes should already be known to the other DC.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit a1658b306d85452407388b91a745078c9c1f7dc7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/178fad24f2c59f10ba07aa23182e586bf4461fa0">178fad24</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-02T09:10:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd: provide SUPPRESS_HELP via Option class

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit b61d580fb7dba8ff94e9e98c958e324865cd2f1d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b292ef1d9f6c3e7006a7b47e9c836c745cb825db">b292ef1d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-02T09:10:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: add --selftest-check-expired-tombstones cmdline option

This will be used by dbcheck tests which operate on static/old provision
dumps in the following commits.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 6f9c5ed8de47bb98e21e8064d8e90f963f2f71ca)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/40b6af9c000db6c83dbd44a78911e24b08344170">40b6af9c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-02T09:10:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">blackbox/dbcheck*.sh: pass --selftest-check-expired-tombstones to dbcheck

These tests operate on provision dumps created long ago, they still
want to run tests on deleted objects, when the next commits remove
processing expired tombstone objects in dbcheck.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 5fccc4e9044d2e57be33471f5e6b9be7cc37ac3a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4b658a5a396bf88cad6948bb83819ea32de3daab">4b658a5a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-02T09:10:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">blackbox/dbcheck-links.sh: prepare regression test for skipping expired tombstones

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit b096a3117ed9249fd6f65f3221a26c88efbba3b8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6602a77b649faae38cce43b98f5f142120916597">6602a77b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-02T09:10:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: don't check expired tombstone objects by default anymore

These will be removed anyway and any change on them risks to
be an originating update that causes replication problems.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Mar 14 03:12:27 UTC 2019 on sn-devel-144

(cherry picked from commit a2c5f8cf41c2dfdc4f122e8427d1dfeabb6ba311)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/10a390e89753bc2180a9326cd142763dedc55825">10a390e8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-02T09:10:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: use the str() value of the "name" attribute

We do the same with the rdn attribute value
and we need the same logic on both in order to
check they are the same.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
(cherry picked from commit dd6f0dad218ec1d5aa38ea8aa6848ec81035cb3f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/286b80cb7a3b7da8bb381786521931c14fed3383">286b80cb</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2019-04-02T09:10:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: cmocka test for empty attributes bug

Cmocka test exposing LDB bug where a request with an empty attributes
list returns a response containing all attributes.  The bug is in the
ACL module and will be fixed in the next commit.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13836

Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 24efa3ca5399d5cf538c3be504014a954685f1ed)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/868356cf36566636cfce5ee28c1a38055dd38ce8">868356cf</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2019-04-02T09:10:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">acl_read: Fix regression caused by db15fcfa899e1fe4d6994f68ceb299921b8aa6f1 for empty lists

The original code never dereferenced attrs and only added "*" if attrs
was NULL (not if attrs[0] was NULL).

This causes significant performance issues with the new paged_results
module introduced for 4.10 as the initial GUID search requests no
attributes. This GUID search turns into a search for "*" and ends up
allocating memory for the entire database.

This never appears to cause changes in the final result set, only
intermediate processing.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13836

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Mar 29 18:37:29 UTC 2019 on sn-devel-144

(cherry picked from commit a2b1970a37836e46d6c9eb6bda9bd20185de96ce)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/75b6e02a8e62dc65d4dfbf3be1e7a15329c08b80">75b6e02a</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-04-02T09:10:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py/graph: use 2.6 compatible check for set membership

It is better this way anyway.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13837
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Mar 20 06:36:05 UTC 2019 on sn-devel-144

(cherry picked from commit c0aca17a4c9ec06f0127d5c972f3fa979a87a77f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b8398ecbbd8abafd7621b5e334bced7b3216e41">9b8398ec</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-04-02T09:10:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py/kcc_utils: py2.6 compatibility

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13837
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f52ebe258ba5566e52cd6180343d0847c69cac04">f52ebe25</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-04-02T09:10:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py/uptodateness: use 2.6 compatible dictionary construction

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13837
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/76b38e19d3c922662fc3a4df6e334243ada8a9e0">76b38e19</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-04-02T09:10:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py/logger: use python 2.6 compatible arguments

In 2.6 stream is a positional argument; 2.7+ it is also a keyword
argument.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13837
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3f278c3f91101dfc46057d5da499dad6d65f3e22">3f278c3f</a></strong>
<div>
<span>by Michael Hanselmann</span>
<i>at 2019-04-02T09:10:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix typos in "valid"

s/vald/valid/

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13840

Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 305346d360d3c13fd315c1af27b037f46fd10650)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cfffac0fc9f1e6b40ad9bb18b12590ba1e6eabda">cfffac0f</a></strong>
<div>
<span>by Michael Hanselmann</span>
<i>at 2019-04-02T09:10:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">regfio: Use correct function names in debug information

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13840

Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit aa6b355858a0d8b77bf49384e5329642add1a5ff)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf6a85178205b777274136cd2c2ace62a8f1a17d">bf6a8517</a></strong>
<div>
<span>by Michael Hanselmann</span>
<i>at 2019-04-02T09:10:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">regfio: Add trivial unit test

An upcoming commit will resolve two cases of insufficient handling of
mangled registry hive files and will include unit tests.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13840

Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 9b2cb845b23cd1c91ab3b5ea8ad791b18b3ab733)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d4ef858ec112149f5ab5504d6367aa60d52446f5">d4ef858e</a></strong>
<div>
<span>by Michael Hanselmann</span>
<i>at 2019-04-02T09:10:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">regfio: Improve handling of malformed registry hive files

* next_record: A malformed file can lead to an endless loop.
* regfio_rootkey: Supplying a malformed registry hive file to the
  registry hive I/O code can lead to out-of-bounds reads.

Test cases are included. Both issues resolved have been identified using
AddressSanitizer.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13840

Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 601afd690346087fbd53819dba9b1afa81560064)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/722c5b3254818ae3a033de0d702196795f47d7e9">722c5b32</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-04-02T09:10:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">regfio: Update code near recent changes to match README.Coding

This file long predates our current code conventions.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13840

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit acbf103fcaa4150a57bfbab2450e36b5b39e399b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78b72ff339da26769ec8b5915eb145bdaeea42fb">78b72ff3</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-04-02T09:10:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">regfio tests: Update comment style to match README.Coding

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13840

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit 68c0fc4335d0c3c526a38481538a33290be6d58a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7921aa6365ba8128f47dfa136a1f7945feec6c6f">7921aa63</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2019-04-02T09:10:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dlz: Add test to ensure there are writable zones

This is currently broken since 28e2a518ff32

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13841

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 6c62e05466917d9454d67eb2dd77e303e612c8a9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0e94b0a3144385e551d25ecb55cda2cb51fe398f">0e94b0a3</a></strong>
<div>
<span>by Michael Saxl</span>
<i>at 2019-04-02T09:10:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:dlz make b9_has_soa check dc=@ node

the zone node does not hold the dnsRecord values, so for the zone level
the node dc=@,dc=zonename has to be queried

regression introduced with 28e2a518ff32, BUG: https://bugzilla.samba.org/show_bug.cgi?id=13466

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13841

Signed-off-by: Michael Saxl <mike@mwsys.mine.bz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 526c6d0be53d97beb38f82a3619d8710fefb4091)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e769bd6608951e80bcc3fac7b4808194f22bbd36">e769bd66</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2019-04-02T09:10:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/messaging: Fix undefined reference in linking libMESSAGING-samba4.so

Early check for DEVELOPER or ENABLE_SELFTEST configure options inside
messaging_handlers.c leaves us with the following undefined reference
linkage error:

[1315/3712] Linking bin/default/source4/lib/messaging/libMESSAGING-samba4.so
/usr/bin/ld: source4/lib/messaging/messaging.c.4.o: in function
                                                `imessaging_init_internal':
/root/samba.git/bin/default/../../source4/lib/messaging/messaging.c:472:
                undefined reference to `imessaging_register_extra_handlers'
collect2: error: ld returned 1 exit status

This happened due to failure in including "includes.h" before checking
the above mentioned configure options.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13854

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 08ba013a2b8b2cf9fc17fdcb3d107e1434709036)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/815be52b60026f9101a66ed8b276a581ec83df7d">815be52b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-04-02T09:10:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Make fd_load work for non-regular files

Follow-up to

https://lists.samba.org/archive/samba/2018-September/217992.html

and following. This also fixes a small and very theoretical race: Between the
fstat and the read call the file size might change. This would make us fail on
potentially legitimate files.

This is more complex and probably slower, but looking at the use cases I don't
think the speed matters.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13859

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Mar 26 04:43:40 UTC 2019 on sn-devel-144

(cherry picked from commit ac487bf4d04c9771ada1ca7eeb9dac4e5fe34185)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/af05bf7911eed71315843c5333cc5bb6b6a06ec3">af05bf79</a></strong>
<div>
<span>by Philipp Gesang</span>
<i>at 2019-04-02T13:52:01Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli: permit larger values of DataLength in SMB2_ENCRYPTION_CAPABILITIES of negotiate response

Certain Netapp versions are sending SMB2_ENCRYPTION_CAPABILITIES
structures containing DataLength field that includes the padding
[0]. Microsoft has since clarified that only values smaller than
the size are considered invalid [1].

While parsing the NegotiateContext it is ensured that DataLength
does not exceed the message bounds. Also, the value is not
actually used anywhere outside the validation. Thus values
greater than the actual data size are safe to use. This patch
makes Samba fail only on values that are too small for the (fixed
size) payload.

[0] https://lists.samba.org/archive/samba/2019-February/221139.html
[1] https://lists.samba.org/archive/cifs-protocol/2019-March/003210.html

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13869

Signed-off-by: Philipp Gesang <philipp.gesang@intra2net.com>
Reviewed-by: Ralph Böhme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sun Mar 31 01:11:09 UTC 2019 on sn-devel-144

(cherry picked from commit 865b7b0c7d2ba7fa0a045586d1e83a72028a0864)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Tue Apr  2 13:52:02 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/17f3d535c71d76345574a4559eda8e5566e97a54">17f3d535</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-04-03T08:31:06Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.10.1.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e0cc225f8a4e15ea7cef4ed2597eeec3790f2f4d">e0cc225f</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-04-03T08:32:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.10.1 release.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/61c4d715a7382047a9a97165256866fe39ebad26">61c4d715</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-04-03T08:33:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.2...

and re-enable GIT_SNAPSHOT.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/16fa173a144674a8d1d5b5f143bf95939f4f1903">16fa173a</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-04-05T08:13:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.2...

and re-enable GIT_SNAPSHOT.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
(cherry picked from commit 61c4d715a7382047a9a97165256866fe39ebad26)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c25ee5bd463d2d433a1b0a868e5d63e3490bc7fd">c25ee5bd</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-04-05T08:14:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-3870 tests: Extend smbd tests to check for umask being overwritten

The smbd changes the umask - if the code fails to restore the umask to
what it was, then this is very bad. Add an extra check to every
smbd-related test that the umask at the end of the test is the same as
what it was at the beginning (i.e. if the smbd code changed the umask
then it correctly restored the value afterwards).

As the selftest sets the umask for all tests to zero, it makes it hard
to detect this problem, so the test setUp() needs to set it to something
else first.

This extra checking is added to the setUp()/tearDown() so that it
applies to all test-cases. However, any failure that occur with this
approach will not be able to be known-failed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13834

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0b712415db68dd5f0a082c036ba051f2b857aa2a">0b712415</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-04-05T08:14:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-3870 tests: Add test to check file-permissions are correct after provision

This provisions a new DC and checks there are no world-writable
files in the new DC's private directory.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13834

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ebb9b7fa9ead90906ff71fed68c30d093ab9c15a">ebb9b7fa</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-04-05T08:14:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-3870 pysmbd: Include tests to show the outside umask has no impact

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13834

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a4029b5d3be1f42da49d4e635f4637f76f01a22">9a4029b5</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-04-05T08:14:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-3870 pysmbd: Move umask manipuations as close as possible to users

Umask manipulation was added to pysmbd with e146fe5ef96c1522175a8e81db15d1e8879e5652 in 2012
and init_files_struct was split out in 747c3f1fb379bb68cc7479501b85741493c05812 in 2018 for
Samba 4.9. (It was added to assist the smbd.create_file() routine used in the backup and
restore tools, which needed to write files with full metadata).

This in turn avoids leaving init_files_struct() without resetting the umask to
the original, saved, value.

Per umask(2) this is required before open() and mkdir() system calls (along
side other file-like things such as those for Unix domain socks and FIFOs etc).

Therefore for safety and clarify the additional 'belt and braces' umask
manipuations elsewhere are removed.

mkdir() will be protected by a umask() bracket, for correctness, in the next patch.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13834

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8e0a6867c4e3480c0269c87821b54f1451656ae7">8e0a6867</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-04-05T08:14:36Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-3870 pysmbd: Ensure a zero umask is set for smbd.mkdir()

mkdir() is the other call that requires a umask of 0 in Samba.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13834

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/67c837789f321c42230bfc3592652ce858f68da1">67c83778</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-04-05T08:15:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-3880 s3: rpc: winreg: Remove implementations of SaveKey/RestoreKey.

The were not using VFS backend calls and could only work
locally, and were unsafe against symlink races and other
security issues.

If the incoming handle is valid, return WERR_BAD_PATHNAME.

[MS-RRP] states "The format of the file name is implementation-specific"
so ensure we don't allow this.

As reported by Michael Hanselmann.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13851

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/619d39538fa9453574a408f858d9168d152839de">619d3953</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-04-05T08:18:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.10.2.

CVE-2019-3870 (World writable files in Samba AD DC private/ dir)
CVE-2019-3880 (Save registry file outside share as unprivileged user)

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/17cd92e1c3672c4ffde7ca94546f57907d22262b">17cd92e1</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-04-05T08:35:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for 4.10.2 release.

CVE-2019-3870 (World writable files in Samba AD DC private/ dir)
CVE-2019-3880 (Save registry file outside share as unprivileged user)

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ebf34098fa30daac7cbae5c863e02d786c8c35b2">ebf34098</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-04-08T10:30:18Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge tag 'samba-4.10.2' into v4-10-test

samba: tag release samba-4.10.2
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cf323d769f0f75a8201b21e5563fc5481beb614e">cf323d76</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-04-08T10:30:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.3.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/54571d3325fbdf4eff5f2f5d8c38bfd929f48b19">54571d33</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-04-10T11:02:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Update smbclient manpage for --max-protocol

We default to SMB3 now.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13857

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 63084375e3c536f22f65e7b7796d114fa8c804c9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ada3417c5cb3b40f47ca963c8d7844f9fadc81f0">ada3417c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-04-10T11:02:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Print more information when LDAP fails

Currently we just get an error but don't know what exactly we tried to
do in 'net ads join -d10'.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13861

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 40669e3739eb5cde135c371e2c8134d3f11a16a5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/461090e0a12b0f9849d19da7b76f214fe044cfdf">461090e0</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-04-10T11:02:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: Add some useful debug output to cliconnect

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13861

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 011a47f04dabe22095a30d284662d8ca50463ee8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2e96408eac8e5e9d8420b3dc0c603fa7109519bd">2e96408e</a></strong>
<div>
<span>by Guenther Deschner</span>
<i>at 2019-04-10T11:02:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet: Fix debug message in libnet_DomainJoin()

A newline is missing but also use DBG_INFO macro and cleanup spelling.

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 3a33c360071bb7cada58f1f71ccd8949fda70662)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0b00c7a2d0aa4607bc871f7daad23f7d3b9125f0">0b00c7a2</a></strong>
<div>
<span>by Guenther Deschner</span>
<i>at 2019-04-10T11:02:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth:ntlmssp: Add back CRAP ndr debug output

This got lost somehow during refactoring. This is still viable
information when trying to figure out what is going wrong when
authenticating a user over NTLMSSP.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13861

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 9e92654899db3c951bee0203415a15737402e7b7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/936594d66b75c71ec61c11b4e4484a74a5a694d7">936594d6</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-04-10T11:02:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth:creds: Prefer the principal over DOMAIN/username when using NTLM

If we want to authenticate using -Wadmin@otherdomain the DC should do
take care of the authentication with the right DC for us.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13861

Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 5c7f0a6902cfdd698e5f4159d37537bb4c9c1cc3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bd573b37c606ae12e34992431e745329cee3e1f2">bd573b37</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-04-10T11:02:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet: Use more secure name for the JOIN krb5.conf

Currently we create krb5.conf..JOIN, use krb5.conf._JOIN_ instead.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13861

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit b7f0c64514a28cfb5d2cdee683c18943b97ea753)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/78f308084f5d762be88374adf784c0ac6d0ad847">78f30808</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-04-10T11:02:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Make sure we can lookup KDCs which are not configured

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13861

Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit c016afc832543514ebf7ecda1fbe6b272ea533d6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/837a141a4d9cebfe0ce29bf3673333ca622fcd24">837a141a</a></strong>
<div>
<span>by Guenther Deschner</span>
<i>at 2019-04-10T11:02:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:ldap: Leave add machine code early for pre-existing accounts

This avoids numerous LDAP constraint violation errors when we try to
re-precreate an already existing machine account.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13861

Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 2044ca0e20bd3180720a82506b3af041d14b5c68)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/05709dbaf2d80f4c2d8a8931655e63b20e216c2a">05709dba</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-04-10T11:02:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-libnet_join: always pass down admin domain to ads layer

Otherwise we could loose the information that a non-default domain name
has been used for admin creds.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13861

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit ea29aa27cbac4253ee1701fed99a3e0811f7475d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f85efe206f9b192a7365ec7ada5e17c7c8655f49">f85efe20</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-04-10T11:02:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-libnet_join: setup libnet join error string when AD connect fails

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13861

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 68121f46c74df9cef7a377040d01ba75cdcf5a26)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bdf59b416d224ef91696e98ac17348a8a6a5a5cd">bdf59b41</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-04-10T11:02:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-libnet_join: allow fallback to NTLMSSP auth in libnet_join

When a non-DNS and non-default admin domain is provided during the join
sometimes we might not be able to kinit with 'user@SHORTDOMAINNAME'
(e.g. when the winbind krb5 locator is not installed). In that case lets
fallback to NTLMSSP, like we do in winbind.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13861

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Apr  3 18:57:31 UTC 2019 on sn-devel-144

(cherry picked from commit 377d27359ccdb8f2680fda36ca388f44456590e5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dda1c48a47cd6a26757c8839dbbc4bbeb25d65a0">dda1c48a</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-04-10T14:21:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py/provision: fix for Python 2.6

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13882
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Wed Apr 10 14:21:16 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/63453eb3fb63b61ab59b038c7d6203109f95f922">63453eb3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-04-11T11:36:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Reindent some functions prior to making changes

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13860

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@samba.org>
(cherry picked from commit d7e187c1a7046196ec96637bdc14cc6b042eafcc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a1275fedd214e3aaf01c3ec2c758e3d9c19c4411">a1275fed</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-04-11T11:36:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Rename variable nfslock_service to nfs_lock_service

There will be more of these variable for other services so, for
readability, it makes sense for them to start with "nfs_".

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13860

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@samba.org>
(cherry picked from commit 9981353ab79dce81b698c535977be4a681119d1e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b2aa818e4d81d4166799687af3471496cae70392">b2aa818e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-04-11T11:36:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Add test variable CTDB_NFS_DISTRO_STYLE

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13860

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@samba.org>
(cherry picked from commit e72c3c800a50fe746164e319e21180c44d041619)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aaf8b6a66c0349b023c93174c4e742beae87de29">aaf8b6a6</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-04-11T11:36:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Factor out nfs_load_config()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13860

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@samba.org>
(cherry picked from commit 8de0a339b550e7363d265af04ad69f2179af75c6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ee78bddd08308637b48bcef68fa5ae3587da8de4">ee78bddd</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-04-11T11:36:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Stop/start mount/rquotad/status via NFS call-out

When an NFS check restarts a failed service by hand then systemd will
be unable to stop or start this service again because (at least) the
PID file will be wrong.  Do this via the NFS Linux kernel call-out
instead.  Allow the call-out to use the services instead of doing
manual restarts.  Add variables for mount, status and rquotad services
to support this.

Adding systemd NFS services to the call-out will follow.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13860

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@samba.org>
(cherry picked from commit 42103b568698d8087d27f0848b402ccb7cfac86b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/002beda318b47d9b3bdcfd470e035f5fb29aa5be">002beda3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-04-11T11:36:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Start NFS quota service if defined

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13860

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@samba.org>
(cherry picked from commit 708c04071af8d6ddc3bf2bddbde4d5847f440c0e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/80c6b7d391419a89c1a1041576196062463c2f61">80c6b7d3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-04-11T11:36:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Add systemd services to NFS call-out

At least Red Hat and Debian appear to use (a variant of?) the upstream
systemd units for NFS, so adding support for these services is
relatively easy.  Distributions using Sys-V init can patch the
call-out to use the relevant Sys-V init services.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13860

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@samba.org>
(cherry picked from commit a8fafd377ff0cb07ab161e437c5fe024704345eb)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/53e76ab4a8c89806b31d03ecd1d42f6c80886582">53e76ab4</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-04-11T11:36:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Update NFS test infrastructure to support systemd services

The tests are written around the default of sysvinit-redhat.  Add
support for systemd-redhat.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13860

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@samba.org>
(cherry picked from commit 2833ddcfcb780497264e0f412a9ad6e26a9bc657)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/12f6eae2c9affd4313655e870ee2d0cefadb1f95">12f6eae2</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-04-11T11:36:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Allow load_system_config() to take multiple alternatives

The situation for NFS config has got more complicated and is probably
broken in statd-callout on Debian-like systems at the moment.  Allow
several alternative configuration names to be tried.  Stop after the
first that is found and loaded.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13860

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@samba.org>
(cherry picked from commit 0d67ea5fcca766734ecc73ad6b0139f7c13a15c5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6baf1529a81abd808106949a93f0b55ba2085d05">6baf1529</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-04-11T11:36:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Update statd-callout to try several configuration files

The alternative seems to be to try something via CTDB_NFS_CALLOUT.
That would be complicated and seems like overkill for something this
simple.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13860

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@samba.org>
(cherry picked from commit a2bd4085896804ee2da811e17f18c78a5bf4e658)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d4ea61f5615afc7220d0e90042d78d3535ae0120">d4ea61f5</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-04-11T11:36:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">memcache: Introduce struct for storing talloc pointer

This allows extending the additional data stored for talloced objects
later.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13865

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 7c44f2f76eefb9156cb1d170c92b4ff07dd6a3d5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/43f3544e83f7c8a6efc95fc61013805ca3799be4">43f3544e</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-04-11T11:36:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">memcache: Properly track the size of talloc objects

With memcache_add_talloc, the talloc object becomes part of the pool and
the memcache_element stores a pointer to the talloc object. The
size of the the talloc object was not used when tracking the used space,
allowing the cache to grow larger than defined in the memcache_init
call.

Fix this by adding the size of the talloc object to the used space.

Also record the initial size of the talloc object for proper adjustment
of the used space in the cache later. This is in case the size of the
talloc object is modified while being owned by the cache (e.g.
allocating talloc child objects). This should never happen, but better
be safe than ending up with a broken cache usage counter.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13865

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit a04ca6f3438595ba7e1a110877f53d1cac0f0402)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1a82c4b95322a60fe231add5f4a965e8f828ccfa">1a82c4b9</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-04-11T11:36:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">memcache: Increase size of default memcache to 512k

With the fixed accounting of talloc objects, the default cache size
needs to increase. The exact increase required depends on the workloads,
going form 256k to 512k seems like a reasonable guess.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13865

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 9ff5c0bab76c5d3d7bea1fcb79861d0c9a3b9839)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/182f329f54139decbbb394e10361922088278d07">182f329f</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-04-11T14:56:59Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Add test for talloc size accounting in memcache

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13865

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Apr  6 06:08:42 UTC 2019 on sn-devel-144

(cherry picked from commit b7028c42462c34cf86cb949bfdb16ebc7ed0a6c6)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Thu Apr 11 14:56:59 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8f43d725d3629daf17a2aaa3006f47021efad72d">8f43d725</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-04-15T11:02:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Revert "We can not assume that just because we could complete a TCP handshake"

We also can not assume that nodes can be marked as connected via only
the keepalive mechanism.  Keepalives are not sent to disconnected
nodes so, in the absence of other packets (e.g. broadcasts), 2 nodes
may never become marked as connected to each other.

Revert to marking nodes as connected in the TCP transport code.  If a
connection is to a non(-operational) ctdbd then it will revert to
disconnected after a short while and may actually flap.  This should
be rare.

This reverts commit 66919db3d7ab1e091223faf515b183af8bfddc83.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13888

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 38dc6d11a26c2e9a2cae7927321f2216ceb1c5ec)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e23fdfe6730afe1ac920a58c94d48aba592c9c7a">e23fdfe6</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-04-15T14:23:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Avoid race between fd and signal events

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13895

In run_proc, there was an implicit assumption that when a process exits,
fd event (pipe between parent and child) would be processed first and
signal event (SIGCHLD for the child) would be processed later.

However, that is not the case.  SIGCHLD can be received asynchronously
any time even when the pipe data has not fully been read.  This causes
run_proc to miss some of the output from child process in tests.

When SIGCHLD is being processed, if the pipe between parent and child is
still open, then do an explict read from the pipe to ensure we read any
data still in the pipe before closing the pipe.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Apr 12 08:19:29 UTC 2019 on sn-devel-144

(cherry picked from commit 289201277cd983b27cdfd5376c607eab112b4082)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Mon Apr 15 14:23:16 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/690ba5dc8769dc4fa0106e311c62ee807e857b92">690ba5dc</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-16T08:51:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: handle IO_REPARSE_TAG_DFS in SMB_FIND_FILE_FULL_DIRECTORY_INFO

This completes commit 74829fecd7a4e806ee441cd75141bede2eefef1a,
which missed SMB_FIND_FILE_FULL_DIRECTORY_INFO

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10097

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 1d9348575914891dbb5638bc9b8d51eda98fe554)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d0f5c69b11a72fcaf120bae664448001a2f22814">d0f5c69b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-16T08:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb2_server: allow smbd_smb2_request_pending_queue(0) to avoid STATUS_PENDING

This has the same meaning as smb2_request_set_async_internal(),
but this will simplifies callers.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13698
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13796

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 4760b85243f335bb2094fc779802ce4b52db0ccb)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/914d7c53f4da68c42f251b8d5bbea4a113a50519">914d7c53</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-16T08:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb2_sesssetup: avoid STATUS_PENDING responses for session setup

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12845
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13698
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13796

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 23792449694b5221f6ea422166c96fac494e3e2c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3e4d622e29625fa53fdc5d11faed2e44c76c4e2c">3e4d622e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-16T08:51:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb2_tcon: avoid STATUS_PENDING responses for tree connect

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12844
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13698

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 8a11da429bd3c89766f43c2bff681837a769987c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0acd5de35323ebb7731a58aeded787baf79f1f13">0acd5de3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-16T08:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb2_sesssetup: avoid STATUS_PENDING completely on session logoff

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10344
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13698

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit d64038425f250e253dce707d69899c7a5d8cb32e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/94b7fcba46eaae9c24e86992e0e99e2144dd1fee">94b7fcba</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-16T08:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb2_tcon: avoid STATUS_PENDING completely on tdis

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10344
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13698

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 1dc002548336b969979c3bf85b531c059d87f015)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5d418910795d0cf88a6815ca732de69e461be0ce">5d418910</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2019-04-16T08:51:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_snapper: drop unneeded fstat handler

fstat is handle based, and unlike vfs_shadow_copy2, we don't need to
make any changes to the returned sbuf, so remove the existing handler
which does nothing.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13858

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Mar 27 18:21:38 UTC 2019 on sn-devel-144

(cherry picked from commit c68d9c9ef367c1e85619ac2d027a0a425164ca8a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cfdec9a8563beb95fb939eb1a5650ab0f19e948b">cfdec9a8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-16T08:51:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_default: fix DEBUG messages in vfswrap_offload_write_*_done()

SMB_VFS_{PREAD,PWRITE}_RECV() don't set errno, so we need to
use strerror(aio_state.error) in the debug messages.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13862

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 2abf9e9a95cbdf76109b3501dee3e0c34ad09194)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d508ec6101226b82ddd334828231bd543c13888b">d508ec61</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-16T08:51:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_default: fix vfswrap_offload_write_send() NT_STATUS_INVALID_VIEW_SIZE check

This fixes a regression introduced in commit
60e45a2d25401eaf9a15a86d19114670ccfde259, where the 'num' variable
was renamed to 'to_copy', but a new 'num' variable was introduced.

Note that off_t is signed!
In future we need to watch out for filesystems supporting
FMODE_UNSIGNED_OFFSET on Linux. Which means they use it unsigned.

This is more or less a theoretical problem, The
NT_STATUS_INVALID_PARAMETER cases are catched before by
SMB_VFS_PREAD_SEND/RECV.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13862

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 4d6cd932a955a99ca33cc4aedd7f612e56e0b1de)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/822df5a6dc1cb4e4094924d1b88f1cd751f6e905">822df5a6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-04-16T08:51:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb2_server: grant all 8192 credits to clients

This seems to match Windows Server 2016.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13863

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 829f692fb1552e56c6a9726036a995b4328731dd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bd3c73e086159ca394b297b751b9337533330ee1">bd3c73e0</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2019-04-16T08:51:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_ceph: explicitly enable libcephfs POSIX ACL support

libcephfs disables ACL support by default and returns -EOPNOTSUPP in the
POSIX ACL get/setxattr paths as a result. Enable support by setting the
following Ceph config parameters during mount:
        client acl type = posix_acl
        fuse default permissions = false

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13896

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 4982e282f2f2246952854ccc10d4787ac6653a7f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/faa61e3c87874baa3ca9ad474dfb803e59d13926">faa61e3c</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2019-04-16T14:42:07Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs/vfs_ceph: describe new ACL behaviour

vfs_ceph now explicitly enables libcephfs POSIX ACL support.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13896

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Apr 12 19:40:25 UTC 2019 on sn-devel-144

(cherry picked from commit 58314d71ea63e36d5f1bbd2c3e190b1edffee726)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Tue Apr 16 14:42:07 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3c027df87fef6e8ffbd754b20561d4556e748935">3c027df8</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2019-04-30T08:22:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/vfs_glusterfs_fuse: Dynamically determine NAME_MAX

This allows the vfs_glusterfs_fuse build to complete on AIX.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13872

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit e28d172b00cadf492c22bd892e2dda3bf2fe2d70)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c7b67d3cb37565bc246e1dd6b4ac869c50771d34">c7b67d3c</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2019-04-30T13:54:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/vfs_glusterfs: Dynamically determine NAME_MAX

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13872

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 8e3a042eb9e502821b147f1bbb2d98d59f17a095)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Tue Apr 30 13:54:14 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/770352cd07776fcfc49511b0b393c2e6371724e9">770352cd</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-05-07T08:53:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.3.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
(cherry picked from commit cf323d769f0f75a8201b21e5563fc5481beb614e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6a7e06239fb725f77877ed6e3435ef101a162148">6a7e0623</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-05-07T09:02:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Re-enable GIT_SNAPSHOT.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6ad19ca46879f166e896562b88244e2ffd17e1ed">6ad19ca4</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-05-07T09:02:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16860 selftest: Add test for S4U2Self with unkeyed checksum

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13685

Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/12086db2101beb44db41da0a811a6be8544b546e">12086db2</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-05-07T09:02:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2018-16860 Heimdal KDC: Reject PA-S4U2Self with unkeyed checksum

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13685

Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/20ce967a45a140475b36c90b8c24ba51374e57d2">20ce967a</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-05-07T09:02:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.10.3.

CVE-2018-16860 (Samba AD DC S4U2Self/S4U2Proxy unkeyed checksum)

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70a164b3214026fe6f94c7b4c468c49d0557e2e5">70a164b3</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-05-07T09:06:14Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.10.3 release.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6c23ad16f02497d086f42dccd75c6fcc5dad3333">6c23ad16</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-05-07T10:26:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.10.3 release.

CVE-2018-16860 (Samba AD DC S4U2Self/S4U2Proxy unkeyed checksum)

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c0a8bd3d66e2dbfab166db082e4ad253adaed9cb">c0a8bd3d</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-05-14T06:21:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge tag 'samba-4.10.3' into v4-10-test

samba: tag release samba-4.10.3
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2ad7a4a64779c06ff4c4aa874656c778c823b959">2ad7a4a6</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-05-14T06:23:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.4.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b7f79137dcdb0dcb99479c7e9e9bc7a73ff38dfa">b7f79137</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-05-14T13:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Add testcase for checking output of wbinfo --sid-to-name

The username should always be returned in the DOMAISHORTNAME/USERNAME
format.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13831

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit d006c769a9cad275339b18b08e13d48acb29d7fc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2670fe833748c8b508ed164e8e2b0a86cb5c38ec">2670fe83</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-05-14T13:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Query domain from msrpc name_to_sid

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13831

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 60b0e91237179b8782c4bd83b9579f51d5af2928)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/af48878005a6452961bda7b9bc731120eef32be1">af488780</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-05-14T13:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Query domain from winbind rpc name_to_sid

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13831

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 562551c0886bdef1f97059e16d375c2e97452b45)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b519cd2156d47ce09207bd8f254a9971bcfb8b2c">b519cd21</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-05-14T13:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Query domain from winbind sam_name_to_sid

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13831

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 32e3f0663be39cf4a81639c818fc88e959791673)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9034980420db2b50b1d2924d196de0548eac6fc3">90349804</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-05-14T13:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Return queried domain name from name_to_sid

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13831

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 640e0ef4fd338ddf03b813a8d45cce67c7ec7a01)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b01e1e3376be76fea435f987e0edea98161b7a35">b01e1e33</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-05-14T13:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Use domain name from lsa query for sid_to_name cache entry

When winbindd is asked to map a name like realm.com\name to a SID ,that
is sucessfully resolved through the lsa lookup name call. The same call
also returns the short domain name (netbios name of the domain). Use
that short domain name for the sid_to_name cache entry, so that
subsequent sid_to_name queries return the expected netbiosname\name
result and not realm.com\name.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13831

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit aec9bda25f10ca2710d91fb680cca7904e92f9de)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ea74b0eb2ef634b35eb0c51053ba3f87d3bee383">ea74b0eb</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-05-14T13:58:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: fix the err_empty_attribute() check

ldb.bytes('') == '' is never True in python3,
we nee ldb.bytes('') == b'' in order to
check that on attribute has an empty value,
that seems to work for python2 and python3.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13843

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Noel Power <npower@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Mar 21 18:15:20 UTC 2019 on sn-devel-144

(cherry picked from commit 261ef9d5b62f0d49f858717e6d8b4b41f008efb5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1efa1e011941075d24b55f5228c167fd847ed61d">1efa1e01</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-05-14T13:58:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add test for setting min/maxPwdAge

Currently setting maxPwdAge doesn't work at all.

While we're adding a test, we might as well assert that minPwdAge
can't be greater than maxPwdAge as well.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13873

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit d247a600845fdc6bf232496e8db56cd1d95a3022)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/36da4c095deb73dfb14ca629b223998fce1f9403">36da4c09</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-05-14T13:58:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Use python constant for -0x8000000000000000

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13873

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit b43f997f2397771b159c49526a36bd2b3467b0ef)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/afc2243b4785180c74bccaa5491396fe7d5d8bcd">afc2243b</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-05-14T13:58:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Add some timestamp conversion helper functions

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13873

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 940306a24a8d14fbb8c76c5a60b3d5f2773873a0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/893ac2a6b2046e4e1d7a46f2a2c50afc7546d3b2">893ac2a6</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-05-14T17:36:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Fix passwordsettings --max-pwd-age command

The min_pwd_age and max_pwd_age parameters are both optional and default
to None. However, if we just set the max-pwd-age, then the check
'min_pwd_age >= max_pwd_age' will throw a Python exception because it's
trying to compare an int to NoneType (min_pwd_age). This works on Python 2
but is a problem on Python 3.

We could just add a check that min_pwd_age is not None, but that defeats
the point of having the check if you're only setting either the min or
max age indepedently.

This patch gets the current min/max password age from the DB (in ticks).
If either setting is changed, the ticks will be updated. Then at the end
we check the min is still less than the max (to do this, we convert the
ticks back to days in the interests of readability).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13873

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Apr  5 08:03:08 UTC 2019 on sn-devel-144

(cherry picked from commit 7a410ccb5f6f2958d56fa6f16d8780c69a3830dd)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Tue May 14 17:36:28 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d1962a5f5278fc299af982d73e517c40a4b09320">d1962a5f</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-05-16T10:37:48Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pytests/dns: use 2.6 compatible syntax

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13886
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2cc3b4c42c5acfba2c0d1d5cee8e0c02f38c322c">2cc3b4c4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-05-16T10:37:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Initialize getline() arguments

Keep "len" valid across the loop iterations for getline to consume

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13892

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit c0b2272a7d15d266ce64c86cf6a313b5b0fb67fd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c167fa8628846426cf9e09e93313174564d09a2">9c167fa8</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-05-16T10:37:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib util debug: Increase format buffer to 4KiB

Increase the debug line buffer to 4KiB, the existing size of 1KiB is too
small for dsdbChange JSON audit messages.  These messages were then
split across multipe lines causing issues in log ingestion tools
expecting single line messages.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13902

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Mon May  6 01:18:22 UTC 2019 on sn-devel-184

(cherry picked from commit ad3af7cdffb98b7998857db609548fc96f60c669)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/38746ec0a3ea943d9489b4115deb76cc42bb34ff">38746ec0</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-05-16T10:37:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add gid-to-sid lookup to idmap_ad test

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13903

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit d7b5ad5e6159c224f70bea782bbdc46059e67978)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/28b5ff2ccf7a5c7d7391450ded6d03b2475276ce">28b5ff2c</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-05-16T10:37:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Use fl2008r2dc for ad_member_idmap_ad

fl2008r2dc already has a trusted domain. That will be used to use
idmap_ad for querying idmap attributes from the trusted domain.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13903

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 8266bd1f45d1b5b2a61d84006ab8e8e1ed0e52a9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/79c04524c380d2ce58b022ef625d6afbe7fb45c6">79c04524</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-05-16T10:37:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Make trusted domain information available for idmap_ad environment

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13903

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 281fb81ab1c72831c752be44fd1bfdcfd10bd798)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c3c2f3707a0131a5dbf9ed71e48bdda0166ad929">c3c2f370</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-05-16T10:37:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add idmap configuration for trusted domain for idmap_ad

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13903

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 65e1d783cb17904cd117d896569e7cbe79a3131b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3a46730f12e3760d1eef2461527e4b58432ee917">3a46730f</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-05-16T10:37:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Pass trusted domain information to idmap_ad test

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13903

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit ac0f8656eed39a4527a5336cf93aa1508666f79b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/24d39db5c372eb96b2bcc4ac44e53f68e03b3f66">24d39db5</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-05-16T10:37:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add trusted domain tests for idmap_ad

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13903

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 2577f43a133f8b8eb997b9529a38e21c77b5da22)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1fa6a46fa53eb2d174b7a60624c44f38c07a8afa">1fa6a46f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-05-16T10:37:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Fix overlapping id ranges

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13903

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Apr 24 02:25:56 UTC 2019 on sn-devel-184

(cherry picked from commit 3020050bdf9df077ec9a0e962a689557187174ac)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c7f25b25d3a4599d6274819e34717c9eae56c2b0">c7f25b25</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2019-05-16T10:37:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:debug: use struct initializer

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13904

Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
(cherry picked from commit b9e1b4ad0033c211710da285c30d603ccb8b8d40)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c584a4b4dfbdf7df1acc9bc452f95511a3f07f02">c584a4b4</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2019-05-16T10:37:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:debug: adjust indention

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13904

Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
(cherry picked from commit a45675879ddcb43ab274d28496eedd6833466ae4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de505618e6028f35d924170fc36652d069464e35">de505618</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2019-05-16T10:37:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:debug: enable logging for early startup failures

Commit c89a33a07a 'debug: Use backends instead of explicitly logging to
syslog or file' introduced a regression where early startup failures (e.g.
unable to connect to CTDB) are no longer logged because the debug subsystem
is not yet fully initialized. Enable logging again with reasonable defaults
when reopen_logs() is called and the parameter file is not yet parsed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13904

Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>

Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Thu Apr 18 22:21:15 UTC 2019 on sn-devel-144

(cherry picked from commit 9b30fcda64080592d20de64b384fd6d3d0775cbf)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f4a603a9f32b75662dc08bf58b75345b16ac8ee7">f4a603a9</a></strong>
<div>
<span>by Robert Sander</span>
<i>at 2019-05-16T10:37:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: modules: ceph: use current working directory instead of share path

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13918

Signed-off-by: Robert Sander <r.sander@heinlein-support.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu May  2 19:34:11 UTC 2019 on sn-devel-184

(cherry picked from commit 966fc0dc604299a87e40e7170d80911475317db5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/649dd7bce868bef1cb62a9070f32858a525c7cd7">649dd7bc</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-05-16T10:37:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/smb2: add smb2.stream.names3 test

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13919

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit b5c4fdbf99caa3a9e7c6446cfbc4f1b23b84b3c8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/07382f0765acf7480a4d78144fcd1659334f375e">07382f07</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-05-16T10:37:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: allow case insensitive opens of named streams

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13919

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 2a69c0915586fb9fb2148239965d06bf9f93c803)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3205d032781b706fb83acfdb6b8dc4dd8bd51a4d">3205d032</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-05-16T10:37:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libcli/raw: add RAW_FILEINFO_NORMALIZED_NAME_INFORMATION support

This is supported over the wire in SMB 3.1.1 on starting with
Windows 10 1803.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13919

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 0c602319194bda6b2a0efdd7c186078583f79264)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5308f042e672b61eab98a486b87dddd54ac6e764">5308f042</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-05-16T10:37:51Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/smb2: add smb2.getinfo.normalized test

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13919

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 8a5828de2bdd95223e5f30996d0490fef53742dd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/42b32da416056f315925c2e6563c2c5d26f27832">42b32da4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-05-16T10:37:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: implement SMB_FILE_NORMALIZED_NAME_INFORMATION handling

Windows 10 (1803 and higher) support and use
SMB_FILE_NORMALIZED_NAME_INFORMATION calls over the network. As a
fallback (in case the server don't support it) the client traverses all
path components, which is very expensive.

Implementing SMB_FILE_NORMALIZED_NAME_INFORMATION is very cheap for us
as the open already went through unix_convert() and we have the
information the client is asking for.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13919

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed May  1 18:33:00 UTC 2019 on sn-devel-184

(cherry picked from commit b20fd15e04ce9292f90a7f70f4184e43034b4b9d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8c9abb2749f2836c97bfa4c4ef3786b3e82633c6">8c9abb27</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-05-16T10:37:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Fix ctdb dumpmemory to avoid printing trailing NUL

Fix ctdb rddumpmemory too.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13923

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit f78d9388fb459dc83fafb4da6e683e3137ad40e1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c054f19fb3773102262b477c8e4d3ec97449a520">c054f19f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-05-16T10:37:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Extend test to cover ctdb rddumpmemory

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13923

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 8108b3134c017c22d245fc5b2207a88d44ab0dd2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8bb1726f6a714dddc3ef63c42ac4741f6477b986">8bb1726f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-05-16T10:37:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Change sanity_check_output() to internally use $out

All callers are currently passed $out.  Global variable $out is used
in many other places so use it here to simplify the interface and make
future changes simpler.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13924

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 7c3819d1ac264acf998f426e0cef7f6211e0ddee)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2044466dd3e2f389843acd8dc24e522c3364cd2b">2044466d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-05-16T10:37:52Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Make try_command_on_node less error-prone

This sometimes fails, apparently due to a cat process in onnode
getting EAGAIN.  The conclusion is that tests that process large
amounts of output should not depend on a sub-shell delivering that
output into a shell variable.

Change try_command_on_node() to leave all of the output in file
$outfile and just put the first 1KB into $out.  $outfile is removed
after each test completes.

Change the implementation of sanity_check_output() to use $outfile
instead of $out.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13924

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 9d02452a24625df5f62fd6d45a16effe2fa45fbe)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/221da170256da830e06b721af9799be57ef1a21f">221da170</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-05-16T10:37:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid bulk output in $out, prefer $outfile

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13924

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 066cc5b0c561464ed08890d9aa1a1a55b545e9cc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b8cf1594a73f2a19a7b295681674383faa63f32d">b8cf1594</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-05-16T10:37:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Wait to allow database attach/detach to take effect

Sometimes the detach test fails:

  Check detaching single test database detach_test1.tdb
  BAD: database detach_test1.tdb is still attached
  Number of databases:4
  dbid:0x5ae995ee name:detach_test4.tdb path:tests/var/simple/node.0/db/volatile/detach_test4.tdb.0
  dbid:0xd84cc13c name:detach_test3.tdb path:tests/var/simple/node.0/db/volatile/detach_test3.tdb.0
  dbid:0x8e8e8cef name:detach_test2.tdb path:tests/var/simple/node.0/db/volatile/detach_test2.tdb.0
  dbid:0xc62491f4 name:detach_test1.tdb path:tests/var/simple/node.0/db/volatile/detach_test1.tdb.0
  Number of databases:3
  dbid:0x5ae995ee name:detach_test4.tdb path:tests/var/simple/node.1/db/volatile/detach_test4.tdb.1
  dbid:0xd84cc13c name:detach_test3.tdb path:tests/var/simple/node.1/db/volatile/detach_test3.tdb.1
  dbid:0x8e8e8cef name:detach_test2.tdb path:tests/var/simple/node.1/db/volatile/detach_test2.tdb.1
  Number of databases:4
  dbid:0x5ae995ee name:detach_test4.tdb path:tests/var/simple/node.2/db/volatile/detach_test4.tdb.2
  dbid:0xd84cc13c name:detach_test3.tdb path:tests/var/simple/node.2/db/volatile/detach_test3.tdb.2
  dbid:0x8e8e8cef name:detach_test2.tdb path:tests/var/simple/node.2/db/volatile/detach_test2.tdb.2
  dbid:0xc62491f4 name:detach_test1.tdb path:tests/var/simple/node.2/db/volatile/detach_test1.tdb.2
  *** TEST COMPLETED (RC=1) AT 2019-04-27 03:35:40, CLEANING UP...

When issued from a client, the detach control re-broadcasts itself
asynchronously to all nodes and then returns success.  The controls to
some nodes to do the actual detach may still be in flight when success
is returned to the client.  Therefore, the test should wait for a few
seconds to allow the asynchronous controls to complete.

The same is true for the attach control, so workaround the problem in
the attach test too.

An alternative is to make the attach and detach controls synchronous
by avoiding the broadcast and waiting for the results of the
individual controls sent to the nodes.  However, a simple
implementation would involve adding new nested event loops.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13924

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 3cb53a7a05409925024d6a67bcfaeb962d896e0b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3582e3066061ac965341bd504f01f8f356b4c08e">3582e306</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-05-16T10:37:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Fix usage message

Since commit 0e9ead8f28fced3ebfa888786a1dc5bb59e734a3 daemons have
been shut down after each test, so this option no longer has anything
to do with killing daemons.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13924

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit a2ab6485e027ebb13871c7d83b7626ac5c9b98c0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0cdf5c6b5ceb89592ce2b93de65f7ad3a6c8db91">0cdf5c6b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-05-16T10:37:53Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Don't clean up test var directory in autotest target

If the directory is always cleaned up then it is not possible to look
at daemon logs to debug test failures.

This target is only really used by autobuild.py, which (optionally)
cleans up the parent directory anyway.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13924

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue May  7 06:56:01 UTC 2019 on sn-devel-184

(cherry picked from commit 5a9e338330fe136908a3a17a5df81c054c5cc5b0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/33739d555690d121bddaf858fe20a85aed6dad30">33739d55</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-05-16T10:37:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Actually restart if cluster doesn't become healthy

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13924

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 97ad353a67ce0232d7ca5637f1bf8886e2df1aca)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65bf14afd83821016e8772311c9c5e97f26453de">65bf14af</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-05-16T10:37:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Remove old socket wrapper state directory during setup

Otherwise, when looping tests for a long time, nodes are unable to
connect to each other.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13924

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon May 13 08:42:44 UTC 2019 on sn-devel-184

(cherry picked from commit c75fbeaa96108cd4dc193ef5f4170977804e5104)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/efb35a1a6950b8483907320590da2140b7e7a084">efb35a1a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-05-16T10:37:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Capture output in $out on failure as well

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13924

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit cf00db40355b49443263187f9d97934f91287e51)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/63a59de4f0fe8a1f8dd41868692857fdec6e405a">63a59de4</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-05-16T10:37:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Make ctdb reloadips tests more reliable

ctdb reloadips will fail if it can't disable takover runs.  The most
likely reason for this is that there is already a takeover run in
progress.  We can't predict when this will happen, so retry if this
occurs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13924

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 8be4ee1a28d5c037955832b6f827d40f28f02796)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/52ba5136f2f0107650f2dfe187bffa3f5d0918f3">52ba5136</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-05-16T10:37:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Fix logic error in simple ctdb reloadips test

There is a chance that restoring IP addresses to the test node will
result in different IP addresses being assigned to that node.
Removing a single IP address may then fail (or be a no-op) if it is
done after the restore.

So, swap the single IP address removal to happen first, then restore,
then remove all IP addresses.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13924

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit dc89db8ca6aadd4a9f7e8a85843c53709d04587c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/385a36b7e7cb20e4cb25d03b84611dff85922a49">385a36b7</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-05-16T10:37:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch pam_winbind: Fix Asan use after free

Fix use after free condition detected by Address Sanitizer triggered by
wbcLogonUserInfoDestructor, wbcFreeMemory has code to detect and prevent a
double free.  This patch prevents the Address Sanitizer error, allowing
tests to be run with Address Sanitizer enabled.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13927

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon May  6 08:55:22 UTC 2019 on sn-devel-184

(cherry picked from commit 193b44466ba05deba8f2b1fdc16ab55c102e82ad)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6aa0fd8b7cdbf429d3b07adba5b922aa1a6c30f3">6aa0fd8b</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-05-16T10:37:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4 lib socket: Ensure address string owned by parent struct

The local address string was not owned by it's parent structure, which
caused a use after free error in
continue_ip_open_socket source4/librpc/rpc/dcerpc_sock.c:267

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13929

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed May  8 20:03:42 UTC 2019 on sn-devel-184

(cherry picked from commit ae9fb93393bcadbc71328335e481e4381ecb65bf)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8a320aad33230de0996f8f455377b1ef11fde637">8a320aad</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-05-16T10:37:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Never use 0 as a client ID

ctdb_control_db_attach() and ctdb_control_db_detach() assume that any
control with client ID 0 comes from another daemon and treat it
specially.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13930

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 8663e0a64fbdb9ea16babbfe87d6f5d7a7b72bbd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8542379bde8e48d25bab820c37eef0aafc2f6472">8542379b</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-05-16T10:37:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3 rpc_client: Fix Asan stack use after scope

Fixes Asan error:

==1924==ERROR: AddressSanitizer: stack-use-after-scope on address
    0x7ffe63f873d0 at pc 0x7fb99dae1733 bp 0x7ffe63f86a00 sp 0x7ffe63f861a8
READ of size 24 at 0x7ffe63f873d0 thread T0
    #0 0x7fb99dae1732  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x79732)
    #1 0x7fb99cfe5549 in memcpy
        /usr/include/x86_64-linux-gnu/bits/string_fortified.h:34
    #2 0x7fb99cfe5549 in ndr_push_bytes
        ../../librpc/ndr/ndr_basic.c:729
    #3 0x7fb99cfe5646 in ndr_push_array_uint8
        ../../librpc/ndr/ndr_basic.c:754
    #4 0x7fb99a69dd1b in ndr_push_netr_ChallengeResponse
        librpc/gen_ndr/ndr_netlogon.c:462
    #5 0x7fb99a6c5fab in ndr_push_netr_NetworkInfo
        librpc/gen_ndr/ndr_netlogon.c:556
    #6 0x7fb99a6c749d in ndr_push_netr_LogonLevel
         librpc/gen_ndr/ndr_netlogon.c:783
    #7 0x7fb99a7222de in ndr_push_netr_LogonSamLogonEx
         librpc/gen_ndr/ndr_netlogon.c:16547
    #8 0x7fb99c982c97 in dcerpc_binding_handle_call_send
         ../../librpc/rpc/binding_handle.c:416

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13936

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri May 10 10:02:21 UTC 2019 on sn-devel-184

(cherry picked from commit a5d1df4a8f9c535ff2f7ef11d7dfea4d79d65e7e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4f0a4fac3de770cc303abdfe48e44f1d42ea6858">4f0a4fac</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-05-16T10:37:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:auth: Fix debug statement in gensec_gssapi

The 'role' is set to null, we should first set it to the correct value
before printing anything.

Found by GCC 9.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13937

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit bd29f3fcc023d00afde8e9cc2f9db22dcae49877)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/405872948fa3cbac491ecf184e7ca69f34ae0e4e">40587294</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-05-16T10:37:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Do not free the tdbname before we printed it

Found by GCC 9.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13937

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 790d7e34cbe4e190d6acdd24696efe53944cd4a6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b522ed38de14a8b544a49396c8f8d4b2a6a62a46">b522ed38</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-05-16T10:37:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:ntvfs: Do not free eadb before we printed an error

Found by GCC 9.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13937

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 6da032df5450ef72f8608a19b3b5cc6e9185cd6e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a81f78ce4e47710ddbb04eadd4ab6e5052037b8f">a81f78ce</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-05-16T10:37:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Do not print NULL strings we just checked before

Found by GCC 9.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13937

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit be72dfbc8edc53ed191dc01668a53cafb5cd785d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4113054a7ceacde8648ea210791ea8cc3effacbd">4113054a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-05-16T10:37:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:torture: Fix string comparison macros where we directly pass NULL

See e.g. lib/util/tests/strlist.c +177

Found by GCC 9.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13937

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit a8f773e326d6bdfc1c9eb87a74c00108f6620c56)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b578a2df99fa29b8331446658d3be8b65baa2ddc">b578a2df</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-05-16T10:37:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Do not free full_name before we printed it

Found by GCC 9.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13937

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 46f036d3231bc99cf37c7cabf82757d3c28c5cff)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5b6adbb0f056061fd2348004a286c8220182214a">5b6adbb0</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-05-16T10:37:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb:common: Do not print NULL if we don't get a sockpath

sock_socket_start_recv() might not fill sockpath if we return early.

Found by GCC 9.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13937

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 830cb7e67568de5f3ce359cb6af3be8ab545c824)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/601cb1d57266abd62da921f97f7aa3c1d80055f2">601cb1d5</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-05-16T10:37:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbindd: Do not free db_path in idmap_tdb2 before we printed it

Found by GCC 9.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13937

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit e333425e0ff6be5691b74a920610b508e7d26892)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b0e862a64a76db0c1865e280367898f6fd31e938">b0e862a6</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-05-16T10:37:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: If share is NULL in smbcquotas, don't print it

Found by GCC 9.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13937

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 3653dc7013518d90e6deb08a1f21d7472dc86675)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f7ffa7a007f462ee240fb3cec5398264d6c140a5">f7ffa7a0</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-05-16T10:37:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: If share is NULL in smbcacls, don't print it

Found by GCC 9.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13937

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 2b957bde5a2f0f670ee0c8acde6edae1f4aaf253)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/198cb5b0550cc7d9c8b2be216f5b695aa1a686f8">198cb5b0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-05-16T10:37:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: don't use recvfile on streams

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13938

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu May  9 20:43:53 UTC 2019 on sn-devel-184

(cherry picked from commit 219bc189472acff24410009ee16a409e0aaf8eef)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5c9489ba557d2ee0b8e40a4dec5e10982126d5dd">5c9489ba</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-05-16T10:37:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: SMB1: Don't allow recvfile on stream fsp's.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13938

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri May 10 01:14:02 UTC 2019 on sn-devel-184

(cherry picked from commit 667db8e8c7836c750085729f5062807669cbb204)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4c02823ab51f99932aadc65244372f5e9b495093">4c02823a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-05-16T10:37:57Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbspool: Fix regression printing with Kerberos credentials

This is a regression which has been introduced with Samba 4.8.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit fd4b1f4f16aee3e3c9a2cb449655edfed171963a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/417a4d2c3cc7b007036b1936601ec71d55f7f9e8">417a4d2c</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2019-05-16T10:37:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_ceph: fix cephwrap_flistxattr() debug message

The @list buffer may be uninitialised prior to ceph_flistxattr()
invocation, so only log the address.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13940

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Fri May 10 12:59:05 UTC 2019 on sn-devel-184

(cherry picked from commit 21dc6f8e8d82f84e4afda355a48fbbd39c7fe800)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/32065a0772ef8c43676d39b43fefd1accf47decb">32065a07</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-05-16T10:37:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Fix memory leak

state is always freed before exiting this function, so allocate fde
off it instead of long-lived ctdb context.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13943

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 6a2941e2a9fd6ab2d5b8dbac042b61a7b1b0b914)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0d4280abf98cb023d21edbf4e069f551931cca1f">0d4280ab</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-05-16T10:37:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Fix memory leak

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13943

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 30bc6e2529cdd444d4ec7902844c3a6fb0858090)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d6243acb3ac386c91e66ff9a2957b87c3fe7a6a1">d6243acb</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-05-16T13:56:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Fix memory leak in run_proc

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13943

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue May 14 08:59:03 UTC 2019 on sn-devel-184

(cherry picked from commit b1f4c86eea022999d5439e4a6ef3494fe41479b6)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Thu May 16 13:56:00 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fa9de54681bc2ebfb37b43f2a7bd2d69124f24c7">fa9de546</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-05-22T09:48:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.10.4.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d3cfdd71997494589edd73943d574964720b5f13">d3cfdd71</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-05-22T09:49:22Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.10.4 release.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/827b5423c0fe6ad472226b6d172e0460d074135a">827b5423</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-05-22T09:50:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.5...

and re-enable GIT_SNAPSHOT.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8eb462bf914f9b8f9427ececbfc15ae8ae4e5b72">8eb462bf</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-05-22T10:05:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge tag 'samba-4.10.3' into v4-10-stable

samba: tag release samba-4.10.3

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/def2c7dabc9d538587a39a3bf75605d8fd89b974">def2c7da</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-05-22T10:14:55Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge 'origin/v4-10-stable' into the real 4.10.4 release

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8e479542e28d3b52a940fc12c9e72d782d953d00">8e479542</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-05-22T10:16:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.10.4 release.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5508e9c8cb4206a1c2b012c6925f8c6f40f89c1f">5508e9c8</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-05-22T10:31:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge tag 'samba-4.10.4' into v4-10-test

samba: tag release samba-4.10.4

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f1d37ab5bb93d965c59304d9bd541a09f5ee666">7f1d37ab</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-06-13T08:52:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb/repl: we need to replicate the whole schema before we can apply it

Otherwise we may not be able to construct a working schema that's
required to apply the changes.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12204
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13713

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit 661dc4574110b0f13c127c8aa6ed0c385292b77c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/183d21bdc928e5acb36cc4c4cd2d3d47df68fbf2">183d21bd</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-06-13T08:52:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">drsuapi.idl: add DRSUAPI_ATTID_schemaInfo

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13799

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit 140a6733a458d0afa20237a09ef4ee2546a83a8f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4ebeef8ef95cfd8455e493bb7af502154cc3834b">4ebeef8e</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2019-06-13T08:52:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samdb: test for schemainfo update with relax control

Currently schema info's revision field isn't incremented if relax
control is present.  This is so that no increment is done during
provision, but we need the relax control in other situations where the
increment is desired.  This patch adds a failing test to expose the
problem.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13799

Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit e34abefb77729330cd48bc039c82b03fe545f8a9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1711b155676b9f1f4a4818a32ec8792fd9ba95fa">1711b155</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-06-13T08:52:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldapcmp: ignore 'schemaInfo' if two domains are compared

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13799

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit b5b572d5f71e2b9783ddb25c21ac32904fbfd661)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b97bba87d1eee1c08b65cf7771c68df17d913123">b97bba87</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-06-13T08:52:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:provision: split out provision_self_join_modify_schema.ldif

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13799

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit 5ea84af2d69e0b3a2a801ea0cc3f4ffc66bf1764)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d2d8caf45bce1e35cd500bce67916ad8be8b103a">d2d8caf4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-06-13T08:52:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/provision: use provision and relax controls for schema provision

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13799

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit 7652439fa1aab92945f5540a43fc49568d446917)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/36830a4e98d88fcc9ed65e1937b5a67241df9772">36830a4e</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2019-06-13T08:52:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb:samdb: schemainfo update with relax control

Currently schema info's revision field isn't incremented if relax
control is present.  This is so that no increment is done during
provision, but we need the relax control in other situations where
the increment is desired, so we should use the provision control instead
to disable schema info update.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13799

Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit b7c1752754da1e8a83a53670cf4a410ec6e9d7b7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/79d0ad8b7daf7685a753e2f51b11db4ed61028c2">79d0ad8b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-06-13T08:52:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/ntacls: we only need security.SEC_STD_READ_CONTROL in order to get the ACL

We should avoid security.SEC_FLAG_MAXIMUM_ALLOWED otherwise
we may get NT_STATUS_SHARING_VIOLATION when we run
'samba-tool domain backup online' against a Windows DC.
Windows DCs have hidden folders for the NtFrs or Dfsr services,
which are locked by the running service.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13917

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 15032ec6df1abbb53f1b1d5377aab369f83ae707)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65bc340af6afe393cca01e09a5afb4fe26eb33f2">65bc340a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-06-13T08:52:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbspool: Add the 'lp' group to the users groups

This is required to access files in /var/spool/cups which have been
temporarily created in there by CUPS.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 6086efb6808089c431e7307fa239924bfda1185b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/819b364f889d4ec329b771f21833e95dce11cac1">819b364f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-06-13T08:52:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbspool: Print the principal we use to authenticate with

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 42492d547661cb7a98c237b32d42ee93de35aba5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/97c1b4d880805a6d91723343a8c6658b268ad03f">97c1b4d8</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-06-13T08:52:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbspool: Add debug for finding KRB5CCNAME

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 3632bfef25e471075886eb7aecddd4cc260db8ba)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1e4d726dae17315a692c57b47266988a8298212d">1e4d726d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-06-13T08:52:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbspool: Use %u format specifier to print uid

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit be596ce3d2455bd49a8ebd311d8c764c37852858)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4f3cb35623ada8d96a0d8c2a2303006de44f48e4">4f3cb356</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-06-13T08:52:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbspool: Fallback to default ccache if KRB5CCNAME is not set

This could also support the new KCM credential cache storage.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 6bbdf69e406916107400e2cabdbc831e2a2bbee3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b8abd04cd641f110652405f73328f1370d994d9c">b8abd04c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-06-13T08:52:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbspool: Print the filename we failed to open

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 281274572bcc3125fe6026a01ef7bf7ef584a0dd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d95b2ecab78b1bd33177b59e7d1ad679b103d0c2">d95b2eca</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-06-13T08:52:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbspool: Always try to authenticate using Kerberos

If username and password is given, then fallback to NTLM. However try
kinit first. Also we correctly handle NULL passwords in the meantime and
this makes it easier to deal with issues.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 3d719a1f85db8e423dc3a4116a2228961d5ac48d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/57f1c2d45a50024909d49c0dac7f77057145ad42">57f1c2d4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-06-13T08:52:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbspool: Add debug messages to kerberos_ccache_is_valid()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 93acd880801524c5e621df7b5bf5ad650f93cec3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2e1b093ebffa4be11e47fc5420b501cee489ed44">2e1b093e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-06-13T08:52:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbspool: Use NTSTATUS return codes

This allows us to simplify some code and return better errors.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit d9af3dc02e98a3eb22441dfbdeddbaca0af078ea)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b6b9f49c25d9ad34bc534d3d2187f1e5f0c7ef32">b6b9f49c</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-06-13T08:52:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4 dsdb/repl_meta_data: allocate new extended DNs during ADD on a better context

Lower down in this function new_values is assigned over el->values and is
filled in with the values of all the parsed DNs.  Therefore it is the natural
talloc parent.

This will allow el->values to be allocated on tmp_ctx in the next commit for
a working area during the function call.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit 4aa9924310287ff3b36618496fa6c707c615ad4c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6946f0690af5d2a748c52c9f0fdc55d82d706f5a">6946f069</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-06-13T08:52:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4 dsdb/repl_meta_data: fix use after free in dsdb_audit_add_ldb_value

Fix use after free detected by AddressSanitizer

AddressSanitizer: heap-use-after-free on address 0x61400026a4a0
                  at pc 0x7fd555c52f12 bp 0x7ffed7231180 sp 0x7ffed7231170
                  READ of size 1 at 0x61400026a4a0 thread T0
    #0 0x7fd555c52f11 in ldb_should_b64_encode
       ../../lib/ldb/common/ldb_ldif.c:197
    #1 0x7fd539dc9417 in dsdb_audit_add_ldb_value
       ../../source4/dsdb/samdb/ldb_modules/audit_util.c:491
    #2 0x7fd539dc9417 in dsdb_audit_attributes_json
       ../../source4/dsdb/samdb/ldb_modules/audit_util.c:651
    #3 0x7fd539dc6a7e in operation_json
       ../../source4/dsdb/samdb/ldb_modules/audit_log.c:305

The problem is that at the successful end of these functions
el->values is overwritten with new_values.  However get_parsed_dns()
points p->v at the supplied el and it effectively gets used
as a working area by replmd_build_la_val().  So we must duplicate it
because our caller only called ldb_msg_copy_shallow().

The reason this matters is that the audit_log module is
above repl_meta_data in the stack, and tries to log the
ldb_message it saw after the reply (to include the error code).
If that ldb_message is changed it is not only misleading,
it can point to memory that has since gone away.

In this case the memory for the full extended DN in the
member attribute ended up on 'ac', a context lost by
the time repl_meta_data has finished processing.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13941

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed May 15 05:35:47 UTC 2019 on sn-devel-184

(cherry picked from commit 0daa0ff921b270df9b794f02acbaa391c95cd89b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/643c75aa2d10d432c1dcc1e3fa764ccf04683195">643c75aa</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-06-13T08:52:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4 dsdb: fix use after free in samldb_rename_search_base_callback

Fix use after free detected by AddressSanitizer

AddressSanitizer: heap-use-after-free on address 0x60f0002b2738
                  at pc 0x7f89b1a213b5 bp 0x7ffce9528810 sp 0x7ffce9528800
                  READ of size 8 at 0x60f0002b2738 thread T0
    #0 0x7f89b1a213b4 in samldb_rename_search_base_callback
        ../../source4/dsdb/samdb/ldb_modules/samldb.c:4203
    #1 0x7f89d3a0db4a in ldb_module_send_entry
        ../../lib/ldb/common/ldb_modules.c:793
    #2 0x7f89b6f27356 in es_callback
        ../../source4/dsdb/samdb/ldb_modules/encrypted_secrets.c:1418

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13942

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit b0cc6d217485c317b2138347216fac5d74684328)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4406c829558495a226eabf5c6c64953d39dd60c4">4406c829</a></strong>
<div>
<span>by Shyamsunder Rathi</span>
<i>at 2019-06-13T08:52:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:loadparm: Ensure to truncate FS Volume Label at multibyte boundary

For FS_VOLUME_INFO/FS_INFO operation, a maximum of 32 characters are
sent back. However, since Samba chops off any share name with >32
bytes at 32, it is possible that a multi-byte share name can get chopped
off between a full character. This causes the string decoding for unicode
failure which sends back NT_STATUS_ILLEGAL_CHARACTER (EILSEQ) to the client
applications.

On Windows, Notepad doesn't like it, and refuses to open a file in this
case and fails with the following error:

  Invalid character. For multibyte character sets, only the leading byte is
  included without the trailing byte. For Unicode character sets, include
  the characters 0xFFFF and 0xFFFE.

Proposed fix:
- Find the last starting point of a multibyte codepoint if the character
  at 32nd byte is a subsequent byte of a MB codepoint.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13947

Signed-off-by: Shyamsunder Rathi <shyam.rathi@nutanix.com>
Reviewed-by: Hemanth Thummala <hemanth.thummala@nutanix.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 0fa490e8476a2a5020ff2c253167b8a9454e8b97)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/def08d36e5bcf277adada2ce0e8bde694733912f">def08d36</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-06-13T08:52:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: winbind: Fix crash when invoking winbind idmap scripts.

Previously the private context was caching a pointer to
a string returned from lp_XXX(). This string can change
on config file reload. Ensure the string is talloc_strup'ed
onto the owning context instead.

Reported by Heinrich Mislik <Heinrich.Mislik@univie.ac.at>

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13956

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit a1f95ba5db6fc017fad35377fbf76c048f2dd8ab)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f7fc364715f8610572a4020a349297a6034533d">9f7fc364</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-06-13T08:52:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Enable "smbd:suicide mode" for smb2

The next commit needs an smbd to just exit and leave data behind in the
locking.tdb file. Don't make it harder to eventually phase out SMB1: Do
the test in SMB2.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13957
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bec45189777316ebf93d50c89d8b02ca46102660">bec45189</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-06-13T08:52:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbtorture: Add a test to make smbd panic

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13957
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ebe505e7cf72587640ef69bc04a0710f26bb90b9">ebe505e7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-06-13T08:52:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix a panic

Opening a file with a stale (smbd died) LEVEL_II oplock makes

vfs_set_filelen-> ... ->contend_level2_oplocks_begin_default

trigger the immediate leading to do_break_to_none. This goes through
because fsp->oplock_type is not initialized yet, thus 0. Also,
file_has_read_oplocks is still valid, because the smbd that has died
could not clean up the brlock.tdb entry.

Later in the code the exclusive oplock is granted, which is then found
by do_break_to_none, making it panic.

This patch just runs the direct FTRUNCATE instead of vfs_set_filelen.
This means the contend_level2_oplock code is skipped.

The relevant break (LEVEL_II to NONE) is now done in delay_for_oplock()
with the nice effect of removing a comment that was very confusing to
me.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13957
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed May 22 20:09:29 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d1cb288bda23a3bad943a66fe626c4fb3d45c91f">d1cb288b</a></strong>
<div>
<span>by Aliaksei Karaliou</span>
<i>at 2019-06-13T08:52:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:util: Move popen wrappers to lib/util

When linked into Samba3 libraries, sys_popen()/sys_pclose()
cannot be used in lower level libraries because of circular
dependencies.

This patch moves them into common samba-util library.

Extra fix needed to enable easy back-port of code for:

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964

Signed-off-by: Aliaksei Karaliou <akaraliou@panasas.com>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 65ea3f2a461c0eeca7d14c4258eea52e19f0ed06)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/21b99870445e832628a8e0f8c0619c8098e8314c">21b99870</a></strong>
<div>
<span>by Aliaksei Karaliou</span>
<i>at 2019-06-13T08:52:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:util: Move static file_pload() function to lib/util

file_pload() is static private function in Samba3 library, however it
does not have any special dependencies and might be widely used as
common function, so moving it into common samba-util library.

Extra fix needed to enable easy back-port of code for:

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964

Signed-off-by: Aliaksei Karaliou <akaraliou@panasas.com>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit d21fc7d8b86b0cddc619ffe528d9cd93eeedbb0b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7ce66c8ba7ae12d098714b1848f6981f41b4553e">7ce66c8b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-06-13T08:52:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: popen: Prepare to remove sys_popen().

Add sys_popenv(char * const argl[]) that uses a NULL
terminated vector array of args. Change sys_popen() to
split up its command string and call sys_popenv().

Once all callers are converted to sys_popenv() we
can remove sys_popen().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit f20538de041eed1cadbabe2149b2b7cfcb779cb5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/59bf36ee25643c2ed443b778216bad6b42213674">59bf36ee</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-06-13T08:52:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: util: Add file_ploadv().

Not yet used.

Duplicate code to file_pload() except uses vectored
argument list. file_pload() will be removed once all
callers are converted.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 5c34fa0b85e4d9a3c5fd4fa0b39af4772ec023db)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0f093e6bed10ab0db8af2ce5b476e4ed6e83f3b8">0f093e6b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-06-13T08:52:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: lib: util: Add file_lines_ploadv().

Not yet used.

Duplicate code to file_lines_pload() except uses vectored
argument list. file_lines_pload() will be removed once all
callers are converted.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 3b19412baedfffb7adc2a79471f5b17990259c31)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c477e2a57aace596c954de689fff0cf17a875a41">c477e2a5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-06-13T08:52:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Convert dfree code to use file_lines_ploadv().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit d6453e1ffd92c7754862389a933a9fd9089ce518)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4912e62ab036bfde19ece4d4641681b510fee0e3">4912e62a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-06-13T08:52:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Convert print_svid code to use file_lines_ploadv().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit f9ccf1cc3df13138a1a4b645c8190238ce011f04)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7bf8d14dbca16ff447d6805532fe9a7ab70d6b4f">7bf8d14d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-06-13T08:52:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Convert sysquotas.c code to use file_lines_ploadv().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 4a63e3b9659c8715d436c66dee8bf420e2ea89fb)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1e94a68dcd60fd0990b578522af80cbadadc9db8">1e94a68d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-06-13T08:52:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: lib: Remove file_lines_pload().

No longer used.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 02bc0ce9d22117b464bae47c5d09c45b4f7c2272)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/681627eb0efb3369b39b6e95b38ee1b69319d5c8">681627eb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-06-13T08:52:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: util: Remove file_pload()

No longer used.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit c5729ae44219ec81008040d4d50f0f5fdf254201)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8f690bbc63283a955648e24cfa5de9384174b118">8f690bbc</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-06-13T08:52:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: lib: Add file_ploadv_send().

Not yet used. Preparing to remove file_pload_send()
with this safer alternative.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 61054e53f53e5884902b566b1f9b454a3ff4741f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bcfdd13764936c96cdb17a9be2861ddf98aebc41">bcfdd137</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-06-13T08:52:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: winbind: Convert idmap to use file_ploadv_send().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 449d49946b295f574e1fed83b5a5ffbf1c1b1e30)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/482219feb09221bb310e9921bc24cf0a2d89cc16">482219fe</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-06-13T08:52:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: lib: Remove file_pload_send().

No longer used.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit d5c363d65d771c792523f2f3e526c90514212fc2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/323fd6648e23fe7ac3758d12a264a2323013719f">323fd664</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-13T08:52:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: lib: Rename all uses of file_pload_XXX -> file_ploadv_XXX.

Keep naming consistent across all usage.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit dbfa3cd186428c02589aa9093e868554b4c695d5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/024d287cb9ad4c81ed670ca57896dab01cdace43">024d287c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-06-13T08:52:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: util: Finally remove possibilities of using sys_popen() unsafely.

All code now uses sys_popenv() which is much
harder to use incorrectly.

Remove the extract_args() function that was the
cause of possible issues.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 9fa95d5b45369acfdd38923e8618e94e5d04b07e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b78b7215658e7594ea345c85ec375252b04b4e00">b78b7215</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-06-13T08:52:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: dfree command. Correct usage of dfree scripts.

Add quotes to the sample scripts to prevent incorrect
parameter usage.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri May 24 20:12:02 UTC 2019 on sn-devel-184

(cherry picked from commit 77eabd74e9a28b1e6decf0890a9ef4c83fa002d4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/40ab50754d1db8fc468cad04a0bf737f45895c0f">40ab5075</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-06-13T08:52:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/samba-tool: test dns serverinfo/zoneinfo

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13965

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/16f3a73c1a7d02d5984083ae53da10ae91477807">16f3a73c</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-06-13T08:52:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool dns: use bytes for inet_ntop

>From Python's point of view, array.AddrArray is a list of byte-valued
integers. In Python 3 we can convert directly using the likes of

         bytes(array.AddrArray[i].MaxSa[8:24])

but in 4.10 we need to support both, so we use struct.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13965

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>

Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Wed May 29 11:29:17 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e0e1707d8fc39e89073a435578b1fbb9466752b5">e0e1707d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-13T08:52:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">registry: add a missing include

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13840

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Karolin Seeger <kseeger@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Mon May 27 14:29:36 UTC 2019 on sn-devel-184

(cherry picked from commit e09053faf457f69ad9b5e6a34be43c947503575f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6dcec5e2536cf814ef8cf60947ac202c6c9ef636">6dcec5e2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-13T08:52:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: ensure test_adouble_conversion() uses a non-emtpy resourcefork

This ensures the resource fork is not deleted as part of the AppleDouble file
conversion for the option fruit:wipe_intentionally_left_blank_rfork=yes.

This is currently not a problem in selftest, as we don't enable the option, but
a subsequent commit will run all vfs.fruit tests against a share with this
option enabled.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13958

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit c3d28d49be3c7536d1ccfe8d00553ce72843f369)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0dfaa70427ed01265e82053f364f0745162b785b">0dfaa704</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-13T08:52:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/vfs/fruit: ensure test_adouble_conversion_wo_xattr() uses a non-emtpy resourcefork

This ensures the resource fork is not deleted as part of the AppleDouble file
conversion for the option fruit:wipe_intentionally_left_blank_rfork=yes.

This is currently not a problem in selftest, as we don't enable the option, but
a subsequent commit will run all vfs.fruit tests against a share with this
option enabled.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13958

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit bb5a457f2872a383b58d62981dade322fca9b283)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/886ab13095e5b8114fba5c6d6e761aa1b27bab72">886ab130</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-13T08:52:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: run vfs.fruit test against a share that deletes empty resource forks

This reveals a bug in the AppleDouble conversion code: the conversion code that
unlinks an empty resource fork AppleDouble sidecar file ("._file") gets
triggered as part of open_file_ntcreate(..., "file:AFP_AfpResource", ...):

after SMB_VFS_OPEN() has been called with O_CREAT, what created the file, we
call SMB_VFS_FSTAT() on the just created filehandle. This ends up in
ad_convert(), finds the resource fork empty and thus deletes the file.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13958

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 8ed9b6b457923d2353d1d18838f4a278db48c6b9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/436356f8d00149f0b3fe0a510cd8aea21167786f">436356f8</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-13T08:52:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: add a forward declaration for ad_get()

Will be needed in the next commit.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13958

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 4777d1163a7c18c89ce9be955903427a18134415)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/090e8700af31c0b9fd273e91a0deb8d1efd3ef24">090e8700</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-06-13T09:28:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.5...

and re-enable GIT_SNAPSHOT.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
(cherry picked from commit 827b5423c0fe6ad472226b6d172e0460d074135a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0b9da247534f735fa96141e9285fd22e0f2bb442">0b9da247</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-06-13T09:28:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-12435 rpc/dns: avoid NULL deference if zone not found in DnssrvOperation

We still want to return DOES_NOT_EXIST when request_filter is not 0.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13922

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d32b96aeff0022c7a9052f15adbc7cd36643ca22">d32b96ae</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-06-13T09:28:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-12435 rpc/dns: avoid NULL deference if zone not found in DnssrvOperation2

We still want to return DOES_NOT_EXIST when request_filter is not 0.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13922

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c48920093da7f5f6cbbca42d516b86b9cf51eea6">c4892009</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-06-13T09:30:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-12436 dsdb/paged_results: ignore successful results without messages

So that we don't dereference result->msgs[0] when it doesn't exist.
This can happen when the object has changed in such a way that it no
longer matches the original search query.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13951

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bfa9f92e611e3b634c505b9c4a2c7aef128afb64">bfa9f92e</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-06-13T09:53:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.10.5.

CVE-2019-12436 dsdb/paged_results: ignore successful results without messages
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13951

CVE-2019-12435 rpc/dns: avoid NULL deference if zone not found in DnssrvOperation2
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13922

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0953917629bb2e21a41013f50def0c9402d5399a">09539176</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-06-13T09:53:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.10.5 release.

CVE-2019-12436 dsdb/paged_results: ignore successful results without messages
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13951

CVE-2019-12435 rpc/dns: avoid NULL deference if zone not found in DnssrvOperation2
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13922

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/881793d52d9a35d7cce814ae5f2cdf8273a7cfee">881793d5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-13T13:55:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: change trigger points of AppleDouble conversion

This moves the trigger points where AppleDouble file conversion is run by
ad_convert() from deep down the callchain in ad_read_rsrc_adouble() to high
level VFS entry points.

Currently ad_convert() will be triggered as part of open_file_ntcreate(...,
"file:AFP_AfpResource", ...): after SMB_VFS_OPEN() has been called with O_CREAT,
what created the file, we call SMB_VFS_FSTAT() on the just created
filehandle. This ends up in ad_convert(), finds the resource fork empty and thus
deletes the file.

This commit moves calling of the conversion funtion to the high level VFS entry
points where the converted metadata is needed:

o for directory enumerations SMB_VFS_READDIR_ATTR() is called to fill in the
  repurposed fields in the directory entry metadata

o obviously for SMB_VFS_CREATE_FILE() on an macOS stream

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13958

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 78a4639b2d06cc69788861618d2e91945e142d2b)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Thu Jun 13 13:55:35 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/734d72bdc968662c33288437e0ed1b877a8c7807">734d72bd</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-06-19T07:22:20Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge tag 'samba-4.10.5' into v4-10-test

samba: tag release samba-4.10.5

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/70e8344a0438def6fffee4c7eabdae25980cff5c">70e8344a</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-06-19T07:24:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.6...

GIT_SNAPSHOT is still enabled in v4-10-test.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f830628c3aaf7e7e6243b889c67dfe661f568f24">f830628c</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-06-21T06:49:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "s3/vfs_glusterfs: Dynamically determine NAME_MAX"

This reverts commit 8e3a042eb9e502821b147f1bbb2d98d59f17a095.

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bb6884042272b943449a225a76d7fab18c2ca00f">bb688404</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-06-21T06:49:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "s3/vfs_glusterfs_fuse: Dynamically determine NAME_MAX"

This reverts commit e28d172b00cadf492c22bd892e2dda3bf2fe2d70.

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/778448469bbe68b2942083a4c9b020717213ed25">77844846</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-06-21T06:49:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/vfs_glusterfs: Avoid using NAME_MAX directly

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13872

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fa1de54cd92c96bbf914eb39d712f59d5a2f3160">fa1de54c</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-06-21T06:49:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/vfs_glusterfs_fuse: Avoid using NAME_MAX directly

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13872

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Tue Jun 11 00:29:19 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/207295b952365c3785a2f2165c3510b3d4864d77">207295b9</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-06-21T06:49:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldap tests: test scheme for referrals

Ensure that the referrals returned in a search request use the same
scheme as the request, i.e. referrals recieved via ldap are prefixed
with "ldap://" and those over ldaps are prefixed with "ldaps://"

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12478

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 6ccf74cf878c295903673e3a1d1ed924a5e87547)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8867c178a9b22f5ed85ec056498ac4647d7f6de5">8867c178</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-06-21T06:49:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldap server: generate correct referral schemes

Ensure that the referrals returned in a search request use the same
scheme as the request, i.e. referrals recieved via ldap are prefixed
with "ldap://" and those over ldaps are prefixed with "ldaps://"

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12478

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri May 24 05:12:14 UTC 2019 on sn-devel-184

(cherry picked from commit 1958cd8a7fb81ec51b81944ecf4dd0fb5c4208fa)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d9fed540c3669564919997cdfb1500e34f397cc5">d9fed540</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-06-21T06:49:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool domain provision: Fix --interactive module in python3

The prompts were not being printed to the screen because the stream
was not being flushed.

As reported on the samba mailing list by Adam Xu:
https://lists.samba.org/archive/samba/2019-March/221753.html

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13828

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Tim Beale <timbeale@catalyst.net.nz>
(cherry picked from commit 31aecee1446c5006771aaa535ae85810bbfb5db0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/49acbea1378152eccb37dc6d25e2855bd7faf461">49acbea1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-06-21T06:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_kv: Skip @ records early in a search full scan

@ records like @IDXLIST are only available via a base search on the specific name
but the method by which they were excluded was expensive, after the unpack the
DN is exploded and ldb_match_msg_error() would reject it for failing to match the
scope.

This uses the fact that @ records have the DN=@ prefix on their TDB/LMDB key
to quickly exclude them from consideration.

Based on analysis by Garming Sam.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13893

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Apr 10 06:23:39 UTC 2019 on sn-devel-144

(cherry picked from commit 49b77d8df2d7113ac7ddb75e78de6628933ff852)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/813856c1c4ee7954e1de8e7112db40a11b8f8001">813856c1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-06-21T06:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb:audit_log: avoid printing "... remote host [Unknown] SID [(NULL SID)] ..."

We better print "... remote host [Unknown] SID [S-1-5-18] ..."
in 'dsdb_audit' message, this matches what we print for
'dsdb_json_audit'.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13916

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 706aba5bf62e674ae12786f6ab275752b8714464)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7f6b171c3e94ab96ed53633657254eaf2d562668">7f6b171c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: add reinit_guest_session_info()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13944

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 8096cc7eb2b36b074ff17a52dc3540be4ecff6bb)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/90a538f4689488a9adc3ab9f504cc9bc1716e1ff">90a538f4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: call reinit_guest_session_info() in the conf updated handler

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13944

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit f4e340a48b6f059a1daa66deb9c26da9e8fcd5e7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d8e33defa5a167d80dc304fffe860345b3a1aaa9">d8e33def</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: allow guest login in the ad_member_idmap_rid env

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13944

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit ac2167eb2349dc1c453e14a65692f16c8ba6532e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b312ceb5730bf76a989d5b0a9744ebfdeca22e27">b312ceb5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: add a test for guest authentication

This verifies that smbd always adds BUILTIN\Guests to the guest token which is
required for guest authentication.

Currently the guest token depends on the on-disk configured group mappings. If
there's an existing group mapping for BUILTIN\Guests, but LOCALSAM\Guest is not
a member, the final guest token won't contain BUILTIN\Guests.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13944

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 0e88f98855e24cfddb55bef65c5910b8e662c630)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/730c24902d5e3dd88ab62072d9f3eaee8657fca2">730c2490</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth: explicitly add BUILTIN\Guests to the guest token

This changes ensures that smbd always adds BUILTIN\Guests to the guest token
which is required for guest authentication.

Currently the guest token depends on the on-disk configured group mappings. If
there's an existing group mapping for BUILTIN\Guests, but LOCALSAM\Guest is not
a member, the final guest token won't contain BUILTIN\Guests.

For SMB2 the flag SMB2_SESSION_FLAG_IS_GUEST will not be set in the final SMB2
SESSION_SETUP response, because smbd sets it based on the token containing the
BUILTIN\Guests SID S-1-5-32-546.

At the same time, the packet is not signed which causes Windows clients and
smbclient to reject the unsigned SMB2 SESSION_SETUP response.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13944

Pair-programmed-with: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jun  5 16:55:26 UTC 2019 on sn-devel-184

(cherry picked from commit a66af4c96accba4ee64eeb1958458b69f3ccec1d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/92bc9e3e11c73429c7f3059991c8673ece58bc55">92bc9e3e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: pass handle to ad_fset()

On the course of removing ad_handle from struct adouble, step 1.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 585d4d49770b4ddc3f7d9dcbb3e322f072767781)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ab9a428f33589225b1d5e1a00c4ee00202c53cf4">ab9a428f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: pass handle to ad_set()

On the course of removing ad_handle from struct adouble, step 2.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit c78ba30ac4534b7037b979ac96b77b834b2eb2fe)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/25ee7f97c6cf7973a359c4aec5831283cd095c05">25ee7f97</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: pass handle to ad_read()

On the course of removing ad_handle from struct adouble, step 3.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit d0abf945e683766029d28915541a4baf9f3879ab)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7a99bba92946a1b61495501ce9f026d789643073">7a99bba9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: pass handle to ad_read_meta()

On the course of removing ad_handle from struct adouble, step 4.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit f8df09157f31b53dbe73eaf4349fc071bfcc1b90)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fd63fda7769e31dc5e907be1dfc90dfbcf22589f">fd63fda7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: indentation fix

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 47721d8d359ef78b8dd4f77f92c30c2caf2c4a80)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9b4ad2a32a620f9d21be095beeb3a5d5c7cc32b8">9b4ad2a3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: use proper VFS function in ad_read_meta()

Continuing to ignore a possible error for now, this is in an error codepath
anyway.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 30ca328c698c2e035e240359bda7c9dcbeb646df)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/03d1328e33bbf8dcbbc8c1c35c72bc5551e8dae4">03d1328e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: pass handle to ad_read_rsrc() and all the way down

On the course of removing ad_handle from struct adouble, step 5.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 661dfa4a19673fdb30d5bf36279cdf867454b947)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/47e08c03ed8d419d6ce021fabab34c09e84f65ef">47e08c03</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: indentation fix

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 400b3c2f8c82b1defe1e321e0cdae486b930344f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4e22296dc6c716c7df4e386ca331c6a0163ad1c5">4e22296d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: pass handle to ad_convert_xattr()

On the course of removing ad_handle from struct adouble, step 7.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit fd2f4cf828ee4c31e3b5a27a79d3a0ee12a5877a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3ff1b960c5efab543e60e7758c4e2e3cfe85234e">3ff1b960</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: pass handle to ad_convert_blank_rfork()

On the course of removing ad_handle from struct adouble, step 8.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit adc7ac38b849b4dce4a85fd6442c8d4b9da57686)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f2b796844b1f8dc8486e7859db8c9798db9562f8">f2b79684</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: pass handle to ad_convert_finderinfo()

On the course of removing ad_handle from struct adouble, step 9.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 50874c1548d62ab0ddaaa6dd4124279ee5029fcf)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ef0522b3434735db2c5e2673709277725e823e3a">ef0522b3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: pass handle to ad_convert_delete_adfile()

On the course of removing ad_handle from struct adouble, step 10.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 5f4d16b40e07acf8d27fee62f1a56de175663a1d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2b8eeb231e0df6a85a51e8d9029deb3789cdae03">2b8eeb23</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: finally, remove ad_handle from struct adouble

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit e266daaed149561b746dbb8d5e9523862f0057b5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8787ac7938c94e7ba21477354afc1059ab804e67">8787ac79</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: add and use is_adouble_file()

This adds a helper function that checks whether the last component of a path is
an AppleDouble sidecar file with "._" name prefix.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit ad70c947c759aa0965ee57f973fb8dc1909e0e39)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/30f25ed6214aca17de70da3482a2b26bbac2ebcd">30f25ed6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: add a missing else

Luckily the missing else has the same control flow due to the previous if and
else blocks calling return.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 44d8568001c87d28962dfc4e3fde6d0f7f409997)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8ceb048644605affc6fbefbb7d14c512d24af79e">8ceb0486</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: ignore AppleDouble files in fruit_unlink()

Otherwise, if SMB_VFS_UNLINK() is called for an AppleDouble path "._file", we
try to delete "._._file" which doesn't make sense. AppleDouble files don't have
AppleDouble themselves.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 797dc649456f39add4af8b54b60db0268ad4e90e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d1164d9f374f4b5f7a95a04a0db6213a7cd1318f">d1164d9f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: use correct case FRUIT_RSRC_STREAM in readdir_attr_rfork_size()

This is a genuine bug, but luckily this would only impact configs which nobody
uses:

  fruit:metadata = netatalk
  fruit:resource = stream

With the above configuration the switch in readdir_attr_rfork_size() would hit
the default case and so always report resource forks as 0 bytes in size.

All deployment that I've seen that use fruit:resource=stream also use
fruit:metadata=stream, so the switch takes FRUIT_META_STREAM case which runs the
correct code readdir_attr_rfork_size_stream().

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 83179a74119de84d20f796c241aae6bccb83a68b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cc1ff660b804c0270a022ce1780078bc62973d15">cc1ff660</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: use stream code for resource fork size calculation in readdir_attr_rfork_size()

This works as well, using an fstat() on the filehandle to get the size. This is
tested by the torture test "vfs.fruit.SMB2/CREATE context AAPL".

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit a23bcc1916a49bf3e0edece190e5434e39862d2c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7bd5ceea7d2d9be05e234ca25dc2b7932b820072">7bd5ceea</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: remove now unused AppleDouble code for resource fork in xattr

This was only needed to get the resourcefork size via the ad_* AppleDouble
function. This is now done with a fstat on the low level xattr fd (remember,
this is Solaris only code...), so we can remove the xattr special casing from
the AppleDouble functions.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit cb9dffa1c66294b6eed85e7576aa99c642d0b541)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8f49fbfdebb6ae61556a533cdf56deaae5cec36e">8f49fbfd</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: remove xattr code from the AppleDouble subsystem

The subsystem consumers have been reworked in the previous commits, so this is
not used anymore. ad_init() doesn't need a handle argument anymore due to this,
remove it as well.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit e3cb1cb24f2a31d7fd03f3bdf417f4704fb4ac7c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f890c4fb86cbb6603da8b040559a4e5704cbe0e4">f890c4fb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: pass VFS handle to ad_convert_move_reso()

Not used for now, that comes next.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 3919ea048fe3b763657e14cdfb5920184a900d27)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9ebfd4f2e5194bad340d2b9093e15730a15c15a0">9ebfd4f2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: remove a layer of indirection

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 97d485ff2cda85edeba163ea01b6abfa705db20f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f5d1561c5b1b2efd99e1fc010d9fe8594dd2620a">f5d1561c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: only do cross protocol locking on non-internal opens

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit f5f7d1e9bf7e39933ccf7c874e682f9df80a6fec)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d49df05e619876b4ea986bdc7d51bb3eaf685c2f">d49df05e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: convert ad_open_rsrc() to open a proper fsp with SMB_VFS_CREATE_FILE()

A first step in converting all raw syscalls to use proper VFS functions. All
existing users of the raw system filedescriptor continue to use the fd from
fsp->fh for now.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 29418c726be74feb1d8c3ac9f7b8c983901a2aab)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7fc300d4655423e7d3daa3e6261c43d6a3805e27">7fc300d4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: remove use of mmap() from ad_convert_move_reso()

We now have an fsp that we can use, so we can get rid of mmap() and
sys_pread()/sys_pwrite().

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 0041855af0b05d6c47558880d6eebd1970179272)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fef47b90e5411c641b5ce8842bbe035e4ea51f0c">fef47b90</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: use fsp and remove mmap in ad_convert_xattr()

No need to mmap() anyway, the xattr data is already available in ad->ad_data.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 4ff7ea0e0312c737aefd350f7b8fbed4c8602325)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/28cdc4421c2a93f187b58e709c475881929e0d37">28cdc442</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: add VFS handle to ad_convert_truncate()

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 4e44b1da9357120f0ad74e24c650bc6386085c47)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/91ed0f8beb951de5c13c170e3ce49408256d91d2">91ed0f8b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: use VFS function in ad_convert_truncate()

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 3739ad90cf2bbaa2094a34197c894363d2e24a5a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2d6a2080afb8d2c9c3734904acf7b3e9f75445a1">2d6a2080</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: use fsp and remove syscalls from ad_convert_blank_rfork()

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 70c4a8f0ac307009c26e857523192c95b42a92f5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bdc257a1cbac7e8c73a084b618ba642476807483">bdc257a1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: use VFS functions in ad_read_rsrc_adouble()

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 9fe84a6345bf5d9fdb1df87a853db3380e6fb0f7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/47a96935df0a1914ca086410c2592cc96f0a378d">47a96935</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: remove a now unnecessary include

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu May 30 22:12:50 UTC 2019 on sn-devel-184

(cherry picked from commit 9a2c9834cb1b77547b8b932c35870301afb9fc25)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4f32284840dd5d80df6676019641fcb276bf763e">4f322848</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-06-21T06:49:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Improve documentation of "lanman auth" and "ntlm auth" connection

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13981

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit dbf3e81f7f0b28c69dca004b32ea3a7344b0cad3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7c80167e2af0afbf530b39efd677cdbffb32ad54">7c80167e</a></strong>
<div>
<span>by Rafael David Tinoco via samba-technical</span>
<i>at 2019-06-21T06:49:34Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Fix tcp_tw_recycle existence check

net.ipv4.tcp_tw_recycle has been removed from Linux 4.12 but, still,
makes sense to check its existence. Unfortunately, current check does
not test for the procfs file existence. This commit fixes the issue.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13984

Signed-off-by: Rafael David Tinoco <rafaeldtinoco@ubuntu.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Jun  4 23:31:24 UTC 2019 on sn-devel-184

(cherry picked from commit 843fbb1207ee7ac84f3282974b66b9290d8da0ac)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d106f5eb9718d4f4e6305101709045314fde03a1">d106f5eb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-06-21T06:49:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: fix flex compilation error

[4440/4495] Compiling bin/default/source3/rpc_server/mdssvc/sparql_lexer.lex.c
../../source3/rpc_server/mdssvc/sparql_lexer.l:26: error: "yyalloc" redefined [-Werror]
26 | #define yyalloc SMB_MALLOC

Looks like the dirty redefine trick doesn't work anymore with newer flex
versions. According to the flex manual the right thing to do is to provide own
functions for yyalloc and yyrealloc when passing the options "noyyalloc
noyyrealloc".

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13987

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue May 28 11:49:06 UTC 2019 on sn-devel-184

(cherry picked from commit 9053391f86a529e0a7dbcd23fa3a555d85c2207c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/48c47f5dbbb2722a718103267d4a0a40b4eaa6a0">48c47f5d</a></strong>
<div>
<span>by Lukas Slebodnik</span>
<i>at 2019-06-21T11:14:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Use native waf timer

  __main__:1: DeprecationWarning: time.clock has been deprecated in Python 3.3
  and will be removed from Python 3.8: use time.perf_counter
  or time.process_time instead

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13998

Signed-off-by: Lukas Slebodnik <lslebodn@fedoraproject.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 8f082904ce580f1a6b8a06ebcc323c99e892bd1f)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Fri Jun 21 11:14:16 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9218655399fd0ef3691dfea25d5f39b32b25fa59">92186553</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-06-26T07:30:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:client: Link smbspool_krb5_wrapper against krb5samba

Heimdal doesn't provide krb5_free_unparsed_name(), so we need to use the
function we provide in krb5samba.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 9268919e046190c7b423133de3f9d0edada3f1b8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1970eadd1231589177dbf75031072636141060e2">1970eadd</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-06-26T07:30:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Document DCEPRC binding string for rpcclient

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Feb  4 02:03:56 CET 2019 on sn-devel-144

(cherry picked from commit cca48c1a1029685672e1c25e39e8be2be947238f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/662d66dcd3c7e23eed4f4131c62b8c22692e23b8">662d66dc</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2019-06-26T07:30:27Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: add test for samba-tool ntacl get/set --use-ntvfs --xattr-backend=tdb

Signed-off-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 1b0184a9562689a658e75a0cfc69bdd23277cff6)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14002
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f8d504acb4c380f1de14ed750897218878617c4d">f8d504ac</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2019-06-26T11:37:29Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/ntacls: use correct "state directory" smb.conf option instead of "state dir"

samba-tool ntacl get testfile --xattr-backend=tdb --use-ntvfs
Fixes: Unknown parameter encountered: "state dir"

Signed-off-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 670a12df52df63a067b638d37bec71341bf18bdd)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14002

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Wed Jun 26 11:37:29 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8052d52b26f9ed00e1e479e6b0e43e83c26d9b4b">8052d52b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-07-03T10:21:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Release ldb 1.5.5

Compared to 1.5.4:

* LDAP_REFERRAL_SCHEME_OPAQUE was added
  to ldb_module.h in order to fix bug #12478.
  It means that Samba >= 4.10.6 will no longer be able to
  build with ldb 1.5.4.

* We Skip @ records early in a search full scan
  in order to address bug #13893.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12478

Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9f1a6fe7f27c74e3b72c2668c60c938d2024bb9b">9f1a6fe7</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-07-08T09:56:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.10.6.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9c67187029b1721656b8f3233339283e482d693c">9c671870</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-07-08T09:57:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.10.6 release.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/372ee3829399b703926616cdbad69ebd36870f44">372ee382</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-07-08T09:58:35Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.7...

and re-enable GIT_SNAPSHOT.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8128ceceb8702e596183dd509dd6f952a2f4efc2">8128cece</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-07-09T06:33:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Allow build when --disable-gnutls is set

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13844

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Wed Mar 20 05:25:48 UTC 2019 on sn-devel-144

(cherry picked from commit a40b0f452af5f393aa33c9d52673994effd0e31f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4179bdb6f2aaaa4841f4c3381ad8ac68f17f0eaa">4179bdb6</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-09T06:33:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/pyrpc_util: appropriately decrement refcounts on failure

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
(cherry picked from commit e23b9f88cc1c8a8c8cda07fb25d639218c12d91a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4f70d4d76a02717bc5d73ab51f936b224b8a6394">4f70d4d7</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-07-09T06:33:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4 librpc rpc pyrpc: Ensure tevent_context deleted last

Ensure that the tevent_context is deleted after the connection, to
prevent a use after free.

Note: Py_DECREF calls dcerpc_interface_dealloc so the
TALLOC_FREE(ret->mem_ctx) calls in the error paths of
py_dcerpc_interface_init_helper needed removal.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13932

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit d65b7641c84976c543ded8f0de5ab2da3c19b407)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/58760fe8b72e74bb0e62c8d30c7de35bfcfb4055">58760fe8</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-07-09T06:33:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4 librpc rpc pyrpc: Fix flapping dcerpc.bare tests

Commit d65b7641c84976c543ded8f0de5ab2da3c19b407 had the parameters to
talloc_reparent reversed.  This caused the dcerpc.bare tests to flap.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13932

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Wed May 22 03:03:43 UTC 2019 on sn-devel-184

(cherry picked from commit 3e6661fd73bb24ef5700a98f676f1df5eeca408b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e9c23a024707bb54edcf2b755ed3f27fbc4325f4">e9c23a02</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-07-09T06:33:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server:netlogon: don't require NEG_AUTHENTICATED_RPC in netr_ServerAuthenticate*()

The domain join with VMWare Horizon Quickprep seems to use
netr_ServerAuthenticate3() with just the NEG_STRONG_KEYS
(and in addition the NEG_SUPPORTS_AES) just to verify a password.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13464 (maybe)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13949

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit ead9b93ce5c2c67bbdb778232805d6d9e70112fc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b7f586ca6c996213732ea6574f1dc7ad5915983b">b7f586ca</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-07-09T06:33:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server:netlogon: don't require NEG_AUTHENTICATED_RPC in netr_ServerAuthenticate*()

The domain join with VMWare Horizon Quickprep seems to use
netr_ServerAuthenticate3() with just the NEG_STRONG_KEYS
(and in addition the NEG_SUPPORTS_AES) just to verify a password.

Note: NETLOGON_NEG_SCHANNEL is an alias to NEG_AUTHENTICATED_RPC.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13464 (maybe)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13949

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit fa5215ce5b93fb032df341e718d7011e619f0916)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1f0870a7b28c5485e1b8131088ff16fca4d04f15">1f0870a7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-07-09T06:33:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server:netlogon: simplify AUTH_TYPE_SCHANNEL check in netr_creds_server_step_check()

The gensec schannel module already asserts that at least
AUTH_LEVEL_INTEGRITY is used.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13949

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 0b6e37c9e801435e094194dd60d9213b4868c3de)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/27bd08f36bda8ab362c7a69a2137734e22a42c48">27bd08f3</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-07-09T06:33:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Handle DB corner-case where PSO container doesn't exist

A 2003 AD DB with functional level set to >= 2008 was non-functional
due to the PSO checks.

We already check the functional level is >= 2008 before checking for the
PSO container. However, users could change their functional level
without ensuring their DB conforms to the corresponding base schema.

The objectclass DSDB module should prevent the PSO container from ever
being deleted. So the only way we should be able to hit this case is
through upgrading the functional level (but not the underlying schema
objects). If so, log a low-priority message and continue without errors.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14008
RN: Previously, AD operations such as user authentication could fail
completely with the message 'Error 32 determining PSOs in system' logged
on the samba server. This problem would only affect a domain that was
created using a pre-2008 AD base schema and then had its functional
level manually raised to 2008 or greater. This issue has now been
resolved.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 295bf73e9b24b1f2b4594320a6501dc7410d4b43)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/01a7df07fc92c8e1d73749585432d5071a6f460a">01a7df07</a></strong>
<div>
<span>by Michael Adam</span>
<i>at 2019-07-09T06:33:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs:glusterfs: treat ENOATTR as ENOENT

The original implementation of the virtual xattr get_real_filename
in gluster was misusing the ENOENT errno as the authoritative anwer
that the file/dir that we were asking the real filename for does not
exist. But since the getxattr call is done on the parent directory,
this is a violation of the getxattr API which uses ENOENT for the
case that the file/dir that the getxattr call is done against does
not exist.

Now after a recent regression for fuse-mount re-exports due to
gluster mapping ENOENT to ESTALE in the fuse-bridge, the gluster
implementation is changed to more correctly return ENOATTR if the
requested file does not exist.

This patch changes the glusterfs vfs module to treat ENOATTR as ENOENT
to be fully functional again with latest gluster.

- Without this patch, samba against a new gluster will work correctly,
  but the get_real_filename optimization for a non-existing entry
  is lost.

- With this patch, Samba will not work correctly any more against
  very old gluster servers: Those (correctly) returned ENOATTR
  always, which Samba originally interpreted as EOPNOTSUPP, triggering
  the expensive directory scan. With this patch, ENOATTR is
  interpreted as ENOENT, the authoritative answer that the requested
  entry does not exist, which is wrong unless it really does not exist.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14010

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 8899eb21d48b7077328ae560490f9fb9715a6b83)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4743188456f7da4023890d17f699a88780525291">47431884</a></strong>
<div>
<span>by Michael Adam</span>
<i>at 2019-07-09T06:33:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs:glusterfs_fuse: treat ENOATTR as ENOENT

The original implementation of the virtual xattr get_real_filename
in gluster was misusing the ENOENT errno as the authoritative anwer
that the file/dir that we were asking the real filename for does not
exist. But since the getxattr call is done on the parent directory,
this is a violation of the getxattr API which uses ENOENT for the
case that the file/dir that the getxattr call is done against does
not exist.

Now after a recent regression for fuse-mount re-exports due to
gluster mapping ENOENT to ESTALE in the fuse-bridge, the gluster
implementation is changed to more correctly return ENOATTR if the
requested file does not exist.

This patch changes the glusterfs_fuse vfs module to treat ENOATTR as
ENOENT to be fully functional again with latest gluster.

- Without this patch, samba against a new gluster will work correctly,
  but the get_real_filename optimization for a non-existing entry
  is lost.

- With this patch, Samba will not work correctly any more against
  very old gluster servers: Those (correctly) returned ENOATTR
  always, which Samba originally interpreted as EOPNOTSUPP, triggering
  the expensive directory scan. With this patch, ENOATTR is
  interpreted as ENOENT, the authoritative answer that the requested
  entry does not exist, which is wrong unless it really does not exist.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14010

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Fri Jun 28 12:52:03 UTC 2019 on sn-devel-184

(cherry picked from commit fee8cf326bfe240d3a8720569eab43f474349aff)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b56e010af12908e4291231172eb67306e14de9a6">b56e010a</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-07-09T10:31:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/libnet: Fix joining a Windows pre-2008R2 DC

>From v4.8 onwards, Samba may not be able join a DC older than 2008R2
because the Windows DC doesn't support GET_TGT.

If the dsdb repl_md code can't resolve a link target it returns an
error, and the calling code (e.g. drs_util.py) should retry with
GET_TGT. However, GET_TGT is only supported on Windows 2008R2 and later,
so if you try to join an earlier Windows DC, the join will throw an
error that you can't work-around.

We can avoid this problem by setting the same DSDB flag that GET_TGT
sets to indicate that the link targets are as up-to-date as possible,
and so there's no point retrying. Missing targets are still logged, so
this at least allows the admin to fix up any problems after the join
completed.

I've only done this for the join case (problems during periodic
replication are probably still worth escalating to an error).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14021
RN: From Samba v4.8 onwards, joining a Windows 2003 or 2008 (non-R2) AD
DC may not have worked. When this problem occurred, the following
message would be displayed:
 'Failed to commit objects: DOS code 0x000021bf'
This particular issue has now been resolved. Note that there may still
be other potential problems that occur when joining an older Windows DC.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit b3a2508f2ad79e2f1007464da7dbe918933038a0)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Tue Jul  9 10:31:40 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fdec94ba7c4da37d3ee7d1507cd41ed83e31291a">fdec94ba</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-08T07:30:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/util: fix call to dbghdrclass() for DEBUGC()

dbghdrclass() sets the global 'current_msg_class' and for that
DEBUGC() should pass the given dbgc_class instead of the per file
DBGC_CLASS.

This is important with the new per class logfile with:

 log level = 1 dsdb_audit:10@/var/log/samba/log.dsdb_audit

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13915

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit bb0ffbf38cb1955c9e400003add680eabcf706a6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/823d57094b992d4287487932c72d308f4d94d6a3">823d5709</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-08T07:30:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/util: remove unused prototypes in debug.h

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13915

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit d98a971247450d494c581c5454e6c270ad1b6880)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1dcb5dc3844b65cee056f552a0565abf210942dd">1dcb5dc3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-08T07:30:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/util: set current_msg_{level,class} also during a DEBUGADD[C]() call

In some situations we use DEBUGADDC() in order to print out content
without a related debug header line.

This is important with the new per class logfile with:

 log level = 1 dsdb_json_audit:10@/var/log/samba/log.dsdb_json_audit

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13915

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 0da12ff93d213ac742eeb865bfa5697ca8a2280a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c51d810ee99fd971f007e2262ff945bd835c7ae8">c51d810e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-08T07:30:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Update waf to version 2.0.17

This fixes building Samba, libtalloc, libtevent, libtdb and libldb with
Python 3.8.

     wget https://waf.io/waf-2.0.17.tar.bz2
     tar -xf waf-2.0.17.tar.bz2
     git rm third_party/waf/waflib/ -r
     mkdir third_party/waf -p
     rsync -a waf-2.0.17/waflib/ third_party/waf/waflib/
     git add third_party/waf/waflib/

(Then update version number in buildtools/bin/waf and
buildtools/wafsamba/wafsamba.py)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13960

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit aabdcc91513e242c4f191e1bbbb70c890416d213)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bbe41dc7806faab7f61363be4524800c1372dca2">bbe41dc7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-08T07:30:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbcheck: fallback to the default tombstoneLifetime of 180 days

If a domain was provisioned by Windows 2000 this value is missing in the
database.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13967

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue May 28 08:32:10 UTC 2019 on sn-devel-184

(cherry picked from commit 2ef79a4c1d695a3e498b142810a1317d85b9b6da)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7dbde4521fe6dd7f9b958bb4a2cb1f340bdbfcaa">7dbde452</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-08T07:30:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: add local.ndr.dnsp tests

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13969

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit 9a0c3a475f29138c0c49e0d22cf52ab45178d16b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e7dfe3f7f77d42991dd32095dced1ac821ddeab0">e7dfe3f7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-08T07:30:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dnsp.idl: fix dnsp_ip4_array definition

In future we should use ipv4address, but that would result in a much
larger change.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13969

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit 6d958af0b4cb6fd45cfda0298243859b3b043c6f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d2087e4b4806940ef398d97133a3842a40951810">d2087e4b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-08T07:30:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dnsp.idl: fix the dnsp_dns_addr_array definition

The endian changes are needed in order to get the following result
from the blobs Windows generated (see the torture test):

  AddrArray: ARRAY(3)
      AddrArray: struct dnsp_dns_addr
          family                   : 0x0002 (2)
          port                     : 0x0035 (53)
          ipv4                     : 172.31.99.33
          ipv6                     : 0000:0000:0000:0000:0000:0000:0000:0000

[MS-DNSP] states that the port is supposed to be ignored, but it's still
good to decode it as port '53' (0x0035) instead of '13568' (0x3500).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13969

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit 6fc7cc15048673d109042d7b40684ed63eb4ff9e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b2849a889f3ec3907e67ea6a4f87435528123588">b2849a88</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-08T07:30:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dnsp.idl: fix payload for DSPROPERTY_ZONE_DELETED_FROM_HOSTNAME

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13969

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Jun 21 11:02:21 UTC 2019 on sn-devel-184

(cherry picked from commit aa2a3d95098231f48d7c308881bf66418164111e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/65c4f4125095262fbea3c973e32b3cb58ac9bf3b">65c4f412</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2019-08-08T07:30:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture:fsmo.py: test role transfers of dns partitions

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13973

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Björn Baumbach <bbaumbach@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 5e000a8487d788dd196980b77ec7299c8be74abf)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cfce211fff116a104d3a4fbd9198cd5470f07ef3">cfce211f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-08T07:30:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: fix replication after dns partition fsmo role transfer

The new role owner need to replicate from the old role owner.

Before we told the old role owner to replicate from itself.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13973

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 4793f8ed584a4e6d8a26b06b691ec636e77d8f2a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/4d7ce477eb0c7d47faf81b910c2b88f6779cb744">4d7ce477</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2019-08-08T07:30:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture:fsmo.py: remove unused 'net_cmd' variable

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13973

Signed-off-by: Björn Baumbach <bbaumbach@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 0fbb013bef886e425602fdbbef14a4029719818f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7788b9f30395df499396510300429f76e0a431db">7788b9f3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-08T07:30:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: use only one LDAP modify for dns partition fsmo role transfer

We should not risk that we end with no role owner.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13973

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 6a2e3a15585086bcceb18283216978a2fcb30da3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/376bed3a0e6e37af3a23e15283fc560a84e9fe6a">376bed3a</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2019-08-08T07:30:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: add 'import samba.drs_utils' to fsmo.py

On some systems we're seeing this:

 ERROR(<type 'exceptions.AttributeError'>): uncaught exception - 'module' object has no attribute 'drs_utils'
   File "/usr/lib/python2.7/dist-packages/samba/netcmd/__init__.py", line 185, in _run
     return self.run(*args, **kwargs)
   File "/usr/lib/python2.7/dist-packages/samba/netcmd/fsmo.py", line 533, in run
     transfer_dns_role(self.outf, sambaopts, credopts, role, samdb)
   File "/usr/lib/python2.7/dist-packages/samba/netcmd/fsmo.py", line 136, in transfer_dns_role
     except samba.drs_utils.drsException as e:

E.g. it happens on debian stretch (9.9) with python 2.7.13 (on 4.10.4)

While it doesn't happen on ubuntu 18.04 with python 2.7.15rc1 or
with python 3.6.7.

There were also some reports on the mailing lists, see:
https://lists.samba.org/archive/samba-technical/2019-May/133624.html

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13973

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Björn Baumbach <bbaumbach@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu May 30 08:27:24 UTC 2019 on sn-devel-184

(cherry picked from commit 320a5c5425e6ced18b1a9bf19b4f361ee16821ed)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b0ebe62fe51e42c6a78a16af68f2aec0424d5b7a">b0ebe62f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T07:30:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_catia: pass stat info to synthetic_smb_fname()

This doesn't cause visible damage in vanilla Samba, but would affect downstream
consumers that add additional fields to struct smb_filename.

For the same reason there's no test.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14015
RN: Ensure vfs_catia passes stat info to stacked VFS modules

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit ae6dd4853e3e651f6e56ce735bcb0a2264857385)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f839423bdab6133720c7a26c4a2300a828c74c14">f839423b</a></strong>
<div>
<span>by Rafael David Tinoco</span>
<i>at 2019-08-08T07:30:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-config: depend on /etc/ctdb/nodes file

CTDB should start as a disabled unit (systemd) in most of the
distributions and, when trying to enable it for the first time, user
should get an unconfigured, or similar, error.

Depending on /etc/ctdb/nodes file will give a clear direction to final
user on what is needed in order to get cluster up and running. It should
work like previous ENABLED=NO variables in SySV like initialization
scripts.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14017
RN: ctdb.service should only start if /etc/ctdb/nodes is not empty
Signed-off-by: Rafael David Tinoco <rafaeldtinoco@ubuntu.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit c5803507df7def388edcd5b6cbfee30cd217b536)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9dac4d85ad0dc52f5b08f048c529f386a0b436c8">9dac4d85</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-08-08T07:30:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">join: Use a specific attribute order for the DsAddEntry nTDSDSA object

Joining a Windows domain can throw an error if the HasMasterNCs
attribute occurs before msDS-HasMasterNCs. This patch changes the
attribute order so that msDS-HasMasterNCs is always first.

Previously on python2, the dictionary hash order was arbitrary but
constant. By luck, msDS-HasMasterNCs was always before HasMasterNCs, so
we never noticed any problem. With python3, the dictionary hash order
now changes everytime you run the command, so the order is
unpredictable.

To enforce a order, we can change to use an OrderedDict, which will
return the keys in the order they're added.

I've asked Microsoft to clarify the protocol requirement here WRT
attribute order. However, in the meantime we may as well fix the problem
for users.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14046
RN: When trying to join a Windows domain (with functional level 2008R2)
as an AD domain controller, the 'samba-tool domain join' command could
throw a python exception: 'RuntimeError ("DsAddEntry failed")'. When
this problem occurred, you would also see the message "DsAddEntry failed
with status WERR_ACCESS_DENIED info (8363, 'WERR_DS_NO_CROSSREF_FOR_NC')"
in the command output. This issue has now been resolved. Note that this
problem would only occur on Samba v4.10 when using the Python3 packages.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jul 24 04:18:21 UTC 2019 on sn-devel-184

(cherry picked from commit 256684c7a86301d26d6cf7298fb70e647bf45cf5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1d2c7ee7061461940a2952b6855db85a21afa494">1d2c7ee7</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2019-08-08T07:30:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Allow drs replicate --local to create partitions

Currently, neither the offline (--local) or online (normal replica sync)
methods allow partition creation post-join. This overrides the Python
default to not create the DB, which allows TDB + MDB to work.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14051

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit d90ccce59754bc833027c06683afac25f7a8d474)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf70fc0985259ce3ea97f1b2bcc48b9518a24e41">bf70fc09</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2019-08-08T07:30:13Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add samba_upgradedns to the list of possible cmds

This will be used to test the replication scenario with no DNS partitions

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14051

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 7d2875bd70cf727730be8dc705bfd01eacaaaa6f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bf28f9d7bef49d91ebe86a59b70da5add025def5">bf28f9d7</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2019-08-08T11:15:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/drs_no_dns: Check dbcheck and ldapcmp pass

When joining a DC without DNS partitions, make sure that the alternate
flow of creating them afterwards results in a database with everything
that is necessary.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14051
RN: Allow a DC join without DNS partitions, to add them later

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 35c54007e6183829d9d85a24b3bd95f469739ad3)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Thu Aug  8 11:15:54 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a89157e5535cdf28f1a30c2e98016d857f865cea">a89157e5</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2019-08-16T09:48:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture/rpc/lsa: allow testing different lookup levels

Convert torture/rpc/lsa LookupNames/LookupSids code to allow testing
different LSA_LOOKUP_NAMES_* levels. Keep existing level 1
(LSA_LOOKUP_NAMES_ALL) for the current set of tests.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14091

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

(cherry picked from commit 317bc6a7342edfa2c503f5932142bf5883485cc9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/692e9e1f411f94523be774f2c57fd300739729f3">692e9e1f</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2019-08-16T09:48:19Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lookup_name: allow own domain lookup when flags == 0

In 2007, we've added support for multiple lookup levels for LSA
LookupNames family of calls. However, forest-wide lookups, as described
in MS-LSAT 2.2.16, never worked because flags passed to lookup_name()
were always set to zero, expecting at least default lookup on a DC to
apply. lookup_name() was instead treating zero flags as 'skip all
checks'.

Allow at least own domain lookup in case domain name is the same.
This should allow FreeIPA DC to respond to LSA LookupNames3 calls from a
trusted AD DC side.

For the reference, below is a request Windows Server 2016 domain
controller sends to FreeIPA domain controller when attempting to look up
a user from a trusted forest root domain that attemps to login to the
domain controller. Notice the level in the lsa_LookupNames3 call and
resulting flags in lookup_name().

[2019/08/03 07:14:24.156065,  1, pid=23639, effective(967001000, 967001000), real(967001000, 0), class=rpc_parse] ../../librpc/ndr/ndr.c:471(ndr_print_function_debug)
       lsa_LookupNames3: struct lsa_LookupNames3
          in: struct lsa_LookupNames3
              handle                   : *
                  handle: struct policy_handle
                      handle_type              : 0x00000000 (0)
                      uuid                     : 0000004c-0000-0000-455d-3018575c0000
              num_names                : 0x00000001 (1)
              names: ARRAY(1)
                  names: struct lsa_String
                      length                   : 0x000a (10)
                      size                     : 0x000c (12)
                      string                   : *
                          string                   : 'XS\ab'
              sids                     : *
                  sids: struct lsa_TransSidArray3
                      count                    : 0x00000000 (0)
                      sids                     : NULL
              level                    : LSA_LOOKUP_NAMES_UPLEVEL_TRUSTS_ONLY2 (6)
              count                    : *
                  count                    : 0x00000000 (0)
              lookup_options           : LSA_LOOKUP_OPTION_SEARCH_ISOLATED_NAMES (0)
              client_revision          : LSA_CLIENT_REVISION_2 (2)
[2019/08/03 07:14:24.156189,  6, pid=23639, effective(967001000, 967001000), real(967001000, 0), class=rpc_srv] ../../source3/rpc_server/rpc_handles.c:339(find_policy_by_hnd_internal)
  Found policy hnd[0] [0000] 00 00 00 00 4C 00 00 00   00 00 00 00 45 5D 30 18   ....L... ....E]0.
  [0010] 57 5C 00 00                                        W\..
[2019/08/03 07:14:24.156228,  4, pid=23639, effective(967001000, 967001000), real(967001000, 0)] ../../source3/smbd/sec_ctx.c:215(push_sec_ctx)
  push_sec_ctx(967001000, 967001000) : sec_ctx_stack_ndx = 2
[2019/08/03 07:14:24.156246,  4, pid=23639, effective(967001000, 967001000), real(967001000, 0)] ../../source3/smbd/uid.c:552(push_conn_ctx)
  push_conn_ctx(0) : conn_ctx_stack_ndx = 0
[2019/08/03 07:14:24.156259,  4, pid=23639, effective(967001000, 967001000), real(967001000, 0)] ../../source3/smbd/sec_ctx.c:319(set_sec_ctx_internal)
  setting sec ctx (0, 0) - sec_ctx_stack_ndx = 2
[2019/08/03 07:14:24.156273,  5, pid=23639, effective(967001000, 967001000), real(967001000, 0)] ../../libcli/security/security_token.c:53(security_token_debug)
  Security token: (NULL)
[2019/08/03 07:14:24.156285,  5, pid=23639, effective(967001000, 967001000), real(967001000, 0)] ../../source3/auth/token_util.c:865(debug_unix_user_token)
  UNIX token of user 0
  Primary group is 0 and contains 0 supplementary groups
[2019/08/03 07:14:24.156311,  5, pid=23639, effective(0, 0), real(0, 0), class=rpc_srv] ../../source3/rpc_server/lsa/srv_lsa_nt.c:244(lookup_lsa_sids)
  lookup_lsa_sids: looking up name XS\ab
[2019/08/03 07:14:24.156327, 10, pid=23639, effective(0, 0), real(0, 0)] ../../source3/passdb/lookup_sid.c:112(lookup_name)
  lookup_name: XS\ab => domain=[XS], name=[ab]
[2019/08/03 07:14:24.156340, 10, pid=23639, effective(0, 0), real(0, 0)] ../../source3/passdb/lookup_sid.c:114(lookup_name)
  lookup_name: flags = 0x00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14091

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

(cherry picked from commit 685bb03de6ab733590831d1df4f5fd60d2ac427d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/aabd5558bcfdaf095eead53004983023069e4a0a">aabd5558</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2019-08-16T14:24:42Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbtorture: extend rpc.lsa to lookup machine over forest-wide LookupNames

Add a simple test to resolve DOMAIN\MACHINE$ via LSA LookupNames3
using LSA_LOOKUP_NAMES_UPLEVEL_TRUSTS_ONLY2 level. This level would pass
zero lookup flags to lookup_name().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14091

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Wed Aug 14 13:07:42 UTC 2019 on sn-devel-184

(cherry picked from commit 4d276a93fc624dc04d880f5b4157f272d3555be6)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Fri Aug 16 14:24:42 UTC 2019 on sn-devel-144
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/db1d9ca55b6eaf4d8af6f62c85a618c156b9508c">db1d9ca5</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-08-20T09:08:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.10.7.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c0f6317dade9901fa0bdea9e7020fca46c8da1b4">c0f6317d</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-08-20T09:09:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.10.7 release.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3677f5c5e61e595457c6ad0514d11cfbbc435bc5">3677f5c5</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T19:15:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-libs: Fix Breaks+Replaces: libndr-standard0 (<< 2:4.0.9) (Closes: #910242)

(cherry picked from commit d5ca39f63f6be92d44868f532c70a3506afe5158)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/82cbadf130dd08db5113aa9450e17c96d62081cb">82cbadf1</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T19:15:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add missing Breaks+Replace found by piuparts (Closes: #929217)

Thanks Andreas Beckmann!

(cherry picked from commit a3d20ae6bdcb03c0bd893e07943906d3fc91c616)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7d56810becce22e5f82c117cd91557831c448e29">7d56810b</a></strong>
<div>
<span>by Rafael David Tinoco</span>
<i>at 2019-08-22T19:15:49Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">  * debian/rules: Make DEB_HOST_ARCH_CPU initialized through
    dpkg-architecture (Closes: #931138)

(cherry picked from commit 56d100618824c3c94b8fb04e27616769d79dd33c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/10a881b5ed2d022d1a38a868d2c7c3f8ad693af9">10a881b5</a></strong>
<div>
<span>by Rafael David Tinoco</span>
<i>at 2019-08-22T19:16:23Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">* d/p/fix-nfs-service-name-to-nfs-kernel-server.patch: change nfs service name from nfs to nfs-kernel-server (LP: #722201)

Signed-off-by: Rafael David Tinoco <rafaeldtinoco@ubuntu.com>
(cherry picked from commit 4e877694adc1d218bdea57c22f3a54ba83f02549)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e83c4f6acfb313c279324a65c7811dbf8ae44677">e83c4f6a</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T19:16:39Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Adapt fix-nfs-service-name-to-nfs-kernel-server.patch to samba 4.9

(cherry picked from commit 626da08b5e79332576833646adf7fd41458d54c5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1adaf973aa956bbeda91f9273c8eebcb69043174">1adaf973</a></strong>
<div>
<span>by Rafael David Tinoco</span>
<i>at 2019-08-22T19:16:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-config: depend on /etc/ctdb/nodes file

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14017

CTDB should start as a disabled unit (systemd) in most of the
distributions and, when trying to enable it for the first time, user
should get an unconfigured, or similar, error.

Depending on /etc/ctdb/nodes file will give a clear direction to final
user on what is needed in order to get cluster up and running. It should
work like previous ENABLED=NO variables in SySV like initialization
scripts.

Signed-off-by: Rafael David Tinoco <rafaeldtinoco@ubuntu.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 60b20e3cc318392642c4f35f9f6be4d2eb2e0e84)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/263ca163cad7ae01136f30e8603465297cd329d4">263ca163</a></strong>
<div>
<span>by Rafael David Tinoco</span>
<i>at 2019-08-22T19:16:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">  * d/ctdb.install, d/rules: create ctdb run directory into tmpfiles.d
    to allow pid file to exist (Closes: #929931)

(cherry picked from commit 4bf9a3123be92b5ead09b0165134c308eb117e43)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/54ab19c4beab62124f09f9cd5fee5c561f15e4c7">54ab19c4</a></strong>
<div>
<span>by Rafael David Tinoco</span>
<i>at 2019-08-22T19:16:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">  * Allow proper ctdb initalization (Closes: #929931):
    - d/ctdb.dirs: added /var/lib/ctdb/* directories
    - d/ctdb.postrm: remove leftovers from:
      /var/lib/ctdb/{state,persistent,volatile,scripts}

(cherry picked from commit ddde541628aa0ac862e76b6d5753e2ec40d2ef89)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5fc057b7861905e32b8188874d21302bec913dd3">5fc057b7</a></strong>
<div>
<span>by Rafael David Tinoco</span>
<i>at 2019-08-22T19:16:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">  * d/rules: installing provided config examples and helper scripts
  * Examples of NFS HA CTDB config files + helper script:
    - d/ctdb.example.enable.nfs.sh
    - d/ctdb.example.nfs-common
    - d/ctdb.example.nfs-kernel-server
    - d/ctdb.example.services
    - d/ctdb.example.sysctl-nfs-static-ports.conf
    (Closes: #929931)

(cherry picked from commit 699f459ec9e58d1a0704abe9d987dc2414c2c964)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/8bc8a3c07ad320ee3ece9fba38000d6565766e17">8bc8a3c0</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T19:16:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Enable vfs_nfs4acl_xattr (Closes: #930540)

(cherry picked from commit 247316b0b2fb712c506c461459c0138f212a9257)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/347a7dca89f1b2bbe0db51b2351ee3353f516edb">347a7dca</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T19:16:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Ensure fix-nfs-service-name-to-nfs-kernel-server.patch applies with git-am

(cherry picked from commit 538f804cdf6adac96dbcdc5b7cc368946bcd9f5e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9a900f3e1ae7a7ed020c8a3ff98d8efc3c419c80">9a900f3e</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T19:16:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsamba-passdb.so bumped to 0.27.2

See https://bugzilla.samba.org/show_bug.cgi?id=13813 for context

(cherry picked from commit 6f817a90d44d543408838d06f8eb7fe8a2d2e949)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0c68db82e288ef1a5c91a80479d9c60124142ff7">0c68db82</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T19:17:26Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: enable ceph and etcd recovery lock

(cherry picked from commit f91f25c9b9022602a79d4b91c9670e523c16744a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ef94f3c5c2f663087b8d0f46241c205481973de6">ef94f3c5</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T19:17:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Downgrade ctdb_mutex_ceph_rados_helper shlibdeps to recommends

(cherry picked from commit 8dc796a40032942696771a357b501e5a3a15925d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ab7829716e14dc8cb3deefcf1ee6be0ca41decba">ab782971</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T19:17:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add gitlabracadabra.yml

See https://gitlab.com/gitlabracadabra/gitlabracadabra

(cherry picked from commit 41cffa04982e372f08d15bb508f8395f117eba56)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/503c00bddc232e58055af6c795abe638cd3b336b">503c00bd</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T19:17:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Use debian/salsa-ci.yml as ci_config_path

(cherry picked from commit 7f6285890227033b54178cfa74aca687adecaf6f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/42eef5e8bd81e3285d71d41adcf59d48c0ad67dc">42eef5e8</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T19:17:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update salsa-ci.yml

(cherry picked from commit e86ec047bbb03895ecb3a48eaddb9f84269e2c5b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b62f8c1942d2de29e31e065a1b81a3f4b4739a39">b62f8c19</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T19:17:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Allow failure for reprotest job

Until #912340 is fixed

(cherry picked from commit 70ef0bea49bff90bd2d85fd076e34ab1993e5e48)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2f9e8d297bd08c4495c08e515fe229be62491791">2f9e8d29</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T19:17:32Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Allow failure for blhc job

Until #929503 is fixed

(cherry picked from commit a91ba8bf9101986c632dd6959011dece2b11e37a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e0b5c54fdb27fe73dcf24a1c5ce3e0e896f0a041">e0b5c54f</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T20:18:05Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Sync CTDB NFS patches from Ubuntu
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b1b10458dd7ed508fc505b4a0732ffa879935832">b1b10458</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T20:31:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Changelog for previous commits
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/6998ca52a934ca07000844a312bb36983021e50c">6998ca52</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T20:35:30Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update d/gbp.conf, d/watch and d/README.source for 4.10
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b9ee441bfef2d6d114f24296b82dea3ec4237190">b9ee441b</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T21:01:58Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">New upstream version 4.10.7+dfsg</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/7de07a680c4597e462de0b1000c9d6696fda6484">7de07a68</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T21:03:09Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update upstream source from tag 'upstream/4.10.7+dfsg'

Update to upstream version '4.10.7+dfsg'
with Debian dir 49a4ba0d9a1452278d532920d637734d8513c65a</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/64f285314d92c75ff83fbf95cd144075ff66f3b3">64f28531</a></strong>
<div>
<span>by Jelmer Vernooij</span>
<i>at 2019-08-22T21:05:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Always specify rpath for private libraries

Last-Update: 2012-02-24
Applied-Upstream: no
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3350252f3624f0def440a793597dc77b4713681d">3350252f</a></strong>
<div>
<span>by Christian Perrier</span>
<i>at 2019-08-22T21:05:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">64 bit fix for libsmbclient

Bug-Debian: http://bugs.debian.org/221618
Forwarded: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=221618#27
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f583c987df55804efa7bd6be83417d8c3fbd6551">f583c987</a></strong>
<div>
<span>by Christian Perrier</span>
<i>at 2019-08-22T21:05:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Mention smbldap-tools package in examples/LDAP/README

Bug-Debian: http://bugs.debian.org/341934
Forwarded: not-needed
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/ee561a7d4fea0546bc9adacf7eaa7339d570b445">ee561a7d</a></strong>
<div>
<span>by Steve Langasek</span>
<i>at 2019-08-22T21:05:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Use the pager alternative as pager is PAGER is undefined

Bug-Debian: http://bugs.debian.org/135603
Forwarded: not-needed
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/9498bb1eceaeb9dcece3ed0f914133919ab70651">9498bb1e</a></strong>
<div>
<span>by mathiaz@ubuntu.com</span>
<i>at 2019-08-22T21:05:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Enable net usershares by default at build time

Enable net usershares by default at build time, with a limit of 100, and update
the corresponding documentation.

Bug-Debian: http://bugs.debian.org/443230
Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/128548
Forwarded: not-needed
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/105f5006630ce3aba1901331a636fd6acf28ac0c">105f5006</a></strong>
<div>
<span>by Eloy A. Paris</span>
<i>at 2019-08-22T21:05:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add "Debian" as vendor suffix

Forwarded: not-needed
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5b49b51f475bc3fbe292941f4e7a47bb2008926b">5b49b51f</a></strong>
<div>
<span>by Jeroen Dekkers</span>
<i>at 2019-08-22T21:05:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add so version number to private libraries for dpkg-shlibdeps

We also want dpkg-shlibdeps to generate correct dependency information
for the private libraries in our binary packages, but dpkg-shlibdeps
only works when the library has a version number.

Origin: vendor
Forwarded: not-needed
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b8432b5a02718fc3720d1f1447a00966b6b83f61">b8432b5a</a></strong>
<div>
<span>by Brian May</span>
<i>at 2019-08-22T21:05:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Patch in symbol table from rfc3454, for Heimdal scripts

Status: cherry-picked from heimdal package
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fe081d22e4c6b0f83a0a66fa3fb6473f78ca75f9">fe081d22</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T21:05:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd.service: Run update-apparmor-samba-profile before start

Bug-Debian: https://bugs.debian.org/896080
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/f01f6fc20d62d8aa246fa58912e9db15c56a3c90">f01f6fc2</a></strong>
<div>
<span>by Rafael David Tinoco</span>
<i>at 2019-08-22T21:05:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">fix nfs related service names

Upstream defines nfs related service names based on the Linux
distribution. This patch fixes the names for Debian and derivatives.

Bug-Debian: https://bugs.debian.org/929931
Bug-Ubuntu: https://bugs.launchpad.net/bugs/722201
Last-Update: 2018-08-05
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/573f39e9fff1edbd4a37d760559be99f8c9e8677">573f39e9</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T21:06:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Drop ctdb-config-depend-on-etc-default-nodes-file.patch, merged upstream
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a7d2a63156491d1d8c49322cd552088a9dd0975b">a7d2a631</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T21:12:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Bump build-depends talloc >= 2.1.16, tdb >= 1.3.18, tevent >= 0.9.39 and ldb >= 2:1.5.5
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/830fee1e37e04a5432e1102a24026b6eb51c10b4">830fee1e</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-22T21:14:21Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Bump libcmocka-dev builddep to 1.1.3
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/523f9f15b020e944cd7929b8afc4d02158668137">523f9f15</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-08-27T11:16:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.10.8...

and re-eanble GIT_SNAPSHOT.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
(cherry picked from commit baafb6fc060c0b61f3e744c041be871303fa9c66)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/cf67b48f779807ccebde6f7c86f4330063f705eb">cf67b48f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-27T11:16:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-10197: smbd: separate out impersonation debug info into a new function.

Will be called on elsewhere on successful impersonation.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fd0d3986bba5ce9fee3df5dbba26a593e1274680">fd0d3986</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-27T11:16:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-10197: smbd: make sure that change_to_user_internal() always resets current_user.done_chdir

We should not leave current_user.done_chdir as true if we didn't call
chdir_current_service() with success.

This caused problems in when calling vfs_ChDir() in pop_conn_ctx() when
chdir_current_service() worked once on one share but later failed on another
share.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0af5d11c762ee623f4c656897ed196722ed8d626">0af5d11c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-27T11:16:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-10197: smbd: make sure we reset current_user.{need,done}_chdir in become_root()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035

Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/d1d48f20a25867e65f064f2c157222cdcb74658b">d1d48f20</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-27T11:16:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-10197: selftest: make fsrvp_share its own independent subdirectory

The next patch will otherwise break the fsrvp related tests.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035

Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/962d4a98b50a3ce1d58ebc516e8de9335a14dfdb">962d4a98</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-27T11:16:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-10197: test_smbclient_s3.sh: add regression test for the no permission on share root problem

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035

Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/661a7cdb0aba2c94332ff7b997023ad040aa4f7c">661a7cdb</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-27T11:16:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-10197: smbd: split change_to_user_impersonate() out of change_to_user_internal()

This makes sure we always call chdir_current_service() even
when we still impersonated the user. Which is important
in order to run the SMB* request within the correct working directory
and only if the user has permissions to enter that directory.

It makes sure we always update conn->lastused_count
in chdir_current_service() for each request.

Note that vfs_ChDir() (called from chdir_current_service())
maintains its own cache and avoids calling SMB_VFS_CHDIR()
if possible.

It means we still avoid syscalls if we get a multiple requests
for the same session/tcon tuple.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3761e4787f0f174252d7316adc23e7e17723bd1c">3761e478</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-08-27T11:16:24Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.10.8.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035
CVE-2019-10197 [SECURITY][EMBARGOED] permissions check deny can allow user to
escape from the share.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/2d587a11d5f48a012d06df3c614283013ccf728c">2d587a11</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-08-27T11:16:44Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.10.8 release.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/1be8e8a423c60211b487ceabeb4cfbf5dfe5ce33">1be8e8a4</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-29T07:21:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">d/rule: Remove 1.5.1+really prefix from LDB_DEPENDS
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/3858d0865717ed591cdf5753e544ffc346f8caa9">3858d086</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-29T07:41:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">d/copyright: s/GPL-3+/GPL-3.0+/ and s/LGPL-3+/LGPL-3.0+/
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/dcf83ccaeb3e0ee53ef5662e83e47e2e56705e8f">dcf83cca</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-29T07:48:00Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">d/copyright: Move License details to end of file
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/73afae80c784f4943545e9ab2cc765c78f57b714">73afae80</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-29T07:50:46Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">d/copyright: Add waf licences

Copied from talloc/ldb
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c45395b2acfd8888c44fff84552d831474593d4f">c45395b2</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-29T08:02:17Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">d/copyright: Add lib/replace licences

Copied from talloc/ldb
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/0fcfee4f8cc6b59001bbb6896b7262728282d2c6">0fcfee4f</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-29T08:09:37Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">d/copyright: Update lib/{ldb,talloc,tdb} licences

Copied from ldb
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/5e0698735688b726a8cfd81cc94e58109430bc98">5e069873</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-29T08:29:56Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Changelog for previous commits
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b6a3f4baf2c28996072ca3c4f10d9f00a8f1e380">b6a3f4ba</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-29T12:22:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Move to Python3 (from Ubuntu)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bb104cac9c4bca2acb343c68ed011b11d82b94a5">bb104cac</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-29T12:22:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update symbols
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/fcd2b27340b99b774d376ff2b8947dfe6c6c7b4e">fcd2b273</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-29T12:22:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update installed files
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/de4ac3007bd63252e16e6ae1ee5588b371ab1912">de4ac300</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-29T12:22:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Bump debhelper from old 11 to 12.

Fixes lintian: package-uses-old-debhelper-compat-version
See https://lintian.debian.org/tags/package-uses-old-debhelper-compat-version.html for more details.
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/a42fc711862b7158f77bf593278ea7ddff61ddcc">a42fc711</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-29T12:22:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Standards-Version: 4.4.0
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/be84b66a6bb1530a638d900a89b4a06e85c1bb00">be84b66a</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-29T12:22:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Changelog for previous commits
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/b5981d35ea759a92fba0dd9e8836ca34ab1980a3">b5981d35</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-29T12:22:45Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Replace all reference of /var/run to /run (Closes: #934540)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/bcd851a116ed93a83913e1494a853ce2b8fdefd9">bcd851a1</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-29T12:32:43Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Replace python shbang by python3 in d/*.py
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/e3698df0c7ea482044352b67737c255a7d27ff3b">e3698df0</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-08-29T12:33:15Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Release 2:4.10.7+dfsg-1 to experimental
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c67d9a394bceff2c1a74436a9f240a078537e415">c67d9a39</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-03T20:32:02Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Update d/gitlabracadabra.yml

- Add carnil (Salvatore Bonaccorso) as developer in the samba-team group
- Allow developers to push tags
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c21df2fddbfe752017f24d39484a72a36301bd46">c21df2fd</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-10T16:32:40Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge branch 'experimental'

With pseudo "theirs" strategy
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/96c16ed9e6352cb8bf90d864699c96ce0c1734bf">96c16ed9</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-10T16:39:31Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">New upstream version 4.10.8+dfsg</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/77dd5e0a2c1ea41c17c96af1995236c650022465">77dd5e0a</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-10T16:40:33Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge tag 'upstream/4.10.8+dfsg'

Upstream version 4.10.8+dfsg
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/commit/c4371bfb787b46d33be08050e86bbbdbcc7b07c8">c4371bfb</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-10T16:47:12Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Release 2:4.10.8+dfsg-1 to unstable
</pre>
</li>
</ul>
<h4>30 changed files:</h4>
<ul>
<li class="file-stats">
<a href="#24139dae656713ba861751fb2c2ac38839349a7a">
<span class="new-file">
+
.gitattributes
</span>
</a>
</li>
<li class="file-stats">
<a href="#961fd7fce40d36e3e5596071d8cbeba0de7dc6d3">
<span class="new-file">
+
.github/contributing.md
</span>
</a>
</li>
<li class="file-stats">
<a href="#99d2d4406193bf0dc3e7b84a6c9b9109997a4864">
<span class="new-file">
+
.github/pull_request_template.md
</span>
</a>
</li>
<li class="file-stats">
<a href="#1e7f0290c43feede36a7d7f90d5535909356001b">
.gitlab-ci-private.yml
</a>
</li>
<li class="file-stats">
<a href="#587d266bb27a4dc3022bbed44dfa19849df3044c">
.gitlab-ci.yml
</a>
</li>
<li class="file-stats">
<a href="#dea01dd89a3b602828e630677fde5d77c06441c8">
<span class="deleted-file">

.travis.yml
</span>
</a>
</li>
<li class="file-stats">
<a href="#73f8abedbab7412a39ca2fd49cdcd1ad3f339122">
.ycm_extra_conf.py
</a>
</li>
<li class="file-stats">
<a href="#836efb6e25a091dcb4ff8e1dbb2f0be6a5cbf14c">
Makefile
</a>
</li>
<li class="file-stats">
<a href="#5df5b4eb5cc165c5531c59175cdabb2aafb2050a">
README.Coding
</a>
</li>
<li class="file-stats">
<a href="#8ec9a00bfd09b3190ac6b22251dbb1aa95a0579d">
README

README.md
</a>
</li>
<li class="file-stats">
<a href="#b33892fbddeffc3368077b4904ad0b3d562a7312">
VERSION
</a>
</li>
<li class="file-stats">
<a href="#3277e12b5a9f9ff632d229e2629d34ad21dd93fc">
WHATSNEW.txt
</a>
</li>
<li class="file-stats">
<a href="#8949504a58f9f540cf1b88389d4f731790dd8d7f">
auth/auth_log.c
</a>
</li>
<li class="file-stats">
<a href="#b92a94ee4472cf33f2bd4ac352ea7c22dfd2662c">
auth/auth_sam_reply.c
</a>
</li>
<li class="file-stats">
<a href="#4ff1301627a8a4b1de35c336c83671e07a0f2c5f">
<span class="new-file">
+
auth/auth_util.c
</span>
</a>
</li>
<li class="file-stats">
<a href="#694da978b3f8bdff8e27dc17b9ae77fed8c50d7f">
ctdb/common/version.c

auth/auth_util.h
</a>
</li>
<li class="file-stats">
<a href="#fcf792b723f1fb082b2ae957ef92e787131776f7">
auth/credentials/credentials_krb5.c
</a>
</li>
<li class="file-stats">
<a href="#9283eb682b67801707177e777c6175a149627c4c">
auth/credentials/pycredentials.c
</a>
</li>
<li class="file-stats">
<a href="#d1e9c57babd173c3a3ecdb72c4a6a0016f04a691">
auth/credentials/tests/bind.py
</a>
</li>
<li class="file-stats">
<a href="#a052e04fd40f1081b95872e2bee962fb500f6f42">
auth/credentials/wscript_build
</a>
</li>
<li class="file-stats">
<a href="#9a8f596bbd3e8d22fe94d1364254a8fbf38c27c8">
auth/gensec/gensec.c
</a>
</li>
<li class="file-stats">
<a href="#3ed38a7cb8aee13db0e459772b40a527411129b5">
auth/ntlmssp/ntlmssp_sign.c
</a>
</li>
<li class="file-stats">
<a href="#71668996a6be349dd644eb17586d4ef5e3b1fdea">
auth/ntlmssp/wscript_build
</a>
</li>
<li class="file-stats">
<a href="#6fc48ce87d1155227246b415e50902d38c0caff7">
auth/wscript_build
</a>
</li>
<li class="file-stats">
<a href="#56a73cbb2d5b9672d5eb4f06b3631d23586b2e24">
buildtools/bin/waf
</a>
</li>
<li class="file-stats">
<a href="#b1684216d843d2f5a6d0966efeee070f28ef9a91">
buildtools/examples/run_on_target.py
</a>
</li>
<li class="file-stats">
<a href="#2c589beadbffa74f16ec00255f527963441fcfc9">
buildtools/wafsamba/configure_file.py
</a>
</li>
<li class="file-stats">
<a href="#21ad961bc0ec51f0c8c2e0c53825bd2fc57e08e9">
buildtools/wafsamba/generic_cc.py
</a>
</li>
<li class="file-stats">
<a href="#bbe31d249259edea453c9a0d87101baabf60abbc">
<span class="deleted-file">

buildtools/wafsamba/hpuxcc.py
</span>
</a>
</li>
<li class="file-stats">
<a href="#8cf351d2b3d842633efb8f7fe2a3cffe7d47c713">
<span class="deleted-file">

buildtools/wafsamba/irixcc.py
</span>
</a>
</li>
</ul>
<h5>The diff was not included because it is too large.</h5>

</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">

<br>
<a href="https://salsa.debian.org/samba-team/samba/compare/9632eb2989818045ee6dc3a3400914fb93a428c0...c4371bfb787b46d33be08050e86bbbdbcc7b07c8">View it on GitLab</a>.
<br>
You're receiving this email because of your account on salsa.debian.org.
If you'd like to receive fewer emails, you can
adjust your notification settings.



</p>
</div>
</body>
</html>