<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<h3>
Mathieu Parent pushed to branch upstream_4.12
at <a href="https://salsa.debian.org/samba-team/samba">Debian Samba Team / samba</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/42c299b090ed9bcf3540c49d337348c1374e77c2">42c299b0</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-07-09T11:49:13+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.12.0pre1...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9cb028d6d1630b20dab5bd456c69052e877d6fcf">9cb028d6</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-07-09T12:02:07+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.12.0.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/36f021f74d9739a9c73b95fc7d6f821bbf7cafdd">36f021f7</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-07-09T12:04:27+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Start release notes for Samba 4.12.0pre1.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6fe2193b17ac2d57c559d3b936b37238d06d6be8">6fe2193b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-09T12:16:10+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:profile: Use SHA1 for hashing in profiling functions.
This can use SHA NI instructions if the CPU supports it.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a31a40b41a18ae09a4e2e76f41c95b011ed30bea">a31a40b4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-09T12:16:11+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:crypto: Fix path to header file in gnutls_helpers.h
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/31a943fa0890438cffc67a566373f36c94c0a5a8">31a943fa</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-09T12:16:11+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:crypto: Add GNUTLS_FIPS140_SET_(LAX|STRICT)_MODE to helpers
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ccf3e76625c42f5aceea0882971a232a9f56a971">ccf3e766</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-09T13:31:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:profile: Allow profile subsystem to use SHA1 in FIPS mode
This is non-cryptographic use.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Jul 9 13:31:46 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/abc58a4a128810294040cca849aad324b9c22fa5">abc58a4a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-09T23:12:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Add dptr_activecnum(), not yet used.
Will be used to help remove the SMB1 idle directory
code.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/461001cbc13727b46b0ff3fb8ea347bfc199a9e4">461001cb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-09T23:12:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Don't idle connections with active SMB1 directory scans.
When all scans are via file handles this code can
be removed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/609c9a58cebd27c2b3ed2c73a8b9dd1b8880a895">609c9a58</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-09T23:12:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Don't idle SMB1 directory scans after DPTR_IDLE_TIMEOUT.
Only broken SMB1 clients leave directory scans hanging
and we shouldn't support that.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/80ae1eba8cb5121172cb3478326e6990d1dc3f4e">80ae1eba</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-09T23:12:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove unused DPTR_IDLE_TIMEOUT.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a43e6771348127dd2e3fd3efcc8e0b5691916862">a43e6771</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-09T23:12:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove now unused dptr_idlecnum().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7b98319f3057bea2e78be7b540f640fc476c770c">7b98319f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-09T23:12:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove MAX_OPEN_DIRECTORIES check in dptr_create().
This is a bug in that it's artificially limiting the number
of open directories an SMB2 client can have. If this code
was needed it should by SMB1 specific.
However we should allow the clients to decide for themselves
how many directory handles they need, not limit to MAX_OPEN_DIRECTORIES.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7b6129d14e4d22728c009ec72529f6f18010db68">7b6129d1</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-09T23:12:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove SMB1 idle unused directory handles code.
This is only needed for broken SMB1 DOS clients, and
we're a long way from needing this anymore.
ifdef out dptr_idleoldest() and dptr_idle()
functions as otherwise we get "unused function"
compile errors. Remove in next commit.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/288d71678b02effdb910e8ebb811d0f502a75166">288d7167</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-09T23:12:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove unused dptr_idleoldest() and dptr_idle() functions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ab65fa9af0ba97fdc5f0e44eea9652212f0f7cd0">ab65fa9a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-09T23:12:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove now unused MAX_OPEN_DIRECTORIES define.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/096a98f6eab3ba4be9e24e1f4cc9c6477983c282">096a98f6</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-09T23:12:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Add a note explaining MAX_DIRECTORY_HANDLES only applies to SMB1.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d9d00ad068c5814e13c68c7fe42d75242f899f0d">d9d00ad0</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-09T23:12:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: We no longer need to keep a count of dirhandles open.
It's not per-connection struct anyway, so doesn't
help for anything.
Remove now unused variable struct smbd_server_connection *sconn
otherwise we get compile errors.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e21b75168d382500370591b678d1558265b18771">e21b7516</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-09T23:12:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: globals - remove dirhandles_open from internal search struct.
It wasn't used for SMB2 anyway, and isn't useful for anything.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ff8c8b34b91ffc5fa9742d57190580cbf64a1afd">ff8c8b34</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-09T23:12:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove now unused parameter 'forclose' to dptr_get().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1376dc3b840561cd782cd5f228eb1c43aa96f22d">1376dc3b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-09T23:12:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove the 'close oldest' logic in SMB1search processing.
Expect the client to manage their handles properly.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6134922f7b4d0141e40286c5c5acad05272fa267">6134922f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-09T23:12:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove the 'close oldest' logic in SMB1 trans2 search processing.
Will be removed in next commit.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/09ddad6c14db6e3310b663f6203582104d85db45">09ddad6c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-10T00:28:51+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove ifdef'ed out dptr_close_oldest().
No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jul 10 00:28:51 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/19a13cbe0681b3996c33f7449f69b0fb0dc5d640">19a13cbe</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-10T04:32:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: do not allow adding a DN as a base to itself
If you try to add a dn to itself, it expands as it goes. The resulting
loop cannot end well.
It looks like this in Python:
dn = ldb.Dn(ldb.Ldb(), 'CN=y,DC=x')
dn.add_base(dn)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f5e0339a0de71dc7d07f3ba95e6573076efe9efd">f5e0339a</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-10T04:32:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pyldb: add pyldb_check_type()
This will be used by pyldb_Ldb_AsLdbContext().
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e075f52a7508979b744fde463d6184405d7a3772">e075f52a</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-10T04:32:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pyldb: fork pyldb_Ldb_AsLdbContext macro to reflect unsafeness
In the Python/C API, conversion functions which check the types of their arguments
have names like:
double PyFloat_AsDouble(PyObject *pyfloat);
while conversion macros that don't check have names like:
PyFloat_AS_DOUBLE(pyfloat)
The pyldb_Ldb_AsLdbContext() macro looks like one of the checking functions
but it actually isn't. This has fooled us more than once. Here we fork
the macro into two -- one which performs checks and keeps the camel
case, and one with a shouty name that keeps the check-free behaviour.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/339f8bbdda04a23460e7fa908d60857b95271c6e">339f8bbd</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-10T04:32:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pyldb: check for errors in PyLdb_GetPyType()
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1d6b472cdcddbd6892741a381f33faf0b4ddc847">1d6b472c</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-10T04:32:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pyldb: rename pyldb_Dn_AsDn() to pyldb_Dn_AS_DN()
Following the python/C convention for checking vs non-checking
convertors.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/545e95386f6a37009975718f2f5ad03390d9296d">545e9538</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-10T04:32:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py segfault test: ldb.register_module
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3af57daa8404476773cef3be544a82ac419f961d">3af57daa</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-10T04:32:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py segfault test: ldb.open
There seems to be no way of using ldb.open without causing a segfault
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/192386ede62c4a72c0fbc173240f02357455c609">192386ed</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-10T04:32:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pyldb: remove ldb.open, which was never survivable
There was no way to call ldb.open without evoking signal 11, so it is
unlikely anyone was using it.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fdb9a59069c5fea131669510b59901cbe3d9e58e">fdb9a590</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-10T04:32:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pyldb: ldb.register_module() checks arguments a little bit
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c80606274fdb1f1736e74e8da26d918bf259922e">c8060627</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-10T05:48:52+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb ABI bump for pyldb_Ldb_AsLdbContext change
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Wed Jul 10 05:48:52 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c19f1c9a3e7fc103754703dff11aa3b63b1edb95">c19f1c9a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-11T04:08:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch/libwbclient: clang Fix Potential leak of memory
Fixes:
nsswitch/libwbclient/wbc_sid.c:848:2: warning: Potential leak of memory pointed to by 'extra_data'
free(extra_data);
^
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c38a7745b18ff83ad0097e604967a2501e88d1e1">c38a7745</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-11T04:08:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/common: clang: Fix access results in null pointer deref.
Fixes:
source4/dsdb/common/util_trusts.c:2915:21: warning: Access to field 'sid' results in a dereference of a null pointer (loaded from field 'tdo') <--[clang]
d->di.domain_sid = d->tdo->sid;
^ ~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3a59a70dab359c4a1e992625b7adaa15f37a10ca">3a59a70d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-11T04:08:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch/libwbclient: clang: Fix Value stored to 'wbc_status' is never read
Fixes:
nsswitch/libwbclient/wbc_util.c:123:3: warning: Value stored to 'wbc_status' is never read <--[clang]
wbc_status = WBC_ERR_SUCCESS;
^ ~~~~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d6c67f7c886c67363c4c1ef139cc366aadf90142">d6c67f7c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-11T04:08:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/auth/gensec: clang: Fix 'initialization value is never read'
Fixes:
source4/auth/gensec/gensec_gssapi.c:431:11: warning: Value stored to 'nt_status' during its initialization is never read <--[clang]
NTSTATUS nt_status = NT_STATUS_LOGON_FAILURE;
^~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f004f8a23493fba882324131e68a046ef84b8de5">f004f8a2</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-11T04:08:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/gensec: clang: Fix 'Value stored to 'status' is never read'
Fixes:
auth/gensec/spnego.c:877:2: warning: Value stored to 'status' is never read <--[clang]
status = sub_status;
^ ~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/71943ab53ee67dab0bb47753b78074917f38749e">71943ab5</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-11T04:08:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/smb: clang: Fix 'value stored to 'p' is never read'
Fixes:
libcli/smb/smb1cli_session.c:226:2: warning: Value stored to 'p' is never read <--[clang]
p += ret;
^ ~~~
libcli/smb/smb1cli_session.c:517:2: warning: Value stored to 'p' is never read <--[clang]
p += ret;
^ ~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fa551bf0a4ae5a6687a1ee638dc3c495a30a2e19">fa551bf0</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-11T04:08:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcl/smb: clang: Fix 'Value stored to 'next_offset' is never read'
Fixes:
libcli/smb/smb2_create_blob.c:146:3: warning: Value stored to 'next_offset' is never read <--[clang]
next_offset += next_pad;
^ ~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9f6b87d3f6cc9930d75c1f8d38ad4f5a37da34ab">9f6b87d3</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2019-07-11T05:25:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldap_server: Regression in 0559430ab6e5c48d6e853fda0d8b63f2e149015c
Extended DN requests seem to have been incorrectly handled.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14029
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Thu Jul 11 05:25:26 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c7bb524438afd08ed25e121ef2a8afd70777f2d4">c7bb5244</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T21:31:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: convert adouble accessor macros to functions
The functions will be moved to a different compilation unit in a subsequent
commit and struct adouble will become a private struct so callers can't access
it directly.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1bf4175a23db4e8a91b64bff73f43e325ee6a517">1bf4175a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T21:31:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: add flags to ad_convert()
A subsequent commmit will move all AppleDouble related functionality, including
ad_convert(), to a different compilation unit. We must therefor remove the
dependency on struct fruit_config_data.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f9df2b67ced95bfad4bdac925dc200ca7daf111e">f9df2b67</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T21:31:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: pass catia mappings as argument to ad_convert()
This removes the direct use of fruit_catia_maps from ad_convert(), to make it
possible to move the whole AppleDouble functionality to a dedicated subsystem.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dbc840e740a447b3e7771bbe0c607a4623518e98">dbc840e7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T21:31:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: move AppleDouble functionality to a dedicated subsystem
It's still tied to the VFS, therefor it lives in source3/modules/. Reduces code
bloat in vfs_fruit and makes it possible to use it from other parts of the
codebase in future.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3093c374f2fe16efd765b485bf86599feff1f6a7">3093c374</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T21:31:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: move Mac streams util functions to s3/lib
While at it, change the functions to work on the stream name directly instead of
struct smb_filename. A later commit wants to use the function on the resulting
stream names coming from vfs_streaminfo().
Also use the simple string compare version, not the multibyte ones, as the afp*
stream names are simple ASCII string, so there's no need to become fancy.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/79e0110e461e56750ab4683900737f1712798575">79e0110e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T21:31:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">adouble: remove redundant calls to ad_pack()
ad_fset() calls ad_pack() anyway...
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5e52d9ebf0638ce40130dc72c8225c5b7e25ee22">5e52d9eb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T21:31:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">adouble: pass VFS handle and fsp to ad_pack()
Unused for now, that comes next.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1c464232f8848e6d3a28f49f7721f4ac076c5645">1c464232</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T21:31:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">adouble: use runtime size when writing out AppleDouble header
We're calling SMB_VFS_NEXT_PWRITE() to write out the AppleDouble header
data. Until now this header always had a fixed sizeof AD_DATASZ_DOT_UND bytes,
but a subsequent commit will change that. Use the correct size which is the
offset of the begining of the resource fork data.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0f5fde7bed4dbf01736ee583fe790db99c7d4561">0f5fde7b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T21:31:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">adouble: add some ASCII art
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a2a30e63d509ac3bca0ae56c9babb63942450699">a2a30e63</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T21:31:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">adouble: remove xattrs after successfull conversion
This ensure the subsequent ad_fset() does not attempt to put back the xattrs on
disk in the AppleDouble file. It's not yet a problem as we don't have the code
that would do that, but that will be added in the next commit...
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f820647fa1be39c700b6989418e379114ec7ea3b">f820647f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T21:31:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">adouble: ensure stat info is marked invalid on new path
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2bd926accd7a4649fb83eb2a262f962277566b45">2bd926ac</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T21:31:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: pass a TALLOC_CTX to string_replace_init_map()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1acdca751937186b9b114961bd045b9a022e39b5">1acdca75</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T21:31:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: remove duplicate catia mappings
0x0d:0xf00d is already given a few lines above.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cd3b4187266a49ceaf5ce176abfdd17c741d4caf">cd3b4187</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T21:31:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:{modules => lib}/string_replace.[c|h]
This is now also consumed by something outside source3/modules/.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/145c54e4de7435810eb82c9299aaccaedd9898f0">145c54e4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T21:31:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: move fruit catia string replace mappings to s3/lib/
This will be needed by another component soonish.
Signed-off-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a331b15e2b4eeda7b206f70ddad04bcac4243e4f">a331b15e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T21:31:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">adouble: add ad_unconvert()
This collects a file's stream data and packs it into a AppleDouble file.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/17496a39b1c6f6c703219d559254e894a40d0117">17496a39</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T21:31:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:net: add 'vfs' hierarchy with 'stream2adouble' command
This adds a new top-level command hierarchy 'vfs' that can be used to add
commands that access the smbd VFS stack.
The first command to be implemented is 'stream2adouble' which can be used to
convert stream metadata to AppleDouble files.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bb37a88e63660f885121703419f183f9c3e85827">bb37a88e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T21:31:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture: add a vfs_fruit unconversion test
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/36b48aa783743c86da21f8a896eac0f774fed27a">36b48aa7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-07-12T22:59:58+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:net: add 'net vfs getntacl' command
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jul 12 22:59:58 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5522aa1a4c34ee1a1e81db73cf41594bb10bd989">5522aa1a</a></strong>
<div>
<span>by Michael Adam</span>
<i>at 2019-07-13T22:54:56+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs:glusterfs_fuse: ensure fileids are constant across nodes
Instead of adding a new gluster-specific mode to the fileid module,
this patches provides a fileid algorithm as part of the glusterfs_fuse
vfs module. This can not be configured further, simply adding the
glusterfs_fuse vfs module to the vfs objects configuration will enable
the new fileid mode.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13972
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Sat Jul 13 22:54:56 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/15196c7561ff3afdb3d61afd6951d22e4cf698c7">15196c75</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-07-16T08:13:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4 echo_server: Enable prefork process model
Enable the prefork process model, for the echo server. This is allows
it to be used in the prefork_restart tests.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1c4b9ba36c724b6fcc26a51af5202483ab3f1c23">1c4b9ba3</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-07-16T08:13:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">prefork restart tests: Use echo server for back off
Use the echo server for the restart back off tests in the
samba.tests.prefork_restart tests instead of the kdc. The kdc is not enabled
when the ADDC is built to run MIT Kerberos. Changing the test to use
the echo server means it can be run when MIT Kerberos is enabled.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/da9472a934bf242c7dec1a7a355fb4eb043e5b15">da9472a9</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-07-16T10:10:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">prefork tests: re-enable restart tests for MIT Kerberos
Previously the restart back off tests were disabled for MIT Kerberos, as
they used the kdc, which is not run in that case. Tests now use the
echo server.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Jul 16 10:10:23 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9cf3379a1409b95714a1d96bf75c0bc08104ed1f">9cf3379a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-16T17:20:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Update uid_wrapper to version 1.2.7
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Jul 16 17:20:31 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/57e9b358ec836e8d8133242c0f6ce4d896531a40">57e9b358</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-16T22:52:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib: clang: Fix 'Value stored during its initialization is never read'
Fixes:
source3/lib/messages.c:483:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0ca6d34a69d308ad756f3697f8f44a8e642b27f0">0ca6d34a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-16T22:52:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib/dwrap: clang: Fix 'Array access results in a null pointer dereference'
Fixes:
source3/lib/dbwrap/dbwrap_watch.c:55:3: warning: Array access (from variable 'wkey') results in a null pointer dereference <--[clang]
SIVAL(wkey, 0, db_id_len);
^
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/80f5461ae6c9e7b443b6845ca9dc341d530a04dd">80f5461a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-16T22:52:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib: clang: Fix 'Value stored to 'b' is never read'
Fixes:
source3/lib/substitute.c:516:7: warning: Value stored to 'b' is never read <--[clang]
for (b = s = a_string; (p = strchr_m(s, '%')); s = a_string + (p - b)) {
^ ~~~~~~~~~~~~
source3/lib/substitute.c:709:7: warning: Value stored to 'b' is never read <--[clang]
for (b = s = a_string; (p = strchr_m(s, '%')); s = a_string + (p - b)) {
^ ~~~~~~~~~~~~
source3/lib/substitute.c:811:7: warning: Value stored to 'b' is never read <--[clang]
for (b = s = a_string; (p = strchr_m(s, '%')); s = a_string + (p - b)) {
^ ~~~~~~~~~~~~
3 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8aed7e9aae13b3fc64a2af1fbdf835f12038ac9b">8aed7e9a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-16T22:52:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/libcli/ldab: clang: Fix 'Access results in a deref of a null pointer'
Fixes:
source4/libcli/ldap/ldap_client.c:1023:6: warning: Access to field 'type' results in a dereference of a null pointer <--[clang]
if ((*msg)->type != type) {
^~~~~~~~~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9cfdb9f190688682dd62d7c148f1d801921a3b92">9cfdb9f1</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-16T22:52:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcls/netlogon: clang: Fix 'initialization value is never read'
Fixes:
libcli/netlogon/netlogon.c:183:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_INVALID_NETWORK_RESPONSE;
^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libcli/netlogon/netlogon.c:224:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_INVALID_NETWORK_RESPONSE;
^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
Note: although use of default seems unecessary but gcc
(with --picky-developer) detects the possibiliy still that status
may be undefined (presumably by a non enum value leaking
into the switch)
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a901c5768accd49b40b17b3350613ca7819a2854">a901c576</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-16T22:52:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/cldap: clang: Fix 'Dereference of null pointer'
Fixes:
libcli/cldap/cldap.c:144:8: warning: Dereference of null pointer <--[clang]
ev = c->searches.list->caller.ev;
^
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/be319e24bb96ac4acbf55f36403f37af08107660">be319e24</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-16T22:52:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/libcli: clang: Fix 'initialization value is never read'
Fixes:
source4/libcli/smb_composite/fetchfile.c:91:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/06c3a493d99846af62c185a9db1a6823726ac1fc">06c3a493</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-16T22:52:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/libcli/raw: clang: Fix 'initialization value is never read'
Fixes:
source4/libcli/raw/rawnegotiate.c:157:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_INTERNAL_ERROR;
^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4f61a9980dbd23774e7d0c205e59dc6c593067dd">4f61a998</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-16T22:52:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/param: clang: Fix 'Value stored to 'bRetval' is never read'
Fixes:
source3/param/loadparm.c:2770:2: warning: Value stored to 'bRetval' is never read <--[clang]
bRetval = false;
^ ~~~~~
source3/param/loadparm.c:3868:2: warning: Value stored to 'bRetval' is never read <--[clang]
bRetval = false;
^ ~~~~~
2 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7b8ec24ccfb06c1d499bf500183c0dc24de553a0">7b8ec24c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-16T22:52:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/libcli/raw: Fix 'Value stored to 'p' is never read'
Fixes:
source4/libcli/raw/clitree.c:138:3: warning: Value stored to 'p' is never read <--[clang]
p += smbcli_req_pull_string(&req->in.bufinfo, mem_ctx, &parms->tconx.out.fs_type,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7a86c99ccb6912effdbb0ffbdc5c66eccf8c1aa2">7a86c99c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-16T22:52:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/smb: clang: Fix 'array access results in a null pointer deref'
Fixes:
smbXcli_base.c:1239:9: warning: Array access (via field 'pending') results in a null pointer dereference <--[clang]
req = conn->pending[0];
^
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3594c3ae202688fd8aae5f7f5e20464cb23feea9">3594c3ae</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-16T22:52:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/smb: clang: Fix 'Array access results in a null pointer deref'
Fixes:
smbXcli_base.c:4393:10: warning: Array access (from variable 'inhdr') results in a null pointer dereference <--[clang]
flags = CVAL(inhdr, HDR_FLG);
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fb49e411aa3ca397b19ea57528c2f67f9b85c877">fb49e411</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-16T22:52:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/smb: clang: Fix 'Dereference of null pointer'
Fixes:
smbXcli_base.c:4885:20: warning: Dereference of null pointer <--[clang]
body = (uint8_t *)iov[1].iov_base;
^~~~~~~~~~~~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6ea9c795b138ebaee40f0ab7d7741cab236cec96">6ea9c795</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-16T22:52:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/smb: clang: Fix ' 2nd function call argument is an uninitialized value'
Fixes:
/home/samba/samba/libcli/smb/smbXcli_base.c:5120:8: warning: 2nd function call argument is an uninitialized value <--[clang]
rc = gnutls_hash(hash_hnd,
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e3e9330609b527a101dfde9a1109da7cb389ed32">e3e93306</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-16T22:52:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib: clang: Fix 'passed-by-value struct argument contains uninit-ed data'
Fixed:
g_lock.c:358:21: warning: Passed-by-value struct argument contains uninitialized data (e.g., field: 'pid') <--[clang]
state->watch_req = dbwrap_watched_watch_send(
^
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/80e57a10164cc8482f0611cbce4086521051ec9b">80e57a10</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-16T22:52:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/registry: clang: Fix 'initialization value is never read'
Fixes:
source3/registry/reg_api.c:139:14: warning: Value stored to 'result' during its initialization is never read <--[clang]
WERROR result = WERR_OK;
^~~~~~ ~~~~~~~
ource3/registry/reg_api.c:958:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
WERROR werr = WERR_OK;
^~~~ ~~~~~~~
2 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/963f58fb622f20d58f9dab2d5f474c7eec58a8e2">963f58fb</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-16T22:52:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/registry: clang: Fix 'initialization value is never read'
Fixes:
source3/registry/reg_backend_db.c:853:9: warning: Value stored to 'result' during its initialization is never read <--[clang]
WERROR result = WERR_OK;
^~~~~~ ~~~~~~~
source3/registry/reg_backend_db.c:1677:2: warning: Value stored to 'len' is never read <--[clang]
len = 0;
^ ~
2 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b388c217d4fa0d2451a5d949b4fdf5a778d814a1">b388c217</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-16T22:52:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib: clang: 'Value stored to 'rta' is never read'
Fixes:
source3/lib/addrchange.c:217:2: warning: Value stored to 'rta' is never read <--[clang]
rta = IFA_RTA(ifa);
^ ~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c4613521723e3ab9b462d75485a514ca16595226">c4613521</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-17T00:07:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib/smbconf: clang: 'Value stored during its initialization is never read'
Fixes:
source3/lib/smbconf/smbconf_reg.c:123:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
WERROR werr = WERR_OK;
^~~~ ~~~~~~~
source3/lib/smbconf/smbconf_reg.c:178:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
WERROR werr = WERR_OK;
^~~~ ~~~~~~~
source3/lib/smbconf/smbconf_reg.c:444:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
WERROR werr = WERR_OK;
^~~~ ~~~~~~~
source3/lib/smbconf/smbconf_reg.c:583:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
WERROR werr = WERR_OK;
^~~~ ~~~~~~~
source3/lib/smbconf/smbconf_reg.c:712:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
WERROR werr = WERR_OK;
^~~~ ~~~~~~~
source3/lib/smbconf/smbconf_reg.c:995:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
WERROR werr = WERR_OK;
^~~~ ~~~~~~~
source3/lib/smbconf/smbconf_reg.c:1103:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
WERROR werr = WERR_OK;
^~~~ ~~~~~~~
7 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Wed Jul 17 00:07:48 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ee2fe56ba0ef6626b634376e8dc2185aa89f8c99">ee2fe56b</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2019-07-17T06:17:10+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">drepl: memory leak fix
Fixes a memory leak where schema reference attached to ldb
instance is lost before it can be freed.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14042
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Wed Jul 17 06:17:10 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/79e3b1c71f59591c54e87299984e50d2ffb00b6b">79e3b1c7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-07-17T11:27:20+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Increase a debug level
This is not a real error, it happens when the share mode record is not
around.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/69cca061a4e176c3d23f5f0771893011adafc940">69cca061</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-07-17T12:45:51+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Optimize file_compare
Triggered by two coverity false positives. Loading both files into
talloc'ed memory seems inefficient to me. Rely on stdio to do proper
buffering. This removes the restriction from ae95d611: "It is meant for
small files".
This is more lines, but to me it has less implicit complexity.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
Autobuild-User(master): Uri Simchoni <uri@samba.org>
Autobuild-Date(master): Wed Jul 17 12:45:51 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/664eed2e926f8f572b81e6d7c8e09b7ccbafb908">664eed2e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-18T01:30:20+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Use GnuTLS random number generator in genrand.c
FIPS requires that a random number generator from a certified crypto
library is used.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jul 18 01:30:20 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b0fc1ca65abd49d5391ea1213c78c2bc22641c36">b0fc1ca6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-07-18T12:55:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Fix the 32-bit build
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Jul 18 12:55:30 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0bcfc550b1a902e3a6a766b06603ac9285d0ff63">0bcfc550</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2019-07-19T02:20:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gp_inf: Read/write files with a UTF-16LE BOM in GptTmpl.inf
Regression caused by 16596842a62bec0a9d974c48d64000e3c079254e
[MS-GPSB] 2.2 Message Syntax says that you have to write a BOM which I
didn't do up until this patch. UTF-16 as input encoding was marked much
higher up in the inheritance tree, which got overriden with the Python 3
fixes. I've now marked the encoding much more obviously for this file.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14004
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Fri Jul 19 02:20:47 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c0b1884c99e1e89f2a7864e72a7064c0c62fad46">c0b1884c</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Rename create_dcerpc_ncalrpc_socket
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3153814db4a4ad667218f47ff610c5b43678aabf">3153814d</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Return NTSTATUS for dcesrv_create_ncalrpc_socket
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/05507d4d19804dfd57b85dd7e20bdad4b3d9781e">05507d4d</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Switch to new debug macros for dcesrv_create_ncalrpc_socket
Additionally new debug messages are added and the existing ones improved.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/af576d335adc75a4bca03fd42d9e510eae841e27">af576d33</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Rename dcerpc_ncalrpc_listener
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7f8f857dfea7a2474bd109339f3ba7627f0e0e65">7f8f857d</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Rename create_named_pipe_socket
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4a5c440b089d1232fe3c11e42ec39d96c3cc0e0a">4a5c440b</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Return NTSTATUS for dcesrv_create_ncacn_np_socket
The 'fd' state struct member is initialized after allocation because it
is checked in the error path.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3fdd4dc03adad694f01cf1fb3fe9e3a7cd666dac">3fdd4dc0</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Switch to new debug macros for dcesrv_create_ncacn_np_socket
Additionally messages are improved.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b6537c15c1623c3141e64537b2998ddae8cc6db9">b6537c15</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Rename setup_named_pipe_socket
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e05ce7b9e75b8fc36f04c25f51f21dcdc463c737">e05ce7b9</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Return NTSTATUS for dcesrv_setup_ncacn_np_socket
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fc3d582ccab2bbb7ca04b2fddf57db1ad7e7016e">fc3d582c</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Switch to new debug macros for dcesrv_setup_ncacn_np_socket
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b52d58d6e1841f4c0d3d9f6c386e60e761ef4b1e">b52d58d6</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Rename named_pipe_listener
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5ed7ee7279911fc98b9f81dddc6f396d368ab2c8">5ed7ee72</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-07-22T16:49:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: simplify the error checking of create_tcpip_socket() callers
create_tcpip_socket() never returns a valid fd and left port as 0.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b7817eaf3d3120a41e38d913d41e4fa3433f78d3">b7817eaf</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Rename create_tcpip_socket
Additionally move function declaration from proto.h to rpc_server.h
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e3999a14daa40ccdfab379aa84da615b47e0f447">e3999a14</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Return NTSTATUS for dcesrv_create_ncacn_ip_tcp_socket
Additionally to the fd number, check the port number has been correctly
assigned. This check was performed by the callers of this function.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6b2aefc579f584c22a4b64c189f883222d8e928c">6b2aefc5</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Use new debug macros for dcesrv_create_ncacn_ip_tcp_socket
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/edc8ef722c86055abbb5438dc6b4df236a465b96">edc8ef72</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Rename dcerpc_ncacn_tcpip_listener
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3f4be0b9dbdf89d09358ab6897feadad477f0ed1">3f4be0b9</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Rename rpc_create_tcpip_sockets
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a6b5899853c95b6b9c3f438af86c5103c0dc4a9d">a6b58998</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Rename setup_dcerpc_ncacn_tcpip_socket
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ae14c51080c6b69edb0364b79a9cecde62e2684f">ae14c510</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Return NTSTATUS for dcesrv_setup_ncacn_ip_tcp_socket
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cbf497dc0956f4685c8991b4499d3d6c56a5214a">cbf497dc</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Use new debug macros in dcesrv_setup_ncacn_ip_tcp_socket
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1a1f31e0820d33edc600d9ad1dc53d63c68f3d4e">1a1f31e0</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Rename setup_dcerpc_ncalrpc_socket
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5a544864245d06630684a173d6a27aa605b79f34">5a544864</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Return NTSTATUS for dcesrv_setup_ncalrpc_socket
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1f2caa4101a29736db38c22036268f0a612420cb">1f2caa41</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Use new debug macros in dcesrv_setup_ncalrpc_socket
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2cb4a9c6e8d31249131b0ba19579c5879c956104">2cb4a9c6</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Use talloc_zero for dcerpc_ncacn_listen_state
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fd62ab62aed2702c5646242b6400455f9fa4e391">fd62ab62</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:spoolss: Exit if fork call fails
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f527964f72af3c31ba16de40756ab468da5924c9">f527964f</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Set the endpoint name to "IP" on ncacn_ip_tcp listener
This matchs what lsasd and mdssd does.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/60b7b791876ef8affce8c770fb6bf11030ab2c50">60b7b791</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Fix code formatting and improve debug messages
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0a65fa8a9a720029b20037259e2e76525bcfafef">0a65fa8a</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: New struct to fix strict aliasing issues with sockets API
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8cb921d2550e4880d29ea7daf13b57fcb7d31936">8cb921d2</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:tsocket: New function to build a tsocket_context from samba_address
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7ee4dff9da219d666a8286623ab556b6b5504bd6">7ee4dff9</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Fix hidden strict aliasing issues
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d1d37a0a6e79f448fbf7443a4554e16e49b44131">d1d37a0a</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Return NTSTATUS in rpc_ep_setup and setup functions
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6ac170267ca269bea80cfa16207b3670f1e4a26d">6ac17026</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-prefork: Add header inclusion guards
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fdfa0e0a01a4f202a0166f878b160dc7aa430633">fdfa0e0a</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:epmapper: Rename conflicting struct
Rename an epmapper internal struct which will conflict when merging s3
and s4 rpc servers.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d8d7c981218ca2daac3234330b03b011efc9d5ba">d8d7c981</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Set dcerpc_ncacn_connection destructor
And call disconnection callback from there if it is set.
Additionally change named_pipe_termination_fn to have * in typedef.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cc6342e7a5e955c55319021ec3cd2ed5800c40f6">cc6342e7</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Move dcerpc_ncanc_conn to header file
Next commits will remove named_pipe_client and dcerpc_ncacn_connection
will be used in its place. It has to be moved to a header file as it
will be used by functions in rpc_server.c and rpc_ncacn_np.c.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/61fb17f85bf7c6a33253d9b34a044d614b733c2b">61fb17f8</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Add termination function and data to dcerpc_ncacn_conn
In preparation to remove the named_pipe_client structure, this function
will be called from ncacn_conn destructor passing the private data pointer
as argument. It is mainly used by preforked childs in "process model" to
attend the next client as soon as the previous client ends the connection..
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/52c3bebd23e0343dfc1b34bbe2e894ca62974be1">52c3bebd</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Split dcerpc_ncacn_accept to deal with tstream_npa
In preparation to remove the named_pipe_client struct split the function
if two parts and build the tstream context as soon as possible, as it
will take care of closing the socket when the tstream_context is freed.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2e938e22ac9484ccefd266ceed590cfbf5c01599">2e938e22</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Add a function to initialize the dcerpc_ncacn_conn struct
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c976d456d2f564764cd1a12f2d1fe37ae4023d17">c976d456</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Make dcerpc_ncacn_packet_process public
In preparation to remove the named_pipe_client struct, this function
will be set as tevent callback from rpc_ncacn_np.c
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/82759189d16449d7e4cb23a353d99e2254437898">82759189</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Check remote address supplied to dcerpc_ncacn_accept
Check if the supplied tsocket_address is valid before changing the
talloc chunk parent to the ncacn_conn struct.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/85201cc76b4990b287681bd248c3c1b91a9f97be">85201cc7</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Remove named_pipe_client struct and use dcerpc_ncacn_conn
Now NCACN_NP connections run the same loop as NCACN_IP_TCP and NCALRPC
connections.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6964348bbfc8781be76ebd6a9f931648843a22f9">6964348b</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:prefork: Allow to associate private data with listening socket
Prepare for merger RPC server codebase, where it will be necessary to
stablish an association between the listening socket and the
dcesrv_endpoint that the socket is serving.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/01c6602dd250b62234e20bd79a46241782863ba0">01c6602d</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Initialize auxiliary variable checked in error path
The auxiliary variable is checked in the function's exit code so reset
it after each usage.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6f07f46771a741142f603635d988394de5e17e66">6f07f467</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Set debug class in all rpc server related files
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5d8e13413c3ce6c68c6bc06f77194e3098ccaf56">5d8e1341</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Return NTSTATUS in make_internal_rpc_pipe_p
Also make it static as it is not used outside rpc_ncacn_np.c
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5865cf4dd98bfe9c780d4ed4b8fe630a4a9949d0">5865cf4d</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:spoolss: Set remote and local address for accepted connections
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cdaf06abadc92796d6c84f0e95172519071f1fa5">cdaf06ab</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Unify RPC client disconnect and termination functions
These functions are used by endpoint mapper to delete the endpoints
when a NCALRPC connection from an external daemon is lost and by
preforked childs to accept the next client as soon as the current
connection terminates. We can use the same function for both purposes.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0c04daf52351b105fd8e8dd28703c290f369a3cd">0c04daf5</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Rename dcesrv_handle struct
The name conflicts with the S4 name.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4d42b7cde208982f2344e0519ebbf6de5da2ec32">4d42b7cd</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Check pointer before dereference
The debug message dereference the pointer, but as close_policy_by_pipe
is called from pipes_struct destructor it may be not initialized yet if
an error occur in the initialization code.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f7529fffce6de70a6914e17f91876d721e02b219">f7529fff</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Make make_external_rpc_pipe_p and np_proxy_state private
This function and struct is not used outside rpc_ncacn_np.c
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dde08e8f262633c017c8288991c9e894cb72d0d8">dde08e8f</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Return NTSTATUS in is_known_pipename function
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a2c943f52d39cedd5b7d9cbb3ed1f34fe62988fc">a2c943f5</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server:spoolssd: Move socket creation to its own function
The function also handles the registration in the endpoint mapper.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6be10e6d439dbeadeac7cb8b11c32c13ea6b8b83">6be10e6d</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Improve debug messages
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7a167b3751c5e955d757b7397f4d596e5b93c140">7a167b37</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Call server exit routines in sigterm handler
The exit server routines already call rpc shutdown functions
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/63a39ef605176f6d6adef7dd95ae430d344a36bb">63a39ef6</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Call fsrvp RPC shutdown function from server exit routines
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ee6fb27c59ba33967f6c8ea473b6938c501f71b6">ee6fb27c</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T16:49:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Call epmapper RPC shutdown function from server exit routines
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c1e649fd473885c0cb779344fc7089a245c7b17d">c1e649fd</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-07-22T18:04:53+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Call server exit routines in sigterm handler
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Jul 22 18:04:53 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c3a52e4c40a819ccaa5b4dab41f74afc8bff3d5c">c3a52e4c</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T22:20:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">py segfault test: registry.open_hive
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3383390b4b82e49865792b839af1e8fb798113ca">3383390b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T22:20:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/py-segfault: add messaging.deregister()
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4496e073cbd0f78bcaa2cf340336e1a14bd6e8e6">4496e073</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T22:20:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: add pytalloc_get_name() helper
In several places we go
talloc_get_name(pytalloc_get_ptr(py_obj))
which is a certain NULL derefernce if py_obj is not a talloc object.
This is a helper function that chooses to say "non-talloc object"
rather than crash.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dc20e7c6df7a230c3b3cd9ae7de79e4cacc36eb4">dc20e7c6</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T22:20:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: pytalloc_get_checked_type: survive non-talloc objects
If the python object is not a talloc object, we will end up
with a NULL pointer. We weren't checking for that properly
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ac23eeb41c3d27d710722f94e22dd84410d183d3">ac23eeb4</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T22:20:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc/py_util: remove tautologically dead code
Being careful is good and all, but if we don't trust the
static PyTypeObject *type = NULL;
two lines up, we need to reconsider our entire software universe.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cd20e3876c368556781ff0c8c14527b9339d3cad">cd20e387</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-07-22T22:20:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: Release talloc 2.3.0
* add pytalloc_get_name() to safely access te talloc name in Python bindings
* Use a new minor version to allow talloc updates in the 4.11 release stream
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/99c43354ef5387b708cf0f527f39a86b43c0e979">99c43354</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T22:20:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/pysecurity: use pytalloc_get_name to avoid NULL deref
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5405f2ad7edc0dc04707e2c7472705c534cb11e8">5405f2ad</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T22:20:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/py_dsdb: avoid NULL deref in set_domain_sid()
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2d1c269a9e4b4bdf8bffc91fcb63778e03097b3e">2d1c269a</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T22:20:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/rpc/py_security: don't deref NULL for invalid values
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c9c1d444881d4464842cfc19fcb5ddd41c58dfa9">c9c1d444</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T22:20:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/pycredentials: always check self is a Credentials object
This prevents a segfault with
credentials.Credentials.guess(x)
where x is not a Credentials object.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0d0a88fc6a4371bf3666186792f253cacf2f1378">0d0a88fc</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T22:20:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pycredentials.h: use import to ensure python type correctness
Because we include pyrpc_util.h, pycredentials doesn't need its own
PyStringFromStringOrNull().
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/95a5140db3e84478b903f9e96fc34e87db2c07c6">95a5140d</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T22:20:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysecurity: use unsigned int, not int to approximate uint32_t
the "I" flag for unsigned int has been available since Python 2.3
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f8fb6f326129267c7742947943df3f920c8cb54f">f8fb6f32</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T22:20:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/pycreds/encrypt_netr_crypt_password: don't segfault
Non-talloc objects were treated as talloc objects, to no good effect
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a5e8a5e05bcb89a3fc36044ce89ac49df2f00d03">a5e8a5e0</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T22:20:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/pycreds/encrypt_netr_crypt_password: don't pretend arg is optional
The "|O" signature is saying the password argument is optional, which
makes no sense in terms of the funxtion and immediately leads to a
TypeError (or until last commit, segfault). Removing the "|" leaves it
with a TypeError, but it is better worded and faster.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/57fc8b6c5369d99b544ff0f43720b9670e018a2a">57fc8b6c</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T22:20:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/auth/pygensec: don't segfault when reporting bad types
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a2680b44358b2e85354c88c3fdd525327835e43a">a2680b44</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T22:20:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb/py: avoid null deref with bad python arguments
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f3b65ff4e5e27e65574a69ee72ac017cd6b3f93c">f3b65ff4</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T22:20:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/smbd/py: avoid null deref with bad python arguments
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/936c96620743b75d3177b787cd50478d346c5870">936c9662</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T22:20:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/gensec/py: avoid null deref with bad python arguments
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3d33e336267f54e1fe344bf1a83af88092c5ad43">3d33e336</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T22:20:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/auth/py: avoid null deref with bad python arguments
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0348dd4b31062b2cf12d19ec5515a309d1d9b470">0348dd4b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-22T23:37:56+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dcerpc: use anon creds for unknown transport
Otherwise we get a segfault when the NULL creds are dereferenced in cli_credentials_is_anonymous()
$ python3 -c"from samba.dcerpc.dnsserver import dnsserver; d = dnsserver('addc')"
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Jul 22 23:37:57 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/42bd3a72a2525aa8a918f4bf7067b30ce8e0e197">42bd3a72</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "nfs4acl: Fix owner mapping with ID_TYPE_BOTH"
This reverts commit 5d4f7bfda579cecb123cfb1d7130688f1d1c98b7.
That patch broke the case with ID_TYPE_BOTH where a file is owned by a
group (e.g. using autorid and having a file owned by
BUILTIN\Administrators). In this case, the ACE entry for the group gets
mapped a to a user ACL entry and the group no longer has access (as in
the user's token the group is not mapped to a uid).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a06486bb110d04a90b66a0bca4b1b600ef3c0ebf">a06486bb</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Remove fsp from smbacl4_win2nfs4
Only the information whether the ACL is for a file or a directory is
required. Replacing the fsp with a flag is clearer and allows for unit
testing of the mapping functions.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8fb906a1860452a320c79ac87917a97303729c19">8fb906a1</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Start implementing unit test for nfs4_acls
Existing smbtorture tests set and query ACLs through SMB, only working
with the DACLs in the Security Descriptors, but never check the NFSv4
ACL representation. This patch introduces a unit test to verify the
mapping between between Security Descriptors and NFSv4 ACLs. As the
mapping code queries id mappings, the id mapping cache is first primed
with the mappings used by the tests and those mappings are removed again
during teardown.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/00f494b25f4e1d1aecf6191523e30f20a90b1e4f">00f494b2</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_nfs4_acls: Add tests for mapping of empty ACLs
This is a fairly simple test that ensures the mapping of empty ACLs
(without any ACL entries) is always done the same way.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dd5934797526ebb4c6f3027a809401dad3abf701">dd593479</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_nfs4_acls: Add tests for mapping of ACL types
Add testcases for mapping the type field (ALLOW or DENY) between NFSv4
ACLs and security descriptors.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/16eb61a900c6749c2554d635ce2dd903f5de1704">16eb61a9</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_nfs4_acls: Add test for flags mapping from NFS4 ACL to DACL
Add testcase for the mapping of inheritance flags when mapping from a
NFSv4 ACL to a DACL in the security descriptor. The mapping is different
between files and directories, as some inheritance flags should never be
present for files. Some defined flags like SUCCESSFUL_ACCESS are also
not mapped at this point, also verify this behavior.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bccd2612761e26ee2514935d56927b2c0c000859">bccd2612</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_nfs4_acls: Add test for flags mapping from DACL to NFS4 ACL
Add testcase for the mapping of inheritance flags from the DACL in the
security descriptor to the NFSv4 ACL. The mapping is different for files
and directories as some inheritance flags should not be present for
files. Also other flags are not mapped at all, verify this behavior.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1767027b44a9e4ebd865022e3f8abb0c72bf15c6">1767027b</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_nfs4_acls: Add test for mapping permissions from NFS4 ACL to DACL
Add testcase for mapping permissions from the NFSv4 ACL to DACL in the
security descriptor. The mapping is simple as each permission bit exists
on both sides.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e4840e680744bd860beedeb5123704c3c0d6a4d7">e4840e68</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_nfs4_acls: Add test for mapping permissions from DACL to NFS4 ACL
Add testcase for mapping the permission flags from the DACL in the
Security Descriptor to a NFSv4 ACL. The mapping is straight-forward as
the same permission bits exist for Security Descriptors and NFSv4 ACLs.
In addition, the code also maps from the generic DACL permissions to a
set of NFSv4 permissions, also verify this mapping.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f86148948c7f89307a34e31f6ddede6923149d34">f8614894</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_nfs4_acls: Add test for mapping of special NFS4 ACL entries to DACL entries
In addition to entries for users and groups, NFSv4 ACLs have the concept
of entries for "special" entries. Only the "owner", "group" and
"everyone" entries are currently used in the ACL mapping.
Add a testcase that verifies the mapping from NFSv4 "special" entries to
the DACL in the security descriptor. Verify that only "owner", "group"
and "everyone" are mapped and all other "special" entries are ignored.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1f1fa5bde2c76636c1beec39c21067b252ea10be">1f1fa5bd</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_nfs4_acls: Add test for mapping from DACL to special NFS4 ACL entries
Add testcase for mapping from entries in the DACL security descriptor to
"special" entries in the NFSv4 ACL. Verify that the WORLD well-known SID
maps to "everyone" in the NFSv4 ACL. Verify that the "Unix NFS" SID is
ignored, as there is no meaningful mapping for this entry. Verify that
SID entries matching the owner or group are mapped to "special owner"
or "special group", but only if no inheritance flags are used. "special
owner" and "special group" with inheritance flags have the meaning of
CREATOR OWNER and CREATOR GROUP and will be tested in another testcase.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bfcc19b705f83bdd5cf665fd4daf43e7eae997a9">bfcc19b7</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_nfs4_acls: Add test for mapping CREATOR entries to NFS4 ACL entries
Add testcase for mapping DACL entries CREATOR OWNER and CREATOR GROUP
with inheritance flag in the security descriptor to NFSv4 "special
owner" and "special group" entries. This is the correct mapping for
these entries as inheriting "special owner" and "special group" grants
permissions to the actual owner and owning group of the new file or
directory, similar to what CREATOR entries do.
The other side is that CREATOR entries without any inheritance flags do
not make sense, so these are not mapped to NFSv4 ACL entries.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3c9cda0f6d80258ef0c2a80d6e24dfb650fea1b1">3c9cda0f</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_nfs4_acls: Add test for mapping from NFS4 to DACL CREATOR entries
Add testcase for mapping from NFSv4 ACL entries for "special owner" and
"special group" to DACL entries in the security descriptor. Each NFSv4
entry here with INHERIT_ONLY maps directly to a CREATOR OWNER or CREATOR
GROUP entry in the DACL. Entries without INHERIT_ONLY map to the CREATOR
entry and an additional explicit entry granting permission on the
current object.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/30677df4dac4ebfcf4e3198db33f14be37948197">30677df4</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_nfs4_acls: Add test for 'map full control' option
"map full control" when enabled adds the DELETE_CHILD permission, when
all other permissions are present. This allows Windows clients to
display the "FULL CONTROL" permissions.
Add a testcase that verifies this mapping when mapping from NFSv4 ACL to
the DACL in the security descriptor. Also verify that switching the
option off disables this behavior.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9671bf2b9f055012057620207624aa2f4ea6833e">9671bf2b</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_nfs4_acls: Add test for acedup settings
The NFSv4 ACL mapping code has a setting nfs4:acedup. Depending on the
setting, when mapping from DACLs to NFSv4 ACLs, duplicate ACL entries
are either merged, ignored or rejected. Add a testcase that has
duplicate ACL entries and verify the expected behavior for all possible
settings of the nfs4:acedup option.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f55cdf42a14f314102f2e13cb06d4db48c08ad4b">f55cdf42</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_nfs4_acls: Add test for matching DACL entries for acedup
The NFSv4 mapping code has a config option nfs4:acedup for the mapping
path from DACLs to NFSv4 ACLs. Part of this codepath is detecting
duplicate ACL entries. Add a testcase with different ACL entries and
verify that only exactly matching entries are detected as duplicates and
treated accordingly.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7ae06d96eb59722154d30e21949f9dba4f2f0bc6">7ae06d96</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_nfs4_acls: Add test for mapping from DACL to NFS4 ACL with config special
The mapping code between NFSv4 ACLs and security descriptors still has
the deprecated config setting "nfs4:mode = special". This should not be
used as it has security problems: All entries matching owner or group
are mapped to "special owner" or "special group", which can change its
meaning when being inherited to a new file or directory with different
owner and owning group.
This mode should eventually be removed, but as long as it still exists
add testcases to verify the expected behavior. This patch adds the
testcase for "nfs4:mode = special" when mapping from the DACL in the
security descriptor to the NFSv4 ACL.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/829c5ea99685c0629fd67ed0528897534ff35b36">829c5ea9</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_nfs4_acls: Add test for mapping from NFS4 to DACL in config mode special
The mapping code between NFSv4 ACLs and security descriptors still has
the deprecated config setting "nfs4:mode = special". This should not be
used as it has security problems: All entries matching owner or group
are mapped to "special owner" or "special group", which can change its
meaning when being inherited to a new file or directory with different
owner and owning group.
This mode should eventually be removed, but as long as it still exists
add testcases to verify the expected behavior. This patch adds the
testcase for "nfs4:mode = special" when mapping from the NFS4 ACL to the
DACL in the security descriptor.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/86480410aec1d2331c65826a13f909492165a291">86480410</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_nfs4_acls: Add test for mapping from NFS4 ACL to DACL with IDMAP_TYPE_BOTH
When id mappings use IDMAP_TYPE_BOTH, the NFSv4 ACL mapping code is not
aware whether a particular entry is for a user or a group. The
underlying assumption then is that is should not matter, as both the ACL
mapping maps everything to NFSv4 ACL group entries and the user's token
will contain gid entries for the groups.
Add a testcase to verify that when mapping from NFSv4 ACL entries to
DACLs with IDMAP_TYPE_BOTH, all entries are mapped as expected.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/38331b00521ef764893a74add01758f14567d901">38331b00</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_nfs4_acls: Add test for mapping from DACL to NFS4 ACL with IDMAP_TYPE_BOTH
When id mappings use IDMAP_TYPE_BOTH, the NFSv4 ACL mapping code is not
aware whether a particular entry is for a user or a group. The
underlying assumption then is that is should not matter, as both the ACL
mapping maps everything to NFSv4 ACL group entries and the user's token
will contain gid entries for the groups.
Add a testcase to verify that when mapping from DACLS to NFSv4 ACL
entries with IDMAP_TYPE_BOTH, all entries are mapped as expected.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d9a2ff559e1ad953141b1118a9e370496f1f61fa">d9a2ff55</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Use sids_to_unixids to lookup uid or gid
This is the newer API to lookup id mappings and will make it easier to
add to the IDMAP_TYPE_BOTH case.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f198a0867e71f248d4887ab0b6f2832123b16d11">f198a086</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Use switch/case for checking idmap type
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3b3d722ce579c19c7b08d06a3adea275537545dc">3b3d722c</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Use correct type when checking ownerGID
uid and gid are members of the same union so this makes no difference,
but for type correctness and readability use the gid to check for
ownerGID.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/336e8668c1cc3682cb3c198eb6dc49baf522a79a">336e8668</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Add helper function for checking INHERIT flags.
This avoids some code duplication. Do not make this static, as it will
be used in a later patch.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmit <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ba73d2363d93a376ba4947963c9de45a7e683f02">ba73d236</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Add missing braces in smbacl4_win2nfs4
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/44790721e4f2c6ee6f46de7ac88123ce1a9f6e39">44790721</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Remove i argument from smbacl4_MergeIgnoreReject
This is only used for logging of a rejected ACL, but does not provide
additional useful information. Remove it to simplify the function a bit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3499d97463110f042415d917160bc2743805a544">3499d974</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Move smbacl4_MergeIgnoreReject function
This static function will be called earlier in later patches.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/abb58b17599bd3f9a06037e208dcc5033c7fdd8b">abb58b17</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Move adding of NFS4 ACE to ACL to smbacl4_fill_ace4
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7ab0003ffc098247c3ee3962d7061f2af5a2d00e">7ab0003f</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Remove redundant logging from smbacl4_fill_ace4
Logging flags in case they do not match seems unnecessary. Other log
messages should show the flags as well.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aa4644193635d846c2e08e8c1e7b512e8009c2ef">aa464419</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Remove redundant pointer variable
The previous patch introduced a pointer to a local variable to reduce
the amount of lines changed. Remove that pointer and adjust all usage
accordingly.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b796119e2df38d1935064556934dd10da6f3d339">b796119e</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Add additional owner entry when mapping to NFS4 ACL with IDMAP_TYPE_BOTH
With IDMAP_TYPE_BOTH, all entries have to be mapped to group entries.
In order to have the file system reflect the owner permissions in the
POSIX modebits, create a second entry for the user. This will be mapped
to the "special owner" entry.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/169812943de23cf2752289c63331d786b0b063bd">16981294</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Rename smbacl4_fill_ace4 function
As this function now maps the ACE and also adds it to the NFSv4 ACE,
change the name to better describe its behavior.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9c88602128592ddad537bf70cbe3c51f0b2cebe5">9c886021</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Remove duplicate entries when mapping from NFS4 ACL to DACL
The previous patch added an additional entry for IDMAP_TYPE_BOTH. When
mapping back to a DACL, there should be no additional entry. Add a loop
that will check and remove entries that are exact duplicates.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1a137a2f20c2f159c5feaef230a2b85bb9fb23b5">1a137a2f</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Add test for merging duplicates when mapping from NFS4 ACL to DACL
The previous patch introduced merging of duplicates on the mapping path
from NFS4 ACL entries to DACL entries. Add a testcase to verify the
expected behavior of this codepath.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/86f7af84f04b06ed96b30f936ace92aa0937be06">86f7af84</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Use correct owner information for ACL after owner change
After a chown, the cached stat data is obviously no longer valid. The
code in smb_set_nt_acl_nfs4 checked the file correctly, but did only use
a local buffer for the stat data. So later checks of the stat buffer
under the fsp->fsp_name->st would still see the old information.
Fix this by removing the local stat buffer and always update the one
under fsp->fsp_name->st.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0aca678fcf1788a76cf0ff11399211c795aa7d2f">0aca678f</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Remove merge_writeappend parameter
All supported GPFS versions now support setting WRITE and APPEND in the
ACLs independently. Remove this now unused parameter to simplify the
code.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8bd79ecc37376dbaa35606f9c2777653eb3d55e3">8bd79ecc</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Remove gpfs:merge_writeappend from vfs_gpfs manpage
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fbf3a090a9ec94262b2924461cc1d6336af9919c">fbf3a090</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Move mapping from generic NFSv ACL to GPFS ACL to separate function
This is not functional change. It cleans up the code a bit and makes
expanding this codepath in a later patch easier.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c1770ed96fd3137f45d584ba9328333d5505e3af">c1770ed9</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Implement special case for denying owner access to ACL
In GPFS, it is not possible to deny ACL or attribute access through a
SPECIAL_OWNER entry. The best that can be done is mapping this to a
named user entry, as this one can at least be stored in an ACL. The same
cannot be done for inheriting SPECIAL_OWNER entries, as these represent
CREATOR OWNER entries, and the limitation of not being able to deny
owner access to ACL or attributes remains.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8f3ebad2e84317997a9be705c809695529455eb6">8f3ebad2</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Remove unused SMB_ACLTYPE_ defines
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3a71d619a935b57acacb6a8ba7c80b0ae938eacd">3a71d619</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Change type of smbacl4_substitute_simple to void
The function always returned true and the return code was never checked,
so simply change to void.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/54a0b1ca664dcde017dcc46c4398c7c3806ec4c3">54a0b1ca</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Use C99 initializer instead of ZERO_STRUCTP for params struct
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/728de59740925665d55c72c7f67c85c7b6b4a5e1">728de597</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Add warning for deprecated setting nfs4:mode special
The documentation states this has been deprecated for years. Add logging
a warning when this is set. Maybe this can be removed in the future.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/de4a11589f15bd983d9f610f532636ac6233d05c">de4a1158</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Update copyright header
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ab4e91d24df19ce820bc092cb91cede42d11037d">ab4e91d2</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Update nfs4:mode example for vfs_zfs
nfs4:mode special has been deprecated. Switch the example to "simple" to
avoid the deprecated setting in the example.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b52b5de76a87a332d7eb74d77e93180c723bf0b9">b52b5de7</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Mark nfs4:acedup ignore and reject as deprecated
The default setting for nfs4:acedup is "dontcare". The only
recommendation i could find is setting this to "merge". The setting of
"ignore" is dangerous as it would silently drop ACEs. "reject" also
seems less useful as it would disallow setting of ACLs that can easily
be stored.
Report "ignore" and "reject" as deprecated. Maybe these can be removed
in the future to simplify the code.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4aac7d37278d7707ac366c48e49f6d7b49ac5380">4aac7d37</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Update manpages for deprecated nfs4:acedup settings
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f81191d51bb345ac13402dc4c8100576b4b381cb">f81191d5</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Change default of nfs4:acedup to "merge"
All tutorials i could find that configure Samba with NFSv4 ACLs set this
parameter to "merge". As this seems to be the main usecase, make this
setting the default.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f466f4d3e8435a2e0a4a7ec2ca50e02df1f7869e">f466f4d3</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Update vfs_gpfs manpage for the new default of nfs4:acedup
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d28b55198a823f94399698843fa62967bb197a7b">d28b5519</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T18:27:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Document change of default for nfs4:acedup parameter
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a073799ded5d26dfc7b37b82e7309e06034f95b1">a073799d</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-07-23T19:45:05+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4_acls: Use fsp stat buffer in smb_fget_nt_acl_nfs4
Instead of having a local buffer for the stat data, update the one kept
in the fsp. With this change the local stat buffer and the helper
function smbacl4_fGetFileOwner are no longer needed and can be removed.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Tue Jul 23 19:45:05 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9f504fd5a320edcbd3d763d4e0464f3cf7d270e1">9f504fd5</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-07-24T02:24:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Store total conversations on the replay context
This is useful info to know, and will be used in subsequent commits.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6b1f9b4a5ff5450b0858d27dcc1af3021694be7d">6b1f9b4a</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-07-24T02:24:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Make use of SCOPE_BASE explicit
i.e. avoid hard-coded numbers.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6d6fe4993876d3374ae7ffeaf55d660ffa6b450b">6d6fe499</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-07-24T02:24:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic replay: Store the instance id in the replay context
Store the traffic runner instance id in the replay context. Will be
used in subsequent commits.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7abfa6778f309bc3c1cfdb45042f708e81cfad9d">7abfa677</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-07-24T02:24:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic replay test: Populate total_converations and instance_id
Ensure that the total_conversations and instance_id attributes are
assigned a value in the replay contexts passed to test cases.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/630857c71eff6332a6c94292ee840fa86a727f10">630857c7</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-07-24T02:24:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic_replay: Avoid DB full scans in LDAP searches
When generating LDAP search traffic, a full DB scan can be very costly.
Avoiding full-scan LDAP searches means that we can run traffic_replay
against a 100K user DB and get some sane results.
Because the traffic_learner doesn't record the LDAP search filter at all,
the traffic_replay LDAP searches default to being full scans.
Doing full scans meant that the LDAP search was usually the first packet
type to exceed the max latency and fail the test. It could also skew
results for the other packet types by creating big demands on memory/CPU/
DB-lock-time.
It's hard to know for sure exactly what real-world LDAP searches will
look like, but let's assume full scan searches will be fairly rare.
In traffic-model files we've collected previously, some of the
attributes are fairly unique (e.g. pKIExtendedKeyUsage), and as there
are some LDAP queries specified in MS specs (such as MS-GPOL and
MS-WCCE), it allows us to infer what the search filter might be.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/256684c7a86301d26d6cf7298fb70e647bf45cf5">256684c7</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-07-24T04:18:21+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">join: Use a specific attribute order for the DsAddEntry nTDSDSA object
Joining a Windows domain can throw an error if the HasMasterNCs
attribute occurs before msDS-HasMasterNCs. This patch changes the
attribute order so that msDS-HasMasterNCs is always first.
Previously on python2, the dictionary hash order was arbitrary but
constant. By luck, msDS-HasMasterNCs was always before HasMasterNCs, so
we never noticed any problem. With python3, the dictionary hash order
now changes everytime you run the command, so the order is
unpredictable.
To enforce a order, we can change to use an OrderedDict, which will
return the keys in the order they're added.
I've asked Microsoft to clarify the protocol requirement here WRT
attribute order. However, in the meantime we may as well fix the problem
for users.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14046
RN: When trying to join a Windows domain (with functional level 2008R2)
as an AD domain controller, the 'samba-tool domain join' command could
throw a python exception: 'RuntimeError ("DsAddEntry failed")'. When
this problem occurred, you would also see the message "DsAddEntry failed
with status WERR_ACCESS_DENIED info (8363, 'WERR_DS_NO_CROSSREF_FOR_NC')"
in the command output. This issue has now been resolved. Note that this
problem would only occur on Samba v4.10 when using the Python3 packages.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jul 24 04:18:21 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/765fc314e4aee455bae0f391a7d388584b48bb4a">765fc314</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-24T04:19:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/auth/kerberos: clang: Fix 'value stored to 'ret' is never read '
Fixes:
source4/auth/kerberos/kerberos_pac.c:116:2: warning: Value stored to 'ret' is never read <--[clang]
ret = smb_krb5_make_pac_checksum(mem_ctx,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6f733b5891db344ec9f3f996322213d8ac2075e5">6f733b58</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-24T04:19:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/auth/kerberos: clang: Fix Value stored to 'code' is never read
Fixes:
source4/auth/kerberos/kerberos_util.c:645:3: warning: Value stored to 'code' is never read <--[clang]
code = 0;
^ ~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/79d585689e206dc0e04a4d30f75a38dc4490d96b">79d58568</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-24T04:19:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/common: clang: Fix 'function call argument is an uninitialized value'
Fixes:
source4/dsdb/common/util.c:1804:8: warning: 3rd function call argument is an uninitialized value <--[clang]
ret = samdb_reference_dn(ldb, mem_ctx, server_ref_dn, "rIDSetReferences", dn);
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bd86df913b14070e157b6a9178438f71321c8872">bd86df91</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-24T04:19:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/common: clang: Fix 'The left operand of '&' is a garbage value'
Fixes:
source4/dsdb/common/util.c:1964:18: warning: The left operand of '&' is a garbage value <--[clang]
return (options & DS_NTDSDSA_OPT_IS_GC) != 0;
~~~~~~~ ^
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/55f18757aae0f7fb137217e42ced6e2e08bfbfa2">55f18757</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-24T04:19:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/common: clang: Fix 'Access results in a deref of a null pointer'
Fixes:
source4/dsdb/common/util.c:2000:6: warning: Access to field 'count' results in a dereference of a null pointer (loaded from variable 'res') <--[clang]
if (res->count != 1) {
^~~
source4/dsdb/common/util.c:3281:28: warning: Access to field 'msgs' results in a dereference of a null pointer (loaded from variable 'res') <--[clang]
el = ldb_msg_find_element(res->msgs[0], attr);
^~~
source4/dsdb/common/util.c:3568:6: warning: Access to field 'count' results in a dereference of a null pointer (loaded from variable 'res') <--[clang]
if (res->count != 1 || ret != LDB_SUCCESS) {
^~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c7c40e205d432342457b20312f3ebf94e15b9ff6">c7c40e20</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-24T04:19:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/common: clang: Fix 'Value stored to 'cps_stdin' is never read'
Fixes:
source4/dsdb/common/util.c:2125:4: warning: Value stored to 'cps_stdin' is never read <--[clang]
cps_stdin = -1;
^ ~~
source4/dsdb/common/util.c:2132:3: warning: Value stored to 'cps_stdin' is never read <--[clang]
cps_stdin = -1;
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/54af94ff21a7f395133bcc13458cc2e1f52183be">54af94ff</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-24T05:49:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/source4/common: clang: Fix 'Dereference of undefined pointer value'
Fixes:
source4/dsdb/common/util.c:3131:6: warning: Dereference of undefined pointer value <--[clang]
if (res->count < 1) {
^
/source4/dsdb/common/util.c:3207:6: warning: Dereference of undefined pointer value <--[clang]
if (res->count < 1) {
^~~~~~~~~~
source4/dsdb/common/util.c:4004:39: warning: Dereference of undefined pointer value <--[clang]
(*wkguid_dn) = talloc_steal(mem_ctx, res->msgs[0]->dn);
^
source4/dsdb/common/util.c:4191:35: warning: Dereference of undefined pointer value <--[clang]
ouv_value = ldb_msg_find_ldb_val(r->msgs[0], "replUpToDateVector");
source4/dsdb/common/util.c:5757:13: warning: 1st function call argument is an uninitialized value <--[clang]
same_nc = (ldb_dn_compare(source_nc, target_nc) == 0);
^
This fix also fixes the associated 'Access to field 'xyx' results in a
dereference of a null pointer' warnings that also will happen when this
is fixed
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Wed Jul 24 05:49:14 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7f4bc0ea81f2b34607849911f1271b030be8ca02">7f4bc0ea</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2019-07-24T05:50:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">partition: correcting lock ordering
A schema reading bug was traced to a lock ordering issue in partition.c.
This patch fixes the problem by:
1. Releasing locks/transactions in the order they were acquired.
2. Always lock/start_trans on metadata.tdb first, before any other
databases, and release it last, after all others. This is so that we are
never exposed to MDB's lock semantics, which we don't support.
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6c691bf84e41b1edd3228c219f7a94e108795d28">6c691bf8</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2019-07-24T05:50:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">partition: reversing partition unlocking
Unlock partition databases in the reverse order from which they were
acquired. This is separated from the previous commit for future
bisecting purposes, since the last commit was made to fix specific CI
failures, while this one is a speculative fix made based on code
inspection.
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9d2fd08249881702a4b4b881688d91576cc71ede">9d2fd082</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-07-24T07:07:01+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Better error message for backup with no RID pool
Add a better error message (and what to do about it) if the user tries
to back up a DC that hasn't initialized its RID pool yet.
Seems to be a fairly common problem hit by users.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14048
RN: Added more informative error message if the 'samba-tool domain
backup' command fails due to no RID pool being present on the DC.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jul 24 07:07:01 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/41c94b8b1f0ba312711b5b6c2ba2f27c696b445b">41c94b8b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-24T07:40:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: OpenDir() is merely a wrapper around open_dir_safely().
Preparatory work.
Separate these out internal to source3/smbd/dir.c so I can
give the internal and external uses separate destructor functions
to allow all client requested directory enumeration to move to handle
based functions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d1441089722b7985df417494f6542e6560e99330">d1441089</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-24T07:40:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Move the setting of the destructor of struct smb_Dir * up two levels.
Previously, open_dir_safely() called OpenDir_internal() which
set the destructor.
Move setting the destructor into the callers of open_dir_safely()
as this will allow us to have different destructors for handle-based
calls.
The reason this is important is that I have a follow up patchset
that depends on this which makes all client directory enumerations
handle-based, calling OpenDir_fsp() only, and so the destructor there
will take care of the fsp back pointer.
Trying to keep a common destructor for handle-based and non-handle
based calls broke my brain when trying to separate the handle-based
calls from the non-handle based ones in my later patchset.
NB. The change in OpenDir_fsp() isn't a logic change as instead
of doing an early return from a function that sets the destructor,
we now fallthrough to setting the destructor then return, which
is identical.
Eventually the whole codepath using the fallback for non-handle
opens inside dptr_create() will go away and this simplifies the
code immensely. Some short term pain for long-term gain :-).
Added doxygen documentation as requested.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eb5fa8ac8465e621c95da1f03b68da8aae73f6b0">eb5fa8ac</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-24T07:40:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Use a separate simple destructor for the OpenDir() codepath.
This will help greatly in understanding the code changes later.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/79eae9e38ac2ef967671b43fc2eb76d8b195eee8">79eae9e3</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-24T07:40:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Naming consistency. Change all uses of struct smb_Dir * variables to be dir_hnd.
Fixes smb_Dir_destructor(). No logic changes.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8e65157edf4fe5a9e7c4abdd6c0f2a8d5b8c43b2">8e65157e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-24T07:40:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Naming consistency. Change all uses of struct smb_Dir * variables to be dir_hnd.
Fixes DirCacheAdd(). No logic changes.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8ad519c4089df71a9fc9191cead68e4eabf844f1">8ad519c4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-24T07:40:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Naming consistency. Change all uses of struct smb_Dir * variables to be dir_hnd.
Fixes OpenDir_internal(). No logic changes.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cc4ac86b950f443b4dd23ca997d872549c80a484">cc4ac86b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-24T07:40:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Naming consistency. Change all uses of struct smb_Dir * variables to be dir_hnd.
Fixes OpenDir_fsp(). No logic changes.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ec072f1a971faba9c140bae0f7792e5fc154189f">ec072f1a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-24T07:40:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Naming consistency. Change all uses of struct smb_Dir * variables to be dir_hnd.
Fixes ReadDirName(). No logic changes.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a5b876f3dbdd2dc17407ec08340b5d192b374098">a5b876f3</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-24T07:40:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Naming consistency. Change all uses of struct smb_Dir * variables to be dir_hnd.
Fixes RewindDir(). No logic changes.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3d95064ceba82a43f6edd5c4b250a22461986480">3d95064c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-24T07:40:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Naming consistency. Change all uses of struct smb_Dir * variables to be dir_hnd.
Fixes TellDir(). No logic changes.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4db886db066c53386aaa16a415c081bd50193af9">4db886db</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-07-24T08:57:05+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Naming consistency. Change all uses of struct smb_Dir * variables to be dir_hnd.
Fixes SearchDir(). No logic changes.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Jul 24 08:57:05 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e7a6c70953daa84b88004e791e67b9a45f086946">e7a6c709</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-24T09:35:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/replmd: replicated_handle_rename free temp_ctx
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5d75ab3ebf48f876f4fb462e0d18c71f931a27c2">5d75ab3e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-24T09:35:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/replmd: add a helper for common calculations
We currently do exactly this work, in exactly these words (ignoring
formatting) in two different places. The next two commits will make
those places use this helper function. We do this over three commits
so that we can more easily compare the next two and be sure they are
doing the same thing.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b9dab848de066a8a3821c30261de8d6cccd77370">b9dab848</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-24T09:35:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/replmd: use incoming_dn_should_be_renamed() 1/2
In replmd_op_possible_conflict_callback().
The helper function was introduced in the previous commit and consists
of a large common stretch of this and replmd_replicated_handle_rename().
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e77237bb46cb1e39433c04d3f4552c4f0ddd4f96">e77237bb</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-24T11:21:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/dsdb/replmd: use incoming_dn_should_be_renamed() 2/2
In replmd_replicated_handle_rename().
The helper function was introduced two commits ago and consists of
a large common stretch of this and the function modified in the previous
commit.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jul 24 11:21:50 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/90e36ef72992a073ba92e736f4533a10f3f5248f">90e36ef7</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-24T21:33:20+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/smb: clang: Fix Value stored to 'next_offset' is never read
Fixes:
ibcli/smb/smb2_negotiate_context.c:117:3: warning: Value stored to 'next_offset' is never read <--[clang]
next_offset += next_pad;
^ ~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/849ffbc8251aa193cfcab043ab7c818a666a4a68">849ffbc8</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-24T21:33:20+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/adnss: clang: Fix The left operand of '!=' is a garbage value
Fixes:
lib/addns/dnssock.c:143:3: warning: The left operand of '!=' is a garbage value <--[clang]
TALLOC_FREE(conn);
^
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6858c83dc625ab2d4c02c702f8f5351805df0ae1">6858c83d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-24T21:33:20+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib/dwrap: clang: Fix 'Value stored to 'ret' is never read'
Fixes:
source3/lib/dbwrap/dbwrap_ctdb.c:95:2: warning: Value stored to 'ret' is never read <--[clang]
ret = ctdbd_init_connection(mem_ctx,
^ ~~~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/637cd1a6c4175c527caa144767f3543156c66ed5">637cd1a6</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-24T21:33:20+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib/dbwrap: clang: Fix 'Access to field results in a deref of a null'
Fixes:
source3/lib/dbwrap/dbwrap_ctdb.c:530:39: warning: Access to field 'm_write' results in a dereference of a null pointer (loaded from field 'transaction') <--[clang]
if (pull_newest_from_marshall_buffer(ctx->transaction->m_write, key,
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6baf0208eb85e834138f666153f94e8327e84996">6baf0208</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-24T21:33:21+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcls/nbt: clang: Fix 'initialization value is never read'
Fixes:
libcli/nbt/nbtsocket.c:65:27: warning: Value stored to 'req' during its initialization is never read <--[clang]
struct nbt_name_request *req = nbtsock->send_queue;
^~~ ~~~~~~~~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/da4c1c5f39669274bf8ff5a0974b4111f80be798">da4c1c5f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-24T21:33:21+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/addns: clang: Fix 'Value stored to 'err' is never read'
Fixes:
/home/samba/samba/lib/addns/dnsmarshall.c:406:2: warning: Value stored to 'err' is never read <--[clang]
err = ERROR_DNS_NO_MEMORY;
^ ~~~~~~~~~~~~~~~~~~~
/home/samba/samba/lib/addns/dnsmarshall.c:447:3: warning: Value stored to 'err' is never read <--[clang]
err = buf->error;
^ ~~~~~~~~~~
2 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/be2b69fecebd35d7a60057d6515e4401d3ce1294">be2b69fe</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-24T21:33:21+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/addns: clang: Fix 'Assigned value is garbage or undefined'
Fixes:
lib/addns/dnsquery.c:222:10: warning: Assigned value is garbage or undefined <--[clang]
*numdcs = num_srvs; /* size_t->int */
^
1 warning generated.
Also fixes the out param being modified even on failure
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1d651a8d5847c1ecd87d5f1bbfc7714e078d60f2">1d651a8d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-24T21:33:21+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib: clang: Fix 'Acces to field results in a deref of a null pointer'
Fixes:
source3/lib/ctdbd_conn.c:415:6: warning: Access to field 'operation' results in a dereference of a null pointer (loaded from variable 'hdr') <--[clang]
if (hdr->operation == CTDB_REQ_MESSAGE) {
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/81f8cbfba358b61e7b394887d23f751691eb8388">81f8cbfb</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-24T21:33:21+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib: clang: Fix 'function call argument is an uninitialized value'
Fixes:
source3/lib/ctdbd_conn.c:1066:3: warning: 3rd function call argument is an uninitialized value <--[clang]
DEBUG(0,("ctdbd_control failed: %s, %d\n", strerror(ret),
^
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3913b9a4088b83d6ed7f94d136a26ecfa7e16b35">3913b9a4</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-07-24T22:50:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib: clang: Fix 'access to field results in a deref of a null pointer'
Fixes:
source3/lib/ctdbd_conn.c:1953:6: warning: Access to field 'operation' results in a dereference of a null pointer (loaded from variable 'hdr') <--[clang]
if (hdr->operation != CTDB_REPLY_CALL) {
^~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Wed Jul 24 22:50:27 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5e62358fbf9ed107ed4a5eb82b62e82ae5638262">5e62358f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:22+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:crypto: Document gnutls_error_to_ntstatus()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e43678b84a3434b977f44b265599f1d9207d3b78">e43678b8</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:22+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:crypto: Document gnutls_error_to_werror()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/baa96ef20945638fb5ee76b03543c7b611e9c7d7">baa96ef2</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:22+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:crypto: Document samba_gnutls_arcfour_confounded_md5()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4b9b1dbe9c8c988a39b1318a4f7aac031bc1ea8b">4b9b1dbe</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:22+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_client: Return NTSTATUS for init_samr_CryptPassword()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7915a48e53c8f72ba56da2f433427b961feeb16f">7915a48e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:22+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_client: Return NTSTATUS for init_samr_CryptPasswordEx()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/57dd415ba49b9621deddf604a5bf148c10ebc37e">57dd415b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:22+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Return NTSTATUS for encode_or_decode_arc4_passwd_buffer()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7ccc76f951a626a25d553ac85c5bf30eb29ffa2b">7ccc76f9</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:22+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Add test for decoding an RC4 password buffer
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2075019ca90d7d474003c87b2f0202239891eba5">2075019c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:22+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_client: Use samba_gnutls_arcfour_confounded_md5 in init_samr_CryptPasswordEx
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/95db9a81db093488e625b4ef385a184a5e517ede">95db9a81</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_client: Use GnuTLS RC4 in init_samr_CryptPassword()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dea160820a393be51985a4e761a3f73da83972e7">dea16082</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Use samba_gnutls_arcfour_confounded_md5() for rc4 passwd buffer
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/89f8b028e2d595348f9996854488d7aa552ae905">89f8b028</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Rename encode_or_decode_arc4_passwd_buffer()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/79ca72ec3d13fea5d2ad608415757ca9870035a3">79ca72ec</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Pass samr_CryptPasswordEx to decode_rc4_passwd_buffer()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/06d46c447e69a6b384c0089863c343b4924c7caf">06d46c44</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Add encode_rc4_passwd_buffer()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fe00b3735a7e8ae16fb6443965769f1e947a6aa6">fe00b373</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Add test for encode_rc4_passwd_buffer()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f0c0cf299eb99e7b78be2f04141b6d415bf525e2">f0c0cf29</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_client: Use encode_rc4_passwd_buffer() in init_samr_CryptPasswordEx()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5afa402bb7ba11a8eefc6e14047eeec1f3327681">5afa402b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libnet: Use encode_rc4_passwd_buffer() in libnet_SetPassword_samr_handle_26()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e44ba0397c7558e1da6a46cc38237a3b0e5cef49">e44ba039</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libnet: Use encode_rc4_passwd_buffer() in libnet_SetPassword_samr_handle_25()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/18937f9ceb5aca23899555c5a34fe359f6fcb126">18937f9c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libnet: Use GnuTLS RC4 in libnet_SetPassword_samr_handle_24()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cdb4e12765266ae767021d932870fbfcd55ccbf6">cdb4e127</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libnet: Use GnuTLS RC4 in libnet_SetPassword_samr_handle_23()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9ea736590d9b22a7518f86b18e8c55b0d0e213d5">9ea73659</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:libnet: Use GnuTLS RC4 in libnet_ChangePassword_samr()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/576bcf61555fb641b2919ad84a6b26b242b57061">576bcf61</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Return WERROR for encode_wkssvc_join_password_buffer()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f4a16bfba8d87de883d3d2e54cdc825fc5e01c2b">f4a16bfb</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Add test for (encode|decode)_wkssvc_join_password_buffer
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/85e2a3c96ad9acc1a85db189f6418c9d880b4718">85e2a3c9</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Use samba_gnutls_arcfour_confounded_md5() in encode_wkssvc_join_password_buffer()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bcf7808d3aa8a5932a40955e4b764f55061e07d7">bcf7808d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Use samba_gnutls_arcfour_confounded_md5() in decode_wkssvc_join_password_buffer()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cb4025a50232f24139f21d87e50b6e6ea69238ba">cb4025a5</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth:ntlmssp: Use GnuTLS RC4 in ntlmssp client
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7bd502dcdb44c7d0f8a56b2ba489ae8cf2b886bd">7bd502dc</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth:ntlmssp: Use GnuTLS RC4 for ntlmssp signing
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0947d8388def40b01b322d0deee4dba386983410">0947d838</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: Use GnuTLS RC4 in clirap
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a95647e12ac75ffda42d95b41144596a078aebd6">a95647e1</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_client: Use init_samr_CryptPassword in cli_samr rpc_client
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d31f6a6803c86b8de0a97927731091f5a7bee4f1">d31f6a68</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Use GnuTLS RC4 in samr password check
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cd0b5e5d9377bc79b4468081f3999ad39be3cb8f">cd0b5e5d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Use GnuTLS RC4 to decrypt samr password buffers
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/359ae5be0d21e7ab235035aab65710c9459e9593">359ae5be</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Use GnuTLS RC4 in ntlm_auth
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9363abfb5fcfeff30295ce0cf94c18941a6c4e9f">9363abfb</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-07-26T01:48:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Use samba_gnutls_arcfour_confounded_md5() in samr_set_password_ex()
This allows the use of GnuTLS for the underlying RC4 crypto operations.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4326e7de6ba0ce02ab23af7297d2f7242988daa4">4326e7de</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Use GnuTLS RC4 for samr password
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/811c412da5c24d7274f9aa4c7d653bbb1191e6a6">811c412d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use GnuTLS RC4 for RAP SAM test
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/80f5beb4804c694ee6e5f5b450e751f538677593">80f5beb4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use init_samr_CryptPassword(Ex) in samba3rpc test
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/70e05d7eb78a0c363dbd72cbbf4f3a264636c840">70e05d7e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use init_samr_CryptPassword in test_SetUserPass
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b0b9cabc4de64497140d33d0fdaf2927f2915987">b0b9cabc</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use init_samr_CryptPassword in test_SetUserPass_23
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e398ecbd8e32bb428073f3635d9178abfae28255">e398ecbd</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use init_samr_CryptPassword in test_SetUserPassEx
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3b9496d905408b75c21919b35b2105e2b0b0325f">3b9496d9</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use init_samr_CryptPassword in test_SetUserPass_25
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f45ba47afb11c1f7bbb8c5c84670395500e1afc1">f45ba47a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use init_samr_CryptPassword in test_SetUserPass_level_ex
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b512b5974494fe41010800f60df0f248b8ea850e">b512b597</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use GnuTLS RC4 in test_OemChangePasswordUser2
This uses STR_ASCII for password encoding!
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dfda49472e0b4a81653963e80d8d65788f80a591">dfda4947</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-07-26T01:48:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use init_samr_CryptPassword in test_ChangePasswordUser2
This allows the use of GnuTLS for the RC4 crypto operation
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1b1c302a7db23bf4377b8fa742ebf7ae913e3511">1b1c302a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-07-26T01:48:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use init_samr_CryptPassword in test_ChangePasswordUser2_ntstatus
This allows the use of GnuTLS for the RC4 crypto operation
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9cbdf7b2e5f734e9b5e0e447d54d720d18977950">9cbdf7b2</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4_torture: Use GnuTLS RC4 in test_ChangePasswordUser2
This uses STR_ASCII as string encodings.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a476a2e3322a550e2857cb5a66096fa3e46416d3">a476a2e3</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use GnuTLS RC4 in test_ChangePasswordUser2_ntstatus
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5b7c21fca576bf6e44233d69b47273058b9197c8">5b7c21fc</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use init_samr_CryptPassword in test_ChangePasswordUser3
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8380668be7963b74cbbd31bfab3d01d1f3089034">8380668b</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-07-26T01:48:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: clarify comments and variable names in "ChangePasswordUser3 tests
There is no session key here, the buffers are directly encrypted
with the long-term passwords.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/19d9c2c01a54957bc3852e2565d92c1cdd89498b">19d9c2c0</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-07-26T01:48:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use init_samr_CryptPassword in test_ChangePasswordRandomBytes
This allows the use of GnuTLS for the underlying RC4 crypto
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/82a6480611f791a3c26fcf70975e6f8b3b1757ad">82a64806</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use GnuTLS RC4 in test_ChangePasswordRandomBytes
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5740e9516f3587e3a9f72cf52cfe1eedd940b2a9">5740e951</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-07-26T01:48:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use samba_gnutls_arcfour_confounded_md5() in test_ChangePasswordRandomBytes
This ensures GnuTLS is used as the underlying RC4 crypto engine
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/301544ab2b0c85752d5307f2daab59652c08e1e0">301544ab</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Use init_samr_CryptPassword in testjoin RPC test
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fc4ae06001fbb0045318a8cec7af6af81241c60e">fc4ae060</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:crypto: Use GnuTLS RC4 in py_crypto
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/14c4a075875860e709a9e2e52aad83aa4c58a5ad">14c4a075</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:crypto: Remove arcfour.h from crypto.h
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9ede63fbada7842cd9ae120936bc6bd4b6ad16ac">9ede63fb</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:crypto: Don't build RC4 if we have GnuTLS >= 3.4.7
We have a GnuTLS DCEPRC backupkey implementation for the server and the
test. However this is only working with GnuTLS >= 3.4.7. So we need to
keep this around till we can require at least GnuTLS in a newer version.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fa09e811ca6fb08a66940380b310ce9794397071">fa09e811</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Use the passed mem_ctx instead of talloc_tos()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9158a6ba8693070f3b2b71dd15089488869ab6cd">9158a6ba</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpcclient: Use a stackframe for temporary memory
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/52b3f921ad2d04cb30232a6aadf261c9fc9aafb2">52b3f921</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: Use a stackframe for temporary memory
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1c84bda361678cb6c4685cff17a2d5a5026f2bce">1c84bda3</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T01:48:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Use a stackframe for temporary memory
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/93d424528f1c3d0d50ebd8a784f4624b2721d416">93d42452</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2019-07-26T01:48:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netlogon: Fix potential use of uninitialized variable
The _netr_NetrEnumerateTrustedDomains()->dcerpc_lsa_open_policy2() error
path checks the policy handle and closes it if non-empty. The policy
handle may be uninitialized in this code-path - fix this.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1f923e067dbe358c17cbccfe179baa811aa3b8b3">1f923e06</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-07-26T03:05:01+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Only dump passwords in developer builds
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Jul 26 03:05:01 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/242ea955e672799c45aba47f454900a5a52ce9f6">242ea955</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-07-26T03:34:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use required_error instead of required_result
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/efd0c45a8b152eb4716193bea6cf95e9e0b97d8b">efd0c45a</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-07-26T03:34:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Fix empty value handling in conf
In tini, allow_empty_value=false causes the parser to ignore the lines
without '=' sign, but lines with nothing after '=' sign are allowed and
cause empty string ("") to be passed as a value.
This is counter-intuitive, so conf requires special handling for empty
values (which are treated as invalid).
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6b7b1e8080096ccf64bfa236db597cec0856e6b7">6b7b1e80</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-07-26T03:34:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add tests for empty values in config file
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f2559ef8ce01a46b33a9295e67da920a327f3929">f2559ef8</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-07-26T03:34:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Log the master at the end of elections
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6fe963c3f72680ecbed1b6f9c70a7af003115666">6fe963c3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-07-26T03:34:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Periodically log recovery master of incomplete cluster
Only do this if the recovery lock is unset. Log every minute for the
first 10 minutes, then every 10 minutes, then every hour.
This is useful for determining whether a split brain occurred. It is
particularly useful if logging failed or was throttled at startup, so
there is no evidence of the split brain when it began.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c276723dd89995100ec42402eee65d6e3a623d03">c276723d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-07-26T03:34:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Set LANG=C for consistency of command output
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/98169241ef74d92beb433639834dfc0decc52a75">98169241</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-07-26T03:34:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-mutex: Update to use modern debug macro
One of these had a missing space, so this implicitly fixes it. It
also drops the need to unnecessarily include common.h, which comes
with some dependency baggage.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/76ab0a2b82db76ee48e98ae9ca6a4af18a99f68c">76ab0a2b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-07-26T03:34:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-mutex: Drop unneeded assignment
clang warns:
ctdb/server/ctdb_mutex_fcntl_helper.c:61:3: warning: Value stored to 'fd' is never read
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2b6f1a8ee648017dcdb595aacc0469d28e30d00e">2b6f1a8e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-07-26T03:34:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-mutex: Drop dependency on ctdb_set_helper
This makes the code more explicit and makes testing easier due to less
dependencies.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/adcf313c49cbd4e411d6f3fb50e90642f3b7531c">adcf313c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-07-26T03:34:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add cluster mutex tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d716be19ea14f15984eab8ce3388eb90bbb49d0a">d716be19</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-07-26T03:34:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add test to confirm need for cluster mutex lock file rechecking
Remove the lock and a second locker can take the it.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2f768a090e0a1f34660227e1aedc0ed03ea98534">2f768a09</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-07-26T03:34:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-mutex: Exit immediately if the lock isn't taken
There is no need to wait until the parent kills the helper. The
parent will get the initial response, indicating contention or
similar, and will then get a separate event indicating that the pipe
is gone.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fae8e438f019e7c1d20582f167b3adeac781ddbe">fae8e438</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-07-26T03:34:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-mutex: Change parent checking to use an asynchronous computation
Put the checking for the process being immediately re-parented into
the computation too. This will be very rare and doing it
consistently makes testing saner.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/af8de1bcfd4cfb2b2517b5badcc9ab564276fb92">af8de1bc</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-07-26T03:34:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-mutex: Add an intermediate asynchronous computation for waiting
This will allow more conditions to be waited on via additional
sub-requests. At the moment this just completes when the parent wait
completes.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/41cd44724e2d035d006645407ed623600d0ec6d8">41cd4472</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-07-26T03:34:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-mutex: Add support for exiting if the lock file disappears
If the lock file is inaccessible or the inode number changes then the
lock is lost, so exit. This allows the recovery daemon to trigger an
election. The ensuing recovery will re-take the lock.
By default the lock file is checked every 60 seconds. A lot can
happen in 60 seconds but being more aggressive and accessing the lock
too often could result in a performance issue for the cluster
filesystem.
An new optional 2nd argument is added, which is the lock file re-check
time in seconds.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2bd316d01d3ddf733787eba6092f5880b7feb65a">2bd316d0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-07-26T03:34:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add tests for cluster mutex lost handling
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ecef4411302113b0513db30169a8481a0a521316">ecef4411</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-07-26T03:34:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Fix 01.reclock.script tests for non-default lock
These tests currently do not do what is expected. They test the
default case.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5701f4aecafcd4efeba5bc12ace5da3101ea49d9">5701f4ae</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-07-26T03:34:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add some 01.reclock.script init event tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/38898775e6f1fb25171c920f2d8bcce24ec51476">38898775</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-07-26T03:34:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop monitoring of recovery lock
The fcntl helper now does a more meaningful check.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ea7708d8c7fa674111ccea58b3cd0757765c702a">ea7708d8</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-07-26T04:52:04+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Simplify 01.reclock.script
The "init" event is only run once so don't bother caching the
configured value of the recovery lock. Add some extra error checking.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Jul 26 04:52:04 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/57695ad44bf10d6ae1dc466551358bd826dac923">57695ad4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-07-30T22:37:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture3: Add oplock5 kernel-oplock test
Show that the current smb1 server does not properly retry a nonblocking
open of a kernel-oplocked file
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14060
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ef582ffcf3a220b73f678d9bce0fd37800f76c54">ef582ffc</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-07-30T22:37:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Always open files with O_NONBLOCK
It's perfectly possible that someone else takes a kernel oplock and
makes us block, independent of our own kernel oplock setting.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14060
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2b590e16bcb4f4e1f1f0bf049a863db38e634beb">2b590e16</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-07-31T00:12:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix retry for kernel-oplocked files
This now removed comment describes the bug correctly:
/*
* As this timer event is owned by req, it will
* disappear if req it talloc_freed.
*/
In smb1, "req" disappears once the reply_whatever routine is done. Thus
the timer goes away and we never look at "req" again.
This change moves the valid data (xconn and mid) to
deferred_open_record, and changes the talloc hierarchy such that the
timer is now a child of open_rec, which is a child of the deferred
message.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14060
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jul 31 00:12:34 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d90ccce59754bc833027c06683afac25f7a8d474">d90ccce5</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2019-07-31T02:50:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netcmd: Allow drs replicate --local to create partitions
Currently, neither the offline (--local) or online (normal replica sync)
methods allow partition creation post-join. This overrides the Python
default to not create the DB, which allows TDB + MDB to work.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14051
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7d2875bd70cf727730be8dc705bfd01eacaaaa6f">7d2875bd</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2019-07-31T02:50:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Add samba_upgradedns to the list of possible cmds
This will be used to test the replication scenario with no DNS partitions
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14051
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/35c54007e6183829d9d85a24b3bd95f469739ad3">35c54007</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2019-07-31T02:50:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/drs_no_dns: Check dbcheck and ldapcmp pass
When joining a DC without DNS partitions, make sure that the alternate
flow of creating them afterwards results in a database with everything
that is necessary.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14051
RN: Allow a DC join without DNS partitions, to add them later
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a5ec857abe99748dd478cdc988fa3399401334dc">a5ec857a</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-31T02:50:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CID 1452109: dsdb/util: do not check for NULL after deref
This is all strictly unnecessary, as ret is always != LDB_SUCCESS when
res is NULL, but we want to make peace between clang and converity.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0c001a7bf644d53cd0db4f4cc901e74d87cfcb35">0c001a7b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-07-31T04:08:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CID 1452121: dsdb/mod/partition: protect whole function with NULL check
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jul 31 04:08:48 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1a7f2a230d509df6f1f91bfea80c9b4b2c0df1bd">1a7f2a23</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-01T05:01:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Quiet CID 1452117 1452119 1452114 (STRAY_SEMICOLON)
Try to make clear what is being done here, we are trying to count the partitions so that
we can then walk them in reverse.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e5452a37425484a95f90604a3e58e8a731460793">e5452a37</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2019-08-01T05:01:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tldap: Make memcpy of no controls safe
Static analyzers sometimes complain about this case.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14029
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bff466943e01540b4d3210392e0fd5b1c882c0b9">bff46694</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2019-08-01T05:01:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tldap: Paged searches fail when they get to the end
The normal case hit the goto label, and should have just returned.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14029
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/85a7b594c56f7729bdfa194fee9299a08f6b4785">85a7b594</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2019-08-01T05:01:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/tldap: Actually check the paging return code
The test never worked correctly because the code was overlooked. It was
also the case that the connection was never authenticated, and so an
LDAP BIND call has now been added.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14029
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/464fef34d1d047d73be347cd446b74e0f5eb2370">464fef34</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2019-08-01T06:20:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/ldap: Use TLDAP to check the extended DN return
Tests commit 9f6b87d3f6cc9930d75c1f8d38ad4f5a37da34ab
To run: make test TESTS="samba3.smbtorture_s3.plain.TLDAP"
Reverting the above commit makes this test fail:
'GUID format in control (no hyphens) doesn't match output
tldap_search with extended dn (no val) failed: LDAP error 0 (TLDAP_SUCCESS),
TEST TLDAP FAILED!'
This behaviour couldn't be tested via LDB libraries because they never
deal with the underlying DN string.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14029
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Aug 1 06:20:28 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f258cfaa1d07af6ac6e996006f6e59955cfe34ce">f258cfaa</a></strong>
<div>
<span>by Michael Adam</span>
<i>at 2019-08-01T09:49:04+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs:glusterfs_fuse: build only if we have setmntent()
FreeBSD and other platforms that don't have setmntent() and friends can
not compile this module. This patch lets changes the build to only
compile this module if the setmntent() function is found.
This is the a follow-up fix to the actual fix for bug #13972.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13972
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Thu Aug 1 09:49:04 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e10b90f33bb812600886656a1124e2d434416563">e10b90f3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-01T14:21:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/smb: add new COMPRESSION and NETNAME negotiate context ids
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14055
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/21f6cece543dd791e0f4636458bfe9819823420c">21f6cece</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-01T14:21:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/smb: send SMB2_NETNAME_NEGOTIATE_CONTEXT_ID
Note: Unlike the current documentation, the utf16 string
is not null-terminated, that matches Windows Server 1903
as a client.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14055
RN: Add the target server name of SMB 3.1.1 connections
as a hint to load balancers or servers with "multi-tenancy"
support.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/10e140d25cd3cad8428e3b080ef28dd237d903d5">10e140d2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-01T14:21:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:torture: Fix the FreeBSD build
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14060
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c226dc6e8a18343031829c35552e557903593daf">c226dc6e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-01T15:39:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix use-after-free from exit_server_common()
We need to keep the smbXsrv_connection structures around until all
pending requests have had their chance to clean up behind them. If you
look at srv_send_smb(), it's exactly prepared already to just drop
anything on the floor when the transport has been declared dead:
if (!NT_STATUS_IS_OK(xconn->transport.status)) {
/*
* we're not supposed to do any io
*/
return true;
}
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14064
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Aug 1 15:39:13 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ff2f20439c403340ec886bf31f055355dfbfcdbf">ff2f2043</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-01T15:40:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/dcerpc/raw_protocol: split test_spnego_connect_request() into 2 parts
This can be a generic test that can be used for more auth_levels.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e0e68ea25514fdb05921eabec6a4cdd587a9844e">e0e68ea2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-01T15:40:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/dcerpc/raw_protocol: split test_spnego_integrity_request into 2 parts
This can be a generic test that can be used for more auth_levels.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4b88e1d997cdb39c4b4e71ea742168598fbb2dff">4b88e1d9</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-08-01T16:59:02+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/dcerpc/raw_protocol: Add more tests for DCERPC_AUTH_LEVEL_PACKET
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Aug 1 16:59:02 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/81186651eebf20e1ed7baf0116d5dbbc16d3d995">81186651</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2019-08-02T02:29:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: skip indexes on full_search
Use iterate_range kv op to skip the index section of the database when
running a full search. Quick local testing showed 18% improved throughput
on a full search with no results on a 50k database. With more results,
improvement is smaller but still noticeable.
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Aug 2 02:29:42 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0df28b3d143db93971ea7c5253a9caf4a7a9d61e">0df28b3d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-06T06:32:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script/autobuild.py: remove explicit --picky-developer"
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bed7fc5a1b5fbea7664aced72dac08846cce6ebc">bed7fc5a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-06T07:50:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: change --picky-developer into --disable-warnings-as-errors
By default we're using -Werror now if --enable-developer is
specified.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Aug 6 07:50:14 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eebcc88ddf93466a3c98c023e86de23aba9875c1">eebcc88d</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-08-06T13:40:21+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">doc: improve vfs objects parameter description
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Karolin Seeger <kseeger@samba.org>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Tue Aug 6 13:40:21 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/23d0555c0d0ff2efc62e80dde58f146de97cc27b">23d0555c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: dptr_close() can only be called from SMB1 code.
SMB_ASSERT this is the case.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f61dae7635971bcbae4d191219ccb5365984d059">f61dae76</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Move the strange OS/2 directory key == -1 close semantics to the caller.
This will allow us to change dptr_closecnum() to close outstanding fsp
handles for SMB1 later.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2ba48f76ecaab3ddcd5d030a1dab3b5a889532b6">2ba48f76</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Add dptr_fsp() to return any stored files_struct pointer.
Will allow [find/search]_next() calls to find and close any associated
fsp. This function is temporary and will eventually go away once I
modify dptr_fetch() to return an fsp.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5a038f511413fdfaa26e41ceee35c1523185b071">5a038f51</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Make dptr_close() safe to call with an fsp handle stored in dptr->dir_hnd.
SMB1 doesn't currently do this, but subsequent changes will add handle based
calls to SMB1 so dptr_close() has to be able to cleanly remove any back pointers.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a5f8769c25ec119805586c145c09f6a63603bc36">a5f8769c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change dptr_closecnum() to use dptr_close() instead of dptr_close_internal().
This will allow us to close any outstanding handles on
an SMB1 connection as later commits move us to using directory
handles instead of pathname directory opens.
This is inefficient, as it means walking the list twice,
but this will only be called with active dptrs in the
OS/2 -1 case, in the connection shutdown case the
directory handles will already have been closed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aa3a087193b23001bd7a17e30644b5cbeb0119eb">aa3a0871</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Prepare for SMB1 directory handle opens in dptr_closecnum().
Call close_file() on any SMB1 directory handle once the dptr is closed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e686e7b6b3f6d8e8ac1cd71979e59d1382c2124a">e686e7b6</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Prepare for SMB1 directory handle opens in reply_search()
Call close_file() on any SMB1 directory handle once the dptr is closed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b055f1ac7b69ede807eead360b7ffb9c65dea53c">b055f1ac</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Prepare for SMB1 directory handle opens in reply_fclose()
Call close_file() on any SMB1 directory handle once the dptr is closed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/61c239fcec1589d078678e729a19920adfe198f6">61c239fc</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Prepare for SMB1 directory handle opens in reply_findclose()
Call close_file() on any SMB1 directory handle once the dptr is closed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/264d6b408e09c2a1758466ec22adb3386f623777">264d6b40</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Prepare for SMB1 directory handle opens in call_trans2findfirst()
Call close_file() on any SMB1 directory handle once the dptr is closed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5388df783e4b60082113086ce6c94e47a841055f">5388df78</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Prepare for SMB1 directory handle opens in call_trans2findnext()
Call close_file() on any SMB1 directory handle once the dptr is closed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/043443ee33bcd8ad61ec59574aaacdde511656da">043443ee</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Convert SMB1 call_trans2findfirst() to use handle-based directory enumeration.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a130760f70960de559b845fffb1b70dc11db6f24">a130760f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Convert SMB1 reply_search() to use handle-based directory enumeration.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d485c43cc74c5550d151fe728ddc53b02ab23df8">d485c43c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Now we always use handle for directory enumeration, we can delete the fallback code.
The code inside open_dir_safely() is root safe
and can replace the deleted open_dir_with_privilege()
fallback code.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/84312fc5c289c926e189504b144bf9655491f706">84312fc5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Now we're using OpenDir_fsp() all the time, make sure we don't leak file handles.
We must always set dir_hnd->fsp, even in the fallback to
SMB_VFS_OPENDIR() case. Remember if we had to fall back
and fix the destructor to close the additional file
descriptor if we did.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/247515982f01db25b484e707621b56c836663a08">24751598</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Now we are always using fsp handle-based client searches, simplify smb_Dir_destructor().
We know we always have a dir_hnd->dir and dir_hnd->fsp.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/492b322237db42b025d2c3c16ae0e6c78b736838">492b3222</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Now we properly open file handles for directory enumerations, we don't need this code in SMB1rmdir.
The share mode exclusion will prevent deletion of open directory
enumeration handles.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/de2167668eaff6b896b4f2e255f37b8755aa3fba">de216766</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove now unused dptr_closepath().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/916afa3746aebe07a06d512db72a852df2f26b9c">916afa37</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: All directory enumeration is now via file handles - remove unneeded code in idle connections.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5a7aaa8060fdcfc2e066f1ef859634bc115699db">5a7aaa80</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove now unused dptr_activecnum().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/96e8175dc81b32ba065ad393f8413373937d41cb">96e8175d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Add dptr_fetch_fsp() for SMB1 code. We will use this to replace dptr_fetch().
Not yet used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/68e403fa587b4c6a27e6d0f2b901942a01e42ea6">68e403fa</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Replace dptr_fetch() with dptr_fetch_fsp() in reply_fclose().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a2ef44b71bffb8500dd88538b1e617497816f608">a2ef44b7</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Replace dptr_fetch() with dptr_fetch_fsp() in reply_search().
We now no longer use dptr_fetch().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e63400841e9d3372b8960b8764d45729926fb02f">e6340084</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove dptr_fetch() - replace internals with dptr_fetch_fsp().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b922f6e7045fc7906ea60cd715b156ff61d477e2">b922f6e7</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Add dptr_fetch_lanman2_fsp() - to replace dptr_fetch_lanman2()..
Not yet used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d6e709c43ea8d8ecbe43a6a499fa5e3ed956bce6">d6e709c4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Convert call_trans2findnext() to use dptr_fetch_lanman2_fsp().
dptr_fetch_lanman2() is now no longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b4431ad3051aa22347455fd3bcb181d17026d501">b4431ad3</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove dptr_fetch_lanman2() - unused.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/37e1dd5af3b30f1c7a76cced215b440bedc1ba4b">37e1dd5a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Replace dptr_fsp() with dptr_fetch_lanman2_fsp() in reply_findclose().
Now we have no users of dptr_fsp() left.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f5eebfc725136d1fdf2d6c9f66db59f24338f9c2">f5eebfc7</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove dptr_fsp(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/24722da0b1f2602c111026b7e6af82360d60a637">24722da0</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove dptr_close() from reply_search().
Now we're handle-based close_file() already does
what is needed to shut down directory enumeration.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/63e1220a2bb984a89b2f6e20c37f16d15f1a8814">63e1220a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove dptr_close() from reply_fclose().
Now we're handle-based close_file() already does
what is needed to shut down directory enumeration.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/269fbc9164615d0e6034b873a76552cb138b24ea">269fbc91</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove dptr_close() from call_trans2findfirst().
Now we're handle-based close_file() already does
what is needed to shut down directory enumeration.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/779dd3f1e6bc462057a8f367d6c7cbb5cd75d4ba">779dd3f1</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove dptr_close() from call_trans2findnext().
Now we're handle-based close_file() already does
what is needed to shut down directory enumeration.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a8ca5dc467c40619722b165a22fdf13b9b474c86">a8ca5dc4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove dptr_close() from reply_findclose().
Now we're handle-based close_file() already does
what is needed to shut down directory enumeration.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/196fe53ede8743ab02a2a29d574cfd27632ceb3f">196fe53e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove dptr_close() from dptr_closecnum().
Now we're handle-based close_file() already does
what is needed to shut down directory enumeration.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/043c232144830d4da12cae877994caa16ec91c6d">043c2321</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove dptr_close().
No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d84c048ea5350418cff87d5bf12f2f583d592994">d84c048e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-06T14:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove call to dptr_closecnum() on connection shutdown.
Now all client enumerations use fsp file handles we will
aleady close them in file_close_conn() above.
The only user of dptr_closecnum() is for the strange old OS/2
semantics, so I can't get rid of it until SMB1 is removed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6d0924d8ea0391c5b6414a79d25e15ddfd7dd448">6d0924d8</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-06T14:23:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: remove redundant smb_dname arg from dptr_create()
Now that dptr_create() is handle based, we can simply used the fsp name.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7d72cf02e799502bf7df93183d325a3d50433569">7d72cf02</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-06T14:23:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: simplify dptr_CloseDir()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3e0cafc2b545f16b84f2f46a270e62a541fc4e49">3e0cafc2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-06T14:23:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: inline dptr_close_internal()
There's now only one caller left.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/37bb6229ad48b7a443eefa19a1845ce92a5bf546">37bb6229</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-06T14:23:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: fix a comment in fd_close()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f5388f97792ac2d7962950dad91aaf8ad49bceaa">f5388f97</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-06T14:23:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: fix compilation on systems with glibc robust mutexes
On older systems like SLES 11 without POSIX robust mutexes, but with glib robust
mutexes where all the functions are available but have a "_np" suffix,
compilation fails in:
ctdb/tests/src/test_mutex_raw.c.239.o: In function `worker':
/root/samba-4.10.6/bin/default/../../ctdb/tests/src/test_mutex_raw.c:129: undefined reference to `pthread_mutex_consistent'
ctdb/tests/src/test_mutex_raw.c.239.o: In function `main':
/root/samba-4.10.6/bin/default/../../ctdb/tests/src/test_mutex_raw.c:285: undefined reference to `pthread_mutex_consistent'
/root/samba-4.10.6/bin/default/../../ctdb/tests/src/test_mutex_raw.c:332: undefined reference to `pthread_mutexattr_setrobust'
/root/samba-4.10.6/bin/default/../../ctdb/tests/src/test_mutex_raw.c:363: undefined reference to `pthread_mutex_consistent'
collect2: ld returned 1 exit status
This could be fixed by using libreplace system/threads.h instead of pthreads.h
directly, but as there has been a desire to keep test_mutex_raw.c standalone and
compilable without other external depenencies then libc and libpthread, make the
tool developer build only. This should get the average user over the cliff.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14038
RN: Fix compiling ctdb on older systems lacking POSIX robust mutexes
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ea17bd5539eb0be7a446b99c8b6baa4aa1ab273f">ea17bd55</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-06T14:23:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Incomplete conversion of former parametric options
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14069
RN: Incomplete conversion of former parametric options
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5d4aa6e867044e6b58b45acde32ac35e1d0a7765">5d4aa6e8</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-06T15:40:18+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Fix sync dosmode fallback in async dosmode codepath
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14070
RN: Fix sync dosmode fallback in async dosmode codepath
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Aug 6 15:40:18 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b136f153b83d80a91ec9d5350fdf08412d881964">b136f153</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-08-06T17:00:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_dn: free dn components on explode failure
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d6a82edd19b82d99401a27dbc6fe10121142e431">d6a82edd</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-08-06T17:00:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/messaging/py: don't DECREF borrowed references
This made Message.deregister() a decref machine, with talloc crashes
and segfaults available thus:
from samba import messaging
m = messaging.Messaging()
for i in range(20):
m.deregister(m)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fe9b12b274028a1310ac6c59cc56ac36bb40ef5e">fe9b12b2</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-08-06T18:17:11+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl/ndr/python: avoid memory errors in getsetters
This:
$ python3 -c'from samba.dcerpc import lsa; x = lsa.EnumAccounts(); x.in_handle'
should not raise a MemoryError, which is very unfriendly given that
'x.in_handle' is just named, not called, as far as the user is
concerned. Returning None is the proper thing.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Tue Aug 6 18:17:11 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/885ba572efaac6c20388b8e119315c837e8f5236">885ba572</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Rename tdb_oob() to tdb_notrans_oob()
tdb_oob() will become a public function encapsulating the pointer
dereferences.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5a388453e0cb038fa3ed5fb46f972470f7793566">5a388453</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Introduce tdb_oob()
Initially just encapsulate the pointer dereferences
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/897bffa8166f643eb9063a848bb0c02455663317">897bffa8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Speed up tdb_oob()
This is common between both implementations of tdb_oob(). It's
faster if we don't have to dereference function pointers.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f5735e2c666a5a494131c1d25f7ba5c7fbeae923">f5735e2c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Inline the common part of tdb_oob
When you set
in tdbtorture.c to make it more similar to locking.tdb use,
bin/tdbtorture -m -n 1 -l 100000 -s
becomes twice as fast. This is a pretty extreme case, but all other
tests that I did improve significantly as well.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2ef382fa764da3dae9f251925c2d9057bb7bb260">2ef382fa</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Avoid a separate "request_time" variable in open_file_ntcreate
We have "smb_request->request_time" that is already set up by
init_smb_request().
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e5ad2d372027fea64d62deaffe6baf95df36f58a">e5ad2d37</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use "req->request_time" in schedule_defer_open()
Both callers passed that in.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d5b5ef3e2fa56a67fec4265384508c74e41f1ca5">d5b5ef3e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use "req->request_time" in defer_open()
Both callers passed that in.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2d05524e846cf75b1a5482855b0afc9092040b17">2d05524e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use "req->request_time" in setup_kernel_oplock_poll_open()
Both callers passed that in.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/af97381b11572befe35dc0cb32ccce59a3f4beaa">af97381b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use "req->request_time" in schedule_async_open()
The one caller passed that in.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bb81b9a75ad66ad8a78f146d217e74c3bf7cc7f8">bb81b9a7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use "req->request_time" in schedule_async_open()
All callers passed that in
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3ca52f11dcc27de0cbd67c8f030d2984869c3085">3ca52f11</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Pass in "struct smb_request" to request_timed_out()
It seems more natural to pass in a request to a routine called
request_timed_out(), and it's a few bytes less .text
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a8a1ca3f83dce6d725392989cbc97271cbf52f4a">a8a1ca3f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix the build with clang
clang correctly complains that "close_fsp" is used uninitialized if
"get_posix_fsp" fails and we end up in "goto out;".
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d8ae28115200196546ace109e338b55a7ae72a93">d8ae2811</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Fix the FreeBSD build
My FreeBSD install does not have __compar_fn_t. libreplace has the
QSORT_CAST for systems that do.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d103af280afd29d633b1958620e7b3beddfd6087">d103af28</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: Fix the FreeBSD nfs4acl build
I get error messages telling SMB4ACL_T isn't defined in the
prototype. Take the easy way to just define that anonymously.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a8e034794beaed00205ba198cbb77c5705767eb1">a8e03479</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Fix the clang build
clang complains that lm_resp and nt_resp is used uninitialized. This
is true for the "goto done;" in line 2644. This directly calls
log_authentication without having initialized those two blobs.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9bae499da78b7978a8145bd6c3499d047b1afe68">9bae499d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d2d4e03b962d22875d6a3b170880c588fdc2688b">d2d4e03b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Correctly detect rpc/xdr.h on FreeBSD
FreeBSD needs rpc/types.h included before rpc/xdr.h
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/42e72f1a30db9090d53669ca68cc71bbe784758d">42e72f1a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: Fix the nfs4acl build on FreeBSD
FreeBSD needs rpc/types.h before rpc/xdr.h
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/04dcae23ab47a31a7348f0246cc2cf434d4e5fc6">04dcae23</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Only check rpc/xdr.h in tirpc if required
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e049ef3e787d8e7939b70d67a167766e89a04083">e049ef3e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove a duplicate prototype for set_blocking()
This is now in lib/util/blocking.h
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/df1caf29fbb745927f94a26598ee8e01ba8d9807">df1caf29</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture3: Don't duplicate set_blocking()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4c6f12c3239c926a34e6b93fa6d0ec167a62c63d">4c6f12c3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove a false comment
Looking at the code we do respect the kernel_flock failure.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2181221d6f06b3285a57bcf57ef263770ef0ccb0">2181221d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix a signed/unsigned comparison
In the 2nd for-loop we need a signed int as we are comparing to >=0.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aedfee8f49b643ae7d1ee4f0bc53f2a835652f30">aedfee8f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix a signed/unsigned warning
For whatever reason, "st_size" in "struct stat" is an off_t, which is a
signed integer. Negative sizes don't really make sense, so this cast
should be safe.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/88768fdecdf4aea12a8a0edfdbe22345ff05be20">88768fde</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use timeval_str_buf() in defer_open()
Also make this a hires timestamp for better debugging.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/303c4829e1c28a889293aad312ea50d380fbd043">303c4829</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Enhance debugging in push_deferred_open_message_smb()
Real timestamps are easier to read
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a7d4d5effa5e3e6c2e09e16ad1ce303e31b61544">a7d4d5ef</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1d9970735ced7adae24f4926a4eeed902d132426">1d997073</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/41ab2b8ec5d398ef6187562c7620c359837f3899">41ab2b8e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Pass share_access/access_mask explicitly to set_share_mode()
Makes the interface more obvious to me. Also, I want to remove
fsp->share_access, which is not really used anywhere after the fsp has
been fully established.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/71c6da46eee4acc245bd326865f84336f457f538">71c6da46</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Pass share_access/access_mask explicitly to grant_fsp_oplock_type()
Why? While restructuring open_file_ntcreate() I found the data flow for
these values confusing: grant_fsp_oplock_type() depends on
fsp->access_mask, which changes its value inside
open_file_ntcreate(). I find the data flow easier to follow if it
happens in explicit variables.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/81731c91414fdf32b150e6be120741dc3a3fdde3">81731c91</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Avoid "fsp->share_access" in vfs_gpfs_kernel_flock()
This was in vfs_gpfs.c from day one, no idea why both "share_mode" and
"fsp->share_access" were used as if they were two different things.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/13921645c4856ddc325a0f8c8a64d0bbecab119d">13921645</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove "share_access" from files_struct
Nobody used this (except vfs_gpfs, which did not need it really). If
you *really* need this, you can always look in locking.tdb, but this
should never happen in any hot code path, as no runtime decisions are
made on the share access after the open is done.
Bump VFS interface number to 42.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c56be509f1f7957057243047470f7bbf26186b2c">c56be509</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove "share_access" from dup_file_fsp()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ef0cf081603b4f23c7fcdbde1ac6be7b7fd58a48">ef0cf081</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove "share_access" from fcb_or_dos_open()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e94ebc705542ffca536d15e28fc99e023f4748bc">e94ebc70</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Slightly optimize reply_open_and_X()
Well, this is just a drive-by patch: We don't use "mtime" if we
exit early. So it's not really a worthwhile optimization, to me
it's more a code clarity thing.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3851062916cbee2114f6aa5154cdc89425724d87">38510629</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Move fsp_client_guid() to locking/
Yes, this adds another peek from locking/ back into smbd/proto.h, but
locking/locking.c does the same already.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e4d5c53e8083406552f361d2df27528d1c2ea061">e4d5c53e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Slightly simplify set_share_mode()
The fsp carries all required information also for leases. There's no
need to pass that as additional parameters
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e28c2ee903855627bc71924a6449267725a7f75d">e28c2ee9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Make remove_oplock_under_lock static
We have support for nested get_share_mode_lock calls, so we can avoid
this additional function.
It's one more talloc/free per close, but I hope this can't be
measurable. Our open/close path is pretty expensive anyway.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2d4e2ea24947c4d2eb647c98b36d9cebb54d434d">2d4e2ea2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Inline remove_oplock_under_lock() into its only caller
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6e7d28c8e03a832bd0704e7f72b25e448746c35a">6e7d28c8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Factor out remove_lease_if_stale()
remove_lease_if_stale() does not have the check
if (e == e2) {
/* Not ourselves. */
continue;
}
that remove_share_mode_lease() had. However, remove_share_mode_lease()
has already set e->op_type=NO_OPLOCK, so that the
if (e->op_type != LEASE_OPLOCK) {
continue;
}
statement has the same effect.
Why? The next commit will need it for proper error path cleanup.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fbc367595418dee16333f3334381a226d37d4e25">fbc36759</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Clean up leases.tdb if set_share_mode() fails
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/67c5034531dca175a70772eedd1489333d511fb4">67c50345</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove "deferred_open_record->id"
Nobody used this
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/61765c7e15b52df9c18541cf8604887f2d558bde">61765c7e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove "id" from deferred_open_record_create()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fc09be5b51fa99bacf6ad761217c9d422a8753d1">fc09be5b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove "deferred_open_record->delayed_for_oplocks"
Nobody used this
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/718c4e27cd502ebb74da41c9911e8d752ac45922">718c4e27</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove "delayed_for_oplocks" from deferred_open_record_create()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5e05686e392107b0e75ca9db6a735eef90245665">5e05686e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T21:49:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove deferred_open_record_create()
This hides a talloc off the NULL context: The caller needs to make sure
this is put on a real talloc context later. Make that more
obvious. Also, it passes down a boolean flag, making its purpose a bit
opaque to the caller sites.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aab17124785b6e4c004368b69bee28fb6cad55c3">aab17124</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-06T23:06:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Assert that INTERNAL_OPEN_ONLY never gets real oplocks
Slightly simplify assumptions in the code
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Aug 6 23:06:41 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dd5f8732d8b2ac6cd86e5d7dc8a9498d2b951a43">dd5f8732</a></strong>
<div>
<span>by Michael Hanselmann</span>
<i>at 2019-08-07T06:07:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add fuzzing support to build system
LibFuzzer, Honggfuzz and other programs implement simple interfaces for
fuzzing appropriately prepared code. Samba contains quite a lot of
parsing code, often a good target for fuzzing.
With this change the build system is amended to support building fuzzing
binaries (added in later changes).
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/404278d9472c28fedc200d385667a0d2cc1c992d">404278d9</a></strong>
<div>
<span>by Michael Hanselmann</span>
<i>at 2019-08-07T06:07:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add fuzzing binary for tiniparser
The "tiniparser_load" function is made into a wrapper for the newly
added "tiniparser_load_stream" function which accepts a FILE pointer.
This way no actual files have to be opened for fuzzing (memfd_create(2)
isn't readily available on all systems yet).
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/39e2f6d59fa2e839c8ef40934790b34dbdfc8f29">39e2f6d5</a></strong>
<div>
<span>by Michael Hanselmann</span>
<i>at 2019-08-07T06:07:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add fuzzing binary for oLschema2ldif
Use the oLschema2ldif library functions introduced in commit
0c7c44a284a26790081c000f5b8f4ed32f9f21d7 to implement a fuzzing utility.
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/323f852147524b950bab4628a2824aa2273cb577">323f8521</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-07T06:07:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: add torture_assert_errno_equal_goto()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/107020793c7ea44e5e776a1401bbf4f8ccb9bd85">10702079</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-07T06:07:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">charset: add support for Unicode normalisation with libicu
This adds a direct conversion hook using libicu to perform NFC <-> NFD
conversion on UTF8 strings. The defined charset strings are "UTF8-NFC" and
"UTF8-NFD", to convert from one to the other the caller calls smb_iconv_open()
with the desired source and target charsets, eg
smb_iconv_open("UTF8-NFD", "UTF8-NFC");
for converting from NFC to NFD.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2a90202052558c945e02675d1331e65aeb15f9fa">2a902020</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-07T07:25:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">charset: add tests for Unicode NFC <-> NFD conversion
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Aug 7 07:25:39 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/314043828b3e3d70600f0f365caad37dbf171d1a">31404382</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-07T12:54:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:lib/http: add http_[dis]connect_send and recv
Not used for now, that comes later.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3ffd74e915f579bcf759f17c32aedb0c5a9f152b">3ffd74e9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-07T12:54:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:lib/http: move struct http_send_request_state to the implementation
This is only used by the implemementation of http_send_request_send/recv, no
need to have this in the header file.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ab389bca9c6d0e1723b471eb1a2e8d38648efbc4">ab389bca</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-07T12:54:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:lib/http: move struct http_read_response_state to the implementation
This is only used by the implemementation of http_send_request_send/recv, no
need to have this in the header file.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/94fe9afae42ee09974b8c5ab802868e703318d95">94fe9afa</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-07T12:54:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:lib/http: remove stream and send_queue from state
They're not used, so remove them.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/53007b77116c510e296995c8a0a8b836b88d7770">53007b77</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-07T12:54:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:librpc/rpc: use http_connect_send/recv in ncacn_http
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5ae515245c235427c5d07f473cf53015701ce4e1">5ae51524</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-07T12:54:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:lib/http: use http_conn in http_send_request_send() and http_read_response_send()
Works, tested with
$ bin/smbtorture -W RIVERSIDE --realm=RIVERSIDE.SITE -s /dev/null \
-U Administrator%Passw0rd \
ncacn_http:10.10.11.164[HttpProxy=10.10.11.164:593,HttpUseTls=false,HttpAuthOption=basic,HttpConnectOption=UseHttpProxy] \
rpc.epmapper.epmapper.Lookup_simple
I get an ACCESS_DENIED error, but I get it over HTTP. :)
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a0065c57601a16011dc1a90688a724ae8acb3377">a0065c57</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-07T12:54:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:lib/http: add support for http POST
Even though GET would work as well, only adding POST, as that's the only method
that's going to be exersized in code and tests (RPC mdssvc elasticsearch
backend).
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fc0371b932286d4f50f8650b1e7a7132f83e565c">fc0371b9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-07T12:54:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:lib/http: move to the toplevel
This is going to be used from the s3 RPC server soon...
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7189eb44d7f8a6514bb48645da89d7f9b148d599">7189eb44</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-08-07T12:54:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:librpc/rpc: Add roh_connect_channel_send/recv
Generic function to connect a ROH channel. The use comes later to avoid
duplicated code.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/959b77988d02731c032b5fcc91f7a62fd9b96340">959b7798</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-08-07T14:12:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:librpc/rpc: Use generic roh_connect_channel_send/recv
The HTTP connection code is common to in and out channels.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Aug 7 14:12:40 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2e3f644f0aa78a255df41325ea6f3bee7f733208">2e3f644f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-07T16:40:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Make unlink return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e8e1b00aef923c701b122cdcc6de16a05b9915ca">e8e1b00a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-07T16:40:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Make chmod return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/68330458e6e3ccc0e5a62d3fa5b99a66d02771ac">68330458</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-07T16:40:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Make chown return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/15761609ee9bf5b1276992103f3b4ebbda9c5e83">15761609</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-07T16:40:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Make ntimes return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2e43661a1b907209a3ae165f1ec2b4bcb1c93ddf">2e43661a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-07T16:40:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Make mknod return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9d35f74766fb0feee7cdbc24f5ca0364ef4b62b9">9d35f747</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-07T16:40:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Make mkdir return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d81570e5fb201181134e2f601a53f49c035bdfab">d81570e5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-07T16:40:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Make rmdir return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5ed5d5445f3bc8c9a864af6f0731ba389d53a511">5ed5d544</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-07T16:40:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Make chflags return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fc405e919d606a3cdb59d557cadeeb953534c1b5">fc405e91</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-07T16:40:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Make removexattr return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/551e3590f98393879ab4c97e7fa734602d4e9f7c">551e3590</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-07T17:59:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Make setxattr return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Aug 7 17:59:25 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2c653515f39e341d7b104cef75f8109410bc90c7">2c653515</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-07T23:45:49+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove access check on SHARING_VIOLATION
This piece of code predates our user-space access checks, which we
nowadays always do in open_file()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/939a1097504540779343dd53fad6cdec581b0e2c">939a1097</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-07T23:45:49+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Avoid exit_server() in setup_kernel_oplock_poll_open()
Failure to postpone a request is not really fatal: We just don't retry
as wanted but return an error to the client that might have resolved
itself after a few seconds. From my point of view such a spurious and
rare error, which is highly unlikely anyway does not justify to kill
that client's connection.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/832b9eb6df520b3ba9f60e8559c2bb9bef2b4ad4">832b9eb6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-07T23:45:49+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Make setup_kernel_oplock_poll_open() more general
This is a generic "open retry without locking.tdb waiter" loop: Take
the specific timeouts as parameters.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/50a3d08673ad5a62ff5769af429e2cc1730a1659">50a3d086</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-07T23:45:49+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Make setup_poll_open() return bool
This is for callers who don't want to call open_was_deferred()
afterwards
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1bc7d18b5f97d9b7e299df2107321601178aed83">1bc7d18b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-07T23:45:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Do not exceed the req's max timeout in setup_poll_open()
This will become important in the next commits when the SMB1 sharing
violation delay will use this. We want to be able to reduce the
timeout to less than 200msec, see the next commits.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/305ea37c81c2eeafb0ae259d4bd319af183a4611">305ea37c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-07T23:45:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Get "req->request_time" early in create_file_default()
This is necessary for the following case:
We want to delete a file with an open stream that is not open with
FILE_SHARE_DELETE. In SMB1, we need to defer the sharing violation
reply (we don't do that right now, test to follow). However, when we
move that sharing violation delay to where it belongs, into the outer
layers, only very deep in the nested open_streams_for_delete smb1
sharing violation delay handling call we will hit the sharing
violation in the 1-second retry case. However, that
open_streams_for_delete itself is INTERNAL_OPEN_ONLY and thus not
deferred itself. This means that it will not overwrite
req->request_time at all.
Exec summary: We only have one request_time now, set it properly as
early as possible.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c7e110e51afea9a36a060bff62506c53e86c8aab">c7e110e5</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-07T23:45:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Add defer_sharing_violation_smb1
This is close to what Windows SMB1 does: Instead of waiting for the
share entry causing the SHARING_VIOLATION to disappear, retry every
200msec up to one second. Windows does it a little differently: Retry
up to 5 times. But up to one second should be close enough.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4c08043ee54350c7c66a963882d4e14c24472986">4c08043e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-07T23:45:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Move handling the 1sec sharing_violation delay into smb1 code
Simplify the flow in open_file_ntcreate, streamline it for SMB2
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/897c36f2cb7de561394ab15e8134fb6e5b91ae63">897c36f2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-08T01:05:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: SMB1 unlink needs delay for a stream's SHARING_VIOLATION
Survives against W2k12R2
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Aug 8 01:05:38 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a16477e6e62b5525f6d8ddc297da2ec1ac176acc">a16477e6</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-08T06:44:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">registry: Free memory at the end of each loop run to prevent mem leak
Found during torture test runs with enable address-sanitizer.
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Aug 8 06:44:12 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d167fb40899c8b2f9919455f40e95e00adc8e1e9">d167fb40</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-08T10:08:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Fix mem allocation in torture test to satisfy sanitizer
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/235288acaedf39ea386121347343d56df3d1d858">235288ac</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-08T10:08:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">util: Free memory in genrand torture test to satisfy sanitizer
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bb8cc5956f7bac9afedcba2744d691b2d8485b62">bb8cc595</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-08T10:08:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndr: Free memory in torture test to satisfy sanitizer
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/84e519f36559f783af7e1143175ae6b316bd1e75">84e519f3</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-08T10:08:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">util: Free memory in charset torture test to satisfy sanitizer
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f9a32767b690532ed897730e8179dcc84473d148">f9a32767</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-08T10:08:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Free memory in torture test to satisfy sanitizer
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3bf915846f77d7df451728d115eaa25613532063">3bf91584</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-08T11:33:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tfork: Free memory in torture test to satisfy sanitizer
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Aug 8 11:33:32 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9e0b6f667f055ab74389759471c0b7181aaf4973">9e0b6f66</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: factor out rpc_mdssvc_sources
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/17f29fa86772a3fe9c03ecee6813c377d85dde6c">17f29fa8</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: README.Coding fixes, long lines, modernize debug macros
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f80f8c5f99f6b5949d14ee62261a7dd448e9b0fe">f80f8c5f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: move debug macro to header file
This is going to be used from other parts of the code soon.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1ef96e09071458322845b4323fa59cf4e7475783">1ef96e09</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-mdssvc: factor out Tracker backend logic
This moves all Tracker backend logic into a modularized component.
This should not result in any change in behaviour, it just paves the way
for adding additional backends. Currently the only available backend is
Gnome Tracker.
slq_destroy_send/recv is not needed anymore as the problem is solved now by
correctly checking if an async Tracker request was cancelled and we got
G_IO_ERROR_CANCELLED in tracker_con_cb() or tracker_query_cb() and avoid using
user_data in that the case.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/66b8d86d71551ab8c615428211294ca110608645">66b8d86d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: pass down sharename and SNUM
Not used for now, will be needed in the upcoming Elasticsearch backend.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1b897df4f7489c6ac7663ca4830dc4c129dd2457">1b897df4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: new option "spotlight backend"
Currently there's only the tracker backend, but subsequent commits will add
other backends.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b5731a94bbc95fa001059d488a2c16a988127619">b5731a94</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: add Unicode normalisation
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f58026b30b2bf9d60222d39947d07ee858ee5756">f58026b3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: mds_dalloc_dump() -> dalloc_dump()
Move mds_dalloc_dump() to dalloc and rename it to dalloc_dump().
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2d98fb57e05ebe16c3a3d8256281830435320607">2d98fb57</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: move some code to a subsystem
We need this in a later patchset when adding a mdssvc client library and for
unit tests.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e5a4114bb563b1ebf8ce7cad2a335bf24dbbdd32">e5a4114b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: log inode number in ino_path_map_destr_cb()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c742ab7a4c78db4101499d15ada1a6635d5cc35b">c742ab7a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: add noindex backend
Add a new default backend that, while allowing mdsvc RPC and search queries from
clients, always returns no results.
Shares using this backend will behave the same way as shares on a macOS SMB
server where indexing is disabled.
This change will later also allow us to compile the Spotlight RPC service by
default which is a big step in the direction of adding tests to CI.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0b1d9d40c249ca7f893cbcc54587ae8fc93f15ee">0b1d9d40</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: supposed status field is in fact a fragment indicator
Spotted this in mdssvc response that containied many results for a search
request: if the mdssvc response blob is larger then ~32k, the server fragments
the response in 32k fragments and sets the "fragment" field to 1.
Note that mdssvc implemenets result set "fragmentation" at the result set layer,
not at the marshalled response buffer layer. Therefor mdssvc always sets this
field to 0.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9e706ee5737bffd6f0a699ce68a75bbd0f7fd7dd">9e706ee5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">unittest: workaround dependency problem in test_lib_util_modules
waf somehow screws the dependencies and the module ends up with a bunch of
missing RPC related symbols once an RPC service has special dependencies like
the mdssvc RPC service.
$ bin/test_lib_util_modules
test: test_samba_module_probe
success: test_samba_module_probe
test: test_samba_module_probe_dummy
Error loading module '/home/samba/src/bin/modules/rpc/test_dummy_module.so':
/home/samba/src/bin/modules/rpc/test_dummy_module.so: undefined symbol:
rpc_service_mode
failure: test_samba_module_probe_dummy [
NT_STATUS_IS_OK(status)
../../testsuite/unittests/test_lib_util_modules.c:39: error: Failure!
]
test: test_samba_module_probe_slash
success: test_samba_module_probe_slash
This is currently not noticed as mdssvc is not enabled in selftest, but that is
going to change with a subsequent commit.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/25c5012c53f4d8efbe04ee8d3c8af256fec592a7">25c5012c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: avoid strncpy when marshalling strings
Avoids failure when at O3 level:
[2082/4232] Compiling source3/rpc_server/mdssvc/marshalling.c
==> /builds/samba-team/devel/samba/samba-o3.stderr <==
In file included from /usr/include/string.h:494,
from /usr/include/bsd/string.h:30,
from ../../lib/tevent/../replace/replace.h:164,
from ../../source3/include/includes.h:23,
from ../../source3/rpc_server/mdssvc/marshalling.c:21:
In function ‘strncpy’,
inlined from ‘sl_pack_string’ at ../../source3/rpc_server/mdssvc/marshalling.c:493:2,
inlined from ‘sl_pack_loop’ at ../../source3/rpc_server/mdssvc/marshalling.c:607:13:
/usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ output
truncated before terminating nul copying as many bytes from a string as its
length [-Werror=stringop-truncation]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../source3/rpc_server/mdssvc/marshalling.c: In function ‘sl_pack_loop’:
../../source3/rpc_server/mdssvc/marshalling.c:458:8: note: length computed here
458 | len = strlen(s);
| ^~~~~~~~~
cc1: all warnings being treated as errors
Marshalled strings are not 0 terminated.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/12ef7b38437f4a4211fa3dce3e3c1e76a3d3df78">12ef7b38</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:wscript: enable Spotlight by default
Now that we have a no-op backend that is always available, we can compile mdssvc
by default.
The new behaviour is:
option not used Default: build mdsvc with available backends
from autodetection
--disable-spotlight Do not build mdssvc
--enable-spotlight Build mdssvc and require a real backend
(currently Tracker, in the future also Elasticsearch)
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9d6794df728d772e6bae611f782d70ed97e5c5aa">9d6794df</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: add RPC_NDR_MDSSVC
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c282d76d556ae3744cae3f113afeda746b93949f">c282d76d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: start of a mdssvc packet (un)marshalling testsuite
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ed37f2d3c478da34dd9b80171ec603be3c23e37b">ed37f2d3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: marshalling: add a newline to a DEBUG message
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d67c98184a176805c0406ea4d6d56bcde78bb26d">d67c9818</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: marshalling: fix unpacking empty filemeta structure
This is how a correct dump of an empty sl_filemeta_t container should look like:
DALLOC_CTX(#1): {
sl_array_t(#3): {
uint64_t: 0x0023
CNIDs: unkn1: 0x0, unkn2: 0x0
DALLOC_CTX(#0): {
}
sl_filemeta_t(#0): {
}
}
}
This is basically the response from macOS mdssvc for a query that yields no
results: sl_filemeta_t is empty, the CNIDs array as well.
Looking at the raw packet data, the empty sl_filemeta_t container as a size of 8
bytes which fails the following check in sl_unpack_cpx():
case SQ_CPX_TYPE_FILEMETA:
...
if (tag.size < 16) {
*boom*
}
Only tag.size=0 is invalid, tag.size=8 denotes an empty container and tag.size>=16
denotes a sl_filemeta_t container with actual content must be unpacked by
calling sl_unpack(). Note that size is always a muliple of 8.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/29ef0306241da38356ffa1ee927e1b343564426e">29ef0306</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: marshalling: fix unpacking empty CNID structure
Pass the correct tag member tag.size to sl_unpack_CNID(), not
tag.length. tag.size is the size actually used in a buffer of size tag.length.
Cf other users of tag.size that already do this correctly, this was only wrong
in this place.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b34fd5b9978904ef0b316ba11564691fdac5316c">b34fd5b9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: fix unmarshalling of empty CNID array
len=0 is invalid, len=8 is an empty array, len>8 is an array with members, so
for the len=8 case we must add the empty cnid array.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4162ba78f8146ad9b39d0749a36fab674197c78e">4162ba78</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:torture: add torture_assert_u32_[not_]equal[_goto] macros
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2cb978b6498c42947377a50fa8a5748f596d9114">2cb978b6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpcclient: domain_sid is only needed for SAMR
This allows using rpcclient commands with servers that don't implement LSA
QueryInfoPolicy.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b45a09f0e1ada1b5fa4a16fb652871f9ae973e2e">b45a09f0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpcclient: add some simple commands for Spotlight RPC
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/017af5d583175ff9f15c64fa7cc631eb4512367b">017af5d5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: beginning of a mdssvc RPC service test-suite
Yikes! Most tests fail atm.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5750f38ca7834254268a93193d72184d03990c1b">5750f38c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: fix error handling of mdssvc RPC requests
It seems for certain error cases macOS just sends an empty response
blob. So if our mdssvc request processing fails, we should just return an empty
response blob, but not fail the mdssvc request at the DCERPC layer.
Example, passing "xxx" as sharename which does not exist at the server:
$ bin/rpcclient -U slow%pass macmini -c "fetch_attributes xxx /foo/bar 123" -d 10
....
Got pdu len 56, data_len 32
rpc_api_pipe: got frag len of 56 at offset 0: NT_STATUS_OK
rpc_api_pipe: host macmini returned 32 bytes.
mdssvc_cmd: struct mdssvc_cmd
out: struct mdssvc_cmd
fragment : *
fragment : 0x00000000 (0)
response_blob : *
response_blob: struct mdssvc_blob
length : 0x00000000 (0)
size : 0x00010000 (65536)
spotlight_blob : *
spotlight_blob: ARRAY(0)
unkn9 : *
unkn9 : 0x00000000 (0)
...
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a3cb4fca864b6e872f453d60b5e58591da3624b1">a3cb4fca</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: macOS returns UINT64_MAX, not 0 for closeQueryForContext mdscmd
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c4b2dc95d5dfb4e875ea58ff6568b89dacf8b916">c4b2dc95</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: macOS returns the client values in the open command
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fef3a4c75f9cad1a81201257f0208b241a93f6c9">fef3a4c7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: initialize the returned share_path with the empty string
macOS returns the empty path for an unknown share. This paves the way for that
change. Currently we still fail the RPC request if the share is not known with
DCERPC_FAULT_CANT_PERFORM, but this is wrong and is going to be changed in the
next commit.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/940c3b31dd1fd68c9d7c9f4e9989d725dc77af4a">940c3b31</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvv: don't fail the RPC request if the share name is unknown
Taken from macOS. We have to return an empty share_path and an empty policy
handle, but not fail the RPC request.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/68a9d1205e54d2f447baad5481ff20dfb184dfe6">68a9d120</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: update a few debug macros to modern style
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/520175e2275abfabfdb5a62e192c4936a6c74d35">520175e2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: use an early return if spotlight is not enabled.
No change in behaviour, best viewed with git show -w.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/63366996879fab5b1729de6d6224ca167bdb05b0">63366996</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: the open command must work on shares with Spotlight disabled
Move the implementation of this setting down to the actual search query
processing. macOS has no notion of "spotlight = false" at the DCERPC layer and
the open request will always succeed even on all shares.
When later the client issues search requests on such shares, we ensure we use
the noindex backend.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a5e705504bf5a9cade2e57a18b068f654fa27a32">a5e70550</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: failing the RPC request if the mdssvc policy handle is not found
Turns out macOS mdssvc doesn't fail the RPC request if the policy handle is all
zero. Also, if it fails with a non-all-zero handle, it returns a different RPC
error, namely DCERPC_NCA_S_PROTO_ERROR, not DCERPC_FAULT_CONTEXT_MISMATCH (or
rather their mapped NT_STATUS codes).
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b2bf13ecf7b5406665f27487cb892e4f15fb28c4">b2bf13ec</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T20:24:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: close mdssvc rpc command must return in handle
Checked against macOS mdssvc.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/64f182412a5b7bdb1f8eccffaee296e7c8554a95">64f18241</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-08T21:43:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: fix slrpc_fetch_attributes() when CNID is not known
Samba currenlty fails the whole RPC request, macOS returns returns a nil entry
for the requested CNID:
DALLOC_CTX(#1): {
sl_array_t(#3): {
uint64_t: 0x0000
CNIDs: unkn1: 0xfec, unkn2: 0x6b000020
DALLOC_CTX(#1): {
uint64_t: 0xe4bbf314c03b1e
}
sl_filemeta_t(#1): {
sl_array_t(#2): {
nil
nil
}
}
}
}
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Aug 8 21:43:14 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/76bf8a1ac438056691fef667bf214f9fe7bafe14">76bf8a1a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-09T07:34:04+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">mdssvc: Fix the clang build
clang complains about "%lu" not to match size_t on 32-bit FreeBSD
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Aug 9 07:34:05 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9f457799a92c34bf8c881142b308a37648bea943">9f457799</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-09T16:48:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots: Make unlink return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a5af9ac8288af1e8cd3ca080eb966d0b9ff34dc2">a5af9ac8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-09T16:48:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots: Make chmod return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d1d3d8f37021bc18d30c8c97f99f1e0d28fdd646">d1d3d8f3</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-09T16:48:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots: Make chown return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eac2ca755f5d09483465732e51ec5b51072628b2">eac2ca75</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-09T16:48:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots: Make ntimes return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5b1f545589e0027e53d56058cbaaaa8c97eaf35d">5b1f5455</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-09T16:48:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots: Make mknod return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9c2c941492a363a96482fe17cfafff1494586b31">9c2c9414</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-09T16:48:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots: Make mkdir return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b3a5c50a51a610957a671a2f42bb4269eb8039e2">b3a5c50a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-09T16:48:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots: Make rmdir return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0ebb15a6e236bf920ee9ff901b81b264212c4c37">0ebb15a6</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-09T16:48:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots: Make chflags return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a7921ded299d138430ab9b37c3f1e1e064f6b3fa">a7921ded</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-09T16:48:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots: Make removexattr return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/64e594e5dc774cc51ec0bdf9b1c5537c4b66e8ce">64e594e5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-09T18:08:03+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots: Make setxattr return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Aug 9 18:08:03 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e2572242986903b1d7e8468dc9528ba4a74ea6bc">e2572242</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-09T22:48:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Nobody uses the changed "lease" from grant_fsp_oplock_type
.. except for the DEBUG message
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d2aaef2e9c90b35e52369e8f229591b06c75bb27">d2aaef2e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-09T22:48:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Make "lease" const in grant_fsp_oplock_type()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/91b479fb6cf7bc7bc2287e8f5cd835e4b1894458">91b479fb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-09T22:48:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Make "lease" const in open_file_ntcreate()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bfa604541edeea4aa91c81f510716d5bb476a3f7">bfa60454</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-09T22:48:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Make "lease_key" const in lease_match()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/665e3f022f215ea7dcaabedee950be134039cd7a">665e3f02</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-09T22:48:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Make "lease" const in create_file_unixpath()
This is the one place where *lease actually got modified. We can
easily make a copy, "struct smb2_lease" is not too large, and this
case is pretty rare anyway.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c2a779f50e8694f20fb06b6e05bc24678d47b7d6">c2a779f5</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-09T22:48:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Make "lease" const in create_file_default()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2c20954af5d55ed3537de7d3b22340c8305ad1a3">2c20954a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-09T22:48:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Make "lease" const in SMB_VFS_CREATE_FILE()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/16b56549d2ca6aad68467116ca08829c1144a41b">16b56549</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-09T22:48:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: FTRUNCATE regular files only
I don't really have a test case, but to me a positive test for a
regular file makes more sense here than just ruling out FIFOs. While
we probably only ever hit regular files (or FIFOs), there might be
more that we catch and don't properly handle.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fe26ff6e911f835808ac3f465822f86260407020">fe26ff6e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-10T00:07:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Simplify fd_open_atomic()
* Assign *file_created on every exit.
* Directly assign curr_flags without &= / |=
Both of these changes make the routine easier to understand for me,
less jumping around in the code to see where the values came from.
* Do the retry in a "positive" if-clause
Normally I'm a big fan of early returns, but this single retry is so
simple that to me it's easier to understand this way.
Overall, 13 lines less code. YMMV :-)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Aug 10 00:07:28 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6bf6cb1643ae5e8fff66a7cbec50f58ede632666">6bf6cb16</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-10T19:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Add forward declaration for gnutls_hmac_hd_t
This file is basically included everywhere. So use a forward declaration
for gnutls_hmac_hd_t. This way we don't have to link everthing against
gnutls to get access to the header path.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b81cb04d03d57b8175d862ba48ac476fedf23636">b81cb04d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-10T19:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: Link vfs_acl_common against gnutls
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5eb4d705396faa5e5de90aaa86f7115b0f005589">5eb4d705</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-10T19:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci: Install compat-gnutls34 on CentOS7
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/99b4791cfe423b19f1f21d5f9fb42157336019f1">99b4791c</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-10T19:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Fix mem-leak if talloc_realloc fails
In case of a failing talloc_realloc(), the only reference
to the originally allocated memory is overwritten.
Instead use a temp var until success is verified.
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1610476860576effa3c05fc10c753c6183f6d9e9">16104768</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-10T19:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: fix mem leak found by ASAN
==14507==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 112 byte(s) in 1 object(s) allocated from:
#0 0x7f3c76fe5c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
#1 0x7f3c7680df33 in __talloc_with_prefix ../../lib/talloc/talloc.c:782
#2 0x7f3c7680df33 in __talloc ../../lib/talloc/talloc.c:824
#3 0x7f3c7680df33 in _talloc_named_const ../../lib/talloc/talloc.c:981
#4 0x7f3c7680df33 in _talloc_zero ../../lib/talloc/talloc.c:2422
#5 0x7f3c7680e2a5 in _talloc_zero_array ../../lib/talloc/talloc.c:2775
#6 0x557a50d4a09f in torture_bench_treeconnect ../../source4/torture/raw/tconrate.c:165
#7 0x7f3c730e4772 in wrap_simple_test ../../lib/torture/torture.c:633
#8 0x7f3c730e875e in internal_torture_run_test ../../lib/torture/torture.c:442
#9 0x7f3c730e9543 in torture_run_tcase_restricted ../../lib/torture/torture.c:507
#10 0x7f3c730e9dd5 in torture_run_suite_restricted ../../lib/torture/torture.c:357
#11 0x7f3c730ea434 in torture_run_suite ../../lib/torture/torture.c:339
#12 0x557a50c1b54a in run_matching ../../source4/torture/smbtorture.c:93
#13 0x557a50c1cf56 in torture_run_named_tests ../../source4/torture/smbtorture.c:143
#14 0x557a50c2099d in main ../../source4/torture/smbtorture.c:691
#15 0x7f3c6b406412 in __libc_start_main (/lib64/libc.so.6+0x24412)
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dbf26d7e0c9b46ff3b8da7af0d51080bbf17a9d6">dbf26d7e</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-10T19:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: fix mem leak found by ASAN (smb2_scan)
Direct leak of 96 byte(s) in 1 object(s) allocated from:
#0 0x7f63e6938c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
#1 0x7f63e615fa5c in __talloc_with_prefix ../../lib/talloc/talloc.c:782
#2 0x7f63e615fa5c in __talloc ../../lib/talloc/talloc.c:824
#3 0x7f63e615fa5c in _talloc_named_const ../../lib/talloc/talloc.c:981
#4 0x7f63e615fa5c in talloc_named_const ../../lib/talloc/talloc.c:1748
#5 0x55609e7530cf in torture_smb2_scan ../../source4/torture/smb2/scan.c:203
#6 0x7f63e2a37772 in wrap_simple_test ../../lib/torture/torture.c:633
#7 0x7f63e2a3b75e in internal_torture_run_test ../../lib/torture/torture.c:442
#8 0x7f63e2a3c543 in torture_run_tcase_restricted ../../lib/torture/torture.c:507
#9 0x7f63e2a3cdd5 in torture_run_suite_restricted ../../lib/torture/torture.c:357
#10 0x7f63e2a3cf25 in torture_run_suite_restricted ../../lib/torture/torture.c:362
#11 0x7f63e2a3d434 in torture_run_suite ../../lib/torture/torture.c:339
#12 0x55609e3a154a in run_matching ../../source4/torture/smbtorture.c:93
#13 0x55609e3a2f56 in torture_run_named_tests ../../source4/torture/smbtorture.c:143
#14 0x55609e3a699d in main ../../source4/torture/smbtorture.c:691
#15 0x7f63dad59412 in __libc_start_main (/lib64/libc.so.6+0x24412)
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9f193b747f399f7d8be42a198f81b0cafa67341d">9f193b74</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-10T20:42:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">loadparm: fix mem leak found by ASAN
==24948==ERROR: LeakSanitizer: detected memory leaks
Indirect leak of 232 byte(s) in 1 object(s) allocated from:
#0 0x7fc44b971c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
#1 0x7fc44a2fe7b0 in __talloc_with_prefix ../../lib/talloc/talloc.c:782
#2 0x7fc44a2fe7b0 in __talloc ../../lib/talloc/talloc.c:824
#3 0x7fc44a2fe7b0 in _talloc_named_const ../../lib/talloc/talloc.c:981
#4 0x7fc44a2fe7b0 in _talloc_array ../../lib/talloc/talloc.c:2764
#5 0x7fc44a1239bc in str_list_make_v3 ../../lib/util/util_strlist_v3.c:58
#6 0x7fc44a123e3b in str_list_make_v3_const ../../lib/util/util_strlist_v3.c:127
#7 0x7fc44b14cc1a in init_globals ../../source3/param/loadparm.c:547
#8 0x7fc44b14deef in lp_load_ex ../../source3/param/loadparm.c:3876
#9 0x7fc44b14f97c in lp_load_initial_only ../../source3/param/loadparm.c:4025
#10 0x7fc44b479235 in cmdline_messaging_context ../../source3/lib/cmdline_contexts.c:34
#11 0x557cf59d642c in process_options ../../source3/utils/smbpasswd.c:200
#12 0x557cf59d642c in main ../../source3/utils/smbpasswd.c:633
#13 0x7fc4419f5412 in __libc_start_main (/lib64/libc.so.6+0x24412)
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Aug 10 20:42:39 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0b64e84c01a36302a2298c1d1af4c7f4c41ed6eb">0b64e84c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-12T00:00:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper: Make unlink return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8eb79cd0524e4a9792017ca7999085b5cd6f01c4">8eb79cd0</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-12T00:00:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper: Make chmod return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/872cd6fbda959936d6b0c3b3e403377837c3abba">872cd6fb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-12T00:00:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper: Make chown return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/78b3784f3ffd1c76a4a41f95cbcc6fe4c68b012f">78b3784f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-12T00:00:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper: Make ntimes return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f5dbda6f32771afbd44db6dc0d865d3c221b22b4">f5dbda6f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-12T00:00:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper: Make mknod return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6539d3be92f044174b862e6cbb04b5ca47651ff4">6539d3be</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-12T00:00:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper: Make mkdir return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2022338b7f9d6e44c43f3d8c4280cfcca346514c">2022338b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-12T00:00:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper: Make rmdir return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5d791718532502ce1ec79aaaaccd2a9b129f73a5">5d791718</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-12T00:00:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper: Make chflags return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3beffd18adddbf7f4c1e01e68440a760e866183f">3beffd18</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-12T00:00:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper: Make removexattr return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e6b7d782020e86fc8e28438c969a2e9e1da288f1">e6b7d782</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-12T01:18:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper: Make setxattr return errno = EROFS on a shadow copy path.
smbd has no business modifying a shadow copy filesystem, it should be read-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon Aug 12 01:18:45 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/70ff216935acc099b762b527033b6191ba3307d0">70ff2169</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-12T09:23:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Add generate_nonce_buffer()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b2506f2407429efb40c3e4e4c360f5817ac13d27">b2506f24</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-12T09:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Use generate_nonce_buffer() for AES-CCM and AES-GCM nonce
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2b2df6cd398c9cb62989710f9b1642665ec89406">2b2df6cd</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-12T09:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Use generate_nonce_buffer() for AES-CCM and AES-GCM nonce
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bf52ab7d2982de84a68a1b9c6d2f68250b7e7cca">bf52ab7d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-12T09:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Add better documentation for generate_secret_buffer()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4b2480518bd3887be3a6cfb713523ac084e09fd5">4b248051</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-12T09:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Use generate_secret_buffer() to create a session key
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5a62056b4530e4c509444be9164a1fca1dce193f">5a62056b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-12T09:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Use generate_secret_buffer() for backupkey wap_key
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a21770cfdffd2a21045a1bc87e489af0f4c6f130">a21770cf</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-12T09:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Use generate_secret_buffer() for netlogon challange
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c3ba556f52b15dd80efc26e4fb8f43ce2ee3a7f0">c3ba556f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-12T10:42:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Use generate_secret_buffer() for netlogon challenge
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Aug 12 10:42:35 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5e9a25ae28f465fb47f18184983cc74d75e15353">5e9a25ae</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2019-08-12T23:23:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/doc: fix some double-word typos
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f2472f48f536daa5a21ba2787c342fceb3b400d3">f2472f48</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2019-08-13T00:42:09+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/pdb: fix debug message typos
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Aug 13 00:42:09 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a3dad84630e58d380f5c735123fba7f67ce1d180">a3dad846</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-14T07:39:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Fix CID 1452292 Null pointer dereferences (REVERSE_INULL)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/02eb2c9225287ac1fed740f68e014aff52ab5fc9">02eb2c92</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-14T07:39:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix CID 1452291 Null pointer dereferences (NULL_RETURNS)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f1b749eebda720ecf97ed6016faeba7116e99996">f1b749ee</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-14T07:39:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix CID 1452290 Null pointer dereferences (REVERSE_INULL)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/77ae0429c91c03163eaf7545888a7ca7d76ace11">77ae0429</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-14T07:39:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: CID 1452289: API usage errors (USE_AFTER_FREE)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dee721af72ec68f45c7a230ea0c1a0a3ebe1c7f6">dee721af</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-14T08:59:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Fix CID 1452288 Null pointer dereferences (NULL_RETURNS)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Aug 14 08:59:23 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/758962a0d435fa595e3917b860a8fd266d122550">758962a0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Drop 'o' option from getopts command
Commit 90de5e0594b9180226b9a13293afe31f18576b3d remove the processing
for this option but forgot to remove it from the getopts command.
Versions of ShellCheck >= 0.4.7 warn on this, so it is worth fixing.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14086
RN: Fix onnode test failure with ShellCheck >= 0.4.7
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/83f73b5abcef860a5a80b685337e5947c7c41b24">83f73b5a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid shellcheck warning SC2086
SC2086 Double quote to prevent globbing and word splitting
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/034f4cfab8b6690e07f5b9cfaaa5cb31ac29336e">034f4cfa</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid shellcheck warning SC2164
SC2164 Use 'cd ... || exit' or 'cd ... || return' in case cd fails
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/664968e523c1533e0fd420d5a0961c7ae1790cff">664968e5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid shellcheck warning SC2004
SC2004 $/${} is unnecessary on arithmetic variables
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/45c9fe3abbf02646b68fe47dd89357bd055feb09">45c9fe3a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid shellcheck warning SC2155
SC2155 Declare and assign separately to avoid masking return values
The wscript changes require an identical change in local_daemons.sh.
While touching the lines in wscript, escape the backslashes to make
them literal backslashes.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/93b3b01032781b75b3d7002f05ddbe2ffc38168d">93b3b010</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid shellcheck warning SC2188
SC2188 This redirection doesn't have a command...
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b198de03dce559decc25fd3ba65ee457fe6cb0ef">b198de03</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid shellcheck warning SC2230
SC2230 which is non-standard...
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7d95cb22a4e8638d71072e3d377076e9e01877ed">7d95cb22</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid shellcheck warning SC2034
SC2034 summary appears unused. Verify use (or export if used externally)
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b1d36e94d2edbab89d7db5055b13689d94b128ad">b1d36e94</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid shellcheck warning SC2045
SC2045 Iterating over ls output is fragile. Use globs.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/061656d383772b27607b8feb4a4ea9c988ce17d8">061656d3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Simplify test_wrap script
Given other improvements, this is now needlessly complex.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ba55306fce0025023e6deea637fa8eb13aa73ad2">ba55306f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Rename CTDB_SCRIPTS_TESTS_BINDIR to CTDB_SCRIPTS_TESTS_LIBEXEC_DIR
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/027b7ca0036db952d647df41e87498dc66a40054">027b7ca0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: New variable CTDB_SCRIPTS_TESTS_BIN_DIR
This can be used to find ctdb_run_tests and ctdb_local_daemons.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/da33fb27ab4f858689d4e93760edadd2018b9068">da33fb27</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add shellcheck test for some test scripts and includes
These files now pass, so we might as well keep them in good shape.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/91e6fc209be07c13db1d85fb268d4ff56b257973">91e6fc20</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Factor out main test loop into run_tests()
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b3b44ae532a19348a93b16314c44b983070a78c0">b3b44ae5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add -I <count> option for iterating tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7c01bf3d37b1b21550ee6aabbad266acc34056a2">7c01bf3d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop mention of non-existent -s option
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/695b3a965b856b2bffa5809d4bb71b9d827c392c">695b3a96</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Don't print summary on failure if -e option is specified
If there is a failure it will always be the last test run. Don't
obscure this by following it with a summary.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a074dbf6454cc37ec9cda92dd897316cc27cd630">a074dbf6</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Fix usage for "ctdb cattdb"
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3ea95ab4cb70224b96a3f40fed9bb6dcc2abedf7">3ea95ab4</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add function select_test_node()
Should be used when public IP addresses are not assigned.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f7f9f57d2e13e7ced1f2237273965af8dfc29335">f7f9f57d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use select_test_node() in ctdb setdebug simple test
There is no requirement for IP addresses here.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5a3d99dc7ad49717252d8c9625e0f8d064cffcd8">5a3d99dc</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Return value of ctdb_queue_length() should be unsigned
Compiling with -Wsign-compare complains:
ctdb/server/ctdb_daemon.c: scope_hint: In function ‘daemon_queue_send’
ctdb/server/ctdb_daemon.c:259:40: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
...
The struct ctdb_queue member out_queue_length is actually uint32_t, so
just return that type.
Found by csbuild.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4bdfbbd8d4fb681d509d702a8a357b11c8dddcac">4bdfbbd8</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T09:11:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Avoid signed/unsigned comparison by declaring as unsigned
Compiling with -Wsign-compare complains:
ctdb/server/ctdb_call.c:831:12: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
831 | if (count <= ctdb_db->statistics.hot_keys[0].count) {
| ^~
and
ctdb/server/ctdb_call.c:844:13: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
844 | if (count <= ctdb_db->statistics.hot_keys[i].count) {
| ^~
Found by cs-build.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6c9d1f855ea3fe3d12f712678b7b4347f8982977">6c9d1f85</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-14T10:29:59+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Avoid signed/unsigned comparison by casting
Compiling with -Wsign-compare complains:
1047 | && (call->call_id == CTDB_FETCH_WITH_HEADER_FUNC)) {
| ^~
struct ctdb_call is a protocol element, so we can't simply change it.
Found by csbuild.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed Aug 14 10:29:59 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2dd7ebe072acdad56f9bab8237cc9421f230f67e">2dd7ebe0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-14T11:48:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix CID 1452293 Incorrect expression (NO_EFFECT)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Aug 14 11:48:42 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/317bc6a7342edfa2c503f5932142bf5883485cc9">317bc6a7</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2019-08-14T11:49:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture/rpc/lsa: allow testing different lookup levels
Convert torture/rpc/lsa LookupNames/LookupSids code to allow testing
different LSA_LOOKUP_NAMES_* levels. Keep existing level 1
(LSA_LOOKUP_NAMES_ALL) for the current set of tests.
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/685bb03de6ab733590831d1df4f5fd60d2ac427d">685bb03d</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2019-08-14T11:49:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lookup_name: allow own domain lookup when flags == 0
In 2007, we've added support for multiple lookup levels for LSA
LookupNames family of calls. However, forest-wide lookups, as described
in MS-LSAT 2.2.16, never worked because flags passed to lookup_name()
were always set to zero, expecting at least default lookup on a DC to
apply. lookup_name() was instead treating zero flags as 'skip all
checks'.
Allow at least own domain lookup in case domain name is the same.
This should allow FreeIPA DC to respond to LSA LookupNames3 calls from a
trusted AD DC side.
For the reference, below is a request Windows Server 2016 domain
controller sends to FreeIPA domain controller when attempting to look up
a user from a trusted forest root domain that attemps to login to the
domain controller. Notice the level in the lsa_LookupNames3 call and
resulting flags in lookup_name().
[2019/08/03 07:14:24.156065, 1, pid=23639, effective(967001000, 967001000), real(967001000, 0), class=rpc_parse] ../../librpc/ndr/ndr.c:471(ndr_print_function_debug)
lsa_LookupNames3: struct lsa_LookupNames3
in: struct lsa_LookupNames3
handle : *
handle: struct policy_handle
handle_type : 0x00000000 (0)
uuid : 0000004c-0000-0000-455d-3018575c0000
num_names : 0x00000001 (1)
names: ARRAY(1)
names: struct lsa_String
length : 0x000a (10)
size : 0x000c (12)
string : *
string : 'XS\ab'
sids : *
sids: struct lsa_TransSidArray3
count : 0x00000000 (0)
sids : NULL
level : LSA_LOOKUP_NAMES_UPLEVEL_TRUSTS_ONLY2 (6)
count : *
count : 0x00000000 (0)
lookup_options : LSA_LOOKUP_OPTION_SEARCH_ISOLATED_NAMES (0)
client_revision : LSA_CLIENT_REVISION_2 (2)
[2019/08/03 07:14:24.156189, 6, pid=23639, effective(967001000, 967001000), real(967001000, 0), class=rpc_srv] ../../source3/rpc_server/rpc_handles.c:339(find_policy_by_hnd_internal)
Found policy hnd[0] [0000] 00 00 00 00 4C 00 00 00 00 00 00 00 45 5D 30 18 ....L... ....E]0.
[0010] 57 5C 00 00 W\..
[2019/08/03 07:14:24.156228, 4, pid=23639, effective(967001000, 967001000), real(967001000, 0)] ../../source3/smbd/sec_ctx.c:215(push_sec_ctx)
push_sec_ctx(967001000, 967001000) : sec_ctx_stack_ndx = 2
[2019/08/03 07:14:24.156246, 4, pid=23639, effective(967001000, 967001000), real(967001000, 0)] ../../source3/smbd/uid.c:552(push_conn_ctx)
push_conn_ctx(0) : conn_ctx_stack_ndx = 0
[2019/08/03 07:14:24.156259, 4, pid=23639, effective(967001000, 967001000), real(967001000, 0)] ../../source3/smbd/sec_ctx.c:319(set_sec_ctx_internal)
setting sec ctx (0, 0) - sec_ctx_stack_ndx = 2
[2019/08/03 07:14:24.156273, 5, pid=23639, effective(967001000, 967001000), real(967001000, 0)] ../../libcli/security/security_token.c:53(security_token_debug)
Security token: (NULL)
[2019/08/03 07:14:24.156285, 5, pid=23639, effective(967001000, 967001000), real(967001000, 0)] ../../source3/auth/token_util.c:865(debug_unix_user_token)
UNIX token of user 0
Primary group is 0 and contains 0 supplementary groups
[2019/08/03 07:14:24.156311, 5, pid=23639, effective(0, 0), real(0, 0), class=rpc_srv] ../../source3/rpc_server/lsa/srv_lsa_nt.c:244(lookup_lsa_sids)
lookup_lsa_sids: looking up name XS\ab
[2019/08/03 07:14:24.156327, 10, pid=23639, effective(0, 0), real(0, 0)] ../../source3/passdb/lookup_sid.c:112(lookup_name)
lookup_name: XS\ab => domain=[XS], name=[ab]
[2019/08/03 07:14:24.156340, 10, pid=23639, effective(0, 0), real(0, 0)] ../../source3/passdb/lookup_sid.c:114(lookup_name)
lookup_name: flags = 0x00
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4d276a93fc624dc04d880f5b4157f272d3555be6">4d276a93</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2019-08-14T13:07:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbtorture: extend rpc.lsa to lookup machine over forest-wide LookupNames
Add a simple test to resolve DOMAIN\MACHINE$ via LSA LookupNames3
using LSA_LOOKUP_NAMES_UPLEVEL_TRUSTS_ONLY2 level. This level would pass
zero lookup flags to lookup_name().
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Wed Aug 14 13:07:42 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/97c441d7c28feb29168e81ebbc5c55b09a845087">97c441d7</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-14T15:07:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Fix documentation for random number functions
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/689760f26521fe5b4c8964a25ddd3ab1c9e9977c">689760f2</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-14T15:07:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "libcli:auth: Use generate_secret_buffer() for netlogon challenge"
This reverts commit c3ba556f52b15dd80efc26e4fb8f43ce2ee3a7f0.
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1c68085404cd467c217640e3eabfc4b7f8b1ce9f">1c680854</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-14T15:07:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "s4:rpc_server: Use generate_secret_buffer() for netlogon challange"
This reverts commit a21770cfdffd2a21045a1bc87e489af0f4c6f130.
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/38b0695ddac244c67b2a33eb927ad3e95d2e8bd6">38b0695d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-14T15:07:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "s4:rpc_server: Use generate_secret_buffer() for backupkey wap_key"
This reverts commit 5a62056b4530e4c509444be9164a1fca1dce193f.
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d73be972ea58d564c770698bf6374a6074f111fe">d73be972</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-14T15:07:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "s4:rpc_server: Use generate_secret_buffer() to create a session key"
This reverts commit 4b2480518bd3887be3a6cfb713523ac084e09fd5.
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/93196dd823e114f260a68d28bb59eac3909c30d8">93196dd8</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-14T15:07:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Use generate_secret_buffer() for long term passwords
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a3e36dd8f43a5c06969ae158fa54fbc649f44d03">a3e36dd8</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-14T15:07:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:samdb: Use generate_nonce_buffer() for AEC GCM nonce
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6fa3e4de7c168dc7c869ec9966729a36bda27f57">6fa3e4de</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-14T15:07:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:passdb: Use generate_secret_buffer() for generating passwords
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9b7825d2d387bcb2515154418a990669ab96358d">9b7825d2</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-14T16:26:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth:ntlmssp: Use generate_random_buffer() for session keys
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Wed Aug 14 16:26:47 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/02b7e6c79b866ba0d339cad6c4fc9eb0d0be8968">02b7e6c7</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-08-14T16:27:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">quotas: Check group quota for directory when SGID is set
On directories with the "set group id" (SGID) bit is set, new files and
subfolders will be created with the group of the directory, and not with
the primary group of the user. Checking for free space in this case
should query the group quota for the gid of the directory.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/72c4e33decbaa19f9e7845240fdcf02029ded82c">72c4e33d</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-08-14T16:27:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Check group quota for directory when SGID is set
On directories with the "set group id" (SGID) bit is set, new files and
subfolders will be created with the group of the directory, and not with
the primary group of the user. Checking for free space in this case
should query the group quota for the gid of the directory.
This is the same change as the common smbd code, but since vfs_gpfs
still has its own check for available space and quotas, add it here as
well. A future goal would be to use the common free space check instead
of duplicating code in vfs_gpfs.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bbb259e7acb2485232359191f9d799e4c87bcbae">bbb259e7</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-08-14T16:27:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fake_dfq: Add option to fake stat information
Add an option to allow faking the gid and the SGID bit in the returned
stat buffer. That will be used to verify quota queries on folders with
SGID set.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f77c6c8be6b19880fb46fb5524a39cea03ef7bd5">f77c6c8b</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-08-14T16:27:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add test for quota query on directory with SGID
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ec05edcceed96f4a17ce7e45c4554b0500946ce0">ec05edcc</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-08-14T17:47:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Make sys_disk_free static
The function is only called from the same file.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Wed Aug 14 17:47:33 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/442a7c9ad8b020b2e88e41fea8a911d244023cb9">442a7c9a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-15T23:48:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_default: use correct flag in vfswrap_fs_file_id
Luckily using the wrong flag ST_EX_IFLAG_CALCULATED_ITIME currently results in
the same semantics as using the correct ST_EX_IFLAG_CALCULATED_FILE_ID, as in
vfs_default the non-calculated file_id is based a non-calculated itime.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14089
RN: vfs_default: use correct flag in vfswrap_fs_file_id
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3ee78cc9979a72ebbe65a16c60967a1735a0d208">3ee78cc9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-16T01:07:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_glusterfs: initialize st_ex_file_id, st_ex_itime and st_ex_iflags
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14090
RN: vfs_glusterfs: initialize st_ex_file_id, st_ex_itime and st_ex_iflags
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Aug 16 01:07:23 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/04f5dbb168a6b91aecb60ebb398a5f5297b288d5">04f5dbb1</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Reformatting. Use helper variable for SMB_VFS_RENAME call.
Will make replacement with renameat() clearer later.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c9b38eb79c99ad054231950e6d56a86da1061f8c">c9b38eb7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-16T19:52:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: modernize conn_new()
Split the monstrous if into individual allocations. I'm going to add more talloc
allocations in a subsequent commit, so it's time to split this up.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b535f78897eb5989666501f9543df478af420ecc">b535f788</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-16T19:52:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_full_audit: pass conn to smb_fname_str_do_log()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/75f98a19537c4d0791108ebfea82f3f9d4606cb3">75f98a19</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-08-16T19:52:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: change connection_struct cwd_fname to cwd_fsp
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/606398a3a6da349877eb1d6f585e3f58778624b2">606398a3</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Add SMB_VFS_RENAMEAT().
Currently identical to SMB_VFS_RENAME() - uses
AT_FDCWD for both src and dst directories.
Next, move add to all VFS modules that implement
rename and eventually remove rename.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/365b81238e261bae2b4f4ffe968a11cb3c0ff50a">365b8123</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_audit. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9859102b204b5ba9a348e4df30aff9d3afc6aae3">9859102b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_cap. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5528bcd44750cd989e051f6db6908e061e714f91">5528bcd4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_catia. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ab74d8d5bd4636405731c9d2aa2d32880844b349">ab74d8d5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4a415f63e6383ef4a293240ab77ec4ba92f25b4e">4a415f63</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c36ba3aff88bbb93ea5048906775bcedfaeac221">c36ba3af</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_crossrename. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ca298af67cebee4c3efebf24f4b9d0ef1e73b047">ca298af6</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_extd_audit. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8d8faa53fc7ef2163a3095ab29430fba06c8455a">8d8faa53</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4d74ed6f567832a43dbf04a868efe0f30cb53752">4d74ed6f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/318461eb7d3e1aa8651b6add54db10ea864bb380">318461eb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_glusterfs. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e61da4989946ff283e77c73cb201ab875de7d264">e61da498</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_media_harmony. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9193cd402ff33caa853f341b90c7a9e25ebb5785">9193cd40</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_netatalk. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a2d27f9113cef750a2e9fe2aac3c70dc7191dada">a2d27f91</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_shadow_copy2. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a85433f4bdeaf493e5c4cbf1c4c0feb5b34a415a">a85433f4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7ec34e6ab86c53e51896b717ede24bf1a9c0a14a">7ec34e6a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_depot. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/251bb56d1b064cbc90729cc58d0549e8f561b4bd">251bb56d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_xattr. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/588e64ddd02cb6b63184d5edffe7b5f2432232d8">588e64dd</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_syncops. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/16a455d3c3816a0a0fa82af8b04fa1c6fe6947a1">16a455d3</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_time_audit. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7978814d3b5a0b41b00b7c6043b9a12b88ca5b12">7978814d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_unityed_media. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d2fc9b136b7c632be92b078fa99a83d025b3d26e">d2fc9b13</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_virusfilter. Implement renameat().
Currently identical to rename().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/74ecfe28a96f2be960bd2d12a33f09a69582c54a">74ecfe28</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change rename_internals_fsp() to call SMB_VFS_RENAMEAT().
Use conn->cwd_fsp as current src and dst fsp's.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/25c1b853cf42b6e56090c1588d5696d24141829a">25c1b853</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Change cmd_vfs to call SMB_VFS_RENAMEAT().
Use conn->cwd_fsp as current src and dst fsp's.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/20564183966e36756b33c3b4e36d89a6932475e1">20564183</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: vfs_virusfilter: Use SMB_VFS_RENAMEAT() instead of SMB_VFS_RENAME.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d439c2bab4a3b1b8c4f3cee0cfe4110f8ea3f88c">d439c2ba</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_recycle. Use SMB_VFS_RENAMEAT() instead of SMB_VFS_RENAME()..
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ef0d50c27225f3a6cb570ed364ce17ffbae3506a">ef0d50c2</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_audit. Remove rename_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e591d92e98c2ddd6f98e2f9aa57f830ab573bf44">e591d92e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_cap. Remove rename_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9cedbbe88cb26e79371c28b017a4078d7091f517">9cedbbe8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_catia. Remove rename_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/086a7d7835081447424153331acc32360642e65b">086a7d78</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph. Remove rename_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/52960225fa8727f9dfe91f76e921a3c56168347c">52960225</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots. Remove rename_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ba25d8fbb16a1c11880e7434803b6c92b23647ee">ba25d8fb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_crossrename. Remove rename_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0464730ee2a1f17ce0944df4bfd9f6aa56678117">0464730e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_extd_audit. Remove rename_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7486b3c9f57b8e1353e93d51cd4597ad6f449509">7486b3c9</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit. Remove rename_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8afb453edc37b352d4d7447049798399332e2490">8afb453e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_glusterfs. Remove rename_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ca4e66cbd3a04407353974a751f0c6de19bdc5a5">ca4e66cb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_media_harmony. Remove rename_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/055fda0830e2fe470ed23ccd963e29b4a8bb711b">055fda08</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_netatalk. Remove rename_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d080085273f8c723dd1a844743904cf1cd9822a1">d0800852</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_shadow_copy2. Remove rename_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8e6a283a16f10f9d83e66d41271ccef536c85f0b">8e6a283a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper. Remove rename_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/46d61e203c73092ae300e75c6c56e5769cb67609">46d61e20</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_depot. Remove rename_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c661a5fbe6e7ff27effb084519b539b9c9819f0c">c661a5fb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_depot: Change to using SMB_VFS_RENAMEAT() instead of SMB_VFS_RENAME().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/110aff0caae03593e53a980c6c9074354f813a64">110aff0c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_xattr. Remove rename_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/33a243b7a2cf0bbcfde5a52dd70cef670164027c">33a243b7</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_syncops. Remove rename_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d45daf1ce86801e5800203e64abcaca0e7381805">d45daf1c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_unityed_media. Remove rename_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5db3edba41421f826f9a5a07efb17734c6c24969">5db3edba</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_virusfilter. Remove rename_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7aadbe5608e0322fbb627b4da4382613fa9dd25d">7aadbe56</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit. Remove rename_fn(). No longer used.
NB, this will now fail smb_vfs_assert_all_fns()
until we remove the rename_fn() from the VFS definitions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f0ac39d56156257275048a55f101665e32905da9">f0ac39d5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_time_audit. Remove rename_fn(). No longer used.
NB, this will now fail smb_vfs_assert_all_fns()
until we remove the rename_fn() from the VFS definitions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6acf4c35b46e8e7860209be00b688c631f0155bf">6acf4c35</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T19:52:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Complete the replacement of SMB_VFS_RENAME() -> SMB_VFS_RENAMEAT().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5cb539d8adedadee2089edd334ffc8c0bd3e4c77">5cb539d8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-16T21:10:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_default. Convert underlying system call to renameat().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Aug 16 21:10:14 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3acb8e9d1c854b577d6be282257269df83055d31">3acb8e9d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-16T21:30:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Add function ctdb_ip_to_node()
This is the core logic from ctdb_ip_to_pnn(), so re-implement that
that function using ctdb_ip_to_node().
Something similar (ctdb_ip_to_nodeid()) was recently removed in commit
010c1d77cd7e192b1fff39b7b91fccbdbbf4a786 because it wasn't required.
Now there is a use case.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c06620169fc178ea6db2631f03edf008285d8cf2">c0662016</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-16T21:30:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: Rename fd -> out_fd
in_fd is coming soon.
Fix coding style violations in the affected and adjacent lines.
Modernise some debug macros and make them more consistent (e.g. drop
logging of errno when strerror(errno) is already logged.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c68b6f96f26664459187ab2fbd56767fb31767e0">c68b6f96</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-16T21:30:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: Move incoming fd and queue into struct ctdb_tcp_node
This makes it easy to track both incoming and outgoing connectivity
states.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d80d9edb4dc107b15a35a39e5c966a3eaed6453a">d80d9edb</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-16T21:30:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: Use TALLOC_FREE()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7f4854d9643a096a6d8a354fcd27b7c6ed24a75e">7f4854d9</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-16T21:30:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: Create outbound queue when the connection becomes writable
Since commit ddd97553f0a8bfaada178ec4a7460d76fa21f079
ctdb_queue_send() doesn't queue a packet if the connection isn't yet
established (i.e. when fd == -1). So, don't bother creating the
outbound queue during initialisation but create it when the connection
becomes writable.
Now the presence of the queue indicates that the outbound connection
is up.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8c98c10f242bc722beffc711e85c0e4f2e74cd57">8c98c10f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-16T21:30:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: Only mark a node connected if both directions are up
Nodes are currently marked as up if the outgoing connection is
established. However, if the incoming connection is not yet
established then this node could send a request where the replying
node can not queue its reply. Wait until both directions are up
before marking a node as connected.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/73c850eda4209b688a169aeeb20c453b738cbb35">73c850ed</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-16T22:50:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: Mark node as disconnected if incoming connection goes away
To make it easy to pass the node data to the upcall, the private data
for ctdb_tcp_read_cb() needs to be changed from tnode to node.
RN: Avoid marking a node as connected before it can receive packets
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Aug 16 22:50:35 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4be5ffdca620c38e65ca955039acbdcf72829c67">4be5ffdc</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2019-08-17T03:50:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Prevent samba-tool online backup crash
On some GPOs, getting a files ntacl throws an
NT_STATUS_ACCESS_DENIED. Catch and log the
failure when this happens.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14088
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Tim Beale <timbeale@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2b7224ab7c555fdaacd0a84649b533e4edb377da">2b7224ab</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-17T03:50:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Remove zlib from third_party
We require zlib 1.2.3.
We stopped requring a patched zlib with 5631a1b9bc03d6cf31af66b13872255f18979fe8
As discussed on samba-technical here:
https://lists.samba.org/archive/samba-technical/2019-May/133476.html
In short, zlib contains some (old, now broken) crypto code that while not compiled
in Samba is best left out of our tarball to ease crypto audits. It is also very
very out of date and is a slightly modified copy of something otherwise very
likely available on our supported host OSs. It would be strange to say that
GnuTLS and dependencies are an acceptable burden to install but say zlib is
a step to far.
So it is removed from Samba's third_party with this commit.
The diff between zlib in Samba and official zlib 1.2.3 is included
in third_party/zlib/last-samba-from-1.2.3.diff
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7d96ed632260d7246f1729ee7efb696abc29fd6c">7d96ed63</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-17T05:10:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Remove historical tombstone about zlib divergance
Now this has been recorded in the git history, we can remove it.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Aug 17 05:10:48 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/58b5bfba11a66d250267efe901dfba76f82005f8">58b5bfba</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Micro-optimization for db_tdb_do_locked()
We don't need the tdb lock for the talloc_free(buf) anymore
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a0b0ea8f356ac3a788d7b33d249ed6ec3eecc4bb">a0b0ea8f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Save two lines in find_share_mode_entry
Directly initialized variables give compilers less reason to complain
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/13fb42ac40067d1b335511e48354169ee15f29b3">13fb42ac</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Avoid casts in share_conflict()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d09bd5f8fd4b2de28efcefc5839bd69bb088b88f">d09bd5f8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Merge two DEBUGs into one
This looks easier to understand to me, less lines in logfiles
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aeb4265ec2f5d75250b1bc4d884628426df28dca">aeb4265e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove a misleading comment
open_mode_check() is done before the oplock breaks.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/38463a91aafa2643551b4e4508c3e575d9e914a1">38463a91</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove a duplicate function prototype
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9034cb39d7c0d8d6387f4977f894349db187d6b5">9034cb39</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Optimize delay_for_oplock()
get_lease_type() can involve a database access. Do that only if
necessary, and that is at most once in this loop.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/71c9fd73d42e092cf65de25fb7773fc1395ff601">71c9fd73</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Simplify is_same_lease()
It does not use "struct share_mode_data"
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/021e2d01e68714556bd811ff2bc2a04c71a6c1fd">021e2d01</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Move is_same_lease() up in the file
The next commit will need it there
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/28868d24576dbd437329b7a59104cb7c15ee4624">28868d24</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Simplify delay_for_oplock()
Use is_same_lease()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6be8057317a05b247169b8a30f968d1d2c085562">6be80573</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Align integer types
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4d6f89c9883abaf7e9152887b7fa13449579c09c">4d6f89c9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Simplify has_other_nonposix_opens()
We pick quite some information from "fsp" already, so from an API design
perspecitve it's only fair to only use its implicit server_id. This is
what all the callers did anyway.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/706f0af2e4b5012644da742c94fc12eb756054fd">706f0af2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Optionally wait for a share mode record in setup_poll_open()
This will be used when waiting for a oplock break that has been
signalled via a kernel oplock break.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/002c6d0efb7bb41c158fc9056a176c5cce72f393">002c6d0e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: For kernel-oplocked files don't call delay_for_oplock()
The kernel has already sent the signal. We don't have to send another
message. Instead, just directly wait for the downgrade to happen via
the watch on the share mode lock assuming it's there. Also setup the
polling interval: I could imagine that in some race situation the file
has already been closed and re-opened by a nonsamba process while we
were waiting.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f8fe0116c1158d8fdf0401ca46e8f12b84c04738">f8fe0116</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Move resetting "oplock_request" to before delay_for_oplock()
It seems to make little sense to me to do the oplock break with one
setting and then later on grant_fsp_oplock_type with another
one. Survives tests, I can't think of any scenario where this (to me)
simplification would break anything
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3bd7b119e6882aee04badc92f2ddbcbc1964c115">3bd7b119</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove a late ref to "file_existed" in open_file_ntcreate()
If you follow "existing_dos_attributes" through the routine, this can
only ever be !=0 if SMB_VFS_GET_DOS_ATTRIBUTES() was successful. This
can only have been successful if the file existed.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3ecfa36e777cf377a4ae06644b0880fef4867452">3ecfa36e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Slightly simplify open_file_ntcreate()
There is no reference to "file_existed" after this point anymore
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5c6163d3e664c20034fb41969e886372e3c88aa6">5c6163d3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Move grant_fsp_oplock_type() close to delay_for_oplock()
Note that this is not a cut&paste: Instead of fsp->access_mask we use
the access_mask the client requested. At the new code location
fsp->access_mask (a.k.a. open_access_mask) might have FILE_WRITE_DATA
from O_TRUNC (a.k.a. FILE_OVERWRITE).
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d4e98b8ae5f08d6e332b15d868e7bf85995974f3">d4e98b8a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Move set_share_mode() out of grant_fsp_oplock_type()
This shows that "req", "share_access" and "access_mask" are not needed
for the core logic of grant_fsp_oplock_type() and it separates
concerns a bit: open_directory() also does the set_share_mode() in the
main open routine, not in a helper like grant_fsp_oplock_type()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/385a7fb196f7a6bdcdeb74b6e8553da7c810c1ca">385a7fb1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Introduce handle_share_mode_lease()
This consolidates the core share_mode_lock access of open_file_ntcreate
into one routine.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d1cb71fa500ede015600ace58411c857b051794e">d1cb71fa</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Slightly simplify delay_for_oplock()
This is never called for INTERNAL_OPENs anymore, see
handle_share_mode_lease()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/10679b67d1372bde37a1cdd639bebcc5f79a9c1b">10679b67</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Slightly simplify grant_fsp_oplock_type()
This is never called with INTERNAL_OPENs anymore
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a4192bc70d7717a5072ccdd8e53b7dda7e6d9c98">a4192bc7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Make delay_for_oplock() return NTSTATUS
A further commit will merge grant_fsp_oplock_type (returning NTSTATUS)
into delay_for_oplock(). Make that commit smaller.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7a6fa34130e8e6bea4672d08637af49097654119">7a6fa341</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Move delay_for_oplock() down
We'll merge grant_fsp_oplock_type() into this function. This makes the next
commit smaller, and the newly extended delay_for_oplocks will for example
reference static file_has_brlocks() above. Make forward declarations
unnecessary.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9a11f361cc19d3b8da3469424697486d0fd8dd6d">9a11f361</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-19T23:14:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Merge grant_fsp_oplock_type() into delay_for_oplock()
This is a preparation for the next commit: Only walk the share_modes[]
array once when handling oplocks and leases.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8a05d2b074d588a481aa372f2923f55cfb3e3a23">8a05d2b0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-08-20T00:33:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Move lease type detection in delay_for_oplock()
Walk the share_modes array only once.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Aug 20 00:33:12 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c4aebb15001c830a46d5a6ad8ea11a6f9ea4fd04">c4aebb15</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2019-08-20T03:40:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">downgradedatabase: comply with samba.tests.source
In next commit we'll install the script, samba.tests.source picked up the
lack of a copyright message and some whitespace errors, so this patch
fixes that stuff first.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a8cdbe0b824f57f73eee09143148f009a9c58582">a8cdbe0b</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-08-20T03:40:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Avoid hardcoding relative filepath
If we move the test file, the test will break.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fdaaee8d3aac77d91642a7d75d4bcd15d4df8657">fdaaee8d</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-08-20T03:40:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">downgradedatabase: rename to samba_downgrade_db
Just so that it's slightly less of a mouthful for users.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c89df3862b17fad9c4648b5d9c6805120d732df8">c89df386</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2019-08-20T03:40:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">downgradedatabase: Add man-page documentation
A man-page is needed so that we can install this tool as part of the
Samba package.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6dcf00ba0a470ba25aabae06b409ec95404c246f">6dcf00ba</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2019-08-20T03:40:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">downgradedatabase: installing script
Installing downgrade script so people don't need the source tree for it.
Exception added in usage test because running the script without arguments
is valid. (This avoids the need to knownfail it).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a2b0fc7c00360f37ed6819f21380294b70d4a195">a2b0fc7c</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-08-20T03:40:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Always log when the database pack format changes
LDB_DEBUG_WARNING gets logged by Samba as level 2, whereas the default
log level for Samba is 0. It's not really fair to the user to change the
format of their database on disk and potentially not tell them.
This patch adds a log with level zero (using a alias define, as this
technically isn't a fatal problem).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d427bd6c775d8117504e76eed42cd2c383512e34">d427bd6c</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-08-20T03:40:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Move where we update the pack format version
Store it on the repack context so that we can log a more informative
message "Repacking from format x to format y".
While this is not really a big deal currently, it could be worth
recording for potential future scenarios (i.e. supporting three or more
pack versions), where upgrades could potentially skip an intermediary
pack format version.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/38e3e7cd328edac302e95ac8839e858c4a225485">38e3e7cd</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-08-20T03:40:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Change pack format defines to enum
The main reason is so that any future pack formats will continue
incrementing this number in a sequential fashion.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5fee9388422e259c2a56e4dccbf44d22ba426ca3">5fee9388</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-08-20T03:40:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Log pack format in user-friendly way
The "format 0x26011968" log confused me (and I'm a developer).
We can subtract the base offset from the pack format to get a more
user-friendly number, e.g. v0 (not actually used), v1, v2, etc.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ee6537c29e747206ee607493ce15d4532fb670c8">ee6537c2</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-08-20T03:40:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Log the partition we're repacking
Firstly, with Samba AD this looks a little weird because we log the same
message 5 times (once for every partition). If we log that we're doing
this to records in different partitions, hopefully someone with a little
Samba knowledge can figure out what's going on.
Secondly, the info about what partitions are actually changing might be
useful. E.g. if we hit a fatal error repacking the 3rd partition, and
the transaction doesn't abort properly, then it would be useful to know
what partitions were repacked and which ones weren't.
There doesn't appear to be a useful name for the partition
(ldb_kv->kv_ops->name() doesn't seem any more intelligible to a user),
so just log the first record that we update. We can use that to infer
the partition database).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b6516dbd24df8c78ed909c7ef9058b0844abb917">b6516dbd</a></strong>
<div>
<span>by Tim Beale</span>
<i>at 2019-08-20T04:57:10+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Free memory when repacking database
The msg for each database record is allocated on the module context, but
never freed. The module seems like it could be a long-running context (as
the database would normally get repacked by the samba executable).
Even if it's not a proper leak, it shouldn't hurt to cleanup the memory.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Tue Aug 20 04:57:10 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f8e79be2c155f26abfa7e5e3fddd2f453c2f943a">f8e79be2</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2019-08-20T06:58:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: fix mandatory typo in zlib configure check
This ensures that waf correctly fails during configure if zlib is
missing.
msg can also be dropped as it matches the waf validate_cfg() default
(ignoring the quotes).
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Aug 20 06:58:12 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a42bcaabb63722411bee52b80cbfc795593defbc">a42bcaab</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-20T07:15:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Factor out new function ctdb_node_become_inactive()
This is a superset of ctdb_local_node_got_banned() so will replace
that function, and will also be used in the NODE_STOP control.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14087
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0f5f7b7cf4e970f3f36c5e0b3d09e710fe90801a">0f5f7b7c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-20T07:15:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Switch banning code to use ctdb_node_become_inactive()
There's no reason to avoid immediately setting recovery mode to active
and initiating freeze of databases.
This effectively reverts the following commits:
d8f3b490bbb691c9916eed0df5b980c1aef23c85
b4357a79d916b1f8ade8fa78563fbef0ce670aa9
The latter is now implemented using a control, resulting in looser
coupling.
See also the following commit:
f8141e91a693912ea1107a49320e83702a80757a
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14087
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/91ac4c13d8472955d1f04bd775ec4b3ff8bf1b61">91ac4c13</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-20T07:15:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Drop unused function ctdb_local_node_got_banned()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14087
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e9f2e205ee89f4f3d6302cc11b4d0eb2efaf0f53">e9f2e205</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-20T08:32:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Make node inactive in the NODE_STOP control
Currently some of this is supported by a periodic check in the
recovery daemon's main_loop(), which notices the flag change, sets
recovery mode active and freezes databases. If STOP_NODE returns
immediately then the associated recovery can complete and the node can
be continued before databases are actually frozen.
Instead, immediately do all of the things that make a node inactive.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14087
RN: Stop "ctdb stop" from completing before freezing databases
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue Aug 20 08:32:27 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/60cba7b3a17104da1543d59609f50c6638880dd1">60cba7b3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-08-20T14:45:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Release tdb 1.4.2
* Build fixes
* Improve the performance by inlining the tdb_oob() checks
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Aug 20 14:45:41 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/098486da91bdf431489879154e297591edef7f83">098486da</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2019-08-20T19:25:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_glusterfs: Enable profiling for file system operations
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14093
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Aug 20 19:25:28 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6c3928e4e5b724190843f75bec3e697af77a01a0">6c3928e4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Add SMB_VFS_LINKAT().
Currently identical to SMB_VFS_LINK().
Next, move add to all VFS modules that implement
link and eventually remove link.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/648e771a61d2d327ed3fe0f3a4eb0837a714b280">648e771a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_cap. Implement linkat().
Currently identical to link().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7d2ba253adaa3c6a57bd7048498e91a1ee0db712">7d2ba253</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph. Implement linkat().
Currently identical to link().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2f989023259c92d3d5da7e0359a31f1a10c1dbb3">2f989023</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots. Implement linkat().
Currently identical to link().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8e5634260632654b82f99170518b1086a2d9b9f1">8e563426</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit. Implement linkat().
Currently identical to link().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d75177454c5612c7c68f637571f1bd3a3d34f220">d7517745</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_glusterfs. Implement linkat().
Currently identical to link().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6e96b98f6436289d1804b6a2a767b411edeb291b">6e96b98f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_media_harmony. Implement linkat().
Currently identical to link().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c55b43ba13a162d07befc27361632cdf2ef8aeb2">c55b43ba</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_shadow_copy2. Implement linkat().
Currently identical to link().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dad377dbe4795f110da35bb751f800d6658fa7c0">dad377db</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper. Implement linkat().
Currently identical to link().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/571624b866d82bb1e9317c1f099049e0483bd1cc">571624b8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_syncops. Implement linkat().
Currently identical to link().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a14d825a2507726f54ac3b4249e10968a2e35bd0">a14d825a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_time_audit. Implement linkat().
Currently identical to link().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6b6298b02392e30044efd9fbc236d9ffb8f1ec1a">6b6298b0</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_unityed_media. Implement linkat().
Currently identical to link().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d4f3d6ce12b2e2d504dcdbbb9b670ceff5cf3243">d4f3d6ce</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Change cmd_link to call SMB_VFS_LINKAT().
Use conn->cwd_fsp as current src and dst fsp's.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ea637f002d0b0e30c29814fc6d8c137103deaa23">ea637f00</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Make hardlink_internals() call SMB_VFS_LINKAT() instead of SMB_VFS_LINK()
Use conn->cwd_fsp as current src and dst fsp's.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/45851ead18ab687218648237e8651887e4d809fa">45851ead</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_cap. Remove link_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/228423811c97d4ee99df924699ae4c003df3e2f9">22842381</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph. Remove link_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f9c3b0b3cf43ee08abd001f48307dbb7a332870f">f9c3b0b3</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots. Remove link_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/751852ced401fa1b3a6fe6c30bc89a23c342def0">751852ce</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_glusterfs. Remove link_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/38da902351b933bb6bb99e724e2f49987a8770d8">38da9023</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_media_harmony. Remove link_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a5911429560fad0585bdc5b9084ad77070abbf96">a5911429</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_shadow_copy2. Remove link_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3c3e62b79ee791209d3696d1d84641e6f3f99981">3c3e62b7</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper. Remove link_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/295aa5bd24ac113913e0ec9f22c59c8f56ba3ddc">295aa5bd</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_syncops. Remove link_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d31d52f16d1554c6fb2f9426a39461206d8eb53d">d31d52f1</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_unityed_media. Remove link_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1b2440107f5e987cf6ffe2806d6516547b593fd8">1b244010</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit. Remove link_fn(). No longer used.
NB, this will now fail smb_vfs_assert_all_fns()
until we remove the rename_fn() from the VFS definitions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fb75a3d5e98e2ae3210f4fc68f0fabbc27f09c18">fb75a3d5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T21:09:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_time_audit. Remove link_fn(). No longer used.
NB, this will now fail smb_vfs_assert_all_fns()
until we remove the rename_fn() from the VFS definitions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f42642e54e560f8a6328cbc035b0bbcfdffcf728">f42642e5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-20T22:26:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Complete the replacement of SMB_VFS_LINK() -> SMB_VFS_LINKAT().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Aug 20 22:26:17 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/616646a0c4c5709ab334a11907642e710f912697">616646a0</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-21T07:20:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: ASAN fix for test_realloc_on_destructor_parent
Direct leak of 96 byte(s) in 1 object(s) allocated from:
#0 0x7fd52c00dc08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
#1 0x7fd52befec45 in __talloc_with_prefix ../../talloc.c:782
#2 0x7fd52befec45 in __talloc ../../talloc.c:824
#3 0x7fd52befec45 in _talloc_named_const ../../talloc.c:981
#4 0x7fd52befec45 in talloc_named_const ../../talloc.c:1748
#5 0x4099bd in test_realloc_on_destructor_parent ../../testsuite.c:1000
#6 0x4099bd in torture_local_talloc ../../testsuite.c:2129
#7 0x402603 in main ../../testsuite_main.c:32
#8 0x7fd52bcb8412 in __libc_start_main (/lib64/libc.so.6+0x24412)
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/878e804df6377ffa120ae62b9abb182c957c10a6">878e804d</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-21T07:20:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: ASAN fix for test_talloc_free_in_destructor
Indirect leak of 104 byte(s) in 1 object(s) allocated from:
#0 0x7f06393dfc08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
#1 0x7f06392d0c45 in __talloc_with_prefix ../../talloc.c:782
#2 0x7f06392d0c45 in __talloc ../../talloc.c:824
#3 0x7f06392d0c45 in _talloc_named_const ../../talloc.c:981
#4 0x7f06392d0c45 in talloc_named_const ../../talloc.c:1748
#5 0x409edd in test_talloc_free_in_destructor ../../testsuite.c:1256
#6 0x409edd in torture_local_talloc ../../testsuite.c:2138
#7 0x402603 in main ../../testsuite_main.c:32
#8 0x7f063908a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6c3e8a0a9f0636467af5678c04d5aecc9c3dbf7a">6c3e8a0a</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-21T07:20:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: ASAN fix for test_pool_nest
Direct leak of 96 byte(s) in 1 object(s) allocated from:
#0 0x7f06393dfc08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
#1 0x7f06392d0c45 in __talloc_with_prefix ../../talloc.c:782
#2 0x7f06392d0c45 in __talloc ../../talloc.c:824
#3 0x7f06392d0c45 in _talloc_named_const ../../talloc.c:981
#4 0x7f06392d0c45 in talloc_named_const ../../talloc.c:1748
#5 0x40901e in test_pool_nest ../../testsuite.c:1451
#6 0x40901e in torture_local_talloc ../../testsuite.c:2096
#7 0x402603 in main ../../testsuite_main.c:32
#8 0x7f063908a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d0933ec62c113a6da5209a556fad8819febe4ec2">d0933ec6</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-21T07:20:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: ASAN fix for test_rusty
Direct leak of 100 byte(s) in 1 object(s) allocated from:
#0 0x7f06393dfc08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
#1 0x7f06392d1af3 in __talloc_with_prefix ../../talloc.c:782
#2 0x7f06392d1af3 in __talloc ../../talloc.c:824
#3 0x7f06392d1af3 in __talloc_strlendup ../../talloc.c:2455
#4 0x7f06392d1af3 in talloc_strdup ../../talloc.c:2471
#5 0x40b4f0 in test_rusty ../../testsuite.c:1543
#6 0x40b4f0 in torture_local_talloc ../../testsuite.c:2146
#7 0x402603 in main ../../testsuite_main.c:32
#8 0x7f063908a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fc4ad5b6dfdcfb859f92dcca868a043e31a051b0">fc4ad5b6</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-21T07:20:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: ASAN fix for test_magic_protection
Direct leak of 1152 byte(s) in 1 object(s) allocated from:
#0 0x7f06393dfc08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
#1 0x7f06392cfd59 in __talloc_with_prefix ../../talloc.c:782
#2 0x7f06392cfd59 in _talloc_pool ../../talloc.c:837
#3 0x7f06392cfd59 in talloc_pool ../../talloc.c:859
#4 0x40b83c in test_magic_protection ../../testsuite.c:1960
#5 0x40b83c in torture_local_talloc ../../testsuite.c:2164
#6 0x402603 in main ../../testsuite_main.c:32
#7 0x7f063908a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1b599e5c0d076f49b8debc35f6888a7612d69599">1b599e5c</a></strong>
<div>
<span>by Marco Wang</span>
<i>at 2019-08-21T08:39:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: net: net_ads: fix a typo in comment
Signed-off-by: Marco Wang <m.aesophor@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Aug 21 08:39:43 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/feccdebe1532030e984e788a6a2c306c0f5c38c5">feccdebe</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:samdb: Add test_gnutls_value_decryption()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/92b9cdf99da1f8657c166d413c5136c8db938a9e">92b9cdf9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-21T09:57:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">encrypted_secrets: Add known and expected value test
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7bf3c5d7640daaf5dc799eaf698618903ec09127">7bf3c5d7</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:samdb: Remove dual-stack mode from (test_)encrypted_secrets
Now we either build with GnuTLS or Samba crypto. If a modern GnuTLS
version is detected that will be used and Samba crypto wont be
available.
This removes the dual-stack mode that encrypted with one and decrypted
with the other in the testsuite.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Commit message clarified by Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d46e538d52433f5f30a5696e5b18bc4b82101951">d46e538d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:samdb: Only include necessary header files in encrypted_secrets
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/20a42459df4fdd57cdf1807a3d97dc5b1c553476">20a42459</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: Check for GNUTLS AES CFB support
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cd97c47873007bfc502926070a758b520d95abf1">cd97c478</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Use netlogon_creds_aes_encrypt() in netlogon_creds_step_crypt()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/054efd118d7500e28f118722312aaae0df2749b0">054efd11</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Use GnuTLS AES128 CFB for netlogon_creds_aes_encrypt()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ded5aad21b54b8783f7390fb2eca483d3861eeff">ded5aad2</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Return NTSTATUS for netlogon_creds_aes_encrypt()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Adapted by Andrew Bartlett to use gnutls_error_to_ntstatus()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a96728586150768957b88a0714b15f13ee9f81af">a9672858</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Use GnuTLS AES128 CFB for netlogon_creds_aes_decrypt()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8ec796f1a1daa444bba06f34a50d2b62ee4a2ef9">8ec796f1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-21T09:57:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth Return NTSTATUS from netlogon_creds_aes_decrypt()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5ae119e7e9ddcfb3473e14585ba6079147a307bd">5ae119e7</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-21T09:57:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">crypto: Update REQUIREMENTS file with new minimum version
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d515b255aa67186ff375af0b465c49722eb56427">d515b255</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-21T09:57:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth Check NTSTATUS from netlogon_creds_aes_{en,de}crypt()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2f827bec8ca831fb486c8ebedc6b89b7f1cb99e2">2f827bec</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-21T09:57:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-rpc_server: Check NTSTATUS return value from netlogon_creds_aes_decrypt()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1e427f55d71350b25a8a26e94a5cb7895d8efdf6">1e427f55</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-21T09:57:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-rpc_server: Check NTSTATUS return value from netlogon_creds_aes_decrypt()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1aa249e7f4a1c4222b4cc79bac64c8b95c89d868">1aa249e7</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-21T09:57:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-librpc: Remove unused init_netr_CryptPassword()
Unused since 38d4dba37406515181e4d6f1a1faffc18e652e27 in 2013
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fefd95091cc52f5e2655fa392312a8b1fa1d35fd">fefd9509</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-21T09:57:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/credentials: Check NTSTATUS return from netlogon_creds_aes_encrypt()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/58c781dc93e24895b2c4b97fa311c66af30e278e">58c781dc</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth:gensec: Use GnuTLS AES128 CFB8 in netsec_do_seq_num()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3b27fd8a490f29cbc94b8ac377b3a2cb6db7598c">3b27fd8a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-21T09:57:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/gensec: Use gnutls_error_to_ntstatus() consistently in schannel
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/025f6a135f930264ddcf1cd1b9e1004464618194">025f6a13</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth:gensec: Use GnuTLS AES CFB8 in netsec_do_seal()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fa8eddc39b4ea9d316201019b603025df5c2fa5e">fa8eddc3</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-21T09:57:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/gensec: Use gnutls_error_to_ntstatus() in netsec_do_seal()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1f6104f09a30cf3816fd5a580ce1b4be5b94848c">1f6104f0</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:crypto: Prepare not to build AES or AES-CMAC if we use GnuTLS support it
Samba will soon require GnuTLS >= 3.4.7.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Adjusted by Andrew Bartlett from an earlier more comprehensive patch by Andreas
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/974cebdf953259f41ecfc7375bc31d72af53f51e">974cebdf</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-21T09:57:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Set minimum GnuTLS version at 3.4.7
This will soon be required for encrypted_secrets in the AD DC, the BackupKey server
and SMB2 as we remove use of the internal AES code.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/52b91cb33c281aeecc6270824cadac6cefbcb136">52b91cb3</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-21T09:57:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-rpc_server: Remove Heimdal-based BackupKey server
We rely on a modern GnuTLS now.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2d54559aad9af81cf21d223dad28b48184c59f44">2d54559a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-21T09:57:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-rpc_server/backupkey: consistently check error codes from GnuTLS
This uses the new gnutls_error_to_werror()
This should resolve Coverity 1452111 as forwarded by Volker.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e9859ad356b42f39585dcef1a38def97a50a3744">e9859ad3</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-21T09:57:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/crypto: Remove unused RC4 code from Samba
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/85a1c4973921fdf9412ec56a3ed6a77f3ab84116">85a1c497</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-21T09:57:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-samdb: Remove duplicate encrypted_secrets code using internal Samba AES
We now rely on GnuTLS 3.4.7 or later.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/068da56a20a2712e498fb3724407836bda2f977b">068da56a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-21T09:57:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Remove explicit check for HAVE_GNUTLS_AEAD as we require GnuTLS 3.4.7
We strictly require it and if this were to fail we would want the compile to fail.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/43a941f51b2954ffa1a7ab8a9d5c4a18e654b9f6">43a941f5</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Define SMB2_AES_128_CCM_NONCE_SIZE
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1b384f378c95f550718ac697271327442e3d09dd">1b384f37</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Use GnuTLS for AES constants
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Adapted to remove Samba AES support
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/37dc63e8afab8e1f88dc8a4b77c6ef3337933eb1">37dc63e8</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Add gnutls_aead_cipher_hd_t to smb2_signing_key structure
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Adapted to remove Samba AES support
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/48116a30d51d9bac6201a8b94262aa78b451ad63">48116a30</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Use a smb2_signing_key for storing the encryption key
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/87832f6140aa5afb42983a1291ba6faa250c7ea3">87832f61</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Use a smb2_signing_key for storing the decryption key
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/95e1c85a47e925fdb9105b85f0e1dbea1ff09950">95e1c85a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Use smb2_signing_key structure for the encryption key
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b51c4293f7430b5ce6a81599fb0c7be5dc444c46">b51c4293</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Use smb2_signing_key structure for the decryption key
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/33bca1fb8087f7392a8ff0d295a5bdc01f1012e7">33bca1fb</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Use GnuTLS for AES constants
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Adapted to remove Samba AES
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/69be6b8416198cfa8e2404a0a62ce6432425adef">69be6b84</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: Check for AES128 CMAC support in GnuTLS
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ee11e3ffd8d801cb5988bb73dbccd1e2f0cbe7b0">ee11e3ff</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Use GnuTLS AES128 CMAC in smb2_signing_sign_pdu()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Adapted by Andrew Bartlett to followup from earlier patch to
allow compile without GnuTLS over the whole series.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9d8ffc81a53b6b3d7c29f0da8fd71e696ca7e9d8">9d8ffc81</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-21T09:57:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/smb: Use gnutls_error_to_ntstatus() in smb2_signing_sign_pdu()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1490f9260060104b31beefac9e61addd36b1919a">1490f926</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T09:57:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Use GnuTLS AES128 CMAC in smb2_signing_check_pdu()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/70ff03ecb6826525727d87ef8807428f91f4e506">70ff03ec</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-21T09:57:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/smb: Use gnutls_error_to_ntstatus() in smb2_signing_check_pdu()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c3f969817553dc9c9db88741bad51100b4d24604">c3f96981</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-21T11:14:11+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:crypto: Do not build AES-CMAC if we use GnuTLS that supports it
This requires GnuTLS >= 3.6.5.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Aug 21 11:14:11 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/52227d19735a3305ad633672c70385f443f222f0">52227d19</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-21T11:50:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Reformat node_has_status()
Re-indent and drop non-POSIX left-parenthesis from case labels.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9b09a87326af28877301ad27bcec5bb13744e2b6">9b09a873</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-21T11:50:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop unused node statuses frozen/unfrozen
Silently drop unused local variable mpat.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bb59073515ee5f7886b5d9a20d7b2805857c2708">bb590735</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-21T11:50:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Inline handling of recovered and notlmaster statuses
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bff1a3a548a2cace997b767d78bb824438664cb7">bff1a3a5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-21T11:50:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Handle special cases first and return
All the other cases involve matching bits.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/53daeb2f878af1634a26e05cb86d87e2faf20173">53daeb2f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-21T11:50:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Don't retrieve the VNN map from target node for notlmaster
Use the VNN map from the node running node_has_status().
This means that
wait_until_node_has_status 1 notlmaster 10 0
will run "ctdb status" on node 0 and check (for up to 10 seconds) if
node 1 is in the VNN map.
If the LMASTER capability has been dropped on node 1 then the above
will wait for the VNN map to be updated on node 0. This will happen
as part of the recovery that is triggered by the change of LMASTER
capability. The next command will then only be able to attach to
$TESTDB after the recovery is complete thus guaranteeing a sane state
for the test to continue.
This stops simple/79_volatile_db_traverse.sh from going into recovery
during the traverse or at some other inconvenient time.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5d655ac6f2ff82f8f1c89b06870d600a1a3c7a8a">5d655ac6</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-21T11:50:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Only check for LMASTER nodes in the VNN map
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ca4df06080709adf0cbebc95b0a70b4090dad5ba">ca4df060</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-21T11:50:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Strengthen volatile DB traverse test
Check the record count more often, from multiple nodes. Add a case
with multiple records.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/45b9e02f8f67cba9885e95a0c0af73373d39bafd">45b9e02f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-21T11:50:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Wait for child process when killing cluster mutex helper
The following test sometimes fails:
==================================================
Running "cluster_mutex_test lock-unlock-lock-unlock ./tests/var/cluster_mutex.lockfile"
--------------------------------------------------
Output (Exit status: 134):
--------------------------------------------------
LOCK
UNLOCK
CONTENTION
NOLOCK
cluster_mutex_test: ../../tests/src/cluster_mutex_test.c:307: test_lock_unlock_lock_unlock: Assertion `dl2->mh != NULL' failed.
--------------------------------------------------
Required output (Exit status: 0):
--------------------------------------------------
LOCK
UNLOCK
LOCK
UNLOCK
FAILED
==========================================================================
TEST FAILED: tests/cunit/cluster_mutex_001.sh (status 1) (duration: 0s)
==========================================================================
This is due to a race in the test. For the first UNLOCK a signal is
sent to the cluster mutex handler but the test tries to retake the
lock before that process is scheduled and the signal is processed.
Therefore, the fcntl() lock is still held and contention is seen.
After unlocking, tests need to wait until the child has gone, so build
this into ctdb_kill(). This is one of the only places where the PID
is accessible.
Outside of testing, on a real system, nothing will never try
to (re)take the lock so quickly.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/71ad473ba805abe23bbe6c1a1290612e448e73f3">71ad473b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-21T13:06:57+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Clear deleted record via recovery instead of vacuuming
This test has been flapping because sometimes the record is not
vacuumed within the expected time period, perhaps even because the
check for the record can interfere with vacuuming. However, instead
of waiting for vacuuming the record can be cleared by doing a
recovery. This should be much more reliable.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
RN: Fix flapping CTDB tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Wed Aug 21 13:06:57 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a7e7a62f7d3697660ba3575b94276e3a0489b57b">a7e7a62f</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-21T15:42:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: fix mem leak found by ASAN (smb2_connect)
Direct leak of 96 byte(s) in 1 object(s) allocated from:
#0 0x7f0b16624c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
#1 0x7f0b15e4ba5c in __talloc_with_prefix ../../lib/talloc/talloc.c:782
#2 0x7f0b15e4ba5c in __talloc ../../lib/talloc/talloc.c:824
#3 0x7f0b15e4ba5c in _talloc_named_const ../../lib/talloc/talloc.c:981
#4 0x7f0b15e4ba5c in talloc_named_const ../../lib/talloc/talloc.c:1748
#5 0x55ffdd30d591 in torture_smb2_connect ../../source4/torture/smb2/connect.c:199
#6 0x7f0b12723772 in wrap_simple_test ../../lib/torture/torture.c:633
#7 0x7f0b1272775e in internal_torture_run_test ../../lib/torture/torture.c:442
#8 0x7f0b12728543 in torture_run_tcase_restricted ../../lib/torture/torture.c:507
#9 0x7f0b12728dd5 in torture_run_suite_restricted ../../lib/torture/torture.c:357
#10 0x7f0b12729434 in torture_run_suite ../../lib/torture/torture.c:339
#11 0x55ffdd10c54a in run_matching ../../source4/torture/smbtorture.c:93
#12 0x55ffdd10df56 in torture_run_named_tests ../../source4/torture/smbtorture.c:143
#13 0x55ffdd11199d in main ../../source4/torture/smbtorture.c:691
#14 0x7f0b0aa45412 in __libc_start_main (/lib64/libc.so.6+0x24412)
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Aug 21 15:42:43 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/968f72041021ccc0301220833f987dad8e3b9364">968f7204</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-22T00:21:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: free popt context in utils
If done with popt context it should be free'd.
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/355c9f5aca2af8db793bc3e695dc9b0d37e86483">355c9f5a</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-22T00:21:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpcclient: free popt context when done
If done with popt context it should be free'd.
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/42123c11c4f279045189226d0a24aaa3eea5695c">42123c11</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-22T00:21:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: free popt context in torture
If done with popt context it should be free'd.
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/72d3604a9c4ee4325fef9b3a160445dc961c863e">72d3604a</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-22T00:21:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: free popt context in client
If done with popt context it should be free'd.
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/24aa50170bb7824c753e6b56c112cec3db02d8af">24aa5017</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-22T00:21:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: free popt context in utils
If done with popt context it should be free'd.
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5e1c7c084c85ea51f6843b95defee12ba6a8f0a0">5e1c7c08</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-22T00:21:51+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: free popt context in dnsserver
If done with popt context it should be free'd.
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a7383889282d3b92a9c2eaded85a5ba20e828134">a7383889</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-22T01:41:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: free popt context in texpect
If done with popt context it should be free'd.
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Aug 22 01:41:37 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/436423162592a684d52634e6db05f20bce6a5362">43642316</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-08-22T12:28:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: use os.urandom, which is available in python by definition
os.urandom also uses CSPRNG methods like getrandom() when the underlying OS
provides those.
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/39e06c49aebddaa208a149233cf35159588ebfdc">39e06c49</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-08-22T13:46:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml: fix problamatic quotes from panic action example
those quotes work for smbd but do not work for the samba binary. Without quotes
it works with both.
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Björn Jacke <bjacke@samba.org>
Autobuild-Date(master): Thu Aug 22 13:46:14 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ad24b7cf4dc61fd78de59539aef1ab73ff3b017d">ad24b7cf</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2019-08-22T17:41:20+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:net: load registry shares too in 'net vfs stream2adouble'
Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Ralph Böhme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Aug 22 17:41:20 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c68671bb949159de77170d8b73883171c50c9d96">c68671bb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Remove extraneous enum/struct values for removed SMB_VFS_OP_LINK.
Forgot this in removal of SMB_VFS_LINK() patch previously pushed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e4c4af64fa7fde3ff116390182628235a2fb7185">e4c4af64</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Add sys_mknodat() wrapper call.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e2246876d1ebdde2eaa2bd635e8907f1671b4159">e2246876</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Add SMB_VFS_MKNODAT().
Currently identical to SMB_VFS_MKNOD().
Next, add to all VFS modules that implement
mknod and eventually remove mknod.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8b27087d9cfbaf9e74538ed2d987531a7ae44d67">8b27087d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_cap. Implement mknodat().
Currently identical to mknod().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2aaadbdda12628258d6bd41b0277758d338cb6a2">2aaadbdd</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph. Implement mknodat().
Currently identical to mknod().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a1c06667d6e2653801a34aae6a5f2dd952a86ae2">a1c06667</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">3: VFS: vfs_ceph_snapshots. Implement mknodat().
Currently identical to mknod().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b32f345f14a79287280e877072da2a42c95ab24d">b32f345f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_glusterfs. Implement mknodat().
Currently identical to mknod().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/574d76c03f637df06918a56999945105c406900e">574d76c0</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_media_harmony. Implement mknodat().
Currently identical to mknod().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1aead2fe2516c237fb128ef03c4ad309c928f846">1aead2fe</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_shadow_copy2. Implement mknodat().
Currently identical to mknod().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4ce3cd31004f42296f7672301c4230842d483044">4ce3cd31</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper. Implement mknodat().
Currently identical to mknod().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a07ce6ead61b7fce545d151bb2ae34ccfda17bc5">a07ce6ea</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_syncops. Implement mknodat().
Currently identical to mknod().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5f115eca9261a568e0a65164af211c6be254e8b0">5f115eca</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_unityed_media. Implement mknodat().
Currently identical to mknod().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6db33e35a868511fc4f9c602978b71fc115aae0c">6db33e35</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit. Implement mknodat().
Currently identical to mknod().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a9099618eb68b0a23b1260902b5df87428201a91">a9099618</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_time_audit. Implement mknodat().
Currently identical to mknod().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/74127f5675381bdd8f77492321ee62080aa212de">74127f56</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Change cmd_mknod to call SMB_VFS_MKNODAT().
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7237517c8b46a578aa38da167e42b6619f3ae68c">7237517c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Make smb_unix_mknod() call SMB_VFS_MKNODAT() instead of SMB_VFS_MKNOD()
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0d606ef6c4ce5948424c779fe951f6cbc2cae021">0d606ef6</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_cap. Remove mknod_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0e701ce3152fb71bc0d7e3271602fef067be7bcd">0e701ce3</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph. Remove mknod_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c15c9eb31f239587f4b9cc44aa015709f572444a">c15c9eb3</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots. Remove mknod_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/50880f3d4a34354f0dca7b01e35cdc187b0975f0">50880f3d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_glusterfs. Remove mknod_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/331cfa1100cc5edfba7f00ba7876a2319d048f5a">331cfa11</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_media_harmony. Remove mknod_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b3fa9ccfdd4aacf13690060c5efbd606d26730f5">b3fa9ccf</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_shadow_copy2. Remove mknod_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9ba187a5fc8d8e180245ee5741728322ff581103">9ba187a5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper. Remove mknod_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5132e78c95c8f81ffae55e348619f7ffe0e6698f">5132e78c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_syncops. Remove mknod_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/42d6d9cf4ee8a3422bda4d4b7164415ce5bd96b5">42d6d9cf</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_unityed_media. Remove mknod_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/569865d4a2143d07ef1afbb00df5289123257c35">569865d4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit. Remove mknod_fn(). No longer used.
NB, this will now fail smb_vfs_assert_all_fns()
until we remove the mknod_fn() from the VFS definitions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e37580f45a557ad9f23a7220bd8edae8e6ce7bd5">e37580f4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T18:00:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_time_audit. Remove mknod_fn(). No longer used.
NB, this will now fail smb_vfs_assert_all_fns()
until we remove the mknod_fn() from the VFS definitions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6a8bc6b549078a09276763f2196bf54c70d5de65">6a8bc6b5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-22T19:17:07+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Complete the replacement of SMB_VFS_MKNOD() -> SMB_VFS_MKNODAT().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Aug 22 19:17:07 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/561e0986ac96c842239b4e8c6509e05c836707b7">561e0986</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-22T20:07:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Deprecate "rndc command" for Samba 4.11
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14092
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b4816861f200bb292e26f51b15c1ce93fa9e16c6">b4816861</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-22T21:24:00+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-dns: Deprecate BIND9_FLATFILE and remove "rndc command"
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Aug 22 21:24:00 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d8863dd8cb74bb0534457ca930a71e77c367d994">d8863dd8</a></strong>
<div>
<span>by Poornima G</span>
<i>at 2019-08-23T18:40:08+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_glusterfs: Use pthreadpool for scheduling aio operations
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14098
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Aug 23 18:40:08 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/515c062b9e67a9f7016bcce3a02b75ab6d61385d">515c062b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Add SMB_VFS_READLINKAT().
Currently identical to SMB_VFS_READLINK().
Next, add to all VFS modules that implement
readlink and eventually remove readlink.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/885d804c91ada945cf4c7d721cf08f55952f6e0b">885d804c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_cap. Implement readlinkat().
Currently identical to readlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e386ddb6a7ab6f4e0dec3f7d44431e2cb8b136da">e386ddb6</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph. Implement readlinkat().
Currently identical to readlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b692b2916de1af02ee6f56c194a0436ec0fe01c0">b692b291</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots. Implement readlinkat().
Currently identical to readlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/de17e762eadc49f565d4495b716da9f0f9837cee">de17e762</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_expand_msdfs. Implement readlinkat().
Currently identical to readlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3bdb77ad790961f6f1df41a088e3b40b0b507e87">3bdb77ad</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit. Implement readlinkat().
Currently identical to readlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4874730c3052668a1bc8b8939ee557a77387f1f0">4874730c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_glusterfs. Implement readlinkat().
Currently identical to readlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/44c955a81ada0f513230653f35f0d6a0dd6d7404">44c955a8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_media_harmony. Implement readlinkat().
Currently identical to readlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/06609f3ada9a4c8fe830e8b01d4ada2dcc640523">06609f3a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_shadow_copy2. Implement readlinkat().
Currently identical to readlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eef38b05092771f496f6614456a797848da474aa">eef38b05</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper. Implement readlinkat().
Currently identical to readlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/854320cd5df93f430cf8a51b1924aa9cd2d5e135">854320cd</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_time_audit. Implement readlinkat().
Currently identical to readlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6f1c0d43177bb050042e808c6c2acc4e3bdddb78">6f1c0d43</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_unityed_media. Implement readlinkat().
Currently identical to readlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4684e2c9270291c664c83099104e5178203265ef">4684e2c9</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Change cmd_readlink to call SMB_VFS_READLINKAT().
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/654469740c7763c3c7a1ace6da0a68ea37682fa1">65446974</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change is_msdfs_link_internal() to call SMB_VFS_READLINKAT().
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/288fbe35993375bcfc5f0191185abf61621b06b9">288fbe35</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change smbd_do_qfilepathinfo(): case SMB_QUERY_FILE_UNIX_LINK: to call SMB_VFS_READLINKAT().
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/406bde26545ef3d86bf19319b60262ee2c13825b">406bde26</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change process_symlink_open() to call SMB_VFS_READLINKAT().
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9ffa8c846201fe8dc8a80c9a7dae90e6677188ee">9ffa8c84</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_cap. Remove readlink_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1d1cef7331ede3ffe4f06435e3100157449b2a5f">1d1cef73</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph. Remove readlink_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0f160428c4b8481196a08ef4d77519af90b99d27">0f160428</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots. Remove readlink_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5fe9845b313090aa4db8cc12f74a13af87dc92bb">5fe9845b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_expand_msdfs. Remove readlink_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f7f2572a23324fdcc6aa9209332a1af995421465">f7f2572a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_glusterfs. Remove readlink_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/65deb57c01d7649920654b7906c40d0a6c26ec40">65deb57c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_media_harmony. Remove readlink_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bc55a552b02d7659efcafd5672fd0fe5aa8dd912">bc55a552</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_shadow_copy2. Remove readlink_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/79ac8e9ecab7b9eeb07a58830cb3569faa41778b">79ac8e9e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper. Remove readlink_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/58bce531fbf2d1d52055520f86d3ac2eabdd1eb0">58bce531</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_unityed_media. Remove readlink_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/021da2f1522b373afeb20350ab2f86aae6f785e6">021da2f1</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit. Remove readlink_fn(). No longer used.
NB, this will now fail smb_vfs_assert_all_fns()
until we remove the mknod_fn() from the VFS definitions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5333ac35dde2b904ac520ac80eee54042c33b39f">5333ac35</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T18:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_time_audit. Remove readlink_fn(). No longer used.
NB, this will now fail smb_vfs_assert_all_fns()
until we remove the mknod_fn() from the VFS definitions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9b4685242fc7aeeae05d50566b428fc003848365">9b468524</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-08-23T20:06:22+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Complete the replacement of SMB_VFS_READLINK() -> SMB_VFS_READLINKAT().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Aug 23 20:06:22 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/767091535613720e1f2384003b363a58be0c5849">76709153</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-08-23T23:09:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: Remove wrong comment.
Commit e45d33e9 removed the sync fallback path for the case that no
thread could be created. Remove the comment for that fallback as it does
not make sense anymore.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Fri Aug 23 23:09:12 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/085e179dcb6a06f664d5447a2bee287f0a3698f4">085e179d</a></strong>
<div>
<span>by Swen Schillig</span>
<i>at 2019-08-26T10:19:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: fix mem leak in ltdb_fetch
Direct leak of 256 byte(s) in 8 object(s) allocated from:
#0 0x7f11b90d9c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
#1 0x7f11b8f395df in tdb_alloc_read ../../../lib/tdb/common/io.c:696
#2 0x7f11b8f290ee in _tdb_fetch ../../../lib/tdb/common/tdb.c:274
#3 0x7f11b8f29379 in tdb_fetch ../../../lib/tdb/common/tdb.c:283
#4 0x473ecc in ltdb_fetch ../../tests/src/fake_ctdbd.c:904
#5 0x478b40 in ltdb_transaction_update ../../tests/src/fake_ctdbd.c:993
#6 0x41fef2 in ctdb_rec_buffer_traverse ../../protocol/protocol_types.c:1656
#7 0x48108b in ltdb_transaction ../../tests/src/fake_ctdbd.c:1026
#8 0x48108b in control_trans3_commit ../../tests/src/fake_ctdbd.c:2878
#9 0x48108b in client_process_control ../../tests/src/fake_ctdbd.c:4147
#10 0x48108b in client_process_packet ../../tests/src/fake_ctdbd.c:3839
#11 0x4847f5 in client_read_handler ../../tests/src/fake_ctdbd.c:3806
#12 0x44f620 in comm_read_done ../../common/comm.c:208
#13 0x7f11b8f94fe8 in _tevent_req_notify_callback ../../../lib/tevent/tevent_req.c:141
#14 0x7f11b8f951fd in tevent_req_finish ../../../lib/tevent/tevent_req.c:193
#15 0x7f11b8f95265 in _tevent_req_done ../../../lib/tevent/tevent_req.c:199
#16 0x44e876 in pkt_read_handler ../../common/pkt_read.c:133
#17 0x44f315 in comm_fd_handler ../../common/comm.c:412
#18 0x7f11b8f92896 in tevent_common_invoke_fd_handler ../../../lib/tevent/tevent_fd.c:138
#19 0x7f11b8fa6937 in epoll_event_loop ../../../lib/tevent/tevent_epoll.c:736
#20 0x7f11b8fa6937 in epoll_event_loop_once ../../../lib/tevent/tevent_epoll.c:937
#21 0x7f11b8f9f53e in std_event_loop_once ../../../lib/tevent/tevent_standard.c:110
#22 0x7f11b8f90f34 in _tevent_loop_once ../../../lib/tevent/tevent.c:772
#23 0x7f11b8f955f1 in tevent_req_poll ../../../lib/tevent/tevent_req.c:300
#24 0x485a04 in start_server ../../tests/src/fake_ctdbd.c:4450
#25 0x485a04 in main ../../tests/src/fake_ctdbd.c:4544
#26 0x7f11b8c60412 in __libc_start_main (/lib64/libc.so.6+0x24412)
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Mon Aug 26 10:19:30 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/41aaeaf1fe921311f183d5c08ff121a9ccc4c5b4">41aaeaf1</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-08-26T23:59:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb tests: Fix ldb_lmdb_size_test
Fix the lmdb size test which ensures that databases > 4GiB can be
written by the lmdb backend. This test is not run as part of the normal
CI run as it exhausts the available disk on the test runners.
It was broken by changes to LDB allowing the lmdb map size to be
specified, and requiring GUID indexing by default.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b1eec5b196e3d5a5716a5c74cf669ceaa5c0301f">b1eec5b1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-26T23:59:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Correct Pigeonhole principle validation in ldb_filter_attrs()
Thankfully this only fails if the DB is corrupt and has a duplicate record.
The test was at the wrong end of the loop, and was for the
wrong boundary condition. A write after the end of the array would
occour before the condition was hit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13695
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2117789c35fbf6d0ed02f391f17593e11727ec3e">2117789c</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-26T23:59:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: use TALLOC_FREE() over talloc_free() in ldb_filter_attrs()
This is a macro that sets the pointer to NULL after the talloc_free()
and is part of our standard coding practices.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1521a22f4366c86ec955cb9d32b7a758315d8ce0">1521a22f</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-27T01:16:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Call TALLOC_FREE(filtered_msg->elements) on ldb_filter_attrs() failure
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Aug 27 01:16:33 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/54f30f2fe3f03c9640664f9a11260b093fc57a5b">54f30f2f</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-08-27T04:44:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: don't try to save a value that isn't there
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14049
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a097ddf65ce56dcd2e0b072b6dd78f512a77a9da">a097ddf6</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-08-27T04:44:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: add some dn explode tests
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14049
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3f290e95c2c133eb2c983ecc984d3dff4809f3d3">3f290e95</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-27T04:44:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Rework all pointer NULL tests to use Samba's normal style
Also avoid if () without braces
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14049
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/52bd2dde5ae809ecc115f7087e367327f4771e73">52bd2dde</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-27T04:44:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Add test with == true or false to boolean if statements in ldb_dn_explode()
This is beyond the normal level of clarity we expect in Samba, and is of course
rudundent, but this is a complex routine that has confusing tests, some of
pointers and some of boolean state values.
This tries to make the code as clear as possible pending a more comprehensive
rewrite.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14049
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a8a3cef3a768aaff01227dd7b229fb7b3aef926f">a8a3cef3</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-27T04:44:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Do not read beyond the end of the extended DN component when printing
The print functions used in Samba NULL terminate, but do not assume they will
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14049
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/10058bcfa16d5029e61252d64d142a8aab9ec296">10058bcf</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-27T04:44:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Extend the ldb_dn_explode test matrix
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14049
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f43da2adf64a8ff20ce6478f656927e531bc42af">f43da2ad</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-27T04:44:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Support GnuTLS AES CCM and GCM in smb2_signing_encrypt_pdu()
This requires GnuTLS >= 3.4.0.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Adapted to remove Samba AES support
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3d2de36d9a08354fb775a5d93a9b40012bf6966f">3d2de36d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-27T04:44:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Support GnuTLS AES CCM and GCM in smb2_signing_decrypt_pdu()
This requires GnuTLS >= 3.4.0.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Adapted to remove Samba AES support
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7f56e91dbe404bc1ee40e4843c4046336945b057">7f56e91d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-27T04:44:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Use smb2_signing_key in smb2_signing_decrypt_pdu()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Adaped to remove Samba AES support
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b9c4990f57aa778942c310b802437e6df1d17e04">b9c4990f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-27T04:44:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Use gnutls_error_to_ntstatus() in smb2_signing_decrypt_pdu()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eb65fe5505e32f451d4cf5d0203abce77c05dae4">eb65fe55</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-27T04:44:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Use smb2_signing_key in smb2_signing_encrypt_pdu()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Adaped to remove Samba AES support
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f24f26aaa58b9223e2c0cfd3e5086278b27903f1">f24f26aa</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-27T04:44:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Use gnutls_error_to_ntstatus() in smb2_signing_encrypt_pdu()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/454ed53221b1374ad8148e922b64c3788ad4998e">454ed532</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-27T04:44:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Prefer AES-GCM over AES-CCM with GnuTLS
The AES-GCM implementation in GnuTLS is faster.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Adapted to remove Samba AES support
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2ee1764ca88c882cddcc0a17f7d83950ec709b5d">2ee1764c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-08-27T04:44:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Prefer AES-GCM over AES-CCM with GnuTLS
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Adapted to remove Samba AES support
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b406b928242c95d34568a79c10e4b004779da085">b406b928</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-27T06:01:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Document new GnuTLS 3.4.7 requirement
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Aug 27 06:01:50 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8190993d99284162bd8699780248bb2edfec2673">8190993d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-08-27T15:29:11+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Fix typo in previous fix
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue Aug 27 15:29:11 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e06d34e98e1d01d04997c342255595ddf74fb388">e06d34e9</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-08-27T23:04:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'The left operand of '!=' is a garbage value'
Fixes:
source3/libsmb/clifile.c:789:15: warning: The left operand of '!=' is a garbage value <--[clang]
if (num_data != 100) {
~~~~~~~~ ^
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4bb9255473dae1e55b7711a9a2851533503ddb22">4bb92554</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-08-27T23:04:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'The left operand of '&' is a garbage value'
Fixes:
source3/libsmb/clifile.c:3108:26: warning: The left operand of '&' is a garbage value <--[clang]
(cr.file_attributes & FILE_ATTRIBUTE_DIRECTORY))
~~~~~~~~~~~~~~~~~~ ^
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ce9fef5fd5ea5475748e99ba1e72abcb557afd83">ce9fef5f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-08-27T23:04:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'Assigned value is garbage or undefined'
Fixes:
source3/libsmb/clifile.c:4898:10: warning: Assigned value is garbage or undefined <--[clang]
*bsize = (uint64_t)old_bsize;
^ ~~~~~~~~~~~~~~~~~~~
source3/libsmb/clifile.c:4901:10: warning: Assigned value is garbage or undefined <--[clang]
*total = (uint64_t)old_total;
^ ~~~~~~~~~~~~~~~~~~~
source3/libsmb/clifile.c:4904:10: warning: Assigned value is garbage or undefined <--[clang]
*avail = (uint64_t)old_avail;
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bf567380a7cc69bf4dc4cf7bad6bc774fcef6085">bf567380</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-08-27T23:04:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'Value stored to 'ea_size' is never read'
Fixes:
source3/libsmb/clifile.c:5290:2: warning: Value stored to 'ea_size' is never read <--[clang]
ea_size = (size_t)IVAL(rdata,0);
^ ~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e874cc909a7f12286ae2514ceb063193469a8946">e874cc90</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-08-27T23:04:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'Value stored to 'p' is never read' warning
Fixes:
source3/libsmb/clirap2.c:1197:4: warning: Value stored to 'p' is never read <--[clang]
p += rap_getstringp(frame,
^ ~~~~~~~~~~~~~~~~~~~~~
source3/libsmb/clirap2.c:1525:5: warning: Value stored to 'p' is never read <--[clang]
p += rap_getstring(frame,
^ ~~~~~~~~~~~~~~~~~~~~
source3/libsmb/clirap2.c:2358:3: warning: Value stored to 'p' is never read <--[clang]
p += WORDSIZE; /* skip rsize */
^ ~~~~~~~~
source3/libsmb/clirap2.c:2380:3: warning: Value stored to 'p' is never read <--[clang]
p += rap_getstringp(frame,
^ ~~~~~~~~~~~~~~~~~~~~~
4 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/78ca70925ca00ae96065db4fd7a963cb999f2f3d">78ca7092</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-08-27T23:04:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/auth: clang: Fix 'Value stored to 'status' is never read'
Fixes:
libcli/auth/netlogon_creds_cli.c:2622:2: warning: Value stored to 'status' is never read <--[clang]
status = netlogon_creds_decrypt_samlogon_validation(&state->tmp_creds,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e1ef99223684e830e4bd5c8e7b33323e25ffafc1">e1ef9922</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-08-27T23:04:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'The left operand of '>' or '<' is a garbage value
Fixes:
source3/libsmb/clireadwrite.c:601:15: warning: The left operand of '>' is a garbage value <--[clang]
if (received > expected) {
source3/libsmb/clireadwrite.c:799:16: warning: The left operand of '<' is a garbage value <--[clang]
if ((received < 0) || (received > state->buflen)) {
~~~~~~~~ ^
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fcb0355a74ea1c5e446c8465dd2fb017970d408e">fcb0355a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-08-27T23:04:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix '2nd func call argument is uninitalized value'
Fixes:
source3/libsmb/clireadwrite.c:805:2: warning: 2nd function call argument is an uninitialized value <--[clang]
memcpy(state->buf, buf, received);
^ ~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ad8fd31441f8012ae01e972d7faeba128507c5d1">ad8fd314</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-08-27T23:04:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'Assigned value is garbage or undefined'
Fixes:
source3/libsmb/clireadwrite.c:851:10: warning: Assigned value is garbage or undefined <--[clang]
*nread = ret;
^
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2575e4066bf84d7a56f0b7126841f4ea5cc027fd">2575e406</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-08-28T00:22:49+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'warning: Assigned value is garbage or undefined '
Fixes:
source3/libsmb/clireadwrite.c:1259:17: warning: Assigned value is garbage or undefined <--[clang]
state->written += written;
^ ~~~~~~~
source3/libsmb/clireadwrite.c:1722:14: warning: The left operand of '>' is a garbage value <--[clang]
if (written > expected) {
~~~~~~~ ^
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Wed Aug 28 00:22:49 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/61c5b891a14e47c784e0aae272630d78bf9c7831">61c5b891</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-08-28T01:47:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix value stored to 'offset' is never read
Fixes:
source3/libsmb/nmblib.c:479:2: warning: Value stored to 'offset' is never read <--[clang]
offset += 10+rec->rdlength;
^ ~~~~~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/52d20087f620704549f5a5cdcbec79cb08a36290">52d20087</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-08-28T01:47:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libads: clang: Fix Value stored to 'canon_princ' is never read
Fixes:
source3/libads/kerberos.c:192:2: warning: Value stored to 'canon_princ' is never read <--[clang]
canon_princ = me;
^ ~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2abe785264b105fc3a5b2ce6bd3df7d24fbdf360">2abe7852</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-08-28T01:47:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix: The right operand of '<' is a garbage value
Fixes:
source3/libsmb/namequery.c:977:12: warning: The right operand of '<' is a garbage value <--[clang]
for (i=0;i<count;i++) {
^~~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6ef4736c3f642d5b1625f6edb8b3cfdc6e7e3736">6ef4736c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-08-28T01:47:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix Value set during its initialization is never read
Fixes:
source3/libsmb/namequery.c:2584:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/32aa8f9195ce83073a04d24583de41ddbf4836c2">32aa8f91</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-08-28T01:47:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 2nd function call argument is an uninitialized value
source3/libsmb/namequery.c:2719:11: warning: 2nd function call argument is an uninitialized value <--[clang]
if (!convert_ss2service(return_iplist,
^
source3/libsmb/namequery.c:2733:10: warning: 2nd function call argument is an uninitialized value <--[clang]
if (!convert_ss2service(return_iplist,
^
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f8b5c47ad51f8ee727122964099b1b3dc36028d9">f8b5c47a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-08-28T01:47:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'warning: Value stored to 'status' is never read'
Fixes:
source3/libsmb/namequery.c:2938:2: warning: Value stored to 'status' is never read <--[clang]
status = NT_STATUS_OK;
^ ~~~~~~~~~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0c91634ebe4065bfb66c5cf575659aa1150fc2fb">0c91634e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-08-28T01:47:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'Value stored to 'status' is never read'
Fixes:
source3/libsmb/cliquota.c:340:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
/home/samba/samba/source3/libsmb/cliquota.c:357:4: warning: Value stored to 'status' is never read <--[clang]
status = NT_STATUS_OK;
^ ~~~~~~~~~~~~
2 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0be320393b85003f65d74e4e6a1b867a8d21eb1c">0be32039</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-08-28T03:06:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'Value stored during initialization is never read'
Fixes:
source3/libsmb/cliquota.c:340:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
source3/libsmb/cliquota.c:357:4: warning: Value stored to 'status' is never read <--[clang]
status = NT_STATUS_OK;
^ ~~~~~~~~~~~~
2 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Wed Aug 28 03:06:42 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b8f4be98f5d22eb034a953ebefab88752bf4a099">b8f4be98</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-08-29T15:53:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace/setxattr: set reasonable and unified errno value in case the EA value was too big
FreeBSD and AIX already set errno to ENAMETOOLONG, this is what we should map
other platforms also to to finally map to the correct NT error code also.
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/56e0ffa11319eebbe0d8b07502aa3ec8971435d0">56e0ffa1</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-08-29T15:53:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">xattr/setxattr: fix flag support on AIX
AIX requires the flags to be 0, we need to do those checks manually.
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3aea2c0f1f498fdb515cbd1d04b1ba3ce7f4cc3b">3aea2c0f</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-08-29T17:10:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace/setxattr: correctly use our flags on Darwin
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Björn Jacke <bjacke@samba.org>
Autobuild-Date(master): Thu Aug 29 17:10:32 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/961f07fb76287359e6a10263b1ea8035367e5375">961f07fb</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2019-08-30T07:08:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpc samr: EnumDomainUsers perf improvement
EnumDomainUsers currently takes too long, significantly slowing down
calls to winbind's getpwent which is a core unix API. The time is taken
up by a GUID lookup for every record in the cached result. The advantages
of this approach are:
1. It meets the specified requirement that if a record yet to be returned
by a search in progress (with a resume handle) is deleted or
modified, the future returned results correctly reflect the
new changes.
2. Memory footprint for a search in progress is only 16 bytes per record.
But, those benefits are not worth the significant performance hit
of the lookups, so this patch changes the function to run the search
and cache the RIDs and names of all records matching the search when
the request is made. This makes the memory footprint around 200 bytes
per record or up to 2MB per concurrent search for a 100k user database.
The speedup achieved by this change is around 50%, and in tandem with
some winbindd improvements as part of the same task has achieved around
15x speedup for getpwent.
The lost specification compliance is unlikely to cause a problem for any
known usage of this RPC call.
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b5b6b74b82631bf7eb09f955b7afb9c71d599522">b5b6b74b</a></strong>
<div>
<span>by Aaron Haslett</span>
<i>at 2019-08-30T08:26:21+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">paged results: tests without server_sort ctrl
On windows, adding or modifying a record during a paged results search
behaves differently depending on whether or not you supply server_sort
control. This patch adds tests and documentation.
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Aug 30 08:26:21 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5f70f972a5871d473f66d7c50ebb3181652b3cae">5f70f972</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-30T08:32:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Remove obsolete LDAP backend hooks from selftest.pl et al
This removes some quite complex logic that has not been used since the LDAP
backend project was shelved prior to 2011.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Nadezhda Ivanova <nivanova@symas.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4a2d3d8fd6318858260c3bc47443a6337da829ce">4a2d3d8f</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-30T08:32:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">sefltest: Remove tests for obsolete OpenLDAP backend
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Nadezhda Ivanova <nivanova@symas.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a4f0a6519cde558fdedb08fbb4742dbf57ee4283">a4f0a651</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-30T08:32:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool domain provision: Remove experimental OpenLDAP support
This feature has long been obsolete, remaining only in the hope
that it might be revived in the future.
Specifically, in 2011 the S4 OpenLDAP backend HOWTO was removed:
commit 1d46325af8541ea467c79cd86e65f93ce6a14ff4
Author: Andrew Bartlett <abartlet@samba.org>
Date: Wed Apr 27 22:42:29 2011 +1000
Remove outdated S4 OpenLDAP backend HOWTO.
There is a project to revive this, hosted here:
https://github.com/Symas/samba
and
https://github.com/Symas/samba_overlays
However discussions at SambaXP with Nadezhda Ivanova
indicate a new approach with slapd being started by Samba
and taught to read native Samba ldb files is more likely
in the short term.
This has the advantage that Samba's provision and offline
tooling would not need to change, with the solution looking
more like how BIND9_DLZ has access to the Samba DB.
If any of this is required then reverting these patches will be
the least of the difficulties in bringing this to production.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Nadezhda Ivanova <nivanova@symas.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6d1fe2841105b7ba3a1384ef6baef399f30800a6">6d1fe284</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-30T08:32:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Remove LDAP backend specific modules from extended_dn_out
This simplifies the code considerably. A real attempt at an LDAP backend would need to implement this
module in a similar way to LDB.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Nadezhda Ivanova <nivanova@symas.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3da41b51b00da97cfe63616d26555441f744ebf3">3da41b51</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-30T08:32:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Remove OpenLDAP backend complexity from partitions module
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Nadezhda Ivanova <nivanova@symas.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2b0fc74a0916a6ab0d5ac007cc5e100d4682b2ea">2b0fc74a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-08-30T09:50:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Remove OpenLDAP backend complexity from samba_dsdb module
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Nadezhda Ivanova <nivanova@symas.com>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Aug 30 09:50:25 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5fc2c7ddb815e753ce57dc050ccf8fad9151063d">5fc2c7dd</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/containter/container/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a1d839f7cea8a3960969df36e772276b01a1e3ac">a1d839f7</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/depencies/dependencies/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2bb4515aff3751d38fb706c6024e3bf1c044da48">2bb4515a</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/tempates/templates/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/781eaea07f1f073a324e44030f779df22679fb61">781eaea0</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/advertisment/advertisement/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fbecbe4d9b102d7cf28d61230a0bfbef3317c8f1">fbecbe4d</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/negotatie/negotiate/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7d1dc9716372b00794f3dcfe518f764636d9629a">7d1dc971</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/sepcific/specific/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/46687a507e8236b75fa2ebfd8389241e36e73a8c">46687a50</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/Unsuported/Unsupported/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8e727867217f797bec2c5f6618804abf0bcf4f2d">8e727867</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/integrety/integrity/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6b47c12549c71485d775a6d1b5a631ce79c8f278">6b47c125</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/autentication/authentication/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4449f5d1b8d42ea862f22a80ee7156e04cb95a00">4449f5d1</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/convertion/conversion/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eff558035b29784d4ccc1c30f8b62b675220e9d0">eff55803</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/exising/existing/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e19c3e0387cf9a2cde973c1df9daf7a1ba426921">e19c3e03</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/Mirgate/Migrate/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b694268ee1c6059850627b883d40e4362cc64ae6">b694268e</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/succedded/succeeded/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e8f8d2d214b6a248df580cd1930a429a3fb7fa38">e8f8d2d2</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/encrpted/encrypted/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a12d843b2c081969ed56f76a7b0f30acf9e4aa38">a12d843b</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/setted/set/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a59e0ec8955e51bb6d9ca62d2636388e417c1d45">a59e0ec8</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/hierachy/hierarchy/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8196b331f30851071fdec7a7ff47bff9697dd6a7">8196b331</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/exisiting/existing/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f2b30a3f6a929a56403ef95f0b0feb1d18a11c17">f2b30a3f</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/Therefor /Therefore /
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/54b6fa863128830fa5c87cd574976d941fa4358b">54b6fa86</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/emtpy/empty/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fbf94dba59696188c35ba16d9dc3b3839b1ebd6e">fbf94dba</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/BUITIN/BUILTIN/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cdc8c05ba51b6809c22b894af66af3c3c3fa43b5">cdc8c05b</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/serivce/service/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/de813400f3c01e21ad5266dcff905b6c4f020b76">de813400</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/DISLPAY/DISPLAY/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dbd6bef29e6bc505d3e95a100759aca40bdfe1e5">dbd6bef2</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/avaiable/available/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5d0c26fc6b527ce6c385c9f3a097e07378f1c559">5d0c26fc</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/nonexistant/nonexistent/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/49a6e109aae9f15069a0f59d9f75b5367f4192e0">49a6e109</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/componet/component/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/06e0f89345e09d2fb4bf0f028711e448bc181346">06e0f893</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/optinally/optionally/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a03bafbcd5b835aa248c01b4150750f8e50f43a9">a03bafbc</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/overriden/overridden/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0459a6db3319948a59c52669193b618f812d8bf0">0459a6db</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/didnt'/didn't/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c5e97f1aa15b11aa6becf168e3750b547e6eccfc">c5e97f1a</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/wont /won't /
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e6654b5f43f26a998a0a11893ed2cec842f26d16">e6654b5f</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/explicite /explicit /
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d9b50ce7df182e3ba8692b6d3edcd1b6489060c0">d9b50ce7</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/recieved/received/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/271b04aaae29be4a52d1c84f53190bec493f05a0">271b04aa</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/noone/no one/
Skipping source4/torture/winbind/struct_based.c
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/736bb924f7e70564df0b94db1deaf9e26f638109">736bb924</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/ ot / to /
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/619e8f46d8a92d2453e1f021a2a330ebbefc7025">619e8f46</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/ upto / up to /
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7cb0ca4171889d1fa4ffd99528b51cc9820f4dd9">7cb0ca41</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/ dont / don't /
Excluding examples/tridge/smb.conf
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0b8f428bf1f1241b7b60660b74060d73bea25475">0b8f428b</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/directores/directories/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/802443927ace02ae48a55247dd4de9905811cacd">80244392</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/filesytems/filesystems/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4973eb37602be39d9cb0a8a3842bec9c548f242d">4973eb37</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/explizitly/explicitly/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/244c05da2062fe27d4e39ccb1ae80b54c2c3d694">244c05da</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/simliar/similar/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/875962ed36688ea7d0749f941fcda6087c0e891a">875962ed</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/substitue/substitute/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/08cc61f9b68ff12d77b698103d2ce99f3d84f6fa">08cc61f9</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/accidentially/accidentally/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/995f0736c668513476ce0bdc1fd073c701dfe7d0">995f0736</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/rebuilded/rebuilt/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e7407c02e7724469e856629f02df2fb2bbe5579f">e7407c02</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/concatonated/concatenated/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eaa44d819d9ae6efcd5d1bc83880d101242e1c0b">eaa44d81</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/retreiving/retrieving/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5a400df01d741bddc84f03d0ad1bb241f413ac4a">5a400df0</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/priveliges/privileges/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/284eaa5728b690df0dcb068fc6b1e2c401d20c57">284eaa57</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/compatability/compatibility/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7c2ee8feab5c2e02a33d4ea4fcd7b861d6a1dbb3">7c2ee8fe</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/ingnored/ignored/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1a750eb1f7f2d5246e451d2162d8c52b6d4d5ad1">1a750eb1</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/staticly/statically/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d6525485df9c1e06206df2239d3069eb180c6768">d6525485</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/implentation/implementation/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b688926cd9e51a27b91ad5f9efe92af837e5e65c">b688926c</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/touble/trouble/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8b9319c455e5b90130ee05e67d5a902873f426c6">8b9319c4</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/whitch/which/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4b207f83653589d5b5b9b041e7202e47b7815ac5">4b207f83</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/suceeded/succeeded/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/105bb06318eecd416c8e78b5cbcd3936aa6ec8c8">105bb063</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/withing/within/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d605860cf40e8695a54436d768dacf345cd3552e">d605860c</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/valuie/value/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/549a4a82e0b918809e718ea966961f3332b6d5c5">549a4a82</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/preceeding/preceding/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2915188c953e050e12081a4c05eada1fc081feda">2915188c</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/intergration/integration/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f8f4ed7529e1ca8c9dd9994c7ba342f15994afbd">f8f4ed75</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/accomodations/accommodations/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a24de32556dddf6994c7c5c68d7794999a7fd4cb">a24de325</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/permited/permitted/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f61d72b303876dda8588ce2b27b22eb76bd09d07">f61d72b3</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/hightest/highest/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4012811a6d557644b207051ff73719305f83dcef">4012811a</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T22:21:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/varaible/variable/
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f2e37b84da64172a07bde33a81b6cd88501967da">f2e37b84</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-01T23:38:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Spelling fixes s/ querys / queries /
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun Sep 1 23:38:14 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cf3977585d095cac916b268629087570e0538130">cf397758</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-09-01T23:55:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Remove unused entryuuid and nsuniqueid modules
These were for the now removed OpenLDAP backend. Any future work in this area will
not involve this kind of translation, it will be done much more cleanly.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/af6799bf4f1509af19c74c300a0d4a889a69cbfe">af6799bf</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-09-01T23:55:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">util: Remove unused NS_GUID_string() and NS_GUID_from_string()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14063
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/72201055f53a9a59c90fa6fe94cbc7e968a2b35a">72201055</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-09-01T23:55:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Remove unused simple_dn module
This became unused with 2b0fc74a0916a6ab0d5ac007cc5e100d4682b2ea that
removed the last of the support for the LDAP Backend
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/29729818823161c08b09bcc8e43c3942a503b129">29729818</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-09-01T23:55:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Remove unused local_password module
This was an idea about how Samba might have worked if passwords were
not safe to be stored in a remote DB (get some kind of LDAP backend).
Nothing ever used this, but it was a nice idea. But git master is not
the place to preserve history, even interesting ideas like splitting
passwords from the non-password data (possible because, in the same way
we are allowed to encrypt them, we do not allow a search on password
values).
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b76bf7afd07924e65cccbee7614b462312d4437c">b76bf7af</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-09-02T01:14:05+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Raise minimum python version to 3.5.0 for Samba 4.12
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Sep 2 01:14:05 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dfa4dcf386febdf1b77ba963f11bcc2a44f8a738">dfa4dcf3</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2019-09-02T02:25:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: drop --with-libcephfs=<path> support
--with-libcephfs=<path> provides a mechanism for explicitly specifying
header and library paths for Ceph. This adds unnecessary complexity and
can be achieved using generic compiler environment variables (e.g.
GCC LIBRARY_PATH and C_INCLUDE_PATH), so drop --with-libcephfs support.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/16c3a00d2eb8471dfa4cf9ace003578331d2e1e0">16c3a00d</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2019-09-02T03:44:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: remove unneeded libceph-common dependency
librados and libcephfs are both dependent on ceph-common, but
ctdb_mutex_ceph_rados_helper and vfs_ceph needn't be explicitly linked
against it.
Signed-off-by: Björn Baumbach <bb@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Sep 2 03:44:24 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e48c11896904fd063619a95d3fa7ceccbf2beb56">e48c1189</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T08:07:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-10197: smbd: separate out impersonation debug info into a new function.
Will be called on elsewhere on successful impersonation.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6fae81312fad5caf948f0f0f48b84fd3f59dc944">6fae8131</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-03T08:07:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-10197: smbd: make sure that change_to_user_internal() always resets current_user.done_chdir
We should not leave current_user.done_chdir as true if we didn't call
chdir_current_service() with success.
This caused problems in when calling vfs_ChDir() in pop_conn_ctx() when
chdir_current_service() worked once on one share but later failed on another
share.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/509113fcffdd0f371f8b32efc900d2102ef0cef7">509113fc</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-03T08:07:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-10197: smbd: make sure we reset current_user.{need,done}_chdir in become_root()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d7ed819d9f83a89f436b13437a71c85335cdb5df">d7ed819d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-03T08:07:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-10197: selftest: make fsrvp_share its own independent subdirectory
The next patch will otherwise break the fsrvp related tests.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9ab5a51a6e770c8bd95ceca892808cf2cf670852">9ab5a51a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-03T08:07:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-10197: test_smbclient_s3.sh: add regression test for the no permission on share root problem
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/efd4832c2cfc4092bafb93dd4caf32d04488919f">efd4832c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-03T09:27:21+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-10197: smbd: split change_to_user_impersonate() out of change_to_user_internal()
This makes sure we always call chdir_current_service() even
when we still impersonated the user. Which is important
in order to run the SMB* request within the correct working directory
and only if the user has permissions to enter that directory.
It makes sure we always update conn->lastused_count
in chdir_current_service() for each request.
Note that vfs_ChDir() (called from chdir_current_service())
maintains its own cache and avoids calling SMB_VFS_CHDIR()
if possible.
It means we still avoid syscalls if we get a multiple requests
for the same session/tcon tuple.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Tue Sep 3 09:27:22 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4bca8e097f5a909c628daa4dbfa932ddc1725ebc">4bca8e09</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T16:15:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmbclient: Ensure SMBC_readdir_ctx() also updates the readdirplus pointers.
If we are returning file entries, we
have a duplicate list in dirplus.
Update dirplus_next also so readdir and
readdirplus are kept in sync.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14094
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3d82b7d11cd7b78adc6b3642e64e3a8f251de869">3d82b7d1</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T16:15:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmbclient: Ensure SMBC_readdirplus_ctx() also updates the readdir pointers.
If we are returning file entries, we
have a duplicate list in dir_list.
Update dir_next also so readdir and
readdirplus are kept in sync.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14094
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/754cec7756b2ddb1cfcc3984265f01cb366beb76">754cec77</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T16:15:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmbclient: Ensure SMBC_getdents_ctx() also updates the readdirplus pointers.
If we are returning file entries, we
have a duplicate list in dirplus.
Update dirplus_next also so readdir and
readdirplus are kept in sync.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14094
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0d9b1645499ce12a79a137d3482434aa5d2eb47c">0d9b1645</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T16:15:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmbclient: Fix smbc_lseekdir() to work with smbc_readdirplus().
If returning files the dir_list and the dirplus_list have exactly the same
entries, we just need to keep the next pointers in sync on seek.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14094
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3355601fe8541994cc41f5ed800aab9b6a2294f4">3355601f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T17:31:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/4: libsmbclient test. Test using smbc_telldir/smbc_lseekdir with smbc_readdir/smbc_readdirplus/smbc_getdents.
Ensure that for file access you can mix any of these
three access methods for directory entries and the
returned names/structs stay in sync across telldir/seekdir
changes.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14094
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Sep 3 17:31:29 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/42414b5bfc8f9e36d684b45997a5e9170b633220">42414b5b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Add SMB_VFS_SYMLINKAT().
Currently identical to SMB_VFS_SYMLINK().
Next, add to all VFS modules that implement
symlink and eventually remove symlink.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f935989f2d4a8ffe9df4fbdfbd9618eb89ab8ef2">f935989f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_cap. Implement symlinkat().
Currently identical to symlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4903c9fcfe6eff17134f8bdeeaadb499eca271c1">4903c9fc</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph. Implement symlinkat().
Currently identical to symlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5665a3845a74d72d374ddfc3bea37b9fc4586b15">5665a384</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots. Implement symlinkat().
Currently identical to symlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/29b691987909aa31e30b73c6dc352ea4df9b646f">29b69198</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit. Implement symlinkat().
Currently identical to symlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ff3af0fccc8013862d75220bd60aa08ffe913d2a">ff3af0fc</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_glusterfs. Implement symlinkat().
Currently identical to symlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2d50dfa52c8bac7f97eb95fef0a266e1fe9b1460">2d50dfa5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_media_harmony. Implement symlinkat().
Currently identical to symlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e033047559e77706401ef7c21f21187502d528b0">e0330475</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_shadow_copy2. Implement symlinkat().
Currently identical to symlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/787487ae3ee7adcd68931d5834dbfc5e3ba1dce3">787487ae</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper. Implement symlinkat().
Currently identical to symlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4f5de7061eb53a5115223ca26279b320a15591c8">4f5de706</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_syncops. Implement symlinkat().
Currently identical to symlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f6d63ff6446cd5423a61cb32204d4dc96a11ec34">f6d63ff6</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_time_audit. Implement symlinkat().
Currently identical to symlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8c851da40f0482efc59b2d0e7f44e9d2b98d3d5c">8c851da4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_unityed_media. Implement symlinkat().
Currently identical to symlink().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1354f2f5210879466c706b8b2fb902bcef32da1f">1354f2f5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Change cmd_symlink to call SMB_VFS_SYMLINKAT().
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/538f78f07b6788f82dc93e17b5e8358a674d48a9">538f78f0</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change smb_set_file_unix_link() to call SMB_VFS_SYMLINKAT().
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/daf78b0271aa1a4a3e21c077a9126aa3b6b7f859">daf78b02</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change create_msdfs_link() to call SMB_VFS_SYMLINKAT().
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d970556b682a5cb807b50ca83bb4ff1c36d2d423">d970556b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_cap. Remove symlink_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1ee61e214a5b886af04209563348104cfe5a08a9">1ee61e21</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph. Remove symlink_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/33c00a61d83a938463b801476d714d4eef576079">33c00a61</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots. Remove symlink_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cb3b0ee853af916a18848b6c666ce55f1f1b6ec7">cb3b0ee8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_glusterfs. Remove symlink_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9b3d3904c65b87746dda37dc73e2c30eb5ce30dd">9b3d3904</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_media_harmony. Remove symlink_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a521377e200d2813eab661be22f520e1cf7cb12b">a521377e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_shadow_copy2. Remove symlink_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d492f4d1031a046989d5e141a6f05ff76de6f151">d492f4d1</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper. Remove symlink_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8ef64494c6d779eac9a4441661ee56586d0d5764">8ef64494</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_syncops. Remove symlink_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a676e494cde2d533718836c4d443cfe0dd9f5aec">a676e494</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_unityed_media. Remove symlink_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2fa1cd37c20ab9415d65659d0dd6e4c95e0ecca2">2fa1cd37</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit. Remove symlink_fn(). No longer used.
NB, this will now fail smb_vfs_assert_all_fns()
until we remove the symlink_fn() from the VFS definitions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ea5a02e811060d674cb8603a30857161c00738df">ea5a02e8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T21:15:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_time_audit. Remove symlink_fn(). No longer used.
NB, this will now fail smb_vfs_assert_all_fns()
until we remove the symlink_fn() from the VFS definitions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c5ea3d045af491549346890929ac3dbbce952aeb">c5ea3d04</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-03T22:32:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Complete the replacement of SMB_VFS_SYMLINK() -> SMB_VFS_SYMLINKAT().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Sep 3 22:32:30 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/123267138e993c6a87990c0022e89f4970c0ac12">12326713</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-04T11:47:04+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: Release tevent 0.10.1
* Update waf to version 2.0.17 in order to
fix the build with python 3.8.
* Other minor build fixes.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Sep 4 11:47:04 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9173ae5f7f02d2f1675d505ee3da7e62cceeafd0">9173ae5f</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2019-09-04T14:20:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib/ctdbd_conn: assert hdr following read/recv
ctdb_pkt_recv_recv() and ctdb_read_packet() give us a non-null hdr on
success, so drop the error path check in favour of an assert.
This fixes a regression in 3913b9a4088b83d6ed7f94d136a26ecfa7e16b35,
where tevent_req_error() may be skipped in the ctdbd_parse_done()
ctdb_pkt_recv_recv() error path.
Reported-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Wed Sep 4 14:20:16 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ad4ef1657e9b2a088a3bfadcce196cfcceead1dc">ad4ef165</a></strong>
<div>
<span>by Evgeny Sinelnikov</span>
<i>at 2019-09-04T17:02:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:ldap: Fix join with don't exists machine account
Add check for requested replies of existing machine object during join
machine to domain. This solves regression fail during join with error:
"None of the information to be translated has been translated."
https://bugzilla.samba.org/show_bug.cgi?id=14007
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Wed Sep 4 17:02:37 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/09946c558fade9ea64f0ef2357bf865c6e1ec441">09946c55</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-04T17:03:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Fix CID 1453465: Null pointer dereferences (NULL_RETURNS)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3a0047eaf18a1dffdedfd6625aeac9f6d7255045">3a0047ea</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-04T17:03:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Fix CID 1453464: Error handling issues (CHECKED_RETURN)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e8ac8a357aec218807f1b750c004bc2f88aa4b08">e8ac8a35</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-04T17:03:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samr: Fix CID 1453463: Null pointer dereferences (NULL_RETURNS)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1e2d209494769cb23f10d3c8f8f294acdc9147f6">1e2d2094</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-04T18:20:22+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Fix the FreeBSD clang build
clang complained that "full_filename==NULL" is always false, because
it's a normal stack variable.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep 4 18:20:22 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8d0d99a4d78ba408bb45e2d693049025e60e277a">8d0d99a4</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-09-05T02:45:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Deprecate "encrypt passwords = no"
This feature is only available for SMB1 and we need to warn users that this
is going away soon, and allow the removal in a future release under our rules
for parameter deprecation.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1006f7abe8980d2c01c181db93225353ce494b3a">1006f7ab</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-09-05T04:04:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Deprecate "lanman auth = yes"
This feature is only available for SMB1 and we need to warn users that this
is going away soon, and allow the removal in a future release under our rules
for parameter deprecation.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Sep 5 04:04:18 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4a7fc97daff69b8cba9c4e2da6a8e1399d6b1107">4a7fc97d</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-09-06T09:52:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-eventscripts: Fix the regression in 01.reclock.script
Commit ea7708d8c7fa674111ccea58b3cd0757765c702a simplified
01.reclock.script and removed include of functions file which is
required for setting CTDB_HELPER_BINDIR and for die() function.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3bd68261eca398895c419284db6515fd6f393f0f">3bd68261</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-09-06T11:11:02+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-eventscripts: Remove non-posix -v option to mkdir
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Sep 6 11:11:02 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/560c3abf453597794e5ddf3782bc05d8ba4e5299">560c3abf</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2019-09-09T10:32:53+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbcontrol: avoid printing NULL help strings
Some smbcontrol commands leave the .help pointer NULL, resulting in the
following usage text:
disconnect-dc (null)
notify-cleanup (null)
...
msg-cleanup (null)
Improve this by printing an empty string instead.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon Sep 9 10:32:53 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bebee47e6386476e9948089484f89d213fcc2660">bebee47e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: make rpc.handles.random-assoc test more robust
We've seen failures like this:
RPC-HANDLE-RANDOM-ASSOC
connect samr pipe1
pipe1 uses assoc_group_id[0x00000001]
connect samr pipe2 with assoc_group_id[0xFFFFFFFF]- should fail
Failed to bind to uuid 12345778-1234-abcd-ef00-0123456789ac for
ncacn_np:localdc[\pipe\samr,bigendian,assoc_group_id=0xffffffff,
abstract_syntax=12345778-1234-abcd-ef00-0123456789ac/0x00000001] NT_STATUS_UNSUCCESSFUL
connect samr pipe3 with assoc_group_id[0x00000000]- should fail
UNEXPECTED(failure): samba4.rpc.handles on ncacn_np with bigendian.random-assoc(ad_dc_default)
REASON: Exception: Exception: ../../source4/torture/rpc/handles.c:546:
status was NT_STATUS_OK, expected NT_STATUS_UNSUCCESSFUL: opening samr pipe3
Prevent that it wraps to 0x00000000
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/28ac2cbaf92a8619f0380f024c5a220d9fdc4622">28ac2cba</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:blocking: call change_to_user_by_fsp() when dbwrap_watched_watch* finishes
This is not strictly required as fd-based calls are used,
but it's more consistent to call SMB_VFS_BRL_LOCK_WINDOWS()
in the same environment on retry.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8b565de1acb0fda121cb0bd4cff42d66ee027529">8b565de1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smb2_lock: call change_to_user_by_fsp() when dbwrap_watched_watch* finishes
This is not strictly required as fd-based calls are used,
but it's more consistent to call SMB_VFS_BRL_LOCK_WINDOWS()
in the same environment on retry.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0e5613e39d6c6bb892fed939c63b4f14b878803b">0e5613e3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:locking: add/split out byte_range_{valid,overlap}() helper functions
They implement the logic from [MS-FSA].
The following commits will use these functions in other locations.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bd8884e5722cbbb7783fb4ae53e4f35b31031b01">bd8884e5</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:locking: add share_mode_wakeup_waiters() helper function
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3b788d97f9995e24e4005567f90a925957fb1e00">3b788d97</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:blocking: remove unused timeval_brl_min()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e18c8ced8e7a872deb118191595425ef6b826bfa">e18c8ced</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:torture: fix the timeout alarm handling on LOCK9
smbXcli_conn_disconnect(alarm_cli->conn, NT_STATUS_OK)
means existing requests are not finished with an error,
but instead just keep dangling arround.
Pass NT_STATUS_LOCAL_DISCONNECT in order to fail the
cli_lock32() call after getting SIGALARM.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ac28eec3e4af710feab3be3d4b25bfbe38294431">ac28eec3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:torture: convert LOCK9 into LOCK9A and LOCK9B
LOCK9A is the original test (with a timeout of -1)
and LOCK9B is the same but with timeout of 10 seconds.
LOCK9B is needed to demonstrate a server bug in the next
commits.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2ec9e93a7aac2706b4a5931495d56a7b64f8d894">2ec9e93a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:blocking: demonstrate the posix lock retry fails
This is just a temporary commit that shows the bug and its
fix. It will be reverted once the problem is fixed.
The posix lock retry fails if the client specified timeout
is smaller than the hardcoded 1 second retry.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e79fcfaaf2ecfca6c3747f6fe4be51f332ebf10d">e79fcfaa</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:blocking: split smbd_smb1_do_locks_retry() into _try() and _retry()
This will make it possible to have just one caller to
smbd_do_locks_try() later and use smbd_smb1_do_locks_try()
from within smbd_smb1_do_locks_send().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Reviewed-by: Volker Lendecke <vl@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8fe708acb43ea36d0cbf398713b125daba180a2d">8fe708ac</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:blocking: move from 'timeout' to 'smbd_smb1_do_locks_state->timeout'
This will make it possible to just use smbd_smb1_do_locks_try()
in a later commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e8d719d31f885d7b6d5b317165f90ec40df169c9">e8d719d3</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:blocking: fix posix lock retry
We should evaluate the timeout condition after the very last
retry and not before.
Otherwise we'd fail to retry when waiting for posix locks.
The problem happens if the client provided timeout is smaller
than the 1 sec (for testing temporary 15 secs) retry.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/62ec58b06c38ee82bb3147c4d325413fd3a76499">62ec58b0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:blocking: Remove bug reproducer from a few commits ago
The problem is fixed, now we can revert the change that made it
easier to trigger.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/15765644d2590d6549f8fcc01c39c56387eed654">15765644</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:blocking: use dynamic posix lock wait intervals
We want to start with a short timeout (200ms) and
slow down to larger timeouts up to 2s for the default
value of "lock spin time".
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2a77025a1e16d897281e5840192c93fa03328681">2a77025a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/raw: assert to get LOCK_NOT_GRANTED in torture_samba3_posixtimedlock()
There should not be a different if the blocker is a posix process
instead of another smbd.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aba0ee46258f3dd910421facb742fce3318a6946">aba0ee46</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:blocking: maintain state->deny_status
For Windows locks we start with LOCK_NOT_GRANTED and use
FILE_LOCK_CONFLICT if we retried after a timeout.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ad98eec6090430ba5296a5111dde2e53b9cd217a">ad98eec6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:brlock: always return LOCK_NOT_GRANTED instead of FILE_LOCK_CONFLICT
Returning NT_STATUS_FILE_LOCK_CONFLICT is a SMB1 only detail
for delayed brlock requests, which is handled in
smbd_smb1_do_locks*().
The brlock layer should be consistent even for posix locks.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f13d13ae9da3072862a781bc926e7a06e8384337">f13d13ae</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smb2_lock: move from 'blocking' to 'state->blocking'
This will simplify the next commits.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d096742da1a045357f52ccd5b28d499c30e96152">d096742d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smb2_lock: split smbd_smb2_lock_retry() into _try() and _retry()
This makes it possible to reuse _try() in the _send() function in the
next commits.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/39d514cdc358f175d0968f4a78f8f2f05a6c1707">39d514cd</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smb2_lock: error out early in smbd_smb2_lock_send()
We no longer expect NT_STATUS_FILE_LOCK_CONFLICT from
the VFS layer and assert that in a future version.
This makes it easier to port the same logic to smbd_smb2_lock_try().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7f77e0b4e9878f1f3515206d052adc012e26aafb">7f77e0b4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smb2_lock: let smbd_smb2_lock_try() explicitly check for the retry condition
This makes it possible to reuse _try() in the _send() function in the
next commit.
We should not retry forever on a hard error.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/359e9992be713bbecfdb19998d69e1d3f020c5e9">359e9992</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smb2_lock: make use of smbd_smb2_lock_try() in smbd_smb2_lock_send()
We only need the logic to call smbd_do_locks_try() and a possible
retry once in smbd_smb2_lock_try().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7155d3a2c5d7237f00cccb1802c1341cf295864e">7155d3a2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/smb2: add smb2.samba3misc.localposixlock1
This demonstrates that the SMB2 code path doesn't do
any retry for local posix locks.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8decf41bbb8be2b4ac463eb6ace16a8628276ab5">8decf41b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smb2_lock: add retry for POSIX locks
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8a7039be530adcdda9e7e7621bdcf902f5ca1721">8a7039be</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/raw: improvements for multilock2
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/297763c6b618c07148d788b46218a0798225bf79">297763c6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/raw: add multilock3 test
This demonstrates that unrelated lock ranges
are not blocked by other blocked requests on the same
fsp.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d3e65ceb1ec25c7b62a7e908506126269011f30d">d3e65ceb</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/raw: add multilock4 test
This is similar to multilock3, but uses read-only
(LOCKING_ANDX_SHARED_LOCK) locks for the blocked
requests.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6d4296aca0c9a9287c0c78c8f8847a560bd2ea24">6d4296ac</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/raw: add multilock5 test
This is similar to multilock3, but uses a read-only
(LOCKING_ANDX_SHARED_LOCK) locks for the first lock
request.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d3bc0199697fd7d6e04479321ca644a227bc4ede">d3bc0199</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/raw: add multilock6 test
This is similar to multilock3, but uses a read-only
(LOCKING_ANDX_SHARED_LOCK) locks for the 2nd lock
request.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5a841a43f9c4f862e2d7235429363b3066cf5850">5a841a43</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:blocking: use timeval_expired(&state->endtime) to stop processing
This is less racy than timeval_elapsed() > 0
as the current time is already expired and timeout = 0
will always work correct.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8da7c10a58292022ee57406db9a365de9ffaf5cf">8da7c10a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:blocking: split out smbd_smb1_do_locks_setup_timeout()
This function can be called multiple times, but only
the first time will setup the endtime. And the
endtime is relative to the request time and not
the current time.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/997548a5f1a14d82f1e80cce6d9ee55e85b5107c">997548a5</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:blocking: do the timeout calculation before calling dbwrap_watched_watch_send()
This makes the next commits easier to understand.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/312327106271abafeb53e62dfb71a38bf93e2d41">31232710</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:blocking: fix the fsp->blocked_smb1_lock_reqs handling
A new request is first checks against all pending
requests before checking the already granted locks.
Before we retried the lock array of another request
(the first in the list), but then finished current request,
which is wrong.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6e30a89b3f00ad55391454fbaa1272074e1962f0">6e30a89b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:blocking: call smbd_smb1_do_locks_setup_timeout() also in smbd_smb1_do_locks_try()
This is a noop if smbd_smb1_do_locks_setup_timeout() was called before.
But it allows us to use smbd_smb1_do_locks_try() in
smbd_smb1_do_locks_send() in a following commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8975673e3c3f9f7dbdb7ba7562bb81a62cd24e2e">8975673e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:blocking: make use of smbd_smb1_do_locks_try() in smbd_smb1_do_locks_send()
We only need the logic to call smbd_smb1_do_locks_check() and a possible
retry once in smbd_smb1_do_locks_try().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7d1cd6f22e7e3d95aba04c45776057945c2a5e30">7d1cd6f2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:blocking: handle NT_STATUS_RETRY from the VFS backend
This allows the VFS backends to implement async byte
range locking.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7471b0f63276e707784c98b832992ff08b1898ef">7471b0f6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smb2_lock: handle NT_STATUS_RETRY from the VFS backend
This allows the VFS backends to implement async byte
range locking.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/66d92f37c3a643d97489a59bb6d1e75e91528c20">66d92f37</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:locking: add brl_req_guid() and brl_req_mem_ctx() helper functions
This allows the vfs backend to detect a retry and keep state between
the retries.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c2503a5c68e967054ab84ca0d8ce693200c2e002">c2503a5c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T14:23:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_delay_inject: add support for brl_[un]lock_windows()
This demonstrates the two ways to handle the retry:
- smb layer retry => plock->context.smblctx = UINT64_MAX
- vfs backend retry => plock->context.smblctx = 0
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2b43ce6704ecf035e6734337a2dea3458153a4b2">2b43ce67</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-09T15:42:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:selftest: add delay_inject:brl_lock_windows testing
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Sep 9 15:42:45 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f5a51061470dda55de04555f7e4dbd1058a1f3c4">f5a51061</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-09-09T21:13:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Create SECURITY.md
This file location is shown under "Security -> Policy" on GitHub
and helps ensure people with a need to report a security issue
find us the right way.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Sep 9 21:13:35 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c6b48490ac68f23c9f172bdfa91954a960928795">c6b48490</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-10T17:38:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: always add ';' after torture_assert()
The next commit will require this.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8270b8c0b2141e3db1cba16b72d152686efe824f">8270b8c0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-10T17:38:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/torture: protect torture_assert[_goto]() with a do { } while(0) block
This hopefully fixes a lot of coverity defects like:
Control flow issues (DEADCODE)
Execution cannot reach this statement: ";".
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/849e3842cd9a0000fb4393b6e770945b8d4d1dc2">849e3842</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-10T18:56:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/smb2: try to fix a RESOURCE_LEAK in smb2.samba3misc.localposixlock1
CID 1453656: (RESOURCE_LEAK)
Handle variable "fd" going out of scope leaks the handle.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Sep 10 18:56:45 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2ecab3c60abf9baa16a6a5e3eba0fc4720def840">2ecab3c6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-09-10T19:05:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: add a file-id related test
Note I'm using the share vfs_fruit_xattr because I need a share with both a
streams and a acl_* VFS object.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14121
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5403bb22e6cb39baf6dc1b91558744d41e9f6f64">5403bb22</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-09-10T19:05:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: add round_timespec_to_nttime()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14121
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/84abeaa60ffced276da2b28b8add6efaa6da5ca6">84abeaa6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-09-10T19:05:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: round itime to NTTIME resolution in make_file_id_from_itime()
The rounding is needed because when a file is created via eg an SMB2 CREATE
request, we need to calculate the correct File-ID for the QFID Create-Context or
for a subsequent GETINFO SMB request on the same file-handle.
Any later metadata request that received the File-ID will do so by going through
dos_mode() -> ... -> parse_dos_attribute_blob(), where the File-ID will be
calculated from the on-disk itime which has NTTIME resolution.
As long as that is the only available itime backend, I'm rounding itime inside
make_file_id_from_itime(), not in the callers.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14121
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3483b75fed8985bd2968bbf8c85985107115fba8">3483b75f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-09-10T19:05:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: ensure to update the File-ID in struct smb_filename
Initialize the File-ID in fsp->fsp_name->st, any subsequent metadata fetch on
this file-handle needs this, eg QFID SMB2 Create-Context or GETINFO SMB
requests.
It would be nice if SMB_VFS_SET_DOS_ATTRIBUTE() would do this, unfortunately it
gets a const struct smb_filename.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14121
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4e49999c97f53acc7006f1dc6b6812bb0e156db5">4e49999c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-09-10T19:05:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_catia: stat info may have been updated, make sure to return changes
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14121
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ac18730f10ce96a607a3a07e1360b522ebf72f38">ac18730f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-09-10T19:05:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: add update_stat_ex_from_saved_stat()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14121
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ab03394969f8a4c748aea7d0d8ed37f9ced6cc30">ab033949</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-09-10T19:05:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: replace fsp_stat() with vfs_stat_fsp()
Both functions do the same, they differ just in the type of the returned result.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14121
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e00e78cfeda99bd5374eff8fb4ba84873e4e46b7">e00e78cf</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-09-10T19:05:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:vfs: streamline vfs_stat_fsp()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14121
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/95655fe683d499d93f3844ed72ad332ef64adb96">95655fe6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-09-10T20:22:21+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: restore stat fields in vfs_stat_fsp()
This ensures we preserve btime, itime and File-ID.
As the Durable Handles code calls vfs_stat_fsp() in the DH disconnect function,
previously the btime was lost and NOT stored in the cookie. With this change the
cookie will store the correct btime (and iflags), which requires us to call
dos_mode() in the reconnect function to ensure we pass
vfs_default_durable_reconnect_check_stat().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14121
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Sep 10 20:22:21 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ba72d8231f836e364304996467f088e1ea8ca448">ba72d823</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Properly #ifdef __LIB_FILE_ID_H__
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/049b8833ae885412db3ce2d41c9e26134b4e7e7e">049b8833</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Add file_id_str_buf()
file_id_string() without talloc
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b09c216f5aeea3c41722b938213572012290a543">b09c216f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Use file_id_str_buf() in file_id_string()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5ca021bd85db7f645b963bbeb89cf6d09ed398f4">5ca021bd</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: Use file_id_str_buf() in xattr_tdb_getattr()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7e70701ab0fd7fa03e79fad62a1903d4037e9852">7e70701a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: Use file_id_str_buf() in xattr_tdb_setattr()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/49d18bbf29dd00414fcd52ddeed72809ba4e9002">49d18bbf</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in brl_get_locks()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/de8b93b47992dc37821aa2bd83b34ba374ff0139">de8b93b4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in brl_cleanup_disconnected()
Also avoid some casts and use DBG_ instead of DEBUG()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d9263473b07abe106f79edda8f880183881b4cff">d9263473</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in share_mode_str()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/feccf9bb4f50bd777b0ff64700272a3496c68576">feccf9bb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in set_sticky_write_time()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bf2bf5b1448be3c4c8c6492a036b46a5ccd55890">bf2bf5b1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbstatus: Use file_id_str_buf() in print_brl()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fd691fbc94cf8da744e70bca0165e6a8356cffc5">fd691fbc</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in defer_open()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c88cb0a13bf2bd6ec8d144c60991643b225746d3">c88cb0a1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in setup_poll_open()
While there, remove a pointless empty line
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2448060072e9f82fc6b0d48109d70e4e491650ca">24480600</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in close_remove_share_mode()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a9d09d4bddb2a66e146f8e157fda4d7dd160a8a4">a9d09d4b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix DBG typo in find_delete_on_close_token()
The routine isn't called find__delete_on_close_token. Also avoid
casts.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b86df6d0591d7d8f3c08d0fe0975839ba00c342c">b86df6d0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove an obsolete comment
At least as of 2ac9d0afa66 ctdb does not care about db prios anymore
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/92c2a723b278fb0338248bfb1fd1c1f4b90dce2b">92c2a723</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap: Initialize state in dbwrap_delete()
Probably not required, but looks safer and gives static checkers less
reason to complain about potentially uninitialized variable reads
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4204ed2b82fd8e9f6faf6e05a009d0ad7742c649">4204ed2b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use dbwrap_do_locked() in add_fd_to_close_entry()
Less explicit talloc. Right now dbwrap_rbt behind the scenes does a
dbwrap_fetch_locked(), but that will eventually change.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5427f73af58252f6aabb044dac267c799ec26eb6">5427f73a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use dbwrap_do_locked() in fd_close_posix()
We don't need to make a copy of the fd array
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/436be09cfc17bcd26ae438608749a1d47acc1954">436be09c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-10T23:14:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Do boolean short-circuiting
&= does bitwise AND, and does not do boolean short-circuiting if the
variable is already 0. As has_other_nonposix_opens() might have its
cost, this speeds up closing a handle.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bdda10875ed1a21a66829206c77a1ffd998c9569">bdda1087</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-09-11T00:33:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: skip write-time fetching for directories.
The whole logic only applies to files.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep 11 00:33:26 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0c0ca0dbd7a7a6512b37ca8a186d814eed47b373">0c0ca0db</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: profile: Remove syscall_symlink entry now syscall is no longer used.
Missed as part of the previous replacement of symlink -> symlinkat.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d9d704b01e21fbc6b05164a5d1fee772f1836fa9">d9d704b0</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: vfstest: Change from create_conn_struct_tos() -> create_conn_struct_tos_cwd().
This does a vfs_ChDir() to the share root (not changing the
directory) which correctly sets up the conn->cwd_fsp member
so any XXXAT() calls correctly work inside vfstest.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5e7828faf3b76c82781e8707d7d7ef990224bd7e">5e7828fa</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: pysmbd: Ensure conn->cwd_fsp member of created connections is initialized.
This is needed to correctly call the XXXAT() vfs calls.
We should probably just use create_conn_struct_tos_cwd() here
and pass $cwd instead of using create_conn_struct_tos() and
passing "/" as the share root. We wouldn't change the current
working directory and the created share root would be set to $cwd
but I'm not sure what effects this may have on users of pysmbd
in case any of them pass paths above the $cwd to these functions.
Less changes to just call vfs_ChDir(conn, &cwd) which doesn't
change the current directory and leaves the share root as "/".
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ca3bc7809949c593fd545047a898348d2f5c4da4">ca3bc780</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Add SMB_VFS_MKDIRAT().
Currently identical to SMB_VFS_MKDIR().
Next, add to all VFS modules that implement
mkdir and eventually remove mkdir.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6a24668f23d2b58bd5076e7349efaa84c7a17548">6a24668f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_audit. Implement mkdirat().
Currently identical to mkdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/84cb7db8b7a9658f668d933d54393efd69c3c41a">84cb7db8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_cap. Implement mkdirat().
Currently identical to mkdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/be61efc8bc4be9b6db2e08b1eed6e458fc6f612c">be61efc8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_catia. Implement mkdirat().
Currently identical to mkdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/808bc3979f5ababbdc1b85a9566af47c4febf480">808bc397</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph. Implement mkdirat().
Currently identical to mkdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0c5825debf5208c3629e55b9ec946ff3021fb1e6">0c5825de</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots. Implement mkdirat().
Currently identical to mkdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d5ac30233e36072a899463b18694a24872e865dc">d5ac3023</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_extd_audit. Implement mkdirat().
Currently identical to mkdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d444cd4e46b836ef643bff26d940a1c5b2f3be0d">d444cd4e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit. Implement mkdirat().
Currently identical to mkdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e55ee2968de3a3d1822062c11d53d383894b7c44">e55ee296</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_glusterfs. Implement mkdirat().
Currently identical to mkdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5dc885a742107a8bc73262af8e7da044feab3d3e">5dc885a7</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_xfs_sgid. Implement mkdirat().
Currently identical to mkdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0999e6865154c2fae67961c76acfb4ae6ab505d5">0999e686</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_media_harmony. Implement mkdirat().
Currently identical to mkdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1bcd799517c76f31c79006fc71ed99f258e19073">1bcd7995</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_shadow_copy2. Implement mkdirat().
Currently identical to mkdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/41f9c49eec2ed6a9a796064349d06c38bc1477fc">41f9c49e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper. Implement mkdirat().
Currently identical to mkdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ef5bb79677f4a2cca613478c5d4b006d64b67f1b">ef5bb796</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_syncops. Implement mkdirat().
Currently identical to mkdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b691df9c2f8a8158c0892c7461cf7ccdbe9ed1b1">b691df9c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_time_audit. Implement mkdirat().
Currently identical to mkdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/63132f8b0418c6d0ed7b664d865724d657b8606a">63132f8b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_unityed_media. Implement mkdirat().
Currently identical to mkdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a799866f2b4e7c38b09140af47ad165172aaf544">a799866f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_xattr_tdb. Implement mkdirat().
Currently identical to mkdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/91e24b04de059c9e3490904373f1e92db6896486">91e24b04</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Change cmd_mkdir to call SMB_VFS_MKDIRAT().
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/497c27a4694f9563145c4de90af753e747c5ad0c">497c27a4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_recycle: Change use of SMB_VFS_NEXT_MKDIR -> SMB_VFS_NEXT_MKDIRAT.
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ea93b756cb23e37d367a07480a50666633b21ef9">ea93b756</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_depot: Change use of SMB_VFS_NEXT_MKDIR -> SMB_VFS_NEXT_MKDIRAT.
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d2e62772d53c3e4bec730a9bad6808f008675cd0">d2e62772</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_virusfilter: Change use of SMB_VFS_NEXT_MKDIR -> SMB_VFS_NEXT_MKDIRAT.
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e4e819c08736d73c046a6fba7437edc690fc9698">e4e819c0</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: pysmbd: Change py_smbd_mkdir() to call SMB_VFS_MKDIRAT().
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/99e04578e35d630930e03ee1120b2a432a0edccd">99e04578</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change mkdir_internal() to call SMB_VFS_MKDIRAT().
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/71833b224595054ed0235a37f3d169c11f47c8bd">71833b22</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_audit. Remove mkdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/450d392551753b7a2d4b0972adea2388f60aa89a">450d3925</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_cap. Remove mkdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/33221ac5270641346fddd20e866b3df327823bd5">33221ac5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_catia. Remove mkdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/abbd55ff4cf47bbf3f48f34ed0738406ef419f81">abbd55ff</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph. Remove mkdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fa9f83d304bc9bce9c3eb04affbc19795aa70424">fa9f83d3</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots. Remove mkdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/79f4b1339af084d7ed2ca00de700d190e252413a">79f4b133</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_extd_audit. Remove mkdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6673d23b34a1dcfe1eef3f565e9b82a89087c52c">6673d23b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_glusterfs. Remove mkdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/88fa32fb6950d3f06658814d6d0420c120ec6272">88fa32fb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_linux_xfs_sgid. Remove mkdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c33eee0232f2ccc822dfb8da254e40c58afafdf0">c33eee02</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_media_harmony. Remove mkdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8470fe4ad0a606974636c009eaf194ccb0102fc3">8470fe4a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_shadow_copy2. Remove mkdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/12ab9553d4c66393c92c498a26436bc16f3f009b">12ab9553</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper. Remove mkdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0a8bd88189090f71fd10e87f53b3cdf83929d501">0a8bd881</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_syncops. Remove mkdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fcccf3ea96ed046d30fa771506ce1990757c01d0">fcccf3ea</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_unityed_media. Remove mkdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a6f238f6e7567fe62b4b6f883898201518ac84d8">a6f238f6</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_xattr_tdb. Remove mkdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d992708d3d51d86391f218ac72127fbc91d1971b">d992708d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit. Remove mkdir_fn(). No longer used.
NB, this will now fail smb_vfs_assert_all_fns()
until we remove the mkdir_fn() from the VFS definitions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2cd27f472463a9ff68d1c7ef84e6cc26998469d5">2cd27f47</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T18:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_time_audit. Remove mkdir_fn(). No longer used.
NB, this will now fail smb_vfs_assert_all_fns()
until we remove the mkdir_fn() from the VFS definitions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c7167e7a82974ee9a07448a1de61c523a58896c9">c7167e7a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-11T19:44:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Complete the replacement of SMB_VFS_MKDIR() -> SMB_VFS_MKDIRAT().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Sep 11 19:44:44 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/219a189c9993893149c9beef90a9d626ee0f3fa7">219a189c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-11T19:59:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Add "utok_string"
A terse, one-line unix token representation for debugging purposes
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ae3cfa5da9e86a4f379df7bba8e45ef31a28bc4d">ae3cfa5d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-11T19:59:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Enhance debugging if chdir fails
This helps admins to figure out which user has a problem
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Volker Lendecke <vl@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d836f4a7d6ffbd3719a8be8141b7a186648556dd">d836f4a7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-09-11T19:59:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: rename change_to_user() to change_to_user_and_service()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1f4ec34447704dc02f08fc4f53ca988571d4769c">1f4ec344</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-09-11T19:59:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: rename change_to_user_by_fsp() to change_to_user_and_service_by_fsp()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1d6fe10ec62d447b004c0e691deb0f970268bad9">1d6fe10e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-09-11T19:59:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: README.Coding fixes
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5a736db046d1922e2b7ad13baf38c42b46f2115d">5a736db0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-09-11T19:59:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: inline change_to_user_by_session()
Prepares for removing changing cwd from become_user*() in a subsequent commit.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b6cf33015de596cd4295d24da4cfcee6c437e3aa">b6cf3301</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-11T19:59:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: inline change_to_user_and_service() into become_user()
In the next commit we'll drop the _and_service() part.
Pair-Programmed-With: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/15699475d6031dd0ed5cd24e9915c574b35a233b">15699475</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-11T19:59:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove directory changing from become_user*()
This was the behavior in versions before 4.9 and
it is hopefully not required by current callers of
become_user*().
Pair-Programmed-With: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5da24aa18e9c0ff6f2852b5421945111ef5c6b2b">5da24aa1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-11T19:59:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: rename [un]become_user*() to [un]become_user_without_service*()
We should make the behavior change (that gives up some protection)
more obvious, by changing the function names.
At least some OEMs have patches relying on the 4.9/4.10 behaviour
and we want them to detect that they have to do more work when they
need to change directories.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e9256b306ecd4299aa96b27d81800382414572a9">e9256b30</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-11T19:59:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: inline change_to_user_internal() into change_to_user_and_service()
There was only one caller left.
Pair-Programmed-With: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/35cd91ee4d8fcd1034787882fb2e2e2ab9f8bd34">35cd91ee</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-11T21:16:57+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove unused current_user.{need,done}_chdir stacking
All become_*()/unbecome_*() functions don't alter the working
directory. Only change_to_user_and_service*() does.
Pair-Programmed-With: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep 11 21:16:57 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/156eb9120e66fe58328decb035a4d926396f6a59">156eb912</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2019-09-12T16:16:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: correctly cast printf() argument
In most cases sattrib is passed as a long int literal. Avoid
compile errors by casting the value passed to printf().
Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aa5b2333283871cc573b3013669c64c3edd3684c">aa5b2333</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2019-09-12T16:16:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: fix closure of test directory handle
Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b730f350c2209236641d0423d4d0c00d43a24929">b730f350</a></strong>
<div>
<span>by Ralph Wuerthner</span>
<i>at 2019-09-12T17:36:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: fix file cleanup in smb2.create.delete
Cleanup of test files created by smb2.create.delete is broken because
READONLY is set on the test file. Clear READONLY first before doing
the cleanup.
Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Sep 12 17:36:50 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a0fe965c36218c5992ed2a6fe7c7fdb00b420702">a0fe965c</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2019-09-13T11:15:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">param: Allow rpc server dynamic port range to roundtrip
Originally this parameter only set two other parameters, but never set
the original string. By setting the string as well, we can make it be
emitted by testparm -v correctly (instead of ''), and set it back as the
value for the parameter.
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d51bb3137fad727baa487c4210ac4d5020bf7a1e">d51bb313</a></strong>
<div>
<span>by Garming Sam</span>
<i>at 2019-09-13T12:33:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">whitespace: Conform to coding convention
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Fri Sep 13 12:33:32 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/522a8480fa5e886d66a2efc8d49ac4e2ac6403d7">522a8480</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-17T04:35:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop reference to unused ctdb_eventd test directory
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/68684377c6970725a57ec6111cb165736468440f">68684377</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-17T04:35:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use ctdb_get_all_pnns()
The nested, arbitrary use of onnode can cause messages from ssh on
stderr to appear in the node list:
Getting list of nodes...
Output of "onnode -pq all ctdb pnn | grep '^[0-9][0-9]*$'":
Warning: Permanently added '10.0.0.72' (RSA) to the list of known hosts.^M
Warning: Permanently added '10.0.0.75' (RSA) to the list of known hosts.^M
Warning: Permanently added '10.0.0.73' (RSA) to the list of known hosts.^M
Warning: Permanently added '10.0.0.74' (RSA) to the list of known hosts.^M
1
0
3
2
Create/wipe test database rec_test.tdb
Failed to execute "Permanently added '10.0.0.72' (RSA) to the list of known hosts.^M ctdb attach rec_test.tdb" on node(s) "Warning:"
Invalid <nodespec>
Avoid that by using an existing function that does not nest ssh uses.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8aed06ce8c802d75e7bacb289916c835164e7307">8aed06ce</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-17T04:35:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use db_ctdb_cattdb_count_records()
Avoid reinventing the wheel.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2c6b098c7220a3e6d78f6040c912fc22a02f6e46">2c6b098c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-17T04:35:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Don't run setup_ctdb_base() for real cluster
This has not been needed for some time.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/284bbca7c730235dd2df9ec2acbfc5fa6de5be42">284bbca7</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-17T04:35:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move NFS test functions to complex local script
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bb040f27985245449771a68606f0da2440ba1e7c">bb040f27</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-17T04:35:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Only set TEST_SUBDIR when needed
This is only needed for setup_ctdb_base() so only set it when calling
this function.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/429502186a70f4220c8597d68a3306a073a33c4c">42950218</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-17T04:35:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop unused code from onnode unit test ctdb stub
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/497ae563a0b3e45794c22acb67ccde060d34f371">497ae563</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-17T04:35:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Fix zero event scripts test so it tests something
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8038f4f64f4f6a77346837c1877e352be2632cd0">8038f4f6</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-17T04:35:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid shellcheck warnings
SC2086 Double quote to prevent globbing and word splitting
This one doesn't need the double quotes if it is contained within the
preceding variable expansion.
SC2181 Check exit code directly with e.g. 'if mycmd;', not indirectly with $?
SC2004 $/${} is unnecessary on arithmetic variables
These are straightforward.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8443798846d3e6f67eeb651f98af24272a8a4b5c">84437988</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-17T04:35:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Invert some logic so it makes sense
The test should be outside the loop.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2730e48360750d4fbfd66ea76a2b0f002acfcab9">2730e483</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-17T04:35:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Simplify setup_ctdb()
There is no point inventing a whole new set of options here.
Continue to locally implement the --no-event-scripts option. This
must be first, though in practice only one option is ever passed to
setup_ctdb() from ctdb_test_init().
Simply pass all other options through to "local_daemons.sh setup".
This has the side effect of causing failure when an invalid option is
passed.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7a5a4a4494d5fd2514651e06c2206007b8422449">7a5a4a44</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-17T04:35:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop run_tests -d option
The usage message says it is dodgy and some test suites may not
support it.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2b37d99a5fbb08954dc4c0ff20867e9fd9dd5712">2b37d99a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-17T04:35:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Put the summary file inside $TEST_VAR_DIR
This means less random files dropped in /tmp or similar.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/32b5ceb31936ec5447362236c1809db003561d29">32b5ceb3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-17T04:35:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tools: Stop deleted nodes from influencing ctdb nodestatus exit code
Deleted nodes should simply be ignored.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14129
RN: Stop deleted nodes from influencing ctdb nodestatus exit code
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/597039daeb88f6d97f71ecaaa55efd7e091638ea">597039da</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-17T04:35:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-utils: CID 1273087 - Resource leak
Ensure that p is not leaked.
This is a test program and the program exits anyway. No need to
backport.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/80cbebce7123f934562d74e5e29dae3719e9cc37">80cbebce</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-17T04:35:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Silence shellcheck warning SC2166
This covers the following:
SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined..
SC2166: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
POSIX agrees that -a and -o should not be used:
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html
Fixing these doesn't cause much churn.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fc7f3b99acad0a1c5ebeb2bc3c0753ec7b31bb49">fc7f3b99</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-17T04:35:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Drop bit-rotted shellcheck directive
The code has changed so this is no longer needed.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/84f544b55f235e2f08596bf4b7854460af008f88">84f544b5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-17T05:52:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-client: Fix some typos in debug messages
tdb_sore -> tdb_store
SCHDULE_FOR_DELETION -> SCHEDULE_FOR_DELETION
Switch to modern debug macros while touching the lines.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue Sep 17 05:52:15 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/98fe813d9cd360f9ac3f9836cd1de9c4a174413f">98fe813d</a></strong>
<div>
<span>by Khem Raj</span>
<i>at 2019-09-17T12:31:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/replace/wscript: Avoid generating nested main function
clang is not happy when it sees another main nested inside the main
function and fails the test for prctl syscall, therefore avoid adding
implicit main() here
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5a80f399b51221fb0b8661f30d940ca24e1ce627">5a80f399</a></strong>
<div>
<span>by Khem Raj</span>
<i>at 2019-09-17T12:31:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">util_sec.c: Move __thread variable to global scope
Make clang happy otherwise it complains about variable scope
fixes
source3/./lib/util_sec.c:470:4: error: '__thread' variables must have global storage
} __thread cache;
^
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/16eb80058ca4a34df96388c26736590247b6a3f4">16eb8005</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-09-17T13:48:18+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Remove tests for getdents() and getdirentries()
These date back to 3a9beef2b7b25427ee4611cfc375e05cc82a1150 in 2003 and
829e72fe9c97feaa3d45b768984a4c47b906a23a in 1998 and appear to be related
to smbwrapper.
More of these should be removed but the getdirents() test caused a timeout
on an ARM builder in Debian. It might just be a fluke but the tests are
pointless regardless.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Sep 17 13:48:18 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e0a3cc469f2f63a663496e932426a289a831dd44">e0a3cc46</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2019-09-17T17:55:55+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs/full_audit: always log full filenames
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13565
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Sep 17 17:55:55 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/78fce47fc23173885143b730552599023c845963">78fce47f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use direct struct assignments in smbXsrv_*.c
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3d1da1ac308538e47017091123361cc927d8d778">3d1da1ac</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">idl: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4f8db9b3cff9ef548a66b45f998573aea103db8c">4f8db9b3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: Make "fd_handle->gen_id" 64-bit everywhere
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e00e53344df78b54bb5978de7062bf4c1242bd46">e00e5334</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Make fsp->fh->gen_id unique per process
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/41393a648899ab2ce61c69e673240e9821735c06">41393a64</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove unused smbXsrv_open_hash()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/735439765a29b0b31e530998e0d46b11c298c50b">73543976</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Make lease_type_is_exclusive() static
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8d63b622df42111b603d5f6fe2fa31490eb7cd98">8d63b622</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Make "current_state" show up first in the blob
Believe it or not, but without this change "num_files" was first.
Thanks Metze for this (to me at least) really, really surprising
insight!
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cc2e5b41646f6c18288ffb4b0ea16f4ea2cb4874">cc2e5b41</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Add quick leases_db_get_current_state()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d12421ace457d1fdca0d97e2c680e90edf556967">d12421ac</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Let fsp_lease_type() look at leases.tdb
The same lease can be used via different TCP connections (yes, we have
tests for this!). At the end of downgrade_lease() we update all fsp's
with fsps_lease_update() that link to the lease that just was
changed. However, this is only in the local process, this is not
cross-smbd. So other smbds using the same lease can use stale
information and for example get the mandatory locking wrong.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ba1234d877b3364be3b2f6793e3a6fe6c238da0f">ba1234d8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Introduce helper variables in open_mode_check()
Less bytes .text, the compiler now does not have to expect other threads to
alter the pointers.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d9ce9c42cb6abd3263d639d6474a92b85776ba8d">d9ce9c42</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Add server_id_cmp()
Will be used later for sorting the share mode array
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/27b63641828f6f1e7e3c8b97cb34795a75688b8f">27b63641</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Use server_id_cmp() in server_id_equal()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e0aa1e09988690ecb8f5caa7201b4a622fc22be5">e0aa1e09</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix a debug message hickup
Mind the missing space before "(e.g. another...". While there, avoid
casts.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e69c4faeb7187922674d85c90134324725993671">e69c4fae</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Rewrite share_conflict()
It was hard for me to understand share_conflict(), so once I understood
it I thought this version would be easier to follow. It violates
README.Coding (one argument per line), but grouping the parameters to
mask_conflict makes it clearer to me what belongs together.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dc7dfb1257397491f8f02d1e1c42253103235d5f">dc7dfb12</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Avoid passing a share mode entry to share_conflict()
Make the real data dependencies clearer, we don't need a full
share_entry, only its access and sharemode masks
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/55e47ada9f85d5152b342d7d39226dc18bbaf162">55e47ada</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Add share_entry_stale_pid()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/be799acb4558f347c6e6a82874897c7af0c0c3d8">be799acb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_entry_stale_pid() in share_mode_stale_pid()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eb99635d0f2a8dbd52d4a5143efe5a9716401b08">eb99635d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Add share_mode_forall_entries()
Abstract away the fact that we store the share modes as an array inside
"struct share_mode_data".
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5cbd3e46714f5bfdbfa54c8cef0f8145bee08094">5cbd3e46</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_forall_entries() in contend_level2_oplocks_begin_default()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f5a6fa40928f9e8c9b91f38f287fd9264de9d826">f5a6fa40</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_forall_entries() in set_delete_on_close_lck()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/14cc16948f0da00119cc85ebe7f9ab51b2275ece">14cc1694</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_forall_entries() in has_other_nonposix_opens_fn()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5b1fd018a2c47106102deb74bbd72fdf0c9faf02">5b1fd018</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_forall_entries() in has_delete_on_close()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cb4b20b79fb426682cdc5c84a88443e590df3df8">cb4b20b7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_forall_entries() for validate_my_share_entries()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fb0b107ac2dc594fd9343f3767b3fb298909879d">fb0b107a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_forall_entries() in open_mode_check()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/434028518403e7e1d216a4acb9b229caccc44149">43402851</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_forall_entries() in rename_share_filename()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/18c8b46e8176ea56f24a853d1f6c5ca484df7d81">18c8b46e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_forall_entries() in file_has_open_streams()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aa94589904518e74b533dc47d56ba6811b6b997f">aa945899</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_forall_entries() in validate_oplock_types()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/30e62710c6e323028555deb0eaee238c1713d7e9">30e62710</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Pass "struct file_id" to get_lease_type()
It does not have to depend on the whole struct share_mode_data.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2a784883a889b517b86cce328f0798c92b69a2d5">2a784883</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_forall_entries() in delay_for_oplock()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f82aebe943534d5ab9b89dcec2150f985b574115">f82aebe9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Avoid "share_mode_lock" dependency in rename_lease_fn()
share_mode_forall_leases() will stop passing "lck" soon.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4955481a678eb69df380c3c915cef95feec92443">4955481a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Avoid "share_mode_lock" dependency cleanup_disconnected_lease()
share_mode_forall_leases() will stop passing "lck" soon.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f69310672501c0e2d0afe638a18a0e21fec17298">f6931067</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Stop passing "share_mode_lock" via share_mode_forall_leases()
Why? Next commit will make share_mode_forall_leases() use
share_mode_forall_entries(), and that does not necessarily have to
depend on "share_mode_lock". And as we can pass the required
information via "private_data", don't embed the "share_mode_lock"
reference into this lowlevel library routine.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ac119c411c4e268d7fe3c6766d3f9023ea4df456">ac119c41</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_forall_entries() in share_mode_forall_leases()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2185db6c610433e0651543b7179cf1fbd0e2c9eb">2185db6c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Pass pid/share_file_id to find_share_mode_entry()
Avoid the full fsp, this makes the indexing of the share mode array
clearer, and it makes the next commit easier
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b3473efa9d3ab7ccd364ab29a3e93e900b5a49e2">b3473efa</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Add reset_share_mode_entry
Mostly for durable reconnect at this point
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2d9bb67d25181eba79b95df661e5a5d613b4a850">2d9bb67d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_forall_entries() in vfs_default_durable_reconnect()
The durable reconnect mainly has to check that there is one and only one
entry, and it has to reset it with the new values.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c7a9e0e4cdfb22e66533b5c8e20af3cfdb8ae78c">c7a9e0e4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_forall_leases() in delay_rename_for_lease_break()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8eda954d6d7469c54855d22a97bf625f32ebdad7">8eda954d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_forall_leases() in lease_match()
We have to break leases referenced from multiple share modes only
once.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6a58f29c6205d6a4cc7f98ad0f5c6ebf1dadd385">6a58f29c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_forall_leases() in share_mode_cleanup_disconnected()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e4a5a017c5d8c4aac14e3440f498374700dd7fbd">e4a5a017</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_forall_entries() in share_entry_forall()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/609143adb68b05dbfa13db0f9289a33b53919a71">609143ad</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove unused share_mode_stale_pid()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5709856138d3149caf019bf70f9acf673efedec7">57098561</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Avoid duplicate assignments
remove_share_mode_lease() already does this
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ad23d0f4f57e24a36960a1fa85f527e96753e4d2">ad23d0f4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Pass share_mode_lock to remove_share_mode_lease()
Later we'll need "lck" further down
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4d512f40f9f6c1689cc4e0ace541079fda98c611">4d512f40</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Pass share_mode_lock to remove_lease_if_stale()
We'll want to use share_mode_forall_entries next
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/72a019d4e32d46ae160ecfe2c90348d005ec2449">72a019d4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_forall_entries() in remove_lease_if_stale()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5151b6d58be54d210795e7769033cb33e6c75b0a">5151b6d5</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Avoid calling remove_stale_share_mode_entries() in open.c
All places that matter explicitly check for staleness. This cleanup
action should only happen before writing the database
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f96aa7063e846021b69403cc9caa091c8e09b578">f96aa706</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Make remove_stale_share_mode_entries() static in share_mode_lock.c
... to the place where the record is stored in the database
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/87e42c73d379738a5f87569ea630c28c9d66c148">87e42c73</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove stale share mode entries while walking the array
Previously, we did this only when writing out the locking.tdb
record. That was because we had places where the index of a particular
share mode entry mattered while operating on the array. This is no
longer the case, so we can remove stale entries early.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d3b0ed13c223a2e4ff22026cddbc55992f35288d">d3b0ed13</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture3: Remove cleanup3
This goes directly into the database, for which the format changes
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ded3f91d80763edfab242a48baa834e669e16ed5">ded3f91d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Allow a 4th lock order
We will have another tdb soon
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/72ac1764d69e165052220f2c1b5bc0d5613ef201">72ac1764</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Allow another database between brlock.tdb and leases.tdb
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/15a8af075a2d7b59f4d97d9804599b26325e5640">15a8af07</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Enable watching and storing dbwrap_watch records.
Samba so far on a dbwrap_watch record either watches or stores a
record, but never both from the same db_record instance acquired from
a dbwrap_fetch_locked(). In one of the next commits this will change,
we will watch a record and at the same time store data into it. This
patch enables a watch_send() followed by a storev() by properly
keeping the watchers around.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9c99675bcbc530f8054de77b1a5f660dde015c62">9c99675b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Introduce share_entries.tdb - ADD COMMENT FIXME !!
This moves share_modes[] from "struct share_mode_data" into a separate
share_entries.tdb with a sorted array of fixed-length (132 byte)
"struct share_mode_entry" entries.
I know it's one huge commit, but I did not see a way to keep both data
structures and associated code working together without a lot of code
duplication after having centralized all the code accessing the
share_modes[] array into a few routines.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/86b4907853e8df20ebe3ec6871aa3210f1bde201">86b49078</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Make "share_mode_flags" 16-bit wide
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ac85ec5ed855d8d0bc2564cbd33a580a8db6818e">ac85ec5e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-17T22:49:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Add share mode flags
This will contain a summary of the "most restrictive" share mode and
lease, i.e. intersection of all share_access entries and the union of
all access_mask and leases in the share mode array. This way
open_mode_check in the non-conflicting case will only have to look at
the summary and not walk the share mode array.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fd61e550acec6e9924a71712eef739b58c7d68e8">fd61e550</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-18T00:07:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Don't always walk the share mode array in open_mode_check()
share_mode_data->flags contains the "most restrictive" share mode of
the whole array. This is maintained lazily: Whenever set_share_mode()
is called, d->flags is updated if the new share mode got more
restrictive. It is not updated when a file is closed, as this would
mean we would have to walk the whole array, making sure that the
closed handle was indeed the only most restrictive one. Instead, we
walk the share mode array only when a conflict happens: Then we need
to know "the truth" and recalculate it by walking the share mode
array.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep 18 00:07:13 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/55b54e72174fc018fee82ded0cb70eebb839cb5f">55b54e72</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-18T01:26:06+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Remove vfs_netatalk. Old, unused and unmaintained.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep 18 01:26:06 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d65b17c3f7f9959ed95b03cc09e020d7387b7931">d65b17c3</a></strong>
<div>
<span>by Bryan Mason</span>
<i>at 2019-09-18T12:31:10+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:client:Use DEVICE_URI, instead of argv[0],for Device URI
CUPS sanitizes argv[0] by removing username/password, so use
DEVICE_URI environment variable first.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14128
Signed-off-by: Bryan Mason <bmason@redhat.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Sep 18 12:31:11 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8df123e7f7cb591f6673ccffefffc30b946f1a5b">8df123e7</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2019-09-18T18:34:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pod2man is no longer needed
Since e24e344d0da58013fd5fa404529fe1d25ef403bf.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14131
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3263dd32fedf9e6c104a0c03f035b585c568a8d1">3263dd32</a></strong>
<div>
<span>by Sam Zaydel</span>
<i>at 2019-09-18T19:51:11+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Argument to control number of operations -o no longer valid
(This patch, only removing manpage text, submitted by gitlab.com user
Sam Zaydel @szaydel in MR 243 but without a Signed-off-by, so I
(Andrew Bartlett) am adding mine to say I'm happy to say this is a
legitimate and deliberate contribtion.)
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Sep 18 19:51:11 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3084928383cdeafc53b2154f458464d9174faff2">30849283</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-18T20:10:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">messaging4: Pass fds to messaging handlers
Boiler-plate replacement moving the (num_fds!=0) check down
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/930ec152123e6a7c37f38e52cc7fd32f755a6b83">930ec152</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-18T20:10:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Align integer types
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/23bee5da95026d161159da74a032780a713c820a">23bee5da</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-18T20:10:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Add talloc_full_report_printf()
Print the talloc full report into a FILE*. talloc itself provides a
very similar function, talloc_report_full(). However, that has a
slightly different output, in particular it does not print the
contents of strings, which is very handy for debugging.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bc4e8b1abaf8431d1f507107cf60e57da75c0bef">bc4e8b1a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-18T21:27:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">messaging: Do POOL_USAGE via a socket
This makes debugging run-away processes much more efficient and even
possible at all: If the pool-usage output is more than 256MB, the
previous code could not realloc it and threw it away. Also, it is not
helpful for an already huge process to allocate even more.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep 18 21:27:30 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d566a4d3e1019cf356b364826fa3ab0cd970818d">d566a4d3</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-09-19T09:28:21+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Remove crypt() reimplementation
Use of Samba with plaintext authenticaiton is incredibly rare, even more
rare is plaintext authentication on systems without a crypt() call and
where DES based crypt() would be the right thing to do.
Remove this additional cryptographic code per our current efforts
to rely entirely on external libraries instead.
Similar to the arguments in this thread about zlib discussed on
samba-technical here:
https://lists.samba.org/archive/samba-technical/2019-May/133476.html
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Sep 19 09:28:21 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7b6e56b0f990c01d5b7a948c42e7e66c2ac596c7">7b6e56b0</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-09-19T12:52:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Fix typo in vfs_ceph_snapshots man page.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/094862b8a67c8f1a3d37c2838bb0d684d5858da8">094862b8</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2019-09-19T14:09:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/vfs_shadow_copy2.c: Fix typo in comment.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
Autobuild-User(master): Björn Jacke <bjacke@samba.org>
Autobuild-Date(master): Thu Sep 19 14:09:44 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/82512034563870d4629d0a42813560e6d69b2b5e">82512034</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-09-19T20:48:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-libads: adapt to coding standards, no code changes
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Sep 19 20:48:45 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d78c87e665e23e6470a19a69383ede7137172c26">d78c87e6</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-09-20T01:14:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-winbindd: fix forest trusts with additional trust attributes.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14130
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7ba90c17343cc9921e1d44a5055d39602dbb6ba1">7ba90c17</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-09-20T01:14:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lsa: document new LSA trust attributes
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a7e49897c4ad84a5d7710ac78a09802fe66f9d16">a7e49897</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-09-20T01:14:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">misc: fix AD trust attributes in adssearch
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/73b93e1a70508346e813e311179e2ed538adfe6b">73b93e1a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-20T01:14:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">security.idl: add GUID_DRS_ALLOWED_TO_AUTHENTICATE
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/09de6f06182ede5bee3cb0c5408ce4082c62ccc2">09de6f06</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-20T01:14:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc/idl: change from samr_GroupAttrs in samr.idl to security_GroupAttrs in security.idl
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c87cf54684be606aa8f9b420f5c4f710de2a363a">c87cf546</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-20T01:14:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">security.idl: add SE_GROUP_INTEGRITY[_ENABLED] to security_GroupAttrs
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0fea2707fb05897eec3c26bd4814669832142382">0fea2707</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-20T01:14:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netlogon.idl: fix the marshalling of netr_OsVersion for NDR64
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8f0751b8b7cd45fc7186b467d814eb5231821e34">8f0751b8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-20T01:14:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netlogon.idl: fix the marshalling of netr_trust_extension_container for NDR64
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6e47f9ab37744d628cc6b723f4838e81202f2df6">6e47f9ab</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-20T01:14:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/auth: add netlogon_creds_cli_LogonGetDomainInfo()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/742d8ba9c4b9e6e70898f08a50f9929662bbafb6">742d8ba9</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-09-20T01:14:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-rpcclient: add logongetdomaininfo command
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fda5b839c705725301fc17562d08a927751b890b">fda5b839</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-09-20T01:14:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: add torture_suite_add_ndr_pull_io_test_flags()
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/634ab14f0d246fab28cf14ad9664cecf3ca5335a">634ab14f</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-09-20T01:14:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-torture: reformat test table in ndr test
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2d5facc95478801580eb52d4d4441660c5fa2697">2d5facc9</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-09-20T02:32:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-torture: add netr_LogonGetDomainInfo NDR(64) tests
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Fri Sep 20 02:32:44 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/01b0e5aadf9a9bb6c806850c3708933eebd08c6b">01b0e5aa</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-09-20T12:58:49+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">spoolss: Add PRINTER_DRIVER_CATEGORY_3D driver define
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Sep 20 12:58:49 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dd0837c9a84bdbb98c9c31997c431173dfe6e714">dd0837c9</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-21T19:33:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">user.py: import tempfile module only where needed
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2291679e2b02e729e34ef848164d6630c5adc546">2291679e</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-21T19:33:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba_abi.py: avoid inefficient string concatenations
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0141c82eedbe525169546f6d30488149c3a7ed7a">0141c82e</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-21T19:33:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba_autoconf.py: avoid inefficient string concatenations
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8b43aabecbad2084169b229859bf5bfc9e2ddac0">8b43aabe</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-21T19:33:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba_bundled.py avoid inefficient string concatenations
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/432d9fd2214a4804a9cfefb9916e97efb9909c2c">432d9fd2</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-21T19:33:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba_deps.py avoid inefficient string concatenations
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/89288c7e8398d86a24ea19a94908bc85a2664074">89288c7e</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-21T20:50:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba_version.py: avoid inefficient string concatenations
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Sep 21 20:50:17 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ec4c5975528f3d3ab9c8813e176c6d1a2f1ca506">ec4c5975</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-23T11:40:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">fault.c: improve fault_report message text pointing to our wiki
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14139
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/465e518d6cc200eefa38643e720ce64e53abac2e">465e518d</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-23T12:58:20+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">classicupgrade: fix a a bytes-like object is required, not 'str' error
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14136
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Björn Baumbach <bb@samba.org>
Autobuild-User(master): Björn Jacke <bjacke@samba.org>
Autobuild-Date(master): Mon Sep 23 12:58:20 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c7e6db97de967e902529fa9e902cdcdf2a159403">c7e6db97</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-09-23T17:06:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Add an error return END_PROFILE call
All other return; statements in reply_tcon_and_X have this
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Sep 23 17:06:25 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/08fea1ced39652954ae44d8cdc4dc405b31786b6">08fea1ce</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-24T02:27:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Generalise pattern for matching valgrind memcheck executable
On my laptop this is "memcheck-amd64-linux instead of just "memcheck".
Alternatively, this part of the test could simply be skipped if
$VALGRIND is set.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ae1e8002b09f0035712df236f4b5efc85d7ad1d6">ae1e8002</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-24T02:27:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use local $ctdb_base instead of $CTDB_BASE
The latter might not be defined in a test.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f331f3f723a4e26af2d5c356cb9b72d062df6311">f331f3f7</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-24T02:27:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use local_daemons.sh onnode for local daemons tests
With some upcoming changes, the setting of CTDB_BASE becomes
problematic because it will be included unconditionally whereas it is
currently being conveniently and almost accidentally not include in
some contexts.
So, instead of trying to coerce onnode into behaving as desired, have
the local daemons tests use local_daemons.sh onnode directly.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/02edfb0f199fb7206df1f725aee56826d65716c1">02edfb0f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-24T02:27:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Rename variable TEST_SUBDIR -> CTDB_TEST_SUITE_DIR
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e9ce035c2d2ef6fd177a3bb10031162586b696bd">e9ce035c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-24T02:27:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move setting of CTDB_TEST_SUITE_DIR to run_tests.sh
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cec8f3907ef7b324035b59f9a965c198b5d03de6">cec8f390</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-24T02:27:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add new variable CTDB_TEST_TMP_DIR
This is a subdirectory of TEST_VAR_DIR that is unique to the current
test suite. It is recreated for each individual test.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cbd27c0a14247477acdf158cc40864afe91e5900">cbd27c0a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-24T02:27:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Switch cunit unit tests to use CTDB_TEST_TMP_DIR
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/96aa807f79df99c0fd64ea66d7f83527d5a490c2">96aa807f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-24T02:27:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Switch eventd unit tests to use CTDB_TEST_TMP_DIR
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3b16aa2016e499af96c4cbb3de4cb38515e86284">3b16aa20</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-24T02:27:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Switch eventscript unit tests to use CTDB_TEST_TMP_DIR
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/18ecdbfb02e64ae7942378efb69df7541b5859f0">18ecdbfb</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-24T02:27:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Switch onnode unit tests to use CTDB_TEST_TMP_DIR
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1934f673dc7aadf8eb288d4ac1b46876d442e039">1934f673</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-24T02:27:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Switch tool unit tests to use CTDB_TEST_TMP_DIR
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/def929954aa26116fc5356203b313b50fcb6d7a8">def92995</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-24T02:27:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Switch takeover helper unit tests to use CTDB_TEST_TMP_DIR
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/263890b36dbe23460a3d38050250d6d792907426">263890b3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-24T02:27:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Switch simple tests to use CTDB_TEST_TMP_DIR
CTDB_TEST_TMP_DIR repaces SIMPLE_TESTS_VAR_DIR. local.bash no longer
needs to ensure that TEST_VAR_DIR is set, since it longer uses this
variable. Drop the comment because state has not been maintained
between tests for some time.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e78c1a0ca2254b533ffa1ab27184e73e79819962">e78c1a0c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-24T02:27:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Use CTDB_TEST_TMP_DIR in integration.bash
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b8f4f141a2d7aed9a8af572b27e2afcc1365bf3b">b8f4f141</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-24T03:46:59+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Switch TEST_VAR_DIR to a local script variable
This is now local to run_tests.sh.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue Sep 24 03:46:59 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4c34a2d72569f31d59b904c3ca1c140f6084b3dd">4c34a2d7</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-24T12:22:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">traffic.py: avoid inefficient string concatenations
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1825a7f4e2a39d03f01da37b68ba4f65dbafd04a">1825a7f4</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-24T12:22:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kcc_utils.py: avoid inefficient string concatenations
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ce56d336f234febfd4cb3da11dd584842c24ce1d">ce56d336</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-24T12:22:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpo.py: avoid inefficient string concatenations
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d2d8ebcca1cc4539a7a6b48fa364e03adda1db6c">d2d8ebcc</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-24T12:22:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">user.py: avoid inefficient string concatenations
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cf51f73e02cab85f508bcbef362ff75a7ae18d7f">cf51f73e</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-24T12:22:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">schema.py: avoid inefficient string concatenations
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dd9e0f0ae1cca23920883a0e04fe5862663e400e">dd9e0f0a</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-24T12:22:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth_log_winbind.py: avoid inefficient string concatenations
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/32d1c3f873fc8bd89a7dc985cb8258e990dc12cd">32d1c3f8</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-24T12:22:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">posixacl.py: avoid inefficient string concatenations
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b3b6b700c47ba771baf632b3a165106c21c9ae04">b3b6b700</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-24T12:22:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/wscript: avoid inefficient string concatenations
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5ad629dcb957e45637f3a71309fa51abd87b267d">5ad629dc</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-24T12:22:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript: avoid inefficient string concatenations
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c7fa030aecd1de5ed32e2509ecd83828aa42c1a3">c7fa030a</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-24T12:22:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">scripting: avoid inefficient string redefinition
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c9088c6aa847685613ec34d61b61e31fe0395035">c9088c6a</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-24T12:22:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pfm_verif: string concatenation efficiency cleanup
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4f5c4df316dc029f7b5ed6e8e48636dc61ecfe22">4f5c4df3</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-09-24T13:40:21+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript_build: string concatenation efficiency cleanup
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-User(master): Björn Jacke <bjacke@samba.org>
Autobuild-Date(master): Tue Sep 24 13:40:21 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/acbf922fc2963a42d6cbe652bb32eee231020958">acbf922f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: add logging to wbc_auth_error_to_pam_error() for non auth errors
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/db8fd3d6a315b140ebd6ccd0dcdfdcf27cd1bb38">db8fd3d6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:auth: use the correct client realm in gensec_gssapi_update_internal()
The function gensec_gssapi_client_creds() may call kinit and gets
a TGT for the user. The principal provided by the user may not
be canonicalized. The user may use 'given.last@example.com'
but that may be mapped to glast@AD.EXAMPLE.PRIVATE in the background.
It means we should use client_realm = AD.EXAMPLE.PRIVATE
instead of client_realm = EXAMPLE.COM
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bc473e5cf088a137395842540ed8eb748373a236">bc473e5c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: let kerberos_kinit_password_ext() return the canonicalized principal/realm
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/361fb0efabfb189526c851107eee49161da2293c">361fb0ef</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: avoid wrong debug message in cli_session_creds_prepare_krb5()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6ed18c12c57efb2a010e0ce5196c51b48e57a4b9">6ed18c12</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: let cli_session_creds_prepare_krb5() update the canonicalized principal to cli_credentials
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0bced73bed481a8846a6b3e68be85941914390ba">0bced73b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads/kerberos: always use the canonicalized principal after kinit
We should always use krb5_get_init_creds_opt_set_canonicalize()
and krb5_get_init_creds_opt_set_win2k() for heimdal
and expect the client principal to be changed.
There's no reason to have a different logic between MIT and Heimdal.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5d0bf32ec0ad21d49587e3a1520ffdc8b5ae7614">5d0bf32e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_wrap: smb_krb5_kinit_password_ccache() should always use the canonicalized principal
We should always use krb5_get_init_creds_opt_set_canonicalize()
and krb5_get_init_creds_opt_set_win2k() for heimdal
and expect the client principal to be changed.
There's no reason to have a different logic between MIT and Heimdal.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/162b4199493c1f179e775a325a19ae7a136c418b">162b4199</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:auth: kinit_to_ccache() should always use the canonicalized principal
We should always use krb5_get_init_creds_opt_set_canonicalize()
and krb5_get_init_creds_opt_set_win2k() for heimdal
and expect the client principal to be changed.
There's no reason to have a different logic between MIT and Heimdal.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/303b7e59a286896888ee2473995fc50bb2b5ce5e">303b7e59</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: ads_krb5_chg_password() should always use the canonicalized principal
We should always use krb5_get_init_creds_opt_set_canonicalize()
and krb5_get_init_creds_opt_set_win2k() for heimdal
and expect the client principal to be changed.
There's no reason to have a different logic between MIT and Heimdal.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3bdf023956e861485be70430112ed38d0a5424f7">3bdf0239</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_wrap: let smb_krb5_parse_name() accept enterprise principals
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9520652399696010c333a3ce7247809ce5337a91">95206523</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml: add "winbind use krb5 enterprise principals" option
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a77be15d28390c5d12202278adbe6b50200a2c1b">a77be15d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbindd: implement the "winbind use krb5 enterprise principals" logic
We can use enterprise principals (e.g. upnfromB@B.EXAMPLE.COM@PRIMARY.A.EXAMPLE.COM)
and delegate the routing decisions to the KDCs.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cd3ffaabb568db26e0de5e83178487e5947c4f09">cd3ffaab</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/pam_winbind.py: turn pypamtest.PamTestError into a failure
A failure generated by the AssertionError() checks can be added
to selftest/knownfail.d/*.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/653e90485854d978dc522e689cd78c19dcc22a70">653e9048</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/pam_winbind.py: allow upn names to be used in USERNAME with an empty DOMAIN value
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3d38a8e9135bb72bc4ca079fab0eb5358942b3f1">3d38a8e9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test_pam_winbind.sh: allow different pam_winbindd config options to be specified
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/72daf99fd1ffd8269fce25d69458de35e2ae32cc">72daf99f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/tests.py: prepare looping over pam_winbindd tests
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/36e95e42ea8a7e5a4091a647215d06d2ab47fab6">36e95e42</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/tests.py: test pam_winbind with krb5_auth
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f07b542c61f84a97c097208e10bf9375ddfa9a15">f07b542c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/tests.py: test pam_winbind with a lot of username variations
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/13e3811c9510cf213881527877bed40092e0b33c">13e3811c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-09-24T18:30:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Export TRUST information in the ad_member target environment
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ad6f0e056ac27ab5c078dbdbff44372da05caab2">ad6f0e05</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/tests.py: test pam_winbind for trusts domains
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e2737a74d4453a3d65e5466ddc4405d68444df27">e2737a74</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T18:30:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/Samba3.pm: use "winbind scan trusted domains = no" for ad_member
This demonstrates that we rely on knowning about trusted domains before
we can do krb5_auth in winbindd.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0ee085b594878f5e0e83839f465303754f015459">0ee085b5</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-09-24T19:51:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/Samba3.pm: use "winbind use krb5 enterprise principals = yes" for ad_member
This demonstrates that can do krb5_auth in winbindd without knowning about trusted domains.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Tue Sep 24 19:51:29 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/929555b7c8e987a98b704c102323546a2034bea7">929555b7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-09-24T23:32:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fileid: add extid mapping hooks
For this always ends up calling fileid_extid_mapping_zero(), so no change in
behaviour. This will change in a subsequent commit.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/517ec63004f6708c9e6b29cb33bd789b1936997b">517ec630</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-09-25T00:48:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fileid: add "fsname_norootdir_ext" option
This can be used to deliberately break lock coherency between all smbd processes
in the whole cluster for the root directory of a share.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Sep 25 00:48:45 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/55c6e4bcc1b084fc391c21b387694a099a015c83">55c6e4bc</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-25T09:47:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/libcli/raw: clang: Fix 'Access to field results in a deref of a null ptr
Fixes:
source4/libcli/raw/rawfileinfo.c:301:56: warning: Access to field 'transport' results in a dereference of a null pointer (loaded from variable 'session') <--[clang]
parms->standard.out.create_time = raw_pull_dos_date2(session->transport,
^
source4/libcli/raw/rawfileinfo.c:314:55: warning: Access to field 'transport' results in a dereference of a null pointer (loaded from variable 'session') <--[clang]
parms->ea_size.out.create_time = raw_pull_dos_date2(session->transport,
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a1a448b19b9565a00e3077690dbda44ed727b2e4">a1a448b1</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-25T09:47:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/libcli/raw: clang: Fix 'Dereference of null pointer'
Fixes:
source4/libcli/raw/rawfileinfo.c:597:2: warning: Dereference of null pointer <--[clang]
SMBCLI_CHECK_WCT(req, 10);
^
source4/libcli/raw/rawfileinfo.c:639:2: warning: Dereference of null pointer <--[clang]
SMBCLI_CHECK_WCT(req, 11);
^
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/088a345f6acd84d888759c935a92737255e17b3f">088a345f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-25T09:47:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/libcli/raw: clang: Fix 'Value stored to 'p' is never read'
Fixes:
source4/libcli/raw/clisession.c:198:4: warning: Value stored to 'p' is never read <--[clang]
p += smbcli_req_pull_string(&req->in.bufinfo, mem_ctx, &parms->old.out.domain, p, -1, STR_TERMINATE);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
source4/libcli/raw/clisession.c:212:5: warning: Value stored to 'p' is never read <--[clang]
p += smbcli_req_pull_string(&req->in.bufinfo, mem_ctx, &parms->nt1.out.domain, p, -1, STR_TERMINATE);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
source4/libcli/raw/clisession.c:232:3: warning: Value stored to 'p' is never read <--[clang]
p += smbcli_req_pull_string(&req->in.bufinfo, mem_ctx, &parms->spnego.out.workgroup, p, -1, STR_TERMINATE);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/076216da7968b77e2a16cf21f879e9f159bc14da">076216da</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-25T09:47:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/libcli/smb2: clang: Fix Passed-by-value arg contains uninitialized data
Fixes:
source4/libcli/smb2/getinfo.c:222:11: warning: Passed-by-value struct argument contains uninitialized data (e.g., field: 'data') <--[clang]
status = smb_raw_fsinfo_passthru_parse(b.out.blob, mem_ctx, io->generic.level, io);
^
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ba55c0220767358656be125e6cecedef97317e9f">ba55c022</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-25T09:47:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/libcli/smb2: clang: Fix 'value stored to 'status' is never read'
Fixes:
source4/libcli/smb2/util.c:134:3: warning: Value stored to 'status' is never read <--[clang]
status = smb2_util_setatr(tree, dname, FILE_ATTRIBUTE_NORMAL);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
source4/libcli/smb2/util.c:187:5: warning: Value stored to 'status' is never read <--[clang]
status = smb2_util_setatr(tree, name, FILE_ATTRIBUTE_NORMAL);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
source4/libcli/smb2/util.c:209:3: warning: Value stored to 'status' is never read <--[clang]
status = smb2_util_setatr(tree, dname, FILE_ATTRIBUTE_NORMAL);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f755de54135ab5900209d093a45d9b824687a3bf">f755de54</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-25T09:47:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/libcli/clideltree.c: clang: Value stored to 'status' is never read
Fixes:
source4/libcli/clideltree.c:113:3: warning: Value stored to 'status' is never read <--[clang]
status = smbcli_setatr(tree, dname, FILE_ATTRIBUTE_NORMAL, 0);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
source4/libcli/clideltree.c:131:3: warning: Value stored to 'status' is never read <--[clang]
status = smbcli_setatr(dstate.tree, dname, FILE_ATTRIBUTE_NORMAL, 0);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d3371d8545bb4303e866e991453a0bbb05dd7656">d3371d85</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-25T09:47:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/librpc/crypto: clang: warning: Value stored to 'gss_maj' is never read
Fixes: Value stored to 'gss_maj' is never read
source3/librpc/crypto/gse.c:562:3: warning: Value stored to 'gss_maj' is never read <--[clang]
gss_maj = gss_release_buffer(&gss_min, &out_data);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
source3/librpc/crypto/gse.c:687:3: warning: Value stored to 'gss_maj' is never read <--[clang]
gss_maj = gss_release_buffer(&gss_min, &out_data);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
source3/librpc/crypto/gse.c:739:3: warning: Value stored to 'gss_maj' is never read <--[clang]
gss_maj = gss_release_buffer(&gss_min, &msg_min);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
source3/librpc/crypto/gse.c:742:3: warning: Value stored to 'gss_maj' is never read <--[clang]
gss_maj = gss_release_buffer(&gss_min, &msg_maj);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/40ddcf7bdcec547acdba090f43651cc5b953aded">40ddcf7b</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-25T09:47:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libads: clang: Fix Array access results in a null pointer dereference
Fixes:
source3/libads/cldap.c:400:6: warning: Array access (from variable 'responses') results in a null pointer dereference <--[clang]
if (responses[0] == NULL) {
^
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/018c93f35a80daef74e44e32ff0ff7437eed8547">018c93f3</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-25T09:47:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/librpc/crypto: clang: Fixes Value stored to 'ret' is never read
Fixes:
source3/librpc/crypto/gse_krb5.c:63:3: warning: Value stored to 'ret' is never read <--[clang]
ret = smb_krb5_kt_free_entry(krbctx, &kt_entry);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3bb7ccb4635535cb9dd9333220222dcfffb2aed9">3bb7ccb4</a></strong>
<div>
<span>by Philipp Gesang</span>
<i>at 2019-09-25T11:06:04+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:scripting: make samba-gpupdate heed --disable-python
Signed-off-by: Philipp Gesang <philipp.gesang@intra2net.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Noel Power<npower@samba.org>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Wed Sep 25 11:06:04 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/952e1812fa9bdc1bac2a7ae5ebb5532f1ea31447">952e1812</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-09-25T15:39:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:waf: Do not check for nanosleep() as we don't use it anywhere
We use usleep() in the meantime.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Pair-Programmed-With: Isaac Boukris <iboukris@gmail.com>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/480152dd6729d4c58faca6f3e4fa91ff4614c272">480152dd</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-09-25T15:39:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Only link against librt if really needed
fdatasync() and clock_gettime() are provided by glibc on Linux, so there
is no need to link against librt. Checks have been added so if there are
platforms which require it are still functional.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Pair-Programmed-With: Isaac Boukris <iboukris@gmail.com>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4b28239d13b17e42eb5aa4b405342f46347f3de4">4b28239d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-09-25T15:39:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pthreadpool: Only link pthreadpool against librt if we have to
This calls clock_gettime() which is available in glibc on Linux. If the
wscript in libreplace detected that librt is needed for clock_gettime()
we have to link against it.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Pair-Programmed-With: Isaac Boukris <iboukris@gmail.com>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/36e8d715bc8dc1e8466f5a5c9798df76310b7572">36e8d715</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-09-25T15:39:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Only link cmocka against librt if really needed
cmocka also uses clock_gettime().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Pair-Programmed-With: Isaac Boukris <iboukris@gmail.com>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/68d8a02ef57cce29e4ff3ef1b792adfc10d0b916">68d8a02e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-09-25T15:39:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Link nss_wrapper against pthread
nss_wrapper uses pthread_atfork() which is only provided by libpthread.
So we need an explicit dependency.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Pair-Programmed-With: Isaac Boukris <iboukris@gmail.com>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bd0cd8e13234d684da77a65f6fdaea2572625369">bd0cd8e1</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-09-25T15:39:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Link uid_wrapper against pthread
uid_wrapper uses pthread_atfork() which is only provided by libpthread. │····················
So we need an explicit dependency.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Pair-Programmed-With: Isaac Boukris <iboukris@gmail.com>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9499db075b72b147e2ff9bb78e9d5edbaac14e69">9499db07</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-09-25T15:39:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf:replace: Do not link against libpthread if not necessary
On Linux we should avoid linking everything against libpthread. Symbols
used my most application are provided by glibc and code which deals with
threads has to explicitly link against libpthread. This avoids setting
LDFLAGS=-pthread globally.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Pair-Programmed-With: Isaac Boukris <iboukris@gmail.com>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ab232ca77f8f08879d99f88cfcd554500717075e">ab232ca7</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-09-25T16:56:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: Use waf function to add for -Wl,--as-needed
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Sep 25 16:56:40 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/43ed3a6eb3ddf3434790bed2cb6abf08c5ce4c56">43ed3a6e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-26T04:45:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move cunit tests to UNIT/ subdirectory
The UNIT subdirectory directory will contain all unit tests. Use an
uppercase name to avoid conflicts with source code subdirectories.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/330a106aaa0c91074d5e64978ed6b2e84702336e">330a106a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-26T04:45:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move eventd tests to UNIT/ subdirectory
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8ed075d396ba5f6f7b7686fb0593984850923f55">8ed075d3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-26T04:45:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move eventscript tests to UNIT/ subdirectory
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a3cbb7eb21be56346b9357649579728d294cf3b4">a3cbb7eb</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-26T04:45:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move onnode tests to UNIT/ subdirectory
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/010c1a85fa9719b726d26c48aa3373f2e328e8f0">010c1a85</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-26T04:45:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move shellcheck tests to UNIT/ subdirectory
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cf0b87f9b7876bc4637c3ed57782c35251d2f965">cf0b87f9</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-26T04:45:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move takeover tests to UNIT/ subdirectory
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9585ece00c8c7eb215da9928e54dae92f55eaac0">9585ece0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-26T04:45:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move takeover_helper tests to UNIT/ subdirectory
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1061bdf29dce60251a53dcc0623efb8815b144ae">1061bdf2</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-26T04:45:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move tool tests to UNIT/ subdirectory
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4947fa5ffa8784c93f3c570e246b106b35f96a80">4947fa5f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-26T04:45:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Fold find_and_run_one_test() in to run_tests()
The additional function makes the logic harder to understand.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/75393cab0f87635e829b45b200cc771a0463b6f4">75393cab</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-26T04:45:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Recurse into directories instead of explicitly looping
run_tests() already has a loop, so use it.
This means collections of test suites can be handled - but explicitly
check valid collection names to avoid running junk.
Add special cases for simple and complex. These will be removed when
those test suites are moved to collections. This seems to be the
smallest amount of churn to support bisection.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4046baad5c3a5155c18566f853a9a08eb7fa431a">4046baad</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-26T04:45:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Skip README files in test directories/collections
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c438e0db45dd803523802055cb988c10ff277063">c438e0db</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-26T04:45:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop custom handling for unit tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/384381fbff5ca900af031fb0606a270f572f5b9e">384381fb</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-26T04:45:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop use of array in run_tests()
This doesn't accomplish anything.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/df6800e330d1c1fd47ce3d2f7a5814597ed46229">df6800e3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-26T04:45:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Convert local daemons include file into top-level include
Do the same with the alternative code for real clusters.
Both of these can now be used by other test suites.
Fix some basic shellcheck warnings (e.g. avoid word-splitting by
quoting) while moving code and add the new files to the shellcheck
test.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/658068184ff9437c11e5260e24a632439adb3d27">65806818</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-26T04:45:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move complex tests to CLUSTER/ subdirectory
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8a5c4a60e156170f8aaa738672ed6dc50712a929">8a5c4a60</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-26T04:45:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move simple tests to INTEGRATION/ subdirectory
Split some tests out into database/ and failover/ subdirectories.
Rename the remaining tests in simple/.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/24f04c1cc561d9f4b7fada1ca87f52bed2167f8d">24f04c1c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-09-26T06:01:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Update README
Bring this up to date. Drop descriptions of command-line options
because these tend to bit-rot - refer to "run_tests.sh -h" instead.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Thu Sep 26 06:01:33 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c58692cee919259edc4b95009925d516384bbc6a">c58692ce</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Add SMB_VFS_UNLINKAT().
Currently identical to SMB_VFS_UNLINK().
Next, add to all VFS modules that implement
unlink and eventually remove unlink.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2c90d2b4f0d61174a9cd35160ed0ae5d7cb2af6d">2c90d2b4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_acl_tdb. Implement unlinkat().
Note this isn't identical to unlink() as
this must cope with (flags & AT_REMOVEDIR),
which is identical to rmdir(). It calls
either unlink or rmdir depending on the
flags parameter.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2a7e472e5ca02bb3c6685e38042b23ee27422a5a">2a7e472e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_acl_xattr. Implement unlinkat().
Note this isn't identical to unlink() as
this must cope with (flags & AT_REMOVEDIR),
which is identical to rmdir(). It calls
either unlink or rmdir depending on the
flags parameter.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/19c8cfa2871050c857c4ad8eecc8dd0f99cfafdb">19c8cfa2</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_posix_eadb. Implement unlinkat().
Note this isn't identical to unlink() as
this must cope with (flags & AT_REMOVEDIR),
which is identical to rmdir(). It calls
either unlink or rmdir depending on the
flags parameter.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/95197108becd184dbff61dc9929606f62460e98d">95197108</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_xattr_tdb. Implement unlinkat().
Note this isn't identical to unlink() as
this must cope with (flags & AT_REMOVEDIR),
which is identical to rmdir(). It calls
either unlink or rmdir depending on the
flags parameter.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4794e8dbb108d8fe7e09a11a5bf651dcdf55c2a2">4794e8db</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_cap. Implement unlinkat().
This is identical to unlink(), as there
are no special cases needed for rmdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f372f2f58c28ff08df3d47f810a9d4d6685662e5">f372f2f5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_catia. Implement unlinkat().
This is identical to unlink(), as there
are no special cases needed for rmdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/797f24fd4df288d9dee98c3bfdc0df1dd410931c">797f24fd</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph. Implement unlinkat().
Note this isn't identical to unlink() as
this must cope with (flags & AT_REMOVEDIR),
which is identical to rmdir(). It calls
either unlink or rmdir depending on the
flags parameter.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/34d7b18cdeda87b0d14e94b56bfc5664b2c9356d">34d7b18c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots. Implement unlinkat().
This is identical to unlink(), as there
are no special cases needed for rmdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0c16e77ae1ea0ef565c66e24297031db0b114710">0c16e77a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_extd_audit. Implement unlinkat().
This is identical to unlink(), as there
are no special cases needed for rmdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2a4eb0782b179d621821a8ecf020f9d0278a289d">2a4eb078</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit. Implement unlinkat().
Note this isn't identical to unlink() as
this must cope with (flags & AT_REMOVEDIR),
which is identical to rmdir(). It calls
either unlink or rmdir depending on the
flags parameter.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6c28a7749bb8c7c45db86647f5046d2df654653e">6c28a774</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit. Implement unlinkat().
This is identical to unlink(), as there
are no special cases needed for rmdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1ee6c9d8a42c9702914acf4d6f10342951cce7d5">1ee6c9d8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_glusterfs. Implement unlinkat().
Note this isn't identical to unlink() as
this must cope with (flags & AT_REMOVEDIR),
which is identical to rmdir(). It calls
either unlink or rmdir depending on the
flags parameter.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8c43f6179a92d8aab22de314626692eb1a9c8ab4">8c43f617</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_media_harmony. Implement unlinkat().
This is identical to unlink(), as there
are no special cases needed for rmdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8d9ff50f85cbcfb361ab6c4f78892ab09f60209f">8d9ff50f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_recycle. Implement unlinkat().
Note this isn't identical to unlink() as
this must cope with (flags & AT_REMOVEDIR),
which is identical to rmdir(). It calls
either unlink or rmdir depending on the
flags parameter.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1f8bdb3974c5eade55bf307077fb71bf0fac8147">1f8bdb39</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_recycle: Wrap recycle_unlink() into a call to recycle_unlink_internal().
Allows UNLINKAT parameters to be passed.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6f0cc51b1f5fc72734b7766302eb245b484dafc2">6f0cc51b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_recycle: Change recycle_unlink_internal() to call UNLINKAT().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/43b9d9adfe3ac5135bee4918e2769cf912e12b7d">43b9d9ad</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_shadow_copy2. Implement unlinkat().
This is identical to unlink(), as there
are no special cases needed for rmdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/62f92f8b29a4d860ee0062de27edb466f699633d">62f92f8b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper. Implement unlinkat().
This is identical to unlink(), as there
are no special cases needed for rmdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c81932fdfea44f466afc4726e5facd23ac92bbfa">c81932fd</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_depot. Implement unlinkat().
Note this isn't identical to unlink() as
this must cope with (flags & AT_REMOVEDIR),
which is identical to rmdir(). It calls
either unlink or rmdir depending on the
flags parameter.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7b2fda0576c76b1a63d08a9266620fe87a2ad587">7b2fda05</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_depot. Wrap Convert streams_depot_unlink() -> streams_depot_unlink_internal() so we can add parameters.
Make streams_depot_unlink() a wrapper calling the internal version.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e73caaed8226b5ca0c2603930928e36a5a97396d">e73caaed</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_depot: Change streams_depot_unlink_internal() to call UNLINKAT().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d7e763ef0558473a81cecd12abc0d50dd77c0b9f">d7e763ef</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_xattr. Implement unlinkat().
Note this isn't identical to unlink() as
this must cope with (flags & AT_REMOVEDIR),
which is identical to rmdir(). It calls
either unlink or rmdir depending on the
flags parameter.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0b3b83c15314859a121ebd4b1983b643fb3a490c">0b3b83c1</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_xattr. Wrap Convert streams_xattr_unlink() -> streams_xattr_unlink_internal() so we can add parameters.
Make streams_xattr_unlink() a wrapper calling the internal version.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d69a9ba7e3065ae57b7de588cf08fc1324ae5d07">d69a9ba7</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_xattr: Convert streams_xattr_unlink_internal() to use UNLINKAT.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/83e0cf6dc9a9017232c910940a46f8d196a2e641">83e0cf6d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_syncops. Implement unlinkat().
This is identical to unlink(), as there
are no special cases needed for rmdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b355a9565dcf67304db12aa827ca582d1dd80b89">b355a956</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_time_audit. Implement unlinkat().
This is identical to unlink(), as there
are no special cases needed for rmdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/70f5cbc54d7c99ea3709b77487d62ea565a99490">70f5cbc5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_unityed_media. Implement unlinkat().
This is identical to unlink(), as there
are no special cases needed for rmdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1023ec61a9deca7a81e0cb4960b51e9b2b917c51">1023ec61</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_virusfilter. Implement unlinkat().
This is identical to unlink(), as there
are no special cases needed for rmdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/488c65672350819e35a543313ca6c876befd1d6e">488c6567</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_audit. Implement unlinkat().
This is identical to unlink(), as there
are no special cases needed for rmdir().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/88249762a4b430e67d7d677b2258389351cc7099">88249762</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_posix_eadb: Wrap posix_eadb_unlink() into a call to posix_eadb_unlink_internal().
Allows UNLINKAT parameters to be passed. Change posix_eadb_unlink_internal()
to call UNLINKAT instead of UNLINK.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/96aeaed858164bb1387c41c954e841e911ba561c">96aeaed8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_virusfilter: Change UNLINK -> UNLINKAT in infected_file_action_delete()
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6ef40bdb94093f2a7afdd0d69bf0467d86660ec8">6ef40bdb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_acl_xattr: Don't call unlink_acl_common() directly.
Use a wrapper function so we can change the parameters.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/63d814047f7cf04be2ab0ab2b235d58d22cfbaa2">63d81404</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_acl_common: Add dirfsp, flags parameters to unlink_acl_common().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f8bdf5db6eb97458450392e2646db746a78b4d81">f8bdf5db</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_acl_common: Convert unlink_acl_common(), acl_common_remove_object() to UNLINKAT.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/244c3820a87e4273b1135959d197ec9fd30866a7">244c3820</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: cmd_vfs: Change cmd_pathfunc() to call SMB_VFS_UNLINKAT().
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/66d86efb9a19285a09940f4f359c80dfd59cddd6">66d86efb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change create_msdfs_link() to call SMB_VFS_UNLINKAT().
Use conn->cwd_fsp as current fsp. Rework to modern standards.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3d6a8d9ae0d55d92068c06651f6722b8158c25c8">3d6a8d9a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change remove_msdfs_link() to call SMB_VFS_UNLINKAT().
Use conn->cwd_fsp as current fsp. Rework to modern standards.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/56b355d07959923381e60c3fc51136cc4703876f">56b355d0</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: pysmbd: Change py_smbd_unlink() to call SMB_VFS_UNLINKAT().
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/24516e78eebbb30df09f85cdeacf6d1ad2635d32">24516e78</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change smb_set_file_unix_basic() to call SMB_VFS_UNLINKAT() in 3 places.
Use conn->cwd_fsp as current fsp. This is horrible code and must
be removed.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7f7ad9bbfd65f813f59b55e043c9e75859cb71e9">7f7ad9bb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change delete_all_streams() to call SMB_VFS_UNLINKAT().
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f8cff71e5f9edb97a3817bc259c0aeec6fbdba7f">f8cff71e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change close_remove_share_mode() to call SMB_VFS_UNLINKAT().
Use conn->cwd_fsp as current fsp. Rework to modern standards.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2adc0e0fdcd639a46008edff18371f181da93ed1">2adc0e0f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change recursive_rmdir() to call SMB_VFS_UNLINKAT().
Use conn->cwd_fsp as current fsp. Rework to modern standards.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3bf8181f159c142a45287e996167d11980508dd6">3bf8181f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change rmdir_internals() to call SMB_VFS_UNLINKAT() in 2 places.
Use conn->cwd_fsp as current fsp. Rework to modern standards.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1e6a8a3093ab118a4dc21344bfb4f41da18adc25">1e6a8a30</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:49+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit. Wrap Convert fruit_unlink() -> fruit_unlink_internal() so we can add parameters.
Make fruit_unlink() a wrapper calling the internal version.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/762b95743c1f60249451562251b7bbc0769eeab1">762b9574</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:49+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit. Add files_struct *dirfsp to fruit_unlink_internal() so we can call UNLINKAT.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/41a740f25120872e67240440f1f8c2f0c8763bbb">41a740f2</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:49+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit. Change fruit_unlink_internal() to call UNLNKAT.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/96842316788615a368b30f3808a0333678266453">96842316</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:49+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit: Wrap fruit_rmdir() so we can add parameters.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/92d8b3b847794ca5c5cd02c3c28b5f3d96540fdc">92d8b3b8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:49+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit: Add dirfsp files_struct pointer parameter to fruit_rmdir_internal().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cb5e52377ae344c63d0e28dc0531075cd1d77d6c">cb5e5237</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:49+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit: Convert fruit_rmdir_internal() to UNLINKAT().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7f49bb9f6ffc67fe40020344700b5f9ef657a7a0">7f49bb9f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:49+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit. Add files_struct *dirfsp parameter to fruit_unlink_meta().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/04ea1232996ddabe0ddb4a9dba56a7b8ba5262a2">04ea1232</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:49+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit. Add struct files_struct *dirfsp parameter to fruit_unlink_meta_stream() and convert to UNLINKAT.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e79ff5dcfe8455ab956f58c31cfffeede50d9bd3">e79ff5dc</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:49+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit. Add files_struct *dirfsp parameter to fruit_unlink_rsrc().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3b1d97555910a9782987a6ab6b0b09e8ac50b792">3b1d9755</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:49+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit. Add struct files_struct *dirfsp parameter to fruit_unlink_rsrc_stream() and convert to UNLINKAT.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/be586203fa5a1ecfece1d7f5390011c952d821df">be586203</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit. Add struct files_struct *dirfsp parameter to fruit_unlink_rsrc_adouble() and convert to UNLINKAT.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a3bd45212607aad0df244db9178153b949cd97ad">a3bd4521</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit. Change fruit_pread_meta_stream() to use UNLINKAT().
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6a55e676aa63f5ca86c53f849bab3d8fce877bc0">6a55e676</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit. Change delete_invalid_meta_stream() to use UNLINKAT().
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7691ce3a4b34b6a0b3f6cc2379f2f4d2b4392047">7691ce3a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: lib: adouble: Add struct files_struct *dirfsp parameter to ad_convert().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0535656284db66dc7bc90fea2f15b1d00a13fe10">05356562</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: lib: adouble: Add dirfsp to ad_convert_delete_adfile(). Use UNLINKAT instead of UNLINK.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1e51128424749eb68634376b01f87362d67b1186">1e511284</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_audit: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d4c4c688dd31ec3b27c1f6001fcc7baabb2d2f04">d4c4c688</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_cap: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/257137ee583d98b93ca09453d00931f7927ac32a">257137ee</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_catia: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/84255a99384e62dc9a950e978e85bd7c9987af98">84255a99</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6f9ede8ad82487c27e9253fe18eb9c20ad2918ab">6f9ede8a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_extd_audit: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/64854db8ac270acf16fa98f1b6ce26d19885795d">64854db8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_media_harmony: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/74ec7c804d8b3305f3a494b435d0d6ecec8cd4d7">74ec7c80</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:51+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_shadow_copy2: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eacfeac62ba086e7f615bb2849785b7d354a7d48">eacfeac6</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:51+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fc29eb2b8581019b9505c8646f1d3c2cda161554">fc29eb2b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:51+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_xattr: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b2f1b3d972602d0305b0e728200092567051def4">b2f1b3d9</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:51+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_time_audit: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/36f4d0f76e6b71a6f79ca0f3cab84b55c40028ec">36f4d0f7</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:51+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_virusfilter: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3bc8527cdc7a7958c8906044dbb0e7ad21f5e336">3bc8527c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:51+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_xattr_tdb: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7c814ef4299178f2d313ee12ea4a38429bbe991c">7c814ef4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:51+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_unityed_media: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/55df30d5a6345b333ee312d43b548ae50107471f">55df30d5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:51+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_recycle: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4dc8c378193f8a4a6fbb913fbb419a7949acc393">4dc8c378</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:51+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6f68049fff82e86554eb2ef8249a38e2ba4de2f7">6f68049f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:51+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_syncops: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/314358b28a573fce13750e17dd0b124a8d6a0a0e">314358b2</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:52+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_depot: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f856d6f41d199f93ba57c93f075a21efc89b27ec">f856d6f4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:52+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_glusterfs: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/467251ccf97561e9717d62080c0e81bfd2a1e11f">467251cc</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:52+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6f9b6a78671491055c9ce4b05039ba698a28abb1">6f9b6a78</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:52+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_posix_eadb: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7222d63d42fb5812197ad8f64a6af1557bd0a043">7222d63d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:52+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_acl_xattr: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eeec2b8003fb0c069188591249415077d8792d0a">eeec2b80</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:52+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_acl_tdb: Remove unlink_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f7f09377919cf39ccc803556b42b024874a92a2b">f7f09377</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T17:20:52+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit: Remove unlink_fn. No longer used.
NB, this will now fail smb_vfs_assert_all_fns()
until we remove the unlink_fn() from the VFS definitions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1ec030398bdc6f912d9beb3bcd0db7860a92eede">1ec03039</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-09-26T18:40:53+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Complete the replacement of SMB_VFS_UNLINK() -> SMB_VFS_UNLINKAT().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Sep 26 18:40:53 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/86a0e4850e02efc406ae5e1ee7cdc6a61eebef76">86a0e485</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-09-26T18:41:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc/ndr: add ndr_print_netlogon_samlogon_response()
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fd20153e8b095fa9a82a024c3f7bebd809ba132f">fd20153e</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-09-26T18:41:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-torture: dump ndr packet in ndr tests with high log level
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5550367e46d2ebb2bb0bb35fa51f34ca178d2907">5550367e</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-09-26T18:41:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-torture: remove duplicate NDR_PRINT
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6055134330d9e4226deb298c506dc6f792bf5d33">60551343</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/groupdb: clang: Fix 'Value stored during its initialization is never read'
Fixes:
ource3/groupdb/mapping.c:648:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_OK;
^~~~~~ ~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/368d0cecc0bc859e321335f46b22d4334e092da1">368d0cec</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/groupdb: clang: 'Value stored during its initialization is never read'
Fixes:
source3/groupdb/mapping_tdb.c:460:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_OK;
^~~~~~ ~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6831b6ba6f52dd865ecf09c575e4862f6dd3424b">6831b6ba</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/rpc_client: clang: Fix 'Value stored during initialization is never read'
Fixes:
source3/rpc_client/cli_pipe.c:397:11: warning: Value stored to 'ret' during its initialization is never read <--[clang]
NTSTATUS ret = NT_STATUS_OK;
^~~ ~~~~~~~~~~~~
source3/rpc_client/cli_pipe.c:1234:11: warning: Value stored to 'ret' during its initialization is never read <--[clang]
NTSTATUS ret = NT_STATUS_OK;
^~~ ~~~~~~~~~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c534b05c8d464940cd4d46c43d6549e86014143b">c534b05c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/winbind: clang: Fixes 'Value stored during its initialization is never read'
Fixes:
source4/winbind/idmap.c:214:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_NONE_MAPPED;
source4/winbind/idmap.c:397:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_NONE_MAPPED;
^~~~~~ ~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/752f5b63d0c4e0a7cdab74128ea54ade461d18d0">752f5b63</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/passdb: clang: Fix 'Value stored during its initialization is never read'
Fixes:
source3/passdb/pdb_util.c:41:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_OK;
^~~~~~ ~~~~~~~~~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2d47067c86303c43f3d7267394ef8a9ce49593d3">2d47067c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/passdb: clang: Fix 'Value stored during initialization is never read'
Fixes:
source3/passdb/pdb_tdb.c:718:18: warning: Value stored to 'nt_status' during its initialization is never read <--[clang]
NTSTATUS nt_status = NT_STATUS_UNSUCCESSFUL;
^~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/299eff4ac906846e8f7f605815792a9d4418f071">299eff4a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/passdb: clang: Fix 'Value stored during initialization is never read'
Fixes:
source3/passdb/pdb_interface.c:65:34: warning: Value stored to 'entry' during its initialization is never read <--[clang]
struct pdb_init_function_entry *entry = backends;
^~~~~ ~~~~~~~~
/source3/passdb/pdb_interface.c:140:11: warning: Value stored to 'nt_status' during its initialization is never read <--[clang]
NTSTATUS nt_status = NT_STATUS_UNSUCCESSFUL;
^~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/38aafe0d6bba0b7651600edfe2a799dcf7d1ed2d">38aafe0d</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/passdb: clang: Fix 'Value stored during its initialization is never read'
Fixes:
source3/passdb/lookup_sid.c:836:11: warning: Value stored to 'result' during its initialization is never read <--[clang]
NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ae2e9ce5c36c9e05f785b3fa7be22074fdc4213d">ae2e9ce5</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/rpc_client: clang: Fix 'Value stored during initialization is never read'
Fixes:
source3/rpc_client/cli_lsarpc.c:182:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_OK;
^~~~~~ ~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b08ec1903d2ebfdcdb83c0f6e042a6d3b06992c9">b08ec190</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/rpc_client: clang: 'Value stored during its initialization is never read'
Fixes:
source3/rpc_client/util_netlogon.c:71:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
source3/rpc_client/util_netlogon.c:199:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fba666cf2a5c83ee76432f0d0d44e867c62231ba">fba666cf</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/passed: clang: Fix 'Value stored during its initialization is never read'
Fixes:
source3/passdb/passdb.c:2502:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_INTERNAL_ERROR;
^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/35e0122e7c7f2cdfa0f6ac4f18a8cc7c42edab24">35e0122e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libads: clang: Fix 'Value stored to 'nt_status' is never read'
Fixes:
source3/libads/sasl.c:219:2: warning: Value stored to 'nt_status' is never read <--[clang]
nt_status = NT_STATUS_MORE_PROCESSING_REQUIRED;
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eb3ba3eeaa200660c7b48253083bffbe39d41a96">eb3ba3ee</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libads: clang: Fix 'Value stored during initialization is never read'
Fixes:
source3/libads/ldap_utils.c:52:13: warning: Value stored to 'status' during its initialization is never read <--[clang]
ADS_STATUS status = ADS_SUCCESS;
^~~~~~ ~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/50ff6c965f23457bfdefa53cd043166fdec899a5">50ff6c96</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'Value stored during its initialization is never read'
Fixes:
source3/libsmb/dsgetdcname.c:1012:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
source3/libsmb/dsgetdcname.c:1099:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9759e96ff1dc8741222eb6794dc01bd5b65c282d">9759e96f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/auth: clang: Fix 'Value stored during its initialization is never read'
Fixes:
source3/auth/auth_util.c:283:11: warning: Value stored to 'ret' during its initialization is never read <--[clang]
NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
^~~ ~~~~~~~~~~~~~~~~~~~~~~
source3/auth/auth_util.c:2005:11: warning: Value stored to 'nt_status' during its initialization is never read <--[clang]
NTSTATUS nt_status = NT_STATUS_OK;
^~~~~~~~~ ~~~~~~~~~~~~
2 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8ea0835a6cbe8721780929b9946de65cd87dc26d">8ea0835a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/auth: clang: Fix 'Value stored during its initialization is never read'
Fixes:
source3/auth/auth.c:38:35: warning: Value stored to 'entry' during its initialization is never read <--[clang]
struct auth_init_function_entry *entry = auth_backends;
^~~~~ ~~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/25c92111dcb646f8537d89fc2d091ee3c5753d56">25c92111</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib/netapi: clang: Fix 'Value stored during initialization is never read'
Fixes:
source3/lib/netapi/group.c:1383:11: warning: Value stored to '
status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_OK;
^~~~~~ ~~~~~~~~~~~~
samba/source3/lib/netapi/group.c:1521:11: warning: Value stored to '
status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_OK;
^~~~~~ ~~~~~~~~~~~~
samba/source3/lib/netapi/group.c:1718:11: warning: Value stored to '
status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_OK;
^~~~~~ ~~~~~~~~~~~~
3 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a3b9986fac270797be4dbd3d453add9d2107e953">a3b9986f</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib/netapi: clang: Fix 'Value stored during initialization is never read'
Fixes:
source3/lib/netapi/getdc.c:173:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/32d487d0746b0fc8888ed37dfbfae3245b269dd7">32d487d0</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libads: clang: Fix 'Value stored during its initialization is never read'
Fixes:
source3/libads/ldap.c:370:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
source3/libads/ldap.c:417:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
source3/libads/ldap.c:1783:13: warning: Value stored to 'ret' during its initialization is never read <--[clang]
ADS_STATUS ret = ADS_ERROR(LDAP_SUCCESS);
^~~ ~~~~~~~~~~~~~~~~~~~~~~~
source3/libads/ldap.c:1862:13: warning: Value stored to 'ret' during its initialization is never read <--[clang]
ADS_STATUS ret = ADS_ERROR(LDAP_SUCCESS);
^~~ ~~~~~~~~~~~~~~~~~~~~~~~
4 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/58400d6e65f70a256ebd900c3eca1c945b71be10">58400d6e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/talloc: clang: Fix 'Value stored during its initialization is never read'
Fixes:
ib/talloc/pytalloc_util.c:245:8: warning: Value stored to 'type_obj' during its initialization is never read <--[clang]
void *type_obj = talloc_check_name(ptr, type_name);
^~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9c16d8fb246911d7bbd576d7e6bce0c8fb39929f">9c16d8fb</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/rpc_client: clang: Fix 'Value stored during initialization is never read'
Fixes:
source3/rpc_client/cli_winreg.c:728:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_OK;
^~~~~~ ~~~~~~~~~~~~
/source3/rpc_client/cli_winreg.c:897:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_OK;
^~~~~~ ~~~~~~~~~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6ae0fd5a348224b2a7942c81c4ef21bf11205d62">6ae0fd5a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib/netapi: clang: Fix 'Value stored during initialization is never read'
Fixes:
source3/lib/netapi/user.c:1290:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_OK;
^~~~~~ ~~~~~~~~~~~~
source3/lib/netapi/user.c:1610:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_OK;
^~~~~~ ~~~~~~~~~~~~
source3/lib/netapi/user.c:2990:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_OK;
^~~~~~ ~~~~~~~~~~~~
source3/lib/netapi/user.c:3184:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_OK;
^~~~~~ ~~~~~~~~~~~~
source3/lib/netapi/user.c:3522:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_OK;
^~~~~~ ~~~~~~~~~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/388f280448b9ea459d8d884dbbbce54ab930da7b">388f2804</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/passdb: clang: Fix warning: Value stored to 'acct_ctrl' is never read
Fixes:
source3/passdb/pdb_ldap.c:922:3: warning: Value stored to 'acct_ctrl' is never read <--[clang]
acct_ctrl |= ACB_NORMAL;
^ ~~~~~~~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2138bd93bb258f2dde2c279a0ba80f9a40737aed">2138bd93</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: value stored to 'idx_current' is never read
Fixes:
source3/libsmb/trusts_util.c:602:2: warning: Value stored to 'idx_current' is never read <--[clang]
idx_current = idx;
^ ~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1ca110b547622f788d94530e0e3432845c2943bf">1ca110b5</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T18:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/passdb: clang: Value stored to 'c' is never read
source3/passdb/pdb_smbpasswd.c:405:4: warning: Value stored to 'c' is never read <--[clang]
c = '\0';
^ ~~~~
/home/samba/samba/source3/passdb/pdb_smbpasswd.c:809:4: warning: Value stored to 'c' is never read <--[clang]
c = '\0';
^ ~~~~
2 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/18e2d6b0098232c2bd8d51320095d35bd7301920">18e2d6b0</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-26T19:59:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'warning: Value stored to 'p' is never read'
Fixes:
source3/libsmb/cliconnect.c:649:2: warning: Value stored to 'p' is never read <--[clang]
p += ret;
^ ~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Sep 26 19:59:24 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/485874d6bb328c50c9a98785e85270f28ade7497">485874d6</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-09-27T16:07:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Test ID_TYPE_BOTH with idmap_rid module
ID_TYPE_BOTH means that each user and group has two mappings, a uid and
gid. In addition the calls to getpwent, getpwuid, getgrent and getgrgid
always return some information, so that uid and gid can be mapped to a
name. Establish a test to verify that the expected information is
returned.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14141
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/63c9147f8631d73b52bdd36ff407e0361dcf5178">63c9147f</a></strong>
<div>
<span>by Michael Adam</span>
<i>at 2019-09-27T17:25:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: provide passwd struct for group sid with ID_TYPE_BOTH mapping (again)
https://git.samba.org/?p=samba.git;a=commitdiff;h=394622ef8c916cf361f8596dba4664dc8d6bfc9e
originally introduced the above feature.
This functionality was undone as part of "winbind: Restructure get_pwsid"
https://git.samba.org/?p=samba.git;a=commitdiff;h=bce19a6efe11980933531f0349c8f5212419366a
I think that this semantic change was accidential.
This patch undoes the semantic change and re-establishes the
functionality.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14141
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Fri Sep 27 17:25:29 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ee6300470dc6113ac4d8a9fbb450da876eb0b07a">ee630047</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-09-30T23:12:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'Value stored during its initialization is never read'
Fixes:
source3/libsmb/cliconnect.c:1877:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_NO_MEMORY;
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/84fae0ed1bb7f2ec1fad8011d42211582e46565a">84fae0ed</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-10-01T00:28:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: passdb: ret doesn't seem to be needed at all
I was looking at the wrong hunk when examining this, ret seems redundant
and the existing status can cover things
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Oct 1 00:28:44 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/432202413f4d11d761c62f46a50747fcb9b6f0cf">43220241</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-02T08:01:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture:smb2: extend test for File-IDs
This now hopefully covers most possible combinations of creating and opening
files plus, checking the file's File-ID after every operation.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/300b47442b023532bd65417fcec04d811f40ef76">300b4744</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-02T08:01:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture:smb2: add a File-ID test on directories
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e1dfaa2b038d91e43d8d34bf1526b7728dba58a5">e1dfaa2b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-02T08:01:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: change the place where we call dos_mode() when processing SMB2_CREATE
This is needed for ordinary file or directory opens so the QFID create context
response gets the correct File-ID value via dos_mode() from the DOS attributes
xattr.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/49a754b82d33fb523cda4151a865584ae52a2e2f">49a754b8</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-02T08:01:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: when storing DOS attribute call dos_mode() beforehand
This is required to ensure File-ID info is populated with the correct on-disk
value, before calling file_set_dosmode() which will update the on-disk value.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d7dc85990a177954925644f9ff332b3481a03cc7">d7dc8599</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-02T08:01:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: rework a return expression into an if block
Needed to add additional stuff after the if block in the next commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6c1647ca7a2f68825c34e9ccc18b86ef911e14ac">6c1647ca</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-02T08:01:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: assert stream_name is NULL for POSIX paths
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f9fdb8a2a6b9ad0fbb89a9734e81a8b1f527966f">f9fdb8a2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-02T08:01:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: factor out stream name asserts to helper function
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2584b4cdeae3f83962cd11538cd4e441104c8274">2584b4cd</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-02T08:01:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: expand a comment with the function doc for is_ntfs_stream_smb_fname
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3f8bc1ce3e094f943363921c46803fd5ec9f73bb">3f8bc1ce</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-02T08:01:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: implement logic directly in is_ntfs_default_stream_smb_fname()
This allows changing the semantics of is_ntfs_stream_smb_fname() in the next
commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/780a8dcba998471bb154e8bae4391786b793e332">780a8dcb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-02T08:01:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: use strequal_m() in is_ntfs_default_stream_smb_fname()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/091e3fdab61217251de1cf5111f070ff295d1649">091e3fda</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-02T08:01:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: add is_named_stream()
Add a new utility functions that checks whether a struct smb_filename points to
a real named stream, excluding the default stream "::$DATA".
foo -> false
foo::$DATA -> false
foo:bar -> true
foo:bar:$DATA -> true
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/90a14c90c4bcede1ef5414e0800aa4c84cbcf1c9">90a14c90</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-02T08:01:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: ensure a created stream picks up the File-ID from the basefile
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c190f3efa9eb4f633df28074b481ff884b67e65f">c190f3ef</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-02T08:01:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: add a comment explaining the File-ID semantics when a file is created
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4b2e44a6ed7de9b1a25c3bf08de24dd49c7f6c1d">4b2e44a6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-02T08:01:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_default: use is_named_stream() for stream check
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/993d327f5d24305d96781afeb11855487323975d">993d327f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-02T08:01:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: use is_named_stream() in a a few places
This simplifies (and corrects) things in the VFS as there the caller is only
interested in whether a name is pointing to a real named stream most of the times.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f21af2ace2261fb6e4d4762bcd70784135b62ddb">f21af2ac</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-02T08:01:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove some unneeded #includes from tftw.c
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b66b8a74b100be85101a7383c634d0d96cf6b0ee">b66b8a74</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-02T08:01:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Fix CID 1453985: Null pointer dereferences (FORWARD_NULL)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/34a35ac15efee431a7848da51409f7dcdf95b48b">34a35ac1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-02T08:01:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix CID 1453984: Null pointer dereferences (REVERSE_INULL)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5d8493f5b459a7b91f9a5ca9dee00c968fab3d67">5d8493f5</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-02T08:01:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpc_client: Don't pass a NULL string to talloc_asprintf
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9dc2cd86f6993fd681513b1b251f5bbdb01212d4">9dc2cd86</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-02T08:01:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e3e5894b854b9fe5680f1028f2bcbb2a2cc01069">e3e5894b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-02T08:01:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Fix a comment
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/86672659c6a757263c7bf64d152f95d89222a3e7">86672659</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-02T08:01:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">epmapper: Fix printf specifiers
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/88f8edf69ba04b4df28d4986199fa13730d3a165">88f8edf6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-02T08:01:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_watch: Slightly simplify dbwrap_watched_fetch_locked()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/491b71f29b966d1fed65d5db1463353a19306db8">491b71f2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-02T08:01:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_watch: Move reallocating watchers to dbwrap_watched_watch_send()
Before 15a8af075a2 we did not have a separately allocated watchers
array and dbwrap_watched_save() could play (too) smart tricks with
dbwrap_record_storev(). Now that we always have watchers talloc'ed, we
can remove those smart tricks from dbwrap_watched_save() in the next
commit.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/64da66a75c688b0443b5d5afa4f73ac51b96c504">64da66a7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-02T08:01:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_watch: Remove "addwatch" handling from dbwrap_watched_save()
This has been moved to dbwrap_watched_watch_send()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/32d6cc84cf8e0cf278b5715b8a9d66b7c0a2a6d2">32d6cc84</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-02T08:01:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_watch: Don't alert ourselves, fix raw.oplock.batch26 race
This fixes the following flaky test:
UNEXPECTED(failure): samba3.raw.oplock.batch26(nt4_dc)
REASON: Exception: Exception: (../../source4/torture/raw/oplock.c:3718): wrong value for break_info.count got 0x2 - should be 0x1
You can reproduce it with two small msleeps, which means it's a race
condition:
diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 20b5a3e294c..126c7fc021d 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -1917,6 +1917,14 @@ NTSTATUS send_break_message(struct messaging_context *msg_ctx,
DATA_BLOB blob;
NTSTATUS status;
+ {
+ static bool sent = false;
+ if (sent) {
+ smb_msleep(500);
+ }
+ sent = true;
+ }
+
if (DEBUGLVL(10)) {
struct server_id_buf buf;
DBG_DEBUG("Sending break message to %s\n",
diff --git a/source3/smbd/oplock.c b/source3/smbd/oplock.c
index b3da84b1269..d9c4dbb9487 100644
--- a/source3/smbd/oplock.c
+++ b/source3/smbd/oplock.c
@@ -858,6 +858,8 @@ static void process_oplock_break_message(struct messaging_context *msg_ctx,
uint16_t break_to;
bool break_needed = true;
+ smb_msleep(100);
+
msg = talloc(talloc_tos(), struct oplock_break_message);
if (msg == NULL) {
DBG_WARNING("talloc failed\n");
15a8af075a2 introduced a bug where we immediately wake up ourselves
after doing a watch_send, leading to two inter-smbd oplock break
messages for this case. In theory, this should not matter, as in the
oplock break handler in the destination smbd we check
(fsp->sent_oplock_break != NO_BREAK_SENT)
so that the break does not get sent twice. However, with the above two
sleeps the oplock holding client could send out its oplock downgrade
while the second inter-smbd break messages was on its way.
The real fix would be to note in the share mode array that the
inter-smbd message has already been sent, but as other users of
dbwrap_watched_watch_send might also be affected by this bug, this fix
should be sufficient to get rid of this flaky test.
Unfortunately, dbwrap_watch.c is now pretty complex and needs some
serious refactoring to become understandable again. But that's
something for another day, sorry.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5642f288c895467e32a39430af709cc48198e7c1">5642f288</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-02T08:01:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Add MS-FSA style terminating '/' and '\\' test - SMB2-PATH-SLASH.
[MS-FSA] 2.1.5.1 Server Requests an Open of a File.
Checks how to behave on both files and directories.
Tested against Windows 10 server - passes. Currently smbd fails this.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/398cb8a56d83a7978836ee0b65b4747d190ab630">398cb8a5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-02T09:31:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Fix the SMB2 server to pass SMB2-PATH-SLASH.
[MS-FSA] 2.1.5.1 Server Requests an Open of a File
Windows pathname specific processing.
Always disallow trailing /, and also \\ on FILE_NON_DIRECTORY_FILE.
We need to check this before the generic pathname parser
as the generic pathname parser removes any trailing '/' and '\\'.
Currently this is SMB2 only, but we could also add this
check to the SMB1 NTCreateX calls if ultimately neded.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Oct 2 09:31:40 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8ca4fe65238f9b086cae842da13111596b9d0114">8ca4fe65</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-03T16:39:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpclient: Remove cmd_test
I can't even properly find why this went in. It's the only user of the
global rpcclient_cli_state, which can go if we remove this.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f74442b4b795d9c282cdf36e6e8ebc312bfe27ca">f74442b4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-03T16:39:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpcclient: Remove rpcclient_cli_state
An unneeded global
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3cac5c1bd4d47d143071891a0f21e242a28bd99f">3cac5c1b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-03T16:39:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpcclient: Move rpccli_try_samr_connects() to cmd_samr.c
That's the only user, make it static to cmd_samr.c
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dd108a171fe807b67fe8186cf96af18836bea451">dd108a17</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-03T16:39:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpcclient: Fix a comment
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cb0b54d9acb4a0021a09f90299fec1bad3b63107">cb0b54d9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-03T16:39:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpcclient: Make cmd_samr.c independent of global domain_sid
Pure SAMR allows us to figure out the domain sid, we don't need LSA
for this.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8a094672212eb49291ff6c8c9441a0a6c71c1561">8a094672</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-03T16:39:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpcclient: Remove domain sid check
The samr calls can take care of this on their own
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fe41238097f4354f18130c43ea3c5db0293097c7">fe412380</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-03T17:59:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">rpcclient: Remove unused global domain sid
For the auth_log tests using rpcclient this means one message less
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Oct 3 17:59:13 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/33f1c9d9654fbdcb99c23f9d23c4bbe2cc596b98">33f1c9d9</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-10-04T05:47:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-vacuum: Process all records not deleted on a remote node
This currently skips the last record.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14147
RN: Avoid potential data loss during recovery after vacuuming error
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a8c4e7d1f6b3375e2cdac962133919cce91f7c1d">a8c4e7d1</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T05:47:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Initialise request->rdata.opcode where missing
Otherwise it is uninitialised, so...
==22889== Conditional jump or move depends on uninitialised value(s)
==22889== at 0x12257B: ctdb_req_control_data_len (protocol_control.c:39)
==22889== by 0x1228E9: ctdb_req_control_len (protocol_control.c:1786)
==22889== by 0x12A51C: ctdb_client_control_send (client_control.c:101)
==22889== by 0x138BE1: ctdb_tunnel_setup_send (client_tunnel.c:100)
==22889== by 0x10EE4F: tunnel_test_send (tunnel_test.c:135)
==22889== by 0x10EE4F: main (tunnel_test.c:463)
and similar.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/815ae644006a11301c1ee81fdd4dcbf13de38141">815ae644</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T05:47:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-vacuum: Drop debug level of repacking message to NOTICE
This occurs rarely but can adversely impact performance, so it is
worth logging it more frequently.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2c54f6df7164d6263624a1ed72485bf4e6690bb6">2c54f6df</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T07:07:21+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Mark VacuumLimit tunable as obsolete
Use of this tunable was dropped over 5 years ago in commit
16837bc309aa9a86fc21d7f59a8fce0b947428a3.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Oct 4 07:07:21 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/65ca431c95e53e8686c2887d8c8ddaf67999305b">65ca431c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T09:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add functions for terminating tests on failure, skip, error
This allows standard exit codes for failed and skipped tests, and test
errors.
Skipped tests currently just succeed and a test error is the same as a
failure. These can be easily changed later when run_tests.sh is ready
to handle them.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/59055f4da1ac4747c771a8acf2392b5e4599679b">59055f4d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T09:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add function ctdb_test_on_cluster()
This centralises this logic. Use it in a subset of tests - there are
other cases but these will be cleaned up soon.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5ad356c282044db251c395db06900b249ff07544">5ad356c2</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T09:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add function ctdb_test_skip_on_cluster()
Use it in relevant tests.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/653b35764a2b4e999dbe6a71c1de2c9554d6fc4d">653b3576</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T09:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add cluster.bash include file
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/38138b42f7c42aca01dccd7b61784f0ddc2570f2">38138b42</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T09:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Update preamble for CLUSTER tests
The main change is to source cluster.bash instead of integration.bash.
While touching the preamble, the following additional changes are also
made:
* Drop test_info() definition and replace it with a comment
The use of test_info() is pointless.
* Drop call to ctdb_test_check_real_cluster()
cluster.bash now does this.
* Drop call to cluster_is_healthy()
This is a holdover from when the previous test would restart daemons
to get things ready for a test. There was also a bug where going
into recovery during the restart would sometimes cause the cluster
to become unhealthy. If we really need something like this then we
can add it to ctdb_test_init().
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e494eb3e8c054a7aa56d2f201459934d1248642a">e494eb3e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T09:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop unused function ctdb_test_check_real_cluster()
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/38b838b59cbece5c6a7bda40e8d411a6c56d1458">38b838b5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T09:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: try_command_on_node() should return status of command
There is no point folding this down to 1. Tests should be able to see
the original value, if required.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0ec83f32faddf6ef9f5fdd11ecd6d651459dd650">0ec83f32</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T09:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add new test functions for running commands on nodes
* ctdb_onnode()
* testprog_onnode()
* function_onnode()
These encapsulate familiar patterns found when running
try_command_on_node(). The new function names are more concise and
encourage more readable tests. Test writers can do less thinking
about the subtleties of running different types of commands on nodes.
For example, these functions ensure that $CTDB and $VALGRIND are used
in the correct contexts.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dc8ddbb0843abdc547055d57184e6cd1ba8e3147">dc8ddbb0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T09:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Switch TEST_CLEANUP and TEST_TIMEOUT to script variables
These are not used outside this script so they do not need to be
environment variables.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e7e6f4067e4a0de1ccfc8650fb0e87b8b6e0d620">e7e6f406</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T09:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Simplify ctdb_test_run()
Only the test file name is ever passed.
Reindent while touching many existing lines.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/47c9b79262ee4101d29c977d98933bfcf22f7426">47c9b792</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T09:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move use of show_progress() into ctdb_test_run()
This allows more variables to be set in this function because they are
no longer in a sub-shell.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/55dd0f047f58f9be2d1a317dfcbebe18e22201a0">55dd0f04</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T09:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move test status interpretation to ctdb_test_run()
It makes sense to do this in one place in case other headers/footers
are added.
Simplify ctdb_test_end() accordingly, reindenting because nearly all
lines are modified.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/473a6fed11a2e63d9cd557f63fdb646bd040deda">473a6fed</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T09:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add a special failure code when a test error occurs
Use it when a test is not executable.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/23982477f3d486815974edce08a247d7280c9578">23982477</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T09:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add handling for skipped tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/435d903ad84e72e8223ae53ca46bb47c1cfe1293">435d903a</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T09:41:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Move test duration calculation to ctdb_test_run()
It makes sense to do this in one place in case other headers/footers
are added.
Reindent ctdb_test_begin() while touching this function.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0bddee8dac095016e892731abe9e5a668c38375d">0bddee8d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-04T10:58:10+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Rename functions to test_header() and test_footer()
That's all they do now.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Oct 4 10:58:10 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bcbadeb82656fafb68b506a3067999c03c481cd2">bcbadeb8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-04T17:01:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ntvfs: Remove pvfs_aio.c
This uses the Linux libaio that does not meet Samba's needs. If
someone wanted to add async I/O to ntvfs, the io_uring API is the way
to go. Second option would be to use a pthreads-based API.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4b62c4f7addba3ce47f1d0d5f2b64103602b7ca2">4b62c4f7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-04T18:18:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/replace: Remove libaio support
io_uring is the way to go these days, libaio was never really useful
for Samba
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Oct 4 18:18:41 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ea82bca8cef0d736305a7a40b3198fc55ea66af8">ea82bca8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-07T08:13:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbclient: Stop an SMB2-connection from blundering into SMB1-specific calls.
Fix in the same way this was done in SMBC_opendir_ctx() for libsmbclient.
This fix means the admin no longer has to remember to set 'min client protocol ='
when connecting to an SMB2-only server (MacOSX for example) and trying to
list shares.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14152
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7eae4280d23404be7d27f65a0c817bea2e0084b6">7eae4280</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-10-07T08:13:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/auth: add test for gensec_schannel code
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/709d54d68a9c2cb3cda91d9ab63228a7adbaceb4">709d54d6</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-10-07T08:13:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/gensec: fix non-AES schannel seal
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14134
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f988756599c2f7253989f2ca1dea2975dd89e6ea">f9887565</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-10-07T08:13:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth/gensec: fix AES schannel seal and unseal
Workaround bug present in gnutls 3.6.8:
gnutls_cipher_decrypt() uses an optimization
internally that breaks decryption when processing
buffers with their length not being a multiple
of the blocksize.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7c2745d41e808b7240358f5d0702dfe7abdc93a1">7c2745d4</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-10-07T09:31:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/auth: add gnutls test for aes-128-cfb8 cipher bug
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Oct 7 09:31:35 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/222f2538636d247f6ca067e0f8a174799143b155">222f2538</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-07T11:48:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Improve sys/sysctl.h check to catch warning on glibc >= 2.30
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Oct 7 11:48:24 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/78161550bac4bdbbea7f187b70413c55ef62fad2">78161550</a></strong>
<div>
<span>by Gordon Ross</span>
<i>at 2019-10-07T22:05:59+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Allow running on FS that does not support EAs
Signed-off-by: Gordon Ross <gordon.w.ross@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Oct 7 22:05:59 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7bceafe8401fdbf67c065d6799ea91d9667fd096">7bceafe8</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-10-08T02:40:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/passdb: clang: Fix 'Value stored during initialization is never read'
Fixes:
source3/passdb/pdb_ldap.c:1933:11: warning: Value stored to 'ret' during its initialization is never read <--[clang]
NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
^~~ ~~~~~~~~~~~~~~~~~~~~~~
source3/passdb/pdb_ldap.c:4094:11: warning: Value stored to 'ntstatus' during its initialization is never read <--[clang]
NTSTATUS ntstatus = NT_STATUS_UNSUCCESSFUL;
^~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Oct 8 02:40:24 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/42edab7bd76022dd4d5338012f29aed29a2a2d89">42edab7b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-08T07:10:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">bootstrap: Remove pyhton2 packages
We dropped support for python2 in Samba already.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9cd0d15370142b3694a51fa9b6cfffdb8e08e886">9cd0d153</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-08T07:10:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">bootstrap: We can only build docker images on gitlab shared runners
Our rackspace runners don't provide a running docker.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c9d302f20b066267a8fd2d7ce4dc171161c9c40c">c9d302f2</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-08T08:27:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci: Add CentOS 8 to CI
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Oct 8 08:27:50 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5084a69de14f24e9d804998580eefcba773fdd5a">5084a69d</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2019-10-08T08:38:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Add SMB_VFS_FCNTL
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0abd1189a60eea4501b5279ebc4bff2b5689f888">0abd1189</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2019-10-08T09:57:19+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Use SMB_VFS_FCNTL to set fd flags in open_file()
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Oct 8 09:57:19 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5a084994144704a6c146b94f8a22cf57ce08deab">5a084994</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2019-10-08T12:50:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: create working private krb5.conf
DNS update tool uses private krb5.conf which should have enough details
to authenticate with GSS-TSIG when running nsupdate.
Unfortunately, the configuration we provide is not enough. We set
defaults to not lookup REALM via DNS but at the same time we don't
provide any realm definition. As result, MIT Kerberos cannot actually
find a working realm for Samba AD deployment because it cannot query DNS
for a realm discovery or pick it up from the configuration.
Extend private krb5.conf with a realm definition that will allow MIT
Kerberos to look up KDC over DNS.
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fa255a36df87e41717d9630ea96ac9439e186062">fa255a36</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-08T12:50:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: Check for gnutls_aead_cipher_encryptv2()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Simo Sorce <idra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/70fdd4821aa811f90944bee17cc85e3ae9302279">70fdd482</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-08T12:50:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Use gnutls_aead_cipher_encryptv2() for AES GCM or CCM
This is a new call which has been added with GnuTLS 3.6.10 and will
recuduce memory allocations and copying of data.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Simo Sorce <idra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4a24d9499757dea377b4e3d8beb7f2c10fd5c5d0">4a24d949</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-08T14:12:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Use gnutls_aead_cipher_decryptv2() for AES GCM or CCM
This is a new call which has been added with GnuTLS 3.6.10 and will
recuduce memory allocations and copying of data.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Simo Sorce <idra@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Oct 8 14:12:44 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/320b5be4dce95d8dac4b3c0847faf5b730754a37">320b5be4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-09T07:06:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs: Fix failure count in test_net_ads.sh
There are missing ` at the end of the line.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13884
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/456322a61319a10aaedda5244488ea4e5aa5cb64">456322a6</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-09T07:06:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Use ldap_add_ext_s() in ads_gen_add()
ldap_add_s() is marked as deprecated.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b84abb3a46211dc84e52ef95750627e4dd081f2f">b84abb3a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-09T07:06:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet: Require sealed LDAP SASL connections for joining
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8ed993789f93624b7b60dd5314fe5472e69e903a">8ed99378</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-09T07:06:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Cleanup error code paths in ads_create_machine_acct()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/35f3e4aed1f1c2ba1c8dc50921f238937f343357">35f3e4ae</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-09T07:06:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Use a talloc_asprintf in ads_find_machine_acct()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4f389c1f78cdc2424795e3b2a1ce43818c400c2d">4f389c1f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-09T07:06:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Fix detection if acount already exists in ads_find_machine_count()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b755a6438022579dab1a403c81d60b1ed7efca38">b755a643</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-09T07:06:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Don't set supported encryption types during account creation
This is already handled by libnet_join_post_processing_ads_modify()
which calls libnet_join_set_etypes() if encrytion types should be set.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ce7762935051c862ecdd3e82d93096aac61dd292">ce776293</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-09T07:06:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Fix creating machine account using LDAP
This implements the same behaviour as Windows.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13884
Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/39b8c8b30a5d5bd70f8da3a02cf77f7592788b94">39b8c8b3</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-09T07:06:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libnet: Improve debug messages
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/14f320fa1e40ecc3a43dabb0cecd57430270a521">14f320fa</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-09T07:06:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Just change the machine password if account already exists
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13884
Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/459b43e5776180dc1540cd845b72ff78747ecd6f">459b43e5</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-09T08:26:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs: Add test for 'net ads join createcomputer='
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Oct 9 08:26:17 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/873aa1e6c8495c04eb21cfc38fc5a4ad401f80fd">873aa1e6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T14:35:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: add Python mdssvc bindings
Not used for now, but soon.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b27d9afa29435b7af6335f228b8a315701b2607a">b27d9afa</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T14:35:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_client: add a mdssvc client library
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/213ca6e4cc981b4a9550042ce927c677883810be">213ca6e4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T14:35:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: add mdscli Python bindings
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/afc90321ecd47ec1a8b6196c9b4aa15c2c654d41">afc90321</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T14:35:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: add SAMBA_DATADIR as "samba" subdirectory of DATADIR
DATADIR should have been set to this path from the beginning, too late to change
that now as ut's used as parent for two other directory varialbles: SETUPDIR and
CODEPAGEDIR.
>From <https://www.gnu.org/prep/standards/html_node/Directory-Variables.html>:
datadir
The directory for installing idiosyncratic read-only
architecture-independent data files for this program. This is usually the
same place as ‘datarootdir’, but we use the two separate variables so that
you can move these program-specific files without altering the location for
Info files, man pages, etc.
This should normally be /usr/local/share, but write it as
$(datarootdir). (If you are using Autoconf, write it as ‘@datadir@’.)
The definition of ‘datadir’ is the same for all packages, so you should
install your data in a subdirectory thereof. Most packages install their
data under $(datadir)/package-name/.
Currently Samba doesn't install any application specific data files, but I'm
going to do just that in a subsequent commit.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/08cb82d26f8f1a0dc66fadfcdee4f487ea06e010">08cb82d2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T14:35:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: remove unused snum from struct sl_query
Looks like this was never used, it's also available via mds_ctx->snum.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ba899694e45aa2e691cf44098846fc0ddf3e79fd">ba899694</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T14:35:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: modernize a few DEBUG macros
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eb740b571d1ed5d55619c059160f236126351bd5">eb740b57</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T14:35:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: fix a long line
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c338bdf5a4aef16cb3048b18c77a0095f3fc3e53">c338bdf5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T14:35:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: add missing mds_ctx deallocation
The mds_ctx object was created in _mdssvc_open() as a talloc child of the pipe
which means as long as the pipe is connected it's not freed.
To ensure we do proper rundown of all resources including backend connections
and pending queries, we must free the mds_ctx object.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f5510d7db3816c6a18dc333e1ae7f505fca69815">f5510d7d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T14:35:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: add Elasticsearch backend
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f479e010961e652230c7e33876058c8fb82e9019">f479e010</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T14:35:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: add unit tests for the Spotlight to Elasticsearch parser
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f0e8dd1a08698884209873bb84002d7b34db016c">f0e8dd1a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T14:35:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: split fileserver testenv into simpleserver and fileserver
The simpleserver testenv continues to be built with minimal
dependencies. fileserver otoh will be built with bells and whistles including
JSON which I need for using the env as target for Spotlight tests.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/da7dec0a50fa5d9f6b92403d8703cd6b7a42159c">da7dec0a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T14:35:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: add end-to-end tests for mdssvc with a fake HTTP server
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c85cd5c4311512fff18b04267408eb60d7c8ecdf">c85cd5c4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T14:35:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:utils: add mdfind
A small command line tool to run macOS Spotlight searches against an SMB server
that runs the Spotlight mdssvc RPC service, including macOS and Samba.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fa4c3fd9341412a9fc4a53923bf52f7433c08079">fa4c3fd9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T14:35:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: add mdfind blackbox test
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bf02a935083c858490b9aecd8949f8a57918615a">bf02a935</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T14:35:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: rpc_server: enable mdssvc by default
Now that mdssvc is built by default and also tested in CI, enable it by default,
running as embedded service.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/91f397bec0dbc24b60f74e80ee413642d955d7bc">91f397be</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T14:35:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">mdssd: fix a debug message
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/78a2d95511357a5ea34473e6a6d98515b4344fb5">78a2d955</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T14:35:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: use a helper variable for the service type
No change in behaviour. Simplifies a subsequent logical change.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/63cbeaf0e7472a7321f27327091217c909864100">63cbeaf0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T14:35:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: fix service startup in deamon mode
Changes:
* Don't initialize the RPC service by calling setup_rpc_module() in the parent
mdssd. This is not needed in the parent, only in the worker childs.
* In the worker childs call setup_rpc_module() instead of init_rpc_module()
which ensures rpc_mdssvc_init() is called with the mdssvc callback which is
needed to initialize mdssvc via mdssvc_init_cb() -> init_service_mdssvc()
* Finally rpc_setup_mdssvc() is adjusted to be a noop if mdssvc is configured to
as external and when called by the main parent smbd via dcesrv_ep_setup() ->
setup_rpc_modules()
I've manually tested all 4 combinations of external=yes|no X module=yes|no with
the new mdfind command.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c9b6298249cd2f670e6953c9c3ef2e977f8bc565">c9b62982</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-09T15:52:55+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">mdssvc.idl: pass policy_handle as pointer
No change in behaviour, this just changes all functions to take the
policy_handle argument as pointer instead of passing it by value.
This is how all other IDLs pass it.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Oct 9 15:52:55 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b4cbdddfb8729b6aa4729ea31da6090dd9e71383">b4cbdddf</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-10T01:04:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix an uninitalized variable
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Oct 10 01:04:33 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9290510fe4d2b5ce88a6085e7047f1e6fafd6f5a">9290510f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_acl_xattr. Wrap rmdir_acl_common() by acl_xattr_rmdir() so we don't call it directly.
This will allow adding the extra dirfsp parameter to
rmdir_acl_common().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1c0c3b61038631f06795fcd9a1424a666b117db1">1c0c3b61</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_acl_common: Change acl_common_remove_object() to use UNLINKAT instead of RMDIR.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7f54bc8794b7dc48b1f0b4c500a144c830f3da74">7f54bc87</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Change rmdir_acl_common() to take a files_struct *dirfsp pointer.
Pass in the passed dirfsp if available, else handle->conn->cwd_fsp.
No logic changes.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0df3371e7a483fd286e96f95c8a4c227e2b686ab">0df3371e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_acl_common: Convert rmdir_acl_common() to use UNLINKAT instead of RMDIR.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4e028aeaff99b4fee71925bca8d3eae0a4841947">4e028aea</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_posix_eadb: Rename posix_eadb_rmdir() to posix_eadb_rmdir_internal().
Make rmdir_fn() a wrapper function. This will
allow us to add the dirfsp parameter.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3221bab80feff7f9e3af05c08f13ecb3a0cf8cde">3221bab8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_posix_eadb: Add a dirfsp parameter to posix_eadb_rmdir_internal().
Not yet used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a8507856ef1fc005a0fefa6e764663b48ec8ea1b">a8507856</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_posix_eadb: Convert posix_eadb_rmdir_internal() to call UNLINKAT() instead of RMDIR().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/881ee37c81c0b94c62c92cd4debf2fe52ad7cd63">881ee37c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_posix_eadb: Convert streams_depot_rmdir_internal() to call UNLINKAT() instead of RMDIR().
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/48ad93aec53e547de5919ec13056c7a4fd5cbf02">48ad93ae</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_depot: Rename streams_depot_rmdir() to streams_depot_rmdir_internal().
Make rmdir_fn() a wrapper function. This will
allow us to add the dirfsp parameter.
Fix DEBUG statement so it doesn't print the wrong function name.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d9091d8fa96645886e7fb35ac95ed0f5b2f5c72a">d9091d8f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_depot: Add a dirfsp parameter to streams_depot_rmdir_internal().
Not yet used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9c5dc89c0b1a3c33840428d04034abe4dcfbbd7b">9c5dc89c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_depot: Change RMDIR -> UNLINKAT inside stream_dir().
No logic change.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c6235f297e7da35411c0effa2394bdc679e433c9">c6235f29</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_depot: Change RMDIR -> UNLINKAT inside streams_depot_unlink_internal().
No logic change.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/576a143deb3aa2ab4ba183a8e81874d6210e9026">576a143d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit: Change fruit_rmdir_internal() to call UNLINKAT instead of RMDIR.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7991a12e3f2b76220ab9885a98f4b427f035af81">7991a12e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: cmd_vfs: Change cmd_pathfunc() to call SMB_VFS_UNLINKAT() in rmdir case.
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ca5e8938ce36835b5f381379560e77fb6cf9cf90">ca5e8938</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change recursive_rmdir() to call SMB_VFS_UNLINKAT() in rmdir case.
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4ce152f1c43a2eb5c96da2f24b3829e4118774e2">4ce152f1</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change rmdir_internals() to call SMB_VFS_UNLINKAT() in rmdir cases.
Use conn->cwd_fsp as current fsp.
No logic change for now.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/305f2b8d01c5e9ecaa599372f75656169e777c7f">305f2b8d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_xattr_tdb: Remove rmdir_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/44f9adc155fc59836580e1d9bc4820d547082fbd">44f9adc1</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_unityed_media: Remove rmdir_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/060eb647f437f4fefb4e511061e48dd62d0c3099">060eb647</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit: Remove rmdir_fn. No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/19a4c5a99334ac38becdf6197e154f98c0455ff6">19a4c5a9</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_acl_tdb: Remove rmdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/26eb0e70bc8aa12890cdc23c3ea6c2e0d408848b">26eb0e70</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_acl_xattr: Remove rmdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8a18518edead4c828a62615365c99624e4315e69">8a18518e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_audit: Remove rmdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b222c486b36e4cff7d827aedb90f5bfa5c3a9fd3">b222c486</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_cap: Remove rmdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b79c7d28738e5e9a33d5f7db9db61116295ac5d5">b79c7d28</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_catia: Remove rmdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/882babe6de7b6410434868294541492181b3b4aa">882babe6</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph: Remove rmdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/09d33f5b31f591c18a29be2265a4b536f3348c2b">09d33f5b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots: Remove rmdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ea386e13fc41cd1c42d6708b9898e74bfc8bb375">ea386e13</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_extd_audit: Remove rmdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5e1e58a1e7734f0b607c24b4f71a6f6224994bab">5e1e58a1</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_glusterfs: Remove rmdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ae28488fb0447d1e3135d5f9569a633fe75c4661">ae28488f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_media_harmony: Remove rmdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8e65a8c2e7ddbc3a53f7adf240cb2a31eb4fdc51">8e65a8c2</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_posix_eadb: Remove rmdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8bb2c7b8989411ac7ebd06ef6621b2a38acf7243">8bb2c7b8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_shadow_copy2: Remove rmdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a940c4c5ac180acf15d005fb3d4fa4a0b3e9b448">a940c4c5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper: Remove rmdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ffa09e09e87ff82d0091529230d9122358d70e96">ffa09e09</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_streams_depot: Remove rmdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/14e24881c4e2839e896c3b6e8b94ecc7a990947f">14e24881</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_syncops: Remove rmdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4fcd20cd6bfc646f4ee9319aae0bf6306f1c1a7c">4fcd20cd</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_time_audit: Remove rmdir_fn(). No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5bf96b1f0b61847771aab7be35121a1d5c15554e">5bf96b1f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T06:09:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_time_audit: Remove rmdir_fn(). No longer used.
NB, this will now fail smb_vfs_assert_all_fns()
until we remove the rmdir_fn() from the VFS definitions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/81fbba8f649e4115961eb77462ca450e7a30611e">81fbba8f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-10T07:26:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Complete the removal of SMB_VFS_RMDIR()
All users now use SMB_VFS_UNLINKAT(..., AT_REMOVEDIR).
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Oct 10 07:26:43 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f45ceb0df99afd7cdbf05cb8d0f00b0a1b5bdd0a">f45ceb0d</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-10-10T08:08:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Remove unused build of atsvc server
This avoids building server-side code we do not use and so makes the build
smaller and code auditing easier.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8216c2187f1efa9cf114f705252a452e5b6721d1">8216c218</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-10-10T08:08:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Remove s4 server build of initshutdown
We do not have a source4 varient of the initshutdown server, so do not generate
the code for it.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6250fe29dd63e803d0dc3cbd8cef5944bf9911d2">6250fe29</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-10-10T08:08:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Remove s4 server build of ntsvcs
We do not have a source4 varient of the ntsvcs server, so do not generate
the code for it.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/759660b16a75a43b910001f9e8502d180a4ba89e">759660b1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-10-10T08:08:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Remove server build of remact.idl
We do not have a server for the DCOM Remote activation service, so do not generate
the code for it.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/83fae584867babbb602da7096160bdc811dcf337">83fae584</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-10-10T08:08:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Add commnets on the split out of IDL files
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/718f9da0a7fb9f48660016a7baafecdb3ed6e4e0">718f9da0</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-10-10T08:08:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Remove s3 server build of unixinfo
We do not have a source3 varient of the unixinfo server, so do not generate
the code for it.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/091e8fe14b51c550ea9d8360651378ebb0e3491b">091e8fe1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-10-10T08:08:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Remove s4 server build of dfs
We do not have a source4 varient of the dfs server, so do not generate
the code for it.
DFS is very closely tied to SMB so we use the DFS server in
smbd.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c46191b8781b076ed872f14e01592997def44f89">c46191b8</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-10-10T08:08:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Remove client and server build of rot.idl
We do not have a client or server for this DCOM component so do not generate
the code for it.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b273924b8a2dd32a949f37be8ff53298bff81bb4">b273924b</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-10-10T08:08:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Remove client and server build of w32time.idl
We do not have a server for the Win32 Time Server so do not generate
the code for it.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d7bb9f54250f170ea18aad08a98862f7054d8579">d7bb9f54</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-10-10T08:08:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Remove server build of oxidresolver.idl
We do not have a server for this DCOM component so do not generate
the code for it.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/04b9369656d4a7cec1c12ea614286fbfc5495eb0">04b93696</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-10T09:41:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Mention performance improvements for SMB3 encryption
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Oct 10 09:41:26 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/834d528213d60a0fc5daed46ed0e51dad578b877">834d5282</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-10T18:56:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript: remove all checks for _FUNC and __FUNC
Those where historic artifacts not needed anymore.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/efb43ecb8e3994171efeb8f8b4231fdd420ace0b">efb43ecb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-10T20:13:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript: split function check to one per line and sort alphabetically
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Oct 10 20:13:25 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/37daeb220e461b842ad9708497699f15c5fa5df3">37daeb22</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-10-12T14:33:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">spnego: ignore server mech_types list
We should not use the mech list sent by the server in the last
'negotiate' packet in CIFS protocol, as it is not protected and
may be subject to downgrade attacks.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7e36de99d7d028a01d4c52c2974d990ef91017bb">7e36de99</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-12T14:33:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: Do not check the SPNEGO neg token for KRB5
The list is not protected and this could be a downgrade attack.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
Pair-Programmed-With: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/90f557f3a1ed0a49e88ab0db29999f1289486cfe">90f557f3</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-10-12T14:33:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: s3: add a test for spnego downgrade from krb5 to ntlm
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d7e57ef7dd7d583cffb7abbe42d71f4f33f2a9af">d7e57ef7</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-10-12T14:33:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">spnego: add client option to omit sending an optimistic token
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/02f538816b409f1a122fae8fd08d761e3617e798">02f53881</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-10-12T14:33:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: add tests for no optimistic spnego exchange
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eee1e8b6ac622e22a34ebfb684e70626cdd20fc1">eee1e8b6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-10-12T14:33:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/gensec: make it possible to add knownfail tests for gensec.update()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8a96359977249e8b19f50e5f2fe3f6ad7b7da52f">8a963599</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-10-12T14:33:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests/gensec: add spnego downgrade python tests
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/23ea12e98ed34d41aee78d8afbe574dfc7e0ff74">23ea12e9</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-10-12T15:51:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">spnego: fix server handling of no optimistic exchange
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Sat Oct 12 15:51:42 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d888655244b4d8ec7a69a042e0ff3c074585b0de">d8886552</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-12T16:18:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:krb5_wrap: Do not create a temporary file for MEMORY keytabs
The autobuild cleanup script fails with:
The tree has 3 new uncommitted files!!!
git clean -n
Would remove MEMORY:tmp_smb_creds_SK98Lv
Would remove MEMORY:tmp_smb_creds_kornU6
Would remove MEMORY:tmp_smb_creds_ljR828
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a06889f6d774ba62be2103da2340b98b3ada6654">a06889f6</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-12T16:18:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:selftest: Do not print the target env twice
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/46068d5f289948a7d478c23391e0036f69d693a4">46068d5f</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-12T16:18:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci: Run several AD tests with MIT KDC
This will avoid introducing regressions in either client or server code.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0cad882380cc361a4106dc12aeb0582a6dccdd88">0cad8823</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-12T16:18:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:selftest: Do not print the target env twice
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/93c2b446755bd89c7ace8c6ee0445a361f8e17ca">93c2b446</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-12T16:18:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs: Add test for kinit with canonicalization
Pair-Programmed-With: Isaac Boukris <iboukris@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/123584294cfd153acc2d9a5be9d71c395c847a25">12358429</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-12T17:39:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Do not turn on canonicalization flag for MIT Kerberos
This partially reverts 303b7e59a286896888ee2473995fc50bb2b5ce5e.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14155
Pair-Programmed-With: Isaac Boukris <iboukris@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Sat Oct 12 17:39:13 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c16cc9a7ef3dc50df511d6a39437347ebc36383e">c16cc9a7</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-14T07:41:51+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">audit_logging: Don't spam the logs if dsdb_event is not found
This gets only registered by our tests.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Oct 14 07:41:52 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2dbc68e2c0212e3e14f304e359d4d0b1ab514ce2">2dbc68e2</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-15T18:46:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: set_nt_acl(). Now we know we always have a valid file handle, always use VFS_FCHOWN.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/99bfdb6e81925760af2a6e89fc6ac55768c88b78">99bfdb6e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-15T18:46:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove vfs_chown_fsp().
No longer used. This gets rid of another case
where we were playing directory changing games
that are eliminated by just using a file handle.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/634a4d13e197e01ae509c88bd6c6487008a86f71">634a4d13</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-15T18:46:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: pysmbd: Change py_smbd_chown() to use SMB_VFS_FCHOWN() internally.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/177f15ebb9e29a4cc6843a300f3da0ba7530332d">177f15eb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-15T18:46:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Remove cmd_chown() - can be replicated by cmd_open()->cmd_fchown().
Last user of SMB_VFS_CHOWN() in the codebase.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2eca6d5b9551bd387e809fc77e496a2dc2c1595a">2eca6d5b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-15T18:46:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_cap: Remove chown_fn().
No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/48335c1f69076ffa7bdbca99a5025f61148506fd">48335c1f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-15T18:46:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_catia: Remove chown_fn().
No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/95a6505e1bcbe89d0d39286668b04b948b1bed4f">95a6505e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-15T18:46:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph: Remove chown_fn().
No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3f8f797975931854e485fbf649b75897f0d6f775">3f8f7979</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-15T18:46:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_ceph_snapshots: Remove chown_fn().
No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/774b8f9ffb287c6011518caf341fed4538bc8eb5">774b8f9f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-15T18:46:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fake_acls: Remove chown_fn().
No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3a853a1d3b5b6c8d82a7887b35fd383bab0c6c1b">3a853a1d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-15T18:46:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_fruit: Remove chown_fn().
No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3e8f319606b898b803c1368154c87ee41dc2c78b">3e8f3196</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-15T18:46:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_glusterfs: Remove chown_fn().
No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3e2c2fdf0271e48538d8004ef03aac7e9d6eec3f">3e2c2fdf</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-15T18:46:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_media_harmony: Remove chown_fn().
No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1516e9e2859bb33bec5e829c1ca9011c2563d801">1516e9e2</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-15T18:46:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_shadow_copy2: Remove chown_fn().
No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/04e70da30b2166a5cfc73484cb156c66d4e1faf5">04e70da3</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-15T18:46:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_snapper: Remove chown_fn().
No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ce63e83a6af38a0ac5e353a0cfd6c6cc1d2daa13">ce63e83a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-15T18:46:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_cap: Remove chown_fn().
No longer used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bd807d4684b48047ab2241602bb46af38a9d0f33">bd807d46</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-15T18:46:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_time_audit: Remove chown_fn(). No longer used.
NB, this will now fail smb_vfs_assert_all_fns()
until we remove the chown_fn() from the VFS definitions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e2863a7e395bc5b73f8d9ef7bca7c21f20c7eeb3">e2863a7e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-15T18:46:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit: Remove chown_fn(). No longer used.
NB, this will now fail smb_vfs_assert_all_fns()
until we remove the chown_fn() from the VFS definitions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b01169ff32188939752c064e2eb803f57a837522">b01169ff</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-15T20:07:51+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Complete the removal of SMB_VFS_CHOWN()
No longer used anywhere.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Oct 15 20:07:51 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d473f1e38c2822746030516269b4d70032cf9b2e">d473f1e3</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-10-16T09:33:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: Link stress-nss-libwbclient against pthread
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7259197bf716f8b81dea74beefe6ee3b1239f172">7259197b</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-10-16T09:33:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: Link libsmb against pthread
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f0abf62adcf4bda6dd7b36ce74695f8ac8ec79f6">f0abf62a</a></strong>
<div>
<span>by Bryan Mason</span>
<i>at 2019-10-16T10:55:04+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:tests: Add smbspool test for CUPS-like "sanitized" Device URI in argv[0]
Before calling a backend like smbspool, CUPS will set argv[0] to the
"sanitized" Device URI (the Device URI with username/password
information removed). These changes are intended to catch problems
with smbspool that may be created by this behavior (like
https://bugzilla.samba.org/show_bug.cgi?id=14128).
source3/script/tests/smbspool_argv_wrapper.c: added to emulate
CUPS-like behavior by setting argv[0] to the device URI before
exec()ing smbspool.
source3/script/tests/test_smbspool.sh: updated to use
smbspool_argv_wrapper to test the CUPS-like behavior described above.
Signed-off-by: Bryan Mason <bmason@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Oct 16 10:55:04 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d023b29876dc1449014c3cf5d19abb6f186e166c">d023b298</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-10-16T15:41:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Disable RTLD_DEEPBIND if running with ASAN
Disable the RTLD_DEEPBIND option for dlopen in LDB and Socket Wrapper when
running with AddressSanitizer. The RTLD_DEEPBIND option is not compatible
with Address Sanitizer see
https://github.com/google/sanitizers/issues/611
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Oct 16 15:41:41 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eb093c5d2ac77889215356ffabb915861cd4e9d5">eb093c5d</a></strong>
<div>
<span>by Amit Kumar</span>
<i>at 2019-10-16T16:39:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Don't abort when receiving a NULL SID
Source code in winbind_rpc.c states that if the trusted domain
has no SID, winbindd just aborts the session. This happens with
MIT Kerberos realm added as trust to AD and winbindd just returns
without processing further as there is no SID returned for the
Linux system having kerberos support.
This fix makes winbindd to skip the domain having NULL SID instead
of aborting the request completely.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13913
Signed-off-by: Amit Kumar <amitkuma@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/50cce842a230f82018be62fca8fe1374b9b0dcd1">50cce842</a></strong>
<div>
<span>by Amit Kumar</span>
<i>at 2019-10-16T16:39:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Add 'net gpo command' text in man net
This change adds contents to man net for 'net ads gpo' command
set based on results got after executing:
'# net ads gpo help' and subcommands
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13986
Signed-off-by: Amit Kumar <amitkuma@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aed4d0637675629a33585a0198c8cbbb64371638">aed4d063</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-10-16T18:00:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli smb smb1cli_trans: fix ubsan warning
Fix ubsan warning null pointer passed as argument 2 when the source
pointer is NULL. The calls to memcpy are now guarded by an
if (len > 0)
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Oct 16 18:00:31 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dd43bb96fda3c030662b810fd82bafb03ac93aa2">dd43bb96</a></strong>
<div>
<span>by Amit Kumar</span>
<i>at 2019-10-17T07:58:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: Add 'ads dns command' text in man net
This change adds contents to man net for 'ads dns' command set.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14009
Signed-off-by: Amit Kumar <amitkuma@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6bd2f0e9c4da1cad10a778da0c86e14d69ad5036">6bd2f0e9</a></strong>
<div>
<span>by Amit Kumar</span>
<i>at 2019-10-17T07:58:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs: modifies 'net ads dns gethostbyname -h' Changes server to nameserver and name to hostname.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14009
Signed-off-by: Amit Kumar amitkuma@redhat.com
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aacbd383b9e843b5d36b91ef75f6f2d2724a438b">aacbd383</a></strong>
<div>
<span>by Amit Kumar</span>
<i>at 2019-10-17T09:21:20+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: Update 'samba-tool gpo list <>' description
We have a command to get gpo listing from Active Directory.
samba-tool gpo list <username>
This command can list GPOs for both username and machinename,
But command help only shows 'username'.
This PR
- Updates the option presented in help.
- Updates name of variable used to retrieve GPO so that it's
not misleading if someone reads code later on
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14016
Signed-off-by: Amit Kumar <amitkuma@redhat.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Oct 17 09:21:20 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/68155811aba10a498cc07bf8a1c6f3a092e6147c">68155811</a></strong>
<div>
<span>by Rowland Penny</span>
<i>at 2019-10-17T12:21:55+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: Add facility to add rfc2307 attributes to an already created user or group
Signed-off-by: Rowland Penny <rpenny@samba.org>
Reviewed-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlet <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Oct 17 12:21:55 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/799a1f65f6cc80256b6e140b7763396d76d4a830">799a1f65</a></strong>
<div>
<span>by Michael Hanselmann</span>
<i>at 2019-10-18T07:31:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Build registry parsing code into subsystem
Fuzzing code will make use of the "reg_parse_fd" function. By building
it into the "SMBREGISTRY" subsystem it can just be linked and
"reg_parse.c" doesn't need to be explicitly included.
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e477a94ffd3795d7d8aa83e899e9b0f2f9860a79">e477a94f</a></strong>
<div>
<span>by Michael Hanselmann</span>
<i>at 2019-10-18T07:31:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add fuzzing binary for reg_parse
A temporary file is used to store the fuzzing input.
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6b6df73b4ce20286b1b7370750d11d0d648d7752">6b6df73b</a></strong>
<div>
<span>by Michael Hanselmann</span>
<i>at 2019-10-18T07:31:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">regfio: Allow ignoring of checksum
In order to get good coverage fuzzing code has to either calculate
checksums correctly or to disable their verification. This change
implements the latter for the "REGF_FILE" structure used by the
"regfio_*" family of functions.
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a42a5a42f79cc886d752de1645638e24c600c4d0">a42a5a42</a></strong>
<div>
<span>by Michael Hanselmann</span>
<i>at 2019-10-18T07:31:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add fuzzing binary for regfio
Checksums are better ignored during fuzzing, hence a flag is added to
the regfio parser to disable checksums.
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f9c39237adfaf1ea223e5c810d019f433af95cf0">f9c39237</a></strong>
<div>
<span>by Michael Hanselmann</span>
<i>at 2019-10-18T07:31:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add fuzzing binary for lzxpress
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/de7c78335de63f95f97f946aec287b7bb87f6b47">de7c7833</a></strong>
<div>
<span>by Michael Hanselmann</span>
<i>at 2019-10-18T07:31:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add fuzzing binary for ldap_decode
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c4e902be7226e596d7bbba8baf4389eeab0ca8b6">c4e902be</a></strong>
<div>
<span>by Michael Hanselmann</span>
<i>at 2019-10-18T07:31:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add fuzzing binary for ldb_parse_tree
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/25b1e478ec5e8ac40d41013a824311824482fa67">25b1e478</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2019-10-18T08:54:04+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/dump_core: Have a newline towards the end of log message
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
Autobuild-User(master): Uri Simchoni <uri@samba.org>
Autobuild-Date(master): Fri Oct 18 08:54:04 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/517342399c0a558fc016d06ce7728f3c56ef952e">51734239</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-10-18T09:26:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Change LDB_TYPESAFE_QSORT() to TYPESAFE_QSORT() in repl_meta_data module
This call does not use the context argument so no additional parameter is needed.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5bc35614253b4769590813249274355fd3d2ae53">5bc35614</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-10-18T09:26:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-rpc_server: Change LDB_TYPESAFE_QSORT() to TYPESAFE_QSORT() in getncchanges
This call does not use the context argument so no additional parameter is needed.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7c83b1ade7a79770689d876e985e245f5af276ad">7c83b1ad</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-10-18T10:58:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Change LDB_TYPESAFE_QSORT() to TYPESAFE_QSORT() in operational module
This call does not use the context argument so no additional parameter is needed.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Oct 18 10:58:45 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d495074ee27a5f528d5156a69800ee58d799b1eb">d495074e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-18T16:07:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: Ensure SMB1 cli_qpathinfo2() doesn't return an inode number.
The info level it uses doesn't return that, previously we
were using the field that is returned as the EA size as
the inode number (which is usually zero, so the code in
libsmbclient would then synthesize an inode number from
a hash of the pathname, which is all it can do for SMB1).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14161
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8e55a8562951924e4b1aad5a6d67fc8b309590c1">8e55a856</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-18T16:07:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Ensure SMB1 cli_qpathinfo2() doesn't return an inode number..
Piggyback on existing tests, ensure we don't regress on:
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14161
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9a02c31deb1a295a5cf403aba378057dfcd44268">9a02c31d</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-10-18T16:07:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Explicitly refuse to truncate unix domain socket paths
This avoids creating a socket like:
.../winbindd_privileged/p
instead of
.../winbindd_privileged/pipe
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8bc228900e8cbc271543add56a2fc98002548a55">8bc22890</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Add header inclusion guards in globals.h
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8b761b126c1a476a2ac36c90c87d0183ba34f4a8">8b761b12</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:printing: Add header inclusion guards in queue_process.h
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e70dbe7d8aad650c6f14e7d78dca522d1ac9d898">e70dbe7d</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:printing: Add spoolssd header file
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/27b01d0aa362b3b226696b9ab7df855fe6fd1ab9">27b01d0a</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tstream_npa: Set local server name in auth requests
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f43e08259c0f41d598f6c7632195e67f80a1f82b">f43e0825</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Add braces
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e4b1354066f302475975006f5dfa8736ca34396e">e4b13540</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Fix torture comment
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/61aaebaa356102eccd996b6c6cd2641354caa2d3">61aaebaa</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Assert connection
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d572219e1bfcd9342f0841b4faa446fd41bbb42d">d572219e</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Fix debug string printing duplicated function name
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4d7a916189c8d910c22eb46c9fe0f061d83cab59">4d7a9161</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Cleanup includes
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3d529762df48205f91e4089178f7aeae240d0da8">3d529762</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Rename common/reply.c to dcesrv_reply.c
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3d7167f4f43f5cf8ca4393d8d852bd146bf05cde">3d7167f4</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Remove imessaging_context from dcerpc core structs
Add a helper function to retrieve the imessaging_context from the
stream connection.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f402b937f4862843015686b8e28504fe588d0c5f">f402b937</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Remove server_id from dcerpc core structs
Add a helper function to retrieve it from the stream connection.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/83def9a945f40892aaf0e4ea6ea7845d74bbaf7c">83def9a9</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Split dcerpc_generic_session_key for server and client
Split the common bits of dcerpc_generic_session_key to librpc and rename
client the specific part to dcecli_generic_session_key.
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b6c8afa98c5c1f9853b09fd83b039aacc79700db">b6c8afa9</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:librpc: Rename ncacn_push_auth to dcerpc_ncacn_push_auth
Next commit will move this function to common librpc
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ae9956a65e6913a73dfa68e2b5deebfeaf52c0e5">ae9956a6</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Move dcerpc_ncacn_push_auth from s4 librpc to common librpc
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/63b78894618a9badac595fbc59cea0f097feeded">63b78894</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Move dcerpc_log_packet from s4 librpc to common librpc
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6fcf8038e49ed7f0996ad21fb9f516de30131df7">6fcf8038</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Do not include s4 librpc headers in dcerpc core
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bf097719534be55abaab931ca03b8be23ef1fe0a">bf097719</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Add dcesrv_context_callbacks to dcesrv_context
Add a new struct dcesrv_context_callbacks in dcesrv_context to hold pointers
to functions whose implementation will differ between S3 and S4.
The log_successful_dcesrv_authz_event implementation will differ as it
requires an imessaging_context.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6fe23fa071d2dc6e348b175b514c99a6ce82b6f4">6fe23fa0</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Hide gensec prepare behind function pointer
This function will be different for s3 and s4
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b0ecc8ef55dc7e8c7ce9f7f3ca325358f62debfb">b0ecc8ef</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: inline the dcesrv_assoc_group_find function
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/55ad4ae7ffcb3221675070b9cb939c29e00f25f4">55ad4ae7</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Find association groups through context callbacks
Split the association group management from the server code, the s3 and
s4 implementation will handle differently.
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/85de73354d982861cc863b4682a8043c22797faa">85de7335</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Add transport termination function pointer
As the dcesrv_terminate_connection function will be moved to the shared
rpc server core library, hide the stream_terminate_connection call behind
a function pointer.
The s3 implementation will define its own termination function.
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0523f0b4d28ca125c207448167608d170b9c0909">0523f0b4</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Add public function dcesrv_connection_loop_start
This function starts the server loop and will be called from s3 and s4
implementations.
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/480dd6163b28d97ba89ceccbf84d7a730d7017aa">480dd616</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Make functions public
These functions will be moved to core dcerpc library and called from
s4 and s3 implementations.
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3f33fdf2e36742ec98e3406f2ecaaa4758ce2a51">3f33fdf2</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Add new dcerpc server core library
Next commits will move the core of s4 rpc server to this library.
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/076ec9173efc2b666be36630e38beab4624638a8">076ec917</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Move core structures and prototypes to core library
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/491102b5b2ca56375d5a58e98f1c037298aa89f3">491102b5</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Move core functions to core library
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/52727543b05c80742e187014ce1048fe7b104bdc">52727543</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc:core: Set debug class
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6a6546b565793341f3be6a6fcf30a40a186f9ae9">6a6546b5</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc:core: Allocate struct dcesrv_interface with talloc
The S3 implementation needs to reinit the dcesrv_context and free the
endpoints list with their registered interfaces.
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/73948df2f1a5dbef0f073933be549e4320013913">73948df2</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc:core: Initialize static variable
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/08c663828c9482767b5128820f8204fd0fe4654e">08c66382</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc:core: Rename find_endpoint to dcesrv_find_endpoint
This function will be public and available for s3 and s4 implementations.
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e10028a05000f6b7a2a8252352ad5f720ad23e86">e10028a0</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T16:07:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc:core: Return NTSTATUS for dcesrv_find_endpoint
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/50f69b60549b5d963e83a96315953e074517c096">50f69b60</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-10-18T17:30:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc:core: Make dcesrv_find_endpoint public
Will be used from s3 implementation when a connection is passed to other
process where a particular association group was created.
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Oct 18 17:30:39 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/75433f60522b935adb8c14fc6d0caa14c85281b3">75433f60</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-18T21:06:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_watch: Test cleanup of dead watchers
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0afd655e80262ea8505a2e6d0dd9cc453fbdfd8c">0afd655e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-18T22:28:07+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_watch: Fix cleaning up dead watchers
"wrec->num_watchers" changes in dbwrap_watch_rec_del_watcher(). In
32d6cc84c I forgot to update the copy of that variable.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Oct 18 22:28:07 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/09e282ec8173f2935bdb579e0396f269ce712e0d">09e282ec</a></strong>
<div>
<span>by Uri Simchoni</span>
<i>at 2019-10-20T12:06:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: upgrade to 2.0.18
This is required to get the new test_args parameter to conf.check, which
facilitates passing arguments to configuration test programs.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e00e93350288dc212fed3f1be2adf78dcb6e58e7">e00e9335</a></strong>
<div>
<span>by Uri Simchoni</span>
<i>at 2019-10-20T12:06:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: use test_args instead of exec_args to support cross-compilation
exec_args seems to have been a custom addition to Samba's copy of waf.
Upstream Waf has an identically-purposed parameter called test_args.
This parameter is being used for addiing runtime args to test programs that
are being run during configuration phases.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5a4ade953420a4122c80d291ac53310abd6a279c">5a4ade95</a></strong>
<div>
<span>by Uri Simchoni</span>
<i>at 2019-10-20T12:06:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: avoid pre-forking if cross-compilation is enabled
Waf supports pre-forking to run configuration tests, but this
doesn't play well with Samba's cross-compilation support, because
Samba monkey-patches the actual fork+exec, which doesn't happen
in a pre-forked process pool.
This patch emulates the impact of WAF_NO_PREFORK env var when
cross-compilation is enabled.
The blueprint for the solution has been suggested by Thomas Nagy
in https://bugzilla.samba.org/show_bug.cgi?id=13846#c7 (item #2)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fdfd69840902f4b13db2a204a0ca87a578b61b85">fdfd6984</a></strong>
<div>
<span>by Uri Simchoni</span>
<i>at 2019-10-20T12:06:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: pass environment to cross-execute tests
This can come in handy for cross-execute scripts in general, and
is particularly required by the samba-xc test for cross-answers /
cross-execute, because Samba sets LD_LIBRARY_PATH during rpath
checks, and the test program needs that in order to successfully
run.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/649d15bb969b6d27fd4554f49600366bb3df4712">649d15bb</a></strong>
<div>
<span>by Uri Simchoni</span>
<i>at 2019-10-20T13:29:58+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: harden samba-xc test suite
Add more checks which directly test the behavior of
--cross-answers and --cross-execute.
Previous test tested things in a round-about way, checking
that running in all three modes (native, cross-execute,
cross-answers) yields the same result. It was vulnerable
to a degradation in which cross-compilation modes didn't
work at all and were running native tests, which is
what happened with the upgrade of waf.
The added tests check the following:
- That cross-excute with cross-answers sets the cross-answers file
- That the content of cross-answers file actually affects the build
configuration
- That a missing line in cross-answers fails the build
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Uri Simchoni <uri@samba.org>
Autobuild-Date(master): Sun Oct 20 13:29:58 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c1349c44d94b3f16daa7286a2762ad05567d8563">c1349c44</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-20T14:52:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:waf: Remove check for fdatasync
This is already checked by libreplace as replace also provides it.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Sun Oct 20 14:52:40 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7b1466cc1e0c25930ca4f8296b31f33e3a7cce2f">7b1466cc</a></strong>
<div>
<span>by Christian Schulz</span>
<i>at 2019-10-21T00:04:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbstatus: use display print function
Signed-off-by: Christian Schulz <chris@schocktools.de>
Reviewed-by: Ralph Böhme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5216fd2287260eeb4864a465121ff7870896e697">5216fd22</a></strong>
<div>
<span>by Christian Schulz</span>
<i>at 2019-10-21T01:26:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbstatus: fix column length for DenyMode
Signed-off-by: Christian Schulz <chris@schocktools.de>
Reviewed-by: Ralph Böhme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Oct 21 01:26:29 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d6a4eea5fd284755d181426dba84ddd5c1ba9769">d6a4eea5</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-10-21T14:40:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/remote_pac: split test_PACVerify() in two
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13133
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/90bdaaf09d9c5595170272bd0bfebaac0a90ae01">90bdaaf0</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-10-21T14:40:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: add a test for PAC delegation-info blob in S4U2Proxy
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13133
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fd5cf415a7536c9f020fff57a707caa703c33b9c">fd5cf415</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-10-21T14:40:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:kdc: fix the principal names in samba_kdc_update_delegation_info_blob
We need the target service without realm, but the proxy services with realm.
I have a domain with an w2008r2 server and a samba and now both generate
the same S4U_DELEGATION_INFO.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13133
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/073dc735b4e286ff1c57cb2634832eb04a78baac">073dc735</a></strong>
<div>
<span>by Marco Wang</span>
<i>at 2019-10-21T14:40:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: include: printing: move copyright notice to beginning
Signed-off-by: Marco Wang <m.aesophor@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/31563f5759f9aeab35b566e77e6ec20b0c4589e1">31563f57</a></strong>
<div>
<span>by Marco Wang</span>
<i>at 2019-10-21T14:40:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: include: printing: fix indentation of struct printif
Signed-off-by: Marco Wang <m.aesophor@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1722e5fb1c3df34fd8eb3f7d215b6d9a913ee45f">1722e5fb</a></strong>
<div>
<span>by Marco Wang</span>
<i>at 2019-10-21T16:01:56+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: include: printing: align function parameters
Signed-off-by: Marco Wang <m.aesophor@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Oct 21 16:01:56 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6a9041ba437464bbe32738ae807e4053c4a5f1ef">6a9041ba</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-22T14:53:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: rename samba-ad-member-* to samba-admem-*
Needed to come around MAX pathlen limit for UNIX domain socket triggered by
the new samba-ad-member-mitkrb5 target added in samba-ad-member-mitkrb5.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Oct 22 14:53:17 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e9dd8821adf1696f2ab292275cc0ee859e4a24c4">e9dd8821</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-10-22T17:28:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'Value stored to 'p' is never read'
Fixes:
source3/libsmb/climessage.c:73:2: warning: Value stored to 'p' is never read <--[clang]
p += hlen;
^ ~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7a4da41c1efb62f5e528907a2e6c0aab766994e1">7a4da41c</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-10-22T17:28:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmd: clang: Fix some uninitialized value errors
Fixes:
source3/libsmb/clilist.c:534:14: warning: 1st function call argument is an uninitialized value <--[clang]
num_finfo = talloc_array_length(finfo);
^
source3/libsmb/clilist.c:1007:13: warning: The right operand of '<' is a garbage value <--[clang]
for (i=0; i<num_finfo; i++) {
^~~~~~~~~~
2 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/25a256bedf2992771b6ea1263fb5e730b27a53dc">25a256be</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-10-22T17:28:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'Dereference of undefined pointer value'
Fixes:
source3/libsmb/clidfs.c:350:3: warning: Dereference of undefined pointer value <--[clang]
DLIST_ADD_END(referring_cli, cli);
^
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4995a0e7e05c4affc9f1f7992cef54e57d9efdc0">4995a0e7</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-10-22T17:28:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'Value stored to 'create_options' is never read'
It looks like the create_options are accumulated as the depending on the
failure reasons returned for cli_smb2_create_fnum (except for when a
directory is encountered) this looks like a mistake
Fixes:
source3/libsmb/cli_smb2_fnum.c:1870:3: warning: Value stored to 'create_options' is never read <--[clang]
create_options |= FILE_DIRECTORY_FILE;
^
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/764bb47a370c6a5d5d73b8855d141c2d4cbd6f58">764bb47a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-10-22T17:28:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'Assigned value is garbage or undefined'
Fixes:
source3/libsmb/smbsock_connect.c:786:13: warning: Assigned value is garbage or undefined <--[clang]
state->fd = fd;
^ ~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/61621009980a4c4a8b64bde8e03370152df0cdce">61621009</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-10-22T17:28:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'Value stored to 'p' is never read'
Fixes:
source3/libsmb/clirap.c:145:3: warning: Value stored to 'p' is never read <--[clang]
p = rdata;
^ ~~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4ef40d41f606f631411991101ed826733a74a8b7">4ef40d41</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-10-22T17:28:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'Assigned value is garbage or undefined'
Fixes:
source3/libsmb/clirap.c:1490:9: warning: Assigned value is garbage or undefined <--[clang]
*mode = attr;
^ ~~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6ebd0ba735e6fdddc4d7ded57879d85a42aabf05">6ebd0ba7</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-10-22T18:48:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/libsmb: clang: Fix 'the left operand of '-' is a garbage value'
Fixes:
source3/libsmb/clifile.c:360:19: warning: The left operand of '-' is a garbage value <--[clang]
if (data[num_data-1] != '\0') {
~~~~~~~~^
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Oct 22 18:48:43 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/799b05cf7f9e49db71a731fdf9264311703fd3cf">799b05cf</a></strong>
<div>
<span>by Amit Kumar</span>
<i>at 2019-10-22T19:39:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: 'net ads gpo getgpo' command not dumping gpo
We have passed dump_gpo(debuglevel=1), hence gpo is not
dumped at debuglevel=0. But end user will expect gpo
to be dumped without setting debug flag.
Signed-off-by: Amit Kumar <amitkuma@redhat.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ce3fdc4dee373a2f9ab55ffa83a97ac690109b09">ce3fdc4d</a></strong>
<div>
<span>by Amit Kumar</span>
<i>at 2019-10-22T19:39:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool domain: fix an unhandled exception
Uncaught exception on running 'samba-tool domain schemaupgrade'
ERROR(<class 'ModuleNotFoundError'>): uncaught exception - No module named
'markdown' File "/usr/lib64/python3.7/site-packages/samba/netcmd/__init__.py",
line 185, in _run return self.run(*args, **kwargs) File
"/usr/lib64/python3.7/site-packages/samba/netcmd/domain.py", line 4157, in run
from samba.ms_schema_markdown import read_ms_markdown File
"/usr/lib64/python3.7/site-packages/samba/ms_schema_markdown.py", line 26, in
<module> import markdown
Signed-off-by: Amit Kumar amitkuma@redhat.com
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b8461b422d94b836eb952a3a5363cf03eb347e95">b8461b42</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-22T19:39:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Simplify tool unit test runner
There is no good reason why the code needs to be this way. The
intervening code was removed years ago leaving a more complex version
of something very simple.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5ae330e5a56553b8809f710230101acf044c98e3">5ae330e5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-22T19:39:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Avoid running valgrind under valgrind
When run from integration tests $CTDB already includes $VALGRIND, if
set. So only add $VALGRIND if $CTDB is not set.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/787662604d4f578f10981845997ccd995f11d853">78766260</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-22T19:39:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add run_tests.sh option to print logs on test failure
Implement this for local daemons integration tests, dumping last 100
lines of logs. This makes it possible to debug some failures in
automated tests where the logs are unavailable for analysis.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fc16b8dbc69130a039f8492563fcc5ffded2000e">fc16b8db</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-22T19:39:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Enable printing of logs on failure in autobuild
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e8dc125ed2e502234135e12fe32fb387baa11a79">e8dc125e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-22T19:39:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop setting of test state directory for testonly target
This is the default and deciding this should be left to run_tests.sh.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fe80038d074d220487782dc837ea4bd779a6aad0">fe80038d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-22T19:39:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Prefix remaining environment variables with CTDB_
Now they are clearly all part of CTDB.
TEST_SOCKET_WRAPPER_SO_PATH gets too long in
integration_local_daemons.bash, so change it to
CTDB_TEST_SWRAP_SO_PATH instead of just prefixing.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aa37668218024aff6bb6518386d4e17a91407633">aa376682</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-22T21:02:11+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add -l option to set number of local daemons
This is the only place where setting an environment variable by hand
is recommended, so remove the anomaly.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Oct 22 21:02:11 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ccc486ca1184962df57e380954747f1593317bb5">ccc486ca</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-23T01:11:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Mark #else/#endif with the if-#define
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0559701478d42e969c8c779d765163271ca9141e">05597014</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-23T01:11:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove an unused #define from mangle_hash2.c
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f37b913348e921afee3e578ff0f14b731157eb03">f37b9133</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-23T02:37:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Save 520 bytes of writable memory from every smbd
Move what can be const from the "data" to the "text" segment
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Wed Oct 23 02:37:12 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1b69795c5bbc2ed24c54f8295fd3d9e4e0a0f938">1b69795c</a></strong>
<div>
<span>by Christian Ambach</span>
<i>at 2019-10-23T04:57:08+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib:wins fix a compile warning on Ubuntu 18.04
gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu1~18.04.1) with -O2 puts up a warning here:
../../source3/lib/wins_srv.c: In function ‘wins_srv_tags’:
../../source3/lib/wins_srv.c:235:3: error: assuming signed overflow does not
occur when simplifying conditional to constant [-Werror=strict-overflow]
for (j=0;j<count;j++) {
^~~
cc1: all warnings being treated as errors
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
Autobuild-User(master): Uri Simchoni <uri@samba.org>
Autobuild-Date(master): Wed Oct 23 04:57:09 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/263bec1b8d0744da73dd92e4a361fb7430289ab3">263bec1b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-23T08:23:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: Only link libnsl and libsocket if requrired
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14168
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Oct 23 08:23:13 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6e8c3ae6e9be38fdd1d1693b93c8629391799b19">6e8c3ae6</a></strong>
<div>
<span>by Heinz Hoelzl</span>
<i>at 2019-10-23T15:54:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: py3 compatiblity in 'user syncpasswords --daemon'
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14154
Signed-off-by: Heinz Hölzl <heinz.hoelzl@gvcc.net>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Björn Baumbach <bb@sernet.de>
Autobuild-User(master): Björn Baumbach <bb@sernet.de>
Autobuild-Date(master): Wed Oct 23 15:54:43 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9f41a9fc1ee10a28d379c8fda49ccfd295d66770">9f41a9fc</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-10-24T04:06:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Avoid malloc/memcpy/free in ctdb_ltdb_fetch()
Make use of tdb_parse_record()
Signed-off-by: Volker Lendecke <vl@samba.org>
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/688567f080156892270cbfb2907cd712cb77cb7a">688567f0</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-10-24T04:06:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Drop code related to obsolete controls
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/913bd331f65e9fe3d7cb16e041cd37b01987841f">913bd331</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-10-24T04:06:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Drop code releated to obsolete controls
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0872c52ef0497f96f53318cf7e4d31be0854adde">0872c52e</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-10-24T04:06:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Add new control VACUUM_FETCH
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b71d8cd80f84169bacf2dd1e753e468a305c50ce">b71d8cd8</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-10-24T04:06:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Add marshalling for new control VACUUM_FETCH
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/36f9b4953a8def40681a6f02f6576795a1ba5fbe">36f9b495</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-10-24T04:06:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add marshalling tests for new control
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/da617f90d90151f955ee354c57bdc4bc6f6498f2">da617f90</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-10-24T04:06:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Add implementation of VACUUM_FETCH control
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/86521837b684df3b7c5a0a1e3b7e606c8b91f63e">86521837</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-10-24T04:06:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-vacuum: Add processing of fetch queue
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/498932c0e8e8614bd52f3270c4d63e2b5f9e26a4">498932c0</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-10-24T04:06:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-vacuum: Replace VACUUM_FETCH message with control
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fc81729dd2d8eddea1e60e22b183894d6541c7dc">fc81729d</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-10-24T04:06:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Drop VACUUM_FETCH message handling
This is now implemented in the ctdb daemon using VACUMM_FETCH control.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c6427dddf5425b267d8c09e8df18653a48679646">c6427ddd</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-10-24T04:06:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: No need for database detach handler
The only reason for recoverd attaching to databases was to migrate
records to the local node as part of vacuuming. Recovery daemon does
not take part in database vacuuming any more.
The actual database recovery is handled via the recovery_helper and
recovery daemon should not need to attach to the databases any more.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/680df07630a94b3e76edefe98ee0986e7e5e1f12">680df076</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-10-24T04:06:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Avoid memory leak when packet is deferred
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d0cc9edc05b6218a8e20a0a8009cbb9918ff4d02">d0cc9edc</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-10-24T04:06:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-vacuum: Avoid processing any more packets
All the vacuum operations if required have an event loop to ensure
completion of pending operations. Once all the steps are complete,
there is no reason to process any more packets.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b314835341e4028f0770fa7f9a37d2d21448ddfd">b3148353</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-24T04:06:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Add new control CTDB_CONTROL_DB_VACUUM
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a896486b62bbcf9915727ba7bfc768fb5383f0c7">a896486b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-24T04:06:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Add marshalling for struct ctdb_db_vacuum
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/496204feb0e2b6eb2f3d9a74e45596a3e74ad9b1">496204fe</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-24T04:06:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Add marshalling for control DB_VACUUM
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5539edfdbe69d1d5f084d06753cce8ed6e524999">5539edfd</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-24T04:06:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-vacuum: Simplify recording of in-progress vacuuming child
There can only be one, so simplify the logic.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/13cedaf0195c6bda3a3820aedb1ee65f36dfc23e">13cedaf0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-24T04:06:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Factor out code to create vacuuming child
This changes the behaviour for some failures from exiting to simply
attempting to schedule the next run.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d462d64cdf001fd5d1cbf2a109df62e087ad0c49">d462d64c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-24T04:06:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-vacuum: Only schedule next vacuum event if vacuuuming is scheduled
At the moment vacuuming is always scheduled.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/41a41d5f3e2b8e16e25221e14939dc5962997ac7">41a41d5f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-24T04:06:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Implement DB_VACUUM control
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/439ef65d290357e513103530183091a9a6fed197">439ef65d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-24T04:06:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-client: Factor out function client_db_tdb()
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5a6d319eea6b281e9f4c35cf6c8889856234a9fd">5a6d319e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-24T04:06:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add ctdb-db-test tool
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b9654085f5facfe8a3d64667d65793146563d7f5">b9654085</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-24T04:06:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Factor out function check_cattdb_num_records()
This can be use in multiple vacuuming tests.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/49262a6bc4d5f8b81aa341294bfe04a22a6b32b6">49262a6b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-24T04:06:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add handling of process clean-up on a cluster node
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6de5706b4dbe70c66872abc80dd9301dccb2ee7c">6de5706b</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-10-24T05:28:21+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add vacuuming tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Thu Oct 24 05:28:21 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b28d06be7a0b730fb893b2f208af4ff864cda166">b28d06be</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-24T06:48:08+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: Create clang compilation database
http://clang.llvm.org/docs/JSONCompilationDatabase.html
This can be used by ymcd or clangd.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ab71d72138fffff5fc89b246b67cc4b82ca24f05">ab71d721</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-24T08:11:19+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">waf: Symlink the compile database to the source dir for clangd
https://github.com/ycm-core/YouCompleteMe
https://github.com/abingham/emacs-ycmd
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Oct 24 08:11:19 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ca95d7f41b683b4d7ac59ed6ee709d44abfe2019">ca95d7f4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-24T08:12:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:dbwrap: initialize messaging before getting the ctdb connection
This is a better fix for bug #13465.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13925
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9471508391fd3bcf199b1e94f8d9ee2b956e8f8e">94715083</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-24T09:33:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: remove now unneeded call to cmdline_messaging_context()
This was only needed as dbwrap_open() had a bug where it asked for the ctdb
connection before initializing messaging. The previous commit fixed that so we
can now safely remove the calls to cmdline_messaging_context() from all tools
that don't use messaging.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13925
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Oct 24 09:33:47 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6d43d82b49c8cd47da2f1489fe8b52d5a873a19c">6d43d82b</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-10-24T09:46:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:tests/dirsync: add tests for dirsync with extended_dn
This demonstrates a problems that the extended_dn returned
by the dirsync module always uses the SDDL format for GUID/SID
components.
Azure AD connect reports discovery errors:
reference-value-not-ldap-conformant
for attributes member and manager.
The key is that it sends the LDAP_SERVER_EXTENDED_DN_OID without
an ExtendedDNRequestValue blob, which means the flag value should
be treated as 0 and the HEX string format should be used.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14153
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d0f566c4ad32d69a1cf896e2dde56fc2489bb7fc">d0f566c4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-10-24T11:06:58+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:dirsync: fix interaction of dirsync and extended_dn controls
Azure AD connect reports discovery errors:
reference-value-not-ldap-conformant
for attributes member and manager.
The key is that it sends the LDAP_SERVER_EXTENDED_DN_OID without
an ExtendedDNRequestValue blob, which means the flag value should
be treated as 0 and the HEX string format should be used.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14153
RN: Prevent azure ad connect from reporting discovery errors:
reference-value-not-ldap-conformant
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Oct 24 11:06:58 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/05f7e9a72a1769af9d41b1ca40fe6a14b3f069d1">05f7e9a7</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-10-25T09:21:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnet_join: build dnsHostName from netbios name and lp_dnsdomain()
This make the join process much more reliable, and avoids "Constraint
violation" error when the fqdn returned from getaddrinfo has already
got assigned an SPN.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14116
Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4cbad1eb46896bbd74c5b19dbb0a8937ffde90c2">4cbad1eb</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-10-25T09:21:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnet_join_set_machine_spn: improve style and make a bit room for indentation
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14116
Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b8e1264ececf38681ca9a519a51e8336044673f0">b8e1264e</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-10-25T09:21:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnet_join_set_machine_spn: simplify memory handling
and avoid a possible memory leak when passing null to
add_string_to_array() as mem_ctx.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14116
Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3e65f72b141a7ee256ae581e5f48f1d930aed76a">3e65f72b</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-10-25T09:21:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnet_join_set_machine_spn: simplify adding uniq spn to array
and do not skip adding a fully qualified spn to netbios-aliases
in case a short spn already existed.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14116
Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/db7560ff0fb861552406bb4c422cff55c82f58bf">db7560ff</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-10-25T09:21:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml: add "additional dns hostnames" smb.conf option
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14116
Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2669cecc51f8f7d6675b4dac9b345b3c5a7fc879">2669cecc</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-10-25T10:43:08+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libnet_join: add SPNs for additional-dns-hostnames entries
and set msDS-AdditionalDnsHostName to the specified list.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14116
Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Oct 25 10:43:08 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9f7a622b2bd4a42fad3e669e83fe07c5d7115dc6">9f7a622b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-29T10:04:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-10218 - s3: libsmb: Protect SMB1 client code from evil server returned names.
Disconnect with NT_STATUS_INVALID_NETWORK_RESPONSE if so.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14071
Signed-off-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7ccc302b4bb9e0a9b695074959dc45e6fc4902bb">7ccc302b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-29T10:04:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-10218 - s3: libsmb: Protect SMB2 client code from evil server returned names.
Disconnect with NT_STATUS_INVALID_NETWORK_RESPONSE if so.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14071
Signed-off-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d524c7ddee92a457ba680853b6c25c877d881ff8">d524c7dd</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-10-29T10:04:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14833: Use utf8 characters in the unacceptable password
This shows that the "check password script" handling has a bug.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12438
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ef58222616fc3175f189417ce878d8413ba2d294">ef582226</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2019-10-29T11:58:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14833 dsdb: send full password to check password script
utf8_len represents the number of characters (not bytes) of the
password. If the password includes multi-byte characters it is required
to write the total number of bytes to the check password script.
Otherwise the last bytes of the password string would be ignored.
Therefore we rename utf8_len to be clear what it does and does
not represent.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12438
Signed-off-by: Björn Baumbach <bb@sernet.de>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Tue Oct 29 11:58:45 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b63069db9fb6efb33b7b917cd5b0ee06b0da9cdc">b63069db</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-30T13:23:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: expand test "vfs.fruit.resource fork IO" to check size
Reveals a bug where the resource fork size is capped at 65454 bytes.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14171
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f0c8ac47a4608eabeae334d39885aab98198b753">f0c8ac47</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-30T13:23:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/adouble: fix a long line
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14171
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/baaaf59e948df625b01fa8b6317ab5c3babb4e8f">baaaf59e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-30T13:23:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/adouble: README.Coding fix: multi-line if expression
Also remove a TAB.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14171
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9a3da6bebcdb924ca2027337544d79ac2088677e">9a3da6be</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-30T13:23:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/adouble: drop ad_data reallocate logic
Simply set the buffer size to AD_XATTR_MAX_HDR_SIZE. When reading the
AppleDouble file, read up to AD_XATTR_MAX_HDR_SIZE from the file.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14171
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f3df83a2c346d945487a27a9d258ee6331ea7dbb">f3df83a2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-30T14:52:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/adouble: pass filesize to ad_unpack()
ad_unpack() needs the filesize, not the capped IO size we're using in the caller
to read up to "size" bystem from the ._ AppleDouble file.
This fixes a regression introduced by bdc257a1cbac7e8c73a084b618ba642476807483
for bug 13968.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14171
RN: vfs_fruit returns capped resource fork length
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Oct 30 14:52:34 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dcf51b5aa58752ddfa4fc8814c7432e34fef4330">dcf51b5a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-30T17:20:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smb2_server: modernize a debug statement
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/41edeff416407d3eae21c7ad43d891dbacc32662">41edeff4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-10-30T18:42:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smb2_server: add message mid to SMB2 request done log message
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Oct 30 18:42:35 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1cfcad6283da855d3e97237a7a6fd6f4d2436ee2">1cfcad62</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-30T20:44:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: Ensure we don't call cli_RNetShareEnum() on an SMB1 connection.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14174
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f30b8b3aa1309e9daeb9a3601b537dead81e5dbb">f30b8b3a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-30T20:44:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: utils: smbtree. Ensure we don't call cli_RNetShareEnum() on an SMB1 connection.
Last unprotected call of cli_RNetShareEnum(). Not a libsmbclient
bug here but might as well fix the last caller as part of the
fix for the bug.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14174
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d44a84295b46cc6c540a9730a615a59c1f22a277">d44a8429</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-30T20:44:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: Change generate_inode()/setup_stat() to modern coding standards.
Change setup_stat() to be void. It doesn't return anything. Export
so it can be used by upcoming smbc_readdirplus2() call.
Remove unused SMBCCTX *context parameters.
Remove unused talloc_stackframe().
Signed-off-by: Puran Chand <pchand@vmware.com>
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7d3b4f47be0359b496087fc40f89b815c7958dd6">7d3b4f47</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-30T20:44:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: Move setting st->st_ino into setup_stat.
Signed-off-by: Puran Chand <pchand@vmware.com>
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1f0715c0e5e6ff371e3b393a0b35222c8b6f49bc">1f0715c0</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-30T20:44:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: Move setting all struct stat fields into setup_stat().
That way we only have one place where a struct stat is synthesised
for libsmbclient callers.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e26487aab01096492ec5ed4251039147963a8d1b">e26487aa</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-30T20:44:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: Add missing ino field to internal struct smbc_dirplus_list.
This should have been added to struct libsmb_file_info, but
this is user-visible so I don't want to change this now. Adding
it to the containing struct allows us to synthesise a struct stat
to return from smbc_readdirplus2() to return all the info from
the server to callers.
Signed-off-by: Puran Chand <pchand@vmware.com>
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/abbbbbff376877bbe92f3695e480472a4070937a">abbbbbff</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-30T20:44:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: Added new API smbc_readdirplus2()
Returns the same as smbc_readdirplus() but also
can return a struct stat if passed in by the caller.
struct stat is synthesized from the data
returned by the SMB server.
Signed-off-by: Puran Chand <pchand@vmware.com>
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a5f850a93f5e2eb371ca0a628c94e28c3d033e0f">a5f850a9</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-30T20:44:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture Add a test for smbc_readdirplus2()
Signed-off-by: Puran Chand <pchand@vmware.com>
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fe7737135a8f4b28cadc0f79e4de5363a8855a38">fe773713</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-10-30T20:44:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4: torture: Add additional smbc_readdirplus2() tests into readdirplus_seek().
Make sure we haven't broken anything :-).
Signed-off-by: Puran Chand <pchand@vmware.com>
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2b060f935026e68d7ad7a5d4e614452a5119dae8">2b060f93</a></strong>
<div>
<span>by Puran Chand</span>
<i>at 2019-10-30T22:18:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbclient added ABI signature file
Signed-off-by: Puran Chand <pchand@vmware.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Oct 30 22:18:15 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c2794780ad09b0fa9d63e4ad31a8ae3c67fa453d">c2794780</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dynconfig/wscript: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c93f06b12d07783104ea833e463f7fd94c0ccb0f">c93f06b1</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">examples/VFS/skel_transparent.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ba1887d37422f39bd36d0ab17dd1ef8efa56cb63">ba1887d3</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/replace/xattr.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/96c7653ee774eb6f0c08a0cbb473f4c4a42a526e">96c7653e</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/tdb/docs/tracing.txt: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b0deb6799c8d40f7c4c8824e11d37594d52e7bd5">b0deb679</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libgpo/gpo_filesync.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5915a40b25cebf7a480b51543cae93021fb091de">5915a40b</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc/ndr/ndr_compression.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6e91c52bbb9a5fe0a4057e15cd52ab56ff6682b6">6e91c52b</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/dbchecker.py: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c259190db2d232a9db6d25d7cdbca649a56bd26f">c259190d</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/netcmd/gpo.py: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/08ffb9388ec39514a24ca87391ffe715db68db88">08ffb938</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samba/upgradehelpers.py: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/12e71a745aedf6906b54dd03ff9d9a18c9d6b523">12e71a74</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source3/modules/vfs_recycle.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/07b506c213a965c900b8002766350ebb38e3c9e4">07b506c2</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source3/modules/vfs_virusfilter.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c7ceca8451f0ff7f4b0650084faed0614332b86e">c7ceca84</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source3/registry/reg_format.h: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9f4e97a4d5d044e5be29b503254684197ca244ee">9f4e97a4</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source3/registry/reg_import.h: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b61e3233273411d693da0e516e4da09423ca92db">b61e3233</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source3/registry/reg_parse.h: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/65d0ea769043637a91cb3b1c6ab9b18ff5e48060">65d0ea76</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source3/smbd/reply.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/616f9d04660f14c9ccb2dab01442c56e377aa37e">616f9d04</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source3/utils/net_rpc.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1ca79e64d8c28edcb3c9bdea3470e5a7eb8003ea">1ca79e64</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source3/winbindd/winbindd_util.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/60fcfa506db3d66b7f51ce1c25b55cb62100c763">60fcfa50</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4/dsdb/schema/schema_description.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7f41f1374264f854a3c7fc74d10a6a691e2f5f64">7f41f137</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4/libcli/clireadwrite.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b4e0c0d38f501f5b477ac384b900fb2651a44e4d">b4e0c0d3</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4/libcli/libcli.h: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9092120b0dbcd45149975a11f32073d3877da406">9092120b</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4/rpc_server/lsa/lsa_lookup.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e781db805e53959150c8a385ac60d55f601dde71">e781db80</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4/scripting/bin/samba_upgradeprovision: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e6cd8884256e5f433b16b4132ed825054af867e5">e6cd8884</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba/samba_install.py: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/522697331fc143bb04cc5136d60178533ae61afc">52269733</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">buildtools/wafsamba/wscript: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c71a1df18aa1b38c194e6b200b81ac44f6d6770f">c71a1df1</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/client/client.h: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1b51b444874bc254fbe7b865fab7e416f898e46a">1b51b444</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/common/srvid.h: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/37398acca58ac9d224aa5d841197b378e1d26e68">37398acc</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/doc/ctdb-statistics.7.xml: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/93859b3394d87f1521f757111eb8e55633c8cde3">93859b33</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/doc/ctdb-tunables.7.xml: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cb867b29c9ca2ef7ea7c9f80228f60b32329dd6f">cb867b29</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/doc/ctdb.1.xml: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b9d7b85afdf96b6ca443861700b9a22c6145dc6d">b9d7b85a</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/doc/readonlyrecords.txt: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/540325d3cb4eee1964fc59a63d51289552293902">540325d3</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/ib/ibw_ctdb.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/493705dc2746ee64a4e2cf1dc290009185853db2">493705dc</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/ib/ibwrapper_test.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9fa37484c30b83bc36b1607a82c76a77fe639b71">9fa37484</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/include/ctdb_private.h: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7722bd80fcde69d13b25a1b120fd3f9ecf6dd7dd">7722bd80</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/server/ctdb_call.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5d2a257c2e4a929bb70e4e2a2f31ed243c2efa51">5d2a257c</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/server/ctdb_client.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f3754b64876e7d0c073d86bb6d2e29425d9e8d31">f3754b64</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/server/ctdb_daemon.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1e73161bdd791fe97053dc2faa85b28e7ef55327">1e73161b</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/utils/scsi_io/scsi_io.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a456c2bb02af56ab3d966d673421aab976e632ad">a456c2bb</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb/utils/smnotify/smnotify.c: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/81df8aa7bea88f90d7ad18b00788fec8d2744a91">81df8aa7</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml/Samba-Developers-Guide/unix-smb.xml: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4b198163d03e97790a3c242f25bbd9949ab0aba1">4b198163</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T00:43:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml/manpages/pam_winbind.8.xml: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c714c996017b4167e9a7424e1aecd4437deeed22">c714c996</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2019-10-31T02:18:11+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml/manpages/pam_winbind.conf.5.xml: typo fixes
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Björn Jacke <bjacke@samba.org>
Autobuild-Date(master): Thu Oct 31 02:18:12 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0de9dad9ebc88ab044f4b946ef44f63ae2281649">0de9dad9</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-31T18:08:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml: Improve krb5_ccache_type documentation
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fe60eef9781f9970d2fa0705e10a6e8e309f839e">fe60eef9</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-10-31T19:32:55+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml: Update krb5_ccache_type in pam_winbind.8
This is a copy from pam_winbind.conf.5
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14173
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Oct 31 19:32:55 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4ae0f9ce0f5ada99cf1d236377e5a1234c879ae3">4ae0f9ce</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-10-31T22:07:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-torture: Reduce flapping in SambaToolDrsTests.test_samba_tool_replicate_local
This test often flaps in Samba 4.9 (where more tests and DCs run in the environment)
with obj_1 being 3. This is quite OK, we just need to see some changes get
replicated, not 0 changes.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e62c535d5b7d357bed9cb998f523e7c007c59910">e62c535d</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-10-31T22:07:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14847 dsdb: Demonstrate the correct interaction of ranged_results style attributes and dirsync
Incremental results are provided by a flag on the dirsync control, not
by changing the attribute name.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14040
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/03205663b3e5939896c1aad93c4a45cd769b06b4">03205663</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-10-31T23:29:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14847 dsdb: Correct behaviour of ranged_results when combined with dirsync
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14040
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Thu Oct 31 23:29:15 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/176d0f0364bc1deb3c8df2f3bb928e01f89f216b">176d0f03</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-04T12:47:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Do not use gnutls_aead_cipher_encryptv2() with GnuTLS 3.6.10
The gnutls_aead_cipher_encryptv2() implementation was released with a
bug. This wont be fixed before 3.6.11.
See https://gitlab.com/gnutls/gnutls/merge_requests/1085
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/831796b2d7c1ee13d17238b5b4a2c3d56ab6eaaf">831796b2</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-04T14:19:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci: Run 'samba' tests also with MIT Kerberos
This runs the tests of the ktest environment.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Nov 4 14:19:17 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a58c93318d592d931d232a1a25e37abdd27a825d">a58c9331</a></strong>
<div>
<span>by Jones Syue</span>
<i>at 2019-11-04T22:48:50+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Fix mem leak in ads_create_machine_acct
Use 'goto done' instead of 'return' to fix machine_escaped leak.
Signed-off-by: Jones Syue <jonessyue@qnap.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Nov 4 22:48:50 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ff47cc661d432a9337ade9a232a4f49164652812">ff47cc66</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-11-05T12:36:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: Ensure return from net_share_enum_rpc() sets cli->raw_status on error.
Convert net_share_enum_rpc() to return an NTSTATUS and ensure the
status is set correctly on error so SMBC_errno() can return it.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14176
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Nov 5 12:36:48 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e62b3a05a874db13a848573d2e2fb1c157393b9c">e62b3a05</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-11-06T01:22:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: Check incoming queue to see if incoming connection is up
This makes it consistent with the reverse case. Also, in_fd will soon
be removed.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14175
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d0baad257e511280ff3e5c7372c38c43df841070">d0baad25</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-11-06T01:22:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: Avoid orphaning the TCP incoming queue
CTDB's incoming queue handling does not check whether an existing
queue exists, so can overwrite the pointer to the queue. This used to
be harmless until commit c68b6f96f26664459187ab2fbd56767fb31767e0
changed the read callback to use a parent structure as the callback
data. Instead of cleaning up an orphaned queue on disconnect, as
before, this will now free the new queue.
At first glance it doesn't seem possible that 2 incoming connections
from the same node could be processed before the intervening
disconnect. However, the incoming connections and disconnect occur on
different file descriptors. The queue can become orphaned on node A
when the following sequence occurs:
1. Node A comes up
2. Node A accepts an incoming connection from node B
3. Node B processes a timeout before noticing that outgoing the queue is writable
4. Node B tears down the outgoing connection to node A
5. Node B initiates a new connection to node A
6. Node A accepts an incoming connection from node B
Node A processes then the disconnect of the old incoming connection
from (2) but tears down the new incoming connection from (6). This
then occurs until the originally affected node is restarted.
However, due to the number of outgoing connection attempts and
associated teardowns, this induces the same behaviour on the
corresponding incoming queue on all nodes that node A attempts to
connect to. Therefore, other nodes become affected and need to be
restarted too.
As a result, the whole cluster probably needs to be restarted to
recover from this situation.
The problem can occur any time CTDB is started on a node.
The fix is to avoid accepting new incoming connections when a queue
for incoming connections is already present. The connecting node will
simply retry establishing its outgoing connection.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14175
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bf47bc18bb8a94231870ef821c0352b7a15c2e28">bf47bc18</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-11-06T01:22:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: Drop tracking of file descriptor for incoming connections
This file descriptor is owned by the incoming queue. It will be
closed when the queue is torn down.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14175
RN: Avoid communication breakdown on node reconnect
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3b5ed00054e7d1e34cf33706c670e17a188c67d1">3b5ed000</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-11-06T01:22:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: No longer retry starting the cluster
Retrying like this hides bugs. The cluster should come up first time,
every time.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dd9d5ec5c8de82f343369ec4b26c0f24d465ce24">dd9d5ec5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-11-06T01:22:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Improve code quality in ctdb_init()
Improve quoting and indentation. Print a clear error if the cluster
goes back into recovery and doesn't come back out.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bf99f82077876fc107adb1ed4f07dd7e1351fff9">bf99f820</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-11-06T02:46:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Make process exists test more resilient
This can fail as follows:
--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--
Running test ./tests/UNIT/tool/ctdb.process-exists.003.sh (02:26:30)
--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--
ctdb.process-exists.003 - ctdbd process with multiple connections on node 0
Setting up fake ctdbd
<10||0|
OK
<10|PID 26107 exists
|0|
OK
==================================================
Running "ctdb -d NOTICE process-exists 26107 0x1234567812345678"
PASSED
==================================================
Running "ctdb -d NOTICE process-exists 26107 0xaebbccdd12345678"
Registered SRVID 0xaebbccdd12345678
--------------------------------------------------
Output (Exit status: 1):
--------------------------------------------------
PID 26107 with SRVID 0xaebbccdd12345678 does not exist
--------------------------------------------------
Required output (Exit status: 0):
--------------------------------------------------
PID 26107 with SRVID 0xaebbccdd12345678 exists
FAILED
connection to daemon closed, exiting
==========================================================================
TEST FAILED: ./tests/UNIT/tool/ctdb.process-exists.003.sh (status 1) (duration: 0s)
==========================================================================
This happens when dummy_client has not registered the SRVID (for its
10th connection) before the 2nd simple_test.
Change the initial wait to ensure that the SRVID is registered.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed Nov 6 02:46:24 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1ba0a32e707618012dcf9f06ff48bb15783cf106">1ba0a32e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-06T12:12:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">bootstrap: Remove Fedora 28 which is already EOL
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6a3b19fb170d13aaed92645866af75cc508d0991">6a3b19fb</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-06T12:12:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">bootstrap: Add Fedora 31
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/35bb734d638e273f2fd1a19220db5f200d3e7489">35bb734d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-06T13:35:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">bootstrap: Fix centos7 image creation
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Nov 6 13:35:17 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4ca0fcb2d4eec29fc75a285947a77974a0555bea">4ca0fcb2</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-11-06T18:08:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: SMB1 UNIX extensions - Ensure POSIX mknod is root-only.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4b25299c0d00b23c22be1e2a4eed3be5572e623a">4b25299c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-11-06T18:08:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">3: smbd: SMB1 UNIX extensions - For POSIX mknod we can only create blk/chr/fifo/sock objects.
Fail requests to create other object types.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d8567d46bd7e371de83e4d1ee1592639eb6f0c06">d8567d46</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-11-06T18:08:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: SMB1 UNIX extensions - only allow size change on regular file.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b784aee40ffceae8332ff3aaa74c20539857ded6">b784aee4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-11-06T18:08:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: SMB1 UNIX extensions - POSIX mknod should just create the object, not change attributes after.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b749c923373c7ccdc68ba2aed42c614e6a11d353">b749c923</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-11-06T19:31:00+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: SMB1 UNIX extensions - remove dead code.
We no longer set delete_on_fail on return from mknod.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Nov 6 19:31:00 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/54d673742f3a81ecdfb98f66a928d119293697ba">54d67374</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove #define serverid_equal server_id_equal
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d6223677bfded0aed659df4a78f318ffc180003c">d6223677</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_tdb: Avoid a use of talloc_stackframe()
For really large keys (that probably don't exist), use dump_data()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aaad4d012d83b2e203b7974f56b3f6f72d1c9141">aaad4d01</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">g_lock: Avoid sys_random(), use generate_random()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d9bd074cc8c0859f4f6333080d457a551e6367a4">d9bd074c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: Avoid the use of g_lock_do()
g_lock_do() does too much in g_lock.c, and it's rarely used.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9dd65d1f991722bf6686ae21e4607192fc2bf327">9dd65d1f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: Avoid the use of g_lock_do()
g_lock_do() does too much in g_lock.c, and it's rarely used.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8febbc2bcd2a136281ad9b4b90537028b6d5c4e2">8febbc2b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove g_lock_do()
This puts too much logic into this lowlevel infrastructure module,
given the two minor external users.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dd8aba30483649ea28199241fbc2410b1b4595a5">dd8aba30</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Avoid includes.h in g_lock.c
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8ec9e97666653469e5bd56ef0576fb0af1406a82">8ec9e976</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Simplify session generation
We don't need to parse a text sid, we have those as binary available
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/995de9c2d2e95a782b81c215efc8d4ab4b3d54b9">995de9c2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ntlm_auth: Simplify session generation
We don't need to parse a text sid, we have those as binary available
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2651463e19cac9cd346e282b9b6316952c683b2e">2651463e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ntlm_auth: Fix nonempty line endings
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d6f952f4c7ca03829d199a3cf9c5b2998146462e">d6f952f4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in set_file_oplock()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c7731649fde2b2336bba3de7e38a9281b3330414">c7731649</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in set_file_oplock()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8dd7b129138d9b89368eb0b5f8f04300672f2e98">8dd7b129</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in downgrade_oplock()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6e521461c5d57ddf01904e75b80602d662da9057">6e521461</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in downgrade_lease()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/75962acade60530ff99663ffbc1ca9d0eb79ccc0">75962aca</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in initial_break_processing()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6018cc5a078fbe042910d6bb07850c21d2ffd923">6018cc5a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in process_oplock_break_message()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/56f93f21114588e7cef8cf837a57ceaad9f9b8bc">56f93f21</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in process_kernel_oplock_break()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1bbdae2234487393e4a964d59b4d772a8a758eff">1bbdae22</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in contend_level2_oplocks_begin_default()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d04581bfe926013bda2df2beefd836555e53e8f9">d04581bf</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in rename_open_files()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3f80b8abac3e4a59371017b841cc43dfe486f18e">3f80b8ab</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in set_write_time()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/001371f45e5a069aa9cfaef9c35dc47b371935a8">001371f4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: Use file_id_str_buf() in smb_full_audit_file_id_create()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2d5aba4d8633d9cf62f6ed7847dad9ebc41f46ce">2d5aba4d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T20:36:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use struct initialization instead of ZERO_STRUCT()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/18cc62b98d47c349d542b435e603d8de72a67200">18cc62b9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-06T21:58:52+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: Use file_id_str_buf() in vfs_delay_inject_brl_lock_timer()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Nov 6 21:58:52 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dcb555c06a6341871b691dab3758e7de04110282">dcb555c0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-07T14:16:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:printing: fix a long line
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/81ae199bb72886f2f1ed87b22b4c75b6b99c72f6">81ae199b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-07T14:16:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: replace standard_sub_advanced with talloc_sub_advanced in one place
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a591de28659919d2afd7ed55106cded6a0d9ab35">a591de28</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-07T14:16:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: remove unused function standard_sub_advanced()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4736623c24503b3ca09c76c9dbb134ef833b2f80">4736623c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-07T14:16:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: rename talloc_sub_advanced() to talloc_sub_full()
We currently have the following substitution functions:
talloc_sub_basic()
talloc_sub_advanced()
talloc_sub_basic() currently substitutes a subset of talloc_sub_advanced().
We'll need a function X that only substitutes what talloc_sub_advanced()
substitutes *without* what talloc_sub_basic() does.
To get there rename talloc_sub_advanced() to talloc_sub_full(). A subsequent
commit will then bring back talloc_sub_advanced() as described above.
Examples with fictional replacement letters A and B. Currently:
talloc_sub_basic: A
talloc_sub_advanced: AB
New:
talloc_sub_basic: A
talloc_sub_advanced: B
talloc_sub_full: AB
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/41ab92b62fbf029374b89f9d0ddf7578981f37cf">41ab92b6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-07T14:16:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: factor out talloc_sub_advanced() from talloc_sub_full()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ede00779ab2d881e061adb9d861879e8c68e272b">ede00779</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-07T14:16:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:printing: add a DEBUG statement
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8846887a55b0c97a1639fc6ecb228941cf16b8f2">8846887a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-07T16:01:21+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:printing: Fix %J substition
print_run_command() uses lp_print_command() which internally performs basic
substition by calling talloc_sub_basic(). As a result. any of the variables in
the "basic set", including "%J" are already substituted.
To prevent the unwanted subtitution, we declare all affected configuration
options as const, which disabled the basic substition.
As a result print_run_command() can run manual substitution on all characters,
including %J, in the variadic argument list *before* calling lp_string() to run
basic substition which we had disabled before with the const.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Nov 7 16:01:21 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f5f89b1b990a3de0e9366beef81cf1a2ce8374da">f5f89b1b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-08T01:35:11+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Use TALLOC_FREE() in a few places
We have a macro for NULLing out the pointer
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Nov 8 01:35:11 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8dbb8643499c495474f28071750cbfc2da5b60f0">8dbb8643</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-11-08T11:01:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: Extend DNS tests to check the SOA record is always returned
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f9eaf4dc713bab48703a053c9446b6becabe18dc">f9eaf4dc</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-11-08T12:31:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dns: Always return SOA record for records we should know
Regression introduced by commit 4b54e14b7cf456e327b176b365e8471e0899210b,
where the number of returned records is not set by talloc_array_length
when the record is not found.
Found by DELL EMC at SDC SMB3 plugfest trying to perform a secure DNS
update.
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Samuel Cabrero <scabrero@samba.org>
Autobuild-Date(master): Fri Nov 8 12:31:30 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/74533b151825416d98912ca8d291637324ccc499">74533b15</a></strong>
<div>
<span>by Heiko Baumann</span>
<i>at 2019-11-10T21:03:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Make sure backup temp directory gets deleted on exception
This fix ensures that the samba-tool backup temp directory is removed
if an exception occurs (e.g. LDAP_INVALID_CREDENTIALS).
Signed-off-by: Heiko Baumann <heibau@gmail.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6cf443ab1f9d0d939d721f58386669202d2fb56e">6cf443ab</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-10T22:27:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-libcli: Remove unused header from composite/composite.c
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14170
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun Nov 10 22:27:47 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/30e8f513a8bae58d7d4e88fad8f8d5497076c553">30e8f513</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2019-11-12T17:52:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Detect when command line max protocol < min protocol
Due to the increased default minimum protocol
level to SMB2, some users notice that
specifying smbclient -m NT1 fails with
NT_STATUS_CONNECTION_DISCONNECTED, with no SMB
traffic on the wire. Report when the max protocol
is set less than the min protocol.
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Tue Nov 12 17:52:28 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eae1a45d09ef54dd6b59803eedca672ae9433902">eae1a45d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-11-12T20:56:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: SMB2 - Ensure we use the correct session_id if encrypting an interim response.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14189
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c133a1fd6765908e49e2b1808818b515c987ab72">c133a1fd</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-11-12T20:56:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: smb2 cleanup - remove variable tf_len - this is a constant SMB2_TF_HDR_SIZE.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1f5ea9d1d523cdf40c6b2c370abc7f9fa335f5cf">1f5ea9d1</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-11-12T20:56:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: smb2 cleanup - restructure smbd_smb2_request_pending_timer() encrypt code to look the same as smbd_smb2_request_reply().
This makes code changes in both (if needed) much easier
to spot.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/215e7f1fe414c38bbde1c896c16ab21f98943ef1">215e7f1f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-12T20:56:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in scavenger_schedule_disconnected()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/420cb1778d8bb7233465459f269002b254049def">420cb177</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-12T20:56:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in scavenger_timer()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0dd11a83dc2d4487315f6654f57e7a43ba6ef98e">0dd11a83</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-12T20:56:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in file_find_dif()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b0a486fabefaabd63cd2838e503360c0865e21dc">b0a486fa</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-12T20:56:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in scavenger_add_timer()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f7dc0334810723de5321f021e2d2be9d85a73939">f7dc0334</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-12T20:56:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in linux_oplock_signal_handler()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/79291056c5b550c0afa8e4089758ad5e44e15cf0">79291056</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-12T20:56:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in linux_release_kernel_oplock()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/64349ce7176c7079ffaace037c1a58a0f24abf29">64349ce7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-12T20:56:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture3: Use file_id_str_buf() in print_brl()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c229c0508bc64bb6e2d8d29be7a7bde58d86c86e">c229c050</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-12T20:56:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove unused file_id_string_tos()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0d246a156da8047b86a8cfab00f5760a840eec60">0d246a15</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-12T20:56:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in share_mode_memcache_store()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6fe211c85d93910960438c48b86614baac7db7de">6fe211c8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-12T20:56:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in share_mode_memcache_fetch()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fea35840b0504ac2fc8a3d85cb044f3d9fb345dd">fea35840</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-12T20:56:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use file_id_str_buf() in share_mode_cleanup_disconnected()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a0aaf5c3345239959221d6c2e9cd949b8ccdf233">a0aaf5c3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-12T22:18:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove unused file_id_string()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Nov 12 22:18:40 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3fea05e01f845588eb0de63af435bfec670593be">3fea05e0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-13T00:20:55+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove write cache
Since this was written, our write path has changed significantly. In
particular we have gained very flexible support for async I/O, with the
linux io_uring in the pipeline. Caching stuff in main memory and then
doing a blocking pwrite nowadays does not belong into the core smbd
code. If someone wants it back, it should be doable in a VFS module.
Removes: "write cache size" parameter.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Nov 13 00:20:55 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8a627b5d65b65e926f739272bb8f8191cd1a25b3">8a627b5d</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-11-13T00:32:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Fix typo in "quota" name in IDL
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/666dbc61f1a32f78a4096373e7b94733e06bd86d">666dbc61</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-13T00:32:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Match interface name and file name for winsrepl.idl
This helps generate fuzzers for this IDL.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a106ceb7bfe588b1888001fbba5f500c2d33e5f8">a106ceb7</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-13T00:32:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Match interface name and file name for bkupblobs.idl
This helps generate fuzzers for this IDL.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dfbb3049585186230a0d28a581ad22de7276614c">dfbb3049</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-11-13T00:32:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndrdump: add --stop-on-parse-failure
If a data stream fails to parse as an NDR object, the default ndrdump
action is to try to print those structures anyway, resulting perhaps in
a NULL dereference. Sometimes you don't want to see that because it isn't
very interesting and makes it harder to distinguish a crash in the parse
routines. So --stop-on-parse-failure will skip the print and validate
stages altogether if the parse failed.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Pair-programmed-with: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/88373c472c52ddc1191c1c20e74bff7776d0e805">88373c47</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-13T00:32:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add expected-output tests for the ndrdump struct mode
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/88c8cd7a1e7bc48a758bd00e91ca58ca91eed9d0">88c8cd7a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-13T00:32:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Do not place the ndr_table for windows_event_ids.idl in the global list
This is just a list of event IDs, there are no structures to parse.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Pair-progammed-with: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e45e342624da1b7f5df42c34c6fdccf32fc7b0e2">e45e3426</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-13T00:32:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Do not include the ndr_table for libnet_join.idl and libnetapi.idl in the global list
These are not wire protocols, there are no structures to parse.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Pair-progammed-with: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5e0442efbe738c1e1d12a237b4c0abe8a472a176">5e0442ef</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-13T00:32:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Allow warning on compile of libnetapi PIDL
This not-protocol only uses the print functions, but this means some other functions
are now unused, and as this is a special case it is better to just allow warnings
here.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dddef1b8224a2977c6e8b56af83429b36d6119ad">dddef1b8</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-13T00:32:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: Allow the compilation of the ndr_table to be skiped
libnetapi.idl defines a large number of functions a nopull,nopush and
no replacement is provided.
This will allow the ndr_table to be generated for all other IDL files
that may have public structures that could usefully be dumped by
ndrdump.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Pair-progammed-with: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dd8dfa16dea73da3e07c0e84c308f74246cc5d13">dd8dfa16</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-13T00:32:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-build: Skip building the ndr_table at the tail of ndr_libnetapi.c
This is not a real protocol and all the functions are set to nopull,nopush
but do not supply replacement functions.
This is the best was I could find to skip compiling the table as otherwise
it would point to undefined functions.
This does not happen until we generate the ndr_table for idl files without
a UUID, but we will shortly do that.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Pair-progammed-with: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1b6ae21fff9a649d451c30df90f167c33452975c">1b6ae21f</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-13T00:32:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Prepare for pidl to generate ndr_table entries for more IDL
These IDL files will soon create ndr_table entries so need to be
linked into the ndr-table subsystem.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Pair-progammed-with: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7299b9ba907d3c55897453ad2102500b94a21b82">7299b9ba</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-13T00:32:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Allow registration of ndr tables with a zero UUID
This helps ndrdump find public structures to dump
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1bd1ae0593a233465cbd5c381199bd0fc2cb476f">1bd1ae05</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-13T00:32:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: Generate the trailing ndr_table even if the UUID is not set
This allows ndrdump to dump many more public structures because most
of these are not in files with a UUID as they are not RPC protocols.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Pair-progammed-with: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/78521577eb11d2d601768f3c521549793341a450">78521577</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-13T00:32:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: Generate compatability wrappers for ndr_print functions
This creates wrappers that are compatible with the functions called by
ndrdump which have an extra "int flags" parameter for NDR_IN and
NDR_OUT. This will make ndrdump of public structures work again.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Pair-progammed-with: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3b9e983b648bd3738d8a5e1d53f29cd21ba63387">3b9e983b</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-13T00:32:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndrdump: Fix new "struct" feature
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Pair-progammed-with: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/01bb7cff023719705d7442ae497c52a3f797edf4">01bb7cff</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-13T01:55:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndrdump: check bounds when passed functions/structs by integer
The function or struct number should be >= 0 ans the underlying
number it is compared to is uint32_t.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Pair-programmed-with: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Wed Nov 13 01:55:33 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dc5788056bcbccdc320aeaad4f35f726632a91a4">dc578805</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-13T08:42:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Only link against libcrypt where needed
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/92ce387ed0e02bc3ebc673bcfd7ffbb55c04f57d">92ce387e</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-13T08:42:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Remove workaround for missing os.path.relpath in Python < 2.6
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dc5db1e8d819f442060015bc93a132cc4b3f7ad9">dc5db1e8</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-13T08:42:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">heimdal_build: Recurse to bld.SAMBA_BINARY()
This reduces a little of the duplication added when it was thought
that having a distinct waf wrapper on heimdal might allow this to be
ported upstream.
It will also streamline building a dedicated fuzzing mode in Samba.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/86e418f992e1bb1faaa099567e0f80f280d391b6">86e418f9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-13T10:29:00+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Refuse to build if ADDITIONAL_LDFLAGS or ADDITIONAL_CFLAGS do not work
This avoids these being silently ignored.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Nov 13 10:29:00 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/816205027a12d16b5de7c1fd78b4bed468a94fbb">81620502</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-11-13T13:31:10+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-ib: Fix build errors for infiniband transport
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Wed Nov 13 13:31:10 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/63f8d7732756b8a8452ab22ca205a29b27b7d1f1">63f8d773</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-11-13T17:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">bootstrap: Remove nettle-devel from package list
nettle is required as dependency for newer gnutls libraries. The gnutls
development package already depends on the nettle development package,
no need to explicitly list it.
Signed-off-by: Christof Schmit <cs@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/be2d90b60d19eca408b60fe4e1b49f9b418f1b97">be2d90b6</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-11-13T17:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wscript: Fix build with system heimdal
Ubuntu has heimdal include files in /usr/include/heimdal. As the
kerberos include files are pulled into many files through indirect
includes, add the discovered include paths to EXTRA_INCLUDES to
always have them available.
Also set USING_SYSTEM_KRB5 when enabling the system heimdal build,
to correctly handle the inclusion of the krb5-types.h file.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/15ddd95d94688ed742a2965c4b269d7c84e2d858">15ddd95d</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-11-13T17:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: system-heimdal: workaround upstream "host" canon bug
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1aef796e302058ad3327613964fa89abaf940c1c">1aef796e</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-11-13T17:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_plugin: Use C99 initializer
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/85d23236200dbe013c09a4f23d982ef1baac240d">85d23236</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-11-13T17:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5_plugin: Fix developer build with newer heimdal system library
Newer heimdal versions provide a different locator plugin interface. The
function pointer for the old method has been renamed. Use an ifdef to
initialize the correct pointer.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7965a204d68196acddf553959bb3407125baf31d">7965a204</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-11-13T17:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: Add test for build with system heimdal library
The configure option --with-system-heimdalkrb5 requires --without-ad-dc.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2efc243f1ad09eae46f6f99fb0646ecd4356c3f9">2efc243f</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-11-13T17:49:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">bootstrap: Add heimdal-multidev for Debian and Ubuntu
This is required for testing the build with the
configure option --with-system-heimdalkrb5.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5343cec5f0a5531af85d72021dba30c31a4a3f1b">5343cec5</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-11-13T19:14:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitlab-ci: Run samba-fileserver-heimdalkrb5
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Wed Nov 13 19:14:25 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/231397f45ee7a328ea41214b1367632298339e44">231397f4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-13T21:41:09+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Make share_mode_do_locked() pass TDB_DATA instead of a record
No callback used (and should not use) the record directly, this is all
handled within share_mode_lock.c
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Nov 13 21:41:09 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a6d99d9e5c5bc58e6d56be7a6c1dbc7c8d1a882f">a6d99d9e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-14T02:20:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: Close inflight connecting TCP sockets after fork
Commit c68b6f96f26 changed the talloc hierarchy such that outgoing TCP sockets
while sitting in the async connect() syscall are not freed via
ctdb_tcp_shutdown() anymore, they are hanging off a longer-running structure.
Free this structure as well.
If an outgoing TCP socket leaks into a long-running child process (possibly the
recovery daemon), this connection will never be closed as seen by the
destination node. Because with recent changes incoming connections will not be
accepted as long as any incoming connection is alive, with that socket leak
into the recovery daemon we will never again be able to successfully connect to
the node that is affected by this leak. Further attempts to connect will be
discarded by the destination as long as the recovery daemon keeps this socket
alive.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14175
RN: Avoid communication breakdown on node reconnect
Signed-off-by: Martin Schwenke <martin@meltin.net>
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/53f8492caafa8556d0c2d3f272d08ce5ce098c25">53f8492c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-11-14T02:20:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Rename ctdb_node private_data to transport_data
This gives a casual reader a useful clue.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/750f3938e4fcd6743954db6b1132751a90ee6107">750f3938</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-11-14T02:20:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Rename ctdb_context private_data to transport_data
This gives a casual reader a useful clue.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e45feaf28da27653e9df36c7c50cbd54a792a2aa">e45feaf2</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2019-11-14T03:45:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: Simplify freeing of transport data on shutdown
The type-checking is superfluous and gets in the way of readability.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Thu Nov 14 03:45:44 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/83b1c21dd0fb932b81491065067a973398bdca91">83b1c21d</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-14T08:01:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Do not return an NDR table for a zero GUID
The source3 RPC server will do a lookup by GUID and should
not be returned a table for a zero GUID.
Thankfully such a pipe would also need to have been registered
but regardless this is not a determinsitic result so should
be avoided.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/045b9eb3f088c66e20bd19e144a2ce3597328d93">045b9eb3</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-14T08:01:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Return NTSTATUS for SMBOWFencrypt_ntv2()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0914824684b3a69a9926402d447e1d5781f2ec02">09148246</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-14T08:01:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Check return codes of SMBsesskeygen_ntv2()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dc75a5f27eb32caf2f2adc289bc82fb0f8042cb3">dc75a5f2</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-14T08:01:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Return NTSTATUS for SMBOWFencrypt_ntv2()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3db2ca2dcf367a6c57071a76668d19f3cbf62565">3db2ca2d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-14T08:01:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Check return code of SMBOWFencrypt_ntv2()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/afb5cb669ceeb68bf93ef8db07abcc5d424580cd">afb5cb66</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-14T08:01:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Remove gnutls_global_(de)init()
This is done by the gnutls library constructor/destructor.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0e159b725ecf2f9a6d026170253e2d1eb73ed0c2">0e159b72</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-14T08:01:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:lib: Remove gnutls_global_(de)init() from libtls
This is handled by the gnutls library constructor/destructor.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fbfb11b0f7ebd69cc4b1b545b398a367720d5473">fbfb11b0</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-14T08:01:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Remove calls to gnutls_global_(de)init() in backupkey test
This is handled by the gnutls library constructor/destructor.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2c21cd6d49d56611acb2f364473d8c2e73e74545">2c21cd6d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-14T08:01:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Check return value of netlogon_creds_init_128bit()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e4ae1ba451d408b3b5c74d303493cb7c38e6e1c8">e4ae1ba4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-14T08:01:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Check return status of netlogon_creds_init_64bit()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0ed92e3e60684bfb02b01479d985535d525a5be5">0ed92e3e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-14T08:01:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Check return status of netlogon_creds_first_step()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7c7dc855ba982a37cb5040752ca473aab3446d6c">7c7dc855</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-14T08:01:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Return NTSTATUS for netlogon_creds_client_authenticator()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d3fffca5e9ab45b43fa3f460ad6051356c9a00a9">d3fffca5</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-14T08:01:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth:pycreds: Check return code of netlogon_creds_client_authenticator()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0906848936c410f49b26f7688df7ce1a0e1097f5">09068489</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-14T08:01:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Check return code of netlogon_creds_client_authenticator()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a64a5b7e17d80a4363774d4e35d3ee676ecf426d">a64a5b7e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-14T08:01:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:librpc: Check return code of netlogon_creds_client_authenticator()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/05f59cbcf803d57ab41b4c7fa4f81da50cd02cd6">05f59cbc</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-14T08:01:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Check return code of netlogon_creds_step()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/32e75bb4cca994af80bb8440009446e4a0ff5d40">32e75bb4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-14T08:01:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Check return code of netlogon_creds_step_crypt()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0361a26e395723296899c3d48cff86d532372710">0361a26e</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-14T09:25:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth Check return code of netlogon_creds_aes_encrypt()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Nov 14 09:25:36 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/29948d7b1eb1337c7e3d91dc53bb3e1e42de6dd3">29948d7b</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-11-14T10:38:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Generate usage message from cmdline_parse()
If any of the option parsing or command parsing fails, generate usage
message.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b2b24c91fae30edf797ed30e3c45c259aee00853">b2b24c91</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-11-14T10:38:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Add section to group commands in cmdline
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7a008c6b74e559a3e677257be3ea57a5821e3e9c">7a008c6b</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-11-14T10:38:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Update cmdline tests for section name
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/977a6f7fad8d2985e8e898bd8dc7d3d376164e9d">977a6f7f</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-11-14T10:38:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Change cmdline implementation to support multiple sections
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e469d6c1191ab9fa78e1ced6d7aa7b37dce7c5a9">e469d6c1</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-11-14T10:38:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-common: Add api to add new section/commands to cmdline
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/963a639101f4c55467e33667a698fffb350a931f">963a6391</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-11-14T12:03:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add tests for cmdline_add() api
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Thu Nov 14 12:03:46 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/220cf67776f16467488805ecd6d1905c708eaa17">220cf677</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-11-14T16:12:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/rpc/dcerpc_connect: no crash on NULL dest_host
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4dd725b1b599968fb787c93f6eb3a42af007b21c">4dd725b1</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-11-14T16:12:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pytests: rpc echo should not segfault
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/272e20adbbbaebd7bbf94c79f44f1ff42d2831d8">272e20ad</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-11-14T16:12:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pytests/segfaults: dcerpc ref elements segfault
These are just a couple of examples.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7e19779b66d7329e4208eaa5801cec0b6feb3754">7e19779b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-11-14T16:12:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pytests/segfault: pidl inline arrays
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1261894ecaebc1a3340c42e818be25caa69f6364">1261894e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-11-14T16:12:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl/python: allocate objects with ref pointers
Struct members that are marked as ref pointers need to have an object
allocated for them.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Pair-programmed-with: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f38077ea5ee0a8d3d18970e3e183c3ee516fa121">f38077ea</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-14T17:36:49+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: Handle obtaining objects from a fixed-size array
Previously we would assume the array head was the talloc context
however this is not the case if the array is a fixed size inline array
within the parent struct.
In that case the overall object's talloc context is the correct
context to reference.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Pair-programmed-with: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Thu Nov 14 17:36:49 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5852bb96584afab61cf2635aa25033fd5b9f3a15">5852bb96</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-14T22:26:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: Use direct struct assignment in store_acl_blob_fsp()
2 lines less code
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0c2a706a11c0ac89476c07f7d7d2554ffd7c342b">0c2a706a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-14T22:26:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: Use dbwrap_store() in store_acl_blob_fsp()
Use the wrapper function that's already available for exactly this
purpose.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b1143a0c7e9080996bb47b52df9124d296e4345b">b1143a0c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-14T22:26:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: Use dbwrap_delete() in acl_tdb_delete()
Use the wrapper function that's already available for exactly this
purpose.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4320196977012e02765f4804070438149d858e22">43201969</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-14T22:26:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Fix an error path memleak in schannel_get_creds_state()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8e8313b2b57f3e760876feb5b732d1d2774baa18">8e8313b2</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-14T23:50:06+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">third_party: Update nss_wrapper to version 1.1.7
This adds missing support for Address Sanitzer.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Nov 14 23:50:06 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/55b2cb47a9701376aa9e844390c8c4ee2d7fa6e9">55b2cb47</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2019-11-15T17:21:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-build: add missing gnutls dependency
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5e63e54f589b25af550f0d4e28e3c28e0a337c0d">5e63e54f</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-15T17:21:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/util: change file_save_mode() to use O_EXCL
Almost all the callers are debug tools or developer debugging aids
and these callers clearly expect to create a new file.
Unchanged in behaviour is:
- TLS certificate creation. This already confirms the files do no exist
prior to generation.
These will now no longer overwrite the given filename
- net ads pac save
- net eventlog export
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f1fa0d3b9dfef17a5129b53695fa454f1a8b8b68">f1fa0d3b</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-15T18:48:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Use the fact that file_save() now uses O_EXCL in dcerpc_log_packet()
This avoids a race with file_exist() and demostrates a better
way to use this function.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Nov 15 18:48:27 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2bb642d98e1c26064907f8f671c1de864f2d8c2f">2bb642d9</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-11-17T22:28:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndrdump: correctly find the public strict by number
We were finding a function that happened to have the same ordinal
number.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b3bdb17a35380237f7b46cc2b453b6b6b7c7a4f8">b3bdb17a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-17T22:28:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Test fix for ndrdump of structures by number
This requires that misc.GUID not move in the IDL, so a comment is added.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/816869ecea06b0b936e3ead4074bb754ee8650ca">816869ec</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-17T22:28:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndrdump: Use human-readable strings for NDR decode errors
These make much more sense than the NTSTATUS values they can be forced
to map to.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e856877ef88bf273cbf814ff17abad900ba7ea27">e856877e</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-11-17T23:54:11+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndrdump: avoid use after free
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Sun Nov 17 23:54:11 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3e2eafeb4460c8b6b3c3dbf64bbc967ae1d601d0">3e2eafeb</a></strong>
<div>
<span>by Uri Simchoni</span>
<i>at 2019-11-18T10:11:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">talloc: Release talloc 2.3.1
* Upgrade waf to 2.0.18 to fix a cross-compilation issue
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/28e4ac0e7ae965745fde628d7a675e337aa45341">28e4ac0e</a></strong>
<div>
<span>by Uri Simchoni</span>
<i>at 2019-11-18T10:11:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tdb: Release tdb 1.4.3
* Upgrade waf to version 2.0.18 to fix a cross-compilation issue.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4aea5c0972de53c143530cc42ef6d3b8cfafb973">4aea5c09</a></strong>
<div>
<span>by Uri Simchoni</span>
<i>at 2019-11-18T11:44:08+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tevent: Release tevent 0.10.2
* Upgrade waf to version 2.0.18 to fix a cross-compilation issue
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Uri Simchoni <uri@samba.org>
Autobuild-Date(master): Mon Nov 18 11:44:08 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/43bc0b2c763284ec63ca1e750602f6a9b354f9ae">43bc0b2c</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-18T19:39:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing: Avoid NULL pointer de-ref from 0-length input
fmemopen() does not like 0-length input.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d6fbfb276ce89ad40f47784300fb99cee9d4aac9">d6fbfb27</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-18T21:02:52+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing: Free memory after successful load in fuzz_tiniparser
Otherwise we have a memory leak and so fail the Google oss-fuzz check_build test.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Nov 18 21:02:52 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/93b9fc3da86a09be8244859ee62063b75e002b23">93b9fc3d</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2019-11-19T04:47:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: add missing crypt dependency for auth4_unix
Commit dc5788056bc removed crypt library from replace. This breaks the
build on fedora 30 ppc64.
[2439/3956] Linking bin/default/source4/auth/ntlm/libauth4-samba4.so
/usr/bin/ld: source4/auth/ntlm/auth_unix.c.5.o: in function `password_check':
auth_unix.c:(.text+0x7e0): undefined reference to `crypt'
crypt library is required to build ntlm auth_unix.c.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue Nov 19 04:47:47 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a377214dce2e9d71f880949fe745d799c75f57a9">a377214d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-19T04:48:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Replace E_md5hash() with GnuTLS calls
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/10499507c4fd91751898696b866ce32b1e38f605">10499507</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-19T04:48:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbindd: Replace E_md5hash() with GnuTLS calls
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4199d1040f09b5d95522d0cbdbaeec78b7d7b9a6">4199d104</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-19T04:48:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Replace E_md5hash() with GnuTLS calls
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e19b115dd27891896364f5e943b0ce7fcc89344e">e19b115d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-19T04:48:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:auth: Remove unused E_md5hash()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/71816984c31cd1a392355afdbfdadb0da2d05765">71816984</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-19T04:48:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:lib:tls: Fix cert and privkey types
../../source4/lib/tls/tlscert.c:42:2: warning: ‘gnutls_x509_crt’ is
deprecated [-Wdeprecated-declarations]
42 | gnutls_x509_crt cacrt, crt;
| ^~~~~~~~~~~~~~~
../../source4/lib/tls/tlscert.c:43:2: warning: ‘gnutls_x509_privkey’ is
deprecated [-Wdeprecated-declarations]
43 | gnutls_x509_privkey key, cakey;
| ^~~~~~~~~~~~~~~~~~~
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c34ec003b7d45aa4196ff93a0ac29694b25e5309">c34ec003</a></strong>
<div>
<span>by Robert Scott</span>
<i>at 2019-11-19T06:12:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">utils: only compile test_oLschema2ldif if fmemopen exists
in the vein of da87fa998ab71328f30bcdf5b41aee8675aee48a
Signed-off-by: Robert Scott <code@humanleg.org.uk>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Nov 19 06:12:29 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/183da1f9fda6f58cdff5cefad133a86462d5942a">183da1f9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-19T13:21:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">witness.idl: Change array type in IDL for the print function
It is important that the generated print function checks r->messages
before de-referencing r->messages[num] as r->num can be non-zero
while r->messages is NULL.
There is not witness server in Samba and print functions are only
used during debugging and ndrdump in any case.
The change in the IDL does not change the header and the IDL
function is already nopull,nopush so only the print function changes.
Found by Douglas Bagnall using Honggfuzz and a new fuzzer for
Samba's NDR layer.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/42ac80fb46cfb485e8c4a26d455fa784fdd1daed">42ac80fb</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-19T14:47:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndr: Include the caller location in ndr_{pull,push}_error() messages
This should aid in debugging NDR parse failures.
Use the ABI bump to again exclude ndr_table_misc incorrectly
added in ABI 0.2.1.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Nov 19 14:47:46 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/41b40f0e557608403ff5b19704fd5363d149444a">41b40f0e</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-11-19T14:48:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest/remote_pac: remove test_PACVerify_workstation_des
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/13655e59e2c76561155ded0f65a46ce34129dd7b">13655e59</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-11-19T14:48:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: exclude msDS-SupportedEncryptionType in ldapcmp
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
Pair-Programmed-With: Alexander Bokovoy <ab@samba.org>
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ad9016d579aa3f6d53c656fd539d821ccfbf592f">ad9016d5</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-11-19T14:48:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kerberos: remove single DES enctypes from ENC_ALL_TYPES
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e8015d8a3485092e12d610e565c8c4ee2be937b6">e8015d8a</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-11-19T14:48:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kdc/db-glue: do not fetch single DES keys from db
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/982aa328f6502f28cc117e15bf0f936a132ddeca">982aa328</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-11-19T14:48:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">password_hash: do not generate single DES keys
Per RFC-6649 single DES enctypes should not be used.
MIT has retired single DES encryption types, see:
https://web.mit.edu/kerberos/krb5-1.12/doc/admin/advanced/retiring-des.html
As a workaround, store random keys instead, making the usage of signle DES
encryption types virtually impossible.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/80f1901de0c34ba0f9993d304ccc193b88e89693">80f1901d</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-11-19T14:48:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">kerberos_keytab: do not add single DES keys to keytab
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/88bf0c572008ac9bc84f334e4c9373817499486b">88bf0c57</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-11-19T14:48:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">machine_account_secrets: do not generate single DES keys
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/151f8c0f31d3d17b9418db3793ec14ba7dbf2143">151f8c0f</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-11-19T14:48:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: mitm-s4u2self: use zlib for CRC32_checksum calc
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a53fa8ffe3e36f7921baf5d31a1052747f90aa7d">a53fa8ff</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-11-19T14:48:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: allow any kdc error in mitm-s4u2self test
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/389d1b979b8a4235033a298a56e6c10294a515fe">389d1b97</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-11-19T14:48:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">heimdal: do not compile weak crypto
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d2b5aa16500835471692c8e1fe6cd1584da89785">d2b5aa16</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-11-19T16:12:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">whatsnew: announce removal of DES encryption type in Kerberos
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Isaac Boukris <iboukris@samba.org>
Autobuild-Date(master): Tue Nov 19 16:12:39 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/51f16ec578987506a2ea07401b287b731c08c3a1">51f16ec5</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-19T16:13:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Fix CID 1455913 Use after free
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b9e74928ab99a169c76dcd3b401da70cbd1b3985">b9e74928</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-19T16:13:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Fix CID 1455915 Resource leak
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/55b0011aaf6b9c46bece711089d89bb1a6317cfa">55b0011a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-19T16:13:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix CID 1455912 Logically dead code
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b68b7d51681955d925b746173ad45f4319171522">b68b7d51</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-19T17:37:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: Fix CID 1455914 Unused value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Nov 19 17:37:42 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/586ffd5b6010b833b4d5b743f69b1629c36b6e7d">586ffd5b</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-11-19T21:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gpfswrap: Add wrappers for gpfs_fstat_x and gpfs_stat_x
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2c3436f05d7f728d5993e9ac9f3de18518647a8a">2c3436f0</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-11-19T21:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Use gpfs_stat_x in vfs_gpfs_get_dos_attributes
This is no functional change, but allows to use additional metadata
later on.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ba5d4803bab3f8fd980a5776f375b4e57b82cc85">ba5d4803</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-11-19T21:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Use gpfs_fstat_x in vfs_gpfs_fget_dos_attributes
This is no functional change, but allows to use additional metadata
later on.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f2339fe0dde2daedfab07d51709d7584c7f00e60">f2339fe0</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-11-19T21:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Create fileid from filesystem metadata
MacOS SMB clients require that file ids are not quickly reused when
files are deleted and new files are created with the same name. Inode
numbers do not satisfy that requirement, as they will be quickly reused.
To address this problem, create a unique id from the available file
system specific metadata. As that id is larger than the available 64bit,
use a hash to generate a 64bit id for usage as fileid.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7ae46019df1c5369cfd15f99448b94e425eddcc4">7ae46019</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-11-19T22:44:53+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Use update_stat_ex_create_time
Make the code a bit easier to read by avoiding direct access to the
statex struct.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Tue Nov 19 22:44:53 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1af1ebe54aefd436b6ed80cb99a30282d5abd495">1af1ebe5</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T02:14:56+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Unify packet dumping on ndr_pull() failure
There were two duplicate implementations of packet dumping just for the s4 RPC server!
This unifies them and makes them easier to find because they are not triggered
from the generated server stub any more.
The behaviour have unified on setting "dcesrv:stubs directory" and
being compiled with --enable-developer.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Nov 20 02:14:56 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/db6c12f1584215c21cd5e56bef13c6d1c8b608ce">db6c12f1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T04:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndrdump: Fix one more NTSTATUS rather than friendly ndr message
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8a6f1de67b1c2e925cce8fb20b6657a425cbaedb">8a6f1de6</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T04:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndrdump: print structure name when failing to setup
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c90bc75df8446c79a9e251c7b07a59674d828505">c90bc75d</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T04:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndrdump: TALLOC_FREE() on each exit path to allow running with leak detection
This allows us to learn if there are other memory leaks not on the mem_ctx
during the processing of the packet.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3194baaf88d78f86cbf821600cd69712e1cc02a2">3194baaf</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T04:41:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndrdump: Add const
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d4eabfb763b7c0ea6b112ea3a129977a68466977">d4eabfb7</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T04:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndrdump: Check for input decode failures
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6f0d30fd5cc921dedbc0f0741e3959b4ebc4027d">6f0d30fd</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T04:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndrdump: Allow for base64-encoded input in a file and on the command line
It has become customary to provide reproduction steps for fuzzing failures
in terms of an ndrdump command line. This allows the input to be provided
as a argument or in a file rather than via base64 -d. This makes reproducing
the issue easier as everything can be put in a plaintext bug report.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c83ad13e5893889852cbd7d2208bf45c2b72b07c">c83ad13e</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T04:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndrdump: Return a different error code for ndr_pull() failures
This may assist in distinguishing between "runner" and "pull" failures.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0491f1727513137a5cf86073d11608b7dd8a2056">0491f172</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T04:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndrdump: Invert sense of --stop-on-parse-failure into --print-after-parse-failure
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2da54d11f1e9744885558a64e72bf93b6009ae0e">2da54d11</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T04:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndrdump: Still print --dump bytes after parse failure
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/24fa3374e041f9ad26b6f124aed0c5a61a7d551e">24fa3374</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T04:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: Return the stdout when also checking error codes
This will aid in checking that ndrdump behaves as expected when
failing to parse
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b1eda993b658590ebb0a8225e448ce399946ed83">b1eda993</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T04:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Confirm that --base64-input and --input work and a PIDL bug is fixed.
The PIDL bug is in the handling of arrays of arrays.
Test input provided by Michael Hanselmann and found using Hongfuzz.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13875
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/536a84935ce7647f43528d6d376f6762c5e8eb78">536a8493</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-11-20T04:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndr_orpc: properly allocate empty DUALSTRINGARRAY
When there is no data we still need to allocate for the terminating NULL.
Found by Michael Hanselmann using Honggfuzz and an fuzzer for Samba's
NDR layer.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13875
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1aec742575252d1efcc47a8e9023889bfb0e5709">1aec7425</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-11-20T04:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: check the size of pulled arrays of arrays
We were accidentally checking the memory just past the array instead of
checking each member.
This could have led to the size of some arrays not being checked.
Found by Michael Hanselmann using Honggfuzz and an fuzzer for Samba's
NDR layer.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13877
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Pair-programmed-with: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ac1be895d2501dc79dcff2c1e03549fe5b5a930c">ac1be895</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T04:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Confirm that NDR bugs are fixed in DCOM code
Test input provided by Michael Hanselmann and found using Hongfuzz.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13875
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/33e9021cbee4c17ee2f11d02b99902a742d77293">33e9021c</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T04:41:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Test repushing an ntlmssp AUTHENTICATE_MESSAGE
This demonstrates a bug found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
fuzzer where the value() evaluatuion could segfault if it was made to follow a NULL
pointer.
This also demonstrates that the --base64 mode works on file inputs.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f7f92803f600f8d302cdbb668c42ca8b186a797f">f7f92803</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T06:06:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Check for NULL pointer in value() in ntlmssp_AUTHENTICATE
This allows ndrdump --validate to avoid following a NULL pointer when re-pushing
a valid but unusual input.
It also avoids an issue if the Samba server code were to provide a response
without an EncryptedRandomSessionKey.
At this stage ntlmssp.idl is not used for this, instead the packets are
generated with msrpc_gen().
Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
fuzzer.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Nov 20 06:06:29 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e7cab18c8b03cdc325f6e29a98b0889ab7647779">e7cab18c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-20T15:23:10+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Nov 20 15:23:10 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9e51bb77f82292800c6f0c0563124954d8f0c524">9e51bb77</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-20T22:29:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:rpc_server: Return the status code from dcesrv_transport_session_key()
Normally this returns the right status code, which normally is:
NT_STATUS_NO_USER_SESSION_KEY
This is consitent with the source3 samr server implmentation.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
Autobuild-User(master): Isaac Boukris <iboukris@samba.org>
Autobuild-Date(master): Wed Nov 20 22:29:35 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cb240510977e60fd46ef0f35b3da77f00733829a">cb240510</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-11-20T23:19:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Set fuzzer=True on fuzzer binaries
This ensures that the binaries are the only binaries built
when configured for fuzzing.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/92ee647858331db012db06314d98e08fe1e5eb5b">92ee6478</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T23:19:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing: Use --fuzz-target-ldflags if specified
This makes integration with oss-fuzz possible. Only the fuzzer binaries should be
linked with libFuzzer, not things like asn1_compile, so this can not be done via
the global ADDITIONAL_LDFLAGS.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Uri Simchoni <uri@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f57c0238e91061698787e4a4b18fb549cc2c86f2">f57c0238</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T23:19:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing/oss-fuzz: Add build_samba.sh for oss-fuzz
We work hard to put the primary logic for oss-fuzz here, and
where possible into waf, so that only a tiny stub needs to
be maintained in the Google oss-fuzz repo.
This will be called by build.sh (not copied directly because
it is too easy to forget to copy in an updated version when
doing development in the docker image).
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Uri Simchoni <uri@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ec4f6f8fd36edfda8b949dcf7451c153f6599427">ec4f6f8f</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T23:19:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing/oss-fuzz: add stub build.sh that will not change often
This makes local development of build_samba.sh easier as it will remain in the source tree.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Uri Simchoni <uri@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fbb2377d51f00617e9065a8a3daecc8f5c340ca0">fbb2377d</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-11-20T23:19:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing/oss-fuzz: Add build_image.sh using Samba's bootstrap tools
Google's oss-fuzz environment is Ubuntu 16.04 based so we can
just use the maintained bootstrap system rather than a manual
package list here that will get out of date.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Uri Simchoni <uri@samba.org>
Pair-programmed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4946811eb67c6e4e6abdfd64a552e7a2686feeec">4946811e</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T23:19:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing/oss-fuzz: Install chrpath as we use it in the build.sh script to set -rpath
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Uri Simchoni <uri@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cc128c788562d6d86c24cbcb784e1e8fca1f06a1">cc128c78</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-20T23:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing/oss-fuzz: copy required libraries to the build target
This is an alternative to static linking as we do not have static source
libraries for all the things we depend on.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Uri Simchoni <uri@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f8947538b5e445ab9c1931d1f7826771ee582385">f8947538</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-21T00:45:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing: Add oss-fuzz info to README.md
Note that Samba has not been accepted yet, but will be soon once some requirements
are addressed per:
https://github.com/google/oss-fuzz/pull/2993
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Uri Simchoni <uri@samba.org>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Thu Nov 21 00:45:33 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6107c79c90fdff3fe60e0d0ef3efe57b52b21262">6107c79c</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-22T11:48:59+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Do not build selftest binaries for builds without --enable-selftest
Add new for_selftest option to SAMBA_BINARY() and SAMBA3_BINARY()
This allows us to be much more consistent (at least in the core Samba)
and documents clearly why the binary should not be installed.
Not modified are
- test_lp_load
- notifyd-tests
- gendrandperf
- test* from examples/libsmbclient
- dbwrap_torture
- split_tokens
- locktest2
- msgtest
- msg_sink
- msg_source
- versiontest
- rpc_open_tcp
- test_headers
As these are not tested in selftest so any change would also be
untested. Of course they probably should be added in a different
MR.
Also not modified (because they are not tests, nor part of the
build system) are:
- smb2mount
- notifydd
- log2pacp
- debug2html
- smbfilter
- destroy_netlogon_creds_cli
- spotlight2*
- tevent_glib_tracker
These do however appear to be untested.
For now, the source4 forked client tools are left unchanged:
- smbclient4
- nmblookup4
Finally, the heimdal binaries are left as install=False as
they are either part of the build system or end-user tools
that we just don't want to install. These are however tested.
The motivation is commit like c34ec003b7d45aa4196ff93a0ac29694b25e5309
and da87fa998ab71328f30bcdf5b41aee8675aee48a, which are both totally
correct but are not needed if the selftest is not run on MacOS.
There are likely other platforms or build environments where building
our test binaries is more pain than valuable, see for example also
https://lists.samba.org/archive/samba/2019-November/227137.html
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
Autobuild-User(master): Isaac Boukris <iboukris@samba.org>
Autobuild-Date(master): Fri Nov 22 11:48:59 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e7f0e858e00a76976c3d84c8808e9296254b42a5">e7f0e858</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-22T19:54:55+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:printing: Use httpConnect2 from CUPS
This fixes deprecation warnings.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Nov 22 19:54:55 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bc2fc51abef823090f178de7e39890bdd91f9067">bc2fc51a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_tdb: Avoid includes.h
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a58633f64ea4e43dd3f860b4176ebae080a0a4f1">a58633f6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_tdb: Return correct error from db_tdb_storev()
Don't lose information to NT_STATUS_UNSUCCESSFUL
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/caef82b1fe6ae7732abcd04a3696756274c935ea">caef82b1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap: Pass "value" to dbwrap_do_locked() callback
I want to reduce dbwrap_record_get_value(). It makes the caller believe it can
make a copy of the TDB_DATA returned and that the value remains constant. It's
not, as you can always do a dbwrap_record_store().
This patch removes one requirement for getting the value out of a
db_record via dbwrap_record_get_value(). You can still make a copy, but from an
API perspective to me it's more obvious that "value" as a parameter to the
callback has a limited lifetime.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/78c96f6995aa0cb8e0ec0872bdc00bb452bc2d36">78c96f69</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">g_lock: Pass "data" down to g_lock_trylock()
Avoid a call to dbwrap_record_get_value(), dbwrap_do_locked() already
gave us the value.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dbf24bcb1baa588295313e4d37ce84ee6db80168">dbf24bcb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: Use dbwrap_parse_record() in vfs_offload_token_db_fetch_fsp()
Less malloc
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5291208836ea85b1b02f5b31b577fcc9050fa8b9">52912088</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: Use dbwrap_do_locked() in vfs_offload_token_db_store_fsp()
Less malloc
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1dc3c168245366d219fc8c3b116f4f5904a9cb07">1dc3c168</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap: Protect against invalid db_record->value
After dbwrap_record_storev()/delete(), dbwrap_record_get_value()
information is stale. Assert on the attempt to re-fetch data after it
became stale. This can't protect against someone copying the result
from dbwrap_record_get_value() somewhere else, but it's better than
nothing.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ffe4933c776bc89ab8a6bb09f74288b8bf7b1310">ffe4933c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">locking: Remove a call to dbwrap_record_get_value()
This makes a copy of the record values TDB_DATA.
In this case, it is okay: We only do a dbwrap_record_storev modifying
the value that we retrieved from the share_mode_lock destructor.
This patch is necessary because the next commit will make the "value"
argument to the dbwrap_do_locked() callback the only source of the
record value. Thus for a nested share_mode_do_locked() call we have to
maintain the record value explicitly.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ca8c23bb42e501d5fe7f47f6c59feb5e7524a0cf">ca8c23bb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap: Don't set rec->value in dbwrap_do_locked()
We pass that via the callback now
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e341911ddad078c3c0c95f7e0ec16701510cb273">e341911d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture3: Consolidate dbwrap_watch test initialization
More lines, but less error-prone copy&paste
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/79dcabfbabb9503eff9efe7cd32b1cb431d3ee69">79dcabfb</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture3: Test the next patch: No two waiters in one do_locked()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7cea5fec29a0d425263a7ecb79d89a4f13de3f7e">7cea5fec</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_watch: Prevent two watchers per fetch_locked sequence
This can lead to very confusing bugs, and the code right now does not
deal with it well.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/053405719a5bd4121a2ca1f756dc7859ebb91faf">05340571</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_watch: Encapsulate watchers in "struct dbwrap_watcher"
Next patch will extend this structure
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7349612c59a518a2858a4a7bb268fa1ad14016d3">7349612c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_watch: Add a uin64_t instance to watchers
Initially used for debugging purposes only
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a793cc2276ef2123bfec1bc1828224372fcd3d93">a793cc22</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_watch: Simplify the wakeup messages
The instance ID per process globally identifies a watch instance
across databases. It's not necessary to send the database ID and the
watched key across, the uin64_t instance ID is sufficient.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e5c28fec6f900dd1d8f1ee81d2cd008a93207a1a">e5c28fec</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_watch: Simplify struct dbwrap_watched_watch_state
With the wakeup messages changed, we don't need to store what used to
be the old message in the struct dbwrap_watched_watch_state
anymore. We still need to store the key that is watched for removal of
our watch entry in the request destructor
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/341223a00596ef1cdc63d9eb0a0b2e496bd6f0f4">341223a0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_watch: Don't store in-RAM caches
The history of this file is a mess with lots of bugs. Most of the bugs
I believe are based on the cache of database contents we maintain in
struct dbwrap_watch_rec. This patch removes that cache and does all
modifications directly in the backend database.
This means we have to mess with the database format in a few more
places, but I think the format is simple enough that this does not
really hurt.
I tried for a few days to split this up into small pieces that are
easier to understand, but every time I separated out individual chunks
I found difficult to track down bugs that are all resolved in the
final code presented here. It's more lines of code, but I hope it's more
robust.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2379dc29bc73bdd1598a4ddaf47240cea5fd0697">2379dc29</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Add share_mode_watch_send/recv
For now this is a simple wrapper around dbwrap_watched_watch_send()
that will make the direct db_record reference in struct
share_mode_data unnecessary.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/24f56aefb487a6b269baf55b6840670666fbf0f3">24f56aef</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_watch_send()
This removes some dependencies on share_mode_data->record
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0a66c9735456dbcee4b59e2bf8cd91402884b894">0a66c973</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Pass the db_record down to share_mode_data_store()
Remove a dependency on share_mode_data->record
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/06b0bcdf8d0abba2f0625ff458adb56bf471b9e0">06b0bcdf</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove share_mode_data->record
In the future, there won't be a record anymore
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c9b34cd2057c05e9965464ca5e9e28b423cb418b">c9b34cd2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">g_lock: Change prototype of g_lock_dump
Soon the g_lock database format will change. There will be one
exclusive entry and an array of shared entries. In that format,
there's no need to attach a lock_type to each entry in the g_lock
database. Reflect this change in the g_lock_dump API
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/97ba1ee2f94e5529839a1c0852f50544dbbb83cf">97ba1ee2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Make struct g_lock_rec private to g_lock.c
This is no longer exposed in the API
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/859148479b98678ee4bfa8084a6dc56bcc10a4c5">85914847</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: g_lock will allow duplicate READ locks soon
In the future, g_lock will not check for duplicate READ locks anymore,
as there might be many of them and the check might be expensive
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/effad89f6224fbaeed5ef67016bd23e645763bc9">effad89f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Add g_lock_ctx_init_backend()
This will allow using the g_lock.c logic on other databases as well
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d734547488c6fab8d136239a95db640df57dbb97">d7345474</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-22T23:57:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Change the g_lock data model
Now we have one fixed field for the exclusive lock holder and an array
of shared locks. This way we now prioritize writers over readers: If a
pending write comes in while readers are active, it will put itself
into the exclusive slot. Then it waits for the readers to vanish. Only
when all readers are gone the exclusive lock request is granted. New
readers will just look at the exclusive slot and see it's taken. They
will then line up as watchers, retrying whenever things change.
This also means that it will be cheaper to support many shared locks:
Granting a shared lock just means to extend the array. We don't have
to walk the array for possible conflicts.
This also adds explicit UPGRADE and DOWNGRADE operations for better
error checking.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9aa03be946467698ac7509251f366e165672feaa">9aa03be9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-23T01:25:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Test g_lock deadlock detection
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Nov 23 01:25:12 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7eb171f6e36a3f1b3101398bb8a99aab99bb5c4f">7eb171f6</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-26T12:49:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">gitignore: Add .build.log
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/97d43cf6982a4bc1bbba70997990b017b6bca213">97d43cf6</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-11-26T12:49:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Print priv pipe location
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/038549608709d4a1b7a1650041a57d201fb6a643">03854960</a></strong>
<div>
<span>by Guenther Deschner</span>
<i>at 2019-11-26T14:14:51+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:winbind: Also set the cmd name for bool dispatch table
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Nov 26 14:14:51 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f849d8c0cf7b8f04dd53cad4f633628c41565d2c">f849d8c0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-26T21:28:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">g_lock: Factor out g_lock_cleanup_shared()
This function will find a second user soon
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ba852a3d92fd762e0a4d4e1b3a8177a30b5e34d5">ba852a3d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-26T21:28:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">g_lock: Move a variable inside the block were it's used
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/39f21a58b0c196ef32e66a27051837e4395bb958">39f21a58</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-11-26T21:28:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">g_lock: Speed up sync g_lock_lock()
The comment "this is used in very hot code paths" is not true right now, but
will get true soon....
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6dfa5bb64fce1ddd054966bd89b07e43034c6edb">6dfa5bb6</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-11-26T21:28:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">sharesec: Return NTSTATUS from share_info_db_init
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1f304fc16c675f402c61f95601481e7a3e27db04">1f304fc1</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-11-26T21:28:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">sharesec: Return NTSTATUS from set_share_security
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6bf6e5364a9ad3e5d8186f1226c83ecf16637a37">6bf6e536</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-11-26T21:28:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">sharesec: Return NTSTATUS from delete_share_security
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cb907fbee8373666100984693f004e37cb20cacf">cb907fbe</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-11-26T21:28:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Make net command available in sharesec test
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9dddb28a1719c753e84e2631ef1e1f12460cc3df">9dddb28a</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-11-26T21:28:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add test for 'net conf delshare' also removing share ACL
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ff35160dc6415e1ef5d57717d7636f38ea25a8f0">ff35160d</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2019-11-26T22:55:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: Delete share ACL from 'net conf delshare'
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Nov 26 22:55:38 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/848cd4c460a52c459bba5ff14a8b72f126378066">848cd4c4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-11-27T10:25:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: remove unused str_list_sub_basic()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/57fa96b47654e899808b5159579b46f4059b5971">57fa96b4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-11-27T10:25:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: remove unused str_list_substitute()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c36dd5931850ae7ed6290718ecae7c3ebf257eb4">c36dd593</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:param: rename lp_string() argument ctx to mem_ctx
Minimizes diff of subsequent patch.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/741bbfd252c272f796d535d653c39abee3569c93">741bbfd2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/param: introduce loadparm_substitution infrastructure
Pair-Programmed-With: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/063c4b25b1529987eb2e59ac53cd0ad23a8f5669">063c4b25</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-11-27T10:25:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:param: split out loadparm_s3_global_substitution from lp_string()
The idea is to get rid of the global state that's
currently used for the substitution in lp_string().
In the end all callers need to pass an explicit
const struct loadparm_substitution *sub_ctx,
which contains all relevant information
for the substitution. At that point lp_string() can be removed.
For now we provide loadparm_s3_global_substitution()
for callers to keep the current bahavior unchanged.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/236857b43453a2460d508fb4a2d7915a5055d195">236857b4</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-11-27T10:25:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:param: split out lp_parm_substituted_string()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/564049fbc949827ccbfddcdbc5f560fc4ccae4ad">564049fb</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-11-27T10:25:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:mdssvc: make use of lp_parm_const_string()
We don't need any substitution for elasticsearch options.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5170fc24218f387c61bf24b13a414ce7d685b2d0">5170fc24</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-11-27T10:25:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:vfs_tsmsm: make use of lp_parm_substituted_string()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/48c7d777f220d5c82cc5c456f86f760c42e3cf7e">48c7d777</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-11-27T10:25:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:vfs_streams_depot: make use of lp_parm_substituted_string()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f6747ccc3b7ba14834bb2c62087203129f84feed">f6747ccc</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-11-27T10:25:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:vfs_nfs4acl_xattr: make use of lp_parm_substituted_string()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cea386de159c6bea141aa507e7b67723fac2f007">cea386de</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-11-27T10:25:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:vfs_glusterfs: make use of lp_parm_substituted_string()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3215d357e6af97ac05266b6ab5c8861d7f124815">3215d357</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-11-27T10:25:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:parm: remove unused lp_parm_talloc_string()
Callers should use lp_parm_substituted_string()
directly or just use lp_parm_const_string().
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ef1f0e9ffe76eaee4b92241ea39d81ea553fa841">ef1f0e9f</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-11-27T10:25:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">param: add FN_{GLOBAL,LOCAL}_SUBSTITUTED_STRING support
Pair-Programmed-With: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c23e3564fc2c7c9dc53c2d26ecbacb1d9682aba6">c23e3564</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-11-27T10:25:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "aio write behind" with substitution="1"
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8e86ac18e7d6c3b3e9c5786138d1c90e699843c8">8e86ac18</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-11-27T10:25:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "comment" with substitution="1"
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7973c873442ed093b71bd42ca1397c5bfd65c820">7973c873</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-11-27T10:25:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "dfree command" with substitution="1"
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7e918fad6e974b06a43357ba08ea5ef7ecd7f3b5">7e918fad</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-11-27T10:25:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "cups options" with substitution="1"
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/79cff6295d11d1c708bb997d458e9d982cddd480">79cff629</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "dont descend" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2cf62e85e5fec7e977779587ab6ae051fad009aa">2cf62e85</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "force group" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/78593e2f0073bbdf6225c2e5d5bbff5cc7688f5a">78593e2f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "force user" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/86843529210e55c57327909e770259bcd8f656d2">86843529</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "hide files" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/595685c1655fb71e64ba94bca504349cb25561b2">595685c1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "magic output" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/223c1f725a5d48f226110f6b2decd1451ea8c526">223c1f72</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "magic script" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/95f0f22ca5150642c77bbbbe40a921ac50861e1c">95f0f22c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "msdfs proxy" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f7619ac22b50bf3bac96825e72e9910946d7f4d2">f7619ac2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "path" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4f2ee224ce8a518ae0328e152addd2a1cdcca298">4f2ee224</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "postexec" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e95e1c2d4f8faf9dee82e7f51f95ca8451163336">e95e1c2d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "preexec" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b98e1ad7711aac4f8914b960199c9ae3aa7cea69">b98e1ad7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "printername" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b92038072f3e5debd519eda0ab07182f46e06e56">b9203807</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "root postexec" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/17726dab60fef0c28ecaf4edb03e320d74b74470">17726dab</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "root preexec" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/73082f938ed6673eb5a0a3a3dbf12f306c13ee24">73082f93</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "veto files" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/18bd0c38f506876fd51c2bf54672b4e257364023">18bd0c38</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "veto oplock files" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8834eafcacaa01d497f488851fe4f6b339be0e30">8834eafc</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "volume" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/db75b5d6fcc3dbdf10ceace57011ede629382da8">db75b5d6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "abort shutdown script" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9e35015739d790ed0d44cd74ad9f8bb308f2d35d">9e350157</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "add group script" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b0198b18314074495eaffd590799e1f0aa098a2c">b0198b18</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "add machine script" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a5db3443a2e2aa25d7f58d999bacc297cc40b14a">a5db3443</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "addport command" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/39f8014275c34d935bdbc5e272e60f2e4ed6b426">39f80142</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "addprinter command" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/390f53cb038ad2f64cb3eae295643656b431b12f">390f53cb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "add share command" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4c345289baa1d18abd9975e2079a40b8f38bb384">4c345289</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "add user script" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/00c4d9ec1a67c9ed0a9827a9cb2982b335ab7a9a">00c4d9ec</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "add user to group script" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8445454008a65581c3cf684a902072324894ea67">84454540</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:param: let lp_add_auto_services() take a const char *
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5e8d600bc6cc12019d986f54d1dd7483a940dacd">5e8d600b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "auto services" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bf9c63a28008883a6722a129e6b0f5a6695ed6a7">bf9c63a2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "change share command" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/12e97ee3e86d72b9edad9a2ac37249ffa0d28331">12e97ee3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "check password script" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fb434275164c21494bbb8be7d0f36c7289b20ce0">fb434275</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "next configfile" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4b1de86de2b84afda280b862d4d6e7234ebb3de8">4b1de86d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "cups server" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/736cb9d80c9fdba0369bd740aa82d88e45e0c4b9">736cb9d8</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "defaultservice" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b1c27e724665a5fea8da3a0f15ab87f01e86aa26">b1c27e72</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "delete group script" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d035f850deb5e7b3eb1f1c0d86f09ea6ec2e4cc4">d035f850</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "deleteprinter command" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/28391f0b61b6cfe75d8042dbb5f811fdfada3b99">28391f0b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "delete share command" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7547d837ec62c0e019122d503097ffe6d080a3ca">7547d837</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "delete user from group script" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1377e66edfc1c6cdd40417a0b3b986bc106b6a3f">1377e66e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "delete user script" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6e678cba77dac7bab2866bbfe393d624643fce1a">6e678cba</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "enumports command" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/25039641490fdc33d7e81959bc462b5a2916d95e">25039641</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "get quota command" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/330f4ac1ca6b04bd86f50489227f9d4b88d03949">330f4ac1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: add missing TALLOC_CTX parameter in call to lp_homedir_map()
This seems to be dead (at least dying) code,
is WITH_NISPLUS_HOME ever defined?
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9f3c05d009a7b6daf720e535e06e33a5ea13bf6b">9f3c05d0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "homedir map" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f2a1f0c705bc2e1f0400e23892fde45de00032b4">f2a1f0c7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "iprint server" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fa5033cfb7e9b65c23fe2c0c391c59b70d8415c3">fa5033cf</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "logfile" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9910b5e1da337e84479421a599badf53c1853ea9">9910b5e1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "logging" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4d7eaed58600342f618a3ea0307208dff0591ad0">4d7eaed5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "log level" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e46ea02939a13ef41b36500874baa90fa29e973e">e46ea029</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "log nt token command" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f47b710b2c97d60d5f8b088a8d8be26c2a1f7d79">f47b710b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "message command" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f3cfef87854ccc27e037501c578fccb712791385">f3cfef87</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "os2 driver map" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ea61dd917e671f2eee225e55aaed285a43ec7523">ea61dd91</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "panic action" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4551dd27840a4bd0f84a78da1920acc7ba204f88">4551dd27</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "passwd chat" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1743ff48ba3e0c738b5909206cfcbd2111221443">1743ff48</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "passwd program" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/299718ccd4f301f0ab90d2d65b05725c45b40c3a">299718cc</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: remove a prototype that is generated by loadparm
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5c5dbcc397f96bb9960786a3f91b7d2f4012aeff">5c5dbcc3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "perfcount module" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dbc82a9f19e2fb4b7f9d9d708a7c5ed0eb4f0778">dbc82a9f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "remote announce" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6d0db70ef7379ab722daed78ff5a877b48efd083">6d0db70e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "remote browse sync" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1439c19ceef3682782a7c337302ef9b7310687ef">1439c19c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "rename user script" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8077804c36c44631ba09d52308fe9ad213ae7eb5">8077804c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "root directory" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7dc7b9e55491267794548f96acc2e45244cf6eac">7dc7b9e5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "server string" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/434d2632cb95cfe6170f554afa7c31810b298037">434d2632</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "set primary group script" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fd72181fd0d9275b8b2972cf0393fd0cc4b94088">fd72181f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "set quota command" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a0185c7efbdba9405bcfade9ad89675532a43ffe">a0185c7e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "shutdown script" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3c68114e73421b5b89b57582defd53faef275ca4">3c68114e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "username map" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b635c445ad5a283bce28ae7eb7a60067d8802d6c">b635c445</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "username map script" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2dae6473fa0dabc2e12ffcf766f81117a10944b4">2dae6473</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "usershare path" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4d2a3c8a791a42e2162ef957de2937673d536f53">4d2a3c8a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "wins hook" with substitution="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/050c28364aa1b476d33ea726ecb6cbd9d26af5d8">050c2836</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "ldap admin dn" with constant="1"
All the other LDAP related options like "ldap user suffix" don't support
variable substitution, so I guess it's safe to remove support for it from this
one as well.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ca2e49fe42087678f971bde26ca05c91fb6f95b3">ca2e49fe</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "ldap suffix" with constant="1"
Due to the use of append_ldap_suffix() where Globals.ldap_suffix was used
directly in the dependent options like "ldap group suffix", we can just mark
this option as const thereby removing substitution from "ldap suffix".
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/71e9c6e48b57f568b04eb829511492aff41745b9">71e9c6e4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "ldap group suffix" with constant="1"
Due to the use of append_ldap_suffix() where Globals.ldap_suffix is returned
directly, variable substitution isn't supported anyway, so we can just mark this
const.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b48d30e0e12a2ddf52429b69599850c670e68160">b48d30e0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "ldap idmap suffix" with constant="1"
Due to the use of append_ldap_suffix() where Globals.ldap_suffix is returned
directly, variable substitution isn't supported anyway, so we can just mark this
const.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9ed8292a7b2fa08e16e5d98147ecdbe859d85e77">9ed8292a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "ldap machine suffix" with constant="1"
Due to the use of append_ldap_suffix() where Globals.ldap_suffix is returned
directly, variable substitution isn't supported anyway, so we can just mark this
const.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6f618b7c95830b73ac636032e136b11c957139be">6f618b7c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "ldap user suffix" with constant="1"
Due to the use of append_ldap_suffix() where Globals.ldap_suffix is returned
directly, variable substitution isn't supported anyway, so we can just mark this
const.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/564b0b5be31593de01e6d53388ee69e48645effa">564b0b5b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "mangling method" with constant="1"
>From the manpage:
... controls the algorithm used for the generating
the mangled names. Can take two different values, "hash" and
"hash2". ...
No need for variable substitution support in this option, declare it const.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9aca11aec9fd129d5636f985969d55db209cb768">9aca11ae</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "rpc server dynamic port range" with constant="1"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ca72c4b39c8d025f237af558fbeba485d09864a0">ca72c4b3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdotconf: mark "usershare template share" with constant="1"
The code uses Globals.usershare_template_share directly anyway.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ad2c824b1f1ab3947176924074f4264fa0f44edd">ad2c824b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml: remove SWAT specific flags
Most of the SWAT stuff was removed in 4a6a010e78721624813a84bfefa7a1b80eaf0abb,
somehow these two crept back in afterwards.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3e81d9460bf4f0640ef7c679cd539e614929343e">3e81d946</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">param: remove now unused FN_GLOBAL_STRING macro
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/24905ba82d2f1b9e01df7a6e03d853c5138bc148">24905ba8</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml: remove explicit "constant"
The constant mark applied to types "string" and "ustring". The previous patches
in this patchset already markes all string options as either constant or
substituted, but it's still possible to add options or change existing ones to
be neither constant nor substituted.
In order to enforce strings to be either constant or substitued, remove the
explicit constant marker. Instead, any option that is not marked as substituted
is implicitly made constant.
This patch doesn't change behaviour and all generated files are the same before
and after this change.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eddc63be868434d3aa5a66b514b692f4d7b8833a">eddc63be</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">printing: use lpcfg_substituted_string() in print_run_command()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b5c6964a50be03999432fa5620be39dcb7093ad8">b5c6964a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:param: make "servicename" a substituted option
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/31b06f412e91f44e074241564766d9c4869fff9d">31b06f41</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">param: remove FN_LOCAL_STRING
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5114f73ea72bda2b4268fece9a5d61214d7afd20">5114f73e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-11-27T10:25:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">param: remove now unused lp_string()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ef1c852f975e98e034cefc7fc0c2da9eb8d5a46f">ef1c852f</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-11-27T10:25:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">heimdal: invoke gsskrb5_set_dns_canonicalize(false) in gse_context_init()
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/609a1d1d6b491c8efc1436c65b75ebf5b0003a03">609a1d1d</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-11-27T10:25:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "selftest: system-heimdal: workaround upstream "host" canon bug"
This reverts commit 15ddd95d94688ed742a2965c4b269d7c84e2d858.
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d9d6ce6eca6ca79fec95e93ce55d6e40da993de5">d9d6ce6e</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-11-27T10:25:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5: remove "set_dns_canonicalize" conf option
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2b88890adada76b1146591d62eb3898096f9105c">2b88890a</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-11-27T12:24:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">krb5: move disabling dns-canon to lower level init calls
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Nov 27 12:24:16 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9983caaa47de2dd983f704867fad509f4d7196b1">9983caaa</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2019-11-29T00:44:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool group show: fix a copy-paste mistake
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c35b3ef2e1e79559c4293a413f5d422908546919">c35b3ef2</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2019-11-29T00:44:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool tests: remove duplicate definitions of test functions
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0b04d9f2ec85f10dac8cd8723deea3a18925deea">0b04d9f2</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2019-11-29T00:44:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool tests: prepare tests for new samba-tool functionality
Use ldbsearch instead of "samba-tool user show" to get base64 encoded
attribute. Used to verify that the attribute value has been changed
successfully.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6d1a0eb8d11dc0ad62500d977fafc7411d6f39ed">6d1a0eb8</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2019-11-29T00:44:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool {user,group,computer,contact} show: avoid base64 encoded strings if possible
Be more user friendly and use clear text argument strings if possible.
Signed-off-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/12b3f26eee88ac810d08197d64019f5c4cfa2a03">12b3f26e</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2019-11-29T00:44:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool tests: re-add tests for attribute value verification using samba-tool
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bd81733bb7c5af3fb2f98bf475d53507c3955b31">bd81733b</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-29T00:44:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Make CFDATA private to cab.idl and remove pull and push functions
We can do this because ndr_{pull,push}_CFDATA is unused.
The earlier commit 466d5e814727046dd630d5503b43874ec46a365e removed
the link between "uint16 cbData" and the size of "DATA_BLOB ab" so
when the new ndr_fuzz_X fusser pushed a new structure this allowed
a read beyond the end of allocated memory.
The ndr_push_cab_file() function is also manually written and
does not rely on the value of cbData to calculate the checksum.
Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
fuzzer, which like ndrdump's struct mode uses the public structure
tables. (This is how it found the unused functions to test).
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/674d2cfd04e79fc35317198c5e9e88734b14a5b9">674d2cfd</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-29T00:44:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc/ndr: Remove unused ndr_cab_generate_checksum()
This function is not just unused, it is a problem because there is no
enforced connection between r->ab.length and r->cbData.
The last caller was removed in the previous commit.
Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
fuzzer.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bbae56411c716d8678687cf7c559488b618e8935">bbae5641</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-29T00:44:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndrdump: Show the actual struct/function name in the print, not just what it was called
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ef0257b1055cfea3ca0bee69d8848f5719300911">ef0257b1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-29T00:44:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndrdump: Improve error message when the pipes fail to dump
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b866018c2c89f6118c18d7a3527a0fa6d9916b9e">b866018c</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-29T00:44:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndrdump: Do not run the validate step after a failure
This avoids ending a failed parse with 'dump OK'
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cddc229a4689f1d1757f427cd58816c1af2e628f">cddc229a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-11-29T02:09:11+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Test partial parse behaviour in ndrdump
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Nov 29 02:09:11 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7c4341c736c875d048ca622217f762b895a945ba">7c4341c7</a></strong>
<div>
<span>by Michael Hanselmann</span>
<i>at 2019-12-01T08:55:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Split winbindd into library and binary
The winbindd program was built in a single target with many source file,
making reuse of parts elsewhere impossible. With this change the
majority of the code is built as a subsystem and included in the binary
as a dependency.
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/27fc062d7ea2207242d5a2c9933f3de5fa206488">27fc062d</a></strong>
<div>
<span>by Uri Simchoni</span>
<i>at 2019-12-01T10:22:00+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">heimdal-build: avoid hard-coded /usr/include/heimdal in asn1_compile-generated code.
This fixes a cross-compilation issue, as cross-compilers (rightly)
complain if host include directories are in the include path.
The fix is taken from buildroot (https://github.com/buildroot/buildroot/blob/8b11b96f41a6ffa76556c9bf03a863955871ee57/package/samba4/0006-heimdal_build-wscript_build-do-not-add-host-include-.patch) where it was applied by Bernd Kuhls <bernd.kuhls@t-online.de>.
This reverts some of 3fe2bfddda6149f6bf7402720226e9285f479fef, but
building Samba's bundled Heimdal with a system roken is not supported
anyway.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13856
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun Dec 1 10:22:01 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7093356440d0828f133fe652b090125af51cd01a">70933564</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-02T21:23:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Make stdin_new_passwd() static
It's only used in one place
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martins@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6ab4b87a7e61d5af6e7980380c0f307bc310e5f0">6ab4b87a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-02T21:23:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove duplicate get_pass() prototypes
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martins@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/34c269ad02cbb6fae0d9b9db43d6700d06de1842">34c269ad</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-02T21:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove a duplicate fdprintf() prototype
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martins@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6d1ce7dc1723e0c9f63b6b5ec08141f198049a56">6d1ce7dc</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-02T21:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Use vasprintf() in winbindd_cache
Don't need to panic, we can do explicit checks in these few callers
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martins@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/39f9618316946783bf7ceb5baf8667e139f3301c">39f96183</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-02T21:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove unused smb_xvasprintf()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martins@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/18d7bb0698361900593bfe33c8655ba32a3671cd">18d7bb06</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-02T21:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_do_locked() in smbd_do_unlocking()
We don't really need the share mode data here
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8d8d2bdfa4f988bf5fdc9e05f7f3d1b4b6c54d0d">8d8d2bdf</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-02T21:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Avoid leaking share_entries.tdb records
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4cd6c87a3d54e37b86c03b5d4bc0c24386fdfffb">4cd6c87a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-02T21:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libndr: Fix a talloc context leak
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/77d3a98aa63f37a8ced01c65fdb9b05ca68c6281">77d3a98a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-02T21:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a82ab4a7b3baaafab91b3e8f0746de70b07c306d">a82ab4a7</a></strong>
<div>
<span>by Puran Chand</span>
<i>at 2019-12-02T21:23:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbclient doc fix
Signed-off-by: Puran Chand <pchand@vmware.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1b583bff72cb47860abc5168cc96d9087df16604">1b583bff</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-02T22:47:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth3: Remove auth_script
Did this ever really work?
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Dec 2 22:47:24 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/787adfbcc9381b19330f1f73c95e34d25613f6b6">787adfbc</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-12-03T23:36:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:heimdal_build: move krb5-types.h into include/krb5-types.h
source4/heimdal_build/include/ contains public headers,
which are needed by callers.
source4/heimdal_build/*.h should only be used for building the
in tree heimdal itself.
Without this an '#include "replace.h"' can catch 'config.h' from
source4/heimal_build/config.h before bin/default/include/config.h.
This #defines HAVE_CLOSEFROM unconditionally before replace.h can define
the replacement for rep_closefrom() on systems without libbsd.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Dec 3 23:36:17 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7127a615cbd742695cea5865533c1ee7098ecc10">7127a615</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-12-04T05:10:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc ndr: Infinite loop parsing Suplemental creds
Fuzzing by Michael Hanselmann found an infinite loop parsing a malformed
supplemental credentials structure. There are no server-side
network-accessible calls using this code.
This patch adds an ndrdump blackbox test to replicate the issue.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13874
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bf8063e369a227eecc902f90277fc59d9d0ad167">bf8063e3</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-12-04T05:10:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc ndr: Tests for ndr_pull_string
Tests to ensure that ndr_pull_string handles zero and one byte length
data correctly for both character strings and UTF-16 strings.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13874
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d15a3797c7949140c872e82cc42d4f7301a9bf82">d15a3797</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-04T05:10:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Avoid spinning on string_array elements with a short input
Without this protection we will spin during decode of a string_array or nstring_array
that is terminated by only a single NUL byte, not two as required by UTF-16.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13874
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/12cccf3447333dfd4f5e437cd57ca5ec68724fdd">12cccf34</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-04T05:10:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pygpo: use correct method flags
The METH_KEYWORDS argument must always be combined with METH_VARARGS.
In Python up to 3.7 this was checked at runtime, and as we had no callers to
get_unix_path() in Python we never noticed. In Python 3.8 it is checked at
import time, and everyone notices even if they aren't directly using GPOs..
Found and reported by Val Kulkov.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14209
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0cb2e6ac4c730e504cf40ec328e90874a2267d7e">0cb2e6ac</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-04T05:10:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: add a base class for PIDL parsers
There are about 5 object-oriented parsers, all with their own
effectively identical but differently spelt versions of pidl(),
pidl_hdr(), indent(), and deindent(). With this commit we add a base
class that they can all use.
The ultimate aim is to be able to add some debugging instrumentation
that benefits all[1] the parsers.
[1] The parsers (e.g. Samba::ServerNDR) which use global scope rather
than objects will not be affected.
The versions of the functions in this file follow the most
sophisticated versions of the soon-to-be subclasses. For example, the
pidl() function avoids spurious whitespace and puts #define at column
0, following the Python parser.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a78f69cb7d374adae470ac5e3dd9f3ac8175292e">a78f69cb</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-04T05:10:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: optionally annotate output for debug purposes
It can sometimes be hard to tell which bit of pidl generated which bit
of C. This commit wants to help.
If the PIDL_DEVELOPER environment variable is set (via waf
--pidl-developer or some other means), pidl will annotate *most* C
indicating which lines were generated by which bits of pidl. It looks
something like this:
_PUBLIC_ enum ndr_err_code ndr_push_auth_session_info(struct ndr_push *ndr, int ndr_flags, const struct auth_session_info *r)
{ //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParseTypePushFunction lib/Parse/Pidl/Samba4/NDR/Parser.pm:3079
NDR_PUSH_CHECK_FLAGS(ndr, ndr_flags); //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParseStructPush lib/Parse/Pidl/Samba4/NDR/Parser.pm:604
if (ndr_flags & NDR_SCALARS) {
NDR_CHECK(ndr_push_align(ndr, 5)); //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParseStructPushPrimitives lib/Parse/Pidl/Samba4/NDR/Parser.pm:1448
NDR_CHECK(ndr_push_unique_ptr(ndr, r->security_token)); //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParsePtrPush lib/Parse/Pidl/Samba4/NDR/Parser.pm:604
NDR_CHECK(ndr_push_unique_ptr(ndr, r->unix_token));
NDR_CHECK(ndr_push_unique_ptr(ndr, r->info));
NDR_CHECK(ndr_push_unique_ptr(ndr, r->unix_info));
NDR_CHECK(ndr_push_uint3264(ndr, NDR_SCALARS, 0));
/* [ignore] 'torture' */ //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParseElementPushLevel lib/Parse/Pidl/Samba4/NDR/Parser.pm:729
NDR_CHECK(ndr_push_DATA_BLOB(ndr, NDR_SCALARS, r->session_key)); //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParseDataPush lib/Parse/Pidl/Samba4/NDR/Parser.pm:604
NDR_CHECK(ndr_push_uint3264(ndr, NDR_SCALARS, 0)); //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParsePtrPush lib/Parse/Pidl/Samba4/NDR/Parser.pm:604
/* [ignore] 'credentials' */ //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParseElementPushLevel lib/Parse/Pidl/Samba4/NDR/Parser.pm:729
The comments starting with '//:PIDL:' have the function name, the filename,
and line number. The comment follows the ordinary output, and uses the '//'
style so as not to interfere with multiline /* */ comments if they happen
to exist.
A '//:PIDL:' comment is added whenever the pidl function or indentation
level changes, and very occasionally at other places if pidl runs for a
while without either of these things happening.
This does not affect pidl parsers that do not inherit from Parse::Pidl::Base,
and is careful to have no performance impact on non-debug generation.
This may help with semi-automated flow analysis.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4f0fba18867faa0578d63c26054d04afd7f8b019">4f0fba18</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-04T05:10:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl Samba3::ClientNDR uses Pidl::Base
We need to modify the '@ISA = ' line, because it overwrites
the inheritance from Pidl::Base.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5513558bb422132632da08574d02f3a568622138">5513558b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-04T05:10:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl:: adjust s4::Python pidl_hdr() to be the same as others
The common case is for pidl_hdr() to add a "\n", which we can
easily do here, allowing this to be merged into the Pidl::Base borg.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/803d9cf8dd7d1767a7d9ac6e846450eb99ba8d5e">803d9cf8</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-04T05:10:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl s4::Python uses Pidl::Base
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3fc222a1225658706444fd8118f9477b6a4baba4">3fc222a1</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-04T05:10:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl s4/NDR/Client: fix pidl_both()
This function was clearly meant to be adding output to both the .c and
.h files, but was only adding it to the .h due to a typo.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/574c8db54cf1ba06516a5036269bffd81e20d602">574c8db5</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-04T05:10:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl s4/NDR/Client: use Pidl::Base
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fd68ba8a10adf7439f842a787943b1ec4580d837">fd68ba8a</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-04T05:10:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: s4/NDR/Parser uses Pidl::Base
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/12f6698f76e29854d5097a266fb4e1658d88ae96">12f6698f</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-04T05:10:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl s4/TDR: use conventional ->{res} name
rather than ->{ret}, meaning this class can be moved to a Pidl::Base subclass
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8429418a88e803592f57e1997bfbe0f639f422c0">8429418a</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-04T05:10:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl s4/TDR: use Parse::Pidl::Base
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eddd6c52678b28131d5dba67e6a8eaf4e5696a92">eddd6c52</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-04T06:35:05+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: don't export parser class methods
These methods are not used or usable as exported functions. The
correct (and actual) usage is along these lines;
require Parse::Pidl::Samba3::ClientNDR;
my $generator = new Parse::Pidl::Samba3::ClientNDR();
my ($c_code,$h_code) = $generator->Parse($ndr, $header, $c_header);
where the methods are either explicitly referenced (new A::B::C),
or are called from the blessed object, neither of which need
exporting.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Dec 4 06:35:06 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/868bc05cf5d575e20edcce241e3af1d0fa6d9824">868bc05c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-12-04T20:02:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Allow smbd_smb2_process_negprot() to return NTSTATUS as it can fail.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a2d81d77c111379cbb6bd732c717307974eace0a">a2d81d77</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-12-04T20:02:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Ensure we exit on smbd_smb2_process_negprot() fail.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/836219c479b047403d2b0839a6b92ad637dbaea0">836219c4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-12-04T20:02:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change reply_smb20xx() to return NTSTATUS.
Not yet used.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f4caa4159bd3db5127e114718e606867348a4f47">f4caa415</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-12-04T20:02:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Change (*proto_reply_fn()) to return an NTSTATUS.
That way the caller can know if the negprot really
succeeded or not.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e84910d919e02feab2a297fccbbf95f333e32119">e84910d9</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-12-04T20:02:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Ensure we exit if supported_protocols[protocol].proto_reply_fn() fails.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/46899ecf836d350c0c29b615869851da7d0ad6fb">46899ecf</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-12-04T20:02:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: tests. Add test for fuzzing smbd crash bug.
Mark knownfail for now.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8db0c1bff6f42feabd2e4d9dfb13ae12cc29607b">8db0c1bf</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-12-04T21:27:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Only set xconn->smb1.negprot.done = true after supported_protocols[protocol].proto_reply_fn() succeeds.
Otherwise we can end up with negprot.done set, but
without smbXsrv_connection_init_tables() being called.
This can cause a client self-crash.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Dec 4 21:27:24 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/520bb70dfd65d0a5236aa83cb8d662be62169e54">520bb70d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-05T15:35:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb:tests: Avoid that the debug function overwrites memory
We are setting ldb_debug_string() as the ldb debug function. The context
we give it is only valid as long as we're in that function.
On failure, we jump to the teardown function. The pointer for
debug_string isn't valid anymore, but the ldb debug system still points
to that address, and when we store the location of the allocated string,
we overwrite memory, in that case something from talloc and a
talloc_free() then jumps into the nirvana.
Thanks to Florian Weimer who helped debugging this.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ea1c62f3c7180e9ad5024bfcaea2d905f0b7996f">ea1c62f3</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-05T17:13:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb:tests: Allow test filtering in ldb_mod_op_test
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Dec 5 17:13:36 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2ffccf9c016a91818e6617a53c5f9d54f5c70c8b">2ffccf9c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-05T17:14:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: fix a flapping test
The previous approach of using ls | grep $NAME for testing whether the previous
directory removal succeeded will fail in case $NAME is a substring of any
directory entrie's name.
Eg
NAME=tmp.123
and the directory contains an unrelated entry
tmp.123456
Using allinfo instead should fix this.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b4b25128b878cc4c41973de9c5ef5e9d0109a6a4">b4b25128</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-12-05T17:14:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/selftest: allow samba3.blackbox.dfree_command run NT1 & SMB3 tests
samba3.blackbox.dfree_command was a single test that run both NT1 &
SMB3 tests together. This allow the protocol to be passed into the test
script so the test can be divided into SMB1 & >=SM2 tests.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7c0ccbe1a004b96ccf726bda01262e5394c4d0b6">7c0ccbe1</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-12-05T17:14:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/script/tests: Prepare to split samba3.blackbox.net.misc for SMB1/SMB2
modify test_net_misc.sh to accept optional protocol, no protocol
specified and it behaves more or less as before (expect this time the
client max protocol is explicitly speficied)
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d4d2e0175a4fef00566efa276a779a4ec23794d2">d4d2e017</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-12-05T17:14:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/selftest: split SMB1 & SMB2 parts of samba3.blackbox.dfree_quota
samba3.blackbox.dfree_quota was almost exclusively a SMB3 test, only
one part was testing legacy SMB1 behaviour, this change splits this
out so the SMB1 part can be run independantly.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f56314a97c508e105cd2b981730cd4fd25b0c6e4">f56314a9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-05T17:14:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/selftest: Run samba3.blackbox.net.misc with smb1/smb2
samba3.blackbox.net.misc now can run with >=SMB2 or SMB1 protocols,
adjust previous test definition and add new one
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f26c678a2ca550de6207634a8ea1461699cf54d6">f26c678a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-12-05T17:14:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/script/tests: Allow test script to accept option protocol list
test_preserve_case.sh tests a range of protocols, this however
fails when running against the normal test env (which have min
protocol of SMB2) because one of the protocols is NT1. This change
allows tests to pass the protocol (or list of protocols) so that
tests can be split.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/980f7736fc0c569af6142288ac444775941426c3">980f7736</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-12-05T17:14:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/selftest: run samba3.blackbox.preserve_case with SMB1 & >=SMB2
adjust test generators to run SMB1 & >=SMB2 versions of
samba3.blackbox.preserve_case test.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a6451609993639616edcb6ee262381d5155774a1">a6451609</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-12-05T17:14:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/selftest: allow samba3.blackbox.smbclient_ntlm.plain run SMB1 & SMB3
samba3.blackbox.smbclient_ntlm.plain used test SMB3 & NT1 protocols
in one test. These changes:
* modify the test driver script test_smbclient_ntlm.sh to take a
protocol as param
* modify the test description generators to pass NT1 & SMB3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/921f9f797f125d5e7cfe5505cd4287d23c2ae8f9">921f9f79</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-12-05T17:14:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/script/tests: Use protocol param passed to selectively run tests
samba3.blackbox.smbclient_s3 passes NT1 or SMB3 to run tests however
the PROTOCOL param is not used consistently within the script which
results in NT1 and SMB3 traffic being produced during testing. This
obviously causes issues when running the tests in an test environment
where SMB1 cannot be negiotiated. These changes fix this
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aca1c949023bf4ac620fe8d21a5e2a6e12c48dae">aca1c949</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-12-05T17:14:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/utils: net time always hardcoded to use SMB1
net time ... cmd ignores any configuration to do with min/max protocols
and connects allways with smb1
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/66443fe9340f1ae3894016fd7be51780f4c631b4">66443fe9</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-12-05T17:14:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/script/tests: Add simple test for net share list
Adding a test for the net share list command. Currently this
command will fail because of a bug in the net command when it tries
to see if rpc is supported. This change adds a known fail to swallow
this error. A future commit will fix the net command and remove the
known fail
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5010535ec14d4e1f4dd83450432fc51a8ab53646">5010535e</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-12-05T17:14:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/utils: Make sure we can negotiate protocol based on smb.conf settings
net_rpc_check was hardcoded to check for rpc using SMB1 only. We
should negotiate protocols based on the client max|min protocol settings
this commit also removes the entry for
samba3.blackbox.net.misc.lookup share list
from knownfails as this test should now pass following this change.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e30607aff3149395ce908d8ebfcac0fe56daa1ae">e30607af</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2019-12-05T18:44:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/smb_server: Fix handling of SMB2 messages after Netbios session setup
On receiving a special NBT packet (e.g. session setup) the samba daemon
effectively sets up SMB1 as the negotiated protocol (in terms of
software handling of the messages) even though no SMB protocol
has yet been negotiated. If the next message after the nbt session setup
is a SMB2 message it will be handled by the SMB1 callbacks and will be
rejected. This is evident when using smbclient (with -p 139) option
in an env where SMB1 cannot be negotiated [*]
This change doesn't set up the SMB1 callbacks on receipt of NBT special
messages but lets the generic callback in place. Once either SMB1 (or)
SMB2 is established (by receipt of a 'real' SMB or >=SMB2 message) then
the proper callbacks will be set as normal.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Dec 5 18:44:40 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/809247973d9441c3d5249a7143cde6e858935d79">80924797</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-05T20:12:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:locking: simplify code in get_share_mode_lock()
The call to get_static_share_mode_data() is identical in the if/else branches,
so move it behind them.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Dec 5 20:12:23 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/41f6248effa5f5c0606a13da289c8a77abb30bce">41f6248e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-12-05T22:51:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">bootstrap: use runners with 'docker' and 'gce' tags for the image creation
As we currently have the 'shared' tag on our private runners, they
maybe selected for image creation, but it fails there.
A lot of shared runners provide 'docker' and 'gce' and they are able to
generate the images.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eefc8ee8e31c108114b6114df4ad006d33af1f4b">eefc8ee8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2019-12-06T00:16:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">bootstrap: add debian10 support
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Dec 6 00:16:45 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/397ecd1feb3c46b861df7d37228b3033f27a06fa">397ecd1f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: remove unused uint64s_nt_time_to_unix_abs()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d95be9135890279a845cc6712a15236aaa87e4d7">d95be913</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:tests: add a blackbox test that confirms broken timestamp behaviour
This blackbox test confirms that Samba returns NTTIME=0 when a filesystem object
has a UNIX timestamp value of 0, ie UNIX epoch start 1.1.1970.
Here's an example output from running smbstatus allinfo on such a file:
$ bin/smbclient -U slow%x //localhost/test -c "allinfo time_0_1970"
altname: T11662~T
create_time: NTTIME(0)
access_time: NTTIME(0)
write_time: NTTIME(0)
change_time: NTTIME(0)
attributes: (80)
stream: [::$DATA], 0 bytes
If you look at it with smbclient ls command, it munges the output to be 1970 so
you don't notice the problem:
$ bin/smbclient -U slow%x //localhost/test -c "ls time_0_1970"
time_0_1970 N 0 Thu Jan 1 01:00:00 1970
The test also test other time_t values -1 and 4294967295 that are used as
sentinel values in Samba code and shows that handling these values is equally
broken.
Same for time_t values < -1.
Note that I'm adding a blackbox test *and* a torture test, as with this blackbox
test I can directly control the server side, but with smbtorture I have to go
through the SMB stack to create the files which doesn't work currently.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5fe42bdcde1d686c885445a718f181a49953c918">5fe42bdc</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">replace: ensure UTIME_NOW and UTIME_OMIT are always available
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/96418cb15606a0969a50096e1c0e5de9c9e48d9a">96418cb1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: provide UTIME_NOW|OMIT defines under our own namespace
We may want to add additional defines in the future in order to deal with
NTTIME(-1) and NTTIME(-2) coming in over the wire. They have special semantics
attached to them, -1 requests "no automatic write time updates" on a filehandle
and -2 reenables them.
We could use something like
#define SAMBA_UTIME_FREEZE (SAMBA_UTIME_OMIT - 1)
#define SAMBA_UTIME_THAW (SAMBA_UTIME_FREEZE - 1)
in the future.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eb42beeb1bf06aa78a67407bd74216230b8b0ef5">eb42beeb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: add functions dealing with struct timespec UTIME_OMIT
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b5dc6aa7202957d6a68eb27150796ef669e81369">b5dc6aa7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: add full_timespec_to_nt_time()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7c1d8957353867470bbcb32cae19467b06f0e25d">7c1d8957</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: add a timestamps torture testsuite
Add a test that shows that setting timestamps to the special
values (time_t) 4294967295, 0, -1 and anything below is broken.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/af142df467fd434d5d45d55a3fd4c017bf673c7e">af142df4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: add nt_time_to_full_timespec()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6f9a824fdad1deb9e738850638328d04731b9d7a">6f9a824f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: add full_timespec_to_time_t()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2e687d0e4dba9a0f94e532726e1f3dceaa3ed840">2e687d0e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: add nt_time_to_full_time_t()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2b938b4d339de095c670661600431bd6383a747b">2b938b4d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: use nt_time_to_unix_full() in nt_time_string()
This enables printing time values before the UNIX epoch coming in over the wire
in smbclient allinfo command.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/928694af7e79edd0a48e43bb48af6fab9d32da89">928694af</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: add timespec_string_buf()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7a69f642d7b138255a73ef42ab6dd9a5e50e5309">7a69f642</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: add time_t_to_full_timespec()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f2af647e7dd9fce537ce1c82e965486eee79aa27">f2af647e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: canonicalize pull_dos_date3()
Returns 0xFFFFFFFF as (time_t)-1. This avoids misenterpreting 0xFFFFFFFF as a
valid time_t value (0xFFFFFFFF = Sun 07 Feb 2106 06:28:15 AM GMT) on 64-bit
platforms where time_t is 64-bit.
Currently direct and indirect callers of pull_dos_date3() rely on the fact that
the resulting time_t is checked with null_time() which also checks for
0xFFFFFFFF as sentinel value amongst 0 and -1:
return t == 0 ||
t == (time_t)0xFFFFFFFF ||
t == (time_t)-1;
By returning -1 instead of 0xFFFFFFFF, callers can safely pass the result to
unix_to_nt_time() which *doesn't* check for 0xFFFFFFFF, only -1.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e3ad7e36a3fc8f5bd000481ac34c8fd3d2d747fd">e3ad7e36</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: let round_timespec() handle SAMBA_UTIME_OMIT
This ensures callers are not required to do the check themselves and we don't
clobber omit-timespecs in this function.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b1a3445e3dbd9c08bc733377f7c3b95a9e8d2755">b1a3445e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: add put_long_date_full_timespec()
put_long_date_full_timespec() will be used in the fileserver to marshall struct
timespec timestamps that are sent to the client. By using
full_timespec_to_nt_time() which supports tv_sec=0 and negative values, we can
return timestamps to clients with a date before the UNIX epoch.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/572d4e3a56eef00e29f93482daa21647af7310d0">572d4e3a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use put_long_date_full_timespec()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e8c9559847503f20cf87f1dbe353ee7d9796ad64">e8c95598</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: add pull_long_date_full_timespec()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7d4be660bbd90c04657ffb3e46b585f164657c5a">7d4be660</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use pull_long_date_full_timespec()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/02f18a3980cfa10ccb8448f0f125ae9164648997">02f18a39</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: use nt_time_to_full_timespec() in interpret_long_date()
interpret_long_date() is now only used in the client. To enable correct
processing of dates before the UNIX epoch, call nt_time_to_full_timespec().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2a82caf57ed10e8c838c157314248a124848c571">2a82caf5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbclient: use full_timespec_to_nt_time()
Needed to support dates corresponding to (time_t)0 and (time_t)-1.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1b9c31ef6ae8ffe1ee052b34d5013032cd37838a">1b9c31ef</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: add cli_setpathinfo_ext()
This takes a struct timespec instead of just time_t as cli_setpathinfo_basic()
does. This is needed to pass sentinel values -1 in the smbclient utime command.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c6beb71813c015fddda02190e8093c335a2de411">c6beb718</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbclient: use cli_setpathinfo_ext() in utimes command
This allows correct processing of sentinel date values.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6e58cfab98d958c8008c77b0d909a3384de28d7b">6e58cfab</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: add init_smb_file_time()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/69691dd0cd5fac292bfb1c1dc28136ae253bbc76">69691dd0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T00:17:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: fix handling of sentinel timestamp values
This implements two core changes:
* use NTTIME instead of struct timespec at the database layer
* use struct timespec { .tv_nsec = SAMBA_UTIME_OMIT } as special sentinel
value in smbd when processing timestamps
Using NTTIME at the database layer is only done to avoid storing the special
struct timespec sentinel values on disk. Instead, with NTTIME the sentinel value
for an "unset" timestamp is just 0 on-disk.
The NTTIME value of 0 gets translated by nt_time_to_full_timespec() to the
struct timespec sentinel value { .tv_nsec = SAMBA_UTIME_OMIT }.
The function is_omit_timespec() can be used to check this.
Beside nt_time_to_full_timespec(), there are various other new time conversion
functions with *full* in their name that can be used to safely convert between
different types with the changed sentinel value.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fe2901e1074afbc488e92a6b930a9430f09063d9">fe2901e1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-06T01:45:21+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: document SMB_VFS_NTIMES() interface change
BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Dec 6 01:45:21 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9a1072ddb6b5ddf7916496068cf9c155eb7762c8">9a1072dd</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-06T09:12:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Avoid a possible NULL pointer dereference
Found by cppcheck.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e464e40c977cd6592240763c7dbb9c45ff16470f">e464e40c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-06T09:12:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb:tests: Use assert_in_range() in test_get_size()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9323b5c50042738b4afbea3dc0db0ddbc096f99c">9323b5c5</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-06T09:12:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb:tests: Add missing size check for tdb
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e79e943824ad0960916585d09d0dd6061f7518f9">e79e9438</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-06T11:13:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb:tests: Add missing null check for ldb_kv_private
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Dec 6 11:13:24 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/63600b4f7841e0a81e40599947dbc62e07078aa2">63600b4f</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Multi-line a long list of deps
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/42035d1159718a39bd00a3289300c91ec62ecf50">42035d11</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: messaging.c uses talloc_report_printf()
This used to be talloc_report_str()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2f2961a1170cd6fcd0f95e30bd243c051276c125">2f2961a1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: libcli/http does not need samba3core, only gensec
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cec30b2e063a4965fee2d4d9e8a50979a4f7647d">cec30b2e</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: gencache.c in 'samba3core' needs crc32()
This comes from zlib, make the dependency explicit
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9e640226621e11c2bd44450c3c284d9f72bfa714">9e640226</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Explicitly depend on samba-modules where needed
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/61b86d30d0218aab274601dd8d7d5c1ff6b5cf4f">61b86d30</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Make lp_use_sendfile() static to reply.c
This is the only place where it's used. Also, via
smb_signing_is_active it pulls in the dependency on
'cli_smb_common' (which pulls in all of gensec) into the 'smbconf'
library. Without this, 'smbconf' is happy with just 'samba-hostconfig'
instead of 'cli_smb_common'
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cf9a029758459399a9ad93f6bd1e393cee644fdc">cf9a0297</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: secrets3 need E_md4hash and kerberos functions
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4ff3e8ee8e1ec0d21db9d103dd6fb04c24c3eaaa">4ff3e8ee</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: util_cmdline depends on cli_credentials
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/415fb7d2df4fdefd8aa78edde29abf64a008341b">415fb7d2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Trim the deps of 'smbconf'
This does not pull in gensec anymore
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0bc3e7499b9a8a9d360f6c9454210f3cad334f90">0bc3e749</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Panic if there's a leak in share_entries.tdb
Hopefully dbwrap_tdb's dbwrap_exists is cheap enough for this to not
impact performance too much. I could not measure any difference in an
open/close benchmark, but at some point things might pile up and we
might have to make this a #ifdef DEVELOPER
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f3802023feb9e5dfa82d2174437b7576470f575b">f3802023</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-08T20:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Make durable_v2_delay more specific
It will grow another subtest soon
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8435128582adf81a18e9d929970074d4f2326d20">84351285</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-08T20:24:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Test cleanup of disconnected durable handle records
Right now this panics the scavenger daemon, preventing it from doing
its work. The reopen we expect to fail with
NT_STATUS_OBJECT_NAME_NOT_FOUND thus succeeds. I know that we should
more precisely detect the scavenger crash and with Jeremy's pattern in
46899ecf836 this would be possible. However, this is C code right now,
and scanning the logfile for the panic is more I have time for right
now. The test successfully indicates failure, as the next commit will
show.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9c81aa9dabc3dcb96fef169521bc7cb6e601a2e9">9c81aa9d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-08T20:24:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix a share_entries.tdb record leak
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5b8b9cd1c4d0065d6987658fdd8e9ec0a7c37a6b">5b8b9cd1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-08T20:24:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:smbtorture: also test for date >> UINT32_MAX in timestamps test
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/241f3709de5bc8db39ec47976428e0284b79fb16">241f3709</a></strong>
<div>
<span>by Richard Sharpe</span>
<i>at 2019-12-08T21:50:52+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml/Samba-Developers-Guide/vfs.xml: Fix incorrect VFS func names.
Use SMB_VFS_P{READ,WRITE} since the others have been retired.
Also, fix up the definitions.
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sun Dec 8 21:50:52 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b05be655a9218add833d41a1765166de92431897">b05be655</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-09T10:11:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:tests: Remove the -I SERVER_IP so that Kerberos auth works
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8987d7eef4f2e1cb1ed29c3607bb6218f6cf668d">8987d7ee</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-09T11:57:52+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:selfest: Do not print the env twice
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Dec 9 11:57:52 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1b42ccfc23eaa8f5b007928bc8bb65b944359f36">1b42ccfc</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-09T12:48:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbspool: Map AUTH_INFO_REQUIRED=none to anonymous connection
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6201b30421f616ec3f118321fd2998435792a4cc">6201b304</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-09T12:48:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbspool_krb5_wrapper: Map AUTH_INFO_REQUIRED=none to anonymous
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/58a90358e2e8ff70c65eb49a21d00c5ce775ba54">58a90358</a></strong>
<div>
<span>by Mikhail Novosyolov</span>
<i>at 2019-12-09T12:48:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbspool_krb5_wrapper: ignore unknown values of AUTH_INFO_REQUIRED
To make smbspool_krb5_wrapper usable as a default destination for symlink
/usr/lib/cups/backend/smb in Linux ditros, it has to be well-prepared
for any possible values of AUTH_INFO_REQUIRED set by cupsd and correctly
pass printing tasks to smbspool if it sees that Kerberos authentication
is not needed.
Discussed here: https://lists.samba.org/archive/samba-technical/2019-October/134470.html
Signed-off-by: Mikhail Novosyolov <m.novosyolov@rosalinux.ru>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c95d32f685d989c91e62a734229d2bd241291315">c95d32f6</a></strong>
<div>
<span>by Mikhail Novosyolov</span>
<i>at 2019-12-09T12:48:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbspool: print a hint about smbspool_krb5_wrapper
When I first met with the situation that Kerberos kredentials cache of root
user was looked for instead of the one of the printing task creator,
it took a lot of time to understand that smbspool_krb5_wrapper will resolve this.
Signed-off-by: Mikhail Novosyolov <m.novosyolov@rosalinux.ru>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/67f455c3d576a0bc3174fd10cf4f3244621b6b13">67f455c3</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-09T14:18:11+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbspool: Leave early if we print as root
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Mon Dec 9 14:18:11 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/99d153fad120e0a9335ec474296f55a2e258561a">99d153fa</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-09T16:10:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: add NTTIME_MAX, NTTIME_MIN, NTTIME_OMIT and NTTIME_FREEZE definitions
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f0813cbf4f507462b5b9aa0e913483232e51bea5">f0813cbf</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-09T16:10:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: harden full_timespec_to_nt_time()
This protects against overflows when tv_sec is less then
TIME_FIXUP_CONSTANT_INT.
It also correctly limits the range of returned values to be
[NTTIME_MIN, NTTIME_MAX].
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e1230f6e45bb076af9f6efda04405b0874430681">e1230f6e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-09T16:10:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: add a comment to nt_time_to_full_timespec()
Add a hint explaining why and how -1 should be treated differently in the
future. Also make use of the helper function make_omit_timespec().
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f576c02bf9365ff538a46dadfe8ce1f1aa19664c">f576c02b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-09T16:10:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use NULL instead of 0 for a pointer type
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a34d75f6f7e56a76b4e3d5399742e5ac837bafdd">a34d75f6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-09T16:10:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Use sizeof() where appropriate
One magic number less that needs to be verified manually
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/27c69b58929ea45bd7108372468cf6c63b80c449">27c69b58</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-09T16:10:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Call reopen_logs() in the smbd scavenger
If you have per-process logfiles with %d, the scavenger will get its
own logfile
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/37fa97b20e30c13cd59f2a58f61d09a3ff761ac4">37fa97b2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-09T16:10:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Call reopen_logs() in the notifyd
If you have per-process logfiles with %d, the notifyd will get its
own logfile
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b6ffbc7d923cbe8c51a02e70d7ea8d2b8035b10e">b6ffbc7d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-09T16:10:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: Extend some debug information
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f2a91426b791d1fc1b1655dfd4b8af5d50142d08">f2a91426</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-09T17:33:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Give a better error message for non-existing share modes
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Mon Dec 9 17:33:42 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a5e3db5b5125c2f9921a51837ac8d696b8f4260e">a5e3db5b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-09T19:23:10+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: spelling fix
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Mon Dec 9 19:23:10 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bb2296f68a36a3b85a5702062a5e488f9d6616dc">bb2296f6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-10T00:29:54+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Fix the build without system gssapi headers
source4/heimdal/lib/gssapi/gssapi/gssapi_krb5.h and gssapi_spnego.h
have an #include <gssapi.h> which they need to find via the -I paths
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Tue Dec 10 00:29:55 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c2e55821bc5db1a33ecd2f7550a75ebdbe7613f9">c2e55821</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-10T00:30:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:lib: Make sure we close fd's in error path
Found by covscan.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/94c3c12df11dccdc34ef91f3065240f34a7244be">94c3c12d</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-10T00:30:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: Fix string compare for utmp entries
The members of struct utmp are marked as nonstring. This means they
might not be nil-terminated.
Found by covscan.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cfa0526100575a7684879bb64f5e492c578bef87">cfa05261</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-10T00:30:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:torture: Do not segfault if cli is NULL
This can happen if we fail early and cli hasn't been initialized yet.
Found by covscan.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8753d5f4567e1bc39c25ea11d444bed6d0afea46">8753d5f4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-10T00:30:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: Fix possible NULL deref in smbd_do_qfilepathinfo()
Found by covscan.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/adfdcc4791b9a5706c48789bfbb46f256ee10538">adfdcc47</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-10T00:30:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:lib: Move NULL check before messaging_dgm_out_rearm_idle_timer()
We dereference out in messaging_dgm_out_rearm_idle_timer().
Found by covscan.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1c65f1fddba77e94edc5338af81c9a25e0d4e970">1c65f1fd</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-10T00:30:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth:tests: Improve debug output of test_gnutls
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/01f531ba6ba1306e99d2e4715dadae073eb0a8ec">01f531ba</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-10T00:30:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth:tests: Only enable torture_gnutls_aes_128_cfb() on GnuTLS >= 3.6.11
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/07b4606f893fabd50c2685307d58e86f55defae5">07b4606f</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli/auth: test des_crypt56() and add test_gnutls to selftest
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7044a41a30e43dda34eecb6df3da82ed5d568eec">7044a41a</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: test E_P16
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0923f94bdc21a80cbf40aaa65c4928c13c298d82">0923f94b</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: test sam_rid_crypt
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dfad082596a53a7c6225da427447922fd4b7f0e2">dfad0825</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: test E_P24 and SMBOWFencrypt
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8f042ba532fc645f2389a0a9d3e83d27c070fde4">8f042ba5</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: test E_old_pw_hash
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e2f8f686d1e3fce91f10aadb9667854cf2a1219a">e2f8f686</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: test des_crypt128
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/394debac6b2f0838cde5d850335e0cdff14b411d">394debac</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: test des_crypt112 and fix (unused) decryption
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a4ec427e54b52307ee2e22079449ff3e59279298">a4ec427e</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: test des_crypt112_16
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6c5f153e4793c0613dd843b1566bd27632912a7c">6c5f153e</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: test SMBsesskeygen_lm_sess_key
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2c470c8035be6d70ce3fc8d1e12be284566a7037">2c470c80</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: test sess_crypt_blob
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0f855f1ab955e3ecf47689c5e4578eb67ebe8f27">0f855f1a</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdes: add des_crypt56_gnutls() using DES-CBC with zeroed IV
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/38189f76d8b958fff8a6351f3fb21f6ed04b76da">38189f76</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">netlogon_creds_des_encrypt/decrypt_LMKey: use gnutls and return NTSTATUS
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bbcf568f317960229caa7486322858093f5d0d04">bbcf568f</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">SMBsesskeygen_lm_sess_key: use gnutls and return NTSTATUS
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ecee1998034b84026ab604dbe4400d9e53dcafd4">ecee1998</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdes: convert sam_rid_crypt() to use gnutls
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9fb6361a8b09fd575bab2f5572fa9e10bd538eed">9fb6361a</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdes: convert E_P16() to use gnutls
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2eef12904f2c08257394a2ee869960f7c2e09112">2eef1290</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdes: remove D_P16() (not used)
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a5548af018643f2e78c482e33ef0e6073db149e4">a5548af0</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdes: convert E_P24() and SMBOWFencrypt to use gnutls
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c57f429574243adbcd43dca4f35d125df8d69ba0">c57f4295</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdes: convert des_crypt128() to use gnutls
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dce944e8a1119034f184336f6b71a28080152a0a">dce944e8</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdes: convert E_old_pw_hash to use gnutls
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/254739137bdaebca31163f1683bfd7111dfefe67">25473913</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdes: convert des_crypt112 to use gnutls
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dcc33103d5c0927bb3757974d4663df888dce95e">dcc33103</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdes: convert des_crypt112_16 to use gnutls
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a75ca8d5d515aef1229acf5a30489ee5f5ced3e1">a75ca8d5</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">session: convert sess_crypt_blob to use gnutls
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b5d8f1f78a04719c6a5d15aa92ae398be326fe56">b5d8f1f7</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">sess_crypt_blob can only crypt blobs whose size divides by 8
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fe2577a40c19c99c29dd54c7c43e12f3d43493be">fe2577a4</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T00:30:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbdes: remove old unused DES builtin-crypto
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/83ffe6752d589180eac96d7b8e7d1a54e3476bfd">83ffe675</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-10T01:54:02+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: Remove Parse/Yapp/Driver.pm
This file is provided by Parse::Yapp and on install we overwrite the
orignal file.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Dec 10 01:54:02 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f786cdf5e84f70c9a0ca206c761d453d42e72251">f786cdf5</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T02:53:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add ndrdump tests for malformed drsuapi traffic
Thanks to Douglas Bagnall for the samples, produced from seeds
generated by Samba's make test traffic, fuzzed by ndr_fuzz_X
and Hongfuzz.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b6913830bf626c8d7059f4cda3a4fc1bb3081973">b6913830</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T02:53:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc/ndr: Do not follow a client-supplied NULL pointer in _print_drsuapi_DsAttributeValue_attid()
This is not a security issue as it only happens when printing the structure
during debugging, not normal production.
Found by Michael Hanselmann using an NDR fuzzer and Hongfuzz.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/efef4366f18515ec78cb025928c20fb7986cd98f">efef4366</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-10T02:53:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: use perl warnings
Warnings are good. If we turn on warnings with 'use warnings', we will
see bugs that have lain latent for years.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2765b5c1a27232b990537415718e98449617641b">2765b5c1</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-10T02:53:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl s4::NDR::Parser: read hex numbers as numbers for ranges
Hex numbers in IDL are not parsed as numbers, resulting in warnings
like
Argument 0x2000 isn't numeric in numeric lt (<) at /home/douglas/src/samba/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm line 981
not to mention problematic code. We add a utility function to convert
these numbers to numbers.
A typical difference this makes is:
--- old/default/librpc/gen_ndr/ndr_dcerpc.c 2019-11-30 23:40:32.915816967 +1300
+++ new/default/librpc/gen_ndr/ndr_dcerpc.c 2019-11-30 17:00:09.055733660 +1300
@@ -1893,7 +1893,7 @@
if (ndr_flags & NDR_SCALARS) {
NDR_CHECK(ndr_pull_align(ndr, 4));
NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, &r->ReceiveWindowSize));
- if (r->ReceiveWindowSize > 0x40000) {
+ if (r->ReceiveWindowSize < 8192 || r->ReceiveWindowSize > 262144) {
return ndr_pull_error(ndr, NDR_ERR_RANGE, "value out of range");
}
NDR_CHECK(ndr_pull_trailer_align(ndr, 4));
Where the minimum ("0x2000" == 8192) was read as a string, thus
treated as zero.
The treatment as zero was introduced in 142b2a61f8a77b3065ce4c78b459ab714d6d190a
accidentially, which shows why warnings are important.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aefce8e7c0d82241ab6ecfab7d714338b331bc52">aefce8e7</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-10T02:53:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl s4::NDR::Parser: correct has_fast_array logic
Here we fix two bugs that cancelled each other out completely, so this
patch leaves us with exactly the same functionally as before.
Bug 1: In perl, return is *syntactically* a function.
That means 'return X or Y' is read as 'return(X) or Y', as in the
'open(X) or die "..."' construct -- Y is only evaluated if return
returns false. But return never returns, so Y is dead code. If in
doubt, try these:
perl -e "sub x {return 0 or die;} x"
perl -e "sub x {return (0 or die);} x"
What we *meant* here is 'return (X or Y)', BUT it turns out we were
confused -- the Y case was bogus.
Bug 2: string arrays never had "fast array logic" in the first place.
The fast array logic is for arrays of bytes, and can be fast (i.e.
memcpy) because there is no endianness to worry about. A string array
is an array of pointers not bytes.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4de002a0f77dba8345ca6c395a855a5c053a8dd4">4de002a0</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-10T02:53:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl s4::NDR::Parser: silence a warning
At level 0 there is no previous level so $pl is undefined thus so is ->{TYPE}
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/33255102acd755cacceafd2a082722ed0fbc695f">33255102</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-10T02:53:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl Parse::Pidl::NDR: warn of unknown scalar alignments
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3c90c9de6f45af60d9db5f40ec0dad6318e53e3d">3c90c9de</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-10T02:53:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl Parse::Pidl::NDR: add HRESULT alignment
this is a guess
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/51a11afecf590a26b784c1d2e484829330efa44f">51a11afe</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-10T02:53:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl Parse::Pidl::NDR: silence two warnings about undefined strings
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fbe402edf55cc4dda8820645c7c4e20862969803">fbe402ed</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-10T02:53:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl s4::Python: silence warnings
- do not redeclare variables in the same scope.
- use $1 instead of \1, which perl just prefers.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ef5d79e24ba8aec226419e594de0cf91c24d7fc4">ef5d79e2</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-10T04:16:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl/tests/samba-ndr.pl: remove duplicate import
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Dec 10 04:16:31 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7b265830ad6796dbbe721f7abfd62a19c2185b65">7b265830</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-10T07:50:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing: add fuzz_ndr_X
This NDR fuzzer links with each "interface" in the IDL files to
create avsingle binary. This tries to matches what the fuzzing
engines desire.
It started as a copy of ndrdump but very little of that remains
in place.
The fancy build rules try to avoid needing a lof of boilerplate
in the wscript_build files and ensure new fuzzers are generated
and run when new IDL is added automatically.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Pair-programmed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e737988641905180d7d9a4e5cc88a85637deaab6">e7379886</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-10T07:50:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dcerpc: developer option to save ndr_fuzz_X seeds
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Pair-programmed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c0043e2352691e5ee3885558e5c1894dda342a70">c0043e23</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-10T07:50:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">fuzzing: Add script decode_ndr_X_crash to decode crash results
This interprets a file that crashes an fuzz_ndr_X binary
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/afe866086c00d433e270a94c782f551e5b00263b">afe86608</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-10T07:50:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing/decode_ndr_X: print less by default, avoid pipe
ndrdump can now take base64 input directly.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c35fe03a63cae908d879328fe4238ed1df1b158d">c35fe03a</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-10T07:50:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">fuzzing/decode_ndr_X: read crashes from a HONGGFUZZ report
In theory, you should be able to run honggfuzz and go
$ lib/fuzzing/decode_ndr_X_crash -H HONGGFUZZ-REPORT.txt > crash-crash-crash.sh
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3ca76f59070020ea188bea88bece38d8c9036f59">3ca76f59</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T07:50:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Fill in full deps for NDR_* subsystems
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6f7a9e87887e50160df6a06b09d8454eef9208a1">6f7a9e87</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T07:50:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing: Link only the required NDR_ subsystems into ndr_fuzz_X binaries
This reduces the binary size and shows that we are linked against the correct
ndr_table_ global variable. This might help the fuzzing engine know there
is not much more of the binary to find if unreachable code is not included.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c16e4dcad9cb8dc16ceacb94b9ba6ce094f4e507">c16e4dca</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T07:50:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzer: Remove rudundent install=False flag from fuzz_ndr_X build rule
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a9a8bcf731659f0898f70759e78a9909f018ae48">a9a8bcf7</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T07:50:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzer: Allow building a fuzz binary for just one interface
This helps direct the fuzzer at a particular function that we are concerned about.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/000d86f537866a3c83f06d7b128532119df45dd9">000d86f5</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T07:50:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing: Tell the compiler we know we are ignoring errors in fuzz_reg_parse
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f4ff9a079414953b17f49857ecfca6c0e479c32f">f4ff9a07</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T07:50:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing: Also confirm we can make a string filter from the parsed tree in fuzz_ldb_parse_tree
This also avoids tree being an unused variable.
This is similar to doing an ndr_push() in ndr_fuzz_X, it
catches some of the cases where the parse is successful but
the application code could misinterpret the structure.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1d98ced841f83d7305a570297908fd1270de42e0">1d98ced8</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T07:50:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing: Add mode for the AFL fuzzer
This is helpful for ensuring the fuzzers still compile in autobuild as no
library support is required.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/47c7f549955b8c01d5fbe09a0f9ccc3503b94c63">47c7f549</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2019-12-10T07:50:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">fuzz/decode_ndr_X_crash: -f to filter crashes by regex
If you go:
$ ./lib/fuzzing/decode_ndr_X_crash -H HONGGFUZZ_REPORT.txt -f 'SIG[^V]' > ./crash.sh
you will get all the crashes and not the timeouts (which have SIGVTALARM)..
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8382fa6408ef5efc45260e332579a6d9ee648d87">8382fa64</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T07:50:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">oss-fuzz: Align build.sh sh parameters with pattern from the oss-fuzz project
We should run build_samba.sh with -eux to ensure we exit on failure,
refuse to use an unset varible and print the commands we are running.
(The suggested build.sh on the oss-fuzz side uses -eu).
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f79caf3b6bf4b3c4942874af70cfa8c912959faa">f79caf3b</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T07:50:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing: Remove oss-fuzz build.sh stub from the Samba repo
We need to ship the stub build.sh in the oss-fuzz repo, not ours.
This is because otherwise the travis CI checks skip the build
(it thinks we are not set up yet, or have been disabled).
See https://github.com/google/oss-fuzz/pull/3094 for the PR
creating a similar file there. This is very similar to how
janus-gateway operates, so this is an accepted pattern.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5bb9ecdf15febb492bf9b65f5811ca0b59fefec8">5bb9ecdf</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T07:50:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing: Support an oss-fuzz build with either address or undefined behaviour sanitizers
Add handler for $SANITIZER in build.sh
This allows a build with the undefined behaviour sanitizer.
Otherwise we fail the oss-fuzz CI because the UBSan build links with ASan..
Once this in in then https://github.com/google/oss-fuzz/pull/3094
can be merged to oss-fuzz.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5e5d18c5b1e710a747ede56efe10792957f11552">5e5d18c5</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T07:50:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing Add comments to explain RUNPATH manipulation in build.sh
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4c8388fb19865c7e0aa6facf43b6cbd1906a6b2c">4c8388fb</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T07:50:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing Truncate the original files after RUNPATH manipulation in build.sh
This saves space on the rackspace runners in particular.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/96184c10b8d048a67e57b7b838a1da2a1588455c">96184c10</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T07:50:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Skip build of python bindings when in fuzzing mode
This will just save a bit of time and space.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8b06cabc7d735f8a780b832ddb7d5ab2989e661f">8b06cabc</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T09:15:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">bootstrap: Add chrpath as a required package
This is used to test build.sh, part of the oss-fuzz integration, and so also that we
correctly build our fuzzers.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Dec 10 09:15:43 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a25a2e4513e48d0408b1f5e78ada0b3569d3426d">a25a2e45</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T09:18:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14861: s4-rpc/dnsserver: Confirm sort behaviour in dcesrv_DnssrvEnumRecords
The sort behaviour for child records is not correct in Samba so
we add a flapping entry.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14138
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4333e41c2243781ae788db8ee7fa6897b0a7e334">4333e41c</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T09:18:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14861: s4-rpc_server: Remove special case for @ in dns_build_tree()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14138
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/defb23732515e3c638d0081f5e4043fbb35d303c">defb2373</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T09:18:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14861: s4-rpc/dnsserver: Avoid crash in ldb_qsort() via dcesrv_DnssrvEnumRecords)
dns_name_compare() had logic to put @ and the top record in the tree being
enumerated first, but if a domain had both then this would break the
older qsort() implementation in ldb_qsort() and cause a read of memory
before the base pointer.
By removing this special case (not required as the base pointer
is already seperatly located, no matter were it is in the
returned records) the crash is avoided.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14138
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aaf037dfb3454cea048489b23ad96c415096dddf">aaf037df</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T09:18:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14861: Test to demonstrate the bug
This test does not fail every time, but when it does it casues a segfault which
takes out the rpc_server master process, as this hosts the dnsserver pipe..
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14138
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aa17d5fcaf7fe0f628856cda902cbd8be7e6ecb4">aa17d5fc</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T09:18:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: add user-sensitive command to set not-delegated flag
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/df72956adee55fbe60d49bd9d58d9df53d4f2198">df72956a</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T09:18:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14870: heimdal: add S4U test for delegation_not_allowed
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/84de46f5347288a3683ba083f529137efa8028e9">84de46f5</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T09:18:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14870: heimdal: enforce delegation_not_allowed in S4U2Self
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/73f436260620a97e307110ec45311e9e5dd321ce">73f43626</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2019-12-10T10:44:01+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14870: mit-kdc: enforce delegation_not_allowed flag
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Tue Dec 10 10:44:01 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/238d08b07d0178940c28839518c9f1afbc605378">238d08b0</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T16:22:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Confirm that ndrdump struct mode is not available for enums
These are not passed by pointer so the structure dump system does not work
for these. It is best to dump the containing structure instead.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bc0c876a9ebbec1a31856a9e7147a481c69ba434">bc0c876a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-10T17:45:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl:NDR/Parser: only include structs in ndr_interface_public_struct
We only have ndrdump and the fuzzers set up for structures, not BITMAPS,
ENUMS etc.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Dec 10 17:45:46 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c3250ff7ab66fb45c9b5a66c7e3a9453fb22777b">c3250ff7</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-10T19:06:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:crypto: Remove our implementation of AES CCM
We require GnuTLS >= 3.4.7 which provides AES CCM.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/337c51c9f503adef58c9b875bfb4f522cfb7d9ae">337c51c9</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-10T19:06:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:crypto: Remove our implementation of AES GCM
We require GnuTLS >= 3.4.7 which provides AES GCM.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6713617724bfe4cba633f0e61052a703c4ca9f3e">67136177</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-10T19:06:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:crypto: Only build AES code if we need AES CMAC
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/20b9cae63d5a5881cc6100a2533fab683cc307aa">20b9cae6</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-10T20:30:57+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:crypto: Build intel aes-ni only if GnuTLS doesn't provide AES CMAC
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Dec 10 20:30:57 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/79b2ee8dc2382354750601ee3d57912442c09817">79b2ee8d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-10T20:31:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture4: Use generate_random_u64() instead of random()
random() returns an int, which is not necessarily a uint64
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7535359602e8b33e38ef1e0e38dc070773a39ea8">75353596</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-10T20:31:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Run durable_v2_reconnect_delay_msec with leases
This will show a leases.tdb record leak. If you SIGSTOP the smbtorture
process while it's in the 10-second wait, you will find locking.tdb
and share_entries.tdb empty after the scavenger has cleaned up. But
there will be an entry in leases.tdb left.
I have no clue how to test this properly, or how to have a reasonably
cheap assert in smbd during normal operations. The problem is that
this leak can't really be distinguished from a "normal" leak that a
crashed smbd would leave behind. Possibly we need a background job
walking leases.tdb to clean this up properly.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fbd97ee822337534006ffcd14e08c8068e178266">fbd97ee8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-10T21:57:05+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix a leases.tdb record leak
If we set e->stale=true in the share_mode_forall_entries() callback,
the share entry will be removed directly. Thus further down
share_mode_forall_leases() won't find anything anymore. Only find
possibly still connected entries in the first walk, and then remove
the share_entries.tdb record straight away after the leases and
brlocks have been removed.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Dec 10 21:57:05 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/de02a553999903058dd69ea8aaff2e248a6ad55c">de02a553</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-11T02:55:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">.gitlab-ci.yml: Align tasks with "pages" dependency to get comprehensive code coverage
These two lists can get out of skew very easily.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/df38d511045311b9b7c68c94aad800c69088e331">df38d511</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-11T02:55:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild.py: Add missing samba-simpleserver job
This was missed when the job was split out in f0e8dd1a08698884209873bb84002d7b34db016c.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d349d344f8872e25526fdb76a38523477baa4366">d349d344</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-11T02:55:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild.py: Avoid listing jobs twice
We use the tasks table instead, to avoid the issue shown in the previous commit.
Now we just have to keep .gitlab-ci.yml and the tasks table in sync.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0be0c044b6769da39b0feb8d7b655a2760413086">0be0c044</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-11T02:55:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">autobuild: extend autobuild with samba-fuzz job to build the fuzzers in AFL mode using oss-fuzz scripts
This helps ensure the build_samba.sh file keeps working and the fuzzers build
(because they are excluded from the main build).
This is not in the default autobuild because it uses too much
space on sn-devel (4GB).
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6e5aefc2d3095f0fb6535e6ab3a4ec12b898794f">6e5aefc2</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-11T02:55:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing: Ensure mem_ctx is freed each time fuzz_ldb_parse_tree is run
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e6fc8e79aee289f79b5fba7b7c2974d476702b1e">e6fc8e79</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-11T02:55:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing: Split up automatically build fuzzers into TYPE_{IN,OUT,STRUCT}
The advise is that a fuzz target should be as small as possible
so we split this up. Splitting up by function would build too
many fuzzers, but this should help a little.
See for example:
https://github.com/google/fuzzing/blob/master/docs/good-fuzz-target.md#large-apis
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/545711ffeaaa12689a4e9a14f23ba5a4afef2180">545711ff</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-11T04:21:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing: Fix argument order to ldb_filter_from_tree in fuzz_ldb_parse_tree
Found by the oss-fuzz CI tooling.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Dec 11 04:21:28 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/049f0c3870179aa4977f5d9c49e18566f166412e">049f0c38</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-11T22:18:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/krb5_wrap: Remove unused smb_krb5_get_allowed_weak_crypto()
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
Autobuild-User(master): Isaac Boukris <iboukris@samba.org>
Autobuild-Date(master): Wed Dec 11 22:18:47 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ee4617ec5f4017e7ee3bbc29102054e7b64f3e3a">ee4617ec</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-12-12T00:35:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc dnsp test: Ensure length matches union selector
Ensure that a dnsp_DnsProperty is rejected if the length data does not not
correspond to the length indicated by the union id. It was possible for
the union to be referencing memory past the end of the structure.
Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X fuzzer.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14206
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fee5c6a4247aeac71318186bbff7708d25de5912">fee5c6a4</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T00:35:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc/idl/dnsserver.idl: Ensure DnsProperty id matches what is pulled from the stored buffer
There are two concerns here, assuming the attacker can place arbitary values
in a dnsProperty attribute over LDAP (eg is a DNS administrator).
This comes from the fact that id is used as the switch value at the C layer
but at the NDR layer the wDataLength value is considered first.
One concern is that a pull/push round-trip could include server memory:
The previous switch_is() behaviour could store the server memory back
into the attribute.
However this pattern of pull/push only happens in ndrdump and fuzzing tools, as
dnsserver_db_do_reset_dword() operates only on the uint32/bitmap union
arms, and fully initialises those.
The other is that a pull of the attacker-supplied value could
cause the server to expose memory.
This would be over the network via DNS or the RPC dnsserver protocols.
However at all times the ndr_pull_struct_blob is passed zeroed memory.
The final concern (which fuzz_ndr_X found) is that in the ndr_size_dnsPropertyData()
the union descriminent is only id.
This has no impact as only zeroed memory is used so there will be a
zero value in all scalars, including data->d_ns_servers.AddrArray.
Therefore the server will not crash processing the attacker-supplied blob
[MS-DNSP] 2.3.2.1 dnsProperty has no mention of this special behaviour.
https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-dnsp/445c7843-e4a1-4222-8c0f-630c230a4c80
This was known as CVE-2019-14908 before being triaged back to a normal bug.
Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X fuzzer.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14206
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/39dfc5c82b2345f2eee7d14f6f2cc3ee8b2aef3d">39dfc5c8</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-12-12T00:35:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc:core: Split dcesrv context init and endpoint servers init
The S4 server will initialize the endpoint servers specified in smb.conf,
but the S3 server need to initialize all registered endpoint servers (the
embedded ones).
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/90eb485cf9d8eaecfab31044e52e8f41b3a51452">90eb485c</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-12-12T00:35:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc:core: Add public functions to initialize endpoint servers
The dcesrv_init_registered_ep_servers() will be used by the S3 server to
initialize all registered endpoint servers (for embedded services), and
the dcesrv_init_ep_server() function will be used by the external
daemons to initialize the required ones.
As serveral S3 services may require to initialize another one before
itself (svcctl and eventlog for example require winreg) a boolean flag is
added to track the initialization status.
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/79af978c815e6ad94797742c8755f4fe8142160e">79af978c</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-12-12T00:35:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc:core: Add a function to reinitialize the dcesrv_context
Clears all registered endpoints and interfaces, association groups and
broken connections.
To be used by S3 forked daemons.
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e24ce0023fa00a33d22f5f475e9280a8cad612c3">e24ce002</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-12-12T00:35:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl:NDR/Server: Allow to define endpoint server shutdown functions
The next commits will register legacy api_struct when the endpoint server
is initialized. This commit adds a shutdown function which will be used
to unregister the legacy api_struct.
The shutdown function will be also used to replace the rpc_srv_callbacks
struct shutdown member used, for example, by the spoolss service to
cleanup before exiting.
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4a608b281cf945b0550d1bf81971f690a5e7ed8a">4a608b28</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-12-12T00:35:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture/rpc: Fix torture comment in mdssvc.c
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3f69c6b1328cda318f78620d19616411705b7034">3f69c6b1</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2019-12-12T02:00:19+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Do not force the endpoint for fsrvp tests
The test suite will bind to the srvsvc interface, let it find the
correct endpoint through the endpoint mapper.
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Dec 12 02:00:19 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cf83eec565f2879c06874cdd390ab3a043c132f8">cf83eec5</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add test for structure with NDR_BUFFERS only in a union
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6ef50145494125c8e67c034ddb1816a567524984">6ef50145</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add example xattr_NTACL packets to demonstrate switch/union behaviour
This is a good example with both buffers and scalars in the union.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f56fa3bb6a0e2275114a6f4dd27640af1e15018b">f56fa3bb</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add test for ndr_size_union() faulting on a NULL pointer
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bcffdc9a895c8aa572819ddd4fca451038990402">bcffdc9a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add test for ndr_size_struct() faulting on a NULL pointer
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4501663f6e523a988f4edd287a1374cab3c9a127">4501663f</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libndr: Do not overwrite token list with NULL on allocation failure
This was one part of the minimum patch for CVE-2019-14908 before
being downgraded as not a security-release worthy issue.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7a0ed44b0e65e742a778915d493e17f04c43b2ef">7a0ed44b</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndr: Restrict size of ndr_token lists to avoid memory abuse by malicious clients
This is designed to stop a very large number of tokens from being stored for
arrays of structures containing relative pointers in particular.
This was one part of the minimum patch for CVE-2019-14908 before
being downgraded as not a security-release worthy issue.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ae43093b79ad59a090e72c22249a65b54a2a6a97">ae43093b</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-libcli/rap: Set the switch_value before NDR_BUFFERS to prepare for new libndr behaviour
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a22a22e4a8a2efad86833d21958bc6abf57f74e7">a22a22e4</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">negoex: Set the switch_value before NDR_BUFFERS to prepare for new libndr behaviour
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f7bcf227f7bac1817ecabbe3dccaebdd9a81a2f9">f7bcf227</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Set the switch_value before NDR_BUFFERS to prepare for new libndr behaviour
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/603f23b19c90d6a1be4ac50e5984e6f9c8a63ba2">603f23b1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: Generate and consume the switch level token for both NDR_SCALARS and NDR_BUFFERS in ndr_pull()
This means what was previously a list becomes a single variable that
could be passed as a function paraemter, but this is avoided for now
because it would change the ABI and be more intrusive.
Before this, a client could cause a NDR token containing the swith level
to be allocated for each and every element in the array that they
promised they were sending (without having to actually send them).
Found by Michael Hanselmann using Honggfuzz and an fuzzer for Samba's
NDR layer.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e1a15710a4c1c96c9d9fdf932357749cc5ed4d7a">e1a15710</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc/ndr: Add ndr_push_steal_switch_value()
This will allow generated code to instead push and pop union values onto the
switch_list stack, which is more memory efficient than creating a single large
list to be scannned and eventually discarded.
Merge into unreleased ABI 1.0.0
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e08461b2845183224b9775b54be4acaaba705ecd">e08461b2</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: Add and use ndr_print_steal_switch_value(), removing ndr_print_get_switch_value()
This avoids really long token lists for switch values
that will not be needed past this point.
The function name is changed to clarify what exactly is being
done here, and the old function is removed to ensure it is
not being used anywhere else.
Merge the removal of ndr_print_get_switch_value into
just-tagged librpc/ABI/ndr-1.0.0.sigs as this
has not been put into any release yet.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5eb560d25e9104dc02477a6bf819d0c37e8afb86">5eb560d2</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: Mismatch between set and get of relative base pointers
The set was within the switch, the get was before the switch.
The difference is shown when there is an empty default element.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/362d70ff2fb6fb6265fce03da6b09dd4756dc604">362d70ff</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Do not follow a NULL pointer when calculating the size of a structure
Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
fuzzer.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/456cdb7fa35f2b5778c7a5c852acc6180cbe03b4">456cdb7f</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl: Mismatch between set and get of relative base pointers
The set was within the switch, the get was before the switch.
The difference is shown when there is an empty default element.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/92a7c5a7262cb78fb6307e9168a540154cbe2f71">92a7c5a7</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Do not follow a NULL pointer when calculating the size of a union
Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
fuzzer.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b880bda589aa136bb954a757f25f8763b74aefd4">b880bda5</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Remove last callers of ndr_pull_get_switch_value()
By removing this we know we do not need to worry about this list
growing without bounds.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a44717394df9dc14a87eb2b9b8d23e2532e6f4c9">a4471739</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Remove last callers of ndr_push_get_switch_value()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d30c377d8c4e8a83b2722b771aa72d219eb69b46">d30c377d</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T02:30:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc/ndr: Remove ndr_{push,pull}_get_switch_value()
By removing this we know we do not need to worry about this list
growing without bounds. We merge this into the recently created but
not yet released ABI 1.0.0
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/82aff583b7f7e018ad4a1db92dc635df8e5ebe7b">82aff583</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-12T03:56:23+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libndr: Return enum ndr_err_code from ndr_{pull,push}_steal_switch_value()
This breaks the ABI so we merge this into the unreleased libndr-1.0.0.
The advantage of the new functions is there (except for print, which
is unchanged) is an error raised when the token is not found, so
we can be confident in the changes to the token behaviour.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Dec 12 03:56:23 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/48ed60d7fd0b567c2450020b8ccaa2c6ff8913e3">48ed60d7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-12T20:22:51+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/replace: work around an API conflict between ncurses and XFS xattr API
Compile error:
[4530/4693] Compiling source3/utils/regedit_list.c
In file included from ../../source3/utils/regedit_list.h:24,
from ../../source3/utils/regedit_list.c:20:
/usr/include/curses.h:611:28: error: conflicting types for ‘attr_get’
611 | extern NCURSES_EXPORT(int) attr_get (attr_t *, NCURSES_PAIRS_T *, void *); /* generated */
| ^~~~~~~~
compilation terminated due to -Wfatal-errors.
Both ncurses and XFS xattr API provide a get_attr() function. As a workaround
avoid including <sys|attr/attributes.h> if <attr|sys/xattr.h> is present.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Dec 12 20:22:51 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2048ff3adc4dbff659dfb5d747f0cb93baad06ee">2048ff3a</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-12-16T14:05:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: msdfs: Cleanup, don't mix int and size_t types for a count variable.
Add integer wrap check.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cc1ec0a9f135ec32c05ae04d0b3bd47fdef5d47d">cc1ec0a9</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-12-16T14:05:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: cleanup. Change 'int referral_count' -> 'size_t referral_count' in struct junction_map.
This is a non-negative count. Fix remaing code to not mix int and size_t.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/af2d54bfce8e389473cdb546155dc58d547011f9">af2d54bf</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2019-12-16T15:32:08+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: msdfs: Factor out the code to create a msdfs:referral,list into a separate function.
This will allow it to be called from other places once the get/set_msdfs
calls are moved into being first class VFS functions.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Mon Dec 16 15:32:08 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f42e089a6efa36adc0d835cb51a1a612b40fa1c9">f42e089a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-16T19:02:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Avoid casts in open_directory()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/810fd90a6fb3cd95f0025321d080aad04afa994d">810fd90a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-16T19:02:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fe7f241225db97d02a060118a342c824ab51e471">fe7f2412</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-16T19:02:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture4: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6abcc83366f5f3203e9454b444c7d0ada7fed41e">6abcc833</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-16T19:02:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Explicitly state when modifying share_mode_data
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1c188c3716a76a290e9e7f529ead782bea936690">1c188c37</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-16T19:02:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use explicit share_mode_wakeup_waiters()
We don't need to unparse the locking.tdb record, we just need to wake
up waiters when downgrading a lease
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/97ad50544aaecd07b4a8f39cd329ed484aa38d6e">97ad5054</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-16T20:27:59+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use explicit share_mode_wakeup_waiters()
We don't need to unparse the locking.tdb record, we just need to wake
up waiters when removing an oplock
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Dec 16 20:27:59 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5d34c8874d6732ffb95458b79b742664744ef605">5d34c887</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2019-12-17T07:58:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-rpc_server: always print the full PDU.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2241ce8e86f35f9bcfd4567aeb8e8a00cb53f7d7">2241ce8e</a></strong>
<div>
<span>by Simo Sorce</span>
<i>at 2019-12-17T09:24:56+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">mit-kdb: Fix license on header file
Signed-off-by: Simo Sorce <idra@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Dec 17 09:24:56 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fca2d3e0d1fa5af59e7b729f7c1d126f7b81e149">fca2d3e0</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2019-12-17T21:53:07+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: glusterfs: Reset nlinks for symlink entries during readdir
On receiving an already initialized stat_ex buffer for readdir() call we
invoke readdirplus() GlusterFS API, an optimized variant of readdir(),
which then returns stat information along with dir entry result. But for
symlink entries we don't know if link or target info is needed. In that
case it is better to leave this decision back to caller by resetting
nlinks value inside stat information to make it invalid.
This was also preventing us from displaying msdfs link as directories
inside the share.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14182
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Dec 17 21:53:07 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/54293f92cd83efc3a5a78fc29a85643921da9d32">54293f92</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2019-12-17T22:40:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_ceph_snapshots: fix root relative path handling
For file paths relative to root, ceph_snap_get_parent_path() may return
an empty parent dir string, in which case the CephFS snashot path should
be ".snap".
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14216
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/28d9c418605356db65e90b1386d890308f3ab41f">28d9c418</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-17T22:40:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Add share_mode_count_entries()
In order to not write the share mode on every open/close, we need to get rid of
share_mode_data->num_share_modes. "net tdb" needs this information precisely
though, and it's pretty cheap to calculate.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3e5f1be8eace95cffa9d7e4cfd55eedca9ce2ceb">3e5f1be8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-17T22:40:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net: Use share_mode_count_entries()
Avoid a reference to share_mode_data->num_share_modes
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/21eff9d18d23ddc232a566eca51a6f32e30f0c11">21eff9d1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-17T22:40:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Pass num_share_modes to share_mode_entry_do() callback
mark_share_mode_disconnected_fn() will need this, the information is
easily available and should not hurt the other callers.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5a2fa45741db6d157705f81a8830907e34f07120">5a2fa457</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-17T22:40:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Avoid a reference to share_mode_data->num_share_modes
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0df06f51ffbc200b0525e175e7ac58795fd93bab">0df06f51</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-17T22:40:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Avoid a reference to share_mode_data->num_share_modes
share_mode_data->num_share_modes will go away soon, count the values
directly while walking the array.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/15977f5df85980ff0adbb372e4a4f0d51dde39dc">15977f5d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-17T22:40:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Introduce share_mode_have_entries()
This hides a use of share_mode_data->num_share_modes in
share_mode_lock.c
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/42ce74994e98dda95c32d3fcbd66d825f6d84519">42ce7499</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-17T22:40:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Avoid a direct access to share_mode_data->num_share_modes
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9734bad37b8bc4b2815f2bff4c0f48d33fb76c4d">9734bad3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-17T22:40:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Use share_mode_data->num_share_modes as a boolean
This is a micro-commit showing that we don't actually need
share_mode_data->num_share_modes as a number *counting* the share mode
entries in share_entries.tdb anymore. Instead, we are only using it as
an indication for share_mode_lock_destructor() to see whether share
entries are around or not, i.e. whether it's worth keeping or deleting
the record in locking.tdb.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4a60e577db51b0ee5b450d643872463d6939ccee">4a60e577</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-17T22:40:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Don't store "num_share_modes" in locking.tdb
With the last commit we don't store the share mode entry count
anymore. With this commit we go one step further and avoid storing
it. If there's valid record in locking.tdb, there is a corresponding
record in share_entries.tdb, so there's no point storing that once
more explicitly.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1141fbe9842c57fca7ee1175665638a0c1f5a181">1141fbe9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-18T00:05:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Convert share_mode_data->num_share_modes into a boolean8
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Dec 18 00:05:13 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/66d12eb98aba10948f829d08b4144969ead5ddbb">66d12eb9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-18T06:39:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing: Initialise st buffer in fuzz_ndr_X
An NDR pull of a function will fill in either the in. or out.
elements of this structure, but never both.
However, some structures have size_is() in the out. that reference
the in. elements. This is the reason for the --context-file option
in ndrdump.
We have a special handler in the fuzzing case embedded in the
pidl-generated output to cope with this, by filling in pointers
for elements declared [ref,in] but it relies on the in-side
(at least) of the buffer being zeroed.
So zero the buffer before we start. Sadly this means things
like valgrind can not find a use of uninitialised data, but that
is a price we have to pay.
Credit to OSS-Fuzz
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5a989d6670911e16aed9061a8c6a74676f4c8a8e">5a989d66</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-18T06:39:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing: Allow load of fuzz inputs as files on the command line
This is easier to put under gdb.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5ccb5e23c96a6555e03fac66a382780df56bcfe6">5ccb5e23</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-18T06:39:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">sefltest: Demonstrate crash in manually written printer for drsuapi_DsAttributeValue
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0e651b4508d44e4343c83e1c157d919150aee489">0e651b45</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-18T06:39:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Fix manually written printer for drsuapi_DsAttributeValue
Credit to OSS-Fuzz
Found using the ndr_fuzz_X target.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4d9753dfbd8a2d66d86f60aabee627826247aa38">4d9753df</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-12-18T06:39:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: fix use after free
Fix ASAN detected use after free. No security implications as the
talloc_free is followed immediately by the print statement and the value
printed is an integer
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bbc4ebbcaf3e602cf11816a24e58f4dc3eed7d8d">bbc4ebbc</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-18T06:39:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzer: Allow coverage build for oss-fuzz
This still does not seem to be enough but it is one step towards a working
coverage build.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5eac5813cc42ab4f17858e61cc512bace4d3bad2">5eac5813</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-18T06:39:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/fuzzing and librpc: Do not generate fuzzers for pointless targets
We need to focus the fuzzing effort on reachable code, and these IDL
are just historical artifacts, many are entirely [todo] and have
no samba client nor server.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ad9a81c6a933558e8ae5ccbdcb329e9effc82bb0">ad9a81c6</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-18T08:05:05+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Move winstation.idl to the top level and exclude from fuzzing
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Dec 18 08:05:05 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f8f3b33ea58a03dc3c17b03256530b6990ce9191">f8f3b33e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-18T10:13:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/replace: prefer <sys/xattr.h> over <attr/xattr.h>
This prevents the following compile error that may happens if "system/filesys.h"
is included before "system/capability.h" on Ubuntu 16.04:
[1802/4407] Compiling source3/lib/system.c
In file included from ../../lib/replace/system/filesys.h:112:0,
from ../../source3/include/vfs.h:29,
from ../../source3/include/smb.h:150,
from ../../source3/include/includes.h:284,
from ../../source3/lib/system.c:23:
/usr/include/x86_64-linux-gnu/sys/xattr.h:32:3: error: expected identifier before numeric constant
XATTR_CREATE = 1, /* set value, fail if attr already exists. */
^
The above error is from compiling a source tree which includes a change that
adds an include "system/filesys.h" to the top of "source3/include/vfs.h".
"source3/lib/system.c" has the following includes:
#include "includes.h"
#include "system/syslog.h"
#include "system/capability.h"
#include "system/passwd.h"
#include "system/filesys.h"
#include "../lib/util/setid.h"
The first include of "includes.h" pulls in "vfs.h" which will pull in
"system/filesys.h" with the mentioned change. "system/filesys.h" pulls in
<attr/xattr.h> which has this define
#define XATTR_CREATE 0x1
Later in "source3/lib/system.c" "system/capability.h" is included which includes
<sys/xattr.h> on Ubuntu 16.04 (not in later versions of glibc). This defines the
XATTR_* values as an enum:
enum {
XATTR_CREATE = 1, /* set value, fail if attr already exists. */
XATTR_REPLACE = 2 /* set value, fail if attr does not exist. */
};
The previous define of XATTR_CREATE as 1 makes this
enum {
1 = 1, /* set value, fail if attr already exists. */
2 = 2 /* set value, fail if attr does not exist. */
};
which is invalid C. The compiler error diagnostic is a bit confusing, as it
prints the original enum from the include file.
See also:
<https://bugs.freedesktop.org/show_bug.cgi?id=78741>
<https://bugs.launchpad.net/ubuntu/+source/attr/+bug/1288091>
<https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756097>
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Björn Baumbach <bb@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5fd65edc91b0f56e044428a32676b079aec9377d">5fd65edc</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2019-12-18T11:37:53+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba_kcc: avoid ValueError when local connections are less than 2
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Björn Baumbach <bb@sernet.de>
Autobuild-Date(master): Wed Dec 18 11:37:53 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f0eb1e623f76d3dbd0c22f96cabebd1041c147df">f0eb1e62</a></strong>
<div>
<span>by Torsten Fohrer</span>
<i>at 2019-12-18T14:33:58+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Avoiding bad call flags with python 3.8, using METH_NOARGS instead of zero.
(C) SBE network solutions GmbH
Signed-off-by: Torsten Fohrer <torsten.fohrer@sbe.de>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Dec 18 14:33:58 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f8799bf076d647d73aa749f3864d022a366c3904">f8799bf0</a></strong>
<div>
<span>by Fabrice Fontaine</span>
<i>at 2019-12-18T15:32:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/ldb/tests: include stdint.h before cmocka.h
This fix the following build failures:
[2466/3864] Linking bin/default/lib/ldb/ldbmodify
In file included from /home/buildroot/autobuild/instance-0/output-1/host/opt/ext-toolchain/lib/gcc/mips64el-buildroot-linux-uclibc/5.5.0/include/stdint.h:9:0,
from ../../lib/tevent/tevent.h:31,
from ../../lib/ldb/include/ldb.h:51,
from ../../lib/ldb/tests/test_ldb_dn.c:25:
/home/buildroot/autobuild/instance-0/output-1/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/stdint.h:122:27: error: conflicting types for 'uintptr_t'
typedef unsigned long int uintptr_t;
^
In file included from ../../lib/ldb/tests/test_ldb_dn.c:23:0:
/home/buildroot/autobuild/instance-0/output-1/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/cmocka.h:132:28: note: previous declaration of 'uintptr_t' was here
typedef unsigned int uintptr_t;
^
In file included from /home/buildroot/autobuild/instance-0/output-1/host/opt/ext-toolchain/lib/gcc/mips64el-buildroot-linux-uclibc/5.5.0/include/stdint.h:9:0,
from ../../lib/tevent/tevent.h:31,
from ../../lib/ldb/tests/ldb_key_value_test.c:48:
/home/buildroot/autobuild/instance-0/output-1/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/stdint.h:122:27: error: conflicting types for 'uintptr_t'
typedef unsigned long int uintptr_t;
^
In file included from ../../lib/ldb/tests/ldb_key_value_test.c:43:0:
/home/buildroot/autobuild/instance-0/output-1/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/cmocka.h:132:28: note: previous declaration of 'uintptr_t' was here
typedef unsigned int uintptr_t;
^
Fixes:
- http://autobuild.buildroot.org/results/9507739b3d5d51024ee9c60b74c2f85d5004e7e2
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14218
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Reviewed-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1bfb384018deb2ee5c27dbea9fa2cdd98901fdcc">1bfb3840</a></strong>
<div>
<span>by Fabrice Fontaine</span>
<i>at 2019-12-18T16:57:52+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">source4/utils/oLschema2ldif: include stdint.h before cmocka.h
This fix the following build failure:
In file included from /home/fabrice/buildroot/output/host/opt/ext-toolchain/lib/gcc/mips64el-buildroot-linux-uclibc/5.5.0/include/stdint.h:9:0,
from /home/fabrice/buildroot/output/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/inttypes.h:27,
from ../../lib/replace/../replace/replace.h:64,
from ../../source4/include/includes.h:23,
from ../../source4/utils/oLschema2ldif/test.c:25:
/home/fabrice/buildroot/output/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/stdint.h:122:27: error: conflicting types for ‘uintptr_t’
typedef unsigned long int uintptr_t;
^
In file included from ../../source4/utils/oLschema2ldif/test.c:23:0:
/home/fabrice/buildroot/output/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/cmocka.h:132:28: note: previous declaration of ‘uintptr_t’ was here
typedef unsigned int uintptr_t;
Fixes:
- http://autobuild.buildroot.org/results/9507739b3d5d51024ee9c60b74c2f85d5004e7e2
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14218
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Reviewed-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Dec 18 16:57:52 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dd694bdc643ad294475ddf2dd42b537ffeb7e8dc">dd694bdc</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-19T14:20:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:script: Try to fix a Perl warning
Scalar value @ENV{"BASH_ENV"} better written as $ENV{"BASH_ENV"} at
/tmp/samba-testbase/b23/samba-ad-dc-1/source3/script/tests/printing/modprinter.pl
line 134.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ea51a426e506bd6456814ecddcb63441859f9d89">ea51a426</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-19T14:20:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: Generate the inode only based on the path component
Currently we use the full smb url which includes also username and
password.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14101
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bf9a3a7aa1913238ae2c997ce00369d0dbae3a08">bf9a3a7a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-19T14:20:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: Add try_posixinfo to SMBSRV struct. Only enable for SMB1 with UNIX for now.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14101
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0fe9dc5219beaf605da9c7922053f7324507b50e">0fe9dc52</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-19T14:20:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: Return a 'struct stat' buffer for SMBC_getatr()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14101
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b3e3cb3bbd86a53b48ee009adf811d48dd50dc8b">b3e3cb3b</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-19T14:20:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: Add a setup_stat_from_stat_ex() function
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14101
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8b04590e4d8f817ad6d194bb9d622c18734e3011">8b04590e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-19T15:44:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmbclient: If over SMB1 first try to do a posix stat on the file.
Disable in future, if server doesn't support this.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14101
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Dec 19 15:44:25 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c20179a4f86bbaad75b0f87376257080760c650b">c20179a4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T06:08:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: use ad_dc_ntvfs env instead of ad_dc_default for samba4.ldb.ldaps
ad_dc_default is currently an alias for ad_dc_ntvfs, so this is currently no
change in behaviour, but this is going to change.
As the ad_dc_ntvfs env specifies "ldap server require strong auth =
allow_sasl_over_tls" and this is needed for the test, we have to let the test
use the ad_dc_ntvfs env explicitly.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2d2809be7b17afd0a6054e93c9e5491a31356a1d">2d2809be</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T06:08:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: make testenv name logic more flexible for the rpc testcases
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9174968b01565a13b046a14a46e9cb77ea4cb5c2">9174968b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T06:08:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: hardcode ad_dc_ntvfs for the rpc.netlogon testsuite
The rpc.netlogon testsuite has a test that verifies LSA over netlogon which is
only enabled in the ad_dc_ntvfs env.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7974e55024f9d0479a375ffc990293941ff90303">7974e550</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T06:08:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: run rpc.srvsvc and rpc.mgmt against ad_dc_ntvfs explicitly
No change in behaviour.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/88a381389c370b697d194c1217d1609bea854c23">88a38138</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T06:08:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: run samba.tests.dcerpc.srvsvc against ad_dc_ntvfs explicitly
No change in behaviour.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0f5b66230d08f27af0ae6f53038271462053ab25">0f5b6623</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T06:08:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: run samba4.ldap.dirsync.python against ad_dc_ntvfs explicitly
No change in behaviour.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f3f22851ff12014452202c1eba4d96ac8db33645">f3f22851</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T06:08:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: run samba.ldap.referrals against ad_dc_ntvfs explicitly
No change in behaviour.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ac115db1fcaae7913dd1e62a5558272e235264e6">ac115db1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T06:08:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: run samba.tests.samba_tool.user against ad_dc_ntvfs:local explicitly
No change in behaviour.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8d1206c92094fce98d42d379bcd07275a51fd50c">8d1206c9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T06:08:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: make ad_dc_default an alias for ad_dc, not ad_dc_ntvfs
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bba0cafa951eee2cbe3a0e87e486c600a24818db">bba0cafa</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T06:08:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: make ad_dc_slowtests an alias for ad_dc, not ad_dc_ntvfs
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/01141d06af858cefdd9a98364122a923cbd312b3">01141d06</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T06:08:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: make fl2008dc an alias for ad_dc, not ad_dc_ntvfs
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/db24892d0e1f5b87dc1b4fb297fde07c919f1dfb">db24892d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T06:08:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: don't use NTVFS fileserver in promoted_dc
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fbcf1ab7087e6d80aa1336aa0cad5c6e7fec62ee">fbcf1ab7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T06:08:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: don't use NTVFS fileserver in vampire_dc
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bd141ead0dd238834aa13f0801463de8563f1dde">bd141ead</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T06:08:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: don't use NTVFS fileserver in fl2000dc
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3518151cb2474ff9000b87e9f08d13290adfadae">3518151c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T06:08:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: don't use NTVFS fileserver in fl2003dc
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/629254ec5b0d60a342f071aa1e67c22822d940a4">629254ec</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T06:08:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: don't use NTVFS fileserver in fl2008r2dc
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2e5188f520d0d452c7ac211ef7cf2791a320ec1f">2e5188f5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T06:08:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: don't use NTVFS fileserver in rodc
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1cf2397226d1ba6d0ff91c58da77b989e30b0420">1cf23972</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T07:34:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: don't use NTVFS fileserver in chgdcpass
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Dec 20 07:34:42 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f0cebbe4dd0317e2abfcbe252977383e6f37f3bd">f0cebbe4</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-12-20T07:35:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test upgradedns: ensure lmdb lock files linked
Add tests to check that the '-lock' files for the dns partitions as well as
the data files are linked when running
samba_dnsupgrade --dns-backend=BIND9_DLZ
failure to create these links can cause corruption of the corresponding
data file.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14199
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0bd479140c18ab79479ced4f25f366744c3afe18">0bd47914</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2019-12-20T07:35:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">upgradedns: ensure lmdb lock files linked
Ensure that the '-lock' files for the dns partitions as well as the data
files are linked when running
samba_dnsupgrade --dns-backend=BIND9_DLZ
failure to create these links can cause corruption of the corresponding
data file.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14199
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f11e207e01c52566c47e350ff240fe95392de0c3">f11e207e</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-20T07:35:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Fix string length checking in ndr_pull_charset_to_null()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14219
Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b28d1dca86d33efac9d03b35c5c9804e02ddfb9a">b28d1dca</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2019-12-20T09:01:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Add test for ndr_string_length()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Dec 20 09:01:30 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/30cbc5b90e4951a0ea924c204ff73e15c9750ace">30cbc5b9</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-20T10:09:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-smbd: Also restart prefork children lost to SIGKILL (-9)
Samba 4.10 and later versions have a process restart capability to greatly
reduce the impact of crashes due to a NULL pointer de-reference or abort().
However SIGKILL was deliberatly omitted.
Sadly this is the most likely case, due to the OOM killer, as raised here:
https://lists.samba.org/archive/samba-technical/2019-November/134529.html
Subsequent discussion (offline) has been to agree that we should restart in
this case.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14221
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/49197368d4dc6925ce7713d46d8adb93c51da433">49197368</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-20T10:09:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Celebrate the end of smbdes and the almost-end of in-tree AES
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/16557e4480a7502d45186854546d502479be156f">16557e44</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-20T10:09:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Confirm parse of dnsProperty records
This confirms a name of "." will round-trip correctly.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a85d257c1ec3a4505f2a4fcbec0f7e1f60dbff91">a85d257c</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2019-12-20T11:33:52+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: Do not access name[-1] trying to push "" into a dnsp_name
This simply matches the behaviour from before e7b1acaddf2ccc7de0301cc67f72187ab450e7b5
when the logic for a trailing . was added. This matches what is added in
the dnsRecord attribute for a name of "." over the dnsserver RPC
management interface and is based on what Windows does for that name
in (eg) an MX record.
No a security bug because we use talloc and so name will be just the
end of the talloc header.
Credit to OSS-Fuzz
Found using the fuzz_ndr_X fuzzer
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Dec 20 11:33:52 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8517bb109c886fcc0b281dd715934138075bab1b">8517bb10</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: pass session info to get_referred_path()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8a0ad072ac0e056ccd34f59f49c6391a50c17c74">8a0ad072</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: pass session_info to create_msdfs_link()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e12a724f0ddf0280b43cbd8107d34fe316585795">e12a724f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: pass session_info to remove_msdfs_link()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8d457a83dd126ac46f498c19a15089c2314625e1">8d457a83</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: pass session_info to junction_to_local_path_tos()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/457c91406aae65689db4df12dd236d2359d7eb88">457c9140</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: pass session_info to enum_msdfs_links()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d6a5aa6d0fdc6f6057a07e8421b71e40d0f845f9">d6a5aa6d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: pass session info to count_dfs_links()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/10fa50a8454f0d7a68f17b26e00e0787325f2dfe">10fa50a8</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: pass session_info to form_junctions()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0e57dbb8466f06c0992dd207acddc8fece47309c">0e57dbb8</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: pass session info to create_conn_struct_tos_cwd()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7fb188c119274a0e84b279ac13a0d696c4884c78">7fb188c1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: pass session_info to elog_check_access()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d68d8c6538287a8b6a4bbe4b43bf0621440592d8">d68d8c65</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:rpc_server: pass session_info to get_nt_acl_no_snum()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/459233b96238e319d8b37c471359bdeb4d26aadf">459233b9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: pass session_info to create_conn_struct_tos()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cfc0ca73374c8a0c418d6738753a10ab872688f6">cfc0ca73</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python: move system_session_unix to new auth_util.py
system_session_unix() will be used by many more callers soon.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9796ebcec4f98d81608e8e3d500745b1dc5f9101">9796ebce</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: reformat py_smbd_set_simple_acl() kwnames and PyArg_ParseTupleAndKeywords() call
No change in behaviour.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/399ebb56865202414cd2b5a8f1880d8c3e8a697a">399ebb56</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: reformat py_smbd_chown() kwnames and PyArg_ParseTupleAndKeywords() call
No change in behaviour.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b08c955ae92db8aae57f821c4080d225b6b01944">b08c955a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: reformat py_smbd_unlink() kwnames and PyArg_ParseTupleAndKeywords() call
No change in behaviour.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/59a6c9a4ce01ce1762be6cf0191db4df211d3b06">59a6c9a4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: reformat py_smbd_have_posix_acls() kwnames and PyArg_ParseTupleAndKeywords() call
No change in behaviour.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/33f33dc08e3ece38cf20924c0513f0857f8eb6d8">33f33dc0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: reformat py_smbd_get_nt_acl() kwnames
No change in behaviour.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/af1f6e9fd165223505c7c5ec59d94bbc3a41dc55">af1f6e9f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: reformat py_smbd_set_sys_acl() kwnames and PyArg_ParseTupleAndKeywords() call
No change in behaviour.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9ff378677afbe3298293779c9168769e15f2d021">9ff37867</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: reformat py_smbd_get_sys_acl() kwnames and PyArg_ParseTupleAndKeywords() call
No change in behaviour.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d80259d819ecdb149ec5d7b9f90eb44eca421320">d80259d8</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: reformat py_smbd_mkdir() kwnames
No change in behaviour.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/927c87d253c42282e8f62038363399f7643fcc76">927c87d2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: reformat py_smbd_create_file() kwnames
No change in behaviour.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9807d69ef4178d4a2c974fed5708ad2d487d0c19">9807d69e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/tests: use a system session_info in posixacl.py
Previously posixacl.py passed None as session_info object from
get_session_info().
That meant that the if/else branch referring to session_info:
if nwrap_winbind_active or session_info:
self.assertEquals(posix_acl.acl[1].a_perm, 7)
else:
self.assertEquals(posix_acl.acl[1].a_perm, 6)
must be tweaked to take into account that session info is now either
* a system session_info in which case we must continue to use the if branch in
the code, or
* a user session_info in which case we must continue to go through the else
branch
Using
is_user_session = not session_info.security_token.is_system()
in place of just "session_info" does the trick.
Cf the classes SessionedPosixAclMappingTests and
UnixSessionedPosixAclMappingTests in posixacl.py, those are the ones that
trigger test execution with a user session.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e6d40e6f9c022c5e571255cd4ff248d5a188b45f">e6d40e6f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: add "session_info" arg to py_smbd_set_simple_acl()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/da2a9857d0397d75ac45fc62440ad29bbd0388a1">da2a9857</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: add "session_info" arg to py_smbd_chown()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a4f3860da31a42c3905cdd8f7ff7103bf901394d">a4f3860d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: add "session_info" arg to py_smbd_unlink()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/437af4d07944f201c26cd0ebc4a5622e342d0f4c">437af4d0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: make "session_info" arg to py_smbd_set_nt_acl() mandatory
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9b2c415d2c614c8980fc800fa1cf967d69eb7975">9b2c415d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: make "session_info" arg to py_smbd_get_nt_acl() mandatory
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a9184a109902bc899920411b7a8893f934c2fd27">a9184a10</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: add "session_info" arg to py_smbd_set_sys_acl()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5cef3a13b880ee058f633e68a9b35996365b5c29">5cef3a13</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: add "session_info" arg to py_smbd_get_sys_acl()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7121d475794b951d9bee13d50e6be125f8cc7c2f">7121d475</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: add "session_info" arg to py_smbd_mkdir()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ee5bf29662ebb164e4be8811c2fcc9bfde88add3">ee5bf296</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pysmbd: add "session_info" arg tp py_smbd_create_file()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1fa05e5c76e718142326915f8671299217a093df">1fa05e5c</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: simplify create_conn_struct_as_root()
Now that all callers pass in a valid session_info, we can remove handling of
session_info=NULL. Add an assert(session_info != NULL) just in case... :)
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5db4a881f6ae74561d0ffd309992896f6681712d">5db4a881</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T11:41:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: remove unused macro FSP_BELONGS_CONN()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/670205acab186448e175433225bfebacf3500900">670205ac</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T13:06:20+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: remove unused session_keystr from struct user_struct
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Dec 20 13:06:20 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/946beafb621c6a5353a87c40264f53a253249c52">946beafb</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2019-12-20T22:01:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Convert samba4.base.*attr tests to smb2
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Ralph Böhme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/33212832b0e61b3c5176b819c34957adeaf6fe5e">33212832</a></strong>
<div>
<span>by David Mulder</span>
<i>at 2019-12-20T22:01:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Convert samba4.base.rw1 test to smb2
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Ralph Böhme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/31d5e945a44e5b8a59933b3516f4235e6057ceb7">31d5e945</a></strong>
<div>
<span>by awalker</span>
<i>at 2019-12-20T22:01:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_zfsacl: load parameters on connect
Convert zfsacl:denymissingspecial so that the parameter loads on connect.
Signed-off-by: Andrew Walker <awalker@ixsystems.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2c7699e7202bef6b8d40c829a4e1515a838f0f6d">2c7699e7</a></strong>
<div>
<span>by awalker</span>
<i>at 2019-12-20T22:01:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_zfsacl: add manpage entry for zfsacl:denymissingspecial
Signed-off-by: Andrew Walker <awalker@ixsystems.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cd313d0ade15556875ebec060b047a2c6e087b62">cd313d0a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T22:01:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_zfsacl: pass nfs4_params to smb_set_nt_acl_nfs4()
Now that we parse nfs4_params in the VFS connect in this module, we can pass it
to smb_set_nt_acl_nfs4() which avoids having smb_set_nt_acl_nfs4() parse
it *every time* it's called.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Walker <awalker@ixsystems.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/063fadd322e54ee12689485457ce15a1bb8c0769">063fadd3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2019-12-20T22:01:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_zfsacl: pass config to zfs_get_nt_acl_common()
Not used for now, that comes next.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Walker <awalker@ixsystems.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/30f9e1dd596a0dc4894f17b07a7e2e58dcb75c16">30f9e1dd</a></strong>
<div>
<span>by awalker</span>
<i>at 2019-12-20T23:24:54+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_zfsacl: fix issue with ACL inheritance in zfsacl
Add parameter zfsacl:map_dacl_protected to address issue preventing Windows Clients
from disabling inheritance on ACLs. FreeBSD does not currently expose the ACL_PROTECTED
NFS4.1 flag, but it does expose ACE4_INHERITED_ACE. When the parameter is enabled,
map the absence of ACE4_INHERITED_ACE to SEC_DESC_DACL_PROTECTED.
See also the discussion at
https://gitlab.com/samba-team/samba/merge_requests/719
Signed-off-by: Andrew Walker <awalker@ixsystems.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Dec 20 23:24:54 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bf592a1905984042aeb57ddef654229ffb2ee39b">bf592a19</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-22T17:29:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture3: Introduce "key" helper variable
Call string_term_tdb_data() once instead of three times
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bc00eaca703be97709d0706f746930b3a13bb44b">bc00eaca</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-22T17:29:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture3: Parametrize lock4_child()s locktype
We'll call it twice soon
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/12638d48a63e90d7d5568d00e39c7041f96675ae">12638d48</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-22T17:29:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture3: Add a test that contends with a READ, not a WRITE lock
This walks different code paths in the subsequent locker. And the one
that we did not test so far is in fact buggy
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/40ecc2f6f015b86b49326bff4b1cbcab8263f1ac">40ecc2f6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2019-12-22T18:57:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Fix contending with a READ lock
When contending a WRITE with an existing READ, the contender puts
himself into the exclusive slot, waiting for the READers to go
away. If the async lock request is canceled before we got the lock, we
need to remove ourselves again. This is done in the destructor of the
g_lock_lock_state. In the successful case, the destructor needs to go
away.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sun Dec 22 18:57:17 UTC 2019 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/df5040b186753acf72600042753d312bd5945429">df5040b1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-01-01T12:04:52+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Happy New Year 2020!
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Jan 1 12:04:52 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/693080abe4d8bec96280af5a6aa668251a98ec5d">693080ab</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-01-02T22:36:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-scripts: Strip square brackets when gathering connection info
ss added square brackets around IPv6 addresses in versions > 4.12.0
via commit aba9c23a6e1cb134840c998df14888dca469a485. CentOS 7 added
this feature somewhere mid-release. So, backward compatibility is
obviously needed.
As per the comment protocol/protocol_util.c should probably print and
parse such square brackets. However, for backward compatibility the
brackets would have to be stripped in both places in
update_tickles()... or added to the ss output when missing. Best to
leave this until we have a connection tracking daemon.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14227
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9edf15afc219a1a782ec1e4d29909361bbabc744">9edf15af</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-01-03T00:00:55+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Skip some tests that don't work with IPv6
See the comments added to the tests.
It may be possible to rewrite these so they do something sane for
IPv6... some other time.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14227
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Jan 3 00:00:55 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ba97f408d81e98863732a8c6bcb59de7a8fedd6b">ba97f408</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-03T00:04:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove an unused variable from security_token_debug()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/605bb4e9077aca1fa06c1c5beca42ca3b91308f7">605bb4e9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-03T00:04:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ntlm_auth: Fix a DEBUG message
This is not routine auth_generic_prepare
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f53c8fbd7ff2be62c1c488cd56507516d85c670d">f53c8fbd</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-03T00:04:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">audit_log: Align integer types
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fd406528b79a2fe4aefe0e04495cdaebe381e3d1">fd406528</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-03T00:04:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Align integer types
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5954a0688ae7fa992f8b5a19793b8662ca2794e1">5954a068</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-03T00:04:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lsasd: Align integer types
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ed3ee452549f5c25800dd7da1c6dc30a826fe28f">ed3ee452</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-03T00:04:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Avoid a "? True : False"
VALID_STAT() already is a boolean expression
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1d0ffcf30e625e7570daa800cf5adf3113c99ce5">1d0ffcf3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-03T01:30:24+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Remove an unused parameter from defer_open()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Fri Jan 3 01:30:24 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4d4443d1e539c1ce0f7245fbcffbf22df8355b2d">4d4443d1</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2020-01-03T20:55:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">loadparm: check for AD DC required VFS modules
When Samba is running as a domain controller and the "vfs objects"
parameter is not set, then the dfs_samba4 and acl_xattr modules are
automatically enabled.
However, if the "vfs objects" is defined, then the setting is left
as-is. This means that attempts to us other VFS modules have the side
effect of disabling the dfs_samba4 and acl_xattr modules, causing
unexpected behaviour, which is then blamed on the VFS modules that were
explicitly defined.
This change ensures that when running as a domain controller, Samba logs
an error if the required VFS modules are not enabled by an explicit
"vfs objects" definition.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10560
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/03b42aeb811ae7260a9a9e197212767877484a78">03b42aeb</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2020-01-03T22:19:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/loadparm: check for AD DC required VFS modules
same as the previous commit, just for python's testparm code
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10560
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): Björn Jacke <bjacke@samba.org>
Autobuild-Date(master): Fri Jan 3 22:19:47 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7283413a3faf4048a46e77c4ac5ed7a8bb804ff6">7283413a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-06T01:47:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b2f070349326bbdb69415524f0a9fa8d54c18049">b2f07034</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-06T01:47:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth3: Check for talloc failure
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bcf944445837e7cdd611dc89fe931575fa771017">bcf94444</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-06T01:47:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth3: Simplify auth_get_ntlm_challenge()
Use generate_random_buffer() directly on the talloc'ed buffer
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d034e839df0898d9db0dc00c1ccf2f113f1787f1">d034e839</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-06T01:47:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth3: Avoid a casts in auth3_check_password()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/33d4d482718fca10030b5a569f17cb1a2637fc8a">33d4d482</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-06T01:47:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbind: Fix CID 1456624 Uninitialized scalar variable
Coverity does not get that for (rc!=0) gnutls_error_to_ntstatus()
never returns NT_STATUS_OK
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/59cb155a27f21a55bdc588d38c8080cd29562a7e">59cb155a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-06T01:47:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Remove the "typedef auth_methods"
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8ec4e4b668d009f9c79ce324dce0d512e16d4cb9">8ec4e4b6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-06T01:47:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Check for talloc failure in smb_pwd_check_ntlmv2()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b78cc8210d3fe75af5236a16841060bbcc553cde">b78cc821</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-06T01:47:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Slightly simplify smb_pwd_check_ntlmv2()
Do an early return for the failure case
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2bd941cc12245728b374edc0f71f5938c887a566">2bd941cc</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-06T01:47:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Check for talloc failure in smb_pwd_check_ntlmv1()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4014d91b9a68aa2161421896a82d84e4211e480e">4014d91b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-06T01:47:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Slightly simplify smb_pwd_check_ntlmv1()
Do an early return for the failure case
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e02d24c0875eb04a53c19119148f5203374382e0">e02d24c0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-06T01:47:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Check for talloc failure in smb_sess_key_ntlmv2()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e4ad0013787a726bfc3d1ba3644b60a6c77ace37">e4ad0013</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-06T03:12:19+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Avoid casts in ntlm_check.c
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Mon Jan 6 03:12:20 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/004e553174623422e68055f727098b0a711eb1a2">004e5531</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2020-01-06T20:33:55+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd_pam.c: split winbindd_dual_pam_auth_samlogon
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Jan 6 20:33:55 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d3d2e6df9c17202c37e8f6beeb0da2738838181c">d3d2e6df</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-06T22:09:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth3: Replace auth3_check_password() by _send and _recv
This is just fake async, but it avoids one use of a sync function
pointer in auth4_context
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/066c4eeaa4fc36052eb30c3aeb6d0be4c82ae1ef">066c4eea</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-06T22:09:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ntlm_auth: Replace local_pw_check() by _send and _recv
This is just fake async, but it avoids one use of a sync function
pointer in auth4_context
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/add8fd21c08f1225191b0794a92206f5c9248d23">add8fd21</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-06T22:09:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ntlm_auth: Replace winbind_pw_check() by _send and _recv
This is just fake async, but it avoids one use of a sync function
pointer in auth4_context
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7f75dec865256049e99f7fcf46317cd2d53e95d1">7f75dec8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-06T23:34:00+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Simplify struct auth4_context
The fake async code has been pushed down into the 3 users, remove the sync
callback. Overall it's more lines of code, but the central interface is
simplified.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Jan 6 23:34:00 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ad8e6863c3791e50bc80418bc94f4970ed6b0e68">ad8e6863</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">system: Rename argument for kernel_flock function
MS-SMB2 and the smbd code refer to this field as share_access. Use the
same name in the function argument.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e8d9a21435ae4266093e355feda1c9bac6f9956e">e8d9a214</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs: Rename argument for kernel_flock function
MS-SMB2 and the smbd code refer to this field as share_access. Use the
same name in the function argument.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/974aae418f68e7dac1e9277d8b8df4b41f0cfa8c">974aae41</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_not_implemented: Rename argument for flock function
MS-SMB2 and the smbd code refer to this field as share_access. Use the
same name in the function argument.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/537d226ed93fdbccf236b7f79bb32802254a2356">537d226e</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_catia: Rename argument for flock function
MS-SMB2 and the smbd code refer to this field as share_access. Use the
same name in the function argument.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/83f59ac00e965a63b81873026e0e8d1c5a72f939">83f59ac0</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_ceph: Rename argument for flock function
MS-SMB2 and the smbd code refer to this field as share_access. Use the
same name in the function argument.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4667399457fee5b49c931c81cb963c6771f03a8d">46673994</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_full_audit: Rename argument of flock function
MS-SMB2 and the smbd code refer to this field as share_access. Use the
same name in the function argument.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0d5794f6f92dbfc2400b73ed3a0376a050b28b50">0d5794f6</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_glusterfs: Rename argument of flock function
MS-SMB2 and the smbd code refer to this field as share_access. Use the
same name in the function argument.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/86c2578a55507804f7ccd7d3a9656ceaa90fb302">86c2578a</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Rename argument of flock function
MS-SMB2 and the smbd code refer to this field as share_access. Use the
same name in the function argument.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b306a7361e9d8e2f50f87e8904fc622da799864e">b306a736</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_streams_xattr: Rename argument of flock function
MS-SMB2 and the smbd code refer to this field as share_access. Use the
same name in the function argument.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/00fb46c7f2f678aa601e4def2b53702d6fabf2e5">00fb46c7</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_time_audit: Rename argument of flock function
MS-SMB2 and the smbd code refer to this field as share_access. Use the
same name in the function argument.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/208007b86c407e98a796dfae30affade05abe4f7">208007b8</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Remove check for open file in share mode function
The calling code already ensures that the file is open with a valid file
descriptor.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/05c54b72c5ad3c8bce18f9a38413032e5224e644">05c54b72</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Move mapping from access mask to sharemode allow to helper function
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/79a50e75b24e7c236f7a5422c7676d45bbe93365">79a50e75</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Move mapping to sharemode deny to helper function
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eff66787c646e6ce6375929f7d61e9f1b5a0e202">eff66787</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Cleanup clearing file system share mode
The VFS flock function is called with a zero access_mask to indicate
that the share mode should be cleared. Adjust the check to directly
check the access_mask and provide a better message to indicate this
case.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5d5763ea8ce14f81107462e7f2dff09b6aec1fbc">5d5763ea</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Cleanup debug message file system share mode
Use the newer debug macro and the full variable names.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/56cf9b15f0a42323d94a407a4de7fae9b039a326">56cf9b15</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Remove unncessary check from close function
The fsp has a valid file descriptor when this function is called. No
need for the additional check.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d912895590170bdd8c720304c664a2259d6a9228">d9128955</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Add comment explaining why sharemode is dropped in close call.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c993480eeff7ff6aee7c4f90f103dcb8d1cd3c6f">c993480e</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Log error if clearing of sharemode fails on close
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ef52a907fe80fdb1cd199a21a68126a7bf9b33cb">ef52a907</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Only clear sharemode on close when sharemode has been taken
This avoids a redundant error message in case the call to acquire the
sharemode had failed before.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f03c4485a2e50d496875fb157d5405e2afa7a0f5">f03c4485</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Remove logging for unsupported file system
The gpfs_set_share API call has been around for a long time and
definitely all supported GPFS versions have it. Remove the check and
fallback for old versions without this API.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/03705f4c2fbac6534a925d7511749d4daa378b2e">03705f4c</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Switch share mode helper function to return int
Follow the convention to return 0 on success and -1 when hitting an
error.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a64978e0dc006b9b14541c60379d61e170355468">a64978e0</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Use early return in sharemode function
This removes one level of indentation.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/191e375d2071de5e44110155230da7e0c4b64d54">191e375d</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Explicitly log when share mode has been denied
As this denies access to a file, provide a better error message for
easier troubleshooting.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/47a2c6707b2f9a9c42673629b82640122c53a609">47a2c670</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Print message when share modes are disabled in file system
GPFS file systems can be configured without support for share modes. As
this results in an unique error code, print a message explaining this
situation and the required config changes.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5c20ef88ab07f52b7354668873c5d51b58748d12">5c20ef88</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T00:01:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Log failed gpfs_set_share call as error
Any other error code from gpfs_set_share should never happen. Print a
error message in case this is ever encountered.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4ff13c0174605e45d7d3b26fbb4226d9613b1c98">4ff13c01</a></strong>
<div>
<span>by Christof Schmitt</span>
<i>at 2020-01-08T01:26:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_gpfs: Update message for requesting sharemode on stream
User newer debug macro and print full path to affected file.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jan 8 01:26:46 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/55fbd4c05b477e95920b53b94eda2572e075e6e1">55fbd4c0</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2020-01-08T15:37:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml/winbindnssinfo: clarify interaction with idmap_ad etc.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14122
RN: docs: clarify interaction between winbind nss info and idmap backend
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Jan 8 15:37:46 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ba53e284e689987641f446fb71ddf1f31aee100b">ba53e284</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2020-01-08T23:24:58+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: lib: dbwrap: Set rec->value_valid to avoid backtrace in `smbstatus`
Following backtrace is observed on executing `smbstatus` with at least
one SMB client connection established:
PANIC: assert failed at ../../lib/dbwrap/dbwrap.c(82): rec->value_valid
PANIC (pid 350270): assert failed: rec->value_valid
BACKTRACE: 15 stack frames:
#0 /usr/local/lib/libsamba-util.so.0(log_stack_trace+0x1f)
[0x7fbbd9b32047]
#1 /usr/local/lib/libsmbconf.so.0(smb_panic_s3+0x74) [0x7fbbd9c1e6ff]
#2 /usr/local/lib/libsamba-util.so.0(smb_panic+0x28) [0x7fbbd9b32012]
#3 /usr/local/lib/samba/libdbwrap-
samba4.so(dbwrap_record_get_value+0x86) [0x7fbbd95800ac]
#4 /usr/local/lib/samba/libsmbd-base-samba4.so(+0x28f563)
[0x7fbbd999e563]
#5 /usr/local/lib/samba/libsamba-cluster-support-samba4.so(+0x7851)
[0x7fbbd92c7851]
#6 /usr/local/lib/samba/libsamba-cluster-support-
samba4.so(ctdbd_traverse+0x4ca) [0x7fbbd92cc641]
#7 /usr/local/lib/samba/libsamba-cluster-support-samba4.so(+0x73eb)
[0x7fbbd92c73eb]
#8 /usr/local/lib/samba/libsamba-cluster-support-samba4.so(+0x7a52)
[0x7fbbd92c7a52]
#9 /usr/local/lib/samba/libdbwrap-samba4.so(dbwrap_traverse_read+0x35)
[0x7fbbd9580de5]
#10 /usr/local/lib/samba/libsmbd-base-
samba4.so(smbXsrv_tcon_global_traverse+0xc5) [0x7fbbd999e7d9]
#11 smbstatus(connections_forall_read+0x114) [0x55d17872b8ee]
#12 smbstatus(main+0x7b2) [0x55d17872a2f3]
#13 /lib64/libc.so.6(__libc_start_main+0xf3) [0x7fbbd93a21a3]
#14 smbstatus(_start+0x2e) [0x55d17872894e]
Can not dump core: corepath not set up
Assertion on rec->value_valid fails as it is uninitialized in the
following functions:
traverse_read_callback
traverse_persistent_callback_read
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jan 8 23:24:58 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e17c8e1b405690d7d38443c8f18c489fc98c1011">e17c8e1b</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-08T23:51:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: fix IDL for spoolss_GetCorePrinterDrivers()
The charset determination makes it more difficult to deal with the real
REG_MULTI_SZ nature of that element.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8ceddba1f3b1aad4c2935e5a1207277f591cace8">8ceddba1</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-08T23:51:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-rpcclient: add cmd_spoolss_get_core_printer_drivers
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/479cf55397062cf38d16d08e4c48b2d1e26ceb99">479cf553</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-08T23:51:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: add IDL for spoolss_EnumPerMachineConnections
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a340aecdd025352bd0cefc1be1aac7526dfe1748">a340aecd</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-08T23:51:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-rpcclient: properly check and initialize buffers in getdriverpackagepath
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ce00972afc205af4f93cde5c3e30a07ec222670c">ce00972a</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-08T23:51:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-rpcclient: add enumpermachineconnections command
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d3c2833f1bb5622c438ec1c7b287e53fce83a6c2">d3c2833f</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-08T23:51:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-rpcclient: add addpermachineconnection command
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d642c9a2a8df3002c30d420f3cd34b447a711212">d642c9a2</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-08T23:51:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-rpcclient: add delpermachineconnection command
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0a76a7c3c258aa84fab96d03347f8e6e8d067fa8">0a76a7c3</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-08T23:51:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-torture: add test for spoolss AddPerMachineConnection
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/210a8f35b66326263e8466a5b58dffa6e0405c56">210a8f35</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-08T23:51:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-torture: add test for spoolss_EnumPerMachineConnections
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1038613878b7c40d4d313697cc0e4e527582afdb">10386138</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-08T23:51:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: better naming for NDR_SPOOLSS_{PUSH|PULL}_ENUM variants
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c9bebbcc464e98abeeb008551657532a1831a96f">c9bebbcc</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-08T23:51:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc/ndr: provide infrastructure for NDR_SPOOLSS_{PUSH|PULL}_ENUM macros
The new macros allow the same macro convenience for enum functions without
level discriminator.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c433dac59818d580bdccb0d0e0daac71ccf01ee2">c433dac5</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-08T23:51:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: pidlify spoolss_EnumPerMachineConnections
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/94157af26107fc12af5c10bedb4ca5af6eeed73e">94157af2</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-08T23:51:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-rpcclient: give slightly better descriptions to clusapi commands
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c9077f16283bdc04068ee669baa99baca8238532">c9077f16</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-08T23:51:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-rpcclient: add clusapi_pause_node command.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/17e692a9fa6b1475855aef5e425c4e4d6b1fd3bc">17e692a9</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-09T01:15:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-rpcclient: add clusapi_resume_node command.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jan 9 01:15:34 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1cd20731ab1e10d1b68b649c8588bbccb624c07e">1cd20731</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-09T18:55:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">printing: Align integer types
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d78b4a841e2ea7b279ae1f3039216723d24220d4">d78b4a84</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-09T18:55:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">printing: Avoid EBADF from EPOLL_CTL_DEL
TALLOC_FREE the fde before closing the fd. Otherwise the fde
destructor tries to remove a nonexisting fd from the epoll set.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/91f069cc16bedf7a89c488afed7c6b705aefb03c">91f069cc</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-09T18:55:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ntlm_auth: Add a NULL check
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4b95ea37cb3d080f22d5c748364dd3b233b76e50">4b95ea37</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-09T18:55:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ntlm_auth: Add type-safety instead of a simple cast
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/60b72f589e2a912682516f1d28c84cc713248a0a">60b72f58</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2020-01-09T20:20:05+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_ceph: assert renameat() fsps match cwd
As discussed with Jeremy in bug 14232, the vfs_ceph.renameat_fn
implementation currently ignores srcfsp and dstfsp. As a result,
relative smb_fname_src/smb_fname_dest paths will be processed as
relative to cwd.
This is currently a valid assumption, as srcfsp and dstfsp should
always match conn->cwd_fsp. Add an assert to clarify this.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jan 9 20:20:05 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/86a31defbf212d188281d5d963b12eedf1960e8b">86a31def</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-01-09T21:49:00+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ndr basic: Check ndr_token_store return code
Fix for
*** CID 1457529: Error handling issues (CHECKED_RETURN)
/librpc/ndr/ndr_basic.c: 786 in ndr_push_full_ptr()
...
ID 1457529: Error handling issues (CHECKED_RETURN)
Calling "ndr_token_store" without checking return value (as is done
elsewhere 14 out of 17 times).
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Thu Jan 9 21:49:00 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b0b9dd2f8693edc87840f04259e8f31fb55f601c">b0b9dd2f</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-01-10T19:38:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Add SMB_VFS_CREATE_DFS_PATHAT().
Not yet used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/421d26a890f0e09feb94d9b445a51fc14ca24615">421d26a8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-01-10T19:38:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Implement create_dfs_pathat() in ceph.
Not yet used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/235e59481d9ca8e1a522e966399266fde1feb708">235e5948</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-01-10T19:38:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Implement create_dfs_pathat() in gluster.
Not yet used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6a46c5f207d1792be048e0233f173286cde0560e">6a46c5f2</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-01-10T19:38:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Implement create_dfs_pathat() in shadow_copy2.
Not yet used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/51fd875661640a7d305b87961b3a0201be350414">51fd8756</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-01-10T19:38:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Implement create_dfs_pathat() in snapper.
Not yet used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/23df92810b3367b58e8a629d7ee42cf7d167373d">23df9281</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-01-10T19:38:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Implement create_dfs_pathat() in full_audit.
Not yet used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/54f9da44356b16efca56cc85f2552624bbe81876">54f9da44</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-01-10T19:38:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Implement create_dfs_pathat() in time_audit.
Not yet used.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/748379c66bc3d5131a9346c4c7a973d514b35563">748379c6</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-01-10T21:05:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: msdfs: Change create_msdfs_link() to call SMB_VFS_CREATE_DFS_PATHAT().
No change in the (rather strange) logic.
First step in abstracting MSDFS storage from direct symlink calls.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jan 10 21:05:25 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/888002f99e113bceec5329b0962b4068e0df49ce">888002f9</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2020-01-11T13:34:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_ceph: drop support for building without statx
libcephfs statx became available with the Kraken (11.2.0) release of
Ceph in Jan 2017. Versions prior to this are no longer supported
upstream, so we can drop support within Samba vfs_ceph.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e61ddeef4cc35402b623dbb655ab06058866bfc4">e61ddeef</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2020-01-11T14:59:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_ceph: drop support for pre-hammer libcephfs versions
The last Ceph Hammer release (0.94.10) came in Feb 2017, as is no longer
supported upstream. Drop support for building Samba vfs_ceph against
version prior to 0.94.0.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Sat Jan 11 14:59:36 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e1c6e7d18b446b55634bb4807c6d1a9e9346bd6c">e1c6e7d1</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-01-12T19:50:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">decode_ndr_X_crash: always find pipe in honggfuzz file
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1d35962128c93c48cd477601359182b63610ab69">1d359621</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-01-12T19:50:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">fuzz_ldap_decode: do not print to stdout
The fuzzer doesn't care and it slows things down
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/16ca385013ae588e8f2b696af03013980926cac1">16ca3850</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-01-12T19:50:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb controls: fix typo in bypassoperational message
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/beb386b584bdff25c714feb7f76d73b65ed072e7">beb386b5</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-01-12T21:21:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">fuzz: add a fuzzer for parsing ldb controls
We have had issues here in the past.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun Jan 12 21:21:30 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c6d880a115095c336b8b74f45854a99abb1bbb87">c6d880a1</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2020-01-13T15:05:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3-rpcserver: fix security level check for DsRGetForestTrustInformation
Harmonize _netr_DsRGetForestTrustInformation with source4/ logic which
didn't change since DCE RPC channel refactoring.
With the current code we return RPC faul as can be seen in the logs:
2019/12/11 17:12:55.463081, 1, pid=20939, effective(1284200000, 1284200000), real(1284200000, 0), class=rpc_parse] ../librpc/ndr/ndr.c:471(ndr_print_function_debug)
netr_DsRGetForestTrustInformation: struct netr_DsRGetForestTrustInformation
in: struct netr_DsRGetForestTrustInformation
server_name : *
server_name : '\\some-dc.example.com'
trusted_domain_name : NULL
flags : 0x00000000 (0)
[2019/12/11 17:12:55.463122, 4, pid=20939, effective(1284200000, 1284200000), real(1284200000, 0), class=rpc_srv] ../source3/rpc_server/srv_pipe.c:1561(api_rpcTNP)
api_rpcTNP: fault(5) return.
This is due to this check in processing a request:
if (!(p->pipe_bound && (p->auth.auth_type != DCERPC_AUTH_TYPE_NONE)
&& (p->auth.auth_level != DCERPC_AUTH_LEVEL_NONE))) {
p->fault_state = DCERPC_FAULT_ACCESS_DENIED;
return WERR_ACCESS_DENIED;
}
and since we get AuthZ response,
Successful AuthZ: [netlogon,ncacn_np] user [EXAMPLE]\[admin] [S-1-5-21-1234567-890123456-500] at [Wed, 11 Dec 2019 17:12:55.461164 UTC]
Remote host [ipv4:Y.Y.Y.Y:59017] local host [ipv4:X.X.X.X:445]
[2019/12/11 17:12:55.461584, 4, pid=20939, effective(0, 0), real(0, 0)] ../lib/audit_logging/audit_logging.c:141(audit_log_json)
JSON Authorization: {"timestamp": "2019-12-11T17:12:55.461491+0000",
"type": "Authorization", "Authorization": {"version": {"major": 1, "minor": 1},
"localAddress": "ipv4:X.X.X.X:445", "remoteAddress": "ipv4:Y.Y.Y.Y:59017",
"serviceDescription": "netlogon", "authType": "ncacn_np",
"domain": "EXAMPLE", "account": "admin", "sid": "S-1-5-21-1234567-890123456-500",
"sessionId": "c5a2386f-f2cc-4241-9a9e-d104cf5859d5", "logonServer": "SOME-DC",
"transportProtection": "SMB", "accountFlags": "0x00000010"}}
this means we are actually getting anonymous DCE/RPC access to netlogon
on top of authenticated SMB connection. In such case we have exactly
auth_type set to DCERPC_AUTH_TYPE_NONE and auth_level set to
DCERPC_AUTH_LEVEL_NONE in the pipe->auth. Thus, returning an error.
Update the code to follow the same security level check as in s4 variant
of the call.
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Mon Jan 13 15:05:28 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/36ea1e188d5ea8d40c47ffc466a494c1160e471c">36ea1e18</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-01-13T19:41:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: lib: dbwrap_ctdb: Ensure value_valid is set true if we find the record in the marshall buffer.
Found by "Christopher O Cowan - Christopher.O.Cowan@ibm.com" <Christopher.O.Cowan@ibm.com>
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/15ee379ef11d86670aeea7fa4b8bf740dd259593">15ee379e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-01-13T19:41:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: lib: dbwrap. Cleanup. Add a couple of missing 'return NULL' statements on talloc fail.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aa27bceff194bf1d6665bcb66dd3ba750a59b598">aa27bcef</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add session to struct smb_request
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8aae1ef5c0b9c50f892e01316fdac5dc6504ecbb">8aae1ef5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: move homes_snum from struct user_struct to struct smbXsrv_session
No change in behaviour. A first step in removing user_struct.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5992f8fa93adfcd6fc9e5c0632fc36f02ce271ca">5992f8fa</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: pass smbXsrv_session to make_connection_snum()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bcadd7d798e0cc9bb58835ecac1799dfea8a4cb8">bcadd7d7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use session->global->session_wire_id instead of session->compat->vuid
session->compat->vuid is set to session->global->session_wire_id after a
successful session setup, so both variables will always carry the same value. Cf
the next commit which removes vuid from user_struct.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/61fa0f99768bf3519cafd2c49d0b774bc4c22841">61fa0f99</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove vuid from struct user_struct
The previous commit removed all users of struct user_struct.vuid.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c1d0a70d19ec03f8a1fd770e53db7a921af1282d">c1d0a70d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use session->global->auth_session_info in make_connection_snum()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/96fd0ddd02eae05024102b5ed8dc7fb158ed1785">96fd0ddd</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove vuser arg from make_connection_snum()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e80aca04278e6bfd35744ca852549669cee8a8e2">e80aca04</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: introduce smbXsrv_session_info_lookup()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/57d4689273f01bb458c33ff6577e1ac3f179ece9">57d46892</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use smbXsrv_session_info_lookup() in change_to_user_and_service()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/46f51912aea157433537af27097a0127c7626085">46f51912</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: share level security is long gone...
vuid will always be valid as will be vuser.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c3f890fb1e982603c7f24033fc1e5d73535fbbb8">c3f890fb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use smbXsrv_session_info_lookup() in api_WWkstaUserLogon()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/25524c8e78b0a927bcea5851d7282af0f0a0654e">25524c8e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use smbXsrv_session_info_lookup() in api_reply()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/54d626cc77e33c47912489d234df667d3d394f75">54d626cc</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove dependency on session->compat in smbXsrv_session_logoff()
This is not needed anymore because a previous commit changes this to use
session->global->session_wire_id insteaf of session->compat->vuid, so we're not
depending on session->compat anymore.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a22b503819ce19f8857484bb6c2ee21ce6b75a7f">a22b5038</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use session->global->auth_session_info in switch_message()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dd9735b1da73b6c27feda32230e3fc843746fd2b">dd9735b1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add get_valid_smbXsrv_session()
In memory of get_valid_user_struct() and functionally equivalent it only returns
the session if session setup was successfully completed and
session->global->auth_session_info is valid.
This function is similar to smbXsrv_session_local_lookup() and it's wrappers,
but it doesn't implement the state checks of those. get_valid_smbXsrv_session()
is NOT meant to be called to validate the session wire-id of incoming SMB
requests, it MUST only be used in later internal processing where the session
wire-id has already been validated.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c3d22018679c6aa83c4a5ae3e480532a3f5eccca">c3d22018</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use get_valid_smbXsrv_session() in invalidate_vuid()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d2b5f85d221626ce505143c7c129c41603dcb24a">d2b5f85d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove enum server_allocated_state magic from get_valid_user_struct()
This has been obsoleted a long time ago by
a129e271b5385853fb39a8e54b56b508b00a3e41.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/18b43aeb5747f0982e4296960f23986a5f536960">18b43aeb</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add smbXsrv_session_local_traverse()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4b89100dc8d7620657fa1e6335d47df97188c102">4b89100d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use smbXsrv_session_local_traverse() in id_in_use()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8be0ca8e19b861d13038769289325537c101072b">8be0ca8e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove use of user_struct from reply_ulogoffX()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9ef30c75b065876fee05103a4ad1b0d70d2d86c6">9ef30c75</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use req->session instead of vuser->session in make_connection_smb1()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/893aba4d65b6f2bdcd49ba3618f882fad0d5df49">893aba4d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove unused vuser arg from make_connection_smb1()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/758c42ec5dd3dd8bba7b4f74741dc9b02cfb0d73">758c42ec</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove unused vuser arg from make_connection_smb2()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1d797a839d4f96da649ff13bf8c6c7ea4b52ae44">1d797a83</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: don't use vuser in make_connection()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cdab99ba1e7ef48faeacf7ec45651ce5b48dc5d4">cdab99ba</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove using vuser from smbd_smb2_tree_connect()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5f85090d78c11c9c4ef58954b947a8bc71481e18">5f85090d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T19:41:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: use smbXsrv_session_info_lookup() in become_user_without_service()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a18ffe26b3be13e45622172c4ade258cfc8fa783">a18ffe26</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-13T21:09:01+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: RIP user_struct
At last, the nail in the coffin. :)
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Jan 13 21:09:01 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7c01a44f18b679709d141b2d05e576ee084039b4">7c01a44f</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-01-13T22:25:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libgpo: parse_gp_ext: do not crash upon no ext_strings
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b07eff31de43adb0cd6eab217ca85cd5ba6f3621">b07eff31</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-01-13T23:52:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">net_ads_gpo: remove old '#if 0' blocks
I think the dump_gpo() calls do enough, and this code has done nothing
for a decade.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Mon Jan 13 23:52:26 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/89ed960b1da48ddcc459514871963b87503fd9ad">89ed960b</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2020-01-14T10:28:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/DNS: \n.COM shouldn't be a valid DNS record
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13788
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Björn Baumbach <bb@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/af7a0e3371e1ae219239a91cb665097abbd50f3e">af7a0e33</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2020-01-14T10:28:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: fix adding of dns SRV/MX/SOA records
Thanks to Denis Cardon for finding
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13788
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Björn Baumbach <bb@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/de768710e1677c591bf1b360a5de1321ad3a4d91">de768710</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2020-01-14T11:58:20+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests/DNS: add MX/SRV record tests with multiple spaces
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13788
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Björn Baumbach <bb@samba.org>
Autobuild-User(master): Björn Baumbach <bb@sernet.de>
Autobuild-Date(master): Tue Jan 14 11:58:20 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dc74b437c2ed245a7baeee633efba37909761d4b">dc74b437</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2020-01-14T15:18:02+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml: 'mangled names = illegal' is the new default
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Jan 14 15:18:02 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/75ddd1d6ab84028a422d4be1c115880fc564c089">75ddd1d6</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-14T19:17:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nfs4acl: Align integer types
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4546aff887c3bf9babb663f014d147dc2052a463">4546aff8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-14T19:17:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Use tevent version of timeval_current_ofs()
We have tevent available anyway, use that infrastructure
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8100b56b55352983c0965f99c6f8ba515e55a929">8100b56b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-14T19:17:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Remove "msg_ctx" from server_id_watch_send()
Not needed
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/46565a049ed7e3ba0ead9b756960e400142db7b0">46565a04</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-14T19:17:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Avoid an unnecessary include
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/be0a5ab852a66a041f0d6c6a96abbe296476b13a">be0a5ab8</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-14T19:17:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test3: Fix usage check for test_sharesec.sh
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9e67b6b9515d1bc456c9f0f4edd0aea430b6d870">9e67b6b9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-14T19:17:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Protect against non-string "close-share" sharenames
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d2d5007936ba4f48edad61c7613bed07c31da463">d2d50079</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2020-01-14T19:17:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbclient/tar: add verbose mode
A verbose mode got lost with the introduction of libarchive support.
The verbose mode is optional, default is quiet mode.
The output format is close to the verbose output format of POSIX tar
implementations and should be good parsable.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11642
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/199f44ff87504b5e323bcccb0b3e7922c328ad38">199f44ff</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2020-01-14T19:17:29+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbtar: adopt for new tar verbose option
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d512b27563b32f7bcb35da21781e87473830c906">d512b275</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2020-01-14T20:42:10+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">clitar: use modern DBG macros
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jan 14 20:42:10 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8403527bbd132ee639fdd3926bf55d15bd8dea56">8403527b</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-15T12:05:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: implement user setprimary group command (set primaryGroupID)
Introduce an option to set the primaryGroupID attribute of a user account..
Pair-programmed-with: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Björn Baumbach <bb@sernet.de>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org></pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a77f758df117638ea22b7589323b71d5f5261bd9">a77f758d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-01-15T12:05:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: implement user getgroups command
samba-tool user getgroups command to list a users group memberships.
Pair-programmed-with: Björn Baumbach <bb@sernet.de>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andreas Schneider <asn@samba.org></pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d73a9d1a8d81bf7d7bc9aeab5198931b2a7fb582">d73a9d1a</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-15T12:05:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: create working directory for blackbox test
Required to run test separately.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andreas Schneider <asn@samba.org></pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fd1c905ec3b21f7fcc61f9bc827a56e3a3038381">fd1c905e</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-15T12:05:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Test samba-tool user getgroups command
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6b8a683884950603a690a2e7e3b267c21e458d6b">6b8a6838</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-15T13:30:53+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">tests: Test samba-tool user setprimarygroup command
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Jan 15 13:30:53 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/79460b1b9f3452d6d68014b84f4a9dc3988bd916">79460b1b</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-01-15T19:58:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb common: Fix memory leak
TALLOC_FREE the ldb_control allocated in ldb_parse_control_from_string
when none of the cases match.
Credit to OSS-Fuzz
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: David Disseldorp <ddiss@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/13bd82db64be827c3472255531ee79501f07f129">13bd82db</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-01-15T19:58:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">fuzz: ldb_dn parsing
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/da4786003fef39737734e1a5cbf752442f7793b1">da478600</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-01-15T19:58:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">fuzz: add ldb ldif fuzzer
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f4bafcca863f1f11b07dfec960495a84184f2317">f4bafcca</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-01-15T19:58:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">fuzz: ldb binary decode/enode
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0fcc2e93192b8737b0a711ed2ca118e4e833f3fe">0fcc2e93</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-01-15T21:24:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">fuzz: add nmblib/parse_packet target
We want to ensure that parse_packet() can parse a packet without
crashing, and that that parsed packet won't cause trouble further down
the line.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Wed Jan 15 21:24:31 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2198da1b9bf79e86112aeeb8e9653f6a82f69e8d">2198da1b</a></strong>
<div>
<span>by Samuel Cabrero</span>
<i>at 2020-01-15T21:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libsmb: Fix querying all names registered within broadcast area
Wait for additional replies until timeout when '*' is given to nmblookup
as name.
Introduced by 8da8c36b53cc115f0d446b666fc24fc9423d808e.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=8927
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4371982619d4fb0b784813950055a0f19e0e8667">43719826</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-15T21:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">texpect: Use lib/replace's closefrom()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4fabe1d1072147c609f2e8a2c86da04724564cb2">4fabe1d1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-15T21:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">texpect: Reformat long line
There will be more deps soon
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/733f798074b76ed8b96272a29c8cb91eef7a7118">733f7980</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-15T21:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">texpect: Avoid duplicate sys_write()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c9850e3d80320a5d13a69194246cce3f09f4ba3e">c9850e3d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-15T21:25:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Move sharename check of conn_force_tdis() into a callback
Next commit will have an additional check
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5394885167fac40a910613272f10b7077e59f05c">53948851</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-15T21:25:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Add close-denied-share message
This is like close-share, but kicks out only active users where share
access controls are changed such that now access would be denied
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ebced94a8721ffd25386bda452a1857fa92b9899">ebced94a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-15T22:51:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture: Test smbcontrol close-denied-share
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jan 15 22:51:14 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4bc481c5cb7d772f473171949a3d522788bb7dcf">4bc481c5</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-01-16T20:09:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool gpo: improve UNC parsing
The "UNC doesn't start with \\\\ or //" message was unreachable due to
a logic error, and an UNC starting with \\ would have been split on
/ if there were enough /s in the string.
The unreachable exception was first noticed by Gerhard Lausser in a
github pull request (https://github.com/samba-team/samba/pull/123),
but that patch no longer applies with this more thorough rewrite.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8dca8aaf95bd5fe74c71dc2530a6e57feeee6416">8dca8aaf</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-16T20:09:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: add various new clusapi functions and types
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/efe353edf486ee2ab351735a8f927fe607046bb1">efe353ed</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-16T20:09:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-torture: save cluster version in clusapi test context
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/21157c66abb349c97d02a1a104a6e1cfcb577542">21157c66</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-16T20:09:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-torture: fix asserts in clusapi_NodeControl tests
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/edf21f5e3034b104cfe99e97f62478194d23283e">edf21f5e</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-16T20:09:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-torture: add clusapi GroupSet tests
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/83bbc5cc42ee33e93bb583886b09c38bde767570">83bbc5cc</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-16T20:09:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-torture: fix copy/paste error in clusapi group test
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ac5b7427022333a312b504cdde9d725676274c93">ac5b7427</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-16T20:09:42+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-torture: increase various bufsizes to better deal with Windows 2019 clusters
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/75367e4b0675047c6b21447473c779547d6b51b6">75367e4b</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-01-16T21:34:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: add clusapi_GroupSetControlCode enum
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jan 16 21:34:27 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6786ec2c9638f13efed8cba156e174644804a61e">6786ec2c</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-01-17T12:59:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">fuzzing: check for NULL on ldb_init()
We simply return 0 because failure here is not a problem with the code we
are actually trying to fuzz. Without this asan is unhappy.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org></pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6c7b722b3fa3d6383a22fb517d3cb5572115c365">6c7b722b</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-01-17T14:33:18+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">fuzz_oLschema2ldif: check multiple possible NULLs
Address sanitizer will object to a theoretically possible NULL dereference
so we can't ignore these checks in set-up.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Jan 17 14:33:18 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c9adf47ac5a5aa0dd12572c34b08cc51f15b2e97">c9adf47a</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2020-01-17T17:14:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_glusterfs: Return fake fd from pipe() during open
GlusterFS currently doesn't have an API implementation to set flags on
open file descriptor. Thus we use pipe() to provide valid file descriptor
from the system.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14241
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Fri Jan 17 17:14:43 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7606800b798a31d62e69f61d441201e5db2f0d8a">7606800b</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-01-17T22:38:14+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: avoid calling vfs_file_id_from_sbuf() if statinfo is not valid
When we're about to create a file, the stat info will be all zero, so
vfs_file_id_from_sbuf() would return a bogus file_id. This is normally not a
problem, as open_file() itself also calls vfs_file_id_from_sbuf() after having
created the file.
This is however a problem when using the VFS module fileid, as that is doing
caching of /etc/mtab and failing to find smb_fname->st.st_ex_dev (all zero in
this case when creating a new file) in the mtab cache will trigger a mtab reload
which can be *very* expensive.
Copying many small files to a Samba server in this situation will result in
abysimal performance.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14237
Pair-Programmed-With: Jeremy Allison <jra@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jan 17 22:38:14 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cffcc39f185031bc85bcf0c770892b115058a831">cffcc39f</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-01-18T12:25:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">heimdal_build: Remove bashism from --address-sanitizer build rule
export FOO=bar is a Bash extension, and is not required in this case, we only need the asn1_compile
to run under the variable, there are no further commands in this sub-shell.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
Autobuild-User(master): Isaac Boukris <iboukris@samba.org>
Autobuild-Date(master): Sat Jan 18 12:25:16 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/37eb87d2be88e0e47c72287033e9c829e9625d41">37eb87d2</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-19T18:29:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Align integer types
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/229518ec01b495e0133d83d3560a432a08307c0b">229518ec</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-19T18:29:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Align integer types
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b274bc698ed26c6897beee6051532244bc30d2ec">b274bc69</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-19T18:29:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Use write_data() to write to the password check script
A simple write() might be interrupted or do short writes. Highly
unlikely, but if it happens, it will be impossible to diagnose.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/42a3e2e503baef456082d40617a7639a9e226491">42a3e2e5</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-19T18:29:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdbd: Use struct initialization
2 lines less
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/25bcf0e7890a690f5f573dc5e8392807c403948c">25bcf0e7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-19T18:29:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Use closefrom() in smbrun.c
INSURE is never defined or used.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4dd026d0d33ab5d3c6cc22d63a74917c1c2c2f27">4dd026d0</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-19T19:58:01+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Fix claiming version
We now have to do an explicit DOWNGRADE when we want to change from
G_LOCK_WRITE to G_LOCK_READ.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sun Jan 19 19:58:01 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5ff83809a2be567b69714373ab13bde09f72705c">5ff83809</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-01-20T04:25:57+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: lib: dbwrap_ctdb: Ensure value_valid is set when creating empty record
Fixes:
PANIC: assert failed at ../../lib/dbwrap/dbwrap.c(82): rec->value_valid
PANIC (pid 902392): assert failed: rec->value_valid
BACKTRACE: 16 stack frames:
#0 bin/shared/libsamba-util.so.0(log_stack_trace+0x30) [0x7fb161f69cb0]
#1 bin/shared/libsmbconf.so.0(smb_panic_s3+0x23) [0x7fb1619f4863]
#2 bin/shared/libsamba-util.so.0(smb_panic+0x2f) [0x7fb161f69daf]
#3 bin/shared/private/libdbwrap-samba4.so(dbwrap_record_get_value+0x27) [0x7fb160a04c57]
#4 bin/shared/libsamba-passdb.so.0(+0x2d27c) [0x7fb1618e627c]
#5 bin/shared/libsamba-passdb.so.0(pdb_add_aliasmem+0x33) [0x7fb1618db663]
#6 bin/shared/libsamba-passdb.so.0(+0x1edbb) [0x7fb1618d7dbb]
#7 bin/shared/libsamba-passdb.so.0(create_builtin_administrators+0x167) [0x7fb1618d8217]
#8 bin/shared/private/libauth-samba4.so(finalize_local_nt_token+0x39d) [0x7fb16194bd5d]
#9 bin/shared/private/libauth-samba4.so(create_local_nt_token_from_info3+0x304) [0x7fb16194c3f4]
#10 bin/shared/private/libauth-samba4.so(create_local_token+0x3d6) [0x7fb161945106]
#11 bin/shared/private/libauth-samba4.so(+0x154b4) [0x7fb1619474b4]
#12 bin/shared/private/libauth-samba4.so(init_guest_session_info+0x58) [0x7fb161947798]
#13 ./bin/smbd(main+0x80f) [0x55944ef8f91f]
#14 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xeb) [0x7fb161076bbb]
#15 ./bin/smbd(_start+0x2a) [0x55944ef90f8a]
This is a similar, additional fix to commit
36ea1e188d5ea8d40c47ffc466a494c1160e471c.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Jan 20 04:25:57 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/558bd7c83d08523a9e88414195d9703df38e9af2">558bd7c8</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-01-21T08:12:17+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">util: Add detection of libunwind
The current detection doesn't seem to work, so libunwind doesn't seem
to be used.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Tue Jan 21 08:12:17 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7b19e221aeefb4a93990aa589636df471cb8d47e">7b19e221</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-01-21T10:11:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14902 selftest: Add test for replication of inherited security descriptors
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d64670bab82f21fc16fb9ffb32f713c0cae2f9e3">d64670ba</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-01-21T10:11:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14902 selftest: Add test for a special case around replicated renames
It appears Samba is currently string-name based in the ACL inheritence code.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/febe15ab2e109721a7f8ef996c3fe4d82106c42c">febe15ab</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-01-21T10:11:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add test to confirm ACL inheritence really happens
While we have a seperate test (sec_descriptor.py) that confirms inheritance in
general we want to lock in these specific patterns as this test covers
rename.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/545d205e5b203983855c10558ad3a326c13b712e">545d205e</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-01-21T10:11:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14902 dsdb: Explain that descriptor_sd_propagation_recursive() is proctected by a transaction
This means we can trust the DB did not change between the two search
requests.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5d714c1cea1beadc9ca07935217e0174d9d48ac6">5d714c1c</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-01-21T10:11:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14902 dsdb: Add comments explaining why SD propagation needs to be done here
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3f3791765c6fd554b8f7708df0101d3c58339a27">3f379176</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-01-21T10:11:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14902 dsdb: Ensure we honour both change->force_self and change->force_children
If we are renaming a DN we can be in a situation where we need to
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/520d2ae187e83b1cefb4d0c9bf823a051db6b14f">520d2ae1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-01-21T10:11:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14902 repl_meta_data: schedule SD propagation to a renamed DN
We need to check the SD of the parent if we rename, it is not the same as an incoming SD change.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4c62210098df44c6c4cbd0a3d41734e11286106c">4c622100</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-01-21T10:11:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14902 repl_meta_data: Fix issue where inherited Security Descriptors were not replicated.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b7030f9a8bd67f454c17d065d9af9199748aa6d3">b7030f9a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-01-21T10:11:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14902 repl_meta_data: Set renamed = true (and so do SD inheritance) after any rename
Previously if there was a conflict, but the incoming object would still
win, this was not marked as a rename, and so inheritence was not done.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2b1828276b365a30131ac6ea543ac344941b8088">2b182827</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-01-21T10:11:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14902 dsdb: Change basis of descriptor module deferred processing to be GUIDs
We can not process on the basis of a DN, as the DN may have changed in a rename,
not only that this module can see, but also from repl_meta_data below.
Therefore remove all the complex tree-based change processing, leaving only
a tree-based sort of the possible objects to be changed, and a single
stopped_dn variable containing the DN to stop processing below (after
a no-op change).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/512ea17983e7cca78778d493c75b4401a438dfbb">512ea179</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-01-21T10:11:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">repl_meta_data: Add comment explaining what is being renamed after the conflict is resolved
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9e126852a6912e545641a506491f425a987e3b80">9e126852</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-01-21T10:11:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">repl_meta_data: Do not set *rename = true unless there has been a conflict on the incoming DN
The normal case of a partner-sent rename is not a cause for updating the replPropertyMetaData
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/86023642c3961f00d0e4e6c71086739d9d568276">86023642</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-01-21T10:11:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">repl_meta_data: Only reset replMetaData entry for name if we made a conflict name here
We previously set it for any rename
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/34a8cee348d3dfea18e92a4ae829ae797a652192">34a8cee3</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-01-21T10:11:39+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-14907 lib/util: Do not print the failed to convert string into the logs
The string may be in another charset, or may be sensitive and
certainly may not be terminated. It is not safe to just print.
Found by Robert Święcki using a fuzzer he wrote for smbd.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14208
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/13658324a3ab30213ff50c21308f287ef3a131fd">13658324</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-01-21T11:38:38+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2019-19344 kcc dns scavenging: Fix use after free in dns_tombstone_records_zone
ldb_msg_add_empty reallocates the underlying element array, leaving
old_el pointing to freed memory.
This patch takes two defensive copies of the ldb message, and performs
the updates on them rather than the ldb messages in the result.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14050
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Tue Jan 21 11:38:38 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/93fc31858f91c1b4080a223fed905eaac66a90d2">93fc3185</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-01-21T11:39:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add local_daemons.sh option for recovery lock recheck interval
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/64501f519319f83fb6281da50c76275782ee1f6c">64501f51</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-01-21T11:39:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Put recovery lock for local daemons into a subdirectory
This makes it more like the way it works with a cluster filesystem.
It also allows the subdirectory to be manipulated in tests.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/14b1dffc27def76f1c69ff820f4e03dc50ddf4b6">14b1dffc</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-01-21T11:39:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tests: Add some tests to check recovery from recovery lock issues
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aa2977e1519b76b2c70871032bbc5ab85f8a0c45">aa2977e1</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-01-21T11:39:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-mutex: Change default re-check time for fcntl helper to 5s
Testing against a commonly used cluster filesystem has shown no
performance impact, as expected.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/85478847a1f6bf8027a1a91df23ae746042620db">85478847</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-01-21T13:05:00+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add CTDB changes for 4.12
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue Jan 21 13:05:00 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4f1e4f9ce3ff21ca542b87ab1a99c34729370701">4f1e4f9c</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-21T14:38:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testenv: Be more careful deleting environment tmpfiles
If there is more than one server we will have for example nt4_dc.smbd,
nt4_dc.nmbd and nt4_dc.winbind as daemon environments, together with
the commandline environment "nt4_dc" coming last. Before this patch we
would have deleted all previous tmpfiles in the commandline environment.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org></pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1ca1c601989f282e379c163847c99a0c21007df1">1ca1c601</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-21T14:38:43+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testenv: Properly kill daemons
Without this, all the daemons were kept around
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org></pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/823e4de3094d10e39efd236e66f3e60fa31a9620">823e4de3</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-21T14:38:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testenv: Simplify "in_screen"
We don't need "seq", bash can do that itself, and we assume bash here
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org></pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0a77890bbc938a75ad2255ac36861262f0c3fd1a">0a77890b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-01-21T14:38:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testenv: No "mktemp" for in_screen
We don't use this
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org></pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b56c56eecdfe63c23204fbc3a72ebde9ac01a708">b56c56ee</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2020-01-21T14:38:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_ceph: add .fcntl_fn hook
This hook is currently called via vfs_set_blocking(), so can safely be
ignored.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14241
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cc4a55d290c2d34d9dcaccef74385c9251d13e15">cc4a55d2</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2020-01-21T14:38:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_glusterfs: add .fcntl_fn hook
This hook is currently called via vfs_set_blocking(), so can safely be
ignored.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14241
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b813ef6ae7a8349f961f9f133de8f52d1127d90b">b813ef6a</a></strong>
<div>
<span>by David Disseldorp</span>
<i>at 2020-01-21T14:38:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Revert "vfs_glusterfs: Return fake fd from pipe() during open"
This reverts commit c9adf47ac5a5aa0dd12572c34b08cc51f15b2e97.
The fake fd is no longer necessary, as vfs_glusterfs now provides a
fcntl_fn hook.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14241
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/51d4c82f3c5bed8a412ccf747e0617e14ca35671">51d4c82f</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: add --full-dn option to group list command
With this option the command lists the groups distringuished names
instead of the sAMAccountNames.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e64f7de31fddbd702b19ec495f34faad01b217f9">e64f7de3</a></strong>
<div>
<span>by Jule Anger</span>
<i>at 2020-01-21T14:38:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool tests: Add test-case for 'group list --full-dn'
Check if the --full-dn option displays DN instead of the sAMAccountName.
Signed-off-by: Jule Anger <ja@sernet.de>
Reviewed-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/29326e32645cd34b442c8048a768a7d37553b43a">29326e32</a></strong>
<div>
<span>by Jule Anger</span>
<i>at 2020-01-21T14:38:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: add --full-dn option to computer list command
With this option the command lists the computers distringuished names
instead of the sAMAccountNames.
Signed-off-by: Jule Anger <ja@sernet.de>
Reviewed-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2e767e81be409f827e2e6ca1dde7b6ebf1354428">2e767e81</a></strong>
<div>
<span>by Jule Anger</span>
<i>at 2020-01-21T14:38:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool tests: add test case for 'computer list --full-dn'
Check if the --full-dn option displays DN instead of the sAMAccountName.
Signed-off-by: Jule Anger <ja@sernet.de>
Reviewed-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/31060963956ba6feb81d45c3afe140a0a4c3d235">31060963</a></strong>
<div>
<span>by Jule Anger</span>
<i>at 2020-01-21T14:38:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: add --full-dn option to user list command
With this option the command lists the users distringuished names
instead of the sAMAccountNames.
Signed-off-by: Jule Anger <ja@sernet.de>
Reviewed-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/08207f77f13e82cbe1c5a1f82f45680cadfd65d9">08207f77</a></strong>
<div>
<span>by Jule Anger</span>
<i>at 2020-01-21T14:38:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool tests: add test case for 'user list --full-dn'
Check if the --full-dn option displays DN instead of the sAMAccountName.
Signed-off-by: Jule Anger <ja@sernet.de>
Reviewed-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bb66b3225463c940141da2c9ae23dbe6d85b3151">bb66b322</a></strong>
<div>
<span>by Jule Anger</span>
<i>at 2020-01-21T14:38:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: add --full-dn option to group listmembers command
With this option the command lists the groupmembers distinguished names
instead of the sAMAccountName.
Signed-off-by: Jule Anger <ja@sernet.de>
Reviewed-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d2d345103b20b0bb72073b785b7b4cc4552c8335">d2d34510</a></strong>
<div>
<span>by Jule Anger</span>
<i>at 2020-01-21T14:38:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool tests: add test-case for 'group listmembers --full-dn'
Check if the group listmembers --full-dn command displays DN instead of the sAMAccountName.
Signed-off-by: Jule Anger <ja@sernet.de>
Reviewed-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/41262d1d66c18e3ea2f2f3c009a88ef830d25aa4">41262d1d</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: add --full-dn option for user getgroups command
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b545ab1a85d56f169eecfa5d8735fdc5dd5a83f4">b545ab1a</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool tests: add test-case for 'user getgrouops --full-dn'
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8f68236dc4ed281098d534981521d22a250e4001">8f68236d</a></strong>
<div>
<span>by Jule Anger</span>
<i>at 2020-01-21T14:38:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: add -b/--base-dn option to groups list command
With this option it's e.g. possible to list the groups of a
specify OU or groups which are located under a different specific
place in the AD.
Signed-off-by: Jule Anger <ja@sernet.de>
Pair-programmed-with: Björn Baumbach <bb@samba.org>
Reviewed-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bced03b0d1af2055a7b32b5658a746d6a0505ede">bced03b0</a></strong>
<div>
<span>by Jule Anger</span>
<i>at 2020-01-21T14:38:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool tests: add test-case for 'group list --base-dn'
Check if the group list --base-dn / -b command uses a specific base dn.
Signed-off-by: Jule Anger <ja@sernet.de>
Reviewed-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b292a266a8db3e5fbe67cd14c0167869efba2705">b292a266</a></strong>
<div>
<span>by Jule Anger</span>
<i>at 2020-01-21T14:38:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: add -b/--base-dn option to computer list command
With this option it's e.g. possible to list the computers of a
specify OU or computers which are located under a different specific
place in the AD.
Signed-off-by: Jule Anger <ja@sernet.de>
Reviewed-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/88f0a1390b854f4ea1f6e29914e3bac85457c745">88f0a139</a></strong>
<div>
<span>by Jule Anger</span>
<i>at 2020-01-21T14:38:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool tests: add test-case for 'computer list --base-dn'
Check if the computer list --base-dn / -b command uses a specific base dn..
Signed-off-by: Jule Anger <ja@sernet.de>
Reviewed-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8a45adb2b19279d01b33d0f7c15f1cd1c5f9e863">8a45adb2</a></strong>
<div>
<span>by Jule Anger</span>
<i>at 2020-01-21T14:38:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: add -b/--base-dn option to contacts list command
With this option it's e.g. possible to list the contacts of a
specify OU or contacts which are located under a different specific
place in the AD.
Signed-off-by: Jule Anger <ja@sernet.de>
Reviewed-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/55be0f1d2f766618a59b6c4f0d95518adda1103e">55be0f1d</a></strong>
<div>
<span>by Jule Anger</span>
<i>at 2020-01-21T14:38:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool tests: add test-case for 'contact list --base-dn'
Check if the contact list --base-dn / -b command uses a specific base dn.
Signed-off-by: Jule Anger <ja@sernet.de>
Reviewed-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d4de2e3192ed9a1e93bc67f3e110dedde339ed98">d4de2e31</a></strong>
<div>
<span>by Jule Anger</span>
<i>at 2020-01-21T14:38:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: add -b/--base-dn option to users list command
With this option it's e.g. possible to list the users of a
specify OU or users which are located under a different specific
place in the AD.
Signed-off-by: Jule Anger <ja@sernet.de>
Reviewed-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/918d91bb8432ffc0788409ef94fa8b1365be8500">918d91bb</a></strong>
<div>
<span>by Jule Anger</span>
<i>at 2020-01-21T14:38:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool tests: add test-case for 'user list --base-dn'
Check if the user list --base-dn / -b command uses a specific base dn.
Signed-off-by: Jule Anger <ja@sernet.de>
Reviewed-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2186c5a6a4c6de16a0371289832ca99bbc5bc3c2">2186c5a6</a></strong>
<div>
<span>by Jule Anger</span>
<i>at 2020-01-21T14:38:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool: add -b/--base-dn option to OUs list command
With this option it's e.g. possible to list the OUs which are
located under a different specific place in the AD.
Signed-off-by: Jule Anger <ja@sernet.de>
Reviewed-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b081bd977c827fdf20193b5b2b535734fec4a8de">b081bd97</a></strong>
<div>
<span>by Jule Anger</span>
<i>at 2020-01-21T14:38:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool tests: add test-case for 'ou list --base-dn'
Check if the ou list --base-dn / -b command uses a specific base dn.
Signed-off-by: Jule Anger <ja@sernet.de>
Reviewed-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/662b7458aed8daf70980f558f9713920c3e56da4">662b7458</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samdb: add option to specify types of group members
The option can be used to specify the type of the object which have to
be added to (or removed) from a group. The search filter for the objects
will be created according to the types.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e3099ac4072668b208529f1c253c308bb82dac5b">e3099ac4</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samdb: add more object types for adding/remove group members
The filters are based on the MS Windows filter, which are used by the
basic group member management dialog.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2abebee1405d2c7606e3980cfc07fec101c24297">2abebee1</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samdb: fetch specific error if there are more than one search results
There can be more than one contact with the same name.
Signed-off-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2baa301237f4a2446667db39369848402af5f9bf">2baa3012</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samdb: add 'computer' to the default group member types for group member filters
Add the 'computer' type to the default member types, so that the next
commit does not change the default behavior.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/45abb4fd4f42db5e71a6e226f1ed5486f3c257db">45abb4fd</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samdb: adapt search filter for user object type
Use a user search filter which is similar to the filter which is used
by the basic MS Windows group membership management.
The filter filters for objects with the sAMAccountType ATYPE_NORMAL_ACCOUNT.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c4e899d6b4bcc5d42c73810e0c7fe8b67db2b094">c4e899d6</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samdb: adapt search filter for group object type
Use a group search filter which is similar to the filter which is used
by the basic MS Windows group membership management.
The filter excludes the group type GROUP_TYPE_BUILTIN_LOCAL_GROUP.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f9bf6b7856ee573d4f9f1bd0748ac46d24798d5c">f9bf6b78</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samdb: add type "all" to search for all common types of group members
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a4d77bfd90d09b37b89f99042d9e0e3d5b102677">a4d77bfd</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">python/samdb: validation of group member types for group member filter
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f2e2579926e0bfcd8b150c33cd4784391426c5e6">f2e25799</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool group addmembers: add new option --object-types
With this option the admin can specify the object types of the group
members which will be added to the group. The search filter for the objects
will be created according to the types.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aedcf6a52748d0858aab7d1b3e0253592e963706">aedcf6a5</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool group addmembers: add --member-dn option
The --member-dn option allows to specify an object by it's DN.
This is required to select a specific object if there are more than one
with the same name. Multiple contacts can exist with the same name in
different OUs.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/47f9ee91ed9d5bdaea82413f36d17bc72498a79a">47f9ee91</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool group removemembers: adapt functionality to addmembers command
Adds --member-dn and --object-types options.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5b129bf12ba138ffd097443fee52709c7f82cf46">5b129bf1</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool group {add,remove}members: allow to use --member-dn in combination with listofmembers
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/557fa1d44b687a552f7a1413306c229449f5eddd">557fa1d4</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool group addmembers: add --member-base-dn option for group member search
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/347c65434ec5cd9134c6d5f0779cc4bb20f4542b">347c6543</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: add test for new samba-tool group addmembers --member-dn option
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8c5a266ef3f616ab79100dc78caf463d0b734900">8c5a266e</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: add tests for samba-tool group addmembers --object-types option
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2697415239dca1ac54eb056b7c80cdf81c79bea9">26974152</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: add test for samba-tool groupmember --member-base-dn option
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cf9850b4e0641845ce8942bdb536531204788adf">cf9850b4</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-01-21T14:38:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool group addmembers: avoid python traceback on member add failure
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e1e55a4741932dda4c4b39e664f7a9dd525e6517">e1e55a47</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-01-21T14:38:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release note for Samba 4.12.0rc1.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/773c5de675049bd6943e0464d7cabcea54d94e47">773c5de6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-01-21T14:38:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.12.0rc1 release...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1e3b0034af65259046771f1aad83d21450220a66">1e3b0034</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-01-21T17:05:58+01:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.12.0rc2...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/814be2888b3bd77f7a67323b1a0a909448e878e3">814be288</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-01-21T19:32:50+01:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script/release.sh: make it possible to run from a git worktree
.git is a regular file in that case.
Also check that script/release.sh is present as a relative path
to ensure we're called from the expected location.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 648f94d2031c6e758bdf54089d1e710c265ca732)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/601b95285ce2e30ddfee8bbea4a3ea2d9030947b">601b9528</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-01-31T12:32:21+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: lib: nmblib. Clean up and harden nmb packet processing.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14239
OSS-FUZZ: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20156
OSS-FUZZ: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20157
Credit to oss-fuzz.
No security implications.
Signed-off-by: Jeremy Allison <jra@samba.org>
Pair programmed with: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jan 21 23:33:41 UTC 2020 on sn-devel-184
(cherry picked from commit ad236bb7590e423b4c69fe6028f2f3495977f48b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/01afd3a9b6daaa38fa42410341ed49bb843daed1">01afd3a9</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2020-01-31T12:32:21+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Log mkdir error on correct debug levels
For smbd we want an error and for smbclient we only want it in NOTICE
debug level.
The default log level of smbclient is log level 1 so we need notice to
not spam the user.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14253
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Mon Jan 27 15:55:24 UTC 2020 on sn-devel-184
(cherry picked from commit 0ad6a243b259d284064c0c5abcc7d430d55be7e1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7b1be793de0da79c3533d221547d19aa89104414">7b1be793</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2020-01-31T13:57:54+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: Skip the deltest20 as user root
The test is meant to be run as a user and not root.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14257
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Jan 30 16:54:33 UTC 2020 on sn-devel-184
(cherry picked from commit 677bc1b18420e717154dc73f632044239ac3ff9e)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Fri Jan 31 13:57:54 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f17d3edbb6414c104687baa19d5dff9f47b55013">f17d3edb</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-02-04T11:06:10+01:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">script/release.sh: Don't use quotations any longer.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Mon Feb 3 12:45:39 UTC 2020 on sn-devel-184
(cherry picked from commit f699df32cdbae4fbc585c259828029c74163323b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/74b22159448c0e82886c03318aec6cffaa465003">74b22159</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-02-04T11:08:05+01:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.12.0rc2.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b017377c930bd0d8e8d9ae6814cc5755c69842fd">b017377c</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-02-04T11:08:41+01:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.12.0rc2 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/75977baa43eda4160515813839f4d79b1b6f7878">75977baa</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-02-04T11:09:35+01:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.12.0rc3...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8e4c08ded7b81755ff3754e386b8790165d811a4">8e4c08de</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2020-02-05T08:45:30+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Improve check for gnutls_aead_cipher_(en|de)cryptv2
This is available since version 3.6.10, but 3.6.10 has a bug which got fixed
in 3.6.11, see:
https://gitlab.com/gnutls/gnutls/-/merge_requests/1085
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14250
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Feb 4 06:44:00 UTC 2020 on sn-devel-184
(cherry picked from commit d459ca04fc46a52276a860e73ae9ec8f813c260e)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Wed Feb 5 08:45:30 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/044a1fee5f7b7bef00e39bea2c4cd0caf8589d37">044a1fee</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-02-05T11:40:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add some more changes since 4.11.
Mention new parameter 'spotlight backend' and note that vfs_netatalk has been
removed.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Wed Feb 5 11:40:25 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d0a0bcf67c8b9a1d4fd9482e82c809e950140087">d0a0bcf6</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2020-02-06T13:10:31+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">wafsamba: Do not use 'rU' as the 'U' is deprecated in Python 3.9
See https://docs.python.org/3.9/whatsnew/3.9.html#changes-in-the-python-api
"open(), io.open(), codecs.open() and fileinput.FileInput no longer accept 'U'
(“universal newline”) in the file mode. This flag was deprecated since Python
3.3. In Python 3, the “universal newline” is used by default when a file is
open in text mode. The newline parameter of open() controls how universal
newlines works."
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14266
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Feb 6 07:30:13 UTC 2020 on sn-devel-184
(cherry picked from commit 52722746a5eb40c309ba59f78bd8e3d897417bdc)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Thu Feb 6 13:10:31 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9a177304331a0a7eeef236cbdfc59330cead3c7d">9a177304</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-02-10T10:10:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli:smb: Don't use forward declartions for GnuTLS typedefs
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14271
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Feb 7 13:48:27 UTC 2020 on sn-devel-184
(cherry picked from commit 3894f878183e645421ec440afd8e010218a58eef)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Mon Feb 10 10:10:46 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5d852de752b18a470fd07108a6f7f59bb0e753c8">5d852de7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-02-11T07:51:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth_sam: replace confusing FALL_THROUGH; with break;
There's no real logic change here, but is makes it easier to
understand.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14247
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 85b168c6dac88f5065c0ec6e925937439f2c12ed)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/88b89f0a3d1cb5e7c0734e231631cc475c7588b9">88b89f0a</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-02-11T07:51:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth_sam: unify the debug messages of all auth_sam*_auth() functions
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14247
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 72ef8d3a52c1ab07c079a4c014ba8ac7bff528f7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f9ac1033177bef15cb911723ef877beaa83a9517">f9ac1033</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-02-11T07:51:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth_sam: make sure we never handle empty usernames
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14247
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 01b8374e7942141e7f6cbdec7623c981a008e4c1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c579ab09a9b1b3f4832ad9785bf659d319086b45">c579ab09</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-02-11T07:51:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth_sam: introduce effective_domain helper variables
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14247
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit a63e2a312c761093fedb09bd234b6736485a930a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2b56b5a05af48bc7c233c8289c80aadd96c268b4">2b56b5a0</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-02-11T07:51:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:selftest: test authentication with an empty userdomain and upn names
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14247
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit a9eeea6ef78cc44c8423c7125fa1376921060018)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9c1b614e11a3fdf418f87f03f6df5be0a7706330">9c1b614e</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-02-11T07:51:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:auth_sam: map an empty domain or '.' to the local SAM name
When a domain member gets an empty domain name or '.', it should
not forward the authentication to domain controllers of
the primary domain.
But we need to keep passing UPN account names with
an empty domain to the DCs as a domain member.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14247
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 590df382bea44eec2dbfd2a28c659b0a29188bca)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7163ae8a7720f4acfb818666bc8a31abddf447b0">7163ae8a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-02-11T07:51:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">bootstrap: Remove un-used dependency python3-crypto
This became unused in bbeef554f2c15e739f6095fcb57d9ef6646b411c
(except for repl_cleartext_pwd.py, a development script) and we now use
GnuTLS via a Samba wrapper.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14255
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 446c92017369007139af7532dae8503f9db40d48)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b1fba6c7a066e577e637acc0f8968c2ec264f0ea">b1fba6c7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-02-11T10:01:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: handling missing idmap in getgrgid()
A similar hunk was added via commit
89f753c1fc824fef29aebb7d783ab7e09cd1f04e ("winbind: Use xids2sids in getpwuid"),
but it was missing in commit
e2dda192e7f8b65a5f02120be56cf0f07d03679f ("winbind: Use xids2sids in getgrgid")
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14265
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Feb 5 17:56:58 UTC 2020 on sn-devel-184
(cherry picked from commit 4d0bda9467ac3f45f85f48a281cdb173ce1064eb)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Tue Feb 11 10:01:33 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3e222ac6b9329dfbf34f124fae0b0f64d2cd76ac">3e222ac6</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-02-18T07:18:20+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: Make error handling for outbound connection consistent
If we can't bind the local end of an outgoing connection then
something has gone wrong. Retrying is better than failing into a
zombie state. The interface might come back up and/or the address my
be reconfigured.
While here, do the same thing for the other (potentially transient)
failures.
The unknown address family failure is special but just handle it via a
retry. Technically it can't happen because the node address parsing
can only return values with address family AF_INET or AF_INET6.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14274
RN: Retry inter-node TCP connections on more transient failures
Reported-by: 耿纪超 <gengjichao@jd.com>
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit a40fc709cc972dadb40efbf1394b10fae3cfcc07)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1e61aa6d46f1bc37e5ec8f1f8499e5078c316bc4">1e61aa6d</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-02-18T07:18:20+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Fix CID 1458420 Null pointer dereferences (REVERSE_INULL)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14247
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 503fc8f2ba662ecbec0788bd1710440464dc5cfd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/46ff9e1bca8645deb3b9b5d9630358b0cee8f607">46ff9e1b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-02-18T09:27:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">auth: Fix CID 1458418 Null pointer dereferences (REVERSE_INULL)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14247
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit ef0350221e194a3dd3350eab02b38baeb32d8fd3)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Tue Feb 18 09:27:36 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/60deff09d09f7f92a6f512bc41a5de553574be50">60deff09</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Simplify register_msg_pool_usage()
We can do as much as we want in the filter. This gives us automatic
retry, we don't have to do the messaging_filtered_read_send() over and
over again
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14281
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 8a23031b7bfea4cdaa71d6815bca24dcc3685b22)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1b4db22b1601c999a59043fcbea5d2b09ff487e2">1b4db22b</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Add a TALLOC_CTX to base register_msg_pool_usage() on
Add a simple way to deactivate the registration
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14281
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit dab982d88e9132cbff52db22f441c08ee59bb159)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fd63e94a2825495a7daae8d3debbb76a2532c540">fd63e94a</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Introduce messaging_context->per_process_talloc_ctx
Consolidate "msg_dgm_ref" and "msg_ctdb_ref": The only purpose of
those pointers was to TALLOC_FREE() them in messaging_reinit(). We'll
have a third entity to talloc_free() in the next commit, make that
simpler.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14281
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 7209357f9ba5525a207d301b299931d6bdee9c2f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9463a387831c1c482770fea3675d30763b7647dc">9463a387</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Fix a shutdown crash with "clustering = yes"
This is a bit confusing now, sorry for that:
register_msg_pool_usage() in the ctdb case uses
messaging_ctdb_register_tevent_context(), which talloc_reference()s
the central struct messaging_ctdb_fde_ev of the
messaging_ctdb_context. In messaging_reinit(), we talloc_free only one
of those references and allocate a new messaging_ctdb_fde_ev. The
remaining messaging_ctdb_fde_ev should have been deleted as well, but
due to the second reference this does not happen. When doing the
shutdown messaging_ctdb_fde_ev_destructor() is called twice, once on
the properly reinitialized fde_ev, and once much later on the leftover
one which references invalid data structures.
By the way, this is not a problem with talloc_reference(), this would
have happened with explicit refcounting too.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14281
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Björn Baumbach <bb@sernet.de>
Autobuild-Date(master): Tue Feb 18 13:05:53 UTC 2020 on sn-devel-184
(cherry picked from commit f1577c2bc13c91ea912ae461870e470065f250c1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/40c84bfcdd288a617a22af6faa50a029d5d537cf">40c84bfc</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/replace: remove unused check for aio.h
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit c1b9bf993402f7d74f992c609ede94653e87172f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ac78557df8e626d12ae062ed629589fd5fae060d">ac78557d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">bootstrap: replace libaio-dev/libaio-devel with liburing-dev/liburing-devel
We'll never use libaio, but will soon add a io_uring vfs module.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit fb5a99fa0200785ef1b5a8c9bc4a645d09fbeb5e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a1486fb28372ef66b0c90b2f73c0d0588d05352d">a1486fb2</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:modules: add vfs_io_uring module
The module makes use of the new io_uring infrastructure
(intruduced in linux 5.1), see https://lwn.net/Articles/778411/ and
http://git.kernel.dk/cgit/liburing/
Currently this only implements SMB_VFS_{PREAD,PWRITE,FSYNC}_SEND/RECV
and avoids the overhead of our userspace threadpool.
In future we'll hopefully make more use of more advanced io_uring
features.
For now we don't have automated tests as our test infrastructure
doesn't use a recent kernel. At least we're able to do compile tests
on fedora31.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sat Feb 15 11:37:45 UTC 2020 on sn-devel-184
(cherry picked from commit 195e88cea34c983afc02cfb521a60cdd1edbe9e1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/59815861b2e33efcf8c6b09d4884cf35b0cfc329">59815861</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: announce vfs_io_uring
Signed-off-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ce3bf591e2fa89056c2a17559b8fe2c8bd7f0980">ce3bf591</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Implement create_dfs_pathat() in catia.
Now we use this instead of symlinks to create
DFS links, it's needed in catia.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit fa2f83e13aa92a12bd8d0113576a04a1e4431a44)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1ba9c318ae1d0490ac30ddddc01d2c015e16ec35">1ba9c318</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Implement create_dfs_pathat() in cap
Now we use this instead of symlinks to create
DFS links, it's needed in cap.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Jan 30 18:21:47 UTC 2020 on sn-devel-184
(cherry picked from commit 042249d95ff59d304cf37914860ee0c4d1f546f8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7f034780869492ea7d34e662baee2e39978565ce">7f034780</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: dfs: Cleanup, reformat calls to parse_msdfs_symlink()
Make parameter easier to change.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit d22b0d907252939c2ded9d73cc67dbbf8bb57fb7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3ff14a2e5a3186eeeb2a97cc9c09ad22d61e31d3">3ff14a2e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: dfs: Move lp_msdfs_shuffle_referrals() call out of parse_msdfs_symlink().
Removes dependency on snum for what is text parsing code.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 028c33e09ab52b55f33f83e26a12498f57918334)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9f87784686d8a55c9e039841c9f8a1ab33a92f5e">9f877846</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: dfs: Make parse_msdfs_symlink() external.
So it can be called by a future new VFS call.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 012b812188f636d9b8cf0edee34df5d43d2ac0a8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2f2794a72419cdd871f41eb4700c27d8bdec7886">2f2794a7</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: dfs: Apply some README.Coding to parse_msdfs_symlink().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit a211c640878d856e859ab2fdfbbe61036240b8eb)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c13c6e44918dcb5de75b9872a119987cfbd13acb">c13c6e44</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: dfs: Allow parse_msdfs_symlink() to be called with NULL pointers.
In case we don't want all the data.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 4e4afc52e6f63fa4058310c6b0a0314b8f73c189)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b4285b8d1b1d6007242bb3aebb9252f238f5474a">b4285b8d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: dfs: Make parameter names consistent.
Initialize reflist to NULL.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit ed527dc1d8bd21d942bc14677d83363144e5f46b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6d5220f23cf43dbceb38bc5bfccaafcede3724f4">6d5220f2</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: dfs: Clean up exits / talloc heirarchy in parse_msdfs_symlink().
Ensure on error or clean return we don't leave memory on mem_ctx.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 74b47bf578dab9ce94a9f2439fa672e51afe809e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6fae0415d55c7204c6eb4a29345b61e45710f7b4">6fae0415</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Add SMB_VFS_READ_DFS_PATHAT().
Not yet used.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 96bc3298fc025d1d76fc06833fece6c62faa5e1a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7bbfc1c3a8c6968d45874af5971ce3c44f730ccb">7bbfc1c3</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: ceph: Add vfswrap_ceph_read_dfs_pathat().
Not yet used.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit e52e2135dd9b8bd2e65261c210e7b8d36a727396)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5c8f5a48df7400e0d2951664c493c3bd3b77026c">5c8f5a48</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: gluster: Add vfs_gluster_read_dfs_pathat().
Not yet used.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 018af49b93f8e9a2cbc0d40cc68b8202e5c95c9a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/13c6e747da1fe1b6e20b8eaefbeb183e7c4d28fb">13c6e747</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: shadow_copy2: Add shadow_copy2_read_dfs_pathat().
Not yet used.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 9e92d46b757d6a4cdd0f956c24b30df89adf2798)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/895c06ccec22e27b32fbe07222514a13a95b7006">895c06cc</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: cap: Add cap_read_dfs_pathat().
Not yet used.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 9f6c01b2cd82963bfa05552aa41dfafcb0bf7637)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dfabe8e731e489071c3e7981e389f332d806ac1a">dfabe8e7</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: catia: Add read_dfs_pathat().
Not yet used.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 16acdc348db71a29bec93d62073ca30a4a920389)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2633e1821339590b849360737060fb67c064eb48">2633e182</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_full_audit: Add read_dfs_pathat().
Not yet used.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 263df988831a40ba751b19c1715277e80095818c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ce94b410867446b997952c368664b5d5cdc36573">ce94b410</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_time_audit: Add read_dfs_pathat().
Not yet used.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 0528584482f798753d636675da778917f50ca845)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/967e0e15fc92cefe7f8d3c9b1442c391e67e87a5">967e0e15</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: DFS: Change simple is_msdfs_link() call to use SMB_VFS_READ_DFS_PATHAT().
This will need an extra dirfsp parameter in future, but this
is the easiest change for now.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 07a3cd56cddfc0e27a75ca76e556e2fdb18c3291)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/007c96ab6e2e9800baa216b29b7fcad8a715a5ef">007c96ab</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: DFS: Parse the returned target path in dfs_path_lookup().
Currently unused, but this will ease the transition to
using SMB_VFS_READ_DFS_PATHAT().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 1ffc52abedae9787f745795a4f502c26b4c005d1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/92722a1b63a6209516d8d6fd606fde4b8d51e25f">92722a1b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: DFS: Change dfs_path_lookup() to return struct referral list and count directly.
Remove external parse of returned link targetpath, expose
the parsing previously added to dfs_path_lookup().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 1668c9ee15b421093756ac9d709f55ce3e808791)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8690880313af37fd4d003f216fa6d16a9ee1ea9e">86908803</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: DFS: Replace calls to is_msdfs_link_internal() inside dfs_path_lookup() with SMB_VFS_READ_DFS_PATHAT().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 3c77a9e7116bc3f1e3c9bf89c28a32bdb6cdffe1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bbbfc6b8acd4187959c1905768f0e05792302091">bbbfc6b8</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: DFS: Change the last use of is_msdfs_link_internal() -> SMB_VFS_READ_DFS_PATHAT() inside form_junctions().
is_msdfs_link_internal() is no longer used.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 94068b5438013479b0426fea7f83bbd7f8f935e9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6c886973fa07f88db0ddd31e0cc28e05ad988000">6c886973</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T06:19:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: DFS: Remove is_msdfs_link_internal() - no longer used.
All DFS links are now read through the VFS and not via
symlink calls.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14282
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Feb 18 22:34:16 UTC 2020 on sn-devel-184
(cherry picked from commit 9ee1320049cf148a2bb102bbdee4a4bcc24c0de1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/19d74ce5f5b649d7f75c18f4430331c948d7e96c">19d74ce5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-19T07:52:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW.txt update explaining SMB_VFS_CREATE_DFS_PATHAT() / SMB_VFS_READ_DFS_PATHAT().
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Wed Feb 19 07:52:15 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5987adfa00c17391bdfe27937eac258fa9ae53fb">5987adfa</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-02-19T11:08:16+01:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Add release notes for Samba 4.12.0rc3.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3a807493547d4bf88719634a85f06ed5f733d101">3a807493</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-02-19T11:08:49+01:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.12.0rc3 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f72bb650ec393d12e7c5dbb7290970506f097184">f72bb650</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-02-19T11:09:30+01:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.12.0rc4...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5a794f3bf8cfae04fab8ef2e5136ee470d8fa60e">5a794f3b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-20T10:32:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: DFS: Don't allow link creation on a read-only share.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14269
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit b4195cd488e1366887acfea6ae03bf4198514a15)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/339566feb72edc3b1fc39d2c7fb5bf05c11a88a5">339566fe</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-02-20T10:32:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: DFS: Don't allow link deletion on a read-only share.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14269
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 0450593e38d62fe0b925d789486517ade31fe3c6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/da44630885eb51f54c4814dcac1c94f11a149642">da446308</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-02-20T10:32:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">pidl/wscript: configure should insist on Parse::Yapp::Driver
following 83ffe6752d589180eac96d7b8e7d1a54e3476bfd, you get a build
error if you lack a system perl Parse::Yapp. Let's make it a configure
failure instead.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14284
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun Feb 2 10:09:11 UTC 2020 on sn-devel-184
(cherry picked from commit af47a77673f58cc6436798b250c90be0e325d20e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/537acf2a185c7b8ee76c7a55cb9d9dad6417d153">537acf2a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-02-20T12:58:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">build: Do not check if system perl modules should be bundled
We do not ship any perl modules in third_party at this time, so
this check is pointless and breaks the build for --bundled-libraries=ALL.
As reported by aaptel on https://gitlab.com/samba-team/samba/-/merge_requests/1104#note_281050331
This changes our autobuild script to cover this case in the
samba-static job.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14284
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
(cherry picked from commit cf4984947b39e9f6f8afd29de8a760703bf9e092)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Thu Feb 20 12:58:46 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0b964d99aa451f9becefca38da80e2b07b4ff63e">0b964d99</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-02-21T09:20:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add zlib and fuzzing notes
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/828b834706f2656b9b669dd6c87f81bedc5b10be">828b8347</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-02-21T09:20:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: samba-tool improvements
This text is based on https://gitlab.com/samba-team/samba/-/merge_requests/1015
by Björn Baumbach, just re-worked a little to suit the WHATSNEW.
I wrote the second section
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9b6e4da57d73136cc1a2e3bce198ce3ff327269f">9b6e4da5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-02-21T10:46:08+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Announce new Spotlight backend for Elasticsearch
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Karolin Seeger <kseeger@samba.org>
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Fri Feb 21 10:46:08 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/670b83a1e6d19e1920fdba09d39c6b0743546a3b">670b83a1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-02-25T19:32:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test: Intercept open in vfs_error_inject
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14285
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 305204a241b74c599f4f6a064cac6608afd9c893)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dcdfa4a752e9bed5ea4556719eb66d88beefb9d3">dcdfa4a7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-02-25T19:32:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">test: Show that smbd does not handle EINTR from open() correctly
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14285
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 7bbba73b30f06304e9a2ad48e853d9ec8171dd30)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1a47b0fd1d31b3c519853e52a96ef810d0b980df">1a47b0fd</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-02-25T19:32:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: Map EINPROGRESS->NT_STATUS_MORE_PROCESSING_REQUIRED
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14285
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 4a943d842a51674425f0c4019f823ef0a9d09f49)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a21688e7d4878fc3d5c80a87d12b1534acc34378">a21688e7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-02-25T19:32:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: Separate aio_pthread indicator from normal EINTR
According to Posix and the Linux open(2) manpage, the open-syscall can
return EINTR. If that happens, core smbd saw this as an indication
that aio_pthread's open function was doing its job. With a real EINTR
without aio_pthread this meant we ended up in a server_exit after 20
seconds, because there was nobody to do the retry.
EINTR is mapped to NT_STATUS_RETRY. Handle this by just retrying after
a second.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14285
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Feb 20 22:14:25 UTC 2020 on sn-devel-184
(cherry picked from commit aebe427b77b5315eb5d2b05b8c72824ca0389723)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ea4c35f1d42247e2ac19c77249d6e9432b1c7c58">ea4c35f1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-02-25T19:32:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Add tests for one-level indexes in conjunction with other indexes
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14270
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 17bd63dbea7f6e6358f81f0ac5b9392b2321bb32)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/71c072c385f9f6a79a11b12bfcbeb0677d10b6a9">71c072c3</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-02-25T19:32:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Add tests aimed at the SCOPE_ONELEVEL particular
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14270
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 167676973b7f1db563da04d54e8ce5668034081c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c521913e4268b5b406c5439a58b1049d605c45cf">c521913e</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-02-25T19:32:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Ensure @IDXONE modes is tested in ldb.python (apy.py) tests
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit ec34a7095705592279647c5046a000e0bf052d1a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/81bdcf9ee4e26e7b9d40b26c2195cb6f7a786d80">81bdcf9e</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-02-25T19:32:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Fix search with scope ONE and small result sets
This changes the LDB behaviour in the combination of a SCOPE_ONE search and
an index returning less than 10 results.
After b6b5b5fe355fee2a4096e9214831cb88c7a2a4c6 the list->strict flag
became set to false in all cases, rather than being left to the
value set by the caller.
This changes the ldb_kv_index_dn_one() code to force strict
mode on success instead.
Thanks to Marcus Granér, ICEYE Oy for reporting.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14270
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 3c7261c43da491b57f50e0e64d7050d85c6b973e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f83104fbfc4ae4bfd2b37f398bf591474aa64c49">f83104fb</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-02-25T19:32:28+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Add tests aimed at the SCOPE_ONELEVEL bug in particular
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14270
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 0b8ab0200805127e36eeb2affe561f3aee59604a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/20195a35bbbd7f6c89315f7e8f2d1fa84e4b4010">20195a35</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-02-25T21:09:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: version 2.1.1
* Bug 14270:
Samba 4.11 and later give incorrect results for SCOPE_ONE searches
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Tue Feb 25 12:59:02 UTC 2020 on sn-devel-184
(cherry picked from commit 0ca46a37268c8219192abc3ab5f2546a02ed8862)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Tue Feb 25 21:09:41 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0f1d595cac33e2596f2e047244150925ece60a99">0f1d595c</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-02-26T08:36:33+01:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.12.0rc4.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e629b9230ea64b4f098589cdbf5edb25f62e9ae8">e629b923</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-02-26T08:37:26+01:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for th Samba 4.12.0rc4 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/201489edf9d95c72ad786f1c6e6169a335e474a0">201489ed</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-02-26T08:38:24+01:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.12.0rc5...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c6b90fbcee065d5eb0f48b64a3f74db1d291ec83">c6b90fbc</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-02-26T10:25:22+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dsdb: Correctly handle memory in objectclass_attrs
el->values is caller-provided memory that should be thought of as constant,
it should not be assumed to be a talloc context.
Otherwise, if the caller gives constant memory or a stack
pointer we will get an abort() in talloc when it expects
a talloc magic in the memory preceeding the el->values.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14258
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 3657bbc21182d764ddfcd603025f24ec240fd263)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a99445e298ca41d6ca3cea2012e22c2f90aaf903">a99445e2</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-02-26T12:35:59+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Test behaviour of DNS scavenge with an existing dNSTombstoned value
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14258
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Feb 6 16:24:25 UTC 2020 on sn-devel-184
(cherry picked from commit c8e3c78d4f2a6f3e122fe458aa6835772290a700)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Wed Feb 26 12:35:59 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a1b4c4a0d9d927d6568b158ce5eba58f36990be2">a1b4c4a0</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-03-03T10:45:39+01:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.12.0.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/21679048604ab7d74f70cc378e1dcaebbaa9d561">21679048</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-03-03T10:47:25+01:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.12.0 release...
and bump version up to 4.12.0.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fdc2f7d218aeb6fe33bc064b34b2228f949280e0">fdc2f7d2</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-03-03T11:06:18+01:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.12.1...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b8ef341f6b537ce23262ca191f4f55a6508a0854">b8ef341f</a></strong>
<div>
<span>by Art M. Gallagher</span>
<i>at 2020-03-18T10:29:09+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_fruit: tmsize prevent overflow Force the type during arithmetic in order to prevent overflow when summing the Time Machine folder size. Increase the precision to off_t (used for file sizes), leave the overflow error traps but with more precise wording.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13622
Signed-off-by: Art M. Gallagher <smblock@artmg.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Mar 7 01:37:31 UTC 2020 on sn-devel-184
(cherry picked from commit b0ba7cd4f96a6ea227943cb05ef51a463e292b2d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e98dcaa16d0943e44fad96868777f08dde023be1">e98dcaa1</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-03-18T10:29:09+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: ignore set NTACL requests which contain S-1-5-88 NFS ACEs
We apply the same "ignore" logic already in the POSIX ACL code and in the
vfs_acl_xattr|tdb VFS modules to smb_set_nt_acl_nfs4() in the nfs4_acl helper
subsystem which is common to a bunch of VFS modules: GPFS, ZFS, NFS4_xattr and
aixacl2.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14307
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Mar 3 19:15:10 UTC 2020 on sn-devel-184
(cherry picked from commit f89c7ad851681c0e0ab39a1bedb3eeb672516fbb)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8f4e8be85547427cf6a3969d1738d1ed68ee195e">8f4e8be8</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-03-18T10:29:09+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VFS: default: let vfswrap_is_offline() take conn, not handle
vfswrap_is_offline() has been converted to a "helper" function some time ago, it
had been a VFS interface function before. To make this change more obvious let
it take a struct connection_struct instead of a struct vfs_handle_struct which
is the canonical first parameter to VFS functions.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14293
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit d4c69d82bdc0fa029609032a9d32f32fa1708beb)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/69e66865203ac1b6dc7fe2eb109f0ee7b5745fc9">69e66865</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-03-18T10:29:09+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VFS: default: remove unused arg from vfswrap_is_offline()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14293
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 99873724cd493366c9957fd9fe230d52a6f02691)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cfaca1c0b7a7f7d7e0b688b21846a9a9d1968cd8">cfaca1c0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-03-18T10:29:09+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VFS: default: avoid a crash in vfswrap_getxattrat_do_sync()
Must use tevent_req_data() to get our tevent_req state, talloc_get_type_abort()
will just crash as struct tevent_req != struct vfswrap_getxattrat_state..
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14293
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit cbca811212a930b94f9917e5a82b6a95ab085e91)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/34f3476d560b743f800bda69338e0c876846e680">34f3476d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-03-18T10:29:10+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VFS: default: use correct type for pathlen in vfswrap_getxattrat_do_sync()
full_path_tos() returns a ssize_t.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14293
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit ace296b97642d9160ea66db89dcd0f24a21dba4e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b0f590055c1642686145154203207b942988608b">b0f59005</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-03-18T10:29:10+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VFS: default: add support for FILE_ATTRIBUTE_OFFLINE to async dosmode
This had been missing in the initial async dosmode implementation. It's the
responsibility of the sync and async dosmode functions to call
vfswrap_is_offline() since the offline functionality has been converted from a
first class VFS function to be a part of the DOS attributes VFS functions..
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14293
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit a23f8d913fa8d77bab394aea9a8e7df2704e8b19)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ea15a4bd1896e5ef1e07738bd46387d9f9bfcdbe">ea15a4bd</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-03-18T10:29:10+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-torture: add rpc test for ChangeServiceConfigW
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14313
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 0825324bc75d2ab10164a1f137be782d84c822b8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ea4603fd5e58d589034772b173a3a518133faa69">ea4603fd</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-03-18T10:29:10+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4-torture: add ndr svcctl testsuite
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14313
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit c3fa0b2df9fc53dddcc3160b6a3dc751bbb389a4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1d226313e0393e7d1e712c990fe2e1d4db26fe71">1d226313</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-03-18T10:29:10+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc: fix IDL for svcctl_ChangeServiceConfigW
Found while trying to run winexe against Windows Server 2019.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14313
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit ebda529b59105e9b70cc74377fe4d54cc16b4f37)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8b86109e5deca6b19883828ff02b4cf19e751641">8b86109e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-03-18T10:29:10+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_recycle: prevent flooding the log if we're called on non-existant paths
vfs_recycle is assuming that any path passed to unlink must exist, otherwise it
logs this error. Turn this into a DEBUG level message.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14316
See also: https://bugzilla.redhat.com/show_bug.cgi?id=1780802
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
Autobuild-User(master): Isaac Boukris <iboukris@samba.org>
Autobuild-Date(master): Mon Mar 9 14:15:06 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f50790c1be70af62cb2d0231cc05bdf59344b4c1">f50790c1</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-03-18T12:26:05+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nmblib: avoid undefined behaviour in handle_name_ptrs()
If *offset is length - 1, we would read ubuf[(*offset)+1] as the lower
bits of the new *offset. This value is undefined, but because it is
checked against the valid range, there is no way to read further
beyond that one byte.
Credit to oss-fuzz.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14242
OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20193
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Feb 7 10:19:39 UTC 2020 on sn-devel-184
(cherry picked from commit 3bc7acc62646b105b03fd3c65e9170a373f95392)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Wed Mar 18 12:26:06 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0706d5394179324e988c00a9d1cabba10fcb3535">0706d539</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-03-19T10:56:08+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: ensure restart() callback is called in half-connected state
If NODE_FLAGS_DISCONNECTED is set the node can be in half-connected state. With
this change we ensure to restart the transport for this case.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14295
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 6a4fa0785fc83561939fa41617d526eb96c1af89)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6f6357c359cb2a8017e2138a03b49da305e8f992">6f6357c3</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-03-19T10:56:08+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: more logical whitespace, debug modernisation
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14295
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 15762a34559599cf908e30651a2d4c11560068ed)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5a51d36317df92e589741c557ed61c64a43413bf">5a51d363</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2020-03-19T10:56:08+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: move free of inbound queue to TCP restart
Since commit 77deaadca8e8dbc3c92ea16893099c72f6dc874e, a nodeA which
had previously accepted a connection from nodeB (where nodeB dies
e.g. as as result of fencing) when nodeB attempts to connect again
after restarting is always rejected with
ctdb_listen_event: Incoming queue active, rejecting connection from w.x.y.z
messages.
Consolidate dead node handling in the TCP restart handling.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14295
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 0ff1b78fc2f0491f9e11131d0040bdaba8873770)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2e619f51b05203fdc3c9a4d9815cd1a567a214ae">2e619f51</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-03-19T10:56:09+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: always call node_dead() upcall in ctdb_tcp_tnode_cb()
ctdb_tcp_tnode_cb() is called when we receive data on the outgoing connection.
This can happen when we get an EOF on the connection because the other side as
closed. In this case data will be NULL.
It would also be called if we received data from the peer. In this case data
will not be NULL.
The latter case is a fatal error though and we already call
ctdb_tcp_stop_connection() for this case as well, which means even though the
node is not fully connected anymore, by not calling the node_dead() upcall
NODE_FLAGS_DISCONNECTED will not be set.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14295
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit b83ef98c7466b2a81968555de83fb977bb6ca9f0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/167ef355b34ca03d3a8255823bebf975cd6e70b7">167ef355</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-03-19T10:56:09+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: Remove redundant restart in ctdb_tcp_tnode_cb()
The node dead upcall has already restarted the outgoing connection.
There's no need to repeat it.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14295
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit ea37ecdcd5960311f54a7a5510b88a654da23daa)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/26e29f7218225037e46ed3df697647bb8f7a89f5">26e29f72</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-03-19T10:56:09+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: rename ctdb_tcp_stop_connection() to ctdb_tcp_stop_outgoing()
No change in behaviour. This makes the code self-documenting.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14295
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 1e2a967ff41cc29c3a0d7f61a46937c68fdb90ba)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3b5af720a4c3d218255a73229ed4591c402f8bdc">3b5af720</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-03-19T10:56:09+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: add ctdb_tcp_stop_incoming()
No change in behaviour. This makes the code self-documenting.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14295
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 2c73dbafba50b28e72a8ec7b4382fae42fca6d17)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e9b727b4f2b95c72087cd6edb3562ef7d9e3d442">e9b727b4</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-03-19T10:56:09+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: Factor out function ctdb_tcp_start_outgoing()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14295
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 3c8747fe29486a4f95308b335a5e3ec1807f62cb)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/25642c7e960d0c83c9fa1eac7f8e0fbb28f90dd7">25642c7e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-03-19T12:19:52+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-tcp: Do not stop outbound connection in ctdb_tcp_node_connect()
The only place the outgoing connection needs to be stopped is when
there is a timeout when waiting for the connection to become writable.
Add a new function ctdb_tcp_node_connect_timeout() to handle this
case.
All of the other cases are attempts to establish a new outgoing
connection (initial attempt, retry after an error or disconnect, ...)
so drop stopping the connection in those cases.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14295
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Thu Mar 12 05:29:20 UTC 2020 on sn-devel-184
(cherry picked from commit 319c93f0c6a949545229b616dfbd4f51baf11171)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Thu Mar 19 12:19:52 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a17de0ee68362363689c171352ef86eb7f000f23">a17de0ee</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-03-20T11:03:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Fix date.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Fri Mar 20 11:03:26 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/20d4785856adda252010b9edd7efb3460651a9f7">20d47858</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-03-27T11:54:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool group listmembers: hide python backtracke on command error
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 789d84c0a9a406f7e0c9ab48cf2f31afdc4d3829)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/439aeba45e96078fb5d63c51d54c5a5d1edc7263">439aeba4</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-03-27T11:54:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool group listmembers: handle group-does-not-exist error
Return a error with a proper message instead of just do nothing when
the target group does not exist.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14296
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 40e498e743e4677a42030373e8d97f6f9763080a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/88edeec6fc18c6b92910bfcef5f27362dc4b520b">88edeec6</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-03-27T11:54:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool group listmembers: find group members by groups SID
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14296
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 1d2e9f27fa9cff55245e45a194f696fc9ca4376d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2dbe9c13d68927e39c58a40e87d1f38d4d15d419">2dbe9c13</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-03-27T11:54:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool group listmembers: use binary encoded group names
Allows to find groups with names like e.g. 'group1 (xy)'.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14296
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit d0f8e833653df652df01a472c4bbfd256f10f810)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ecd119fc6cf1c3292f6d4a68ac25b5cf48099090">ecd119fc</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-03-27T11:54:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool group move: use binary encoded group name
Allows to move groups with names like e.g. 'group1 (xy)'.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14296
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 626209beab2fc9b0fdb7e90338cdfec5cfa48dd7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fc8961c15621a44554cb36fde04a40483f7b94a8">fc8961c1</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-03-27T11:54:40+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool group delete: use binary encoded group name
Allows to delete groups with names like e.g. 'group1 (xy)'.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14296
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 104582b73caf008600e15d76d57424263a0f28d4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f2dae546f22051192e170d4be0fb64cbafb60509">f2dae546</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-03-27T11:54:41+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">samba-tool group edit: use binary encoded group name
Allows to edit groups with names like e.g. 'group1 (xy)'.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14296
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit f3e7ea0405d46ddfbeba9b3a84c13b7878464180)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ee06963cbb42db243764b3a3cf7dcb887483d564">ee06963c</a></strong>
<div>
<span>by Björn Baumbach</span>
<i>at 2020-03-27T13:19:20+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: test samba-tool group commands with groupnames with brackets and spaces
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14296
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 534809a0f09775390e89fa1cbfae3a1d0fafecb8)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Fri Mar 27 13:19:20 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/be8d05f59787acecfac26b577ac6ed18c9c1c37f">be8d05f5</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2020-03-30T08:06:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recovery: Fetched vnnmap is never used, so don't fetch it
New vnnmap is constructed using the information from all the connected
nodes. So there is no need to fetch the vnnmap from recovery master.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14294
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 072ff4d12b8f34766120ddae888d772e97bca491)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ad5c6f3a5202af3120b18f1067c6328a9ee8a651">ad5c6f3a</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2020-03-30T08:06:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recovery: Consolidate node state
This avoids passing multiple arguments to async computation.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14294
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 6e2f8756f1bce4dfc7fdc435e082f400116e29ec)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f468f65407812acc08fa9c1e1cce7f51e9459f19">f468f654</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2020-03-30T08:06:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recovery: Don't trust nodemap obtained from local node
It's possible to have a node stopped, but recovery master not yet
updated flags on the local ctdb daemon when recovery is started. So do
not trust the list of active nodes obtained from the local node. Query
the connected nodes to calculate the list of active nodes.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14294
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit c6a0ff1bed0265e44fd6135d16bfc41919fe5bf5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b7f7f7b63e608a0215ad3cc8fc576cbab68d3bb0">b7f7f7b6</a></strong>
<div>
<span>by Amitay Isaacs</span>
<i>at 2020-03-30T08:06:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recovery: Refactor banning a node into separate computation
If a node is marked for banning, confirm that it's not become inactive
during the recovery. If yes, then don't ban the node.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14294
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
(cherry picked from commit 1c56d6413f86cc15ebac232f39ef1e2a53ae4297)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c9fa4fb05755eb5083a1ec28035b1105a9e90b4f">c9fa4fb0</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-03-30T08:06:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Fix database attach deferral logic
Commit 3cc230b5eeca749ab68d19cfda969f72c269f1f6 says:
Dont allow clients to connect to databases untile we are well past
and through the initial recovery phase
It is unclear what this commit was attempting to do. The commit
message implies that more attaches should be deferred but the code
change adds a conjunction that causes less attaches to be deferred.
In particular, no attaches will be deferred after startup is complete.
This seems wrong.
To implement what seems to be stated in the commit message an "or"
needs to be used so that non-recovery daemon attaches are deferred
either when in recovery or before startup is complete. Making this
change highlights that attaches need to be allowed during the
"startup" event because this is when smbd is started.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14294
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit c6c89495fbe9b6f238d10a538eccc92b937a69de)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aefd9b2e68ddf6ec37b9db173796a7cc2941dbbe">aefd9b2e</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-03-30T08:06:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Remove unused old client database functions
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14294
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit fc23cd1b9cdd1d70067491614b16e616291e8ff2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7c1f9bde013d40c736745a81c845a2d1e7a37171">7c1f9bde</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-03-30T08:06:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-protocol: Add control flag CTDB_CTRL_FLAG_ATTACH_RECOVERY
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14294
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 17ed0425904a98624284d351ab7617b3e02c0f7b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/05c2d86d0757653b777d0518f96beabc91bc7993">05c2d86d</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-03-30T08:06:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recovery: Use CTDB_CTRL_FLAG_ATTACH_RECOVERY to attach during recovery
ctdb_ctrl_createdb() is only called by the recovery daemon, so this is
a safe, temporary change. This is temporary because
ctdb_ctrl_createdb(), create_missing_remote_databases() and
create_missing_local_databases() will all go away soon.
Note that this doesn't cause a change in behaviour. The main daemon
will still only defer attaches from non-recoverd processes during
recovery.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14294
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 98e3d0db2bc5f33217e26fab1dfb4bb91eae534f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1e57e5c4e62e18390b08efd026eac8fddca4e619">1e57e5c4</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-03-30T08:06:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Respect CTDB_CTRL_FLAG_ATTACH_RECOVERY when attaching databases
This is currently only set by the recovery daemon when it attaches
missing databases, so there is no obvious behaviour change. However,
attaching missing databases can now be moved to the recovery helper as
long as it sets this flag.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14294
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 7e5a8a4884ea87bb985fe0e2b65ff130fc2ba8aa)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/808c7aabcbda0272e666037b3f715facdb48fa76">808c7aab</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-03-30T08:06:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recovery: Replace use of ctdb_dbid_map with local db_list
This will be used to build a merged list of databases from all nodes,
allowing the recovery helper to create missing databases.
It would be possible to also include the db_name field in this
structure but that would cause a lot of churn. This field is used
locally in the recovery of each database so can continue to live in
the relevant state structure(s).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14294
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 4c0b9c36050a0ed8a180d4ac1853224089528e8e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/58f835828213ac5bec4e459e3f59b0bcfdc2fe31">58f83582</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-03-30T08:06:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recovery: GET_DBMAP from all nodes
This builds a complete list of databases across the cluster so it can
be used to create databases on the nodes where they are missing.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14294
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit c6f74e590f602e2ed38fe293468770a5e669aefa)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7131081967600ad8fa332e4004b8d93859a35008">71310819</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-03-30T08:06:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recovery: Pass db structure for each database recovery
Instead of db_id and db_flags.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14294
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 1bdfeb3fdc06947a607957ab3d114f97bad5d7d7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/63db9658e1e71146ff6f06619b26d2ad3c7ebfbb">63db9658</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-03-30T08:06:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recovery: Fetch database name from all nodes where it is attached
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14294
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit e6e63f8fb8194634135bf34cda18f6cc8ff69a7c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c8354a9cb79c7c961bc29772e864e08edd3731f6">c8354a9c</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-03-30T08:06:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recovery: Create database on nodes where it is missing
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14294
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 76a8174279f42486b36cc41d5831d4e6613f172e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2049792ff784f7943f04a62c6614a703cfa765fb">2049792f</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-03-30T08:06:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recovery: Remove old code for creating missing databases
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14294
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 3a66d181b6f6199fca362fcb0aa06513645b589d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/60dc3c3282d0d677ed1d441add0b4003749835dd">60dc3c32</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-03-30T08:06:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Remove more unused old client database functions
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14294
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 052f1bdb9cf78f53f584edd32f81ae8e01e8e86e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b1b41b88a5ee6d5f06f9c1f722f5288f1af61203">b1b41b88</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-03-30T08:06:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-daemon: Don't allow attach from recovery if recovery is not active
Neither the recovery daemon nor the recovery helper should attach
databases outside of the recovery process.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14294
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 147afe77de372ddb9c180228d6fe1b04cca4610f)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2dabb4c5cddc674c6a94ceaa42783cfef488cd4d">2dabb4c5</a></strong>
<div>
<span>by Martin Schwenke</span>
<i>at 2020-03-30T09:36:01+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb-recoverd: Avoid dereferencing NULL rec->nodemap
Inside the nested event loop in ctdb_ctrl_getnodemap(), various
asynchronous handlers may dereference rec->nodemap, which will be
NULL.
One example is lost_reclock_handler(), which causes rec->nodemap to be
unconditionally dereferenced in list_of_nodes() via this call chain:
list_of_nodes()
list_of_active_nodes()
set_recovery_mode()
force_election()
lost_reclock_handler()
Instead of attempting to trace all of the cases, just avoid leaving
rec->nodemap set to NULL. Attempting to use an old value is generally
harmless, especially since it will be the same as the new value in
most cases.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14324
Reported-by: Volker Lendecke <vl@samba.org>
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Tue Mar 24 01:22:45 UTC 2020 on sn-devel-184
(cherry picked from commit 716f52f68b248ae7cfd66479b3fc678c4a0d8b38)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Mon Mar 30 09:36:01 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/784e4266787ae734eebabe013a96b49da5ee5c5d">784e4266</a></strong>
<div>
<span>by Günther Deschner</span>
<i>at 2020-04-01T08:51:15+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">nsswitch: fix use-after-free causing segfault in _pam_delete_cred
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14327
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Mon Mar 30 13:01:20 UTC 2020 on sn-devel-184
(cherry picked from commit 047b0d8ab534c7a10a8572fd9f21e2456fd30710)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Wed Apr 1 08:51:15 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b82cec527084f826670cb66d0ab3dbae7783dae7">b82cec52</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2020-04-03T12:24:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/utils: Fix double free error with smbtree
==3632==
WORKGROUP
\\ATP
\\ATP\IPC$ IPC Service ()
==3632== Invalid read of size 8
==3632== at 0x773C926: poptResetContext (in /usr/lib64/libpopt.so.0.0.0)
==3632== by 0x773E5DD: poptFreeContext (in /usr/lib64/libpopt.so.0.0.0)
==3632== by 0x10A8BC: main (smbtree.c:354)
==3632== Address 0x16085e00 is 640 bytes inside a block of size 784 free'd
==3632== at 0x4C2F1AD: free (vg_replace_malloc.c:530)
==3632== by 0x773E6F7: poptFreeContext (in /usr/lib64/libpopt.so.0.0.0)
==3632== by 0x10A84B: main (smbtree.c:342)
==3632== Block was alloc'd at
==3632== at 0x4C2FE45: calloc (vg_replace_malloc.c:711)
==3632== by 0x773C79A: poptGetContext (in /usr/lib64/libpopt.so.0.0.0)
==3632== by 0x10A829: main (smbtree.c:339)
==3632==
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14332
Signed-off-by: Noel Power <npower@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Wed Apr 1 18:51:43 UTC 2020 on sn-devel-184
(cherry picked from commit 24b03fd28ed19cea8f875f96b3e300f808dfc4ae)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Fri Apr 3 12:24:36 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/21095de9d96017d49047cef63b00525ebedcf8b6">21095de9</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-04-06T10:03:43+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.12.1.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dcaa10c6e37f0cdccb70f45f1e579f5a65bbc0a4">dcaa10c6</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-04-07T08:37:55+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.12.1 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a3157b958bfd9f1f77014fcfc6ca5ad1f38b0fbf">a3157b95</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-04-07T08:38:40+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.12.2...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/be695ae6e0e6f428771f80ac4a8d389db31e4598">be695ae6</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-04-07T08:12:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture: fix a timestamps test to work on ext filesystem
ext filesystem has a time_t limit of 15032385535 (0x0x37fffffff). From
Documentation/filesystems/ext4/inodes.rst:
If the inode structure size ``sb->s_inode_size`` is larger than 128 bytes and
the ``i_inode_extra`` field is large enough to encompass the respective
``i_[cma]time_extra`` field, the ctime, atime, and mtime inode fields are
widened to 64 bits. Within this “extra” 32-bit field, the lower two bits are
used to extend the 32-bit seconds field to be 34 bit wide; the upper 30 bits
are used to provide nanosecond timestamp accuracy. Therefore, timestamps
should not overflow until May 2446. ...
Changing the test to use the value 0x37fffffff instead of 100000000000 allows
running the test locally on ext filesytems.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 73fedf014bbe02a408360d48e35bce4a6dbc9c36)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2d21f3c4b387e745b65bfc77bb003c7d3e23bb10">2d21f3c4</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-04-07T08:12:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture/smb2: mtime update logic with 2 handles: write io on handle 1, then set mtime on handle 2
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14150
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 47508c5ecf0713ef404d5226499a4269651dc020)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6c7b69c7f2bfc4da1353df320e125a46b6e88621">6c7b69c7</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-04-07T08:12:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture/smb2: add a test verifying a flush flushes a pending writetime update
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14150
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit c63d6c9e256cdf6a3620373ef0f595e61d43fa97)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f79e39158db0f11d770bf2269a284acb3dee22aa">f79e3915</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-04-07T08:12:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture/smb2: add a test verifying a setinfo(basicinfo) flushes a pending writetime update
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14150
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 4e3c2afbd6f12159252405f6efc6528fa9345f08)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8d05e789320d5f091ec4216c707845f67197a692">8d05e789</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-04-07T08:12:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: always flush pending write time update when setting filesize
We need to flush a pending write time update even when we're setting the
filesize to current filesize.
Note that we're already doing it this way in the relevant places listed my
dochelp@MS in
https://lists.samba.org/archive/cifs-protocol/2019-December/003364.html
Cleanup (= Close)
SetBasicInfo
SetAllocationInfo
SetEndOfFileInfo
SetValidDataLengthInfo
Flush
FSCTL_SET_ENCRYPTION
FSCTL_OFFLOAD_WRITE
Cleanup (= Close):
Already implemented by update_write_time_on_close() and friends.
SetBasicInfo:
Currently doesn't flush pending updates. Fixed by a subsequent commit.
SetAllocationInfo:
smb_set_file_allocation_info() when setting a file's allocation size.
SetEndOfFileInfo:
Currently doesn't flush pending updates. Fixed by a subsequent commit.
SetValidDataLengthInfo:
Not implemented, returns NT_STATUS_NOT_SUPPORTED which seems wrong btw, as
SetValidDataLengthInfo IS listed in MS-SMB2 2.2.39.
Flush:
Currently doesn't flush pending updates. Fixed by subsequent commit.
FSCTL_SET_ENCRYPTION:
Windows 2016 doesn't flush a pending writetime update, verified with a
smbtorture test.
FSCTL_OFFLOAD_WRITE:
NT_STATUS_NOT_IMPLEMENTED
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14150
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 79d7d6b9d01b8547f16b74a62926d0b471f18c39)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a8b9462030296a3dff2c3bb36db5c41943d1162f">a8b94620</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-04-07T08:12:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: flush pending writetime update when flushing file
Cf the explanations in the previous commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14150
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit d99d5bf2c6d0a818ef2f3920e0c93fac38761c36)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f6497e769ac3ff38b23758ec90536c823febf9ee">f6497e76</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-04-07T08:12:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: flush pending writetime update when setting timestamps file
Cf the explanations in the previous commits.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14150
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 7b90fe69a865ae8648b6548eabbcf2fa8237ebd8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8935fe7e0341008391dec06d2896f343f2e15e67">8935fe7e</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-04-07T08:12:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture/smb2: Windows 2019 15 ms timestamp resolution
This test demonstrates that Windows has a timestamp resolution of ~15ms.
When a smaller amount of time than that has passed between modifying operations
on a file, it's not necessarily detectable on a Windows 2019 server that
implements immediate timestamp updates (no delayed magic).
Note that this test relies on a low latency SMB connection. Even with a low
latency connection of eg 1m there's a chance of 1/15 that the first part of the
test expecting no timestamp change fails as the writetime is updated.
Due to this timing dependency this test is skipped in Samba CI, but it is
preserved here for future SMB2 timestamps behaviour archealogists.
See also: https://lists.samba.org/archive/cifs-protocol/2019-December/003358.html
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 6f7d1d8a37bfb877b3f07423cbcffd15710e8d08)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/24ab1b46af32c3549fe4a52fde03007044bdca23">24ab1b46</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-04-07T08:12:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: avoid double chdir() in chdir_current_service()
Since 8e81090789e4cc3ba9e5aa792d4e52971909c894 we're doing chdir() twice, first
into conn->connectpath, then into conn->origpath.
Before commit 8e81090789e4cc3ba9e5aa792d4e52971909c894 if
chdir(conn->connectpath) succeeded, we wouldn't do the second chdir().
While at it, simplify the logging logic: if chdir() fails in this core function,
just always log is as error including the unix token.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14256
RN: smbd does a chdir() twice per request
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Feb 6 11:44:07 UTC 2020 on sn-devel-184
(cherry picked from commit f705629a171c1411131164f3adff36175154c093)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7c6a03547364ad04a023c79e6014321200033bb7">7c6a0354</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_aio_pthread. Fix leak of state struct on error.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit a1e247c3ba579ecc6ee03f5aad9679ed79fac5ac)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/addd33f6880e5c785e2f92af3b80118abfc5baf6">addd33f6</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:33+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_aio_pthread: Replace state destructor with explicitly called teardown function.
This will allow repurposing a real destructor to allow
connections structs to be freed whilst the aio open
request is in flight.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 8db831a318cd4a10ec9c1d629ebff4ca35b8acfe)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/35583c7b80c7a5f2c82bb0579058fde2a190028d">35583c7b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_aio_pthread. Move xconn into state struct (opd).
We will need this in future to cause a pending open to
be rescheduled after the connection struct we're using
has been shut down with an aio open in flight. This will
allow a correct error reply to an awaiting client.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit ddb9038fe776b1d8239e563a4c9a70b4097645f3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ef91325978d38adc2ad05d095939fdec424c77e1">ef913259</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_aio_pthread: Add a talloc context parameter to create_private_open_data().
Pass in NULL for now so no behavior change.
We will be changing this from NULL to fsp->conn in a later commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit e566066605981549b670a5392683fbd81ce93d18)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bb646d6b5b8b08635720cf296de44b8e1bc4da42">bb646d6b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: vfs_aio_pthread: Make aio opens safe against connection teardown.
Allocate state off fsp->conn, not NULL, and add a destructor
that catches deallocation of conn which happens
on connection shutdown or force close.
Note - We don't allocate off fsp as the passed in
fsp will get freed once we return EINPROGRESS/NT_STATUS_MORE_PROCESSING_REQUIRED.
A new fsp pointer gets allocated on every re-run of the
open code path.
The destructor allows us to NULL out the saved conn struct pointer
when conn is deallocated so we know not to access deallocated memory.
This matches the async teardown code changes for bug #14301
in pread/pwrite/fsync vfs_default.c and vfs_glusterfs.c
state is still correctly deallocated in all code
paths so no memory leaks.
This allows us to safely complete when the openat()
returns and then return the error NT_STATUS_NETWORK_NAME_DELETED
to the client open request.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 6b567e0c138d1cf2bcf58c84872ed2b0e89d628d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8a6dc998ec6da2bfa19aea8b4060f27a1d2f11b9">8a6dc998</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: In aio_del_req_from_fsp() talloc_free(fsp->aio_requests[]) when fsp->num_aio_requests reaches zero.
The add code in aio_add_req_to_fsp() re-tallocs
this array on demand, and talloc freeing it here
allows it to be used as the parent for a tevent
wait queue, so callers can get notified when
all outstanding aio on an fsp is finished.
We'll deal with any performance issues in
the next commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 0c952bba1edf7c8173d05ccdc6fdaa7232d2c6aa)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1ad202440c5469a1855af416575bd0593d1a1344">1ad20244</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Now we free fsp->aio_requests when it gets zero entries, talloc in chunks of 10 instead of 1.
Prevents incremental +1 tallocs, and the original
idea of this array was that it wasn't freed for
io efficiency reasons. Add paranoia integer wrap
protection also.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit b90bc0f28918133badbf6810d5e298fc326bd1aa)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/49d50bedb8f683b3e620f81ddacacd5d40ab50b9">49d50bed</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: In async SMB1 reply_close() set fsp->closing = true, as we already do in SMB2 async close.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit b7d09b30ad14d51bbcbe368a11348754121f6ff8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/efc902b29eee6085a5ea7862cf04bf737c7b5b87">efc902b2</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Every place we check fsp->deferred_close, also check for fsp->closing.
Eventually this will allow us to remove fsp->deferred_close
from the fsp struct (and also source3/lib/tevent_wait.[ch]).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 4287ea138e82103cce0a939e504f9810636b4747)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/044cf379e541b574a2782945a607578e9687c279">044cf379</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Don't allow force disconnect of a connection already being disconnected.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit ac800ca6bcb43c74a1a6ef508b900e2e6cb532dc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/97e136880efb0d5e4d579300f137599287e9792b">97e13688</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:34+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Add async internals of conn_force_tdis().
Commented out so it can be seen complete as
a diff. The next commit will replace the old
synchronous conn_force_tdis() code with the
new async code.
Uses a wait_queue to cause the force close
requests to stay pending until all outstanding
aio is finished on all file handles opened
on the connection.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 4f9e0459cd06f0332083a4a465f49b5f258838fa)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b22e8c8c411cc34c1d0a4304cb50f6032fcbd861">b22e8c8c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Replace synchronous conn_force_tdis() with the async version.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 7891302ab8eeba8261b92171a4d429e2f538b89a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/83eace543fad81b19a807c1da6490d508ed9798e">83eace54</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Add async internals of reply_tdis().
Waits until all aio requests on all fsp's under this
conn struct are finished before returning to the client.
Charges the profile time in the done function. Not strictly
correct but better than the other SMB1 async code that
double-charges profiling in both send and done at the
moment.
Done this way (commented out) so it is a clean
diff and it's clear what is being added.
A later commit will remove the old synchronous version.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 86cc67d5a7de0a81131b11447dad57b2681d8e01)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/01450dece2162d13a79cfeaa30220e17acf6fe38">01450dec</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: In reply_tdis(), replace req -> smb1req.
Minimises the diff in the next commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit ca4521f1dd97bc5a05e381c652b05ae1eb8bd29b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c613e113dbe176e1bfc1e358cc7ba1e5d23af135">c613e113</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: reply_tdis() Update to modern coding standards.
Minimizes the diff in the next commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 71725f1c4adaa04ef04c0dd400c49399952ef5fa)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/999a14c5cb75006fee4ccd162b073347ad8456fd">999a14c5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove old synchronous SMB1 reply_tdis().
SMB1 tree disconnect is now fully async.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 7613998e10c5f13c896667257fdef33824a45d2a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f6bb69d9215390ab2fd6ec689cb4afacf7e902bd">f6bb69d9</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Add async internals of reply_ulogoffX.
Waits until all aio requests on all fsp's owned by this
vuid are finished before returning to the client.
Charges the profile time in the done function. Not strictly
correct but better than the other SMB1 async code that
double-charges profiling in both send and done at the
moment.
Done this way (commented out) so it is a clean
diff and it's clear what is being added.
A later commit will remove the old synchronous version.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 4dd3012cb1b5e000ccf68d2601dbdbcb7ff538b5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b619e2042a436e40ee445db102701c9dc9515492">b619e204</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: In reply_ulogoffX(), replace req -> smb1req.
Minimises the diff in later commits.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 5c073aa01b304f54a0039d9cd9dc74123191eb4b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aa58b41b8b91f8b80ca505980d6809ff67ddbee9">aa58b41b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: reply_ulogoffX() Update to modern coding standards.
Minimizes the diff in the later commits.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 9cda76ad29db0cfbffa3dbb0764ec5dda24490f9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/83b4482828bba83a4b28994e59ed9aa7aa188e83">83b44828</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:35+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove old synchronous SMB1 reply_ulogoffX().
SMB1 user logoff is now fully async.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 446b64ca66591d8ae5b4bf1aabdd46a1e8cb1c1c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2b32fdde6929bcac49e9168a64c47a6bb31cd67b">2b32fdde</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Add async internals of reply_exit().
Waits until all aio requests on all fsp's owned by this
vuid are finished before returning to the client.
Charges the profile time in the done function. Not strictly
correct but better than the other SMB1 async code that
double-charges profiling in both send and done at the
moment.
Done this way (commented out) so it is a clean
diff and it's clear what is being added.
A later commit will remove the old synchronous version.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 8f58feab58afbc7aa214fac2a1728dda68303c6b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/824bc7f7f5b8ce13e82a79d75b2550e239f60445">824bc7f7</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove old synchronous SMB1 reply_exit().
SMB1 exit is now fully async.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 1de0daa715f3324e3620ae8152b7fbaeb40ee9d9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/680157b533808b3a09f31e703805c830e6d63349">680157b5</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Remove file_close_pid().
The old synchronous reply_exit() was the only user.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 584933439c70af3d2fd047e62a3456c1c2eca45e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a108dece4fb11c36af321f5673097e76433c28ad">a108dece</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: enforce AIO requests draining
Assert we have no aio on a close.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Combined squash of commits:
(cherry picked from commit 410e7599bd2ae9b35429f60a529bb7c4aa88df25)
(cherry picked from commit acb0b01761330864a23932f643f7ad4e3d374634)
(cherry picked from commit f94cd10a211e2eae966ba4bd26921556bbe513fc)
(cherry picked from commit 0ae4f368c6c8d2c8c7aa34069007a984055df0da)
(cherry picked from commit 86dd5a080969e14ab0d131d8cb1054ec624a41ba)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/58723f78af08dac2959e14705f0023f5a6517a32">58723f78</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-07T08:12:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: tests: Add samba3.blackbox.force-close-share
Checks server stays up whilst writing to a force closed share.
Uses existing aio_delay_inject share to delay writes while
we force close the share.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sun Mar 8 19:34:14 UTC 2020 on sn-devel-184
(cherry picked from commit bb22be08b077b7d5911ccdeb1012f4dea85647e5)
(cherry picked from commit 566658d914176c41942e3c6aba404ae369aeb123)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bd89299d2f7ba27f65b901bbbab27677751d0d84">bd89299d</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-04-07T08:12:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: remove stat call from mark_file_modified()
This stat dates back to d03453864ab1bc5fd3b4a3abaf96176a006c102b where the call
to trigger_write_time_update() had been to the file IO codepath. It was present
there for other reasons: to setup the write-cache based on the file's size.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14320
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 2c19d27113036d607850f370bb9afd62856d671e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/92b0555fcd78d062fd993eb35441595f4aa96d96">92b0555f</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-04-07T08:12:36+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture/smb2: delayed timestamp update test: single write
Verify close only updates write-time when a delayed update is actually pending.
This scenario is not covered by basic.delaywrite.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14320
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 58fa7b4fd7b53d3100459a0c9c7ef4ca7481b58a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f09cb423ec6b66313a92c12543412aa0c4bf5596">f09cb423</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-04-07T08:12:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">torture/smb2: delayed timestamp updates test: more then one write
Verify a close updates the write-time for subsequent writes after an initial
write started the delayed update logic.
This covers a scenario that will become relevant with the two subsequent
commits. The next commit:
smbd: let mark_file_modified() always call trigger_write_time_update()
ensures that trigger_write_time_update() is not only called for the first write
on a file. Without that preaparatory change, the second commit:
smbd: let delayed update handler also update on-disk timestamps
alone would cause this test to fail.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14320
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 60aecca9a727555847aa1412415c5bbd927df4ff)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6d3279d01d9e75514fe8b7f070b32ed5b8d9e7c5">6d3279d0</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-04-07T08:12:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: let mark_file_modified() always call trigger_write_time_update()
Preperatory change: the next commit will reset fsp->update_write_time_on_close
in the event handler, so this change ensures it gets set again for any
subsequent write.
This will NOT always result in a write-time update because
trigger_write_time_update() has its own only-once logic using the internal
variable fsp->update_write_time_triggered.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14320
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 53de2da7acfc24513082190502d93306c12b7434)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d6d93329b4c2eff0c041bfd11a471c3512709594">d6d93329</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-04-07T08:12:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: let delayed update handler also update on-disk timestamps
Let delayed update handler also update on-disk timestamps by calling
trigger_write_time_update_immediate().
trigger_write_time_update_immediate() sets fsp->update_write_time_on_close to
false which prevents updating the write-time on close if there was ever only one
write to the file.
Besides resetting fsp->update_write_time_on_close and setting the on-disk timestamps
trigger_write_time_update_immediate() takes the same steps as the removed code.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14320
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Mar 19 03:05:40 UTC 2020 on sn-devel-184
(cherry picked from commit 81c1a14e3271aeed7ed4fe6311171b19ba963555)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dacbd35a11bef4c59df359e2ded01b2e28b02bbb">dacbd35a</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2020-04-07T08:12:37+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: Fix ads_get_upn()
This adds the userPrincipalName to ads_find_machine_acct() which
fetches the data for us.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14336
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit ec69752cb963ae850568d3f4905d2941e485627e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d0ca4d173cd2153c7e2a25da22d712e89493c4db">d0ca4d17</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2020-04-07T09:36:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testprogs: Add 'net ads join createupn' test also verifying the keytab
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14336
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Apr 6 19:09:53 UTC 2020 on sn-devel-184
(cherry picked from commit c4be195da2845be4f64e47883e3c911dedd90e48)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Tue Apr 7 09:36:45 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6e3fd37ab243858e6494a37b3c805bff855ff5a7">6e3fd37a</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2020-04-15T11:56:08+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Adapt sign_authdata in our KDB module for krb5 v1.18
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14342
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/25fefdb75f50716e6ad812fd900092fb56a18647">25fefdb7</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2020-04-15T11:56:08+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix uxsuccess test with new MIT krb5 library 1.18
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14155
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14342
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/958807109845313c35a0c6949b33ffbc09eeba59">95880710</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2020-04-15T11:56:08+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Sign and verify PAC with ticket principal instead of canon principal
With MIT library 1.18 the KDC no longer set
KRB5_KDB_FLAG_CANONICALIZE for enterprise principals which allows
us to not canonicalize them (like in Windows / Heimdal).
However, it now breaks the PAC signature verification as it was
wrongly done using canonical client rather than ticket client name.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14342
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8bdcac936ead95295f2203eb22effb10c07591c1">8bdcac93</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2020-04-15T11:56:08+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Set KRB5RCACHETYPE to none for selftest
This is required that out tests work with MIT KRB5 1.18.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14342
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8e3484c163c07a69425edaa5790d2e33f406c993">8e3484c1</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2020-04-15T11:56:08+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">mit-kdc: Explicitly reject S4U requests
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14342
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Isaac Boukris <iboukris@samba.org>
Autobuild-Date(master): Tue Mar 10 14:46:04 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8c537c8a40261c08742e76e6de9a1d08b6618ed3">8c537c8a</a></strong>
<div>
<span>by Noel Power</span>
<i>at 2020-04-15T13:20:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/librpc/crypto: Fix double free with unresolved credential cache
We free gse_ctx->k5ctx but then free it again in the
talloc dtor. This patch just lets the talloc dtor handle
things and removes the extra krb5_free_context
Failed to resolve credential cache 'DIR:/run/user/1000/krb5cc'! (No credentials cache found)
==30762== Invalid read of size 8
==30762== at 0x108100F4: k5_os_free_context (in /usr/lib64/libkrb5.so.3.3)
==30762== by 0x107EA661: krb5_free_context (in /usr/lib64/libkrb5.so.3.3)
==30762== by 0x7945D2E: gse_context_destructor (gse.c:84)
==30762== by 0x645FB49: _tc_free_internal (talloc.c:1157)
==30762== by 0x645FEC5: _talloc_free_internal (talloc.c:1247)
==30762== by 0x646118D: _talloc_free (talloc.c:1789)
==30762== by 0x79462E4: gse_context_init (gse.c:241)
==30762== by 0x794636E: gse_init_client (gse.c:268)
==30762== by 0x7947602: gensec_gse_client_start (gse.c:786)
==30762== by 0xBC87A3A: gensec_start_mech (gensec_start.c:743)
==30762== by 0xBC87BC6: gensec_start_mech_by_ops (gensec_start.c:774)
==30762== by 0xBC8167F: gensec_spnego_client_negTokenInit_step (spnego.c:633)
==30762== Address 0x17259928 is 40 bytes inside a block of size 496 free'd
==30762== at 0x4C2F50B: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==30762== by 0x79462CA: gse_context_init (gse.c:238)
==30762== by 0x794636E: gse_init_client (gse.c:268)
==30762== by 0x7947602: gensec_gse_client_start (gse.c:786)
==30762== by 0xBC87A3A: gensec_start_mech (gensec_start.c:743)
==30762== by 0xBC87BC6: gensec_start_mech_by_ops (gensec_start.c:774)
==30762== by 0xBC8167F: gensec_spnego_client_negTokenInit_step (spnego.c:633)
==30762== by 0xBC813E2: gensec_spnego_client_negTokenInit_start (spnego.c:537)
==30762== by 0xBC84084: gensec_spnego_update_pre (spnego.c:1943)
==30762== by 0xBC83AE5: gensec_spnego_update_send (spnego.c:1741)
==30762== by 0xBC85622: gensec_update_send (gensec.c:449)
==30762== by 0x551BFD0: cli_session_setup_gensec_local_next (cliconnect.c:997)
==30762== Block was alloc'd at
==30762== at 0x4C306B5: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==30762== by 0x107EA7AE: krb5_init_context_profile (in /usr/lib64/libkrb5.so.3.3)
==30762== by 0xB853215: smb_krb5_init_context_common (krb5_samba.c:3597)
==30762== by 0x794615B: gse_context_init (gse.c:209)
==30762== by 0x794636E: gse_init_client (gse.c:268)
==30762== by 0x7947602: gensec_gse_client_start (gse.c:786)
==30762== by 0xBC87A3A: gensec_start_mech (gensec_start.c:743)
==30762== by 0xBC87BC6: gensec_start_mech_by_ops (gensec_start.c:774)
==30762== by 0xBC8167F: gensec_spnego_client_negTokenInit_step (spnego.c:633)
==30762== by 0xBC813E2: gensec_spnego_client_negTokenInit_start (spnego.c:537)
==30762== by 0xBC84084: gensec_spnego_update_pre (spnego.c:1943)
==30762== by 0xBC83AE5: gensec_spnego_update_send (spnego.c:1741)
==30762==
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14344
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Tue Apr 14 22:55:51 UTC 2020 on sn-devel-184
(cherry picked from commit 34f8ab774d1484b0e60dbdec8ad2a1607ad92122)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Wed Apr 15 13:20:28 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5ecac7b6dd54a4ad89b147bce816f024221d4635">5ecac7b6</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-17T08:55:08+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: full_audit. Add missing fcntl entry in vfs_op_names[] array.
Found by yannick@in2ip.nl.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14343
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 977d3c7bab3319725abc418839d581489fd9bbe9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/790bf2ab1988dad118c845c5f477d1f3701d0c7a">790bf2ab</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-04-17T10:19:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: Add cmocka test for vfs_full_audit to make sure all arrays are correct.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14343
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(Back-ported from commit 5e987e2f40e7698de489696d795ebe26b7e75c9b)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Fri Apr 17 10:19:13 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/21f64af155b5f5901758888f4926ab4f57fe8a04">21f64af1</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-04-21T12:44:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ctdb: Fix a memleak
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14348
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Apr 17 08:32:35 UTC 2020 on sn-devel-184
(cherry picked from commit ad4b53f2d95de3d3609f3a23d96602f3dd516705)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Tue Apr 21 12:44:16 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/feb24fc1e51e6a465350b4b010f35a6522c2f283">feb24fc1</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-04-22T12:50:42+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.12.2...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
(cherry picked from commit a3157b958bfd9f1f77014fcfc6ca5ad1f38b0fbf)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8e597aa1b9b1fa3483250907579ec4a9dea3c4c9">8e597aa1</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-04-22T12:50:42+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10700: dsdb: Add test for ASQ and ASQ in combination with paged_results
Thanks to Andrei Popa <andrei.popa@next-gen.ro> for finding,
reporting and working with us to diagnose this issue!
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14331
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b824444544f8b970ed93c914cb96de3b54c6e282">b8244445</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-04-22T12:50:42+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10700: ldb: Always use ldb_next_request() in ASQ module
We want to keep going down the module stack, and not start from the top again.
ASQ is above the ACL modules, but below paged_results and we do not wish to
re-trigger that work.
Thanks to Andrei Popa <andrei.popa@next-gen.ro> for finding,
reporting and working with us to diagnose this issue!
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14331
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fb3e51020ab589cf76306b36548eda8a2de8f6ce">fb3e5102</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-04-22T12:50:42+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10700: dsdb: Do not permit the ASQ control for the GUID search in paged_results
ASQ is a very strange control and a BASE search can return multiple results
that are NOT the requested DN, but the DNs pointed to by it!
Thanks to Andrei Popa <andrei.popa@next-gen.ro> for finding,
reporting and working with us to diagnose this issue!
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14331
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/fecb05c8980100e32ab5812cc97d15edd5b83b50">fecb05c8</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-04-22T12:50:42+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10700: ldb: Bump version up to 2.1.2.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14331
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/109b128ec1db7ffc90c43c075d86b1c3de344cba">109b128e</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-04-22T12:50:42+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10704: lib util asn1: Add ASN.1 max tree depth
Add maximum parse tree depth to the call to asn1_init, which will be
used to limit the depth of the ASN.1 parse tree.
Credit to OSS-Fuzz
REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20454
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14334
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/74986c179ea66d1cefda3ff6bb6338b618da451f">74986c17</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-04-22T12:50:42+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10704: libcli ldap: test recursion depth in ldap_decode_filter_tree
Add tests to check that ASN.1 ldap requests with deeply nested elements
are rejected. Previously there was no check on the on the depth of
nesting and excessive nesting could cause a stack overflow.
Credit to OSS-Fuzz
REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20454
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14334
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/16da9c6e3d87d11e358441804dc7ff842eb5a9e7">16da9c6e</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-04-22T12:50:42+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10704: lib util asn1: Check parse tree depth
Check the current depth of the parse tree and reject the input if the
depth exceeds that passed to asn1_init
Credit to OSS-Fuzz
REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20454
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14334
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/4aeb07ef49e4e8734fc5f5cd092bbf165e9cc9f3">4aeb07ef</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-04-22T12:50:42+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10704: ldapserver tests: Limit search request sizes
Add tests to ensure that overly long (> 256000 bytes) LDAP search
requests are rejected.
Credit to OSS-Fuzz
REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20454
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14334
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/48a3bdd7703ad3952f45e04c4f0a8d289ae74190">48a3bdd7</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-04-22T12:50:42+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10704: smb.conf: Add max ldap request sizes
Add two new smb.conf parameters to control the maximum permitted ldap
request size.
Adds:
ldap max anonymous request size default 250Kb
ldap max authenticated request size default 16Mb
Credit to OSS-Fuzz
REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20454
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14334
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8729c05b1cd6a63d9f8e163b2e438007db3eb4f8">8729c05b</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-04-22T12:50:42+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10704: S4 ldap server: Limit request sizes
Check the size of authenticated and anonymous ldap requests and reject
them if they exceed the limits in smb.conf
Credit to OSS-Fuzz
REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20454
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14334
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/db78f2667eb51c106c66edebcf66914ea580bfc6">db78f266</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-04-22T12:50:42+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10704: libcli ldap_message: Add search size limits to ldap_decode
Add search request size limits to ldap_decode calls.
The ldap server uses the smb.conf variable
"ldap max search request size" which defaults to 250Kb.
For cldap the limit is hard coded as 4096.
Credit to OSS-Fuzz
REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20454
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14334
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/71b92c9554d2e92281c6ce7f0340def2e6c0623c">71b92c95</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-04-22T12:50:42+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10704 libcli ldap: Check search request lengths.
Check the search request lengths against the limits passed to
ldap_decode.
Credit to OSS-Fuzz
REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20454
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14334
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/51b4bf0c873a790698fc1c4ee55bc7a1e8cfa82b">51b4bf0c</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-04-22T12:53:26+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.12.2.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ee9600d8a8f244c9417f0819ee17b21ea84ed94a">ee9600d8</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-04-22T12:55:18+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.12.2 release.
o CVE-2020-10700: Use-after-free in Samba AD DC LDAP Server with ASQ
o CVE-2020-10704: LDAP Denial of Service (stack overflow) in Samba AD DC
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/11620a07a898146384f1473206791ebcfe09dfa5">11620a07</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-04-28T13:48:23+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge tag 'samba-4.12.2' into v4-12-test
samba: tag release samba-4.12.2
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/af4d2a38fcb92ae58e4310acbfe43ab9548d1fa5">af4d2a38</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-04-28T13:48:51+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.12.3.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d3eb8ef981ee7090bf4bc603fd0b3ad358e89a6d">d3eb8ef9</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-05-04T11:36:07+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Don't try to find posix stat info in SMBC_getatr()
This wrongly used "frame" instead of "fname", which can never have
worked. A first attempt to fix in 51551e0d53fa6 caused a few followup
patches in an attempt to clean up the test failures 51551e0d53fa6
introduced. They were reverted after a few discussions. So rather than
changing behaviour, just remove the code that introduced the valgrind
error again.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Mar 20 05:06:07 UTC 2020 on sn-devel-184
(cherry picked from commit 39c910fd9cba3caf7414274b678b9eee33d7e20b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d2e0eafa92b7d4e12551bf46a8ee77438403cec6">d2e0eafa</a></strong>
<div>
<span>by Anoop C S</span>
<i>at 2020-05-04T11:36:07+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">dbwrap_watch: Set rec->value_valid while returning nested share_mode_do_locked()
As reported on samba-technical by Rouven WEILER <Rouven_Weiler@gmx.net>:
https://lists.samba.org/archive/samba-technical/2020-April/135116.html
Following backtrace was observed with vfs_fruit for time machine backup:
[2020/04/10 08:00:38.107917, 0] ../../lib/dbwrap/dbwrap.c:82(dbwrap_record_get_value)
PANIC: assert failed at ../../lib/dbwrap/dbwrap.c(82): rec->value_valid
[2020/04/10 08:00:38.108499, 0] ../../source3/lib/util.c:830(smb_panic_s3)
PANIC (pid 3427): assert failed: rec->value_valid
[2020/04/10 08:00:38.109541, 0] ../../lib/util/fault.c:265(log_stack_trace)
BACKTRACE: 37 stack frames:
#0 /usr/lib/samba/amd64/libsamba-util.so.0.0.1'log_stack_trace+0x26 [0xfffffd7fee51de66]
#1 /usr/lib/samba/amd64/libsmbconf.so.0'smb_panic_s3+0x26 [0xfffffd7fedf5a596]
#2 /usr/lib/samba/amd64/libsamba-util.so.0.0.1'smb_panic+0x1f [0xfffffd7fee51df3f]
#3 /usr/lib/samba/private/amd64/libdbwrap-samba4.so'dbwrap_record_get_value+0x2a [0xfffffd7feccb627a]
#4 /usr/lib/samba/private/amd64/libsmbd-base-samba4.so'get_share_mode_lock+0x109 [0xfffffd7fee7195c9]
#5 /usr/lib/samba/private/amd64/libsmbd-base-samba4.so'smbd_contend_level2_oplocks_begin+0xa1 [0xfffffd7fee7f7761]
#6 /usr/lib/samba/private/amd64/libsmbd-base-samba4.so'brl_lock+0x635 [0xfffffd7fee710f45]
#7 /usr/lib/samba/private/amd64/libsmbd-base-samba4.so'do_lock_fn+0xa4 [0xfffffd7fee70d534]
#8 /usr/lib/samba/private/amd64/libsmbd-base-samba4.so'share_mode_do_locked_fn+0x86 [0xfffffd7fee7174b6]
#9 /usr/lib/samba/amd64/libsmbconf.so.0'dbwrap_watched_do_locked_fn+0xfa [0xfffffd7fedf622ca]
#10 /usr/lib/samba/private/amd64/libdbwrap-samba4.so'db_tdb_do_locked+0x12f [0xfffffd7feccb95cf]
#11 /usr/lib/samba/private/amd64/libdbwrap-samba4.so'dbwrap_do_locked+0x48 [0xfffffd7feccb69a8]
#12 /usr/lib/samba/amd64/libsmbconf.so.0'dbwrap_watched_do_locked+0x6f [0xfffffd7fedf60d7f]
#13 /usr/lib/samba/private/amd64/libdbwrap-samba4.so'dbwrap_do_locked+0x48 [0xfffffd7feccb69a8]
#14 /usr/lib/samba/private/amd64/libsmbd-base-samba4.so'share_mode_do_locked+0xd2 [0xfffffd7fee719b82]
#15 /usr/lib/samba/private/amd64/libsmbd-base-samba4.so'do_lock+0xf0 [0xfffffd7fee70dfe0]
#16 /usr/lib/samba/amd64/vfs/fruit.so'fruit_create_file+0x7ba [0xfffffd7fe88855aa]
#17 /usr/lib/samba/private/amd64/libsmbd-base-samba4.so'smbd_smb2_request_process_create+0xa07 [0xfffffd7fee7d3237]
#18 /usr/lib/samba/private/amd64/libsmbd-base-samba4.so'smbd_smb2_request_dispatch+0xc8f [0xfffffd7fee7c985f]
#19 /usr/lib/samba/private/amd64/libsmbd-base-samba4.so'smbd_smb2_connection_handler+0x621 [0xfffffd7fee7ca7e1]
#20 /usr/lib/samba/private/amd64/libtevent.so.0.10.2'tevent_common_invoke_fd_handler+0x80 [0xfffffd7fecd3a580]
#21 /usr/lib/samba/private/amd64/libtevent.so.0.10.2'epoll_event_loop_once+0x22c [0xfffffd7fecd4180c]
#22 /usr/lib/samba/private/amd64/libtevent.so.0.10.2'std_event_loop_once+0x40 [0xfffffd7fecd3f8f0]
#23 /usr/lib/samba/private/amd64/libtevent.so.0.10.2'_tevent_loop_once+0x95 [0xfffffd7fecd39bd5]
#24 /usr/lib/samba/private/amd64/libtevent.so.0.10.2'tevent_common_loop_wait+0x23 [0xfffffd7fecd39e43]
#25 /usr/lib/samba/private/amd64/libtevent.so.0.10.2'std_event_loop_wait+0x40 [0xfffffd7fecd3f870]
#26 /usr/lib/samba/private/amd64/libsmbd-base-samba4.so'smbd_process+0x777 [0xfffffd7fee7b8677]
#27 /usr/lib/samba/sbin/amd64/smbd'smbd_accept_connection+0x189 [0x40d5b9]
#28 /usr/lib/samba/private/amd64/libtevent.so.0.10.2'tevent_common_invoke_fd_handler+0x80 [0xfffffd7fecd3a580]
#29 /usr/lib/samba/private/amd64/libtevent.so.0.10.2'epoll_event_loop_once+0x22c [0xfffffd7fecd4180c]
#30 /usr/lib/samba/private/amd64/libtevent.so.0.10.2'std_event_loop_once+0x40 [0xfffffd7fecd3f8f0]
#31 /usr/lib/samba/private/amd64/libtevent.so.0.10.2'_tevent_loop_once+0x95 [0xfffffd7fecd39bd5]
#32 /usr/lib/samba/private/amd64/libtevent.so.0.10.2'tevent_common_loop_wait+0x23 [0xfffffd7fecd39e43]
#33 /usr/lib/samba/private/amd64/libtevent.so.0.10.2'std_event_loop_wait+0x40 [0xfffffd7fecd3f870]
#34 /usr/lib/samba/sbin/amd64/smbd'main+0x1a0f [0x40f9ff]
#35 /usr/lib/samba/sbin/amd64/smbd'_start_crt+0x83 [0x408e73]
#36 /usr/lib/samba/sbin/amd64/smbd'_start+0x18 [0x408dd8]
In this particular nested share_mode_do_locked() invocation, callback
comes through dbwrap_watched_do_locked_fn() where it fails to update
rec->value_valid which further gets assigned to static_share_mode_record
within share_mode_do_locked_fn().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14352
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Apr 21 17:37:43 UTC 2020 on sn-devel-184
(cherry picked from commit 5651fafe9856e69c93dba3efa6253780cf3c10a1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/21cf1419c543047085e1acf1a125ad6c0e561423">21cf1419</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2020-05-04T13:06:07+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: pass DCE RPC handle type to create_policy_hnd
Various RPC services expect policy handles of a specific type.
s3 RPC server did not allow to create policy handles with a specific
type while actually requiring that policy handle type itself in some
places.
Make sure we are able to specify the policy on-wire handle type when
creating the policy handle. The changes follow s4 DCE RPC server
implementation.
The original logic to always set on-wire handle type to 0 can be tracked
down to commit fdeea341ed1bae670382e45eb731db1b5838ad21 when we didn't
really know about differences in on-wire handle types.
All but LSA trusted domain RPC calls do not check the on-wire handle
type in s3 RPC server.
Fixes trusted domain operations when Samba RPC client attempts to call
s3 RPC server to perform lsa_lsaRSetForestTrustInformation in FreeIPA.
This fix is a pre-requisite for FreeIPA-FreeIPA forest trust.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14359
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Apr 28 22:55:29 UTC 2020 on sn-devel-184
(cherry picked from commit c7a4578d06427a82ead287f0c5248c1a54cc9336)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Mon May 4 13:06:07 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6bc407b28600596b3270b4671c12199177dc5f2b">6bc407b2</a></strong>
<div>
<span>by Amit Kumar</span>
<i>at 2020-05-14T07:25:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add a test for smbclient -l basename
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14345
Signed-off-by: Amit Kumar <amitkuma@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 2a7fc40fb3f3ca994cecad3e2957433d7a411208)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f6468de046e93dc45d4bcc76dc27daef75a0152d">f6468de0</a></strong>
<div>
<span>by Amit Kumar</span>
<i>at 2020-05-14T07:25:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Fix smbclient -l basename dir
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14345
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Amit Kumar <amitkuma@redhat.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit c83ce5f4f99aef94530411ec82cc03e9935b352d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2b8faefabb49e6823762fe1d0ae26ff6f54f8319">2b8faefa</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-05-14T07:25:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb tests: Confirm lmdb free list handling
Add cmocka tests to confirm lmdb's handling of the free list.
As a result of lmdb's MVCC (Multiversion Concurrency Control) long
running read transactions or stale readers (read transactions where the
process exited without ending the transaction) can cause the database to
run out of space.
Items in the free list are only reused when they would not be visible in
a read transaction. So long running read transactions prevent entries
in the free list being reused, and the database can run out of space.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit fc13304d1575ad6bc6e04cdb3eedf46d3c3678c7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d294eb472961b2450a0d2737e2bab69a9fae1fb9">d294eb47</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-05-14T07:25:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: lmdb clear stale readers on write txn start
In use process failures and Bind9 shut downs leave stale entries in the
lmdb reader table. This can result in lmdb filling it's database file, as
the free list can not be reclaimed due to the stale reader.
In this fix we call mdb_reader_check at the start of each transaction,
to free any stale readers. As the default maximum number of readers is
127, this should not impact on performance to any great extent.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14330
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Mar 31 01:26:07 UTC 2020 on sn-devel-184
(cherry picked from commit 89041a6d18a1d091ea713e6986cac5ca66c2b481)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/39742f3ffe89f6227d2d57d159f427a4fa622ea5">39742f3f</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-05-14T07:25:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib ldb: lmdb init var before calling mdb_reader_check
Initilalise "stale" to zero before passing a pointer to it to
mdb_reader_check.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Apr 7 12:29:00 UTC 2020 on sn-devel-184
(cherry picked from commit d1f4002b914efb31aa34a59e7c93d80f3174727c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f9f03c0a6f5c998df9f1f150c19fea4300ce5738">f9f03c0a</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-05-14T07:25:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Bump version to 2.1.3
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14330
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3cedb9c9594e3958be378dfbc0ec615905c9440a">3cedb9c9</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-05-14T07:25:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CI: add two tests for shadow_copy2 VFS module
Note that the test "fetch a previous version of a regular file via non-canonical
basepath" doesn't fail by "luck" because it runs into the "creating file"
optimisation in unix_convert().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14350
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 6557777c86d72a185b3fe4061a8b5791fd748924)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6bf40566d88957423c31cf17014b45876420aefd">6bf40566</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-05-14T07:25:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: make get_real_filename_full_scan() public
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14350
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(backported from commit aa5f19ddf1dec1ac4386441929bca94727f30ee6)
[Conflicts: source3/smbd/proto.h: more functions are missing in 4.12]
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/105ed96add2e0506abcff0d7a480f5942f1e8c72">105ed96a</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-05-14T07:25:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/lib: add is_gmt_token()
This is not present in master as master has been converted to use struct
smb_filename.twrp instead of @GMT string tokens as part of the path.
Signed-off-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/392863d3d510156b8cc63a403b19e688d1a7a464">392863d3</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-05-14T07:25:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_shadow_copy2: implement case canonicalisation in shadow_copy2_get_real_filename()
unix_convert() can't do this for us in snapdirseverywhere mode, so we do it
ourselves.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14350
Signed-off-by: Ralph Boehme <slow@samba.org>
(Similar to commit a3d1ac2a597e2441d6855db566306298ae5db99b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b50874309d2d133afc24895adc51aef6a7734c66">b5087430</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4:torture: add tests to test the SMB2 read/write offset/length boundaries
[MS-FSA] 2.1.5.2 Server Requests a Read and
2.1.5.3 Server Requests a Write define some contraints.
These tests demonstrate that ((int64_t)offset) < 0) is
not allowed for both reads and writes for SMB.
Also the special case for writes at offset -2 is not possible
nor the append mode with offset < 0.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 54de0e4a3e46a53db5262963e64b109c567554a1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b171d8161d2823f79676fb26baa136bc5bafbe1b">b171d816</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: util: Add sys_valid_io_range()
This implements the contraints of
[MS-FSA] 2.1.5.2 Server Requests a Read.
The special handling of [MS-FSA] 2.1.5.3 Server Requests a Write
with offset < 0, should be handled by higher layers!
Which means the check can also be used for writes.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit e02cbd5c3ea6903d2b7b43c3193b8662d029ecdd)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/442fa5a97829c0a8bb293ffe224c7b08c743f8ad">442fa5a9</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-05-14T07:25:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: util: Add sys_pread_full().
A pread wrapper that will deal with EINTR and never return a short
read unless pread returns zero meaning EOF.
Thread-safe so may be used as a replacement for pread
inside pread_do() thread functions.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 36af33bf9fcdf93fce5ef1520fcb7ddbb07b355e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6c51b56282bf4b34433dd5718a75d2fa7d85adf1">6c51b562</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-05-14T07:25:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib: util: Add sys_pwrite_full().
A pwrite wrapper that will deal with EINTR and never return a short
write unless the file system returns an error. Copes with the
unspecified edge condition of pwrite returning zero by changing
the return to -1, errno = ENOSPC.
Thread-safe so may be used as a replacement for pwrite
inside pwrite_do() thread functions.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 3ba7a89cea85d134eacf1e624e011fe6f66146fc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f3114c72a3fd3c12d8b49d323757134ec34fd971">f3114c72</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smb2_server: fix smbd_smb2_request_verify_sizes() for SMB2_OP_WRITE
Writes with a length of 0 are allowed.
The readfile related check we had before was not really useful
as min_dyn_len can only every be 0 or 1 (and for SMB2_OP_WRITE it's
always 1). So we checked
if (unread_bytes > 0) {
if (unread_bytes < 1) {
return error;
}
}
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit a6eee38ba2f89280676f0a32d26745afd95b551c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9b0aba40e836b7686c609fa6b5ab2e95ebb48e48">9b0aba40</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:44+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: handle 0 length writes as no-op.
They should never touch the SMB_VFS layer
and they never trigger an DISK_FULL error.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit ba68f21286c2c2f1fef8bf8c9cd500a622077887)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3197bd27b359746aaa70fa80b1971fc42cc96c13">3197bd27</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:smbd: add vfs_valid_{pread,pwrite}_range() helper functions
These implement the SMB2 visible behavior of the [MS-FSA]
2.1.5.2 Server Requests a Read and 2.1.5.3 Server Requests a Write
constraints. Note that offset < 0 is not allowed over SMB.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 70fa4b884d2c22669984c25fe757c2fc528f7331)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0d29e442b159ed1123356c8c1ced29b8282903a9">0d29e442</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: add vfs_valid_{pread,pwrite}_range() checks where needed
I checked all callers of SMB_VFS_PWRITE[_SEND](),
all callers of SMB_VFS_PREAD[_SEND]() and also
places where we append to the file and allocate
more space.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 6fa753a1a67d563cd22d0cad73ae15ee267512fc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f6baeeece8f2ceec232d32c94e8076979782ca3f">f6baeeec</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: aio_fork: Change sys_pread() -> sys_pread_full() to protect against short reads.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 60f590000d545292760018694deb34a7cc4ded6d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b60d60bd5052e2aac1c87eaf94b3b62c37323762">b60d60bd</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: aio_fork: Change sys_pwrite() -> sys_pwrite_full() to protect against short writes.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 20ee8b03bbe5bef4ea968170808e3c4c9d22318e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/aff82c00a056c1cf4b6f9fe59807d579e6fac679">aff82c00</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: default. Change sys_pread() -> sys_pread_full() in SMB_VFS_PREAD() to protect against short reads.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 7daa79908b6a0362db30276b3b6f0db176b6ae3c)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/838a52fa25ebf7e399e086eed6be4b5c0f3db743">838a52fa</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: default. Change sys_pwrite() -> sys_pwrite_full() in SMB_VFS_PWRITE() to protect against short writes.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit ca8c3619f657dc38db7cb248f1a657f5bfe20757)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/00e0cf4241be4142316882d70e03a2b20258c224">00e0cf42</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: default. Change pread() -> sys_pread_full() in SMB_VFS_PREAD_SEND() to protect against short reads.
Note that as sys_pread_full() deals with the EINTR case
we can remove the do {} while loop here.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit bf2e546be38abfc77cf40e0b0fef42937696dcde)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6b347a406de873a5703b99f46ae490bf2ae2cec6">6b347a40</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: VFS: default. Change pwrite() -> sys_pwrite_full() in SMB_VFS_PWRITE_SEND() to protect against short writes.
Note that as sys_pwrite_full() deals with the EINTR case
we can remove the do {} while loop here.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 801c06f4c9400343b72cad998086288931f7c6b3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7130e37d8f29b1071d5a19361f5fef156a458a6c">7130e37d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_io_uring: fix the prefix for parametric options from 'vfs_io_uring' to 'io_uring'
This is what the manpage describes.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit fadc7043a71b409ad60a1a4076a7f88f379d2056)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5acc7ee76819c69c0aa0bb83233a43c8ee76ecf5">5acc7ee7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_io_uring: replace vfs_io_uring_request->state with _tevent_req_data()
We don't need a direct pointer to the state...
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit f78e98e0226fe70899b613e0aa5c804d8458bdb0)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a15861f6dd39400ff08db8479f84caa29a0d979d">a15861f6</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_io_uring: introduce vfs_io_uring_request->completion_fn()
We'll need to add more logic than a simple _tevent_req_done()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 456533c9cfc332d3a83ea03a6f969b0d64ccbeb6)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3dc60c5409096a35ec1742bf42b7f84099181fba">3dc60c54</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_io_uring: move error handling out of vfs_io_uring_pread_recv()
We should do that as early as possible and that's in
vfs_io_uring_pread_completion().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit a1487067a6c9df3136fd5d4d16dda4c0f63cb662)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d9e2acf94459c1ce66229ed4d6f57d35f662a409">d9e2acf9</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_io_uring: move error handling out of vfs_io_uring_pwrite_recv()
We should do that as early as possible and that's in
vfs_io_uring_pwrite_completion().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit a51969b8c7e6e49c0d3b776d897aea4f309f8678)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2588cf0d711147f256bb485f152b8ff91c632478">2588cf0d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_io_uring: move error handling out of vfs_io_uring_fsync_recv()
We should do that as early as possible and that's in
vfs_io_uring_fsync_completion().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 40be2232a44a86cb5dfdda330801e615826408ba)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/49847bada158a1a530c6055c475b6a7d1a2300a5">49847bad</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_io_uring: make use of sys_valid_io_range() in vfs_io_uring_pread_send()
This makes the follow up commits easier as we don't have to care
about overflows.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 5005ae3fb24018e370ae60cc23c5e9cfe8357bc9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/efdcf63d939c5ab4dd426c97e39c984ec39cb82e">efdcf63d</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_io_uring: make use of sys_valid_io_range() in vfs_io_uring_pwrite_send()
This makes the follow up commits easier as we don't have to care
about overflows.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 388bc2e6e44470ea4043ecb22750e241145355d2)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2ab5eaebc4c6f7bbffc35aa592f8aa09c8246f2d">2ab5eaeb</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_io_uring: avoid stack recursion of vfs_io_uring_queue_run()
Instead we remember if recursion was triggered and jump to
the start of the function again from the end.
This should make it safe to be called from the completion_fn().
This is hideously complex stuff, so document the hell
out of it.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit f96f45c9ba8d4c8fa4026c22ac4201d66335e5c4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/adac9ae7017e5c31aca91d54139788b8603c867f">adac9ae7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_io_uring: split out a vfs_io_uring_request_submit() function
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit ab89b8e75354c5fd571985e924e1ccbec99de990)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bd41e956fcd409bf121205084469fe8d2923b9c7">bd41e956</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_io_uring: split out a vfs_io_uring_pread_submit() function
This can be reused when we add handling for short reads.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 9de4f8be1dc8b4274891016191a5ca1f724e08b3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0c3523d83cf9612602a9487686b635c0f394b0cd">0c3523d8</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_io_uring: split out a vfs_io_uring_pwrite_submit() function
This can be reused when we add handling for short writes.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 2f6abb00b0daeb4de9ad0aea1b5c56559391aef9)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dadb169869375221c04478dbf19f95f100096530">dadb1698</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_io_uring: protect vfs_io_uring_pread_completion() against invalid results
We should never get back more than we asked for.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit f085dbf8b2bed2695e0065a5bf4523232cb532c7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9b1281a7062537f46c0e33ad040965d3c6975353">9b1281a7</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_io_uring: protect vfs_io_uring_pwrite_completion() against invalid results
We should never get more acked than we asked for.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 283f96872237517f0b3bc4e63e8d3c482ecd5fa4)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8ed9668cefbf09ca7d985ce82cfd10bf9d00dfab">8ed9668c</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_io_uring: protect vfs_io_uring_fsync_completion() against invalid results
We should never get back a value > 0.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit c57a731c4ce395fd710f0b066cd6f1b72223ae07)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0baa1036c6f5fbf5ed2334f6f6655c64363eaf41">0baa1036</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_io_uring: retry after a short read in vfs_io_uring_pread_completion()
We need to be prepared for short reads from the kernel depending on
the state of the page cache. Windows and Mac clients don't
expect short reads for files, so we need to retry ourself.
For the future we may be able to play with some io_uring flags
in order to avoid the retries in userspace, but for now we just fix
the data corruption bug...
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 42e77c4cf245d8420641d216d1abefe81f7a3b79)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/43bc61b1c799470bb87f99ad4401aa77fb17e901">43bc61b1</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-05-14T07:25:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">vfs_io_uring: retry after a short writes in vfs_io_uring_pwrite_completion()
We need to be prepared for short writes from the kernel depending on
the state of the page cache.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 0f01b10679c06dbd28da72ca6c6280ddf81672ba)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/20d61b9c543944c1d292d7829a6ce14a3f31d491">20d61b9c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-05-14T07:25:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: RPC: Don't crash on trying to talloc_free(-1) if smb_iconv_open_ex() fails.
Assign output from smb_iconv_open_ex() to a temporary
handle. Only assign to mds_ctx->[handles] if correctly
opened otherwise we end up trying to call smb_iconv_close(-1).
MacOSX Catalina triggers this.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14372
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu May 7 18:03:16 UTC 2020 on sn-devel-184
(cherry picked from commit 14df5d20a8ec00bf8627732284f427f6463177e3)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/31f91b59365f4a61b044b48cad101cbd15a57335">31f91b59</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-05-14T07:25:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: split a knownfail entry
Lists the two existing subtests indidivually in preparation of adding a third
that is going to pass against ad_dc_ntvfs.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14375
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit c83ef1d90573fdc9db3d0acbc1335a5b2325f5c5)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5c76c6f2d600d1b1bca6189f2925cc5353198c15">5c76c6f2</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-05-14T07:25:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/torture: reproducer for bug 14375
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14375
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 2ace545a6378970ca3d8a1a30d4c7da66aaa9721)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2b1525ca030f44c558aaacbf630a42c0828d4198">2b1525ca</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-05-14T07:25:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: make conflicting_access available to other functions
The next commit adds more users of conflicting_access.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14375
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 3f37008edaa31c3bc8c9b291dc1af00550ce4f9a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6b650659ef6dc037e446879e19773159d04e9cbe">6b650659</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-05-14T07:25:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">smbd: fix for bug 14375
... with many thanks to an enthusiastic Samba user from Poland for helping to
track this down.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14375
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 59f55aa083ce2d87ad6f43dc941f725c79c8ec59)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/136a83c5a9faf9a5d32c4b2f43559aef984fe09d">136a83c5</a></strong>
<div>
<span>by Ralph Boehme</span>
<i>at 2020-05-14T07:25:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3/locking: prime flags in a fresh sharemode data object
This is needed to prime the logic in share_mode_flags_restrict() for the
following scenario:
* (First) CREATE on a file with FILE_SHARE_NONE and
access_mask=FILE_READ_ATTRIBUTES (a stat-open).
* share_mode_flags_restrict() gets called with
share_mode_flags_restrict(flags=0,
access_mask=0x80,
share_mode=0,
lease_type=UINT32_MAX)
and returns a value where none of the FILE_SHARE_* flags is set.
As a result share_mode_data.flags doesn't reflect the share-modes in effect.
This doesn't change any current visible behaviour outside of open_mode_check(),
but it avoids calling share_mode_forall_entries() in open_mode_check_fn()..
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14375
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue May 12 19:52:48 UTC 2020 on sn-devel-184
(cherry picked from commit bf04ca5658dcf7d7cdf5f718eec0e5e21f9a0d64)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/848a1ad7c159442d3ad51297fb12dd8c2f2d110e">848a1ad7</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-05-14T07:25:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Fix indentation in cli_RNetShareEnum()
Also remove a level of indentation with a "goto done;"
Best review with "git show -b", almost no code change
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14366
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit ae91d67a247424d4ddc89230f52365558d6ff402)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8dc3d1e4fb7f25d3be238dba2652201281b4cfc6">8dc3d1e4</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-05-14T07:25:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Protect cli_RNetShareEnum() against rprcnt<6
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14366
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 4a9fe4efefa67d6f24efcbe29722a43fc4859fdc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/054e7de5b4b090e1d4579184d7137824a56ac598">054e7de5</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-05-14T07:25:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Protect cli_RNetServerEnum against rprcnt<6
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14366
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit ce8b70df7bd63e96723b8e8dc864f1690f5fad7b)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8d8549f571d13a241b9811b90ac451d00cb6ada9">8d8549f5</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-05-14T07:25:46+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libsmb: Protect cli_oem_change_password() from rprcnt<2
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14366
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue May 5 17:12:04 UTC 2020 on sn-devel-184
(cherry picked from commit f80c97cb8da64f3cd9904e2e1fd43c29b691166d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f1c602ea9c9073daa050bf6cb2101c0b7f5e7e12">f1c602ea</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2020-05-14T09:33:57+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml: Fix usernames in pam_winbind manpages
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14358
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Apr 29 09:44:55 UTC 2020 on sn-devel-184
(cherry picked from commit 3abd92d7824e803f1ff53425088ebee30b58894b)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Thu May 14 09:33:57 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/53d9450505595a3bf982d9a09956937c3a8433c2">53d94505</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-05-19T12:04:50+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.12.3.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/659c8c3d733b3de88664460f3a2f72ccb0448a2a">659c8c3d</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-05-19T12:05:25+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.12.3 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/df7c3d5b0045d2a1a73dda7546142fcd0b517b19">df7c3d5b</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2020-06-21T08:04:25+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">New upstream version 4.12.3+dfsg</pre>
</li>
</ul>
<h4>30 changed files:</h4>
<ul>
<li class="file-stats">
<a href="#eaaa114e7221d556c2bc2f86d4d18cddf093138a">
<span class="deleted-file">
−
.bzrignore
</span>
</a>
</li>
<li class="file-stats">
<a href="#a5cc2925ca8258af241be7e5b0381edf30266302">
<span class="deleted-file">
−
.gitignore
</span>
</a>
</li>
<li class="file-stats">
<a href="#587d266bb27a4dc3022bbed44dfa19849df3044c">
.gitlab-ci.yml
</a>
</li>
<li class="file-stats">
<a href="#836efb6e25a091dcb4ff8e1dbb2f0be6a5cbf14c">
Makefile
</a>
</li>
<li class="file-stats">
<a href="#7c875fef54268bc433a7fc46aa5fd6e96d58f32f">
<span class="new-file">
+
SECURITY.md
</span>
</a>
</li>
<li class="file-stats">
<a href="#b33892fbddeffc3368077b4904ad0b3d562a7312">
VERSION
</a>
</li>
<li class="file-stats">
<a href="#3277e12b5a9f9ff632d229e2629d34ad21dd93fc">
WHATSNEW.txt
</a>
</li>
<li class="file-stats">
<a href="#537370e7e9d868507093bf1a758bef98a2e919b0">
auth/common_auth.h
</a>
</li>
<li class="file-stats">
<a href="#0789ffa2f9e10b296a93e28057e96840974fc1f1">
auth/credentials/credentials.c
</a>
</li>
<li class="file-stats">
<a href="#6f3c30cf6afc81a7615cec7c65516c4c52997abc">
auth/credentials/credentials_ntlm.c
</a>
</li>
<li class="file-stats">
<a href="#9283eb682b67801707177e777c6175a149627c4c">
auth/credentials/pycredentials.c
</a>
</li>
<li class="file-stats">
<a href="#9ed35f98da985460be43e8adf736bf7fd4aaf5b8">
auth/credentials/pycredentials.h
</a>
</li>
<li class="file-stats">
<a href="#ad462ff026e43477e18e9b8f1bb1a8ba607251c9">
auth/gensec/gensec_util.c
</a>
</li>
<li class="file-stats">
<a href="#82a90d9af4695349d06bab213a9c8b46bc21a3a3">
auth/gensec/schannel.c
</a>
</li>
<li class="file-stats">
<a href="#66295ac674be94d435ac3bf2e41ecd51bac9b984">
auth/gensec/spnego.c
</a>
</li>
<li class="file-stats">
<a href="#0b14a47777d0310e81b8550bb8ab5dd91a7303cb">
auth/ntlmssp/ntlmssp_client.c
</a>
</li>
<li class="file-stats">
<a href="#e74ab4d1ff4dfa8ca77bbeb57c8c246266feb861">
auth/ntlmssp/ntlmssp_private.h
</a>
</li>
<li class="file-stats">
<a href="#df1151fa8fcf1360a4878d0376c50ac14f9e97f6">
auth/ntlmssp/ntlmssp_server.c
</a>
</li>
<li class="file-stats">
<a href="#3ed38a7cb8aee13db0e459772b40a527411129b5">
auth/ntlmssp/ntlmssp_sign.c
</a>
</li>
<li class="file-stats">
<a href="#8d5fef1d13c420deab2dc4c036dda3471bd17825">
bootstrap/.gitlab-ci.yml
</a>
</li>
<li class="file-stats">
<a href="#edadce52cd34e6cf8974e72428cb6d9953c36432">
bootstrap/READMD.md
</a>
</li>
<li class="file-stats">
<a href="#68f7b289335d16fab7fefe7dd1242033744a7fb5">
bootstrap/config.py
</a>
</li>
<li class="file-stats">
<a href="#51c82bf2c8bc6e4e28ddc6d4cb22a3ee41cd04b2">
bootstrap/generated-dists/Vagrantfile
</a>
</li>
<li class="file-stats">
<a href="#eb92e80fad5f6ddce465942cbf191443ab68465f">
bootstrap/generated-dists/centos6/bootstrap.sh
</a>
</li>
<li class="file-stats">
<a href="#2205c8fc87c3cd9dd645a9562f1f40cf7c8f5f44">
bootstrap/generated-dists/centos6/packages.yml
</a>
</li>
<li class="file-stats">
<a href="#c865828c60e463bc21053b6fe798092d4299f009">
bootstrap/generated-dists/centos7/bootstrap.sh
</a>
</li>
<li class="file-stats">
<a href="#26d68eda024a2fa761b73aa0ce5749d5719ac275">
bootstrap/generated-dists/centos7/packages.yml
</a>
</li>
<li class="file-stats">
<a href="#75af13c4f4e4c8074302ba8361a37d7828e00dbc">
<span class="new-file">
+
bootstrap/generated-dists/centos8/Dockerfile
</span>
</a>
</li>
<li class="file-stats">
<a href="#5b2d080271b9d8bf57438473a42fc133fec6cd60">
<span class="new-file">
+
bootstrap/generated-dists/centos8/bootstrap.sh
</span>
</a>
</li>
<li class="file-stats">
<a href="#af696c21836e530b6e9e1a52a18b470b2f08e043">
bootstrap/generated-dists/fedora28/locale.sh
→
bootstrap/generated-dists/centos8/locale.sh
</a>
</li>
</ul>
<h5>The diff was not included because it is too large.</h5>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
<a href="https://salsa.debian.org/samba-team/samba/-/compare/1fea3f8c98e228fd8ff00783ec8799b34853e5ab...df7c3d5b0045d2a1a73dda7546142fcd0b517b19">View it on GitLab</a>.
<br>
You're receiving this email because of your account on salsa.debian.org.
If you'd like to receive fewer emails, you can
adjust your notification settings.
</p>
</div>
</body>
</html>