<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<h3>
Mathieu Parent pushed to branch upstream_4.12
at <a href="https://salsa.debian.org/samba-team/samba">Debian Samba Team / samba</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/11abc955736af2e398cb0f208ab47bde9fadee60">11abc955</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-05-19T12:06:12+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.12.4...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/50653906976f6c28a7efc36be09e13ef3100cc8f">50653906</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-05-25T06:27:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">librpc/idl: Add dnsp_DnsProperty_short
This will be used by a test and the DNS server code to parse short dnsProperty
records which come from Windows servers.
This example is from the value that caused Samba to fail as it
can not be parsed as a normal dnsp_DnsProperty
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14310
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(backported to 4.12 from commit 87bf1d687fe7b48a7b6d511dfc7f5414db16119c)
[abartlet@samba.org: resolve conflict due to less ndrdump tests in 4.12]
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0acfdab2a6ac113652556439c5bbd09b8caf8e72">0acfdab2</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-05-25T06:27:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: Add test for handling of "short" dnsProperty records
These have been known to be given by Windows DCs that share the same domain
as while invalid, they are not format-checked inbound when set by the DNS
Manager MMC applet over the dnsserver pipe to Windows.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14310
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit 6eb2a48f5a998b82bb071ef42d00d2f34a2b0ed8)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/76c8a9deaa777cda273c9e9ebda91590b2ab68f7">76c8a9de</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-05-25T06:27:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s4/rpc_server/dnsserver: Allow parsing of dnsProperty to fail gracefully
On (eg) the
DC=_msdcs.X.Y,CN=MicrosoftDNS,DC=ForestDnsZones,DC=X,DC=Y
record, in domains that have had a Microsoft Windows DC an attribute:
dNSProperty:: AAAAAAAAAAAAAAAAAQAAAJIAAAAAAAAA
000000 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 >................<
000010 92 00 00 00 00 00 00 00 >........<
000018
We, until samba 4.12, would parse this as:
pull returned Success
dnsp_DnsProperty: struct dnsp_DnsProperty
wDataLength : 0x00000000 (0)
namelength : 0x00000000 (0)
flag : 0x00000000 (0)
version : 0x00000001 (1)
id : DSPROPERTY_ZONE_NS_SERVERS_DA (146)
data : union dnsPropertyData(case 0)
name : 0x00000000 (0)
dump OK
However, the wDataLength is 0. There is not anything in
[MS-DNSP] 2.3.2.1 dnsProperty to describe any special behaviour
for when the id suggests that there is a value, but wDataLength is 0.
https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-dnsp/445c7843-e4a1-4222-8c0f-630c230a4c80
We now fail to parse it, because we expect an entry with id DSPROPERTY_ZONE_NS_SERVERS_DA
to therefore have a valid DNS_ADDR_ARRAY (section 2.2.3.2.3).
As context we changed it in our commit fee5c6a4247aeac71318186bbff7708d25de5912
because of bug https://bugzilla.samba.org/show_bug.cgi?id=14206
which was due to the artificial environment of the fuzzer.
Microsoft advises that Windows also fails to parse this, but
instead of failing the operation, the value is ignored.
Reported by Alex MacCuish. Many thanks for your assistance in
tracking down the issue.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14310
RN: Can't use DNS functionality after a Windows DC has been in domain
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri May 15 07:29:17 UTC 2020 on sn-devel-184
(cherry picked from commit 004e7a1fee766102de302e83f4dc5f4d977aef32)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f0654fa47e07a2b756d3640f29e523161288e60f">f0654fa4</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2020-05-25T06:27:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Add path_expand_tilde()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14370
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 15457254be0ab1235c327bd305dfeee19b2ea7a1)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b91925075ef34df7aabbe3512d3c93d3ce726455">b9192507</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2020-05-25T06:27:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib:util: Add test for path_expand_tilde()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14370
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(backported from commit a15bd5493b696c66c6803d8ca65bc13f1cfcdf0a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/eae0ae3cae31a130bba322620241c23e6f97fecd">eae0ae3c</a></strong>
<div>
<span>by Andreas Schneider</span>
<i>at 2020-05-25T06:27:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:gencache: Allow to open gencache as read-only
This allows client tools to access the cache for ready-only operations
as a normal user.
Example:
net ads status
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14370
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri May 15 14:40:32 UTC 2020 on sn-devel-184
(cherry picked from commit 04f0c45475de383a0be4ca355ab9aa7784e61c27)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/572eb426f3fcbf99924be0b294e2e38bff2d04d8">572eb426</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-05-25T06:27:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: lib: Paranoia around use of snprintf copying into a fixed-size buffer from a getenv() pointer.
Post checks for overflow/error.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon May 18 23:42:57 UTC 2020 on sn-devel-184
(cherry picked from commit dd1f750293ef4361455a5d5b63fc7a89495715b7)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f02893f536005157b214e962497914c5d078e52a">f02893f5</a></strong>
<div>
<span>by Volker Lendecke</span>
<i>at 2020-05-25T07:52:12+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">winbindd: Fix a use-after-free when winbind clients exit
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14382
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Volker Lendecke <vl@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue May 19 10:45:06 UTC 2020 on sn-devel-184
(cherry picked from commit 68380ebaa60c64311cc1081f700d571abbf69f4f)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Mon May 25 07:52:12 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/701cbabc92e3bab2ddf55e8adef2b005ea4ae4c5">701cbabc</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-06-04T11:47:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: selftest: Add share definition [bad_iconv] in fileserver.
Creates a utf8 valid filename within that is invalid in CP850.
Useful to test smbclient list directory character set conversions.
https://bugzilla.samba.org/show_bug.cgi?id=14374
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(back-ported from commit a9651d6bc2b6dea8adc859ce21c2431253868887)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/290ae67b24eec2a50c937216b92e7294e1e08109">290ae67b</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-06-04T11:47:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: selftest: Add test_smbclient_iconv.sh to check client behavior on bad name conversion.
SMB2 and NT1 fail this, CORE already returns NT_STATUS_INVALID_NETWORK_RESPONSE
on bad conversion.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14374
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(back-ported from commit e016671d34c24c4768df774425ec743b88e30015)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/cc105695a60f629928c971e98e15edb89fb58162">cc105695</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-06-04T11:47:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: In SMB1 old protocol - return NT_STATUS_INVALID_NETWORK_RESPONSE if name conversion ended up with a NULL filename.
Can happen if namelen == 0.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14374
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit b10de0bb64fe022e6b066584013dfb0bdf2ade96)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ea64f5fb2d87877d77a8ccdd6874b367efaf62a4">ea64f5fb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-06-04T11:47:47+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: In SMB2 return NT_STATUS_INVALID_NETWORK_RESPONSE if name conversion ended up with a NULL filename.
Can happen if namelen == 0.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14374
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 753115a8d19f6ac8cd28305748fc6d888679dccc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c2051cdfda67f04e641c7b58d0c89a675ed6fb79">c2051cdf</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-06-04T11:47:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmbclient: Finish unifing bad iconv behavior across CORE NT1 SMB2 protocols.
On bad name conversion, exit the directory listing with an error, but leave the
connection intact. We were already checking for finfo->name == NULL here,
but were ignoring it and not reporting an error.
Remove the knownfail.d/bad_iconv file as we now
behave the same across CORE/NT1/SMB2.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14374
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue May 12 21:32:44 UTC 2020 on sn-devel-184
(cherry picked from commit 393da520e43bd3a28feb231bcd9fd5308a3daa4a)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/2b15eee1bc0d48b9804f20d5bb3cc8b2fde8085e">2b15eee1</a></strong>
<div>
<span>by Björn Jacke</span>
<i>at 2020-06-04T11:47:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">docs-xml: update list of posible VFS operations for vfs_full_audit
the list of valid operations can be generated by
grep "{ SMB_VFS_OP_" source3/modules/vfs_full_audit.c |sed 's/.*,[ \t]*"//;s/".*//'|grep -v NULL | sort
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14386
based on 14470e4e4c16cfc36384027c39c1685dea42ad26 in master
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/5015bbbd70188553454cfdbbf4faa1c2062c4882">5015bbbd</a></strong>
<div>
<span>by Stefan Metzmacher</span>
<i>at 2020-06-04T11:47:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3:libads: prefer ENCTYPE_AES256_CTS_HMAC_SHA1_96 in ads_keytab_add_entry()
This is currently not critical as we only use keytabs
only as acceptor, but in future we'll also use them
for kinit() and there we should prefer the newest type.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/e25e574ba042d83c7f7675b75139385d8cc9ffc8">e25e574b</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2020-06-04T11:47:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add a test to check dNSHostName with netbios aliases
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/533a4be557bd7923ff8bfaea9a82cd99d47b10f4">533a4be5</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2020-06-04T11:47:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix accidental overwrite of dnsHostName by the last netbios alias
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b3630d58e4816402231500551aa6268b5a8cffa7">b3630d58</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2020-06-04T11:47:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Refactor ads_keytab_add_entry() to make it iterable
so we can more easily add msDS-AdditionalDnsHostName entries.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/279e72fe334d8ac375f0e5a8cfccc0fcf0b6d02f">279e72fe</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2020-06-04T11:47:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add a test for msDS-AdditionalDnsHostName entries in keytab
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/71efed33f47dfc4f294881257add9121623e29ce">71efed33</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2020-06-04T11:47:48+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add msDS-AdditionalDnsHostName entries to the keytab
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7b1bac7d084815cf8b0f070b16a5c93af78f2153">7b1bac7d</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2020-06-04T13:12:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add net-ads-join dnshostname=fqdn option
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri May 29 13:33:28 UTC 2020 on sn-devel-184
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Thu Jun 4 13:12:27 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/f50cb3a0fbf403a8c40329a446d15648a04a3c79">f50cb3a0</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-06-24T09:57:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">libcli ldap tests: remove use of zero length array
libcli/ldap/tests/ldap_message_test.c defines a zero length array
(uint8_t buf[0]), which is a GCC extension and breaks the build with
some strict compilers like xlc.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14387
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Jun 23 02:15:35 UTC 2020 on sn-devel-184
(cherry picked from commit d701bc1518766f36b1c7a3a00a82485098a8ee3d)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/63c70acd4f473d709c25a7c35398db98d4504981">63c70acd</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2020-06-24T09:57:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix a typo in recent net man page changes
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14406
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/60e7328219169d949e5a864e322fb2de57c4ffd3">60e73282</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2020-06-24T09:57:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">selftest: add tests for binary msDS-AdditionalDnsHostName
Like the short names added implicitly by Windows DC.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14406
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0e668997c83bcd4c736a86bd78803992225fd4dd">0e668997</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2020-06-24T09:57:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Properly handle msDS-AdditionalDnsHostName returned from Windows DC
Windows DC adds short names for each specified msDS-AdditionalDnsHostName
attribute, but these have a suffix of "\0$" and thus fail with
ldap_get_values(), use ldap_get_values_len() instead.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14406
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0ac77960440f69e47ad52f134ecc95133c3c2353">0ac77960</a></strong>
<div>
<span>by Isaac Boukris</span>
<i>at 2020-06-24T09:57:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix usage of ldap_get_values_len for msDS-AdditionalDnsHostName
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14406
Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Jun 22 09:59:04 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1049c5776f8b28ac15c3752eb2becee75e15cd45">1049c577</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2020-06-24T09:57:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">lib/ldb: add unit test for ldb_ldap internal code
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14413
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 36bd6edd8a603f3aa34aff81c43ef26efd3ad4cf)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3db89a6c8809fd7ff733ab1b7d401ea202f29ab0">3db89a6c</a></strong>
<div>
<span>by Alexander Bokovoy</span>
<i>at 2020-06-24T11:22:16+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb_ldap: fix off-by-one increment in lldb_add_msg_attr
Fix regression introduced by commit ce2bf5c72b6423fff680b3d6a9042103a6cdda55
lldb_add_msg_attr() calls ldb_msg_add_empty() which, in turn, calls
calls _ldb_msg_add_el() which already increments msg->num_elements by one.
As a result, msg->num_elements is bigger than the actual number of
elements and any iteration over elements would step over elements array
boundary.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14413
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Jun 19 08:35:33 UTC 2020 on sn-devel-184
(cherry picked from commit 990a0fc4a0481aed817fad7575d8df453fbe7af9)
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Wed Jun 24 11:22:16 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/837ee4b1757e990827ecf0cd3a29a057886a9357">837ee4b1</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-06-25T10:36:07+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.12.4...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
(cherry picked from commit 11abc955736af2e398cb0f208ab47bde9fadee60)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c61a5255d9efaa1e63e33810f5236ea21b283c40">c61a5255</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10730: vlv: Use strcmp(), not strncmp() checking the NULL terminated control OIDs
The end result is the same, as sizeof() includes the trailing NUL, but this
avoids having to think about that.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/dd53faf44463705f83e6f25e53a5682eb0dc0e1b">dd53faf4</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10730: vlv: Do not re-ASQ search the results of an ASQ search with VLV
This is a silly combination, but at least try and keep the results sensible
and avoid a double-dereference.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/98a67d491375b9ccbf55e4cedd517a1678010a91">98a67d49</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10730: selftest: Add test to confirm VLV interaction with ASQ
Tested against Windows 1709.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/337f3e42841fb5c592b93285d37fb9ea238ee3ec">337f3e42</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10730: vlv: Another workaround for mixing ASQ and VLV
This is essentially an alternative patch, but without the correct
behaviour. Instead this just avoids a segfault.
Included in case we have something simialr again in
another module.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d6329e8ace7f332492201f224359fd7f2e0f6937">d6329e8a</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10730: selftest: Add test to show that VLV and paged_results are incompatible
As tested against Windows Server 1709
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8103df54b18ec7ae0fc3876c826da06385663776">8103df54</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10730: dsdb: Fix crash when vlv and paged_results are combined
The GUID is not returned in the DN for some reason in this (to be banned)
combination.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b1f72d2ce5e7cf3dc6877040a0fd086bd5d7c2c9">b1f72d2c</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10730: dsdb: Ban the combination of paged_results and VLV
This (two different paging controls) makes no sense and fails against
Windows Server 1709.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c29319e91d0764c7078ea59af78a16dbaf0b6824">c29319e9</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10730: s4 dsdb paged_results: Prevent repeat call of ldb_module_done
Check the return code from paged_results, if it is not LDB_SUCCESS
ldb_module_done has already been called, and SHOULD NOT be called again.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/b2658b9432c6a6a03b9da269da6ede701c8322fb">b2658b94</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10730: s4 dsdb vlv_pagination: Prevent repeat call of ldb_module_done
Check the return code from vlv_results, if it is not LDB_SUCCESS
ldb_module_done has already been called, and SHOULD NOT be called again.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/9dd458956d7af1b4bbe505ba2ab72235e81c27d0">9dd45895</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10730: lib ldb: Check if ldb_lock_backend_callback called twice
Prevent use after free issues if ldb_lock_backend_callback is called
twice, usually due to ldb_module_done being called twice. This can happen if a
module ignores the return value from function a function that calls
ldb_module_done as part of it's error handling.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7cc5a5a35e93e5f5bfcafe767a07b3c87192a34f">7cc5a5a3</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ldb: Bump version to 2.1.4
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6e04e0b4944b394cd1ba1879367af2b6e53b9882">6e04e0b4</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10745: pytests: hand-rolled invalid dns/nbt packet tests
The client libraries don't allow us to make packets that are broken in
certain ways, so we need to construct them as byte strings.
These tests all fail at present, proving the server is rendered
unresponsive, which is the crux of CVE-2020-10745.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/ec640f93bc99e5b24409a2ea2b5fb70e7f991c53">ec640f93</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10745: librpc/tests: cmocka tests of dns and ndr strings
These time the push and pull function in isolation.
Timing should be under 0.0001 seconds on even quite old hardware; we
assert it must be under 0.2 seconds.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378
(backported from master commit)
[abartlet@samba.org: backported due to differences in pre-existing
tests - eg test_ndr - mentioned in wscript_build and tests.py]
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a80dd6d12718a69aa18d0c429f4c6b2c18dc6662">a80dd6d1</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10745: ndr_dns: move ndr_push_dns_string core into sharable function
This is because ndr_nbt.c does almost exactly the same thing with
almost exactly the same code, and they both do it wrong. Soon they
will both be using the better version that this will become. Though in
this patch we just move the code, not fix it.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/be20d15af1349217ada57b6651ba063218301aa5">be20d15a</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10745: ndr/dns_utils: correct a comment
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a19660d1fea66937a29dde85af41d911822aa2f2">a19660d1</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10745: ndr_dns: do not allow consecutive dots
The empty subdomain component is reserved for the root domain, which we
should only (and always) see at the end of the list. That is, we expect
"example.com.", but never "example..com".
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/0afc9f777a609d0677bc5de83b35fb9313ea8466">0afc9f77</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10745: dns_util/push: forbid names longer than 255 bytes
As per RFC 1035.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/3b98e807eb9879e89fffd1bbf6c5a0feaa99d121">3b98e807</a></strong>
<div>
<span>by Douglas Bagnall</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10745: ndr/dns-utils: prepare for NBT compatibility
NBT has a funny thing where it sometimes needs to send a trailing dot as
part of the last component, because the string representation is a user
name. In DNS, "example.com", and "example.com." are the same, both
having three components ("example", "com", ""); in NBT, we want to treat
them differently, with the second form having the three components
("example", "com.", "").
This retains the logic of e6e2ec0001fe3c010445e26cc0efddbc1f73416b.
Also DNS compression cannot be turned off for NBT.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/795a25dc81b37f2d85264865f8a4a38559f06e2c">795a25dc</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-14303 Ensure an empty packet will not DoS the NBT server
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/d7a32e815bfedeb70a17ecaa7028a1587b88c6c9">d7a32e81</a></strong>
<div>
<span>by Gary Lockyer</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-14303: s4 nbt: fix busy loop on empty UDP packet
An empty UDP packet put the nbt server into a busy loop that consumes
100% of a cpu.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14417
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/a6a3a9f59d429ae01dc05aa412eab251cc842dcf">a6a3a9f5</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10760 dsdb: Ensure a proper talloc tree for saved controls
Otherwise a paged search on the GC port will fail as the ->data was
not kept around for the second page of searches.
An example command to produce this is
bin/ldbsearch --paged -H ldap://$SERVER:3268 -U$USERNAME%$PASSWORD
This shows up later in the partition module as:
ERROR: AddressSanitizer: heap-use-after-free on address 0x60b00151ef20 at pc 0x7fec3f801aac bp 0x7ffe8472c270 sp 0x7ffe8472c260
READ of size 4 at 0x60b00151ef20 thread T0 (ldap(0))
#0 0x7fec3f801aab in talloc_chunk_from_ptr ../../lib/talloc/talloc.c:526
#1 0x7fec3f801aab in __talloc_get_name ../../lib/talloc/talloc.c:1559
#2 0x7fec3f801aab in talloc_check_name ../../lib/talloc/talloc.c:1582
#3 0x7fec1b86b2e1 in partition_search ../../source4/dsdb/samdb/ldb_modules/partition.c:780
or
smb_panic_default: PANIC (pid 13287): Bad talloc magic value - unknown value
(from source4/dsdb/samdb/ldb_modules/partition.c:780)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14402
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/565811f4f5f16e072644a1a7c625ad1e60c89b10">565811f4</a></strong>
<div>
<span>by Andrew Bartlett</span>
<i>at 2020-06-25T10:43:52+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">CVE-2020-10760 dsdb: Add tests for paged_results and VLV over the Global Catalog port
This should avoid a regression.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/86177f14ff9be3aedd574a47b6733c7c8be6b01a">86177f14</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-06-25T12:56:15+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.12.4.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/6ecd05dfbc201c60346d2ae486663ae0dfc0c09c">6ecd05df</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-06-25T12:57:04+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.12.4 release.
This is a security release in order to address the following CVEs:
o CVE-2020-10730: NULL pointer de-reference and use-after-free in Samba AD DC
LDAP Server with ASQ, VLV and paged_results.
o CVE-2020-10745: Parsing and packing of NBT and DNS packets can consume
excessive CPU.
o CVE-2020-10760: LDAP Use-after-free in Samba AD DC Global Catalog with
paged_results and VLV.
o CVE-2020-14303: Empty UDP packet DoS in Samba AD DC nbtd.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/19c6e21cfd62dcda709fca5ea9fc1bad04533277">19c6e21c</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-06-26T07:52:25+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: selftest: Add samba3.blackbox.aio-outstanding test.
Shows smbd panics if connection is terminated (torn down)
by killing the client with outstanding aio requests in the
queue. As we're closing smbd we should cope with this.
Followup-bugfix for:
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit f206d37f6ec8143b2051a8fe15783c188344adbe)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8666dc1eec63b74830b95112bb4c589c5aa788dd">8666dc1e</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-06-26T07:52:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Add smbXsrv_client_valid_connections().
Next commit will make use of this.
Followup-bugfix for:
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/1f8a77fe3aaebb15f3c71e6d3a46e2ef15590b29">1f8a77fe</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-06-26T07:52:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: smbd: Allow a SHUTDOWN_CLOSE on a file with outstanding aio if there are no client connections alive.
The process is exiting now so pthreads will never complete to cause
problems.
Remove the knownfail.d/aio_outstanding entry.
Followup-bugfix for:
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jun 24 20:14:15 UTC 2020 on sn-devel-184
(cherry picked from commit 205653732064ecf76d3198451240af468806ec14)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/10e8d8b4b13a7d1bbd07072a8ebd178ca12b9641">10e8d8b4</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-06-26T07:52:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: Info level SMB2_FIND_ID_BOTH_DIRECTORY_INFO encodes attibutes as a uint32, not a uint8.
Fix the SMB2 parsing code.
Cast to a uint16_t for now after pulling the information
as finfo->mode is currently only 16 bits.
We will need this to detect FILE_ATTRIBUTE_REPARSE_POINT in a later commit.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 3063e1601ad9e2536651a75a47ebf4921ffddbdc)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/bb210d6d29bcd08a36334e9b159c0a5fd3d82bf5">bb210d6d</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-06-26T07:52:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: Info level SMB_FIND_FILE_BOTH_DIRECTORY_INFO encodes attibutes as a uint32, not a uint8.
Cast to a uint16_t for now after pulling the information
as finfo->mode is currently only 16 bits.
We will need this to detect FILE_ATTRIBUTE_REPARSE_POINT in a later commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 5e3e6c4c0c70e171607f4b5351bd8ec146730f08)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/7db0eb75680a8af464ad26122331e0b808bc5aa5">7db0eb75</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-06-26T07:52:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: Info level SMB_FIND_INFO_STANDARD encodes attibutes as a uint16, not a uint8.
We will need this to detect FILE_ATTRIBUTE_REPARSE_POINT in a later commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit be52f87c376a8f71b2de4aa52f25818cad2b160e)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/50ff83cb3e3bc9247c639308057b7c927c266701">50ff83cb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-06-26T07:52:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: libsmb: Info level SMB_FIND_EA_SIZE encodes attibutes as a uint16, not a uint8.
We will need this to detect FILE_ATTRIBUTE_REPARSE_POINT in a later commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 6463f2612a662f217af18455206afde122323375)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/68c0b008bddcb25e13184f3a6b67f09b1d08f5a7">68c0b008</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-06-26T07:52:26+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Add a MSDFS-ATTRIBUTE test.
Framework to drive comes next.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 84134812e3447317125ae08b2a98848a2e4bbd65)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/54d6efeb917ba8e7a69ed4b0e9c94adad1545e5d">54d6efeb</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-06-26T07:52:27+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: torture: Add test for getting attibutes on an MSDFS link.
Mark as knownfail for now.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(back ported from commit 2a4705129d06b91023bc3fc435fccf91d3939553)
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/50badbae62f51789a776cd3aa80a80d9aed1d8fe">50badbae</a></strong>
<div>
<span>by Jeremy Allison</span>
<i>at 2020-06-26T11:18:10+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">s3: msdfs: Fix missing struct stat return on msdfs links by doing an LSTAT call.
This (unfortunately) re-exposes the fact the msdfs links are symlinks,
bit fixing this correctly requires a VFS ABI change which we can't
do for a released stream.
Remove the knownfail.d/msdfs-attr file.
Everything now passes.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-12-test): Fri Jun 26 11:18:10 UTC 2020 on sn-devel-184
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/05b8919c7c2c21848feebd94d3cec5ad2162d440">05b8919c</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-07-02T11:05:20+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge tag 'samba-4.12.4' into v4-12-test
samba: tag release samba-4.12.4
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/8d47600f11065b85098ee4ffa59d7345f491aa1c">8d47600f</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-07-02T11:05:41+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Bump version up to 4.12.5.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c61cb94a46328e983a7a53ccfe553795301c73f8">c61cb94a</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-07-02T13:07:29+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">WHATSNEW: Add release notes for Samba 4.12.5.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/217bc17f1d22bd85631dfe9e60731385c59fc2b0">217bc17f</a></strong>
<div>
<span>by Karolin Seeger</span>
<i>at 2020-07-02T13:08:04+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">VERSION: Disable GIT_SNAPSHOT for the 4.12.5 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
</pre>
</li>
<li>
<strong><a href="https://salsa.debian.org/samba-team/samba/-/commit/c3562f1d81acbe6b3a70a75e2029a02de7c559af">c3562f1d</a></strong>
<div>
<span>by Mathieu Parent</span>
<i>at 2020-07-02T13:58:46+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">New upstream version 4.12.5+dfsg</pre>
</li>
</ul>
<h4>30 changed files:</h4>
<ul>
<li class="file-stats">
<a href="#b33892fbddeffc3368077b4904ad0b3d562a7312">
VERSION
</a>
</li>
<li class="file-stats">
<a href="#3277e12b5a9f9ff632d229e2629d34ad21dd93fc">
WHATSNEW.txt
</a>
</li>
<li class="file-stats">
<a href="#7621aa1ce515b0afdaffdf0eca777ff6f439e31a">
ctdb/doc/ctdb-etcd.7
</a>
</li>
<li class="file-stats">
<a href="#5cbe2af7f9551bd8ba760b3978da68f98bcca8d1">
ctdb/doc/ctdb-script.options.5
</a>
</li>
<li class="file-stats">
<a href="#6f372b1da785e9b62534d3ddc2b1cc994e1edea1">
ctdb/doc/ctdb-statistics.7
</a>
</li>
<li class="file-stats">
<a href="#bff45f5b0a1ff6f2cac0546191f2199bad760297">
ctdb/doc/ctdb-tunables.7
</a>
</li>
<li class="file-stats">
<a href="#cf03e1c00a6ff50094bf342fee6dbac15b3a4e0f">
ctdb/doc/ctdb.1
</a>
</li>
<li class="file-stats">
<a href="#ab0737fb37c5f24c1a655306d7f3cf9b28970fa1">
ctdb/doc/ctdb.7
</a>
</li>
<li class="file-stats">
<a href="#355570170158b89f755ad8c2655ff1b55be32cfb">
ctdb/doc/ctdb.conf.5
</a>
</li>
<li class="file-stats">
<a href="#f3298e106280fd2e988e57b01b9f5697370b66b1">
ctdb/doc/ctdb.sysconfig.5
</a>
</li>
<li class="file-stats">
<a href="#027f7ec3db27f736464febdb40a2f5784278e923">
ctdb/doc/ctdb_diagnostics.1
</a>
</li>
<li class="file-stats">
<a href="#944489b6fed794d85434d7748c57ff12c56034db">
ctdb/doc/ctdb_mutex_ceph_rados_helper.7
</a>
</li>
<li class="file-stats">
<a href="#b3f02388c7b39adb49f0f55dbc87a0b75e7f21c3">
ctdb/doc/ctdbd.1
</a>
</li>
<li class="file-stats">
<a href="#2097dbfda6f5cb780a636fd916929b31054ddd8c">
ctdb/doc/ctdbd_wrapper.1
</a>
</li>
<li class="file-stats">
<a href="#1abbc4563e217dafc807f4824b2e10419a31fcf7">
ctdb/doc/ltdbtool.1
</a>
</li>
<li class="file-stats">
<a href="#0a2e2417e72340b1b7bea2f903aa804c91c6386b">
ctdb/doc/onnode.1
</a>
</li>
<li class="file-stats">
<a href="#cfbec512f592346951273f1f00fd0300153259f8">
ctdb/doc/ping_pong.1
</a>
</li>
<li class="file-stats">
<a href="#ff24328aaf3ffa605e87eeecbcf2383fcbd513c2">
docs-xml/manpages/net.8.xml
</a>
</li>
<li class="file-stats">
<a href="#1c43dea1312d3359a9b5ea69a2c5de0377440845">
docs-xml/manpages/vfs_full_audit.8.xml
</a>
</li>
<li class="file-stats">
<a href="#3ffe9922012afbdd8d172aea0e4a744017a46c3e">
docs/manpages/cifsdd.8
</a>
</li>
<li class="file-stats">
<a href="#fb65349fa2f09806b79d9f359349e05a1a43aab9">
docs/manpages/dbwrap_tool.1
</a>
</li>
<li class="file-stats">
<a href="#eae12bb44b3ee724b1c740f12730f4c389df0b72">
docs/manpages/eventlogadm.8
</a>
</li>
<li class="file-stats">
<a href="#8b9d6931b4023500ead3431562d618ffd52466ff">
docs/manpages/findsmb.1
</a>
</li>
<li class="file-stats">
<a href="#28926762f13c3ce5a1de6e2d2e8068ffb67c6740">
docs/manpages/idmap_ad.8
</a>
</li>
<li class="file-stats">
<a href="#e777d8f0d1e98d8eb6b36fe3cecbf128683c39d6">
docs/manpages/idmap_autorid.8
</a>
</li>
<li class="file-stats">
<a href="#25cc1933670f40b62ff9a036acd111a74cd79767">
docs/manpages/idmap_hash.8
</a>
</li>
<li class="file-stats">
<a href="#5e94741d6f83b11f5f44b9534cb80852b6663b3b">
docs/manpages/idmap_ldap.8
</a>
</li>
<li class="file-stats">
<a href="#9866bbd092d8ac30b5d4d0b2c769014f00968de0">
docs/manpages/idmap_nss.8
</a>
</li>
<li class="file-stats">
<a href="#a656ad172d8f1be792355bac9e7b4c3bbd953e10">
docs/manpages/idmap_rfc2307.8
</a>
</li>
<li class="file-stats">
<a href="#292a9fb6acd638e1a952d4947275be44996f43e7">
docs/manpages/idmap_rid.8
</a>
</li>
</ul>
<h5>The diff was not included because it is too large.</h5>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
<a href="https://salsa.debian.org/samba-team/samba/-/compare/df7c3d5b0045d2a1a73dda7546142fcd0b517b19...c3562f1d81acbe6b3a70a75e2029a02de7c559af">View it on GitLab</a>.
<br>
You're receiving this email because of your account on salsa.debian.org.
If you'd like to receive fewer emails, you can
adjust your notification settings.
</p>
</div>
</body>
</html>