<html dir="ltr"><head></head><body style="text-align:left; direction:ltr;"><div>On Mon, 2024-04-08 at 08:37 +0300, Michael Tokarev wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><pre>08.04.2024 01:59, Andrew Bartlett:</pre><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><pre>Thanks Michael for everything you do to maintain the Samba packages in Debian.</pre><pre><br></pre><pre>The SAMBA_VERSION_VENDOR_SUFFIX=Debian in the Samba package is a specific request from the upstream Samba team.</pre><pre><br></pre><pre>It is added because Debian carries patches that don't appear upstream (it has got better, but there are still some) and the branding appears in our </pre><pre>debug logs (specifically in every PANIC) so we can ensure we are debugging the right version and expecting the right behaviours when a user has </pre><pre>questions on the mailing list.</pre></blockquote><pre><br></pre><pre>Aha. Interesting.</pre><pre><br></pre><pre>I tried to find out why this has been done and if it can be removed now, -</pre><pre>if it's okay with ubuntu folks. I didn't even think to ask the upstream,</pre><pre>I was 100% sure it was due to downstream.</pre><pre><br></pre><pre>The reason I thought it not only unneeded but also even wrong, is because</pre><pre>there's nothing really debian (or ubuntu) in the debian samba package, it</pre><pre>seemed a bit unfair to add our (debian) label to the goods not made by</pre><pre>debian, so to say. It is the samba team who wrote the code, and in my</pre><pre>view, by adding "debian" label, debian claims it added something valuable</pre><pre>to samba, which is untrue. It's not about "we're not to blame", my</pre><pre>thoughts was entirely due to "who to thank", so to say.</pre><pre><br></pre><pre>This change has been made at a somewhat unfortunate moment, - I thought</pre><pre>about this, made a commit in my local tree, and asked around if this</pre><pre>thing is okay. And next, a t64-related bug report has come which needed</pre><pre>fixing, so I fixed that one on top of "de-branding" and uploaded,</pre><pre>without waiting for the other answers to come.</pre><pre><br></pre><pre>There's no harm done, as it's not a big thing and it's not a long time</pre><pre>it existed. It is more, it looks like without this upload I wouldn't</pre><pre>have know the answer anyway :)</pre></blockquote><pre><br></pre><pre>And only because I read that particular commit e-mail. </pre><pre><br></pre><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><pre>Having your reasons in mind, I still think this is wrong to have the</pre><pre>branding in debian. The only still-relevant change which makes</pre><pre>debian/ubuntu packages different from upstream is enabling of user</pre><pre>shares by default (a change I think is very wrong exactly due to</pre><pre>it being different from upstream), and I want to address this (and</pre><pre>it still isn't very important in context of bug reports since if the</pre><pre>question will be about user shares it will be obvious they're enabled).</pre><pre>All the rest are just trivial bugfixes (or adjustments for inadequate</pre><pre>log levels - but which actually might be confusing when debugging), -</pre><pre>I especially refuse to change the code in a way which might change</pre><pre>behavior compared to the upstream samba.</pre></blockquote><pre><br></pre><pre>It is more about where files might be located, and if it was extended to include the full package version, it would allow absolute certainty on matching lines in debug messages to source. </pre><pre><br></pre><pre>It would be good to get the rest of the patches upstream if possible.</pre><pre><br></pre><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><pre>I definitely am not insisting on removing the branding, - once again,</pre><pre>it just felt unfair for the samba team to brand things like this,</pre><pre>like debian (or ubuntu) wrongly appropriated samba to themselves,</pre><pre>that's all.</pre></blockquote><pre><br></pre><pre>Packaging is an important part of the task of getting Samba to our users, but as I said before it really was asked for to aid debugging. </pre><pre><br></pre><pre>I'm pretty sure the SerNet samba.plus packages use this also, to likewise avoid confusion. </pre><pre><br></pre><pre>And now I need to go to our friends building RPM packages to see if we can get then do this also, I don't a reference to this in the Fedora Rawhide ;-)</pre><pre><br></pre><pre>Thanks for your understanding,</pre><pre><br></pre><pre>Andrew Bartlett</pre><pre>-- </pre><div><span><div style="width: 71ch;">Andrew Bartlett (he/him) <a href="https://samba.org/~abartlet/">https://samba.org/~abartlet/</a></div><div style="width: 71ch;" data-evo-signature-plain-text-mode="">Samba Team Member (since 2001) <a href="https://samba.org">https://samba.org</a></div><div style="width: 71ch;" data-evo-signature-plain-text-mode="">Samba Team Lead <a href="https://catalyst.net.nz/services/samba">https://catalyst.net.nz/services/samba</a></div><div style="width: 71ch;" data-evo-signature-plain-text-mode=""><span style="font-size: 17.333334px;">Catalyst.Net Ltd</span></div><div style="width: 71ch;" data-evo-signature-plain-text-mode=""><span style="font-size: 17.333334px;"><br></span></div><div style="width: 71ch;" data-evo-signature-plain-text-mode="">Proudly developing Samba for Catalyst.Net Ltd - a Catalyst IT group company</div><div style="width: 71ch;" data-evo-signature-plain-text-mode=""><br></div><div style="width: 71ch;" data-evo-signature-plain-text-mode="">Samba Development and Support: <a href="https://catalyst.net.nz/services/samba">https://catalyst.net.nz/services/samba</a></div><div style="width: 71ch;" data-evo-signature-plain-text-mode=""><br></div><div style="width: 71ch;" data-evo-signature-plain-text-mode="">Catalyst IT - Expert Open Source Solutions</div><div style="width: 71ch;" data-evo-signature-plain-text-mode=""><br></div><div style="width: 71ch;" data-evo-signature-plain-text-mode=""><br></div></span></div></body></html>