Bug#1034505: unblock (pre-approval): libsdl2/2.26.5+dfsg-1

[Simon McVittie]

Package: release.debian.org
Severity: normal
User: release.debian.org at packages.debian.org
Usertags: unblock
X-Debbugs-Cc: libsdl2 at packages.debian.org
Control: affects -1 + src:libsdl2

I've prepared a libsdl2 update for upstream stable release 2.26.5 and
I'd like to include it in bookworm if possible.

The most serious bug fixed here is a crash for fcitx users if libdbus
cannot be initialized (src/core/linux/SDL_fcitx.c, 1-line change). If
this upstream stable update is considered too large, I'll cherry-pick
that change and anything else the release team is willing to accept into
a 2.26.4-2 instead; but I'd prefer to take the whole release if we can.

[ Reason ]
New upstream stable release with various bug fixes

[ Impact ]
If not accepted, bookworm users will continue to suffer from various
fixable bugs, and taking further fixes from upstream's 2.26.x branch
will become more difficult.

[ Tests ]
Manually tested with some SDL games (openarena, 0ad, opentyrian,
nexuiz). There are autopkgtests and they pass, but they're marked
superficial because most of SDL is not really practical to test
automatically.

Corresponding changes are also included in libsdl2/experimental already.

A backported version of this package is likely to be included in the
next round of updates to Valve's Steam Runtime, providing wider end-user
testing.

[ Risks ]
I would say that the most likely regression from this update would be
an incorrect change to a game controller button/axis mapping, which is
easily fixed and can also be overridden with an environment variable.

The change in src/audio/SDL_audiocvt.c is probably not something I
would have included in a stable-branch if I was the upstream release
manager, but I'm not, and it does have new automated test coverage
(in test/testautomation_audio.c) so it seems safe enough.

All changes in src/joystick/iphoneos, src/video/cocoa, src/video/windows
are in code that Debian doesn't compile, so there's no risk for us
there. I filtered those out from the diff contents (they're still in
the diffstat).

Similarly, the changes in SDL_gamecontrollerdb.h from "GPD XD Plus"
down to end-of-file are #ifdef __ANDROID__ and so can be disregarded
in Debian (for simplicity I didn't filter these out from the diff), and
src/joystick/sort_controllers.py is used by upstream maintainers to help
to maintain that file but I don't think we run it during the Debian build.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing
      (lightly filtered to exclude files irrelevant to Debian, and the
      diff for a patch that is no longer applied)

[ Other info ]
If there are changes here that the release team would prefer not to see
in stable-branch updates, please let me know, and I can give feedback
to upstream. The stable-branches mainly exist for distros' benefit,
so if we're unable to accept them, that defeats their purpose.

unblock libsdl2/2.26.5+dfsg-1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libsdl2_2.26.5+dfsg-1.diff
Type: text/x-diff
Size: 79730 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-sdl-maintainers/attachments/20230417/b81d1fed/attachment-0001.diff>