Bug#1049222: libsdl2-image: Fails to build source after successful build

[Lucas Nussbaum]

Source: libsdl2-image
Version: 2.6.3+dfsg-2
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> --------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package libsdl2-image
> dpkg-buildpackage: info: source version 2.6.3+dfsg-2
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Simon McVittie <smcv at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    dh_auto_clean
> 	make -j8 distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> Making distclean in .
> make[2]: Entering directory '/<<PKGBUILDDIR>>'
> test -z "libSDL2_image.la" || rm -f libSDL2_image.la
> rm -rf .libs _libs
> rm -f *.o
> rm -f *.lo
> rm -f *.tab.c
> test -z "sdl2_image-config.cmake sdl2_image-config-version.cmake SDL2_image.spec SDL2_image.pc" || rm -f sdl2_image-config.cmake sdl2_image-config-version.cmake SDL2_image.spec SDL2_image.pc
> rm -f libtool config.lt
>  rm -f showimage showanim
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> test . = "." || test -z "" || rm -f 
> rm -f cscope.out cscope.in.out cscope.po.out cscope.files
> rm -f ./so_locations
> make[2]: Leaving directory '/<<PKGBUILDDIR>>'
> Making distclean in test
> make[2]: Entering directory '/<<PKGBUILDDIR>>/test'
> rm -rf .libs _libs
> rm -f *.test
> rm -f *.o
> test -z "testimage.log" || rm -f testimage.log
> rm -f *.lo
> rm -f save.jpg save.bmp CompareSurfaces*.bmp
>  rm -f testimage
> test -z "testimage.trs" || rm -f testimage.trs
> rm -f *.tab.c
> test -z "" || rm -f 
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> test -z "test-suite.log" || rm -f test-suite.log
> test . = "." || test -z "" || rm -f 
> rm -f ./.deps/testimage-main.Po
> rm -f Makefile
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/test'
> rm -f config.status config.cache config.log configure.lineno config.status.lineno
> rm -f ./.deps/IMG.Plo
> rm -f ./.deps/IMG_ImageIO.Plo
> rm -f ./.deps/IMG_WIC.Plo
> rm -f ./.deps/IMG_avif.Plo
> rm -f ./.deps/IMG_bmp.Plo
> rm -f ./.deps/IMG_gif.Plo
> rm -f ./.deps/IMG_jpg.Plo
> rm -f ./.deps/IMG_jxl.Plo
> rm -f ./.deps/IMG_lbm.Plo
> rm -f ./.deps/IMG_pcx.Plo
> rm -f ./.deps/IMG_png.Plo
> rm -f ./.deps/IMG_pnm.Plo
> rm -f ./.deps/IMG_qoi.Plo
> rm -f ./.deps/IMG_stb.Plo
> rm -f ./.deps/IMG_svg.Plo
> rm -f ./.deps/IMG_tga.Plo
> rm -f ./.deps/IMG_tif.Plo
> rm -f ./.deps/IMG_webp.Plo
> rm -f ./.deps/IMG_xcf.Plo
> rm -f ./.deps/IMG_xpm.Plo
> rm -f ./.deps/IMG_xv.Plo
> rm -f ./.deps/showanim.Po
> rm -f ./.deps/showimage.Po
> rm -f Makefile
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean
>    dh_clean
>  dpkg-source -b .
> dpkg-source: warning: upstream signing key but no upstream tarball signature
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building libsdl2-image using existing ./libsdl2-image_2.6.3+dfsg.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: ignoring deletion of file SDL2_image.spec, use --include-removal to override
> dpkg-source: error: cannot represent change to test/save.JPG: binary file contents changed
> dpkg-source: error: add test/save.JPG in debian/source/include-binaries if you want to store the modified binary in the debian tarball
> dpkg-source: error: cannot represent change to test/save.PNG: binary file contents changed
> dpkg-source: error: add test/save.PNG in debian/source/include-binaries if you want to store the modified binary in the debian tarball
> dpkg-source: error: cannot represent change to test/saveRwops.JPG: binary file contents changed
> dpkg-source: error: add test/saveRwops.JPG in debian/source/include-binaries if you want to store the modified binary in the debian tarball
> dpkg-source: error: cannot represent change to test/saveRwops.PNG: binary file contents changed
> dpkg-source: error: add test/saveRwops.PNG in debian/source/include-binaries if you want to store the modified binary in the debian tarball
> dpkg-source: error: unrepresentable changes to source
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 1
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/libsdl2-image_2.6.3+dfsg-2_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.