<div dir="ltr"><div>Hi,</div><div><br></div><div>I'd like to add a new key value in the login.defs file to select the HMAC algorithm used in pam_timestamp module. I already have a PR in pam repository [<a href="https://github.com/linux-pam/linux-pam/pull/342">1</a>] that changes the actual hmac implementation embedded in pam_timestamp for one that is provided by openssl. This library provides several algorithms to calculate the HMAC message and in order to select the algorithm I decided to get the configure from login.defs.</div><div><br></div><div>That brings me to my questions:<br></div><ol><li>Would the shadow-utils project be willing to accept a PR that adds this new key value?</li><li>Do you think "<span class="gmail-blob-code-inner gmail-blob-code-marker"><span class="gmail-pl-s"><span class="gmail-pl-pds"></span>HMAC_CRYPTO_ALGO<span class="gmail-pl-pds">" is a sufficiently meaningful name for the key?<br></span></span></span></li></ol><div><br></div><div>Links:</div><div>[1] <a href="https://github.com/linux-pam/linux-pam/pull/342">https://github.com/linux-pam/linux-pam/pull/342</a></div><div><br>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>
<p style="font-weight:bold;margin:0px;padding:0px;font-size:14px;font-family:"RedHatText",sans-serif">
<span>Iker</span> <span>Pedrosa</span><span style="color:rgb(170,170,170);margin:0px"></span>
</p>
<p style="font-weight:normal;font-size:12px;margin:0px;font-family:"RedHatText",sans-serif">
<span>Software Engineer, Identity Management team</span>
</p>
<p style="font-weight:normal;margin:0px 0px 4px;font-size:12px;font-family:"RedHatText",sans-serif">
<a style="color:rgb(0,136,206);font-size:12px;margin:0px;text-decoration:none;font-family:"RedHatText",sans-serif" href="https://www.redhat.com" target="_blank">Red Hat <span></span></a>
</p>
<div style="margin-bottom:4px">
</div>
<div style="margin-top:12px">
<table border="0">
<tbody><tr>
<td width="100px"><a href="https://www.redhat.com" target="_blank"> <img src="https://static.redhat.com/libs/redhat/brand-assets/2/corp/logo--200.png" width="90" height="auto"></a> </td>
</tr>
</tbody></table>
</div>
</div></div></div></div></div>