<div dir="ltr"><div>Hi Anuj,</div><div><br></div><div>I'm having difficulties understanding your proposal.<br></div><div><br></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Apr 23, 2021 at 7:31 AM Anuj Borah <<a href="mailto:aborah@redhat.com">aborah@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hi,</div><div><br></div><div>After discussing with our team, we have decided that we will test and review the pytest script on sssd CI platform then we will send the scripts to : <span><a href="https://github.com/shadow-maint/shadow/tree/master/tests" rel="noreferrer" target="_blank">https://github.com/shadow-maint/shadow/tree/master/tests</a><br></span></div><div><br></div><div>sssd repo: <a href="https://github.com/SSSD/sssd" target="_blank">https://github.com/SSSD/sssd</a></div><div><br></div></div></blockquote><div><br></div><div>IIUC, you are proposing to check that the test scripts are correctly executed by opening a PR in sssd repository. But what about the peer review? Where will it happen? I think that the right place to do it is shadow-utils repository.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div><div><br></div><div>This is because there are very few bash shadow utils test cases here with us that will be ported to pytest and if we try to configure new CI on shadow utils repo it will take much more time and effort , which does not make sense for a very few test cases . Our sssd CI is configured and working which we would like to utilize for this task .</div><div><br></div><div>For every PR sent to shadow utils repo we will attach the PR send for CI test and review on sssd repo.<br></div></div></blockquote><div><br></div><div>IIUC, what you are proposing is that the shadow-utils PRs will have some type of mirror in the sssd repository to be able to test them using the CI included in that repository? Isn't this more difficult than configuring the CI directly in the shadow-utils repository?<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div><div><br></div><div>Please let me know what you think ?</div><div><br></div><div>Regards</div><div>Anuj Borah <br></div><div><br></div><div><br></div><div><br></div><div><br></div><div><span></span></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Apr 19, 2021 at 5:20 PM Serge E. Hallyn <<a href="mailto:serge@hallyn.com" target="_blank">serge@hallyn.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, Apr 19, 2021 at 04:27:58PM +0530, Anuj Borah wrote:<br>
> Hi<br>
> <br>
> We have some bash test cases for shadow utils which we are porting to<br>
> pytest .<br>
> <br>
> I have visited : <a href="https://github.com/shadow-maint/shadow/tree/master/tests" rel="noreferrer" target="_blank">https://github.com/shadow-maint/shadow/tree/master/tests</a><br>
> <br>
> There I can see tests are in c and bash .<br>
> <br>
> So my questions will be :<br>
> <br>
> 1. Is it possible to put pytest cases on upstream shadow utils repo.<br>
<br>
Yes, that would be great.<br>
<br>
> 2. Is it possible to import our sssd test library there to run those test<br>
> cases on CI .<br>
<br>
Should be, yeah.<br>
<br>
> Please let me know.<br>
> <br>
> <br>
> Regards<br>
> Anuj Borah(redhat QE sssd )<br>
<br>
> _______________________________________________<br>
> Pkg-shadow-devel mailing list<br>
> <a href="mailto:Pkg-shadow-devel@alioth-lists.debian.net" target="_blank">Pkg-shadow-devel@alioth-lists.debian.net</a><br>
> <a href="https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-shadow-devel" rel="noreferrer" target="_blank">https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-shadow-devel</a><br>
<br>
</blockquote></div>
_______________________________________________<br>
Pkg-shadow-devel mailing list<br>
<a href="mailto:Pkg-shadow-devel@alioth-lists.debian.net" target="_blank">Pkg-shadow-devel@alioth-lists.debian.net</a><br>
<a href="https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-shadow-devel" rel="noreferrer" target="_blank">https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-shadow-devel</a><br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div>
<p style="font-weight:bold;margin:0px;padding:0px;font-size:14px;font-family:"RedHatText",sans-serif">
<span>Iker</span> <span>Pedrosa</span><span style="color:rgb(170,170,170);margin:0px"></span>
</p>
<p style="font-weight:normal;font-size:12px;margin:0px;font-family:"RedHatText",sans-serif">
<span>Software Engineer, Identity Management team</span>
</p>
<p style="font-weight:normal;margin:0px 0px 4px;font-size:12px;font-family:"RedHatText",sans-serif">
<a style="color:rgb(0,136,206);font-size:12px;margin:0px;text-decoration:none;font-family:"RedHatText",sans-serif" href="https://www.redhat.com" target="_blank">Red Hat <span></span></a>
</p>
<div style="margin-bottom:4px">
</div>
<div style="margin-top:12px">
<table border="0">
<tbody><tr>
<td width="100px"><a href="https://www.redhat.com" target="_blank"> <img src="https://static.redhat.com/libs/redhat/brand-assets/2/corp/logo--200.png" width="90" height="auto"></a> </td>
</tr>
</tbody></table>
</div>
</div></div></div></div>