Bug#819416: shibboleth-sp2: FTBFS when built with dpkg-buildpackage -A (dh_install: missing files, aborting)

[Santiago Vila]

Package: src:shibboleth-sp2
Version: 2.5.6+dfsg1-1
User: sanvila at debian.org
Usertags: binary-indep
Severity: important

Dear maintainer:

I tried to build this package with "dpkg-buildpackage -A"
(i.e. only architecture-independent packages), and it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --parallel --with apache2,autoreconf
   dh_testdir -i -O--parallel
   dh_update_autotools_config -i -O--parallel
   debian/rules override_dh_autoreconf
make[1]: Entering directory '/<<BUILDDIR>>/shibboleth-sp2-2.5.6+dfsg1'
dh_autoreconf --as-needed
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
libtoolize: copying file 'build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'

[... snipped ...]

make[5]: Entering directory '/<<BUILDDIR>>/shibboleth-sp2-2.5.6+dfsg1/odbc-store'
for la in odbc-store.la ; do rm -f /<<BUILDDIR>>/shibboleth-sp2-2.5.6+dfsg1/debian/tmp/usr/lib/x86_64-linux-gnu/shibboleth/$la ; done
make[5]: Leaving directory '/<<BUILDDIR>>/shibboleth-sp2-2.5.6+dfsg1/odbc-store'
make[4]: Leaving directory '/<<BUILDDIR>>/shibboleth-sp2-2.5.6+dfsg1/odbc-store'
make[3]: Leaving directory '/<<BUILDDIR>>/shibboleth-sp2-2.5.6+dfsg1/odbc-store'
make[3]: Entering directory '/<<BUILDDIR>>/shibboleth-sp2-2.5.6+dfsg1'
make[4]: Entering directory '/<<BUILDDIR>>/shibboleth-sp2-2.5.6+dfsg1'
make[4]: Nothing to be done for 'install-exec-am'.
make[4]: Nothing to be done for 'install-data-am'.
make[4]: Leaving directory '/<<BUILDDIR>>/shibboleth-sp2-2.5.6+dfsg1'
make[3]: Leaving directory '/<<BUILDDIR>>/shibboleth-sp2-2.5.6+dfsg1'
make[2]: Leaving directory '/<<BUILDDIR>>/shibboleth-sp2-2.5.6+dfsg1'
rm -r debian/tmp/var/run
for i in CREDITS.txt LICENSE.txt NOTICE.txt README.txt RELEASE.txt \
    FASTCGI.LICENSE OPENSSL.LICENSE LOG4CPP.LICENSE; do \
    rm debian/tmp/usr/share/doc/shibboleth-*/$i; \
done
rm debian/tmp/etc/shibboleth/*.dist
rm debian/tmp/etc/shibboleth/*.config
rm debian/tmp/etc/shibboleth/shibd-amazon
rm debian/tmp/etc/shibboleth/shibd-osx.plist
rm debian/tmp/etc/shibboleth/shibd-redhat
rm debian/tmp/etc/shibboleth/shibd-suse
mkdir -p debian/tmp/usr/include/x86_64-linux-gnu/shibsp
mv debian/tmp/usr/include/shibsp/paths.h \
    debian/tmp/usr/include/x86_64-linux-gnu/shibsp/
make[1]: Leaving directory '/<<BUILDDIR>>/shibboleth-sp2-2.5.6+dfsg1'
   debian/rules override_dh_install
make[1]: Entering directory '/<<BUILDDIR>>/shibboleth-sp2-2.5.6+dfsg1'
dh_install --fail-missing
dh_install: etc/shibboleth/shibd-systemd exists in debian/tmp but is not installed to anywhere
dh_install: etc/shibboleth/metagen.sh exists in debian/tmp but is not installed to anywhere
dh_install: etc/shibboleth/keygen.sh exists in debian/tmp but is not installed to anywhere
dh_install: etc/shibboleth/shibd-debian exists in debian/tmp but is not installed to anywhere
dh_install: missing files, aborting
debian/rules:61: recipe for target 'override_dh_install' failed
make[1]: *** [override_dh_install] Error 2
make[1]: Leaving directory '/<<BUILDDIR>>/shibboleth-sp2-2.5.6+dfsg1'
debian/rules:28: recipe for target 'binary-indep' failed
make: *** [binary-indep] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-indep gave error exit status 2
--------------------------------------------------------------------------------

Sorry not to have a fix, as I am reporting many bugs similar to
this one. The common hints are:

* If the only architecture-independent packages are dummy transitional
ones and they were released with jessie, the easy fix is to drop them
now.

* When using "dh", it is allowed to use (independently)
optional targets override_dh_foo-arch and override_dh_foo-indep
(for several values of "foo").


Once that both "dpkg-buildpackage -A" and "dpkg-buildpackage -B" work
properly, the package would be suitable to be uploaded in source-only
form if you wish.

Thanks.