<html><head></head><body>Probably not, unless some other code change changes the conventional fd to no block. I added it only for symmetry sake. It does not fix any currently known bug. <br><br><div class="gmail_quote">On February 13, 2019 9:54:12 AM PST, Andreas Metzler <ametzler@bebt.de> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2019-02-13 "Torrance, Douglas" <dtorrance@piedmont.edu> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">On 12/27/18 3:48 PM, Nye Liu wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">Package: wmbiff<br>Version: 0.4.31-1<br>Severity: important<br>Tags: upstream patch<br></blockquote></blockquote> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">If gnutls_read() or read() report EAGAIN, tlscomm_expect() fails:<br></blockquote></blockquote> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">wmbiff/nyet comm: wrote a000 CAPABILITY<br>wmbiff/nyet comm: imap.***.***:993: expecting: * CAPABILITY<br>wmbiff/nyet comm: imap.***.***:993: gnutls error reading: Resource temporarily unavailable, try again.<br>wmbiff/nyet imap4: unable to query capability stringwmbiff/nyet comm: wrote a002 LOGOUT<br>wmbiff/nyet comm: imap.***.***:993: closing.<br></blockquote></blockquote><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Thanks for the bug report and patch! I submitted the patch upstream [1] <br>and released a new version of wmbiff [2].<br></blockquote><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Andreas, I've pushed a new Debian package to git [3]. Would you be able <br>to review and sponsor?<br></blockquote><br>Hello,<br><br>I am not sure about the second part of the patch. I understand wmbiff<br>breaking on GNUTLS_E_AGAIN from gnutls_read, because this only started<br>to happen recently (with TLS1.3) on blocking sockets.<br><br>What I do not get from my rudimentary understanding C programmimg is the<br>second part, this is in the else of "if (scs->tls_state)", so, afaiui for<br>non-encrypted connections. Is the change necessary there at all, is it<br>the right thing to retry read on EAGAIN then?<br><br>cu Andreas<br></pre></blockquote></div><br>-- <br>Sent from my Android device with K-9 Mail. Please excuse my brevity.</body></html>