[Pkg-zfsonlinux-devel] Bug#1030316: Bug#1030316: trim script always exits 1 despite not failing

наб nabijaczleweli at nabijaczleweli.xyz
Sat Apr 1 23:46:37 BST 2023


Control: tags -1 + patch
Control: retitle -1 zfsutils-linux: trim script exits 1 if last pool not nvme-only

Got the attached mail today from sd-cron; a quick skim reveals
this is because the final pipeline exits 1 because I used a && as an if;
there's some merit to catching errors from t_i_n_a_t,
so spell it the long way with if instead of || : or explicit exit 0.

With this patch the script exits 0 on the same system
(single HDD-only pool).

Best,
наб
-------------- next part --------------
An embedded message was scrubbed...
From: root at szarotka.nabijaczleweli.xyz (systemd-cron)
Subject: [szarotka] job cron-zfsutils-linux-root-0 failed
Date: Sat, 01 Apr 2023 22:24:39 -0000
Size: 2365
URL: <http://alioth-lists.debian.net/pipermail/pkg-zfsonlinux-devel/attachments/20230402/0d7350bf/attachment.eml>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lib-zfs-linux-trim-don-t-exit-1-if-last-pool-isn-t-n.patch
Type: text/x-diff
Size: 1148 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-zfsonlinux-devel/attachments/20230402/0d7350bf/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-zfsonlinux-devel/attachments/20230402/0d7350bf/attachment.sig>


More information about the Pkg-zfsonlinux-devel mailing list