[From nobody Fri Jul  3 10:49:06 2026
Received: (at submit) by bugs.debian.org; 10 Jul 2021 05:30:57 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.2-bugs.debian.org_2005_01_02
 (2018-09-13) on buxtehude.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-17.0 required=4.0 tests=BAYES_00,DIGITS_LETTERS,
 FOURLA,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FROMDEVELOPER,
 FVGT_m_MULTI_ODD,HAS_PACKAGE,HEADER_FROM_DIFFERENT_DOMAINS,
 RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP
 autolearn=ham autolearn_force=no
 version=3.4.2-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 48; hammy, 142; neutral, 54; spammy,
 1. spammytokens:0.952-+--deals hammytokens:0.000-+--H*RU:sk:happyar,
 0.000-+--H*rp:U*happyaron.xu, 0.000-+--H*r:209.85.208,
 0.000-+--Hx-spam-relays-external:sk:happyar, 0.000-+--zfslinux
Return-path: <happyaron.xu@gmail.com>
Received: from mail-lj1-f178.google.com ([209.85.208.178]:33410)
 by buxtehude.debian.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.92) (envelope-from <happyaron.xu@gmail.com>)
 id 1m25Zp-0005mT-Gc
 for submit@bugs.debian.org; Sat, 10 Jul 2021 05:30:57 +0000
Received: by mail-lj1-f178.google.com with SMTP id u14so915853ljh.0
 for <submit@bugs.debian.org>; Fri, 09 Jul 2021 22:30:56 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
 bh=sLDa7cugzXApFhQhfyd6gYBuo45GAQIQliDYBsrfewo=;
 b=kS3jpCshZzjhowiColQvseoHwMBGFQSFRjUWZ77aAODj4cO25WCEdsDs2JQIayObox
 BYiwY3QJ+4a0/ghfXLHhPCtQWskEAm4xjrtdVMt65NVJqeLfB9G98o8ide4OrldnwnmE
 tO1u9PHxCTMXq2V+k7JPWVO3yncdzqNDv6Ihzrj3cIK1Wt9Q04qEY46u/lZBga13XFW9
 ECJh7DgOdphr+FhenRG1RHqN1KRTpZHvW+l1yH4OOgfpWQyGHL1cIXUIiuAZ6CA0Eh9Y
 Qwcc/tv+KbrS+CoPt0OPdwNSW8+4DDAr6VixjaiaFiRlB4vSIlFvPlZAhWg2XCgWe9Zl
 HhxA==
X-Gm-Message-State: AOAM5328q0gLLo2SZPaHGmA/hqCTfe5VEaz5UWp+xIaY6KT9B6iAmuNU
 qynZv/S8MVVf8+b6W2WkTDAimoOHGsXOR739N1f16Kwnf2I=
X-Google-Smtp-Source: ABdhPJyktmAtw0au5Vs84iBdMneye93FxfI0gWgx9DC46KMZ6FB15tQmELV7+1zlZTMzLX3jO5JPgx7mLHMmh7FeZTg=
X-Received: by 2002:a05:651c:10b2:: with SMTP id
 k18mr29553422ljn.38.1625895053624; 
 Fri, 09 Jul 2021 22:30:53 -0700 (PDT)
MIME-Version: 1.0
From: Aron Xu <aron@debian.org>
Date: Sat, 10 Jul 2021 13:30:44 +0800
Message-ID: <CAMr=8w6uF4nZefPGVi8yk6YbMRL0DHeftm8G2UBnhfdN_Dcgyw@mail.gmail.com>
Subject: zfs-linux: periodic-trim should deal with SATA SSD with protocol > 3.0
To: Debian Bug Tracking System <submit@bugs.debian.org>
Content-Type: text/plain; charset="UTF-8"
Delivered-To: submit@bugs.debian.org

Package: src:zfs-linux
Version: 2.0.3-3
Severity: normal

periodic-trim's current behavior only deals with NVMe-only pools, to
be more clear this means all SSDs in the pool are using NVMe protocol.
This is not sufficient since there are many new SATA SSDs that come
with protocol version > 3.0.

For reference:

=== START OF INFORMATION SECTION ===
Model Family: Sandisk SATA Cloudspeed Max and GEN2 ESS SSDs
Device Model: SDLF1CRR-019T-1HA1
Serial Number: A028D942
LU WWN Device Id: 5 001173 101148678
Firmware Version: ZR11RPA1
User Capacity: 1,920,383,410,176 bytes [1.92 TB]
Sector Sizes: 512 bytes logical, 4096 bytes physical
Rotation Rate: Solid State Device
Device is: In smartctl database [for details use: -P show]
ATA Version is: ATA8-ACS T13/1699-D revision 4c
SATA Version is: SATA 3.1, 6.0 Gb/s (current: 6.0 Gb/s)
Local Time is: Sat Jul 10 13:08:52 2021 CST
SMART support is: Available - device has SMART capability.
SMART support is: Enabled

=== START OF INFORMATION SECTION ===
Device Model: Samsung SSD 870 QVO 8TB
Serial Number: S5SSNF0R400589B
LU WWN Device Id: 5 002538 f4147f25e
Firmware Version: SVQ01B6Q
User Capacity: 8,001,563,222,016 bytes [8.00 TB]
Sector Size: 512 bytes logical/physical
Rotation Rate: Solid State Device
Form Factor: 2.5 inches
Device is: Not in smartctl database [for details use: -P showall]
ATA Version is: ACS-4 T13/BSR INCITS 529 revision 5
SATA Version is: SATA 3.3, 6.0 Gb/s (current: 6.0 Gb/s)
Local Time is: Sat Jul 10 13:06:12 2021 CST
SMART support is: Available - device has SMART capability.
SMART support is: Enabled
]