[Pkg-zsh-devel] Review request (was: Refreshing patches for z-sy-h 0.7.0)

Daniel Shahaf danielsh at apache.org
Thu Aug 1 16:10:09 BST 2019


Good morning Axel,

Axel Beckert wrote on Thu, Aug 01, 2019 at 10:23:04 +0200:
> Daniel Shahaf wrote:
> > https://salsa.debian.org/debian/zsh-syntax-highlighting/commit/e2fe8d5cbbc9eedeaf6893248aff642cb80b470b
> 
> Fair enough. There are other communities where the signatures are made
> differently, too, especially CPAN, but IIRC the Perl Team just ignores
> these (low-severity) warning instead of overriding them in several
> thousand packages.

Understood, but on the other hand, I do like build processes that output
nothing when there's nothing to do.¹  Besides, the issue doesn't affect
consumers of the source package, and as to future maintainers, the
package specifics are documented in the debian/ dir and (as of 30
seconds ago) in the upstream "how to roll a release" docs.

> Easiest way to test if the setup is correct — in case you haven't
> found out now: Running "autopkgtest -B ./ --- null" in the unpacked
> source package given that the built package and all its dependencies
> are installed. It's only a 90% check as it doesn't run the tests in a
> clean chroot but your own system. But that suffices to check it the
> autopkgtest setup generally works.

Thanks.  I do have a «autopkgtest $BUILDRESULT/*.changes -- null» in my
shell history, so I assume I've figured it out.  I probably tried it in
a sid chroot too, on general principles, but I don't keep shell
histories of chroots so I can't prove I did that. ☺

Thanks for the review!

Daniel

¹ <shameless plug>z-sy-h ships a stdin-to-stdout filter of TAP output:
tests/tap-filter.</shameless plug>



More information about the Pkg-zsh-devel mailing list