<div dir="ltr"><div>Hello Sergio, <br></div><div><br></div><div>I am really sorry for the delay. <br></div><div><br></div><div>I finish the update of pcapy package. I push the commit, but is on UNRELEASED status. <br></div><div><br></div><div>Please, check if whole the things are ok, and then I will make change to unstable status on d/changelog</div><div><br></div><div>Thanks!</div><div>Regards!<br></div></div><br><div class="gmail_quote"><div dir="ltr">El lun., 2 de jul. de 2018 a la(s) 21:36, eamanu15 <<a href="mailto:emmanuelarias30@gmail.com">emmanuelarias30@gmail.com</a>> escribió:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hello Sergio, <br></div><div><br></div><div><span id="m_-9003950800879775159inbox-inbox-result_box" class="m_-9003950800879775159inbox-inbox-short_text" lang="en"><span class="m_-9003950800879775159inbox-inbox-">Sorry for the delay in my response.</span></span></div><div><span id="m_-9003950800879775159inbox-inbox-result_box" class="m_-9003950800879775159inbox-inbox-short_text" lang="en"><span class="m_-9003950800879775159inbox-inbox-"><br></span></span></div><div><span id="m_-9003950800879775159inbox-inbox-result_box" class="m_-9003950800879775159inbox-inbox-short_text" lang="en"><span class="m_-9003950800879775159inbox-inbox-">In this week I will work on your reviews. When I fix the problems I will push to salsa and will let it know you.<br></span></span></div><div><span id="m_-9003950800879775159inbox-inbox-result_box" class="m_-9003950800879775159inbox-inbox-short_text" lang="en"><span class="m_-9003950800879775159inbox-inbox-"><br></span></span></div><div><span id="m_-9003950800879775159inbox-inbox-result_box" class="m_-9003950800879775159inbox-inbox-short_text" lang="en"><span class="m_-9003950800879775159inbox-inbox-">Thanks!</span></span></div><div><span id="m_-9003950800879775159inbox-inbox-result_box" class="m_-9003950800879775159inbox-inbox-short_text" lang="en"><span class="m_-9003950800879775159inbox-inbox-">Regards!</span></span></div><div><span id="m_-9003950800879775159inbox-inbox-result_box" class="m_-9003950800879775159inbox-inbox-short_text" lang="en"><span class="m_-9003950800879775159inbox-inbox-">Emmanuel<br></span></span></div></div><br><div class="gmail_quote"><div dir="ltr">El sáb., 16 de jun. de 2018 a la(s) 16:38, Sergio Durigan Junior <<a href="mailto:sergiodj@debian.org" target="_blank">sergiodj@debian.org</a>> escribió:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Control: owner -1 !<br>
Control: tags -1 + moreinfo<br>
<br>
On Thursday, June 07 2018, eamanu wrote:<br>
<br>
> Dear mentors,<br>
><br>
> I am looking for a sponsor for my package "pcapy"<br>
><br>
> * Package name : pcapy<br>
> Version : 0.11.3-1<br>
> Upstream Author : Core Security <<a href="mailto:oss@coresecurity.com" target="_blank">oss@coresecurity.com</a>><br>
> * URL : <a href="https://github.com/CoreSecurity/pcapy" rel="noreferrer" target="_blank">https://github.com/CoreSecurity/pcapy</a><br>
> * License : Apache Software License<br>
> Section : python<br>
><br>
> It builds those binary packages:<br>
><br>
> python-pcapy - Python interface to the libpcap packet capture library<br>
><br>
> To access further information about this package, please visit the<br>
> following URL:<br>
><br>
> <a href="https://mentors.debian.net/package/pcapy" rel="noreferrer" target="_blank">https://mentors.debian.net/package/pcapy</a><br>
><br>
><br>
> Alternatively, one can download the package with dget using this command:<br>
><br>
> dget -x<br>
> <a href="https://mentors.debian.net/debian/pool/main/p/pcapy/pcapy_0.11.3-1.dsc" rel="noreferrer" target="_blank">https://mentors.debian.net/debian/pool/main/p/pcapy/pcapy_0.11.3-1.dsc</a><br>
><br>
> More information about hello can be obtained from <a href="https://www.example.com" rel="noreferrer" target="_blank">https://www.example.com</a>.<br>
><br>
> Changes since the last upload:<br>
><br>
> [ Jakub Wilk ]<br>
> * Use canonical URIs for Vcs-* fields.<br>
><br>
> [ Ondřej Nový ]<br>
> * Fixed VCS URL (https)<br>
> * d/control: Set Vcs-* to <a href="http://salsa.debian.org" rel="noreferrer" target="_blank">salsa.debian.org</a><br>
> * d/changelog: Remove trailing whitespaces<br>
> * Remove debian/pycompat, it's not used by any modern Python helper<br>
><br>
> [ Emmanuel Arias ]<br>
> * new upstream version<br>
> * update d/watch to download correctly the last upstream version<br>
> * update d/control to add Maintainer the DPMT<br>
> * update d/control to add me to Uploaders field (Closes: #895787)<br>
> * update debhelper on d/contorl from 5.0.37.2 to 11<br>
> * update Standards-Version from 3.9.2 to 4.1.4 on d/control<br>
> * add Testsuite: autopkgtest-pkg-python on d/control<br>
> * update d/compat from 5 to 11<br>
> * add to copyright file the debian files copyright<br>
<br>
Hi Emmanuel,<br>
<br>
Thanks for the package, and for your interest in adopting it! The first<br>
question I have is about the VCS. I tried finding your commits on the<br>
official Salsa repo, but wasn't able to. Are you using any other<br>
repository for that? It's much easier to review the changes when<br>
there's a repository, and I strongly suggest you use the official one<br>
for the packaging.<br>
<br>
As for the review, here's what I'd like you to address:<br>
<br>
1) d/copyright should follow DEP-5. Take a look at:<br>
<br>
<a href="https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/" rel="noreferrer" target="_blank">https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/</a><br>
<br>
and you'll be able to find instructions on the format of the file. It<br>
shouldn't be too hard for you to convert the existing file.<br>
<br>
2) The package doesn't need CDBS anymore, so you can safely remove it<br>
from the Build-Depends line.<br>
<br>
3) The "Homepage" field can have a better URL:<br>
<br>
<a href="https://www.coresecurity.com/corelabs-research/open-source-tools/pcapy" rel="noreferrer" target="_blank">https://www.coresecurity.com/corelabs-research/open-source-tools/pcapy</a><br>
<br>
4) You should consider packaging a Python 3 package, as well as the<br>
Python 2 you're already packaging (in which case you could probably<br>
split the documentation part into its own package). If Python 3 is not<br>
supported, you should contact upstream and probably file a bug against<br>
it.<br>
<br>
5) Any reason why the package has "Suggests: doc-base"?<br>
<br>
6) It's a good habit to export the PYBUILD_NAME variable (on d/rules):<br>
<br>
export PYBUILD_NAME=pcapy<br>
<br>
This variable tells pybuild what's the name of your project.<br>
<br>
7) It's a good idea to use (on d/rules):<br>
<br>
export DEB_BUILD_MAINT_OPTIONS = hardening=+all<br>
<br>
since your package is building a shlib.<br>
<br>
8) The package is installing the LICENSE file by default, but this is<br>
not needed since we have the d/copyright file. Therefore, it'd be good<br>
if you could remove this file from the package. You can do that by<br>
e.g. overriding dh_auto_install and rm'ing the file there.<br>
<br>
<br>
I think that's basically everything I've spotted. Please let me know if<br>
you need any help.<br>
<br>
Cheers,<br>
<br>
-- <br>
Sergio<br>
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36<br>
Please send encrypted e-mail if possible<br>
<a href="http://sergiodj.net/" rel="noreferrer" target="_blank">http://sergiodj.net/</a><br>
</blockquote></div>-- <br><div dir="ltr" class="m_-9003950800879775159gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>Arias Emmanuel</div><div><a href="https://www.linkedin.com/in/emmanuel-arias-437a6a8a" target="_blank">https://www.linkedin.com/in/emmanuel-arias-437a6a8a</a><br></div><a href="http://eamanu.com" target="_blank">http://eamanu.com</a><br></div></div>
</blockquote></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>Arias Emmanuel</div><div><a href="https://www.linkedin.com/in/emmanuel-arias-437a6a8a">https://www.linkedin.com/in/emmanuel-arias-437a6a8a</a><br></div><a href="http://eamanu.com">http://eamanu.com</a><br></div></div>