<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">Hello Sergio, <br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">I made the changes!</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">Thanks for your help</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">regards!</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">Emmanuel<br></div><br><div class="gmail_quote"><div dir="ltr">El mié., 22 de ago. de 2018 a la(s) 01:59, Sergio Durigan Junior (<a href="mailto:sergiodj@debian.org">sergiodj@debian.org</a>) escribió:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Emmanuel,<br>
<br>
Sorry, you still have to fix a few things before the package is ready<br>
for upload. We're almost there; don't give up!<br>
<br>
On Tuesday, August 21 2018, eamanu wrote:<br>
<br>
> No problem. However, the "License:" still doesn't reflect the license<br>
>> of the software. According to LICENSE:<br>
>><br>
>> We provide this software under a slightly modified version of the<br>
>> Apache Software License. The only changes to the document were the<br>
>> replacement of "Apache" with "Pcapy" and "Apache Software Foundation"<br>
>> with "CORE Security Technologies". Feel free to compare the resulting<br>
>> document to the official Apache license.<br>
>><br>
>> The `Apache Software License' is an Open Source Initiative Approved<br>
>> License.<br>
>><br>
>> Therefore, I think a better value for the field would be:<br>
>><br>
>> License: Apache with Pcapy modifications<br>
>><br>
><br>
> Ready!<br>
<br>
Thanks. The "License:" must be the same in both places, though. Here:<br>
<br>
Files: *<br>
Copyright (C) 2014 CORE Security Technologies <<a href="mailto:oss@coresecurity.com" target="_blank">oss@coresecurity.com</a>>. <br>
License: Apache Software License with Pcapy modifications<br>
<br>
and here:<br>
<br>
License: Apache with Pcapy modifications<br>
We provide this software under a slightly modified version of the<br>
...<br>
<br>
It's OK to use "Apache with Pcapy modifications" in both places.<br>
<br>
>> I see that the contributions under the debian/ directory are released<br>
>> under GPL-3+. That's absolutely fine (I am a GPL advocate as well).<br>
>> However, I must warn you that the Debian patches will also be released<br>
>> under this license, which may be problematic if/when you decide to<br>
>> upstream them. But I understand this is the current situation anyway.<br>
>> You may want to try to contact Arnaud Fontaine and ask him if he's OK<br>
>> with changing the license to Apache in the future.<br>
>><br>
><br>
> Ok. I will contact Arnaud Fontaine to ask about it. I think it's ok for<br>
> now. In the next release of package I can update this field.<br>
<br>
Great. It's OK for now, indeed.<br>
<br>
> Thanks, but what you did is incomplete. In order to create a new<br>
>> package, you have to create an entry for it on d/control. What you did<br>
>> (add ${python3:Depends} to python-pcapy's Depends) is wrong because<br>
>> you're basically pulling Python 3 dependencies for a Python 2 package.<br>
>> Please have a look at other packages under them DPMT and check their<br>
>> d/control; you will find many examples of how to create Python 3<br>
>> packages.<br>
>><br>
><br>
> Ready!<br>
<br>
Thanks, that's better, but there are still a few things that need<br>
fixing.<br>
<br>
1) It's a good practice to explicitly say if the package is a Python 2<br>
or Python 3 module. We do that by suffixing the short description with<br>
"(Python X)" (where X is 2 or 2), and by appending "This package<br>
installs the library for Python X." to the long description. Like this:<br>
<br>
Package: python-pcapy<br>
Architecture: any<br>
Depends: ${python:Depends}, ${shlibs:Depends}, ${misc:Depends}<br>
Recommends: python-impacket<br>
Description: Python interface to the libpcap packet capture library (Python 2)<br>
Pcapy is a Python extension module that interfaces with the libpcap<br>
packet capture library.<br>
.<br>
Pcapy enables Python scripts to capture packets on the network. Pcapy<br>
is highly effective when used in conjunction with a packet-handling<br>
package such as Impacket, which is a collection of Python classes for<br>
constructing and dissecting network packets.<br>
.<br>
This package installs the library for Python 2.<br>
<br>
2) You don't need to specify "Provides:". Please remove them from both<br>
packages.<br>
<br>
<br>
As a last note, it seems that you forgot to push the "upstream" and<br>
"pristine-tar" branches, so I can't really build the package locally<br>
here. Please do that.<br>
<br>
Thanks,<br>
<br>
-- <br>
Sergio<br>
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36<br>
Please send encrypted e-mail if possible<br>
<a href="http://sergiodj.net/" rel="noreferrer" target="_blank">http://sergiodj.net/</a><br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div><font size="1"><span style="font-family:verdana,sans-serif"></span><span style="font-family:arial narrow,sans-serif">Arias Emmanuel</span></font></div><div><span style="font-family:arial narrow,sans-serif"><font size="1"><a href="http://eamanu.com" target="_blank">http://eamanu.com</a><br></font></span></div><div><span style="font-family:arial narrow,sans-serif"><font size="1">Github/Gitlab; @eamanu<br></font></span></div><div><span style="font-family:arial narrow,sans-serif"><font size="1">Debian: @eamanu-guest</font></span><br></div></div></div></div></div>