<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">Hi!</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">I think now it's ok.</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><a href="https://salsa.debian.org/python-team/modules/python-tornado/commit/70526d2ad0022925b3f23f1b71e50928df1051f0">https://salsa.debian.org/python-team/modules/python-tornado/commit/70526d2ad0022925b3f23f1b71e50928df1051f0</a></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">Please, review it.</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">Regards<br></div></div></div><br><div class="gmail_quote"><div dir="ltr">El jue., 27 de dic. de 2018 a la(s) 09:43, eamanu15 (<a href="mailto:emmanuelarias30@gmail.com">emmanuelarias30@gmail.com</a>) escribió:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">Hi Lamby!</div></div><br><div class="gmail_quote"><div dir="ltr">El jue., 27 de dic. de 2018 a la(s) 05:30, Chris Lamb (<a href="mailto:lamby@debian.org" target="_blank">lamby@debian.org</a>) escribió:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi eamanu15,<br>
<br>
> I push the patch to salsa.<br>
> <br>
> Please, review it.<br>
<br>
Assuming you mean:<br>
<br>
  <a href="https://salsa.debian.org/python-team/modules/python-tornado/commit/397def589597dd2deed12289f4858ec0a875e35a" rel="noreferrer" target="_blank">https://salsa.debian.org/python-team/modules/python-tornado/commit/397def589597dd2deed12289f4858ec0a875e35a</a><br>
<br>
... I would probably prefer to see something based on:<br>
<br>
  <a href="https://reproducible-builds.org/docs/source-date-epoch/" rel="noreferrer" target="_blank">https://reproducible-builds.org/docs/source-date-epoch/</a><br>
<br>
… as that is more likely to be accepted upstream.<br></blockquote><div><br></div><div style="font-family:monospace,monospace;font-size:small" class="gmail_default">Thanks, so I will work with source date epoch<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
(In addition, the above commit I link to above contains a bunch of<br>
changes unrelated to the commit [message] itself. These are better<br>
done in other commits to make review easier/faster, especially when<br>
asking others to take a look.)<br></blockquote><div><span class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></span></div><div><span class="gmail_default" style="font-family:monospace,monospace;font-size:small">Ok :-)</span><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
Regards,<br>
<br>
-- <br>
      ,''`.<br>
     : :'  :     Chris Lamb<br>
     `. `'`      <a href="mailto:lamby@debian.org" target="_blank">lamby@debian.org</a> / <a href="http://chris-lamb.co.uk" rel="noreferrer" target="_blank">chris-lamb.co.uk</a><br>
       `-<br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail-m_8057255377592897478gmail_signature"><div dir="ltr"><div><div><font size="1"><span style="font-family:verdana,sans-serif"></span><span style="font-family:arial narrow,sans-serif">Arias Emmanuel</span></font></div><div><span style="font-family:arial narrow,sans-serif"><font size="1"><a href="http://eamanu.com" target="_blank">http://eamanu.com</a><br></font></span></div><div><span style="font-family:arial narrow,sans-serif"><font size="1">Github/Gitlab; @eamanu<br></font></span></div><div><span style="font-family:arial narrow,sans-serif"><font size="1">Debian: @eamanu-guest</font></span><br></div></div></div></div></div>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div><font size="1"><span style="font-family:verdana,sans-serif"></span><span style="font-family:arial narrow,sans-serif">Arias Emmanuel</span></font></div><div><span style="font-family:arial narrow,sans-serif"><font size="1"><a href="http://eamanu.com" target="_blank">http://eamanu.com</a><br></font></span></div><div><span style="font-family:arial narrow,sans-serif"><font size="1">Github/Gitlab; @eamanu<br></font></span></div><div><span style="font-family:arial narrow,sans-serif"><font size="1">Debian: @eamanu-guest</font></span><br></div></div></div></div>