<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">Hi Joseph!</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div></div><br><div class="gmail_quote"><div dir="ltr">El mar., 1 de ene. de 2019 a la(s) 21:27, Joseph Herlant (<a href="mailto:aerostitch@debian.org">aerostitch@debian.org</a>) escribió:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Control: tags -1 - fixed<br>
Control: tags -1 + patch<br>
Hi guys,<br>
<br>
Thanks Lucas for the report. Sorry for the late reply, I was out of<br>
the country with very limited internet access.<br>
<br>
Thanks Emmanuel for the quick patch.<br>
Notes for next time:<br>
 * Please use meaningful commit messages, especially when committing<br>
to the master branch of a package you don't maintain. Using commit<br>
messages like "fix issue 917717" makes the commit history harder to<br>
read and the use of tools like gbp dch impossible as well as rendering<br>
the gitlab hooks in place for tagging the bugs as pending unusable.<br>
(If you're not sure about your patches, please just create a MR and<br>
the maintainer can help getting the patch to a better standard)<br></blockquote><div><span class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></span></div><div><span class="gmail_default" style="font-family:monospace,monospace;font-size:small">Ok! I will do it!. What is the meaning of MR?</span> <br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
 * Please conform to the DEP-3 headers when you are writing a quilt<br>
patch header. See <a href="https://dep-team.pages.debian.net/deps/dep3/" rel="noreferrer" target="_blank">https://dep-team.pages.debian.net/deps/dep3/</a></blockquote><div><br></div><div style="font-family:monospace,monospace;font-size:small" class="gmail_default">I used gbp-pq to create the patch. Maybe, I am using this tool <br></div><div style="font-family:monospace,monospace;font-size:small" class="gmail_default">from a wrong way?</div><div style="font-family:monospace,monospace;font-size:small" class="gmail_default"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
 * If you have a patch that you thing is good enough for Debian, it's<br>
generally a good practice to propose it upstream as upstream is<br>
generally aware of the potential negative impacts and this would avoid<br>
having to maintain diverging patch hell, especially on packages you<br>
don't maintain.<br></blockquote><div><span class="gmail_default" style="font-family:monospace,monospace;font-size:small"></span></div><div><span class="gmail_default" style="font-family:monospace,monospace;font-size:small">Ok. Thanks.</span></div><div><span class="gmail_default" style="font-family:monospace,monospace;font-size:small"></span> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
 * <span class="gmail_default" style="font-family:monospace,monospace;font-size:small"></span>Please don't tag bugs as "fixed" as long as there's no NMU uploaded<br>
(as long as the package is not in the archive). In your case the tag<br>
"patch" seems more appropriate.<br></blockquote><div><span class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></span></div><div><span class="gmail_default" style="font-family:monospace,monospace;font-size:small">Great. thanks</span> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
There is an upstream upgrade I need to do so I'll clean the previous<br>
points and do the upload today or tomorrow.<br>
<br>
Thanks,<br>
Joseph<br>
<br>
_______________________________________________<br>
Python-modules-team mailing list<br>
<a href="mailto:Python-modules-team@alioth-lists.debian.net" target="_blank">Python-modules-team@alioth-lists.debian.net</a><br>
<a href="https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team" rel="noreferrer" target="_blank">https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team</a></blockquote></div><div><br></div><div><div style="font-family:monospace,monospace;font-size:small" class="gmail_default"><span class="gmail-tlid-translation gmail-translation"><span title="" class="gmail-">Thanks for your tips.</span> <span title="" class="gmail-">I will keep them in mind :-)</span></span></div><div style="font-family:monospace,monospace;font-size:small" class="gmail_default"><span class="gmail-tlid-translation gmail-translation"><span title="" class="gmail-"><br></span></span></div><div style="font-family:monospace,monospace;font-size:small" class="gmail_default"><span class="gmail-tlid-translation gmail-translation"><span title="" class="gmail-">Cheers,<br></span></span></div><br></div><br>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div><font size="1"><span style="font-family:verdana,sans-serif"></span><span style="font-family:arial narrow,sans-serif">Arias Emmanuel</span></font></div><div><span style="font-family:arial narrow,sans-serif"><font size="1"><a href="http://eamanu.com" target="_blank">http://eamanu.com</a><br></font></span></div><div><span style="font-family:arial narrow,sans-serif"><font size="1">Github/Gitlab; @eamanu<br></font></span></div><div><span style="font-family:arial narrow,sans-serif"><font size="1">Debian: @eamanu-guest</font></span><br></div></div></div></div></div>