[Qa-jenkins-scm] [jenkins.debian.net] 08/09: reproducible: build: refactor: one todo item down \o/

[Holger Levsen]

This is an automated email from the git hooks/post-receive script.

holger pushed a commit to branch master
in repository jenkins.debian.net.

commit b94fd3a99dd3148519031bf1924ff8fca8123fa0
Author: Mattia Rizzolo <mattia at mapreri.org>
Date:   Wed Apr 8 10:04:28 2015 +0200

    reproducible: build: refactor: one todo item down \o/
---
 TODO                      | 3 +--
 bin/reproducible_build.sh | 4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/TODO b/TODO
index 2d1e55c..d1a6e87 100644
--- a/TODO
+++ b/TODO
@@ -156,14 +156,12 @@ grep '(=.*).,.$' rygel_0.24.2-1.debbindiff.html | uniq -c | sort | grep -c '^\s*
 ** the grepping should probably only done on files younger then $check_frequency
 
 * misc
-** reproducible: dont delete userContent/$pkg on build begin..
 ** move all content into /var/lib/userContent/reproducible/
 ** more graphs: graph average build duration by day
 ** meld bin/reproducible_setup_schroot.sh into bin/schroot-create.sh and alias the former to the latter
 ** "fork" etc/schroot/default into etc/schroot/reproducible
 ** use one css for all, not two minimally different ones
 ** repo-comparison: check for binaries without source
-** turn job-cfg/g-i.yaml into .yaml.py
 
 * notes related
 ** hint issues of a package while hovering over it
@@ -224,6 +222,7 @@ These small changes are probably still worth doing anyway:
 * g-i: replace '--' with '---' as param delimiter. see #776763 / 5df5b95908 in d-e-c
 * download .isos once in central place
 * g-i_presentation: use preseeding files on jenkins.d.n and not hands.com
+* turn job-cfg/g-i.yaml into .yaml.py
 
 The following ideas should really only be implemented for the new 'lvc*' tests.... (but are kept here for now)
 
diff --git a/bin/reproducible_build.sh b/bin/reproducible_build.sh
index 552d78e..569a318 100755
--- a/bin/reproducible_build.sh
+++ b/bin/reproducible_build.sh
@@ -352,7 +352,7 @@ build_rebuild() {
 		if [ -f b2/${SRCPACKAGE}_${EVERSION}_${ARCH}.changes ] ; then
 			# both builds were fine, i.e., they did not FTBFS.
 			FTBFS=0
-			cleanup_userContent # FIXME check wheter my changes here are fine
+			cleanup_userContent
 			chmod 644 $RBUILDLOG
 			mv $RBUILDLOG /var/lib/jenkins/userContent/rbuild/${SUITE}/${ARCH}/${SRCPACKAGE}_${EVERSION}.rbuild.log
 			RBUILDLOG=/var/lib/jenkins/userContent/rbuild/${SUITE}/${ARCH}/${SRCPACKAGE}_${EVERSION}.rbuild.log
@@ -378,7 +378,7 @@ cd $TMPDIR
 
 DATE=$(date +'%Y-%m-%d %H:%M')
 START=$(date +'%s')
-RBUILDLOG=$(mktemp --tmpdir=$TMPDIR) # FIXME check wheter my changes here are fine
+RBUILDLOG=$(mktemp --tmpdir=$TMPDIR)
 
 choose_package  # defines SUITE, PKGID, SRCPACKAGE, SCHEDULED_DATE, SAVE_ARTIFACTS
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/qa/jenkins.debian.net.git