[Qa-jenkins-scm] [jenkins.debian.net] 01/02: bin/find_dpkg_trigger_cycles.sh: add comment to explain curl usage in pipeline

[Holger Levsen]

This is an automated email from the git hooks/post-receive script.

holger pushed a commit to branch master
in repository jenkins.debian.net.

commit eaf9e2074edf4a0d3ce93744431351305deba1e1
Author: Johannes 'josch' Schauer <josch at mister-muffin.de>
Date:   Thu Feb 11 12:48:50 2016 +0100

    bin/find_dpkg_trigger_cycles.sh: add comment to explain curl usage in pipeline
---
 bin/find_dpkg_trigger_cycles.sh | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/bin/find_dpkg_trigger_cycles.sh b/bin/find_dpkg_trigger_cycles.sh
index 12c02c7..14416a8 100755
--- a/bin/find_dpkg_trigger_cycles.sh
+++ b/bin/find_dpkg_trigger_cycles.sh
@@ -176,6 +176,15 @@ curl --retry 3 --retry-delay 10 --globoff "http://binarycontrol.debian.net/?q=&p
 	| while read pkg url; do
 	echo "working on $pkg..." >&2
 	tmpdir=`mktemp -d --tmpdir="$scratch" -t dpkg-trigger-cycles-curl-XXXXXXXX`
+	# we use curl as part of a pipeline to dpkg-deb instead of first
+	# downloading to a temporary file and then using dpkg-deb on it,
+	# because we do not want to download the full .deb (which could be very
+	# large) but only the beginning of it until dpkg-deb has the
+	# control.tar.gz extracted. After that, dpkg-deb will close the pipe
+	# and thus signal curl to stop downloading. Downloading the full
+	# binary package would be unnecessarily wasteful thousands of binary
+	# packages in terms of bandwidth and disk requirements.
+	#
 	# curl is allowed to fail with exit status 23 because we want to stop
 	# downloading immediately after control.tar.gz has been extracted
 	( curl --retry 3 --retry-delay 10 --location --silent "$url" || [ "$?" -eq 23 ] || ( echo "curl failed">&2 && exec /srv/jenkins/bin/abort.sh ) ) \

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/qa/jenkins.debian.net.git