[Git][qa/jenkins.debian.net][master] reproducible Debian live: scp --> rsync

[Holger Levsen (@holger)]

Holger Levsen pushed to branch master at Debian QA / jenkins.debian.net


Commits:
3efc26b4 by Philip Hands at 2023-07-27T13:53:30+02:00
reproducible Debian live: scp --> rsync

rsync does the copy then move thing automatically, so there's no need to
stage the file via a .tmp one. Also, doing that would prevent rsync from
noticing that it can use the old image to speed things up.

One could add a '-v' to the rsync command to see how much it is managing
to speed things up.

I don't think the Batchmode=yes is really needed (because all our
servers are locked-down to refuse passwords) but perhaps that was also
there to suppress prompts regarding host keys, in which case one could
add an option:

  -e 'ssh -o "Batchmode=yes"'

Signed-off-by: Holger Levsen <holger at layer-acht.org>

- - - - -


1 changed file:

- bin/reproducible_debian_live_sync_result.sh


Changes:

=====================================
bin/reproducible_debian_live_sync_result.sh
=====================================
@@ -51,9 +51,8 @@ rsync_remote_results() {
     fi
     local URL="${REPRODUCIBLE_URL}/${PROJECT_PATH}/$EXTRADIR${filename}"
     # Copy the new results from the build node to the web server node
-    scp -O -p -o Batchmode=yes "$NODE":"$origfile" "$filename.tmp"
-    chmod 755 "$filename.tmp"
-    mv "$filename.tmp" "$filename"
+    rsync -t "$NODE":"$origfile" "$filename"
+    chmod 755 "$filename"
     echo "$(date -u) - enjoy $URL"
 }
 



View it on GitLab: https://salsa.debian.org/qa/jenkins.debian.net/-/commit/3efc26b456bab9133cb2fc097939b095fbc60c18

-- 
View it on GitLab: https://salsa.debian.org/qa/jenkins.debian.net/-/commit/3efc26b456bab9133cb2fc097939b095fbc60c18
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/qa-jenkins-scm/attachments/20230727/6e992701/attachment-0001.htm>