<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<h3>
Mattia Rizzolo pushed to branch master
at <a href="https://salsa.debian.org/qa/jenkins.debian.net">Debian QA / jenkins.debian.net</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://salsa.debian.org/qa/jenkins.debian.net/commit/daeeb033642df2ad061cf70f28c31d4730fa1a5d">daeeb033</a></strong>
<div>
<span>by Mattia Rizzolo</span>
<i>at 2018-10-09T11:29:28Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">cs16/squid: correctly allow only the /24 subnet of the 192.168.101.0 network
the notation previously used would have allowed the whole /16, despite a
single address being specified.
This was also causing warnings:
2018/10/09 06:25:09| aclIpParseIpData: WARNING: Netmask masks away part of the specified IP in '192.168.101.16/16'
Signed-off-by: Mattia Rizzolo <mattia@debian.org>
</pre>
</li>
</ul>
<h4>1 changed file:</h4>
<ul>
<li class="file-stats">
<a href="#5fa73e455ef46eb27cb5f6ee5a0b81339285a229">
hosts/codethink-sled16-arm64/etc/squid/squid.conf
</a>
</li>
</ul>
<h4>Changes:</h4>
<li id="5fa73e455ef46eb27cb5f6ee5a0b81339285a229">
<a href="https://salsa.debian.org/qa/jenkins.debian.net/commit/daeeb033642df2ad061cf70f28c31d4730fa1a5d#5fa73e455ef46eb27cb5f6ee5a0b81339285a229"><strong>hosts/codethink-sled16-arm64/etc/squid/squid.conf</strong></a>
<hr>
<table class="code white" style="font-family: monospace; font-size: 90%;" bgcolor="#fff" width="100%" cellpadding="0" cellspacing="0">
<tr class="line_holder match" id="" style="line-height: 1.6;">
<td class="diff-line-num unfold js-unfold old_line" data-linenumber="974" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">...</td>
<td class="diff-line-num unfold js-unfold new_line" data-linenumber="974" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">...</td>
<td class="line_content match " style="padding-left: 0.5em; padding-right: 0.5em; color: rgba(0,0,0,0.3);" bgcolor="#fafafa">@@ -974,7 +974,8 @@</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="974" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
974
</td>
<td class="diff-line-num new_line" data-linenumber="974" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
974
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC974" class="line" lang="conf"><span class="c" style="color: #998; font-style: italic;"># should be allowed</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="975" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
975
</td>
<td class="diff-line-num new_line" data-linenumber="975" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
975
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC975" class="line" lang="conf"><span class="n" style="color: #333;">acl</span> <span class="n" style="color: #333;">localnet</span> <span class="n" style="color: #333;">src</span> <span class="m" style="color: #099;">10</span>.<span class="m" style="color: #099;">0</span>.<span class="m" style="color: #099;">0</span>.<span class="m" style="color: #099;">0</span>/<span class="m" style="color: #099;">8</span> <span class="c" style="color: #998; font-style: italic;"># RFC1918 possible internal network</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="976" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
976
</td>
<td class="diff-line-num new_line" data-linenumber="976" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
976
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC976" class="line" lang="conf"><span class="c" style="color: #998; font-style: italic;">#acl localnet src 172.16.0.0/12 # RFC1918 possible internal network</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="" style="line-height: 1.6;">
<td class="diff-line-num old old_line" data-linenumber="977" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
977
</td>
<td class="diff-line-num new_line old" data-linenumber="977" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content noteable_line old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC977" class="line" lang="conf"><span class="n" style="color: #333;">acl</span> <span class="n" style="color: #333;">localnet</span> <span class="n" style="color: #333;">src</span> <span class="m" style="color: #099;">192</span>.<span class="m" style="color: #099;">168</span>.<span class="m" style="color: #099;">101</span>.<span class="m" style="color: #099;">16</span>/<span class="m" style="color: #099;">16</span> <span class="c" style="color: #998; font-style: italic;"># RFC1918 possible internal network</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="" style="line-height: 1.6;">
<td class="diff-line-num new old_line" data-linenumber="978" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="977" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
977
</td>
<td class="line_content new noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC977" class="line" lang="conf"><span class="c" style="color: #998; font-style: italic;">#acl localnet src 192.168.0.0/16 # RFC1918 possible internal network</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="" style="line-height: 1.6;">
<td class="diff-line-num new old_line" data-linenumber="978" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="978" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
978
</td>
<td class="line_content new noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC978" class="line" lang="conf"><span class="n" style="color: #333;">acl</span> <span class="n" style="color: #333;">localnet</span> <span class="n" style="color: #333;">src</span> <span class="m" style="color: #099;">192</span>.<span class="m" style="color: #099;">168</span>.<span class="m" style="color: #099;">101</span>.<span class="m" style="color: #099;">0</span>/<span class="m" style="color: #099;">24</span> <span class="c" style="color: #998; font-style: italic;"># private network between the codethink nodes</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="978" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
978
</td>
<td class="diff-line-num new_line" data-linenumber="979" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
979
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC979" class="line" lang="conf"><span class="c" style="color: #998; font-style: italic;">#acl localnet src fc00::/7 # RFC 4193 local private network range</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="979" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
979
</td>
<td class="diff-line-num new_line" data-linenumber="980" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
980
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC980" class="line" lang="conf"><span class="c" style="color: #998; font-style: italic;">#acl localnet src fe80::/10 # RFC 4291 link-local (directly plugged) machines</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="980" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
980
</td>
<td class="diff-line-num new_line" data-linenumber="981" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
981
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC981" class="line" lang="conf"></span>
</pre>
</td>
</tr>
</table>
<br>
</li>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
<a href="https://salsa.debian.org/qa/jenkins.debian.net/commit/daeeb033642df2ad061cf70f28c31d4730fa1a5d">View it on GitLab</a>.
<br>
You're receiving this email because of your account on salsa.debian.org.
If you'd like to receive fewer emails, you can
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Commit","url":"https://salsa.debian.org/qa/jenkins.debian.net/commit/daeeb033642df2ad061cf70f28c31d4730fa1a5d"}}</script>
</p>
</div>
</body>
</html>