<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<h3>
Mattia Rizzolo pushed to branch master
at <a href="https://salsa.debian.org/qa/jenkins.debian.net">Debian QA / jenkins.debian.net</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://salsa.debian.org/qa/jenkins.debian.net/commit/4bf29894706ca64f2e87caa4eb4eefeee49a32ba">4bf29894</a></strong>
<div>
<span>by Mattia Rizzolo</span>
<i>at 2019-01-13T09:35:47Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">reproducible: health_check: fix a (nonfatal?) syntax error
This was causing:
/tmp/jenkins-script-vkjPKnSH: line 116: "2019" + 1: syntax error: operand expected (error token is ""2019" + 1")
Turns out that within arithmetic variables using $ is discuraged due to
how the expansion is done, and this was indeed leading to a subtle bug
here.
Should have followed shellcheck in the first instance.
https://github.com/koalaman/shellcheck/wiki/SC2004
Curiously, not double-quoting the variables within whould have _also_
prevented this bug (in a different way).
Signed-off-by: Mattia Rizzolo <mattia@debian.org>
</pre>
</li>
</ul>
<h4>1 changed file:</h4>
<ul>
<li class="file-stats">
<a href="#02877709f166a707a0b1c3bb2d53594f61e132e3">
bin/reproducible_node_health_check.sh
</a>
</li>
</ul>
<h4>Changes:</h4>
<li id="02877709f166a707a0b1c3bb2d53594f61e132e3">
<a href="https://salsa.debian.org/qa/jenkins.debian.net/commit/4bf29894706ca64f2e87caa4eb4eefeee49a32ba#02877709f166a707a0b1c3bb2d53594f61e132e3"><strong>bin/reproducible_node_health_check.sh</strong></a>
<hr>
<table class="code white" style="font-family: monospace; font-size: 90%;" bgcolor="#fff" width="100%" cellpadding="0" cellspacing="0">
<tr class="line_holder match" id="" style="line-height: 1.6;">
<td class="diff-line-num unfold js-unfold old_line" data-linenumber="113" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">...</td>
<td class="diff-line-num unfold js-unfold new_line" data-linenumber="113" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">...</td>
<td class="line_content match " style="padding-left: 0.5em; padding-right: 0.5em; color: rgba(0,0,0,0.3);" bgcolor="#fafafa">@@ -113,8 +113,8 @@ if "$NODE_RUN_IN_THE_FUTURE"; then</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="113" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
113
</td>
<td class="diff-line-num new_line" data-linenumber="113" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
113
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC113" class="line" lang="shell"><span class="k" style="font-weight: 600;"> if</span> <span class="o" style="font-weight: 600;">[</span> <span class="s2" style="color: #d14;">"</span><span class="nv" style="color: teal;">$year</span><span class="s2" style="color: #d14;">"</span> <span class="nt" style="color: navy;">-eq</span> <span class="s2" style="color: #d14;">"</span><span class="nv" style="color: teal;">$real_year</span><span class="s2" style="color: #d14;">"</span> <span class="o" style="font-weight: 600;">]</span><span class="p">;</span> <span class="k" style="font-weight: 600;">then</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="114" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
114
</td>
<td class="diff-line-num new_line" data-linenumber="114" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
114
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC114" class="line" lang="shell"><span class="k" style="font-weight: 600;"> </span><span class="nb" style="color: #0086b3;">echo</span> <span class="s2" style="color: #d14;">"Warning, today we came back to the present: </span><span class="k" style="font-weight: 600;">$(</span><span class="nb" style="color: #0086b3;">date</span> <span class="nt" style="color: navy;">-u</span><span class="k" style="font-weight: 600;">)</span><span class="s2" style="color: #d14;">."</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="115" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
115
</td>
<td class="diff-line-num new_line" data-linenumber="115" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
115
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC115" class="line" lang="shell"> <span class="nv" style="color: teal;">DIRTY</span><span class="o" style="font-weight: 600;">=</span><span class="nb" style="color: #0086b3;">true</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="" style="line-height: 1.6;">
<td class="diff-line-num old old_line" data-linenumber="116" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
116
</td>
<td class="diff-line-num new_line old" data-linenumber="116" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content noteable_line old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC116" class="line" lang="shell"><span class="nb" style="color: #0086b3;"> </span><span class="k" style="font-weight: 600;">elif</span> <span class="o" style="font-weight: 600;">[</span> <span class="s2" style="color: #d14;">"</span><span class="nv" style="color: teal;">$year</span><span class="s2" style="color: #d14;">"</span> <span class="nt" style="color: navy;">-eq</span> <span class="s2" style="color: #d14;">"</span><span class="k" style="font-weight: 600;">$((</span><span class="s2" style="color: #d14;"><span class="idiff left">"</span></span><span class="nv" style="color: teal;"><span class="idiff">$real_year</span></span><span class="s2" style="color: #d14;"><span class="idiff right">"</span></span> <span class="o" style="font-weight: 600;">+</span> <span class="m" style="color: #099;">1</span><span class="k" style="font-weight: 600;">))</span><span class="s2" style="color: #d14;">"</span> <span class="o" style="font-weight: 600;">]</span> <span class="o" style="font-weight: 600;">||</span> <span class="se" style="color: #d14;">\</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="" style="line-height: 1.6;">
<td class="diff-line-num old old_line" data-linenumber="117" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
117
</td>
<td class="diff-line-num new_line old" data-linenumber="116" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content noteable_line old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC117" class="line" lang="shell"> <span class="o" style="font-weight: 600;">[</span> <span class="s2" style="color: #d14;">"</span><span class="nv" style="color: teal;">$year</span><span class="s2" style="color: #d14;">"</span> <span class="nt" style="color: navy;">-eq</span> <span class="s2" style="color: #d14;">"</span><span class="k" style="font-weight: 600;">$((</span><span class="s2" style="color: #d14;"><span class="idiff left">"</span></span><span class="nv" style="color: teal;"><span class="idiff">$real_year</span></span><span class="s2" style="color: #d14;"><span class="idiff right">"</span></span> <span class="o" style="font-weight: 600;">+</span> <span class="m" style="color: #099;">2</span><span class="k" style="font-weight: 600;">))</span><span class="s2" style="color: #d14;">"</span> <span class="nt" style="color: navy;">-a</span> <span class="s2" style="color: #d14;">"</span><span class="k" style="font-weight: 600;">$(</span><span class="nb" style="color: #0086b3;">date</span> +%m<span class="k" style="font-weight: 600;">)</span><span class="s2" style="color: #d14;">"</span> <span class="nt" style="color: navy;">-eq</span> 1 <span class="o" style="font-weight: 600;">]</span><span class="p">;</span> <span class="k" style="font-weight: 600;">then</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="" style="line-height: 1.6;">
<td class="diff-line-num new old_line" data-linenumber="118" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="116" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
116
</td>
<td class="line_content new noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC116" class="line" lang="shell"><span class="nb" style="color: #0086b3;"> </span><span class="k" style="font-weight: 600;">elif</span> <span class="o" style="font-weight: 600;">[</span> <span class="s2" style="color: #d14;">"</span><span class="nv" style="color: teal;">$year</span><span class="s2" style="color: #d14;">"</span> <span class="nt" style="color: navy;">-eq</span> <span class="s2" style="color: #d14;">"</span><span class="k" style="font-weight: 600;">$((</span><span class="idiff left right">real_year</span> <span class="o" style="font-weight: 600;">+</span> <span class="m" style="color: #099;">1</span><span class="k" style="font-weight: 600;">))</span><span class="s2" style="color: #d14;">"</span> <span class="o" style="font-weight: 600;">]</span> <span class="o" style="font-weight: 600;">||</span> <span class="se" style="color: #d14;">\</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="" style="line-height: 1.6;">
<td class="diff-line-num new old_line" data-linenumber="118" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="117" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
117
</td>
<td class="line_content new noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC117" class="line" lang="shell"> <span class="o" style="font-weight: 600;">[</span> <span class="s2" style="color: #d14;">"</span><span class="nv" style="color: teal;">$year</span><span class="s2" style="color: #d14;">"</span> <span class="nt" style="color: navy;">-eq</span> <span class="s2" style="color: #d14;">"</span><span class="k" style="font-weight: 600;">$((</span><span class="idiff left right">real_year</span> <span class="o" style="font-weight: 600;">+</span> <span class="m" style="color: #099;">2</span><span class="k" style="font-weight: 600;">))</span><span class="s2" style="color: #d14;">"</span> <span class="nt" style="color: navy;">-a</span> <span class="s2" style="color: #d14;">"</span><span class="k" style="font-weight: 600;">$(</span><span class="nb" style="color: #0086b3;">date</span> +%m<span class="k" style="font-weight: 600;">)</span><span class="s2" style="color: #d14;">"</span> <span class="nt" style="color: navy;">-eq</span> 1 <span class="o" style="font-weight: 600;">]</span><span class="p">;</span> <span class="k" style="font-weight: 600;">then</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="118" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
118
</td>
<td class="diff-line-num new_line" data-linenumber="118" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
118
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC118" class="line" lang="shell"><span class="k" style="font-weight: 600;"> </span><span class="nb" style="color: #0086b3;">echo</span> <span class="s2" style="color: #d14;">"Good, today is the right future: </span><span class="k" style="font-weight: 600;">$(</span><span class="nb" style="color: #0086b3;">date</span> <span class="nt" style="color: navy;">-u</span><span class="k" style="font-weight: 600;">)</span><span class="s2" style="color: #d14;">."</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="119" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
119
</td>
<td class="diff-line-num new_line" data-linenumber="119" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
119
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC119" class="line" lang="shell"> <span class="k" style="font-weight: 600;">else</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="120" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
120
</td>
<td class="diff-line-num new_line" data-linenumber="120" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
120
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC120" class="line" lang="shell"><span class="k" style="font-weight: 600;"> </span><span class="nb" style="color: #0086b3;">echo</span> <span class="s2" style="color: #d14;">"Warning, today is the wrong future: </span><span class="k" style="font-weight: 600;">$(</span><span class="nb" style="color: #0086b3;">date</span> <span class="nt" style="color: navy;">-u</span><span class="k" style="font-weight: 600;">)</span><span class="s2" style="color: #d14;">."</span></span>
</pre>
</td>
</tr>
</table>
<br>
</li>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777777;">
—
<br>
<a href="https://salsa.debian.org/qa/jenkins.debian.net/commit/4bf29894706ca64f2e87caa4eb4eefeee49a32ba">View it on GitLab</a>.
<br>
You're receiving this email because of your account on salsa.debian.org.
If you'd like to receive fewer emails, you can
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Commit","url":"https://salsa.debian.org/qa/jenkins.debian.net/commit/4bf29894706ca64f2e87caa4eb4eefeee49a32ba"}}</script>
</p>
</div>
</body>
</html>