<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "Menlo"), DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: 0.875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px;
}
body {
font-family: var(--default-regular-font, -apple-system),BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px; font-family: var(--default-regular-font, -apple-system),BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<h3 style="margin-top: 20px; margin-bottom: 10px;">
Holger Levsen pushed to branch master at <a href="https://salsa.debian.org/qa/jenkins.debian.net">Debian QA / jenkins.debian.net</a>
</h3>
<h4 style="margin-top: 10px; margin-bottom: 10px;">
Commits:
</h4>
<ul>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/qa/jenkins.debian.net/-/commit/6d0ee613559757b19ee81c1a888cd02f148d1ecc">6d0ee613</a></strong>
<div>
<span> by Philip Hands </span> <i> at 2023-03-30T11:47:00+02:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 0.875rem; color: #333238; position: relative; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>code cleanup: '! -z' --> '-n'
Signed-off-by: Holger Levsen <holger@layer-acht.org>
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/qa/jenkins.debian.net/-/commit/4489f7a3be9d495661069bed65fbcb766eef218c">4489f7a3</a></strong>
<div>
<span> by Philip Hands </span> <i> at 2023-03-30T11:47:00+02:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 0.875rem; color: #333238; position: relative; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>code cleanup: use grep return code directly
This uses greps return code directly, instead of checking if it produced
output.
NOTE: the problem with this is that I think that the old code was
broken in a couple of ways:
the $WORKER is inside single quotes (') which will ensure that the
variable expansion doesn't happen, and so the grep presumably never
matches.
the comment claims that the {z}cat runs when the worker isn't running,
but the code (if it worked) seems to be trying to run it only when it
is running.
My version uses the trick of putting some square brackets in the
pattern ([r]) to avoid the need for the protective `grep -v grep`
and makes it match the comment (adding a '!' at the start)
It would be better to use pgrep, but I'm not certain what the pattern
should be without seeing the running processes so I'll leave it at
ps|grep for now.
Signed-off-by: Holger Levsen <holger@layer-acht.org>
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/qa/jenkins.debian.net/-/commit/12803b1076d3715dbc50adf2c20d7a074a7df7bf">12803b10</a></strong>
<div>
<span> by Philip Hands </span> <i> at 2023-03-30T11:47:00+02:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 0.875rem; color: #333238; position: relative; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>code cleanup: useless echo removed
Signed-off-by: Holger Levsen <holger@layer-acht.org>
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/qa/jenkins.debian.net/-/commit/c94e713e163f4ae5b49a6e428f599bb29180578f">c94e713e</a></strong>
<div>
<span> by Philip Hands </span> <i> at 2023-03-30T11:47:00+02:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 0.875rem; color: #333238; position: relative; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>code cleanup: get rid of if $(echo|grep), and similar constructs
the $() is spurious here, and anyway bash can do regexp comparison
thus [[ ... =~ ... ]]
Signed-off-by: Holger Levsen <holger@layer-acht.org>
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/qa/jenkins.debian.net/-/commit/1be276c7b20cee2966613457e6dca63aec93bebc">1be276c7</a></strong>
<div>
<span> by Philip Hands </span> <i> at 2023-03-30T11:47:00+02:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 0.875rem; color: #333238; position: relative; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>code cleanup: use grep -c rather than grep|wc -l
Signed-off-by: Holger Levsen <holger@layer-acht.org>
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/qa/jenkins.debian.net/-/commit/b458da01ab250fb07c8f9d982cbd3ae90c315f54">b458da01</a></strong>
<div>
<span> by Philip Hands </span> <i> at 2023-03-30T11:47:00+02:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 0.875rem; color: #333238; position: relative; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>code cleanup: replace egrep (obsolescent) with grep -E
Signed-off-by: Holger Levsen <holger@layer-acht.org>
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/qa/jenkins.debian.net/-/commit/24913ce341a90b8b177738b0353e124013deefcf">24913ce3</a></strong>
<div>
<span> by Philip Hands </span> <i> at 2023-03-30T11:47:00+02:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 0.875rem; color: #333238; position: relative; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>code cleanup: remove unneeded bits inside $((...))
Signed-off-by: Holger Levsen <holger@layer-acht.org>
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/qa/jenkins.debian.net/-/commit/9c8b268d2c76add4f83a3e43398cc0c88f0bd17a">9c8b268d</a></strong>
<div>
<span> by Philip Hands </span> <i> at 2023-03-30T11:47:00+02:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 0.875rem; color: #333238; position: relative; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>code cleanup: get rid of superfluous [ -n/z $(grep ... bits
Signed-off-by: Holger Levsen <holger@layer-acht.org>
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/qa/jenkins.debian.net/-/commit/d97b7136a68b2e73caf14ec0700b82ebb2cec114">d97b7136</a></strong>
<div>
<span> by Philip Hands </span> <i> at 2023-03-30T11:47:00+02:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 0.875rem; color: #333238; position: relative; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>fixup! replace egrep (obsolescent) with grep -E
Signed-off-by: Holger Levsen <holger@layer-acht.org>
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/qa/jenkins.debian.net/-/commit/129dca0317db478a6ca63b27a69f6ee69a45ccf7">129dca03</a></strong>
<div>
<span> by Philip Hands </span> <i> at 2023-03-30T11:47:00+02:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 0.875rem; color: #333238; position: relative; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>fixup! code cleanup: remove unneeded bits inside $((...))
Signed-off-by: Holger Levsen <holger@layer-acht.org>
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/qa/jenkins.debian.net/-/commit/7d92f2d944d24ec70abf8edb541f4aa1e0046a14">7d92f2d9</a></strong>
<div>
<span> by Philip Hands </span> <i> at 2023-03-30T11:47:00+02:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 0.875rem; color: #333238; position: relative; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>add (& use) exitcode_to_signame()
Signed-off-by: Holger Levsen <holger@layer-acht.org>
</pre>
</li>
</ul>
<h4 style="margin-top: 10px; margin-bottom: 10px;">
30 changed files:
</h4>
<ul>
<li class="file-stats">
<a href="#eca20d08cb010db9a1c31ad22a95c4f6372b8b58">
bin/cgi-bin/nph-logwatch
</a>
</li>
<li class="file-stats">
<a href="#d6351d9db850b416900c4927d0373f5271208b20">
bin/chroot-installation.sh
</a>
</li>
<li class="file-stats">
<a href="#9dbe7e69e46d36fdac536e76221477144ae05082">
bin/chroot-run.sh
</a>
</li>
<li class="file-stats">
<a href="#e3deaad80f56158e6554bcf482c3ceaa7ecebfac">
bin/common-functions.sh
</a>
</li>
<li class="file-stats">
<a href="#e131a59de87b43b1ebd0bc8d9f5cf835099bbd2f">
bin/d-i_build.sh
</a>
</li>
<li class="file-stats">
<a href="#44960b834d5f6879f1478bb8afb68abc2d86e016">
bin/d-i_manual.sh
</a>
</li>
<li class="file-stats">
<a href="#ee8a17da46d48a9cdabb26c56dcdfc9af69175b3">
bin/diffoscope_distribution_test.sh
</a>
</li>
<li class="file-stats">
<a href="#b6e11db19be34816396fb6a345301c7170830594">
bin/find_dpkg_trigger_cycles.sh
</a>
</li>
<li class="file-stats">
<a href="#60c384e2ffbf32b9fb5e719ab4f7b8756c584a23">
bin/find_obsolete_transitional_packages.sh
</a>
</li>
<li class="file-stats">
<a href="#25ca3adf2821c325ea034b2db5398d9e6ff24eef">
bin/jenkins-shell-monitor.sh
</a>
</li>
<li class="file-stats">
<a href="#97c4bc1d3e51d3e6714862c7c1f69fe2492ed4d7">
bin/maintenance.sh
</a>
</li>
<li class="file-stats">
<a href="#ed84ab1635d79084ca0b7011c93ee9def8a9dd8f">
bin/reproducible_alpine_manual_scheduler.sh
</a>
</li>
<li class="file-stats">
<a href="#2876e619d4554b212bfc6e554ae0c138c52e7bc3">
bin/reproducible_alpine_scheduler.sh
</a>
</li>
<li class="file-stats">
<a href="#35ad4fb08a931b42f251d026edf4282d87177f52">
bin/reproducible_archlinux_manual_scheduler.sh
</a>
</li>
<li class="file-stats">
<a href="#0e24ec33fe775977738c35d204be3543f06a6d5d">
bin/reproducible_archlinux_scheduler.sh
</a>
</li>
<li class="file-stats">
<a href="#ea43fc89b5567a125d6f3bbbc0def947819087dc">
bin/reproducible_blacklist.sh
</a>
</li>
<li class="file-stats">
<a href="#e3529fc8c5367270028ddcf3d4783f057cb9019d">
bin/reproducible_build.sh
</a>
</li>
<li class="file-stats">
<a href="#c5df1802f4ca336e63df17d5f8f3885241427d3d">
bin/reproducible_build_alpine_pkg.sh
</a>
</li>
<li class="file-stats">
<a href="#29452a9219fdc2da556d0a6b36b6d9d77b3ab444">
bin/reproducible_build_archlinux_pkg.sh
</a>
</li>
<li class="file-stats">
<a href="#a3a4ba4f420b25a94c7531d1a8a84f827403c329">
bin/reproducible_build_rpm.sh
</a>
</li>
<li class="file-stats">
<a href="#0214b4cfbea7bec47400dc8554005b8a38e5de55">
bin/reproducible_build_service.sh
</a>
</li>
<li class="file-stats">
<a href="#af3658f223e603a5f788c2e315344f56c6f908e2">
bin/reproducible_common.sh
</a>
</li>
<li class="file-stats">
<a href="#f57301e271c6e72b0ed1e578b4fa609e37bafbaa">
bin/reproducible_create_meta_pkg_sets.sh
</a>
</li>
<li class="file-stats">
<a href="#c8ebdf44d7e36d2ffff3b8dc2b055437c5c1c686">
bin/reproducible_debian_live_build.sh
</a>
</li>
<li class="file-stats">
<a href="#6b9db3ccc509ca1bd286052fca88f3bfacb6f1ad">
bin/reproducible_debstrap.sh
</a>
</li>
<li class="file-stats">
<a href="#394d47c8695f798691128c200532e75431e87bfb">
bin/reproducible_html_dashboard.sh
</a>
</li>
<li class="file-stats">
<a href="#a4aa65cbe252b823cfb0d3f591ad18db831005be">
bin/reproducible_html_nodes_info.sh
</a>
</li>
<li class="file-stats">
<a href="#553f0eb2abd60a09ad26ec45e5e5ced4206698db">
bin/reproducible_html_repository_comparison.sh
</a>
</li>
<li class="file-stats">
<a href="#1c00d88555776c71a8e4552115b65812bf86e4fc">
bin/reproducible_html_rpms.sh
</a>
</li>
<li class="file-stats">
<a href="#3e7b2c27fe89ce8b8db3788811575eb1f00cb944">
bin/reproducible_maintenance.sh
</a>
</li>
</ul>
<h5 style="margin-top: 10px; margin-bottom: 10px; font-size: 0.875rem;">
The diff was not included because it is too large.
</h5>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
<a href="https://salsa.debian.org/qa/jenkins.debian.net/-/compare/f0ac16d1310d6d555de007b36079b9c8f37db63a...7d92f2d944d24ec70abf8edb541f4aa1e0046a14">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://salsa.debian.org">salsa.debian.org</a>. <a href="https://salsa.debian.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://salsa.debian.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
</p>
</div>
</body>
</html>