[Raspbian-devel] [PATCH] drivers: wireless: brcmfmac: use correct interface to record log info

[Li, Meng]

> -----Original Message-----
> From: Phil Elwell <phil at raspberrypi.com>
> Sent: Friday, March 12, 2021 2:08 AM
> To: Li, Meng <Meng.Li at windriver.com>
> Cc: raspbian-devel at alioth-lists.debian.net
> Subject: Re: [PATCH] drivers: wireless: brcmfmac: use correct interface to
> record log info
> 
> [Please note: This e-mail is from an EXTERNAL e-mail address]
> 
> Meng Li,
> 
> I don't know what the raspbian-devel mailing list is intended for, but what
> you have is a kernel patch so it needs to go to the kernel mailing lists. Use
> scripts/get_maintainer.pl in the kernel tree on your patch to find out which
> mailing lists it should be sent to.
> 
> I think you would be wise to also read
> Documentation/process/submitting-patches.rst, which describes the whole
> process of getting a patch accepted.
> 

Thanks for offering the guideline about how to submit patch to mainline.
But I only want to submit this patch to raspberry pi git repo(https://github.com/raspberrypi/linux.git).
Because this issue is only on raspberry pi git repo. For example, on branch rpi-5.11.y, it is introduced by
commit 47b54f97e78e(brcm: adds support for BCM43341 wifi) and commit c4bf343143b3(brcmfmac: Increase power saving delay to 2s)
the 2 patches are created by you, and in the second patch, you change the brcmf_err into brcmf_info. Maybe for the purpose of debugging.
If you think my patch is not necessary to be merged, could you please avoid the debug info when creating above patches next time?

In additional, do you know who maintains the raspberry pi git repo, and do the rebase based on latest mainline version?

Thanks,
Limeng

> Phil
> 
> On Wed, 10 Mar 2021 at 04:51, <Meng.Li at windriver.com> wrote:
> >
> > From: Meng Li <Meng.Li at windriver.com>
> >
> > Use brcmf_info interface that causes lots of debug info recorded in
> > log message file. So, refer to code that is used to record debug info
> > in this file, replace brcmf_info with the more reasonable brcmf_dbg
> > interface and set INFO parameter.
> >
> > Signed-off-by: Meng Li <Meng.Li at windriver.com>
> > ---
> >  drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> > b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> > index 525bf62d5b3c..32b232998f1e 100644
> > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> > @@ -2938,7 +2938,7 @@ brcmf_cfg80211_set_power_mgmt(struct wiphy
> *wiphy, struct net_device *ndev,
> >                 brcmf_dbg(INFO, "Do not enable power save for P2P clients\n");
> >                 pm = PM_OFF;
> >         }
> > -       brcmf_info("power save %s\n", (pm ? "enabled" : "disabled"));
> > +       brcmf_dbg(INFO, "power save %s\n", (pm ? "enabled" :
> > + "disabled"));
> >
> >         err = brcmf_fil_cmd_int_set(ifp, BRCMF_C_SET_PM, pm);
> >         if (err) {
> > --
> > 2.17.1
> >