Bug#845282: pcsc-tools: please make the build reproducible (buildpath)

[Daniel Shahaf]

Source: pcsc-tools
Version: 1.4.27-1
Severity: wishlist
Tags: upstream patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: buildpath

Hi!

While working on the “reproducible builds” effort [1], we have noticed
that pcsc-tools could not be built reproducibly.

Specifically, the build process embeds a (munged version of) the
absolute source directory in the package:

    https://tests.reproducible-builds.org/debian/dbdtxt/unstable/amd64/pcsc-tools_1.4.27-1.diffoscope.txt
    # Build directory: /build/pcsc-tools-1.4.27/2nd
       0x000019d0                00 5620312e 342e3237        .V 1.4.27
    +  0x000019e0 2f326e64 20286329 20323030 312d3230 /2nd (c) 2001-20
    +  0x000019f0 31312c20 4c75646f 76696320 526f7573 11, Ludovic Rous
    +  0x00001a00 73656175 203c6c75 646f7669 632e726f seau <ludovic.ro
    +  0x00001a10 75737365 61754066 7265652e 66723e00 usseau at free.fr>.

Patch attached.

[[[
--- a/Makefile
+++ b/Makefile
@@ -5,7 +5,7 @@
 # by default install in /usr/local
 DESTDIR ?= /usr/local
 
-VERSION := $(shell pwd | sed s/.*tools-//)
+VERSION := $(shell <Changelog head -n1 | grep -o 'pcsc-tools-[^,]\+')
 CFLAGS := $(CFLAGS) -DVERSION=\"$(VERSION)\" $(PCSC_CFLAGS)
 LDLIBS := $(PCSC_LDLIBS)
 # On xBSD systems use
]]]

Cheers,

Daniel

 [1]: https://wiki.debian.org/ReproducibleBuilds