Bug#869516: libcdio: please make the build reproducible

[Chris Lamb]

Source: libcdio
Version: 0.83-4.3
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that libcdio could not be built reproducibly as it was embedding
the absolute build path and also installing a randomly named
(empty) directory.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb, Debian Project Leader
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/patches/07_reproducible_build	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/07_reproducible_build	2017-07-23 22:01:29.845325740 +0100
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2017-07-23
+
+--- libcdio-0.83.orig/configure.ac
++++ libcdio-0.83/configure.ac
+@@ -486,7 +486,7 @@ AC_SUBST(HAVE_SOLARIS_CDROM)
+ AC_SUBST(HAVE_WIN32_CDROM)
+ AC_SUBST(HAVE_OS2_CDROM)
+ 
+-LIBCDIO_SOURCE_PATH="`pwd`"
++LIBCDIO_SOURCE_PATH="/usr/include/cdio"
+ AC_DEFINE_UNQUOTED(LIBCDIO_SOURCE_PATH, "$LIBCDIO_SOURCE_PATH",
+ 	[Full path to libcdio top_sourcedir.])
+ AC_SUBST(LIBCDIO_SOURCE_PATH)
--- a/debian/patches/series	2017-07-23 21:55:00.166495499 +0100
--- b/debian/patches/series	2017-07-23 22:01:28.405315273 +0100
@@ -3,3 +3,4 @@
 04_avoid_make_check_failure_when_stderr_is_not_a_tty
 05_revert_iso9660_set_pvd
 06_fix_japanese_manpage_location
+07_reproducible_build
--- a/debian/rules	2017-07-23 21:55:00.166495499 +0100
--- b/debian/rules	2017-07-23 22:14:55.655188567 +0100
@@ -66,6 +66,7 @@
 
 	# Add here commands to install the package into debian/tmp
 	$(MAKE) install DESTDIR=$(CURDIR)/debian/tmp
+	find $(CURDIR)/debian/tmp -type d -empty -delete
 
 
 # Build architecture-independent files here.