Bug#881259: soundmodem: please make the build reproducible

[Chris Lamb]

Source: soundmodem
Version: 0.20-5
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that soundmodem could not be built reproducibly.

This is because it captures the current working directory to add
to a search path. This path is meaningless in the target binary
as it will point to /build or something that won't exist at runtime
(or could even contain dodgy data..!).

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/patches/reproducible-build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/reproducible-build.patch	2017-11-09 13:00:57.331049787 +0000
@@ -0,0 +1,14 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2017-11-09
+
+--- soundmodem-0.20.orig/configapp/src/main.c
++++ soundmodem-0.20/configapp/src/main.c
+@@ -565,7 +565,6 @@ int main (int argc, char *argv[])
+ 	gtk_init(&argc, &argv);
+ 
+ 	add_pixmap_directory(PACKAGE_DATA_DIR "/pixmaps");
+-	add_pixmap_directory(PACKAGE_SOURCE_DIR "/pixmaps");
+ 
+ 	mainwindow = create_mainwindow();
+ 	gtk_notebook_remove_page(GTK_NOTEBOOK(g_object_get_data(G_OBJECT(mainwindow), "confignotebook")), 0);
--- a/debian/patches/series	2017-11-09 12:55:05.348590463 +0000
--- b/debian/patches/series	2017-11-09 13:00:56.451043552 +0000
@@ -4,3 +4,4 @@
 ftbfs-freebsd.patch
 fix-ftbfs-gcc6-matlib-mdet.patch
 fix-ftbfs-i386-multiple-def-mac.patch
+reproducible-build.patch