Bug#908222: octavia: please make the build reproducible

[Chris Lamb]

Source: octavia
Version: 3.0.0-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: hostname
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that octavia could not be built reproducibly.

This is because it embeds the hostname in the config file (which
also gets picked up in the documentation and the documentation
index files.)

Patch attached that uses sample_default.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/patches/reproducible-build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/reproducible-build.patch	2018-09-07 14:37:54.488579794 +0100
@@ -0,0 +1,14 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2018-09-07
+
+--- octavia-3.0.0.orig/octavia/common/config.py
++++ octavia-3.0.0/octavia/common/config.py
+@@ -38,6 +38,7 @@ API_SETTINGS_DEPRECATION_MESSAGE = _(
+ 
+ core_opts = [
+     cfg.HostnameOpt('host', default=utils.get_hostname(),
++                    sample_default='<server-hostname.example.com>',
+                     help=_("The hostname Octavia is running on")),
+     cfg.StrOpt('octavia_plugins', default='hot_plug_plugin',
+                help=_("Name of the controller plugin to use")),
--- a/debian/patches/series	2018-09-07 14:26:28.148228533 +0100
--- b/debian/patches/series	2018-09-07 14:37:53.404572475 +0100
@@ -1 +1,2 @@
 fix-py36-compatibility.patch
+reproducible-build.patch