Bug#910752: syndie: please make the build reproducible

[Chris Lamb]

Source: syndie
Version: 1.107b-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: umask
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that syndie could not be built reproducibly.

This is because it:

  a) Did not call dh_fixperms "correctly" resulting in files under /
     usr/share depending on the current umask

  b) Some .jars were not installed to /usr/bin (is that correct?) with
     a .jar suffix, dh_strip_nondeterminism did not normalise them.

Patch for both issues is attached. Enjoy..


 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/control	2018-10-10 18:08:37.731186608 +0100
--- b/debian/control	2018-10-10 18:21:31.159937883 +0100
@@ -2,7 +2,7 @@
 Section: net
 Priority: optional
 Maintainer: Masayuki Hatta <mhatta at debian.org>
-Build-Depends: debhelper (>= 11), ant, default-jdk, libswt-gtk-3-java, libhsqldb-java, i2p-router
+Build-Depends: debhelper (>= 11), ant, default-jdk, libswt-gtk-3-java, libhsqldb-java, i2p-router, strip-nondeterminism
 Standards-Version: 4.2.1
 Homepage: http://syndie.i2p2.de
 Vcs-Browser: https://salsa.debian.org/debian/syndie
@@ -20,4 +20,4 @@
  Syndie operates like blogs, newsgroups, and forums.  Authors can post
  messages privately or publicly.  Messages are pushed and pulled to and
  from archive servers, which are hosted in a variety of anonymous and
- non-anonymous networks including I2P, Tor, and Freenet.
\ No newline at end of file
+ non-anonymous networks including I2P, Tor, and Freenet.
--- a/debian/rules	2018-10-10 18:08:37.731186608 +0100
--- b/debian/rules	2018-10-10 18:20:16.995484168 +0100
@@ -19,7 +19,7 @@
 
 override_dh_auto_build:
 	ant stub-jars-debian -Dlib.dir=/usr/share/java -Di2p.jar=/usr/share/i2p/lib/i2p.jar -Djavac.version=1.8
-	chmod 755 pkg-temp/bin/*.jar
+	strip-nondeterminism --verbose pkg-temp/bin/*.jar
 	mv pkg-temp/bin/syndie-cli.jar pkg-temp/bin/syndie-cli
 	mv pkg-temp/bin/syndie.jar pkg-temp/bin/syndie
 	mv pkg-temp/bin/syndie-desktop.jar pkg-temp/bin/syndie-desktop
@@ -34,4 +34,5 @@
 	   $(CURDIR)/debian/syndie/usr/share/doc/syndie/html
 
 override_dh_fixperms:
-	dh_fixperms -Xsyndie.jar -Xsyndie-cli.jar -Xsyndie-desktop.jar
+	dh_fixperms
+	chmod 755 $(CURDIR)/debian/syndie/usr/share/syndie/*.jar