Bug#972496: softether-vpn: please make the build reproducible

[Chris Lamb]

Source: softether-vpn
Version: 5.01.9674+git20200806+8181039+dfsg-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: hostname
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
softether-vpn could not be built reproducibly.

This is because it embeds the build username and build hostname into
the final binary.

Patch attached that doesn't set these variables (by editing the CMake
build configuration). The build does not fail when we do not define
these because of #ifdef preprocessor macros in upstream's header
files that has fallbacks.

The build is not fully reproducible with this change though, but it
will be once we enable fixfilepath dpkg-buildflags feature area toggle
archive-wide. (There's a thread unfolding on dpkg-dev now; no need to
set this here for now.)

 [0] https://reproducible-builds.org/


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: softether-vpn.diff.txt
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20201019/d9a5bd56/attachment.txt>