Bug#975046: open-iscsi: please make the build reproducible

[Chris Lamb]

Source: open-iscsi
Version: 2.1.2-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
open-iscsi could not be built reproducibly.

This is because the libopeniscsiusr/docs/kernel-doc script adds a
timestamp to the generated manpages. This script supports the
KBUILD_BUILD_TIMESTAMP environment variable though which is similar
to SOURCE_DATE_EPOCH but it supports any format that GNU date
will accept, even stuff like 'today + 4 days'.

Patch attached. Note the prefix '@' to '$(SOURCE_DATE_EPOCH)' so GNU
date interprets as a number of seconds though.

An alternative approach would be to ask upstream to move to
SOURCE_DATE_EPOCH, but it seems like KBUILD_BUILD_TIMESTAMP is used
elsewhere so I don't know the ramifications of this within the Kernel
ecosystem.


 [0] https://reproducible-builds.org/


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: open-iscsi.diff.txt
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20201118/3d259750/attachment.txt>