Bug#1039457: mplayer: reproducible-builds: version differences caused by /bin/sh implementations

[Vagrant Cascadian]

Source: mplayer
Version: 2:1.5+svn38423-2
Severity: normal
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: shell
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

When build with /bin/sh pointing to dash or bash, a different version.h
is generated, which results in different version strings getting
embedded in various binaries:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/mplayer.html

  /usr/bin/mencoder

  MPlayer·1.5+svn38423-2·(Debian)
  vs.
  MPlayer·1.5+svn38423-2·(Debian)\n

The two shell implementations have some differences in echo
implementations.

The patch to debian/rules fixes this by using a single printf call
instead of two echo calls, and adjusting the escaped strings
accordingly.


According to my local tests, with this patch applied mplayer should
build reproducibly again on tests.reproducible-builds.org when it
migrates to trixie/testing! Unfortunately, there are still outstanding
issues with embedded build paths that are tested in unstable and
experimental.


Thanks for maintaining mplayer!


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-debian-rules-Use-printf-instead-of-echo.patch
Type: text/x-diff
Size: 1581 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20230625/6e472786/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20230625/6e472786/attachment.sig>