<div dir="ltr">Hi Chris,<div><br></div><div>Based on this bug, please find attached a proposed patch for handling this error gracefully by catching any exceptions caused by trying to open an encrypted file in an archive. and forwarding it on as a <b>ContainerExtractionError</b>.</div><div><br></div><div>I would gladly appreciate some feedback. I tried to update the changelog as best as I understood <a href="https://reproducible-builds.org/contribute/#Fixing_issues">here</a>.</div><div><br></div><div>Additionally, I see that I could have also just submitted a merge request via <a href="https://salsa.debian.org">salsa.debian.org</a>. What is the usual workflow, email patches or merge requests?</div><div><br></div><div>Regards,</div><div>Ricardo</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Jul 27, 2018 at 5:28 PM Ricardo Gaviria <<a href="mailto:ricardo@unitelabs.ch">ricardo@unitelabs.ch</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Perfect! thanks for the clarification. Will look into it so ;) <div><div><br>P.S. I love <span class="m_6738819417126962326inbox-inbox-gr_ m_6738819417126962326inbox-inbox-gr_280 m_6738819417126962326inbox-inbox-gr-alert m_6738819417126962326inbox-inbox-gr_spell m_6738819417126962326inbox-inbox-gr_inline_cards m_6738819417126962326inbox-inbox-gr_run_anim m_6738819417126962326inbox-inbox-ContextualSpelling" id="m_6738819417126962326inbox-inbox-280" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat">diffoscope</span>! <br></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Jul 27, 2018 at 5:26 PM Chris Lamb <<a href="mailto:lamby@debian.org" target="_blank">lamby@debian.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Ricardo,<br>
<br>
> By the way, if this is a lower priority bug than others. I will gladly have<br>
> a look into the issue and try and resolve it, provided that we agree on the<br>
> expected behaviour of the tool under such a scenario.<br>
<br>
AIUI the *ideal* behaviour would be that encrypted files would:<br>
<br>
a) Not cause a traceback<br>
b) Be marked as such in the diff (see `add_comment` in the code)<br>
c) Be compared in a fallback (ie. binary) fashion<br>
<br>
Hope that helps. :)<br>
<br>
<br>
Regards,<br>
<br>
-- <br>
,''`.<br>
: :' : Chris Lamb<br>
`. `'` <a href="mailto:lamby@debian.org" target="_blank">lamby@debian.org</a> / <a href="http://chris-lamb.co.uk" rel="noreferrer" target="_blank">chris-lamb.co.uk</a><br>
`-<br>
</blockquote></div>-- <br><div dir="ltr" class="m_6738819417126962326gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Regards,<div>Ricardo Gaviria</div><div>Software Engineer, UniteLabs<br></div><div><div><b>M: </b><a href="tel:+41%2077%20956%2023%2076" value="+41779562376" target="_blank">+41 77 956 2376</a></div><div><b>W: </b><a href="http://unitelabs.ch" target="_blank">http://unitelabs.ch</a></div><div><b>In: </b><a href="https://www.linkedin.com/in/ricardogaviria/" target="_blank">https://www.linkedin.com/in/ricardogaviria/</a></div><br class="m_6738819417126962326inbox-inbox-inbox-inbox-inbox-inbox-inbox-inbox-inbox-Apple-interchange-newline"></div></div></div>
</blockquote></div></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Regards,<div>Ricardo Gaviria</div><div>Software Engineer, UniteLabs<br></div><div><div><b>M: </b>+41 77 956 2376</div><div><b>W: </b><a href="http://unitelabs.ch">http://unitelabs.ch</a></div><div><b>In: </b><a href="https://www.linkedin.com/in/ricardogaviria/">https://www.linkedin.com/in/ricardogaviria/</a></div><br class="inbox-inbox-inbox-inbox-inbox-inbox-inbox-inbox-inbox-inbox-Apple-interchange-newline"></div></div></div>