[Syslog-ng-maintainers] Bug#831677: syslog-ng: breaks reverse-dependencies

[Gianfranco Costamagna]

Source: syslog-ng
Severity: serious
Version: 3.7.3-1
Affects: syslog-ng-incubator

Hi, while trying to rebuild syslog-ng-incubator on top of the new syslog-ng I discovered it is actually FTBFS
I tried to patch the source, because seems that stats.h has been moved into stats/stats.h

the problem is that seems syslog-ng introducing some more backward incompatible changes, according to the new log
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/eventlog -I/usr/include/syslog-ng -I/usr/include/eventlog -I../../modules/riemann -I./modules/riemann -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -c ../../modules/riemann/riemann.c  -fPIC -DPIC -o modules/riemann/.libs/modules_riemann_libriemann_la-riemann.o
../../modules/riemann/riemann.c: In function 'riemann_worker_insert':
../../modules/riemann/riemann.c:329:51: warning: passing argument 2 of 'log_queue_pop_head' from incompatible pointer type [-Wincompatible-pointer-types]
success = log_queue_pop_head(self->super.queue, &msg, &path_options, FALSE, FALSE);
^
In file included from /usr/include/syslog-ng/driver.h:30:0,
from /usr/include/syslog-ng/logthrdestdrv.h:29,
from ../../modules/riemann/riemann.c:29:
/usr/include/syslog-ng/logqueue.h:107:1: note: expected 'LogPathOptions * {aka struct _LogPathOptions *}' but argument is of type 'LogMessage ** {aka struct _LogMessage **}'
log_queue_pop_head(LogQueue *self, LogPathOptions *path_options)
^
../../modules/riemann/riemann.c:329:13: error: too many arguments to function 'log_queue_pop_head'
success = log_queue_pop_head(self->super.queue, &msg, &path_options, FALSE, FALSE);
^
In file included from /usr/include/syslog-ng/driver.h:30:0,
from /usr/include/syslog-ng/logthrdestdrv.h:29,
from ../../modules/riemann/riemann.c:29:
/usr/include/syslog-ng/logqueue.h:107:1: note: declared here
log_queue_pop_head(LogQueue *self, LogPathOptions *path_options)
^
../../modules/riemann/riemann.c:329:11: warning: assignment makes integer from pointer without a cast [-Wint-conversion]
success = log_queue_pop_head(self->super.queue, &msg, &path_options, FALSE, FALSE);
^
../../modules/riemann/riemann.c:435:35: warning: passing argument 2 of 'log_msg_tags_foreach' from incompatible pointer type [-Wincompatible-pointer-types]
log_msg_tags_foreach(msg, riemann_dd_field_add_msg_tag,
^
In file included from /usr/include/syslog-ng/logpipe.h:29:0,
from /usr/include/syslog-ng/driver.h:29,
from /usr/include/syslog-ng/logthrdestdrv.h:29,
from ../../modules/riemann/riemann.c:29:
/usr/include/syslog-ng/logmsg.h:272:6: note: expected 'LogMessageTagsForeachFunc {aka int (*)(const struct _LogMessage *, short unsigned int,  const char *, void *)}' but argument is of type 'gboolean (*)(LogMessage *, LogTagId,  const gchar *, void *) {aka int (*)(struct _LogMessage *, short unsigned int,  const char *, void *)}'
void log_msg_tags_foreach(const LogMessage *self, LogMessageTagsForeachFunc callback, gpointer user_data);
^
../../modules/riemann/riemann.c:455:7: error: too few arguments to function 'log_msg_ack'
log_msg_ack(msg, &path_options);
^
In file included from /usr/include/syslog-ng/logpipe.h:29:0,
from /usr/include/syslog-ng/driver.h:29,
from /usr/include/syslog-ng/logthrdestdrv.h:29,
from ../../modules/riemann/riemann.c:29:
/usr/include/syslog-ng/logmsg.h:290:6: note: declared here
void log_msg_ack(LogMessage *msg, const LogPathOptions *path_options, AckType ack_type);
^
../../modules/riemann/riemann.c:464:11: error: too few arguments to function 'log_msg_ack'
log_msg_ack(msg, &path_options);
^
In file included from /usr/include/syslog-ng/logpipe.h:29:0,
from /usr/include/syslog-ng/driver.h:29,
from /usr/include/syslog-ng/logthrdestdrv.h:29,
from ../../modules/riemann/riemann.c:29:
/usr/include/syslog-ng/logmsg.h:290:6: note: declared here
void log_msg_ack(LogMessage *msg, const LogPathOptions *path_options, AckType ack_type);
^
../../modules/riemann/riemann.c: In function 'riemann_dd_new':
../../modules/riemann/riemann.c:507:3: error: too few arguments to function 'log_threaded_dest_driver_init_instance'
log_threaded_dest_driver_init_instance(&self->super);
^
In file included from ../../modules/riemann/riemann.c:29:0:
/usr/include/syslog-ng/logthrdestdrv.h:102:6: note: declared here
void log_threaded_dest_driver_init_instance(LogThrDestDriver *self, GlobalConfig *cfg);
^
../../modules/riemann/riemann.c:513:29: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]
self->super.worker.insert = riemann_worker_insert;
^
Makefile:1807: recipe for target 'modules/riemann/modules_riemann_libriemann_la-riemann.lo' failed
make[2]: *** [modules/riemann/modules_riemann_libriemann_la-riemann.lo] Error 1
make[2]: Leaving directory '/build/syslog-ng-incubator-0.3.3/debian/build-tree'
Makefile:1126: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/build/syslog-ng-incubator-0.3.3/debian/build-tree'
dh_auto_build: make -j1 returned exit code 2
debian/rules:39: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2


cheers,

G.