[3dprinter-general] Bug#884709: cura: Require explicit consent to anonymous slicing statistics

[Gregor Riepl]

The plugin can be disabled during package building with:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 1c372ffa..6baae46a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -39,7 +39,8 @@ find_package(PythonInterp 3.5.0 REQUIRED)
 install(DIRECTORY resources
         DESTINATION ${CMAKE_INSTALL_DATADIR}/cura)
 install(DIRECTORY plugins
-        DESTINATION lib/cura)
+        DESTINATION lib/cura
+        PATTERN plugins/SliceInfoPlugin EXCLUDE)
 if(NOT APPLE AND NOT WIN32)
     install(FILES cura_app.py
             DESTINATION ${CMAKE_INSTALL_BINDIR}


To switch the default to "disabled", use (still needs i18n):

diff --git a/plugins/SliceInfoPlugin/SliceInfo.py
b/plugins/SliceInfoPlugin/SliceInfo.py
index 0514c4da..2c3d6ba3 100755
--- a/plugins/SliceInfoPlugin/SliceInfo.py
+++ b/plugins/SliceInfoPlugin/SliceInfo.py
@@ -36,11 +36,11 @@ class SliceInfo(Extension):
     def __init__(self):
         super().__init__()

Application.getInstance().getOutputDeviceManager().writeStarted.connect(self._onWriteStarted)
-        Preferences.getInstance().addPreference("info/send_slice_info", True)
+        Preferences.getInstance().addPreference("info/send_slice_info", False)
         Preferences.getInstance().addPreference("info/asked_send_slice_info",
False)

         if not Preferences.getInstance().getValue("info/asked_send_slice_info"):
-            self.send_slice_info_message = Message(catalog.i18nc("@info",
"Cura collects anonymised slicing statistics. You can disable this in the
preferences."),
+            self.send_slice_info_message = Message(catalog.i18nc("@info",
"Cura may optionally collect anonymised slicing statistics. You can enable
this feature in the preferences."),
                                                    lifetime = 0,
                                                    dismissable = False,
                                                    title =
catalog.i18nc("@info:title", "Collecting Data"))