[Amavisd-new-debian-devel] Re: Bug#350962: amavisd-new: cab files not detected

[Henrique de Moraes Holschuh]

Mark,

A Debian user reported the bug below, and kindly provided a patch about a
case mismatch for Microsoft cabinet.

The patch is easier to download from
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=350962

Is there a reason not to make all file(1) matching case-insensitive? I am
inclined to do that to avoid future problems of this sort...

On Thu, 02 Feb 2006, AP wrote:
> Package: amavisd-new
> Version: 1:2.3.3-4
> Severity: important
> 
> 
> All's well except that file is reporting cab archives as:
> 
> Microsoft Cabinet file, 621 bytes, 1 file
> 
> and not as:
> 
> Microsoft cabinet file, 621 bytes, 1 file
> 
> as amavis expects in:
> 
>   [qr/^Microsoft cabinet file\b/      => 'cab'],
> 
> The fix is obvious. Change the above to:
> 
>   [qr/^Microsoft cabinet file\b/i      => 'cab'],
> 
> And it all works well :)
> 
> Patch below:
> 
> --- amavisd-new	2006-02-02 11:46:54.000000000 +1100
> +++ /usr/sbin/amavisd-new	2006-02-02 11:46:59.000000000 +1100
> @@ -789,7 +789,7 @@
>    [qr/^current ar archive\b/i         => 'a'],    # standard Unix archive (ar)
>    [qr/^RPM\b/                         => 'rpm'],
>    [qr/^(Transport Neutral Encapsulation Format|TNEF)\b/i => 'tnef'],
> -  [qr/^Microsoft cabinet file\b/      => 'cab'],
> +  [qr/^Microsoft cabinet file\b/i     => 'cab'],
>  
>    [qr/^(uuencoded|xxencoded)\b/i      => 'uue'],
>    [qr/^binhex\b/i                     => 'hqx'],
> 
> 

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh