[Android-tools-devel] Bug#824930: Bug#824930: Bug#824930: Bug#824930: Bug#824930: Bug#824930: apktool: creates directories and an empty 1.apk file in $HOME contain

[Chirayu Desai]

I have it ready at [1] & [2]

On Thu, Jun 9, 2016 at 9:11 AM, Paul Wise <pabs at debian.org> wrote:
> On Thu, 2016-06-09 at 00:32 +0530, Chirayu Desai wrote:
>
>> This was discussed on IRC, and since we already need to build
>> framework-res.apk for android.jar (it is extracted and the contents
>> are included as-is in the jar), we can also have a separate package
>> for it, which I have ready at:
>
> Excellent, perfect resolution to this issue!
>
> It sounds like the package that will contain android.jar should have
> Built-Using set to android-framework-res (= $version) so that the
> Debian archive will keep the right version available.
Currently both android.jar and framework-res.apk are built from
android-platform-frameworks-base, and so android.jar uses the current
version directly.
Once that is working and versioning is added later on, this could be done.
>
>> https://gitlab.com/cde/debian_android-tools_android-platform-frameworks-base/commit/1ea978033eb92e0c7c14f1ca40c61d84b2a2e7f1
>
> Nitpicks:
>
> You don't need dh-exec for android-framework-res.install
Why?
It didn't work when I tried it without.
>
> The android-framework-res package description needs filling out.
>
> I would have put the contents of debian/framework-res.mk into
> debian/rules and debian/clean instead.
Done
>
>> I have a patch locally that makes it use ~/.local/share/apktool, can
>> update it / push it as preferred.
>
> If the android-framework-res package is installed (should be in the
> apktool Depends), I don't think apktool should create any directories
> or files in ~/ until the user manually installs another framework.
That might need more changes, as currently it will install the system
framework to 1.apk
>
> I don't know enough about which of ~/.local or ~/.cache should be
> preferred but it definitely should use one of them instead of what the
> upstream developers have chosen.
Yes. The patch I have for this is [3], works well when combined with
[2] (otherwise you get a NPE)
>
> --
> bye,
> pabs
>
> https://wiki.debian.org/PaulWise
>
> _______________________________________________
> Android-tools-devel mailing list
> Android-tools-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/android-tools-devel

[1]: https://gitlab.com/cde/debian_android-tools_android-platform-frameworks-base/commits/f-r-apk/master
[2]: https://gitlab.com/cde/debian_android-tools_apktool/commits/f-r-apk/master
[3]: https://gitlab.com/cde/debian_android-tools_apktool/commits/path/master