[Android-tools-devel] RFS: android-platform-libcore/6.0.1+r55-1

[Markus Koschany]

On 27.07.2016 20:22, 殷啟聰 wrote:
> Hi Markus,
> 
> So far I have filed RFS for 4 packages:
> 
>   * android-platform-libcore
>   * android-platform-external-jsilver
>   * android-platfom-frameworks-data-binding
>   * jacoco

Hi,

my review:

android-platform-libcore:
=========================

Please use versioned Breaks and Replaces. Useful if someone else
reintroduces the old package name in another context

Breaks: libdex-java (<< 6.0.1+r55-1~)
Replaces: libdex-java (<< 6.0.1+r55-1~)

libandroid-dex-java (= ${binary:Version})

I think just libandroid-dex-java will do or is there a reason why we
would need such a strict dependency?

incompatible-java-bytecode-format Java8

Please override the Lintian warning if Java 8 is in fact required
Otherwise I recommend to build Java 6 (preferred for maximum
compatibility) or Java 7 classes.

unused-file-paragraph-in-dep5-copyright paragraph at line 37

Files: luni/*
Copyright: 1991-2006 Unicode, Inc.
License: Unicode

Files: luni/*
Copyright: 2000-2006, The Legion Of The Bouncy Castle
License: bouncycastle

Both paragraphs together can't be right. Please double-check the luni
directory again. The parser always regards the last paragraph as the
valid one, so it would be best to move from the generic license (Files:
*) to directory based paragraphs (Files: luni/*) to file specific
paragraphs (Files: luni/myfile.java) Thus the copyright file would be
accurate and you won't see any Lintian warnings anymore.

android-platform-external-jsilver:
==================================

versioned Breaks and Replaces please

incompatible-java-bytecode-format (see above)

android-platform-frameworks-data-binding:
=========================================

unused-file-paragraph-in-dep5-copyright paragraph at line 11
unused-file-paragraph-in-dep5-copyright paragraph at line 16

Again the parser is right and the ordering should be changed

There are more BSD licensed files:

 compilerCommon/BindingExpression.g4
 compilerCommon/XMLLexer.g4

Please double-check again if other licenses are missing

jacoco review is here:
======

https://lists.alioth.debian.org/pipermail/pkg-java-maintainers/2016-July/060618.html

Regards,

Markus











-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/android-tools-devel/attachments/20160728/90218f58/attachment.sig>