[Android-tools-devel] RFS: android-platform-external-doclava/6.0.1+r55-1 [ITP]

[殷啟聰]

Hi Markus,

Thank you for your review!

I added "debian/missing-sources" and mentioned the BSD-3-clause licensed file.

I named it "doclava-aosp" because Doclava is not only a Java library
but also a Java program. This package installs a launcher script so
that we can use Doclava from the command line instead of using
"javadoc" with the doclet option. In fact, I tried the doclet option
and it failed to run... :(

Cheers,
Kai-Chung Yan

2016-08-21 7:00 GMT+08:00 Markus Koschany <apo at debian.org>:
> On 20.08.2016 13:19, Chirayu Desai wrote:
>> Done http://deb.li/3rsxx
>> doclava built without this doesn't work, so it'll be needed to use it in
>> general.
>
> Hi,
>
> here are some things that we need to fix:
>
> debian/copyright:
>
>
> Better use the specific GPL-3+ instead of GPL which is too generic.
>
> I already fixed a syntax error (should be GPL-3+ and MIT, not GPL, and MIT)
>
> Please mention the license of src/com/google/doclava/parser/Java.g
>
> We need the sources of
>
> jquery-resizable.min.js and
> res/assets/templates/assets/prettify.js
>
> Please add them to debian/missing-sources.
>
> debian/control:
>
> What do you think about changing the binary name from doclava-aosp to
> libdoclava-aosp-java? That would be in line with libjsilver-aosp-java
> for example.
>
> Rest looks good.
>
> Regards,
>
> Markus
>
>
>
> _______________________________________________
> Android-tools-devel mailing list
> Android-tools-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/android-tools-devel



-- 
/*
* 殷啟聰 | Kai-Chung Yan
* 一生只向真理與妻子低頭
* Undergraduate student in National Taichung University of Education
* LinkedIn: <https://linkedin.com/in/seamlik>
* Blog: <http://seamlik.logdown.com>
*/