[Android-tools-devel] Bug#942019: Assembling an .apk fails with: Invalid file name: must contain only [a-z0-9_.]

[Georg Koppen]

Package: apktool
Version: 2.4.0-1

When using apktool to assemble a .apk after decompiling it I get the
following error:

W: aapt: brut.common.BrutException: brut.common.BrutException: Could not
extract resource: /prebuilt/linux/aapt_64 (defaulting to $PATH binary)
W: res/drawable/$avd_hide_password__0.xml: Invalid file name: must
contain only [a-z0-9_.]
W: res/drawable/$avd_hide_password__1.xml: Invalid file name: must
contain only [a-z0-9_.]
W: res/drawable/$avd_hide_password__2.xml: Invalid file name: must
contain only [a-z0-9_.]
W: res/drawable/$avd_show_password__0.xml: Invalid file name: must
contain only [a-z0-9_.]
W: res/drawable/$avd_show_password__1.xml: Invalid file name: must
contain only [a-z0-9_.]
W: res/drawable/$avd_show_password__2.xml: Invalid file name: must
contain only [a-z0-9_.]
brut.androlib.AndrolibException: brut.common.BrutException: could not
exec (exit code = 1): [aapt, p, --min-sdk-version, 21,
--target-sdk-version, 28, --version-code, 2015620227, --version-name,
68.1.0, --no-version-vectors, -F, /tmp/APKTOOL6614726003976878246.tmp,
-0, arsc, -0, txt, -0, png, -0, ja, -0,
assets/features/webcompat-reporter at mozilla.org.xpi, -0,
assets/features/webcompat at mozilla.org.xpi, -0,
res/drawable-hdpi-v4/abc_ab_share_pack_mtrl_alpha.9.png, -0,
res/drawable-hdpi-v4/abc_btn_switch_to_on_mtrl_00001.9.png, -0,
res/drawable-hdpi-v4/abc_btn_switch_to_on_mtrl_00012.9.png, -0,
res/drawable-hdpi-v4/abc_cab_background_top_mtrl_alpha.9.png, -0,
res/drawable-hdpi-v4/abc_list_divider_mtrl_alpha.9.png, -0,
res/drawable-hdpi-v4/abc_list_focused_holo.9.png, -0,
res/drawable-hdpi-v4/abc_list_longpressed_holo.9.png, -0,
res/drawable-hdpi-v4/abc_list_pressed_holo_dark.9.png, -0,
res/drawable-hdpi-v4/abc_list_pressed_holo_light.9.png, -0,
res/drawable-hdpi-v4/abc_list_selector_disabled_holo_dark.9.png, -0,
res/drawable-hdpi-v4/abc_list_selector_disabled_holo_light.9.png, -0,
res/drawable-hdpi-v4/abc_menu_hardkey_panel_mtrl_mult.9.png, -0,
res/drawable-hdpi-v4/abc_popup_background_mtrl_mult.9.png, -0,
res/drawable-hdpi-v4/abc_scrubber_primary_mtrl_alpha.9.png, -0,
res/drawable-hdpi-v4/abc_scrubber_track_mtrl_alpha.9.png, -0,
res/drawable-hdpi-v4/abc_spinner_mtrl_am_alpha.9.png, -0,
res/drawable-hdpi-v4/abc_switch_track_mtrl_alpha.9.png, -0,
res/drawable-hdpi-v4/abc_tab_indicator_mtrl_alpha.9.png, -0,
res/drawable-hdpi-v4/abc_textfield_activated_mtrl_alpha.9.png, -0,
res/drawable-hdpi-v4/abc_textfield_default_mtrl_alpha.9.png, -0,
res/drawable-hdpi-v4/abc_textfield_search_activated_mtrl_alpha.9.png,
-0, res/drawable-hdpi-v4/abc_textfield_search_default_mtrl_alpha.9.png,
-0, res/drawable-hdpi-v4/color_picker_row_bg.9.png, -0,
res/drawable-hdpi-v4/dropshadow.9.png, -0,
res/drawable-hdpi-v4/grid_icon_bg_activated.9.png, -0,
res/drawable-hdpi-v4/grid_icon_bg_focused.9.png, -0, webp, -0,
res/drawable-hdpi-v4/home_tab_menu_strip.9.png, -0,
res/drawable-hdpi-v4/notification_bg_low_normal.9.png, -0,
res/drawable-hdpi-v4/notification_bg_low_pressed.9.png, -0,
res/drawable-hdpi-v4/notification_bg_normal.9.png, -0,
res/drawable-hdpi-v4/notification_bg_normal_pressed.9.png, -0,
res/drawable-hdpi-v4/tab_indicator_background.9.png, -0,
res/drawable-hdpi-v4/tab_indicator_selected.9.png, -0,
res/drawable-hdpi-v4/tab_indicator_selected_focused.9.png, -0,
res/drawable-hdpi-v4/url_bar_entry_default.9.png, -0,
res/drawable-hdpi-v4/url_bar_entry_default_pb.9.png, -0,
res/drawable-hdpi-v4/url_bar_entry_pressed.9.png, -0,
res/drawable-hdpi-v4/url_bar_entry_pressed_pb.9.png, -0,
res/drawable-hdpi-v4/validation_bg.9.png, -0,
res/drawable-large-hdpi-v11/url_bar_entry_default.9.png, -0,
res/drawable-large-hdpi-v11/url_bar_entry_default_pb.9.png, -0,
res/drawable-large-hdpi-v11/url_bar_entry_pressed.9.png, -0,
res/drawable-large-hdpi-v11/url_bar_entry_pressed_pb.9.png, -0,
res/drawable-large-xhdpi-v11/url_bar_entry_default.9.png, -0,
res/drawable-large-xhdpi-v11/url_bar_entry_default_pb.9.png, -0,
res/drawable-large-xhdpi-v11/url_bar_entry_pressed.9.png, -0,
res/drawable-large-xhdpi-v11/url_bar_entry_pressed_pb.9.png, -0,
res/drawable-large-xxhdpi-v11/url_bar_entry_default.9.png, -0,
res/drawable-large-xxhdpi-v11/url_bar_entry_default_pb.9.png, -0,
res/drawable-large-xxhdpi-v11/url_bar_entry_pressed.9.png, -0,
res/drawable-large-xxhdpi-v11/url_bar_entry_pressed_pb.9.png, -0,
res/drawable-ldrtl-hdpi-v17/abc_spinner_mtrl_am_alpha.9.png, -0,
res/drawable-ldrtl-mdpi-v17/abc_spinner_mtrl_am_alpha.9.png, -0,
res/drawable-ldrtl-xhdpi-v17/abc_spinner_mtrl_am_alpha.9.png, -0,
res/drawable-ldrtl-xxhdpi-v17/abc_spinner_mtrl_am_alpha.9.png, -0,
res/drawable-ldrtl-xxxhdpi-v17/abc_spinner_mtrl_am_alpha.9.png, -0,
res/drawable-mdpi-v4/abc_ab_share_pack_mtrl_alpha.9.png, -0,
res/drawable-mdpi-v4/abc_btn_switch_to_on_mtrl_00001.9.png, -0,
res/drawable-mdpi-v4/abc_btn_switch_to_on_mtrl_00012.9.png, -0,
res/drawable-mdpi-v4/abc_cab_background_top_mtrl_alpha.9.png, -0,
res/drawable-mdpi-v4/abc_list_divider_mtrl_alpha.9.png, -0,
res/drawable-mdpi-v4/abc_list_focused_holo.9.png, -0,
res/drawable-mdpi-v4/abc_list_longpressed_holo.9.png, -0,
res/drawable-mdpi-v4/abc_list_pressed_holo_dark.9.png, -0,
res/drawable-mdpi-v4/abc_list_pressed_holo_light.9.png, -0,
res/drawable-mdpi-v4/abc_list_selector_disabled_holo_dark.9.png, -0,
res/drawable-mdpi-v4/abc_list_selector_disabled_holo_light.9.png, -0,
res/drawable-mdpi-v4/abc_menu_hardkey_panel_mtrl_mult.9.png, -0,
res/drawable-mdpi-v4/abc_popup_background_mtrl_mult.9.png, -0,
res/drawable-mdpi-v4/abc_scrubber_primary_mtrl_alpha.9.png, -0,
res/drawable-mdpi-v4/abc_scrubber_track_mtrl_alpha.9.png, -0,
res/drawable-mdpi-v4/abc_spinner_mtrl_am_alpha.9.png, -0,
res/drawable-mdpi-v4/abc_switch_track_mtrl_alpha.9.png, -0,
res/drawable-mdpi-v4/abc_tab_indicator_mtrl_alpha.9.png, -0,
res/drawable-mdpi-v4/abc_textfield_activated_mtrl_alpha.9.png, -0,
res/drawable-mdpi-v4/abc_textfield_default_mtrl_alpha.9.png, -0,
res/drawable-mdpi-v4/abc_textfield_search_activated_mtrl_alpha.9.png,
-0, res/drawable-mdpi-v4/abc_textfield_search_default_mtrl_alpha.9.png,
-0, res/drawable-mdpi-v4/notification_bg_low_normal.9.png, -0,
res/drawable-mdpi-v4/notification_bg_low_pressed.9.png, -0,
res/drawable-mdpi-v4/notification_bg_normal.9.png, -0,
res/drawable-mdpi-v4/notification_bg_normal_pressed.9.png, -0,
res/drawable-nodpi-v4/home_tab_menu_strip_tor.9.png, -0, gif, -0,
res/drawable-xhdpi-v4/abc_ab_share_pack_mtrl_alpha.9.png, -0,
res/drawable-xhdpi-v4/abc_btn_switch_to_on_mtrl_00001.9.png, -0,
res/drawable-xhdpi-v4/abc_btn_switch_to_on_mtrl_00012.9.png, -0,
res/drawable-xhdpi-v4/abc_cab_background_top_mtrl_alpha.9.png, -0,
res/drawable-xhdpi-v4/abc_list_divider_mtrl_alpha.9.png, -0,
res/drawable-xhdpi-v4/abc_list_focused_holo.9.png, -0,
res/drawable-xhdpi-v4/abc_list_longpressed_holo.9.png, -0,
res/drawable-xhdpi-v4/abc_list_pressed_holo_dark.9.png, -0,
res/drawable-xhdpi-v4/abc_list_pressed_holo_light.9.png, -0,
res/drawable-xhdpi-v4/abc_list_selector_disabled_holo_dark.9.png, -0,
res/drawable-xhdpi-v4/abc_list_selector_disabled_holo_light.9.png, -0,
res/drawable-xhdpi-v4/abc_menu_hardkey_panel_mtrl_mult.9.png, -0,
res/drawable-xhdpi-v4/abc_popup_background_mtrl_mult.9.png, -0,
res/drawable-xhdpi-v4/abc_scrubber_primary_mtrl_alpha.9.png, -0,
res/drawable-xhdpi-v4/abc_scrubber_track_mtrl_alpha.9.png, -0,
res/drawable-xhdpi-v4/abc_spinner_mtrl_am_alpha.9.png, -0,
res/drawable-xhdpi-v4/abc_switch_track_mtrl_alpha.9.png, -0,
res/drawable-xhdpi-v4/abc_tab_indicator_mtrl_alpha.9.png, -0,
res/drawable-xhdpi-v4/abc_textfield_activated_mtrl_alpha.9.png, -0,
res/drawable-xhdpi-v4/abc_textfield_default_mtrl_alpha.9.png, -0,
res/drawable-xhdpi-v4/abc_textfield_search_activated_mtrl_alpha.9.png,
-0, res/drawable-xhdpi-v4/abc_textfield_search_default_mtrl_alpha.9.png,
-0, res/drawable-xhdpi-v4/color_picker_row_bg.9.png, -0,
res/drawable-xhdpi-v4/dropshadow.9.png, -0,
res/drawable-xhdpi-v4/grid_icon_bg_activated.9.png, -0,
res/drawable-xhdpi-v4/grid_icon_bg_focused.9.png, -0,
res/drawable-xhdpi-v4/notification_bg_low_normal.9.png, -0,
res/drawable-xhdpi-v4/notification_bg_low_pressed.9.png, -0,
res/drawable-xhdpi-v4/notification_bg_normal.9.png, -0,
res/drawable-xhdpi-v4/notification_bg_normal_pressed.9.png, -0,
res/drawable-xhdpi-v4/url_bar_entry_default.9.png, -0,
res/drawable-xhdpi-v4/url_bar_entry_default_pb.9.png, -0,
res/drawable-xhdpi-v4/url_bar_entry_pressed.9.png, -0,
res/drawable-xhdpi-v4/url_bar_entry_pressed_pb.9.png, -0,
res/drawable-xhdpi-v4/validation_bg.9.png, -0,
res/drawable-xxhdpi-v4/abc_ab_share_pack_mtrl_alpha.9.png, -0,
res/drawable-xxhdpi-v4/abc_btn_switch_to_on_mtrl_00001.9.png, -0,
res/drawable-xxhdpi-v4/abc_btn_switch_to_on_mtrl_00012.9.png, -0,
res/drawable-xxhdpi-v4/abc_cab_background_top_mtrl_alpha.9.png, -0,
res/drawable-xxhdpi-v4/abc_list_divider_mtrl_alpha.9.png, -0,
res/drawable-xxhdpi-v4/abc_list_focused_holo.9.png, -0,
res/drawable-xxhdpi-v4/abc_list_longpressed_holo.9.png, -0,
res/drawable-xxhdpi-v4/abc_list_pressed_holo_dark.9.png, -0,
res/drawable-xxhdpi-v4/abc_list_pressed_holo_light.9.png, -0,
res/drawable-xxhdpi-v4/abc_list_selector_disabled_holo_dark.9.png, -0,
res/drawable-xxhdpi-v4/abc_list_selector_disabled_holo_light.9.png, -0,
res/drawable-xxhdpi-v4/abc_menu_hardkey_panel_mtrl_mult.9.png, -0,
res/drawable-xxhdpi-v4/abc_popup_background_mtrl_mult.9.png, -0,
res/drawable-xxhdpi-v4/abc_scrubber_primary_mtrl_alpha.9.png, -0,
res/drawable-xxhdpi-v4/abc_scrubber_track_mtrl_alpha.9.png, -0,
res/drawable-xxhdpi-v4/abc_spinner_mtrl_am_alpha.9.png, -0,
res/drawable-xxhdpi-v4/abc_switch_track_mtrl_alpha.9.png, -0,
res/drawable-xxhdpi-v4/abc_tab_indicator_mtrl_alpha.9.png, -0,
res/drawable-xxhdpi-v4/abc_textfield_activated_mtrl_alpha.9.png, -0,
res/drawable-xxhdpi-v4/abc_textfield_default_mtrl_alpha.9.png, -0,
res/drawable-xxhdpi-v4/abc_textfield_search_activated_mtrl_alpha.9.png,
-0,
res/drawable-xxhdpi-v4/abc_textfield_search_default_mtrl_alpha.9.png,
-0, res/drawable-xxhdpi-v4/dropshadow.9.png, -0,
res/drawable-xxhdpi-v4/url_bar_entry_default.9.png, -0,
res/drawable-xxhdpi-v4/url_bar_entry_default_pb.9.png, -0,
res/drawable-xxhdpi-v4/url_bar_entry_pressed.9.png, -0,
res/drawable-xxhdpi-v4/url_bar_entry_pressed_pb.9.png, -0,
res/drawable-xxxhdpi-v4/abc_btn_switch_to_on_mtrl_00001.9.png, -0,
res/drawable-xxxhdpi-v4/abc_btn_switch_to_on_mtrl_00012.9.png, -0,
res/drawable-xxxhdpi-v4/abc_spinner_mtrl_am_alpha.9.png, -0,
res/drawable-xxxhdpi-v4/abc_switch_track_mtrl_alpha.9.png, -0,
res/drawable-xxxhdpi-v4/abc_tab_indicator_mtrl_alpha.9.png, -0,
res/drawable/list_section_divider_mtrl_alpha.9.png, -0, arsc, -I,
/home/thomas/.local/share/apktool/framework/1.apk, -S,
/home/thomas/Arbeit/Tor/tor-browser-build/test/decompile/res, -M,
/home/thomas/Arbeit/Tor/tor-browser-build/test/decompile/AndroidManifest.xml]

Steps to reproduce:

1) Download the latest Tor Browser 9.0a7 for aarch64 from our archive[1]
2) Run in a terminal:

apktool d --no-src -o decompiled tor-browser-9.0a7-android-aarch64-multi.apk

3) Run in a terminal:

apktool b -o test.apk decompiled

4) The exception is shown and the .apk is not re-assembled.

Some notes:

1) This works with the 2.4.0 .apk downloaded from the Internet.[2]
2) If I use Tor Browser stable (which is still based on ESR 60 instead
of the alpha which is based on ESR68) I can't reproduce the issue. Only

W: aapt: brut.common.BrutException: brut.common.BrutException: Could not
extract resource: /prebuilt/linux/aapt_64 (defaulting to $PATH binary)

is shown in the terminal but assembling the .apk succeeds in that case.

3) The original bug report can be found in Tor's bugtracker.[3]

Georg

[1]
https://archive.torproject.org/tor-package-archive/torbrowser/9.0a7/tor-browser-9.0a7-android-aarch64-multi.apk
[2] https://bitbucket.org/iBotPeaches/apktool/downloads/apktool_2.4.0.jar
[3] https://trac.torproject.org/projects/tor/ticket/31564#comment:44

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/android-tools-devel/attachments/20191009/44be785c/attachment.sig>