[Android-tools-devel] Bug#1001757: RFS: google-android-installers/1639148153 [NMU] -- Google's Android SDK

[Roger Shimizu]

Dear Fab,

On Tue, May 24, 2022 at 8:40 PM Fab Stz <fabstz-it at yahoo.fr> wrote:
>
> Le mardi 24 mai 2022, 13:01:13 CEST Roger Shimizu a écrit :
> > Dear Fab,
> >
> > On Tue, May 24, 2022 at 1:01 AM Fab Stz <fabstz-it at yahoo.fr> wrote:
> > > Le jeudi 19 mai 2022, 18:16:50 CEST Roger Shimizu a écrit :
> > > > I think there's no need to download the whole file, but just use HTTP
> > > > HEAD command to check whether the file is able to download or not.
> > > > This can save a lot of bandwidth, and time of test execution.
> > > > Anyway, I don't have any existing code on hand.
> > > > Just an idea to share with you.
> > >
> > > I would need some guidance here. I don't understand what you mean by HTTP
> > > HEAD command. Do you mean with curl or wget or something like that?
> > > Putting the URL manually in the d/tests/control file doesn't bring any
> > > guarantee that the binary package will be able to download the binary not
> > > to speak about running it (eg. if the URL is incorrect in it).
> >
> > Sorry I didn't make this clear enough.
> > HTTP HEAD command is not a real command in shell, but a command in
> > HTTP protocol [1].
> >
> > both curl and wget [2] should support HEAD.
> >
> > [1] https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/HEAD
> > [2] https://superuser.com/questions/197009/wget-head-request
> >
> > > Maybe we should simply disable the tests by default because installing any
> > > binary package necessarily downloads the whole file (except if cached on
> > > the user system).
> >
> > I think the unit test can as simple as to check all embedded URL are
> > working. Please try HEAD command mentioned above first.
>
> Actually, computing the download URL of each Android SDK component is not an
> easy task. This job is what is done in the postinst script together with the
> "Makefile" that are shipped in each package.
>
> So that would mean implementing yet another way to compute the URL, different
> from the one in postinst & Makefile. IMHO this wouldn't help in testing that
> the binary packages will work to download the components from google servers
> since the computation of the URL will use a different method than the one of
> the packages.
>
> So, for now, I simply removed the tests.

I merged your new MR.
But I found you didn't add new entry in d/changelog, so I cannot upload.

Feel free to make another MR when you're ready.
BTW. I prefer there's an autopkgtest test, even it's a simple one.
Thank you!

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1