[Aptitude-devel] r3152 - in branches/aptitude-0.3/aptitude: . src/vscreen

Daniel Burrows dburrows@costa.debian.org
Wed, 27 Apr 2005 16:08:40 +0000


Author: dburrows
Date: Wed Apr 27 16:08:37 2005
New Revision: 3152

Modified:
   branches/aptitude-0.3/aptitude/ChangeLog
   branches/aptitude-0.3/aptitude/src/vscreen/vs_tree.cc
Log:
Don't call highlighted() in vs_tree::paint(), it causes way too
much recalculation.

Modified: branches/aptitude-0.3/aptitude/ChangeLog
==============================================================================
--- branches/aptitude-0.3/aptitude/ChangeLog	(original)
+++ branches/aptitude-0.3/aptitude/ChangeLog	Wed Apr 27 16:08:37 2005
@@ -1,5 +1,11 @@
 2005-04-27  Daniel Burrows  <dburrows@debian.org>
 
+	* src/vscreen/vs_tree.cc:
+
+	  Remove the grotesque hack of calling highlighted() in paint();
+	  among other things, it was responsible for making everything
+	  slow when the user was scrolling around the description area.
+
 	* src/generic/aptcache.cc, src/generic/aptitude_resolver.cc, src/generic/aptitude_resolver.h, src/generic/problemresolver/problemresolver.h:
 
 	  Put a cap on how many successors will be generated for any given

Modified: branches/aptitude-0.3/aptitude/src/vscreen/vs_tree.cc
==============================================================================
--- branches/aptitude-0.3/aptitude/src/vscreen/vs_tree.cc	(original)
+++ branches/aptitude-0.3/aptitude/src/vscreen/vs_tree.cc	Wed Apr 27 16:08:37 2005
@@ -1,6 +1,6 @@
 // vs_tree.cc
 //
-//  Copyright 1999 Daniel Burrows
+//  Copyright 1999-2002, 2004-2005 Daniel Burrows
 //
 //  This program is free software; you can redistribute it and/or modify
 //  it under the terms of the GNU General Public License as published by
@@ -761,8 +761,8 @@
 	}
     }
 
-  if(selected!=end && selected->get_selectable())
-    selected->highlighted(this);
+  //if(selected!=end && selected->get_selectable())
+  //selected->highlighted(this);
   // Some classes need this to update display stuff properly.  For instance,
   // when a new pkg_tree is created, its 'update the status line' signal
   // won't be properly called without this.