[Aptitude-devel] [PATCH 2 of 4] * src/gtk/entityview.cc (EntityView::setup_column_properties): if

Daniel Burrows dburrows at debian.org
Mon Dec 29 14:46:48 UTC 2008

On Fri, Dec 26, 2008 at 01:26:47PM +0100, Luca Bruno <lethalman88 at gmail.com> was heard to say:
> # HG changeset patch
> # User Luca Bruno <lethalman88 at gmail.com>
> # Date 1230288425 -3600
> # Node ID fd610a4a201e14871a8a5990d7bdee7a0351673b
> # Parent  a12881333af93cd5eca3c17a85f02e1082571f78
> 	* src/gtk/entityview.cc (EntityView::setup_column_properties): if
> 	  size < 0 use AUTOSIZE sizing
> 	(EntityView::init): setup Status column properties with size = -1

  Please revert this patch.  The reason we are using a fixed width is
that GTK+ only updates the column's width when the tree is initially
created.  You can see the effect of this if you pull up a list of
packages that aren't being modified, then change the state of one of
them.  The state change indicator is invisible, because the column is
only large enough to hold the first renderer -- you need to expand the
column manually to see the second renderer, except that you can't do
that because this patch *also* disables the ability to expand the status

  I understand and support what you're trying to do, but this way of
doing it makes things uniformly worse.


More information about the Aptitude-devel mailing list