[Aptitude-devel] aptitude-qt VCS usage and code review

[Daniel Burrows]

On Sat, Jul 10, 2010 at 06:37:16PM +0200, Piotr Galiszewski <piotr at galiszewski.pl> was heard to say:
> 2010/7/10 Daniel Burrows <dburrows at google.com>:
> >  On the other hand, the PkgIterator objects are very efficient, since
> > most of their method calls are inlinable.  In the past, I've just assumed
> > that it wouldn't be reasonable to turn every call on a package into a
> > virtual method, but I have no evidence that this is actually true and
> > that I'm not just prematurely optimizing.  Also, it's not 1998 any more,
> > and both compilers and hardware have advanced a bit since then.
> >
> >  Anyway, as long as you have the machinery set up for timing, I
> > thought it might be easy to get some numbers showing how costly
> > this would be in one particular instance.

  [snip]

> I have created ipackage interface and package class delivers from
> this. I have also change other required code. There were no visible
> difference from the above results. Accuracy of my measurement is not
> sufficient in this this case (but as I said I tested it on quite
> modern cpu)

  Interesting.  That suggests to me that it might be feasible to pursue
this at some point.  Not something to work on now, though.

  Daniel