[Aptitude-devel] Review: 001-build-skeleton

[Piotr Galiszewski]

2010/7/12 Daniel Burrows <dburrows at debian.org>:
> On Sun, Jul 11, 2010 at 02:27:59AM +0200, Piotr Galiszewski <piotr at galiszewski.pl> was heard to say:
>> 2010/7/10 Daniel Burrows <dburrows at debian.org>:
>> I am sorry about that. That was a problem with invalid settings of my
>> editor. Visually it looked correct on him. Both problems should be
>> fixed now
>
>  I noticed one more of these, in configure.ac:
>
> @@ -820,6 +885,7 @@ AC_CONFIG_FILES([
>         src/gtk/toplevel/Makefile
>        src/gtk/util/Makefile
>         src/gtk/view-impls/Makefile
> +  src/qt/Makefile
>        src/cmdline/Makefile
>         src/cmdline/mocks/Makefile
>        src/generic/Makefile
>
>  (the surrounding lines look ragged because some of them are tabbed
>   and some are spaced, but they line up when they're not in a diff)'
>

Fixed

>  I can't see anything else that really needs to be changed right now,
> so I guess it's almost ready to merge.
>

Thanks for the review :)

P.S.
I am working now (in separate branch) on new solution for package
class, which contains most fixes and suggestions from our recent
discussion. Before rebasing later patches I will push this for
discussion and review, and write an email with more informations about
later usage of this code. This time comments are in they place and
there is not bare pointers ;) I should finish this in an hour and
later come back to patch number 2 :)

P.S.2
During documenting my third branch I have discovered that this was not
good design in some places (as you said that this could happen ;) ). I
will fix this after finishing my current task


>  Daniel
>
-- 
Regards
Piotr Galiszewski