[Aptitude-devel] Experimental package and package_pool implementation
Piotr Galiszewski
piotr at galiszewski.pl
Mon Jul 12 23:04:40 UTC 2010
2010/7/13 Piotr Galiszewski <piotr at galiszewski.pl>:
> 2010/7/13 Daniel Burrows <dburrows at google.com>:
>> On Mon, Jul 12, 2010 at 2:03 PM, Piotr Galiszewski <piotr at galiszewski.pl> wrote:
[snip]
>
>> - Maybe inherit from boost::noncopyable to make it noncopyable?
>>
>> - I would drop the virtual destructor here and make it impossible to
>> subclass package (by hiding its constructor and using a static factory).
>> That allows you to avoid a virtual method table for each instance (not
>> a huge deal even if we create tens of thousands of them, but not bad
>> either)
>>
>
> probably it is not an option, because it won't work with QVariant type
>
>> - I really wish boost::flyweight didn't suck so we could make these strings
>> into flyweights easily.
>>
Never mind. QVariant uses boost::shared_ptr, so above sentence is not
true. The only question is about performance of conversion between
std::strings and QStrings
--
Regards
Piotr Galiszewski
More information about the Aptitude-devel
mailing list