[Aptitude-devel] Review: bf48d "Add tab classes and stubs of the program's tabs"

[Daniel Burrows]

  Ah, sorry, I noticed a few more things:

---- Cut here ----
-libqt_a_MOC =
+libqt_a_MOC = \
+   widgets/changes_preview_tab.moc \
+   widgets/package_info_tab.moc \
+   widgets/packages_tab.moc \
+   widgets/perform_changes_tab.moc \
+   widgets/resolver_tab.moc \
+   widgets/status_widget.moc \
+   widgets/tab.moc
 
 libqt_a_SOURCES= \
+   widgets/changes_preview_tab.cc \
+   widgets/changes_preview_tab.h \
+   widgets/package_info_tab.cc \
+   widgets/package_info_tab.h \
+   widgets/packages_tab.cc \
+   widgets/packages_tab.h \
+   widgets/perform_changes_tab.cc \
+   widgets/perform_changes_tab.h \
+   widgets/resolver_tab.cc \
+   widgets/resolver_tab.h \
+   widgets/status_widget.cc \
+   widgets/status_widget.h \
+   widgets/tab.cc \
+   widgets/tab.h \
    qt_main.cc \
    qt_main.h

  status_widget doesn't exist, so this doesn't compile.  Probably you
need to move that to the following patch.

  Other than that, this is OK.  It does break the pattern of using
hierarchical Makefiles, but hierarchical Makefiles tend to be
cumbersome and inefficient anyway.  Maybe this can be an experiment
in non-hierarchical Makefiles, with the idea of adopting them for the
larger project if they work out here.

---- Cut here ----

  Daniel